{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/comments/129073344","pull_request_review_id":51810309,"id":129073344,"diff_hunk":"@@ -36,6 +35,8 @@ const (\n \tmaxNumLabels    = 10\n \t// The largest number of timeseries we can write to per request.\n \tmaxTimeseriesPerRequest = 200\n+\tgcpCredentialsEnv       = \"GOOGLE_APPLICATION_CREDENTIALS\"","path":"metrics/sinks/gcm/gcm.go","position":null,"original_position":12,"commit_id":"11295b42c0c4bb282cd30b2de96b37f1ef58e422","original_commit_id":"06695f539d495c35b30fdc1a9a3cebc230836134","user":{"login":"georgebuckerfield","id":22893641,"avatar_url":"https://avatars2.githubusercontent.com/u/22893641?v=4","gravatar_id":"","url":"https://api.github.com/users/georgebuckerfield","html_url":"https://github.com/georgebuckerfield","followers_url":"https://api.github.com/users/georgebuckerfield/followers","following_url":"https://api.github.com/users/georgebuckerfield/following{/other_user}","gists_url":"https://api.github.com/users/georgebuckerfield/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebuckerfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebuckerfield/subscriptions","organizations_url":"https://api.github.com/users/georgebuckerfield/orgs","repos_url":"https://api.github.com/users/georgebuckerfield/repos","events_url":"https://api.github.com/users/georgebuckerfield/events{/privacy}","received_events_url":"https://api.github.com/users/georgebuckerfield/received_events","type":"User","site_admin":false},"body":"My bad, forgot to remove them.","created_at":"2017-07-24T15:43:19Z","updated_at":"2017-07-24T15:43:20Z","html_url":"https://github.com/kubernetes/heapster/pull/1657#discussion_r129073344","pull_request_url":"https://api.github.com/repos/kubernetes/heapster/pulls/1657","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/comments/129073344"},"html":{"href":"https://github.com/kubernetes/heapster/pull/1657#discussion_r129073344"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/1657"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/heapster/pulls/1657","id":121871533,"html_url":"https://github.com/kubernetes/heapster/pull/1657","diff_url":"https://github.com/kubernetes/heapster/pull/1657.diff","patch_url":"https://github.com/kubernetes/heapster/pull/1657.patch","issue_url":"https://api.github.com/repos/kubernetes/heapster/issues/1657","number":1657,"state":"open","locked":false,"title":"Authenticate with GCM without GCE metadata","user":{"login":"georgebuckerfield","id":22893641,"avatar_url":"https://avatars2.githubusercontent.com/u/22893641?v=4","gravatar_id":"","url":"https://api.github.com/users/georgebuckerfield","html_url":"https://github.com/georgebuckerfield","followers_url":"https://api.github.com/users/georgebuckerfield/followers","following_url":"https://api.github.com/users/georgebuckerfield/following{/other_user}","gists_url":"https://api.github.com/users/georgebuckerfield/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebuckerfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebuckerfield/subscriptions","organizations_url":"https://api.github.com/users/georgebuckerfield/orgs","repos_url":"https://api.github.com/users/georgebuckerfield/repos","events_url":"https://api.github.com/users/georgebuckerfield/events{/privacy}","received_events_url":"https://api.github.com/users/georgebuckerfield/received_events","type":"User","site_admin":false},"body":"This adds functionality to authenticate against GCM without requiring the GCE metadata service. It instead uses the`GOOGLE_APPLICATION_CREDENTIALS` environment variable to lookup a credentials file downloaded from GCP. If this variable is not set, the process falls back to using the GCE metadata. \r\n\r\nThis change allows users running clusters in AWS/on-prem to store heapster metrics in GCM/Stackdriver.","created_at":"2017-05-22T21:42:31Z","updated_at":"2017-07-24T15:43:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"770635a7fadf5f66ae63ccae9883408a7a5dbc1f","assignee":{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars1.githubusercontent.com/u/1756505?v=4","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},"assignees":[{"login":"crassirostris","id":1756505,"avatar_url":"https://avatars1.githubusercontent.com/u/1756505?v=4","gravatar_id":"","url":"https://api.github.com/users/crassirostris","html_url":"https://github.com/crassirostris","followers_url":"https://api.github.com/users/crassirostris/followers","following_url":"https://api.github.com/users/crassirostris/following{/other_user}","gists_url":"https://api.github.com/users/crassirostris/gists{/gist_id}","starred_url":"https://api.github.com/users/crassirostris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crassirostris/subscriptions","organizations_url":"https://api.github.com/users/crassirostris/orgs","repos_url":"https://api.github.com/users/crassirostris/repos","events_url":"https://api.github.com/users/crassirostris/events{/privacy}","received_events_url":"https://api.github.com/users/crassirostris/received_events","type":"User","site_admin":false},{"login":"piosz","id":10819974,"avatar_url":"https://avatars0.githubusercontent.com/u/10819974?v=4","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/heapster/pulls/1657/commits","review_comments_url":"https://api.github.com/repos/kubernetes/heapster/pulls/1657/comments","review_comment_url":"https://api.github.com/repos/kubernetes/heapster/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/heapster/issues/1657/comments","statuses_url":"https://api.github.com/repos/kubernetes/heapster/statuses/11295b42c0c4bb282cd30b2de96b37f1ef58e422","head":{"label":"georgebuckerfield:gcm-sink-outside-gce","ref":"gcm-sink-outside-gce","sha":"11295b42c0c4bb282cd30b2de96b37f1ef58e422","user":{"login":"georgebuckerfield","id":22893641,"avatar_url":"https://avatars2.githubusercontent.com/u/22893641?v=4","gravatar_id":"","url":"https://api.github.com/users/georgebuckerfield","html_url":"https://github.com/georgebuckerfield","followers_url":"https://api.github.com/users/georgebuckerfield/followers","following_url":"https://api.github.com/users/georgebuckerfield/following{/other_user}","gists_url":"https://api.github.com/users/georgebuckerfield/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebuckerfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebuckerfield/subscriptions","organizations_url":"https://api.github.com/users/georgebuckerfield/orgs","repos_url":"https://api.github.com/users/georgebuckerfield/repos","events_url":"https://api.github.com/users/georgebuckerfield/events{/privacy}","received_events_url":"https://api.github.com/users/georgebuckerfield/received_events","type":"User","site_admin":false},"repo":{"id":91697800,"name":"heapster","full_name":"georgebuckerfield/heapster","owner":{"login":"georgebuckerfield","id":22893641,"avatar_url":"https://avatars2.githubusercontent.com/u/22893641?v=4","gravatar_id":"","url":"https://api.github.com/users/georgebuckerfield","html_url":"https://github.com/georgebuckerfield","followers_url":"https://api.github.com/users/georgebuckerfield/followers","following_url":"https://api.github.com/users/georgebuckerfield/following{/other_user}","gists_url":"https://api.github.com/users/georgebuckerfield/gists{/gist_id}","starred_url":"https://api.github.com/users/georgebuckerfield/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgebuckerfield/subscriptions","organizations_url":"https://api.github.com/users/georgebuckerfield/orgs","repos_url":"https://api.github.com/users/georgebuckerfield/repos","events_url":"https://api.github.com/users/georgebuckerfield/events{/privacy}","received_events_url":"https://api.github.com/users/georgebuckerfield/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/georgebuckerfield/heapster","description":"Compute Resource Usage Analysis and Monitoring of Container Clusters","fork":true,"url":"https://api.github.com/repos/georgebuckerfield/heapster","forks_url":"https://api.github.com/repos/georgebuckerfield/heapster/forks","keys_url":"https://api.github.com/repos/georgebuckerfield/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/georgebuckerfield/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/georgebuckerfield/heapster/teams","hooks_url":"https://api.github.com/repos/georgebuckerfield/heapster/hooks","issue_events_url":"https://api.github.com/repos/georgebuckerfield/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/georgebuckerfield/heapster/events","assignees_url":"https://api.github.com/repos/georgebuckerfield/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/georgebuckerfield/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/georgebuckerfield/heapster/tags","blobs_url":"https://api.github.com/repos/georgebuckerfield/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/georgebuckerfield/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/georgebuckerfield/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/georgebuckerfield/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/georgebuckerfield/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/georgebuckerfield/heapster/languages","stargazers_url":"https://api.github.com/repos/georgebuckerfield/heapster/stargazers","contributors_url":"https://api.github.com/repos/georgebuckerfield/heapster/contributors","subscribers_url":"https://api.github.com/repos/georgebuckerfield/heapster/subscribers","subscription_url":"https://api.github.com/repos/georgebuckerfield/heapster/subscription","commits_url":"https://api.github.com/repos/georgebuckerfield/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/georgebuckerfield/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/georgebuckerfield/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/georgebuckerfield/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/georgebuckerfield/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/georgebuckerfield/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/georgebuckerfield/heapster/merges","archive_url":"https://api.github.com/repos/georgebuckerfield/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/georgebuckerfield/heapster/downloads","issues_url":"https://api.github.com/repos/georgebuckerfield/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/georgebuckerfield/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/georgebuckerfield/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/georgebuckerfield/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/georgebuckerfield/heapster/labels{/name}","releases_url":"https://api.github.com/repos/georgebuckerfield/heapster/releases{/id}","deployments_url":"https://api.github.com/repos/georgebuckerfield/heapster/deployments","created_at":"2017-05-18T13:40:30Z","updated_at":"2017-05-18T13:40:33Z","pushed_at":"2017-07-24T15:31:43Z","git_url":"git://github.com/georgebuckerfield/heapster.git","ssh_url":"git@github.com:georgebuckerfield/heapster.git","clone_url":"https://github.com/georgebuckerfield/heapster.git","svn_url":"https://github.com/georgebuckerfield/heapster","homepage":"","size":37052,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"2ca8178ad9ddbe0f2c7ed6e9878260c1280903cf","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":23272510,"name":"heapster","full_name":"kubernetes/heapster","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/heapster","description":"Compute Resource Usage Analysis and Monitoring of Container Clusters","fork":false,"url":"https://api.github.com/repos/kubernetes/heapster","forks_url":"https://api.github.com/repos/kubernetes/heapster/forks","keys_url":"https://api.github.com/repos/kubernetes/heapster/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/heapster/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/heapster/teams","hooks_url":"https://api.github.com/repos/kubernetes/heapster/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/heapster/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/heapster/events","assignees_url":"https://api.github.com/repos/kubernetes/heapster/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/heapster/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/heapster/tags","blobs_url":"https://api.github.com/repos/kubernetes/heapster/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/heapster/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/heapster/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/heapster/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/heapster/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/heapster/languages","stargazers_url":"https://api.github.com/repos/kubernetes/heapster/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/heapster/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/heapster/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/heapster/subscription","commits_url":"https://api.github.com/repos/kubernetes/heapster/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/heapster/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/heapster/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/heapster/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/heapster/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/heapster/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/heapster/merges","archive_url":"https://api.github.com/repos/kubernetes/heapster/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/heapster/downloads","issues_url":"https://api.github.com/repos/kubernetes/heapster/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/heapster/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/heapster/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/heapster/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/heapster/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/heapster/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/heapster/deployments","created_at":"2014-08-24T03:50:18Z","updated_at":"2017-07-24T14:57:57Z","pushed_at":"2017-07-24T15:31:50Z","git_url":"git://github.com/kubernetes/heapster.git","ssh_url":"git@github.com:kubernetes/heapster.git","clone_url":"https://github.com/kubernetes/heapster.git","svn_url":"https://github.com/kubernetes/heapster","homepage":"","size":38483,"stargazers_count":1327,"watchers_count":1327,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":654,"mirror_url":null,"open_issues_count":179,"forks":654,"open_issues":179,"watchers":1327,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/1657"},"html":{"href":"https://github.com/kubernetes/heapster/pull/1657"},"issue":{"href":"https://api.github.com/repos/kubernetes/heapster/issues/1657"},"comments":{"href":"https://api.github.com/repos/kubernetes/heapster/issues/1657/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/1657/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/heapster/pulls/1657/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/heapster/statuses/11295b42c0c4bb282cd30b2de96b37f1ef58e422"}}}}
{"actor":{"display_login":"georgebuckerfield"}}