{"action":"closed","number":20512,"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/20512","id":123338011,"html_url":"https://github.com/dotnet/corefx/pull/20512","diff_url":"https://github.com/dotnet/corefx/pull/20512.diff","patch_url":"https://github.com/dotnet/corefx/pull/20512.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/20512","number":20512,"state":"closed","locked":false,"title":"Update Tests for Exception Serialization.","user":{"login":"shmao","id":12262109,"avatar_url":"https://avatars2.githubusercontent.com/u/12262109?v=3","gravatar_id":"","url":"https://api.github.com/users/shmao","html_url":"https://github.com/shmao","followers_url":"https://api.github.com/users/shmao/followers","following_url":"https://api.github.com/users/shmao/following{/other_user}","gists_url":"https://api.github.com/users/shmao/gists{/gist_id}","starred_url":"https://api.github.com/users/shmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmao/subscriptions","organizations_url":"https://api.github.com/users/shmao/orgs","repos_url":"https://api.github.com/users/shmao/repos","events_url":"https://api.github.com/users/shmao/events{/privacy}","received_events_url":"https://api.github.com/users/shmao/received_events","type":"User","site_admin":false},"body":"#19119 removed [Serializable] from most Exceptions except Exception and AggregateException and made those exceptions' GetObjectData() throw. We should update the tests for Exception serialization.\r\n\r\nFix #20361 ","created_at":"2017-05-31T18:28:06Z","updated_at":"2017-06-01T00:48:45Z","closed_at":"2017-06-01T00:48:45Z","merged_at":"2017-06-01T00:48:44Z","merge_commit_sha":"4ea87afadfee7a7ae083773a7d0f7d1622528424","assignee":null,"assignees":[],"requested_reviewers":[{"login":"huanwu","id":1438378,"avatar_url":"https://avatars2.githubusercontent.com/u/1438378?v=3","gravatar_id":"","url":"https://api.github.com/users/huanwu","html_url":"https://github.com/huanwu","followers_url":"https://api.github.com/users/huanwu/followers","following_url":"https://api.github.com/users/huanwu/following{/other_user}","gists_url":"https://api.github.com/users/huanwu/gists{/gist_id}","starred_url":"https://api.github.com/users/huanwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/huanwu/subscriptions","organizations_url":"https://api.github.com/users/huanwu/orgs","repos_url":"https://api.github.com/users/huanwu/repos","events_url":"https://api.github.com/users/huanwu/events{/privacy}","received_events_url":"https://api.github.com/users/huanwu/received_events","type":"User","site_admin":false},{"login":"zhenlan","id":10566826,"avatar_url":"https://avatars1.githubusercontent.com/u/10566826?v=3","gravatar_id":"","url":"https://api.github.com/users/zhenlan","html_url":"https://github.com/zhenlan","followers_url":"https://api.github.com/users/zhenlan/followers","following_url":"https://api.github.com/users/zhenlan/following{/other_user}","gists_url":"https://api.github.com/users/zhenlan/gists{/gist_id}","starred_url":"https://api.github.com/users/zhenlan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhenlan/subscriptions","organizations_url":"https://api.github.com/users/zhenlan/orgs","repos_url":"https://api.github.com/users/zhenlan/repos","events_url":"https://api.github.com/users/zhenlan/events{/privacy}","received_events_url":"https://api.github.com/users/zhenlan/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/20512/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/20512/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/20512/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/82a719f503a18103d9f896336237989f8d630486","head":{"label":"shmao:20361-ExceptionTest","ref":"20361-ExceptionTest","sha":"82a719f503a18103d9f896336237989f8d630486","user":{"login":"shmao","id":12262109,"avatar_url":"https://avatars2.githubusercontent.com/u/12262109?v=3","gravatar_id":"","url":"https://api.github.com/users/shmao","html_url":"https://github.com/shmao","followers_url":"https://api.github.com/users/shmao/followers","following_url":"https://api.github.com/users/shmao/following{/other_user}","gists_url":"https://api.github.com/users/shmao/gists{/gist_id}","starred_url":"https://api.github.com/users/shmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmao/subscriptions","organizations_url":"https://api.github.com/users/shmao/orgs","repos_url":"https://api.github.com/users/shmao/repos","events_url":"https://api.github.com/users/shmao/events{/privacy}","received_events_url":"https://api.github.com/users/shmao/received_events","type":"User","site_admin":false},"repo":{"id":39537803,"name":"corefx","full_name":"shmao/corefx","owner":{"login":"shmao","id":12262109,"avatar_url":"https://avatars2.githubusercontent.com/u/12262109?v=3","gravatar_id":"","url":"https://api.github.com/users/shmao","html_url":"https://github.com/shmao","followers_url":"https://api.github.com/users/shmao/followers","following_url":"https://api.github.com/users/shmao/following{/other_user}","gists_url":"https://api.github.com/users/shmao/gists{/gist_id}","starred_url":"https://api.github.com/users/shmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shmao/subscriptions","organizations_url":"https://api.github.com/users/shmao/orgs","repos_url":"https://api.github.com/users/shmao/repos","events_url":"https://api.github.com/users/shmao/events{/privacy}","received_events_url":"https://api.github.com/users/shmao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shmao/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/shmao/corefx","forks_url":"https://api.github.com/repos/shmao/corefx/forks","keys_url":"https://api.github.com/repos/shmao/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shmao/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shmao/corefx/teams","hooks_url":"https://api.github.com/repos/shmao/corefx/hooks","issue_events_url":"https://api.github.com/repos/shmao/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/shmao/corefx/events","assignees_url":"https://api.github.com/repos/shmao/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/shmao/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/shmao/corefx/tags","blobs_url":"https://api.github.com/repos/shmao/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shmao/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shmao/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/shmao/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shmao/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/shmao/corefx/languages","stargazers_url":"https://api.github.com/repos/shmao/corefx/stargazers","contributors_url":"https://api.github.com/repos/shmao/corefx/contributors","subscribers_url":"https://api.github.com/repos/shmao/corefx/subscribers","subscription_url":"https://api.github.com/repos/shmao/corefx/subscription","commits_url":"https://api.github.com/repos/shmao/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/shmao/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/shmao/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/shmao/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/shmao/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/shmao/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shmao/corefx/merges","archive_url":"https://api.github.com/repos/shmao/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shmao/corefx/downloads","issues_url":"https://api.github.com/repos/shmao/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/shmao/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/shmao/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/shmao/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shmao/corefx/labels{/name}","releases_url":"https://api.github.com/repos/shmao/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/shmao/corefx/deployments","created_at":"2015-07-23T00:55:49Z","updated_at":"2016-08-08T17:11:12Z","pushed_at":"2017-05-31T21:19:21Z","git_url":"git://github.com/shmao/corefx.git","ssh_url":"git@github.com:shmao/corefx.git","clone_url":"https://github.com/shmao/corefx.git","svn_url":"https://github.com/shmao/corefx","homepage":"http://dotnet.github.io/core/","size":143636,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"dcacc2afb2b793fda4cd78e826aaa1dbaa62997d","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"name":"corefx","full_name":"dotnet/corefx","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars3.githubusercontent.com/u/9141961?v=3","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2017-05-31T23:46:17Z","pushed_at":"2017-06-01T00:48:44Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://github.com/dotnet/core","size":145850,"stargazers_count":11860,"watchers_count":11860,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3166,"mirror_url":null,"open_issues_count":1575,"forks":3166,"open_issues":1575,"watchers":11860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/20512"},"html":{"href":"https://github.com/dotnet/corefx/pull/20512"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/20512"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/20512/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/20512/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/20512/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/82a719f503a18103d9f896336237989f8d630486"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"danmosemsft","id":6385855,"avatar_url":"https://avatars0.githubusercontent.com/u/6385855?v=3","gravatar_id":"","url":"https://api.github.com/users/danmosemsft","html_url":"https://github.com/danmosemsft","followers_url":"https://api.github.com/users/danmosemsft/followers","following_url":"https://api.github.com/users/danmosemsft/following{/other_user}","gists_url":"https://api.github.com/users/danmosemsft/gists{/gist_id}","starred_url":"https://api.github.com/users/danmosemsft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danmosemsft/subscriptions","organizations_url":"https://api.github.com/users/danmosemsft/orgs","repos_url":"https://api.github.com/users/danmosemsft/repos","events_url":"https://api.github.com/users/danmosemsft/events{/privacy}","received_events_url":"https://api.github.com/users/danmosemsft/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":55,"deletions":25,"changed_files":4}}
{"actor":{"display_login":"danmosemsft"}}