{"action":"created","issue":{"url":"https://api.github.com/repos/shakacode/webpacker_lite/issues/20","repository_url":"https://api.github.com/repos/shakacode/webpacker_lite","labels_url":"https://api.github.com/repos/shakacode/webpacker_lite/issues/20/labels{/name}","comments_url":"https://api.github.com/repos/shakacode/webpacker_lite/issues/20/comments","events_url":"https://api.github.com/repos/shakacode/webpacker_lite/issues/20/events","html_url":"https://github.com/shakacode/webpacker_lite/issues/20","id":237585774,"number":20,"title":"manifest.json in Hot Reload mode. Is it really required?","user":{"login":"iJackUA","id":568566,"avatar_url":"https://avatars1.githubusercontent.com/u/568566?v=3","gravatar_id":"","url":"https://api.github.com/users/iJackUA","html_url":"https://github.com/iJackUA","followers_url":"https://api.github.com/users/iJackUA/followers","following_url":"https://api.github.com/users/iJackUA/following{/other_user}","gists_url":"https://api.github.com/users/iJackUA/gists{/gist_id}","starred_url":"https://api.github.com/users/iJackUA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iJackUA/subscriptions","organizations_url":"https://api.github.com/users/iJackUA/orgs","repos_url":"https://api.github.com/users/iJackUA/repos","events_url":"https://api.github.com/users/iJackUA/events{/privacy}","received_events_url":"https://api.github.com/users/iJackUA/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2017-06-21T16:01:14Z","updated_at":"2017-06-29T08:18:11Z","closed_at":null,"body":"As I understand, hash from mafiest is not used in Hot reload mode.\r\nAnd I can omit including manifest loader in WebPack config for Dev env.\r\nMaybe it is worth to check hot reloading mode in javascript_pack_tag here https://github.com/shakacode/webpacker_lite/blob/master/lib/webpacker_lite/helper.rb#L63 similar to the way CSS is handled https://github.com/shakacode/webpacker_lite/blob/master/lib/webpacker_lite/helper.rb#L57 \r\nand omit Manifest.lookup ?"},"comment":{"url":"https://api.github.com/repos/shakacode/webpacker_lite/issues/comments/311896188","html_url":"https://github.com/shakacode/webpacker_lite/issues/20#issuecomment-311896188","issue_url":"https://api.github.com/repos/shakacode/webpacker_lite/issues/20","id":311896188,"user":{"login":"gauravtiwari","id":771039,"avatar_url":"https://avatars1.githubusercontent.com/u/771039?v=3","gravatar_id":"","url":"https://api.github.com/users/gauravtiwari","html_url":"https://github.com/gauravtiwari","followers_url":"https://api.github.com/users/gauravtiwari/followers","following_url":"https://api.github.com/users/gauravtiwari/following{/other_user}","gists_url":"https://api.github.com/users/gauravtiwari/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravtiwari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravtiwari/subscriptions","organizations_url":"https://api.github.com/users/gauravtiwari/orgs","repos_url":"https://api.github.com/users/gauravtiwari/repos","events_url":"https://api.github.com/users/gauravtiwari/events{/privacy}","received_events_url":"https://api.github.com/users/gauravtiwari/received_events","type":"User","site_admin":false},"created_at":"2017-06-29T08:18:11Z","updated_at":"2017-06-29T08:18:11Z","body":"Well, it was just an idea but the addition is pretty confusing (and name too). I understand that this might make sense for your particular use case but probably not for other people who are either just getting started or have small to medium projects to work with. Sure, because you know it 😄  \r\n\r\nPerhaps, this may be simpler: \r\n\r\n```erb\r\njavascript_pack_tag(\"vendor\", manifest: false)\r\n```"}}
{"actor":{"display_login":"gauravtiwari"}}