{"action":"created","issue":{"url":"https://api.github.com/repos/randombit/botan/issues/862","repository_url":"https://api.github.com/repos/randombit/botan","labels_url":"https://api.github.com/repos/randombit/botan/issues/862/labels{/name}","comments_url":"https://api.github.com/repos/randombit/botan/issues/862/comments","events_url":"https://api.github.com/repos/randombit/botan/issues/862/events","html_url":"https://github.com/randombit/botan/issues/862","id":204546645,"number":862,"title":"Amalgamation build for C89 interface","user":{"login":"reitzig","id":4246780,"avatar_url":"https://avatars.githubusercontent.com/u/4246780?v=3","gravatar_id":"","url":"https://api.github.com/users/reitzig","html_url":"https://github.com/reitzig","followers_url":"https://api.github.com/users/reitzig/followers","following_url":"https://api.github.com/users/reitzig/following{/other_user}","gists_url":"https://api.github.com/users/reitzig/gists{/gist_id}","starred_url":"https://api.github.com/users/reitzig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reitzig/subscriptions","organizations_url":"https://api.github.com/users/reitzig/orgs","repos_url":"https://api.github.com/users/reitzig/repos","events_url":"https://api.github.com/users/reitzig/events{/privacy}","received_events_url":"https://api.github.com/users/reitzig/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-02-01T10:29:21Z","updated_at":"2017-02-02T03:45:41Z","closed_at":null,"body":"For using (a custom, small build of) Botan in a Swift package, I want to use the C interface mentioned in the documentation. I have several questions.\r\n\r\n 1. Is there any documentation of the C interface?\r\n 2. Where does `make` create the C headers, in particular with `--amalgamation`?\r\n 3. Do we get C source files or only C headers against the compilate?"},"comment":{"url":"https://api.github.com/repos/randombit/botan/issues/comments/276860619","html_url":"https://github.com/randombit/botan/issues/862#issuecomment-276860619","issue_url":"https://api.github.com/repos/randombit/botan/issues/862","id":276860619,"user":{"login":"randombit","id":469092,"avatar_url":"https://avatars.githubusercontent.com/u/469092?v=3","gravatar_id":"","url":"https://api.github.com/users/randombit","html_url":"https://github.com/randombit","followers_url":"https://api.github.com/users/randombit/followers","following_url":"https://api.github.com/users/randombit/following{/other_user}","gists_url":"https://api.github.com/users/randombit/gists{/gist_id}","starred_url":"https://api.github.com/users/randombit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/randombit/subscriptions","organizations_url":"https://api.github.com/users/randombit/orgs","repos_url":"https://api.github.com/users/randombit/repos","events_url":"https://api.github.com/users/randombit/events{/privacy}","received_events_url":"https://api.github.com/users/randombit/received_events","type":"User","site_admin":false},"created_at":"2017-02-02T03:45:41Z","updated_at":"2017-02-02T03:45:41Z","body":"Fixing FFI turns out to be a bit more complicated than I thought, because initializing a public key operation in Botan requires an RNG reference, but this change to Botan's API came after the FFI API was created, so no RNG is passed by the callers. The FFI code just always uses the system RNG when creating the object.\r\n\r\nTo fix this seems to require adding new versions of  all `botan_pk_op_*_create` functions (`_create2`) taking also a RNG reference. Then the `_create` calls (without an RNG arg) would fail at runtime on systems without a RNG, and `_create2` could be used on systems with or without a system RNG."}}
{"actor":{"display_login":"randombit"}}