{"action":"created","comment":{"url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/comments/150230430","pull_request_review_id":75751243,"id":150230430,"diff_hunk":"@@ -0,0 +1,86 @@\n+# Revision static assets\n+\n+## Functionality\n+\n+Give files a unique filename based on their contents and update references to them. A hash is generated based on a file's contents and added to its filename. This ensures a filename only changes when a file's contents change.\n+Revisioning allows browsers to aggresively cache these assets by *setting their cache headers to never expire*. \n+\n+\n+## Usage\n+\n+### Install dependencies\n+\n+All dependencies needed to run this recipe are pre-configured in [`package.json`](package.json). You just need to install these:\n+\n+```bash\n+npm install\n+```\n+\n+Note: it's smart to update to the latest versions of these dependencies.\n+\n+\n+### Configure working directory and file patterns","path":"revision-static-assets/README.md","position":22,"original_position":22,"commit_id":"222d2cb042975c869ed29b8e5b65e30070937e6d","original_commit_id":"222d2cb042975c869ed29b8e5b65e30070937e6d","user":{"login":"decrek","id":2034675,"avatar_url":"https://avatars3.githubusercontent.com/u/2034675?v=4","gravatar_id":"","url":"https://api.github.com/users/decrek","html_url":"https://github.com/decrek","followers_url":"https://api.github.com/users/decrek/followers","following_url":"https://api.github.com/users/decrek/following{/other_user}","gists_url":"https://api.github.com/users/decrek/gists{/gist_id}","starred_url":"https://api.github.com/users/decrek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/decrek/subscriptions","organizations_url":"https://api.github.com/users/decrek/orgs","repos_url":"https://api.github.com/users/decrek/repos","events_url":"https://api.github.com/users/decrek/events{/privacy}","received_events_url":"https://api.github.com/users/decrek/received_events","type":"User","site_admin":false},"body":"Im missing the file pattern part here, while it is in the title. What are static assets? Now its done base on the working dir and some patterns. Maybe do it just on the directory, copy all static assets to a static dir and revhash everything in that directory regardless of filetype? Or put the patterns in a variable and describe in the readme how to adjust file patterns?","created_at":"2017-11-10T13:09:17Z","updated_at":"2017-11-10T13:20:48Z","html_url":"https://github.com/voorhoede/front-end-tooling-recipes/pull/20#discussion_r150230430","pull_request_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/20","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/comments/150230430"},"html":{"href":"https://github.com/voorhoede/front-end-tooling-recipes/pull/20#discussion_r150230430"},"pull_request":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/20","id":149405555,"html_url":"https://github.com/voorhoede/front-end-tooling-recipes/pull/20","diff_url":"https://github.com/voorhoede/front-end-tooling-recipes/pull/20.diff","patch_url":"https://github.com/voorhoede/front-end-tooling-recipes/pull/20.patch","issue_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues/20","number":20,"state":"open","locked":false,"title":"feat(revision): change filenames & update references","user":{"login":"jbmoelker","id":1516059,"avatar_url":"https://avatars1.githubusercontent.com/u/1516059?v=4","gravatar_id":"","url":"https://api.github.com/users/jbmoelker","html_url":"https://github.com/jbmoelker","followers_url":"https://api.github.com/users/jbmoelker/followers","following_url":"https://api.github.com/users/jbmoelker/following{/other_user}","gists_url":"https://api.github.com/users/jbmoelker/gists{/gist_id}","starred_url":"https://api.github.com/users/jbmoelker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbmoelker/subscriptions","organizations_url":"https://api.github.com/users/jbmoelker/orgs","repos_url":"https://api.github.com/users/jbmoelker/repos","events_url":"https://api.github.com/users/jbmoelker/events{/privacy}","received_events_url":"https://api.github.com/users/jbmoelker/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nProposed changes:\r\n\r\n* Recipe to revision static assets.\r\n* Comes with example project (in `src/`) and demo server.\r\n* Configuration for Express, Apache and Nginx are part of readme.\r\n\r\n## Checklist\r\n\r\n* [X] The changes only affect or contain one recipe.\r\n* [X] The changes are according to [contribution guidelines](/CONTRIBUTING.md#guidelines).\r\n* [X] The new recipe has an entry in the [recipes index](/README.md#recipes) (only in case of new recipe).\r\n* [X] The changes can be merged into the target branch without conflicts. \r\n","created_at":"2017-10-29T20:37:25Z","updated_at":"2017-11-10T13:20:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da8a2184f14dd130121c8aff0302529580be57cd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"thadeetrompetter","id":5120227,"avatar_url":"https://avatars3.githubusercontent.com/u/5120227?v=4","gravatar_id":"","url":"https://api.github.com/users/thadeetrompetter","html_url":"https://github.com/thadeetrompetter","followers_url":"https://api.github.com/users/thadeetrompetter/followers","following_url":"https://api.github.com/users/thadeetrompetter/following{/other_user}","gists_url":"https://api.github.com/users/thadeetrompetter/gists{/gist_id}","starred_url":"https://api.github.com/users/thadeetrompetter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thadeetrompetter/subscriptions","organizations_url":"https://api.github.com/users/thadeetrompetter/orgs","repos_url":"https://api.github.com/users/thadeetrompetter/repos","events_url":"https://api.github.com/users/thadeetrompetter/events{/privacy}","received_events_url":"https://api.github.com/users/thadeetrompetter/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/20/commits","review_comments_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/20/comments","review_comment_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues/20/comments","statuses_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/statuses/222d2cb042975c869ed29b8e5b65e30070937e6d","head":{"label":"voorhoede:revision-static-assets","ref":"revision-static-assets","sha":"222d2cb042975c869ed29b8e5b65e30070937e6d","user":{"login":"voorhoede","id":2759382,"avatar_url":"https://avatars3.githubusercontent.com/u/2759382?v=4","gravatar_id":"","url":"https://api.github.com/users/voorhoede","html_url":"https://github.com/voorhoede","followers_url":"https://api.github.com/users/voorhoede/followers","following_url":"https://api.github.com/users/voorhoede/following{/other_user}","gists_url":"https://api.github.com/users/voorhoede/gists{/gist_id}","starred_url":"https://api.github.com/users/voorhoede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voorhoede/subscriptions","organizations_url":"https://api.github.com/users/voorhoede/orgs","repos_url":"https://api.github.com/users/voorhoede/repos","events_url":"https://api.github.com/users/voorhoede/events{/privacy}","received_events_url":"https://api.github.com/users/voorhoede/received_events","type":"Organization","site_admin":false},"repo":{"id":59119517,"name":"front-end-tooling-recipes","full_name":"voorhoede/front-end-tooling-recipes","owner":{"login":"voorhoede","id":2759382,"avatar_url":"https://avatars3.githubusercontent.com/u/2759382?v=4","gravatar_id":"","url":"https://api.github.com/users/voorhoede","html_url":"https://github.com/voorhoede","followers_url":"https://api.github.com/users/voorhoede/followers","following_url":"https://api.github.com/users/voorhoede/following{/other_user}","gists_url":"https://api.github.com/users/voorhoede/gists{/gist_id}","starred_url":"https://api.github.com/users/voorhoede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voorhoede/subscriptions","organizations_url":"https://api.github.com/users/voorhoede/orgs","repos_url":"https://api.github.com/users/voorhoede/repos","events_url":"https://api.github.com/users/voorhoede/events{/privacy}","received_events_url":"https://api.github.com/users/voorhoede/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voorhoede/front-end-tooling-recipes","description":"Collection of pre-configured front-end tooling setups for common uses.","fork":false,"url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes","forks_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/forks","keys_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/teams","hooks_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/hooks","issue_events_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/events","assignees_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/tags","blobs_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/languages","stargazers_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/stargazers","contributors_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/contributors","subscribers_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/subscribers","subscription_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/subscription","commits_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/merges","archive_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/downloads","issues_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/labels{/name}","releases_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/deployments","created_at":"2016-05-18T13:46:25Z","updated_at":"2017-11-09T10:41:20Z","pushed_at":"2017-10-29T20:37:25Z","git_url":"git://github.com/voorhoede/front-end-tooling-recipes.git","ssh_url":"git@github.com:voorhoede/front-end-tooling-recipes.git","clone_url":"https://github.com/voorhoede/front-end-tooling-recipes.git","svn_url":"https://github.com/voorhoede/front-end-tooling-recipes","homepage":"https://voorhoede.github.io/front-end-tooling-recipes/","size":211,"stargazers_count":106,"watchers_count":106,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":106,"default_branch":"master"}},"base":{"label":"voorhoede:master","ref":"master","sha":"b02bab67c664d0acc6a1894c2122f9150b0d79ba","user":{"login":"voorhoede","id":2759382,"avatar_url":"https://avatars3.githubusercontent.com/u/2759382?v=4","gravatar_id":"","url":"https://api.github.com/users/voorhoede","html_url":"https://github.com/voorhoede","followers_url":"https://api.github.com/users/voorhoede/followers","following_url":"https://api.github.com/users/voorhoede/following{/other_user}","gists_url":"https://api.github.com/users/voorhoede/gists{/gist_id}","starred_url":"https://api.github.com/users/voorhoede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voorhoede/subscriptions","organizations_url":"https://api.github.com/users/voorhoede/orgs","repos_url":"https://api.github.com/users/voorhoede/repos","events_url":"https://api.github.com/users/voorhoede/events{/privacy}","received_events_url":"https://api.github.com/users/voorhoede/received_events","type":"Organization","site_admin":false},"repo":{"id":59119517,"name":"front-end-tooling-recipes","full_name":"voorhoede/front-end-tooling-recipes","owner":{"login":"voorhoede","id":2759382,"avatar_url":"https://avatars3.githubusercontent.com/u/2759382?v=4","gravatar_id":"","url":"https://api.github.com/users/voorhoede","html_url":"https://github.com/voorhoede","followers_url":"https://api.github.com/users/voorhoede/followers","following_url":"https://api.github.com/users/voorhoede/following{/other_user}","gists_url":"https://api.github.com/users/voorhoede/gists{/gist_id}","starred_url":"https://api.github.com/users/voorhoede/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voorhoede/subscriptions","organizations_url":"https://api.github.com/users/voorhoede/orgs","repos_url":"https://api.github.com/users/voorhoede/repos","events_url":"https://api.github.com/users/voorhoede/events{/privacy}","received_events_url":"https://api.github.com/users/voorhoede/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voorhoede/front-end-tooling-recipes","description":"Collection of pre-configured front-end tooling setups for common uses.","fork":false,"url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes","forks_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/forks","keys_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/teams","hooks_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/hooks","issue_events_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues/events{/number}","events_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/events","assignees_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/assignees{/user}","branches_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/branches{/branch}","tags_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/tags","blobs_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/refs{/sha}","trees_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/statuses/{sha}","languages_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/languages","stargazers_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/stargazers","contributors_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/contributors","subscribers_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/subscribers","subscription_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/subscription","commits_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/commits{/sha}","git_commits_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/git/commits{/sha}","comments_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/comments{/number}","issue_comment_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues/comments{/number}","contents_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/contents/{+path}","compare_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/merges","archive_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/downloads","issues_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues{/number}","pulls_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls{/number}","milestones_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/milestones{/number}","notifications_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/labels{/name}","releases_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/releases{/id}","deployments_url":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/deployments","created_at":"2016-05-18T13:46:25Z","updated_at":"2017-11-09T10:41:20Z","pushed_at":"2017-10-29T20:37:25Z","git_url":"git://github.com/voorhoede/front-end-tooling-recipes.git","ssh_url":"git@github.com:voorhoede/front-end-tooling-recipes.git","clone_url":"https://github.com/voorhoede/front-end-tooling-recipes.git","svn_url":"https://github.com/voorhoede/front-end-tooling-recipes","homepage":"https://voorhoede.github.io/front-end-tooling-recipes/","size":211,"stargazers_count":106,"watchers_count":106,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":3,"open_issues":3,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/20"},"html":{"href":"https://github.com/voorhoede/front-end-tooling-recipes/pull/20"},"issue":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues/20"},"comments":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/voorhoede/front-end-tooling-recipes/statuses/222d2cb042975c869ed29b8e5b65e30070937e6d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"decrek"}}