{"action":"created","comment":{"url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/comments/139370490","pull_request_review_id":63291584,"id":139370490,"diff_hunk":"@@ -1,137 +0,0 @@\n-/*******************************************************************************\n-\n-    Links the elements into the list, making a queue. To be used with\n-    AioScheduler. `Queue.Element` should be inherited from the actual classes\n-    that will be queued by thread workers, and processed by the main thread.\n-    The reason for linking all these objects together and forming a queue in","path":"src/dlsnode/util/aio/internal/Queue.d","position":6,"original_position":6,"commit_id":"6485f515e5844b33cbd08cf527e95a212e8ab129","original_commit_id":"3a2d07d157e67830f4d9968fcc88d6c6710149ca","user":{"login":"gavin-norman-sociomantic","id":2863963,"avatar_url":"https://avatars1.githubusercontent.com/u/2863963?v=4","gravatar_id":"","url":"https://api.github.com/users/gavin-norman-sociomantic","html_url":"https://github.com/gavin-norman-sociomantic","followers_url":"https://api.github.com/users/gavin-norman-sociomantic/followers","following_url":"https://api.github.com/users/gavin-norman-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/gavin-norman-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/gavin-norman-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavin-norman-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/gavin-norman-sociomantic/orgs","repos_url":"https://api.github.com/users/gavin-norman-sociomantic/repos","events_url":"https://api.github.com/users/gavin-norman-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/gavin-norman-sociomantic/received_events","type":"User","site_admin":false},"body":"Does this reasoning still apply and is it worth mentioning this somewhere else?","created_at":"2017-09-18T09:11:16Z","updated_at":"2017-09-18T09:51:05Z","html_url":"https://github.com/sociomantic-tsunami/dlsnode/pull/4#discussion_r139370490","pull_request_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/comments/139370490"},"html":{"href":"https://github.com/sociomantic-tsunami/dlsnode/pull/4#discussion_r139370490"},"pull_request":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/4","id":134464798,"html_url":"https://github.com/sociomantic-tsunami/dlsnode/pull/4","diff_url":"https://github.com/sociomantic-tsunami/dlsnode/pull/4.diff","patch_url":"https://github.com/sociomantic-tsunami/dlsnode/pull/4.patch","issue_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/issues/4","number":4,"state":"open","locked":false,"title":"Cancelable and nonblocking async io calls","user":{"login":"nemanja-boric-sociomantic","id":7437552,"avatar_url":"https://avatars2.githubusercontent.com/u/7437552?v=4","gravatar_id":"","url":"https://api.github.com/users/nemanja-boric-sociomantic","html_url":"https://github.com/nemanja-boric-sociomantic","followers_url":"https://api.github.com/users/nemanja-boric-sociomantic/followers","following_url":"https://api.github.com/users/nemanja-boric-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/nemanja-boric-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/nemanja-boric-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemanja-boric-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/nemanja-boric-sociomantic/orgs","repos_url":"https://api.github.com/users/nemanja-boric-sociomantic/repos","events_url":"https://api.github.com/users/nemanja-boric-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/nemanja-boric-sociomantic/received_events","type":"User","site_admin":false},"body":"This adds support for cancelling pending async IO jobs. In case user decides it no longer needs the results, it can cancel the job and the results will be discarded (if any). This also implies that the caller's suspending should be delegated to the caller, as it may want to support multiple resuming sources (for example, if it's waken up from the client, asking for the request to stop, we don't want to read anything else, so we need to cancel it).","created_at":"2017-08-07T15:27:26Z","updated_at":"2017-09-18T09:51:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7deb83d3ed78910a5687e3b947ea468ee8cf4794","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/milestones/1","html_url":"https://github.com/sociomantic-tsunami/dlsnode/milestone/1","labels_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/milestones/1/labels","id":2685853,"number":1,"title":"v1.10.0","description":"","creator":{"login":"nemanja-boric-sociomantic","id":7437552,"avatar_url":"https://avatars2.githubusercontent.com/u/7437552?v=4","gravatar_id":"","url":"https://api.github.com/users/nemanja-boric-sociomantic","html_url":"https://github.com/nemanja-boric-sociomantic","followers_url":"https://api.github.com/users/nemanja-boric-sociomantic/followers","following_url":"https://api.github.com/users/nemanja-boric-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/nemanja-boric-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/nemanja-boric-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemanja-boric-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/nemanja-boric-sociomantic/orgs","repos_url":"https://api.github.com/users/nemanja-boric-sociomantic/repos","events_url":"https://api.github.com/users/nemanja-boric-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/nemanja-boric-sociomantic/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2017-08-07T15:27:11Z","updated_at":"2017-09-15T15:04:15Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/4/commits","review_comments_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/4/comments","review_comment_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/issues/4/comments","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/statuses/6485f515e5844b33cbd08cf527e95a212e8ab129","head":{"label":"nemanja-boric-sociomantic:aio_enhancement","ref":"aio_enhancement","sha":"6485f515e5844b33cbd08cf527e95a212e8ab129","user":{"login":"nemanja-boric-sociomantic","id":7437552,"avatar_url":"https://avatars2.githubusercontent.com/u/7437552?v=4","gravatar_id":"","url":"https://api.github.com/users/nemanja-boric-sociomantic","html_url":"https://github.com/nemanja-boric-sociomantic","followers_url":"https://api.github.com/users/nemanja-boric-sociomantic/followers","following_url":"https://api.github.com/users/nemanja-boric-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/nemanja-boric-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/nemanja-boric-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemanja-boric-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/nemanja-boric-sociomantic/orgs","repos_url":"https://api.github.com/users/nemanja-boric-sociomantic/repos","events_url":"https://api.github.com/users/nemanja-boric-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/nemanja-boric-sociomantic/received_events","type":"User","site_admin":false},"repo":{"id":99341942,"name":"dlsnode-1","full_name":"nemanja-boric-sociomantic/dlsnode-1","owner":{"login":"nemanja-boric-sociomantic","id":7437552,"avatar_url":"https://avatars2.githubusercontent.com/u/7437552?v=4","gravatar_id":"","url":"https://api.github.com/users/nemanja-boric-sociomantic","html_url":"https://github.com/nemanja-boric-sociomantic","followers_url":"https://api.github.com/users/nemanja-boric-sociomantic/followers","following_url":"https://api.github.com/users/nemanja-boric-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/nemanja-boric-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/nemanja-boric-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemanja-boric-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/nemanja-boric-sociomantic/orgs","repos_url":"https://api.github.com/users/nemanja-boric-sociomantic/repos","events_url":"https://api.github.com/users/nemanja-boric-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/nemanja-boric-sociomantic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nemanja-boric-sociomantic/dlsnode-1","description":"Distributed log store node","fork":true,"url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1","forks_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/forks","keys_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/teams","hooks_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/hooks","issue_events_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/issues/events{/number}","events_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/events","assignees_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/assignees{/user}","branches_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/branches{/branch}","tags_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/tags","blobs_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/statuses/{sha}","languages_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/languages","stargazers_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/stargazers","contributors_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/contributors","subscribers_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/subscribers","subscription_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/subscription","commits_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/contents/{+path}","compare_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/merges","archive_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/downloads","issues_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/issues{/number}","pulls_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/pulls{/number}","milestones_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/milestones{/number}","notifications_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/labels{/name}","releases_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/releases{/id}","deployments_url":"https://api.github.com/repos/nemanja-boric-sociomantic/dlsnode-1/deployments","created_at":"2017-08-04T12:44:24Z","updated_at":"2017-08-04T14:23:56Z","pushed_at":"2017-09-15T15:03:47Z","git_url":"git://github.com/nemanja-boric-sociomantic/dlsnode-1.git","ssh_url":"git@github.com:nemanja-boric-sociomantic/dlsnode-1.git","clone_url":"https://github.com/nemanja-boric-sociomantic/dlsnode-1.git","svn_url":"https://github.com/nemanja-boric-sociomantic/dlsnode-1","homepage":null,"size":159,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sociomantic-tsunami:master","ref":"master","sha":"530fb7d6360574cda8b0c8551a0f71b068b89d14","user":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars0.githubusercontent.com/u/16766217?v=4","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"repo":{"id":99139871,"name":"dlsnode","full_name":"sociomantic-tsunami/dlsnode","owner":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars0.githubusercontent.com/u/16766217?v=4","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sociomantic-tsunami/dlsnode","description":"Distributed log store node","fork":false,"url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode","forks_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/forks","keys_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/teams","hooks_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/hooks","issue_events_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/issues/events{/number}","events_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/events","assignees_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/assignees{/user}","branches_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/branches{/branch}","tags_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/tags","blobs_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/git/refs{/sha}","trees_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/statuses/{sha}","languages_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/languages","stargazers_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/stargazers","contributors_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/contributors","subscribers_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/subscribers","subscription_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/subscription","commits_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/commits{/sha}","git_commits_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/git/commits{/sha}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/comments{/number}","issue_comment_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/issues/comments{/number}","contents_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/contents/{+path}","compare_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/merges","archive_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/downloads","issues_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/issues{/number}","pulls_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls{/number}","milestones_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/milestones{/number}","notifications_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/labels{/name}","releases_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/releases{/id}","deployments_url":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/deployments","created_at":"2017-08-02T16:42:38Z","updated_at":"2017-08-14T12:43:14Z","pushed_at":"2017-09-15T15:04:15Z","git_url":"git://github.com/sociomantic-tsunami/dlsnode.git","ssh_url":"git@github.com:sociomantic-tsunami/dlsnode.git","clone_url":"https://github.com/sociomantic-tsunami/dlsnode.git","svn_url":"https://github.com/sociomantic-tsunami/dlsnode","homepage":null,"size":113,"stargazers_count":4,"watchers_count":4,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":3,"forks":2,"open_issues":3,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/4"},"html":{"href":"https://github.com/sociomantic-tsunami/dlsnode/pull/4"},"issue":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/issues/4"},"comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/sociomantic-tsunami/dlsnode/statuses/6485f515e5844b33cbd08cf527e95a212e8ab129"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gavin-norman-sociomantic"}}