{"action":"created","issue":{"url":"https://api.github.com/repos/dhowe/AdNauseam/issues/1029","repository_url":"https://api.github.com/repos/dhowe/AdNauseam","labels_url":"https://api.github.com/repos/dhowe/AdNauseam/issues/1029/labels{/name}","comments_url":"https://api.github.com/repos/dhowe/AdNauseam/issues/1029/comments","events_url":"https://api.github.com/repos/dhowe/AdNauseam/issues/1029/events","html_url":"https://github.com/dhowe/AdNauseam/issues/1029","id":225563132,"number":1029,"title":"Test branch merged1.12.2","user":{"login":"cqx931","id":3056154,"avatar_url":"https://avatars2.githubusercontent.com/u/3056154?v=3","gravatar_id":"","url":"https://api.github.com/users/cqx931","html_url":"https://github.com/cqx931","followers_url":"https://api.github.com/users/cqx931/followers","following_url":"https://api.github.com/users/cqx931/following{/other_user}","gists_url":"https://api.github.com/users/cqx931/gists{/gist_id}","starred_url":"https://api.github.com/users/cqx931/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cqx931/subscriptions","organizations_url":"https://api.github.com/users/cqx931/orgs","repos_url":"https://api.github.com/users/cqx931/repos","events_url":"https://api.github.com/users/cqx931/events{/privacy}","received_events_url":"https://api.github.com/users/cqx931/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cqx931","id":3056154,"avatar_url":"https://avatars2.githubusercontent.com/u/3056154?v=3","gravatar_id":"","url":"https://api.github.com/users/cqx931","html_url":"https://github.com/cqx931","followers_url":"https://api.github.com/users/cqx931/followers","following_url":"https://api.github.com/users/cqx931/following{/other_user}","gists_url":"https://api.github.com/users/cqx931/gists{/gist_id}","starred_url":"https://api.github.com/users/cqx931/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cqx931/subscriptions","organizations_url":"https://api.github.com/users/cqx931/orgs","repos_url":"https://api.github.com/users/cqx931/repos","events_url":"https://api.github.com/users/cqx931/events{/privacy}","received_events_url":"https://api.github.com/users/cqx931/received_events","type":"User","site_admin":false},"assignees":[{"login":"cqx931","id":3056154,"avatar_url":"https://avatars2.githubusercontent.com/u/3056154?v=3","gravatar_id":"","url":"https://api.github.com/users/cqx931","html_url":"https://github.com/cqx931","followers_url":"https://api.github.com/users/cqx931/followers","following_url":"https://api.github.com/users/cqx931/following{/other_user}","gists_url":"https://api.github.com/users/cqx931/gists{/gist_id}","starred_url":"https://api.github.com/users/cqx931/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cqx931/subscriptions","organizations_url":"https://api.github.com/users/cqx931/orgs","repos_url":"https://api.github.com/users/cqx931/repos","events_url":"https://api.github.com/users/cqx931/events{/privacy}","received_events_url":"https://api.github.com/users/cqx931/received_events","type":"User","site_admin":false},{"login":"greysonevins","id":11656811,"avatar_url":"https://avatars1.githubusercontent.com/u/11656811?v=3","gravatar_id":"","url":"https://api.github.com/users/greysonevins","html_url":"https://github.com/greysonevins","followers_url":"https://api.github.com/users/greysonevins/followers","following_url":"https://api.github.com/users/greysonevins/following{/other_user}","gists_url":"https://api.github.com/users/greysonevins/gists{/gist_id}","starred_url":"https://api.github.com/users/greysonevins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greysonevins/subscriptions","organizations_url":"https://api.github.com/users/greysonevins/orgs","repos_url":"https://api.github.com/users/greysonevins/repos","events_url":"https://api.github.com/users/greysonevins/events{/privacy}","received_events_url":"https://api.github.com/users/greysonevins/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-05-02T00:43:37Z","updated_at":"2017-05-18T23:52:48Z","closed_at":null,"body":"All platforms\r\n\r\n- [x] https://github.com/dhowe/AdNauseam/issues/1034 Eff whitelist rules are not loaded\r\n\r\n- [ ] https://github.com/dhowe/AdNauseam/issues/1036 DNT header\r\n\r\n\r\n- [ ] Firefox \r\n\r\n- [ ] Web extension\r\nhttps://github.com/dhowe/AdNauseam/issues/1035 Ad Blocker Notification - on hold\r\nhttps://github.com/dhowe/AdNauseam/issues/1033 Ads export\r\nhttps://github.com/dhowe/AdNauseam/issues/1032 Firstrun page\r\nhttps://github.com/dhowe/AdNauseam/issues/627   Iframe\r\n- [x] Chrome\r\n\r\n- [ ] Opera @greysonevins "},"comment":{"url":"https://api.github.com/repos/dhowe/AdNauseam/issues/comments/302571974","html_url":"https://github.com/dhowe/AdNauseam/issues/1029#issuecomment-302571974","issue_url":"https://api.github.com/repos/dhowe/AdNauseam/issues/1029","id":302571974,"user":{"login":"greysonevins","id":11656811,"avatar_url":"https://avatars1.githubusercontent.com/u/11656811?v=3","gravatar_id":"","url":"https://api.github.com/users/greysonevins","html_url":"https://github.com/greysonevins","followers_url":"https://api.github.com/users/greysonevins/followers","following_url":"https://api.github.com/users/greysonevins/following{/other_user}","gists_url":"https://api.github.com/users/greysonevins/gists{/gist_id}","starred_url":"https://api.github.com/users/greysonevins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greysonevins/subscriptions","organizations_url":"https://api.github.com/users/greysonevins/orgs","repos_url":"https://api.github.com/users/greysonevins/repos","events_url":"https://api.github.com/users/greysonevins/events{/privacy}","received_events_url":"https://api.github.com/users/greysonevins/received_events","type":"User","site_admin":false},"created_at":"2017-05-18T23:52:48Z","updated_at":"2017-05-18T23:52:48Z","body":"**Opera Web extension**\r\n\r\n## Interface\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>First-Run</b>\r\nRemove and reinstall AdNauseam to trigger this page \r\n- [ ] Test selection of various options (click-ads, block-malware, hide-ads, DNT)\r\n- [ ] Verify that the DNT option is visible _only_ when clicking OR hiding is enabled\r\n- [ ] Test that toggling the DNT option changes _both_ DNT options in Settings\r\n- [ ] Check the links on first-run page\r\n- [ ] Check the version number at left-bottom corner\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>Menu</b>\r\n- [ ] Check all buttons and information (including number of Ads and $$ cost, hidden if no ads)\r\n- [ ] Hover over Ad images and check zooming\r\n- [ ] Check there is no text overlap in the menu for text ads\r\n- [ ] Check AdNauseam version number(in uBlock menu)\r\n- [ ] Menu shows \"AdNauseam is paused on current pages\" when AdNauseam is paused, and make sure that the layout is correct.\r\n- [ ] Check that the Adnauseam logo links to homepage\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>Vault</b>\r\n- [ ] Verify loading animation, and centering/scaling of Ads on load\r\n- [ ] Zoom in/out using mouse wheel and buttons in top-left corner \r\n- [ ] Check function/layout of Inspector (for both image and text ads)\r\n- [ ] Check correct function of date-filter slider at bottom\r\n- [ ] Check that AdNauseam logo in the bottom-right corner links correctly to homepage  \r\n- [ ] Check correct calculation of ad cost\r\n- [ ] Test import/export/clear functions\r\n- [ ] Right click on an ad and delete it. Refresh the page and check that it is successfully deleted\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>Dashboard</b>\r\n- [ ] Check 2 version numbers in 'About' page (links.html)\r\n- [ ] Check layout of buttons, check-boxes, and links in each tab\r\n- [ ] Test that all (i)nfo buttons lead to correct FAQ pages in each tab\r\n- [ ] On settings tab (options.html) check that when clicking or hiding are disabled, then all of their sub-items are also disabled\r\n- [ ] Test import/export/clear ads functions\r\n- [ ] Test whitelist\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>Toolbar Icon</b>\r\n- [ ] Check that the icon in the toolbar is in purple when AdNauseam is active\r\n- [ ] Check that the icon in the toolbar is in grey when AdNauseam is disabled\r\n- [ ] Check that the icon in the toolbar is in green when on DNT pages\r\n- [ ] Icon should animate each time an Ad is clicked (>= v3.1)\r\n- [ ] double check that the badge number is correctly updated\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>Notifications</b>\r\n- [ ] Check that disabling hiding, clicking, or blocking on the first-run generates a notification warning at the top of the dashboard (all tabs), menu, and vault page (after first-run is closed or 'ok' is clicked). \r\n- [ ] Check that disabling hiding, clicking, or blocking on the dashboard/options page generates a notification warning at the top of the dashboard(all tabs), menu, and vault page. \r\n- [ ] Check that disabling EasyList/AdNauseam filters on the dashboard/3p-filters page generates a notification warning at the top of the dashboard(all tabs), menu, and vault page. \r\n- [ ] Check that clicking 'reactivate' on a notification warning at the top of the dashboard, menu, or vault pages causes the visual state to change correctly, and the setting in question to be updated correctly. \r\n- [ ] Check that the vault (if open) is updated when notifications change\r\n- [ ] Check that the dashboard (if open) is updated when notifications change\r\n- [ ] Dashboard::settings (options.html) Check that page refreshes correctly when a notification is 'reactivated'\r\n- [ ] Dashboard::3rd-Party (3p-filters.html) Check that page refreshes correctly when a list-notification is 'reactivated'\r\n\r\n------------------\r\n\r\n## Ad Hiding/Parsing\r\n* Test a set of pages, and make sure that ads are being captured and visited   \r\n- [ ] ImageAds: visit Facebook/Youtube/Amazon... and verify ads are hidden and appear in menu\r\n- [ ] TextAds: visit Google/Ask/Yahoo/Bing/DuckDuckGo to search for keywords such as \"credit card\" or \"loan\"\r\n- [ ]  Test Ad-parsing from within dynamically-created iFrames: hidden and collected [here](http://lab-lamp.scm.cityu.edu.hk/adntest/dynamic_iframe.html)\r\n- [ ] Test Ad-parsing from cosmetically-filtered iFrames: hidden but not collected (without cosmetic filters for any contained elements)  [here](http://lab-lamp.scm.cityu.edu.hk/adntest/iframe-cosm.html)                       \r\n*  Test that no Ads are collected in incognito/private-browsing windows:    \r\n   * In Chrome/Opera, go to the extension page and check \"Allow in incognito\" for AdNauseam, then hit command+shift+N to start testing\r\n- [ ] In Firefox, use command+shift+P to open a private window\r\n\r\n------------------\r\n\r\n## DoNotTrack (DNT)\r\nDNT: Go to a DNT page (Ex: duckduckgo.com) and check the following items:\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>Headers/Cookies</b>\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;To check ad visits headers, click on request in browser's network panel, select 'Headers'\r\n&nbsp;&nbsp;&nbsp;&nbsp;(For a more detailed network logging, you can check Chrome Net-Internals of the [tools](#tools) listed below.)\r\n- [ ] DNT-header is being sent correctly for ALL requests (including Ad visits) if either disableClickingForDNT and disableHidingForDNT are enabled (and vice versa) \r\n- [ ] DNT Cookie handling (v3.1 and later)\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>Hiding/Clicking</b>\r\n- [ ] Ads are visible when domain is 1st-party if disableHidingForDNT is checked\r\n- [ ] Requests are not blocked when domain is 1st-party iff disableHidingForDNT is checked\r\n- [ ] Requests are not blocked when domain is 3rd-party iff disableHidingForDNT is checked([hrere](http://lab-lamp.scm.cityu.edu.hk/adntest/effTestPage.html))\r\n- [ ] No clicking when ad domain is on list iff disableClickingForDNT is checked (especially for 3rd-party)\r\n- [ ] If both DNT options are disabled, then hiding, blocking, visiting occur again as usual(both first pary and 3-rd party)\r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<b>Interface</b>\r\n- [ ] DNT list at top of whitelist.html is checked when either DNT option is checked, otherwise unchecked\r\n- [ ] Check that changing the two DNT settings will triggger DNT notifications with corresponding messages to the menu  \r\n- [ ] Check the layout of each DNT notification(\"?\" should be in the middle, 'settings' button appears on hover)  \r\n\r\n&nbsp;&nbsp;&nbsp;&nbsp;<i>[Test Page for 3rd-party DNT](http://lab-lamp.scm.cityu.edu.hk/adntest/effTestPage.html)</i>\r\n\r\n------------------\r\n\r\n## Cookies \r\n* Test that no cookies are accepted from adn-ALLOWed requests: [Test Case](http://lab-lamp.scm.cityu.edu.hk/adntest/incomingCookies.html) \r\n  - [ ] Make sure ‘Activate debugging mode’ is set to true to view log info in the console   \r\n  - [ ] Visit sites where one or more _3rd-party_ requests are adn-ALLOWed and note their domains\r\n* Verify that no cookies are accepted from these domains: first by checking cookies before/after in the browser, then verify using one of the [tools](#tools) listed below (look for 'set-cookies' in response Header)\r\n\r\n------------------\r\n\r\n## Ad Visits \r\nTo check headers for ad visits, please go to developer tools of the browser -> Network -> click on a request -> select 'Headers'. You can also click on 'XHR' type to filter the requests.\r\n(For a more detailed network logging, you can check Chrome Net-Internals of the [tools](#tools) listed below.)\r\n\r\n- [ ] Test that outgoing cookies are always sent\r\n- [ ] Test that incoming cookies are not allowed from responses to Ad visits, by checking cookies before/after\r\n(if only Channel ID cookies are allowed, it is ok for now) [TestCase](http://lab-lamp.scm.cityu.edu.hk/adntest/cookie-setting-ad.html)\r\n- [ ] Please notice that, sometimes there is a “CAUTION: provisional headers are shown” message when you check headers in the console. If you see this message, the headers shown are not reliable. Therefore it should not be considered as a reference when checking the headers during test release/ debugging. Check other requests or use [Chrome Net-Internals](#tools) instead.\r\n- [ ] Test different click probabilities\r\n------------------\r\n\r\n## Check Ad Blockers\r\n- [ ] Install uBlock Origin\r\n- [ ] Remove and reinstall AdNauseam to trigger the first-run page \r\n- [ ] check if there is a warning about other ad blockers on first-run page,menu and vault\r\n- [ ] click 'disable' button on the warning message, it should lead to the extension page\r\n- [ ] disable uBlock and check whether the message is gone in vault and menu.(If the page was opened, it need to be refreshed)\r\n\r\n  _Test this for Adblock Plus/AdBlock/uBlock as well\r\n\r\n------------------\r\n\r\n## Check Blocking\r\n- [ ] Check that the request from the following test page is blocked by adnauseam by using the uBlock logger \r\n[here](http://lab-lamp.scm.cityu.edu.hk/adntest/block.html)\r\n\r\n------------------\r\n\r\n## Check Element-picker Tool\r\n- [ ] Go to some web page with a visible ad, then right-click, select 'Block element', create a rule to hide the element\r\n\r\n------------------\r\n\r\n## Test Update\r\n- [ ] Test Manual Update by clicking \"Update Now\" in settings page\r\n  1.  Change the local uAsset and run tools/update-ublock0.sh to generate a new checksum\r\n  1.  Rebuild AdNauseam\r\n  1.  Click \"Update Now\" in Settings Page and check \r\n    - [ ] All out-dated filters are updated (background.html console)\r\n    - [ ] The total rules of adnauseam has been updated\r\n    - [ ] The rules are functioning when test on webpage.\r\n- [ ] Test Auto Update (This need to be tested from unpacked extension)\r\n Check the same thing above with a different procedure:\r\n 1.  Go to start.js and change this line : \"µb.scheduleAssetUpdater(µb.userSettings.autoUpdate ? 7 * 60 * 1000 : 0);\" to \"µb.scheduleAssetUpdater(µb.userSettings.autoUpdate ? 10 * 1000 : 0);\"\r\n 1.  Go to background.js and change autoUpdateAssetFetchPeriod to 1\r\n 1.  Rebuild AdNauseam\r\n 1.  Delete and reinstall AdNauseam\r\n 1.  Activate debugging mode and open the background.html page to check the logging message in the console\r\n 1.  Wait till the autoUpdate triggers and check whether there is any error message in the console\r\n 1.  Check the same things as above\r\n- [ ] Test \"Update\" button for adnauseam.txt\r\n"}}
{"actor":{"display_login":"greysonevins"}}