{"action":"created","issue":{"url":"https://api.github.com/repos/open-source-parsers/jsoncpp/issues/647","repository_url":"https://api.github.com/repos/open-source-parsers/jsoncpp","labels_url":"https://api.github.com/repos/open-source-parsers/jsoncpp/issues/647/labels{/name}","comments_url":"https://api.github.com/repos/open-source-parsers/jsoncpp/issues/647/comments","events_url":"https://api.github.com/repos/open-source-parsers/jsoncpp/issues/647/events","html_url":"https://github.com/open-source-parsers/jsoncpp/pull/647","id":249560752,"number":647,"title":"Add explicit type conversions into type checks functions","user":{"login":"amostyaev","id":5754691,"avatar_url":"https://avatars3.githubusercontent.com/u/5754691?v=4","gravatar_id":"","url":"https://api.github.com/users/amostyaev","html_url":"https://github.com/amostyaev","followers_url":"https://api.github.com/users/amostyaev/followers","following_url":"https://api.github.com/users/amostyaev/following{/other_user}","gists_url":"https://api.github.com/users/amostyaev/gists{/gist_id}","starred_url":"https://api.github.com/users/amostyaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amostyaev/subscriptions","organizations_url":"https://api.github.com/users/amostyaev/orgs","repos_url":"https://api.github.com/users/amostyaev/repos","events_url":"https://api.github.com/users/amostyaev/events{/privacy}","received_events_url":"https://api.github.com/users/amostyaev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-11T07:47:14Z","updated_at":"2017-08-16T20:14:50Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/open-source-parsers/jsoncpp/pulls/647","html_url":"https://github.com/open-source-parsers/jsoncpp/pull/647","diff_url":"https://github.com/open-source-parsers/jsoncpp/pull/647.diff","patch_url":"https://github.com/open-source-parsers/jsoncpp/pull/647.patch"},"body":"These conversions are required for stable work of debug build on Android"},"comment":{"url":"https://api.github.com/repos/open-source-parsers/jsoncpp/issues/comments/322885761","html_url":"https://github.com/open-source-parsers/jsoncpp/pull/647#issuecomment-322885761","issue_url":"https://api.github.com/repos/open-source-parsers/jsoncpp/issues/647","id":322885761,"user":{"login":"cdunn2001","id":450656,"avatar_url":"https://avatars3.githubusercontent.com/u/450656?v=4","gravatar_id":"","url":"https://api.github.com/users/cdunn2001","html_url":"https://github.com/cdunn2001","followers_url":"https://api.github.com/users/cdunn2001/followers","following_url":"https://api.github.com/users/cdunn2001/following{/other_user}","gists_url":"https://api.github.com/users/cdunn2001/gists{/gist_id}","starred_url":"https://api.github.com/users/cdunn2001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdunn2001/subscriptions","organizations_url":"https://api.github.com/users/cdunn2001/orgs","repos_url":"https://api.github.com/users/cdunn2001/repos","events_url":"https://api.github.com/users/cdunn2001/events{/privacy}","received_events_url":"https://api.github.com/users/cdunn2001/received_events","type":"User","site_admin":false},"created_at":"2017-08-16T20:14:49Z","updated_at":"2017-08-16T20:14:49Z","body":"Test failure:\r\n\r\n```cpp\r\nTesting RValueTest/moveConstruction: OK\r\n\r\n* Detail of ValueTest/integers test failure:\r\n\r\n../src/test_lib_json/main.cpp(825): checkIs(val, checks)\r\n\r\n  ../src/test_lib_json/main.cpp(1313): check.isInt_ == value.isInt()\r\n\r\n    Expected: false\r\n\r\n    Actual  : true\r\n\r\n../src/test_lib_json/main.cpp(828): !val.isConvertibleTo(Json::intValue)\r\n\r\n../src/test_lib_json/main.cpp(851): checkIs(val, checks)\r\n\r\n  ../src/test_lib_json/main.cpp(1313): check.isInt_ == value.isInt()\r\n\r\n    Expected: false\r\n\r\n    Actual  : true\r\n\r\n  ../src/test_lib_json/main.cpp(1314): check.isUInt_ == value.isUInt()\r\n\r\n    Expected: false\r\n\r\n    Actual  : true\r\n\r\n../src/test_lib_json/main.cpp(854): !val.isConvertibleTo(Json::intValue)\r\n\r\n../src/test_lib_json/main.cpp(855): !val.isConvertibleTo(Json::uintValue)\r\n\r\n../src/test_lib_json/main.cpp(903): checkIs(val, checks)\r\n\r\n  ../src/test_lib_json/main.cpp(1313): check.isInt_ == value.isInt()\r\n\r\n    Expected: false\r\n\r\n    Actual  : true\r\n\r\n../src/test_lib_json/main.cpp(906): !val.isConvertibleTo(Json::intValue)\r\n\r\n../src/test_lib_json/main.cpp(927): checkIs(val, checks)\r\n\r\n  ../src/test_lib_json/main.cpp(1313): check.isInt_ == value.isInt()\r\n\r\n    Expected: false\r\n\r\n    Actual  : true\r\n\r\n../src/test_lib_json/main.cpp(930): !val.isConvertibleTo(Json::intValue)\r\n\r\n../src/test_lib_json/main.cpp(978): checkIs(val, checks)\r\n\r\n  ../src/test_lib_json/main.cpp(1313): check.isInt_ == value.isInt()\r\n\r\n    Expected: false\r\n\r\n    Actual  : true\r\n\r\n../src/test_lib_json/main.cpp(981): !val.isConvertibleTo(Json::intValue)\r\n\r\n../src/test_lib_json/main.cpp(1027): checkIs(val, checks)\r\n\r\n  ../src/test_lib_json/main.cpp(1314): check.isUInt_ == value.isUInt()\r\n\r\n    Expected: false\r\n\r\n    Actual  : true\r\n\r\n../src/test_lib_json/main.cpp(1031): !val.isConvertibleTo(Json::uintValue)\r\n\r\n../src/test_lib_json/main.cpp(1073): checkIs(val, checks)\r\n\r\n  ../src/test_lib_json/main.cpp(1314): check.isUInt_ == value.isUInt()\r\n\r\n    Expected: false\r\n\r\n    Actual  : true\r\n\r\n../src/test_lib_json/main.cpp(1077): !val.isConvertibleTo(Json::uintValue)\r\n\r\n56/57 tests passed (1 failure(s))\r\n```\r\nPossibly, the tests themselves need to be fixed? But that could be a backward incompatible change."}}
{"actor":{"display_login":"cdunn2001"}}