{"action":"created","comment":{"url":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/comments/103241182","pull_request_review_id":24021568,"id":103241182,"diff_hunk":"@@ -136,9 +136,33 @@\n \n   describe '#loans' do\n     let(:premium_schedule_report) { PremiumScheduleReport.new }\n-    let(:loan1) { FactoryGirl.create(:loan, :guaranteed, loan_scheme: 'E', loan_source: 'L') }\n-    let(:loan2) { FactoryGirl.create(:loan, :guaranteed, loan_scheme: 'E', loan_source: 'S', reference: 'ABC') }\n-    let(:loan3) { FactoryGirl.create(:loan, :guaranteed, loan_scheme: 'S', loan_source: 'S') }\n+\n+    let(:loan1) do\n+      create(\n+        :guaranteed_loan,\n+        loan_scheme: 'E',\n+        loan_source: 'L'","path":"spec/reports/premium_schedule_report_spec.rb","position":12,"original_position":12,"commit_id":"2a1509d593d88a2b4c8edd21a9fca1f10b71aa0b","original_commit_id":"2a1509d593d88a2b4c8edd21a9fca1f10b71aa0b","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars.githubusercontent.com/u/6697940?v=3","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Put a comma after the last parameter of a multiline method call.<br>Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.","created_at":"2017-02-27T16:02:15Z","updated_at":"2017-02-27T16:02:16Z","html_url":"https://github.com/BritishBusinessBank/EFG/pull/343#discussion_r103241182","pull_request_url":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/343","_links":{"self":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/comments/103241182"},"html":{"href":"https://github.com/BritishBusinessBank/EFG/pull/343#discussion_r103241182"},"pull_request":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/343"}}},"pull_request":{"url":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/343","id":107415783,"html_url":"https://github.com/BritishBusinessBank/EFG/pull/343","diff_url":"https://github.com/BritishBusinessBank/EFG/pull/343.diff","patch_url":"https://github.com/BritishBusinessBank/EFG/pull/343.patch","issue_url":"https://api.github.com/repos/BritishBusinessBank/EFG/issues/343","number":343,"state":"open","locked":false,"title":"Replace loan factory traits with inheritance","user":{"login":"sidane","id":53722,"avatar_url":"https://avatars.githubusercontent.com/u/53722?v=3","gravatar_id":"","url":"https://api.github.com/users/sidane","html_url":"https://github.com/sidane","followers_url":"https://api.github.com/users/sidane/followers","following_url":"https://api.github.com/users/sidane/following{/other_user}","gists_url":"https://api.github.com/users/sidane/gists{/gist_id}","starred_url":"https://api.github.com/users/sidane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidane/subscriptions","organizations_url":"https://api.github.com/users/sidane/orgs","repos_url":"https://api.github.com/users/sidane/repos","events_url":"https://api.github.com/users/sidane/events{/privacy}","received_events_url":"https://api.github.com/users/sidane/received_events","type":"User","site_admin":false},"body":"Previously building a loan that needs to be in a specific state for a spec required combining many traits. Example:\r\n\r\n`create(:loan, :eligible, :completed, :offered, :guaranteed)`\r\n\r\nThis is both verbose and error prone as each state is dependent on attributes set in preceding states. If a trait is left out you will have an incomplete loan in your spec. Often this won’t matter but it has the potential to give false positive test results.\r\n\r\nThere is now a specific factory for each loan state, with these factories inheriting from the relevant parent factory. Examples:\r\n\r\n`create(:completed_loan)` (inherits from `:eligible_loan`)\r\n`build(:guaranteed_loan)` (inherits from `:offered_loan`)\r\n\r\nThis commit also includes a few tweaks to various factories and minor changes to some specs to work with the new factories.","created_at":"2017-02-22T14:16:14Z","updated_at":"2017-02-27T16:02:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd3b1239d9dff13c8aa2d52a01363512ba40d92c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/343/commits","review_comments_url":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/343/comments","review_comment_url":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BritishBusinessBank/EFG/issues/343/comments","statuses_url":"https://api.github.com/repos/BritishBusinessBank/EFG/statuses/2a1509d593d88a2b4c8edd21a9fca1f10b71aa0b","head":{"label":"BritishBusinessBank:nm-replace-loan-factory-traits-with-inheritance","ref":"nm-replace-loan-factory-traits-with-inheritance","sha":"2a1509d593d88a2b4c8edd21a9fca1f10b71aa0b","user":{"login":"BritishBusinessBank","id":25531149,"avatar_url":"https://avatars.githubusercontent.com/u/25531149?v=3","gravatar_id":"","url":"https://api.github.com/users/BritishBusinessBank","html_url":"https://github.com/BritishBusinessBank","followers_url":"https://api.github.com/users/BritishBusinessBank/followers","following_url":"https://api.github.com/users/BritishBusinessBank/following{/other_user}","gists_url":"https://api.github.com/users/BritishBusinessBank/gists{/gist_id}","starred_url":"https://api.github.com/users/BritishBusinessBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BritishBusinessBank/subscriptions","organizations_url":"https://api.github.com/users/BritishBusinessBank/orgs","repos_url":"https://api.github.com/users/BritishBusinessBank/repos","events_url":"https://api.github.com/users/BritishBusinessBank/events{/privacy}","received_events_url":"https://api.github.com/users/BritishBusinessBank/received_events","type":"Organization","site_admin":false},"repo":{"id":4335097,"name":"EFG","full_name":"BritishBusinessBank/EFG","owner":{"login":"BritishBusinessBank","id":25531149,"avatar_url":"https://avatars.githubusercontent.com/u/25531149?v=3","gravatar_id":"","url":"https://api.github.com/users/BritishBusinessBank","html_url":"https://github.com/BritishBusinessBank","followers_url":"https://api.github.com/users/BritishBusinessBank/followers","following_url":"https://api.github.com/users/BritishBusinessBank/following{/other_user}","gists_url":"https://api.github.com/users/BritishBusinessBank/gists{/gist_id}","starred_url":"https://api.github.com/users/BritishBusinessBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BritishBusinessBank/subscriptions","organizations_url":"https://api.github.com/users/BritishBusinessBank/orgs","repos_url":"https://api.github.com/users/BritishBusinessBank/repos","events_url":"https://api.github.com/users/BritishBusinessBank/events{/privacy}","received_events_url":"https://api.github.com/users/BritishBusinessBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BritishBusinessBank/EFG","description":"Enterprise Finance Guarantee","fork":false,"url":"https://api.github.com/repos/BritishBusinessBank/EFG","forks_url":"https://api.github.com/repos/BritishBusinessBank/EFG/forks","keys_url":"https://api.github.com/repos/BritishBusinessBank/EFG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BritishBusinessBank/EFG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BritishBusinessBank/EFG/teams","hooks_url":"https://api.github.com/repos/BritishBusinessBank/EFG/hooks","issue_events_url":"https://api.github.com/repos/BritishBusinessBank/EFG/issues/events{/number}","events_url":"https://api.github.com/repos/BritishBusinessBank/EFG/events","assignees_url":"https://api.github.com/repos/BritishBusinessBank/EFG/assignees{/user}","branches_url":"https://api.github.com/repos/BritishBusinessBank/EFG/branches{/branch}","tags_url":"https://api.github.com/repos/BritishBusinessBank/EFG/tags","blobs_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/refs{/sha}","trees_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BritishBusinessBank/EFG/statuses/{sha}","languages_url":"https://api.github.com/repos/BritishBusinessBank/EFG/languages","stargazers_url":"https://api.github.com/repos/BritishBusinessBank/EFG/stargazers","contributors_url":"https://api.github.com/repos/BritishBusinessBank/EFG/contributors","subscribers_url":"https://api.github.com/repos/BritishBusinessBank/EFG/subscribers","subscription_url":"https://api.github.com/repos/BritishBusinessBank/EFG/subscription","commits_url":"https://api.github.com/repos/BritishBusinessBank/EFG/commits{/sha}","git_commits_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/commits{/sha}","comments_url":"https://api.github.com/repos/BritishBusinessBank/EFG/comments{/number}","issue_comment_url":"https://api.github.com/repos/BritishBusinessBank/EFG/issues/comments{/number}","contents_url":"https://api.github.com/repos/BritishBusinessBank/EFG/contents/{+path}","compare_url":"https://api.github.com/repos/BritishBusinessBank/EFG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BritishBusinessBank/EFG/merges","archive_url":"https://api.github.com/repos/BritishBusinessBank/EFG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BritishBusinessBank/EFG/downloads","issues_url":"https://api.github.com/repos/BritishBusinessBank/EFG/issues{/number}","pulls_url":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls{/number}","milestones_url":"https://api.github.com/repos/BritishBusinessBank/EFG/milestones{/number}","notifications_url":"https://api.github.com/repos/BritishBusinessBank/EFG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BritishBusinessBank/EFG/labels{/name}","releases_url":"https://api.github.com/repos/BritishBusinessBank/EFG/releases{/id}","deployments_url":"https://api.github.com/repos/BritishBusinessBank/EFG/deployments","created_at":"2012-05-15T11:43:32Z","updated_at":"2017-02-15T09:24:27Z","pushed_at":"2017-02-27T15:58:33Z","git_url":"git://github.com/BritishBusinessBank/EFG.git","ssh_url":"git@github.com:BritishBusinessBank/EFG.git","clone_url":"https://github.com/BritishBusinessBank/EFG.git","svn_url":"https://github.com/BritishBusinessBank/EFG","homepage":"https://www.sflg.gov.uk/","size":22424,"stargazers_count":37,"watchers_count":37,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":37,"default_branch":"master"}},"base":{"label":"BritishBusinessBank:loan-variants","ref":"loan-variants","sha":"2a870bae26f26a18c69a7d242b58ef26a50ff724","user":{"login":"BritishBusinessBank","id":25531149,"avatar_url":"https://avatars.githubusercontent.com/u/25531149?v=3","gravatar_id":"","url":"https://api.github.com/users/BritishBusinessBank","html_url":"https://github.com/BritishBusinessBank","followers_url":"https://api.github.com/users/BritishBusinessBank/followers","following_url":"https://api.github.com/users/BritishBusinessBank/following{/other_user}","gists_url":"https://api.github.com/users/BritishBusinessBank/gists{/gist_id}","starred_url":"https://api.github.com/users/BritishBusinessBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BritishBusinessBank/subscriptions","organizations_url":"https://api.github.com/users/BritishBusinessBank/orgs","repos_url":"https://api.github.com/users/BritishBusinessBank/repos","events_url":"https://api.github.com/users/BritishBusinessBank/events{/privacy}","received_events_url":"https://api.github.com/users/BritishBusinessBank/received_events","type":"Organization","site_admin":false},"repo":{"id":4335097,"name":"EFG","full_name":"BritishBusinessBank/EFG","owner":{"login":"BritishBusinessBank","id":25531149,"avatar_url":"https://avatars.githubusercontent.com/u/25531149?v=3","gravatar_id":"","url":"https://api.github.com/users/BritishBusinessBank","html_url":"https://github.com/BritishBusinessBank","followers_url":"https://api.github.com/users/BritishBusinessBank/followers","following_url":"https://api.github.com/users/BritishBusinessBank/following{/other_user}","gists_url":"https://api.github.com/users/BritishBusinessBank/gists{/gist_id}","starred_url":"https://api.github.com/users/BritishBusinessBank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BritishBusinessBank/subscriptions","organizations_url":"https://api.github.com/users/BritishBusinessBank/orgs","repos_url":"https://api.github.com/users/BritishBusinessBank/repos","events_url":"https://api.github.com/users/BritishBusinessBank/events{/privacy}","received_events_url":"https://api.github.com/users/BritishBusinessBank/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BritishBusinessBank/EFG","description":"Enterprise Finance Guarantee","fork":false,"url":"https://api.github.com/repos/BritishBusinessBank/EFG","forks_url":"https://api.github.com/repos/BritishBusinessBank/EFG/forks","keys_url":"https://api.github.com/repos/BritishBusinessBank/EFG/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BritishBusinessBank/EFG/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BritishBusinessBank/EFG/teams","hooks_url":"https://api.github.com/repos/BritishBusinessBank/EFG/hooks","issue_events_url":"https://api.github.com/repos/BritishBusinessBank/EFG/issues/events{/number}","events_url":"https://api.github.com/repos/BritishBusinessBank/EFG/events","assignees_url":"https://api.github.com/repos/BritishBusinessBank/EFG/assignees{/user}","branches_url":"https://api.github.com/repos/BritishBusinessBank/EFG/branches{/branch}","tags_url":"https://api.github.com/repos/BritishBusinessBank/EFG/tags","blobs_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/refs{/sha}","trees_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BritishBusinessBank/EFG/statuses/{sha}","languages_url":"https://api.github.com/repos/BritishBusinessBank/EFG/languages","stargazers_url":"https://api.github.com/repos/BritishBusinessBank/EFG/stargazers","contributors_url":"https://api.github.com/repos/BritishBusinessBank/EFG/contributors","subscribers_url":"https://api.github.com/repos/BritishBusinessBank/EFG/subscribers","subscription_url":"https://api.github.com/repos/BritishBusinessBank/EFG/subscription","commits_url":"https://api.github.com/repos/BritishBusinessBank/EFG/commits{/sha}","git_commits_url":"https://api.github.com/repos/BritishBusinessBank/EFG/git/commits{/sha}","comments_url":"https://api.github.com/repos/BritishBusinessBank/EFG/comments{/number}","issue_comment_url":"https://api.github.com/repos/BritishBusinessBank/EFG/issues/comments{/number}","contents_url":"https://api.github.com/repos/BritishBusinessBank/EFG/contents/{+path}","compare_url":"https://api.github.com/repos/BritishBusinessBank/EFG/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BritishBusinessBank/EFG/merges","archive_url":"https://api.github.com/repos/BritishBusinessBank/EFG/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BritishBusinessBank/EFG/downloads","issues_url":"https://api.github.com/repos/BritishBusinessBank/EFG/issues{/number}","pulls_url":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls{/number}","milestones_url":"https://api.github.com/repos/BritishBusinessBank/EFG/milestones{/number}","notifications_url":"https://api.github.com/repos/BritishBusinessBank/EFG/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BritishBusinessBank/EFG/labels{/name}","releases_url":"https://api.github.com/repos/BritishBusinessBank/EFG/releases{/id}","deployments_url":"https://api.github.com/repos/BritishBusinessBank/EFG/deployments","created_at":"2012-05-15T11:43:32Z","updated_at":"2017-02-15T09:24:27Z","pushed_at":"2017-02-27T15:58:33Z","git_url":"git://github.com/BritishBusinessBank/EFG.git","ssh_url":"git@github.com:BritishBusinessBank/EFG.git","clone_url":"https://github.com/BritishBusinessBank/EFG.git","svn_url":"https://github.com/BritishBusinessBank/EFG","homepage":"https://www.sflg.gov.uk/","size":22424,"stargazers_count":37,"watchers_count":37,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":7,"forks":13,"open_issues":7,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/343"},"html":{"href":"https://github.com/BritishBusinessBank/EFG/pull/343"},"issue":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/issues/343"},"comments":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/issues/343/comments"},"review_comments":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/343/comments"},"review_comment":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/pulls/343/commits"},"statuses":{"href":"https://api.github.com/repos/BritishBusinessBank/EFG/statuses/2a1509d593d88a2b4c8edd21a9fca1f10b71aa0b"}}}}
{"actor":{"display_login":"houndci-bot"}}