{"action":"opened","issue":{"url":"https://api.github.com/repos/toelke/lwip-ftpd/issues/12","repository_url":"https://api.github.com/repos/toelke/lwip-ftpd","labels_url":"https://api.github.com/repos/toelke/lwip-ftpd/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/toelke/lwip-ftpd/issues/12/comments","events_url":"https://api.github.com/repos/toelke/lwip-ftpd/issues/12/events","html_url":"https://github.com/toelke/lwip-ftpd/issues/12","id":223517820,"number":12,"title":"Memory leak after client quits session","user":{"login":"mseker-issd","id":6210351,"avatar_url":"https://avatars3.githubusercontent.com/u/6210351?v=3","gravatar_id":"","url":"https://api.github.com/users/mseker-issd","html_url":"https://github.com/mseker-issd","followers_url":"https://api.github.com/users/mseker-issd/followers","following_url":"https://api.github.com/users/mseker-issd/following{/other_user}","gists_url":"https://api.github.com/users/mseker-issd/gists{/gist_id}","starred_url":"https://api.github.com/users/mseker-issd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mseker-issd/subscriptions","organizations_url":"https://api.github.com/users/mseker-issd/orgs","repos_url":"https://api.github.com/users/mseker-issd/repos","events_url":"https://api.github.com/users/mseker-issd/events{/privacy}","received_events_url":"https://api.github.com/users/mseker-issd/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-21T22:57:20Z","updated_at":"2017-04-21T22:57:20Z","closed_at":null,"body":"Hi Philipp,\r\n\r\nIf the client issues a QUIT command, ftpd replies with 221 and waits for the ftpd_msgsent callback to release the allocated resources with the help of ftpd_msgclose. However, following check never lets the code to reach the ftpd_msgclose function :\r\n\r\nhttps://github.com/toelke/lwip-ftpd/blob/master/ftpd.c#L1203\r\n\r\n`\tif (pcb->state > ESTABLISHED)\r\n\t\treturn ERR_OK;\r\n`\r\n\r\npcb->state is always CLOSE_WAIT at this point in case of QUIT command.\r\n\r\nIs this check really necessary ? Can we remove it to solve the problem ?"}}
{"actor":{"display_login":"mseker-issd"}}