{"action":"closed","number":777,"pull_request":{"url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/777","id":156340629,"html_url":"https://github.com/RedHatInsights/insights-core/pull/777","diff_url":"https://github.com/RedHatInsights/insights-core/pull/777.diff","patch_url":"https://github.com/RedHatInsights/insights-core/pull/777.patch","issue_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/777","number":777,"state":"closed","locked":false,"title":"Document and tidy the ClusterConf parser for master branch","user":{"login":"PaulWay","id":1616393,"avatar_url":"https://avatars1.githubusercontent.com/u/1616393?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulWay","html_url":"https://github.com/PaulWay","followers_url":"https://api.github.com/users/PaulWay/followers","following_url":"https://api.github.com/users/PaulWay/following{/other_user}","gists_url":"https://api.github.com/users/PaulWay/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulWay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulWay/subscriptions","organizations_url":"https://api.github.com/users/PaulWay/orgs","repos_url":"https://api.github.com/users/PaulWay/repos","events_url":"https://api.github.com/users/PaulWay/events{/privacy}","received_events_url":"https://api.github.com/users/PaulWay/received_events","type":"User","site_admin":false},"body":"Long ago, when Paul was young and naive, he added the `get_cluster_conf` parser in the hopes that one day people would load entire XML files and do intelligent queries on them. His hopes were dashed when he found out that the XML being imported was being line filtered by keywords, so every single Insights archive would never work with this parser.\r\n\r\nFinally, seeing that no-one was in any hurry to actually parse the XML of the cluster.conf file, Paul came to his senses and removed this failed attempt.\r\n\r\nThis merge also documents and tests the ClusterConf parser, such as it is.\r\n\r\nThis is the master branch version of #743 ","created_at":"2017-12-05T00:13:11Z","updated_at":"2017-12-05T09:38:38Z","closed_at":"2017-12-05T09:38:38Z","merged_at":"2017-12-05T09:38:38Z","merge_commit_sha":"570a6f2365a7a5411204e19601b37c78fe5fafab","assignee":{"login":"PaulWay","id":1616393,"avatar_url":"https://avatars1.githubusercontent.com/u/1616393?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulWay","html_url":"https://github.com/PaulWay","followers_url":"https://api.github.com/users/PaulWay/followers","following_url":"https://api.github.com/users/PaulWay/following{/other_user}","gists_url":"https://api.github.com/users/PaulWay/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulWay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulWay/subscriptions","organizations_url":"https://api.github.com/users/PaulWay/orgs","repos_url":"https://api.github.com/users/PaulWay/repos","events_url":"https://api.github.com/users/PaulWay/events{/privacy}","received_events_url":"https://api.github.com/users/PaulWay/received_events","type":"User","site_admin":false},"assignees":[{"login":"PaulWay","id":1616393,"avatar_url":"https://avatars1.githubusercontent.com/u/1616393?v=4","gravatar_id":"","url":"https://api.github.com/users/PaulWay","html_url":"https://github.com/PaulWay","followers_url":"https://api.github.com/users/PaulWay/followers","following_url":"https://api.github.com/users/PaulWay/following{/other_user}","gists_url":"https://api.github.com/users/PaulWay/gists{/gist_id}","starred_url":"https://api.github.com/users/PaulWay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaulWay/subscriptions","organizations_url":"https://api.github.com/users/PaulWay/orgs","repos_url":"https://api.github.com/users/PaulWay/repos","events_url":"https://api.github.com/users/PaulWay/events{/privacy}","received_events_url":"https://api.github.com/users/PaulWay/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bfahr","id":20520336,"avatar_url":"https://avatars2.githubusercontent.com/u/20520336?v=4","gravatar_id":"","url":"https://api.github.com/users/bfahr","html_url":"https://github.com/bfahr","followers_url":"https://api.github.com/users/bfahr/followers","following_url":"https://api.github.com/users/bfahr/following{/other_user}","gists_url":"https://api.github.com/users/bfahr/gists{/gist_id}","starred_url":"https://api.github.com/users/bfahr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bfahr/subscriptions","organizations_url":"https://api.github.com/users/bfahr/orgs","repos_url":"https://api.github.com/users/bfahr/repos","events_url":"https://api.github.com/users/bfahr/events{/privacy}","received_events_url":"https://api.github.com/users/bfahr/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/777/commits","review_comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/777/comments","review_comment_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/777/comments","statuses_url":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/67061a12267cb40fb50237820ddf0b4ba3c88254","head":{"label":"RedHatInsights:cluster_conf_disable_failed_parser","ref":"cluster_conf_disable_failed_parser","sha":"67061a12267cb40fb50237820ddf0b4ba3c88254","user":{"login":"RedHatInsights","id":24939818,"avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"repo":{"id":92518221,"name":"insights-core","full_name":"RedHatInsights/insights-core","owner":{"login":"RedHatInsights","id":24939818,"avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHatInsights/insights-core","description":"Core rule execution framework","fork":false,"url":"https://api.github.com/repos/RedHatInsights/insights-core","forks_url":"https://api.github.com/repos/RedHatInsights/insights-core/forks","keys_url":"https://api.github.com/repos/RedHatInsights/insights-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatInsights/insights-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatInsights/insights-core/teams","hooks_url":"https://api.github.com/repos/RedHatInsights/insights-core/hooks","issue_events_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatInsights/insights-core/events","assignees_url":"https://api.github.com/repos/RedHatInsights/insights-core/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatInsights/insights-core/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/tags","blobs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatInsights/insights-core/languages","stargazers_url":"https://api.github.com/repos/RedHatInsights/insights-core/stargazers","contributors_url":"https://api.github.com/repos/RedHatInsights/insights-core/contributors","subscribers_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscribers","subscription_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscription","commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatInsights/insights-core/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatInsights/insights-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatInsights/insights-core/merges","archive_url":"https://api.github.com/repos/RedHatInsights/insights-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatInsights/insights-core/downloads","issues_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatInsights/insights-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatInsights/insights-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatInsights/insights-core/labels{/name}","releases_url":"https://api.github.com/repos/RedHatInsights/insights-core/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatInsights/insights-core/deployments","created_at":"2017-05-26T14:23:11Z","updated_at":"2017-11-10T02:20:47Z","pushed_at":"2017-12-05T09:38:38Z","git_url":"git://github.com/RedHatInsights/insights-core.git","ssh_url":"git@github.com:RedHatInsights/insights-core.git","clone_url":"https://github.com/RedHatInsights/insights-core.git","svn_url":"https://github.com/RedHatInsights/insights-core","homepage":"https://access.redhat.com/insights","size":5258,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":23,"open_issues":86,"watchers":7,"default_branch":"master"}},"base":{"label":"RedHatInsights:master","ref":"master","sha":"e724018a62b992c615f31f62c0b391d1e5f8a80b","user":{"login":"RedHatInsights","id":24939818,"avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"repo":{"id":92518221,"name":"insights-core","full_name":"RedHatInsights/insights-core","owner":{"login":"RedHatInsights","id":24939818,"avatar_url":"https://avatars2.githubusercontent.com/u/24939818?v=4","gravatar_id":"","url":"https://api.github.com/users/RedHatInsights","html_url":"https://github.com/RedHatInsights","followers_url":"https://api.github.com/users/RedHatInsights/followers","following_url":"https://api.github.com/users/RedHatInsights/following{/other_user}","gists_url":"https://api.github.com/users/RedHatInsights/gists{/gist_id}","starred_url":"https://api.github.com/users/RedHatInsights/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RedHatInsights/subscriptions","organizations_url":"https://api.github.com/users/RedHatInsights/orgs","repos_url":"https://api.github.com/users/RedHatInsights/repos","events_url":"https://api.github.com/users/RedHatInsights/events{/privacy}","received_events_url":"https://api.github.com/users/RedHatInsights/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RedHatInsights/insights-core","description":"Core rule execution framework","fork":false,"url":"https://api.github.com/repos/RedHatInsights/insights-core","forks_url":"https://api.github.com/repos/RedHatInsights/insights-core/forks","keys_url":"https://api.github.com/repos/RedHatInsights/insights-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RedHatInsights/insights-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RedHatInsights/insights-core/teams","hooks_url":"https://api.github.com/repos/RedHatInsights/insights-core/hooks","issue_events_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/events{/number}","events_url":"https://api.github.com/repos/RedHatInsights/insights-core/events","assignees_url":"https://api.github.com/repos/RedHatInsights/insights-core/assignees{/user}","branches_url":"https://api.github.com/repos/RedHatInsights/insights-core/branches{/branch}","tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/tags","blobs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/{sha}","languages_url":"https://api.github.com/repos/RedHatInsights/insights-core/languages","stargazers_url":"https://api.github.com/repos/RedHatInsights/insights-core/stargazers","contributors_url":"https://api.github.com/repos/RedHatInsights/insights-core/contributors","subscribers_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscribers","subscription_url":"https://api.github.com/repos/RedHatInsights/insights-core/subscription","commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/RedHatInsights/insights-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/RedHatInsights/insights-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/RedHatInsights/insights-core/contents/{+path}","compare_url":"https://api.github.com/repos/RedHatInsights/insights-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RedHatInsights/insights-core/merges","archive_url":"https://api.github.com/repos/RedHatInsights/insights-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RedHatInsights/insights-core/downloads","issues_url":"https://api.github.com/repos/RedHatInsights/insights-core/issues{/number}","pulls_url":"https://api.github.com/repos/RedHatInsights/insights-core/pulls{/number}","milestones_url":"https://api.github.com/repos/RedHatInsights/insights-core/milestones{/number}","notifications_url":"https://api.github.com/repos/RedHatInsights/insights-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RedHatInsights/insights-core/labels{/name}","releases_url":"https://api.github.com/repos/RedHatInsights/insights-core/releases{/id}","deployments_url":"https://api.github.com/repos/RedHatInsights/insights-core/deployments","created_at":"2017-05-26T14:23:11Z","updated_at":"2017-11-10T02:20:47Z","pushed_at":"2017-12-05T09:38:38Z","git_url":"git://github.com/RedHatInsights/insights-core.git","ssh_url":"git@github.com:RedHatInsights/insights-core.git","clone_url":"https://github.com/RedHatInsights/insights-core.git","svn_url":"https://github.com/RedHatInsights/insights-core","homepage":"https://access.redhat.com/insights","size":5258,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":86,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":23,"open_issues":86,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/777"},"html":{"href":"https://github.com/RedHatInsights/insights-core/pull/777"},"issue":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/issues/777"},"comments":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/issues/777/comments"},"review_comments":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/777/comments"},"review_comment":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/pulls/777/commits"},"statuses":{"href":"https://api.github.com/repos/RedHatInsights/insights-core/statuses/67061a12267cb40fb50237820ddf0b4ba3c88254"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"xiangce","id":16770981,"avatar_url":"https://avatars2.githubusercontent.com/u/16770981?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangce","html_url":"https://github.com/xiangce","followers_url":"https://api.github.com/users/xiangce/followers","following_url":"https://api.github.com/users/xiangce/following{/other_user}","gists_url":"https://api.github.com/users/xiangce/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangce/subscriptions","organizations_url":"https://api.github.com/users/xiangce/orgs","repos_url":"https://api.github.com/users/xiangce/repos","events_url":"https://api.github.com/users/xiangce/events{/privacy}","received_events_url":"https://api.github.com/users/xiangce/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":19,"deletions":179,"changed_files":3}}
{"actor":{"display_login":"xiangce"}}