{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-unity/issues/95","repository_url":"https://api.github.com/repos/aws/aws-sdk-unity","labels_url":"https://api.github.com/repos/aws/aws-sdk-unity/issues/95/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-unity/issues/95/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-unity/issues/95/events","html_url":"https://github.com/aws/aws-sdk-unity/pull/95","id":110289673,"number":95,"title":"*Don't* swallow errors from the callback.  Let it fail, in another th…","user":{"login":"seaders","id":955114,"avatar_url":"https://avatars3.githubusercontent.com/u/955114?v=4","gravatar_id":"","url":"https://api.github.com/users/seaders","html_url":"https://github.com/seaders","followers_url":"https://api.github.com/users/seaders/followers","following_url":"https://api.github.com/users/seaders/following{/other_user}","gists_url":"https://api.github.com/users/seaders/gists{/gist_id}","starred_url":"https://api.github.com/users/seaders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seaders/subscriptions","organizations_url":"https://api.github.com/users/seaders/orgs","repos_url":"https://api.github.com/users/seaders/repos","events_url":"https://api.github.com/users/seaders/events{/privacy}","received_events_url":"https://api.github.com/users/seaders/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2015-10-07T18:39:21Z","updated_at":"2017-11-09T20:04:39Z","closed_at":"2017-11-09T20:04:39Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-unity/pulls/95","html_url":"https://github.com/aws/aws-sdk-unity/pull/95","diff_url":"https://github.com/aws/aws-sdk-unity/pull/95.diff","patch_url":"https://github.com/aws/aws-sdk-unity/pull/95.patch"},"body":"…read / Coroutine, but _don't_ swallow it.  It causes all sorts of issues in real-life scenarios.\n\nThis is especially relevant for how we all work with the Amazon SDK, with anonymous lambdas, so the only sort of debugging information you get after an exception has been thrown is something like,\n\n```\n An unhandled exception was thrown from the callback method, <>m__0\n```\n\nSwallowing errors, and displaying incomplete largely unhelpful reports of those errors is really, really, really bad practise _ESPECIALLY_ when we're talking about swallowing errors of CALLBACK methods.  Sure, you don't want to break your internal flow, that's fine.  But then detach from it, through another thread, or coroutine, but _DON'T_ swallow the errors.\n"},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-unity/issues/comments/343275257","html_url":"https://github.com/aws/aws-sdk-unity/pull/95#issuecomment-343275257","issue_url":"https://api.github.com/repos/aws/aws-sdk-unity/issues/95","id":343275257,"user":{"login":"hyandell","id":477715,"avatar_url":"https://avatars2.githubusercontent.com/u/477715?v=4","gravatar_id":"","url":"https://api.github.com/users/hyandell","html_url":"https://github.com/hyandell","followers_url":"https://api.github.com/users/hyandell/followers","following_url":"https://api.github.com/users/hyandell/following{/other_user}","gists_url":"https://api.github.com/users/hyandell/gists{/gist_id}","starred_url":"https://api.github.com/users/hyandell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyandell/subscriptions","organizations_url":"https://api.github.com/users/hyandell/orgs","repos_url":"https://api.github.com/users/hyandell/repos","events_url":"https://api.github.com/users/hyandell/events{/privacy}","received_events_url":"https://api.github.com/users/hyandell/received_events","type":"User","site_admin":false},"created_at":"2017-11-09T20:04:38Z","updated_at":"2017-11-09T20:04:38Z","author_association":"NONE","body":"Closing per Karthik's comment."}}
{"actor":{"display_login":"hyandell"}}