{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/118081077","pull_request_review_id":39840772,"id":118081077,"diff_hunk":"@@ -32,6 +32,8 @@ buildGoPackage rec {\n     sha256 = \"0n8hcj2b1pb95x4bd7fb9ri43vgc4h2dj2v3iiziw2imqjyphfx4\";\n   };\n \n+  patches = [ ./v1-fix-shell-path.patch ];","path":"pkgs/development/tools/continuous-integration/gitlab-runner/default.nix","position":null,"original_position":4,"commit_id":"86e714095c4446466fafa47f1a546d0da4410530","original_commit_id":"da6f5e3b77529ad4bc4c2e8ca40792ac8a7af9f9","user":{"login":"bachp","id":333807,"avatar_url":"https://avatars2.githubusercontent.com/u/333807?v=3","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"body":"@elseym Looks reasonable. Are you willing to push this to gitlab runner upstream?","created_at":"2017-05-23T19:13:50Z","updated_at":"2017-05-23T19:13:51Z","html_url":"https://github.com/NixOS/nixpkgs/pull/26003#discussion_r118081077","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/26003","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/118081077"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/26003#discussion_r118081077"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/26003"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/26003","id":121869784,"html_url":"https://github.com/NixOS/nixpkgs/pull/26003","diff_url":"https://github.com/NixOS/nixpkgs/pull/26003.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/26003.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/26003","number":26003,"state":"open","locked":false,"title":"Gitlab runner update","user":{"login":"bachp","id":333807,"avatar_url":"https://avatars2.githubusercontent.com/u/333807?v=3","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nUpdate to latest upstream release.\r\nAlso apply the patch from 1.11 to 9.2.0\r\n\r\n###### Things done\r\n\r\n- [x] Tested using sandboxing\r\n  ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS,\r\n    or option `build-use-sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file)\r\n    on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] Linux\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2017-05-22T21:31:44Z","updated_at":"2017-05-23T19:13:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d4767c98410dd5456cdb8c7814f9bf5c1ebad909","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/26003/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/26003/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/26003/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/86e714095c4446466fafa47f1a546d0da4410530","head":{"label":"bachp:gitlab-runner-update","ref":"gitlab-runner-update","sha":"86e714095c4446466fafa47f1a546d0da4410530","user":{"login":"bachp","id":333807,"avatar_url":"https://avatars2.githubusercontent.com/u/333807?v=3","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"repo":{"id":68442977,"name":"nixpkgs","full_name":"bachp/nixpkgs","owner":{"login":"bachp","id":333807,"avatar_url":"https://avatars2.githubusercontent.com/u/333807?v=3","gravatar_id":"","url":"https://api.github.com/users/bachp","html_url":"https://github.com/bachp","followers_url":"https://api.github.com/users/bachp/followers","following_url":"https://api.github.com/users/bachp/following{/other_user}","gists_url":"https://api.github.com/users/bachp/gists{/gist_id}","starred_url":"https://api.github.com/users/bachp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bachp/subscriptions","organizations_url":"https://api.github.com/users/bachp/orgs","repos_url":"https://api.github.com/users/bachp/repos","events_url":"https://api.github.com/users/bachp/events{/privacy}","received_events_url":"https://api.github.com/users/bachp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bachp/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/bachp/nixpkgs","forks_url":"https://api.github.com/repos/bachp/nixpkgs/forks","keys_url":"https://api.github.com/repos/bachp/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bachp/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bachp/nixpkgs/teams","hooks_url":"https://api.github.com/repos/bachp/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/bachp/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/bachp/nixpkgs/events","assignees_url":"https://api.github.com/repos/bachp/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/bachp/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/bachp/nixpkgs/tags","blobs_url":"https://api.github.com/repos/bachp/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bachp/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bachp/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bachp/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bachp/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/bachp/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/bachp/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/bachp/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/bachp/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/bachp/nixpkgs/subscription","commits_url":"https://api.github.com/repos/bachp/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bachp/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bachp/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bachp/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bachp/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/bachp/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bachp/nixpkgs/merges","archive_url":"https://api.github.com/repos/bachp/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bachp/nixpkgs/downloads","issues_url":"https://api.github.com/repos/bachp/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/bachp/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/bachp/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/bachp/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bachp/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/bachp/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/bachp/nixpkgs/deployments","created_at":"2016-09-17T09:17:09Z","updated_at":"2016-09-17T09:17:31Z","pushed_at":"2017-05-22T21:27:16Z","git_url":"git://github.com/bachp/nixpkgs.git","ssh_url":"git@github.com:bachp/nixpkgs.git","clone_url":"https://github.com/bachp/nixpkgs.git","svn_url":"https://github.com/bachp/nixpkgs","homepage":null,"size":465536,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"2549be898de0eb535d6b1cd04728791b2935f23e","user":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"avatar_url":"https://avatars0.githubusercontent.com/u/487568?v=3","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2017-05-23T18:05:57Z","pushed_at":"2017-05-23T18:51:38Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":475102,"stargazers_count":1699,"watchers_count":1699,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2055,"mirror_url":null,"open_issues_count":2012,"forks":2055,"open_issues":2012,"watchers":1699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/26003"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/26003"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/26003"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/26003/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/26003/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/26003/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/86e714095c4446466fafa47f1a546d0da4410530"}}}}
{"actor":{"display_login":"bachp"}}