{"action":"created","comment":{"url":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/comments/102846702","pull_request_review_id":23616908,"id":102846702,"diff_hunk":"@@ -81,7 +81,7 @@ defmodule Bypass.Instance do\n   end\n   defp do_handle_call(:down, from, %{socket: socket, ref: ref} = state) when not is_nil(socket) do\n     nil = state.caller_awaiting_down  # assertion\n-    if state.retained_plug != nil do\n+    if state.retained_plugs != [] do","path":"lib/bypass/instance.ex","position":26,"original_position":26,"commit_id":"6a0cf4b2b26ff0650ad1e5e8db96f2594ca6e3d6","original_commit_id":"6a0cf4b2b26ff0650ad1e5e8db96f2594ca6e3d6","user":{"login":"alanvoss","id":1993821,"avatar_url":"https://avatars.githubusercontent.com/u/1993821?v=3","gravatar_id":"","url":"https://api.github.com/users/alanvoss","html_url":"https://github.com/alanvoss","followers_url":"https://api.github.com/users/alanvoss/followers","following_url":"https://api.github.com/users/alanvoss/following{/other_user}","gists_url":"https://api.github.com/users/alanvoss/gists{/gist_id}","starred_url":"https://api.github.com/users/alanvoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanvoss/subscriptions","organizations_url":"https://api.github.com/users/alanvoss/orgs","repos_url":"https://api.github.com/users/alanvoss/repos","events_url":"https://api.github.com/users/alanvoss/events{/privacy}","received_events_url":"https://api.github.com/users/alanvoss/received_events","type":"User","site_admin":false},"body":"@alco  If we are doing concurrent requests, then \"the specific plug associated with this Bypass instance\" doesn't really hold -- there are multiple plugs associated with this instance's `state`.  We need to wait for all of them to finish.\r\n\r\n I think your second statement makes perfect sense to me, and definitely was something I neglected.\r\n\r\nCan you please expand on your first statement and explain a little more?","created_at":"2017-02-23T23:33:14Z","updated_at":"2017-02-23T23:33:14Z","html_url":"https://github.com/PSPDFKit-labs/bypass/pull/34#discussion_r102846702","pull_request_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/comments/102846702"},"html":{"href":"https://github.com/PSPDFKit-labs/bypass/pull/34#discussion_r102846702"},"pull_request":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/34","id":101978440,"html_url":"https://github.com/PSPDFKit-labs/bypass/pull/34","diff_url":"https://github.com/PSPDFKit-labs/bypass/pull/34.diff","patch_url":"https://github.com/PSPDFKit-labs/bypass/pull/34.patch","issue_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/issues/34","number":34,"state":"open","locked":false,"title":"Adding concurrent request capabilities","user":{"login":"alanvoss","id":1993821,"avatar_url":"https://avatars.githubusercontent.com/u/1993821?v=3","gravatar_id":"","url":"https://api.github.com/users/alanvoss","html_url":"https://github.com/alanvoss","followers_url":"https://api.github.com/users/alanvoss/followers","following_url":"https://api.github.com/users/alanvoss/following{/other_user}","gists_url":"https://api.github.com/users/alanvoss/gists{/gist_id}","starred_url":"https://api.github.com/users/alanvoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanvoss/subscriptions","organizations_url":"https://api.github.com/users/alanvoss/orgs","repos_url":"https://api.github.com/users/alanvoss/repos","events_url":"https://api.github.com/users/alanvoss/events{/privacy}","received_events_url":"https://api.github.com/users/alanvoss/received_events","type":"User","site_admin":false},"body":"Per @manukall 's original request in https://github.com/PSPDFKit-labs/bypass/issues/12 .\r\n\r\nWe, too, were having problems at our organization with this.  It seems that keeping a running `List` of the calling `pid`s is sufficient.\r\n\r\nI've included his test in the pull, and fixed it, I believe.  Commits squashed.\r\n\r\nCloses PSPDFKit-labs/bypass#12 .","created_at":"2017-01-18T00:50:01Z","updated_at":"2017-02-23T23:33:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"85f388a50649163e8f718a50881c5c0210d3e016","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/34/commits","review_comments_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/34/comments","review_comment_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/issues/34/comments","statuses_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/statuses/6a0cf4b2b26ff0650ad1e5e8db96f2594ca6e3d6","head":{"label":"alanvoss:concurrent_requests_amended","ref":"concurrent_requests_amended","sha":"6a0cf4b2b26ff0650ad1e5e8db96f2594ca6e3d6","user":{"login":"alanvoss","id":1993821,"avatar_url":"https://avatars.githubusercontent.com/u/1993821?v=3","gravatar_id":"","url":"https://api.github.com/users/alanvoss","html_url":"https://github.com/alanvoss","followers_url":"https://api.github.com/users/alanvoss/followers","following_url":"https://api.github.com/users/alanvoss/following{/other_user}","gists_url":"https://api.github.com/users/alanvoss/gists{/gist_id}","starred_url":"https://api.github.com/users/alanvoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanvoss/subscriptions","organizations_url":"https://api.github.com/users/alanvoss/orgs","repos_url":"https://api.github.com/users/alanvoss/repos","events_url":"https://api.github.com/users/alanvoss/events{/privacy}","received_events_url":"https://api.github.com/users/alanvoss/received_events","type":"User","site_admin":false},"repo":{"id":79285228,"name":"bypass","full_name":"alanvoss/bypass","owner":{"login":"alanvoss","id":1993821,"avatar_url":"https://avatars.githubusercontent.com/u/1993821?v=3","gravatar_id":"","url":"https://api.github.com/users/alanvoss","html_url":"https://github.com/alanvoss","followers_url":"https://api.github.com/users/alanvoss/followers","following_url":"https://api.github.com/users/alanvoss/following{/other_user}","gists_url":"https://api.github.com/users/alanvoss/gists{/gist_id}","starred_url":"https://api.github.com/users/alanvoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanvoss/subscriptions","organizations_url":"https://api.github.com/users/alanvoss/orgs","repos_url":"https://api.github.com/users/alanvoss/repos","events_url":"https://api.github.com/users/alanvoss/events{/privacy}","received_events_url":"https://api.github.com/users/alanvoss/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alanvoss/bypass","description":"Bypass provides a quick way to create a custom plug that can be put in place instead of an actual HTTP server to return prebaked responses to client requests.","fork":true,"url":"https://api.github.com/repos/alanvoss/bypass","forks_url":"https://api.github.com/repos/alanvoss/bypass/forks","keys_url":"https://api.github.com/repos/alanvoss/bypass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alanvoss/bypass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alanvoss/bypass/teams","hooks_url":"https://api.github.com/repos/alanvoss/bypass/hooks","issue_events_url":"https://api.github.com/repos/alanvoss/bypass/issues/events{/number}","events_url":"https://api.github.com/repos/alanvoss/bypass/events","assignees_url":"https://api.github.com/repos/alanvoss/bypass/assignees{/user}","branches_url":"https://api.github.com/repos/alanvoss/bypass/branches{/branch}","tags_url":"https://api.github.com/repos/alanvoss/bypass/tags","blobs_url":"https://api.github.com/repos/alanvoss/bypass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alanvoss/bypass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alanvoss/bypass/git/refs{/sha}","trees_url":"https://api.github.com/repos/alanvoss/bypass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alanvoss/bypass/statuses/{sha}","languages_url":"https://api.github.com/repos/alanvoss/bypass/languages","stargazers_url":"https://api.github.com/repos/alanvoss/bypass/stargazers","contributors_url":"https://api.github.com/repos/alanvoss/bypass/contributors","subscribers_url":"https://api.github.com/repos/alanvoss/bypass/subscribers","subscription_url":"https://api.github.com/repos/alanvoss/bypass/subscription","commits_url":"https://api.github.com/repos/alanvoss/bypass/commits{/sha}","git_commits_url":"https://api.github.com/repos/alanvoss/bypass/git/commits{/sha}","comments_url":"https://api.github.com/repos/alanvoss/bypass/comments{/number}","issue_comment_url":"https://api.github.com/repos/alanvoss/bypass/issues/comments{/number}","contents_url":"https://api.github.com/repos/alanvoss/bypass/contents/{+path}","compare_url":"https://api.github.com/repos/alanvoss/bypass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alanvoss/bypass/merges","archive_url":"https://api.github.com/repos/alanvoss/bypass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alanvoss/bypass/downloads","issues_url":"https://api.github.com/repos/alanvoss/bypass/issues{/number}","pulls_url":"https://api.github.com/repos/alanvoss/bypass/pulls{/number}","milestones_url":"https://api.github.com/repos/alanvoss/bypass/milestones{/number}","notifications_url":"https://api.github.com/repos/alanvoss/bypass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alanvoss/bypass/labels{/name}","releases_url":"https://api.github.com/repos/alanvoss/bypass/releases{/id}","deployments_url":"https://api.github.com/repos/alanvoss/bypass/deployments","created_at":"2017-01-18T00:02:38Z","updated_at":"2017-01-18T00:02:41Z","pushed_at":"2017-02-23T23:02:13Z","git_url":"git://github.com/alanvoss/bypass.git","ssh_url":"git@github.com:alanvoss/bypass.git","clone_url":"https://github.com/alanvoss/bypass.git","svn_url":"https://github.com/alanvoss/bypass","homepage":"","size":63,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PSPDFKit-labs:master","ref":"master","sha":"6ed6bee81e48653bcca31f03dec9506889fc44c6","user":{"login":"PSPDFKit-labs","id":10983927,"avatar_url":"https://avatars.githubusercontent.com/u/10983927?v=3","gravatar_id":"","url":"https://api.github.com/users/PSPDFKit-labs","html_url":"https://github.com/PSPDFKit-labs","followers_url":"https://api.github.com/users/PSPDFKit-labs/followers","following_url":"https://api.github.com/users/PSPDFKit-labs/following{/other_user}","gists_url":"https://api.github.com/users/PSPDFKit-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/PSPDFKit-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PSPDFKit-labs/subscriptions","organizations_url":"https://api.github.com/users/PSPDFKit-labs/orgs","repos_url":"https://api.github.com/users/PSPDFKit-labs/repos","events_url":"https://api.github.com/users/PSPDFKit-labs/events{/privacy}","received_events_url":"https://api.github.com/users/PSPDFKit-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":42600815,"name":"bypass","full_name":"PSPDFKit-labs/bypass","owner":{"login":"PSPDFKit-labs","id":10983927,"avatar_url":"https://avatars.githubusercontent.com/u/10983927?v=3","gravatar_id":"","url":"https://api.github.com/users/PSPDFKit-labs","html_url":"https://github.com/PSPDFKit-labs","followers_url":"https://api.github.com/users/PSPDFKit-labs/followers","following_url":"https://api.github.com/users/PSPDFKit-labs/following{/other_user}","gists_url":"https://api.github.com/users/PSPDFKit-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/PSPDFKit-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PSPDFKit-labs/subscriptions","organizations_url":"https://api.github.com/users/PSPDFKit-labs/orgs","repos_url":"https://api.github.com/users/PSPDFKit-labs/repos","events_url":"https://api.github.com/users/PSPDFKit-labs/events{/privacy}","received_events_url":"https://api.github.com/users/PSPDFKit-labs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PSPDFKit-labs/bypass","description":"Bypass provides a quick way to create a custom plug that can be put in place instead of an actual HTTP server to return prebaked responses to client requests.","fork":false,"url":"https://api.github.com/repos/PSPDFKit-labs/bypass","forks_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/forks","keys_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/teams","hooks_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/hooks","issue_events_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/issues/events{/number}","events_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/events","assignees_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/assignees{/user}","branches_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/branches{/branch}","tags_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/tags","blobs_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/git/refs{/sha}","trees_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/statuses/{sha}","languages_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/languages","stargazers_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/stargazers","contributors_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/contributors","subscribers_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/subscribers","subscription_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/subscription","commits_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/commits{/sha}","git_commits_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/git/commits{/sha}","comments_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/comments{/number}","issue_comment_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/issues/comments{/number}","contents_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/contents/{+path}","compare_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/merges","archive_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/downloads","issues_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/issues{/number}","pulls_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls{/number}","milestones_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/milestones{/number}","notifications_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/labels{/name}","releases_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/releases{/id}","deployments_url":"https://api.github.com/repos/PSPDFKit-labs/bypass/deployments","created_at":"2015-09-16T16:52:16Z","updated_at":"2017-02-20T10:02:35Z","pushed_at":"2017-02-20T08:39:13Z","git_url":"git://github.com/PSPDFKit-labs/bypass.git","ssh_url":"git@github.com:PSPDFKit-labs/bypass.git","clone_url":"https://github.com/PSPDFKit-labs/bypass.git","svn_url":"https://github.com/PSPDFKit-labs/bypass","homepage":"","size":44,"stargazers_count":259,"watchers_count":259,"language":"Elixir","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":7,"forks":20,"open_issues":7,"watchers":259,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/34"},"html":{"href":"https://github.com/PSPDFKit-labs/bypass/pull/34"},"issue":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/issues/34"},"comments":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/PSPDFKit-labs/bypass/statuses/6a0cf4b2b26ff0650ad1e5e8db96f2594ca6e3d6"}}}}
{"actor":{"display_login":"alanvoss"}}