{"action":"created","issue":{"url":"https://api.github.com/repos/e107inc/e107/issues/2272","repository_url":"https://api.github.com/repos/e107inc/e107","labels_url":"https://api.github.com/repos/e107inc/e107/issues/2272/labels{/name}","comments_url":"https://api.github.com/repos/e107inc/e107/issues/2272/comments","events_url":"https://api.github.com/repos/e107inc/e107/issues/2272/events","html_url":"https://github.com/e107inc/e107/issues/2272","id":200726879,"number":2272,"title":"Menu HTML Markup - Theme Developer Feedback Requested","user":{"login":"CaMer0n","id":2825679,"avatar_url":"https://avatars.githubusercontent.com/u/2825679?v=3","gravatar_id":"","url":"https://api.github.com/users/CaMer0n","html_url":"https://github.com/CaMer0n","followers_url":"https://api.github.com/users/CaMer0n/followers","following_url":"https://api.github.com/users/CaMer0n/following{/other_user}","gists_url":"https://api.github.com/users/CaMer0n/gists{/gist_id}","starred_url":"https://api.github.com/users/CaMer0n/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CaMer0n/subscriptions","organizations_url":"https://api.github.com/users/CaMer0n/orgs","repos_url":"https://api.github.com/users/CaMer0n/repos","events_url":"https://api.github.com/users/CaMer0n/events{/privacy}","received_events_url":"https://api.github.com/users/CaMer0n/received_events","type":"User","site_admin":false},"labels":[{"id":38759968,"url":"https://api.github.com/repos/e107inc/e107/labels/awaiting%20feedback","name":"awaiting feedback","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-13T20:46:42Z","updated_at":"2017-01-14T07:17:08Z","closed_at":null,"body":"\r\nRight now the styling of menus that contain 'lists' is a bit of a mess. It's inconsistent and doesn't have a 'clean' look about it. \r\n\r\nI would like to propose that we use bootstrap` list-group` and `media-list` for all menus that contain lists. \r\nThis means, the online menu, news categories, all the 'latest' menus, comments menu, forum post menu etc etc. everything.  The chatbox and a few others are already doing this. \r\n\r\nWhen there is only text we would use 'list-group' and when there are images, we would use 'media-list'. \r\n\r\nI would like to open the discussion to e107 theme developers to get their feedback on this proposal. \r\nHow might it impact existing themes, break old themes etc etc?\r\nDo you have other ideas relating to consistent bootstrap markup of menu lists?\r\n\r\nFor reference.. here are the 2 list styles I'm referring to: \r\n\r\n## List Group\r\n\r\n![list-group](https://cloud.githubusercontent.com/assets/2825679/21944997/c933c07a-d98d-11e6-81db-1cd2d8a97967.png)\r\n\r\n![media-list](https://cloud.githubusercontent.com/assets/2825679/21945001/d11e843c-d98d-11e6-85bb-f60fdc1becee.png)\r\n\r\n\r\n \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/e107inc/e107/issues/comments/272607574","html_url":"https://github.com/e107inc/e107/issues/2272#issuecomment-272607574","issue_url":"https://api.github.com/repos/e107inc/e107/issues/2272","id":272607574,"user":{"login":"Jimmi08","id":5429548,"avatar_url":"https://avatars.githubusercontent.com/u/5429548?v=3","gravatar_id":"","url":"https://api.github.com/users/Jimmi08","html_url":"https://github.com/Jimmi08","followers_url":"https://api.github.com/users/Jimmi08/followers","following_url":"https://api.github.com/users/Jimmi08/following{/other_user}","gists_url":"https://api.github.com/users/Jimmi08/gists{/gist_id}","starred_url":"https://api.github.com/users/Jimmi08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jimmi08/subscriptions","organizations_url":"https://api.github.com/users/Jimmi08/orgs","repos_url":"https://api.github.com/users/Jimmi08/repos","events_url":"https://api.github.com/users/Jimmi08/events{/privacy}","received_events_url":"https://api.github.com/users/Jimmi08/received_events","type":"User","site_admin":false},"created_at":"2017-01-14T07:17:08Z","updated_at":"2017-01-14T07:17:08Z","body":"My two cents.  _(I know that I can do it other way)._\r\n1. good idea, full support, but there should be version with BOOTSTRAP constant defined or not.  And to make it perfect - make version just for bootstrap 3.  Using classes from bootstrap 4  together (list-group-item-action with list-group-item)  like you did it with BT2 is workaround. \r\n \r\n2. next rule: each ul tag should have its own selector/class (maybe the same as you use in tablerender() as id). With unique selector and common class (media-list) you can style almost anything.  I think that this is already done with classes, just don't remove it (at least in online menu and last seen menu)\r\n\r\n3. without bootstrap it looks like this (so no problem):\r\n![image](https://cloud.githubusercontent.com/assets/5429548/21952979/f4f04e92-da2b-11e6-9803-e17eb2e22db7.png)\r\n\r\n4. you could consider something like this (it's screen from e107 rules for old table layout. It's not mine. I am sure that there were some Dutch/French pdf for templating or something like this too)\r\nNow you use panel, panel-heading and panel-body. But adding custom and standard e107 classes would be add possibility to styling panels in menus without influence on other place that are using panels. I mean using panel.menu{} etc. (I would use f.e e107_menu etc)\r\n![image](https://cloud.githubusercontent.com/assets/5429548/21953043/b84cabdc-da2d-11e6-9ad7-b0f72af2288a.png)\r\nSo standard using would look like this:   \r\n```\r\n\tif($style == 'menu')\r\n\t{\r\n\techo '<div class=\"panel panel-default menu\">\r\n\t  <div class=\"panel-heading menu-caption\">'.$caption.'</div>\r\n\t  <div class=\"panel-body menu-text\">\r\n\t   '.$text.'\r\n\t  </div>\r\n\t</div>';\r\n\treturn;\t\t\r\n\t}\r\n```\t\r\n\r\n"}}
{"actor":{"display_login":"Jimmi08"}}