{"action":"created","issue":{"url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/26","repository_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react","labels_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/26/comments","events_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/26/events","html_url":"https://github.com/carbon-design-system/carbon-components-react/issues/26","id":235702891,"number":26,"title":"Module Header has changed","user":{"login":"jzhang300","id":1449523,"avatar_url":"https://avatars1.githubusercontent.com/u/1449523?v=3","gravatar_id":"","url":"https://api.github.com/users/jzhang300","html_url":"https://github.com/jzhang300","followers_url":"https://api.github.com/users/jzhang300/followers","following_url":"https://api.github.com/users/jzhang300/following{/other_user}","gists_url":"https://api.github.com/users/jzhang300/gists{/gist_id}","starred_url":"https://api.github.com/users/jzhang300/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jzhang300/subscriptions","organizations_url":"https://api.github.com/users/jzhang300/orgs","repos_url":"https://api.github.com/users/jzhang300/repos","events_url":"https://api.github.com/users/jzhang300/events{/privacy}","received_events_url":"https://api.github.com/users/jzhang300/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-13T21:47:28Z","updated_at":"2017-06-13T22:24:05Z","closed_at":null,"body":"Module Header used to be a container section \r\n![screen shot 2017-06-13 at 4 19 51 pm](https://user-images.githubusercontent.com/1449523/27105155-2c33019e-5054-11e7-8595-300ca4d5e93c.jpg)\r\n\r\nNow it's wrapping the children inside of an `<h1>`\r\n![screen shot 2017-06-13 at 4 21 49 pm](https://user-images.githubusercontent.com/1449523/27105251-7ed952b8-5054-11e7-9ebb-f2af84af2d5d.jpg)\r\n\r\nThe component should be open to flexibility.\r\nMost of the time it's just going to be a normal h1, but sometimes additional UI will be introduced like buttons and such.\r\n\r\n---\r\n\r\n- [ ] make ModuleHeader component flexible for html children"},"comment":{"url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/comments/308266212","html_url":"https://github.com/carbon-design-system/carbon-components-react/issues/26#issuecomment-308266212","issue_url":"https://api.github.com/repos/carbon-design-system/carbon-components-react/issues/26","id":308266212,"user":{"login":"hellobrian","id":4185382,"avatar_url":"https://avatars0.githubusercontent.com/u/4185382?v=3","gravatar_id":"","url":"https://api.github.com/users/hellobrian","html_url":"https://github.com/hellobrian","followers_url":"https://api.github.com/users/hellobrian/followers","following_url":"https://api.github.com/users/hellobrian/following{/other_user}","gists_url":"https://api.github.com/users/hellobrian/gists{/gist_id}","starred_url":"https://api.github.com/users/hellobrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hellobrian/subscriptions","organizations_url":"https://api.github.com/users/hellobrian/orgs","repos_url":"https://api.github.com/users/hellobrian/repos","events_url":"https://api.github.com/users/hellobrian/events{/privacy}","received_events_url":"https://api.github.com/users/hellobrian/received_events","type":"User","site_admin":false},"created_at":"2017-06-13T22:24:05Z","updated_at":"2017-06-13T22:24:05Z","body":"Thanks for pointing this out.\r\n\r\nAlso, we also recognize that we shouldn't  be using `<h1>` and other heading tags in our components for visual styling since it can lead to confusing screen-reader navigation (see https://github.com/carbon-design-system/carbon-components/pull/154#issue-233643947 for more details). \r\n\r\nIf no one assigns themselves to this in time, feel free to assign yourself to this issue and submit a PR. "}}
{"actor":{"display_login":"hellobrian"}}