{"action":"created","issue":{"url":"https://api.github.com/repos/sigma-dev/sigma/issues/138","repository_url":"https://api.github.com/repos/sigma-dev/sigma","labels_url":"https://api.github.com/repos/sigma-dev/sigma/issues/138/labels{/name}","comments_url":"https://api.github.com/repos/sigma-dev/sigma/issues/138/comments","events_url":"https://api.github.com/repos/sigma-dev/sigma/issues/138/events","html_url":"https://github.com/sigma-dev/sigma/pull/138","id":234566984,"number":138,"title":"Tasker overhaul","user":{"login":"meganokeefe","id":3137106,"avatar_url":"https://avatars3.githubusercontent.com/u/3137106?v=3","gravatar_id":"","url":"https://api.github.com/users/meganokeefe","html_url":"https://github.com/meganokeefe","followers_url":"https://api.github.com/users/meganokeefe/followers","following_url":"https://api.github.com/users/meganokeefe/following{/other_user}","gists_url":"https://api.github.com/users/meganokeefe/gists{/gist_id}","starred_url":"https://api.github.com/users/meganokeefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meganokeefe/subscriptions","organizations_url":"https://api.github.com/users/meganokeefe/orgs","repos_url":"https://api.github.com/users/meganokeefe/repos","events_url":"https://api.github.com/users/meganokeefe/events{/privacy}","received_events_url":"https://api.github.com/users/meganokeefe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-08T15:30:19Z","updated_at":"2017-06-12T21:49:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/sigma-dev/sigma/pulls/138","html_url":"https://github.com/sigma-dev/sigma/pull/138","diff_url":"https://github.com/sigma-dev/sigma/pull/138.diff","patch_url":"https://github.com/sigma-dev/sigma/pull/138.patch"},"body":"Closes #129. \r\n\r\n## Changelog \r\n- [x] Removed `Tasker.Logs()`, `Tasker.Progress()`, and `Tasker.Outputs()`. Instead, now NomadTasker and DockerTasker both \"ship\" all three to the Sigma API --> DB. This removes NomadTasker's database dependency and standardizes the two Taskers.\r\n- [x] Removed the `Shipper` struct and instead have isolated `ServiceOperation.Logs` into their own struct. `Progress` and  the raw string`Outputs` now live inside a `ServiceOperation`. \r\n- [x] ADD and GET API endpoints/functions for `Progress`, `Logs`, `Outputs`. All 3 have the url structure: `v1/services/<service-id>/op/<service-op-id>/logs`. (replace `logs` with `progress` or `outputs`). \r\n- [x] Updated database, model to reflect these changes \r\n- [x] Instead of calling `Tasker.Progress()`, etc., Manager now calls `Ship()` to get stuff into the DB so that on its next loop, ServiceOperations/ServiceOperationLogs have logs, progress, output.\r\n\r\n- [x] refactored the server API tests \r\n- [x] updated Tasker tests (unit and integration) \r\n- [x] updated Manager tests (unit and integration) \r\n\r\n\r\n## TODO \r\n\r\nLogs will eventually become a problem here, given their size. Eventually, we should consider piping them into some log aggregation system VS. storing all serviceOp logs in couchbase. Put out an issue for this. #133 "},"comment":{"url":"https://api.github.com/repos/sigma-dev/sigma/issues/comments/307940585","html_url":"https://github.com/sigma-dev/sigma/pull/138#issuecomment-307940585","issue_url":"https://api.github.com/repos/sigma-dev/sigma/issues/138","id":307940585,"user":{"login":"mikeynap","id":704427,"avatar_url":"https://avatars3.githubusercontent.com/u/704427?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeynap","html_url":"https://github.com/mikeynap","followers_url":"https://api.github.com/users/mikeynap/followers","following_url":"https://api.github.com/users/mikeynap/following{/other_user}","gists_url":"https://api.github.com/users/mikeynap/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeynap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeynap/subscriptions","organizations_url":"https://api.github.com/users/mikeynap/orgs","repos_url":"https://api.github.com/users/mikeynap/repos","events_url":"https://api.github.com/users/mikeynap/events{/privacy}","received_events_url":"https://api.github.com/users/mikeynap/received_events","type":"User","site_admin":false},"created_at":"2017-06-12T21:49:22Z","updated_at":"2017-06-12T21:49:22Z","body":"It sorta is unfortunate that this is gonna use the raw API, since now we have to worry about authentication. \r\n\r\nWe'll have to talk about what is the best way to address this -- both nomad && docker will both need to get JWT tokens to post to the API. We should have some sorta abstraction in place for that."}}
{"actor":{"display_login":"mikeynap"}}