{"action":"created","issue":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/23783","repository_url":"https://api.github.com/repos/twbs/bootstrap","labels_url":"https://api.github.com/repos/twbs/bootstrap/issues/23783/labels{/name}","comments_url":"https://api.github.com/repos/twbs/bootstrap/issues/23783/comments","events_url":"https://api.github.com/repos/twbs/bootstrap/issues/23783/events","html_url":"https://github.com/twbs/bootstrap/pull/23783","id":254460950,"number":23783,"title":"Increases clickable area of the close btn on modals","user":{"login":"andresgalante","id":1832037,"avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"labels":[{"id":210556,"url":"https://api.github.com/repos/twbs/bootstrap/labels/css","name":"css","color":"563d7c","default":false},{"id":250176882,"url":"https://api.github.com/repos/twbs/bootstrap/labels/v4","name":"v4","color":"563d7c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-31T20:39:08Z","updated_at":"2017-09-01T11:32:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/twbs/bootstrap/pulls/23783","html_url":"https://github.com/twbs/bootstrap/pull/23783","diff_url":"https://github.com/twbs/bootstrap/pull/23783.diff","patch_url":"https://github.com/twbs/bootstrap/pull/23783.patch"},"body":"On alerts we increase the clickable area of the close btns to make them easier to click on devices where the pointer is coarse and improve accessibility.\r\n\r\nThis PR does 2 things:\r\n\r\n1- Introduces the same concept for modals.\r\n1- Changes the `align-items` to `flex-start` so the close btn always stays on the upper right corner when the `modal-title` text wraps.\r\n\r\nI am not sure if this should be a global change on _close.scss\r\n\r\nWhat do you think?\r\n"},"comment":{"url":"https://api.github.com/repos/twbs/bootstrap/issues/comments/326558024","html_url":"https://github.com/twbs/bootstrap/pull/23783#issuecomment-326558024","issue_url":"https://api.github.com/repos/twbs/bootstrap/issues/23783","id":326558024,"user":{"login":"andresgalante","id":1832037,"avatar_url":"https://avatars1.githubusercontent.com/u/1832037?v=4","gravatar_id":"","url":"https://api.github.com/users/andresgalante","html_url":"https://github.com/andresgalante","followers_url":"https://api.github.com/users/andresgalante/followers","following_url":"https://api.github.com/users/andresgalante/following{/other_user}","gists_url":"https://api.github.com/users/andresgalante/gists{/gist_id}","starred_url":"https://api.github.com/users/andresgalante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andresgalante/subscriptions","organizations_url":"https://api.github.com/users/andresgalante/orgs","repos_url":"https://api.github.com/users/andresgalante/repos","events_url":"https://api.github.com/users/andresgalante/events{/privacy}","received_events_url":"https://api.github.com/users/andresgalante/received_events","type":"User","site_admin":false},"created_at":"2017-09-01T11:32:22Z","updated_at":"2017-09-01T11:32:22Z","author_association":"CONTRIBUTOR","body":"@mdo sure! here is the bug:\r\nhttps://codepen.io/andresgalante/pen/NvopBJ?editors=1100\r\n\r\n- close btn \"X\" centers instead of  been top right\r\n- the x btn click are is smaller than a finger.\r\n\r\nHere is the solution:\r\nhttps://codepen.io/andresgalante/pen/MvLpZw?editors=1100\r\n\r\n- The close btn in the top right corner\r\n- the click area is larger\r\n\r\nWhat do you you think?"}}
{"actor":{"display_login":"andresgalante"}}