{"action":"created","comment":{"url":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/comments/148022068","pull_request_review_id":73199931,"id":148022068,"diff_hunk":"@@ -70,27 +71,65 @@ export const getGroupUsers = (req, res) => {\n   const groupId = req.params.groupId;\n   const ref = firebase.database().ref(`group/${groupId}/users`);\n   const ref1 = firebase.database().ref().child('users');\n-  ref.once('value', (data) => {\n-    const groupUsers = data.val();\n+\n+  ref.once('value', (users) => {\n+    const groupUsers = users.val();\n     if (groupUsers === null) {\n-      res.status(404)\n-        .send('This group has no user yet!');\n+      res.status(200)\n+        .send({ message: 'This group has no user yet!' });\n+    } else {\n+      const newArr = getArray(groupUsers);\n+      ref1.once('value', (users2) => {\n+        const usersGotten = users2.val();\n+        if (users2 !== null) {\n+          const allUsers = getArray(usersGotten);\n+          const filtered = allUsers.filter(userInAllUsers => newArr.some(\n+            userInGroup => userInAllUsers.id === userInGroup.id),\n+          );","path":"server/controllers/groups.js","position":90,"original_position":90,"commit_id":"6ce6ccec1e9283aa519946a3047f43c951c40339","original_commit_id":"6ce6ccec1e9283aa519946a3047f43c951c40339","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Unexpected newline before ')'                                  function-paren-newline","created_at":"2017-10-31T14:57:57Z","updated_at":"2017-10-31T14:57:58Z","html_url":"https://github.com/Dannytebj/post-it-app/pull/59#discussion_r148022068","pull_request_url":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/59","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/comments/148022068"},"html":{"href":"https://github.com/Dannytebj/post-it-app/pull/59#discussion_r148022068"},"pull_request":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/59","id":149804667,"html_url":"https://github.com/Dannytebj/post-it-app/pull/59","diff_url":"https://github.com/Dannytebj/post-it-app/pull/59.diff","patch_url":"https://github.com/Dannytebj/post-it-app/pull/59.patch","issue_url":"https://api.github.com/repos/Dannytebj/post-it-app/issues/59","number":59,"state":"open","locked":false,"title":"Ft client tests","user":{"login":"Dannytebj","id":25308231,"avatar_url":"https://avatars0.githubusercontent.com/u/25308231?v=4","gravatar_id":"","url":"https://api.github.com/users/Dannytebj","html_url":"https://github.com/Dannytebj","followers_url":"https://api.github.com/users/Dannytebj/followers","following_url":"https://api.github.com/users/Dannytebj/following{/other_user}","gists_url":"https://api.github.com/users/Dannytebj/gists{/gist_id}","starred_url":"https://api.github.com/users/Dannytebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dannytebj/subscriptions","organizations_url":"https://api.github.com/users/Dannytebj/orgs","repos_url":"https://api.github.com/users/Dannytebj/repos","events_url":"https://api.github.com/users/Dannytebj/events{/privacy}","received_events_url":"https://api.github.com/users/Dannytebj/received_events","type":"User","site_admin":false},"body":"### What Does This PR Do?\r\n- It adds Client-side Test\r\n- Add Code Climate file\r\n- Implement some feedbacks","created_at":"2017-10-31T14:39:08Z","updated_at":"2017-10-31T14:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f4f06cdb6e6301bfb1dbb2d8155217cb80ca21b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/59/commits","review_comments_url":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/59/comments","review_comment_url":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Dannytebj/post-it-app/issues/59/comments","statuses_url":"https://api.github.com/repos/Dannytebj/post-it-app/statuses/6ce6ccec1e9283aa519946a3047f43c951c40339","head":{"label":"Dannytebj:ft-Client-Tests","ref":"ft-Client-Tests","sha":"6ce6ccec1e9283aa519946a3047f43c951c40339","user":{"login":"Dannytebj","id":25308231,"avatar_url":"https://avatars0.githubusercontent.com/u/25308231?v=4","gravatar_id":"","url":"https://api.github.com/users/Dannytebj","html_url":"https://github.com/Dannytebj","followers_url":"https://api.github.com/users/Dannytebj/followers","following_url":"https://api.github.com/users/Dannytebj/following{/other_user}","gists_url":"https://api.github.com/users/Dannytebj/gists{/gist_id}","starred_url":"https://api.github.com/users/Dannytebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dannytebj/subscriptions","organizations_url":"https://api.github.com/users/Dannytebj/orgs","repos_url":"https://api.github.com/users/Dannytebj/repos","events_url":"https://api.github.com/users/Dannytebj/events{/privacy}","received_events_url":"https://api.github.com/users/Dannytebj/received_events","type":"User","site_admin":false},"repo":{"id":91925595,"name":"post-it-app","full_name":"Dannytebj/post-it-app","owner":{"login":"Dannytebj","id":25308231,"avatar_url":"https://avatars0.githubusercontent.com/u/25308231?v=4","gravatar_id":"","url":"https://api.github.com/users/Dannytebj","html_url":"https://github.com/Dannytebj","followers_url":"https://api.github.com/users/Dannytebj/followers","following_url":"https://api.github.com/users/Dannytebj/following{/other_user}","gists_url":"https://api.github.com/users/Dannytebj/gists{/gist_id}","starred_url":"https://api.github.com/users/Dannytebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dannytebj/subscriptions","organizations_url":"https://api.github.com/users/Dannytebj/orgs","repos_url":"https://api.github.com/users/Dannytebj/repos","events_url":"https://api.github.com/users/Dannytebj/events{/privacy}","received_events_url":"https://api.github.com/users/Dannytebj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dannytebj/post-it-app","description":"PostIt is a simple application that allows friends and colleagues create groups for notifications.","fork":false,"url":"https://api.github.com/repos/Dannytebj/post-it-app","forks_url":"https://api.github.com/repos/Dannytebj/post-it-app/forks","keys_url":"https://api.github.com/repos/Dannytebj/post-it-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dannytebj/post-it-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dannytebj/post-it-app/teams","hooks_url":"https://api.github.com/repos/Dannytebj/post-it-app/hooks","issue_events_url":"https://api.github.com/repos/Dannytebj/post-it-app/issues/events{/number}","events_url":"https://api.github.com/repos/Dannytebj/post-it-app/events","assignees_url":"https://api.github.com/repos/Dannytebj/post-it-app/assignees{/user}","branches_url":"https://api.github.com/repos/Dannytebj/post-it-app/branches{/branch}","tags_url":"https://api.github.com/repos/Dannytebj/post-it-app/tags","blobs_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dannytebj/post-it-app/statuses/{sha}","languages_url":"https://api.github.com/repos/Dannytebj/post-it-app/languages","stargazers_url":"https://api.github.com/repos/Dannytebj/post-it-app/stargazers","contributors_url":"https://api.github.com/repos/Dannytebj/post-it-app/contributors","subscribers_url":"https://api.github.com/repos/Dannytebj/post-it-app/subscribers","subscription_url":"https://api.github.com/repos/Dannytebj/post-it-app/subscription","commits_url":"https://api.github.com/repos/Dannytebj/post-it-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dannytebj/post-it-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dannytebj/post-it-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dannytebj/post-it-app/contents/{+path}","compare_url":"https://api.github.com/repos/Dannytebj/post-it-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dannytebj/post-it-app/merges","archive_url":"https://api.github.com/repos/Dannytebj/post-it-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dannytebj/post-it-app/downloads","issues_url":"https://api.github.com/repos/Dannytebj/post-it-app/issues{/number}","pulls_url":"https://api.github.com/repos/Dannytebj/post-it-app/pulls{/number}","milestones_url":"https://api.github.com/repos/Dannytebj/post-it-app/milestones{/number}","notifications_url":"https://api.github.com/repos/Dannytebj/post-it-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dannytebj/post-it-app/labels{/name}","releases_url":"https://api.github.com/repos/Dannytebj/post-it-app/releases{/id}","deployments_url":"https://api.github.com/repos/Dannytebj/post-it-app/deployments","created_at":"2017-05-21T01:14:10Z","updated_at":"2017-05-21T01:14:10Z","pushed_at":"2017-10-31T14:57:03Z","git_url":"git://github.com/Dannytebj/post-it-app.git","ssh_url":"git@github.com:Dannytebj/post-it-app.git","clone_url":"https://github.com/Dannytebj/post-it-app.git","svn_url":"https://github.com/Dannytebj/post-it-app","homepage":null,"size":31686,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"Dannytebj:dev1","ref":"dev1","sha":"b78c46b62854431eb6b61287b8aa6216f05289e0","user":{"login":"Dannytebj","id":25308231,"avatar_url":"https://avatars0.githubusercontent.com/u/25308231?v=4","gravatar_id":"","url":"https://api.github.com/users/Dannytebj","html_url":"https://github.com/Dannytebj","followers_url":"https://api.github.com/users/Dannytebj/followers","following_url":"https://api.github.com/users/Dannytebj/following{/other_user}","gists_url":"https://api.github.com/users/Dannytebj/gists{/gist_id}","starred_url":"https://api.github.com/users/Dannytebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dannytebj/subscriptions","organizations_url":"https://api.github.com/users/Dannytebj/orgs","repos_url":"https://api.github.com/users/Dannytebj/repos","events_url":"https://api.github.com/users/Dannytebj/events{/privacy}","received_events_url":"https://api.github.com/users/Dannytebj/received_events","type":"User","site_admin":false},"repo":{"id":91925595,"name":"post-it-app","full_name":"Dannytebj/post-it-app","owner":{"login":"Dannytebj","id":25308231,"avatar_url":"https://avatars0.githubusercontent.com/u/25308231?v=4","gravatar_id":"","url":"https://api.github.com/users/Dannytebj","html_url":"https://github.com/Dannytebj","followers_url":"https://api.github.com/users/Dannytebj/followers","following_url":"https://api.github.com/users/Dannytebj/following{/other_user}","gists_url":"https://api.github.com/users/Dannytebj/gists{/gist_id}","starred_url":"https://api.github.com/users/Dannytebj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dannytebj/subscriptions","organizations_url":"https://api.github.com/users/Dannytebj/orgs","repos_url":"https://api.github.com/users/Dannytebj/repos","events_url":"https://api.github.com/users/Dannytebj/events{/privacy}","received_events_url":"https://api.github.com/users/Dannytebj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Dannytebj/post-it-app","description":"PostIt is a simple application that allows friends and colleagues create groups for notifications.","fork":false,"url":"https://api.github.com/repos/Dannytebj/post-it-app","forks_url":"https://api.github.com/repos/Dannytebj/post-it-app/forks","keys_url":"https://api.github.com/repos/Dannytebj/post-it-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Dannytebj/post-it-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Dannytebj/post-it-app/teams","hooks_url":"https://api.github.com/repos/Dannytebj/post-it-app/hooks","issue_events_url":"https://api.github.com/repos/Dannytebj/post-it-app/issues/events{/number}","events_url":"https://api.github.com/repos/Dannytebj/post-it-app/events","assignees_url":"https://api.github.com/repos/Dannytebj/post-it-app/assignees{/user}","branches_url":"https://api.github.com/repos/Dannytebj/post-it-app/branches{/branch}","tags_url":"https://api.github.com/repos/Dannytebj/post-it-app/tags","blobs_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Dannytebj/post-it-app/statuses/{sha}","languages_url":"https://api.github.com/repos/Dannytebj/post-it-app/languages","stargazers_url":"https://api.github.com/repos/Dannytebj/post-it-app/stargazers","contributors_url":"https://api.github.com/repos/Dannytebj/post-it-app/contributors","subscribers_url":"https://api.github.com/repos/Dannytebj/post-it-app/subscribers","subscription_url":"https://api.github.com/repos/Dannytebj/post-it-app/subscription","commits_url":"https://api.github.com/repos/Dannytebj/post-it-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/Dannytebj/post-it-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/Dannytebj/post-it-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/Dannytebj/post-it-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/Dannytebj/post-it-app/contents/{+path}","compare_url":"https://api.github.com/repos/Dannytebj/post-it-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Dannytebj/post-it-app/merges","archive_url":"https://api.github.com/repos/Dannytebj/post-it-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Dannytebj/post-it-app/downloads","issues_url":"https://api.github.com/repos/Dannytebj/post-it-app/issues{/number}","pulls_url":"https://api.github.com/repos/Dannytebj/post-it-app/pulls{/number}","milestones_url":"https://api.github.com/repos/Dannytebj/post-it-app/milestones{/number}","notifications_url":"https://api.github.com/repos/Dannytebj/post-it-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Dannytebj/post-it-app/labels{/name}","releases_url":"https://api.github.com/repos/Dannytebj/post-it-app/releases{/id}","deployments_url":"https://api.github.com/repos/Dannytebj/post-it-app/deployments","created_at":"2017-05-21T01:14:10Z","updated_at":"2017-05-21T01:14:10Z","pushed_at":"2017-10-31T14:57:03Z","git_url":"git://github.com/Dannytebj/post-it-app.git","ssh_url":"git@github.com:Dannytebj/post-it-app.git","clone_url":"https://github.com/Dannytebj/post-it-app.git","svn_url":"https://github.com/Dannytebj/post-it-app","homepage":null,"size":31686,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/59"},"html":{"href":"https://github.com/Dannytebj/post-it-app/pull/59"},"issue":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/issues/59"},"comments":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/Dannytebj/post-it-app/statuses/6ce6ccec1e9283aa519946a3047f43c951c40339"}},"author_association":"OWNER"}}
{"actor":{"display_login":"houndci-bot"}}