{"action":"created","issue":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/1567","repository_url":"https://api.github.com/repos/freedomofpress/securedrop","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/1567/labels{/name}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/1567/comments","events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/1567/events","html_url":"https://github.com/freedomofpress/securedrop/pull/1567","id":206146083,"number":1567,"title":"Update security slider instructions and source interface icons","user":{"login":"redshiftzero","id":7832803,"avatar_url":"https://avatars.githubusercontent.com/u/7832803?v=3","gravatar_id":"","url":"https://api.github.com/users/redshiftzero","html_url":"https://github.com/redshiftzero","followers_url":"https://api.github.com/users/redshiftzero/followers","following_url":"https://api.github.com/users/redshiftzero/following{/other_user}","gists_url":"https://api.github.com/users/redshiftzero/gists{/gist_id}","starred_url":"https://api.github.com/users/redshiftzero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redshiftzero/subscriptions","organizations_url":"https://api.github.com/users/redshiftzero/orgs","repos_url":"https://api.github.com/users/redshiftzero/repos","events_url":"https://api.github.com/users/redshiftzero/events{/privacy}","received_events_url":"https://api.github.com/users/redshiftzero/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2017-02-08T09:53:08Z","updated_at":"2017-02-10T20:43:18Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/1567","html_url":"https://github.com/freedomofpress/securedrop/pull/1567","diff_url":"https://github.com/freedomofpress/securedrop/pull/1567.diff","patch_url":"https://github.com/freedomofpress/securedrop/pull/1567.patch"},"body":"In #1480, I removed Font Awesome icons from the source interface in order to direct sources to use Tor Browser's security slider without seeing breakage or weirdness. However, @micahflee noticed that since that PR was merged 1) the UI has changed - requiring an update to the instructions on the source interface and documentation and 2) the SVG icons used to replace Font Awesome also no longer work. Also the hover over effects did not work for the icons.\r\n\r\nI've cherry-picked the commits from #1480 and follow-up PR #1522 and added commits to address the above issues in this PR, updating the docs and source interface and replacing the SVGs with PNGs. The rollover effects are back through some hacky CSS to change the image displayed on hover:\r\n\r\n![style_3_11](https://cloud.githubusercontent.com/assets/7832803/22731466/9fff7e80-ed9f-11e6-8759-1571ba949477.gif)\r\n\r\nImportant note: This PR _does not_ update `/etc/apparmor.d/usr.sbin/apache2`, also noted by @micahflee as a problem. "},"comment":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments/279060640","html_url":"https://github.com/freedomofpress/securedrop/pull/1567#issuecomment-279060640","issue_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/1567","id":279060640,"user":{"login":"ninavizz","id":8262612,"avatar_url":"https://avatars.githubusercontent.com/u/8262612?v=3","gravatar_id":"","url":"https://api.github.com/users/ninavizz","html_url":"https://github.com/ninavizz","followers_url":"https://api.github.com/users/ninavizz/followers","following_url":"https://api.github.com/users/ninavizz/following{/other_user}","gists_url":"https://api.github.com/users/ninavizz/gists{/gist_id}","starred_url":"https://api.github.com/users/ninavizz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ninavizz/subscriptions","organizations_url":"https://api.github.com/users/ninavizz/orgs","repos_url":"https://api.github.com/users/ninavizz/repos","events_url":"https://api.github.com/users/ninavizz/events{/privacy}","received_events_url":"https://api.github.com/users/ninavizz/received_events","type":"User","site_admin":false},"created_at":"2017-02-10T20:43:18Z","updated_at":"2017-02-10T20:43:18Z","body":"@conorsch Coolio, I figured! Thanks for taking the time to respond, tho. :) \r\n\r\nFor future iterative releases, my lone request will then be to still include \"erase existing text, replace with newly composed text\" fixes. Content is a much bigger part of ux than most folks realize—hence, most of my \"usability bottleneck\" recommendations for the website, being content (and not design or UI per-se). \r\n\r\nI'm working with @justintroutman to develop a processes through which UX/UI changes can be iteratively scoped-in to releases as a general, ongoing-thing... but since editing exiting text strings creates the least amount of things changed that can then break QA, I'd love to see things like that included into +0.4.1, etc. I realize my last-minute request for this release include(d) some CSS mandatory changes too, tho, and that every little change puts QA at risk.\r\n\r\nAnd, yes: it's on me/Justin to devise a way to most clearly make those changes clear to contributing devs, here in GitHub. And heck, once I'm more comfortable doing PRs, I should be able to make many of those changes on my own, too! "}}
{"actor":{"display_login":"ninavizz"}}