{"action":"created","issue":{"url":"https://api.github.com/repos/koreader/koreader/issues/2898","repository_url":"https://api.github.com/repos/koreader/koreader","labels_url":"https://api.github.com/repos/koreader/koreader/issues/2898/labels{/name}","comments_url":"https://api.github.com/repos/koreader/koreader/issues/2898/comments","events_url":"https://api.github.com/repos/koreader/koreader/issues/2898/events","html_url":"https://github.com/koreader/koreader/issues/2898","id":228821769,"number":2898,"title":"FR: Add confirmation to Power off/Reboot the device","user":{"login":"a-kohout","id":26367956,"avatar_url":"https://avatars3.githubusercontent.com/u/26367956?v=3","gravatar_id":"","url":"https://api.github.com/users/a-kohout","html_url":"https://github.com/a-kohout","followers_url":"https://api.github.com/users/a-kohout/followers","following_url":"https://api.github.com/users/a-kohout/following{/other_user}","gists_url":"https://api.github.com/users/a-kohout/gists{/gist_id}","starred_url":"https://api.github.com/users/a-kohout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-kohout/subscriptions","organizations_url":"https://api.github.com/users/a-kohout/orgs","repos_url":"https://api.github.com/users/a-kohout/repos","events_url":"https://api.github.com/users/a-kohout/events{/privacy}","received_events_url":"https://api.github.com/users/a-kohout/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-05-15T19:39:43Z","updated_at":"2017-05-15T20:01:14Z","closed_at":null,"body":"* KOReader version: v2015.11-1038-g474c011\r\n* Device: Kobo Glo HD\r\n\r\n#### Issue\r\nConsider adding a confirmation dialog to the newly added \"Power off\" and \"Reboot the device\"\r\nactions. Accidentally invoking either one is super annoying. \r\nAn option to disable these entries altogether would be great as well.\r\n\r\n#### Steps to reproduce\r\n"},"comment":{"url":"https://api.github.com/repos/koreader/koreader/issues/comments/301587960","html_url":"https://github.com/koreader/koreader/issues/2898#issuecomment-301587960","issue_url":"https://api.github.com/repos/koreader/koreader/issues/2898","id":301587960,"user":{"login":"Frenzie","id":202757,"avatar_url":"https://avatars1.githubusercontent.com/u/202757?v=3","gravatar_id":"","url":"https://api.github.com/users/Frenzie","html_url":"https://github.com/Frenzie","followers_url":"https://api.github.com/users/Frenzie/followers","following_url":"https://api.github.com/users/Frenzie/following{/other_user}","gists_url":"https://api.github.com/users/Frenzie/gists{/gist_id}","starred_url":"https://api.github.com/users/Frenzie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Frenzie/subscriptions","organizations_url":"https://api.github.com/users/Frenzie/orgs","repos_url":"https://api.github.com/users/Frenzie/repos","events_url":"https://api.github.com/users/Frenzie/events{/privacy}","received_events_url":"https://api.github.com/users/Frenzie/received_events","type":"User","site_admin":false},"created_at":"2017-05-15T20:01:14Z","updated_at":"2017-05-15T20:01:14Z","body":"Disabling is already present through the menu customization option, although that's currently still potentially a bit user-unfriendly. You'd have to create `settings/filemanager_menu_order.lua` and `settings/reader_menu_order.lua`.\r\n\r\n```lua\r\nreturn {\r\n    [\"main\"] = {\r\n        \"history\",\r\n        \"book_status\",\r\n        \"----------------------------\",\r\n        \"ota_update\", --[[ if Device:isKindle() or Device:isKobo() or\r\n                           Device:isPocketBook() or Device:isAndroid() ]]--\r\n        \"version\",\r\n        \"help\",\r\n        \"system_statistics\",\r\n        --\"----------------------------\",\r\n        --\"poweroff\", -- if Device:isKobo()\r\n        --\"reboot\",   -- if Device:isKobo()\r\n        --\"----------------------------\",\r\n        \"exit\",\r\n        -- I commented out the undesired menu entries for demonstration purposes\r\n    },\r\n    [\"KOMenu:disabled\"] = {\r\n        \"poweroff\",\r\n        \"reboot\",\r\n    }\r\n}\r\n```\r\n\r\nI already brought up confirmation in #2873, so I agree on that one."}}
{"actor":{"display_login":"Frenzie"}}