{"action":"opened","number":1712,"pull_request":{"url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls/1712","id":151012088,"html_url":"https://github.com/WhisperSystems/Signal-Desktop/pull/1712","diff_url":"https://github.com/WhisperSystems/Signal-Desktop/pull/1712.diff","patch_url":"https://github.com/WhisperSystems/Signal-Desktop/pull/1712.patch","issue_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/1712","number":1712,"state":"open","locked":false,"title":"Export fixes, tracking export metrics, show new versions in log","user":{"login":"scottnonnenberg","id":443005,"avatar_url":"https://avatars2.githubusercontent.com/u/443005?v=4","gravatar_id":"","url":"https://api.github.com/users/scottnonnenberg","html_url":"https://github.com/scottnonnenberg","followers_url":"https://api.github.com/users/scottnonnenberg/followers","following_url":"https://api.github.com/users/scottnonnenberg/following{/other_user}","gists_url":"https://api.github.com/users/scottnonnenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/scottnonnenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottnonnenberg/subscriptions","organizations_url":"https://api.github.com/users/scottnonnenberg/orgs","repos_url":"https://api.github.com/users/scottnonnenberg/repos","events_url":"https://api.github.com/users/scottnonnenberg/events{/privacy}","received_events_url":"https://api.github.com/users/scottnonnenberg/received_events","type":"User","site_admin":false},"body":"To get a better handle on the export issues we're dealing with, we now continue on with the export even if we run into an attachment or malformed `messages.json`. We count up how many problems we encounter, then report that at the end of the process. If non-zero, we consider the whole export failed, but there's useful metrics in the log.\r\n\r\nFor the `Illegal buffer` issue (https://github.com/WhisperSystems/Signal-Desktop/issues/1616), we now attempt to handle these 'strange' pieces of data by first giving them to a `Uint8Array`.\r\n\r\nFor the malformed JSON issue (https://github.com/WhisperSystems/Signal-Desktop/issues/1637), we now verify the structure of every `messages.json` file before considering that conversation export done. However, I discovered that immediate checking of these files found a lot of malformed files - so we first manually wait 10s after we're told that the write is done.\r\n\r\nExport takes quite a bit longer with this change, but should be more reliable.\r\n\r\nLastly, we now log the current version of the app when we detect a version upgrade. Previously we only showed the version were replacing. Because we're releasing new versions pretty frequently, this will help us track things down.","created_at":"2017-11-07T02:41:17Z","updated_at":"2017-11-07T02:41:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls/1712/commits","review_comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls/1712/comments","review_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/1712/comments","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/statuses/62893140bb03ba05be78e67a4333aaf69052ee19","head":{"label":"WhisperSystems:export-fixes","ref":"export-fixes","sha":"62893140bb03ba05be78e67a4333aaf69052ee19","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":17148588,"name":"Signal-Desktop","full_name":"WhisperSystems/Signal-Desktop","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-Desktop","description":"Signal Private Messenger for the Desktop","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/deployments","created_at":"2014-02-24T19:53:36Z","updated_at":"2017-11-07T00:54:31Z","pushed_at":"2017-11-07T02:32:28Z","git_url":"git://github.com/WhisperSystems/Signal-Desktop.git","ssh_url":"git@github.com:WhisperSystems/Signal-Desktop.git","clone_url":"https://github.com/WhisperSystems/Signal-Desktop.git","svn_url":"https://github.com/WhisperSystems/Signal-Desktop","homepage":"https://whispersystems.org","size":52629,"stargazers_count":2692,"watchers_count":2692,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":480,"mirror_url":null,"archived":false,"open_issues_count":342,"forks":480,"open_issues":342,"watchers":2692,"default_branch":"development"}},"base":{"label":"WhisperSystems:chrome","ref":"chrome","sha":"16a376303072521c2d218a96c89c737e66405bd1","user":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":17148588,"name":"Signal-Desktop","full_name":"WhisperSystems/Signal-Desktop","owner":{"login":"WhisperSystems","id":702459,"avatar_url":"https://avatars2.githubusercontent.com/u/702459?v=4","gravatar_id":"","url":"https://api.github.com/users/WhisperSystems","html_url":"https://github.com/WhisperSystems","followers_url":"https://api.github.com/users/WhisperSystems/followers","following_url":"https://api.github.com/users/WhisperSystems/following{/other_user}","gists_url":"https://api.github.com/users/WhisperSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/WhisperSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WhisperSystems/subscriptions","organizations_url":"https://api.github.com/users/WhisperSystems/orgs","repos_url":"https://api.github.com/users/WhisperSystems/repos","events_url":"https://api.github.com/users/WhisperSystems/events{/privacy}","received_events_url":"https://api.github.com/users/WhisperSystems/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WhisperSystems/Signal-Desktop","description":"Signal Private Messenger for the Desktop","fork":false,"url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop","forks_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/forks","keys_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/teams","hooks_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/hooks","issue_events_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/events{/number}","events_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/events","assignees_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/assignees{/user}","branches_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/branches{/branch}","tags_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/tags","blobs_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/refs{/sha}","trees_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/statuses/{sha}","languages_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/languages","stargazers_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/stargazers","contributors_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/contributors","subscribers_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/subscribers","subscription_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/subscription","commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/commits{/sha}","git_commits_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/git/commits{/sha}","comments_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/comments{/number}","issue_comment_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/comments{/number}","contents_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/contents/{+path}","compare_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/merges","archive_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/downloads","issues_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues{/number}","pulls_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls{/number}","milestones_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/milestones{/number}","notifications_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/labels{/name}","releases_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/releases{/id}","deployments_url":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/deployments","created_at":"2014-02-24T19:53:36Z","updated_at":"2017-11-07T00:54:31Z","pushed_at":"2017-11-07T02:32:28Z","git_url":"git://github.com/WhisperSystems/Signal-Desktop.git","ssh_url":"git@github.com:WhisperSystems/Signal-Desktop.git","clone_url":"https://github.com/WhisperSystems/Signal-Desktop.git","svn_url":"https://github.com/WhisperSystems/Signal-Desktop","homepage":"https://whispersystems.org","size":52629,"stargazers_count":2692,"watchers_count":2692,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":480,"mirror_url":null,"archived":false,"open_issues_count":342,"forks":480,"open_issues":342,"watchers":2692,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls/1712"},"html":{"href":"https://github.com/WhisperSystems/Signal-Desktop/pull/1712"},"issue":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/1712"},"comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/issues/1712/comments"},"review_comments":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls/1712/comments"},"review_comment":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/pulls/1712/commits"},"statuses":{"href":"https://api.github.com/repos/WhisperSystems/Signal-Desktop/statuses/62893140bb03ba05be78e67a4333aaf69052ee19"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":82,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"scottnonnenberg"}}