{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/helm/issues/3131","repository_url":"https://api.github.com/repos/kubernetes/helm","labels_url":"https://api.github.com/repos/kubernetes/helm/issues/3131/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/helm/issues/3131/comments","events_url":"https://api.github.com/repos/kubernetes/helm/issues/3131/events","html_url":"https://github.com/kubernetes/helm/pull/3131","id":273218855,"number":3131,"title":"check if resource is present before adding it to remaining or keep on deletion","user":{"login":"fgimenez","id":70376,"avatar_url":"https://avatars2.githubusercontent.com/u/70376?v=4","gravatar_id":"","url":"https://api.github.com/users/fgimenez","html_url":"https://github.com/fgimenez","followers_url":"https://api.github.com/users/fgimenez/followers","following_url":"https://api.github.com/users/fgimenez/following{/other_user}","gists_url":"https://api.github.com/users/fgimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/fgimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgimenez/subscriptions","organizations_url":"https://api.github.com/users/fgimenez/orgs","repos_url":"https://api.github.com/users/fgimenez/repos","events_url":"https://api.github.com/users/fgimenez/events{/privacy}","received_events_url":"https://api.github.com/users/fgimenez/received_events","type":"User","site_admin":false},"labels":[{"id":269212351,"url":"https://api.github.com/repos/kubernetes/helm/labels/bug","name":"bug","color":"fc2929","default":true},{"id":484574947,"url":"https://api.github.com/repos/kubernetes/helm/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676174034,"url":"https://api.github.com/repos/kubernetes/helm/labels/size/S","name":"size/S","color":"77bb00","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/helm/milestones/47","html_url":"https://github.com/kubernetes/helm/milestone/47","labels_url":"https://api.github.com/repos/kubernetes/helm/milestones/47/labels","id":2818810,"number":47,"title":"2.8.0 - Features","description":"Keeping with tradition, this release will be a focused on stability","creator":{"login":"thomastaylor312","id":4294228,"avatar_url":"https://avatars2.githubusercontent.com/u/4294228?v=4","gravatar_id":"","url":"https://api.github.com/users/thomastaylor312","html_url":"https://github.com/thomastaylor312","followers_url":"https://api.github.com/users/thomastaylor312/followers","following_url":"https://api.github.com/users/thomastaylor312/following{/other_user}","gists_url":"https://api.github.com/users/thomastaylor312/gists{/gist_id}","starred_url":"https://api.github.com/users/thomastaylor312/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thomastaylor312/subscriptions","organizations_url":"https://api.github.com/users/thomastaylor312/orgs","repos_url":"https://api.github.com/users/thomastaylor312/repos","events_url":"https://api.github.com/users/thomastaylor312/events{/privacy}","received_events_url":"https://api.github.com/users/thomastaylor312/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":16,"state":"open","created_at":"2017-10-06T01:19:02Z","updated_at":"2017-12-01T02:10:01Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2017-11-12T10:30:53Z","updated_at":"2017-12-01T07:48:13Z","closed_at":"2017-12-01T02:10:01Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/helm/pulls/3131","html_url":"https://github.com/kubernetes/helm/pull/3131","diff_url":"https://github.com/kubernetes/helm/pull/3131.diff","patch_url":"https://github.com/kubernetes/helm/pull/3131.patch"},"body":"Closes https://github.com/kubernetes/helm/issues/2745\r\n\r\nWhile checking which resources to keep on deletion, verify if each of them is actually present from k8s client's point of view before adding it to the list of manifests remaining or to keep. The check is done on the output string sent, the client doesn't fail if the resource is not present and instead sends a specific string (now turned into an exported constant) together with the name and kind of the resource.\r\n\r\nI've tested these changes using a ResourceQuota that limits the number of secrets, creating a chart that includes a secret with the keep annotation, along with other resources (a namespace included so that it will be created before the secret). On install I get the secret creation error. With the current codebase i get the faulty keep message on deletion of the chart. With these changes the message is not shown while deleting the chart.\r\n\r\nThis test was performed manually, it would be super nice to be able to write a (probably integration) test for this but haven't found how, pls let me know if that could be possible.\r\n\r\nThx!"},"comment":{"url":"https://api.github.com/repos/kubernetes/helm/issues/comments/348425513","html_url":"https://github.com/kubernetes/helm/pull/3131#issuecomment-348425513","issue_url":"https://api.github.com/repos/kubernetes/helm/issues/3131","id":348425513,"user":{"login":"fgimenez","id":70376,"avatar_url":"https://avatars2.githubusercontent.com/u/70376?v=4","gravatar_id":"","url":"https://api.github.com/users/fgimenez","html_url":"https://github.com/fgimenez","followers_url":"https://api.github.com/users/fgimenez/followers","following_url":"https://api.github.com/users/fgimenez/following{/other_user}","gists_url":"https://api.github.com/users/fgimenez/gists{/gist_id}","starred_url":"https://api.github.com/users/fgimenez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fgimenez/subscriptions","organizations_url":"https://api.github.com/users/fgimenez/orgs","repos_url":"https://api.github.com/users/fgimenez/repos","events_url":"https://api.github.com/users/fgimenez/events{/privacy}","received_events_url":"https://api.github.com/users/fgimenez/received_events","type":"User","site_admin":false},"created_at":"2017-12-01T07:48:13Z","updated_at":"2017-12-01T07:48:13Z","author_association":"CONTRIBUTOR","body":"Thank you! =)"}}
{"actor":{"display_login":"fgimenez"}}