{"action":"opened","number":292,"pull_request":{"url":"https://api.github.com/repos/google/xi-editor/pulls/292","id":120627101,"html_url":"https://github.com/google/xi-editor/pull/292","diff_url":"https://github.com/google/xi-editor/pull/292.diff","patch_url":"https://github.com/google/xi-editor/pull/292.patch","issue_url":"https://api.github.com/repos/google/xi-editor/issues/292","number":292,"state":"open","locked":false,"title":"Identifiers are now real types","user":{"login":"cmyr","id":3330916,"avatar_url":"https://avatars1.githubusercontent.com/u/3330916?v=3","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"body":"This patch makes better use of the type system to distinguish between `BufferIdentifier` and `ViewIdentifier`. \r\n\r\nThere were a few spots in the plugin code where this was poorly distinguished, and this change makes me a bit more considered about those places. It also will make it easier to use some value type as an identifier in the future.","created_at":"2017-05-15T15:19:34Z","updated_at":"2017-05-15T15:19:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/xi-editor/pulls/292/commits","review_comments_url":"https://api.github.com/repos/google/xi-editor/pulls/292/comments","review_comment_url":"https://api.github.com/repos/google/xi-editor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/xi-editor/issues/292/comments","statuses_url":"https://api.github.com/repos/google/xi-editor/statuses/819d9364626e57e7347de07bdc18a7a4b77eb99c","head":{"label":"cmyr:ident-types","ref":"ident-types","sha":"819d9364626e57e7347de07bdc18a7a4b77eb99c","user":{"login":"cmyr","id":3330916,"avatar_url":"https://avatars1.githubusercontent.com/u/3330916?v=3","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"repo":{"id":83341143,"name":"xi-editor","full_name":"cmyr/xi-editor","owner":{"login":"cmyr","id":3330916,"avatar_url":"https://avatars1.githubusercontent.com/u/3330916?v=3","gravatar_id":"","url":"https://api.github.com/users/cmyr","html_url":"https://github.com/cmyr","followers_url":"https://api.github.com/users/cmyr/followers","following_url":"https://api.github.com/users/cmyr/following{/other_user}","gists_url":"https://api.github.com/users/cmyr/gists{/gist_id}","starred_url":"https://api.github.com/users/cmyr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmyr/subscriptions","organizations_url":"https://api.github.com/users/cmyr/orgs","repos_url":"https://api.github.com/users/cmyr/repos","events_url":"https://api.github.com/users/cmyr/events{/privacy}","received_events_url":"https://api.github.com/users/cmyr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cmyr/xi-editor","description":"A modern editor with a backend written in Rust.","fork":true,"url":"https://api.github.com/repos/cmyr/xi-editor","forks_url":"https://api.github.com/repos/cmyr/xi-editor/forks","keys_url":"https://api.github.com/repos/cmyr/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmyr/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmyr/xi-editor/teams","hooks_url":"https://api.github.com/repos/cmyr/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/cmyr/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/cmyr/xi-editor/events","assignees_url":"https://api.github.com/repos/cmyr/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/cmyr/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/cmyr/xi-editor/tags","blobs_url":"https://api.github.com/repos/cmyr/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmyr/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmyr/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmyr/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmyr/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/cmyr/xi-editor/languages","stargazers_url":"https://api.github.com/repos/cmyr/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/cmyr/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/cmyr/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/cmyr/xi-editor/subscription","commits_url":"https://api.github.com/repos/cmyr/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmyr/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmyr/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmyr/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmyr/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/cmyr/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmyr/xi-editor/merges","archive_url":"https://api.github.com/repos/cmyr/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmyr/xi-editor/downloads","issues_url":"https://api.github.com/repos/cmyr/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/cmyr/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/cmyr/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/cmyr/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmyr/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/cmyr/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/cmyr/xi-editor/deployments","created_at":"2017-02-27T18:08:20Z","updated_at":"2017-02-27T18:08:22Z","pushed_at":"2017-05-15T15:16:59Z","git_url":"git://github.com/cmyr/xi-editor.git","ssh_url":"git@github.com:cmyr/xi-editor.git","clone_url":"https://github.com/cmyr/xi-editor.git","svn_url":"https://github.com/cmyr/xi-editor","homepage":"","size":1890,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"db62b5dc3b75f68b7d17f54233ddb25f73c9cefa","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":57167764,"name":"xi-editor","full_name":"google/xi-editor","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/xi-editor","description":"A modern editor with a backend written in Rust.","fork":false,"url":"https://api.github.com/repos/google/xi-editor","forks_url":"https://api.github.com/repos/google/xi-editor/forks","keys_url":"https://api.github.com/repos/google/xi-editor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/xi-editor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/xi-editor/teams","hooks_url":"https://api.github.com/repos/google/xi-editor/hooks","issue_events_url":"https://api.github.com/repos/google/xi-editor/issues/events{/number}","events_url":"https://api.github.com/repos/google/xi-editor/events","assignees_url":"https://api.github.com/repos/google/xi-editor/assignees{/user}","branches_url":"https://api.github.com/repos/google/xi-editor/branches{/branch}","tags_url":"https://api.github.com/repos/google/xi-editor/tags","blobs_url":"https://api.github.com/repos/google/xi-editor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/xi-editor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/xi-editor/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/xi-editor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/xi-editor/statuses/{sha}","languages_url":"https://api.github.com/repos/google/xi-editor/languages","stargazers_url":"https://api.github.com/repos/google/xi-editor/stargazers","contributors_url":"https://api.github.com/repos/google/xi-editor/contributors","subscribers_url":"https://api.github.com/repos/google/xi-editor/subscribers","subscription_url":"https://api.github.com/repos/google/xi-editor/subscription","commits_url":"https://api.github.com/repos/google/xi-editor/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/xi-editor/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/xi-editor/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/xi-editor/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/xi-editor/contents/{+path}","compare_url":"https://api.github.com/repos/google/xi-editor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/xi-editor/merges","archive_url":"https://api.github.com/repos/google/xi-editor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/xi-editor/downloads","issues_url":"https://api.github.com/repos/google/xi-editor/issues{/number}","pulls_url":"https://api.github.com/repos/google/xi-editor/pulls{/number}","milestones_url":"https://api.github.com/repos/google/xi-editor/milestones{/number}","notifications_url":"https://api.github.com/repos/google/xi-editor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/xi-editor/labels{/name}","releases_url":"https://api.github.com/repos/google/xi-editor/releases{/id}","deployments_url":"https://api.github.com/repos/google/xi-editor/deployments","created_at":"2016-04-26T23:03:23Z","updated_at":"2017-05-15T10:40:40Z","pushed_at":"2017-05-15T06:50:25Z","git_url":"git://github.com/google/xi-editor.git","ssh_url":"git@github.com:google/xi-editor.git","clone_url":"https://github.com/google/xi-editor.git","svn_url":"https://github.com/google/xi-editor","homepage":"","size":1917,"stargazers_count":7844,"watchers_count":7844,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":258,"mirror_url":null,"open_issues_count":78,"forks":258,"open_issues":78,"watchers":7844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/xi-editor/pulls/292"},"html":{"href":"https://github.com/google/xi-editor/pull/292"},"issue":{"href":"https://api.github.com/repos/google/xi-editor/issues/292"},"comments":{"href":"https://api.github.com/repos/google/xi-editor/issues/292/comments"},"review_comments":{"href":"https://api.github.com/repos/google/xi-editor/pulls/292/comments"},"review_comment":{"href":"https://api.github.com/repos/google/xi-editor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/xi-editor/pulls/292/commits"},"statuses":{"href":"https://api.github.com/repos/google/xi-editor/statuses/819d9364626e57e7347de07bdc18a7a4b77eb99c"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":153,"deletions":67,"changed_files":6}}
{"actor":{"display_login":"cmyr"}}