{"action":"created","comment":{"url":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/comments/100226599","pull_request_review_id":20926185,"id":100226599,"diff_hunk":"@@ -828,7 +842,7 @@ def build_parlay_item_subfields(c_input_format, c_input_names, local_subfields,\n \n         format_tokens = PCOMSerial.tokenize_format_char_string(c_input_format)\n \n-        for parameter, format_token in zip(c_input_names, format_tokens):\n+        for parameter, format_token in zip(c_input_names, expand_fmt_string(format_tokens)):","path":"parlay/protocols/pcom/pcom_serial.py","position":49,"original_position":49,"commit_id":"ffbbdca6342eedad81598789fc25b265b2ac6d93","original_commit_id":"ffbbdca6342eedad81598789fc25b265b2ac6d93","user":{"login":"matt-dees","id":7563021,"avatar_url":"https://avatars.githubusercontent.com/u/7563021?v=3","gravatar_id":"","url":"https://api.github.com/users/matt-dees","html_url":"https://github.com/matt-dees","followers_url":"https://api.github.com/users/matt-dees/followers","following_url":"https://api.github.com/users/matt-dees/following{/other_user}","gists_url":"https://api.github.com/users/matt-dees/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-dees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-dees/subscriptions","organizations_url":"https://api.github.com/users/matt-dees/orgs","repos_url":"https://api.github.com/users/matt-dees/repos","events_url":"https://api.github.com/users/matt-dees/events{/privacy}","received_events_url":"https://api.github.com/users/matt-dees/received_events","type":"User","site_admin":false},"body":"Added:\r\n\r\nAlso fixed a bug where numbers in format strings were not being considered when checking for INPUT_TYPE of Parlay command parameters. Eg. If the format string was \"3f\" for a command, it's input types would be STRING, NUMBER because the format string was not being expanded. Fixed to add expansion of format string so that the INPUT TYPES are calculated using \"fff\" instead of \"3f\".","created_at":"2017-02-09T03:53:47Z","updated_at":"2017-02-09T03:53:47Z","html_url":"https://github.com/PromenadeSoftware/Parlay/pull/29#discussion_r100226599","pull_request_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/29","_links":{"self":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/comments/100226599"},"html":{"href":"https://github.com/PromenadeSoftware/Parlay/pull/29#discussion_r100226599"},"pull_request":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/29"}}},"pull_request":{"url":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/29","id":105273059,"html_url":"https://github.com/PromenadeSoftware/Parlay/pull/29","diff_url":"https://github.com/PromenadeSoftware/Parlay/pull/29.diff","patch_url":"https://github.com/PromenadeSoftware/Parlay/pull/29.patch","issue_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues/29","number":29,"state":"open","locked":false,"title":"Ability for PCOM to be reset by embedded board on startup","user":{"login":"matt-dees","id":7563021,"avatar_url":"https://avatars.githubusercontent.com/u/7563021?v=3","gravatar_id":"","url":"https://api.github.com/users/matt-dees","html_url":"https://github.com/matt-dees","followers_url":"https://api.github.com/users/matt-dees/followers","following_url":"https://api.github.com/users/matt-dees/following{/other_user}","gists_url":"https://api.github.com/users/matt-dees/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-dees/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-dees/subscriptions","organizations_url":"https://api.github.com/users/matt-dees/orgs","repos_url":"https://api.github.com/users/matt-dees/repos","events_url":"https://api.github.com/users/matt-dees/events{/privacy}","received_events_url":"https://api.github.com/users/matt-dees/received_events","type":"User","site_admin":false},"body":"When the embedded board restarts it resets its ACK window while the PCOM protocol does not. This leads to a mismatch in ACK sequence numbers.\r\n\r\nNow, the embedded board can reset the protocol by calling\r\n\r\n    Reactor.send_broadcast_notification(m_id, PCOM_ID, RESET_EVENT_ID);\r\n\r\nWhere PCOM ID and RESET_EVENT_ID are both 0xFEFE. I have included this addition in the Reactor startup in the embedded/common/reactor/CReactor.cc file.\r\n\r\nAlso fixed a bug where numbers in format strings were not being considered when checking for INPUT_TYPE of Parlay command parameters. Eg. If the format string was \"3f\" for a command, it's input types would be STRING, NUMBER because the format string was not being expanded. Fixed to add expansion of format string so that the INPUT TYPES are calculated using \"fff\" instead of \"3f\".","created_at":"2017-02-08T18:11:34Z","updated_at":"2017-02-09T03:53:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e3f44201463205d8ec8b8ecc19cf63dbc2bae29","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/29/commits","review_comments_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/29/comments","review_comment_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues/29/comments","statuses_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/statuses/ffbbdca6342eedad81598789fc25b265b2ac6d93","head":{"label":"PromenadeSoftware:pcom","ref":"pcom","sha":"ffbbdca6342eedad81598789fc25b265b2ac6d93","user":{"login":"PromenadeSoftware","id":16788339,"avatar_url":"https://avatars.githubusercontent.com/u/16788339?v=3","gravatar_id":"","url":"https://api.github.com/users/PromenadeSoftware","html_url":"https://github.com/PromenadeSoftware","followers_url":"https://api.github.com/users/PromenadeSoftware/followers","following_url":"https://api.github.com/users/PromenadeSoftware/following{/other_user}","gists_url":"https://api.github.com/users/PromenadeSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/PromenadeSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PromenadeSoftware/subscriptions","organizations_url":"https://api.github.com/users/PromenadeSoftware/orgs","repos_url":"https://api.github.com/users/PromenadeSoftware/repos","events_url":"https://api.github.com/users/PromenadeSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/PromenadeSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":49994470,"name":"Parlay","full_name":"PromenadeSoftware/Parlay","owner":{"login":"PromenadeSoftware","id":16788339,"avatar_url":"https://avatars.githubusercontent.com/u/16788339?v=3","gravatar_id":"","url":"https://api.github.com/users/PromenadeSoftware","html_url":"https://github.com/PromenadeSoftware","followers_url":"https://api.github.com/users/PromenadeSoftware/followers","following_url":"https://api.github.com/users/PromenadeSoftware/following{/other_user}","gists_url":"https://api.github.com/users/PromenadeSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/PromenadeSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PromenadeSoftware/subscriptions","organizations_url":"https://api.github.com/users/PromenadeSoftware/orgs","repos_url":"https://api.github.com/users/PromenadeSoftware/repos","events_url":"https://api.github.com/users/PromenadeSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/PromenadeSoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PromenadeSoftware/Parlay","description":"Web based system for controlling and scripting embedded devices","fork":false,"url":"https://api.github.com/repos/PromenadeSoftware/Parlay","forks_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/forks","keys_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/teams","hooks_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/hooks","issue_events_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues/events{/number}","events_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/events","assignees_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/assignees{/user}","branches_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/branches{/branch}","tags_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/tags","blobs_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/statuses/{sha}","languages_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/languages","stargazers_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/stargazers","contributors_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/contributors","subscribers_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/subscribers","subscription_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/subscription","commits_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/contents/{+path}","compare_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/merges","archive_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/downloads","issues_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues{/number}","pulls_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls{/number}","milestones_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/milestones{/number}","notifications_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/labels{/name}","releases_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/releases{/id}","deployments_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/deployments","created_at":"2016-01-20T01:04:48Z","updated_at":"2016-12-04T23:09:40Z","pushed_at":"2017-02-09T03:38:48Z","git_url":"git://github.com/PromenadeSoftware/Parlay.git","ssh_url":"git@github.com:PromenadeSoftware/Parlay.git","clone_url":"https://github.com/PromenadeSoftware/Parlay.git","svn_url":"https://github.com/PromenadeSoftware/Parlay","homepage":"http://promenadesoftware.com/parlay","size":3379,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":8,"default_branch":"master"}},"base":{"label":"PromenadeSoftware:dev","ref":"dev","sha":"6a4a9f0b37a42e9b4f3e119e506bf1681e846c1f","user":{"login":"PromenadeSoftware","id":16788339,"avatar_url":"https://avatars.githubusercontent.com/u/16788339?v=3","gravatar_id":"","url":"https://api.github.com/users/PromenadeSoftware","html_url":"https://github.com/PromenadeSoftware","followers_url":"https://api.github.com/users/PromenadeSoftware/followers","following_url":"https://api.github.com/users/PromenadeSoftware/following{/other_user}","gists_url":"https://api.github.com/users/PromenadeSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/PromenadeSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PromenadeSoftware/subscriptions","organizations_url":"https://api.github.com/users/PromenadeSoftware/orgs","repos_url":"https://api.github.com/users/PromenadeSoftware/repos","events_url":"https://api.github.com/users/PromenadeSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/PromenadeSoftware/received_events","type":"Organization","site_admin":false},"repo":{"id":49994470,"name":"Parlay","full_name":"PromenadeSoftware/Parlay","owner":{"login":"PromenadeSoftware","id":16788339,"avatar_url":"https://avatars.githubusercontent.com/u/16788339?v=3","gravatar_id":"","url":"https://api.github.com/users/PromenadeSoftware","html_url":"https://github.com/PromenadeSoftware","followers_url":"https://api.github.com/users/PromenadeSoftware/followers","following_url":"https://api.github.com/users/PromenadeSoftware/following{/other_user}","gists_url":"https://api.github.com/users/PromenadeSoftware/gists{/gist_id}","starred_url":"https://api.github.com/users/PromenadeSoftware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PromenadeSoftware/subscriptions","organizations_url":"https://api.github.com/users/PromenadeSoftware/orgs","repos_url":"https://api.github.com/users/PromenadeSoftware/repos","events_url":"https://api.github.com/users/PromenadeSoftware/events{/privacy}","received_events_url":"https://api.github.com/users/PromenadeSoftware/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PromenadeSoftware/Parlay","description":"Web based system for controlling and scripting embedded devices","fork":false,"url":"https://api.github.com/repos/PromenadeSoftware/Parlay","forks_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/forks","keys_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/teams","hooks_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/hooks","issue_events_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues/events{/number}","events_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/events","assignees_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/assignees{/user}","branches_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/branches{/branch}","tags_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/tags","blobs_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/statuses/{sha}","languages_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/languages","stargazers_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/stargazers","contributors_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/contributors","subscribers_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/subscribers","subscription_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/subscription","commits_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/contents/{+path}","compare_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/merges","archive_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/downloads","issues_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues{/number}","pulls_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls{/number}","milestones_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/milestones{/number}","notifications_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/labels{/name}","releases_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/releases{/id}","deployments_url":"https://api.github.com/repos/PromenadeSoftware/Parlay/deployments","created_at":"2016-01-20T01:04:48Z","updated_at":"2016-12-04T23:09:40Z","pushed_at":"2017-02-09T03:38:48Z","git_url":"git://github.com/PromenadeSoftware/Parlay.git","ssh_url":"git@github.com:PromenadeSoftware/Parlay.git","clone_url":"https://github.com/PromenadeSoftware/Parlay.git","svn_url":"https://github.com/PromenadeSoftware/Parlay","homepage":"http://promenadesoftware.com/parlay","size":3379,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/29"},"html":{"href":"https://github.com/PromenadeSoftware/Parlay/pull/29"},"issue":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues/29"},"comments":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/PromenadeSoftware/Parlay/statuses/ffbbdca6342eedad81598789fc25b265b2ac6d93"}}}}
{"actor":{"display_login":"matt-dees"}}