{"action":"created","comment":{"url":"https://api.github.com/repos/SUSE/kiwi/pulls/comments/154600629","pull_request_review_id":80780883,"id":154600629,"diff_hunk":"@@ -383,13 +381,16 @@ overlay root filesystem\n Summary:        KIWI - buildservice package requirements for boot images\n Provides:       kiwi-boot:netboot\n Provides:       kiwi-boot:oemboot\n+Provides:       kiwi-image:docker\n Provides:       kiwi-filesystem:btrfs\n Provides:       kiwi-filesystem:xfs\n Provides:       kiwi-filesystem:ext3\n Provides:       kiwi-filesystem:ext4\n Provides:       kiwi-filesystem:squashfs\n Requires:       e2fsprogs\n Requires:       xfsprogs\n+Requires:       umoci\n+Requires:       skopeo","path":"package/python-kiwi-spec-template","position":29,"original_position":29,"commit_id":"752dd0e6faecd2c9f00bf75987417e8be839bb97","original_commit_id":"752dd0e6faecd2c9f00bf75987417e8be839bb97","user":{"login":"schaefi","id":912234,"avatar_url":"https://avatars0.githubusercontent.com/u/912234?v=4","gravatar_id":"","url":"https://api.github.com/users/schaefi","html_url":"https://github.com/schaefi","followers_url":"https://api.github.com/users/schaefi/followers","following_url":"https://api.github.com/users/schaefi/following{/other_user}","gists_url":"https://api.github.com/users/schaefi/gists{/gist_id}","starred_url":"https://api.github.com/users/schaefi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schaefi/subscriptions","organizations_url":"https://api.github.com/users/schaefi/orgs","repos_url":"https://api.github.com/users/schaefi/repos","events_url":"https://api.github.com/users/schaefi/events{/privacy}","received_events_url":"https://api.github.com/users/schaefi/received_events","type":"User","site_admin":false},"body":"umoci and skopeo are only required when a docker image will be build. I'm ok adding this requires to the kiwi-boot-requires package but it's imho the wrong place with regards to my comments before. You should also keep in mind that kiwi-boot-requires will be deleted as soon as I have moved all custom kiwi boot code to dracut because at that point no kiwi boot descriptions will be existing anymore\r\n\r\nThus I'd prefer to only have provides, requires information for kiwi-boot-requires which are correct to the context of the package and will not cause trouble when this package goes away","created_at":"2017-12-04T09:51:30Z","updated_at":"2017-12-04T09:52:54Z","html_url":"https://github.com/SUSE/kiwi/pull/558#discussion_r154600629","pull_request_url":"https://api.github.com/repos/SUSE/kiwi/pulls/558","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/comments/154600629"},"html":{"href":"https://github.com/SUSE/kiwi/pull/558#discussion_r154600629"},"pull_request":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/558"}}},"pull_request":{"url":"https://api.github.com/repos/SUSE/kiwi/pulls/558","id":155881569,"html_url":"https://github.com/SUSE/kiwi/pull/558","diff_url":"https://github.com/SUSE/kiwi/pull/558.diff","patch_url":"https://github.com/SUSE/kiwi/pull/558.patch","issue_url":"https://api.github.com/repos/SUSE/kiwi/issues/558","number":558,"state":"open","locked":false,"title":"add missing deps for docker builds.","user":{"login":"adrianschroeter","id":1067148,"avatar_url":"https://avatars3.githubusercontent.com/u/1067148?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianschroeter","html_url":"https://github.com/adrianschroeter","followers_url":"https://api.github.com/users/adrianschroeter/followers","following_url":"https://api.github.com/users/adrianschroeter/following{/other_user}","gists_url":"https://api.github.com/users/adrianschroeter/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianschroeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianschroeter/subscriptions","organizations_url":"https://api.github.com/users/adrianschroeter/orgs","repos_url":"https://api.github.com/users/adrianschroeter/repos","events_url":"https://api.github.com/users/adrianschroeter/events{/privacy}","received_events_url":"https://api.github.com/users/adrianschroeter/received_events","type":"User","site_admin":false},"body":"(the other kiwi-image: provides should also get moved to -requires package? not tested...)\r\n\r\nFixes # .\r\n\r\nChanges proposed in this pull request:\r\n*\r\n*\r\n","created_at":"2017-12-01T15:02:20Z","updated_at":"2017-12-04T09:52:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f55f0ba5b8422c3b3a49cdee78988a2847f34179","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/kiwi/pulls/558/commits","review_comments_url":"https://api.github.com/repos/SUSE/kiwi/pulls/558/comments","review_comment_url":"https://api.github.com/repos/SUSE/kiwi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/kiwi/issues/558/comments","statuses_url":"https://api.github.com/repos/SUSE/kiwi/statuses/752dd0e6faecd2c9f00bf75987417e8be839bb97","head":{"label":"adrianschroeter:master","ref":"master","sha":"752dd0e6faecd2c9f00bf75987417e8be839bb97","user":{"login":"adrianschroeter","id":1067148,"avatar_url":"https://avatars3.githubusercontent.com/u/1067148?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianschroeter","html_url":"https://github.com/adrianschroeter","followers_url":"https://api.github.com/users/adrianschroeter/followers","following_url":"https://api.github.com/users/adrianschroeter/following{/other_user}","gists_url":"https://api.github.com/users/adrianschroeter/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianschroeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianschroeter/subscriptions","organizations_url":"https://api.github.com/users/adrianschroeter/orgs","repos_url":"https://api.github.com/users/adrianschroeter/repos","events_url":"https://api.github.com/users/adrianschroeter/events{/privacy}","received_events_url":"https://api.github.com/users/adrianschroeter/received_events","type":"User","site_admin":false},"repo":{"id":112752500,"name":"kiwi","full_name":"adrianschroeter/kiwi","owner":{"login":"adrianschroeter","id":1067148,"avatar_url":"https://avatars3.githubusercontent.com/u/1067148?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianschroeter","html_url":"https://github.com/adrianschroeter","followers_url":"https://api.github.com/users/adrianschroeter/followers","following_url":"https://api.github.com/users/adrianschroeter/following{/other_user}","gists_url":"https://api.github.com/users/adrianschroeter/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianschroeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianschroeter/subscriptions","organizations_url":"https://api.github.com/users/adrianschroeter/orgs","repos_url":"https://api.github.com/users/adrianschroeter/repos","events_url":"https://api.github.com/users/adrianschroeter/events{/privacy}","received_events_url":"https://api.github.com/users/adrianschroeter/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adrianschroeter/kiwi","description":"KIWI—Appliance Builder Next Generation","fork":true,"url":"https://api.github.com/repos/adrianschroeter/kiwi","forks_url":"https://api.github.com/repos/adrianschroeter/kiwi/forks","keys_url":"https://api.github.com/repos/adrianschroeter/kiwi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adrianschroeter/kiwi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adrianschroeter/kiwi/teams","hooks_url":"https://api.github.com/repos/adrianschroeter/kiwi/hooks","issue_events_url":"https://api.github.com/repos/adrianschroeter/kiwi/issues/events{/number}","events_url":"https://api.github.com/repos/adrianschroeter/kiwi/events","assignees_url":"https://api.github.com/repos/adrianschroeter/kiwi/assignees{/user}","branches_url":"https://api.github.com/repos/adrianschroeter/kiwi/branches{/branch}","tags_url":"https://api.github.com/repos/adrianschroeter/kiwi/tags","blobs_url":"https://api.github.com/repos/adrianschroeter/kiwi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adrianschroeter/kiwi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adrianschroeter/kiwi/git/refs{/sha}","trees_url":"https://api.github.com/repos/adrianschroeter/kiwi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adrianschroeter/kiwi/statuses/{sha}","languages_url":"https://api.github.com/repos/adrianschroeter/kiwi/languages","stargazers_url":"https://api.github.com/repos/adrianschroeter/kiwi/stargazers","contributors_url":"https://api.github.com/repos/adrianschroeter/kiwi/contributors","subscribers_url":"https://api.github.com/repos/adrianschroeter/kiwi/subscribers","subscription_url":"https://api.github.com/repos/adrianschroeter/kiwi/subscription","commits_url":"https://api.github.com/repos/adrianschroeter/kiwi/commits{/sha}","git_commits_url":"https://api.github.com/repos/adrianschroeter/kiwi/git/commits{/sha}","comments_url":"https://api.github.com/repos/adrianschroeter/kiwi/comments{/number}","issue_comment_url":"https://api.github.com/repos/adrianschroeter/kiwi/issues/comments{/number}","contents_url":"https://api.github.com/repos/adrianschroeter/kiwi/contents/{+path}","compare_url":"https://api.github.com/repos/adrianschroeter/kiwi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adrianschroeter/kiwi/merges","archive_url":"https://api.github.com/repos/adrianschroeter/kiwi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adrianschroeter/kiwi/downloads","issues_url":"https://api.github.com/repos/adrianschroeter/kiwi/issues{/number}","pulls_url":"https://api.github.com/repos/adrianschroeter/kiwi/pulls{/number}","milestones_url":"https://api.github.com/repos/adrianschroeter/kiwi/milestones{/number}","notifications_url":"https://api.github.com/repos/adrianschroeter/kiwi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adrianschroeter/kiwi/labels{/name}","releases_url":"https://api.github.com/repos/adrianschroeter/kiwi/releases{/id}","deployments_url":"https://api.github.com/repos/adrianschroeter/kiwi/deployments","created_at":"2017-12-01T15:01:33Z","updated_at":"2017-12-01T15:01:36Z","pushed_at":"2017-12-01T15:01:56Z","git_url":"git://github.com/adrianschroeter/kiwi.git","ssh_url":"git@github.com:adrianschroeter/kiwi.git","clone_url":"https://github.com/adrianschroeter/kiwi.git","svn_url":"https://github.com/adrianschroeter/kiwi","homepage":"https://suse.github.io/kiwi","size":43264,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"0527c59bc361e923743ecd0419c65353760e10cb","user":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":47460440,"name":"kiwi","full_name":"SUSE/kiwi","owner":{"login":"SUSE","id":1067733,"avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SUSE/kiwi","description":"KIWI—Appliance Builder Next Generation","fork":false,"url":"https://api.github.com/repos/SUSE/kiwi","forks_url":"https://api.github.com/repos/SUSE/kiwi/forks","keys_url":"https://api.github.com/repos/SUSE/kiwi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/kiwi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/kiwi/teams","hooks_url":"https://api.github.com/repos/SUSE/kiwi/hooks","issue_events_url":"https://api.github.com/repos/SUSE/kiwi/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/kiwi/events","assignees_url":"https://api.github.com/repos/SUSE/kiwi/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/kiwi/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/kiwi/tags","blobs_url":"https://api.github.com/repos/SUSE/kiwi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/kiwi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/kiwi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/kiwi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/kiwi/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/kiwi/languages","stargazers_url":"https://api.github.com/repos/SUSE/kiwi/stargazers","contributors_url":"https://api.github.com/repos/SUSE/kiwi/contributors","subscribers_url":"https://api.github.com/repos/SUSE/kiwi/subscribers","subscription_url":"https://api.github.com/repos/SUSE/kiwi/subscription","commits_url":"https://api.github.com/repos/SUSE/kiwi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/kiwi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/kiwi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/kiwi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/kiwi/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/kiwi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/kiwi/merges","archive_url":"https://api.github.com/repos/SUSE/kiwi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/kiwi/downloads","issues_url":"https://api.github.com/repos/SUSE/kiwi/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/kiwi/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/kiwi/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/kiwi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/kiwi/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/kiwi/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/kiwi/deployments","created_at":"2015-12-05T15:11:01Z","updated_at":"2017-12-02T03:45:56Z","pushed_at":"2017-12-01T15:02:21Z","git_url":"git://github.com/SUSE/kiwi.git","ssh_url":"git@github.com:SUSE/kiwi.git","clone_url":"https://github.com/SUSE/kiwi.git","svn_url":"https://github.com/SUSE/kiwi","homepage":"https://suse.github.io/kiwi","size":43265,"stargazers_count":46,"watchers_count":46,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":22,"open_issues":13,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/558"},"html":{"href":"https://github.com/SUSE/kiwi/pull/558"},"issue":{"href":"https://api.github.com/repos/SUSE/kiwi/issues/558"},"comments":{"href":"https://api.github.com/repos/SUSE/kiwi/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/kiwi/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/kiwi/statuses/752dd0e6faecd2c9f00bf75987417e8be839bb97"}},"author_association":"NONE"}}
{"actor":{"display_login":"schaefi"}}