{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/124496266","pull_request_review_id":46787677,"id":124496266,"diff_hunk":"@@ -651,11 +704,21 @@ void java_bytecode_convert_methodt::setup_local_variables(\n   method_with_amapt dominator_args(m, amap);\n   dominator_analysis(dominator_args);\n \n+#ifdef DEBUG\n+  debug() << \"jcm: setup-local-vars: m.is_static \"\n+          << m.is_static << \" m.signature \" << m.signature << eom;\n+  debug() << \"jcm: setup-local-vars: lv arg slots \"\n+          << slots_for_parameters << eom;\n+  debug() << \"jcm: setup-local-vars: lvt size \"\n+          << m.local_variable_table.size() << eom;\n+#endif\n+\n   // Find out which local variable table entries should be merged:\n-  // Wrap each entry so we have somewhere to record live ranges with holes:\n+  // Wrap each entry so we have a data structure to work during function calls,\n+  // where we record live ranges with holes:\n   std::vector<local_variable_with_holest> vars_with_holes;\n   for(const auto &v : m.local_variable_table)\n-    vars_with_holes.push_back({v, {}});\n+    vars_with_holes.push_back({v, is_parameter(v), {}});\n \n   // Merge variable records:\n   find_initialisers(vars_with_holes, amap, dominator_analysis);","path":"src/java_bytecode/java_local_variable_table.cpp","position":240,"original_position":240,"commit_id":"742f6acb26e02de199122ac65a9b7b715a54cf07","original_commit_id":"742f6acb26e02de199122ac65a9b7b715a54cf07","user":{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars0.githubusercontent.com/u/4222448?v=3","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false},"body":"rename to `find_initializers`","created_at":"2017-06-28T09:41:09Z","updated_at":"2017-06-28T09:49:06Z","html_url":"https://github.com/diffblue/cbmc/pull/1053#discussion_r124496266","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1053","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/124496266"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1053#discussion_r124496266"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1053"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1053","id":127057339,"html_url":"https://github.com/diffblue/cbmc/pull/1053","diff_url":"https://github.com/diffblue/cbmc/pull/1053.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1053.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1053","number":1053,"state":"open","locked":false,"title":"Documentation to existing code + fixes parameter detection on bytecode->goto translation","user":{"login":"cesaro","id":143977,"avatar_url":"https://avatars2.githubusercontent.com/u/143977?v=3","gravatar_id":"","url":"https://api.github.com/users/cesaro","html_url":"https://github.com/cesaro","followers_url":"https://api.github.com/users/cesaro/followers","following_url":"https://api.github.com/users/cesaro/following{/other_user}","gists_url":"https://api.github.com/users/cesaro/gists{/gist_id}","starred_url":"https://api.github.com/users/cesaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesaro/subscriptions","organizations_url":"https://api.github.com/users/cesaro/orgs","repos_url":"https://api.github.com/users/cesaro/repos","events_url":"https://api.github.com/users/cesaro/events{/privacy}","received_events_url":"https://api.github.com/users/cesaro/received_events","type":"User","site_admin":false},"body":"Fixes [test-gen/#581](https://github.com/diffblue/test-gen/issues/581).","created_at":"2017-06-22T18:27:26Z","updated_at":"2017-06-28T09:49:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fffcc19573f14adce6772a353432b7b6a6c50717","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1053/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1053/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1053/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/742f6acb26e02de199122ac65a9b7b715a54cf07","head":{"label":"cesaro:bugfix/581-incorrect-params","ref":"bugfix/581-incorrect-params","sha":"742f6acb26e02de199122ac65a9b7b715a54cf07","user":{"login":"cesaro","id":143977,"avatar_url":"https://avatars2.githubusercontent.com/u/143977?v=3","gravatar_id":"","url":"https://api.github.com/users/cesaro","html_url":"https://github.com/cesaro","followers_url":"https://api.github.com/users/cesaro/followers","following_url":"https://api.github.com/users/cesaro/following{/other_user}","gists_url":"https://api.github.com/users/cesaro/gists{/gist_id}","starred_url":"https://api.github.com/users/cesaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesaro/subscriptions","organizations_url":"https://api.github.com/users/cesaro/orgs","repos_url":"https://api.github.com/users/cesaro/repos","events_url":"https://api.github.com/users/cesaro/events{/privacy}","received_events_url":"https://api.github.com/users/cesaro/received_events","type":"User","site_admin":false},"repo":{"id":90751053,"name":"cbmc","full_name":"cesaro/cbmc","owner":{"login":"cesaro","id":143977,"avatar_url":"https://avatars2.githubusercontent.com/u/143977?v=3","gravatar_id":"","url":"https://api.github.com/users/cesaro","html_url":"https://github.com/cesaro","followers_url":"https://api.github.com/users/cesaro/followers","following_url":"https://api.github.com/users/cesaro/following{/other_user}","gists_url":"https://api.github.com/users/cesaro/gists{/gist_id}","starred_url":"https://api.github.com/users/cesaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cesaro/subscriptions","organizations_url":"https://api.github.com/users/cesaro/orgs","repos_url":"https://api.github.com/users/cesaro/repos","events_url":"https://api.github.com/users/cesaro/events{/privacy}","received_events_url":"https://api.github.com/users/cesaro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cesaro/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/cesaro/cbmc","forks_url":"https://api.github.com/repos/cesaro/cbmc/forks","keys_url":"https://api.github.com/repos/cesaro/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cesaro/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cesaro/cbmc/teams","hooks_url":"https://api.github.com/repos/cesaro/cbmc/hooks","issue_events_url":"https://api.github.com/repos/cesaro/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/cesaro/cbmc/events","assignees_url":"https://api.github.com/repos/cesaro/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/cesaro/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/cesaro/cbmc/tags","blobs_url":"https://api.github.com/repos/cesaro/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cesaro/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cesaro/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cesaro/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cesaro/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/cesaro/cbmc/languages","stargazers_url":"https://api.github.com/repos/cesaro/cbmc/stargazers","contributors_url":"https://api.github.com/repos/cesaro/cbmc/contributors","subscribers_url":"https://api.github.com/repos/cesaro/cbmc/subscribers","subscription_url":"https://api.github.com/repos/cesaro/cbmc/subscription","commits_url":"https://api.github.com/repos/cesaro/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cesaro/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cesaro/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cesaro/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cesaro/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/cesaro/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cesaro/cbmc/merges","archive_url":"https://api.github.com/repos/cesaro/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cesaro/cbmc/downloads","issues_url":"https://api.github.com/repos/cesaro/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/cesaro/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/cesaro/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/cesaro/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cesaro/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/cesaro/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/cesaro/cbmc/deployments","created_at":"2017-05-09T13:50:09Z","updated_at":"2017-05-09T13:50:16Z","pushed_at":"2017-06-28T09:07:47Z","git_url":"git://github.com/cesaro/cbmc.git","ssh_url":"git@github.com:cesaro/cbmc.git","clone_url":"https://github.com/cesaro/cbmc.git","svn_url":"https://github.com/cesaro/cbmc","homepage":"http://www.cprover.org/cbmc","size":20604,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:test-gen-support","ref":"test-gen-support","sha":"f690a3c805c8b9e2a5d67a0442b8995c2a3086eb","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars3.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars3.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2017-06-27T23:17:56Z","pushed_at":"2017-06-28T09:34:54Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":20785,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":257,"forks":60,"open_issues":257,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1053"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1053"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1053"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1053/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1053/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1053/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/742f6acb26e02de199122ac65a9b7b715a54cf07"}}}}
{"actor":{"display_login":"peterschrammel"}}