{"action":"created","issue":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8897","repository_url":"https://api.github.com/repos/rapid7/metasploit-framework","labels_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8897/labels{/name}","comments_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8897/comments","events_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8897/events","html_url":"https://github.com/rapid7/metasploit-framework/pull/8897","id":253329525,"number":8897,"title":"rewrite timestomp command dispatcher to deal with file args properly","user":{"login":"busterb","id":4108654,"avatar_url":"https://avatars3.githubusercontent.com/u/4108654?v=4","gravatar_id":"","url":"https://api.github.com/users/busterb","html_url":"https://github.com/busterb","followers_url":"https://api.github.com/users/busterb/followers","following_url":"https://api.github.com/users/busterb/following{/other_user}","gists_url":"https://api.github.com/users/busterb/gists{/gist_id}","starred_url":"https://api.github.com/users/busterb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/busterb/subscriptions","organizations_url":"https://api.github.com/users/busterb/orgs","repos_url":"https://api.github.com/users/busterb/repos","events_url":"https://api.github.com/users/busterb/events{/privacy}","received_events_url":"https://api.github.com/users/busterb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-28T13:29:59Z","updated_at":"2017-08-28T16:25:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/pulls/8897","html_url":"https://github.com/rapid7/metasploit-framework/pull/8897","diff_url":"https://github.com/rapid7/metasploit-framework/pull/8897.diff","patch_url":"https://github.com/rapid7/metasploit-framework/pull/8897.patch"},"body":"This fixes #8588 by making timestomp argument parsing work like it actually documents as:\r\n\r\n`Usage: timestomp file_path OPTIONS`\r\n\r\nRather than a hacky 'the last thing that doesn't start with - is assumed to be a file' code path, accumulate file paths based on what Rex::Parser finds in the argument string.\r\n\r\nThis also teaches timestamp to deal with multiple files, and updates the Ruby code style.\r\n\r\n## Verification\r\n\r\n- [ ] Get a Windows meterpreter session\r\n- [ ] `timestomp test.txt -z \"01/01/2001 01:01:01\"` should work as expected\r\n- [ ] `timestomp -z \"01/01/2001 01:01:01\" test.txt` should also work\r\n- [ ] `timestomp -z \"01/01/2001 01:01:01\" test.txt test.txt test2.txt` should set MACE on 2 files\r\n\r\nPoke around at it to make sure I didn't break anything as well.\r\n"},"comment":{"url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/comments/325402477","html_url":"https://github.com/rapid7/metasploit-framework/pull/8897#issuecomment-325402477","issue_url":"https://api.github.com/repos/rapid7/metasploit-framework/issues/8897","id":325402477,"user":{"login":"sempervictus","id":1331084,"avatar_url":"https://avatars2.githubusercontent.com/u/1331084?v=4","gravatar_id":"","url":"https://api.github.com/users/sempervictus","html_url":"https://github.com/sempervictus","followers_url":"https://api.github.com/users/sempervictus/followers","following_url":"https://api.github.com/users/sempervictus/following{/other_user}","gists_url":"https://api.github.com/users/sempervictus/gists{/gist_id}","starred_url":"https://api.github.com/users/sempervictus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sempervictus/subscriptions","organizations_url":"https://api.github.com/users/sempervictus/orgs","repos_url":"https://api.github.com/users/sempervictus/repos","events_url":"https://api.github.com/users/sempervictus/events{/privacy}","received_events_url":"https://api.github.com/users/sempervictus/received_events","type":"User","site_admin":false},"created_at":"2017-08-28T16:25:04Z","updated_at":"2017-08-28T16:25:04Z","body":"Would be nice to wrap all the args.length checks into the standard arg parser along with the usage/help stuff so these dispatchers get homogenized.\r\nWill test, thanks as always."}}
{"actor":{"display_login":"sempervictus"}}