{"action":"created","issue":{"url":"https://api.github.com/repos/playframework/playframework/issues/6955","repository_url":"https://api.github.com/repos/playframework/playframework","labels_url":"https://api.github.com/repos/playframework/playframework/issues/6955/labels{/name}","comments_url":"https://api.github.com/repos/playframework/playframework/issues/6955/comments","events_url":"https://api.github.com/repos/playframework/playframework/issues/6955/events","html_url":"https://github.com/playframework/playframework/issues/6955","id":206046808,"number":6955,"title":"Update documentation for ScalaFunctionalTestingWithScalaTest#Testing-with-a-server","user":{"login":"shashidesai","id":209642,"avatar_url":"https://avatars.githubusercontent.com/u/209642?v=3","gravatar_id":"","url":"https://api.github.com/users/shashidesai","html_url":"https://github.com/shashidesai","followers_url":"https://api.github.com/users/shashidesai/followers","following_url":"https://api.github.com/users/shashidesai/following{/other_user}","gists_url":"https://api.github.com/users/shashidesai/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidesai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidesai/subscriptions","organizations_url":"https://api.github.com/users/shashidesai/orgs","repos_url":"https://api.github.com/users/shashidesai/repos","events_url":"https://api.github.com/users/shashidesai/events{/privacy}","received_events_url":"https://api.github.com/users/shashidesai/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-02-07T23:16:52Z","updated_at":"2017-02-08T18:24:59Z","closed_at":null,"body":"### Play Version (2.5.x / etc)\r\n2.5.x\r\n\r\n\r\n### API (Scala / Java / Neither / Both)\r\nScala 2.11.8\r\n\r\n\r\n### Operating System (Ubuntu 15.10 / MacOS 10.10 / Windows 10)\r\n\r\nmacOS Sierra 10.12.3\r\n\r\n### JDK (Oracle 1.8.0_72, OpenJDK 1.8.x, Azul Zing)\r\n\r\njava version \"1.8.0_77\"\r\nJava(TM) SE Runtime Environment (build 1.8.0_77-b03)\r\nJava HotSpot(TM) 64-Bit Server VM (build 25.77-b03, mixed mode)\r\n\r\n### Library Dependencies\r\n\r\nNone\r\n\r\n### Expected Behavior\r\n\r\nPlease describe the expected behavior of the issue, starting from the first action.\r\n\r\n1. Documentation Page - https://www.playframework.com/documentation/2.5.x/ScalaFunctionalTestingWithScalaTest#Testing-with-a-server\r\n2. 'Testing with a server' example does not compile.\r\n3. Adding these imports, makes it compilable\r\nimport play.api.routing.sird._\r\nimport play.api.mvc.Results._\r\n\r\n### Actual Behavior\r\n\r\nPlease provide a description of what actually happens, working from the same starting point.\r\n\r\n1. If you use the example here - https://www.playframework.com/documentation/2.5.x/ScalaFunctionalTestingWithScalaTest#testing-with-a-server\r\n2. It does not compile\r\n\r\n### Reproducible Test Case\r\n\r\nNot applicable, as the code does not compile.\r\n\r\nNote: checked the existing issues and couldn't find any existing issues related to this. And in general I think the playframework website is not up to date with scala test play documentation.\r\n"},"comment":{"url":"https://api.github.com/repos/playframework/playframework/issues/comments/278417259","html_url":"https://github.com/playframework/playframework/issues/6955#issuecomment-278417259","issue_url":"https://api.github.com/repos/playframework/playframework/issues/6955","id":278417259,"user":{"login":"shashidesai","id":209642,"avatar_url":"https://avatars.githubusercontent.com/u/209642?v=3","gravatar_id":"","url":"https://api.github.com/users/shashidesai","html_url":"https://github.com/shashidesai","followers_url":"https://api.github.com/users/shashidesai/followers","following_url":"https://api.github.com/users/shashidesai/following{/other_user}","gists_url":"https://api.github.com/users/shashidesai/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidesai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidesai/subscriptions","organizations_url":"https://api.github.com/users/shashidesai/orgs","repos_url":"https://api.github.com/users/shashidesai/repos","events_url":"https://api.github.com/users/shashidesai/events{/privacy}","received_events_url":"https://api.github.com/users/shashidesai/received_events","type":"User","site_admin":false},"created_at":"2017-02-08T18:24:59Z","updated_at":"2017-02-08T18:24:59Z","body":"Seems like the file on ScalaGuide seems to have been changed, it has different code than whats on the website. So its just matter of latest ScalaGuide(https://github.com/playframework/scalatestplus-play) not published to the website then ?\r\n\r\nThe one on the website has this class extended.\r\nclass ExampleSpec extends PlaySpec with OneServerPerSuite\r\nbut on the ScalaGuide repository its different.\r\nclass ExampleSpec extends PlaySpec with GuiceOneServerPerSuite\r\n\r\nScalatestplus-play --> oneserverpersuite --> ExampleSpec.scala\r\nhttps://github.com/playframework/scalatestplus-play/blob/master/docs/manual/working/scalaGuide/main/tests/ScalaFunctionalTestingWithScalaTest.md#testing-with-a-server\r\nhttps://github.com/playframework/scalatestplus-play/blob/master/docs/manual/working/scalaGuide/main/tests/code/oneserverpersuite/ExampleSpec.scala\r\n\r\nWebsite has different code - https://www.playframework.com/documentation/2.5.x/ScalaFunctionalTestingWithScalaTest#testing-with-a-server"}}
{"actor":{"display_login":"shashidesai"}}