{"action":"opened","number":1411,"pull_request":{"url":"https://api.github.com/repos/istio/pilot/pulls/1411","id":145495702,"html_url":"https://github.com/istio/pilot/pull/1411","diff_url":"https://github.com/istio/pilot/pull/1411.diff","patch_url":"https://github.com/istio/pilot/pull/1411.patch","issue_url":"https://api.github.com/repos/istio/pilot/issues/1411","number":1411,"state":"open","locked":false,"title":"Enable ingress mode for Eureka/Consul","user":{"login":"rshriram","id":8202871,"avatar_url":"https://avatars1.githubusercontent.com/u/8202871?v=4","gravatar_id":"","url":"https://api.github.com/users/rshriram","html_url":"https://github.com/rshriram","followers_url":"https://api.github.com/users/rshriram/followers","following_url":"https://api.github.com/users/rshriram/following{/other_user}","gists_url":"https://api.github.com/users/rshriram/gists{/gist_id}","starred_url":"https://api.github.com/users/rshriram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rshriram/subscriptions","organizations_url":"https://api.github.com/users/rshriram/orgs","repos_url":"https://api.github.com/users/rshriram/repos","events_url":"https://api.github.com/users/rshriram/events{/privacy}","received_events_url":"https://api.github.com/users/rshriram/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nIngress is a generic concept applicable across platforms. K8S has ingress as first class resource (except its broken in several ways). In non k8s platforms, we cannot use this ingress resource spec reliably, as it requires enabling ingress controller without the status syncer (adds more complexities), especially if people are just adding it for the dummy ingress.\r\n\r\nThis PR defines a new proxy agent mode (LB) that allows the sidecar to obtain just outbound configs, and run as standalone envoy [which becomes ingress in Consul/Eureka]. With this, we would no longer have to expose services directly (like the way we do today). An added benefit is that this would allow people to run envoy as standalone using load balancer service in kubernetes.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nnew Load Balancer mode for sidecar to enable ingress functionality in non-k8s environments\r\n```\r\n","created_at":"2017-10-09T16:25:28Z","updated_at":"2017-10-09T16:25:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/pilot/pulls/1411/commits","review_comments_url":"https://api.github.com/repos/istio/pilot/pulls/1411/comments","review_comment_url":"https://api.github.com/repos/istio/pilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/pilot/issues/1411/comments","statuses_url":"https://api.github.com/repos/istio/pilot/statuses/2ac7f9e47d47d4955f6b98de8e14a6eaf813c620","head":{"label":"istio:consul_ing","ref":"consul_ing","sha":"2ac7f9e47d47d4955f6b98de8e14a6eaf813c620","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75686596,"name":"pilot","full_name":"istio/pilot","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/pilot","description":"Istio Pilot implementation","fork":false,"url":"https://api.github.com/repos/istio/pilot","forks_url":"https://api.github.com/repos/istio/pilot/forks","keys_url":"https://api.github.com/repos/istio/pilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/pilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/pilot/teams","hooks_url":"https://api.github.com/repos/istio/pilot/hooks","issue_events_url":"https://api.github.com/repos/istio/pilot/issues/events{/number}","events_url":"https://api.github.com/repos/istio/pilot/events","assignees_url":"https://api.github.com/repos/istio/pilot/assignees{/user}","branches_url":"https://api.github.com/repos/istio/pilot/branches{/branch}","tags_url":"https://api.github.com/repos/istio/pilot/tags","blobs_url":"https://api.github.com/repos/istio/pilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/pilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/pilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/pilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/pilot/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/pilot/languages","stargazers_url":"https://api.github.com/repos/istio/pilot/stargazers","contributors_url":"https://api.github.com/repos/istio/pilot/contributors","subscribers_url":"https://api.github.com/repos/istio/pilot/subscribers","subscription_url":"https://api.github.com/repos/istio/pilot/subscription","commits_url":"https://api.github.com/repos/istio/pilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/pilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/pilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/pilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/pilot/contents/{+path}","compare_url":"https://api.github.com/repos/istio/pilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/pilot/merges","archive_url":"https://api.github.com/repos/istio/pilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/pilot/downloads","issues_url":"https://api.github.com/repos/istio/pilot/issues{/number}","pulls_url":"https://api.github.com/repos/istio/pilot/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/pilot/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/pilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/pilot/labels{/name}","releases_url":"https://api.github.com/repos/istio/pilot/releases{/id}","deployments_url":"https://api.github.com/repos/istio/pilot/deployments","created_at":"2016-12-06T02:29:57Z","updated_at":"2017-10-05T17:44:18Z","pushed_at":"2017-10-09T16:17:58Z","git_url":"git://github.com/istio/pilot.git","ssh_url":"git@github.com:istio/pilot.git","clone_url":"https://github.com/istio/pilot.git","svn_url":"https://github.com/istio/pilot","homepage":"","size":3098,"stargazers_count":121,"watchers_count":121,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":105,"forks":88,"open_issues":105,"watchers":121,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"d2b0cedf57ef1ccc26f3d2a530274dec3fa1e07f","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75686596,"name":"pilot","full_name":"istio/pilot","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/pilot","description":"Istio Pilot implementation","fork":false,"url":"https://api.github.com/repos/istio/pilot","forks_url":"https://api.github.com/repos/istio/pilot/forks","keys_url":"https://api.github.com/repos/istio/pilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/pilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/pilot/teams","hooks_url":"https://api.github.com/repos/istio/pilot/hooks","issue_events_url":"https://api.github.com/repos/istio/pilot/issues/events{/number}","events_url":"https://api.github.com/repos/istio/pilot/events","assignees_url":"https://api.github.com/repos/istio/pilot/assignees{/user}","branches_url":"https://api.github.com/repos/istio/pilot/branches{/branch}","tags_url":"https://api.github.com/repos/istio/pilot/tags","blobs_url":"https://api.github.com/repos/istio/pilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/pilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/pilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/pilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/pilot/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/pilot/languages","stargazers_url":"https://api.github.com/repos/istio/pilot/stargazers","contributors_url":"https://api.github.com/repos/istio/pilot/contributors","subscribers_url":"https://api.github.com/repos/istio/pilot/subscribers","subscription_url":"https://api.github.com/repos/istio/pilot/subscription","commits_url":"https://api.github.com/repos/istio/pilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/pilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/pilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/pilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/pilot/contents/{+path}","compare_url":"https://api.github.com/repos/istio/pilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/pilot/merges","archive_url":"https://api.github.com/repos/istio/pilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/pilot/downloads","issues_url":"https://api.github.com/repos/istio/pilot/issues{/number}","pulls_url":"https://api.github.com/repos/istio/pilot/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/pilot/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/pilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/pilot/labels{/name}","releases_url":"https://api.github.com/repos/istio/pilot/releases{/id}","deployments_url":"https://api.github.com/repos/istio/pilot/deployments","created_at":"2016-12-06T02:29:57Z","updated_at":"2017-10-05T17:44:18Z","pushed_at":"2017-10-09T16:17:58Z","git_url":"git://github.com/istio/pilot.git","ssh_url":"git@github.com:istio/pilot.git","clone_url":"https://github.com/istio/pilot.git","svn_url":"https://github.com/istio/pilot","homepage":"","size":3098,"stargazers_count":121,"watchers_count":121,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":105,"forks":88,"open_issues":105,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/pilot/pulls/1411"},"html":{"href":"https://github.com/istio/pilot/pull/1411"},"issue":{"href":"https://api.github.com/repos/istio/pilot/issues/1411"},"comments":{"href":"https://api.github.com/repos/istio/pilot/issues/1411/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/pilot/pulls/1411/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/pilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/pilot/pulls/1411/commits"},"statuses":{"href":"https://api.github.com/repos/istio/pilot/statuses/2ac7f9e47d47d4955f6b98de8e14a6eaf813c620"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":22,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"rshriram"}}