{"action":"created","issue":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5498","repository_url":"https://api.github.com/repos/dolphin-emu/dolphin","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5498/labels{/name}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5498/comments","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5498/events","html_url":"https://github.com/dolphin-emu/dolphin/pull/5498","id":232104910,"number":5498,"title":"Hybrid xfb","user":{"login":"iwubcode","id":15224722,"avatar_url":"https://avatars2.githubusercontent.com/u/15224722?v=3","gravatar_id":"","url":"https://api.github.com/users/iwubcode","html_url":"https://github.com/iwubcode","followers_url":"https://api.github.com/users/iwubcode/followers","following_url":"https://api.github.com/users/iwubcode/following{/other_user}","gists_url":"https://api.github.com/users/iwubcode/gists{/gist_id}","starred_url":"https://api.github.com/users/iwubcode/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iwubcode/subscriptions","organizations_url":"https://api.github.com/users/iwubcode/orgs","repos_url":"https://api.github.com/users/iwubcode/repos","events_url":"https://api.github.com/users/iwubcode/events{/privacy}","received_events_url":"https://api.github.com/users/iwubcode/received_events","type":"User","site_admin":false},"labels":[{"id":221808232,"url":"https://api.github.com/repos/dolphin-emu/dolphin/labels/WIP","name":"WIP","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":28,"created_at":"2017-05-29T22:08:35Z","updated_at":"2017-07-03T04:25:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/5498","html_url":"https://github.com/dolphin-emu/dolphin/pull/5498","diff_url":"https://github.com/dolphin-emu/dolphin/pull/5498.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/5498.patch"},"body":"The second pr based off of @phire 's original Hybrid XFB #3880 .  Leverages the AbstractTexture ( #5305 ) to treat the xfb as a texture.\r\n\r\nWhat's done:\r\n\r\n- Initial hybrid xfb support for Vulkan, D3D, Opengl\r\n- Make texture cache always use safe hashing for XFB copies.\r\n- Initial Screenshot dumping for D3D, Vulkan through VideoCommon\r\n- Initial Video dumping for D3D, Vulkan through VideoCommon\r\n- GUI Options\r\n- Update fifoplayer to support XFB\r\n\r\nWhat's left:\r\n\r\n- Improve \"Partial Texture Updates\" to fix games using 3x Anti Aliasing (and spyro)  ( fixed in #5718 )\r\n- Clean up code / Remove lots of unnecessary code!\r\n- Squash all the bugs\r\n  - OGL crashes on frame dump\r\n  - Vulkan crashed on framedump once when testing\r\n- Vertical scaling for PAL games\r\n  - XFB to RAM copies need to apply the scale\r\n  - XFB to Tex copies need to store, but not apply the scale.\r\n  - Partial texture updates need to apply any store scaling before display.\r\n\r\nFuture Enhancements:\r\n\r\n  - Find a new sane home for the \"End of frame\" stuff.\r\n  - Somehow allow Swap to detect when the XFB hasn't changed since last frame"},"comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments/312546796","html_url":"https://github.com/dolphin-emu/dolphin/pull/5498#issuecomment-312546796","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/5498","id":312546796,"user":{"login":"JMC47","id":6598209,"avatar_url":"https://avatars1.githubusercontent.com/u/6598209?v=3","gravatar_id":"","url":"https://api.github.com/users/JMC47","html_url":"https://github.com/JMC47","followers_url":"https://api.github.com/users/JMC47/followers","following_url":"https://api.github.com/users/JMC47/following{/other_user}","gists_url":"https://api.github.com/users/JMC47/gists{/gist_id}","starred_url":"https://api.github.com/users/JMC47/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JMC47/subscriptions","organizations_url":"https://api.github.com/users/JMC47/orgs","repos_url":"https://api.github.com/users/JMC47/repos","events_url":"https://api.github.com/users/JMC47/events{/privacy}","received_events_url":"https://api.github.com/users/JMC47/received_events","type":"User","site_admin":false},"created_at":"2017-07-03T04:25:02Z","updated_at":"2017-07-03T04:25:02Z","body":"Please bisect if that's happening on master.  Thanks."}}
{"actor":{"display_login":"JMC47"}}