{"action":"created","issue":{"url":"https://api.github.com/repos/docker/docker/issues/29807","repository_url":"https://api.github.com/repos/docker/docker","labels_url":"https://api.github.com/repos/docker/docker/issues/29807/labels{/name}","comments_url":"https://api.github.com/repos/docker/docker/issues/29807/comments","events_url":"https://api.github.com/repos/docker/docker/issues/29807/events","html_url":"https://github.com/docker/docker/pull/29807","id":198243704,"number":29807,"title":"Update frozen images in Dockerfiles","user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars1.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"labels":[{"id":175375407,"url":"https://api.github.com/repos/docker/docker/labels/status/2-code-review","name":"status/2-code-review","color":"fad8c7","default":false},{"id":333507103,"url":"https://api.github.com/repos/docker/docker/labels/status/failing-ci","name":"status/failing-ci","color":"888888","default":false}],"state":"open","locked":false,"assignee":{"login":"LK4D4","id":101445,"avatar_url":"https://avatars1.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false},"assignees":[{"login":"LK4D4","id":101445,"avatar_url":"https://avatars1.githubusercontent.com/u/101445?v=3","gravatar_id":"","url":"https://api.github.com/users/LK4D4","html_url":"https://github.com/LK4D4","followers_url":"https://api.github.com/users/LK4D4/followers","following_url":"https://api.github.com/users/LK4D4/following{/other_user}","gists_url":"https://api.github.com/users/LK4D4/gists{/gist_id}","starred_url":"https://api.github.com/users/LK4D4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LK4D4/subscriptions","organizations_url":"https://api.github.com/users/LK4D4/orgs","repos_url":"https://api.github.com/users/LK4D4/repos","events_url":"https://api.github.com/users/LK4D4/events{/privacy}","received_events_url":"https://api.github.com/users/LK4D4/received_events","type":"User","site_admin":false}],"milestone":null,"comments":32,"created_at":"2016-12-31T19:13:02Z","updated_at":"2017-04-01T11:52:11Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/docker/docker/pulls/29807","html_url":"https://github.com/docker/docker/pull/29807","diff_url":"https://github.com/docker/docker/pull/29807.diff","patch_url":"https://github.com/docker/docker/pull/29807.patch"},"body":"This updates the versions of the frozen images used to their current\r\nversion. The original reason for updating these images was to make sure\r\nthey are not affected by [CVE-2016-1252 / DSA-3733-1](https://lwn.net/Articles/709119/),\r\nwhich is fixed in apt 1.0.9.8.4 and up.\r\n\r\nNote that `CVE-2016-1252` won't affect our test-suite, because no packages\r\nare installed during out tests. It is just \"good practice\" to keep these\r\nimages up to date.\r\n\r\nThe `debian:jessie`, and `buildpack-deps:jessie` in  `Dockerfile.s390x`,\r\nand `Dockerfile.armhf` have not been updated in this patch, because\r\nthose images have not yet been updated to contain apt 1.0.9.8.4.\r\n\r\nWhile working on this, the `busybox` and `hello-world` were also updated\r\nto their latest version.\r\n\r\nAlso removes a reference to `hack/make/.ensure-frozen-images`, which\r\nwas removed in ff91276d1f5beab5582d9ca582ee01af13198333.\r\n\r\n/cc @tianon @vdemeester @tophj-ibm "},"comment":{"url":"https://api.github.com/repos/docker/docker/issues/comments/290915333","html_url":"https://github.com/docker/docker/pull/29807#issuecomment-290915333","issue_url":"https://api.github.com/repos/docker/docker/issues/29807","id":290915333,"user":{"login":"thaJeztah","id":1804568,"avatar_url":"https://avatars1.githubusercontent.com/u/1804568?v=3","gravatar_id":"","url":"https://api.github.com/users/thaJeztah","html_url":"https://github.com/thaJeztah","followers_url":"https://api.github.com/users/thaJeztah/followers","following_url":"https://api.github.com/users/thaJeztah/following{/other_user}","gists_url":"https://api.github.com/users/thaJeztah/gists{/gist_id}","starred_url":"https://api.github.com/users/thaJeztah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thaJeztah/subscriptions","organizations_url":"https://api.github.com/users/thaJeztah/orgs","repos_url":"https://api.github.com/users/thaJeztah/repos","events_url":"https://api.github.com/users/thaJeztah/events{/privacy}","received_events_url":"https://api.github.com/users/thaJeztah/received_events","type":"User","site_admin":false},"created_at":"2017-04-01T11:52:11Z","updated_at":"2017-04-01T11:52:11Z","body":"Ok, the \"good news\" is that a test, \"formerly known as flaky\" now consistently fails on all builds;\r\n\r\n\r\n```\r\n16:26:05 ----------------------------------------------------------------------\r\n16:26:05 FAIL: docker_cli_push_test.go:608: DockerRegistryAuthTokenSuite.TestPushMisconfiguredTokenServiceResponseError\r\n16:26:05 \r\n16:26:05 docker_cli_push_test.go:617:\r\n16:26:05     c.Assert(out, checker.Not(checker.Contains), \"Retrying in 15\")\r\n16:26:05 ... obtained string = \"\" +\r\n16:26:05 ...     \"The push refers to a repository [127.0.0.1:5000/busybox]\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Preparing\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 5 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 4 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 3 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 2 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 1 second\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 10 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 9 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 8 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 7 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 6 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 5 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 4 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 3 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 2 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 1 second\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 15 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 14 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 13 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 12 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 11 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 10 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 9 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 8 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 7 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 6 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 5 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 4 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 3 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 2 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 1 second\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 20 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 19 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 18 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 17 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 16 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 15 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 14 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 13 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 12 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 11 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 10 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 9 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 8 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 7 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 6 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 5 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 4 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 3 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 2 seconds\\n\" +\r\n16:26:05 ...     \"c0de73ac9968: Retrying in 1 second\\n\" +\r\n16:26:05 ...     \"toomanyrequests: out of tokens\\n\"\r\n16:26:05 ... substring string = \"Retrying in 15\"\r\n16:26:05 \r\n```\r\n\r\nDiscussing with @dmcgowan on Slack;\r\n\r\n> that switch from 3 to 10 looks like it is going to always cause it to fail since it checks that it doesn't grow the retry time to 15 which 10 will cause it to do, there has got to be a better way to test this, the current approach seems very broken\r\n\r\n> [thaJeztah] should we change it back to 3? Weird that it started consistently failing after updating the frozen images (but tbh, I haven't dived into the test)\r\n\r\n> 3 should be enough, would have to dig into the original flakiness more possibly that check that it didn't retry after 15 seconds should be removed, the test might have been updated to ensure that it wasn't unnecessarily taking a long time\r\n\r\nThe \"switch from 3 to 10\" (actually \"4 to 10\") was done here to try and make it less flaky; https://github.com/docker/docker/pull/32058\r\n\r\n"}}
{"actor":{"display_login":"thaJeztah"}}