{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/123591523","pull_request_review_id":45810855,"id":123591523,"diff_hunk":"@@ -42,7 +42,19 @@ internal SessionPoolImpl(SessionPoolKey key)\n         {\n             Key = key;\n         }\n-\n+        internal void DumpSessionPoolContents(StringBuilder stringBuilder)\n+        {\n+            lock (_sessionMruStack)\n+            {\n+                int i = 0;\n+                foreach (var entry in _sessionMruStack)\n+                {\n+                    var instance = i;\n+                    stringBuilder.AppendLine($\"  {instance}:{entry.Session?.GetHashCode()}\");","path":"apis/Google.Cloud.Spanner.V1/Google.Cloud.Spanner.V1/SessionPoolImpl.cs","position":37,"original_position":37,"commit_id":"74e6eecc4903e32b392eaa8f0e9271fe2570e5ea","original_commit_id":"74e6eecc4903e32b392eaa8f0e9271fe2570e5ea","user":{"login":"benwulfe","id":8314021,"avatar_url":"https://avatars0.githubusercontent.com/u/8314021?v=3","gravatar_id":"","url":"https://api.github.com/users/benwulfe","html_url":"https://github.com/benwulfe","followers_url":"https://api.github.com/users/benwulfe/followers","following_url":"https://api.github.com/users/benwulfe/following{/other_user}","gists_url":"https://api.github.com/users/benwulfe/gists{/gist_id}","starred_url":"https://api.github.com/users/benwulfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwulfe/subscriptions","organizations_url":"https://api.github.com/users/benwulfe/orgs","repos_url":"https://api.github.com/users/benwulfe/repos","events_url":"https://api.github.com/users/benwulfe/events{/privacy}","received_events_url":"https://api.github.com/users/benwulfe/received_events","type":"User","site_admin":false},"body":"old version had a modified closure issue.","created_at":"2017-06-22T18:41:23Z","updated_at":"2017-06-22T18:41:23Z","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1135#discussion_r123591523","pull_request_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1135","_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments/123591523"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1135#discussion_r123591523"},"pull_request":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1135"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1135","id":126885910,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1135","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1135.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1135.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/1135","number":1135,"state":"open","locked":false,"title":"Cloud spanner multichannel","user":{"login":"benwulfe","id":8314021,"avatar_url":"https://avatars0.githubusercontent.com/u/8314021?v=3","gravatar_id":"","url":"https://api.github.com/users/benwulfe","html_url":"https://github.com/benwulfe","followers_url":"https://api.github.com/users/benwulfe/followers","following_url":"https://api.github.com/users/benwulfe/following{/other_user}","gists_url":"https://api.github.com/users/benwulfe/gists{/gist_id}","starred_url":"https://api.github.com/users/benwulfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwulfe/subscriptions","organizations_url":"https://api.github.com/users/benwulfe/orgs","repos_url":"https://api.github.com/users/benwulfe/repos","events_url":"https://api.github.com/users/benwulfe/events{/privacy}","received_events_url":"https://api.github.com/users/benwulfe/received_events","type":"User","site_admin":false},"body":"Major: Stress tests and fixes for priorityheap (sortedlist had an issue with duplicate priorities)\r\n  Multichannel support (config setting for how many grpc channels to use)\r\nMinor: \r\n some minor stress fixes around transaction prewarm.\r\n dataadapter integration tests.  …\r\n Fixed an issue on multiple Fills for dataadapter.\r\n spannerparametercolleciton implements ienumerable<spannerparameter>\r\n timestampbound should be immutable\r\n should be able to set properties in any order for spannerparameter\r\n new logging options.\r\n sets default cap of sessions to 400 per spanner guidelines.\r\n","created_at":"2017-06-22T00:07:47Z","updated_at":"2017-06-22T18:41:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4eef8ae5fe780b11008f082e35949e2360790357","assignee":{"login":"benwulfe","id":8314021,"avatar_url":"https://avatars0.githubusercontent.com/u/8314021?v=3","gravatar_id":"","url":"https://api.github.com/users/benwulfe","html_url":"https://github.com/benwulfe","followers_url":"https://api.github.com/users/benwulfe/followers","following_url":"https://api.github.com/users/benwulfe/following{/other_user}","gists_url":"https://api.github.com/users/benwulfe/gists{/gist_id}","starred_url":"https://api.github.com/users/benwulfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwulfe/subscriptions","organizations_url":"https://api.github.com/users/benwulfe/orgs","repos_url":"https://api.github.com/users/benwulfe/repos","events_url":"https://api.github.com/users/benwulfe/events{/privacy}","received_events_url":"https://api.github.com/users/benwulfe/received_events","type":"User","site_admin":false},"assignees":[{"login":"benwulfe","id":8314021,"avatar_url":"https://avatars0.githubusercontent.com/u/8314021?v=3","gravatar_id":"","url":"https://api.github.com/users/benwulfe","html_url":"https://github.com/benwulfe","followers_url":"https://api.github.com/users/benwulfe/followers","following_url":"https://api.github.com/users/benwulfe/following{/other_user}","gists_url":"https://api.github.com/users/benwulfe/gists{/gist_id}","starred_url":"https://api.github.com/users/benwulfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwulfe/subscriptions","organizations_url":"https://api.github.com/users/benwulfe/orgs","repos_url":"https://api.github.com/users/benwulfe/repos","events_url":"https://api.github.com/users/benwulfe/events{/privacy}","received_events_url":"https://api.github.com/users/benwulfe/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1135/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1135/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/1135/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/74e6eecc4903e32b392eaa8f0e9271fe2570e5ea","head":{"label":"benwulfe:cloud-spanner-multichannel","ref":"cloud-spanner-multichannel","sha":"74e6eecc4903e32b392eaa8f0e9271fe2570e5ea","user":{"login":"benwulfe","id":8314021,"avatar_url":"https://avatars0.githubusercontent.com/u/8314021?v=3","gravatar_id":"","url":"https://api.github.com/users/benwulfe","html_url":"https://github.com/benwulfe","followers_url":"https://api.github.com/users/benwulfe/followers","following_url":"https://api.github.com/users/benwulfe/following{/other_user}","gists_url":"https://api.github.com/users/benwulfe/gists{/gist_id}","starred_url":"https://api.github.com/users/benwulfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwulfe/subscriptions","organizations_url":"https://api.github.com/users/benwulfe/orgs","repos_url":"https://api.github.com/users/benwulfe/repos","events_url":"https://api.github.com/users/benwulfe/events{/privacy}","received_events_url":"https://api.github.com/users/benwulfe/received_events","type":"User","site_admin":false},"repo":{"id":87865964,"name":"google-cloud-dotnet","full_name":"benwulfe/google-cloud-dotnet","owner":{"login":"benwulfe","id":8314021,"avatar_url":"https://avatars0.githubusercontent.com/u/8314021?v=3","gravatar_id":"","url":"https://api.github.com/users/benwulfe","html_url":"https://github.com/benwulfe","followers_url":"https://api.github.com/users/benwulfe/followers","following_url":"https://api.github.com/users/benwulfe/following{/other_user}","gists_url":"https://api.github.com/users/benwulfe/gists{/gist_id}","starred_url":"https://api.github.com/users/benwulfe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benwulfe/subscriptions","organizations_url":"https://api.github.com/users/benwulfe/orgs","repos_url":"https://api.github.com/users/benwulfe/repos","events_url":"https://api.github.com/users/benwulfe/events{/privacy}","received_events_url":"https://api.github.com/users/benwulfe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/benwulfe/google-cloud-dotnet","description":"Google Cloud Client Library for .NET","fork":true,"url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet","forks_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/benwulfe/google-cloud-dotnet/deployments","created_at":"2017-04-10T23:12:07Z","updated_at":"2017-05-11T18:31:33Z","pushed_at":"2017-06-22T00:18:52Z","git_url":"git://github.com/benwulfe/google-cloud-dotnet.git","ssh_url":"git@github.com:benwulfe/google-cloud-dotnet.git","clone_url":"https://github.com/benwulfe/google-cloud-dotnet.git","svn_url":"https://github.com/benwulfe/google-cloud-dotnet","homepage":"https://googlecloudplatform.github.io/google-cloud-dotnet/","size":19338,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"f954f68f249513e2078732c43484080493f32690","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":35877412,"name":"google-cloud-dotnet","full_name":"GoogleCloudPlatform/google-cloud-dotnet","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars3.githubusercontent.com/u/2810941?v=3","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","description":"Google Cloud Client Libraries for .NET","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/deployments","created_at":"2015-05-19T11:14:02Z","updated_at":"2017-06-16T17:08:59Z","pushed_at":"2017-06-22T15:48:53Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-dotnet.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet","homepage":"https://googlecloudplatform.github.io/google-cloud-dotnet/","size":25788,"stargazers_count":129,"watchers_count":129,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":53,"mirror_url":null,"open_issues_count":44,"forks":53,"open_issues":44,"watchers":129,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1135"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-dotnet/pull/1135"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/1135"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/issues/1135/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1135/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/pulls/1135/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-dotnet/statuses/74e6eecc4903e32b392eaa8f0e9271fe2570e5ea"}}}}
{"actor":{"display_login":"benwulfe"}}