{"action":"created","comment":{"url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/comments/137216272","pull_request_review_id":60852121,"id":137216272,"diff_hunk":"@@ -0,0 +1,93 @@\n+define(['jquery'], function ($) {\n+  \n+  function initAutoComplete () {\n+\n+    if ($('.metis-autocomplete').length === 0) { return false; }\n+\n+      $('.metis-autocomplete').each(function(i, ac) {   \n+\n+      var orgInput = $(ac).find('.metis-autocomplete-wrap input');\n+\n+      if(orgInput.length > 0 && orgInput.data('autocomplete-url').length > 0) {\n+\n+        // add autocomplete\n+        addAutocomplete({\n+          autoCompleteEl: $(ac),\n+          selInput: orgInput,\n+          url: orgInput.data('autocomplete-url'),\n+          min_chars: orgInput.data('autocomplete-min-chars')\n+        });\n+\n+        // add remove action to tags/buttons\n+        $(ac).next('.metis-autocomplete-selected').find('.tag .icon-delete').on('click', function(){\n+          $(this).closest('.tag').remove();\n+        });\n+      }\n+    });\n+\n+  }\n+\n+  function addAutocomplete(options){\n+    require(['eu_autocomplete', 'util_resize'], function(Autocomplete){\n+\n+    var selInput = options.selInput;\n+    var selectedItems = options.autoCompleteEl.next('.metis-autocomplete-selected');\n+\n+    Autocomplete.init({\n+      evtResize       : 'europeanaResize',\n+      fnOnSelect     : function(sel) {\n+\n+      var val   = sel.data('term');\n+      var itemId = sel.data('id');","path":"source/js/modules/eu/pandora/pandora-autocomplete.js","position":41,"original_position":41,"commit_id":"89a0f7c9c157641709c9cdc73eeac2209210e358","original_commit_id":"89a0f7c9c157641709c9cdc73eeac2209210e358","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Expected indentation of 8 spaces but found 6  indent","created_at":"2017-09-06T09:27:13Z","updated_at":"2017-09-06T09:27:14Z","html_url":"https://github.com/europeana/Europeana-Patternlab/pull/230#discussion_r137216272","pull_request_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/230","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/comments/137216272"},"html":{"href":"https://github.com/europeana/Europeana-Patternlab/pull/230#discussion_r137216272"},"pull_request":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/230"}}},"pull_request":{"url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/230","id":139510210,"html_url":"https://github.com/europeana/Europeana-Patternlab/pull/230","diff_url":"https://github.com/europeana/Europeana-Patternlab/pull/230.diff","patch_url":"https://github.com/europeana/Europeana-Patternlab/pull/230.patch","issue_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/230","number":230,"state":"open","locked":false,"title":"Metis reorganisecss+2630","user":{"login":"mirjamverloop","id":30619959,"avatar_url":"https://avatars2.githubusercontent.com/u/30619959?v=4","gravatar_id":"","url":"https://api.github.com/users/mirjamverloop","html_url":"https://github.com/mirjamverloop","followers_url":"https://api.github.com/users/mirjamverloop/followers","following_url":"https://api.github.com/users/mirjamverloop/following{/other_user}","gists_url":"https://api.github.com/users/mirjamverloop/gists{/gist_id}","starred_url":"https://api.github.com/users/mirjamverloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mirjamverloop/subscriptions","organizations_url":"https://api.github.com/users/mirjamverloop/orgs","repos_url":"https://api.github.com/users/mirjamverloop/repos","events_url":"https://api.github.com/users/mirjamverloop/events{/privacy}","received_events_url":"https://api.github.com/users/mirjamverloop/received_events","type":"User","site_admin":false},"body":"- I started removing unused and duplicate code, made some code more generic and restructured the pandora css folder, I will continue doing this in the upcoming weeks and have a look at the pandora js files and folder as well\r\n\r\n- I created a seperate user profile page (mustache and json)\r\n\r\n- I made the autocomplete code (pandora-autocomplete.js) a bit more generic, and moved it from the pandora-home.js to the new file\r\n\r\n- I removed the unused autocomplete from the user profile page and removed the plugin from the lib folder, I will investigate if other pages also include the \"old\" autocomplete and replace it there as well\r\n\r\n- I changed all appearances of \"organisation\" to \"organization\" to make it more consistent throughout the pandora code, frontend and backend\r\n","created_at":"2017-09-06T09:16:42Z","updated_at":"2017-09-06T09:27:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e654ca30b6a1bb8da9dc13136285b96efcb608f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andyjmaclean","id":4441899,"avatar_url":"https://avatars3.githubusercontent.com/u/4441899?v=4","gravatar_id":"","url":"https://api.github.com/users/andyjmaclean","html_url":"https://github.com/andyjmaclean","followers_url":"https://api.github.com/users/andyjmaclean/followers","following_url":"https://api.github.com/users/andyjmaclean/following{/other_user}","gists_url":"https://api.github.com/users/andyjmaclean/gists{/gist_id}","starred_url":"https://api.github.com/users/andyjmaclean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyjmaclean/subscriptions","organizations_url":"https://api.github.com/users/andyjmaclean/orgs","repos_url":"https://api.github.com/users/andyjmaclean/repos","events_url":"https://api.github.com/users/andyjmaclean/events{/privacy}","received_events_url":"https://api.github.com/users/andyjmaclean/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/230/commits","review_comments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/230/comments","review_comment_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/230/comments","statuses_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/statuses/89a0f7c9c157641709c9cdc73eeac2209210e358","head":{"label":"europeana:metis-reorganisecss+2630","ref":"metis-reorganisecss+2630","sha":"89a0f7c9c157641709c9cdc73eeac2209210e358","user":{"login":"europeana","id":4570681,"avatar_url":"https://avatars3.githubusercontent.com/u/4570681?v=4","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"repo":{"id":14299552,"name":"Europeana-Patternlab","full_name":"europeana/Europeana-Patternlab","owner":{"login":"europeana","id":4570681,"avatar_url":"https://avatars3.githubusercontent.com/u/4570681?v=4","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/europeana/Europeana-Patternlab","description":"Source code for the Europeana Web Style Guide. ","fork":false,"url":"https://api.github.com/repos/europeana/Europeana-Patternlab","forks_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/forks","keys_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/teams","hooks_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/hooks","issue_events_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/events{/number}","events_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/events","assignees_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/assignees{/user}","branches_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/branches{/branch}","tags_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/tags","blobs_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/statuses/{sha}","languages_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/languages","stargazers_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/stargazers","contributors_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/contributors","subscribers_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/subscribers","subscription_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/subscription","commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/contents/{+path}","compare_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/merges","archive_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/downloads","issues_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues{/number}","pulls_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls{/number}","milestones_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/milestones{/number}","notifications_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/labels{/name}","releases_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/releases{/id}","deployments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/deployments","created_at":"2013-11-11T11:53:37Z","updated_at":"2017-07-21T20:47:05Z","pushed_at":"2017-09-06T09:26:41Z","git_url":"git://github.com/europeana/Europeana-Patternlab.git","ssh_url":"git@github.com:europeana/Europeana-Patternlab.git","clone_url":"https://github.com/europeana/Europeana-Patternlab.git","svn_url":"https://github.com/europeana/Europeana-Patternlab","homepage":"http://styleguide.europeana.eu/","size":213598,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":8,"default_branch":"develop"}},"base":{"label":"europeana:develop","ref":"develop","sha":"fa5bda2e555627ac64d9d0cdadd945046719f72d","user":{"login":"europeana","id":4570681,"avatar_url":"https://avatars3.githubusercontent.com/u/4570681?v=4","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"repo":{"id":14299552,"name":"Europeana-Patternlab","full_name":"europeana/Europeana-Patternlab","owner":{"login":"europeana","id":4570681,"avatar_url":"https://avatars3.githubusercontent.com/u/4570681?v=4","gravatar_id":"","url":"https://api.github.com/users/europeana","html_url":"https://github.com/europeana","followers_url":"https://api.github.com/users/europeana/followers","following_url":"https://api.github.com/users/europeana/following{/other_user}","gists_url":"https://api.github.com/users/europeana/gists{/gist_id}","starred_url":"https://api.github.com/users/europeana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/europeana/subscriptions","organizations_url":"https://api.github.com/users/europeana/orgs","repos_url":"https://api.github.com/users/europeana/repos","events_url":"https://api.github.com/users/europeana/events{/privacy}","received_events_url":"https://api.github.com/users/europeana/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/europeana/Europeana-Patternlab","description":"Source code for the Europeana Web Style Guide. ","fork":false,"url":"https://api.github.com/repos/europeana/Europeana-Patternlab","forks_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/forks","keys_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/teams","hooks_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/hooks","issue_events_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/events{/number}","events_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/events","assignees_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/assignees{/user}","branches_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/branches{/branch}","tags_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/tags","blobs_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/statuses/{sha}","languages_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/languages","stargazers_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/stargazers","contributors_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/contributors","subscribers_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/subscribers","subscription_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/subscription","commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/contents/{+path}","compare_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/merges","archive_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/downloads","issues_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues{/number}","pulls_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls{/number}","milestones_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/milestones{/number}","notifications_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/labels{/name}","releases_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/releases{/id}","deployments_url":"https://api.github.com/repos/europeana/Europeana-Patternlab/deployments","created_at":"2013-11-11T11:53:37Z","updated_at":"2017-07-21T20:47:05Z","pushed_at":"2017-09-06T09:26:41Z","git_url":"git://github.com/europeana/Europeana-Patternlab.git","ssh_url":"git@github.com:europeana/Europeana-Patternlab.git","clone_url":"https://github.com/europeana/Europeana-Patternlab.git","svn_url":"https://github.com/europeana/Europeana-Patternlab","homepage":"http://styleguide.europeana.eu/","size":213598,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":8,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/230"},"html":{"href":"https://github.com/europeana/Europeana-Patternlab/pull/230"},"issue":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/230"},"comments":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/europeana/Europeana-Patternlab/statuses/89a0f7c9c157641709c9cdc73eeac2209210e358"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}