{"action":"created","comment":{"url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/comments/100725762","pull_request_review_id":21438833,"id":100725762,"diff_hunk":"@@ -23,6 +24,16 @@ describe('Response', function () {\n             expect(jsonified).to.have.property('cookie');\n         });\n \n+        it('must retain Buffer nature on stream property after new Response(response.toJSON())', function () {\n+            var rawResponse = {\n+                    body: 'response body',","path":"test/unit/response.test.js","position":14,"original_position":14,"commit_id":"b5e9ea600acea78f97df3d2a4837e7660dbd5bb1","original_commit_id":"b5e9ea600acea78f97df3d2a4837e7660dbd5bb1","user":{"login":"kamalaknn","id":8401064,"avatar_url":"https://avatars.githubusercontent.com/u/8401064?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalaknn","html_url":"https://github.com/kamalaknn","followers_url":"https://api.github.com/users/kamalaknn/followers","following_url":"https://api.github.com/users/kamalaknn/following{/other_user}","gists_url":"https://api.github.com/users/kamalaknn/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalaknn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalaknn/subscriptions","organizations_url":"https://api.github.com/users/kamalaknn/orgs","repos_url":"https://api.github.com/users/kamalaknn/repos","events_url":"https://api.github.com/users/kamalaknn/events{/privacy}","received_events_url":"https://api.github.com/users/kamalaknn/received_events","type":"User","site_admin":false},"body":"The reason I did not want to add an explicit test for the above case, is because we are not really interested in supporting a `{ type: 'Buffer', data: [] }`. What is more important, is to ensure `response` and `new Response(response.toJSON())` are the same, i.e. response instance is properly serialised and deserialised back without loosing data. Which is what the added test ensures.","created_at":"2017-02-13T05:20:52Z","updated_at":"2017-02-13T05:20:52Z","html_url":"https://github.com/postmanlabs/postman-collection/pull/271#discussion_r100725762","pull_request_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/271","_links":{"self":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/comments/100725762"},"html":{"href":"https://github.com/postmanlabs/postman-collection/pull/271#discussion_r100725762"},"pull_request":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/271"}}},"pull_request":{"url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/271","id":105209048,"html_url":"https://github.com/postmanlabs/postman-collection/pull/271","diff_url":"https://github.com/postmanlabs/postman-collection/pull/271.diff","patch_url":"https://github.com/postmanlabs/postman-collection/pull/271.patch","issue_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues/271","number":271,"state":"closed","locked":false,"title":"Allow options.stream to be a new Buffer().toJSON()","user":{"login":"kamalaknn","id":8401064,"avatar_url":"https://avatars.githubusercontent.com/u/8401064?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalaknn","html_url":"https://github.com/kamalaknn","followers_url":"https://api.github.com/users/kamalaknn/followers","following_url":"https://api.github.com/users/kamalaknn/following{/other_user}","gists_url":"https://api.github.com/users/kamalaknn/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalaknn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalaknn/subscriptions","organizations_url":"https://api.github.com/users/kamalaknn/orgs","repos_url":"https://api.github.com/users/kamalaknn/repos","events_url":"https://api.github.com/users/kamalaknn/events{/privacy}","received_events_url":"https://api.github.com/users/kamalaknn/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-08T12:41:05Z","updated_at":"2017-02-13T05:20:52Z","closed_at":"2017-02-10T11:53:51Z","merged_at":"2017-02-10T11:53:51Z","merge_commit_sha":"9c0fc782f2ebe4bc633e6d697ebf7f5e0e000a3d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/271/commits","review_comments_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/271/comments","review_comment_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues/271/comments","statuses_url":"https://api.github.com/repos/postmanlabs/postman-collection/statuses/b5e9ea600acea78f97df3d2a4837e7660dbd5bb1","head":{"label":"kamalaknn:preserve-response-stream","ref":"preserve-response-stream","sha":"b5e9ea600acea78f97df3d2a4837e7660dbd5bb1","user":{"login":"kamalaknn","id":8401064,"avatar_url":"https://avatars.githubusercontent.com/u/8401064?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalaknn","html_url":"https://github.com/kamalaknn","followers_url":"https://api.github.com/users/kamalaknn/followers","following_url":"https://api.github.com/users/kamalaknn/following{/other_user}","gists_url":"https://api.github.com/users/kamalaknn/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalaknn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalaknn/subscriptions","organizations_url":"https://api.github.com/users/kamalaknn/orgs","repos_url":"https://api.github.com/users/kamalaknn/repos","events_url":"https://api.github.com/users/kamalaknn/events{/privacy}","received_events_url":"https://api.github.com/users/kamalaknn/received_events","type":"User","site_admin":false},"repo":{"id":81325985,"name":"postman-collection","full_name":"kamalaknn/postman-collection","owner":{"login":"kamalaknn","id":8401064,"avatar_url":"https://avatars.githubusercontent.com/u/8401064?v=3","gravatar_id":"","url":"https://api.github.com/users/kamalaknn","html_url":"https://github.com/kamalaknn","followers_url":"https://api.github.com/users/kamalaknn/followers","following_url":"https://api.github.com/users/kamalaknn/following{/other_user}","gists_url":"https://api.github.com/users/kamalaknn/gists{/gist_id}","starred_url":"https://api.github.com/users/kamalaknn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamalaknn/subscriptions","organizations_url":"https://api.github.com/users/kamalaknn/orgs","repos_url":"https://api.github.com/users/kamalaknn/repos","events_url":"https://api.github.com/users/kamalaknn/events{/privacy}","received_events_url":"https://api.github.com/users/kamalaknn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kamalaknn/postman-collection","description":"Javascript module that allows a developer to work with Postman Collections","fork":true,"url":"https://api.github.com/repos/kamalaknn/postman-collection","forks_url":"https://api.github.com/repos/kamalaknn/postman-collection/forks","keys_url":"https://api.github.com/repos/kamalaknn/postman-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kamalaknn/postman-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kamalaknn/postman-collection/teams","hooks_url":"https://api.github.com/repos/kamalaknn/postman-collection/hooks","issue_events_url":"https://api.github.com/repos/kamalaknn/postman-collection/issues/events{/number}","events_url":"https://api.github.com/repos/kamalaknn/postman-collection/events","assignees_url":"https://api.github.com/repos/kamalaknn/postman-collection/assignees{/user}","branches_url":"https://api.github.com/repos/kamalaknn/postman-collection/branches{/branch}","tags_url":"https://api.github.com/repos/kamalaknn/postman-collection/tags","blobs_url":"https://api.github.com/repos/kamalaknn/postman-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kamalaknn/postman-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kamalaknn/postman-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/kamalaknn/postman-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kamalaknn/postman-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/kamalaknn/postman-collection/languages","stargazers_url":"https://api.github.com/repos/kamalaknn/postman-collection/stargazers","contributors_url":"https://api.github.com/repos/kamalaknn/postman-collection/contributors","subscribers_url":"https://api.github.com/repos/kamalaknn/postman-collection/subscribers","subscription_url":"https://api.github.com/repos/kamalaknn/postman-collection/subscription","commits_url":"https://api.github.com/repos/kamalaknn/postman-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/kamalaknn/postman-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/kamalaknn/postman-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/kamalaknn/postman-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/kamalaknn/postman-collection/contents/{+path}","compare_url":"https://api.github.com/repos/kamalaknn/postman-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kamalaknn/postman-collection/merges","archive_url":"https://api.github.com/repos/kamalaknn/postman-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kamalaknn/postman-collection/downloads","issues_url":"https://api.github.com/repos/kamalaknn/postman-collection/issues{/number}","pulls_url":"https://api.github.com/repos/kamalaknn/postman-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/kamalaknn/postman-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/kamalaknn/postman-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kamalaknn/postman-collection/labels{/name}","releases_url":"https://api.github.com/repos/kamalaknn/postman-collection/releases{/id}","deployments_url":"https://api.github.com/repos/kamalaknn/postman-collection/deployments","created_at":"2017-02-08T12:06:44Z","updated_at":"2017-02-08T12:06:47Z","pushed_at":"2017-02-13T05:16:58Z","git_url":"git://github.com/kamalaknn/postman-collection.git","ssh_url":"git@github.com:kamalaknn/postman-collection.git","clone_url":"https://github.com/kamalaknn/postman-collection.git","svn_url":"https://github.com/kamalaknn/postman-collection","homepage":"https://www.getpostman.com/","size":884,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"postmanlabs:develop","ref":"develop","sha":"f03e65075be89558016c541f94f4c6bf99cd38fe","user":{"login":"postmanlabs","id":10251060,"avatar_url":"https://avatars.githubusercontent.com/u/10251060?v=3","gravatar_id":"","url":"https://api.github.com/users/postmanlabs","html_url":"https://github.com/postmanlabs","followers_url":"https://api.github.com/users/postmanlabs/followers","following_url":"https://api.github.com/users/postmanlabs/following{/other_user}","gists_url":"https://api.github.com/users/postmanlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/postmanlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmanlabs/subscriptions","organizations_url":"https://api.github.com/users/postmanlabs/orgs","repos_url":"https://api.github.com/users/postmanlabs/repos","events_url":"https://api.github.com/users/postmanlabs/events{/privacy}","received_events_url":"https://api.github.com/users/postmanlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":52270857,"name":"postman-collection","full_name":"postmanlabs/postman-collection","owner":{"login":"postmanlabs","id":10251060,"avatar_url":"https://avatars.githubusercontent.com/u/10251060?v=3","gravatar_id":"","url":"https://api.github.com/users/postmanlabs","html_url":"https://github.com/postmanlabs","followers_url":"https://api.github.com/users/postmanlabs/followers","following_url":"https://api.github.com/users/postmanlabs/following{/other_user}","gists_url":"https://api.github.com/users/postmanlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/postmanlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/postmanlabs/subscriptions","organizations_url":"https://api.github.com/users/postmanlabs/orgs","repos_url":"https://api.github.com/users/postmanlabs/repos","events_url":"https://api.github.com/users/postmanlabs/events{/privacy}","received_events_url":"https://api.github.com/users/postmanlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/postmanlabs/postman-collection","description":"Javascript module that allows a developer to work with Postman Collections","fork":false,"url":"https://api.github.com/repos/postmanlabs/postman-collection","forks_url":"https://api.github.com/repos/postmanlabs/postman-collection/forks","keys_url":"https://api.github.com/repos/postmanlabs/postman-collection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/postmanlabs/postman-collection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/postmanlabs/postman-collection/teams","hooks_url":"https://api.github.com/repos/postmanlabs/postman-collection/hooks","issue_events_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues/events{/number}","events_url":"https://api.github.com/repos/postmanlabs/postman-collection/events","assignees_url":"https://api.github.com/repos/postmanlabs/postman-collection/assignees{/user}","branches_url":"https://api.github.com/repos/postmanlabs/postman-collection/branches{/branch}","tags_url":"https://api.github.com/repos/postmanlabs/postman-collection/tags","blobs_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/refs{/sha}","trees_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/postmanlabs/postman-collection/statuses/{sha}","languages_url":"https://api.github.com/repos/postmanlabs/postman-collection/languages","stargazers_url":"https://api.github.com/repos/postmanlabs/postman-collection/stargazers","contributors_url":"https://api.github.com/repos/postmanlabs/postman-collection/contributors","subscribers_url":"https://api.github.com/repos/postmanlabs/postman-collection/subscribers","subscription_url":"https://api.github.com/repos/postmanlabs/postman-collection/subscription","commits_url":"https://api.github.com/repos/postmanlabs/postman-collection/commits{/sha}","git_commits_url":"https://api.github.com/repos/postmanlabs/postman-collection/git/commits{/sha}","comments_url":"https://api.github.com/repos/postmanlabs/postman-collection/comments{/number}","issue_comment_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues/comments{/number}","contents_url":"https://api.github.com/repos/postmanlabs/postman-collection/contents/{+path}","compare_url":"https://api.github.com/repos/postmanlabs/postman-collection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/postmanlabs/postman-collection/merges","archive_url":"https://api.github.com/repos/postmanlabs/postman-collection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/postmanlabs/postman-collection/downloads","issues_url":"https://api.github.com/repos/postmanlabs/postman-collection/issues{/number}","pulls_url":"https://api.github.com/repos/postmanlabs/postman-collection/pulls{/number}","milestones_url":"https://api.github.com/repos/postmanlabs/postman-collection/milestones{/number}","notifications_url":"https://api.github.com/repos/postmanlabs/postman-collection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/postmanlabs/postman-collection/labels{/name}","releases_url":"https://api.github.com/repos/postmanlabs/postman-collection/releases{/id}","deployments_url":"https://api.github.com/repos/postmanlabs/postman-collection/deployments","created_at":"2016-02-22T12:08:36Z","updated_at":"2017-02-10T09:41:50Z","pushed_at":"2017-02-10T11:53:51Z","git_url":"git://github.com/postmanlabs/postman-collection.git","ssh_url":"git@github.com:postmanlabs/postman-collection.git","clone_url":"https://github.com/postmanlabs/postman-collection.git","svn_url":"https://github.com/postmanlabs/postman-collection","homepage":"https://www.getpostman.com/","size":885,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":23,"mirror_url":null,"open_issues_count":22,"forks":23,"open_issues":22,"watchers":40,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/271"},"html":{"href":"https://github.com/postmanlabs/postman-collection/pull/271"},"issue":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/issues/271"},"comments":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/issues/271/comments"},"review_comments":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/271/comments"},"review_comment":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/pulls/271/commits"},"statuses":{"href":"https://api.github.com/repos/postmanlabs/postman-collection/statuses/b5e9ea600acea78f97df3d2a4837e7660dbd5bb1"}}}}
{"actor":{"display_login":"kamalaknn"}}