{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/framework/issues/9055","repository_url":"https://api.github.com/repos/vaadin/framework","labels_url":"https://api.github.com/repos/vaadin/framework/issues/9055/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/framework/issues/9055/comments","events_url":"https://api.github.com/repos/vaadin/framework/issues/9055/events","html_url":"https://github.com/vaadin/framework/pull/9055","id":220911217,"number":9055,"title":"Grid drag and drop documentation","user":{"login":"wbadam","id":15823229,"avatar_url":"https://avatars0.githubusercontent.com/u/15823229?v=3","gravatar_id":"","url":"https://api.github.com/users/wbadam","html_url":"https://github.com/wbadam","followers_url":"https://api.github.com/users/wbadam/followers","following_url":"https://api.github.com/users/wbadam/following{/other_user}","gists_url":"https://api.github.com/users/wbadam/gists{/gist_id}","starred_url":"https://api.github.com/users/wbadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbadam/subscriptions","organizations_url":"https://api.github.com/users/wbadam/orgs","repos_url":"https://api.github.com/users/wbadam/repos","events_url":"https://api.github.com/users/wbadam/events{/privacy}","received_events_url":"https://api.github.com/users/wbadam/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-04-11T10:47:22Z","updated_at":"2017-04-12T12:07:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/vaadin/framework/pulls/9055","html_url":"https://github.com/vaadin/framework/pull/9055","diff_url":"https://github.com/vaadin/framework/pull/9055.diff","patch_url":"https://github.com/vaadin/framework/pull/9055.patch"},"body":"Part of issue #8399\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/framework/9055)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/framework/issues/comments/293556405","html_url":"https://github.com/vaadin/framework/pull/9055#issuecomment-293556405","issue_url":"https://api.github.com/repos/vaadin/framework/issues/9055","id":293556405,"user":{"login":"wbadam","id":15823229,"avatar_url":"https://avatars0.githubusercontent.com/u/15823229?v=3","gravatar_id":"","url":"https://api.github.com/users/wbadam","html_url":"https://github.com/wbadam","followers_url":"https://api.github.com/users/wbadam/followers","following_url":"https://api.github.com/users/wbadam/following{/other_user}","gists_url":"https://api.github.com/users/wbadam/gists{/gist_id}","starred_url":"https://api.github.com/users/wbadam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbadam/subscriptions","organizations_url":"https://api.github.com/users/wbadam/orgs","repos_url":"https://api.github.com/users/wbadam/repos","events_url":"https://api.github.com/users/wbadam/events{/privacy}","received_events_url":"https://api.github.com/users/wbadam/received_events","type":"User","site_admin":false},"created_at":"2017-04-12T12:07:00Z","updated_at":"2017-04-12T12:07:00Z","body":"\n\n\n\nReview status: all files reviewed at latest revision, 5 unresolved discussions, some commit checks failed.\n\n---\n\n*[documentation/advanced/advanced-dragndrop.asciidoc, line 177 at r3](https://reviewable.io:443/reviews/vaadin/framework/9055#-KhW-KK3EK-RC7DHPFAl:-KhX1rqu2yC-bHKR1j-L:b-gdn7jz) ([raw file](https://github.com/vaadin/framework/blob/2f029385040793211fafb3f57fc4bc78edbe0174/documentation/advanced/advanced-dragndrop.asciidoc#L177)):*\n<details><summary><i>Previously, pleku (Pekka Hyvönen) wrote…</i></summary><blockquote>\n\n> `GridConnector.getDataSource().getRow(index)` method.\n\nThis basically tells nothing and forces people to look up what that is. While it is also a good thing, I'd prefer to explain it here a bit, e.g.:\n\", the whole row data as JSON is transferred. You can look up the format from the foobar method.\"\n</blockquote></details>\n\nWent a slightly different way, take a look and see if you like it\n\n---\n\n*[documentation/advanced/advanced-dragndrop.asciidoc, line 215 at r3](https://reviewable.io:443/reviews/vaadin/framework/9055#-KhW1ayo8ymf25-lfbtq:-KhWmftY5HeHKQ7wlQyW:by64cwn) ([raw file](https://github.com/vaadin/framework/blob/2f029385040793211fafb3f57fc4bc78edbe0174/documentation/advanced/advanced-dragndrop.asciidoc#L215)):*\n<details><summary><i>Previously, pleku (Pekka Hyvönen) wrote…</i></summary><blockquote>\n\n> Bean\n\noops, please do a search and replace all in these code samples\n</blockquote></details>\n\nWeird, I thought I did a search. Anyway, gone now.\n\n---\n\n*[documentation/advanced/advanced-dragndrop.asciidoc, line 244 at r3](https://reviewable.io:443/reviews/vaadin/framework/9055#-KhW-uVZolwApcleZp0Y:-KhWnN4QFYeC-2UJScTw:b-82figj) ([raw file](https://github.com/vaadin/framework/blob/2f029385040793211fafb3f57fc4bc78edbe0174/documentation/advanced/advanced-dragndrop.asciidoc#L244)):*\n<details><summary><i>Previously, pleku (Pekka Hyvönen) wrote…</i></summary><blockquote>\n\nThis seems a bit weird in this context, you might replace this with \n```java\n// Show the dropped data\nNotification.show(\"Dropped row data: \" + event.getDataTransferText());\n```\n\nor just remove completely from here\n</blockquote></details>\n\nI wanted to include that so that it would be documented how to get the drag data since it is not obvious.\nI think better leave it and I also mentioned it in the description for clarity's sake\n\n---\n\n*[documentation/components/components-grid.asciidoc, line 851 at r3](https://reviewable.io:443/reviews/vaadin/framework/9055#-KhW0ZLPaBP_7AqhI0Vg:-KhX2Ikz5bYqmH8oA7LM:b-896fix) ([raw file](https://github.com/vaadin/framework/blob/2f029385040793211fafb3f57fc4bc78edbe0174/documentation/components/components-grid.asciidoc#L851)):*\n<details><summary><i>Previously, pleku (Pekka Hyvönen) wrote…</i></summary><blockquote>\n\n>  Drag and Drop Rows\n\nDrag and Drop of Rows\n</blockquote></details>\n\nDone.\n\n---\n\n*[documentation/components/components-grid.asciidoc, line 854 at r3](https://reviewable.io:443/reviews/vaadin/framework/9055#-KhW0N7hTCERKqbej96Q:-KhX2aTC8TUtG28TNB12:b-896fix) ([raw file](https://github.com/vaadin/framework/blob/2f029385040793211fafb3f57fc4bc78edbe0174/documentation/components/components-grid.asciidoc#L854)):*\n<details><summary><i>Previously, pleku (Pekka Hyvönen) wrote…</i></summary><blockquote>\n\n> \"Drag and Drop documentation\"\n\nUsually we have the exact same header title in the link, here it would be \"Drag and Drop Rows in Grid\"\n</blockquote></details>\n\nDone.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/vaadin/framework/9055)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"wbadam"}}