{"action":"created","comment":{"url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/comments/133425631","pull_request_review_id":56600875,"id":133425631,"diff_hunk":"@@ -4,75 +4,231 @@\n \"\"\"\n from collections import OrderedDict\n \n-import numpy\n+import numpy as np\n \n-from tvb_epilepsy.base.h5_model import prepare_for_h5\n-from tvb_epilepsy.base.utils import formal_repr\n+from tvb_epilepsy.base.utils import initialize_logger, formal_repr, ensure_list, dicts_of_lists_to_lists_of_dicts, \\\n+                                    linear_index_to_coordinate_tuples\n+from tvb_epilepsy.base.h5_model import convert_to_h5_model\n+\n+from tvb_epilepsy.base.model_configuration import ModelConfiguration","path":"tvb_epilepsy/base/disease_hypothesis.py","position":13,"original_position":13,"commit_id":"400346c6e507732677ecd8367b1a48d876fea29b","original_commit_id":"400346c6e507732677ecd8367b1a48d876fea29b","user":{"login":"liadomide","id":674853,"avatar_url":"https://avatars3.githubusercontent.com/u/674853?v=4","gravatar_id":"","url":"https://api.github.com/users/liadomide","html_url":"https://github.com/liadomide","followers_url":"https://api.github.com/users/liadomide/followers","following_url":"https://api.github.com/users/liadomide/following{/other_user}","gists_url":"https://api.github.com/users/liadomide/gists{/gist_id}","starred_url":"https://api.github.com/users/liadomide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liadomide/subscriptions","organizations_url":"https://api.github.com/users/liadomide/orgs","repos_url":"https://api.github.com/users/liadomide/repos","events_url":"https://api.github.com/users/liadomide/events{/privacy}","received_events_url":"https://api.github.com/users/liadomide/received_events","type":"User","site_admin":false},"body":"This import should not be here! \r\nIt ruins the architectural design of the package (a ModelConfiguration is built after and from a Hypothesis, we should not require it back here)","created_at":"2017-08-16T11:42:03Z","updated_at":"2017-08-16T12:02:03Z","html_url":"https://github.com/the-virtual-brain/tvb-epilepsy/pull/6#discussion_r133425631","pull_request_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/6","_links":{"self":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/comments/133425631"},"html":{"href":"https://github.com/the-virtual-brain/tvb-epilepsy/pull/6#discussion_r133425631"},"pull_request":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/6","id":135964064,"html_url":"https://github.com/the-virtual-brain/tvb-epilepsy/pull/6","diff_url":"https://github.com/the-virtual-brain/tvb-epilepsy/pull/6.diff","patch_url":"https://github.com/the-virtual-brain/tvb-epilepsy/pull/6.patch","issue_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues/6","number":6,"state":"open","locked":false,"title":"Update branch review","user":{"login":"popaula937","id":22170448,"avatar_url":"https://avatars1.githubusercontent.com/u/22170448?v=4","gravatar_id":"","url":"https://api.github.com/users/popaula937","html_url":"https://github.com/popaula937","followers_url":"https://api.github.com/users/popaula937/followers","following_url":"https://api.github.com/users/popaula937/following{/other_user}","gists_url":"https://api.github.com/users/popaula937/gists{/gist_id}","starred_url":"https://api.github.com/users/popaula937/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/popaula937/subscriptions","organizations_url":"https://api.github.com/users/popaula937/orgs","repos_url":"https://api.github.com/users/popaula937/repos","events_url":"https://api.github.com/users/popaula937/events{/privacy}","received_events_url":"https://api.github.com/users/popaula937/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-16T08:08:09Z","updated_at":"2017-08-16T12:02:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b32e87408be0d13f61d80dc8b2333d5d675596b6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/6/commits","review_comments_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/6/comments","review_comment_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues/6/comments","statuses_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/statuses/400346c6e507732677ecd8367b1a48d876fea29b","head":{"label":"the-virtual-brain:master","ref":"master","sha":"400346c6e507732677ecd8367b1a48d876fea29b","user":{"login":"the-virtual-brain","id":3657317,"avatar_url":"https://avatars3.githubusercontent.com/u/3657317?v=4","gravatar_id":"","url":"https://api.github.com/users/the-virtual-brain","html_url":"https://github.com/the-virtual-brain","followers_url":"https://api.github.com/users/the-virtual-brain/followers","following_url":"https://api.github.com/users/the-virtual-brain/following{/other_user}","gists_url":"https://api.github.com/users/the-virtual-brain/gists{/gist_id}","starred_url":"https://api.github.com/users/the-virtual-brain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-virtual-brain/subscriptions","organizations_url":"https://api.github.com/users/the-virtual-brain/orgs","repos_url":"https://api.github.com/users/the-virtual-brain/repos","events_url":"https://api.github.com/users/the-virtual-brain/events{/privacy}","received_events_url":"https://api.github.com/users/the-virtual-brain/received_events","type":"Organization","site_admin":false},"repo":{"id":80632814,"name":"tvb-epilepsy","full_name":"the-virtual-brain/tvb-epilepsy","owner":{"login":"the-virtual-brain","id":3657317,"avatar_url":"https://avatars3.githubusercontent.com/u/3657317?v=4","gravatar_id":"","url":"https://api.github.com/users/the-virtual-brain","html_url":"https://github.com/the-virtual-brain","followers_url":"https://api.github.com/users/the-virtual-brain/followers","following_url":"https://api.github.com/users/the-virtual-brain/following{/other_user}","gists_url":"https://api.github.com/users/the-virtual-brain/gists{/gist_id}","starred_url":"https://api.github.com/users/the-virtual-brain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-virtual-brain/subscriptions","organizations_url":"https://api.github.com/users/the-virtual-brain/orgs","repos_url":"https://api.github.com/users/the-virtual-brain/repos","events_url":"https://api.github.com/users/the-virtual-brain/events{/privacy}","received_events_url":"https://api.github.com/users/the-virtual-brain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-virtual-brain/tvb-epilepsy","description":"TVB applications to epilepsy","fork":false,"url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy","forks_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/forks","keys_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/teams","hooks_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/hooks","issue_events_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues/events{/number}","events_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/events","assignees_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/assignees{/user}","branches_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/branches{/branch}","tags_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/tags","blobs_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/statuses/{sha}","languages_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/languages","stargazers_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/stargazers","contributors_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/contributors","subscribers_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/subscribers","subscription_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/subscription","commits_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/contents/{+path}","compare_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/merges","archive_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/downloads","issues_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues{/number}","pulls_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls{/number}","milestones_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/milestones{/number}","notifications_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/labels{/name}","releases_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/releases{/id}","deployments_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/deployments","created_at":"2017-02-01T15:22:12Z","updated_at":"2017-07-11T18:02:02Z","pushed_at":"2017-08-16T08:08:09Z","git_url":"git://github.com/the-virtual-brain/tvb-epilepsy.git","ssh_url":"git@github.com:the-virtual-brain/tvb-epilepsy.git","clone_url":"https://github.com/the-virtual-brain/tvb-epilepsy.git","svn_url":"https://github.com/the-virtual-brain/tvb-epilepsy","homepage":null,"size":38575,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"base":{"label":"the-virtual-brain:review","ref":"review","sha":"2e26d2b4b4f04236d294697977d8253231b4aefa","user":{"login":"the-virtual-brain","id":3657317,"avatar_url":"https://avatars3.githubusercontent.com/u/3657317?v=4","gravatar_id":"","url":"https://api.github.com/users/the-virtual-brain","html_url":"https://github.com/the-virtual-brain","followers_url":"https://api.github.com/users/the-virtual-brain/followers","following_url":"https://api.github.com/users/the-virtual-brain/following{/other_user}","gists_url":"https://api.github.com/users/the-virtual-brain/gists{/gist_id}","starred_url":"https://api.github.com/users/the-virtual-brain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-virtual-brain/subscriptions","organizations_url":"https://api.github.com/users/the-virtual-brain/orgs","repos_url":"https://api.github.com/users/the-virtual-brain/repos","events_url":"https://api.github.com/users/the-virtual-brain/events{/privacy}","received_events_url":"https://api.github.com/users/the-virtual-brain/received_events","type":"Organization","site_admin":false},"repo":{"id":80632814,"name":"tvb-epilepsy","full_name":"the-virtual-brain/tvb-epilepsy","owner":{"login":"the-virtual-brain","id":3657317,"avatar_url":"https://avatars3.githubusercontent.com/u/3657317?v=4","gravatar_id":"","url":"https://api.github.com/users/the-virtual-brain","html_url":"https://github.com/the-virtual-brain","followers_url":"https://api.github.com/users/the-virtual-brain/followers","following_url":"https://api.github.com/users/the-virtual-brain/following{/other_user}","gists_url":"https://api.github.com/users/the-virtual-brain/gists{/gist_id}","starred_url":"https://api.github.com/users/the-virtual-brain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/the-virtual-brain/subscriptions","organizations_url":"https://api.github.com/users/the-virtual-brain/orgs","repos_url":"https://api.github.com/users/the-virtual-brain/repos","events_url":"https://api.github.com/users/the-virtual-brain/events{/privacy}","received_events_url":"https://api.github.com/users/the-virtual-brain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/the-virtual-brain/tvb-epilepsy","description":"TVB applications to epilepsy","fork":false,"url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy","forks_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/forks","keys_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/teams","hooks_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/hooks","issue_events_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues/events{/number}","events_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/events","assignees_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/assignees{/user}","branches_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/branches{/branch}","tags_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/tags","blobs_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/refs{/sha}","trees_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/statuses/{sha}","languages_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/languages","stargazers_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/stargazers","contributors_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/contributors","subscribers_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/subscribers","subscription_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/subscription","commits_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/commits{/sha}","git_commits_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/git/commits{/sha}","comments_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/comments{/number}","issue_comment_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues/comments{/number}","contents_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/contents/{+path}","compare_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/merges","archive_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/downloads","issues_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues{/number}","pulls_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls{/number}","milestones_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/milestones{/number}","notifications_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/labels{/name}","releases_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/releases{/id}","deployments_url":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/deployments","created_at":"2017-02-01T15:22:12Z","updated_at":"2017-07-11T18:02:02Z","pushed_at":"2017-08-16T08:08:09Z","git_url":"git://github.com/the-virtual-brain/tvb-epilepsy.git","ssh_url":"git@github.com:the-virtual-brain/tvb-epilepsy.git","clone_url":"https://github.com/the-virtual-brain/tvb-epilepsy.git","svn_url":"https://github.com/the-virtual-brain/tvb-epilepsy","homepage":null,"size":38575,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/6"},"html":{"href":"https://github.com/the-virtual-brain/tvb-epilepsy/pull/6"},"issue":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues/6"},"comments":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/the-virtual-brain/tvb-epilepsy/statuses/400346c6e507732677ecd8367b1a48d876fea29b"}}}}
{"actor":{"display_login":"liadomide"}}