{"push_id":1941370848,"size":6,"distinct_size":2,"ref":"refs/heads/leave-group-api","head":"e4fd519fb473bf8233d58f5e7c76125356ac563a","before":"41aec1291d6c93bd5928808a90aad64630eb4307","commits":[{"sha":"43bc7228352bd2391e5532ff1c23700dcd5581cf","author":{"name":"Robert Knight","email":"d3a75f012596346a1e294e73943b7403ef1e26c3@gmail.com"},"message":"Remove \"oauthAuthorizeUrl\" and \"oauthRevokeUrl\" from sidebar config\n\nRemove the \"oauthAuthorizeUrl\" and \"oauthRevokeUrl\" keys from the JSON\nconfig that is rendered into the client's sidebar HTML page.\n\nThese URLs are now available via the `/api/links` endpoint.","distinct":false,"url":"https://api.github.com/repos/hypothesis/h/commits/43bc7228352bd2391e5532ff1c23700dcd5581cf"},{"sha":"5efcd65ff1f32031666d91d759d49305f4cf33a7","author":{"name":"Robert Knight","email":"d3a75f012596346a1e294e73943b7403ef1e26c3@gmail.com"},"message":"Merge pull request #4632 from hypothesis/remove-oauth-config-from-sidebar-html\n\nRemove \"oauthAuthorizeUrl\" and \"oauthRevokeUrl\" from sidebar config","distinct":false,"url":"https://api.github.com/repos/hypothesis/h/commits/5efcd65ff1f32031666d91d759d49305f4cf33a7"},{"sha":"3092f47eaa52e21ad5fc97c3b90a72fed0639416","author":{"name":"David Thompson","email":"dc99377e52a8b32a88b872bc577a683a1260c8e7@hypothes.is"},"message":"Add a functional test for the API index\n\nAn unrelated-looking code change caused this view to break, and none of\nour automated tests caught the problem.","distinct":false,"url":"https://api.github.com/repos/hypothesis/h/commits/3092f47eaa52e21ad5fc97c3b90a72fed0639416"},{"sha":"e65789058d7049173c3c73c68b61c58060484ac6","author":{"name":"Robert Knight","email":"d3a75f012596346a1e294e73943b7403ef1e26c3@gmail.com"},"message":"Merge pull request #4634 from hypothesis/api-index-functional-test\n\nAdd a functional test for the API index","distinct":false,"url":"https://api.github.com/repos/hypothesis/h/commits/e65789058d7049173c3c73c68b61c58060484ac6"},{"sha":"94c311393435ea85ba29a3f2a1190eecadeb52dd","author":{"name":"David Thompson","email":"dc99377e52a8b32a88b872bc577a683a1260c8e7@hypothes.is"},"message":"Add a functional test for the API to leave groups","distinct":true,"url":"https://api.github.com/repos/hypothesis/h/commits/94c311393435ea85ba29a3f2a1190eecadeb52dd"},{"sha":"e4fd519fb473bf8233d58f5e7c76125356ac563a","author":{"name":"David Thompson","email":"dc99377e52a8b32a88b872bc577a683a1260c8e7@hypothes.is"},"message":"Add a way to leave groups through the API\n\nAs we shift our login from a cookie-based system to a token-based one,\nwe need a way to leave a group with only an access token, supplementing\nand ultimately replacing the cookie-authenticated method that exists at\nthe moment[1].\n\n[1]: https://github.com/hypothesis/h/blob/d8928aa6/h/views/groups.py#L127-L137\n\nThe URL structure of this API is designed to fit into a future world\nwhere groups are treated as first-class resources in the API, based on\nthe proposal @nickstenning wrote before he left Hypothesis[2].\nCurrently, the only user we support removing from the group is the\nrequesting user (represented with the shorthand value \"me\", rather than\na user ID), but we can expand this in the future to allow removal of\narbitrary users from groups.\n\n[2]: https://notes.wtk.io/2017/07/24/api-scribblings\n\nIn line with the previous implementation, this endpoint returns an empty\n`204` response, whether the requesting user was initially a member of\nthe group or not. At some point, we may need to revisit this decision:\nfor instance, if we decide to implement groups that are not visible to\nanyone who knows their slug, then this could be used by a malicious user\nas a way to check whether a group with a given slug exists.","distinct":true,"url":"https://api.github.com/repos/hypothesis/h/commits/e4fd519fb473bf8233d58f5e7c76125356ac563a"}]}
{"actor":{"display_login":"fatbusinessman"}}