{"action":"created","issue":{"url":"https://api.github.com/repos/cmu-db/peloton/issues/577","repository_url":"https://api.github.com/repos/cmu-db/peloton","labels_url":"https://api.github.com/repos/cmu-db/peloton/issues/577/labels{/name}","comments_url":"https://api.github.com/repos/cmu-db/peloton/issues/577/comments","events_url":"https://api.github.com/repos/cmu-db/peloton/issues/577/events","html_url":"https://github.com/cmu-db/peloton/pull/577","id":216487154,"number":577,"title":"Add Worker Pool/ Networking Thread, worker thread separation","user":{"login":"MattPerron","id":7608614,"avatar_url":"https://avatars2.githubusercontent.com/u/7608614?v=3","gravatar_id":"","url":"https://api.github.com/users/MattPerron","html_url":"https://github.com/MattPerron","followers_url":"https://api.github.com/users/MattPerron/followers","following_url":"https://api.github.com/users/MattPerron/following{/other_user}","gists_url":"https://api.github.com/users/MattPerron/gists{/gist_id}","starred_url":"https://api.github.com/users/MattPerron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MattPerron/subscriptions","organizations_url":"https://api.github.com/users/MattPerron/orgs","repos_url":"https://api.github.com/users/MattPerron/repos","events_url":"https://api.github.com/users/MattPerron/events{/privacy}","received_events_url":"https://api.github.com/users/MattPerron/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-23T16:18:34Z","updated_at":"2017-03-23T17:30:39Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/577","html_url":"https://github.com/cmu-db/peloton/pull/577","diff_url":"https://github.com/cmu-db/peloton/pull/577.diff","patch_url":"https://github.com/cmu-db/peloton/pull/577.patch"},"body":"This PR is not ready to merge, but I'd like to get feedback from @yingjunwu and other interested parties.\r\n\r\nThe current implementation has the following known issues:\r\n1. A Client disconnection while worker threads are running queries result in a segfault.\r\n2. The Worker Thread Pool has a single task queue, this may have a negative effect on scalability.\r\n3. The transactional consistency of the separation of networking and worker threads is not well tested.\r\n4. More testing is needed, particularly for the Worker Thread Pool. (Only simple functionality has been tested manually)\r\n5. The number of worker threads/network threads needs tuning.\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/cmu-db/peloton/issues/comments/288798518","html_url":"https://github.com/cmu-db/peloton/pull/577#issuecomment-288798518","issue_url":"https://api.github.com/repos/cmu-db/peloton/issues/577","id":288798518,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars2.githubusercontent.com/u/2354108?v=3","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-03-23T17:30:39Z","updated_at":"2017-03-23T17:30:39Z","body":"\n[![Coverage Status](https://coveralls.io/builds/10741950/badge)](https://coveralls.io/builds/10741950)\n\nCoverage decreased (-0.06%) to 66.281% when pulling **b507b51981e58d1d1b2a08bae9909c7bfb5ae937 on MattPerron:worker-pool** into **048dba74b1ee5b24032ddba237d353b5cb65113d on cmu-db:master**.\n"}}
{"actor":{"display_login":"coveralls"}}