{"action":"created","comment":{"url":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/comments/152816294","pull_request_review_id":78736299,"id":152816294,"diff_hunk":"@@ -87,7 +87,10 @@\n       ;; xxx allow these to be updated\n       (define SpriteAtlasId (make-2dtexture))\n       (with-texture (GL_TEXTURE0 SpriteAtlasId)\n-        (load-texture/bytes atlas-size atlas-size atlas-bs))\n+        (load-texture/bytes atlas-size atlas-size atlas-bs)\n+        (glGenerateMipmap GL_TEXTURE_2D)","path":"mode-lambda/backend/gl.rkt","position":6,"original_position":6,"commit_id":"7f11eb9b2a07c7254f731b4a6a1e37800510a680","original_commit_id":"7f11eb9b2a07c7254f731b4a6a1e37800510a680","user":{"login":"david-vanderson","id":3290996,"avatar_url":"https://avatars3.githubusercontent.com/u/3290996?v=4","gravatar_id":"","url":"https://api.github.com/users/david-vanderson","html_url":"https://github.com/david-vanderson","followers_url":"https://api.github.com/users/david-vanderson/followers","following_url":"https://api.github.com/users/david-vanderson/following{/other_user}","gists_url":"https://api.github.com/users/david-vanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/david-vanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-vanderson/subscriptions","organizations_url":"https://api.github.com/users/david-vanderson/orgs","repos_url":"https://api.github.com/users/david-vanderson/repos","events_url":"https://api.github.com/users/david-vanderson/events{/privacy}","received_events_url":"https://api.github.com/users/david-vanderson/received_events","type":"User","site_admin":false},"body":"I will attempt to do that.","created_at":"2017-11-23T14:40:25Z","updated_at":"2017-11-23T14:40:25Z","html_url":"https://github.com/jeapostrophe/mode-lambda/pull/9#discussion_r152816294","pull_request_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/comments/152816294"},"html":{"href":"https://github.com/jeapostrophe/mode-lambda/pull/9#discussion_r152816294"},"pull_request":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/9"}},"in_reply_to_id":152773384},"pull_request":{"url":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/9","id":151773379,"html_url":"https://github.com/jeapostrophe/mode-lambda/pull/9","diff_url":"https://github.com/jeapostrophe/mode-lambda/pull/9.diff","patch_url":"https://github.com/jeapostrophe/mode-lambda/pull/9.patch","issue_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/issues/9","number":9,"state":"open","locked":false,"title":"Rough Changes","user":{"login":"david-vanderson","id":3290996,"avatar_url":"https://avatars3.githubusercontent.com/u/3290996?v=4","gravatar_id":"","url":"https://api.github.com/users/david-vanderson","html_url":"https://github.com/david-vanderson","followers_url":"https://api.github.com/users/david-vanderson/followers","following_url":"https://api.github.com/users/david-vanderson/following{/other_user}","gists_url":"https://api.github.com/users/david-vanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/david-vanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-vanderson/subscriptions","organizations_url":"https://api.github.com/users/david-vanderson/orgs","repos_url":"https://api.github.com/users/david-vanderson/repos","events_url":"https://api.github.com/users/david-vanderson/events{/privacy}","received_events_url":"https://api.github.com/users/david-vanderson/received_events","type":"User","site_admin":false},"body":"First pass, probably far from being merge-able, but it's in the right direction I think.\r\n\r\n1. Changes the drawing model so each layer is a separate glDrawArrayInstanced call\r\n  - This fixes some weird alpha blending stuff that was hurting text especially\r\n  - Also removes the layer cap\r\n\r\n2. Changes the drawing model from hard pixel edges to smoothed\r\n  - Needs to be made optional\r\n  - Scaled smoothed sprites have weird gray edges, I'm looking into premultiplied alpha to fix\r\n\r\n3. Small change to text rendering that should make the text render at the same pixel size as the screen\r\n  - I'm not sure what this code was trying to do, but with this change I think text looks better but maybe it's less saturated?","created_at":"2017-11-09T21:57:16Z","updated_at":"2017-11-23T14:40:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ffbe3bf6f0411ead82c0190ec6b9b4fa1b5557b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/9/commits","review_comments_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/9/comments","review_comment_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/issues/9/comments","statuses_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/statuses/7f11eb9b2a07c7254f731b4a6a1e37800510a680","head":{"label":"david-vanderson:master","ref":"master","sha":"7f11eb9b2a07c7254f731b4a6a1e37800510a680","user":{"login":"david-vanderson","id":3290996,"avatar_url":"https://avatars3.githubusercontent.com/u/3290996?v=4","gravatar_id":"","url":"https://api.github.com/users/david-vanderson","html_url":"https://github.com/david-vanderson","followers_url":"https://api.github.com/users/david-vanderson/followers","following_url":"https://api.github.com/users/david-vanderson/following{/other_user}","gists_url":"https://api.github.com/users/david-vanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/david-vanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-vanderson/subscriptions","organizations_url":"https://api.github.com/users/david-vanderson/orgs","repos_url":"https://api.github.com/users/david-vanderson/repos","events_url":"https://api.github.com/users/david-vanderson/events{/privacy}","received_events_url":"https://api.github.com/users/david-vanderson/received_events","type":"User","site_admin":false},"repo":{"id":80935156,"name":"mode-lambda","full_name":"david-vanderson/mode-lambda","owner":{"login":"david-vanderson","id":3290996,"avatar_url":"https://avatars3.githubusercontent.com/u/3290996?v=4","gravatar_id":"","url":"https://api.github.com/users/david-vanderson","html_url":"https://github.com/david-vanderson","followers_url":"https://api.github.com/users/david-vanderson/followers","following_url":"https://api.github.com/users/david-vanderson/following{/other_user}","gists_url":"https://api.github.com/users/david-vanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/david-vanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-vanderson/subscriptions","organizations_url":"https://api.github.com/users/david-vanderson/orgs","repos_url":"https://api.github.com/users/david-vanderson/repos","events_url":"https://api.github.com/users/david-vanderson/events{/privacy}","received_events_url":"https://api.github.com/users/david-vanderson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/david-vanderson/mode-lambda","description":"mode-lambda - sprite-based 2D graphics engine","fork":true,"url":"https://api.github.com/repos/david-vanderson/mode-lambda","forks_url":"https://api.github.com/repos/david-vanderson/mode-lambda/forks","keys_url":"https://api.github.com/repos/david-vanderson/mode-lambda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/david-vanderson/mode-lambda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/david-vanderson/mode-lambda/teams","hooks_url":"https://api.github.com/repos/david-vanderson/mode-lambda/hooks","issue_events_url":"https://api.github.com/repos/david-vanderson/mode-lambda/issues/events{/number}","events_url":"https://api.github.com/repos/david-vanderson/mode-lambda/events","assignees_url":"https://api.github.com/repos/david-vanderson/mode-lambda/assignees{/user}","branches_url":"https://api.github.com/repos/david-vanderson/mode-lambda/branches{/branch}","tags_url":"https://api.github.com/repos/david-vanderson/mode-lambda/tags","blobs_url":"https://api.github.com/repos/david-vanderson/mode-lambda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/david-vanderson/mode-lambda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/david-vanderson/mode-lambda/git/refs{/sha}","trees_url":"https://api.github.com/repos/david-vanderson/mode-lambda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/david-vanderson/mode-lambda/statuses/{sha}","languages_url":"https://api.github.com/repos/david-vanderson/mode-lambda/languages","stargazers_url":"https://api.github.com/repos/david-vanderson/mode-lambda/stargazers","contributors_url":"https://api.github.com/repos/david-vanderson/mode-lambda/contributors","subscribers_url":"https://api.github.com/repos/david-vanderson/mode-lambda/subscribers","subscription_url":"https://api.github.com/repos/david-vanderson/mode-lambda/subscription","commits_url":"https://api.github.com/repos/david-vanderson/mode-lambda/commits{/sha}","git_commits_url":"https://api.github.com/repos/david-vanderson/mode-lambda/git/commits{/sha}","comments_url":"https://api.github.com/repos/david-vanderson/mode-lambda/comments{/number}","issue_comment_url":"https://api.github.com/repos/david-vanderson/mode-lambda/issues/comments{/number}","contents_url":"https://api.github.com/repos/david-vanderson/mode-lambda/contents/{+path}","compare_url":"https://api.github.com/repos/david-vanderson/mode-lambda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/david-vanderson/mode-lambda/merges","archive_url":"https://api.github.com/repos/david-vanderson/mode-lambda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/david-vanderson/mode-lambda/downloads","issues_url":"https://api.github.com/repos/david-vanderson/mode-lambda/issues{/number}","pulls_url":"https://api.github.com/repos/david-vanderson/mode-lambda/pulls{/number}","milestones_url":"https://api.github.com/repos/david-vanderson/mode-lambda/milestones{/number}","notifications_url":"https://api.github.com/repos/david-vanderson/mode-lambda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/david-vanderson/mode-lambda/labels{/name}","releases_url":"https://api.github.com/repos/david-vanderson/mode-lambda/releases{/id}","deployments_url":"https://api.github.com/repos/david-vanderson/mode-lambda/deployments","created_at":"2017-02-04T17:22:47Z","updated_at":"2017-02-04T17:22:48Z","pushed_at":"2017-11-23T03:43:19Z","git_url":"git://github.com/david-vanderson/mode-lambda.git","ssh_url":"git@github.com:david-vanderson/mode-lambda.git","clone_url":"https://github.com/david-vanderson/mode-lambda.git","svn_url":"https://github.com/david-vanderson/mode-lambda","homepage":"","size":399,"stargazers_count":0,"watchers_count":0,"language":"Racket","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jeapostrophe:master","ref":"master","sha":"e3542b390b33e92dd9653f0ea0611b2343069cc4","user":{"login":"jeapostrophe","id":232698,"avatar_url":"https://avatars1.githubusercontent.com/u/232698?v=4","gravatar_id":"","url":"https://api.github.com/users/jeapostrophe","html_url":"https://github.com/jeapostrophe","followers_url":"https://api.github.com/users/jeapostrophe/followers","following_url":"https://api.github.com/users/jeapostrophe/following{/other_user}","gists_url":"https://api.github.com/users/jeapostrophe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeapostrophe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeapostrophe/subscriptions","organizations_url":"https://api.github.com/users/jeapostrophe/orgs","repos_url":"https://api.github.com/users/jeapostrophe/repos","events_url":"https://api.github.com/users/jeapostrophe/events{/privacy}","received_events_url":"https://api.github.com/users/jeapostrophe/received_events","type":"User","site_admin":false},"repo":{"id":24722704,"name":"mode-lambda","full_name":"jeapostrophe/mode-lambda","owner":{"login":"jeapostrophe","id":232698,"avatar_url":"https://avatars1.githubusercontent.com/u/232698?v=4","gravatar_id":"","url":"https://api.github.com/users/jeapostrophe","html_url":"https://github.com/jeapostrophe","followers_url":"https://api.github.com/users/jeapostrophe/followers","following_url":"https://api.github.com/users/jeapostrophe/following{/other_user}","gists_url":"https://api.github.com/users/jeapostrophe/gists{/gist_id}","starred_url":"https://api.github.com/users/jeapostrophe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeapostrophe/subscriptions","organizations_url":"https://api.github.com/users/jeapostrophe/orgs","repos_url":"https://api.github.com/users/jeapostrophe/repos","events_url":"https://api.github.com/users/jeapostrophe/events{/privacy}","received_events_url":"https://api.github.com/users/jeapostrophe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeapostrophe/mode-lambda","description":"mode-lambda - sprite-based 2D graphics engine","fork":false,"url":"https://api.github.com/repos/jeapostrophe/mode-lambda","forks_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/forks","keys_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/teams","hooks_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/hooks","issue_events_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/issues/events{/number}","events_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/events","assignees_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/assignees{/user}","branches_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/branches{/branch}","tags_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/tags","blobs_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/statuses/{sha}","languages_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/languages","stargazers_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/stargazers","contributors_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/contributors","subscribers_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/subscribers","subscription_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/subscription","commits_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/contents/{+path}","compare_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/merges","archive_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/downloads","issues_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/issues{/number}","pulls_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls{/number}","milestones_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/milestones{/number}","notifications_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/labels{/name}","releases_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/releases{/id}","deployments_url":"https://api.github.com/repos/jeapostrophe/mode-lambda/deployments","created_at":"2014-10-02T14:40:19Z","updated_at":"2017-11-03T23:54:14Z","pushed_at":"2017-11-23T03:43:21Z","git_url":"git://github.com/jeapostrophe/mode-lambda.git","ssh_url":"git@github.com:jeapostrophe/mode-lambda.git","clone_url":"https://github.com/jeapostrophe/mode-lambda.git","svn_url":"https://github.com/jeapostrophe/mode-lambda","homepage":"","size":397,"stargazers_count":12,"watchers_count":12,"language":"Racket","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":4,"open_issues":2,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/9"},"html":{"href":"https://github.com/jeapostrophe/mode-lambda/pull/9"},"issue":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/issues/9"},"comments":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/jeapostrophe/mode-lambda/statuses/7f11eb9b2a07c7254f731b4a6a1e37800510a680"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"david-vanderson"}}