{"action":"created","comment":{"url":"https://api.github.com/repos/lxc/lxc/pulls/comments/147578461","pull_request_review_id":72694944,"id":147578461,"diff_hunk":"@@ -729,11 +722,18 @@ void lxc_fini(const char *name, struct lxc_handler *handler)\n \n \twhile (namespace_count--)\n \t\tfree(namespaces[namespace_count]);\n+\n \tfor (i = 0; i < LXC_NS_MAX; i++) {\n \t\tif (handler->nsfd[i] != -1) {\n \t\t\tclose(handler->nsfd[i]);\n \t\t\thandler->nsfd[i] = -1;\n \t\t}\n+\n+\t\tif (handler->conf->inherit_ns[i].fd < 0) {","path":"src/lxc/start.c","position":43,"original_position":43,"commit_id":"8e30b6d0a7852d529e92d5deb987d3412d19bb2c","original_commit_id":"8e30b6d0a7852d529e92d5deb987d3412d19bb2c","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars0.githubusercontent.com/u/7353573?v=4","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"body":"wrong check","created_at":"2017-10-29T11:44:05Z","updated_at":"2017-10-29T11:44:05Z","html_url":"https://github.com/lxc/lxc/pull/1884#discussion_r147578461","pull_request_url":"https://api.github.com/repos/lxc/lxc/pulls/1884","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lxc/lxc/pulls/comments/147578461"},"html":{"href":"https://github.com/lxc/lxc/pull/1884#discussion_r147578461"},"pull_request":{"href":"https://api.github.com/repos/lxc/lxc/pulls/1884"}}},"pull_request":{"url":"https://api.github.com/repos/lxc/lxc/pulls/1884","id":149380521,"html_url":"https://github.com/lxc/lxc/pull/1884","diff_url":"https://github.com/lxc/lxc/pull/1884.diff","patch_url":"https://github.com/lxc/lxc/pull/1884.patch","issue_url":"https://api.github.com/repos/lxc/lxc/issues/1884","number":1884,"state":"open","locked":false,"title":"confile: add lxc.namespace.<namespace-key> ","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars0.githubusercontent.com/u/7353573?v=4","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"body":"Relates to #1881.\r\n\r\nSigned-off-by: Christian Brauner <christian.brauner@ubuntu.com>","created_at":"2017-10-29T11:33:43Z","updated_at":"2017-10-29T11:44:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"59390c519b240651a503832f515181a06b122141","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/lxc/lxc/pulls/1884/commits","review_comments_url":"https://api.github.com/repos/lxc/lxc/pulls/1884/comments","review_comment_url":"https://api.github.com/repos/lxc/lxc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lxc/lxc/issues/1884/comments","statuses_url":"https://api.github.com/repos/lxc/lxc/statuses/8e30b6d0a7852d529e92d5deb987d3412d19bb2c","head":{"label":"brauner:2017-10-28/move_tools_to_api_only","ref":"2017-10-28/move_tools_to_api_only","sha":"8e30b6d0a7852d529e92d5deb987d3412d19bb2c","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars0.githubusercontent.com/u/7353573?v=4","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"repo":{"id":34560469,"name":"lxc","full_name":"brauner/lxc","owner":{"login":"brauner","id":7353573,"avatar_url":"https://avatars0.githubusercontent.com/u/7353573?v=4","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brauner/lxc","description":"LXC - Linux Containers","fork":true,"url":"https://api.github.com/repos/brauner/lxc","forks_url":"https://api.github.com/repos/brauner/lxc/forks","keys_url":"https://api.github.com/repos/brauner/lxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brauner/lxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brauner/lxc/teams","hooks_url":"https://api.github.com/repos/brauner/lxc/hooks","issue_events_url":"https://api.github.com/repos/brauner/lxc/issues/events{/number}","events_url":"https://api.github.com/repos/brauner/lxc/events","assignees_url":"https://api.github.com/repos/brauner/lxc/assignees{/user}","branches_url":"https://api.github.com/repos/brauner/lxc/branches{/branch}","tags_url":"https://api.github.com/repos/brauner/lxc/tags","blobs_url":"https://api.github.com/repos/brauner/lxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brauner/lxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brauner/lxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/brauner/lxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brauner/lxc/statuses/{sha}","languages_url":"https://api.github.com/repos/brauner/lxc/languages","stargazers_url":"https://api.github.com/repos/brauner/lxc/stargazers","contributors_url":"https://api.github.com/repos/brauner/lxc/contributors","subscribers_url":"https://api.github.com/repos/brauner/lxc/subscribers","subscription_url":"https://api.github.com/repos/brauner/lxc/subscription","commits_url":"https://api.github.com/repos/brauner/lxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/brauner/lxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/brauner/lxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/brauner/lxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/brauner/lxc/contents/{+path}","compare_url":"https://api.github.com/repos/brauner/lxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brauner/lxc/merges","archive_url":"https://api.github.com/repos/brauner/lxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brauner/lxc/downloads","issues_url":"https://api.github.com/repos/brauner/lxc/issues{/number}","pulls_url":"https://api.github.com/repos/brauner/lxc/pulls{/number}","milestones_url":"https://api.github.com/repos/brauner/lxc/milestones{/number}","notifications_url":"https://api.github.com/repos/brauner/lxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brauner/lxc/labels{/name}","releases_url":"https://api.github.com/repos/brauner/lxc/releases{/id}","deployments_url":"https://api.github.com/repos/brauner/lxc/deployments","created_at":"2015-04-25T08:02:11Z","updated_at":"2017-05-09T00:28:06Z","pushed_at":"2017-10-29T11:36:17Z","git_url":"git://github.com/brauner/lxc.git","ssh_url":"git@github.com:brauner/lxc.git","clone_url":"https://github.com/brauner/lxc.git","svn_url":"https://github.com/brauner/lxc","homepage":"https://linuxcontainers.org","size":15110,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"lxc:master","ref":"master","sha":"cf13d10781200f16427e16b8bd8f8d6d66cf3adc","user":{"login":"lxc","id":2301756,"avatar_url":"https://avatars2.githubusercontent.com/u/2301756?v=4","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"repo":{"id":5720995,"name":"lxc","full_name":"lxc/lxc","owner":{"login":"lxc","id":2301756,"avatar_url":"https://avatars2.githubusercontent.com/u/2301756?v=4","gravatar_id":"","url":"https://api.github.com/users/lxc","html_url":"https://github.com/lxc","followers_url":"https://api.github.com/users/lxc/followers","following_url":"https://api.github.com/users/lxc/following{/other_user}","gists_url":"https://api.github.com/users/lxc/gists{/gist_id}","starred_url":"https://api.github.com/users/lxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lxc/subscriptions","organizations_url":"https://api.github.com/users/lxc/orgs","repos_url":"https://api.github.com/users/lxc/repos","events_url":"https://api.github.com/users/lxc/events{/privacy}","received_events_url":"https://api.github.com/users/lxc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lxc/lxc","description":"LXC - Linux Containers","fork":false,"url":"https://api.github.com/repos/lxc/lxc","forks_url":"https://api.github.com/repos/lxc/lxc/forks","keys_url":"https://api.github.com/repos/lxc/lxc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lxc/lxc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lxc/lxc/teams","hooks_url":"https://api.github.com/repos/lxc/lxc/hooks","issue_events_url":"https://api.github.com/repos/lxc/lxc/issues/events{/number}","events_url":"https://api.github.com/repos/lxc/lxc/events","assignees_url":"https://api.github.com/repos/lxc/lxc/assignees{/user}","branches_url":"https://api.github.com/repos/lxc/lxc/branches{/branch}","tags_url":"https://api.github.com/repos/lxc/lxc/tags","blobs_url":"https://api.github.com/repos/lxc/lxc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lxc/lxc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lxc/lxc/git/refs{/sha}","trees_url":"https://api.github.com/repos/lxc/lxc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lxc/lxc/statuses/{sha}","languages_url":"https://api.github.com/repos/lxc/lxc/languages","stargazers_url":"https://api.github.com/repos/lxc/lxc/stargazers","contributors_url":"https://api.github.com/repos/lxc/lxc/contributors","subscribers_url":"https://api.github.com/repos/lxc/lxc/subscribers","subscription_url":"https://api.github.com/repos/lxc/lxc/subscription","commits_url":"https://api.github.com/repos/lxc/lxc/commits{/sha}","git_commits_url":"https://api.github.com/repos/lxc/lxc/git/commits{/sha}","comments_url":"https://api.github.com/repos/lxc/lxc/comments{/number}","issue_comment_url":"https://api.github.com/repos/lxc/lxc/issues/comments{/number}","contents_url":"https://api.github.com/repos/lxc/lxc/contents/{+path}","compare_url":"https://api.github.com/repos/lxc/lxc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lxc/lxc/merges","archive_url":"https://api.github.com/repos/lxc/lxc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lxc/lxc/downloads","issues_url":"https://api.github.com/repos/lxc/lxc/issues{/number}","pulls_url":"https://api.github.com/repos/lxc/lxc/pulls{/number}","milestones_url":"https://api.github.com/repos/lxc/lxc/milestones{/number}","notifications_url":"https://api.github.com/repos/lxc/lxc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lxc/lxc/labels{/name}","releases_url":"https://api.github.com/repos/lxc/lxc/releases{/id}","deployments_url":"https://api.github.com/repos/lxc/lxc/deployments","created_at":"2012-09-07T18:50:27Z","updated_at":"2017-10-28T21:18:49Z","pushed_at":"2017-10-29T11:37:27Z","git_url":"git://github.com/lxc/lxc.git","ssh_url":"git@github.com:lxc/lxc.git","clone_url":"https://github.com/lxc/lxc.git","svn_url":"https://github.com/lxc/lxc","homepage":"https://linuxcontainers.org/lxc","size":15070,"stargazers_count":1866,"watchers_count":1866,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":633,"mirror_url":null,"archived":false,"open_issues_count":177,"forks":633,"open_issues":177,"watchers":1866,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lxc/lxc/pulls/1884"},"html":{"href":"https://github.com/lxc/lxc/pull/1884"},"issue":{"href":"https://api.github.com/repos/lxc/lxc/issues/1884"},"comments":{"href":"https://api.github.com/repos/lxc/lxc/issues/1884/comments"},"review_comments":{"href":"https://api.github.com/repos/lxc/lxc/pulls/1884/comments"},"review_comment":{"href":"https://api.github.com/repos/lxc/lxc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lxc/lxc/pulls/1884/commits"},"statuses":{"href":"https://api.github.com/repos/lxc/lxc/statuses/8e30b6d0a7852d529e92d5deb987d3412d19bb2c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"brauner"}}