{"action":"opened","number":1359,"pull_request":{"url":"https://api.github.com/repos/gradle/gradle/pulls/1359","id":105184869,"html_url":"https://github.com/gradle/gradle/pull/1359","diff_url":"https://github.com/gradle/gradle/pull/1359.diff","patch_url":"https://github.com/gradle/gradle/pull/1359.patch","issue_url":"https://api.github.com/repos/gradle/gradle/issues/1359","number":1359,"state":"open","locked":false,"title":"Lenient compile classpath snapshotting","user":{"login":"melix","id":316357,"avatar_url":"https://avatars.githubusercontent.com/u/316357?v=3","gravatar_id":"","url":"https://api.github.com/users/melix","html_url":"https://github.com/melix","followers_url":"https://api.github.com/users/melix/followers","following_url":"https://api.github.com/users/melix/following{/other_user}","gists_url":"https://api.github.com/users/melix/gists{/gist_id}","starred_url":"https://api.github.com/users/melix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melix/subscriptions","organizations_url":"https://api.github.com/users/melix/orgs","repos_url":"https://api.github.com/users/melix/repos","events_url":"https://api.github.com/users/melix/events{/privacy}","received_events_url":"https://api.github.com/users/melix/received_events","type":"User","site_admin":false},"body":"Since the introduction of compile classpath snapshotting, and the improvements to annotation processor detection,\r\nwe're much stricter with regards to what we find on classpath. If a jar is broken (unreadable, or has wrong entries)\r\nor that a class file is unreadable, we fail early and do not bother compiling. The justification for this is that\r\nwe want to make sure compile classpath snapshotting is valid: if for example a bug is introduced in ASM, that we use\r\nfor snapshotting, we want to make sure we realize this and not silently ignore errors and lead to wrong ABI signatures.\r\n\r\nBut the consequence for the user is too big: upgrading from Gradle 3.3 to Gradle 3.4 can make compile fail just because\r\nof the presence of a broken Jar on classpath (even if it means, in practice, that the jar is probably a leaking dependency\r\nnot used in sources, otherwise javac would also fail), or a broken class on classpath (even if it means that Javac itself\r\nwould fail, so the class is unused). The reality is that there are many broken jars in the wild, apparently. So we\r\nstart with being more lenient, and tolerate them, but warn the user of the presence of a broken jar/class, and that we\r\nwill not support this in Gradle 5.0. This gives the opportunity to the user to either fix the jar, remove the leaking\r\ndependency, or ask to the maintainers of the dependency to fix it.\r\n\r\n","created_at":"2017-02-08T10:11:05Z","updated_at":"2017-02-08T10:11:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"melix","id":316357,"avatar_url":"https://avatars.githubusercontent.com/u/316357?v=3","gravatar_id":"","url":"https://api.github.com/users/melix","html_url":"https://github.com/melix","followers_url":"https://api.github.com/users/melix/followers","following_url":"https://api.github.com/users/melix/following{/other_user}","gists_url":"https://api.github.com/users/melix/gists{/gist_id}","starred_url":"https://api.github.com/users/melix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melix/subscriptions","organizations_url":"https://api.github.com/users/melix/orgs","repos_url":"https://api.github.com/users/melix/repos","events_url":"https://api.github.com/users/melix/events{/privacy}","received_events_url":"https://api.github.com/users/melix/received_events","type":"User","site_admin":false},"assignees":[{"login":"melix","id":316357,"avatar_url":"https://avatars.githubusercontent.com/u/316357?v=3","gravatar_id":"","url":"https://api.github.com/users/melix","html_url":"https://github.com/melix","followers_url":"https://api.github.com/users/melix/followers","following_url":"https://api.github.com/users/melix/following{/other_user}","gists_url":"https://api.github.com/users/melix/gists{/gist_id}","starred_url":"https://api.github.com/users/melix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melix/subscriptions","organizations_url":"https://api.github.com/users/melix/orgs","repos_url":"https://api.github.com/users/melix/repos","events_url":"https://api.github.com/users/melix/events{/privacy}","received_events_url":"https://api.github.com/users/melix/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/gradle/gradle/milestones/23","html_url":"https://github.com/gradle/gradle/milestone/23","labels_url":"https://api.github.com/repos/gradle/gradle/milestones/23/labels","id":2306016,"number":23,"title":"3.4 RC3","description":"","creator":{"login":"bmuschko","id":440872,"avatar_url":"https://avatars.githubusercontent.com/u/440872?v=3","gravatar_id":"","url":"https://api.github.com/users/bmuschko","html_url":"https://github.com/bmuschko","followers_url":"https://api.github.com/users/bmuschko/followers","following_url":"https://api.github.com/users/bmuschko/following{/other_user}","gists_url":"https://api.github.com/users/bmuschko/gists{/gist_id}","starred_url":"https://api.github.com/users/bmuschko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmuschko/subscriptions","organizations_url":"https://api.github.com/users/bmuschko/orgs","repos_url":"https://api.github.com/users/bmuschko/repos","events_url":"https://api.github.com/users/bmuschko/events{/privacy}","received_events_url":"https://api.github.com/users/bmuschko/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":2,"state":"open","created_at":"2017-02-07T15:25:11Z","updated_at":"2017-02-08T10:11:05Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/gradle/gradle/pulls/1359/commits","review_comments_url":"https://api.github.com/repos/gradle/gradle/pulls/1359/comments","review_comment_url":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gradle/gradle/issues/1359/comments","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/65119cc8c5fb9436ad6ffe4f8ac2d9d6e9dec60f","head":{"label":"gradle:cc-lenient-classpath-snapshotting","ref":"cc-lenient-classpath-snapshotting","sha":"65119cc8c5fb9436ad6ffe4f8ac2d9d6e9dec60f","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"A powerful build system for the JVM","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2017-02-08T08:41:06Z","pushed_at":"2017-02-08T10:09:39Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"gradle.org","size":156738,"stargazers_count":4399,"watchers_count":4399,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1644,"mirror_url":null,"open_issues_count":364,"forks":1644,"open_issues":364,"watchers":4399,"default_branch":"master"}},"base":{"label":"gradle:release","ref":"release","sha":"39177eb87c7b0c079d28076b5d79029d06ed6d18","user":{"login":"gradle","id":124156,"avatar_url":"https://avatars.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"repo":{"id":302322,"name":"gradle","full_name":"gradle/gradle","owner":{"login":"gradle","id":124156,"avatar_url":"https://avatars.githubusercontent.com/u/124156?v=3","gravatar_id":"","url":"https://api.github.com/users/gradle","html_url":"https://github.com/gradle","followers_url":"https://api.github.com/users/gradle/followers","following_url":"https://api.github.com/users/gradle/following{/other_user}","gists_url":"https://api.github.com/users/gradle/gists{/gist_id}","starred_url":"https://api.github.com/users/gradle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gradle/subscriptions","organizations_url":"https://api.github.com/users/gradle/orgs","repos_url":"https://api.github.com/users/gradle/repos","events_url":"https://api.github.com/users/gradle/events{/privacy}","received_events_url":"https://api.github.com/users/gradle/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gradle/gradle","description":"A powerful build system for the JVM","fork":false,"url":"https://api.github.com/repos/gradle/gradle","forks_url":"https://api.github.com/repos/gradle/gradle/forks","keys_url":"https://api.github.com/repos/gradle/gradle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gradle/gradle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gradle/gradle/teams","hooks_url":"https://api.github.com/repos/gradle/gradle/hooks","issue_events_url":"https://api.github.com/repos/gradle/gradle/issues/events{/number}","events_url":"https://api.github.com/repos/gradle/gradle/events","assignees_url":"https://api.github.com/repos/gradle/gradle/assignees{/user}","branches_url":"https://api.github.com/repos/gradle/gradle/branches{/branch}","tags_url":"https://api.github.com/repos/gradle/gradle/tags","blobs_url":"https://api.github.com/repos/gradle/gradle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gradle/gradle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gradle/gradle/git/refs{/sha}","trees_url":"https://api.github.com/repos/gradle/gradle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gradle/gradle/statuses/{sha}","languages_url":"https://api.github.com/repos/gradle/gradle/languages","stargazers_url":"https://api.github.com/repos/gradle/gradle/stargazers","contributors_url":"https://api.github.com/repos/gradle/gradle/contributors","subscribers_url":"https://api.github.com/repos/gradle/gradle/subscribers","subscription_url":"https://api.github.com/repos/gradle/gradle/subscription","commits_url":"https://api.github.com/repos/gradle/gradle/commits{/sha}","git_commits_url":"https://api.github.com/repos/gradle/gradle/git/commits{/sha}","comments_url":"https://api.github.com/repos/gradle/gradle/comments{/number}","issue_comment_url":"https://api.github.com/repos/gradle/gradle/issues/comments{/number}","contents_url":"https://api.github.com/repos/gradle/gradle/contents/{+path}","compare_url":"https://api.github.com/repos/gradle/gradle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gradle/gradle/merges","archive_url":"https://api.github.com/repos/gradle/gradle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gradle/gradle/downloads","issues_url":"https://api.github.com/repos/gradle/gradle/issues{/number}","pulls_url":"https://api.github.com/repos/gradle/gradle/pulls{/number}","milestones_url":"https://api.github.com/repos/gradle/gradle/milestones{/number}","notifications_url":"https://api.github.com/repos/gradle/gradle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gradle/gradle/labels{/name}","releases_url":"https://api.github.com/repos/gradle/gradle/releases{/id}","deployments_url":"https://api.github.com/repos/gradle/gradle/deployments","created_at":"2009-09-09T18:27:19Z","updated_at":"2017-02-08T08:41:06Z","pushed_at":"2017-02-08T10:09:39Z","git_url":"git://github.com/gradle/gradle.git","ssh_url":"git@github.com:gradle/gradle.git","clone_url":"https://github.com/gradle/gradle.git","svn_url":"https://github.com/gradle/gradle","homepage":"gradle.org","size":156738,"stargazers_count":4399,"watchers_count":4399,"language":"Java","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":1644,"mirror_url":null,"open_issues_count":364,"forks":1644,"open_issues":364,"watchers":4399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gradle/gradle/pulls/1359"},"html":{"href":"https://github.com/gradle/gradle/pull/1359"},"issue":{"href":"https://api.github.com/repos/gradle/gradle/issues/1359"},"comments":{"href":"https://api.github.com/repos/gradle/gradle/issues/1359/comments"},"review_comments":{"href":"https://api.github.com/repos/gradle/gradle/pulls/1359/comments"},"review_comment":{"href":"https://api.github.com/repos/gradle/gradle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gradle/gradle/pulls/1359/commits"},"statuses":{"href":"https://api.github.com/repos/gradle/gradle/statuses/65119cc8c5fb9436ad6ffe4f8ac2d9d6e9dec60f"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":94,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"melix"}}