{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/152184305","pull_request_review_id":78005922,"id":152184305,"diff_hunk":"@@ -129,6 +129,11 @@ func DeleteHost(api libmachine.API) error {\n \tm := util.MultiError{}\n \tm.Collect(host.Driver.Remove())\n \tm.Collect(api.Remove(constants.MachineName))\n+\n+\tif len(m.Errors) == 0 && glog.V(2) {","path":"pkg/minikube/cluster/cluster.go","position":5,"original_position":5,"commit_id":"d234b493fad2e44d5fed900095540f228569e3d2","original_commit_id":"d234b493fad2e44d5fed900095540f228569e3d2","user":{"login":"ulyssessouza","id":373485,"avatar_url":"https://avatars0.githubusercontent.com/u/373485?v=4","gravatar_id":"","url":"https://api.github.com/users/ulyssessouza","html_url":"https://github.com/ulyssessouza","followers_url":"https://api.github.com/users/ulyssessouza/followers","following_url":"https://api.github.com/users/ulyssessouza/following{/other_user}","gists_url":"https://api.github.com/users/ulyssessouza/gists{/gist_id}","starred_url":"https://api.github.com/users/ulyssessouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulyssessouza/subscriptions","organizations_url":"https://api.github.com/users/ulyssessouza/orgs","repos_url":"https://api.github.com/users/ulyssessouza/repos","events_url":"https://api.github.com/users/ulyssessouza/events{/privacy}","received_events_url":"https://api.github.com/users/ulyssessouza/received_events","type":"User","site_admin":false},"body":"Notice that by placing it here, the same applies to `minikube delete`. I just preferred this to make the VM deletion messages coherent, independently of the trigger.","created_at":"2017-11-21T05:51:20Z","updated_at":"2017-11-21T05:51:20Z","html_url":"https://github.com/minishift/minishift/pull/1711#discussion_r152184305","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/1711","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/152184305"},"html":{"href":"https://github.com/minishift/minishift/pull/1711#discussion_r152184305"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1711"}}},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/1711","id":153228274,"html_url":"https://github.com/minishift/minishift/pull/1711","diff_url":"https://github.com/minishift/minishift/pull/1711.diff","patch_url":"https://github.com/minishift/minishift/pull/1711.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/1711","number":1711,"state":"open","locked":false,"title":"Issue #1706 Consolidate delete messages","user":{"login":"ulyssessouza","id":373485,"avatar_url":"https://avatars0.githubusercontent.com/u/373485?v=4","gravatar_id":"","url":"https://api.github.com/users/ulyssessouza","html_url":"https://github.com/ulyssessouza","followers_url":"https://api.github.com/users/ulyssessouza/followers","following_url":"https://api.github.com/users/ulyssessouza/following{/other_user}","gists_url":"https://api.github.com/users/ulyssessouza/gists{/gist_id}","starred_url":"https://api.github.com/users/ulyssessouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulyssessouza/subscriptions","organizations_url":"https://api.github.com/users/ulyssessouza/orgs","repos_url":"https://api.github.com/users/ulyssessouza/repos","events_url":"https://api.github.com/users/ulyssessouza/events{/privacy}","received_events_url":"https://api.github.com/users/ulyssessouza/received_events","type":"User","site_admin":false},"body":"Fixes #1706 \r\n\r\n- Consolidate delete messages","created_at":"2017-11-17T07:02:59Z","updated_at":"2017-11-21T05:51:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0edc8bf980f71d5a86b8e7722cd7c8de06bc161","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/1711/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/1711/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/1711/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/d234b493fad2e44d5fed900095540f228569e3d2","head":{"label":"ulyssessouza:issue_1706","ref":"issue_1706","sha":"d234b493fad2e44d5fed900095540f228569e3d2","user":{"login":"ulyssessouza","id":373485,"avatar_url":"https://avatars0.githubusercontent.com/u/373485?v=4","gravatar_id":"","url":"https://api.github.com/users/ulyssessouza","html_url":"https://github.com/ulyssessouza","followers_url":"https://api.github.com/users/ulyssessouza/followers","following_url":"https://api.github.com/users/ulyssessouza/following{/other_user}","gists_url":"https://api.github.com/users/ulyssessouza/gists{/gist_id}","starred_url":"https://api.github.com/users/ulyssessouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulyssessouza/subscriptions","organizations_url":"https://api.github.com/users/ulyssessouza/orgs","repos_url":"https://api.github.com/users/ulyssessouza/repos","events_url":"https://api.github.com/users/ulyssessouza/events{/privacy}","received_events_url":"https://api.github.com/users/ulyssessouza/received_events","type":"User","site_admin":false},"repo":{"id":111063115,"name":"minishift","full_name":"ulyssessouza/minishift","owner":{"login":"ulyssessouza","id":373485,"avatar_url":"https://avatars0.githubusercontent.com/u/373485?v=4","gravatar_id":"","url":"https://api.github.com/users/ulyssessouza","html_url":"https://github.com/ulyssessouza","followers_url":"https://api.github.com/users/ulyssessouza/followers","following_url":"https://api.github.com/users/ulyssessouza/following{/other_user}","gists_url":"https://api.github.com/users/ulyssessouza/gists{/gist_id}","starred_url":"https://api.github.com/users/ulyssessouza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulyssessouza/subscriptions","organizations_url":"https://api.github.com/users/ulyssessouza/orgs","repos_url":"https://api.github.com/users/ulyssessouza/repos","events_url":"https://api.github.com/users/ulyssessouza/events{/privacy}","received_events_url":"https://api.github.com/users/ulyssessouza/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ulyssessouza/minishift","description":"Run OpenShift locally","fork":true,"url":"https://api.github.com/repos/ulyssessouza/minishift","forks_url":"https://api.github.com/repos/ulyssessouza/minishift/forks","keys_url":"https://api.github.com/repos/ulyssessouza/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ulyssessouza/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ulyssessouza/minishift/teams","hooks_url":"https://api.github.com/repos/ulyssessouza/minishift/hooks","issue_events_url":"https://api.github.com/repos/ulyssessouza/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/ulyssessouza/minishift/events","assignees_url":"https://api.github.com/repos/ulyssessouza/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/ulyssessouza/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/ulyssessouza/minishift/tags","blobs_url":"https://api.github.com/repos/ulyssessouza/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ulyssessouza/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ulyssessouza/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/ulyssessouza/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ulyssessouza/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/ulyssessouza/minishift/languages","stargazers_url":"https://api.github.com/repos/ulyssessouza/minishift/stargazers","contributors_url":"https://api.github.com/repos/ulyssessouza/minishift/contributors","subscribers_url":"https://api.github.com/repos/ulyssessouza/minishift/subscribers","subscription_url":"https://api.github.com/repos/ulyssessouza/minishift/subscription","commits_url":"https://api.github.com/repos/ulyssessouza/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/ulyssessouza/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/ulyssessouza/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/ulyssessouza/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/ulyssessouza/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/ulyssessouza/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ulyssessouza/minishift/merges","archive_url":"https://api.github.com/repos/ulyssessouza/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ulyssessouza/minishift/downloads","issues_url":"https://api.github.com/repos/ulyssessouza/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/ulyssessouza/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/ulyssessouza/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/ulyssessouza/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ulyssessouza/minishift/labels{/name}","releases_url":"https://api.github.com/repos/ulyssessouza/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/ulyssessouza/minishift/deployments","created_at":"2017-11-17T05:44:52Z","updated_at":"2017-11-17T05:44:56Z","pushed_at":"2017-11-21T04:43:23Z","git_url":"git://github.com/ulyssessouza/minishift.git","ssh_url":"git@github.com:ulyssessouza/minishift.git","clone_url":"https://github.com/ulyssessouza/minishift.git","svn_url":"https://github.com/ulyssessouza/minishift","homepage":"","size":157513,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"e66d4dc3dd07bb5c84ce4a1f9dcfbfca1e029071","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars1.githubusercontent.com/u/23212309?v=4","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-11-21T03:56:37Z","pushed_at":"2017-11-21T05:50:47Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":157511,"stargazers_count":723,"watchers_count":723,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":167,"mirror_url":null,"archived":false,"open_issues_count":228,"forks":167,"open_issues":228,"watchers":723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1711"},"html":{"href":"https://github.com/minishift/minishift/pull/1711"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/1711"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/1711/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1711/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/1711/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/d234b493fad2e44d5fed900095540f228569e3d2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ulyssessouza"}}