{"action":"created","issue":{"url":"https://api.github.com/repos/carllerche/bytes/issues/153","repository_url":"https://api.github.com/repos/carllerche/bytes","labels_url":"https://api.github.com/repos/carllerche/bytes/issues/153/labels{/name}","comments_url":"https://api.github.com/repos/carllerche/bytes/issues/153/comments","events_url":"https://api.github.com/repos/carllerche/bytes/issues/153/events","html_url":"https://github.com/carllerche/bytes/pull/153","id":243577886,"number":153,"title":"\"allocator\" and \"nightly\" features (for no_std environments)","user":{"login":"tonychain","id":23511481,"avatar_url":"https://avatars1.githubusercontent.com/u/23511481?v=4","gravatar_id":"","url":"https://api.github.com/users/tonychain","html_url":"https://github.com/tonychain","followers_url":"https://api.github.com/users/tonychain/followers","following_url":"https://api.github.com/users/tonychain/following{/other_user}","gists_url":"https://api.github.com/users/tonychain/gists{/gist_id}","starred_url":"https://api.github.com/users/tonychain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonychain/subscriptions","organizations_url":"https://api.github.com/users/tonychain/orgs","repos_url":"https://api.github.com/users/tonychain/repos","events_url":"https://api.github.com/users/tonychain/events{/privacy}","received_events_url":"https://api.github.com/users/tonychain/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-18T01:59:18Z","updated_at":"2017-12-14T23:35:36Z","closed_at":"2017-12-14T23:35:36Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/carllerche/bytes/pulls/153","html_url":"https://github.com/carllerche/bytes/pull/153","diff_url":"https://github.com/carllerche/bytes/pull/153.diff","patch_url":"https://github.com/carllerche/bytes/pull/153.patch"},"body":"This gates all allocator-dependent features on an \"allocator\" feature.\r\n\r\nIt also adds a \"nightly\" feature which enables using the \"allocator\" feature in no_std environments. This requires using `#[feature(alloc)]` which requires nightly.\r\n\r\nThe \"allocator\" feature is automatically enabled when either the \"std\" or \"nightly\" features are enabled.\r\n\r\nTravis CI is configured to check that builds succeed with both the \"nightly\" feature along with \"std\" and \"nightly\" in combination. To avoid the problem of nightly changes breaking the build, these combinations are specifically flagged as allowed failures in the Travis CI configuration."},"comment":{"url":"https://api.github.com/repos/carllerche/bytes/issues/comments/351868824","html_url":"https://github.com/carllerche/bytes/pull/153#issuecomment-351868824","issue_url":"https://api.github.com/repos/carllerche/bytes/issues/153","id":351868824,"user":{"login":"carllerche","id":6180,"avatar_url":"https://avatars3.githubusercontent.com/u/6180?v=4","gravatar_id":"","url":"https://api.github.com/users/carllerche","html_url":"https://github.com/carllerche","followers_url":"https://api.github.com/users/carllerche/followers","following_url":"https://api.github.com/users/carllerche/following{/other_user}","gists_url":"https://api.github.com/users/carllerche/gists{/gist_id}","starred_url":"https://api.github.com/users/carllerche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carllerche/subscriptions","organizations_url":"https://api.github.com/users/carllerche/orgs","repos_url":"https://api.github.com/users/carllerche/repos","events_url":"https://api.github.com/users/carllerche/events{/privacy}","received_events_url":"https://api.github.com/users/carllerche/received_events","type":"User","site_admin":false},"created_at":"2017-12-14T23:35:36Z","updated_at":"2017-12-14T23:35:36Z","author_association":"OWNER","body":"Sorry to have left this without a response.\r\n\r\nI don't think we want to add a dependency (even hidden behind a feature flag) on the allocator crate as it is highly unstable.\r\n\r\n#135 is fine as an approach to support `no_std` but it does not include any types that require allocation.\r\n\r\nI'm going to close this for now as #135 is the preferred path forward."}}
{"actor":{"display_login":"carllerche"}}