{"action":"closed","number":5199,"pull_request":{"url":"https://api.github.com/repos/discourse/discourse/pulls/5199","id":142248441,"html_url":"https://github.com/discourse/discourse/pull/5199","diff_url":"https://github.com/discourse/discourse/pull/5199.diff","patch_url":"https://github.com/discourse/discourse/pull/5199.patch","issue_url":"https://api.github.com/repos/discourse/discourse/issues/5199","number":5199,"state":"closed","locked":false,"title":"TEST ONLY: PollFeed integration test","user":{"login":"xrav3nz","id":6376558,"avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"body":"> CONTEXT: https://meta.discourse.org/t/simple-rss-is-buggy-and-should-be-forked-or-replaced/27529/23\r\n\r\nThis is _almost_ a spec-only PR that introduces integration tests for PollFeed (except for a tiny bug fix discovered by the new tests). There will be a follow-up PR to actually replace the SimpleRSS gem with the built-in Ruby RSS module.\r\n\r\nThe new tests focus on parsing and extracting the correct information out of the RSS/XML feed. Open to suggestions, and let me know if you think more cases should be covered (i.e. all logic in `PollFeed::Feed`).\r\n\r\n\r\n","created_at":"2017-09-21T03:26:58Z","updated_at":"2017-10-03T06:33:23Z","closed_at":"2017-10-03T06:33:23Z","merged_at":"2017-10-03T06:33:22Z","merge_commit_sha":"a5b7d34fe21de4c2fd45de1370d042100b60adf0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/discourse/discourse/pulls/5199/commits","review_comments_url":"https://api.github.com/repos/discourse/discourse/pulls/5199/comments","review_comment_url":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/discourse/discourse/issues/5199/comments","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/15cd3b78aec7f4716b1a5c9e36686b415a2edf79","head":{"label":"xrav3nz:poll-feed-integration-test","ref":"poll-feed-integration-test","sha":"15cd3b78aec7f4716b1a5c9e36686b415a2edf79","user":{"login":"xrav3nz","id":6376558,"avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"repo":{"id":99668064,"name":"discourse","full_name":"xrav3nz/discourse","owner":{"login":"xrav3nz","id":6376558,"avatar_url":"https://avatars0.githubusercontent.com/u/6376558?v=4","gravatar_id":"","url":"https://api.github.com/users/xrav3nz","html_url":"https://github.com/xrav3nz","followers_url":"https://api.github.com/users/xrav3nz/followers","following_url":"https://api.github.com/users/xrav3nz/following{/other_user}","gists_url":"https://api.github.com/users/xrav3nz/gists{/gist_id}","starred_url":"https://api.github.com/users/xrav3nz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrav3nz/subscriptions","organizations_url":"https://api.github.com/users/xrav3nz/orgs","repos_url":"https://api.github.com/users/xrav3nz/repos","events_url":"https://api.github.com/users/xrav3nz/events{/privacy}","received_events_url":"https://api.github.com/users/xrav3nz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xrav3nz/discourse","description":"A platform for community discussion. Free, open, simple.","fork":true,"url":"https://api.github.com/repos/xrav3nz/discourse","forks_url":"https://api.github.com/repos/xrav3nz/discourse/forks","keys_url":"https://api.github.com/repos/xrav3nz/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xrav3nz/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xrav3nz/discourse/teams","hooks_url":"https://api.github.com/repos/xrav3nz/discourse/hooks","issue_events_url":"https://api.github.com/repos/xrav3nz/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/xrav3nz/discourse/events","assignees_url":"https://api.github.com/repos/xrav3nz/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/xrav3nz/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/xrav3nz/discourse/tags","blobs_url":"https://api.github.com/repos/xrav3nz/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xrav3nz/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xrav3nz/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/xrav3nz/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xrav3nz/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/xrav3nz/discourse/languages","stargazers_url":"https://api.github.com/repos/xrav3nz/discourse/stargazers","contributors_url":"https://api.github.com/repos/xrav3nz/discourse/contributors","subscribers_url":"https://api.github.com/repos/xrav3nz/discourse/subscribers","subscription_url":"https://api.github.com/repos/xrav3nz/discourse/subscription","commits_url":"https://api.github.com/repos/xrav3nz/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/xrav3nz/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/xrav3nz/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/xrav3nz/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/xrav3nz/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/xrav3nz/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xrav3nz/discourse/merges","archive_url":"https://api.github.com/repos/xrav3nz/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xrav3nz/discourse/downloads","issues_url":"https://api.github.com/repos/xrav3nz/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/xrav3nz/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/xrav3nz/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/xrav3nz/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xrav3nz/discourse/labels{/name}","releases_url":"https://api.github.com/repos/xrav3nz/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/xrav3nz/discourse/deployments","created_at":"2017-08-08T08:13:56Z","updated_at":"2017-08-08T08:14:19Z","pushed_at":"2017-10-02T05:16:31Z","git_url":"git://github.com/xrav3nz/discourse.git","ssh_url":"git@github.com:xrav3nz/discourse.git","clone_url":"https://github.com/xrav3nz/discourse.git","svn_url":"https://github.com/xrav3nz/discourse","homepage":"https://www.discourse.org","size":186699,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"discourse:master","ref":"master","sha":"b5bbb8ae8a8fd8c91085639378b969414266c487","user":{"login":"discourse","id":3220138,"avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"repo":{"id":7569578,"name":"discourse","full_name":"discourse/discourse","owner":{"login":"discourse","id":3220138,"avatar_url":"https://avatars2.githubusercontent.com/u/3220138?v=4","gravatar_id":"","url":"https://api.github.com/users/discourse","html_url":"https://github.com/discourse","followers_url":"https://api.github.com/users/discourse/followers","following_url":"https://api.github.com/users/discourse/following{/other_user}","gists_url":"https://api.github.com/users/discourse/gists{/gist_id}","starred_url":"https://api.github.com/users/discourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/discourse/subscriptions","organizations_url":"https://api.github.com/users/discourse/orgs","repos_url":"https://api.github.com/users/discourse/repos","events_url":"https://api.github.com/users/discourse/events{/privacy}","received_events_url":"https://api.github.com/users/discourse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/discourse/discourse","description":"A platform for community discussion. Free, open, simple.","fork":false,"url":"https://api.github.com/repos/discourse/discourse","forks_url":"https://api.github.com/repos/discourse/discourse/forks","keys_url":"https://api.github.com/repos/discourse/discourse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/discourse/discourse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/discourse/discourse/teams","hooks_url":"https://api.github.com/repos/discourse/discourse/hooks","issue_events_url":"https://api.github.com/repos/discourse/discourse/issues/events{/number}","events_url":"https://api.github.com/repos/discourse/discourse/events","assignees_url":"https://api.github.com/repos/discourse/discourse/assignees{/user}","branches_url":"https://api.github.com/repos/discourse/discourse/branches{/branch}","tags_url":"https://api.github.com/repos/discourse/discourse/tags","blobs_url":"https://api.github.com/repos/discourse/discourse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/discourse/discourse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/discourse/discourse/git/refs{/sha}","trees_url":"https://api.github.com/repos/discourse/discourse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/discourse/discourse/statuses/{sha}","languages_url":"https://api.github.com/repos/discourse/discourse/languages","stargazers_url":"https://api.github.com/repos/discourse/discourse/stargazers","contributors_url":"https://api.github.com/repos/discourse/discourse/contributors","subscribers_url":"https://api.github.com/repos/discourse/discourse/subscribers","subscription_url":"https://api.github.com/repos/discourse/discourse/subscription","commits_url":"https://api.github.com/repos/discourse/discourse/commits{/sha}","git_commits_url":"https://api.github.com/repos/discourse/discourse/git/commits{/sha}","comments_url":"https://api.github.com/repos/discourse/discourse/comments{/number}","issue_comment_url":"https://api.github.com/repos/discourse/discourse/issues/comments{/number}","contents_url":"https://api.github.com/repos/discourse/discourse/contents/{+path}","compare_url":"https://api.github.com/repos/discourse/discourse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/discourse/discourse/merges","archive_url":"https://api.github.com/repos/discourse/discourse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/discourse/discourse/downloads","issues_url":"https://api.github.com/repos/discourse/discourse/issues{/number}","pulls_url":"https://api.github.com/repos/discourse/discourse/pulls{/number}","milestones_url":"https://api.github.com/repos/discourse/discourse/milestones{/number}","notifications_url":"https://api.github.com/repos/discourse/discourse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/discourse/discourse/labels{/name}","releases_url":"https://api.github.com/repos/discourse/discourse/releases{/id}","deployments_url":"https://api.github.com/repos/discourse/discourse/deployments","created_at":"2013-01-12T00:25:55Z","updated_at":"2017-10-02T21:41:24Z","pushed_at":"2017-10-03T06:33:22Z","git_url":"git://github.com/discourse/discourse.git","ssh_url":"git@github.com:discourse/discourse.git","clone_url":"https://github.com/discourse/discourse.git","svn_url":"https://github.com/discourse/discourse","homepage":"https://www.discourse.org","size":186834,"stargazers_count":22818,"watchers_count":22818,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5782,"mirror_url":null,"open_issues_count":13,"forks":5782,"open_issues":13,"watchers":22818,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/discourse/discourse/pulls/5199"},"html":{"href":"https://github.com/discourse/discourse/pull/5199"},"issue":{"href":"https://api.github.com/repos/discourse/discourse/issues/5199"},"comments":{"href":"https://api.github.com/repos/discourse/discourse/issues/5199/comments"},"review_comments":{"href":"https://api.github.com/repos/discourse/discourse/pulls/5199/comments"},"review_comment":{"href":"https://api.github.com/repos/discourse/discourse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/discourse/discourse/pulls/5199/commits"},"statuses":{"href":"https://api.github.com/repos/discourse/discourse/statuses/15cd3b78aec7f4716b1a5c9e36686b415a2edf79"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tgxworld","id":4335742,"avatar_url":"https://avatars3.githubusercontent.com/u/4335742?v=4","gravatar_id":"","url":"https://api.github.com/users/tgxworld","html_url":"https://github.com/tgxworld","followers_url":"https://api.github.com/users/tgxworld/followers","following_url":"https://api.github.com/users/tgxworld/following{/other_user}","gists_url":"https://api.github.com/users/tgxworld/gists{/gist_id}","starred_url":"https://api.github.com/users/tgxworld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgxworld/subscriptions","organizations_url":"https://api.github.com/users/tgxworld/orgs","repos_url":"https://api.github.com/users/tgxworld/repos","events_url":"https://api.github.com/users/tgxworld/events{/privacy}","received_events_url":"https://api.github.com/users/tgxworld/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":2,"additions":102,"deletions":1,"changed_files":3}}
{"actor":{"display_login":"tgxworld"}}