{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/113672702","pull_request_review_id":35080366,"id":113672702,"diff_hunk":"@@ -246,6 +246,9 @@\n       action :delete\n     end\n \n+  when \"ironic\"","path":"chef/cookbooks/nova/recipes/compute.rb","position":null,"original_position":4,"commit_id":"c291b83f6a88a8e8558510823d8c798150b2361c","original_commit_id":"8f14c4051689fccea7aeb15bc1f2abacb100035f","user":{"login":"skazi0","id":2458112,"avatar_url":"https://avatars0.githubusercontent.com/u/2458112?v=3","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"body":"I don't like this long `case` too. As a quick fix I moved ironic section to top as it's only one line (like zvm).","created_at":"2017-04-27T11:25:18Z","updated_at":"2017-04-27T11:25:18Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/449#discussion_r113672702","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/449","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/113672702"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/449#discussion_r113672702"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/449"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/449","id":77606234,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/449","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/449.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/449.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/449","number":449,"state":"open","locked":false,"title":"Ironic barclamp","user":{"login":"skazi0","id":2458112,"avatar_url":"https://avatars0.githubusercontent.com/u/2458112?v=3","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"body":"Implementation of the barclamp to install Ironic services using crowbar.\r\n- [x] new barclamp for installation and configuration of ironic-api and ironic-conductor\r\n- [x] new role (nova-compute-ironic) in nova barclamp for configuration of nova node which will act as a \"proxy\" for ironic\r\n- [x] neutron configuration handling\r\n- [x] PXE/tftp configuration\r\n- [ ] ironic specific images and flavors\r\n\r\nKnown bugs/issues:\r\n- [ ] host manager in nova config can be either for baremetal or for VMs. Baremetal option works only with baremetal machines. Default host manager can handle both baremetal and VMs but it requires some tricks to make things work. Current implementation uses the ironic host manager. Selecting this could be added as an option in the barclamp if it makes sense.\r\n- [x] nova-compute-ironic needs to be on the same host as ironic-server.\r\n- [x] ironic-br bridge is lost after re-applying Ironic proposal. After re-applying Neutron proposal it's back but misses some connections.\r\n- [ ] isolation of instance types in mixed hypervisor (i.e. baremetal + vm) setup was not tested (using AZ is one of options)\r\n- [ ] ironic-server needs to be on the same node as neutron-server (and maybe others)\r\n- [x] nova proposal needs to be re-applied after ironic-server is applied\r\n- [ ] linuxbridge is not supported (only ovs based networking is implemented)","created_at":"2016-07-15T12:13:50Z","updated_at":"2017-04-27T11:25:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2f143b8ee8fd567bbed795c899c4364a589c23b","assignee":{"login":"rhafer","id":373399,"avatar_url":"https://avatars1.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},"assignees":[{"login":"rhafer","id":373399,"avatar_url":"https://avatars1.githubusercontent.com/u/373399?v=3","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},{"login":"nkrinner","id":975758,"avatar_url":"https://avatars3.githubusercontent.com/u/975758?v=3","gravatar_id":"","url":"https://api.github.com/users/nkrinner","html_url":"https://github.com/nkrinner","followers_url":"https://api.github.com/users/nkrinner/followers","following_url":"https://api.github.com/users/nkrinner/following{/other_user}","gists_url":"https://api.github.com/users/nkrinner/gists{/gist_id}","starred_url":"https://api.github.com/users/nkrinner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nkrinner/subscriptions","organizations_url":"https://api.github.com/users/nkrinner/orgs","repos_url":"https://api.github.com/users/nkrinner/repos","events_url":"https://api.github.com/users/nkrinner/events{/privacy}","received_events_url":"https://api.github.com/users/nkrinner/received_events","type":"User","site_admin":false},{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars2.githubusercontent.com/u/1029152?v=3","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},{"login":"mjura","id":4455471,"avatar_url":"https://avatars0.githubusercontent.com/u/4455471?v=3","gravatar_id":"","url":"https://api.github.com/users/mjura","html_url":"https://github.com/mjura","followers_url":"https://api.github.com/users/mjura/followers","following_url":"https://api.github.com/users/mjura/following{/other_user}","gists_url":"https://api.github.com/users/mjura/gists{/gist_id}","starred_url":"https://api.github.com/users/mjura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjura/subscriptions","organizations_url":"https://api.github.com/users/mjura/orgs","repos_url":"https://api.github.com/users/mjura/repos","events_url":"https://api.github.com/users/mjura/events{/privacy}","received_events_url":"https://api.github.com/users/mjura/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/449/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/449/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/449/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/c291b83f6a88a8e8558510823d8c798150b2361c","head":{"label":"skazi0:ironic-barclamp","ref":"ironic-barclamp","sha":"c291b83f6a88a8e8558510823d8c798150b2361c","user":{"login":"skazi0","id":2458112,"avatar_url":"https://avatars0.githubusercontent.com/u/2458112?v=3","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"repo":{"id":62718880,"name":"crowbar-openstack","full_name":"skazi0/crowbar-openstack","owner":{"login":"skazi0","id":2458112,"avatar_url":"https://avatars0.githubusercontent.com/u/2458112?v=3","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skazi0/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/skazi0/crowbar-openstack","forks_url":"https://api.github.com/repos/skazi0/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/skazi0/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skazi0/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skazi0/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/skazi0/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/skazi0/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/skazi0/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/skazi0/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/skazi0/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/skazi0/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skazi0/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/skazi0/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/skazi0/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/skazi0/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/skazi0/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/skazi0/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/skazi0/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/skazi0/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/skazi0/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/skazi0/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/skazi0/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/skazi0/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skazi0/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/skazi0/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skazi0/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/skazi0/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/skazi0/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/skazi0/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/skazi0/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skazi0/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/skazi0/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/skazi0/crowbar-openstack/deployments","created_at":"2016-07-06T12:20:57Z","updated_at":"2017-03-30T10:43:07Z","pushed_at":"2017-04-27T11:24:18Z","git_url":"git://github.com/skazi0/crowbar-openstack.git","ssh_url":"git@github.com:skazi0/crowbar-openstack.git","clone_url":"https://github.com/skazi0/crowbar-openstack.git","svn_url":"https://github.com/skazi0/crowbar-openstack","homepage":null,"size":18488,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"bb440e27c6548f1d231d14d7aba6df852bb08680","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars1.githubusercontent.com/u/2910205?v=3","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2017-03-24T11:40:40Z","pushed_at":"2017-04-27T11:24:19Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":18707,"stargazers_count":11,"watchers_count":11,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"open_issues_count":57,"forks":55,"open_issues":57,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/449"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/449"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/449"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/449/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/449/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/449/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/c291b83f6a88a8e8558510823d8c798150b2361c"}}}}
{"actor":{"display_login":"skazi0"}}