{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/paas-bootstrap/issues/60","repository_url":"https://api.github.com/repos/alphagov/paas-bootstrap","labels_url":"https://api.github.com/repos/alphagov/paas-bootstrap/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/paas-bootstrap/issues/60/comments","events_url":"https://api.github.com/repos/alphagov/paas-bootstrap/issues/60/events","html_url":"https://github.com/alphagov/paas-bootstrap/pull/60","id":227381733,"number":60,"title":"Add a btrfs process count metric on concourse","user":{"login":"Jonty","id":1553,"avatar_url":"https://avatars0.githubusercontent.com/u/1553?v=3","gravatar_id":"","url":"https://api.github.com/users/Jonty","html_url":"https://github.com/Jonty","followers_url":"https://api.github.com/users/Jonty/followers","following_url":"https://api.github.com/users/Jonty/following{/other_user}","gists_url":"https://api.github.com/users/Jonty/gists{/gist_id}","starred_url":"https://api.github.com/users/Jonty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jonty/subscriptions","organizations_url":"https://api.github.com/users/Jonty/orgs","repos_url":"https://api.github.com/users/Jonty/repos","events_url":"https://api.github.com/users/Jonty/events{/privacy}","received_events_url":"https://api.github.com/users/Jonty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"dcarley","id":260438,"avatar_url":"https://avatars3.githubusercontent.com/u/260438?v=3","gravatar_id":"","url":"https://api.github.com/users/dcarley","html_url":"https://github.com/dcarley","followers_url":"https://api.github.com/users/dcarley/followers","following_url":"https://api.github.com/users/dcarley/following{/other_user}","gists_url":"https://api.github.com/users/dcarley/gists{/gist_id}","starred_url":"https://api.github.com/users/dcarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcarley/subscriptions","organizations_url":"https://api.github.com/users/dcarley/orgs","repos_url":"https://api.github.com/users/dcarley/repos","events_url":"https://api.github.com/users/dcarley/events{/privacy}","received_events_url":"https://api.github.com/users/dcarley/received_events","type":"User","site_admin":false},"assignees":[{"login":"dcarley","id":260438,"avatar_url":"https://avatars3.githubusercontent.com/u/260438?v=3","gravatar_id":"","url":"https://api.github.com/users/dcarley","html_url":"https://github.com/dcarley","followers_url":"https://api.github.com/users/dcarley/followers","following_url":"https://api.github.com/users/dcarley/following{/other_user}","gists_url":"https://api.github.com/users/dcarley/gists{/gist_id}","starred_url":"https://api.github.com/users/dcarley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcarley/subscriptions","organizations_url":"https://api.github.com/users/dcarley/orgs","repos_url":"https://api.github.com/users/dcarley/repos","events_url":"https://api.github.com/users/dcarley/events{/privacy}","received_events_url":"https://api.github.com/users/dcarley/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-05-09T14:15:44Z","updated_at":"2017-05-10T13:00:54Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/alphagov/paas-bootstrap/pulls/60","html_url":"https://github.com/alphagov/paas-bootstrap/pull/60","diff_url":"https://github.com/alphagov/paas-bootstrap/pull/60.diff","patch_url":"https://github.com/alphagov/paas-bootstrap/pull/60.patch"},"body":"## What\r\n\r\nThis causes the datadog agent to track all btrfs processes running on the concourse machines, which we then use in https://github.com/alphagov/paas-cf/pull/906 to alert when it gets out of control.\r\n\r\n## How to review\r\n\r\n1. Deploy to your deployer concourse (with `ENABLE_DATADOG=true`)\r\n1. Check that your concourse is emitting a new `system.processes.number` metric for `process_name:btrfs`\r\n\r\n## After this is merged\r\n\r\nThis must be deployed to our ci/staging/prod concourses."},"comment":{"url":"https://api.github.com/repos/alphagov/paas-bootstrap/issues/comments/300474485","html_url":"https://github.com/alphagov/paas-bootstrap/pull/60#issuecomment-300474485","issue_url":"https://api.github.com/repos/alphagov/paas-bootstrap/issues/60","id":300474485,"user":{"login":"Jonty","id":1553,"avatar_url":"https://avatars0.githubusercontent.com/u/1553?v=3","gravatar_id":"","url":"https://api.github.com/users/Jonty","html_url":"https://github.com/Jonty","followers_url":"https://api.github.com/users/Jonty/followers","following_url":"https://api.github.com/users/Jonty/following{/other_user}","gists_url":"https://api.github.com/users/Jonty/gists{/gist_id}","starred_url":"https://api.github.com/users/Jonty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jonty/subscriptions","organizations_url":"https://api.github.com/users/Jonty/orgs","repos_url":"https://api.github.com/users/Jonty/repos","events_url":"https://api.github.com/users/Jonty/events{/privacy}","received_events_url":"https://api.github.com/users/Jonty/received_events","type":"User","site_admin":false},"created_at":"2017-05-10T13:00:54Z","updated_at":"2017-05-10T13:00:54Z","body":"@dcarley Yes, it does mean that, I intended to call that out in the review notes for discussion but completely forgot.\r\n\r\nThis is because there's no easy way to add configuration for just one host in runtime-config - you can target specific deployments with an entire addon, but not with a specific bit of configuration.\r\n\r\nFor the rest of CF we have [`paas-datadog-for-cloudfoundry`](https://github.com/alphagov/paas-datadog-for-cloudfoundry-boshrelease) which drops datadog `conf.d` files on-disk to add metric collectors.\r\n\r\nThis means that we'll have a metric for the number of `btrfs` processes running on every machine in the cluster, but it won't have any adverse effects. It may even prove useful.\r\n\r\nAlternatives:\r\n* Produce a new bosh release that just adds the metric collector to the concourse VM, in a similar way to  [`paas-datadog-for-cloudfoundry`](https://github.com/alphagov/paas-datadog-for-cloudfoundry-boshrelease). Seems a bit overkill.\r\n* Duplicate the runtime config entry for the datadog-agent, then use runtime-config `include` rules to place two different configurations of the agent - one targetting the concourse deployment, and one targetting the cf deployment. Somewhat ugly."}}
{"actor":{"display_login":"Jonty"}}