{"action":"created","issue":{"url":"https://api.github.com/repos/in-toto/in-toto/issues/120","repository_url":"https://api.github.com/repos/in-toto/in-toto","labels_url":"https://api.github.com/repos/in-toto/in-toto/issues/120/labels{/name}","comments_url":"https://api.github.com/repos/in-toto/in-toto/issues/120/comments","events_url":"https://api.github.com/repos/in-toto/in-toto/issues/120/events","html_url":"https://github.com/in-toto/in-toto/pull/120","id":259364077,"number":120,"title":"Fix metadata format","user":{"login":"SantiagoTorres","id":3579933,"avatar_url":"https://avatars1.githubusercontent.com/u/3579933?v=4","gravatar_id":"","url":"https://api.github.com/users/SantiagoTorres","html_url":"https://github.com/SantiagoTorres","followers_url":"https://api.github.com/users/SantiagoTorres/followers","following_url":"https://api.github.com/users/SantiagoTorres/following{/other_user}","gists_url":"https://api.github.com/users/SantiagoTorres/gists{/gist_id}","starred_url":"https://api.github.com/users/SantiagoTorres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SantiagoTorres/subscriptions","organizations_url":"https://api.github.com/users/SantiagoTorres/orgs","repos_url":"https://api.github.com/users/SantiagoTorres/repos","events_url":"https://api.github.com/users/SantiagoTorres/events{/privacy}","received_events_url":"https://api.github.com/users/SantiagoTorres/received_events","type":"User","site_admin":false},"labels":[{"id":381362156,"url":"https://api.github.com/repos/in-toto/in-toto/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-21T03:21:18Z","updated_at":"2017-09-21T03:23:12Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/in-toto/in-toto/pulls/120","html_url":"https://github.com/in-toto/in-toto/pull/120","diff_url":"https://github.com/in-toto/in-toto/pull/120.diff","patch_url":"https://github.com/in-toto/in-toto/pull/120.patch"},"body":"The current state of the in-toto classes do not match with the description in the specification (closes #98) \r\n\r\nPlease review commit by commit, so as to make historical sense **and** to simplify your review process.\r\n\r\nYou will probably notice some OOP abuse, and other horrendous things (I apologize to the language puritans out there in advance). These are the things that I don't pledge allegiance to, but I included anyway (I was hoping to ticketize/discuss them):\r\n\r\n- The abuse of OOP (also known as, \"**why is there a mixin in my diff**\")\r\n- Is that a custom __getattr__ implementation?\r\n- The wonky adapter pattern in the constructor\r\n- The if-else clauses in the constructor (specially for links) so as to be too smart around the code throwing various types at it.\r\n\r\nMost of these were added to introduce a \"working copy\" in under a 300 line diff. I hope we can slowly pour in upgrades and cleanups to get rid of the mixin, the \"custom builtins\" and the \"why does this code try handle 3 different things at the same time\" instances."},"comment":{"url":"https://api.github.com/repos/in-toto/in-toto/issues/comments/331040207","html_url":"https://github.com/in-toto/in-toto/pull/120#issuecomment-331040207","issue_url":"https://api.github.com/repos/in-toto/in-toto/issues/120","id":331040207,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-09-21T03:23:12Z","updated_at":"2017-09-21T03:23:12Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/13365141/badge)](https://coveralls.io/builds/13365141)\n\nCoverage decreased (-0.1%) to 99.206% when pulling **c2f703085eeadd4a7d8dcc5f26a8307ed404f977 on fix_metadata_format** into **5d167c8d397e68daed3968eb61fa8e48cd4d7f23 on develop**.\n"}}
{"actor":{"display_login":"coveralls"}}