{"action":"created","comment":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments/124814723","pull_request_review_id":47140988,"id":124814723,"diff_hunk":"@@ -565,7 +573,7 @@ namespace hpx { namespace parallel { inline namespace v1\n                     out_iters.push_back(sit_out);\n                     results.push_back(dispatch_async(traits_in::get_id(sit_in),\n                         segmented_scan_T<T>(), policy,\n-                        forced_seq(), beg, end, op));\n+                        forced_seq(), beg, end, op, conv));","path":"hpx/parallel/segmented_algorithms/detail/scan.hpp","position":138,"original_position":138,"commit_id":"b296c2e6aaeeeaca84ee8e0735085ee7cd8b7d3f","original_commit_id":"b296c2e6aaeeeaca84ee8e0735085ee7cd8b7d3f","user":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars2.githubusercontent.com/u/568063?v=3","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"body":"`conv` has to be perfectly forwarded (here and more places below).","created_at":"2017-06-29T14:26:29Z","updated_at":"2017-06-29T14:26:29Z","html_url":"https://github.com/STEllAR-GROUP/hpx/pull/2725#discussion_r124814723","pull_request_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/2725","_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments/124814723"},"html":{"href":"https://github.com/STEllAR-GROUP/hpx/pull/2725#discussion_r124814723"},"pull_request":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/2725"}}},"pull_request":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/2725","id":128149729,"html_url":"https://github.com/STEllAR-GROUP/hpx/pull/2725","diff_url":"https://github.com/STEllAR-GROUP/hpx/pull/2725.diff","patch_url":"https://github.com/STEllAR-GROUP/hpx/pull/2725.patch","issue_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2725","number":2725,"state":"open","locked":false,"title":"Implemented segmented algorithms for partitioned vector","user":{"login":"ajaivgeorge","id":5080703,"avatar_url":"https://avatars0.githubusercontent.com/u/5080703?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaivgeorge","html_url":"https://github.com/ajaivgeorge","followers_url":"https://api.github.com/users/ajaivgeorge/followers","following_url":"https://api.github.com/users/ajaivgeorge/following{/other_user}","gists_url":"https://api.github.com/users/ajaivgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaivgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaivgeorge/subscriptions","organizations_url":"https://api.github.com/users/ajaivgeorge/orgs","repos_url":"https://api.github.com/users/ajaivgeorge/repos","events_url":"https://api.github.com/users/ajaivgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/ajaivgeorge/received_events","type":"User","site_admin":false},"body":"Tasks completed as part of GSoC project (See: #1338) -\r\n  - Moved unit tests for segmented algorithms from component to\r\n    parallel/segmented_algorithms\r\n  - Implemented segmented for_each_n using existing segmented for_each\r\n  - Implemented segmented unary transform\r\n  - Implemented 2 versions of segmented binary transform with 4 and 5\r\n    iterators as arguments\r\n  - Implemented segmented reduce\r\n  - Implemented segmented transform_inclusive/exclusive_scan by\r\n    modifying existing inclusive/exculsive_scan to accept one more\r\n    default parameter (unary operator) as input\r\n  - modified dispatch.hpp in both algorithms/detail and\r\n    segmented_algorithms/detail to add helper functions for output type\r\n    inference and casting\r\n\r\nAll algorithms have associated passing tests in the unit/parallel/segmented_algorithms folder.\r\nInspect shows 0 errors\r\nThis branch has been updated with the almost latest hpx/master and only one test unrelated to my code fails (68 - tests.regressions.lcos_dir.wait_for_1751), which has been fixed in later commits.","created_at":"2017-06-29T13:21:06Z","updated_at":"2017-06-29T14:26:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7a680d4409423d289a55d6106263111eb212bfc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones/26","html_url":"https://github.com/STEllAR-GROUP/hpx/milestone/26","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones/26/labels","id":2254928,"number":26,"title":"1.1.0","description":"","creator":{"login":"hkaiser","id":568063,"avatar_url":"https://avatars2.githubusercontent.com/u/568063?v=3","gravatar_id":"","url":"https://api.github.com/users/hkaiser","html_url":"https://github.com/hkaiser","followers_url":"https://api.github.com/users/hkaiser/followers","following_url":"https://api.github.com/users/hkaiser/following{/other_user}","gists_url":"https://api.github.com/users/hkaiser/gists{/gist_id}","starred_url":"https://api.github.com/users/hkaiser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkaiser/subscriptions","organizations_url":"https://api.github.com/users/hkaiser/orgs","repos_url":"https://api.github.com/users/hkaiser/repos","events_url":"https://api.github.com/users/hkaiser/events{/privacy}","received_events_url":"https://api.github.com/users/hkaiser/received_events","type":"User","site_admin":false},"open_issues":132,"closed_issues":113,"state":"open","created_at":"2017-01-16T14:53:21Z","updated_at":"2017-06-29T13:39:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/2725/commits","review_comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/2725/comments","review_comment_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2725/comments","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/b296c2e6aaeeeaca84ee8e0735085ee7cd8b7d3f","head":{"label":"ajaivgeorge:master","ref":"master","sha":"b296c2e6aaeeeaca84ee8e0735085ee7cd8b7d3f","user":{"login":"ajaivgeorge","id":5080703,"avatar_url":"https://avatars0.githubusercontent.com/u/5080703?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaivgeorge","html_url":"https://github.com/ajaivgeorge","followers_url":"https://api.github.com/users/ajaivgeorge/followers","following_url":"https://api.github.com/users/ajaivgeorge/following{/other_user}","gists_url":"https://api.github.com/users/ajaivgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaivgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaivgeorge/subscriptions","organizations_url":"https://api.github.com/users/ajaivgeorge/orgs","repos_url":"https://api.github.com/users/ajaivgeorge/repos","events_url":"https://api.github.com/users/ajaivgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/ajaivgeorge/received_events","type":"User","site_admin":false},"repo":{"id":90903149,"name":"hpx","full_name":"ajaivgeorge/hpx","owner":{"login":"ajaivgeorge","id":5080703,"avatar_url":"https://avatars0.githubusercontent.com/u/5080703?v=3","gravatar_id":"","url":"https://api.github.com/users/ajaivgeorge","html_url":"https://github.com/ajaivgeorge","followers_url":"https://api.github.com/users/ajaivgeorge/followers","following_url":"https://api.github.com/users/ajaivgeorge/following{/other_user}","gists_url":"https://api.github.com/users/ajaivgeorge/gists{/gist_id}","starred_url":"https://api.github.com/users/ajaivgeorge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajaivgeorge/subscriptions","organizations_url":"https://api.github.com/users/ajaivgeorge/orgs","repos_url":"https://api.github.com/users/ajaivgeorge/repos","events_url":"https://api.github.com/users/ajaivgeorge/events{/privacy}","received_events_url":"https://api.github.com/users/ajaivgeorge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ajaivgeorge/hpx","description":"The C++ Standard Library for Parallelism and Concurrency","fork":true,"url":"https://api.github.com/repos/ajaivgeorge/hpx","forks_url":"https://api.github.com/repos/ajaivgeorge/hpx/forks","keys_url":"https://api.github.com/repos/ajaivgeorge/hpx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ajaivgeorge/hpx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ajaivgeorge/hpx/teams","hooks_url":"https://api.github.com/repos/ajaivgeorge/hpx/hooks","issue_events_url":"https://api.github.com/repos/ajaivgeorge/hpx/issues/events{/number}","events_url":"https://api.github.com/repos/ajaivgeorge/hpx/events","assignees_url":"https://api.github.com/repos/ajaivgeorge/hpx/assignees{/user}","branches_url":"https://api.github.com/repos/ajaivgeorge/hpx/branches{/branch}","tags_url":"https://api.github.com/repos/ajaivgeorge/hpx/tags","blobs_url":"https://api.github.com/repos/ajaivgeorge/hpx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ajaivgeorge/hpx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ajaivgeorge/hpx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ajaivgeorge/hpx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ajaivgeorge/hpx/statuses/{sha}","languages_url":"https://api.github.com/repos/ajaivgeorge/hpx/languages","stargazers_url":"https://api.github.com/repos/ajaivgeorge/hpx/stargazers","contributors_url":"https://api.github.com/repos/ajaivgeorge/hpx/contributors","subscribers_url":"https://api.github.com/repos/ajaivgeorge/hpx/subscribers","subscription_url":"https://api.github.com/repos/ajaivgeorge/hpx/subscription","commits_url":"https://api.github.com/repos/ajaivgeorge/hpx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ajaivgeorge/hpx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ajaivgeorge/hpx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ajaivgeorge/hpx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ajaivgeorge/hpx/contents/{+path}","compare_url":"https://api.github.com/repos/ajaivgeorge/hpx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ajaivgeorge/hpx/merges","archive_url":"https://api.github.com/repos/ajaivgeorge/hpx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ajaivgeorge/hpx/downloads","issues_url":"https://api.github.com/repos/ajaivgeorge/hpx/issues{/number}","pulls_url":"https://api.github.com/repos/ajaivgeorge/hpx/pulls{/number}","milestones_url":"https://api.github.com/repos/ajaivgeorge/hpx/milestones{/number}","notifications_url":"https://api.github.com/repos/ajaivgeorge/hpx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ajaivgeorge/hpx/labels{/name}","releases_url":"https://api.github.com/repos/ajaivgeorge/hpx/releases{/id}","deployments_url":"https://api.github.com/repos/ajaivgeorge/hpx/deployments","created_at":"2017-05-10T19:57:25Z","updated_at":"2017-05-10T19:57:34Z","pushed_at":"2017-06-28T18:34:24Z","git_url":"git://github.com/ajaivgeorge/hpx.git","ssh_url":"git@github.com:ajaivgeorge/hpx.git","clone_url":"https://github.com/ajaivgeorge/hpx.git","svn_url":"https://github.com/ajaivgeorge/hpx","homepage":"http://stellar-group.org/libraries/hpx","size":605269,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"STEllAR-GROUP:master","ref":"master","sha":"383eab90cad8a29dfd66f930d97bd50c77569689","user":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars2.githubusercontent.com/u/1780988?v=3","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"repo":{"id":4455628,"name":"hpx","full_name":"STEllAR-GROUP/hpx","owner":{"login":"STEllAR-GROUP","id":1780988,"avatar_url":"https://avatars2.githubusercontent.com/u/1780988?v=3","gravatar_id":"","url":"https://api.github.com/users/STEllAR-GROUP","html_url":"https://github.com/STEllAR-GROUP","followers_url":"https://api.github.com/users/STEllAR-GROUP/followers","following_url":"https://api.github.com/users/STEllAR-GROUP/following{/other_user}","gists_url":"https://api.github.com/users/STEllAR-GROUP/gists{/gist_id}","starred_url":"https://api.github.com/users/STEllAR-GROUP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/STEllAR-GROUP/subscriptions","organizations_url":"https://api.github.com/users/STEllAR-GROUP/orgs","repos_url":"https://api.github.com/users/STEllAR-GROUP/repos","events_url":"https://api.github.com/users/STEllAR-GROUP/events{/privacy}","received_events_url":"https://api.github.com/users/STEllAR-GROUP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/STEllAR-GROUP/hpx","description":"The C++ Standard Library for Parallelism and Concurrency","fork":false,"url":"https://api.github.com/repos/STEllAR-GROUP/hpx","forks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/forks","keys_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/teams","hooks_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/hooks","issue_events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/events{/number}","events_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/events","assignees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/assignees{/user}","branches_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/branches{/branch}","tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/tags","blobs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/refs{/sha}","trees_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/{sha}","languages_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/languages","stargazers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/stargazers","contributors_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contributors","subscribers_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscribers","subscription_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/subscription","commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/commits{/sha}","git_commits_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/git/commits{/sha}","comments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/comments{/number}","issue_comment_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/comments{/number}","contents_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/contents/{+path}","compare_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/merges","archive_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/downloads","issues_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues{/number}","pulls_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls{/number}","milestones_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/milestones{/number}","notifications_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/labels{/name}","releases_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/releases{/id}","deployments_url":"https://api.github.com/repos/STEllAR-GROUP/hpx/deployments","created_at":"2012-05-26T15:02:39Z","updated_at":"2017-06-27T21:59:24Z","pushed_at":"2017-06-29T13:21:06Z","git_url":"git://github.com/STEllAR-GROUP/hpx.git","ssh_url":"git@github.com:STEllAR-GROUP/hpx.git","clone_url":"https://github.com/STEllAR-GROUP/hpx.git","svn_url":"https://github.com/STEllAR-GROUP/hpx","homepage":"http://stellar-group.org/libraries/hpx","size":616296,"stargazers_count":667,"watchers_count":667,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":163,"mirror_url":null,"open_issues_count":139,"forks":163,"open_issues":139,"watchers":667,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/2725"},"html":{"href":"https://github.com/STEllAR-GROUP/hpx/pull/2725"},"issue":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2725"},"comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/issues/2725/comments"},"review_comments":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/2725/comments"},"review_comment":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/pulls/2725/commits"},"statuses":{"href":"https://api.github.com/repos/STEllAR-GROUP/hpx/statuses/b296c2e6aaeeeaca84ee8e0735085ee7cd8b7d3f"}}}}
{"actor":{"display_login":"hkaiser"}}