{"action":"created","issue":{"url":"https://api.github.com/repos/browserstack/browserstack-runner/issues/178","repository_url":"https://api.github.com/repos/browserstack/browserstack-runner","labels_url":"https://api.github.com/repos/browserstack/browserstack-runner/issues/178/labels{/name}","comments_url":"https://api.github.com/repos/browserstack/browserstack-runner/issues/178/comments","events_url":"https://api.github.com/repos/browserstack/browserstack-runner/issues/178/events","html_url":"https://github.com/browserstack/browserstack-runner/pull/178","id":227817735,"number":178,"title":"Fix for Issue #177","user":{"login":"reeteshranjan","id":5516599,"avatar_url":"https://avatars0.githubusercontent.com/u/5516599?v=3","gravatar_id":"","url":"https://api.github.com/users/reeteshranjan","html_url":"https://github.com/reeteshranjan","followers_url":"https://api.github.com/users/reeteshranjan/followers","following_url":"https://api.github.com/users/reeteshranjan/following{/other_user}","gists_url":"https://api.github.com/users/reeteshranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/reeteshranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reeteshranjan/subscriptions","organizations_url":"https://api.github.com/users/reeteshranjan/orgs","repos_url":"https://api.github.com/users/reeteshranjan/repos","events_url":"https://api.github.com/users/reeteshranjan/events{/privacy}","received_events_url":"https://api.github.com/users/reeteshranjan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-05-10T21:36:34Z","updated_at":"2017-05-10T23:52:00Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/browserstack/browserstack-runner/pulls/178","html_url":"https://github.com/browserstack/browserstack-runner/pull/178","diff_url":"https://github.com/browserstack/browserstack-runner/pull/178.diff","patch_url":"https://github.com/browserstack/browserstack-runner/pull/178.patch"},"body":"### Cause\r\n\r\nThe code that works with `Jasmine` is completely different from the one working with `Mocha` and `QUnit`. The results sent to `_report` api in case of `Jasmine` have very limited information resulting in the case as described in this issue.\r\n\r\nIt was found that the `Jasmine` reports are as good as `Mocha` ones and it's our code that does not let it pass through in its entirety causing the limited information.\r\n\r\n### Modifications\r\n\r\n- **jasmine-jsreporter.js** - It has the code that prepares per test suite report, and cuts out detailed information. It was modified to retain detailed information. Also some 'summarization' attributes turned out to be duplicate state post these modifications, and they were removed.\r\n- **jasmine-plugin.js** - It has code that further summarizes the reports created per suite in `jasmine-jsreporter.js` before making a call to the `_report` api. It was modified to retain detailed information.\r\n- **server.js** - for `Jasmine` case, a 'reformatting' adapter function is added. With the changes done in above files, detailed information as good as `Mocha` is available; however, the structure of the information is different. This function adapts the structure such that the final reports are seen in the format as in `README.md`. This function is called in the handler for `_report` api.\r\n\r\n### Limitations/Differences\r\n\r\n- There is no equivalent of `_progress` api added. The `tests` attribute at the topmost level in the final test reports is built in the `_progress` api handler in case of `Mocha`. This api gets called as each test completes, in case of `Mocha`. In `Jasmine` case, we build the `tests` attribute completely in the handler for `_report` api call.\r\n- In case of `Mocha`, whether it's an assertion failure or an uncaught exception, stack trace is available for both cases. In `Jasmine` case, stack trace is available only in case of uncaught exceptions. In case of assertion failures, `Jasmine` provides only a message, not a trace. This is a limitation that we do not have any control over as it exists in the source test reports data output by `Jasmine`."},"comment":{"url":"https://api.github.com/repos/browserstack/browserstack-runner/issues/comments/300643943","html_url":"https://github.com/browserstack/browserstack-runner/pull/178#issuecomment-300643943","issue_url":"https://api.github.com/repos/browserstack/browserstack-runner/issues/178","id":300643943,"user":{"login":"reeteshranjan","id":5516599,"avatar_url":"https://avatars0.githubusercontent.com/u/5516599?v=3","gravatar_id":"","url":"https://api.github.com/users/reeteshranjan","html_url":"https://github.com/reeteshranjan","followers_url":"https://api.github.com/users/reeteshranjan/followers","following_url":"https://api.github.com/users/reeteshranjan/following{/other_user}","gists_url":"https://api.github.com/users/reeteshranjan/gists{/gist_id}","starred_url":"https://api.github.com/users/reeteshranjan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reeteshranjan/subscriptions","organizations_url":"https://api.github.com/users/reeteshranjan/orgs","repos_url":"https://api.github.com/users/reeteshranjan/repos","events_url":"https://api.github.com/users/reeteshranjan/events{/privacy}","received_events_url":"https://api.github.com/users/reeteshranjan/received_events","type":"User","site_admin":false},"created_at":"2017-05-10T23:52:00Z","updated_at":"2017-05-10T23:52:00Z","body":"Bug in terms of not handling bad Jasmine data (comes in to play with spine v1.0 test) was fixed. Also, Safari 5.1 just won't work. Have changed spine v1.0 test browser to Safari 9.0, for which the test went through."}}
{"actor":{"display_login":"reeteshranjan"}}