{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/24992","repository_url":"https://api.github.com/repos/JuliaLang/julia","labels_url":"https://api.github.com/repos/JuliaLang/julia/issues/24992/labels{/name}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/24992/comments","events_url":"https://api.github.com/repos/JuliaLang/julia/issues/24992/events","html_url":"https://github.com/JuliaLang/julia/pull/24992","id":280609990,"number":24992,"title":"[WIP] Make it easier to extend broadcast!","user":{"login":"tkoolen","id":2585880,"avatar_url":"https://avatars0.githubusercontent.com/u/2585880?v=4","gravatar_id":"","url":"https://api.github.com/users/tkoolen","html_url":"https://github.com/tkoolen","followers_url":"https://api.github.com/users/tkoolen/followers","following_url":"https://api.github.com/users/tkoolen/following{/other_user}","gists_url":"https://api.github.com/users/tkoolen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkoolen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkoolen/subscriptions","organizations_url":"https://api.github.com/users/tkoolen/orgs","repos_url":"https://api.github.com/users/tkoolen/repos","events_url":"https://api.github.com/users/tkoolen/events{/privacy}","received_events_url":"https://api.github.com/users/tkoolen/received_events","type":"User","site_admin":false},"labels":[{"id":756208727,"url":"https://api.github.com/repos/JuliaLang/julia/labels/broadcast","name":"broadcast","color":"3289b5","default":false},{"id":294535982,"url":"https://api.github.com/repos/JuliaLang/julia/labels/needs%20docs","name":"needs docs","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/JuliaLang/julia/milestones/4","html_url":"https://github.com/JuliaLang/julia/milestone/4","labels_url":"https://api.github.com/repos/JuliaLang/julia/milestones/4/labels","id":96266,"number":4,"title":"1.0","description":"","creator":{"login":"StefanKarpinski","id":153596,"avatar_url":"https://avatars2.githubusercontent.com/u/153596?v=4","gravatar_id":"","url":"https://api.github.com/users/StefanKarpinski","html_url":"https://github.com/StefanKarpinski","followers_url":"https://api.github.com/users/StefanKarpinski/followers","following_url":"https://api.github.com/users/StefanKarpinski/following{/other_user}","gists_url":"https://api.github.com/users/StefanKarpinski/gists{/gist_id}","starred_url":"https://api.github.com/users/StefanKarpinski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/StefanKarpinski/subscriptions","organizations_url":"https://api.github.com/users/StefanKarpinski/orgs","repos_url":"https://api.github.com/users/StefanKarpinski/repos","events_url":"https://api.github.com/users/StefanKarpinski/events{/privacy}","received_events_url":"https://api.github.com/users/StefanKarpinski/received_events","type":"User","site_admin":false},"open_issues":53,"closed_issues":341,"state":"open","created_at":"2012-03-15T04:57:43Z","updated_at":"2017-12-21T20:45:03Z","due_on":"2017-12-15T08:00:00Z","closed_at":null},"comments":32,"created_at":"2017-12-08T20:37:53Z","updated_at":"2017-12-22T10:17:53Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/24992","html_url":"https://github.com/JuliaLang/julia/pull/24992","diff_url":"https://github.com/JuliaLang/julia/pull/24992.diff","patch_url":"https://github.com/JuliaLang/julia/pull/24992.patch"},"body":"Fix https://github.com/JuliaLang/julia/issues/24914.\r\n\r\nThis implements @timholy's proposal from https://github.com/JuliaLang/julia/issues/24914#issuecomment-349722131. This passes all tests locally except some `@inferred`/`@allocated` tests in `sparse/higherorderfns.jl`, specifically:\r\n* https://github.com/JuliaLang/julia/blob/5f929a4dc91ac0b644c556b574682bf3a4776098/test/sparse/higherorderfns.jl#L239\r\n* https://github.com/JuliaLang/julia/blob/5f929a4dc91ac0b644c556b574682bf3a4776098/test/sparse/higherorderfns.jl#L244\r\n* https://github.com/JuliaLang/julia/blob/5f929a4dc91ac0b644c556b574682bf3a4776098/test/sparse/higherorderfns.jl#L329 when the number of arguments is higher than some number\r\n* https://github.com/JuliaLang/julia/blob/5f929a4dc91ac0b644c556b574682bf3a4776098/test/sparse/higherorderfns.jl#L363\r\n\r\nI'm not exactly sure why this is the case, and could use some help.\r\n\r\nTo do:\r\n- [x] get `sparse/higherorderfns.jl` inference/allocation tests to pass\r\n- [x] documentation\r\n- [x] decide what to do with `broadcast!(f, X::AbstractArray, x::Number...)`\r\n\r\nI'll add some line comments to better explain what I did."},"comment":{"url":"https://api.github.com/repos/JuliaLang/julia/issues/comments/353568052","html_url":"https://github.com/JuliaLang/julia/pull/24992#issuecomment-353568052","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/24992","id":353568052,"user":{"login":"timholy","id":1525481,"avatar_url":"https://avatars3.githubusercontent.com/u/1525481?v=4","gravatar_id":"","url":"https://api.github.com/users/timholy","html_url":"https://github.com/timholy","followers_url":"https://api.github.com/users/timholy/followers","following_url":"https://api.github.com/users/timholy/following{/other_user}","gists_url":"https://api.github.com/users/timholy/gists{/gist_id}","starred_url":"https://api.github.com/users/timholy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timholy/subscriptions","organizations_url":"https://api.github.com/users/timholy/orgs","repos_url":"https://api.github.com/users/timholy/repos","events_url":"https://api.github.com/users/timholy/events{/privacy}","received_events_url":"https://api.github.com/users/timholy/received_events","type":"User","site_admin":false},"created_at":"2017-12-22T10:17:53Z","updated_at":"2017-12-22T10:17:53Z","author_association":"OWNER","body":"This passes tests locally for me. Let's get some performance data: @nanosoldier `runbenchmarks(ALL, vs = \":master\")`\r\n\r\n"}}
{"actor":{"display_login":"timholy"}}