{"action":"created","comment":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/101332025","pull_request_review_id":22056396,"id":101332025,"diff_hunk":"@@ -556,15 +557,78 @@ int mca_pml_ucx_isend_init(const void *buf, size_t count, ompi_datatype_t *datat\n     req->flags          = MCA_PML_UCX_REQUEST_FLAG_SEND;\n     req->buffer         = (void *)buf;\n     req->count          = count;\n-    req->datatype       = mca_pml_ucx_get_datatype(datatype);\n     req->tag            = PML_UCX_MAKE_SEND_TAG(tag, comm);\n     req->send.mode      = mode;\n     req->send.ep        = ep;\n+    if (MCA_PML_BASE_SEND_BUFFERED == mode) {\n+        req->ompi_datatype = datatype;\n+    } else {\n+        req->datatype = mca_pml_ucx_get_datatype(datatype);\n+    }\n \n     *request = &req->ompi;\n     return OMPI_SUCCESS;\n }\n \n+static int \n+mca_pml_ucx_bsend(ucp_ep_h ep, const void *buf, size_t count, \n+                  ompi_datatype_t *datatype, uint64_t pml_tag)\n+{\n+    ompi_request_t *req;\n+    void *packed_data;\n+    size_t packed_length;\n+    size_t offset;\n+    uint32_t iov_count;\n+    struct iovec iov;\n+    opal_convertor_t opal_conv;\n+\n+    OBJ_CONSTRUCT(&opal_conv, opal_convertor_t);\n+    opal_convertor_copy_and_prepare_for_recv(ompi_proc_local_proc->super.proc_convertor,\n+                                             &datatype->super, count, buf, 0,\n+                                             &opal_conv);\n+    opal_convertor_get_packed_size(&opal_conv, &packed_length);\n+\n+    packed_data = mca_pml_base_bsend_request_alloc_buf(packed_length);\n+    if (OPAL_UNLIKELY(NULL == packed_data)) {\n+        OBJ_DESTRUCT(&opal_conv);\n+        return OMPI_ERR_OUT_OF_RESOURCE;","path":"ompi/mca/pml/ucx/pml_ucx.c","position":74,"original_position":74,"commit_id":"c658525f49682a7446c523e8dd4e856eada7e027","original_commit_id":"c658525f49682a7446c523e8dd4e856eada7e027","user":{"login":"yosefe","id":2255631,"avatar_url":"https://avatars.githubusercontent.com/u/2255631?v=3","gravatar_id":"","url":"https://api.github.com/users/yosefe","html_url":"https://github.com/yosefe","followers_url":"https://api.github.com/users/yosefe/followers","following_url":"https://api.github.com/users/yosefe/following{/other_user}","gists_url":"https://api.github.com/users/yosefe/gists{/gist_id}","starred_url":"https://api.github.com/users/yosefe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yosefe/subscriptions","organizations_url":"https://api.github.com/users/yosefe/orgs","repos_url":"https://api.github.com/users/yosefe/repos","events_url":"https://api.github.com/users/yosefe/events{/privacy}","received_events_url":"https://api.github.com/users/yosefe/received_events","type":"User","site_admin":false},"body":"pls add error messages","created_at":"2017-02-15T17:20:00Z","updated_at":"2017-02-15T17:21:06Z","html_url":"https://github.com/open-mpi/ompi/pull/2944#discussion_r101332025","pull_request_url":"https://api.github.com/repos/open-mpi/ompi/pulls/2944","_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments/101332025"},"html":{"href":"https://github.com/open-mpi/ompi/pull/2944#discussion_r101332025"},"pull_request":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/2944"}}},"pull_request":{"url":"https://api.github.com/repos/open-mpi/ompi/pulls/2944","id":105448472,"html_url":"https://github.com/open-mpi/ompi/pull/2944","diff_url":"https://github.com/open-mpi/ompi/pull/2944.diff","patch_url":"https://github.com/open-mpi/ompi/pull/2944.patch","issue_url":"https://api.github.com/repos/open-mpi/ompi/issues/2944","number":2944,"state":"open","locked":false,"title":"ompi: pml ucx: add support for the buffered send","user":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"body":"@yosefe please take a look","created_at":"2017-02-09T15:23:47Z","updated_at":"2017-02-15T17:21:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ed10c05c30408ac08111847b3ff116948f40272c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/open-mpi/ompi/pulls/2944/commits","review_comments_url":"https://api.github.com/repos/open-mpi/ompi/pulls/2944/comments","review_comment_url":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/open-mpi/ompi/issues/2944/comments","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/c658525f49682a7446c523e8dd4e856eada7e027","head":{"label":"alex-mikheev:topic/pml_ucx_bsend","ref":"topic/pml_ucx_bsend","sha":"c658525f49682a7446c523e8dd4e856eada7e027","user":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"repo":{"id":31536469,"name":"ompi","full_name":"alex-mikheev/ompi","owner":{"login":"alex-mikheev","id":8735389,"avatar_url":"https://avatars.githubusercontent.com/u/8735389?v=3","gravatar_id":"","url":"https://api.github.com/users/alex-mikheev","html_url":"https://github.com/alex-mikheev","followers_url":"https://api.github.com/users/alex-mikheev/followers","following_url":"https://api.github.com/users/alex-mikheev/following{/other_user}","gists_url":"https://api.github.com/users/alex-mikheev/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mikheev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mikheev/subscriptions","organizations_url":"https://api.github.com/users/alex-mikheev/orgs","repos_url":"https://api.github.com/users/alex-mikheev/repos","events_url":"https://api.github.com/users/alex-mikheev/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mikheev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alex-mikheev/ompi","description":"Open MPI main development repository","fork":true,"url":"https://api.github.com/repos/alex-mikheev/ompi","forks_url":"https://api.github.com/repos/alex-mikheev/ompi/forks","keys_url":"https://api.github.com/repos/alex-mikheev/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alex-mikheev/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alex-mikheev/ompi/teams","hooks_url":"https://api.github.com/repos/alex-mikheev/ompi/hooks","issue_events_url":"https://api.github.com/repos/alex-mikheev/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/alex-mikheev/ompi/events","assignees_url":"https://api.github.com/repos/alex-mikheev/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/alex-mikheev/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/alex-mikheev/ompi/tags","blobs_url":"https://api.github.com/repos/alex-mikheev/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alex-mikheev/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alex-mikheev/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/alex-mikheev/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alex-mikheev/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/alex-mikheev/ompi/languages","stargazers_url":"https://api.github.com/repos/alex-mikheev/ompi/stargazers","contributors_url":"https://api.github.com/repos/alex-mikheev/ompi/contributors","subscribers_url":"https://api.github.com/repos/alex-mikheev/ompi/subscribers","subscription_url":"https://api.github.com/repos/alex-mikheev/ompi/subscription","commits_url":"https://api.github.com/repos/alex-mikheev/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/alex-mikheev/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/alex-mikheev/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/alex-mikheev/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/alex-mikheev/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/alex-mikheev/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alex-mikheev/ompi/merges","archive_url":"https://api.github.com/repos/alex-mikheev/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alex-mikheev/ompi/downloads","issues_url":"https://api.github.com/repos/alex-mikheev/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/alex-mikheev/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/alex-mikheev/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/alex-mikheev/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alex-mikheev/ompi/labels{/name}","releases_url":"https://api.github.com/repos/alex-mikheev/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/alex-mikheev/ompi/deployments","created_at":"2015-03-02T11:04:56Z","updated_at":"2015-03-02T11:05:19Z","pushed_at":"2017-02-13T17:00:37Z","git_url":"git://github.com/alex-mikheev/ompi.git","ssh_url":"git@github.com:alex-mikheev/ompi.git","clone_url":"https://github.com/alex-mikheev/ompi.git","svn_url":"https://github.com/alex-mikheev/ompi","homepage":null,"size":101375,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"open-mpi:master","ref":"master","sha":"cad4c03e5cc6acd89c2782251415b8145252dd05","user":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"repo":{"id":24107001,"name":"ompi","full_name":"open-mpi/ompi","owner":{"login":"open-mpi","id":2165682,"avatar_url":"https://avatars.githubusercontent.com/u/2165682?v=3","gravatar_id":"","url":"https://api.github.com/users/open-mpi","html_url":"https://github.com/open-mpi","followers_url":"https://api.github.com/users/open-mpi/followers","following_url":"https://api.github.com/users/open-mpi/following{/other_user}","gists_url":"https://api.github.com/users/open-mpi/gists{/gist_id}","starred_url":"https://api.github.com/users/open-mpi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/open-mpi/subscriptions","organizations_url":"https://api.github.com/users/open-mpi/orgs","repos_url":"https://api.github.com/users/open-mpi/repos","events_url":"https://api.github.com/users/open-mpi/events{/privacy}","received_events_url":"https://api.github.com/users/open-mpi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/open-mpi/ompi","description":"Open MPI main development repository","fork":false,"url":"https://api.github.com/repos/open-mpi/ompi","forks_url":"https://api.github.com/repos/open-mpi/ompi/forks","keys_url":"https://api.github.com/repos/open-mpi/ompi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/open-mpi/ompi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/open-mpi/ompi/teams","hooks_url":"https://api.github.com/repos/open-mpi/ompi/hooks","issue_events_url":"https://api.github.com/repos/open-mpi/ompi/issues/events{/number}","events_url":"https://api.github.com/repos/open-mpi/ompi/events","assignees_url":"https://api.github.com/repos/open-mpi/ompi/assignees{/user}","branches_url":"https://api.github.com/repos/open-mpi/ompi/branches{/branch}","tags_url":"https://api.github.com/repos/open-mpi/ompi/tags","blobs_url":"https://api.github.com/repos/open-mpi/ompi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/open-mpi/ompi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/open-mpi/ompi/git/refs{/sha}","trees_url":"https://api.github.com/repos/open-mpi/ompi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/open-mpi/ompi/statuses/{sha}","languages_url":"https://api.github.com/repos/open-mpi/ompi/languages","stargazers_url":"https://api.github.com/repos/open-mpi/ompi/stargazers","contributors_url":"https://api.github.com/repos/open-mpi/ompi/contributors","subscribers_url":"https://api.github.com/repos/open-mpi/ompi/subscribers","subscription_url":"https://api.github.com/repos/open-mpi/ompi/subscription","commits_url":"https://api.github.com/repos/open-mpi/ompi/commits{/sha}","git_commits_url":"https://api.github.com/repos/open-mpi/ompi/git/commits{/sha}","comments_url":"https://api.github.com/repos/open-mpi/ompi/comments{/number}","issue_comment_url":"https://api.github.com/repos/open-mpi/ompi/issues/comments{/number}","contents_url":"https://api.github.com/repos/open-mpi/ompi/contents/{+path}","compare_url":"https://api.github.com/repos/open-mpi/ompi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/open-mpi/ompi/merges","archive_url":"https://api.github.com/repos/open-mpi/ompi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/open-mpi/ompi/downloads","issues_url":"https://api.github.com/repos/open-mpi/ompi/issues{/number}","pulls_url":"https://api.github.com/repos/open-mpi/ompi/pulls{/number}","milestones_url":"https://api.github.com/repos/open-mpi/ompi/milestones{/number}","notifications_url":"https://api.github.com/repos/open-mpi/ompi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/open-mpi/ompi/labels{/name}","releases_url":"https://api.github.com/repos/open-mpi/ompi/releases{/id}","deployments_url":"https://api.github.com/repos/open-mpi/ompi/deployments","created_at":"2014-09-16T16:08:30Z","updated_at":"2017-02-09T12:47:38Z","pushed_at":"2017-02-15T14:31:29Z","git_url":"git://github.com/open-mpi/ompi.git","ssh_url":"git@github.com:open-mpi/ompi.git","clone_url":"https://github.com/open-mpi/ompi.git","svn_url":"https://github.com/open-mpi/ompi","homepage":null,"size":105955,"stargazers_count":266,"watchers_count":266,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"open_issues_count":370,"forks":187,"open_issues":370,"watchers":266,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/2944"},"html":{"href":"https://github.com/open-mpi/ompi/pull/2944"},"issue":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/2944"},"comments":{"href":"https://api.github.com/repos/open-mpi/ompi/issues/2944/comments"},"review_comments":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/2944/comments"},"review_comment":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/open-mpi/ompi/pulls/2944/commits"},"statuses":{"href":"https://api.github.com/repos/open-mpi/ompi/statuses/c658525f49682a7446c523e8dd4e856eada7e027"}}}}
{"actor":{"display_login":"yosefe"}}