{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/comments/121056646","pull_request_review_id":43075898,"id":121056646,"diff_hunk":"@@ -131,6 +137,40 @@ union ble_store_value {\n     struct ble_store_value_cccd cccd;\n };\n \n+struct ble_store_status_event {\n+    /**\n+     * The type of object that failed to persist; one of the\n+     * BLE_STORE_OBJ_TYPE_[...] codes.\n+     */\n+    int obj_type;\n+\n+    /**\n+     * The type of event being reported; one of the BLE_STORE_EVENT_TYPE_[...]\n+     * codes.\n+     */\n+    int event_code;\n+\n+    /**\n+     * Additional data related to the event; the valid field is inferred from\n+     * the obj_type,event_code pair.\n+     */\n+    union {\n+        /**\n+         * The record that failed to be written.  Valid for the following event\n+         * types:\n+         *     o BLE_STORE_EVENT_OVERFLOW","path":"net/nimble/host/include/host/ble_store.h","position":38,"original_position":38,"commit_id":"c328875ade1dcd2b1a70aec22cf944b6af560196","original_commit_id":"04156c8d7c3c9e104b934b86e4aaae75439dedc1","user":{"login":"rymanluk","id":2675599,"avatar_url":"https://avatars1.githubusercontent.com/u/2675599?v=3","gravatar_id":"","url":"https://api.github.com/users/rymanluk","html_url":"https://github.com/rymanluk","followers_url":"https://api.github.com/users/rymanluk/followers","following_url":"https://api.github.com/users/rymanluk/following{/other_user}","gists_url":"https://api.github.com/users/rymanluk/gists{/gist_id}","starred_url":"https://api.github.com/users/rymanluk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rymanluk/subscriptions","organizations_url":"https://api.github.com/users/rymanluk/orgs","repos_url":"https://api.github.com/users/rymanluk/repos","events_url":"https://api.github.com/users/rymanluk/events{/privacy}","received_events_url":"https://api.github.com/users/rymanluk/received_events","type":"User","site_admin":false},"body":"Since a key for union data is pair (obj_type, event_code pair) could we extend comment here and say that value is valid for event type \"BLE_STORE_EVENT_OVERFLOW\" and all possible obj_type.\r\n\r\nSimilar we could do for description to conn_handle, but int this case we have only couple of obj_types valid.\r\n\r\n","created_at":"2017-06-09T06:28:17Z","updated_at":"2017-06-09T06:45:42Z","html_url":"https://github.com/apache/incubator-mynewt-core/pull/279#discussion_r121056646","pull_request_url":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/279","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/comments/121056646"},"html":{"href":"https://github.com/apache/incubator-mynewt-core/pull/279#discussion_r121056646"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/279"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/279","id":120423902,"html_url":"https://github.com/apache/incubator-mynewt-core/pull/279","diff_url":"https://github.com/apache/incubator-mynewt-core/pull/279.diff","patch_url":"https://github.com/apache/incubator-mynewt-core/pull/279.patch","issue_url":"https://api.github.com/repos/apache/incubator-mynewt-core/issues/279","number":279,"state":"open","locked":false,"title":"BLE Host - Policy for SM key overflow","user":{"login":"ccollins476ad","id":13006531,"avatar_url":"https://avatars3.githubusercontent.com/u/13006531?v=3","gravatar_id":"","url":"https://api.github.com/users/ccollins476ad","html_url":"https://github.com/ccollins476ad","followers_url":"https://api.github.com/users/ccollins476ad/followers","following_url":"https://api.github.com/users/ccollins476ad/following{/other_user}","gists_url":"https://api.github.com/users/ccollins476ad/gists{/gist_id}","starred_url":"https://api.github.com/users/ccollins476ad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccollins476ad/subscriptions","organizations_url":"https://api.github.com/users/ccollins476ad/orgs","repos_url":"https://api.github.com/users/ccollins476ad/repos","events_url":"https://api.github.com/users/ccollins476ad/events{/privacy}","received_events_url":"https://api.github.com/users/ccollins476ad/received_events","type":"User","site_admin":false},"body":"This pull request addresses the issue identified in MYNEWT-751 (https://issues.apache.org/jira/browse/MYNEWT-751).\r\n\r\nThis PR incorporates changes from another PR: 277 (https://github.com/apache/incubator-mynewt-core/pull/277).  Therefore, this PR should only be merged after 277.\r\n\r\n","created_at":"2017-05-12T23:37:12Z","updated_at":"2017-06-09T06:45:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a61109ca470d07aa4adef2f8af7886a3f7002bfb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/279/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/279/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-mynewt-core/issues/279/comments","statuses_url":"https://api.github.com/repos/apache/incubator-mynewt-core/statuses/c328875ade1dcd2b1a70aec22cf944b6af560196","head":{"label":"ccollins476ad:key-wont-fit","ref":"key-wont-fit","sha":"c328875ade1dcd2b1a70aec22cf944b6af560196","user":{"login":"ccollins476ad","id":13006531,"avatar_url":"https://avatars3.githubusercontent.com/u/13006531?v=3","gravatar_id":"","url":"https://api.github.com/users/ccollins476ad","html_url":"https://github.com/ccollins476ad","followers_url":"https://api.github.com/users/ccollins476ad/followers","following_url":"https://api.github.com/users/ccollins476ad/following{/other_user}","gists_url":"https://api.github.com/users/ccollins476ad/gists{/gist_id}","starred_url":"https://api.github.com/users/ccollins476ad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccollins476ad/subscriptions","organizations_url":"https://api.github.com/users/ccollins476ad/orgs","repos_url":"https://api.github.com/users/ccollins476ad/repos","events_url":"https://api.github.com/users/ccollins476ad/events{/privacy}","received_events_url":"https://api.github.com/users/ccollins476ad/received_events","type":"User","site_admin":false},"repo":{"id":54583308,"name":"incubator-mynewt-core","full_name":"ccollins476ad/incubator-mynewt-core","owner":{"login":"ccollins476ad","id":13006531,"avatar_url":"https://avatars3.githubusercontent.com/u/13006531?v=3","gravatar_id":"","url":"https://api.github.com/users/ccollins476ad","html_url":"https://github.com/ccollins476ad","followers_url":"https://api.github.com/users/ccollins476ad/followers","following_url":"https://api.github.com/users/ccollins476ad/following{/other_user}","gists_url":"https://api.github.com/users/ccollins476ad/gists{/gist_id}","starred_url":"https://api.github.com/users/ccollins476ad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccollins476ad/subscriptions","organizations_url":"https://api.github.com/users/ccollins476ad/orgs","repos_url":"https://api.github.com/users/ccollins476ad/repos","events_url":"https://api.github.com/users/ccollins476ad/events{/privacy}","received_events_url":"https://api.github.com/users/ccollins476ad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ccollins476ad/incubator-mynewt-core","description":"Mirror of Apache MyNewt Core (Incubating)","fork":true,"url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core","forks_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/forks","keys_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/teams","hooks_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/hooks","issue_events_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/issues/events{/number}","events_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/events","assignees_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/assignees{/user}","branches_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/branches{/branch}","tags_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/tags","blobs_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/statuses/{sha}","languages_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/languages","stargazers_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/stargazers","contributors_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/contributors","subscribers_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/subscribers","subscription_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/subscription","commits_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/contents/{+path}","compare_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/merges","archive_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/downloads","issues_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/issues{/number}","pulls_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/pulls{/number}","milestones_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/milestones{/number}","notifications_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/labels{/name}","releases_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/releases{/id}","deployments_url":"https://api.github.com/repos/ccollins476ad/incubator-mynewt-core/deployments","created_at":"2016-03-23T18:22:29Z","updated_at":"2016-03-23T18:22:37Z","pushed_at":"2017-06-08T22:10:45Z","git_url":"git://github.com/ccollins476ad/incubator-mynewt-core.git","ssh_url":"git@github.com:ccollins476ad/incubator-mynewt-core.git","clone_url":"https://github.com/ccollins476ad/incubator-mynewt-core.git","svn_url":"https://github.com/ccollins476ad/incubator-mynewt-core","homepage":"","size":80632,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"16323b514bc7dd45db9db163e24f477b3c2082ae","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45165993,"name":"incubator-mynewt-core","full_name":"apache/incubator-mynewt-core","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-mynewt-core","description":null,"fork":false,"url":"https://api.github.com/repos/apache/incubator-mynewt-core","forks_url":"https://api.github.com/repos/apache/incubator-mynewt-core/forks","keys_url":"https://api.github.com/repos/apache/incubator-mynewt-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-mynewt-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-mynewt-core/teams","hooks_url":"https://api.github.com/repos/apache/incubator-mynewt-core/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-mynewt-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-mynewt-core/events","assignees_url":"https://api.github.com/repos/apache/incubator-mynewt-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-mynewt-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-mynewt-core/tags","blobs_url":"https://api.github.com/repos/apache/incubator-mynewt-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-mynewt-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-mynewt-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-mynewt-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-mynewt-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-mynewt-core/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-mynewt-core/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-mynewt-core/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-mynewt-core/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-mynewt-core/subscription","commits_url":"https://api.github.com/repos/apache/incubator-mynewt-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-mynewt-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-mynewt-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-mynewt-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-mynewt-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-mynewt-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-mynewt-core/merges","archive_url":"https://api.github.com/repos/apache/incubator-mynewt-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-mynewt-core/downloads","issues_url":"https://api.github.com/repos/apache/incubator-mynewt-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-mynewt-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-mynewt-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-mynewt-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-mynewt-core/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-mynewt-core/deployments","created_at":"2015-10-29T07:00:07Z","updated_at":"2017-06-08T05:24:11Z","pushed_at":"2017-06-08T22:01:06Z","git_url":"git://github.com/apache/incubator-mynewt-core.git","ssh_url":"git@github.com:apache/incubator-mynewt-core.git","clone_url":"https://github.com/apache/incubator-mynewt-core.git","svn_url":"https://github.com/apache/incubator-mynewt-core","homepage":"","size":80398,"stargazers_count":205,"watchers_count":205,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":7,"forks":99,"open_issues":7,"watchers":205,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/279"},"html":{"href":"https://github.com/apache/incubator-mynewt-core/pull/279"},"issue":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/issues/279"},"comments":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/issues/279/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/279/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/pulls/279/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-mynewt-core/statuses/c328875ade1dcd2b1a70aec22cf944b6af560196"}}}}
{"actor":{"display_login":"rymanluk"}}