{"action":"created","issue":{"url":"https://api.github.com/repos/qgis/QGIS/issues/4313","repository_url":"https://api.github.com/repos/qgis/QGIS","labels_url":"https://api.github.com/repos/qgis/QGIS/issues/4313/labels{/name}","comments_url":"https://api.github.com/repos/qgis/QGIS/issues/4313/comments","events_url":"https://api.github.com/repos/qgis/QGIS/issues/4313/events","html_url":"https://github.com/qgis/QGIS/pull/4313","id":217853640,"number":4313,"title":"[Server] WMS getmap refactoring","user":{"login":"pblottiere","id":9266424,"avatar_url":"https://avatars1.githubusercontent.com/u/9266424?v=3","gravatar_id":"","url":"https://api.github.com/users/pblottiere","html_url":"https://github.com/pblottiere","followers_url":"https://api.github.com/users/pblottiere/followers","following_url":"https://api.github.com/users/pblottiere/following{/other_user}","gists_url":"https://api.github.com/users/pblottiere/gists{/gist_id}","starred_url":"https://api.github.com/users/pblottiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pblottiere/subscriptions","organizations_url":"https://api.github.com/users/pblottiere/orgs","repos_url":"https://api.github.com/users/pblottiere/repos","events_url":"https://api.github.com/users/pblottiere/events{/privacy}","received_events_url":"https://api.github.com/users/pblottiere/received_events","type":"User","site_admin":false},"labels":[{"id":405607789,"url":"https://api.github.com/repos/qgis/QGIS/labels/API%20break","name":"API break","color":"fbca04","default":false},{"id":513911293,"url":"https://api.github.com/repos/qgis/QGIS/labels/Server","name":"Server","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/qgis/QGIS/milestones/9","html_url":"https://github.com/qgis/QGIS/milestone/9","labels_url":"https://api.github.com/repos/qgis/QGIS/milestones/9/labels","id":1468273,"number":9,"title":"QGIS 3","description":"Code which requires an API change or contains other modifications which is not acceptable without a major version number change.","creator":{"login":"m-kuhn","id":588407,"avatar_url":"https://avatars2.githubusercontent.com/u/588407?v=3","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":56,"state":"open","created_at":"2015-12-20T10:10:21Z","updated_at":"2017-06-01T15:57:12Z","due_on":null,"closed_at":null},"comments":49,"created_at":"2017-03-29T12:04:14Z","updated_at":"2017-06-02T06:30:45Z","closed_at":"2017-06-01T15:57:11Z","pull_request":{"url":"https://api.github.com/repos/qgis/QGIS/pulls/4313","html_url":"https://github.com/qgis/QGIS/pull/4313","diff_url":"https://github.com/qgis/QGIS/pull/4313.diff","patch_url":"https://github.com/qgis/QGIS/pull/4313.patch"},"body":"## Description\r\n\r\nThe aim of this PR is to propose a cleaner version of the WMS `getmap` function defined in the server:\r\n- QgsProject singleton is not used anymore\r\n- XML parsers are not used either\r\n- WMS parameters are centralised in a new class `QgsWmsParameters`\r\n- clones methods for raster and vector layers are implemented. Thus, `getmap` is working on clones only, so it's completely stateless and there's no need for restorers (like `QgsOWSServerFilterRestorer`)\r\n\r\nObviously the final aim is to completely remove XML parsers  (`QgsWmsConfigParser`, `QgsWmsProjectParser`, `QgsSLDConfigParser`, ...), restorers, ... but the same kind of work has to be done on `getprint` and `getlegendgraphic` requests. So a `getMapOld` function is still there to keep the `getlegendgraphic` function running. Moreover, the new class `QgsWmsParameters` should be used in these functions too.\r\n\r\nSome new units tests have been added for SLD, hilight layers, rasters, ...\r\n\r\n## Checklist\r\n\r\n- [x] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Commits which fix bugs include `fixes #11111` in the commit message next to the description\r\n- [ ] Commits which add new features are tagged with `[FEATURE]` in the commit message\r\n- [ ] Commits which change the UI or existing user workflows are tagged with `[needs-docs]` in the commit message and containt sufficient information in the commit message to be documented\r\n- [x] I have read the [QGIS Coding Standards](https://docs.qgis.org/testing/en/docs/developers_guide/codingstandards.html) and this PR complies with them\r\n- [x] This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)\r\n- [x] New unit tests have been added for core changes\r\n- [x] I have run [the `scripts/prepare-commit.sh` script](https://github.com/qgis/QGIS/blob/master/.github/CONTRIBUTE.md#contributing-to-qgis) before each commit\r\n"},"comment":{"url":"https://api.github.com/repos/qgis/QGIS/issues/comments/305701703","html_url":"https://github.com/qgis/QGIS/pull/4313#issuecomment-305701703","issue_url":"https://api.github.com/repos/qgis/QGIS/issues/4313","id":305701703,"user":{"login":"m-kuhn","id":588407,"avatar_url":"https://avatars2.githubusercontent.com/u/588407?v=3","gravatar_id":"","url":"https://api.github.com/users/m-kuhn","html_url":"https://github.com/m-kuhn","followers_url":"https://api.github.com/users/m-kuhn/followers","following_url":"https://api.github.com/users/m-kuhn/following{/other_user}","gists_url":"https://api.github.com/users/m-kuhn/gists{/gist_id}","starred_url":"https://api.github.com/users/m-kuhn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-kuhn/subscriptions","organizations_url":"https://api.github.com/users/m-kuhn/orgs","repos_url":"https://api.github.com/users/m-kuhn/repos","events_url":"https://api.github.com/users/m-kuhn/events{/privacy}","received_events_url":"https://api.github.com/users/m-kuhn/received_events","type":"User","site_admin":false},"created_at":"2017-06-02T06:30:45Z","updated_at":"2017-06-02T06:30:45Z","body":"Awesome.\r\nGreat work, @pblottiere "}}
{"actor":{"display_login":"m-kuhn"}}