{"action":"created","comment":{"url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/comments/130255590","pull_request_review_id":53108763,"id":130255590,"diff_hunk":"@@ -14,6 +14,7 @@ export class ExecutionMetrics {\n     public skippedSpecs = 0;\n     public totalSpecsDefined = 0;\n     public executedSpecs = 0;\n+    public errors: CustomReporterResult[] = [];","path":"src/execution-metrics.ts","position":4,"original_position":4,"commit_id":"ddfd7285d32d567d099668bbf2d4c6dddf10e62f","original_commit_id":"ddfd7285d32d567d099668bbf2d4c6dddf10e62f","user":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars1.githubusercontent.com/u/205570?v=4","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"body":"I was planning to cheat and use the same mechanism in karma-jasmine, for global errors.\r\n\r\nIn karma-jasmine, global errors have to be passed from the browser back to the server, then reported via the karma-reporter. Our reporter translates karma API into jasmine calls then into jasmine-spec-reporter.  The `jasmineDone()` api provides a path to report global errors.\r\n\r\nThat case need not concern you, so my only other question is whether there could be other errors in future? The `jasmineDone()`/`suiteDone()` reporting path is not specific to `afterAll()`, but then again I don't know of any other possible errors.\r\n\r\nNot a big deal, so decide and I will follow up.","created_at":"2017-07-30T23:15:12Z","updated_at":"2017-07-30T23:15:12Z","html_url":"https://github.com/bcaudan/jasmine-spec-reporter/pull/214#discussion_r130255590","pull_request_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/214","_links":{"self":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/comments/130255590"},"html":{"href":"https://github.com/bcaudan/jasmine-spec-reporter/pull/214#discussion_r130255590"},"pull_request":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/214"}}},"pull_request":{"url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/214","id":133099061,"html_url":"https://github.com/bcaudan/jasmine-spec-reporter/pull/214","diff_url":"https://github.com/bcaudan/jasmine-spec-reporter/pull/214.diff","patch_url":"https://github.com/bcaudan/jasmine-spec-reporter/pull/214.patch","issue_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/issues/214","number":214,"state":"open","locked":false,"title":"Support reporting errors in afterAll.","user":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars1.githubusercontent.com/u/205570?v=4","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"body":"Starting in jasmine 2.5, errors in afterAll are reported to jasmineDone or suiteDone.\r\nAdd ExecutionMetrics.errors to store these errors; report them.\r\n\r\nFixes #210\r\n","created_at":"2017-07-29T16:59:40Z","updated_at":"2017-07-30T23:15:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8ead4bdf62a1ef3c736880fded489466ccf23ade","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/214/commits","review_comments_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/214/comments","review_comment_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/issues/214/comments","statuses_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/statuses/ddfd7285d32d567d099668bbf2d4c6dddf10e62f","head":{"label":"johnjbarton:after-all","ref":"after-all","sha":"ddfd7285d32d567d099668bbf2d4c6dddf10e62f","user":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars1.githubusercontent.com/u/205570?v=4","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"repo":{"id":87364696,"name":"jasmine-spec-reporter","full_name":"johnjbarton/jasmine-spec-reporter","owner":{"login":"johnjbarton","id":205570,"avatar_url":"https://avatars1.githubusercontent.com/u/205570?v=4","gravatar_id":"","url":"https://api.github.com/users/johnjbarton","html_url":"https://github.com/johnjbarton","followers_url":"https://api.github.com/users/johnjbarton/followers","following_url":"https://api.github.com/users/johnjbarton/following{/other_user}","gists_url":"https://api.github.com/users/johnjbarton/gists{/gist_id}","starred_url":"https://api.github.com/users/johnjbarton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnjbarton/subscriptions","organizations_url":"https://api.github.com/users/johnjbarton/orgs","repos_url":"https://api.github.com/users/johnjbarton/repos","events_url":"https://api.github.com/users/johnjbarton/events{/privacy}","received_events_url":"https://api.github.com/users/johnjbarton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/johnjbarton/jasmine-spec-reporter","description":"Console spec reporter for jasmine behavior-driven development testing framework","fork":true,"url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter","forks_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/forks","keys_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/teams","hooks_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/hooks","issue_events_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/issues/events{/number}","events_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/events","assignees_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/assignees{/user}","branches_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/branches{/branch}","tags_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/tags","blobs_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/statuses/{sha}","languages_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/languages","stargazers_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/stargazers","contributors_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/contributors","subscribers_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/subscribers","subscription_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/subscription","commits_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/contents/{+path}","compare_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/merges","archive_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/downloads","issues_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/issues{/number}","pulls_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/pulls{/number}","milestones_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/milestones{/number}","notifications_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/labels{/name}","releases_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/releases{/id}","deployments_url":"https://api.github.com/repos/johnjbarton/jasmine-spec-reporter/deployments","created_at":"2017-04-05T23:12:33Z","updated_at":"2017-04-05T23:12:34Z","pushed_at":"2017-07-29T17:13:56Z","git_url":"git://github.com/johnjbarton/jasmine-spec-reporter.git","ssh_url":"git@github.com:johnjbarton/jasmine-spec-reporter.git","clone_url":"https://github.com/johnjbarton/jasmine-spec-reporter.git","svn_url":"https://github.com/johnjbarton/jasmine-spec-reporter","homepage":"https://github.com/bcaudan/jasmine-spec-reporter","size":772,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bcaudan:master","ref":"master","sha":"4a5506eabf5ea731e3f05088a8c2fcfe038bed79","user":{"login":"bcaudan","id":1331991,"avatar_url":"https://avatars0.githubusercontent.com/u/1331991?v=4","gravatar_id":"","url":"https://api.github.com/users/bcaudan","html_url":"https://github.com/bcaudan","followers_url":"https://api.github.com/users/bcaudan/followers","following_url":"https://api.github.com/users/bcaudan/following{/other_user}","gists_url":"https://api.github.com/users/bcaudan/gists{/gist_id}","starred_url":"https://api.github.com/users/bcaudan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcaudan/subscriptions","organizations_url":"https://api.github.com/users/bcaudan/orgs","repos_url":"https://api.github.com/users/bcaudan/repos","events_url":"https://api.github.com/users/bcaudan/events{/privacy}","received_events_url":"https://api.github.com/users/bcaudan/received_events","type":"User","site_admin":false},"repo":{"id":18489022,"name":"jasmine-spec-reporter","full_name":"bcaudan/jasmine-spec-reporter","owner":{"login":"bcaudan","id":1331991,"avatar_url":"https://avatars0.githubusercontent.com/u/1331991?v=4","gravatar_id":"","url":"https://api.github.com/users/bcaudan","html_url":"https://github.com/bcaudan","followers_url":"https://api.github.com/users/bcaudan/followers","following_url":"https://api.github.com/users/bcaudan/following{/other_user}","gists_url":"https://api.github.com/users/bcaudan/gists{/gist_id}","starred_url":"https://api.github.com/users/bcaudan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcaudan/subscriptions","organizations_url":"https://api.github.com/users/bcaudan/orgs","repos_url":"https://api.github.com/users/bcaudan/repos","events_url":"https://api.github.com/users/bcaudan/events{/privacy}","received_events_url":"https://api.github.com/users/bcaudan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcaudan/jasmine-spec-reporter","description":"Real time console spec reporter for jasmine testing framework","fork":false,"url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter","forks_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/forks","keys_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/teams","hooks_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/hooks","issue_events_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/issues/events{/number}","events_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/events","assignees_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/assignees{/user}","branches_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/branches{/branch}","tags_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/tags","blobs_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/statuses/{sha}","languages_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/languages","stargazers_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/stargazers","contributors_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/contributors","subscribers_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/subscribers","subscription_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/subscription","commits_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/contents/{+path}","compare_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/merges","archive_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/downloads","issues_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/issues{/number}","pulls_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls{/number}","milestones_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/milestones{/number}","notifications_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/labels{/name}","releases_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/releases{/id}","deployments_url":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/deployments","created_at":"2014-04-06T12:23:22Z","updated_at":"2017-07-23T09:06:20Z","pushed_at":"2017-07-30T10:43:58Z","git_url":"git://github.com/bcaudan/jasmine-spec-reporter.git","ssh_url":"git@github.com:bcaudan/jasmine-spec-reporter.git","clone_url":"https://github.com/bcaudan/jasmine-spec-reporter.git","svn_url":"https://github.com/bcaudan/jasmine-spec-reporter","homepage":"https://github.com/bcaudan/jasmine-spec-reporter","size":787,"stargazers_count":166,"watchers_count":166,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"open_issues_count":5,"forks":40,"open_issues":5,"watchers":166,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/214"},"html":{"href":"https://github.com/bcaudan/jasmine-spec-reporter/pull/214"},"issue":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/issues/214"},"comments":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/issues/214/comments"},"review_comments":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/214/comments"},"review_comment":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/pulls/214/commits"},"statuses":{"href":"https://api.github.com/repos/bcaudan/jasmine-spec-reporter/statuses/ddfd7285d32d567d099668bbf2d4c6dddf10e62f"}}}}
{"actor":{"display_login":"johnjbarton"}}