{"action":"closed","number":1385,"pull_request":{"url":"https://api.github.com/repos/uclibs/scholar_uc/pulls/1385","id":119955945,"html_url":"https://github.com/uclibs/scholar_uc/pull/1385","diff_url":"https://github.com/uclibs/scholar_uc/pull/1385.diff","patch_url":"https://github.com/uclibs/scholar_uc/pull/1385.patch","issue_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/1385","number":1385,"state":"closed","locked":false,"title":"fix college and department value autofill on work create/edit/batch edit","user":{"login":"lawhorkl","id":12615997,"avatar_url":"https://avatars2.githubusercontent.com/u/12615997?v=3","gravatar_id":"","url":"https://api.github.com/users/lawhorkl","html_url":"https://github.com/lawhorkl","followers_url":"https://api.github.com/users/lawhorkl/followers","following_url":"https://api.github.com/users/lawhorkl/following{/other_user}","gists_url":"https://api.github.com/users/lawhorkl/gists{/gist_id}","starred_url":"https://api.github.com/users/lawhorkl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lawhorkl/subscriptions","organizations_url":"https://api.github.com/users/lawhorkl/orgs","repos_url":"https://api.github.com/users/lawhorkl/repos","events_url":"https://api.github.com/users/lawhorkl/events{/privacy}","received_events_url":"https://api.github.com/users/lawhorkl/received_events","type":"User","site_admin":false},"body":"Fixes #1378 \r\n\r\nPresent short summary (50 characters or less)\r\n\r\nPrevious iteration used incorrect conditional check. This gives the helper/view the proper conditional checks to function.\r\n\r\nChanges proposed in this pull request:\r\n* Pull out `value` logic from view into helper methods `old_or_new_college` and `old_or_new_department`, rather than keeping it in view.\r\n* Change conditional statement to check for an empty string coming from form builder object rather than the object being `nil`.\r\n\r\n","created_at":"2017-05-10T19:05:21Z","updated_at":"2017-05-12T15:31:23Z","closed_at":"2017-05-12T15:31:23Z","merged_at":"2017-05-12T15:31:23Z","merge_commit_sha":"cb6fb25534d06f30c6f41e4cfda0ded25860209b","assignee":{"login":"jamesvanmil","id":2651187,"avatar_url":"https://avatars2.githubusercontent.com/u/2651187?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesvanmil","html_url":"https://github.com/jamesvanmil","followers_url":"https://api.github.com/users/jamesvanmil/followers","following_url":"https://api.github.com/users/jamesvanmil/following{/other_user}","gists_url":"https://api.github.com/users/jamesvanmil/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesvanmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesvanmil/subscriptions","organizations_url":"https://api.github.com/users/jamesvanmil/orgs","repos_url":"https://api.github.com/users/jamesvanmil/repos","events_url":"https://api.github.com/users/jamesvanmil/events{/privacy}","received_events_url":"https://api.github.com/users/jamesvanmil/received_events","type":"User","site_admin":false},"assignees":[{"login":"jamesvanmil","id":2651187,"avatar_url":"https://avatars2.githubusercontent.com/u/2651187?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesvanmil","html_url":"https://github.com/jamesvanmil","followers_url":"https://api.github.com/users/jamesvanmil/followers","following_url":"https://api.github.com/users/jamesvanmil/following{/other_user}","gists_url":"https://api.github.com/users/jamesvanmil/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesvanmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesvanmil/subscriptions","organizations_url":"https://api.github.com/users/jamesvanmil/orgs","repos_url":"https://api.github.com/users/jamesvanmil/repos","events_url":"https://api.github.com/users/jamesvanmil/events{/privacy}","received_events_url":"https://api.github.com/users/jamesvanmil/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/uclibs/scholar_uc/pulls/1385/commits","review_comments_url":"https://api.github.com/repos/uclibs/scholar_uc/pulls/1385/comments","review_comment_url":"https://api.github.com/repos/uclibs/scholar_uc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/1385/comments","statuses_url":"https://api.github.com/repos/uclibs/scholar_uc/statuses/dcf87e6549f31cbd9678658c0eb845f2956bf7a1","head":{"label":"uclibs:bug/#1378-fix-c-and-d-autofill","ref":"bug/#1378-fix-c-and-d-autofill","sha":"dcf87e6549f31cbd9678658c0eb845f2956bf7a1","user":{"login":"uclibs","id":6144529,"avatar_url":"https://avatars2.githubusercontent.com/u/6144529?v=3","gravatar_id":"","url":"https://api.github.com/users/uclibs","html_url":"https://github.com/uclibs","followers_url":"https://api.github.com/users/uclibs/followers","following_url":"https://api.github.com/users/uclibs/following{/other_user}","gists_url":"https://api.github.com/users/uclibs/gists{/gist_id}","starred_url":"https://api.github.com/users/uclibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclibs/subscriptions","organizations_url":"https://api.github.com/users/uclibs/orgs","repos_url":"https://api.github.com/users/uclibs/repos","events_url":"https://api.github.com/users/uclibs/events{/privacy}","received_events_url":"https://api.github.com/users/uclibs/received_events","type":"Organization","site_admin":false},"repo":{"id":15346914,"name":"scholar_uc","full_name":"uclibs/scholar_uc","owner":{"login":"uclibs","id":6144529,"avatar_url":"https://avatars2.githubusercontent.com/u/6144529?v=3","gravatar_id":"","url":"https://api.github.com/users/uclibs","html_url":"https://github.com/uclibs","followers_url":"https://api.github.com/users/uclibs/followers","following_url":"https://api.github.com/users/uclibs/following{/other_user}","gists_url":"https://api.github.com/users/uclibs/gists{/gist_id}","starred_url":"https://api.github.com/users/uclibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclibs/subscriptions","organizations_url":"https://api.github.com/users/uclibs/orgs","repos_url":"https://api.github.com/users/uclibs/repos","events_url":"https://api.github.com/users/uclibs/events{/privacy}","received_events_url":"https://api.github.com/users/uclibs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uclibs/scholar_uc","description":"University of Cincinnati's self-submission institutional repository","fork":false,"url":"https://api.github.com/repos/uclibs/scholar_uc","forks_url":"https://api.github.com/repos/uclibs/scholar_uc/forks","keys_url":"https://api.github.com/repos/uclibs/scholar_uc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclibs/scholar_uc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclibs/scholar_uc/teams","hooks_url":"https://api.github.com/repos/uclibs/scholar_uc/hooks","issue_events_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/events{/number}","events_url":"https://api.github.com/repos/uclibs/scholar_uc/events","assignees_url":"https://api.github.com/repos/uclibs/scholar_uc/assignees{/user}","branches_url":"https://api.github.com/repos/uclibs/scholar_uc/branches{/branch}","tags_url":"https://api.github.com/repos/uclibs/scholar_uc/tags","blobs_url":"https://api.github.com/repos/uclibs/scholar_uc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclibs/scholar_uc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclibs/scholar_uc/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclibs/scholar_uc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclibs/scholar_uc/statuses/{sha}","languages_url":"https://api.github.com/repos/uclibs/scholar_uc/languages","stargazers_url":"https://api.github.com/repos/uclibs/scholar_uc/stargazers","contributors_url":"https://api.github.com/repos/uclibs/scholar_uc/contributors","subscribers_url":"https://api.github.com/repos/uclibs/scholar_uc/subscribers","subscription_url":"https://api.github.com/repos/uclibs/scholar_uc/subscription","commits_url":"https://api.github.com/repos/uclibs/scholar_uc/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclibs/scholar_uc/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclibs/scholar_uc/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/comments{/number}","contents_url":"https://api.github.com/repos/uclibs/scholar_uc/contents/{+path}","compare_url":"https://api.github.com/repos/uclibs/scholar_uc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclibs/scholar_uc/merges","archive_url":"https://api.github.com/repos/uclibs/scholar_uc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclibs/scholar_uc/downloads","issues_url":"https://api.github.com/repos/uclibs/scholar_uc/issues{/number}","pulls_url":"https://api.github.com/repos/uclibs/scholar_uc/pulls{/number}","milestones_url":"https://api.github.com/repos/uclibs/scholar_uc/milestones{/number}","notifications_url":"https://api.github.com/repos/uclibs/scholar_uc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclibs/scholar_uc/labels{/name}","releases_url":"https://api.github.com/repos/uclibs/scholar_uc/releases{/id}","deployments_url":"https://api.github.com/repos/uclibs/scholar_uc/deployments","created_at":"2013-12-20T19:53:26Z","updated_at":"2017-05-03T07:17:43Z","pushed_at":"2017-05-12T15:31:23Z","git_url":"git://github.com/uclibs/scholar_uc.git","ssh_url":"git@github.com:uclibs/scholar_uc.git","clone_url":"https://github.com/uclibs/scholar_uc.git","svn_url":"https://github.com/uclibs/scholar_uc","homepage":"https://scholar.uc.edu","size":16910,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":205,"forks":0,"open_issues":205,"watchers":4,"default_branch":"develop"}},"base":{"label":"uclibs:develop","ref":"develop","sha":"e2e73582adc87b51c367b505b4d71db5a8507c8c","user":{"login":"uclibs","id":6144529,"avatar_url":"https://avatars2.githubusercontent.com/u/6144529?v=3","gravatar_id":"","url":"https://api.github.com/users/uclibs","html_url":"https://github.com/uclibs","followers_url":"https://api.github.com/users/uclibs/followers","following_url":"https://api.github.com/users/uclibs/following{/other_user}","gists_url":"https://api.github.com/users/uclibs/gists{/gist_id}","starred_url":"https://api.github.com/users/uclibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclibs/subscriptions","organizations_url":"https://api.github.com/users/uclibs/orgs","repos_url":"https://api.github.com/users/uclibs/repos","events_url":"https://api.github.com/users/uclibs/events{/privacy}","received_events_url":"https://api.github.com/users/uclibs/received_events","type":"Organization","site_admin":false},"repo":{"id":15346914,"name":"scholar_uc","full_name":"uclibs/scholar_uc","owner":{"login":"uclibs","id":6144529,"avatar_url":"https://avatars2.githubusercontent.com/u/6144529?v=3","gravatar_id":"","url":"https://api.github.com/users/uclibs","html_url":"https://github.com/uclibs","followers_url":"https://api.github.com/users/uclibs/followers","following_url":"https://api.github.com/users/uclibs/following{/other_user}","gists_url":"https://api.github.com/users/uclibs/gists{/gist_id}","starred_url":"https://api.github.com/users/uclibs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uclibs/subscriptions","organizations_url":"https://api.github.com/users/uclibs/orgs","repos_url":"https://api.github.com/users/uclibs/repos","events_url":"https://api.github.com/users/uclibs/events{/privacy}","received_events_url":"https://api.github.com/users/uclibs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uclibs/scholar_uc","description":"University of Cincinnati's self-submission institutional repository","fork":false,"url":"https://api.github.com/repos/uclibs/scholar_uc","forks_url":"https://api.github.com/repos/uclibs/scholar_uc/forks","keys_url":"https://api.github.com/repos/uclibs/scholar_uc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uclibs/scholar_uc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uclibs/scholar_uc/teams","hooks_url":"https://api.github.com/repos/uclibs/scholar_uc/hooks","issue_events_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/events{/number}","events_url":"https://api.github.com/repos/uclibs/scholar_uc/events","assignees_url":"https://api.github.com/repos/uclibs/scholar_uc/assignees{/user}","branches_url":"https://api.github.com/repos/uclibs/scholar_uc/branches{/branch}","tags_url":"https://api.github.com/repos/uclibs/scholar_uc/tags","blobs_url":"https://api.github.com/repos/uclibs/scholar_uc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uclibs/scholar_uc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uclibs/scholar_uc/git/refs{/sha}","trees_url":"https://api.github.com/repos/uclibs/scholar_uc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uclibs/scholar_uc/statuses/{sha}","languages_url":"https://api.github.com/repos/uclibs/scholar_uc/languages","stargazers_url":"https://api.github.com/repos/uclibs/scholar_uc/stargazers","contributors_url":"https://api.github.com/repos/uclibs/scholar_uc/contributors","subscribers_url":"https://api.github.com/repos/uclibs/scholar_uc/subscribers","subscription_url":"https://api.github.com/repos/uclibs/scholar_uc/subscription","commits_url":"https://api.github.com/repos/uclibs/scholar_uc/commits{/sha}","git_commits_url":"https://api.github.com/repos/uclibs/scholar_uc/git/commits{/sha}","comments_url":"https://api.github.com/repos/uclibs/scholar_uc/comments{/number}","issue_comment_url":"https://api.github.com/repos/uclibs/scholar_uc/issues/comments{/number}","contents_url":"https://api.github.com/repos/uclibs/scholar_uc/contents/{+path}","compare_url":"https://api.github.com/repos/uclibs/scholar_uc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uclibs/scholar_uc/merges","archive_url":"https://api.github.com/repos/uclibs/scholar_uc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uclibs/scholar_uc/downloads","issues_url":"https://api.github.com/repos/uclibs/scholar_uc/issues{/number}","pulls_url":"https://api.github.com/repos/uclibs/scholar_uc/pulls{/number}","milestones_url":"https://api.github.com/repos/uclibs/scholar_uc/milestones{/number}","notifications_url":"https://api.github.com/repos/uclibs/scholar_uc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uclibs/scholar_uc/labels{/name}","releases_url":"https://api.github.com/repos/uclibs/scholar_uc/releases{/id}","deployments_url":"https://api.github.com/repos/uclibs/scholar_uc/deployments","created_at":"2013-12-20T19:53:26Z","updated_at":"2017-05-03T07:17:43Z","pushed_at":"2017-05-12T15:31:23Z","git_url":"git://github.com/uclibs/scholar_uc.git","ssh_url":"git@github.com:uclibs/scholar_uc.git","clone_url":"https://github.com/uclibs/scholar_uc.git","svn_url":"https://github.com/uclibs/scholar_uc","homepage":"https://scholar.uc.edu","size":16910,"stargazers_count":4,"watchers_count":4,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":205,"forks":0,"open_issues":205,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/uclibs/scholar_uc/pulls/1385"},"html":{"href":"https://github.com/uclibs/scholar_uc/pull/1385"},"issue":{"href":"https://api.github.com/repos/uclibs/scholar_uc/issues/1385"},"comments":{"href":"https://api.github.com/repos/uclibs/scholar_uc/issues/1385/comments"},"review_comments":{"href":"https://api.github.com/repos/uclibs/scholar_uc/pulls/1385/comments"},"review_comment":{"href":"https://api.github.com/repos/uclibs/scholar_uc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uclibs/scholar_uc/pulls/1385/commits"},"statuses":{"href":"https://api.github.com/repos/uclibs/scholar_uc/statuses/dcf87e6549f31cbd9678658c0eb845f2956bf7a1"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jamesvanmil","id":2651187,"avatar_url":"https://avatars2.githubusercontent.com/u/2651187?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesvanmil","html_url":"https://github.com/jamesvanmil","followers_url":"https://api.github.com/users/jamesvanmil/followers","following_url":"https://api.github.com/users/jamesvanmil/following{/other_user}","gists_url":"https://api.github.com/users/jamesvanmil/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesvanmil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesvanmil/subscriptions","organizations_url":"https://api.github.com/users/jamesvanmil/orgs","repos_url":"https://api.github.com/users/jamesvanmil/repos","events_url":"https://api.github.com/users/jamesvanmil/events{/privacy}","received_events_url":"https://api.github.com/users/jamesvanmil/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":66,"deletions":11,"changed_files":5}}
{"actor":{"display_login":"jamesvanmil"}}