{"action":"created","comment":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/comments/128050241","pull_request_review_id":50693769,"id":128050241,"diff_hunk":"@@ -2729,13 +2763,14 @@ public Jar pack(String profile) throws Exception {\n \t */\n \n \tpublic void baseline() throws Exception {\n-\t\tProjectBuilder b = getBuilder(null);\n-\t\tfor (Builder pb : b.getSubBuilders()) {\n-\t\t\tProjectBuilder ppb = (ProjectBuilder) pb;\n-\t\t\tJar build = ppb.build();\n-\t\t\tgetInfo(ppb);\n+\t\ttry (ProjectBuilder b = getBuilder(null);) {\n+\t\t\tfor (Builder pb : b.getSubBuilders()) {\n+\t\t\t\tProjectBuilder ppb = (ProjectBuilder) pb;\n+\t\t\t\tJar build = ppb.build();","path":"biz.aQute.bndlib/src/aQute/bnd/build/Project.java","position":273,"original_position":273,"commit_id":"30b96cc5ef1f7f6d21fb60388f6e2c7ad47090af","original_commit_id":"30b96cc5ef1f7f6d21fb60388f6e2c7ad47090af","user":{"login":"bjhargrave","id":277682,"avatar_url":"https://avatars1.githubusercontent.com/u/277682?v=4","gravatar_id":"","url":"https://api.github.com/users/bjhargrave","html_url":"https://github.com/bjhargrave","followers_url":"https://api.github.com/users/bjhargrave/followers","following_url":"https://api.github.com/users/bjhargrave/following{/other_user}","gists_url":"https://api.github.com/users/bjhargrave/gists{/gist_id}","starred_url":"https://api.github.com/users/bjhargrave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjhargrave/subscriptions","organizations_url":"https://api.github.com/users/bjhargrave/orgs","repos_url":"https://api.github.com/users/bjhargrave/repos","events_url":"https://api.github.com/users/bjhargrave/events{/privacy}","received_events_url":"https://api.github.com/users/bjhargrave/received_events","type":"User","site_admin":false},"body":"The jar is associated with the builder that returns it. So when the builder is closed, the jar will also be closed. The builder will be closed when the project builder is closed.","created_at":"2017-07-18T18:00:35Z","updated_at":"2017-07-18T18:00:35Z","html_url":"https://github.com/bndtools/bnd/pull/2090#discussion_r128050241","pull_request_url":"https://api.github.com/repos/bndtools/bnd/pulls/2090","_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments/128050241"},"html":{"href":"https://github.com/bndtools/bnd/pull/2090#discussion_r128050241"},"pull_request":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2090"}}},"pull_request":{"url":"https://api.github.com/repos/bndtools/bnd/pulls/2090","id":131110875,"html_url":"https://github.com/bndtools/bnd/pull/2090","diff_url":"https://github.com/bndtools/bnd/pull/2090.diff","patch_url":"https://github.com/bndtools/bnd/pull/2090.patch","issue_url":"https://api.github.com/repos/bndtools/bnd/issues/2090","number":2090,"state":"open","locked":false,"title":"[file leak] It seems likely the file leak was caused by builders not …","user":{"login":"pkriens","id":200494,"avatar_url":"https://avatars1.githubusercontent.com/u/200494?v=4","gravatar_id":"","url":"https://api.github.com/users/pkriens","html_url":"https://github.com/pkriens","followers_url":"https://api.github.com/users/pkriens/followers","following_url":"https://api.github.com/users/pkriens/following{/other_user}","gists_url":"https://api.github.com/users/pkriens/gists{/gist_id}","starred_url":"https://api.github.com/users/pkriens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkriens/subscriptions","organizations_url":"https://api.github.com/users/pkriens/orgs","repos_url":"https://api.github.com/users/pkriens/repos","events_url":"https://api.github.com/users/pkriens/events{/privacy}","received_events_url":"https://api.github.com/users/pkriens/received_events","type":"User","site_admin":false},"body":"…being closed\r\n\r\nThis patch fixes a number of places where builders were created but never closed.\r\n\r\nNote: the previous patch worked for the GC option\r\n\r\nSigned-off-by: Peter Kriens <peter.kriens@aqute.biz>","created_at":"2017-07-18T15:00:46Z","updated_at":"2017-07-18T18:00:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82ced752af96ba2f39cbf39d2414733002aa0e2f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bndtools/bnd/pulls/2090/commits","review_comments_url":"https://api.github.com/repos/bndtools/bnd/pulls/2090/comments","review_comment_url":"https://api.github.com/repos/bndtools/bnd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bndtools/bnd/issues/2090/comments","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/30b96cc5ef1f7f6d21fb60388f6e2c7ad47090af","head":{"label":"pkriens:master","ref":"master","sha":"30b96cc5ef1f7f6d21fb60388f6e2c7ad47090af","user":{"login":"pkriens","id":200494,"avatar_url":"https://avatars1.githubusercontent.com/u/200494?v=4","gravatar_id":"","url":"https://api.github.com/users/pkriens","html_url":"https://github.com/pkriens","followers_url":"https://api.github.com/users/pkriens/followers","following_url":"https://api.github.com/users/pkriens/following{/other_user}","gists_url":"https://api.github.com/users/pkriens/gists{/gist_id}","starred_url":"https://api.github.com/users/pkriens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkriens/subscriptions","organizations_url":"https://api.github.com/users/pkriens/orgs","repos_url":"https://api.github.com/users/pkriens/repos","events_url":"https://api.github.com/users/pkriens/events{/privacy}","received_events_url":"https://api.github.com/users/pkriens/received_events","type":"User","site_admin":false},"repo":{"id":21281549,"name":"bnd","full_name":"pkriens/bnd","owner":{"login":"pkriens","id":200494,"avatar_url":"https://avatars1.githubusercontent.com/u/200494?v=4","gravatar_id":"","url":"https://api.github.com/users/pkriens","html_url":"https://github.com/pkriens","followers_url":"https://api.github.com/users/pkriens/followers","following_url":"https://api.github.com/users/pkriens/following{/other_user}","gists_url":"https://api.github.com/users/pkriens/gists{/gist_id}","starred_url":"https://api.github.com/users/pkriens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pkriens/subscriptions","organizations_url":"https://api.github.com/users/pkriens/orgs","repos_url":"https://api.github.com/users/pkriens/repos","events_url":"https://api.github.com/users/pkriens/events{/privacy}","received_events_url":"https://api.github.com/users/pkriens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pkriens/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build bundles.","fork":true,"url":"https://api.github.com/repos/pkriens/bnd","forks_url":"https://api.github.com/repos/pkriens/bnd/forks","keys_url":"https://api.github.com/repos/pkriens/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pkriens/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pkriens/bnd/teams","hooks_url":"https://api.github.com/repos/pkriens/bnd/hooks","issue_events_url":"https://api.github.com/repos/pkriens/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/pkriens/bnd/events","assignees_url":"https://api.github.com/repos/pkriens/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/pkriens/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/pkriens/bnd/tags","blobs_url":"https://api.github.com/repos/pkriens/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pkriens/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pkriens/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pkriens/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pkriens/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/pkriens/bnd/languages","stargazers_url":"https://api.github.com/repos/pkriens/bnd/stargazers","contributors_url":"https://api.github.com/repos/pkriens/bnd/contributors","subscribers_url":"https://api.github.com/repos/pkriens/bnd/subscribers","subscription_url":"https://api.github.com/repos/pkriens/bnd/subscription","commits_url":"https://api.github.com/repos/pkriens/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pkriens/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pkriens/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pkriens/bnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pkriens/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/pkriens/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pkriens/bnd/merges","archive_url":"https://api.github.com/repos/pkriens/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pkriens/bnd/downloads","issues_url":"https://api.github.com/repos/pkriens/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/pkriens/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/pkriens/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/pkriens/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pkriens/bnd/labels{/name}","releases_url":"https://api.github.com/repos/pkriens/bnd/releases{/id}","deployments_url":"https://api.github.com/repos/pkriens/bnd/deployments","created_at":"2014-06-27T16:11:14Z","updated_at":"2017-03-20T17:23:43Z","pushed_at":"2017-07-18T15:35:02Z","git_url":"git://github.com/pkriens/bnd.git","ssh_url":"git@github.com:pkriens/bnd.git","clone_url":"https://github.com/pkriens/bnd.git","svn_url":"https://github.com/pkriens/bnd","homepage":"http://www.aQute.biz/Bnd","size":289894,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"bndtools:master","ref":"master","sha":"a944cb2945e6cc975f0c2cb61d0ef6040b8a87b9","user":{"login":"bndtools","id":1130828,"avatar_url":"https://avatars1.githubusercontent.com/u/1130828?v=4","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"repo":{"id":606956,"name":"bnd","full_name":"bndtools/bnd","owner":{"login":"bndtools","id":1130828,"avatar_url":"https://avatars1.githubusercontent.com/u/1130828?v=4","gravatar_id":"","url":"https://api.github.com/users/bndtools","html_url":"https://github.com/bndtools","followers_url":"https://api.github.com/users/bndtools/followers","following_url":"https://api.github.com/users/bndtools/following{/other_user}","gists_url":"https://api.github.com/users/bndtools/gists{/gist_id}","starred_url":"https://api.github.com/users/bndtools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bndtools/subscriptions","organizations_url":"https://api.github.com/users/bndtools/orgs","repos_url":"https://api.github.com/users/bndtools/repos","events_url":"https://api.github.com/users/bndtools/events{/privacy}","received_events_url":"https://api.github.com/users/bndtools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bndtools/bnd","description":"bnd, the swiss army knife for OSGi. A tool to build OSGi bundles.","fork":false,"url":"https://api.github.com/repos/bndtools/bnd","forks_url":"https://api.github.com/repos/bndtools/bnd/forks","keys_url":"https://api.github.com/repos/bndtools/bnd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bndtools/bnd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bndtools/bnd/teams","hooks_url":"https://api.github.com/repos/bndtools/bnd/hooks","issue_events_url":"https://api.github.com/repos/bndtools/bnd/issues/events{/number}","events_url":"https://api.github.com/repos/bndtools/bnd/events","assignees_url":"https://api.github.com/repos/bndtools/bnd/assignees{/user}","branches_url":"https://api.github.com/repos/bndtools/bnd/branches{/branch}","tags_url":"https://api.github.com/repos/bndtools/bnd/tags","blobs_url":"https://api.github.com/repos/bndtools/bnd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bndtools/bnd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bndtools/bnd/git/refs{/sha}","trees_url":"https://api.github.com/repos/bndtools/bnd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bndtools/bnd/statuses/{sha}","languages_url":"https://api.github.com/repos/bndtools/bnd/languages","stargazers_url":"https://api.github.com/repos/bndtools/bnd/stargazers","contributors_url":"https://api.github.com/repos/bndtools/bnd/contributors","subscribers_url":"https://api.github.com/repos/bndtools/bnd/subscribers","subscription_url":"https://api.github.com/repos/bndtools/bnd/subscription","commits_url":"https://api.github.com/repos/bndtools/bnd/commits{/sha}","git_commits_url":"https://api.github.com/repos/bndtools/bnd/git/commits{/sha}","comments_url":"https://api.github.com/repos/bndtools/bnd/comments{/number}","issue_comment_url":"https://api.github.com/repos/bndtools/bnd/issues/comments{/number}","contents_url":"https://api.github.com/repos/bndtools/bnd/contents/{+path}","compare_url":"https://api.github.com/repos/bndtools/bnd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bndtools/bnd/merges","archive_url":"https://api.github.com/repos/bndtools/bnd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bndtools/bnd/downloads","issues_url":"https://api.github.com/repos/bndtools/bnd/issues{/number}","pulls_url":"https://api.github.com/repos/bndtools/bnd/pulls{/number}","milestones_url":"https://api.github.com/repos/bndtools/bnd/milestones{/number}","notifications_url":"https://api.github.com/repos/bndtools/bnd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bndtools/bnd/labels{/name}","releases_url":"https://api.github.com/repos/bndtools/bnd/releases{/id}","deployments_url":"https://api.github.com/repos/bndtools/bnd/deployments","created_at":"2010-04-12T17:30:15Z","updated_at":"2017-06-20T16:47:21Z","pushed_at":"2017-07-18T17:57:15Z","git_url":"git://github.com/bndtools/bnd.git","ssh_url":"git@github.com:bndtools/bnd.git","clone_url":"https://github.com/bndtools/bnd.git","svn_url":"https://github.com/bndtools/bnd","homepage":"http://bnd.bndtools.org","size":289914,"stargazers_count":273,"watchers_count":273,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":179,"mirror_url":null,"open_issues_count":58,"forks":179,"open_issues":58,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2090"},"html":{"href":"https://github.com/bndtools/bnd/pull/2090"},"issue":{"href":"https://api.github.com/repos/bndtools/bnd/issues/2090"},"comments":{"href":"https://api.github.com/repos/bndtools/bnd/issues/2090/comments"},"review_comments":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2090/comments"},"review_comment":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bndtools/bnd/pulls/2090/commits"},"statuses":{"href":"https://api.github.com/repos/bndtools/bnd/statuses/30b96cc5ef1f7f6d21fb60388f6e2c7ad47090af"}}}}
{"actor":{"display_login":"bjhargrave"}}