{"action":"created","comment":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/127677290","pull_request_review_id":50284708,"id":127677290,"diff_hunk":"@@ -336,14 +358,14 @@ private synchronized void close() {\n             if (!updating) { \n                 osgiManager.managedBundlesRecord.addManagedBundle(result);\n                 result.code = OsgiBundleInstallationResult.ResultCode.INSTALLED_NEW_BUNDLE;\n-                result.message = \"Installed \"+result.getMetadata().getVersionedName()+\" with ID \"+result.getMetadata().getId();\n+                result.message = \"Installed Brooklyn catalog bundle \"+result.getMetadata().getVersionedName()+\" with ID \"+result.getMetadata().getId()+\" [\"+result.bundle.getBundleId()+\"]\";","path":"core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiArchiveInstaller.java","position":150,"original_position":150,"commit_id":"c39eb71ad0ef066b479cec10ff4e97166b3558c1","original_commit_id":"5868124a4eba5e02847479178bfa7415340ffc0a","user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars4.githubusercontent.com/u/496540?v=4","gravatar_id":"","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"body":"this will happen if you install a `catalog.bom` which doesn't come from OSGi and which declare a bundle.  we should be declaring a `bundle` in all BOMs.  i've added this (some cheekily pushed to other projects).\r\n\r\nthe odd thing though is that the \"delete empty BOMs\" logic should be cleaning this up.  i'm looking at that.  (i think all other comments are addressed.)","created_at":"2017-07-17T10:43:42Z","updated_at":"2017-07-17T10:43:42Z","html_url":"https://github.com/apache/brooklyn-server/pull/746#discussion_r127677290","pull_request_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/746","_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments/127677290"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/746#discussion_r127677290"},"pull_request":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/746"}}},"pull_request":{"url":"https://api.github.com/repos/apache/brooklyn-server/pulls/746","id":127900865,"html_url":"https://github.com/apache/brooklyn-server/pull/746","diff_url":"https://github.com/apache/brooklyn-server/pull/746.diff","patch_url":"https://github.com/apache/brooklyn-server/pull/746.patch","issue_url":"https://api.github.com/repos/apache/brooklyn-server/issues/746","number":746,"state":"open","locked":false,"title":"Auto wrap YAML BOMs as catalog bundles","user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars4.githubusercontent.com/u/496540?v=4","gravatar_id":"","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"body":"Wraps pure-YAML BOMs uploaded to catalog in a bundle, creating a name and version if needed.\r\n\r\nThis allows us to see all items added as a unit.  This will allow us to prefer loading co-defined items (though that's not fully done, still relies on preferring search path when doing item lookup), and to edit or remove that item as a set (crucially we now keep the BOM, previously we discarded it!).\r\n\r\nDocs changed to reflect this and explain differences in another PR.\r\n\r\nThe basic wrapping was pretty simple but a surprising number of subtleties emerged which this fixes:\r\n\r\n* java scanning doesn't work in OSGi; docs and errors make this clear\r\n* impacts replacement semantics (now it does a hash on the bundle to make most things the same, though a re-post of a non-SNAPSHOT BOM that doesn't declare a bundle will now fail because the random bundle name is stored on the item as containingBundle and is different on a re-post; and needed extra work to remove leaked anonymous bundles)\r\n* had to change the way we set up the libraries / search path, to exclude this \"bundle\" (mainly so tests are unchanged, but also improves efficiency for simple BOMs; also the code is cleaner now)\r\n\r\nAnd there is one thing that emerged that I *haven't* fixed:  on rebind it became vital to handle the situation where dependent bundles might not be loaded before the depender bundle; see failing test`testLongReferenceSequence`.  Not entirely sure how to do this /cc @neykov @geomacy @aledsage.\r\n\r\nDepends on #743.\r\n\r\n","created_at":"2017-06-28T11:31:32Z","updated_at":"2017-07-17T10:43:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49f5822fbffd841300943e17e8f24c23f23927dd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/746/commits","review_comments_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/746/comments","review_comment_url":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/issues/746/comments","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/c39eb71ad0ef066b479cec10ff4e97166b3558c1","head":{"label":"ahgittin:osgi-auto-wrap-yaml","ref":"osgi-auto-wrap-yaml","sha":"c39eb71ad0ef066b479cec10ff4e97166b3558c1","user":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars4.githubusercontent.com/u/496540?v=4","gravatar_id":"","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"repo":{"id":51005981,"name":"brooklyn-server","full_name":"ahgittin/brooklyn-server","owner":{"login":"ahgittin","id":496540,"avatar_url":"https://avatars4.githubusercontent.com/u/496540?v=4","gravatar_id":"","url":"https://api.github.com/users/ahgittin","html_url":"https://github.com/ahgittin","followers_url":"https://api.github.com/users/ahgittin/followers","following_url":"https://api.github.com/users/ahgittin/following{/other_user}","gists_url":"https://api.github.com/users/ahgittin/gists{/gist_id}","starred_url":"https://api.github.com/users/ahgittin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahgittin/subscriptions","organizations_url":"https://api.github.com/users/ahgittin/orgs","repos_url":"https://api.github.com/users/ahgittin/repos","events_url":"https://api.github.com/users/ahgittin/events{/privacy}","received_events_url":"https://api.github.com/users/ahgittin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ahgittin/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":true,"url":"https://api.github.com/repos/ahgittin/brooklyn-server","forks_url":"https://api.github.com/repos/ahgittin/brooklyn-server/forks","keys_url":"https://api.github.com/repos/ahgittin/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ahgittin/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ahgittin/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/ahgittin/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/ahgittin/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/ahgittin/brooklyn-server/events","assignees_url":"https://api.github.com/repos/ahgittin/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/ahgittin/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/ahgittin/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/ahgittin/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ahgittin/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ahgittin/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/ahgittin/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ahgittin/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/ahgittin/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/ahgittin/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/ahgittin/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/ahgittin/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/ahgittin/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/ahgittin/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/ahgittin/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/ahgittin/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/ahgittin/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/ahgittin/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/ahgittin/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ahgittin/brooklyn-server/merges","archive_url":"https://api.github.com/repos/ahgittin/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ahgittin/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/ahgittin/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/ahgittin/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/ahgittin/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/ahgittin/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ahgittin/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/ahgittin/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/ahgittin/brooklyn-server/deployments","created_at":"2016-02-03T14:45:22Z","updated_at":"2016-02-03T14:45:30Z","pushed_at":"2017-07-17T10:41:32Z","git_url":"git://github.com/ahgittin/brooklyn-server.git","ssh_url":"git@github.com:ahgittin/brooklyn-server.git","clone_url":"https://github.com/ahgittin/brooklyn-server.git","svn_url":"https://github.com/ahgittin/brooklyn-server","homepage":null,"size":36816,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"be99f135fe28e93d2cd534731f22289e86e1e89c","user":{"login":"apache","id":47359,"avatar_url":"https://avatars4.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":47246081,"name":"brooklyn-server","full_name":"apache/brooklyn-server","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars4.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/brooklyn-server","description":"Mirror of Apache Brooklyn server","fork":false,"url":"https://api.github.com/repos/apache/brooklyn-server","forks_url":"https://api.github.com/repos/apache/brooklyn-server/forks","keys_url":"https://api.github.com/repos/apache/brooklyn-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/brooklyn-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/brooklyn-server/teams","hooks_url":"https://api.github.com/repos/apache/brooklyn-server/hooks","issue_events_url":"https://api.github.com/repos/apache/brooklyn-server/issues/events{/number}","events_url":"https://api.github.com/repos/apache/brooklyn-server/events","assignees_url":"https://api.github.com/repos/apache/brooklyn-server/assignees{/user}","branches_url":"https://api.github.com/repos/apache/brooklyn-server/branches{/branch}","tags_url":"https://api.github.com/repos/apache/brooklyn-server/tags","blobs_url":"https://api.github.com/repos/apache/brooklyn-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/brooklyn-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/brooklyn-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/brooklyn-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/brooklyn-server/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/brooklyn-server/languages","stargazers_url":"https://api.github.com/repos/apache/brooklyn-server/stargazers","contributors_url":"https://api.github.com/repos/apache/brooklyn-server/contributors","subscribers_url":"https://api.github.com/repos/apache/brooklyn-server/subscribers","subscription_url":"https://api.github.com/repos/apache/brooklyn-server/subscription","commits_url":"https://api.github.com/repos/apache/brooklyn-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/brooklyn-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/brooklyn-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/brooklyn-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/brooklyn-server/contents/{+path}","compare_url":"https://api.github.com/repos/apache/brooklyn-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/brooklyn-server/merges","archive_url":"https://api.github.com/repos/apache/brooklyn-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/brooklyn-server/downloads","issues_url":"https://api.github.com/repos/apache/brooklyn-server/issues{/number}","pulls_url":"https://api.github.com/repos/apache/brooklyn-server/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/brooklyn-server/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/brooklyn-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/brooklyn-server/labels{/name}","releases_url":"https://api.github.com/repos/apache/brooklyn-server/releases{/id}","deployments_url":"https://api.github.com/repos/apache/brooklyn-server/deployments","created_at":"2015-12-02T08:00:06Z","updated_at":"2017-03-30T16:04:01Z","pushed_at":"2017-07-17T10:41:33Z","git_url":"git://github.com/apache/brooklyn-server.git","ssh_url":"git@github.com:apache/brooklyn-server.git","clone_url":"https://github.com/apache/brooklyn-server.git","svn_url":"https://github.com/apache/brooklyn-server","homepage":null,"size":36308,"stargazers_count":16,"watchers_count":16,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":"git://git.apache.org/brooklyn-server.git","open_issues_count":12,"forks":44,"open_issues":12,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/746"},"html":{"href":"https://github.com/apache/brooklyn-server/pull/746"},"issue":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/746"},"comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/issues/746/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/746/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/brooklyn-server/pulls/746/commits"},"statuses":{"href":"https://api.github.com/repos/apache/brooklyn-server/statuses/c39eb71ad0ef066b479cec10ff4e97166b3558c1"}}}}
{"actor":{"display_login":"ahgittin"}}