{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/comments/135141978","pull_request_review_id":58523124,"id":135141978,"diff_hunk":"@@ -10,4 +10,7 @@ export { Grid } from \"./grid\";\n export { Rect, AnyRect } from \"./rect\";\n export { RoundSize } from \"./roundSize\";\n export { Utils } from \"./utils\";\n-// NOTE: Errors is not exported in public API\n+\n+// NOTE: The following are not exported in the public API:\n+// - Errors\n+// - internal/","path":"packages/table/src/common/index.ts","position":8,"original_position":8,"commit_id":"839c0276b9c36156989422487f1b70e47a331b18","original_commit_id":"f5080e452ad771cdeefdc0bb7d248f873aa39ff8","user":{"login":"giladgray","id":464822,"avatar_url":"https://avatars1.githubusercontent.com/u/464822?v=4","gravatar_id":"","url":"https://api.github.com/users/giladgray","html_url":"https://github.com/giladgray","followers_url":"https://api.github.com/users/giladgray/followers","following_url":"https://api.github.com/users/giladgray/following{/other_user}","gists_url":"https://api.github.com/users/giladgray/gists{/gist_id}","starred_url":"https://api.github.com/users/giladgray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giladgray/subscriptions","organizations_url":"https://api.github.com/users/giladgray/orgs","repos_url":"https://api.github.com/users/giladgray/repos","events_url":"https://api.github.com/users/giladgray/events{/privacy}","received_events_url":"https://api.github.com/users/giladgray/received_events","type":"User","site_admin":false},"body":"👍 yes nice","created_at":"2017-08-24T22:00:13Z","updated_at":"2017-08-24T22:07:22Z","html_url":"https://github.com/palantir/blueprint/pull/1496#discussion_r135141978","pull_request_url":"https://api.github.com/repos/palantir/blueprint/pulls/1496","_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments/135141978"},"html":{"href":"https://github.com/palantir/blueprint/pull/1496#discussion_r135141978"},"pull_request":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/1496"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/blueprint/pulls/1496","id":137540980,"html_url":"https://github.com/palantir/blueprint/pull/1496","diff_url":"https://github.com/palantir/blueprint/pull/1496.diff","patch_url":"https://github.com/palantir/blueprint/pull/1496.patch","issue_url":"https://api.github.com/repos/palantir/blueprint/issues/1496","number":1496,"state":"open","locked":false,"title":"[Table] scrollToRegion instance method","user":{"login":"cmslewis","id":443450,"avatar_url":"https://avatars2.githubusercontent.com/u/443450?v=4","gravatar_id":"","url":"https://api.github.com/users/cmslewis","html_url":"https://github.com/cmslewis","followers_url":"https://api.github.com/users/cmslewis/followers","following_url":"https://api.github.com/users/cmslewis/following{/other_user}","gists_url":"https://api.github.com/users/cmslewis/gists{/gist_id}","starred_url":"https://api.github.com/users/cmslewis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmslewis/subscriptions","organizations_url":"https://api.github.com/users/cmslewis/orgs","repos_url":"https://api.github.com/users/cmslewis/repos","events_url":"https://api.github.com/users/cmslewis/events{/privacy}","received_events_url":"https://api.github.com/users/cmslewis/received_events","type":"User","site_admin":false},"body":"#### Fixes #1065, Fixes #1430\r\n\r\n#### Checklist\r\n\r\n- [ ] Include tests (`TODO`)\r\n- [ ] Update documentation (`TODO`)\r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- 💎 __NEW__ `Table` now offers a __`scrollToRegion(region: IRegion)`__ instance method to programmatically scroll a desired row, column, or cell into view!\r\n    - The target region will be positioned in the top/left corner of the viewport.\r\n        - Or if the table is maximally scrolled, then having the target cell simply in view is enough.\r\n    - If there are active frozen rows and/or columns:\r\n        - Scrolling to a frozen row will move the table back to `scrollTop=0`.\r\n        - Scrolling to a frozen column will move the table back to `scrollLeft=0`.\r\n        - Scrolling to a frozen `TOP_LEFT` cell will move the table back to (0, 0).\r\n        - Scrolling to a non-frozen row/column will scroll the target region to just _beyond_ the frozen regions, keeping it clearly in view.\r\n- Also added some new `scrollTo` controls on the `Table` example page.\r\n\r\n#### Reviewers should focus on:\r\n\r\n- How does this API look? Tried to be as simple and general as possible. Ended up not including an `animated` option for now, because that'd actually be a lot more work.\r\n\r\n#### Screenshot\r\n\r\n![2017-08-24 12 50 14](https://user-images.githubusercontent.com/443450/29686106-9b0ac308-88cc-11e7-9cf6-e008b3b9012f.gif)","created_at":"2017-08-24T20:11:09Z","updated_at":"2017-08-24T22:07:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9396d1f10f748f1f81e860cf9b71fa71d32643a8","assignee":null,"assignees":[],"requested_reviewers":[{"login":"llorca","id":199754,"avatar_url":"https://avatars0.githubusercontent.com/u/199754?v=4","gravatar_id":"","url":"https://api.github.com/users/llorca","html_url":"https://github.com/llorca","followers_url":"https://api.github.com/users/llorca/followers","following_url":"https://api.github.com/users/llorca/following{/other_user}","gists_url":"https://api.github.com/users/llorca/gists{/gist_id}","starred_url":"https://api.github.com/users/llorca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/llorca/subscriptions","organizations_url":"https://api.github.com/users/llorca/orgs","repos_url":"https://api.github.com/users/llorca/repos","events_url":"https://api.github.com/users/llorca/events{/privacy}","received_events_url":"https://api.github.com/users/llorca/received_events","type":"User","site_admin":false},{"login":"themadcreator","id":569364,"avatar_url":"https://avatars2.githubusercontent.com/u/569364?v=4","gravatar_id":"","url":"https://api.github.com/users/themadcreator","html_url":"https://github.com/themadcreator","followers_url":"https://api.github.com/users/themadcreator/followers","following_url":"https://api.github.com/users/themadcreator/following{/other_user}","gists_url":"https://api.github.com/users/themadcreator/gists{/gist_id}","starred_url":"https://api.github.com/users/themadcreator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themadcreator/subscriptions","organizations_url":"https://api.github.com/users/themadcreator/orgs","repos_url":"https://api.github.com/users/themadcreator/repos","events_url":"https://api.github.com/users/themadcreator/events{/privacy}","received_events_url":"https://api.github.com/users/themadcreator/received_events","type":"User","site_admin":false},{"login":"gscshoyru","id":2463526,"avatar_url":"https://avatars1.githubusercontent.com/u/2463526?v=4","gravatar_id":"","url":"https://api.github.com/users/gscshoyru","html_url":"https://github.com/gscshoyru","followers_url":"https://api.github.com/users/gscshoyru/followers","following_url":"https://api.github.com/users/gscshoyru/following{/other_user}","gists_url":"https://api.github.com/users/gscshoyru/gists{/gist_id}","starred_url":"https://api.github.com/users/gscshoyru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gscshoyru/subscriptions","organizations_url":"https://api.github.com/users/gscshoyru/orgs","repos_url":"https://api.github.com/users/gscshoyru/repos","events_url":"https://api.github.com/users/gscshoyru/events{/privacy}","received_events_url":"https://api.github.com/users/gscshoyru/received_events","type":"User","site_admin":false},{"login":"tgreenwatts","id":24398123,"avatar_url":"https://avatars3.githubusercontent.com/u/24398123?v=4","gravatar_id":"","url":"https://api.github.com/users/tgreenwatts","html_url":"https://github.com/tgreenwatts","followers_url":"https://api.github.com/users/tgreenwatts/followers","following_url":"https://api.github.com/users/tgreenwatts/following{/other_user}","gists_url":"https://api.github.com/users/tgreenwatts/gists{/gist_id}","starred_url":"https://api.github.com/users/tgreenwatts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tgreenwatts/subscriptions","organizations_url":"https://api.github.com/users/tgreenwatts/orgs","repos_url":"https://api.github.com/users/tgreenwatts/repos","events_url":"https://api.github.com/users/tgreenwatts/events{/privacy}","received_events_url":"https://api.github.com/users/tgreenwatts/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/blueprint/pulls/1496/commits","review_comments_url":"https://api.github.com/repos/palantir/blueprint/pulls/1496/comments","review_comment_url":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/blueprint/issues/1496/comments","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/839c0276b9c36156989422487f1b70e47a331b18","head":{"label":"palantir:cl/table-scroll-to-position","ref":"cl/table-scroll-to-position","sha":"839c0276b9c36156989422487f1b70e47a331b18","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2017-08-24T21:01:33Z","pushed_at":"2017-08-24T21:58:15Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":47426,"stargazers_count":6794,"watchers_count":6794,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":384,"mirror_url":null,"open_issues_count":280,"forks":384,"open_issues":280,"watchers":6794,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"625f343a48111025aa44b01002d5312e1e35eb5c","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":71939872,"name":"blueprint","full_name":"palantir/blueprint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/blueprint","description":"A React-based UI toolkit for the web","fork":false,"url":"https://api.github.com/repos/palantir/blueprint","forks_url":"https://api.github.com/repos/palantir/blueprint/forks","keys_url":"https://api.github.com/repos/palantir/blueprint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/blueprint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/blueprint/teams","hooks_url":"https://api.github.com/repos/palantir/blueprint/hooks","issue_events_url":"https://api.github.com/repos/palantir/blueprint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/blueprint/events","assignees_url":"https://api.github.com/repos/palantir/blueprint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/blueprint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/blueprint/tags","blobs_url":"https://api.github.com/repos/palantir/blueprint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/blueprint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/blueprint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/blueprint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/blueprint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/blueprint/languages","stargazers_url":"https://api.github.com/repos/palantir/blueprint/stargazers","contributors_url":"https://api.github.com/repos/palantir/blueprint/contributors","subscribers_url":"https://api.github.com/repos/palantir/blueprint/subscribers","subscription_url":"https://api.github.com/repos/palantir/blueprint/subscription","commits_url":"https://api.github.com/repos/palantir/blueprint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/blueprint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/blueprint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/blueprint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/blueprint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/blueprint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/blueprint/merges","archive_url":"https://api.github.com/repos/palantir/blueprint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/blueprint/downloads","issues_url":"https://api.github.com/repos/palantir/blueprint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/blueprint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/blueprint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/blueprint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/blueprint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/blueprint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/blueprint/deployments","created_at":"2016-10-25T21:17:50Z","updated_at":"2017-08-24T21:01:33Z","pushed_at":"2017-08-24T21:58:15Z","git_url":"git://github.com/palantir/blueprint.git","ssh_url":"git@github.com:palantir/blueprint.git","clone_url":"https://github.com/palantir/blueprint.git","svn_url":"https://github.com/palantir/blueprint","homepage":"http://blueprintjs.com/","size":47426,"stargazers_count":6794,"watchers_count":6794,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":384,"mirror_url":null,"open_issues_count":280,"forks":384,"open_issues":280,"watchers":6794,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/1496"},"html":{"href":"https://github.com/palantir/blueprint/pull/1496"},"issue":{"href":"https://api.github.com/repos/palantir/blueprint/issues/1496"},"comments":{"href":"https://api.github.com/repos/palantir/blueprint/issues/1496/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/1496/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/blueprint/pulls/1496/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/blueprint/statuses/839c0276b9c36156989422487f1b70e47a331b18"}}}}
{"actor":{"display_login":"giladgray"}}