{"action":"created","comment":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/158107635","pull_request_review_id":84864043,"id":158107635,"diff_hunk":"@@ -7,6 +7,10 @@\n from pandas import (Index, DatetimeIndex, Timestamp, Series,\n                     date_range, period_range)\n \n+from pandas._libs.tslibs.frequencies import (_period_code_map, get_rule_month,\n+                                             _period_str_to_code,\n+                                             _INVALID_FREQ_ERROR)","path":"pandas/tests/tseries/test_frequencies.py","position":6,"original_position":6,"commit_id":"02e32174140e596a3d12272dc8488b07bf6ef464","original_commit_id":"02e32174140e596a3d12272dc8488b07bf6ef464","user":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"Mostly just in tests.  If OK I'm going to save the remaining de-privatization and test_libfreqs for a follow-up.  Too many active PRs and this one is ready for its AARP membership.","created_at":"2017-12-20T18:59:44Z","updated_at":"2017-12-20T18:59:44Z","html_url":"https://github.com/pandas-dev/pandas/pull/17746#discussion_r158107635","pull_request_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17746","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments/158107635"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/17746#discussion_r158107635"},"pull_request":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17746"}},"in_reply_to_id":158015729},"pull_request":{"url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17746","id":144238331,"html_url":"https://github.com/pandas-dev/pandas/pull/17746","diff_url":"https://github.com/pandas-dev/pandas/pull/17746.diff","patch_url":"https://github.com/pandas-dev/pandas/pull/17746.patch","issue_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17746","number":17746,"state":"open","locked":false,"title":"Move frequencies functions to cython","user":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"body":"Move some more functions from `tseries.frequencies` up to `tslibs.frequencies`, update imports in `_libs.period` to cimports\r\n\r\n- [x] closes #xxxx\r\n- [ ] tests added / passed\r\n- [x] passes `git diff upstream/master -u -- \"*.py\" | flake8 --diff`\r\n- [ ] whatsnew entry\r\n","created_at":"2017-10-02T17:26:27Z","updated_at":"2017-12-20T18:59:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d134603f5bb57aecbecc0674bc3da2205872fe1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17746/commits","review_comments_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/17746/comments","review_comment_url":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/issues/17746/comments","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/02e32174140e596a3d12272dc8488b07bf6ef464","head":{"label":"jbrockmendel:tslibs-freqs3","ref":"tslibs-freqs3","sha":"02e32174140e596a3d12272dc8488b07bf6ef464","user":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"repo":{"id":96820953,"name":"pandas","full_name":"jbrockmendel/pandas","owner":{"login":"jbrockmendel","id":8078968,"avatar_url":"https://avatars1.githubusercontent.com/u/8078968?v=4","gravatar_id":"","url":"https://api.github.com/users/jbrockmendel","html_url":"https://github.com/jbrockmendel","followers_url":"https://api.github.com/users/jbrockmendel/followers","following_url":"https://api.github.com/users/jbrockmendel/following{/other_user}","gists_url":"https://api.github.com/users/jbrockmendel/gists{/gist_id}","starred_url":"https://api.github.com/users/jbrockmendel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbrockmendel/subscriptions","organizations_url":"https://api.github.com/users/jbrockmendel/orgs","repos_url":"https://api.github.com/users/jbrockmendel/repos","events_url":"https://api.github.com/users/jbrockmendel/events{/privacy}","received_events_url":"https://api.github.com/users/jbrockmendel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbrockmendel/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":true,"url":"https://api.github.com/repos/jbrockmendel/pandas","forks_url":"https://api.github.com/repos/jbrockmendel/pandas/forks","keys_url":"https://api.github.com/repos/jbrockmendel/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbrockmendel/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbrockmendel/pandas/teams","hooks_url":"https://api.github.com/repos/jbrockmendel/pandas/hooks","issue_events_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/jbrockmendel/pandas/events","assignees_url":"https://api.github.com/repos/jbrockmendel/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/jbrockmendel/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/jbrockmendel/pandas/tags","blobs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbrockmendel/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbrockmendel/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbrockmendel/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbrockmendel/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/jbrockmendel/pandas/languages","stargazers_url":"https://api.github.com/repos/jbrockmendel/pandas/stargazers","contributors_url":"https://api.github.com/repos/jbrockmendel/pandas/contributors","subscribers_url":"https://api.github.com/repos/jbrockmendel/pandas/subscribers","subscription_url":"https://api.github.com/repos/jbrockmendel/pandas/subscription","commits_url":"https://api.github.com/repos/jbrockmendel/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbrockmendel/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbrockmendel/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbrockmendel/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbrockmendel/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/jbrockmendel/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbrockmendel/pandas/merges","archive_url":"https://api.github.com/repos/jbrockmendel/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbrockmendel/pandas/downloads","issues_url":"https://api.github.com/repos/jbrockmendel/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/jbrockmendel/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/jbrockmendel/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/jbrockmendel/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbrockmendel/pandas/labels{/name}","releases_url":"https://api.github.com/repos/jbrockmendel/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/jbrockmendel/pandas/deployments","created_at":"2017-07-10T21:01:07Z","updated_at":"2017-07-10T21:01:15Z","pushed_at":"2017-12-20T18:35:26Z","git_url":"git://github.com/jbrockmendel/pandas.git","ssh_url":"git@github.com:jbrockmendel/pandas.git","clone_url":"https://github.com/jbrockmendel/pandas.git","svn_url":"https://github.com/jbrockmendel/pandas","homepage":"http://pandas.pydata.org","size":111943,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pandas-dev:master","ref":"master","sha":"96439fb13e941100080a8fb5c78b7b291a2dd2fe","user":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"repo":{"id":858127,"name":"pandas","full_name":"pandas-dev/pandas","owner":{"login":"pandas-dev","id":21206976,"avatar_url":"https://avatars2.githubusercontent.com/u/21206976?v=4","gravatar_id":"","url":"https://api.github.com/users/pandas-dev","html_url":"https://github.com/pandas-dev","followers_url":"https://api.github.com/users/pandas-dev/followers","following_url":"https://api.github.com/users/pandas-dev/following{/other_user}","gists_url":"https://api.github.com/users/pandas-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/pandas-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pandas-dev/subscriptions","organizations_url":"https://api.github.com/users/pandas-dev/orgs","repos_url":"https://api.github.com/users/pandas-dev/repos","events_url":"https://api.github.com/users/pandas-dev/events{/privacy}","received_events_url":"https://api.github.com/users/pandas-dev/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pandas-dev/pandas","description":"Flexible and powerful data analysis / manipulation library for Python, providing labeled data structures similar to R data.frame objects, statistical functions, and much more","fork":false,"url":"https://api.github.com/repos/pandas-dev/pandas","forks_url":"https://api.github.com/repos/pandas-dev/pandas/forks","keys_url":"https://api.github.com/repos/pandas-dev/pandas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pandas-dev/pandas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pandas-dev/pandas/teams","hooks_url":"https://api.github.com/repos/pandas-dev/pandas/hooks","issue_events_url":"https://api.github.com/repos/pandas-dev/pandas/issues/events{/number}","events_url":"https://api.github.com/repos/pandas-dev/pandas/events","assignees_url":"https://api.github.com/repos/pandas-dev/pandas/assignees{/user}","branches_url":"https://api.github.com/repos/pandas-dev/pandas/branches{/branch}","tags_url":"https://api.github.com/repos/pandas-dev/pandas/tags","blobs_url":"https://api.github.com/repos/pandas-dev/pandas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pandas-dev/pandas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pandas-dev/pandas/git/refs{/sha}","trees_url":"https://api.github.com/repos/pandas-dev/pandas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pandas-dev/pandas/statuses/{sha}","languages_url":"https://api.github.com/repos/pandas-dev/pandas/languages","stargazers_url":"https://api.github.com/repos/pandas-dev/pandas/stargazers","contributors_url":"https://api.github.com/repos/pandas-dev/pandas/contributors","subscribers_url":"https://api.github.com/repos/pandas-dev/pandas/subscribers","subscription_url":"https://api.github.com/repos/pandas-dev/pandas/subscription","commits_url":"https://api.github.com/repos/pandas-dev/pandas/commits{/sha}","git_commits_url":"https://api.github.com/repos/pandas-dev/pandas/git/commits{/sha}","comments_url":"https://api.github.com/repos/pandas-dev/pandas/comments{/number}","issue_comment_url":"https://api.github.com/repos/pandas-dev/pandas/issues/comments{/number}","contents_url":"https://api.github.com/repos/pandas-dev/pandas/contents/{+path}","compare_url":"https://api.github.com/repos/pandas-dev/pandas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pandas-dev/pandas/merges","archive_url":"https://api.github.com/repos/pandas-dev/pandas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pandas-dev/pandas/downloads","issues_url":"https://api.github.com/repos/pandas-dev/pandas/issues{/number}","pulls_url":"https://api.github.com/repos/pandas-dev/pandas/pulls{/number}","milestones_url":"https://api.github.com/repos/pandas-dev/pandas/milestones{/number}","notifications_url":"https://api.github.com/repos/pandas-dev/pandas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pandas-dev/pandas/labels{/name}","releases_url":"https://api.github.com/repos/pandas-dev/pandas/releases{/id}","deployments_url":"https://api.github.com/repos/pandas-dev/pandas/deployments","created_at":"2010-08-24T01:37:33Z","updated_at":"2017-12-20T14:19:42Z","pushed_at":"2017-12-20T18:35:50Z","git_url":"git://github.com/pandas-dev/pandas.git","ssh_url":"git@github.com:pandas-dev/pandas.git","clone_url":"https://github.com/pandas-dev/pandas.git","svn_url":"https://github.com/pandas-dev/pandas","homepage":"http://pandas.pydata.org","size":111882,"stargazers_count":12110,"watchers_count":12110,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4739,"mirror_url":null,"archived":false,"open_issues_count":2259,"license":{"key":"bsd-3-clause","name":"BSD 3-clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":4739,"open_issues":2259,"watchers":12110,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17746"},"html":{"href":"https://github.com/pandas-dev/pandas/pull/17746"},"issue":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/17746"},"comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/issues/17746/comments"},"review_comments":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17746/comments"},"review_comment":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pandas-dev/pandas/pulls/17746/commits"},"statuses":{"href":"https://api.github.com/repos/pandas-dev/pandas/statuses/02e32174140e596a3d12272dc8488b07bf6ef464"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jbrockmendel"}}