{"action":"created","comment":{"url":"https://api.github.com/repos/CDRH/data/pulls/comments/142464123","pull_request_review_id":66829212,"id":142464123,"diff_hunk":"@@ -120,8 +120,10 @@ def publisher\n     get_list(@xpaths[\"publisher\"])\n   end\n \n-  def recipients\n-    # TODO default behavior?\n+  def recipient\n+    eles = @xml.xpath(@xpaths[\"recipient\"])\n+    people = eles.map { |p| { \"role\" => p[\"role\"], \"name\" => p.text, \"id\" => \"\" } }","path":"scripts/ruby/lib/to_es/vra_to_es/fields.rb","position":8,"original_position":8,"commit_id":"1a24c491f087805f929a053d91af55c8400d2183","original_commit_id":"179e59fb5405832c82086e7c1f474fce9ccb24b7","user":{"login":"jduss4","id":2480492,"avatar_url":"https://avatars3.githubusercontent.com/u/2480492?v=4","gravatar_id":"","url":"https://api.github.com/users/jduss4","html_url":"https://github.com/jduss4","followers_url":"https://api.github.com/users/jduss4/followers","following_url":"https://api.github.com/users/jduss4/following{/other_user}","gists_url":"https://api.github.com/users/jduss4/gists{/gist_id}","starred_url":"https://api.github.com/users/jduss4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jduss4/subscriptions","organizations_url":"https://api.github.com/users/jduss4/orgs","repos_url":"https://api.github.com/users/jduss4/repos","events_url":"https://api.github.com/users/jduss4/events{/privacy}","received_events_url":"https://api.github.com/users/jduss4/received_events","type":"User","site_admin":false},"body":"We're gonna need to change like all of my code if we're taking out explicit returns...","created_at":"2017-10-03T17:13:04Z","updated_at":"2017-10-03T17:13:04Z","html_url":"https://github.com/CDRH/data/pull/86#discussion_r142464123","pull_request_url":"https://api.github.com/repos/CDRH/data/pulls/86","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CDRH/data/pulls/comments/142464123"},"html":{"href":"https://github.com/CDRH/data/pull/86#discussion_r142464123"},"pull_request":{"href":"https://api.github.com/repos/CDRH/data/pulls/86"}},"in_reply_to_id":142443324},"pull_request":{"url":"https://api.github.com/repos/CDRH/data/pulls/86","id":144276449,"html_url":"https://github.com/CDRH/data/pull/86","diff_url":"https://github.com/CDRH/data/pull/86.diff","patch_url":"https://github.com/CDRH/data/pull/86.patch","issue_url":"https://api.github.com/repos/CDRH/data/issues/86","number":86,"state":"open","locked":false,"title":"Recipient default behavior and bugfix","user":{"login":"jduss4","id":2480492,"avatar_url":"https://avatars3.githubusercontent.com/u/2480492?v=4","gravatar_id":"","url":"https://api.github.com/users/jduss4","html_url":"https://github.com/jduss4","followers_url":"https://api.github.com/users/jduss4/followers","following_url":"https://api.github.com/users/jduss4/following{/other_user}","gists_url":"https://api.github.com/users/jduss4/gists{/gist_id}","starred_url":"https://api.github.com/users/jduss4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jduss4/subscriptions","organizations_url":"https://api.github.com/users/jduss4/orgs","repos_url":"https://api.github.com/users/jduss4/repos","events_url":"https://api.github.com/users/jduss4/events{/privacy}","received_events_url":"https://api.github.com/users/jduss4/received_events","type":"User","site_admin":false},"body":"I suspect that the VRA in particular will need updated default behavior\r\nbut in both cases I tried to model the current \"person\" field as an example\r\n\r\nAlso found a bug where a helper was altering the xml object being used all over\r\nwhich hadn't yet caused a problem, but which became apparently when I was\r\ntrying to manipulate the XML for the `transcription_t` field","created_at":"2017-10-02T20:31:31Z","updated_at":"2017-10-03T17:13:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7491d78e2dccbf3693c81f24250afec9991aa609","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/CDRH/data/pulls/86/commits","review_comments_url":"https://api.github.com/repos/CDRH/data/pulls/86/comments","review_comment_url":"https://api.github.com/repos/CDRH/data/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CDRH/data/issues/86/comments","statuses_url":"https://api.github.com/repos/CDRH/data/statuses/1a24c491f087805f929a053d91af55c8400d2183","head":{"label":"CDRH:recipient_default","ref":"recipient_default","sha":"1a24c491f087805f929a053d91af55c8400d2183","user":{"login":"CDRH","id":1234340,"avatar_url":"https://avatars2.githubusercontent.com/u/1234340?v=4","gravatar_id":"","url":"https://api.github.com/users/CDRH","html_url":"https://github.com/CDRH","followers_url":"https://api.github.com/users/CDRH/followers","following_url":"https://api.github.com/users/CDRH/following{/other_user}","gists_url":"https://api.github.com/users/CDRH/gists{/gist_id}","starred_url":"https://api.github.com/users/CDRH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDRH/subscriptions","organizations_url":"https://api.github.com/users/CDRH/orgs","repos_url":"https://api.github.com/users/CDRH/repos","events_url":"https://api.github.com/users/CDRH/events{/privacy}","received_events_url":"https://api.github.com/users/CDRH/received_events","type":"Organization","site_admin":false},"repo":{"id":30602927,"name":"data","full_name":"CDRH/data","owner":{"login":"CDRH","id":1234340,"avatar_url":"https://avatars2.githubusercontent.com/u/1234340?v=4","gravatar_id":"","url":"https://api.github.com/users/CDRH","html_url":"https://github.com/CDRH","followers_url":"https://api.github.com/users/CDRH/followers","following_url":"https://api.github.com/users/CDRH/following{/other_user}","gists_url":"https://api.github.com/users/CDRH/gists{/gist_id}","starred_url":"https://api.github.com/users/CDRH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDRH/subscriptions","organizations_url":"https://api.github.com/users/CDRH/orgs","repos_url":"https://api.github.com/users/CDRH/repos","events_url":"https://api.github.com/users/CDRH/events{/privacy}","received_events_url":"https://api.github.com/users/CDRH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CDRH/data","description":"A central repository for CDRH data","fork":false,"url":"https://api.github.com/repos/CDRH/data","forks_url":"https://api.github.com/repos/CDRH/data/forks","keys_url":"https://api.github.com/repos/CDRH/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CDRH/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CDRH/data/teams","hooks_url":"https://api.github.com/repos/CDRH/data/hooks","issue_events_url":"https://api.github.com/repos/CDRH/data/issues/events{/number}","events_url":"https://api.github.com/repos/CDRH/data/events","assignees_url":"https://api.github.com/repos/CDRH/data/assignees{/user}","branches_url":"https://api.github.com/repos/CDRH/data/branches{/branch}","tags_url":"https://api.github.com/repos/CDRH/data/tags","blobs_url":"https://api.github.com/repos/CDRH/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CDRH/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CDRH/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/CDRH/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CDRH/data/statuses/{sha}","languages_url":"https://api.github.com/repos/CDRH/data/languages","stargazers_url":"https://api.github.com/repos/CDRH/data/stargazers","contributors_url":"https://api.github.com/repos/CDRH/data/contributors","subscribers_url":"https://api.github.com/repos/CDRH/data/subscribers","subscription_url":"https://api.github.com/repos/CDRH/data/subscription","commits_url":"https://api.github.com/repos/CDRH/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/CDRH/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/CDRH/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/CDRH/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/CDRH/data/contents/{+path}","compare_url":"https://api.github.com/repos/CDRH/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CDRH/data/merges","archive_url":"https://api.github.com/repos/CDRH/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CDRH/data/downloads","issues_url":"https://api.github.com/repos/CDRH/data/issues{/number}","pulls_url":"https://api.github.com/repos/CDRH/data/pulls{/number}","milestones_url":"https://api.github.com/repos/CDRH/data/milestones{/number}","notifications_url":"https://api.github.com/repos/CDRH/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CDRH/data/labels{/name}","releases_url":"https://api.github.com/repos/CDRH/data/releases{/id}","deployments_url":"https://api.github.com/repos/CDRH/data/deployments","created_at":"2015-02-10T16:57:46Z","updated_at":"2017-02-14T16:08:10Z","pushed_at":"2017-10-02T20:31:33Z","git_url":"git://github.com/CDRH/data.git","ssh_url":"git@github.com:CDRH/data.git","clone_url":"https://github.com/CDRH/data.git","svn_url":"https://github.com/CDRH/data","homepage":null,"size":60688,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":0,"default_branch":"master"}},"base":{"label":"CDRH:master","ref":"master","sha":"2d48fbdc7ee1e0471dffc43b34dba49c8d5c7a85","user":{"login":"CDRH","id":1234340,"avatar_url":"https://avatars2.githubusercontent.com/u/1234340?v=4","gravatar_id":"","url":"https://api.github.com/users/CDRH","html_url":"https://github.com/CDRH","followers_url":"https://api.github.com/users/CDRH/followers","following_url":"https://api.github.com/users/CDRH/following{/other_user}","gists_url":"https://api.github.com/users/CDRH/gists{/gist_id}","starred_url":"https://api.github.com/users/CDRH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDRH/subscriptions","organizations_url":"https://api.github.com/users/CDRH/orgs","repos_url":"https://api.github.com/users/CDRH/repos","events_url":"https://api.github.com/users/CDRH/events{/privacy}","received_events_url":"https://api.github.com/users/CDRH/received_events","type":"Organization","site_admin":false},"repo":{"id":30602927,"name":"data","full_name":"CDRH/data","owner":{"login":"CDRH","id":1234340,"avatar_url":"https://avatars2.githubusercontent.com/u/1234340?v=4","gravatar_id":"","url":"https://api.github.com/users/CDRH","html_url":"https://github.com/CDRH","followers_url":"https://api.github.com/users/CDRH/followers","following_url":"https://api.github.com/users/CDRH/following{/other_user}","gists_url":"https://api.github.com/users/CDRH/gists{/gist_id}","starred_url":"https://api.github.com/users/CDRH/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CDRH/subscriptions","organizations_url":"https://api.github.com/users/CDRH/orgs","repos_url":"https://api.github.com/users/CDRH/repos","events_url":"https://api.github.com/users/CDRH/events{/privacy}","received_events_url":"https://api.github.com/users/CDRH/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CDRH/data","description":"A central repository for CDRH data","fork":false,"url":"https://api.github.com/repos/CDRH/data","forks_url":"https://api.github.com/repos/CDRH/data/forks","keys_url":"https://api.github.com/repos/CDRH/data/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CDRH/data/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CDRH/data/teams","hooks_url":"https://api.github.com/repos/CDRH/data/hooks","issue_events_url":"https://api.github.com/repos/CDRH/data/issues/events{/number}","events_url":"https://api.github.com/repos/CDRH/data/events","assignees_url":"https://api.github.com/repos/CDRH/data/assignees{/user}","branches_url":"https://api.github.com/repos/CDRH/data/branches{/branch}","tags_url":"https://api.github.com/repos/CDRH/data/tags","blobs_url":"https://api.github.com/repos/CDRH/data/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CDRH/data/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CDRH/data/git/refs{/sha}","trees_url":"https://api.github.com/repos/CDRH/data/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CDRH/data/statuses/{sha}","languages_url":"https://api.github.com/repos/CDRH/data/languages","stargazers_url":"https://api.github.com/repos/CDRH/data/stargazers","contributors_url":"https://api.github.com/repos/CDRH/data/contributors","subscribers_url":"https://api.github.com/repos/CDRH/data/subscribers","subscription_url":"https://api.github.com/repos/CDRH/data/subscription","commits_url":"https://api.github.com/repos/CDRH/data/commits{/sha}","git_commits_url":"https://api.github.com/repos/CDRH/data/git/commits{/sha}","comments_url":"https://api.github.com/repos/CDRH/data/comments{/number}","issue_comment_url":"https://api.github.com/repos/CDRH/data/issues/comments{/number}","contents_url":"https://api.github.com/repos/CDRH/data/contents/{+path}","compare_url":"https://api.github.com/repos/CDRH/data/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CDRH/data/merges","archive_url":"https://api.github.com/repos/CDRH/data/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CDRH/data/downloads","issues_url":"https://api.github.com/repos/CDRH/data/issues{/number}","pulls_url":"https://api.github.com/repos/CDRH/data/pulls{/number}","milestones_url":"https://api.github.com/repos/CDRH/data/milestones{/number}","notifications_url":"https://api.github.com/repos/CDRH/data/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CDRH/data/labels{/name}","releases_url":"https://api.github.com/repos/CDRH/data/releases{/id}","deployments_url":"https://api.github.com/repos/CDRH/data/deployments","created_at":"2015-02-10T16:57:46Z","updated_at":"2017-02-14T16:08:10Z","pushed_at":"2017-10-02T20:31:33Z","git_url":"git://github.com/CDRH/data.git","ssh_url":"git@github.com:CDRH/data.git","clone_url":"https://github.com/CDRH/data.git","svn_url":"https://github.com/CDRH/data","homepage":null,"size":60688,"stargazers_count":0,"watchers_count":0,"language":"XSLT","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":10,"forks":2,"open_issues":10,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CDRH/data/pulls/86"},"html":{"href":"https://github.com/CDRH/data/pull/86"},"issue":{"href":"https://api.github.com/repos/CDRH/data/issues/86"},"comments":{"href":"https://api.github.com/repos/CDRH/data/issues/86/comments"},"review_comments":{"href":"https://api.github.com/repos/CDRH/data/pulls/86/comments"},"review_comment":{"href":"https://api.github.com/repos/CDRH/data/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CDRH/data/pulls/86/commits"},"statuses":{"href":"https://api.github.com/repos/CDRH/data/statuses/1a24c491f087805f929a053d91af55c8400d2183"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jduss4"}}