{"action":"opened","number":13,"pull_request":{"url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls/13","id":128715938,"html_url":"https://github.com/rmarscher/virtual-module-webpack-plugin/pull/13","diff_url":"https://github.com/rmarscher/virtual-module-webpack-plugin/pull/13.diff","patch_url":"https://github.com/rmarscher/virtual-module-webpack-plugin/pull/13.patch","issue_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/issues/13","number":13,"state":"open","locked":false,"title":"Fix resolver returning undefined arguments to cb()","user":{"login":"MrHayato","id":600962,"avatar_url":"https://avatars1.githubusercontent.com/u/600962?v=3","gravatar_id":"","url":"https://api.github.com/users/MrHayato","html_url":"https://github.com/MrHayato","followers_url":"https://api.github.com/users/MrHayato/followers","following_url":"https://api.github.com/users/MrHayato/following{/other_user}","gists_url":"https://api.github.com/users/MrHayato/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHayato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHayato/subscriptions","organizations_url":"https://api.github.com/users/MrHayato/orgs","repos_url":"https://api.github.com/users/MrHayato/repos","events_url":"https://api.github.com/users/MrHayato/events{/privacy}","received_events_url":"https://api.github.com/users/MrHayato/received_events","type":"User","site_admin":false},"body":"Currently, when resolving the `resolved` promise, the `argument`s passed to `cb` contains an argument with `undefined` as the first argument, like so:\r\n\r\n![image](https://user-images.githubusercontent.com/600962/27812533-794c8cea-6024-11e7-93df-dadb4b7c827d.png)\r\n\r\nThis causes an issue with the enhanced-resolver in webpack. Particularly this line here: https://github.com/webpack/enhanced-resolve/blob/master/lib/Resolver.js#L128\r\n\r\nBecause arguments.length is > 0, this causes the callback to be called, instead of the `resolver.applyPluginsAsyncSeriesBailResult1` being called, which means `after-resolve` never gets called in the plugin chain, causing other things in webpack to break.\r\n\r\nThis fix just makes sure cb() gets called with no arguments.","created_at":"2017-07-04T02:35:00Z","updated_at":"2017-07-04T02:35:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls/13/commits","review_comments_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls/13/comments","review_comment_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/issues/13/comments","statuses_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/statuses/091427505664dd3f220b6d8506e22ef1f6acb1d4","head":{"label":"MrHayato:callbacks-without-undefined-args","ref":"callbacks-without-undefined-args","sha":"091427505664dd3f220b6d8506e22ef1f6acb1d4","user":{"login":"MrHayato","id":600962,"avatar_url":"https://avatars1.githubusercontent.com/u/600962?v=3","gravatar_id":"","url":"https://api.github.com/users/MrHayato","html_url":"https://github.com/MrHayato","followers_url":"https://api.github.com/users/MrHayato/followers","following_url":"https://api.github.com/users/MrHayato/following{/other_user}","gists_url":"https://api.github.com/users/MrHayato/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHayato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHayato/subscriptions","organizations_url":"https://api.github.com/users/MrHayato/orgs","repos_url":"https://api.github.com/users/MrHayato/repos","events_url":"https://api.github.com/users/MrHayato/events{/privacy}","received_events_url":"https://api.github.com/users/MrHayato/received_events","type":"User","site_admin":false},"repo":{"id":96163829,"name":"virtual-module-webpack-plugin","full_name":"MrHayato/virtual-module-webpack-plugin","owner":{"login":"MrHayato","id":600962,"avatar_url":"https://avatars1.githubusercontent.com/u/600962?v=3","gravatar_id":"","url":"https://api.github.com/users/MrHayato","html_url":"https://github.com/MrHayato","followers_url":"https://api.github.com/users/MrHayato/followers","following_url":"https://api.github.com/users/MrHayato/following{/other_user}","gists_url":"https://api.github.com/users/MrHayato/gists{/gist_id}","starred_url":"https://api.github.com/users/MrHayato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrHayato/subscriptions","organizations_url":"https://api.github.com/users/MrHayato/orgs","repos_url":"https://api.github.com/users/MrHayato/repos","events_url":"https://api.github.com/users/MrHayato/events{/privacy}","received_events_url":"https://api.github.com/users/MrHayato/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrHayato/virtual-module-webpack-plugin","description":"Adds the contents of a virtual file to webpack's cached file system without writing it to disk","fork":true,"url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin","forks_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/forks","keys_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/events","assignees_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/merges","archive_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/MrHayato/virtual-module-webpack-plugin/deployments","created_at":"2017-07-04T01:38:12Z","updated_at":"2017-07-04T01:38:13Z","pushed_at":"2017-07-04T01:40:14Z","git_url":"git://github.com/MrHayato/virtual-module-webpack-plugin.git","ssh_url":"git@github.com:MrHayato/virtual-module-webpack-plugin.git","clone_url":"https://github.com/MrHayato/virtual-module-webpack-plugin.git","svn_url":"https://github.com/MrHayato/virtual-module-webpack-plugin","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rmarscher:master","ref":"master","sha":"1e03eb40c8e8e843b98ba9948f4eeda50de99de3","user":{"login":"rmarscher","id":352937,"avatar_url":"https://avatars0.githubusercontent.com/u/352937?v=3","gravatar_id":"","url":"https://api.github.com/users/rmarscher","html_url":"https://github.com/rmarscher","followers_url":"https://api.github.com/users/rmarscher/followers","following_url":"https://api.github.com/users/rmarscher/following{/other_user}","gists_url":"https://api.github.com/users/rmarscher/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarscher/subscriptions","organizations_url":"https://api.github.com/users/rmarscher/orgs","repos_url":"https://api.github.com/users/rmarscher/repos","events_url":"https://api.github.com/users/rmarscher/events{/privacy}","received_events_url":"https://api.github.com/users/rmarscher/received_events","type":"User","site_admin":false},"repo":{"id":54988726,"name":"virtual-module-webpack-plugin","full_name":"rmarscher/virtual-module-webpack-plugin","owner":{"login":"rmarscher","id":352937,"avatar_url":"https://avatars0.githubusercontent.com/u/352937?v=3","gravatar_id":"","url":"https://api.github.com/users/rmarscher","html_url":"https://github.com/rmarscher","followers_url":"https://api.github.com/users/rmarscher/followers","following_url":"https://api.github.com/users/rmarscher/following{/other_user}","gists_url":"https://api.github.com/users/rmarscher/gists{/gist_id}","starred_url":"https://api.github.com/users/rmarscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmarscher/subscriptions","organizations_url":"https://api.github.com/users/rmarscher/orgs","repos_url":"https://api.github.com/users/rmarscher/repos","events_url":"https://api.github.com/users/rmarscher/events{/privacy}","received_events_url":"https://api.github.com/users/rmarscher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rmarscher/virtual-module-webpack-plugin","description":"Adds the contents of a virtual file to webpack's cached file system without writing it to disk","fork":false,"url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin","forks_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/forks","keys_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/teams","hooks_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/hooks","issue_events_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/issues/events{/number}","events_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/events","assignees_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/assignees{/user}","branches_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/branches{/branch}","tags_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/tags","blobs_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/git/refs{/sha}","trees_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/statuses/{sha}","languages_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/languages","stargazers_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/stargazers","contributors_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/contributors","subscribers_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/subscribers","subscription_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/subscription","commits_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/commits{/sha}","git_commits_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/git/commits{/sha}","comments_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/comments{/number}","issue_comment_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/issues/comments{/number}","contents_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/contents/{+path}","compare_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/merges","archive_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/downloads","issues_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/issues{/number}","pulls_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls{/number}","milestones_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/milestones{/number}","notifications_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/labels{/name}","releases_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/releases{/id}","deployments_url":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/deployments","created_at":"2016-03-29T15:44:42Z","updated_at":"2017-06-30T21:51:12Z","pushed_at":"2017-06-12T18:19:01Z","git_url":"git://github.com/rmarscher/virtual-module-webpack-plugin.git","ssh_url":"git@github.com:rmarscher/virtual-module-webpack-plugin.git","clone_url":"https://github.com/rmarscher/virtual-module-webpack-plugin.git","svn_url":"https://github.com/rmarscher/virtual-module-webpack-plugin","homepage":null,"size":137,"stargazers_count":36,"watchers_count":36,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":2,"forks":9,"open_issues":2,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls/13"},"html":{"href":"https://github.com/rmarscher/virtual-module-webpack-plugin/pull/13"},"issue":{"href":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/issues/13"},"comments":{"href":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/rmarscher/virtual-module-webpack-plugin/statuses/091427505664dd3f220b6d8506e22ef1f6acb1d4"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"MrHayato"}}