{"action":"created","issue":{"url":"https://api.github.com/repos/lxc/lxd/issues/2961","repository_url":"https://api.github.com/repos/lxc/lxd","labels_url":"https://api.github.com/repos/lxc/lxd/issues/2961/labels{/name}","comments_url":"https://api.github.com/repos/lxc/lxd/issues/2961/comments","events_url":"https://api.github.com/repos/lxc/lxd/issues/2961/events","html_url":"https://github.com/lxc/lxd/pull/2961","id":210359869,"number":2961,"title":"storage: remove pool property on pool delete","user":{"login":"brauner","id":7353573,"avatar_url":"https://avatars.githubusercontent.com/u/7353573?v=3","gravatar_id":"","url":"https://api.github.com/users/brauner","html_url":"https://github.com/brauner","followers_url":"https://api.github.com/users/brauner/followers","following_url":"https://api.github.com/users/brauner/following{/other_user}","gists_url":"https://api.github.com/users/brauner/gists{/gist_id}","starred_url":"https://api.github.com/users/brauner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brauner/subscriptions","organizations_url":"https://api.github.com/users/brauner/orgs","repos_url":"https://api.github.com/users/brauner/repos","events_url":"https://api.github.com/users/brauner/events{/privacy}","received_events_url":"https://api.github.com/users/brauner/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-02-26T23:50:11Z","updated_at":"2017-02-27T00:57:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/lxc/lxd/pulls/2961","html_url":"https://github.com/lxc/lxd/pull/2961","diff_url":"https://github.com/lxc/lxd/pull/2961.diff","patch_url":"https://github.com/lxc/lxd/pull/2961.patch"},"body":"So this may be somewhat debatable. One could make a reasonable argument that we simply leave the profile devices that have a pool property set alone and simply let users figure this out. However, I feel that this might be a problem. Consider the case where a user has a profile that has a disk device entry like:\r\n\r\n```\r\nsensitive-device:\r\n  path: /opt\r\n  source: sensitive-vol1\r\n  pool: pool1\r\n```\r\n\r\nand the user deletes the volume and the pool but we leave the properties set in the device. Now the user creates a new pool of the same name and a new volume of the same name that contains sensitive data and creates a container on the profile that still contains this device. This could potentially be a problem. So wipe the pool property on pool delete. For disk devices outside of LXD's storage management abilities (host paths etc.) we can't do this. But for pools and volumes we created we should probably do this. "},"comment":{"url":"https://api.github.com/repos/lxc/lxd/issues/comments/282604279","html_url":"https://github.com/lxc/lxd/pull/2961#issuecomment-282604279","issue_url":"https://api.github.com/repos/lxc/lxd/issues/2961","id":282604279,"user":{"login":"stgraber","id":2230599,"avatar_url":"https://avatars.githubusercontent.com/u/2230599?v=3","gravatar_id":"","url":"https://api.github.com/users/stgraber","html_url":"https://github.com/stgraber","followers_url":"https://api.github.com/users/stgraber/followers","following_url":"https://api.github.com/users/stgraber/following{/other_user}","gists_url":"https://api.github.com/users/stgraber/gists{/gist_id}","starred_url":"https://api.github.com/users/stgraber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stgraber/subscriptions","organizations_url":"https://api.github.com/users/stgraber/orgs","repos_url":"https://api.github.com/users/stgraber/repos","events_url":"https://api.github.com/users/stgraber/events{/privacy}","received_events_url":"https://api.github.com/users/stgraber/received_events","type":"User","site_admin":false},"created_at":"2017-02-27T00:57:56Z","updated_at":"2017-02-27T00:57:56Z","body":"brauner: Yep, would be useful to have in the error message or at least have them listed in UsedBy."}}
{"actor":{"display_login":"stgraber"}}