{"action":"created","comment":{"url":"https://api.github.com/repos/rook/rook/pulls/comments/137856849","pull_request_review_id":61583580,"id":137856849,"diff_hunk":"@@ -0,0 +1,62 @@\n+/*\n+Copyright 2017 The Rook Authors. All rights reserved.\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+\thttp://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package cmd\n+\n+import (\n+\t\"fmt\"\n+\t\"os\"\n+\t\"os/exec\"\n+\n+\t\"github.com/rook/rook/pkg/util/sys\"\n+\t\"github.com/spf13/cobra\"\n+)\n+\n+var (\n+\tinitCmd = &cobra.Command{\n+\t\tUse:   \"init\",\n+\t\tShort: \"Initialize the volume plugin\",\n+\t\tRunE:  initPlugin,\n+\t}\n+)\n+\n+func init() {\n+\tRootCmd.AddCommand(initCmd)\n+}\n+\n+func initPlugin(cmd *cobra.Command, args []string) error {\n+\n+\tmoduleName := \"rbd\"","path":"cmd/flexvolume/cmd/init.go","position":42,"original_position":42,"commit_id":"3e434955915317b0c3dbef5d7ac58fb7c1c15b25","original_commit_id":"3e434955915317b0c3dbef5d7ac58fb7c1c15b25","user":{"login":"galexrt","id":3718398,"avatar_url":"https://avatars1.githubusercontent.com/u/3718398?v=4","gravatar_id":"","url":"https://api.github.com/users/galexrt","html_url":"https://github.com/galexrt","followers_url":"https://api.github.com/users/galexrt/followers","following_url":"https://api.github.com/users/galexrt/following{/other_user}","gists_url":"https://api.github.com/users/galexrt/gists{/gist_id}","starred_url":"https://api.github.com/users/galexrt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galexrt/subscriptions","organizations_url":"https://api.github.com/users/galexrt/orgs","repos_url":"https://api.github.com/users/galexrt/repos","events_url":"https://api.github.com/users/galexrt/events{/privacy}","received_events_url":"https://api.github.com/users/galexrt/received_events","type":"User","site_admin":false},"body":"I would make a const out of `moduleName` even if it is just used here.","created_at":"2017-09-08T18:18:17Z","updated_at":"2017-09-08T18:29:04Z","html_url":"https://github.com/rook/rook/pull/882#discussion_r137856849","pull_request_url":"https://api.github.com/repos/rook/rook/pulls/882","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/comments/137856849"},"html":{"href":"https://github.com/rook/rook/pull/882#discussion_r137856849"},"pull_request":{"href":"https://api.github.com/repos/rook/rook/pulls/882"}}},"pull_request":{"url":"https://api.github.com/repos/rook/rook/pulls/882","id":134545890,"html_url":"https://github.com/rook/rook/pull/882","diff_url":"https://github.com/rook/rook/pull/882.diff","patch_url":"https://github.com/rook/rook/pull/882.patch","issue_url":"https://api.github.com/repos/rook/rook/issues/882","number":882,"state":"open","locked":false,"title":"WIP: Rook flex volume","user":{"login":"kokhang","id":1672672,"avatar_url":"https://avatars2.githubusercontent.com/u/1672672?v=4","gravatar_id":"","url":"https://api.github.com/users/kokhang","html_url":"https://github.com/kokhang","followers_url":"https://api.github.com/users/kokhang/followers","following_url":"https://api.github.com/users/kokhang/following{/other_user}","gists_url":"https://api.github.com/users/kokhang/gists{/gist_id}","starred_url":"https://api.github.com/users/kokhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokhang/subscriptions","organizations_url":"https://api.github.com/users/kokhang/orgs","repos_url":"https://api.github.com/users/kokhang/repos","events_url":"https://api.github.com/users/kokhang/events{/privacy}","received_events_url":"https://api.github.com/users/kokhang/received_events","type":"User","site_admin":false},"body":"Rook plugin for Kubernetes implemented as flexvolume\r\n- Operator is deployed under namespace rook-system\r\n- Operator deploys rook-agent on all nodes as daemonset also on rook-system\r\n- Rook-agent installs flexvolume driver on hosts\r\n- Rook-agent listens on unix socket for driver requests\r\n- Rook-agent perform attach/detach on its node\r\n- Rook-agent creates/delete CRD volumeattach objects\r\n\r\nfixes #432 ","created_at":"2017-08-07T23:15:49Z","updated_at":"2017-09-08T18:33:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb6fa583073987b8c4eecbe680a32aa58b99e364","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rook/rook/pulls/882/commits","review_comments_url":"https://api.github.com/repos/rook/rook/pulls/882/comments","review_comment_url":"https://api.github.com/repos/rook/rook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rook/rook/issues/882/comments","statuses_url":"https://api.github.com/repos/rook/rook/statuses/3e434955915317b0c3dbef5d7ac58fb7c1c15b25","head":{"label":"kokhang:rook-flex","ref":"rook-flex","sha":"3e434955915317b0c3dbef5d7ac58fb7c1c15b25","user":{"login":"kokhang","id":1672672,"avatar_url":"https://avatars2.githubusercontent.com/u/1672672?v=4","gravatar_id":"","url":"https://api.github.com/users/kokhang","html_url":"https://github.com/kokhang","followers_url":"https://api.github.com/users/kokhang/followers","following_url":"https://api.github.com/users/kokhang/following{/other_user}","gists_url":"https://api.github.com/users/kokhang/gists{/gist_id}","starred_url":"https://api.github.com/users/kokhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokhang/subscriptions","organizations_url":"https://api.github.com/users/kokhang/orgs","repos_url":"https://api.github.com/users/kokhang/repos","events_url":"https://api.github.com/users/kokhang/events{/privacy}","received_events_url":"https://api.github.com/users/kokhang/received_events","type":"User","site_admin":false},"repo":{"id":81874235,"name":"rook","full_name":"kokhang/rook","owner":{"login":"kokhang","id":1672672,"avatar_url":"https://avatars2.githubusercontent.com/u/1672672?v=4","gravatar_id":"","url":"https://api.github.com/users/kokhang","html_url":"https://github.com/kokhang","followers_url":"https://api.github.com/users/kokhang/followers","following_url":"https://api.github.com/users/kokhang/following{/other_user}","gists_url":"https://api.github.com/users/kokhang/gists{/gist_id}","starred_url":"https://api.github.com/users/kokhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kokhang/subscriptions","organizations_url":"https://api.github.com/users/kokhang/orgs","repos_url":"https://api.github.com/users/kokhang/repos","events_url":"https://api.github.com/users/kokhang/events{/privacy}","received_events_url":"https://api.github.com/users/kokhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kokhang/rook","description":"Open, Cloud Native, and Universal Distributed Storage","fork":true,"url":"https://api.github.com/repos/kokhang/rook","forks_url":"https://api.github.com/repos/kokhang/rook/forks","keys_url":"https://api.github.com/repos/kokhang/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kokhang/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kokhang/rook/teams","hooks_url":"https://api.github.com/repos/kokhang/rook/hooks","issue_events_url":"https://api.github.com/repos/kokhang/rook/issues/events{/number}","events_url":"https://api.github.com/repos/kokhang/rook/events","assignees_url":"https://api.github.com/repos/kokhang/rook/assignees{/user}","branches_url":"https://api.github.com/repos/kokhang/rook/branches{/branch}","tags_url":"https://api.github.com/repos/kokhang/rook/tags","blobs_url":"https://api.github.com/repos/kokhang/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kokhang/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kokhang/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/kokhang/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kokhang/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/kokhang/rook/languages","stargazers_url":"https://api.github.com/repos/kokhang/rook/stargazers","contributors_url":"https://api.github.com/repos/kokhang/rook/contributors","subscribers_url":"https://api.github.com/repos/kokhang/rook/subscribers","subscription_url":"https://api.github.com/repos/kokhang/rook/subscription","commits_url":"https://api.github.com/repos/kokhang/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/kokhang/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/kokhang/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/kokhang/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/kokhang/rook/contents/{+path}","compare_url":"https://api.github.com/repos/kokhang/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kokhang/rook/merges","archive_url":"https://api.github.com/repos/kokhang/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kokhang/rook/downloads","issues_url":"https://api.github.com/repos/kokhang/rook/issues{/number}","pulls_url":"https://api.github.com/repos/kokhang/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/kokhang/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/kokhang/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kokhang/rook/labels{/name}","releases_url":"https://api.github.com/repos/kokhang/rook/releases{/id}","deployments_url":"https://api.github.com/repos/kokhang/rook/deployments","created_at":"2017-02-13T21:34:07Z","updated_at":"2017-02-13T21:34:10Z","pushed_at":"2017-09-08T00:00:54Z","git_url":"git://github.com/kokhang/rook.git","ssh_url":"git@github.com:kokhang/rook.git","clone_url":"https://github.com/kokhang/rook.git","svn_url":"https://github.com/kokhang/rook","homepage":"https://rook.io","size":2793,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rook:master","ref":"master","sha":"70162f3273bc4db060357fef1adf0cebaa0a90d2","user":{"login":"rook","id":22860722,"avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"repo":{"id":62921553,"name":"rook","full_name":"rook/rook","owner":{"login":"rook","id":22860722,"avatar_url":"https://avatars1.githubusercontent.com/u/22860722?v=4","gravatar_id":"","url":"https://api.github.com/users/rook","html_url":"https://github.com/rook","followers_url":"https://api.github.com/users/rook/followers","following_url":"https://api.github.com/users/rook/following{/other_user}","gists_url":"https://api.github.com/users/rook/gists{/gist_id}","starred_url":"https://api.github.com/users/rook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rook/subscriptions","organizations_url":"https://api.github.com/users/rook/orgs","repos_url":"https://api.github.com/users/rook/repos","events_url":"https://api.github.com/users/rook/events{/privacy}","received_events_url":"https://api.github.com/users/rook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rook/rook","description":"File, Block, and Object Storage Services for your Cloud-Native Environment","fork":false,"url":"https://api.github.com/repos/rook/rook","forks_url":"https://api.github.com/repos/rook/rook/forks","keys_url":"https://api.github.com/repos/rook/rook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rook/rook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rook/rook/teams","hooks_url":"https://api.github.com/repos/rook/rook/hooks","issue_events_url":"https://api.github.com/repos/rook/rook/issues/events{/number}","events_url":"https://api.github.com/repos/rook/rook/events","assignees_url":"https://api.github.com/repos/rook/rook/assignees{/user}","branches_url":"https://api.github.com/repos/rook/rook/branches{/branch}","tags_url":"https://api.github.com/repos/rook/rook/tags","blobs_url":"https://api.github.com/repos/rook/rook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rook/rook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rook/rook/git/refs{/sha}","trees_url":"https://api.github.com/repos/rook/rook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rook/rook/statuses/{sha}","languages_url":"https://api.github.com/repos/rook/rook/languages","stargazers_url":"https://api.github.com/repos/rook/rook/stargazers","contributors_url":"https://api.github.com/repos/rook/rook/contributors","subscribers_url":"https://api.github.com/repos/rook/rook/subscribers","subscription_url":"https://api.github.com/repos/rook/rook/subscription","commits_url":"https://api.github.com/repos/rook/rook/commits{/sha}","git_commits_url":"https://api.github.com/repos/rook/rook/git/commits{/sha}","comments_url":"https://api.github.com/repos/rook/rook/comments{/number}","issue_comment_url":"https://api.github.com/repos/rook/rook/issues/comments{/number}","contents_url":"https://api.github.com/repos/rook/rook/contents/{+path}","compare_url":"https://api.github.com/repos/rook/rook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rook/rook/merges","archive_url":"https://api.github.com/repos/rook/rook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rook/rook/downloads","issues_url":"https://api.github.com/repos/rook/rook/issues{/number}","pulls_url":"https://api.github.com/repos/rook/rook/pulls{/number}","milestones_url":"https://api.github.com/repos/rook/rook/milestones{/number}","notifications_url":"https://api.github.com/repos/rook/rook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rook/rook/labels{/name}","releases_url":"https://api.github.com/repos/rook/rook/releases{/id}","deployments_url":"https://api.github.com/repos/rook/rook/deployments","created_at":"2016-07-08T22:45:05Z","updated_at":"2017-09-08T16:34:01Z","pushed_at":"2017-09-08T16:50:17Z","git_url":"git://github.com/rook/rook.git","ssh_url":"git@github.com:rook/rook.git","clone_url":"https://github.com/rook/rook.git","svn_url":"https://github.com/rook/rook","homepage":"https://rook.io","size":2744,"stargazers_count":1583,"watchers_count":1583,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":126,"mirror_url":null,"open_issues_count":156,"forks":126,"open_issues":156,"watchers":1583,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rook/rook/pulls/882"},"html":{"href":"https://github.com/rook/rook/pull/882"},"issue":{"href":"https://api.github.com/repos/rook/rook/issues/882"},"comments":{"href":"https://api.github.com/repos/rook/rook/issues/882/comments"},"review_comments":{"href":"https://api.github.com/repos/rook/rook/pulls/882/comments"},"review_comment":{"href":"https://api.github.com/repos/rook/rook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rook/rook/pulls/882/commits"},"statuses":{"href":"https://api.github.com/repos/rook/rook/statuses/3e434955915317b0c3dbef5d7ac58fb7c1c15b25"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"galexrt"}}