{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/153380358","pull_request_review_id":79375797,"id":153380358,"diff_hunk":"@@ -1977,6 +1977,45 @@ void Compiler::fgComputeLife(VARSET_TP&       life,\n     }\n }\n \n+static bool HasAnyThrowableNodes(Compiler* compiler, BasicBlock* block, jitstd::vector<GenTree*>& disabledNodes)\n+{\n+\n+    LIR::Range& blockRange  = LIR::AsRange(block);\n+    GenTree*    currentNode = blockRange.LastNode();\n+    GenTree*    endNode     = blockRange.FirstNonPhiNode()->gtPrev;\n+\n+    size_t left = disabledNodes.size();\n+\n+    while (currentNode != endNode)\n+    {\n+        for (size_t i = 0; i < disabledNodes.size(); ++i)","path":"src/jit/liveness.cpp","position":15,"original_position":15,"commit_id":"15457295f107d8a51bcb258d8a2ba38ccec83cea","original_commit_id":"15457295f107d8a51bcb258d8a2ba38ccec83cea","user":{"login":"sandreenko","id":22642771,"avatar_url":"https://avatars2.githubusercontent.com/u/22642771?v=4","gravatar_id":"","url":"https://api.github.com/users/sandreenko","html_url":"https://github.com/sandreenko","followers_url":"https://api.github.com/users/sandreenko/followers","following_url":"https://api.github.com/users/sandreenko/following{/other_user}","gists_url":"https://api.github.com/users/sandreenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sandreenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sandreenko/subscriptions","organizations_url":"https://api.github.com/users/sandreenko/orgs","repos_url":"https://api.github.com/users/sandreenko/repos","events_url":"https://api.github.com/users/sandreenko/events{/privacy}","received_events_url":"https://api.github.com/users/sandreenko/received_events","type":"User","site_admin":false},"body":"I understand that `disabledNodes.size()` is small, but I would prefer `set` or `hash map` here, but it is up to you.","created_at":"2017-11-28T02:26:46Z","updated_at":"2017-11-28T02:26:46Z","html_url":"https://github.com/dotnet/coreclr/pull/15192#discussion_r153380358","pull_request_url":"https://api.github.com/repos/dotnet/coreclr/pulls/15192","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments/153380358"},"html":{"href":"https://github.com/dotnet/coreclr/pull/15192#discussion_r153380358"},"pull_request":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/15192"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/15192","id":154289710,"html_url":"https://github.com/dotnet/coreclr/pull/15192","diff_url":"https://github.com/dotnet/coreclr/pull/15192.diff","patch_url":"https://github.com/dotnet/coreclr/pull/15192.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/15192","number":15192,"state":"open","locked":false,"title":"Fixed DCE of call nodes","user":{"login":"rartemev","id":25832893,"avatar_url":"https://avatars2.githubusercontent.com/u/25832893?v=4","gravatar_id":"","url":"https://api.github.com/users/rartemev","html_url":"https://github.com/rartemev","followers_url":"https://api.github.com/users/rartemev/followers","following_url":"https://api.github.com/users/rartemev/following{/other_user}","gists_url":"https://api.github.com/users/rartemev/gists{/gist_id}","starred_url":"https://api.github.com/users/rartemev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rartemev/subscriptions","organizations_url":"https://api.github.com/users/rartemev/orgs","repos_url":"https://api.github.com/users/rartemev/repos","events_url":"https://api.github.com/users/rartemev/events{/privacy}","received_events_url":"https://api.github.com/users/rartemev/received_events","type":"User","site_admin":false},"body":"Fixed DCE of call node which modifies stack level.\r\nThe possible situation is when there is an edge from call's block to throw helper block which depends on correct stack level. Removing call node which affects stack level we should guarantee that stack will be unwound correct.\r\n\r\nThe fix checks if there is any throwable node between eliminating call and its `PUTARG_STK` operands and set up flag whether frame pointer is required. ","created_at":"2017-11-23T02:30:33Z","updated_at":"2017-11-28T02:26:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ebd03fad8384053fb462a5e184f060cbecb5c63","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BruceForstall","id":10901265,"avatar_url":"https://avatars3.githubusercontent.com/u/10901265?v=4","gravatar_id":"","url":"https://api.github.com/users/BruceForstall","html_url":"https://github.com/BruceForstall","followers_url":"https://api.github.com/users/BruceForstall/followers","following_url":"https://api.github.com/users/BruceForstall/following{/other_user}","gists_url":"https://api.github.com/users/BruceForstall/gists{/gist_id}","starred_url":"https://api.github.com/users/BruceForstall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BruceForstall/subscriptions","organizations_url":"https://api.github.com/users/BruceForstall/orgs","repos_url":"https://api.github.com/users/BruceForstall/repos","events_url":"https://api.github.com/users/BruceForstall/events{/privacy}","received_events_url":"https://api.github.com/users/BruceForstall/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/15192/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/15192/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/15192/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/15457295f107d8a51bcb258d8a2ba38ccec83cea","head":{"label":"rartemev:superpmi_524312","ref":"superpmi_524312","sha":"15457295f107d8a51bcb258d8a2ba38ccec83cea","user":{"login":"rartemev","id":25832893,"avatar_url":"https://avatars2.githubusercontent.com/u/25832893?v=4","gravatar_id":"","url":"https://api.github.com/users/rartemev","html_url":"https://github.com/rartemev","followers_url":"https://api.github.com/users/rartemev/followers","following_url":"https://api.github.com/users/rartemev/following{/other_user}","gists_url":"https://api.github.com/users/rartemev/gists{/gist_id}","starred_url":"https://api.github.com/users/rartemev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rartemev/subscriptions","organizations_url":"https://api.github.com/users/rartemev/orgs","repos_url":"https://api.github.com/users/rartemev/repos","events_url":"https://api.github.com/users/rartemev/events{/privacy}","received_events_url":"https://api.github.com/users/rartemev/received_events","type":"User","site_admin":false},"repo":{"id":82239785,"name":"coreclr","full_name":"rartemev/coreclr","owner":{"login":"rartemev","id":25832893,"avatar_url":"https://avatars2.githubusercontent.com/u/25832893?v=4","gravatar_id":"","url":"https://api.github.com/users/rartemev","html_url":"https://github.com/rartemev","followers_url":"https://api.github.com/users/rartemev/followers","following_url":"https://api.github.com/users/rartemev/following{/other_user}","gists_url":"https://api.github.com/users/rartemev/gists{/gist_id}","starred_url":"https://api.github.com/users/rartemev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rartemev/subscriptions","organizations_url":"https://api.github.com/users/rartemev/orgs","repos_url":"https://api.github.com/users/rartemev/repos","events_url":"https://api.github.com/users/rartemev/events{/privacy}","received_events_url":"https://api.github.com/users/rartemev/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rartemev/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/rartemev/coreclr","forks_url":"https://api.github.com/repos/rartemev/coreclr/forks","keys_url":"https://api.github.com/repos/rartemev/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rartemev/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rartemev/coreclr/teams","hooks_url":"https://api.github.com/repos/rartemev/coreclr/hooks","issue_events_url":"https://api.github.com/repos/rartemev/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/rartemev/coreclr/events","assignees_url":"https://api.github.com/repos/rartemev/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/rartemev/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/rartemev/coreclr/tags","blobs_url":"https://api.github.com/repos/rartemev/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rartemev/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rartemev/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/rartemev/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rartemev/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/rartemev/coreclr/languages","stargazers_url":"https://api.github.com/repos/rartemev/coreclr/stargazers","contributors_url":"https://api.github.com/repos/rartemev/coreclr/contributors","subscribers_url":"https://api.github.com/repos/rartemev/coreclr/subscribers","subscription_url":"https://api.github.com/repos/rartemev/coreclr/subscription","commits_url":"https://api.github.com/repos/rartemev/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/rartemev/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/rartemev/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/rartemev/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/rartemev/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/rartemev/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rartemev/coreclr/merges","archive_url":"https://api.github.com/repos/rartemev/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rartemev/coreclr/downloads","issues_url":"https://api.github.com/repos/rartemev/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/rartemev/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/rartemev/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/rartemev/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rartemev/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/rartemev/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/rartemev/coreclr/deployments","created_at":"2017-02-17T00:29:34Z","updated_at":"2017-02-17T00:31:49Z","pushed_at":"2017-11-28T01:38:59Z","git_url":"git://github.com/rartemev/coreclr.git","ssh_url":"git@github.com:rartemev/coreclr.git","clone_url":"https://github.com/rartemev/coreclr.git","svn_url":"https://github.com/rartemev/coreclr","homepage":"https://docs.microsoft.com/dotnet/","size":194075,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"a7427d8550ffaab76e593b0e01a9b64f7fcd1ea1","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"name":"coreclr","full_name":"dotnet/coreclr","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2017-11-28T00:57:16Z","pushed_at":"2017-11-28T01:39:01Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":195120,"stargazers_count":8657,"watchers_count":8657,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2166,"mirror_url":null,"archived":false,"open_issues_count":1483,"forks":2166,"open_issues":1483,"watchers":8657,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/15192"},"html":{"href":"https://github.com/dotnet/coreclr/pull/15192"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/15192"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/15192/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/15192/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/15192/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/15457295f107d8a51bcb258d8a2ba38ccec83cea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sandreenko"}}