{"action":"created","comment":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/134062032","pull_request_review_id":57319837,"id":134062032,"diff_hunk":"@@ -0,0 +1,63 @@\n+/*\n+ * This file is part of Sponge, licensed under the MIT License (MIT).\n+ *\n+ * Copyright (c) SpongePowered <https://www.spongepowered.org>\n+ * Copyright (c) contributors\n+ *\n+ * Permission is hereby granted, free of charge, to any person obtaining a copy\n+ * of this software and associated documentation files (the \"Software\"), to deal\n+ * in the Software without restriction, including without limitation the rights\n+ * to use, copy, modify, merge, publish, distribute, sublicense, and/or sell\n+ * copies of the Software, and to permit persons to whom the Software is\n+ * furnished to do so, subject to the following conditions:\n+ *\n+ * The above copyright notice and this permission notice shall be included in\n+ * all copies or substantial portions of the Software.\n+ *\n+ * THE SOFTWARE IS PROVIDED \"AS IS\", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR\n+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,\n+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE\n+ * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER\n+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,\n+ * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN\n+ * THE SOFTWARE.\n+ */\n+package org.spongepowered.common.registry.type.entity;\n+\n+import static com.google.common.base.Preconditions.checkNotNull;\n+\n+import com.google.common.collect.ImmutableList;\n+import org.spongepowered.api.data.type.ParrotVariant;\n+import org.spongepowered.api.data.type.ParrotVariants;\n+import org.spongepowered.api.registry.CatalogRegistryModule;\n+import org.spongepowered.api.registry.util.RegisterCatalog;\n+import org.spongepowered.common.entity.SpongeEntityConstants;\n+\n+import java.util.Collection;\n+import java.util.HashMap;\n+import java.util.Locale;\n+import java.util.Map;\n+import java.util.Optional;\n+\n+public class ParrotVariantRegistryModule implements CatalogRegistryModule<ParrotVariant> {\n+\n+    @RegisterCatalog(ParrotVariants.class)\n+    private final Map<String, ParrotVariant> parrotVariantMap = new HashMap<>();\n+\n+    @Override\n+    public Optional<ParrotVariant> getById(String id) {\n+        return Optional.ofNullable(this.parrotVariantMap.get(checkNotNull(id).toLowerCase(Locale.ENGLISH)));\n+    }\n+\n+    @Override\n+    public Collection<ParrotVariant> getAll() {\n+        return ImmutableList.copyOf(this.parrotVariantMap.values());\n+    }\n+\n+    @Override\n+    public void registerDefaults() {\n+        this.parrotVariantMap.putAll(SpongeEntityConstants.PARROT_VARIANTS);","path":"src/main/java/org/spongepowered/common/registry/type/entity/ParrotVariantRegistryModule.java","position":59,"original_position":59,"commit_id":"5bd54543fad276f84dfcb8ef7f91be8dcc5e924a","original_commit_id":"5bd54543fad276f84dfcb8ef7f91be8dcc5e924a","user":{"login":"Zidane","id":744482,"avatar_url":"https://avatars2.githubusercontent.com/u/744482?v=4","gravatar_id":"","url":"https://api.github.com/users/Zidane","html_url":"https://github.com/Zidane","followers_url":"https://api.github.com/users/Zidane/followers","following_url":"https://api.github.com/users/Zidane/following{/other_user}","gists_url":"https://api.github.com/users/Zidane/gists{/gist_id}","starred_url":"https://api.github.com/users/Zidane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zidane/subscriptions","organizations_url":"https://api.github.com/users/Zidane/orgs","repos_url":"https://api.github.com/users/Zidane/repos","events_url":"https://api.github.com/users/Zidane/events{/privacy}","received_events_url":"https://api.github.com/users/Zidane/received_events","type":"User","site_admin":false},"body":"@gabizou Not sure its worth it to have a constants class for the Entity stuff but not do this for many other processors. Either we should standardize this or drop this concept and have the mappings in each module. I almost prefer to keep it in the module as it is all kept together under a common struct (parrot stuff with parrot).","created_at":"2017-08-18T21:48:06Z","updated_at":"2017-08-18T21:48:07Z","html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1495#discussion_r134062032","pull_request_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1495","_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments/134062032"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/1495#discussion_r134062032"},"pull_request":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1495"}}},"pull_request":{"url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1495","id":136417945,"html_url":"https://github.com/SpongePowered/SpongeCommon/pull/1495","diff_url":"https://github.com/SpongePowered/SpongeCommon/pull/1495.diff","patch_url":"https://github.com/SpongePowered/SpongeCommon/pull/1495.patch","issue_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1495","number":1495,"state":"open","locked":false,"title":"Implement parrot data and variants","user":{"login":"Meronat","id":18372958,"avatar_url":"https://avatars0.githubusercontent.com/u/18372958?v=4","gravatar_id":"","url":"https://api.github.com/users/Meronat","html_url":"https://github.com/Meronat","followers_url":"https://api.github.com/users/Meronat/followers","following_url":"https://api.github.com/users/Meronat/following{/other_user}","gists_url":"https://api.github.com/users/Meronat/gists{/gist_id}","starred_url":"https://api.github.com/users/Meronat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meronat/subscriptions","organizations_url":"https://api.github.com/users/Meronat/orgs","repos_url":"https://api.github.com/users/Meronat/repos","events_url":"https://api.github.com/users/Meronat/events{/privacy}","received_events_url":"https://api.github.com/users/Meronat/received_events","type":"User","site_admin":false},"body":"[SpongeAPI](https://github.com/SpongePowered/SpongeAPI/pull/1638) | **SpongeCommon**\r\n\r\nThis pull request implements parrot data and parrot variants, as well as adding a cute little test plugin.\r\n\r\nFor now I default to red in places as that is the parrot in vanilla with the 0 meta, so it made sense, but I'm open to changing this.\r\n\r\nCheers 🐦 \r\n\r\n(Here's me using the test plugin to make a ton of red parrots)\r\n![2017-08-18_02 23 47](https://user-images.githubusercontent.com/18372958/29448581-e8561956-83bc-11e7-8609-0398478fd58c.png)\r\n","created_at":"2017-08-18T07:29:14Z","updated_at":"2017-08-18T21:48:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbe78726465200e17893872eb0bea7d0ebd5c89a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1495/commits","review_comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1495/comments","review_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1495/comments","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/5bd54543fad276f84dfcb8ef7f91be8dcc5e924a","head":{"label":"Meronat:feature/parrot-data","ref":"feature/parrot-data","sha":"5bd54543fad276f84dfcb8ef7f91be8dcc5e924a","user":{"login":"Meronat","id":18372958,"avatar_url":"https://avatars0.githubusercontent.com/u/18372958?v=4","gravatar_id":"","url":"https://api.github.com/users/Meronat","html_url":"https://github.com/Meronat","followers_url":"https://api.github.com/users/Meronat/followers","following_url":"https://api.github.com/users/Meronat/following{/other_user}","gists_url":"https://api.github.com/users/Meronat/gists{/gist_id}","starred_url":"https://api.github.com/users/Meronat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meronat/subscriptions","organizations_url":"https://api.github.com/users/Meronat/orgs","repos_url":"https://api.github.com/users/Meronat/repos","events_url":"https://api.github.com/users/Meronat/events{/privacy}","received_events_url":"https://api.github.com/users/Meronat/received_events","type":"User","site_admin":false},"repo":{"id":87684512,"name":"SpongeCommon","full_name":"Meronat/SpongeCommon","owner":{"login":"Meronat","id":18372958,"avatar_url":"https://avatars0.githubusercontent.com/u/18372958?v=4","gravatar_id":"","url":"https://api.github.com/users/Meronat","html_url":"https://github.com/Meronat","followers_url":"https://api.github.com/users/Meronat/followers","following_url":"https://api.github.com/users/Meronat/following{/other_user}","gists_url":"https://api.github.com/users/Meronat/gists{/gist_id}","starred_url":"https://api.github.com/users/Meronat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Meronat/subscriptions","organizations_url":"https://api.github.com/users/Meronat/orgs","repos_url":"https://api.github.com/users/Meronat/repos","events_url":"https://api.github.com/users/Meronat/events{/privacy}","received_events_url":"https://api.github.com/users/Meronat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Meronat/SpongeCommon","description":"Shared code between SpongeForge and SpongeVanilla","fork":true,"url":"https://api.github.com/repos/Meronat/SpongeCommon","forks_url":"https://api.github.com/repos/Meronat/SpongeCommon/forks","keys_url":"https://api.github.com/repos/Meronat/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Meronat/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Meronat/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/Meronat/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/Meronat/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/Meronat/SpongeCommon/events","assignees_url":"https://api.github.com/repos/Meronat/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/Meronat/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/Meronat/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Meronat/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/Meronat/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/Meronat/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/Meronat/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/Meronat/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/Meronat/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/Meronat/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/Meronat/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/Meronat/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/Meronat/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/Meronat/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/Meronat/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Meronat/SpongeCommon/merges","archive_url":"https://api.github.com/repos/Meronat/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Meronat/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/Meronat/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/Meronat/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/Meronat/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/Meronat/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Meronat/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/Meronat/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/Meronat/SpongeCommon/deployments","created_at":"2017-04-09T05:11:36Z","updated_at":"2017-04-09T05:11:44Z","pushed_at":"2017-08-18T21:40:19Z","git_url":"git://github.com/Meronat/SpongeCommon.git","ssh_url":"git@github.com:Meronat/SpongeCommon.git","clone_url":"https://github.com/Meronat/SpongeCommon.git","svn_url":"https://github.com/Meronat/SpongeCommon","homepage":"","size":20706,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"bleeding"}},"base":{"label":"SpongePowered:bleeding","ref":"bleeding","sha":"3b4915376cedacef8aab0c7c46c6fc9ac1c4b1ae","user":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"repo":{"id":33791453,"name":"SpongeCommon","full_name":"SpongePowered/SpongeCommon","owner":{"login":"SpongePowered","id":8683473,"avatar_url":"https://avatars1.githubusercontent.com/u/8683473?v=4","gravatar_id":"","url":"https://api.github.com/users/SpongePowered","html_url":"https://github.com/SpongePowered","followers_url":"https://api.github.com/users/SpongePowered/followers","following_url":"https://api.github.com/users/SpongePowered/following{/other_user}","gists_url":"https://api.github.com/users/SpongePowered/gists{/gist_id}","starred_url":"https://api.github.com/users/SpongePowered/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpongePowered/subscriptions","organizations_url":"https://api.github.com/users/SpongePowered/orgs","repos_url":"https://api.github.com/users/SpongePowered/repos","events_url":"https://api.github.com/users/SpongePowered/events{/privacy}","received_events_url":"https://api.github.com/users/SpongePowered/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpongePowered/SpongeCommon","description":"Shared code between SpongeForge and SpongeVanilla","fork":false,"url":"https://api.github.com/repos/SpongePowered/SpongeCommon","forks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/forks","keys_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/teams","hooks_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/hooks","issue_events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/events{/number}","events_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/events","assignees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/assignees{/user}","branches_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/branches{/branch}","tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/tags","blobs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/{sha}","languages_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/languages","stargazers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/stargazers","contributors_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contributors","subscribers_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscribers","subscription_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/subscription","commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/contents/{+path}","compare_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/merges","archive_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/downloads","issues_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues{/number}","pulls_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls{/number}","milestones_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/milestones{/number}","notifications_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/labels{/name}","releases_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/releases{/id}","deployments_url":"https://api.github.com/repos/SpongePowered/SpongeCommon/deployments","created_at":"2015-04-11T20:38:48Z","updated_at":"2017-08-18T05:30:31Z","pushed_at":"2017-08-18T21:40:21Z","git_url":"git://github.com/SpongePowered/SpongeCommon.git","ssh_url":"git@github.com:SpongePowered/SpongeCommon.git","clone_url":"https://github.com/SpongePowered/SpongeCommon.git","svn_url":"https://github.com/SpongePowered/SpongeCommon","homepage":"","size":20766,"stargazers_count":126,"watchers_count":126,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":108,"mirror_url":null,"open_issues_count":209,"forks":108,"open_issues":209,"watchers":126,"default_branch":"bleeding"}},"_links":{"self":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1495"},"html":{"href":"https://github.com/SpongePowered/SpongeCommon/pull/1495"},"issue":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1495"},"comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/issues/1495/comments"},"review_comments":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1495/comments"},"review_comment":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/pulls/1495/commits"},"statuses":{"href":"https://api.github.com/repos/SpongePowered/SpongeCommon/statuses/5bd54543fad276f84dfcb8ef7f91be8dcc5e924a"}}}}
{"actor":{"display_login":"Zidane"}}