{"action":"created","issue":{"url":"https://api.github.com/repos/bazelbuild/bazel/issues/632","repository_url":"https://api.github.com/repos/bazelbuild/bazel","labels_url":"https://api.github.com/repos/bazelbuild/bazel/issues/632/labels{/name}","comments_url":"https://api.github.com/repos/bazelbuild/bazel/issues/632/comments","events_url":"https://api.github.com/repos/bazelbuild/bazel/issues/632/events","html_url":"https://github.com/bazelbuild/bazel/issues/632","id":117944276,"number":632,"title":"ijar does not work with scala jars that contain macros","user":{"login":"johnynek","id":67958,"avatar_url":"https://avatars3.githubusercontent.com/u/67958?v=3","gravatar_id":"","url":"https://api.github.com/users/johnynek","html_url":"https://github.com/johnynek","followers_url":"https://api.github.com/users/johnynek/followers","following_url":"https://api.github.com/users/johnynek/following{/other_user}","gists_url":"https://api.github.com/users/johnynek/gists{/gist_id}","starred_url":"https://api.github.com/users/johnynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnynek/subscriptions","organizations_url":"https://api.github.com/users/johnynek/orgs","repos_url":"https://api.github.com/users/johnynek/repos","events_url":"https://api.github.com/users/johnynek/events{/privacy}","received_events_url":"https://api.github.com/users/johnynek/received_events","type":"User","site_admin":false},"labels":[{"id":288539189,"url":"https://api.github.com/repos/bazelbuild/bazel/labels/category:%20rules%20%3E%20java","name":"category: rules > java","color":"d4c5f9","default":false},{"id":192364241,"url":"https://api.github.com/repos/bazelbuild/bazel/labels/P3","name":"P3","color":"fbca04","default":false},{"id":106503259,"url":"https://api.github.com/repos/bazelbuild/bazel/labels/type:%20bug","name":"type: bug","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bazelbuild/bazel/milestones/7","html_url":"https://github.com/bazelbuild/bazel/milestone/7","labels_url":"https://api.github.com/repos/bazelbuild/bazel/milestones/7/labels","id":1717216,"number":7,"title":"1.0","description":"","creator":{"login":"damienmg","id":3721087,"avatar_url":"https://avatars1.githubusercontent.com/u/3721087?v=3","gravatar_id":"","url":"https://api.github.com/users/damienmg","html_url":"https://github.com/damienmg","followers_url":"https://api.github.com/users/damienmg/followers","following_url":"https://api.github.com/users/damienmg/following{/other_user}","gists_url":"https://api.github.com/users/damienmg/gists{/gist_id}","starred_url":"https://api.github.com/users/damienmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienmg/subscriptions","organizations_url":"https://api.github.com/users/damienmg/orgs","repos_url":"https://api.github.com/users/damienmg/repos","events_url":"https://api.github.com/users/damienmg/events{/privacy}","received_events_url":"https://api.github.com/users/damienmg/received_events","type":"User","site_admin":false},"open_issues":130,"closed_issues":24,"state":"open","created_at":"2016-04-19T15:08:01Z","updated_at":"2017-06-22T18:56:15Z","due_on":"2018-06-30T07:00:00Z","closed_at":null},"comments":29,"created_at":"2015-11-20T01:09:39Z","updated_at":"2017-07-06T13:30:31Z","closed_at":null,"body":"I get:\n\n```\nException in thread \"main\" java.lang.ClassFormatError: Absent Code attribute in method that is not native or abstract in class file com/twitter/\nscalding/serialization/macros/impl/OrderedSerializationProviderImpl$\n```\n\nwhen compiling against an ijar'ed file that contains macros.\n\nmaybe this is not easily solvable, since I guess the scala compiler has to run methods in the jars at compile time. It would be good to see if there is a way we can tell a method is a macro method, and if it is, it should not be removed by ijar.\n"},"comment":{"url":"https://api.github.com/repos/bazelbuild/bazel/issues/comments/313396434","html_url":"https://github.com/bazelbuild/bazel/issues/632#issuecomment-313396434","issue_url":"https://api.github.com/repos/bazelbuild/bazel/issues/632","id":313396434,"user":{"login":"ulfjack","id":7355745,"avatar_url":"https://avatars3.githubusercontent.com/u/7355745?v=3","gravatar_id":"","url":"https://api.github.com/users/ulfjack","html_url":"https://github.com/ulfjack","followers_url":"https://api.github.com/users/ulfjack/followers","following_url":"https://api.github.com/users/ulfjack/following{/other_user}","gists_url":"https://api.github.com/users/ulfjack/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfjack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfjack/subscriptions","organizations_url":"https://api.github.com/users/ulfjack/orgs","repos_url":"https://api.github.com/users/ulfjack/repos","events_url":"https://api.github.com/users/ulfjack/events{/privacy}","received_events_url":"https://api.github.com/users/ulfjack/received_events","type":"User","site_admin":false},"created_at":"2017-07-06T13:30:31Z","updated_at":"2017-07-06T13:30:31Z","body":"On Thu, Jul 6, 2017 at 2:55 PM, Ittai Zeidman <notifications@github.com>\nwrote:\n\n> So maybe to have a rule that uses native.maven_jar but then exports as an\n> output the non-ijar jar file (instead of the ijar one)?\n> Did I understand correctly?\n\n\nMore or less. I think the idea would be that the scala rules can depend on\nmaven_jar, but use the runtime classpath for compiling rather than the\ncompile-time classpath. So no intermediate rules needed.\n\n\n>\n>\n> On Thu, Jul 6, 2017 at 12:54 PM Ulf Adams <notifications@github.com>\n> wrote:\n>\n> > What Liam is saying is that you can get the non-processed jar files from\n> > the java_common provider, and use those on the classpath.\n> >\n> > On Wed, Jul 5, 2017 at 9:34 PM, P. Oscar Boykin <\n> notifications@github.com>\n> > wrote:\n> >\n> > > We are using java_common.create_provider in the rules but I think\n> recent\n> > > ask: #632 (comment)\n> > > <https://github.com/bazelbuild/bazel/issues/632#issuecomment-312938533\n> >\n> > > was around maven_jar which we don't control. We can certainly make our\n> > > own scala_maven_jar repository rule but it is a shame to have a\n> duplicate\n> > > path with only one minor difference.\n> > >\n> > > —\n> > > You are receiving this because you were mentioned.\n> > > Reply to this email directly, view it on GitHub\n> > > <https://github.com/bazelbuild/bazel/issues/632#issuecomment-313203937\n> >,\n> > > or mute the thread\n> > > <\n> > https://github.com/notifications/unsubscribe-auth/\n> AHA9YXowXWXd5oA4ck5rZ7sbkEyBagltks5sK-UygaJpZM4GmC6N\n> > >\n> > > .\n> > >\n> >\n> > —\n> > You are receiving this because you were mentioned.\n> > Reply to this email directly, view it on GitHub\n> > <https://github.com/bazelbuild/bazel/issues/632#issuecomment-313351358>,\n> > or mute the thread\n> > <https://github.com/notifications/unsubscribe-\n> auth/ABUIF33irI4rPfUBpr7utMUe-2FsYg-cks5sLK68gaJpZM4GmC6N>\n> > .\n> >\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/bazelbuild/bazel/issues/632#issuecomment-313387939>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AHA9Ybgxk-_P-jN_uqgF6BCCVESXTKggks5sLNlWgaJpZM4GmC6N>\n> .\n>\n"}}
{"actor":{"display_login":"ulfjack"}}