{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/echo/pulls/comments/114065751","pull_request_review_id":35508327,"id":114065751,"diff_hunk":"@@ -68,16 +68,37 @@ class RestConfig {\n         .setLogLevel(retrofitLogLevel)\n         .setConverter(new JacksonConverter())\n \n+","path":"echo-rest/src/main/groovy/com/netflix/spinnaker/echo/config/RestConfig.groovy","position":4,"original_position":4,"commit_id":"3b17bcf5b40b6aa56300dec9abfb9eaffce103d5","original_commit_id":"3b17bcf5b40b6aa56300dec9abfb9eaffce103d5","user":{"login":"duftler","id":8437718,"avatar_url":"https://avatars1.githubusercontent.com/u/8437718?v=3","gravatar_id":"","url":"https://api.github.com/users/duftler","html_url":"https://github.com/duftler","followers_url":"https://api.github.com/users/duftler/followers","following_url":"https://api.github.com/users/duftler/following{/other_user}","gists_url":"https://api.github.com/users/duftler/gists{/gist_id}","starred_url":"https://api.github.com/users/duftler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duftler/subscriptions","organizations_url":"https://api.github.com/users/duftler/orgs","repos_url":"https://api.github.com/users/duftler/repos","events_url":"https://api.github.com/users/duftler/events{/privacy}","received_events_url":"https://api.github.com/users/duftler/received_events","type":"User","site_admin":false},"body":"Extraneous blank line.","created_at":"2017-04-30T03:07:32Z","updated_at":"2017-04-30T03:09:23Z","html_url":"https://github.com/spinnaker/echo/pull/143#discussion_r114065751","pull_request_url":"https://api.github.com/repos/spinnaker/echo/pulls/143","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/echo/pulls/comments/114065751"},"html":{"href":"https://github.com/spinnaker/echo/pull/143#discussion_r114065751"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/echo/pulls/143"}}},"pull_request":{"url":"https://api.github.com/repos/spinnaker/echo/pulls/143","id":117773991,"html_url":"https://github.com/spinnaker/echo/pull/143","diff_url":"https://github.com/spinnaker/echo/pull/143.diff","patch_url":"https://github.com/spinnaker/echo/pull/143.patch","issue_url":"https://api.github.com/repos/spinnaker/echo/issues/143","number":143,"state":"open","locked":false,"title":"feat(core): Allow configurable headers for rest endpoints","user":{"login":"andrewbackes","id":7506976,"avatar_url":"https://avatars3.githubusercontent.com/u/7506976?v=3","gravatar_id":"","url":"https://api.github.com/users/andrewbackes","html_url":"https://github.com/andrewbackes","followers_url":"https://api.github.com/users/andrewbackes/followers","following_url":"https://api.github.com/users/andrewbackes/following{/other_user}","gists_url":"https://api.github.com/users/andrewbackes/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewbackes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewbackes/subscriptions","organizations_url":"https://api.github.com/users/andrewbackes/orgs","repos_url":"https://api.github.com/users/andrewbackes/repos","events_url":"https://api.github.com/users/andrewbackes/events{/privacy}","received_events_url":"https://api.github.com/users/andrewbackes/received_events","type":"User","site_admin":false},"body":"This feature started because I needed to be able to set the Authorization header in order to send events to Splunk.\r\n\r\nThis PR will allow you to set headers in two ways.\r\n\r\n1. Directly in `echo-local.yml`:\r\n```yaml\r\nrest:\r\n  enabled: true\r\n  endpoints:\r\n    - wrap: false\r\n      url: http://www.example.com\r\n      headers:\r\n        Authorization: Splunk MYSECRETKEYHERE\r\n```\r\n\r\n2. In a file that contains the headers you want to include:\r\n```yaml\r\nrest:\r\n  enabled: true\r\n  endpoints:\r\n    - wrap: false\r\n      url: http://www.example.com\r\n      headersFile: /mnt/mysecrets/splunkKey\r\n```\r\nwhere `/mnt/mysecrets/splunkKey` looks like:\r\n```\r\nAuthorization: Splunk MYSECRETKEYHERE\r\n```\r\n\r\nIn the examples above, I only used the `Authorization` header. However, you can specify any header you want. \r\n\r\nIf there are conflicts with headers then the header in the `headersFile` will be used over what is in the `headers` field. If username/password fields are present in `echo-local.yml` and an Authorization header is specified, then the Authorization header will override the basic auth header created from the username/password.","created_at":"2017-04-26T17:57:06Z","updated_at":"2017-04-30T03:09:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"490b9138161c443a6565641977ac9a08fa9f994d","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/echo/pulls/143/commits","review_comments_url":"https://api.github.com/repos/spinnaker/echo/pulls/143/comments","review_comment_url":"https://api.github.com/repos/spinnaker/echo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/echo/issues/143/comments","statuses_url":"https://api.github.com/repos/spinnaker/echo/statuses/3b17bcf5b40b6aa56300dec9abfb9eaffce103d5","head":{"label":"armory-io:master","ref":"master","sha":"3b17bcf5b40b6aa56300dec9abfb9eaffce103d5","user":{"login":"armory-io","id":22381802,"avatar_url":"https://avatars3.githubusercontent.com/u/22381802?v=3","gravatar_id":"","url":"https://api.github.com/users/armory-io","html_url":"https://github.com/armory-io","followers_url":"https://api.github.com/users/armory-io/followers","following_url":"https://api.github.com/users/armory-io/following{/other_user}","gists_url":"https://api.github.com/users/armory-io/gists{/gist_id}","starred_url":"https://api.github.com/users/armory-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armory-io/subscriptions","organizations_url":"https://api.github.com/users/armory-io/orgs","repos_url":"https://api.github.com/users/armory-io/repos","events_url":"https://api.github.com/users/armory-io/events{/privacy}","received_events_url":"https://api.github.com/users/armory-io/received_events","type":"Organization","site_admin":false},"repo":{"id":87374933,"name":"echo","full_name":"armory-io/echo","owner":{"login":"armory-io","id":22381802,"avatar_url":"https://avatars3.githubusercontent.com/u/22381802?v=3","gravatar_id":"","url":"https://api.github.com/users/armory-io","html_url":"https://github.com/armory-io","followers_url":"https://api.github.com/users/armory-io/followers","following_url":"https://api.github.com/users/armory-io/following{/other_user}","gists_url":"https://api.github.com/users/armory-io/gists{/gist_id}","starred_url":"https://api.github.com/users/armory-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armory-io/subscriptions","organizations_url":"https://api.github.com/users/armory-io/orgs","repos_url":"https://api.github.com/users/armory-io/repos","events_url":"https://api.github.com/users/armory-io/events{/privacy}","received_events_url":"https://api.github.com/users/armory-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/armory-io/echo","description":"Spinnaker Eventing Service","fork":true,"url":"https://api.github.com/repos/armory-io/echo","forks_url":"https://api.github.com/repos/armory-io/echo/forks","keys_url":"https://api.github.com/repos/armory-io/echo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/armory-io/echo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/armory-io/echo/teams","hooks_url":"https://api.github.com/repos/armory-io/echo/hooks","issue_events_url":"https://api.github.com/repos/armory-io/echo/issues/events{/number}","events_url":"https://api.github.com/repos/armory-io/echo/events","assignees_url":"https://api.github.com/repos/armory-io/echo/assignees{/user}","branches_url":"https://api.github.com/repos/armory-io/echo/branches{/branch}","tags_url":"https://api.github.com/repos/armory-io/echo/tags","blobs_url":"https://api.github.com/repos/armory-io/echo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/armory-io/echo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/armory-io/echo/git/refs{/sha}","trees_url":"https://api.github.com/repos/armory-io/echo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/armory-io/echo/statuses/{sha}","languages_url":"https://api.github.com/repos/armory-io/echo/languages","stargazers_url":"https://api.github.com/repos/armory-io/echo/stargazers","contributors_url":"https://api.github.com/repos/armory-io/echo/contributors","subscribers_url":"https://api.github.com/repos/armory-io/echo/subscribers","subscription_url":"https://api.github.com/repos/armory-io/echo/subscription","commits_url":"https://api.github.com/repos/armory-io/echo/commits{/sha}","git_commits_url":"https://api.github.com/repos/armory-io/echo/git/commits{/sha}","comments_url":"https://api.github.com/repos/armory-io/echo/comments{/number}","issue_comment_url":"https://api.github.com/repos/armory-io/echo/issues/comments{/number}","contents_url":"https://api.github.com/repos/armory-io/echo/contents/{+path}","compare_url":"https://api.github.com/repos/armory-io/echo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/armory-io/echo/merges","archive_url":"https://api.github.com/repos/armory-io/echo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/armory-io/echo/downloads","issues_url":"https://api.github.com/repos/armory-io/echo/issues{/number}","pulls_url":"https://api.github.com/repos/armory-io/echo/pulls{/number}","milestones_url":"https://api.github.com/repos/armory-io/echo/milestones{/number}","notifications_url":"https://api.github.com/repos/armory-io/echo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/armory-io/echo/labels{/name}","releases_url":"https://api.github.com/repos/armory-io/echo/releases{/id}","deployments_url":"https://api.github.com/repos/armory-io/echo/deployments","created_at":"2017-04-06T02:00:12Z","updated_at":"2017-04-06T02:00:14Z","pushed_at":"2017-04-26T17:23:21Z","git_url":"git://github.com/armory-io/echo.git","ssh_url":"git@github.com:armory-io/echo.git","clone_url":"https://github.com/armory-io/echo.git","svn_url":"https://github.com/armory-io/echo","homepage":"","size":828,"stargazers_count":0,"watchers_count":0,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"03d9a6fdbb25387d527c81b2ddf107c109c37dfb","user":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars2.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21145185,"name":"echo","full_name":"spinnaker/echo","owner":{"login":"spinnaker","id":7634182,"avatar_url":"https://avatars2.githubusercontent.com/u/7634182?v=3","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spinnaker/echo","description":"Spinnaker Eventing Service","fork":false,"url":"https://api.github.com/repos/spinnaker/echo","forks_url":"https://api.github.com/repos/spinnaker/echo/forks","keys_url":"https://api.github.com/repos/spinnaker/echo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/echo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/echo/teams","hooks_url":"https://api.github.com/repos/spinnaker/echo/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/echo/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/echo/events","assignees_url":"https://api.github.com/repos/spinnaker/echo/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/echo/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/echo/tags","blobs_url":"https://api.github.com/repos/spinnaker/echo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/echo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/echo/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/echo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/echo/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/echo/languages","stargazers_url":"https://api.github.com/repos/spinnaker/echo/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/echo/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/echo/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/echo/subscription","commits_url":"https://api.github.com/repos/spinnaker/echo/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/echo/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/echo/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/echo/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/echo/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/echo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/echo/merges","archive_url":"https://api.github.com/repos/spinnaker/echo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/echo/downloads","issues_url":"https://api.github.com/repos/spinnaker/echo/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/echo/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/echo/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/echo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/echo/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/echo/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/echo/deployments","created_at":"2014-06-23T22:59:57Z","updated_at":"2017-03-13T22:47:08Z","pushed_at":"2017-04-26T17:57:06Z","git_url":"git://github.com/spinnaker/echo.git","ssh_url":"git@github.com:spinnaker/echo.git","clone_url":"https://github.com/spinnaker/echo.git","svn_url":"https://github.com/spinnaker/echo","homepage":"","size":826,"stargazers_count":16,"watchers_count":16,"language":"Groovy","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":62,"mirror_url":null,"open_issues_count":1,"forks":62,"open_issues":1,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/echo/pulls/143"},"html":{"href":"https://github.com/spinnaker/echo/pull/143"},"issue":{"href":"https://api.github.com/repos/spinnaker/echo/issues/143"},"comments":{"href":"https://api.github.com/repos/spinnaker/echo/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/echo/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/echo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/echo/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/echo/statuses/3b17bcf5b40b6aa56300dec9abfb9eaffce103d5"}}}}
{"actor":{"display_login":"duftler"}}