{"action":"created","comment":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/comments/138216820","pull_request_review_id":61983142,"id":138216820,"diff_hunk":"@@ -33,81 +32,61 @@ import (\n // ServerHTTPResponse struct manages request\n type ServerHTTPResponse struct {","path":"runtime/server_http_response.go","position":10,"original_position":10,"commit_id":"7a157c158efd98421e595480ee5e1d07af3c54ec","original_commit_id":"7a157c158efd98421e595480ee5e1d07af3c54ec","user":{"login":"ravirajj","id":3112692,"avatar_url":"https://avatars0.githubusercontent.com/u/3112692?v=4","gravatar_id":"","url":"https://api.github.com/users/ravirajj","html_url":"https://github.com/ravirajj","followers_url":"https://api.github.com/users/ravirajj/followers","following_url":"https://api.github.com/users/ravirajj/following{/other_user}","gists_url":"https://api.github.com/users/ravirajj/gists{/gist_id}","starred_url":"https://api.github.com/users/ravirajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravirajj/subscriptions","organizations_url":"https://api.github.com/users/ravirajj/orgs","repos_url":"https://api.github.com/users/ravirajj/repos","events_url":"https://api.github.com/users/ravirajj/events{/privacy}","received_events_url":"https://api.github.com/users/ravirajj/received_events","type":"User","site_admin":false},"body":"Sure, no problem.","created_at":"2017-09-11T23:16:50Z","updated_at":"2017-09-11T23:16:50Z","html_url":"https://github.com/uber/zanzibar/pull/201#discussion_r138216820","pull_request_url":"https://api.github.com/repos/uber/zanzibar/pulls/201","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/comments/138216820"},"html":{"href":"https://github.com/uber/zanzibar/pull/201#discussion_r138216820"},"pull_request":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/201"}},"in_reply_to_id":138215405},"pull_request":{"url":"https://api.github.com/repos/uber/zanzibar/pulls/201","id":139412516,"html_url":"https://github.com/uber/zanzibar/pull/201","diff_url":"https://github.com/uber/zanzibar/pull/201.diff","patch_url":"https://github.com/uber/zanzibar/pull/201.patch","issue_url":"https://api.github.com/repos/uber/zanzibar/issues/201","number":201,"state":"open","locked":false,"title":"Adding inbound call metrics to http endpoint","user":{"login":"ravirajj","id":3112692,"avatar_url":"https://avatars0.githubusercontent.com/u/3112692?v=4","gravatar_id":"","url":"https://api.github.com/users/ravirajj","html_url":"https://github.com/ravirajj","followers_url":"https://api.github.com/users/ravirajj/followers","following_url":"https://api.github.com/users/ravirajj/following{/other_user}","gists_url":"https://api.github.com/users/ravirajj/gists{/gist_id}","starred_url":"https://api.github.com/users/ravirajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravirajj/subscriptions","organizations_url":"https://api.github.com/users/ravirajj/orgs","repos_url":"https://api.github.com/users/ravirajj/repos","events_url":"https://api.github.com/users/ravirajj/events{/privacy}","received_events_url":"https://api.github.com/users/ravirajj/received_events","type":"User","site_admin":false},"body":"HTTP endpoint emits the following metrics:\r\n\r\nNames:\r\n- inbound.calls.latency\r\n- inbound.calls.recvd\r\n- inbound.calls.success\r\n- inbound.calls.errors\r\n- inbound.calls.status.2XX\r\n- inbound.calls.status.4XX\r\n- inbound.calls.status.5XX\r\n\r\nTags:\r\n- host - “all”\r\n- env - environment, e.g. “production”, “staging”, “test”\r\n- service - service name, e.g. “example-gateway”\r\n- module - “client” module class name\r\n- module-type - “http” module class type\r\n- endpoint - endpointId, e.g. “bar”\r\n- handler - handleId, e.g. “normal”\r\n- thrift-method - thrift method, e.g. “Bar::echostring”\r\n- workflow-type - “tchannelclient”, “httpclient”, “custom” workflowType\r\n- calling-service - e.g. “bar”, etc.\r\n","created_at":"2017-09-05T20:21:56Z","updated_at":"2017-09-11T23:16:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a361384bf32c7fb340063997444e0bc28d9b5ea3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Matt-Esch","id":1058839,"avatar_url":"https://avatars1.githubusercontent.com/u/1058839?v=4","gravatar_id":"","url":"https://api.github.com/users/Matt-Esch","html_url":"https://github.com/Matt-Esch","followers_url":"https://api.github.com/users/Matt-Esch/followers","following_url":"https://api.github.com/users/Matt-Esch/following{/other_user}","gists_url":"https://api.github.com/users/Matt-Esch/gists{/gist_id}","starred_url":"https://api.github.com/users/Matt-Esch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Matt-Esch/subscriptions","organizations_url":"https://api.github.com/users/Matt-Esch/orgs","repos_url":"https://api.github.com/users/Matt-Esch/repos","events_url":"https://api.github.com/users/Matt-Esch/events{/privacy}","received_events_url":"https://api.github.com/users/Matt-Esch/received_events","type":"User","site_admin":false},{"login":"srivastavankit","id":4098001,"avatar_url":"https://avatars3.githubusercontent.com/u/4098001?v=4","gravatar_id":"","url":"https://api.github.com/users/srivastavankit","html_url":"https://github.com/srivastavankit","followers_url":"https://api.github.com/users/srivastavankit/followers","following_url":"https://api.github.com/users/srivastavankit/following{/other_user}","gists_url":"https://api.github.com/users/srivastavankit/gists{/gist_id}","starred_url":"https://api.github.com/users/srivastavankit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/srivastavankit/subscriptions","organizations_url":"https://api.github.com/users/srivastavankit/orgs","repos_url":"https://api.github.com/users/srivastavankit/repos","events_url":"https://api.github.com/users/srivastavankit/events{/privacy}","received_events_url":"https://api.github.com/users/srivastavankit/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/uber/zanzibar/pulls/201/commits","review_comments_url":"https://api.github.com/repos/uber/zanzibar/pulls/201/comments","review_comment_url":"https://api.github.com/repos/uber/zanzibar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uber/zanzibar/issues/201/comments","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/7a157c158efd98421e595480ee5e1d07af3c54ec","head":{"label":"ravirajj:rj.httpendpoint","ref":"rj.httpendpoint","sha":"7a157c158efd98421e595480ee5e1d07af3c54ec","user":{"login":"ravirajj","id":3112692,"avatar_url":"https://avatars0.githubusercontent.com/u/3112692?v=4","gravatar_id":"","url":"https://api.github.com/users/ravirajj","html_url":"https://github.com/ravirajj","followers_url":"https://api.github.com/users/ravirajj/followers","following_url":"https://api.github.com/users/ravirajj/following{/other_user}","gists_url":"https://api.github.com/users/ravirajj/gists{/gist_id}","starred_url":"https://api.github.com/users/ravirajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravirajj/subscriptions","organizations_url":"https://api.github.com/users/ravirajj/orgs","repos_url":"https://api.github.com/users/ravirajj/repos","events_url":"https://api.github.com/users/ravirajj/events{/privacy}","received_events_url":"https://api.github.com/users/ravirajj/received_events","type":"User","site_admin":false},"repo":{"id":97967323,"name":"zanzibar","full_name":"ravirajj/zanzibar","owner":{"login":"ravirajj","id":3112692,"avatar_url":"https://avatars0.githubusercontent.com/u/3112692?v=4","gravatar_id":"","url":"https://api.github.com/users/ravirajj","html_url":"https://github.com/ravirajj","followers_url":"https://api.github.com/users/ravirajj/followers","following_url":"https://api.github.com/users/ravirajj/following{/other_user}","gists_url":"https://api.github.com/users/ravirajj/gists{/gist_id}","starred_url":"https://api.github.com/users/ravirajj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravirajj/subscriptions","organizations_url":"https://api.github.com/users/ravirajj/orgs","repos_url":"https://api.github.com/users/ravirajj/repos","events_url":"https://api.github.com/users/ravirajj/events{/privacy}","received_events_url":"https://api.github.com/users/ravirajj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ravirajj/zanzibar","description":"A build system & configuration system to generate versionsed API gateways.","fork":true,"url":"https://api.github.com/repos/ravirajj/zanzibar","forks_url":"https://api.github.com/repos/ravirajj/zanzibar/forks","keys_url":"https://api.github.com/repos/ravirajj/zanzibar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravirajj/zanzibar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravirajj/zanzibar/teams","hooks_url":"https://api.github.com/repos/ravirajj/zanzibar/hooks","issue_events_url":"https://api.github.com/repos/ravirajj/zanzibar/issues/events{/number}","events_url":"https://api.github.com/repos/ravirajj/zanzibar/events","assignees_url":"https://api.github.com/repos/ravirajj/zanzibar/assignees{/user}","branches_url":"https://api.github.com/repos/ravirajj/zanzibar/branches{/branch}","tags_url":"https://api.github.com/repos/ravirajj/zanzibar/tags","blobs_url":"https://api.github.com/repos/ravirajj/zanzibar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravirajj/zanzibar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravirajj/zanzibar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravirajj/zanzibar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravirajj/zanzibar/statuses/{sha}","languages_url":"https://api.github.com/repos/ravirajj/zanzibar/languages","stargazers_url":"https://api.github.com/repos/ravirajj/zanzibar/stargazers","contributors_url":"https://api.github.com/repos/ravirajj/zanzibar/contributors","subscribers_url":"https://api.github.com/repos/ravirajj/zanzibar/subscribers","subscription_url":"https://api.github.com/repos/ravirajj/zanzibar/subscription","commits_url":"https://api.github.com/repos/ravirajj/zanzibar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravirajj/zanzibar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravirajj/zanzibar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravirajj/zanzibar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravirajj/zanzibar/contents/{+path}","compare_url":"https://api.github.com/repos/ravirajj/zanzibar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravirajj/zanzibar/merges","archive_url":"https://api.github.com/repos/ravirajj/zanzibar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravirajj/zanzibar/downloads","issues_url":"https://api.github.com/repos/ravirajj/zanzibar/issues{/number}","pulls_url":"https://api.github.com/repos/ravirajj/zanzibar/pulls{/number}","milestones_url":"https://api.github.com/repos/ravirajj/zanzibar/milestones{/number}","notifications_url":"https://api.github.com/repos/ravirajj/zanzibar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravirajj/zanzibar/labels{/name}","releases_url":"https://api.github.com/repos/ravirajj/zanzibar/releases{/id}","deployments_url":"https://api.github.com/repos/ravirajj/zanzibar/deployments","created_at":"2017-07-21T16:26:54Z","updated_at":"2017-07-21T16:26:56Z","pushed_at":"2017-09-11T23:01:32Z","git_url":"git://github.com/ravirajj/zanzibar.git","ssh_url":"git@github.com:ravirajj/zanzibar.git","clone_url":"https://github.com/ravirajj/zanzibar.git","svn_url":"https://github.com/ravirajj/zanzibar","homepage":"","size":8355,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uber:master","ref":"master","sha":"4b55513f12424ba58ce1721f8902c08211b4f0fd","user":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"repo":{"id":85628655,"name":"zanzibar","full_name":"uber/zanzibar","owner":{"login":"uber","id":538264,"avatar_url":"https://avatars3.githubusercontent.com/u/538264?v=4","gravatar_id":"","url":"https://api.github.com/users/uber","html_url":"https://github.com/uber","followers_url":"https://api.github.com/users/uber/followers","following_url":"https://api.github.com/users/uber/following{/other_user}","gists_url":"https://api.github.com/users/uber/gists{/gist_id}","starred_url":"https://api.github.com/users/uber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uber/subscriptions","organizations_url":"https://api.github.com/users/uber/orgs","repos_url":"https://api.github.com/users/uber/repos","events_url":"https://api.github.com/users/uber/events{/privacy}","received_events_url":"https://api.github.com/users/uber/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uber/zanzibar","description":"A build system & configuration system to generate versionsed API gateways.","fork":false,"url":"https://api.github.com/repos/uber/zanzibar","forks_url":"https://api.github.com/repos/uber/zanzibar/forks","keys_url":"https://api.github.com/repos/uber/zanzibar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uber/zanzibar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uber/zanzibar/teams","hooks_url":"https://api.github.com/repos/uber/zanzibar/hooks","issue_events_url":"https://api.github.com/repos/uber/zanzibar/issues/events{/number}","events_url":"https://api.github.com/repos/uber/zanzibar/events","assignees_url":"https://api.github.com/repos/uber/zanzibar/assignees{/user}","branches_url":"https://api.github.com/repos/uber/zanzibar/branches{/branch}","tags_url":"https://api.github.com/repos/uber/zanzibar/tags","blobs_url":"https://api.github.com/repos/uber/zanzibar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uber/zanzibar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uber/zanzibar/git/refs{/sha}","trees_url":"https://api.github.com/repos/uber/zanzibar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uber/zanzibar/statuses/{sha}","languages_url":"https://api.github.com/repos/uber/zanzibar/languages","stargazers_url":"https://api.github.com/repos/uber/zanzibar/stargazers","contributors_url":"https://api.github.com/repos/uber/zanzibar/contributors","subscribers_url":"https://api.github.com/repos/uber/zanzibar/subscribers","subscription_url":"https://api.github.com/repos/uber/zanzibar/subscription","commits_url":"https://api.github.com/repos/uber/zanzibar/commits{/sha}","git_commits_url":"https://api.github.com/repos/uber/zanzibar/git/commits{/sha}","comments_url":"https://api.github.com/repos/uber/zanzibar/comments{/number}","issue_comment_url":"https://api.github.com/repos/uber/zanzibar/issues/comments{/number}","contents_url":"https://api.github.com/repos/uber/zanzibar/contents/{+path}","compare_url":"https://api.github.com/repos/uber/zanzibar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uber/zanzibar/merges","archive_url":"https://api.github.com/repos/uber/zanzibar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uber/zanzibar/downloads","issues_url":"https://api.github.com/repos/uber/zanzibar/issues{/number}","pulls_url":"https://api.github.com/repos/uber/zanzibar/pulls{/number}","milestones_url":"https://api.github.com/repos/uber/zanzibar/milestones{/number}","notifications_url":"https://api.github.com/repos/uber/zanzibar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uber/zanzibar/labels{/name}","releases_url":"https://api.github.com/repos/uber/zanzibar/releases{/id}","deployments_url":"https://api.github.com/repos/uber/zanzibar/deployments","created_at":"2017-03-20T21:22:09Z","updated_at":"2017-09-11T11:04:32Z","pushed_at":"2017-09-11T23:01:33Z","git_url":"git://github.com/uber/zanzibar.git","ssh_url":"git@github.com:uber/zanzibar.git","clone_url":"https://github.com/uber/zanzibar.git","svn_url":"https://github.com/uber/zanzibar","homepage":"","size":8272,"stargazers_count":32,"watchers_count":32,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":24,"forks":10,"open_issues":24,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/201"},"html":{"href":"https://github.com/uber/zanzibar/pull/201"},"issue":{"href":"https://api.github.com/repos/uber/zanzibar/issues/201"},"comments":{"href":"https://api.github.com/repos/uber/zanzibar/issues/201/comments"},"review_comments":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/201/comments"},"review_comment":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uber/zanzibar/pulls/201/commits"},"statuses":{"href":"https://api.github.com/repos/uber/zanzibar/statuses/7a157c158efd98421e595480ee5e1d07af3c54ec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ravirajj"}}