{"action":"closed","number":659,"pull_request":{"url":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls/659","id":119941486,"html_url":"https://github.com/MylesIsCool/ViaVersion/pull/659","diff_url":"https://github.com/MylesIsCool/ViaVersion/pull/659.diff","patch_url":"https://github.com/MylesIsCool/ViaVersion/pull/659.patch","issue_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/issues/659","number":659,"state":"closed","locked":false,"title":"[WIP] Add bStats as a metrics service, implements #658","user":{"login":"MiniDigger","id":2185527,"avatar_url":"https://avatars3.githubusercontent.com/u/2185527?v=3","gravatar_id":"","url":"https://api.github.com/users/MiniDigger","html_url":"https://github.com/MiniDigger","followers_url":"https://api.github.com/users/MiniDigger/followers","following_url":"https://api.github.com/users/MiniDigger/following{/other_user}","gists_url":"https://api.github.com/users/MiniDigger/gists{/gist_id}","starred_url":"https://api.github.com/users/MiniDigger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiniDigger/subscriptions","organizations_url":"https://api.github.com/users/MiniDigger/orgs","repos_url":"https://api.github.com/users/MiniDigger/repos","events_url":"https://api.github.com/users/MiniDigger/events{/privacy}","received_events_url":"https://api.github.com/users/MiniDigger/received_events","type":"User","site_admin":false},"body":"# Info\r\n\r\nAs explained in #658 bStats is basically the replacement for mcstats.org.\r\n\r\nThis pr implements the metric service for all 3 platforms and also adds a custom chart to track protocol versions of connected players. \r\nYou will have to sign up @ bstats.org, add the plugin and configure the custom graph (its a 'Advanced Pie' named 'protocol_versions'), see [here](https://bstats.org/add-plugin) and [here](https://bstats.org/help/custom-charts)\r\n\r\n# What data will be send?\r\nFrom bStats.org:\r\n```\r\nBy default, bStats sends the following data:\r\n- Your server's randomly generated UUID\r\n- The amount of players on your server\r\n- The online mode of your server\r\n- The bukkit version of your server\r\n- The java version of your system (e.g. Java 8)\r\n- The name of your OS (e.g. Windows)\r\n- The version of your OS\r\n- The architecture of your OS (e.g. amd64)\r\n- The system cores of your OS (e.g. 8)\r\n- bStats-supported plugins\r\n- Plugin version of bStats-supported plugins\r\n```\r\nthis PR will additional send the protocol version of all connected players.\r\n\r\nAll data collection can be disabled by the server admin by opting out in the bStats config: plugins/bStats/config.yml \r\n\r\n# Status\r\nThis PR is currently completely untested as I cannot build via (see gitter).  \r\nOnce that is fixed, I need to test all platforms with multiple versions.  \r\nI am also unsure if the relocation works like that. Needs testing once I can build.","created_at":"2017-05-10T17:49:04Z","updated_at":"2017-05-22T12:56:24Z","closed_at":"2017-05-22T12:56:24Z","merged_at":null,"merge_commit_sha":"e059e13b66516c1d0607724e6f53eb3e5b0dcf78","assignee":{"login":"MylesIsCool","id":1151143,"avatar_url":"https://avatars1.githubusercontent.com/u/1151143?v=3","gravatar_id":"","url":"https://api.github.com/users/MylesIsCool","html_url":"https://github.com/MylesIsCool","followers_url":"https://api.github.com/users/MylesIsCool/followers","following_url":"https://api.github.com/users/MylesIsCool/following{/other_user}","gists_url":"https://api.github.com/users/MylesIsCool/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesIsCool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesIsCool/subscriptions","organizations_url":"https://api.github.com/users/MylesIsCool/orgs","repos_url":"https://api.github.com/users/MylesIsCool/repos","events_url":"https://api.github.com/users/MylesIsCool/events{/privacy}","received_events_url":"https://api.github.com/users/MylesIsCool/received_events","type":"User","site_admin":false},"assignees":[{"login":"MylesIsCool","id":1151143,"avatar_url":"https://avatars1.githubusercontent.com/u/1151143?v=3","gravatar_id":"","url":"https://api.github.com/users/MylesIsCool","html_url":"https://github.com/MylesIsCool","followers_url":"https://api.github.com/users/MylesIsCool/followers","following_url":"https://api.github.com/users/MylesIsCool/following{/other_user}","gists_url":"https://api.github.com/users/MylesIsCool/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesIsCool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesIsCool/subscriptions","organizations_url":"https://api.github.com/users/MylesIsCool/orgs","repos_url":"https://api.github.com/users/MylesIsCool/repos","events_url":"https://api.github.com/users/MylesIsCool/events{/privacy}","received_events_url":"https://api.github.com/users/MylesIsCool/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls/659/commits","review_comments_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls/659/comments","review_comment_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/issues/659/comments","statuses_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/statuses/06eefcfefd9dae57b662ae77d14398b14acb3110","head":{"label":"MiniDigger:feature/bstats","ref":"feature/bstats","sha":"06eefcfefd9dae57b662ae77d14398b14acb3110","user":{"login":"MiniDigger","id":2185527,"avatar_url":"https://avatars3.githubusercontent.com/u/2185527?v=3","gravatar_id":"","url":"https://api.github.com/users/MiniDigger","html_url":"https://github.com/MiniDigger","followers_url":"https://api.github.com/users/MiniDigger/followers","following_url":"https://api.github.com/users/MiniDigger/following{/other_user}","gists_url":"https://api.github.com/users/MiniDigger/gists{/gist_id}","starred_url":"https://api.github.com/users/MiniDigger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiniDigger/subscriptions","organizations_url":"https://api.github.com/users/MiniDigger/orgs","repos_url":"https://api.github.com/users/MiniDigger/repos","events_url":"https://api.github.com/users/MiniDigger/events{/privacy}","received_events_url":"https://api.github.com/users/MiniDigger/received_events","type":"User","site_admin":false},"repo":{"id":68029549,"name":"ViaVersion","full_name":"MiniDigger/ViaVersion","owner":{"login":"MiniDigger","id":2185527,"avatar_url":"https://avatars3.githubusercontent.com/u/2185527?v=3","gravatar_id":"","url":"https://api.github.com/users/MiniDigger","html_url":"https://github.com/MiniDigger","followers_url":"https://api.github.com/users/MiniDigger/followers","following_url":"https://api.github.com/users/MiniDigger/following{/other_user}","gists_url":"https://api.github.com/users/MiniDigger/gists{/gist_id}","starred_url":"https://api.github.com/users/MiniDigger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MiniDigger/subscriptions","organizations_url":"https://api.github.com/users/MiniDigger/orgs","repos_url":"https://api.github.com/users/MiniDigger/repos","events_url":"https://api.github.com/users/MiniDigger/events{/privacy}","received_events_url":"https://api.github.com/users/MiniDigger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MiniDigger/ViaVersion","description":"Allows the connection of newer clients to older server versions for Minecraft Bukkit servers.","fork":true,"url":"https://api.github.com/repos/MiniDigger/ViaVersion","forks_url":"https://api.github.com/repos/MiniDigger/ViaVersion/forks","keys_url":"https://api.github.com/repos/MiniDigger/ViaVersion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MiniDigger/ViaVersion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MiniDigger/ViaVersion/teams","hooks_url":"https://api.github.com/repos/MiniDigger/ViaVersion/hooks","issue_events_url":"https://api.github.com/repos/MiniDigger/ViaVersion/issues/events{/number}","events_url":"https://api.github.com/repos/MiniDigger/ViaVersion/events","assignees_url":"https://api.github.com/repos/MiniDigger/ViaVersion/assignees{/user}","branches_url":"https://api.github.com/repos/MiniDigger/ViaVersion/branches{/branch}","tags_url":"https://api.github.com/repos/MiniDigger/ViaVersion/tags","blobs_url":"https://api.github.com/repos/MiniDigger/ViaVersion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MiniDigger/ViaVersion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MiniDigger/ViaVersion/git/refs{/sha}","trees_url":"https://api.github.com/repos/MiniDigger/ViaVersion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MiniDigger/ViaVersion/statuses/{sha}","languages_url":"https://api.github.com/repos/MiniDigger/ViaVersion/languages","stargazers_url":"https://api.github.com/repos/MiniDigger/ViaVersion/stargazers","contributors_url":"https://api.github.com/repos/MiniDigger/ViaVersion/contributors","subscribers_url":"https://api.github.com/repos/MiniDigger/ViaVersion/subscribers","subscription_url":"https://api.github.com/repos/MiniDigger/ViaVersion/subscription","commits_url":"https://api.github.com/repos/MiniDigger/ViaVersion/commits{/sha}","git_commits_url":"https://api.github.com/repos/MiniDigger/ViaVersion/git/commits{/sha}","comments_url":"https://api.github.com/repos/MiniDigger/ViaVersion/comments{/number}","issue_comment_url":"https://api.github.com/repos/MiniDigger/ViaVersion/issues/comments{/number}","contents_url":"https://api.github.com/repos/MiniDigger/ViaVersion/contents/{+path}","compare_url":"https://api.github.com/repos/MiniDigger/ViaVersion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MiniDigger/ViaVersion/merges","archive_url":"https://api.github.com/repos/MiniDigger/ViaVersion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MiniDigger/ViaVersion/downloads","issues_url":"https://api.github.com/repos/MiniDigger/ViaVersion/issues{/number}","pulls_url":"https://api.github.com/repos/MiniDigger/ViaVersion/pulls{/number}","milestones_url":"https://api.github.com/repos/MiniDigger/ViaVersion/milestones{/number}","notifications_url":"https://api.github.com/repos/MiniDigger/ViaVersion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MiniDigger/ViaVersion/labels{/name}","releases_url":"https://api.github.com/repos/MiniDigger/ViaVersion/releases{/id}","deployments_url":"https://api.github.com/repos/MiniDigger/ViaVersion/deployments","created_at":"2016-09-12T17:03:02Z","updated_at":"2016-09-12T17:03:04Z","pushed_at":"2017-05-10T17:41:32Z","git_url":"git://github.com/MiniDigger/ViaVersion.git","ssh_url":"git@github.com:MiniDigger/ViaVersion.git","clone_url":"https://github.com/MiniDigger/ViaVersion.git","svn_url":"https://github.com/MiniDigger/ViaVersion","homepage":"https://viaversion.com","size":1661,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MylesIsCool:master","ref":"master","sha":"efa6e8ec31384034d178fe28469c35956443d6c6","user":{"login":"MylesIsCool","id":1151143,"avatar_url":"https://avatars1.githubusercontent.com/u/1151143?v=3","gravatar_id":"","url":"https://api.github.com/users/MylesIsCool","html_url":"https://github.com/MylesIsCool","followers_url":"https://api.github.com/users/MylesIsCool/followers","following_url":"https://api.github.com/users/MylesIsCool/following{/other_user}","gists_url":"https://api.github.com/users/MylesIsCool/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesIsCool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesIsCool/subscriptions","organizations_url":"https://api.github.com/users/MylesIsCool/orgs","repos_url":"https://api.github.com/users/MylesIsCool/repos","events_url":"https://api.github.com/users/MylesIsCool/events{/privacy}","received_events_url":"https://api.github.com/users/MylesIsCool/received_events","type":"User","site_admin":false},"repo":{"id":52748444,"name":"ViaVersion","full_name":"MylesIsCool/ViaVersion","owner":{"login":"MylesIsCool","id":1151143,"avatar_url":"https://avatars1.githubusercontent.com/u/1151143?v=3","gravatar_id":"","url":"https://api.github.com/users/MylesIsCool","html_url":"https://github.com/MylesIsCool","followers_url":"https://api.github.com/users/MylesIsCool/followers","following_url":"https://api.github.com/users/MylesIsCool/following{/other_user}","gists_url":"https://api.github.com/users/MylesIsCool/gists{/gist_id}","starred_url":"https://api.github.com/users/MylesIsCool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MylesIsCool/subscriptions","organizations_url":"https://api.github.com/users/MylesIsCool/orgs","repos_url":"https://api.github.com/users/MylesIsCool/repos","events_url":"https://api.github.com/users/MylesIsCool/events{/privacy}","received_events_url":"https://api.github.com/users/MylesIsCool/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MylesIsCool/ViaVersion","description":"Allows the connection of newer clients to older server versions for Minecraft servers.","fork":false,"url":"https://api.github.com/repos/MylesIsCool/ViaVersion","forks_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/forks","keys_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/teams","hooks_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/hooks","issue_events_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/issues/events{/number}","events_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/events","assignees_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/assignees{/user}","branches_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/branches{/branch}","tags_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/tags","blobs_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/git/refs{/sha}","trees_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/statuses/{sha}","languages_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/languages","stargazers_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/stargazers","contributors_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/contributors","subscribers_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/subscribers","subscription_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/subscription","commits_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/commits{/sha}","git_commits_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/git/commits{/sha}","comments_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/comments{/number}","issue_comment_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/issues/comments{/number}","contents_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/contents/{+path}","compare_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/merges","archive_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/downloads","issues_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/issues{/number}","pulls_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls{/number}","milestones_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/milestones{/number}","notifications_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/labels{/name}","releases_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/releases{/id}","deployments_url":"https://api.github.com/repos/MylesIsCool/ViaVersion/deployments","created_at":"2016-02-28T22:39:27Z","updated_at":"2017-05-18T21:22:24Z","pushed_at":"2017-05-22T12:38:44Z","git_url":"git://github.com/MylesIsCool/ViaVersion.git","ssh_url":"git@github.com:MylesIsCool/ViaVersion.git","clone_url":"https://github.com/MylesIsCool/ViaVersion.git","svn_url":"https://github.com/MylesIsCool/ViaVersion","homepage":"https://viaversion.com","size":1714,"stargazers_count":120,"watchers_count":120,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"open_issues_count":7,"forks":63,"open_issues":7,"watchers":120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls/659"},"html":{"href":"https://github.com/MylesIsCool/ViaVersion/pull/659"},"issue":{"href":"https://api.github.com/repos/MylesIsCool/ViaVersion/issues/659"},"comments":{"href":"https://api.github.com/repos/MylesIsCool/ViaVersion/issues/659/comments"},"review_comments":{"href":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls/659/comments"},"review_comment":{"href":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MylesIsCool/ViaVersion/pulls/659/commits"},"statuses":{"href":"https://api.github.com/repos/MylesIsCool/ViaVersion/statuses/06eefcfefd9dae57b662ae77d14398b14acb3110"}},"merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":116,"deletions":13,"changed_files":11}}
{"actor":{"display_login":"MylesIsCool"}}