{"action":"closed","number":12056,"pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/12056","id":119067233,"html_url":"https://github.com/xbmc/xbmc/pull/12056","diff_url":"https://github.com/xbmc/xbmc/pull/12056.diff","patch_url":"https://github.com/xbmc/xbmc/pull/12056.patch","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/12056","number":12056,"state":"closed","locked":false,"title":"Fix bookmark thumbnails creation when using amcodec","user":{"login":"codesnake","id":4332622,"avatar_url":"https://avatars0.githubusercontent.com/u/4332622?v=3","gravatar_id":"","url":"https://api.github.com/users/codesnake","html_url":"https://github.com/codesnake","followers_url":"https://api.github.com/users/codesnake/followers","following_url":"https://api.github.com/users/codesnake/following{/other_user}","gists_url":"https://api.github.com/users/codesnake/gists{/gist_id}","starred_url":"https://api.github.com/users/codesnake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesnake/subscriptions","organizations_url":"https://api.github.com/users/codesnake/orgs","repos_url":"https://api.github.com/users/codesnake/repos","events_url":"https://api.github.com/users/codesnake/events{/privacy}","received_events_url":"https://api.github.com/users/codesnake/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your change in the Title above -->\r\n\r\n## Description\r\nFix bookmark thumbnails creation when playing a video with amcodec.\r\n\r\n## Motivation and Context\r\nIf during a video playback using amcodec you add a bookmark, the bookmark is created but its thumbnail is always just a black bar. This PR fixes the creation of bookmark thumbnails for amcodec.\r\n\r\n## How Has This Been Tested?\r\nThis fix has been tested by creating bookmarks for different videos on WeTek Core (kernel 3.10) and WeTek Hub (kernel 3.14).\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n","created_at":"2017-05-04T21:09:02Z","updated_at":"2017-05-11T07:05:48Z","closed_at":"2017-05-11T07:05:48Z","merged_at":"2017-05-11T07:05:48Z","merge_commit_sha":"492ab0676ac7510fb1003d16c8ca70baed316f60","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/xbmc/xbmc/milestones/95","html_url":"https://github.com/xbmc/xbmc/milestone/95","labels_url":"https://api.github.com/repos/xbmc/xbmc/milestones/95/labels","id":2166828,"number":95,"title":"L 18.0-alpha1","description":"","creator":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars2.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":665,"state":"open","created_at":"2016-11-30T16:58:49Z","updated_at":"2017-05-11T07:05:48Z","due_on":"2017-05-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/xbmc/xbmc/pulls/12056/commits","review_comments_url":"https://api.github.com/repos/xbmc/xbmc/pulls/12056/comments","review_comment_url":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/12056/comments","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/25593b25aa2b50b8019474f8b57c788c841faa72","head":{"label":"codesnake:aml_fix_bookmark_thumbs","ref":"aml_fix_bookmark_thumbs","sha":"25593b25aa2b50b8019474f8b57c788c841faa72","user":{"login":"codesnake","id":4332622,"avatar_url":"https://avatars0.githubusercontent.com/u/4332622?v=3","gravatar_id":"","url":"https://api.github.com/users/codesnake","html_url":"https://github.com/codesnake","followers_url":"https://api.github.com/users/codesnake/followers","following_url":"https://api.github.com/users/codesnake/following{/other_user}","gists_url":"https://api.github.com/users/codesnake/gists{/gist_id}","starred_url":"https://api.github.com/users/codesnake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesnake/subscriptions","organizations_url":"https://api.github.com/users/codesnake/orgs","repos_url":"https://api.github.com/users/codesnake/repos","events_url":"https://api.github.com/users/codesnake/events{/privacy}","received_events_url":"https://api.github.com/users/codesnake/received_events","type":"User","site_admin":false},"repo":{"id":18849284,"name":"xbmc","full_name":"codesnake/xbmc","owner":{"login":"codesnake","id":4332622,"avatar_url":"https://avatars0.githubusercontent.com/u/4332622?v=3","gravatar_id":"","url":"https://api.github.com/users/codesnake","html_url":"https://github.com/codesnake","followers_url":"https://api.github.com/users/codesnake/followers","following_url":"https://api.github.com/users/codesnake/following{/other_user}","gists_url":"https://api.github.com/users/codesnake/gists{/gist_id}","starred_url":"https://api.github.com/users/codesnake/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codesnake/subscriptions","organizations_url":"https://api.github.com/users/codesnake/orgs","repos_url":"https://api.github.com/users/codesnake/repos","events_url":"https://api.github.com/users/codesnake/events{/privacy}","received_events_url":"https://api.github.com/users/codesnake/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/codesnake/xbmc","description":"XBMC Main Repository","fork":true,"url":"https://api.github.com/repos/codesnake/xbmc","forks_url":"https://api.github.com/repos/codesnake/xbmc/forks","keys_url":"https://api.github.com/repos/codesnake/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codesnake/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codesnake/xbmc/teams","hooks_url":"https://api.github.com/repos/codesnake/xbmc/hooks","issue_events_url":"https://api.github.com/repos/codesnake/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/codesnake/xbmc/events","assignees_url":"https://api.github.com/repos/codesnake/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/codesnake/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/codesnake/xbmc/tags","blobs_url":"https://api.github.com/repos/codesnake/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codesnake/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codesnake/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/codesnake/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codesnake/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/codesnake/xbmc/languages","stargazers_url":"https://api.github.com/repos/codesnake/xbmc/stargazers","contributors_url":"https://api.github.com/repos/codesnake/xbmc/contributors","subscribers_url":"https://api.github.com/repos/codesnake/xbmc/subscribers","subscription_url":"https://api.github.com/repos/codesnake/xbmc/subscription","commits_url":"https://api.github.com/repos/codesnake/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/codesnake/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/codesnake/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/codesnake/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/codesnake/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/codesnake/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codesnake/xbmc/merges","archive_url":"https://api.github.com/repos/codesnake/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codesnake/xbmc/downloads","issues_url":"https://api.github.com/repos/codesnake/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/codesnake/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/codesnake/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/codesnake/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codesnake/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/codesnake/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/codesnake/xbmc/deployments","created_at":"2014-04-16T17:37:34Z","updated_at":"2015-01-25T10:15:46Z","pushed_at":"2017-05-05T23:16:02Z","git_url":"git://github.com/codesnake/xbmc.git","ssh_url":"git@github.com:codesnake/xbmc.git","clone_url":"https://github.com/codesnake/xbmc.git","svn_url":"https://github.com/codesnake/xbmc","homepage":"http://xbmc.org","size":580873,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xbmc:master","ref":"master","sha":"b8ad238aa8010063eaf7d608d139002a50075e8d","user":{"login":"xbmc","id":199122,"avatar_url":"https://avatars1.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"repo":{"id":1217614,"name":"xbmc","full_name":"xbmc/xbmc","owner":{"login":"xbmc","id":199122,"avatar_url":"https://avatars1.githubusercontent.com/u/199122?v=3","gravatar_id":"","url":"https://api.github.com/users/xbmc","html_url":"https://github.com/xbmc","followers_url":"https://api.github.com/users/xbmc/followers","following_url":"https://api.github.com/users/xbmc/following{/other_user}","gists_url":"https://api.github.com/users/xbmc/gists{/gist_id}","starred_url":"https://api.github.com/users/xbmc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xbmc/subscriptions","organizations_url":"https://api.github.com/users/xbmc/orgs","repos_url":"https://api.github.com/users/xbmc/repos","events_url":"https://api.github.com/users/xbmc/events{/privacy}","received_events_url":"https://api.github.com/users/xbmc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xbmc/xbmc","description":"Kodi Main Repository - By using this code you agree with our policy and will follow the GPLv2 license as included","fork":false,"url":"https://api.github.com/repos/xbmc/xbmc","forks_url":"https://api.github.com/repos/xbmc/xbmc/forks","keys_url":"https://api.github.com/repos/xbmc/xbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xbmc/xbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xbmc/xbmc/teams","hooks_url":"https://api.github.com/repos/xbmc/xbmc/hooks","issue_events_url":"https://api.github.com/repos/xbmc/xbmc/issues/events{/number}","events_url":"https://api.github.com/repos/xbmc/xbmc/events","assignees_url":"https://api.github.com/repos/xbmc/xbmc/assignees{/user}","branches_url":"https://api.github.com/repos/xbmc/xbmc/branches{/branch}","tags_url":"https://api.github.com/repos/xbmc/xbmc/tags","blobs_url":"https://api.github.com/repos/xbmc/xbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xbmc/xbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xbmc/xbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/xbmc/xbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xbmc/xbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/xbmc/xbmc/languages","stargazers_url":"https://api.github.com/repos/xbmc/xbmc/stargazers","contributors_url":"https://api.github.com/repos/xbmc/xbmc/contributors","subscribers_url":"https://api.github.com/repos/xbmc/xbmc/subscribers","subscription_url":"https://api.github.com/repos/xbmc/xbmc/subscription","commits_url":"https://api.github.com/repos/xbmc/xbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/xbmc/xbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/xbmc/xbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/xbmc/xbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/xbmc/xbmc/contents/{+path}","compare_url":"https://api.github.com/repos/xbmc/xbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xbmc/xbmc/merges","archive_url":"https://api.github.com/repos/xbmc/xbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xbmc/xbmc/downloads","issues_url":"https://api.github.com/repos/xbmc/xbmc/issues{/number}","pulls_url":"https://api.github.com/repos/xbmc/xbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/xbmc/xbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/xbmc/xbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xbmc/xbmc/labels{/name}","releases_url":"https://api.github.com/repos/xbmc/xbmc/releases{/id}","deployments_url":"https://api.github.com/repos/xbmc/xbmc/deployments","created_at":"2011-01-03T21:18:51Z","updated_at":"2017-05-11T03:19:20Z","pushed_at":"2017-05-11T07:05:48Z","git_url":"git://github.com/xbmc/xbmc.git","ssh_url":"git@github.com:xbmc/xbmc.git","clone_url":"https://github.com/xbmc/xbmc.git","svn_url":"https://github.com/xbmc/xbmc","homepage":"http://kodi.wiki/view/Official:Trademark_Policy","size":1405981,"stargazers_count":5895,"watchers_count":5895,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4122,"mirror_url":null,"open_issues_count":169,"forks":4122,"open_issues":169,"watchers":5895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/12056"},"html":{"href":"https://github.com/xbmc/xbmc/pull/12056"},"issue":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/12056"},"comments":{"href":"https://api.github.com/repos/xbmc/xbmc/issues/12056/comments"},"review_comments":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/12056/comments"},"review_comment":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xbmc/xbmc/pulls/12056/commits"},"statuses":{"href":"https://api.github.com/repos/xbmc/xbmc/statuses/25593b25aa2b50b8019474f8b57c788c841faa72"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"MartijnKaijser","id":907436,"avatar_url":"https://avatars2.githubusercontent.com/u/907436?v=3","gravatar_id":"","url":"https://api.github.com/users/MartijnKaijser","html_url":"https://github.com/MartijnKaijser","followers_url":"https://api.github.com/users/MartijnKaijser/followers","following_url":"https://api.github.com/users/MartijnKaijser/following{/other_user}","gists_url":"https://api.github.com/users/MartijnKaijser/gists{/gist_id}","starred_url":"https://api.github.com/users/MartijnKaijser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartijnKaijser/subscriptions","organizations_url":"https://api.github.com/users/MartijnKaijser/orgs","repos_url":"https://api.github.com/users/MartijnKaijser/repos","events_url":"https://api.github.com/users/MartijnKaijser/events{/privacy}","received_events_url":"https://api.github.com/users/MartijnKaijser/received_events","type":"User","site_admin":false},"comments":6,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":25,"deletions":20,"changed_files":2}}
{"actor":{"display_login":"MartijnKaijser"}}