{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/158890069","pull_request_review_id":85758312,"id":158890069,"diff_hunk":"@@ -1184,6 +1184,28 @@ namespace ts.projectSystem {\n             checkNumberOfInferredProjects(projectService, 0);\r\n         });\r\n \r\n+        it(\"external project for dynamic file\", () => {\r\n+            const file1 = {\r","path":"src/harness/unittests/tsserverProjectSystem.ts","position":5,"original_position":5,"commit_id":"90e11f079780c62d7463bbcc0ed93822c51f56b4","original_commit_id":"90e11f079780c62d7463bbcc0ed93822c51f56b4","user":{"login":"sheetalkamat","id":8052792,"avatar_url":"https://avatars2.githubusercontent.com/u/8052792?v=4","gravatar_id":"","url":"https://api.github.com/users/sheetalkamat","html_url":"https://github.com/sheetalkamat","followers_url":"https://api.github.com/users/sheetalkamat/followers","following_url":"https://api.github.com/users/sheetalkamat/following{/other_user}","gists_url":"https://api.github.com/users/sheetalkamat/gists{/gist_id}","starred_url":"https://api.github.com/users/sheetalkamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheetalkamat/subscriptions","organizations_url":"https://api.github.com/users/sheetalkamat/orgs","repos_url":"https://api.github.com/users/sheetalkamat/repos","events_url":"https://api.github.com/users/sheetalkamat/events{/privacy}","received_events_url":"https://api.github.com/users/sheetalkamat/received_events","type":"User","site_admin":false},"body":"You dont need this at all.. better to remove.","created_at":"2017-12-28T02:32:30Z","updated_at":"2017-12-28T02:32:30Z","html_url":"https://github.com/Microsoft/TypeScript/pull/20910#discussion_r158890069","pull_request_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/20910","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments/158890069"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/20910#discussion_r158890069"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/20910"}},"in_reply_to_id":158874354},"pull_request":{"url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/20910","id":160292299,"html_url":"https://github.com/Microsoft/TypeScript/pull/20910","diff_url":"https://github.com/Microsoft/TypeScript/pull/20910.diff","patch_url":"https://github.com/Microsoft/TypeScript/pull/20910.patch","issue_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/20910","number":20910,"state":"open","locked":false,"title":"Allow dynamic files script info to be created when not opened by client","user":{"login":"uniqueiniquity","id":9092011,"avatar_url":"https://avatars1.githubusercontent.com/u/9092011?v=4","gravatar_id":"","url":"https://api.github.com/users/uniqueiniquity","html_url":"https://github.com/uniqueiniquity","followers_url":"https://api.github.com/users/uniqueiniquity/followers","following_url":"https://api.github.com/users/uniqueiniquity/following{/other_user}","gists_url":"https://api.github.com/users/uniqueiniquity/gists{/gist_id}","starred_url":"https://api.github.com/users/uniqueiniquity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uniqueiniquity/subscriptions","organizations_url":"https://api.github.com/users/uniqueiniquity/orgs","repos_url":"https://api.github.com/users/uniqueiniquity/repos","events_url":"https://api.github.com/users/uniqueiniquity/events{/privacy}","received_events_url":"https://api.github.com/users/uniqueiniquity/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for submitting a pull request!\r\n\r\nHere's a checklist you might find useful.\r\n[ ] There is an associated issue that is labelled\r\n  'Bug' or 'help wanted' or is in the Community milestone\r\n[ ] Code is up-to-date with the `master` branch\r\n[ ] You've successfully run `jake runtests` locally\r\n[ ] You've signed the CLA\r\n[ ] There are new or updated unit tests validating the change\r\n\r\nRefer to CONTRIBUTING.MD for more details.\r\n  https://github.com/Microsoft/TypeScript/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\nCurrently, if a dynamic file is opened in VS, either the language service will fail to start or the file will be incorrectly added to an inferred project rather than the intended external project. \r\nThis change allows the script info for the dynamic file to be created as part of a call to `openExternalProjects`, thereby resolving the issue.\r\n","created_at":"2017-12-27T19:24:06Z","updated_at":"2017-12-28T02:32:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e983785bf524f139c6bac46a5d6c2302d325c835","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/20910/commits","review_comments_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/20910/comments","review_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/20910/comments","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/90e11f079780c62d7463bbcc0ed93822c51f56b4","head":{"label":"uniqueiniquity:allowDynamicNotOpenByClient","ref":"allowDynamicNotOpenByClient","sha":"90e11f079780c62d7463bbcc0ed93822c51f56b4","user":{"login":"uniqueiniquity","id":9092011,"avatar_url":"https://avatars1.githubusercontent.com/u/9092011?v=4","gravatar_id":"","url":"https://api.github.com/users/uniqueiniquity","html_url":"https://github.com/uniqueiniquity","followers_url":"https://api.github.com/users/uniqueiniquity/followers","following_url":"https://api.github.com/users/uniqueiniquity/following{/other_user}","gists_url":"https://api.github.com/users/uniqueiniquity/gists{/gist_id}","starred_url":"https://api.github.com/users/uniqueiniquity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uniqueiniquity/subscriptions","organizations_url":"https://api.github.com/users/uniqueiniquity/orgs","repos_url":"https://api.github.com/users/uniqueiniquity/repos","events_url":"https://api.github.com/users/uniqueiniquity/events{/privacy}","received_events_url":"https://api.github.com/users/uniqueiniquity/received_events","type":"User","site_admin":false},"repo":{"id":99018967,"name":"TypeScript","full_name":"uniqueiniquity/TypeScript","owner":{"login":"uniqueiniquity","id":9092011,"avatar_url":"https://avatars1.githubusercontent.com/u/9092011?v=4","gravatar_id":"","url":"https://api.github.com/users/uniqueiniquity","html_url":"https://github.com/uniqueiniquity","followers_url":"https://api.github.com/users/uniqueiniquity/followers","following_url":"https://api.github.com/users/uniqueiniquity/following{/other_user}","gists_url":"https://api.github.com/users/uniqueiniquity/gists{/gist_id}","starred_url":"https://api.github.com/users/uniqueiniquity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uniqueiniquity/subscriptions","organizations_url":"https://api.github.com/users/uniqueiniquity/orgs","repos_url":"https://api.github.com/users/uniqueiniquity/repos","events_url":"https://api.github.com/users/uniqueiniquity/events{/privacy}","received_events_url":"https://api.github.com/users/uniqueiniquity/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/uniqueiniquity/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":true,"url":"https://api.github.com/repos/uniqueiniquity/TypeScript","forks_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/forks","keys_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/teams","hooks_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/events","assignees_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/tags","blobs_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/languages","stargazers_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/subscription","commits_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/merges","archive_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/downloads","issues_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/uniqueiniquity/TypeScript/deployments","created_at":"2017-08-01T15:57:12Z","updated_at":"2017-08-01T15:58:03Z","pushed_at":"2017-12-28T00:58:21Z","git_url":"git://github.com/uniqueiniquity/TypeScript.git","ssh_url":"git@github.com:uniqueiniquity/TypeScript.git","clone_url":"https://github.com/uniqueiniquity/TypeScript.git","svn_url":"https://github.com/uniqueiniquity/TypeScript","homepage":"http://www.typescriptlang.org","size":488178,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"b15ecfc51c84cc3b9a44d3ee167c2d18e7664278","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":20929025,"name":"TypeScript","full_name":"Microsoft/TypeScript","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/TypeScript","description":"TypeScript is a superset of JavaScript that compiles to clean JavaScript output.","fork":false,"url":"https://api.github.com/repos/Microsoft/TypeScript","forks_url":"https://api.github.com/repos/Microsoft/TypeScript/forks","keys_url":"https://api.github.com/repos/Microsoft/TypeScript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/TypeScript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/TypeScript/teams","hooks_url":"https://api.github.com/repos/Microsoft/TypeScript/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/TypeScript/events","assignees_url":"https://api.github.com/repos/Microsoft/TypeScript/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/TypeScript/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/TypeScript/tags","blobs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/TypeScript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/TypeScript/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/TypeScript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/TypeScript/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/TypeScript/languages","stargazers_url":"https://api.github.com/repos/Microsoft/TypeScript/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/TypeScript/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/TypeScript/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/TypeScript/subscription","commits_url":"https://api.github.com/repos/Microsoft/TypeScript/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/TypeScript/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/TypeScript/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/TypeScript/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/TypeScript/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/TypeScript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/TypeScript/merges","archive_url":"https://api.github.com/repos/Microsoft/TypeScript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/TypeScript/downloads","issues_url":"https://api.github.com/repos/Microsoft/TypeScript/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/TypeScript/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/TypeScript/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/TypeScript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/TypeScript/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/TypeScript/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/TypeScript/deployments","created_at":"2014-06-17T15:28:39Z","updated_at":"2017-12-28T02:15:39Z","pushed_at":"2017-12-28T01:06:07Z","git_url":"git://github.com/Microsoft/TypeScript.git","ssh_url":"git@github.com:Microsoft/TypeScript.git","clone_url":"https://github.com/Microsoft/TypeScript.git","svn_url":"https://github.com/Microsoft/TypeScript","homepage":"http://www.typescriptlang.org","size":493941,"stargazers_count":29312,"watchers_count":29312,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4315,"mirror_url":null,"archived":false,"open_issues_count":2747,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4315,"open_issues":2747,"watchers":29312,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/20910"},"html":{"href":"https://github.com/Microsoft/TypeScript/pull/20910"},"issue":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/20910"},"comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/issues/20910/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/20910/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/TypeScript/pulls/20910/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/TypeScript/statuses/90e11f079780c62d7463bbcc0ed93822c51f56b4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sheetalkamat"}}