{"action":"created","issue":{"url":"https://api.github.com/repos/Netflix/falcor-json-graph/issues/7","repository_url":"https://api.github.com/repos/Netflix/falcor-json-graph","labels_url":"https://api.github.com/repos/Netflix/falcor-json-graph/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/Netflix/falcor-json-graph/issues/7/comments","events_url":"https://api.github.com/repos/Netflix/falcor-json-graph/issues/7/events","html_url":"https://github.com/Netflix/falcor-json-graph/pull/7","id":280350937,"number":7,"title":"Refactor and add Flow types.","user":{"login":"lrowe","id":290859,"avatar_url":"https://avatars0.githubusercontent.com/u/290859?v=4","gravatar_id":"","url":"https://api.github.com/users/lrowe","html_url":"https://github.com/lrowe","followers_url":"https://api.github.com/users/lrowe/followers","following_url":"https://api.github.com/users/lrowe/following{/other_user}","gists_url":"https://api.github.com/users/lrowe/gists{/gist_id}","starred_url":"https://api.github.com/users/lrowe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrowe/subscriptions","organizations_url":"https://api.github.com/users/lrowe/orgs","repos_url":"https://api.github.com/users/lrowe/repos","events_url":"https://api.github.com/users/lrowe/events{/privacy}","received_events_url":"https://api.github.com/users/lrowe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-12-08T02:40:11Z","updated_at":"2017-12-12T02:15:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Netflix/falcor-json-graph/pulls/7","html_url":"https://github.com/Netflix/falcor-json-graph/pull/7","diff_url":"https://github.com/Netflix/falcor-json-graph/pull/7.diff","patch_url":"https://github.com/Netflix/falcor-json-graph/pull/7.patch"},"body":"Refactored adding flow type definitions, tests, and enable CI.\r\n\r\nThis includes IDataSource. To avoid a dependency on falcor-observable I've copied the structural IObservable type here.\r\n\r\nPoints of interest:\r\n\r\n* JsonGraphError.value type is `ConstJsonValue`.\r\n* IDataSource.call args type is `JsonGraphNode[]`.\r\n* Key type is now `string | number | boolean | null`. Non string values are equivalent to `String(value)`.\r\n* PathValue.path and PathInvalidation.path types are `PathSet`.\r\n\r\nImpact of changes:\r\n\r\nThis package is currently depended on only by the Falcor client which exposes the atom/error/ref helpers on the Model and calls pathValue in setValue. As such it become part of the built artifact for the Falcor client. We're comfortable the switching from var to const will not create any problems for our supported platforms."},"comment":{"url":"https://api.github.com/repos/Netflix/falcor-json-graph/issues/comments/350923045","html_url":"https://github.com/Netflix/falcor-json-graph/pull/7#issuecomment-350923045","issue_url":"https://api.github.com/repos/Netflix/falcor-json-graph/issues/7","id":350923045,"user":{"login":"jhusain","id":466863,"avatar_url":"https://avatars2.githubusercontent.com/u/466863?v=4","gravatar_id":"","url":"https://api.github.com/users/jhusain","html_url":"https://github.com/jhusain","followers_url":"https://api.github.com/users/jhusain/followers","following_url":"https://api.github.com/users/jhusain/following{/other_user}","gists_url":"https://api.github.com/users/jhusain/gists{/gist_id}","starred_url":"https://api.github.com/users/jhusain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhusain/subscriptions","organizations_url":"https://api.github.com/users/jhusain/orgs","repos_url":"https://api.github.com/users/jhusain/repos","events_url":"https://api.github.com/users/jhusain/events{/privacy}","received_events_url":"https://api.github.com/users/jhusain/received_events","type":"User","site_admin":false},"created_at":"2017-12-12T02:15:45Z","updated_at":"2017-12-12T02:15:45Z","author_association":"CONTRIBUTOR","body":"Communicated some feedback offline. Otherwise LGTM."}}
{"actor":{"display_login":"jhusain"}}