{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/147182581","pull_request_review_id":72241734,"id":147182581,"diff_hunk":"@@ -22,9 +19,25 @@ class AssetBundle {\n   static const String defaultManifestPath = 'pubspec.yaml';\n   static const String _kAssetManifestJson = 'AssetManifest.json';\n   static const String _kFontManifestJson = 'FontManifest.json';\n-  static const String _kFontSetMaterial = 'material';\n   static const String _kLICENSE = 'LICENSE';\n \n+  static const String _materialIconsFontUpgradeInstructions = '''\n+═══════════════════════════════════════════════════════════════════════════════════\n+'uses-material-design' in pubspec.yaml is deprecated\n+\n+The flag is now replaced by a generic Dart package to provide the Material icons asset.\n+\n+Replace","path":"packages/flutter_tools/lib/src/asset.dart","position":25,"original_position":25,"commit_id":"58eef0d4be1027d4923c251eb242a07035b40c52","original_commit_id":"58eef0d4be1027d4923c251eb242a07035b40c52","user":{"login":"pq","id":67586,"avatar_url":"https://avatars3.githubusercontent.com/u/67586?v=4","gravatar_id":"","url":"https://api.github.com/users/pq","html_url":"https://github.com/pq","followers_url":"https://api.github.com/users/pq/followers","following_url":"https://api.github.com/users/pq/following{/other_user}","gists_url":"https://api.github.com/users/pq/gists{/gist_id}","starred_url":"https://api.github.com/users/pq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pq/subscriptions","organizations_url":"https://api.github.com/users/pq/orgs","repos_url":"https://api.github.com/users/pq/repos","events_url":"https://api.github.com/users/pq/events{/privacy}","received_events_url":"https://api.github.com/users/pq/received_events","type":"User","site_admin":false},"body":"Interesting!\r\n\r\nIf someone could capture the advice in a sentence (or more), I'll open a lint request.  Thanks!","created_at":"2017-10-26T15:39:21Z","updated_at":"2017-10-26T15:39:21Z","html_url":"https://github.com/flutter/flutter/pull/12730#discussion_r147182581","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/12730","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/147182581"},"html":{"href":"https://github.com/flutter/flutter/pull/12730#discussion_r147182581"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/12730"}},"in_reply_to_id":147179475},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/12730","id":148811946,"html_url":"https://github.com/flutter/flutter/pull/12730","diff_url":"https://github.com/flutter/flutter/pull/12730.diff","patch_url":"https://github.com/flutter/flutter/pull/12730.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/12730","number":12730,"state":"open","locked":false,"title":"Let Flutter tools get material icons from pub package instead of special logic","user":{"login":"xster","id":156888,"avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"body":"- Removes logic to embed fonts based on the `uses-material-design:` flag in pubspec.yaml\r\n- Stop caching the material fonts in Flutter tools artifacts\r\n- Update material Icons to refer to glyphs from the `material_icons_font` package\r\n- Update the font update script\r\n- Add a project pubspec upgrade warning message for existing projects\r\n- Tests\r\n\r\nAfter submit:\r\n- [ ] Update https://github.com/flutter/flutter/wiki/Updating-Material-Design-Fonts \r\n- [ ] Send announcement\r\n- [ ] Update [all usages in the Flutter org](https://github.com/search?p=3&q=org%3Aflutter+uses-material-design&type=Code)\r\n- [ ] Rename the cupertino_icons package to cupertino_icons_font for consistency (because material_icons is already taken on pub)\r\n\r\n_API BREAK_\r\nWill require manual upgrade from [~1000 project pubspec.yaml on GitHub](https://github.com/search?utf8=%E2%9C%93&q=uses-material-design&type=Code)\r\n\r\n## Upgrade instructions\r\nFor existing projects, go to pubspec.yaml and change\r\n```\r\nname: [...]\r\ndependencies:\r\n  [...]\r\nflutter: \r\n  uses-material-design: true\r\n  [...]\r\n```\r\ninto\r\n```\r\nname: [...]\r\ndependencies:\r\n  [...]\r\n  material_icons_font: ^0.1.1\r\nflutter:\r\n  [...]\r\n```\r\nto continue to use the icons assets referred to by the Material [Icons class](https://github.com/flutter/flutter/blob/master/packages/flutter/lib/src/material/icons.dart)","created_at":"2017-10-26T00:25:19Z","updated_at":"2017-10-26T15:39:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d93c3f03623e2cff0fa8a2c9b7099f4bf35ec338","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cbracken","id":351029,"avatar_url":"https://avatars3.githubusercontent.com/u/351029?v=4","gravatar_id":"","url":"https://api.github.com/users/cbracken","html_url":"https://github.com/cbracken","followers_url":"https://api.github.com/users/cbracken/followers","following_url":"https://api.github.com/users/cbracken/following{/other_user}","gists_url":"https://api.github.com/users/cbracken/gists{/gist_id}","starred_url":"https://api.github.com/users/cbracken/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbracken/subscriptions","organizations_url":"https://api.github.com/users/cbracken/orgs","repos_url":"https://api.github.com/users/cbracken/repos","events_url":"https://api.github.com/users/cbracken/events{/privacy}","received_events_url":"https://api.github.com/users/cbracken/received_events","type":"User","site_admin":false},{"login":"Hixie","id":551196,"avatar_url":"https://avatars2.githubusercontent.com/u/551196?v=4","gravatar_id":"","url":"https://api.github.com/users/Hixie","html_url":"https://github.com/Hixie","followers_url":"https://api.github.com/users/Hixie/followers","following_url":"https://api.github.com/users/Hixie/following{/other_user}","gists_url":"https://api.github.com/users/Hixie/gists{/gist_id}","starred_url":"https://api.github.com/users/Hixie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hixie/subscriptions","organizations_url":"https://api.github.com/users/Hixie/orgs","repos_url":"https://api.github.com/users/Hixie/repos","events_url":"https://api.github.com/users/Hixie/events{/privacy}","received_events_url":"https://api.github.com/users/Hixie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/12730/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/12730/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/12730/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/58eef0d4be1027d4923c251eb242a07035b40c52","head":{"label":"xster:material-font","ref":"material-font","sha":"58eef0d4be1027d4923c251eb242a07035b40c52","user":{"login":"xster","id":156888,"avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"repo":{"id":79845855,"name":"flutter","full_name":"xster/flutter","owner":{"login":"xster","id":156888,"avatar_url":"https://avatars2.githubusercontent.com/u/156888?v=4","gravatar_id":"","url":"https://api.github.com/users/xster","html_url":"https://github.com/xster","followers_url":"https://api.github.com/users/xster/followers","following_url":"https://api.github.com/users/xster/following{/other_user}","gists_url":"https://api.github.com/users/xster/gists{/gist_id}","starred_url":"https://api.github.com/users/xster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xster/subscriptions","organizations_url":"https://api.github.com/users/xster/orgs","repos_url":"https://api.github.com/users/xster/repos","events_url":"https://api.github.com/users/xster/events{/privacy}","received_events_url":"https://api.github.com/users/xster/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xster/flutter","description":"Framework for building high-performance, high-fidelity iOS and Android apps.","fork":true,"url":"https://api.github.com/repos/xster/flutter","forks_url":"https://api.github.com/repos/xster/flutter/forks","keys_url":"https://api.github.com/repos/xster/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xster/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xster/flutter/teams","hooks_url":"https://api.github.com/repos/xster/flutter/hooks","issue_events_url":"https://api.github.com/repos/xster/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/xster/flutter/events","assignees_url":"https://api.github.com/repos/xster/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/xster/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/xster/flutter/tags","blobs_url":"https://api.github.com/repos/xster/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xster/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xster/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/xster/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xster/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/xster/flutter/languages","stargazers_url":"https://api.github.com/repos/xster/flutter/stargazers","contributors_url":"https://api.github.com/repos/xster/flutter/contributors","subscribers_url":"https://api.github.com/repos/xster/flutter/subscribers","subscription_url":"https://api.github.com/repos/xster/flutter/subscription","commits_url":"https://api.github.com/repos/xster/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/xster/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/xster/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/xster/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/xster/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/xster/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xster/flutter/merges","archive_url":"https://api.github.com/repos/xster/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xster/flutter/downloads","issues_url":"https://api.github.com/repos/xster/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/xster/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/xster/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/xster/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xster/flutter/labels{/name}","releases_url":"https://api.github.com/repos/xster/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/xster/flutter/deployments","created_at":"2017-01-23T20:41:37Z","updated_at":"2017-01-23T20:41:42Z","pushed_at":"2017-10-26T01:07:36Z","git_url":"git://github.com/xster/flutter.git","ssh_url":"git@github.com:xster/flutter.git","clone_url":"https://github.com/xster/flutter.git","svn_url":"https://github.com/xster/flutter","homepage":"https://flutter.io","size":30640,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"7f0d4f4caae30d20670a8f3272fa1c70170ace8a","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-10-26T14:16:36Z","pushed_at":"2017-10-26T09:27:28Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":30642,"stargazers_count":8124,"watchers_count":8124,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":756,"mirror_url":null,"archived":false,"open_issues_count":1918,"forks":756,"open_issues":1918,"watchers":8124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/12730"},"html":{"href":"https://github.com/flutter/flutter/pull/12730"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/12730"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/12730/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/12730/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/12730/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/58eef0d4be1027d4923c251eb242a07035b40c52"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pq"}}