{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gporca/issues/140","repository_url":"https://api.github.com/repos/greenplum-db/gporca","labels_url":"https://api.github.com/repos/greenplum-db/gporca/issues/140/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gporca/issues/140/comments","events_url":"https://api.github.com/repos/greenplum-db/gporca/issues/140/events","html_url":"https://github.com/greenplum-db/gporca/pull/140","id":202260186,"number":140,"title":"Fix populating config.h.","user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-01-20T22:36:54Z","updated_at":"2017-01-21T01:42:43Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gporca/pulls/140","html_url":"https://github.com/greenplum-db/gporca/pull/140","diff_url":"https://github.com/greenplum-db/gporca/pull/140.diff","patch_url":"https://github.com/greenplum-db/gporca/pull/140.patch"},"body":"Commmit 76af81942a, to generate a config.h with all the required GPOS_*\r\nflags that affect the API of the resulting binaries, most notably\r\nGPOS_DEBUG, was broken. It didn't derive the GPOS_DEBUG flag from\r\nfrom CMAKE_BUILD_TYPE sit should've. It did the right thing if you set\r\n\"GPOS_DEBUG=1\" property on the cmake command line, but that property was\r\nnot set automatically with CMAKE_BUILD_TYPE=Debug. CMAKE_BUILD_TYPE=Debug\r\nadded GPOS_DEBUG=1 to the COMPILE_DEFINITIONS property, but that's different\r\nfrom having a stand-along GPOS_DEBUG property.\r\n\r\nLikewise, the GPOS_<arch> and GPOS_32BIT/64BIT variables were also not set\r\ncorrectly. The reason I didn't notice this while testing was that the\r\nflags in COMPILE_DEFINITIONS were still set, even though if config.h was\r\ngenerated correctly, those would not have been necessary aynmore.\r\n\r\nTo fix, remove those flags from COMPILE_DEFINITIONS so that they are not\r\npassed to the compiler command line anymore. The defines are now always\r\nread from the config.h file, and the defines are set correctly in config.h.\r\n\r\nPer report off-list by Jesse Zhang."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gporca/issues/comments/274223187","html_url":"https://github.com/greenplum-db/gporca/pull/140#issuecomment-274223187","issue_url":"https://api.github.com/repos/greenplum-db/gporca/issues/140","id":274223187,"user":{"login":"vraghavan78","id":12649877,"avatar_url":"https://avatars.githubusercontent.com/u/12649877?v=3","gravatar_id":"","url":"https://api.github.com/users/vraghavan78","html_url":"https://github.com/vraghavan78","followers_url":"https://api.github.com/users/vraghavan78/followers","following_url":"https://api.github.com/users/vraghavan78/following{/other_user}","gists_url":"https://api.github.com/users/vraghavan78/gists{/gist_id}","starred_url":"https://api.github.com/users/vraghavan78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vraghavan78/subscriptions","organizations_url":"https://api.github.com/users/vraghavan78/orgs","repos_url":"https://api.github.com/users/vraghavan78/repos","events_url":"https://api.github.com/users/vraghavan78/events{/privacy}","received_events_url":"https://api.github.com/users/vraghavan78/received_events","type":"User","site_admin":false},"created_at":"2017-01-21T01:42:43Z","updated_at":"2017-01-21T01:42:43Z","body":"Thanks @hlinnaka @d @khannaekta for working on this. GPDB now compile."}}
{"actor":{"display_login":"vraghavan78"}}