{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/20422","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20422/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20422/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20422/events","html_url":"https://github.com/cms-sw/cmssw/pull/20422","id":255998296,"number":20422,"title":"include dark current contribution in M2 pedestal constraint for Phase2","user":{"login":"kpedro88","id":4672808,"avatar_url":"https://avatars0.githubusercontent.com/u/4672808?v=4","gravatar_id":"","url":"https://api.github.com/users/kpedro88","html_url":"https://github.com/kpedro88","followers_url":"https://api.github.com/users/kpedro88/followers","following_url":"https://api.github.com/users/kpedro88/following{/other_user}","gists_url":"https://api.github.com/users/kpedro88/gists{/gist_id}","starred_url":"https://api.github.com/users/kpedro88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpedro88/subscriptions","organizations_url":"https://api.github.com/users/kpedro88/orgs","repos_url":"https://api.github.com/users/kpedro88/repos","events_url":"https://api.github.com/users/kpedro88/events{/privacy}","received_events_url":"https://api.github.com/users/kpedro88/received_events","type":"User","site_admin":false},"labels":[{"id":673935056,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-pending","name":"code-checks-pending","color":"fbca04","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":52822551,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/hlt-pending","name":"hlt-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":56131152,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-pending","name":"tests-pending","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/71","html_url":"https://github.com/cms-sw/cmssw/milestone/71","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/71/labels","id":2747412,"number":71,"title":"CMSSW_9_4_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":84,"closed_issues":7,"state":"open","created_at":"2017-09-06T08:22:14Z","updated_at":"2017-09-07T16:33:20Z","due_on":null,"closed_at":null},"comments":11,"created_at":"2017-09-07T16:33:02Z","updated_at":"2017-09-07T16:42:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/20422","html_url":"https://github.com/cms-sw/cmssw/pull/20422","diff_url":"https://github.com/cms-sw/cmssw/pull/20422.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/20422.patch"},"body":"When SiPM aging is enabled, the dark current (an extra source of electronics noise, separate from the regular pedestal) can increase drastically. The pedestal constraint in HCAL Method 2 reconstruction did not account for this increase, leading to biased energy for some RecHits. Now it is included, but only enabled for Phase2. An additional parameter is added to the Method 2 parameter set, which must eventually be propagated to HLT separately (since M2 parameters are not kept in fillDescriptions).\r\n\r\nSee the presentation https://indico.cern.ch/event/664043/contributions/2713101/attachments/1519347/2372809/hcal_raddam_phase2_status_sept_6_2017.pdf and this plot that demonstrates improvement in jet energy response:\r\n![JER w/ M2 fix](http://kjplanet.com/pr/RelValRelRspVsRefPt_JetEta0.5to1.3_ak4pfl2l3.png)\r\n\r\nThis PR will be backported to 93X for inclusion in the HGCal TDR release (hopefully).\r\n\r\nattn: @abdoulline @mariadalfonso @hatakeyamak "},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/327856358","html_url":"https://github.com/cms-sw/cmssw/pull/20422#issuecomment-327856358","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/20422","id":327856358,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars1.githubusercontent.com/u/4170616?v=4","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2017-09-07T16:42:05Z","updated_at":"2017-09-07T16:42:05Z","author_association":"CONTRIBUTOR","body":"+code-checks\n\nLogs: https://cmssdt.cern.ch/SDT/code-checks/PR-20422/564"}}
{"actor":{"display_login":"cmsbuild"}}