{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/contrib/issues/2384","repository_url":"https://api.github.com/repos/kubernetes/contrib","labels_url":"https://api.github.com/repos/kubernetes/contrib/issues/2384/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/contrib/issues/2384/comments","events_url":"https://api.github.com/repos/kubernetes/contrib/issues/2384/events","html_url":"https://github.com/kubernetes/contrib/pull/2384","id":207576519,"number":2384,"title":"[keepalived-vip] Support for configurable virtual router id","user":{"login":"cdemers","id":595362,"avatar_url":"https://avatars3.githubusercontent.com/u/595362?v=3","gravatar_id":"","url":"https://api.github.com/users/cdemers","html_url":"https://github.com/cdemers","followers_url":"https://api.github.com/users/cdemers/followers","following_url":"https://api.github.com/users/cdemers/following{/other_user}","gists_url":"https://api.github.com/users/cdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/cdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdemers/subscriptions","organizations_url":"https://api.github.com/users/cdemers/orgs","repos_url":"https://api.github.com/users/cdemers/repos","events_url":"https://api.github.com/users/cdemers/events{/privacy}","received_events_url":"https://api.github.com/users/cdemers/received_events","type":"User","site_admin":false},"labels":[{"id":447087456,"url":"https://api.github.com/repos/kubernetes/contrib/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars0.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"assignees":[{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars0.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"milestone":null,"comments":8,"created_at":"2017-02-14T17:05:20Z","updated_at":"2017-03-07T15:54:27Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/contrib/pulls/2384","html_url":"https://github.com/kubernetes/contrib/pull/2384","diff_url":"https://github.com/kubernetes/contrib/pull/2384.diff","patch_url":"https://github.com/kubernetes/contrib/pull/2384.patch"},"body":"Hi all, I submit this small PR.\r\n\r\nIt adds support for configurable keepalived _virtual router id_.   This functionality is necessary in order to be able to run multiple keepalived \"clusters\" in the same subnet without having them stepping on each other's toes (having one node from one group confusing the other group into thinking it has a master).\r\n\r\nThe configuration of the _virtual router id_ is done using the `--router-id` command line flag. I considered using the project's _configmap_ but the structure of the existing _configmap_ is not easily expandable, so I had to use a flag (I would have added support for environment variables, but it didn't seems to be in line with the way this application is thought out, so I refrained).\r\n\r\nThe flag can be specified in a k8s object with the `args` key, for example:\r\n`- args: [\"--services-configmap=admin/vip-configmap\", \"--router-id=45\"]`\r\n\r\nIf not specified, it will default to router id _50_ as it was before.\r\n\r\nThat's pretty much all there is to it, thanks in advance for your time!"},"comment":{"url":"https://api.github.com/repos/kubernetes/contrib/issues/comments/284762428","html_url":"https://github.com/kubernetes/contrib/pull/2384#issuecomment-284762428","issue_url":"https://api.github.com/repos/kubernetes/contrib/issues/2384","id":284762428,"user":{"login":"cdemers","id":595362,"avatar_url":"https://avatars3.githubusercontent.com/u/595362?v=3","gravatar_id":"","url":"https://api.github.com/users/cdemers","html_url":"https://github.com/cdemers","followers_url":"https://api.github.com/users/cdemers/followers","following_url":"https://api.github.com/users/cdemers/following{/other_user}","gists_url":"https://api.github.com/users/cdemers/gists{/gist_id}","starred_url":"https://api.github.com/users/cdemers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdemers/subscriptions","organizations_url":"https://api.github.com/users/cdemers/orgs","repos_url":"https://api.github.com/users/cdemers/repos","events_url":"https://api.github.com/users/cdemers/events{/privacy}","received_events_url":"https://api.github.com/users/cdemers/received_events","type":"User","site_admin":false},"created_at":"2017-03-07T15:54:27Z","updated_at":"2017-03-07T15:54:27Z","body":"Hi @mikedanese, any chance you might have a look at this? I'm not sure I follow the right process, I'm pretty new at this.\r\nThanks!"}}
{"actor":{"display_login":"cdemers"}}