{"action":"created","comment":{"url":"https://api.github.com/repos/akuhlens/schml/pulls/comments/137444804","pull_request_review_id":61111574,"id":137444804,"diff_hunk":"@@ -1463,54 +1352,144 @@ but a static single assignment is implicitly maintained.\n     [(Static-Id u) (Var u)]\n     [other (error 'specify-representation/primitive-type \"unmatched ~a\" other)]))\n \n-\n-;; The following functions specify the types runtime layout,\n-;; parameterized on whether the type is known in compile-time or\n-;; run-time\n-\n-(: sr-type-gref (All (A) (A -> D0-Expr) A -> D0-Expr))\n-(define (sr-type-gref compile-type-static/dynamic ty)\n-  (sr-alloc \"GRefT\" TYPE-GREF-TAG\n-            `((\"type\" . ,(compile-type-static/dynamic ty)))))\n-\n-(: sr-type-gvect (All (A) (A -> D0-Expr) A -> D0-Expr))\n-(define (sr-type-gvect compile-type-static/dynamic ty)\n-  (sr-alloc \"GVectT\" TYPE-GVECT-TAG\n-            `((\"type\" . ,(compile-type-static/dynamic ty)))))\n-\n-(: sr-type-mref (All (A) (A -> D0-Expr) A -> D0-Expr))\n-(define (sr-type-mref compile-type-static/dynamic ty)\n-  (sr-alloc \"MRefT\" TYPE-MREF-TAG\n-            `((\"type\" . ,(compile-type-static/dynamic ty)))))\n-\n-(: sr-type-mvect (All (A) (A -> D0-Expr) A -> D0-Expr))\n-(define (sr-type-mvect compile-type-static/dynamic ty)\n-  (sr-alloc \"MVectT\" TYPE-MVECT-TAG\n-            `((\"type\" . ,(compile-type-static/dynamic ty)))))\n+;; it generates constants and functions for creating, accessing, and checking","path":"src/casts/specify-representation.rkt","position":null,"original_position":1136,"commit_id":"19b95c799dfc95b5eed093ef2e767a7151e9e53a","original_commit_id":"b29f46616a14d221cc280c1954b1d468ba768b01","user":{"login":"deyaaeldeen","id":6074665,"avatar_url":"https://avatars0.githubusercontent.com/u/6074665?v=4","gravatar_id":"","url":"https://api.github.com/users/deyaaeldeen","html_url":"https://github.com/deyaaeldeen","followers_url":"https://api.github.com/users/deyaaeldeen/followers","following_url":"https://api.github.com/users/deyaaeldeen/following{/other_user}","gists_url":"https://api.github.com/users/deyaaeldeen/gists{/gist_id}","starred_url":"https://api.github.com/users/deyaaeldeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deyaaeldeen/subscriptions","organizations_url":"https://api.github.com/users/deyaaeldeen/orgs","repos_url":"https://api.github.com/users/deyaaeldeen/repos","events_url":"https://api.github.com/users/deyaaeldeen/events{/privacy}","received_events_url":"https://api.github.com/users/deyaaeldeen/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-09-07T04:38:44Z","updated_at":"2017-09-07T04:38:44Z","html_url":"https://github.com/akuhlens/schml/pull/14#discussion_r137444804","pull_request_url":"https://api.github.com/repos/akuhlens/schml/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/akuhlens/schml/pulls/comments/137444804"},"html":{"href":"https://github.com/akuhlens/schml/pull/14#discussion_r137444804"},"pull_request":{"href":"https://api.github.com/repos/akuhlens/schml/pulls/14"}},"in_reply_to_id":137331155},"pull_request":{"url":"https://api.github.com/repos/akuhlens/schml/pulls/14","id":139077578,"html_url":"https://github.com/akuhlens/schml/pull/14","diff_url":"https://github.com/akuhlens/schml/pull/14.diff","patch_url":"https://github.com/akuhlens/schml/pull/14.patch","issue_url":"https://api.github.com/repos/akuhlens/schml/issues/14","number":14,"state":"open","locked":false,"title":"Unified heap allocation interface","user":{"login":"deyaaeldeen","id":6074665,"avatar_url":"https://avatars0.githubusercontent.com/u/6074665?v=4","gravatar_id":"","url":"https://api.github.com/users/deyaaeldeen","html_url":"https://github.com/deyaaeldeen","followers_url":"https://api.github.com/users/deyaaeldeen/followers","following_url":"https://api.github.com/users/deyaaeldeen/following{/other_user}","gists_url":"https://api.github.com/users/deyaaeldeen/gists{/gist_id}","starred_url":"https://api.github.com/users/deyaaeldeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deyaaeldeen/subscriptions","organizations_url":"https://api.github.com/users/deyaaeldeen/orgs","repos_url":"https://api.github.com/users/deyaaeldeen/repos","events_url":"https://api.github.com/users/deyaaeldeen/events{/privacy}","received_events_url":"https://api.github.com/users/deyaaeldeen/received_events","type":"User","site_admin":false},"body":"The key contribution is the `define-memory-layout-helpers` macro that manages how heap-allocated objects are created, accessed, and checked for equality. I used it for allocating all our types so far. I will use it for coercions too but after I finish the runtime hashconsing for types first.","created_at":"2017-09-04T03:32:40Z","updated_at":"2017-09-07T04:38:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efddb0430b08938182b921acd5bdb3ac3d729ab2","assignee":{"login":"deyaaeldeen","id":6074665,"avatar_url":"https://avatars0.githubusercontent.com/u/6074665?v=4","gravatar_id":"","url":"https://api.github.com/users/deyaaeldeen","html_url":"https://github.com/deyaaeldeen","followers_url":"https://api.github.com/users/deyaaeldeen/followers","following_url":"https://api.github.com/users/deyaaeldeen/following{/other_user}","gists_url":"https://api.github.com/users/deyaaeldeen/gists{/gist_id}","starred_url":"https://api.github.com/users/deyaaeldeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deyaaeldeen/subscriptions","organizations_url":"https://api.github.com/users/deyaaeldeen/orgs","repos_url":"https://api.github.com/users/deyaaeldeen/repos","events_url":"https://api.github.com/users/deyaaeldeen/events{/privacy}","received_events_url":"https://api.github.com/users/deyaaeldeen/received_events","type":"User","site_admin":false},"assignees":[{"login":"deyaaeldeen","id":6074665,"avatar_url":"https://avatars0.githubusercontent.com/u/6074665?v=4","gravatar_id":"","url":"https://api.github.com/users/deyaaeldeen","html_url":"https://github.com/deyaaeldeen","followers_url":"https://api.github.com/users/deyaaeldeen/followers","following_url":"https://api.github.com/users/deyaaeldeen/following{/other_user}","gists_url":"https://api.github.com/users/deyaaeldeen/gists{/gist_id}","starred_url":"https://api.github.com/users/deyaaeldeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deyaaeldeen/subscriptions","organizations_url":"https://api.github.com/users/deyaaeldeen/orgs","repos_url":"https://api.github.com/users/deyaaeldeen/repos","events_url":"https://api.github.com/users/deyaaeldeen/events{/privacy}","received_events_url":"https://api.github.com/users/deyaaeldeen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/akuhlens/schml/pulls/14/commits","review_comments_url":"https://api.github.com/repos/akuhlens/schml/pulls/14/comments","review_comment_url":"https://api.github.com/repos/akuhlens/schml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akuhlens/schml/issues/14/comments","statuses_url":"https://api.github.com/repos/akuhlens/schml/statuses/19b95c799dfc95b5eed093ef2e767a7151e9e53a","head":{"label":"akuhlens:unified-heap-allocation-interface","ref":"unified-heap-allocation-interface","sha":"19b95c799dfc95b5eed093ef2e767a7151e9e53a","user":{"login":"akuhlens","id":4377138,"avatar_url":"https://avatars1.githubusercontent.com/u/4377138?v=4","gravatar_id":"","url":"https://api.github.com/users/akuhlens","html_url":"https://github.com/akuhlens","followers_url":"https://api.github.com/users/akuhlens/followers","following_url":"https://api.github.com/users/akuhlens/following{/other_user}","gists_url":"https://api.github.com/users/akuhlens/gists{/gist_id}","starred_url":"https://api.github.com/users/akuhlens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akuhlens/subscriptions","organizations_url":"https://api.github.com/users/akuhlens/orgs","repos_url":"https://api.github.com/users/akuhlens/repos","events_url":"https://api.github.com/users/akuhlens/events{/privacy}","received_events_url":"https://api.github.com/users/akuhlens/received_events","type":"User","site_admin":false},"repo":{"id":27832586,"name":"schml","full_name":"akuhlens/schml","owner":{"login":"akuhlens","id":4377138,"avatar_url":"https://avatars1.githubusercontent.com/u/4377138?v=4","gravatar_id":"","url":"https://api.github.com/users/akuhlens","html_url":"https://github.com/akuhlens","followers_url":"https://api.github.com/users/akuhlens/followers","following_url":"https://api.github.com/users/akuhlens/following{/other_user}","gists_url":"https://api.github.com/users/akuhlens/gists{/gist_id}","starred_url":"https://api.github.com/users/akuhlens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akuhlens/subscriptions","organizations_url":"https://api.github.com/users/akuhlens/orgs","repos_url":"https://api.github.com/users/akuhlens/repos","events_url":"https://api.github.com/users/akuhlens/events{/privacy}","received_events_url":"https://api.github.com/users/akuhlens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akuhlens/schml","description":"A compiler for the gradually typed lambda calculus","fork":false,"url":"https://api.github.com/repos/akuhlens/schml","forks_url":"https://api.github.com/repos/akuhlens/schml/forks","keys_url":"https://api.github.com/repos/akuhlens/schml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akuhlens/schml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akuhlens/schml/teams","hooks_url":"https://api.github.com/repos/akuhlens/schml/hooks","issue_events_url":"https://api.github.com/repos/akuhlens/schml/issues/events{/number}","events_url":"https://api.github.com/repos/akuhlens/schml/events","assignees_url":"https://api.github.com/repos/akuhlens/schml/assignees{/user}","branches_url":"https://api.github.com/repos/akuhlens/schml/branches{/branch}","tags_url":"https://api.github.com/repos/akuhlens/schml/tags","blobs_url":"https://api.github.com/repos/akuhlens/schml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akuhlens/schml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akuhlens/schml/git/refs{/sha}","trees_url":"https://api.github.com/repos/akuhlens/schml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akuhlens/schml/statuses/{sha}","languages_url":"https://api.github.com/repos/akuhlens/schml/languages","stargazers_url":"https://api.github.com/repos/akuhlens/schml/stargazers","contributors_url":"https://api.github.com/repos/akuhlens/schml/contributors","subscribers_url":"https://api.github.com/repos/akuhlens/schml/subscribers","subscription_url":"https://api.github.com/repos/akuhlens/schml/subscription","commits_url":"https://api.github.com/repos/akuhlens/schml/commits{/sha}","git_commits_url":"https://api.github.com/repos/akuhlens/schml/git/commits{/sha}","comments_url":"https://api.github.com/repos/akuhlens/schml/comments{/number}","issue_comment_url":"https://api.github.com/repos/akuhlens/schml/issues/comments{/number}","contents_url":"https://api.github.com/repos/akuhlens/schml/contents/{+path}","compare_url":"https://api.github.com/repos/akuhlens/schml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akuhlens/schml/merges","archive_url":"https://api.github.com/repos/akuhlens/schml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akuhlens/schml/downloads","issues_url":"https://api.github.com/repos/akuhlens/schml/issues{/number}","pulls_url":"https://api.github.com/repos/akuhlens/schml/pulls{/number}","milestones_url":"https://api.github.com/repos/akuhlens/schml/milestones{/number}","notifications_url":"https://api.github.com/repos/akuhlens/schml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akuhlens/schml/labels{/name}","releases_url":"https://api.github.com/repos/akuhlens/schml/releases{/id}","deployments_url":"https://api.github.com/repos/akuhlens/schml/deployments","created_at":"2014-12-10T18:06:44Z","updated_at":"2017-06-08T14:02:21Z","pushed_at":"2017-09-07T04:38:22Z","git_url":"git://github.com/akuhlens/schml.git","ssh_url":"git@github.com:akuhlens/schml.git","clone_url":"https://github.com/akuhlens/schml.git","svn_url":"https://github.com/akuhlens/schml","homepage":null,"size":32300,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"akuhlens:master","ref":"master","sha":"3f2b420cf09c19ec450f6da020773e60a877013f","user":{"login":"akuhlens","id":4377138,"avatar_url":"https://avatars1.githubusercontent.com/u/4377138?v=4","gravatar_id":"","url":"https://api.github.com/users/akuhlens","html_url":"https://github.com/akuhlens","followers_url":"https://api.github.com/users/akuhlens/followers","following_url":"https://api.github.com/users/akuhlens/following{/other_user}","gists_url":"https://api.github.com/users/akuhlens/gists{/gist_id}","starred_url":"https://api.github.com/users/akuhlens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akuhlens/subscriptions","organizations_url":"https://api.github.com/users/akuhlens/orgs","repos_url":"https://api.github.com/users/akuhlens/repos","events_url":"https://api.github.com/users/akuhlens/events{/privacy}","received_events_url":"https://api.github.com/users/akuhlens/received_events","type":"User","site_admin":false},"repo":{"id":27832586,"name":"schml","full_name":"akuhlens/schml","owner":{"login":"akuhlens","id":4377138,"avatar_url":"https://avatars1.githubusercontent.com/u/4377138?v=4","gravatar_id":"","url":"https://api.github.com/users/akuhlens","html_url":"https://github.com/akuhlens","followers_url":"https://api.github.com/users/akuhlens/followers","following_url":"https://api.github.com/users/akuhlens/following{/other_user}","gists_url":"https://api.github.com/users/akuhlens/gists{/gist_id}","starred_url":"https://api.github.com/users/akuhlens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akuhlens/subscriptions","organizations_url":"https://api.github.com/users/akuhlens/orgs","repos_url":"https://api.github.com/users/akuhlens/repos","events_url":"https://api.github.com/users/akuhlens/events{/privacy}","received_events_url":"https://api.github.com/users/akuhlens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/akuhlens/schml","description":"A compiler for the gradually typed lambda calculus","fork":false,"url":"https://api.github.com/repos/akuhlens/schml","forks_url":"https://api.github.com/repos/akuhlens/schml/forks","keys_url":"https://api.github.com/repos/akuhlens/schml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akuhlens/schml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akuhlens/schml/teams","hooks_url":"https://api.github.com/repos/akuhlens/schml/hooks","issue_events_url":"https://api.github.com/repos/akuhlens/schml/issues/events{/number}","events_url":"https://api.github.com/repos/akuhlens/schml/events","assignees_url":"https://api.github.com/repos/akuhlens/schml/assignees{/user}","branches_url":"https://api.github.com/repos/akuhlens/schml/branches{/branch}","tags_url":"https://api.github.com/repos/akuhlens/schml/tags","blobs_url":"https://api.github.com/repos/akuhlens/schml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akuhlens/schml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akuhlens/schml/git/refs{/sha}","trees_url":"https://api.github.com/repos/akuhlens/schml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akuhlens/schml/statuses/{sha}","languages_url":"https://api.github.com/repos/akuhlens/schml/languages","stargazers_url":"https://api.github.com/repos/akuhlens/schml/stargazers","contributors_url":"https://api.github.com/repos/akuhlens/schml/contributors","subscribers_url":"https://api.github.com/repos/akuhlens/schml/subscribers","subscription_url":"https://api.github.com/repos/akuhlens/schml/subscription","commits_url":"https://api.github.com/repos/akuhlens/schml/commits{/sha}","git_commits_url":"https://api.github.com/repos/akuhlens/schml/git/commits{/sha}","comments_url":"https://api.github.com/repos/akuhlens/schml/comments{/number}","issue_comment_url":"https://api.github.com/repos/akuhlens/schml/issues/comments{/number}","contents_url":"https://api.github.com/repos/akuhlens/schml/contents/{+path}","compare_url":"https://api.github.com/repos/akuhlens/schml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akuhlens/schml/merges","archive_url":"https://api.github.com/repos/akuhlens/schml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akuhlens/schml/downloads","issues_url":"https://api.github.com/repos/akuhlens/schml/issues{/number}","pulls_url":"https://api.github.com/repos/akuhlens/schml/pulls{/number}","milestones_url":"https://api.github.com/repos/akuhlens/schml/milestones{/number}","notifications_url":"https://api.github.com/repos/akuhlens/schml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akuhlens/schml/labels{/name}","releases_url":"https://api.github.com/repos/akuhlens/schml/releases{/id}","deployments_url":"https://api.github.com/repos/akuhlens/schml/deployments","created_at":"2014-12-10T18:06:44Z","updated_at":"2017-06-08T14:02:21Z","pushed_at":"2017-09-07T04:38:22Z","git_url":"git://github.com/akuhlens/schml.git","ssh_url":"git@github.com:akuhlens/schml.git","clone_url":"https://github.com/akuhlens/schml.git","svn_url":"https://github.com/akuhlens/schml","homepage":null,"size":32300,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":6,"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akuhlens/schml/pulls/14"},"html":{"href":"https://github.com/akuhlens/schml/pull/14"},"issue":{"href":"https://api.github.com/repos/akuhlens/schml/issues/14"},"comments":{"href":"https://api.github.com/repos/akuhlens/schml/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/akuhlens/schml/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/akuhlens/schml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akuhlens/schml/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/akuhlens/schml/statuses/19b95c799dfc95b5eed093ef2e767a7151e9e53a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"deyaaeldeen"}}