{"action":"created","comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/101537367","pull_request_review_id":22268488,"id":101537367,"diff_hunk":"@@ -172,9 +172,20 @@ def _make_dipoles(times, poss, oris, sol, gof):\n def _compute_subcorr(G, phi_sig):\n     \"\"\"Compute the subspace correlation.\"\"\"\n     Ug, Sg, Vg = linalg.svd(G, full_matrices=False)\n+    # Now we look at the actual rank of the forward fields\n+    # in G and handle the fact that it might be rank defficient\n+    # eg. when using MEG and a sphere model for which the\n+    # radial component will be truly 0.\n+    # rank = np.sum(Sg > (Sg[0] * 1e-12))","path":"mne/beamformer/_rap_music.py","position":8,"original_position":8,"commit_id":"50e9ff025201e9ce8b26520e9dd1ef657048f6cb","original_commit_id":"50e9ff025201e9ce8b26520e9dd1ef657048f6cb","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"body":"> You told me to put 1e-12 ;)\r\n\r\nWell maybe you stopped reading after the first sentence? :)\r\n\r\n> 1e-12 might be a better threshold since we're using double precision. Have you looked at the eigenvalue spectra to see if 1e-6 or 1e-12 is a better choice?","created_at":"2017-02-16T14:58:40Z","updated_at":"2017-02-16T14:58:40Z","html_url":"https://github.com/mne-tools/mne-python/pull/3995#discussion_r101537367","pull_request_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3995","_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments/101537367"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3995#discussion_r101537367"},"pull_request":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3995"}}},"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3995","id":106413623,"html_url":"https://github.com/mne-tools/mne-python/pull/3995","diff_url":"https://github.com/mne-tools/mne-python/pull/3995.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3995.patch","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3995","number":3995,"state":"open","locked":false,"title":"Fix music with sphere head model","user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=3","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-02-15T22:27:23Z","updated_at":"2017-02-16T14:58:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"265a9345902d0182d7b3809e6a9252eb3b983cee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3995/commits","review_comments_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3995/comments","review_comment_url":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3995/comments","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/50e9ff025201e9ce8b26520e9dd1ef657048f6cb","head":{"label":"agramfort:fix_music_sphere","ref":"fix_music_sphere","sha":"50e9ff025201e9ce8b26520e9dd1ef657048f6cb","user":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=3","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"repo":{"id":2202093,"name":"mne-python","full_name":"agramfort/mne-python","owner":{"login":"agramfort","id":161052,"avatar_url":"https://avatars.githubusercontent.com/u/161052?v=3","gravatar_id":"","url":"https://api.github.com/users/agramfort","html_url":"https://github.com/agramfort","followers_url":"https://api.github.com/users/agramfort/followers","following_url":"https://api.github.com/users/agramfort/following{/other_user}","gists_url":"https://api.github.com/users/agramfort/gists{/gist_id}","starred_url":"https://api.github.com/users/agramfort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agramfort/subscriptions","organizations_url":"https://api.github.com/users/agramfort/orgs","repos_url":"https://api.github.com/users/agramfort/repos","events_url":"https://api.github.com/users/agramfort/events{/privacy}","received_events_url":"https://api.github.com/users/agramfort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agramfort/mne-python","description":"MNE scripting with Python","fork":true,"url":"https://api.github.com/repos/agramfort/mne-python","forks_url":"https://api.github.com/repos/agramfort/mne-python/forks","keys_url":"https://api.github.com/repos/agramfort/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agramfort/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agramfort/mne-python/teams","hooks_url":"https://api.github.com/repos/agramfort/mne-python/hooks","issue_events_url":"https://api.github.com/repos/agramfort/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/agramfort/mne-python/events","assignees_url":"https://api.github.com/repos/agramfort/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/agramfort/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/agramfort/mne-python/tags","blobs_url":"https://api.github.com/repos/agramfort/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agramfort/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agramfort/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/agramfort/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agramfort/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/agramfort/mne-python/languages","stargazers_url":"https://api.github.com/repos/agramfort/mne-python/stargazers","contributors_url":"https://api.github.com/repos/agramfort/mne-python/contributors","subscribers_url":"https://api.github.com/repos/agramfort/mne-python/subscribers","subscription_url":"https://api.github.com/repos/agramfort/mne-python/subscription","commits_url":"https://api.github.com/repos/agramfort/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/agramfort/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/agramfort/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/agramfort/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/agramfort/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/agramfort/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agramfort/mne-python/merges","archive_url":"https://api.github.com/repos/agramfort/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agramfort/mne-python/downloads","issues_url":"https://api.github.com/repos/agramfort/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/agramfort/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/agramfort/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/agramfort/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agramfort/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/agramfort/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/agramfort/mne-python/deployments","created_at":"2011-08-13T15:44:42Z","updated_at":"2017-01-08T15:36:30Z","pushed_at":"2017-02-16T07:13:06Z","git_url":"git://github.com/agramfort/mne-python.git","ssh_url":"git@github.com:agramfort/mne-python.git","clone_url":"https://github.com/agramfort/mne-python.git","svn_url":"https://github.com/agramfort/mne-python","homepage":"http://martinos.org/mne","size":92150,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mne-tools:master","ref":"master","sha":"0c31b1e248bea43343bded9b7fa0e2d7aa664210","user":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"repo":{"id":1301584,"name":"mne-python","full_name":"mne-tools/mne-python","owner":{"login":"mne-tools","id":583875,"avatar_url":"https://avatars.githubusercontent.com/u/583875?v=3","gravatar_id":"","url":"https://api.github.com/users/mne-tools","html_url":"https://github.com/mne-tools","followers_url":"https://api.github.com/users/mne-tools/followers","following_url":"https://api.github.com/users/mne-tools/following{/other_user}","gists_url":"https://api.github.com/users/mne-tools/gists{/gist_id}","starred_url":"https://api.github.com/users/mne-tools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mne-tools/subscriptions","organizations_url":"https://api.github.com/users/mne-tools/orgs","repos_url":"https://api.github.com/users/mne-tools/repos","events_url":"https://api.github.com/users/mne-tools/events{/privacy}","received_events_url":"https://api.github.com/users/mne-tools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mne-tools/mne-python","description":"MNE : Magnetoencephalography (MEG) and Electroencephalography (EEG) in Python","fork":false,"url":"https://api.github.com/repos/mne-tools/mne-python","forks_url":"https://api.github.com/repos/mne-tools/mne-python/forks","keys_url":"https://api.github.com/repos/mne-tools/mne-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mne-tools/mne-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mne-tools/mne-python/teams","hooks_url":"https://api.github.com/repos/mne-tools/mne-python/hooks","issue_events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/events{/number}","events_url":"https://api.github.com/repos/mne-tools/mne-python/events","assignees_url":"https://api.github.com/repos/mne-tools/mne-python/assignees{/user}","branches_url":"https://api.github.com/repos/mne-tools/mne-python/branches{/branch}","tags_url":"https://api.github.com/repos/mne-tools/mne-python/tags","blobs_url":"https://api.github.com/repos/mne-tools/mne-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mne-tools/mne-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mne-tools/mne-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/mne-tools/mne-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mne-tools/mne-python/statuses/{sha}","languages_url":"https://api.github.com/repos/mne-tools/mne-python/languages","stargazers_url":"https://api.github.com/repos/mne-tools/mne-python/stargazers","contributors_url":"https://api.github.com/repos/mne-tools/mne-python/contributors","subscribers_url":"https://api.github.com/repos/mne-tools/mne-python/subscribers","subscription_url":"https://api.github.com/repos/mne-tools/mne-python/subscription","commits_url":"https://api.github.com/repos/mne-tools/mne-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/mne-tools/mne-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/mne-tools/mne-python/contents/{+path}","compare_url":"https://api.github.com/repos/mne-tools/mne-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mne-tools/mne-python/merges","archive_url":"https://api.github.com/repos/mne-tools/mne-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mne-tools/mne-python/downloads","issues_url":"https://api.github.com/repos/mne-tools/mne-python/issues{/number}","pulls_url":"https://api.github.com/repos/mne-tools/mne-python/pulls{/number}","milestones_url":"https://api.github.com/repos/mne-tools/mne-python/milestones{/number}","notifications_url":"https://api.github.com/repos/mne-tools/mne-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mne-tools/mne-python/labels{/name}","releases_url":"https://api.github.com/repos/mne-tools/mne-python/releases{/id}","deployments_url":"https://api.github.com/repos/mne-tools/mne-python/deployments","created_at":"2011-01-28T03:31:13Z","updated_at":"2017-02-14T13:33:29Z","pushed_at":"2017-02-16T14:37:14Z","git_url":"git://github.com/mne-tools/mne-python.git","ssh_url":"git@github.com:mne-tools/mne-python.git","clone_url":"https://github.com/mne-tools/mne-python.git","svn_url":"https://github.com/mne-tools/mne-python","homepage":"http://martinos.org/mne/","size":91476,"stargazers_count":273,"watchers_count":273,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":238,"mirror_url":null,"open_issues_count":226,"forks":238,"open_issues":226,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3995"},"html":{"href":"https://github.com/mne-tools/mne-python/pull/3995"},"issue":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3995"},"comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/issues/3995/comments"},"review_comments":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3995/comments"},"review_comment":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mne-tools/mne-python/pulls/3995/commits"},"statuses":{"href":"https://api.github.com/repos/mne-tools/mne-python/statuses/50e9ff025201e9ce8b26520e9dd1ef657048f6cb"}}}}
{"actor":{"display_login":"Eric89GXL"}}