{"action":"created","issue":{"url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/1072","repository_url":"https://api.github.com/repos/remotestorage/remotestorage.js","labels_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/1072/labels{/name}","comments_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/1072/comments","events_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/1072/events","html_url":"https://github.com/remotestorage/remotestorage.js/pull/1072","id":270370044,"number":1072,"title":"Fix binary detection for Dropbox and Google Drive","user":{"login":"galfert","id":843,"avatar_url":"https://avatars1.githubusercontent.com/u/843?v=4","gravatar_id":"","url":"https://api.github.com/users/galfert","html_url":"https://github.com/galfert","followers_url":"https://api.github.com/users/galfert/followers","following_url":"https://api.github.com/users/galfert/following{/other_user}","gists_url":"https://api.github.com/users/galfert/gists{/gist_id}","starred_url":"https://api.github.com/users/galfert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galfert/subscriptions","organizations_url":"https://api.github.com/users/galfert/orgs","repos_url":"https://api.github.com/users/galfert/repos","events_url":"https://api.github.com/users/galfert/events{/privacy}","received_events_url":"https://api.github.com/users/galfert/received_events","type":"User","site_admin":false},"labels":[{"id":139608375,"url":"https://api.github.com/repos/remotestorage/remotestorage.js/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-11-01T16:37:16Z","updated_at":"2017-11-01T17:17:34Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/remotestorage/remotestorage.js/pulls/1072","html_url":"https://github.com/remotestorage/remotestorage.js/pull/1072","diff_url":"https://github.com/remotestorage/remotestorage.js/pull/1072.diff","patch_url":"https://github.com/remotestorage/remotestorage.js/pull/1072.patch"},"body":"Fixes #1059\r\n\r\nWith this fix, downloaded binary data is returned as ArrayBuffer, similar to binaries from a remoteStorage backend."},"comment":{"url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/comments/341174332","html_url":"https://github.com/remotestorage/remotestorage.js/pull/1072#issuecomment-341174332","issue_url":"https://api.github.com/repos/remotestorage/remotestorage.js/issues/1072","id":341174332,"user":{"login":"galfert","id":843,"avatar_url":"https://avatars1.githubusercontent.com/u/843?v=4","gravatar_id":"","url":"https://api.github.com/users/galfert","html_url":"https://github.com/galfert","followers_url":"https://api.github.com/users/galfert/followers","following_url":"https://api.github.com/users/galfert/following{/other_user}","gists_url":"https://api.github.com/users/galfert/gists{/gist_id}","starred_url":"https://api.github.com/users/galfert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galfert/subscriptions","organizations_url":"https://api.github.com/users/galfert/orgs","repos_url":"https://api.github.com/users/galfert/repos","events_url":"https://api.github.com/users/galfert/events{/privacy}","received_events_url":"https://api.github.com/users/galfert/received_events","type":"User","site_admin":false},"created_at":"2017-11-01T17:17:34Z","updated_at":"2017-11-01T17:17:34Z","author_association":"OWNER","body":"I pushed my test version of Sharesome to https://github.com/galfert/sharesome/tree/test_binary_download\r\n\r\nOn the history page, there is a \"Download item\" link for every shared item (not right at the item, just somewhere on the page, because no extra styling). Clicking that should log the downloaded file to the console.\r\n\r\nRight now the branch is using remotestorage 1.0.0-rc3. So when using Dropbox or Google Drive, the logged file's data will just be a string. When using it with this PR's fix, it should be an `ArrayBuffer` instead, similar to the remoteStorage backend.\r\n\r\nBtw, I noticed that in this Sharesome version, when the widget is minimized, the icon is cut off at the right side. I haven't looked into this yet. Maybe it's just the styling of the container the widget is added to. But we should check out that it's not another widget style that can be overwritten."}}
{"actor":{"display_login":"galfert"}}