{"action":"created","comment":{"url":"https://api.github.com/repos/openitg/openitg/pulls/comments/110145710","pull_request_review_id":31295227,"id":110145710,"diff_hunk":"@@ -283,7 +287,16 @@ endif\n \n Arch = $(LoadingWindow) $(Sound) $(ArchHooks) $(InputHandler) $(MovieTexture) \\\n \t   $(Lights) $(MemoryCard) $(LowLevelWindow) $(ArchUtils) $(Dialog) $(Threads) $(USBDriver) \\\n-\t   arch/arch_default.h arch/arch_platform.h arch/RageDriver.cpp arch/RageDriver.h\n+\t   arch/arch_default.h arch/arch_platform.h arch/RageDriver.cpp arch/RageDriver.h \\\n+\t   arch/ACIO.h arch/ACIO.cpp arch/COM/serial.h arch/COM/serial.cc arch/COM/v8stdint.h","path":"src/Makefile.am","position":37,"original_position":37,"commit_id":"f6767806d9adf739ebe4dbdd6e7c16d5927c15de","original_commit_id":"f6767806d9adf739ebe4dbdd6e7c16d5927c15de","user":{"login":"chrispable","id":4312054,"avatar_url":"https://avatars0.githubusercontent.com/u/4312054?v=3","gravatar_id":"","url":"https://api.github.com/users/chrispable","html_url":"https://github.com/chrispable","followers_url":"https://api.github.com/users/chrispable/followers","following_url":"https://api.github.com/users/chrispable/following{/other_user}","gists_url":"https://api.github.com/users/chrispable/gists{/gist_id}","starred_url":"https://api.github.com/users/chrispable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrispable/subscriptions","organizations_url":"https://api.github.com/users/chrispable/orgs","repos_url":"https://api.github.com/users/chrispable/repos","events_url":"https://api.github.com/users/chrispable/events{/privacy}","received_events_url":"https://api.github.com/users/chrispable/received_events","type":"User","site_admin":false},"body":"Yup, sorry 'lol windows'. It doesn't use this file and I was typing it out by hand. Oops. Thanks for catching it.","created_at":"2017-04-06T12:15:31Z","updated_at":"2017-04-06T12:15:31Z","html_url":"https://github.com/openitg/openitg/pull/98#discussion_r110145710","pull_request_url":"https://api.github.com/repos/openitg/openitg/pulls/98","_links":{"self":{"href":"https://api.github.com/repos/openitg/openitg/pulls/comments/110145710"},"html":{"href":"https://github.com/openitg/openitg/pull/98#discussion_r110145710"},"pull_request":{"href":"https://api.github.com/repos/openitg/openitg/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/openitg/openitg/pulls/98","id":113936089,"html_url":"https://github.com/openitg/openitg/pull/98","diff_url":"https://github.com/openitg/openitg/pull/98.diff","patch_url":"https://github.com/openitg/openitg/pull/98.patch","issue_url":"https://api.github.com/repos/openitg/openitg/issues/98","number":98,"state":"open","locked":false,"title":"P3io","user":{"login":"chrispable","id":4312054,"avatar_url":"https://avatars0.githubusercontent.com/u/4312054?v=3","gravatar_id":"","url":"https://api.github.com/users/chrispable","html_url":"https://github.com/chrispable","followers_url":"https://api.github.com/users/chrispable/followers","following_url":"https://api.github.com/users/chrispable/following{/other_user}","gists_url":"https://api.github.com/users/chrispable/gists{/gist_id}","starred_url":"https://api.github.com/users/chrispable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrispable/subscriptions","organizations_url":"https://api.github.com/users/chrispable/orgs","repos_url":"https://api.github.com/users/chrispable/repos","events_url":"https://api.github.com/users/chrispable/events{/privacy}","received_events_url":"https://api.github.com/users/chrispable/received_events","type":"User","site_admin":false},"body":"Addresses issue #42 - This adds support to drive cabinet lights on a real ddr machine using REAL konami hardware provided you use libusb with it (the p3io konami io board). You can do this easily with zadig. Not only does it fully support of messages from the usb io device but the multiple serial light devices as well. Since different cabinets have different lights on different configurations and such, you will need to set options to tell the drivers what is where. Use the default settings to automatically setup a standard definition cabinet, the most common type in the wild. This also support the rarer deluxe cabinet with the light spires / satellites. Tested working in isolation. Will stress test at MGC 2017 but seems to be working fantastic (ableit full of hackery, someone please make this better lol). If merged, I'll supply my mods to tommath/tomcrypt (benefits everyone, eliminates 2 minute startup wait for entropy on windows with older runtimes, support for this made possible by a small tweak present in this code when working on portability for sm5, hence the prereq) and vs2010 project file (which is of dubious utility to others but works for me).\r\n\r\n\r\nHighly suggest setting the following options in your ini if you use this on a ddr cab with windows, the following is what I use for my JP DDRX cabinet:\r\n\r\n#ogl causes issues with 15/31 khz on a stock windows cab\r\nVideoRenderers=d3d\r\n\r\n#Lights are dumb as hell if you dont set these\r\nBlinkGameplayButtonLightsOnNote=0\r\nEasterEggs2=0\r\n\r\n#This will help DDR players use the build\r\nOnlyDedicatedMenuButtons=1\r\n\r\n#Use only this so people can't put coins in with a keyboard, you cannot exit the game easily though!\r\n#this also is an HDXB light driver. Due to the way this is architected, I cannot seperate HDXB into its own light device easily since NORMALLY it needs to talk to the p3io to work\r\nInputDrivers=P3IO\r\n\r\n#HD cabinet specific stuff, can also set SD or leave blank for SD\r\nCabinetType=HD\r\n\r\n#Give pad and SD neons as well as satellites\r\nLightsDriver=EXTIO,Satellite\r\n\r\n#set the proper com ports for the light services\r\nEXTIOComPort=COM1\r\nSatelliteComPort=COM2\r\nCOM4PORT=\r\n\r\n#Note on COM4PORT, by default it uses a VIRTUAL com port on the p3io through bulk transfers.... yeah wtf.\r\n#If you bypass this with a regular serial adapter, just put in something like COM4 as your COM4PORT. SHOULD work.\r\n#If it doesn't, I added HDXB support to acrealio, you can make an HDXB device to stuff on a comport, fix it then put up a PR :)\r\n","created_at":"2017-04-03T13:55:05Z","updated_at":"2017-04-06T12:15:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e91c1fa484332d353d9084b29d3783ec90a6c1cf","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openitg/openitg/pulls/98/commits","review_comments_url":"https://api.github.com/repos/openitg/openitg/pulls/98/comments","review_comment_url":"https://api.github.com/repos/openitg/openitg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openitg/openitg/issues/98/comments","statuses_url":"https://api.github.com/repos/openitg/openitg/statuses/f6767806d9adf739ebe4dbdd6e7c16d5927c15de","head":{"label":"chrispable:p3io","ref":"p3io","sha":"f6767806d9adf739ebe4dbdd6e7c16d5927c15de","user":{"login":"chrispable","id":4312054,"avatar_url":"https://avatars0.githubusercontent.com/u/4312054?v=3","gravatar_id":"","url":"https://api.github.com/users/chrispable","html_url":"https://github.com/chrispable","followers_url":"https://api.github.com/users/chrispable/followers","following_url":"https://api.github.com/users/chrispable/following{/other_user}","gists_url":"https://api.github.com/users/chrispable/gists{/gist_id}","starred_url":"https://api.github.com/users/chrispable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrispable/subscriptions","organizations_url":"https://api.github.com/users/chrispable/orgs","repos_url":"https://api.github.com/users/chrispable/repos","events_url":"https://api.github.com/users/chrispable/events{/privacy}","received_events_url":"https://api.github.com/users/chrispable/received_events","type":"User","site_admin":false},"repo":{"id":81345701,"name":"openitg","full_name":"chrispable/openitg","owner":{"login":"chrispable","id":4312054,"avatar_url":"https://avatars0.githubusercontent.com/u/4312054?v=3","gravatar_id":"","url":"https://api.github.com/users/chrispable","html_url":"https://github.com/chrispable","followers_url":"https://api.github.com/users/chrispable/followers","following_url":"https://api.github.com/users/chrispable/following{/other_user}","gists_url":"https://api.github.com/users/chrispable/gists{/gist_id}","starred_url":"https://api.github.com/users/chrispable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrispable/subscriptions","organizations_url":"https://api.github.com/users/chrispable/orgs","repos_url":"https://api.github.com/users/chrispable/repos","events_url":"https://api.github.com/users/chrispable/events{/privacy}","received_events_url":"https://api.github.com/users/chrispable/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chrispable/openitg","description":"The OpenITG Project Code - an open-source rhythm dancing game based on StepMania 3.95","fork":true,"url":"https://api.github.com/repos/chrispable/openitg","forks_url":"https://api.github.com/repos/chrispable/openitg/forks","keys_url":"https://api.github.com/repos/chrispable/openitg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chrispable/openitg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chrispable/openitg/teams","hooks_url":"https://api.github.com/repos/chrispable/openitg/hooks","issue_events_url":"https://api.github.com/repos/chrispable/openitg/issues/events{/number}","events_url":"https://api.github.com/repos/chrispable/openitg/events","assignees_url":"https://api.github.com/repos/chrispable/openitg/assignees{/user}","branches_url":"https://api.github.com/repos/chrispable/openitg/branches{/branch}","tags_url":"https://api.github.com/repos/chrispable/openitg/tags","blobs_url":"https://api.github.com/repos/chrispable/openitg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chrispable/openitg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chrispable/openitg/git/refs{/sha}","trees_url":"https://api.github.com/repos/chrispable/openitg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chrispable/openitg/statuses/{sha}","languages_url":"https://api.github.com/repos/chrispable/openitg/languages","stargazers_url":"https://api.github.com/repos/chrispable/openitg/stargazers","contributors_url":"https://api.github.com/repos/chrispable/openitg/contributors","subscribers_url":"https://api.github.com/repos/chrispable/openitg/subscribers","subscription_url":"https://api.github.com/repos/chrispable/openitg/subscription","commits_url":"https://api.github.com/repos/chrispable/openitg/commits{/sha}","git_commits_url":"https://api.github.com/repos/chrispable/openitg/git/commits{/sha}","comments_url":"https://api.github.com/repos/chrispable/openitg/comments{/number}","issue_comment_url":"https://api.github.com/repos/chrispable/openitg/issues/comments{/number}","contents_url":"https://api.github.com/repos/chrispable/openitg/contents/{+path}","compare_url":"https://api.github.com/repos/chrispable/openitg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chrispable/openitg/merges","archive_url":"https://api.github.com/repos/chrispable/openitg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chrispable/openitg/downloads","issues_url":"https://api.github.com/repos/chrispable/openitg/issues{/number}","pulls_url":"https://api.github.com/repos/chrispable/openitg/pulls{/number}","milestones_url":"https://api.github.com/repos/chrispable/openitg/milestones{/number}","notifications_url":"https://api.github.com/repos/chrispable/openitg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chrispable/openitg/labels{/name}","releases_url":"https://api.github.com/repos/chrispable/openitg/releases{/id}","deployments_url":"https://api.github.com/repos/chrispable/openitg/deployments","created_at":"2017-02-08T15:44:11Z","updated_at":"2017-02-08T15:44:28Z","pushed_at":"2017-04-03T13:37:15Z","git_url":"git://github.com/chrispable/openitg.git","ssh_url":"git@github.com:chrispable/openitg.git","clone_url":"https://github.com/chrispable/openitg.git","svn_url":"https://github.com/chrispable/openitg","homepage":"http://openitg.gr-p.com/","size":84592,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openitg:master","ref":"master","sha":"2aa7f90d8fa6fc5835dc2779024ad1c856149656","user":{"login":"openitg","id":567762,"avatar_url":"https://avatars0.githubusercontent.com/u/567762?v=3","gravatar_id":"","url":"https://api.github.com/users/openitg","html_url":"https://github.com/openitg","followers_url":"https://api.github.com/users/openitg/followers","following_url":"https://api.github.com/users/openitg/following{/other_user}","gists_url":"https://api.github.com/users/openitg/gists{/gist_id}","starred_url":"https://api.github.com/users/openitg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openitg/subscriptions","organizations_url":"https://api.github.com/users/openitg/orgs","repos_url":"https://api.github.com/users/openitg/repos","events_url":"https://api.github.com/users/openitg/events{/privacy}","received_events_url":"https://api.github.com/users/openitg/received_events","type":"Organization","site_admin":false},"repo":{"id":1261156,"name":"openitg","full_name":"openitg/openitg","owner":{"login":"openitg","id":567762,"avatar_url":"https://avatars0.githubusercontent.com/u/567762?v=3","gravatar_id":"","url":"https://api.github.com/users/openitg","html_url":"https://github.com/openitg","followers_url":"https://api.github.com/users/openitg/followers","following_url":"https://api.github.com/users/openitg/following{/other_user}","gists_url":"https://api.github.com/users/openitg/gists{/gist_id}","starred_url":"https://api.github.com/users/openitg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openitg/subscriptions","organizations_url":"https://api.github.com/users/openitg/orgs","repos_url":"https://api.github.com/users/openitg/repos","events_url":"https://api.github.com/users/openitg/events{/privacy}","received_events_url":"https://api.github.com/users/openitg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openitg/openitg","description":"The OpenITG Project Code - an open-source rhythm dancing game based on StepMania 3.95","fork":false,"url":"https://api.github.com/repos/openitg/openitg","forks_url":"https://api.github.com/repos/openitg/openitg/forks","keys_url":"https://api.github.com/repos/openitg/openitg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openitg/openitg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openitg/openitg/teams","hooks_url":"https://api.github.com/repos/openitg/openitg/hooks","issue_events_url":"https://api.github.com/repos/openitg/openitg/issues/events{/number}","events_url":"https://api.github.com/repos/openitg/openitg/events","assignees_url":"https://api.github.com/repos/openitg/openitg/assignees{/user}","branches_url":"https://api.github.com/repos/openitg/openitg/branches{/branch}","tags_url":"https://api.github.com/repos/openitg/openitg/tags","blobs_url":"https://api.github.com/repos/openitg/openitg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openitg/openitg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openitg/openitg/git/refs{/sha}","trees_url":"https://api.github.com/repos/openitg/openitg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openitg/openitg/statuses/{sha}","languages_url":"https://api.github.com/repos/openitg/openitg/languages","stargazers_url":"https://api.github.com/repos/openitg/openitg/stargazers","contributors_url":"https://api.github.com/repos/openitg/openitg/contributors","subscribers_url":"https://api.github.com/repos/openitg/openitg/subscribers","subscription_url":"https://api.github.com/repos/openitg/openitg/subscription","commits_url":"https://api.github.com/repos/openitg/openitg/commits{/sha}","git_commits_url":"https://api.github.com/repos/openitg/openitg/git/commits{/sha}","comments_url":"https://api.github.com/repos/openitg/openitg/comments{/number}","issue_comment_url":"https://api.github.com/repos/openitg/openitg/issues/comments{/number}","contents_url":"https://api.github.com/repos/openitg/openitg/contents/{+path}","compare_url":"https://api.github.com/repos/openitg/openitg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openitg/openitg/merges","archive_url":"https://api.github.com/repos/openitg/openitg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openitg/openitg/downloads","issues_url":"https://api.github.com/repos/openitg/openitg/issues{/number}","pulls_url":"https://api.github.com/repos/openitg/openitg/pulls{/number}","milestones_url":"https://api.github.com/repos/openitg/openitg/milestones{/number}","notifications_url":"https://api.github.com/repos/openitg/openitg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openitg/openitg/labels{/name}","releases_url":"https://api.github.com/repos/openitg/openitg/releases{/id}","deployments_url":"https://api.github.com/repos/openitg/openitg/deployments","created_at":"2011-01-16T19:24:41Z","updated_at":"2017-03-23T20:33:59Z","pushed_at":"2017-04-03T13:55:06Z","git_url":"git://github.com/openitg/openitg.git","ssh_url":"git@github.com:openitg/openitg.git","clone_url":"https://github.com/openitg/openitg.git","svn_url":"https://github.com/openitg/openitg","homepage":"http://openitg.gr-p.com/","size":84545,"stargazers_count":99,"watchers_count":99,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":11,"forks":60,"open_issues":11,"watchers":99,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openitg/openitg/pulls/98"},"html":{"href":"https://github.com/openitg/openitg/pull/98"},"issue":{"href":"https://api.github.com/repos/openitg/openitg/issues/98"},"comments":{"href":"https://api.github.com/repos/openitg/openitg/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/openitg/openitg/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/openitg/openitg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openitg/openitg/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/openitg/openitg/statuses/f6767806d9adf739ebe4dbdd6e7c16d5927c15de"}}}}
{"actor":{"display_login":"chrispable"}}