{"action":"created","comment":{"url":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/comments/105688540","pull_request_review_id":26579598,"id":105688540,"diff_hunk":"@@ -0,0 +1,30 @@\n+(* Copyright (C) 2015-2016 Bloomberg Finance L.P.\n+ * \n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU Lesser General Public License as published by\n+ * the Free Software Foundation, either version 3 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * In addition to the permissions granted to you by the LGPL, you may combine\n+ * or link a \"work that uses the Library\" with a publicly distributed version\n+ * of this file to produce a combined library or application, then distribute\n+ * that combined work under the terms of your choosing, with no requirement\n+ * to comply with the obligations normally placed on you by section 4 of the\n+ * LGPL version 3 (or the corresponding section of a later version of the LGPL\n+ * should you choose to use a later version).\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU Lesser General Public License for more details.\n+ * \n+ * You should have received a copy of the GNU Lesser General Public License\n+ * along with this program; if not, write to the Free Software\n+ * Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. *)\n+\n+type option ","path":"src/node_child_process.ml","position":25,"original_position":25,"commit_id":"8dbf16f000ccd71cd68510b08b61118dbd437cfd","original_commit_id":"8dbf16f000ccd71cd68510b08b61118dbd437cfd","user":{"login":"ul","id":233227,"avatar_url":"https://avatars1.githubusercontent.com/u/233227?v=3","gravatar_id":"","url":"https://api.github.com/users/ul","html_url":"https://github.com/ul","followers_url":"https://api.github.com/users/ul/followers","following_url":"https://api.github.com/users/ul/following{/other_user}","gists_url":"https://api.github.com/users/ul/gists{/gist_id}","starred_url":"https://api.github.com/users/ul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ul/subscriptions","organizations_url":"https://api.github.com/users/ul/orgs","repos_url":"https://api.github.com/users/ul/repos","events_url":"https://api.github.com/users/ul/events{/privacy}","received_events_url":"https://api.github.com/users/ul/received_events","type":"User","site_admin":false},"body":"It's a typo. It should be `options`. I did not make any fix to original code except ones required to build stuff. The next step will be more thoughtful reading/fixing/extending.","created_at":"2017-03-13T15:25:57Z","updated_at":"2017-03-13T15:25:57Z","html_url":"https://github.com/BuckleTypes/bs-node/pull/1#discussion_r105688540","pull_request_url":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/comments/105688540"},"html":{"href":"https://github.com/BuckleTypes/bs-node/pull/1#discussion_r105688540"},"pull_request":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/1","id":110387241,"html_url":"https://github.com/BuckleTypes/bs-node/pull/1","diff_url":"https://github.com/BuckleTypes/bs-node/pull/1.diff","patch_url":"https://github.com/BuckleTypes/bs-node/pull/1.patch","issue_url":"https://api.github.com/repos/BuckleTypes/bs-node/issues/1","number":1,"state":"open","locked":false,"title":"fix cyclic deps and use jest","user":{"login":"ul","id":233227,"avatar_url":"https://avatars1.githubusercontent.com/u/233227?v=3","gravatar_id":"","url":"https://api.github.com/users/ul","html_url":"https://github.com/ul","followers_url":"https://api.github.com/users/ul/followers","following_url":"https://api.github.com/users/ul/following{/other_user}","gists_url":"https://api.github.com/users/ul/gists{/gist_id}","starred_url":"https://api.github.com/users/ul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ul/subscriptions","organizations_url":"https://api.github.com/users/ul/orgs","repos_url":"https://api.github.com/users/ul/repos","events_url":"https://api.github.com/users/ul/events{/privacy}","received_events_url":"https://api.github.com/users/ul/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-13T11:45:05Z","updated_at":"2017-03-13T15:25:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fb3f054875795278dd669dfb58faf894c9c71e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/1/commits","review_comments_url":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/1/comments","review_comment_url":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BuckleTypes/bs-node/issues/1/comments","statuses_url":"https://api.github.com/repos/BuckleTypes/bs-node/statuses/8dbf16f000ccd71cd68510b08b61118dbd437cfd","head":{"label":"ul:master","ref":"master","sha":"8dbf16f000ccd71cd68510b08b61118dbd437cfd","user":{"login":"ul","id":233227,"avatar_url":"https://avatars1.githubusercontent.com/u/233227?v=3","gravatar_id":"","url":"https://api.github.com/users/ul","html_url":"https://github.com/ul","followers_url":"https://api.github.com/users/ul/followers","following_url":"https://api.github.com/users/ul/following{/other_user}","gists_url":"https://api.github.com/users/ul/gists{/gist_id}","starred_url":"https://api.github.com/users/ul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ul/subscriptions","organizations_url":"https://api.github.com/users/ul/orgs","repos_url":"https://api.github.com/users/ul/repos","events_url":"https://api.github.com/users/ul/events{/privacy}","received_events_url":"https://api.github.com/users/ul/received_events","type":"User","site_admin":false},"repo":{"id":84193391,"name":"bs-node","full_name":"ul/bs-node","owner":{"login":"ul","id":233227,"avatar_url":"https://avatars1.githubusercontent.com/u/233227?v=3","gravatar_id":"","url":"https://api.github.com/users/ul","html_url":"https://github.com/ul","followers_url":"https://api.github.com/users/ul/followers","following_url":"https://api.github.com/users/ul/following{/other_user}","gists_url":"https://api.github.com/users/ul/gists{/gist_id}","starred_url":"https://api.github.com/users/ul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ul/subscriptions","organizations_url":"https://api.github.com/users/ul/orgs","repos_url":"https://api.github.com/users/ul/repos","events_url":"https://api.github.com/users/ul/events{/privacy}","received_events_url":"https://api.github.com/users/ul/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ul/bs-node","description":"Node bindings for BuckleScript","fork":true,"url":"https://api.github.com/repos/ul/bs-node","forks_url":"https://api.github.com/repos/ul/bs-node/forks","keys_url":"https://api.github.com/repos/ul/bs-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ul/bs-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ul/bs-node/teams","hooks_url":"https://api.github.com/repos/ul/bs-node/hooks","issue_events_url":"https://api.github.com/repos/ul/bs-node/issues/events{/number}","events_url":"https://api.github.com/repos/ul/bs-node/events","assignees_url":"https://api.github.com/repos/ul/bs-node/assignees{/user}","branches_url":"https://api.github.com/repos/ul/bs-node/branches{/branch}","tags_url":"https://api.github.com/repos/ul/bs-node/tags","blobs_url":"https://api.github.com/repos/ul/bs-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ul/bs-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ul/bs-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/ul/bs-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ul/bs-node/statuses/{sha}","languages_url":"https://api.github.com/repos/ul/bs-node/languages","stargazers_url":"https://api.github.com/repos/ul/bs-node/stargazers","contributors_url":"https://api.github.com/repos/ul/bs-node/contributors","subscribers_url":"https://api.github.com/repos/ul/bs-node/subscribers","subscription_url":"https://api.github.com/repos/ul/bs-node/subscription","commits_url":"https://api.github.com/repos/ul/bs-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/ul/bs-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/ul/bs-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/ul/bs-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/ul/bs-node/contents/{+path}","compare_url":"https://api.github.com/repos/ul/bs-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ul/bs-node/merges","archive_url":"https://api.github.com/repos/ul/bs-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ul/bs-node/downloads","issues_url":"https://api.github.com/repos/ul/bs-node/issues{/number}","pulls_url":"https://api.github.com/repos/ul/bs-node/pulls{/number}","milestones_url":"https://api.github.com/repos/ul/bs-node/milestones{/number}","notifications_url":"https://api.github.com/repos/ul/bs-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ul/bs-node/labels{/name}","releases_url":"https://api.github.com/repos/ul/bs-node/releases{/id}","deployments_url":"https://api.github.com/repos/ul/bs-node/deployments","created_at":"2017-03-07T11:50:48Z","updated_at":"2017-03-13T11:44:08Z","pushed_at":"2017-03-13T11:44:06Z","git_url":"git://github.com/ul/bs-node.git","ssh_url":"git@github.com:ul/bs-node.git","clone_url":"https://github.com/ul/bs-node.git","svn_url":"https://github.com/ul/bs-node","homepage":null,"size":5,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BuckleTypes:master","ref":"master","sha":"61bd281041a6c04106d6596556f134e0d1bc9da2","user":{"login":"BuckleTypes","id":25113633,"avatar_url":"https://avatars0.githubusercontent.com/u/25113633?v=3","gravatar_id":"","url":"https://api.github.com/users/BuckleTypes","html_url":"https://github.com/BuckleTypes","followers_url":"https://api.github.com/users/BuckleTypes/followers","following_url":"https://api.github.com/users/BuckleTypes/following{/other_user}","gists_url":"https://api.github.com/users/BuckleTypes/gists{/gist_id}","starred_url":"https://api.github.com/users/BuckleTypes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuckleTypes/subscriptions","organizations_url":"https://api.github.com/users/BuckleTypes/orgs","repos_url":"https://api.github.com/users/BuckleTypes/repos","events_url":"https://api.github.com/users/BuckleTypes/events{/privacy}","received_events_url":"https://api.github.com/users/BuckleTypes/received_events","type":"Organization","site_admin":false},"repo":{"id":84104393,"name":"bs-node","full_name":"BuckleTypes/bs-node","owner":{"login":"BuckleTypes","id":25113633,"avatar_url":"https://avatars0.githubusercontent.com/u/25113633?v=3","gravatar_id":"","url":"https://api.github.com/users/BuckleTypes","html_url":"https://github.com/BuckleTypes","followers_url":"https://api.github.com/users/BuckleTypes/followers","following_url":"https://api.github.com/users/BuckleTypes/following{/other_user}","gists_url":"https://api.github.com/users/BuckleTypes/gists{/gist_id}","starred_url":"https://api.github.com/users/BuckleTypes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BuckleTypes/subscriptions","organizations_url":"https://api.github.com/users/BuckleTypes/orgs","repos_url":"https://api.github.com/users/BuckleTypes/repos","events_url":"https://api.github.com/users/BuckleTypes/events{/privacy}","received_events_url":"https://api.github.com/users/BuckleTypes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BuckleTypes/bs-node","description":"Node bindings for BuckleScript","fork":false,"url":"https://api.github.com/repos/BuckleTypes/bs-node","forks_url":"https://api.github.com/repos/BuckleTypes/bs-node/forks","keys_url":"https://api.github.com/repos/BuckleTypes/bs-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BuckleTypes/bs-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BuckleTypes/bs-node/teams","hooks_url":"https://api.github.com/repos/BuckleTypes/bs-node/hooks","issue_events_url":"https://api.github.com/repos/BuckleTypes/bs-node/issues/events{/number}","events_url":"https://api.github.com/repos/BuckleTypes/bs-node/events","assignees_url":"https://api.github.com/repos/BuckleTypes/bs-node/assignees{/user}","branches_url":"https://api.github.com/repos/BuckleTypes/bs-node/branches{/branch}","tags_url":"https://api.github.com/repos/BuckleTypes/bs-node/tags","blobs_url":"https://api.github.com/repos/BuckleTypes/bs-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BuckleTypes/bs-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BuckleTypes/bs-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/BuckleTypes/bs-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BuckleTypes/bs-node/statuses/{sha}","languages_url":"https://api.github.com/repos/BuckleTypes/bs-node/languages","stargazers_url":"https://api.github.com/repos/BuckleTypes/bs-node/stargazers","contributors_url":"https://api.github.com/repos/BuckleTypes/bs-node/contributors","subscribers_url":"https://api.github.com/repos/BuckleTypes/bs-node/subscribers","subscription_url":"https://api.github.com/repos/BuckleTypes/bs-node/subscription","commits_url":"https://api.github.com/repos/BuckleTypes/bs-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/BuckleTypes/bs-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/BuckleTypes/bs-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/BuckleTypes/bs-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/BuckleTypes/bs-node/contents/{+path}","compare_url":"https://api.github.com/repos/BuckleTypes/bs-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BuckleTypes/bs-node/merges","archive_url":"https://api.github.com/repos/BuckleTypes/bs-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BuckleTypes/bs-node/downloads","issues_url":"https://api.github.com/repos/BuckleTypes/bs-node/issues{/number}","pulls_url":"https://api.github.com/repos/BuckleTypes/bs-node/pulls{/number}","milestones_url":"https://api.github.com/repos/BuckleTypes/bs-node/milestones{/number}","notifications_url":"https://api.github.com/repos/BuckleTypes/bs-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BuckleTypes/bs-node/labels{/name}","releases_url":"https://api.github.com/repos/BuckleTypes/bs-node/releases{/id}","deployments_url":"https://api.github.com/repos/BuckleTypes/bs-node/deployments","created_at":"2017-03-06T18:02:13Z","updated_at":"2017-03-06T18:02:13Z","pushed_at":"2017-03-13T11:45:06Z","git_url":"git://github.com/BuckleTypes/bs-node.git","ssh_url":"git@github.com:BuckleTypes/bs-node.git","clone_url":"https://github.com/BuckleTypes/bs-node.git","svn_url":"https://github.com/BuckleTypes/bs-node","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/1"},"html":{"href":"https://github.com/BuckleTypes/bs-node/pull/1"},"issue":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/issues/1"},"comments":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/BuckleTypes/bs-node/statuses/8dbf16f000ccd71cd68510b08b61118dbd437cfd"}}}}
{"actor":{"display_login":"ul"}}