{"action":"opened","issue":{"url":"https://api.github.com/repos/kubernetes/charts/issues/2098","repository_url":"https://api.github.com/repos/kubernetes/charts","labels_url":"https://api.github.com/repos/kubernetes/charts/issues/2098/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/2098/comments","events_url":"https://api.github.com/repos/kubernetes/charts/issues/2098/events","html_url":"https://github.com/kubernetes/charts/issues/2098","id":256990017,"number":2098,"title":"[stable/traefik] Disable compression by default?","user":{"login":"kachkaev","id":608862,"avatar_url":"https://avatars3.githubusercontent.com/u/608862?v=4","gravatar_id":"","url":"https://api.github.com/users/kachkaev","html_url":"https://github.com/kachkaev","followers_url":"https://api.github.com/users/kachkaev/followers","following_url":"https://api.github.com/users/kachkaev/following{/other_user}","gists_url":"https://api.github.com/users/kachkaev/gists{/gist_id}","starred_url":"https://api.github.com/users/kachkaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kachkaev/subscriptions","organizations_url":"https://api.github.com/users/kachkaev/orgs","repos_url":"https://api.github.com/users/kachkaev/repos","events_url":"https://api.github.com/users/kachkaev/events{/privacy}","received_events_url":"https://api.github.com/users/kachkaev/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-12T10:12:40Z","updated_at":"2017-09-12T10:12:40Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Is this a BUG REPORT or FEATURE REQUEST?** (choose one):\r\n\r\nsomewhat a bug\r\n\r\n**Version of Helm and Kubernetes**:\r\n\r\nN/A\r\n\r\n**Which chart**:\r\n\r\nstable/traefik\r\n\r\n**What happened**:\r\n\r\nI noticed that the traefik chart by default sets `compress = true` for both http and https endpoints by having [`gzip.enabled: true` in `values.yml`](https://github.com/kubernetes/charts/blob/master/stable/traefik/values.yaml#L61-L62). I saw a couple of issues with this and decided to bring them up for discussion:\r\n\r\n* At the moment there seems to be a bug related to compressing files by traefik in tls mode, which means that some users of this chart who go for the defaults may get poorly performing setups. See https://github.com/containous/traefik/issues/1908#issuecomment-328376354 and below.\r\n\r\n* Overall, there's probably not much benefit from compressing all the requests by traefik itself, because some of them will carry jpegs, zips and videos. Percentagewise, this is may be quite a lot of data.  I guess that most of the upstream containers in most cases will do the compression already and importantly this will happen based on the mime types. Distinguishing between text and binaries is not what traefik is enable to do ATM.\r\n\r\nIf the chart was in its early days, I'd recommend setting `gzip.enabled` to `false` by default, but now this is a breaking change. However given that traefik 1.4 will be released soon, maybe a time for a BC is not too bad? We could also use this opportunity to clean-up a few things e.g. https://github.com/kubernetes/charts/issues/1457.\r\n\r\nWDYT?\r\n\r\n/cc @krancour  @electroma"}}
{"actor":{"display_login":"kachkaev"}}