{"action":"created","issue":{"url":"https://api.github.com/repos/go-gitea/gitea/issues/1468","repository_url":"https://api.github.com/repos/go-gitea/gitea","labels_url":"https://api.github.com/repos/go-gitea/gitea/issues/1468/labels{/name}","comments_url":"https://api.github.com/repos/go-gitea/gitea/issues/1468/comments","events_url":"https://api.github.com/repos/go-gitea/gitea/issues/1468/events","html_url":"https://github.com/go-gitea/gitea/pull/1468","id":220359305,"number":1468,"title":"Check if missing/modified/unused deps in vendor and fix errors","user":{"login":"sapk","id":4052400,"avatar_url":"https://avatars3.githubusercontent.com/u/4052400?v=3","gravatar_id":"","url":"https://api.github.com/users/sapk","html_url":"https://github.com/sapk","followers_url":"https://api.github.com/users/sapk/followers","following_url":"https://api.github.com/users/sapk/following{/other_user}","gists_url":"https://api.github.com/users/sapk/gists{/gist_id}","starred_url":"https://api.github.com/users/sapk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapk/subscriptions","organizations_url":"https://api.github.com/users/sapk/orgs","repos_url":"https://api.github.com/users/sapk/repos","events_url":"https://api.github.com/users/sapk/events{/privacy}","received_events_url":"https://api.github.com/users/sapk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-08T00:01:57Z","updated_at":"2017-04-08T01:05:16Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/go-gitea/gitea/pulls/1468","html_url":"https://github.com/go-gitea/gitea/pull/1468","diff_url":"https://github.com/go-gitea/gitea/pull/1468.diff","patch_url":"https://github.com/go-gitea/gitea/pull/1468.patch"},"body":"I was planning to add a check in makefile for Ci to check vendoring changes because it is difficult to check all import and validate vendoring in PR. For example, the change in makefile (test) would catch any missing vendoring or vendoring without editing vendor.json or any vendor that could be removed after a change.\r\n\r\nDoing that I found that `govendor status +outside +unused ` returns on master : \r\n```\r\nThe following packages are missing or modified locally:\r\n\tgithub.com/boltdb/bolt\r\n\tgithub.com/go-xorm/core\r\n\tgithub.com/smartystreets/assertions/internal/go-render/render\r\n\tgithub.com/smartystreets/assertions/internal/oglematchers\r\n\tgithub.com/smartystreets/goconvey/convey/gotest\r\n\tgithub.com/smartystreets/goconvey/convey/reporting\r\n\tgopkg.in/ldap.v2\r\nError: status failed for 7 package(s)\r\n```\r\n\r\nSo I am adding fix of vendor :\r\n- [x] Revome un-used import github.com/smartystreets (used in test in gogs)\r\n- [x] ~~Remove github.com/boltdb/bolt unused dep~~ Fetch github.com/boltdb/bolt  \r\n- [X] github.com/go-xorm/core Is on a commit from a PR not from master : https://github.com/go-xorm/core/pull/21 -> fetch last commit\r\n- [X] sync gopkg.in/ldap.v2/ldap.go since a comment seems to be different in vendor than remote source.\r\n\r\nAfter rebasing and looking at failing drone I found that PR #1448 put to a5cb21c@go-xorm/xorm for files but vendor.json (https://github.com/go-gitea/gitea/blob/master/vendor/vendor.json#L460) to 7e70eb. So I update it and it is a good illustration of difficult to catch error. ^^"},"comment":{"url":"https://api.github.com/repos/go-gitea/gitea/issues/comments/292684069","html_url":"https://github.com/go-gitea/gitea/pull/1468#issuecomment-292684069","issue_url":"https://api.github.com/repos/go-gitea/gitea/issues/1468","id":292684069,"user":{"login":"sapk","id":4052400,"avatar_url":"https://avatars3.githubusercontent.com/u/4052400?v=3","gravatar_id":"","url":"https://api.github.com/users/sapk","html_url":"https://github.com/sapk","followers_url":"https://api.github.com/users/sapk/followers","following_url":"https://api.github.com/users/sapk/following{/other_user}","gists_url":"https://api.github.com/users/sapk/gists{/gist_id}","starred_url":"https://api.github.com/users/sapk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sapk/subscriptions","organizations_url":"https://api.github.com/users/sapk/orgs","repos_url":"https://api.github.com/users/sapk/repos","events_url":"https://api.github.com/users/sapk/events{/privacy}","received_events_url":"https://api.github.com/users/sapk/received_events","type":"User","site_admin":false},"created_at":"2017-04-08T01:05:16Z","updated_at":"2017-04-08T01:05:16Z","body":"After looking further for change from github.com/boltdb/bolt base it's seems that changes were made to compile on specific platform like #1107. \r\n\r\nDon't really know what to do so .... \r\n\r\nShould we make a fork of bolt if we want a custom code and use it in vendor ?"}}
{"actor":{"display_login":"sapk"}}