{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/minikube/pulls/comments/112751316","pull_request_review_id":34094437,"id":112751316,"diff_hunk":"@@ -421,6 +422,51 @@ func MountHost(api libmachine.API, path string) error {\n \treturn nil\n }\n \n+// GetVMHostIP gets the ip address to be used for mapping host -> VM and VM -> host\n+func GetVMHostIP(host *host.Host) (net.IP, error) {\n+\tswitch host.DriverName {\n+\tcase \"kvm\":\n+\t\treturn net.ParseIP(\"192.168.42.1\"), nil\n+\tcase \"hyperv\":\n+\t\tre := regexp.MustCompile(\"\\\"VSwitch\\\": \\\"(.*?)\\\",\")\n+\t\thypervVirtualSwitch := re.FindStringSubmatch(string(host.RawDriver))[1]\n+\t\tip, err := getIPForInterface(fmt.Sprintf(\"vEthernet (%s)\", hypervVirtualSwitch))\n+\t\tif err != nil {\n+\t\t\treturn []byte{}, errors.Wrap(err, \"Error getting 9p mount command\")","path":"pkg/minikube/cluster/cluster.go","position":31,"original_position":31,"commit_id":"2c8ff771c48799d369f0fe47af02a44e7b1586a8","original_commit_id":"2c8ff771c48799d369f0fe47af02a44e7b1586a8","user":{"login":"dlorenc","id":1714486,"avatar_url":"https://avatars2.githubusercontent.com/u/1714486?v=3","gravatar_id":"","url":"https://api.github.com/users/dlorenc","html_url":"https://github.com/dlorenc","followers_url":"https://api.github.com/users/dlorenc/followers","following_url":"https://api.github.com/users/dlorenc/following{/other_user}","gists_url":"https://api.github.com/users/dlorenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dlorenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlorenc/subscriptions","organizations_url":"https://api.github.com/users/dlorenc/orgs","repos_url":"https://api.github.com/users/dlorenc/repos","events_url":"https://api.github.com/users/dlorenc/events{/privacy}","received_events_url":"https://api.github.com/users/dlorenc/received_events","type":"User","site_admin":false},"body":"Should we switch up these error messages too? It's more about an error getting the IP.","created_at":"2017-04-21T18:32:27Z","updated_at":"2017-04-21T18:33:22Z","html_url":"https://github.com/kubernetes/minikube/pull/1388#discussion_r112751316","pull_request_url":"https://api.github.com/repos/kubernetes/minikube/pulls/1388","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/comments/112751316"},"html":{"href":"https://github.com/kubernetes/minikube/pull/1388#discussion_r112751316"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/1388"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/minikube/pulls/1388","id":116821448,"html_url":"https://github.com/kubernetes/minikube/pull/1388","diff_url":"https://github.com/kubernetes/minikube/pull/1388.diff","patch_url":"https://github.com/kubernetes/minikube/pull/1388.patch","issue_url":"https://api.github.com/repos/kubernetes/minikube/issues/1388","number":1388,"state":"open","locked":false,"title":"Fixed mount command to bind on specific VM ip address instead of all …","user":{"login":"aaron-prindle","id":1951658,"avatar_url":"https://avatars3.githubusercontent.com/u/1951658?v=3","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"body":"…interfaces","created_at":"2017-04-20T17:14:03Z","updated_at":"2017-04-21T18:33:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c88c50deddf8c6e34f047eb3ebec6fdb27cdeb14","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/minikube/pulls/1388/commits","review_comments_url":"https://api.github.com/repos/kubernetes/minikube/pulls/1388/comments","review_comment_url":"https://api.github.com/repos/kubernetes/minikube/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/minikube/issues/1388/comments","statuses_url":"https://api.github.com/repos/kubernetes/minikube/statuses/2c8ff771c48799d369f0fe47af02a44e7b1586a8","head":{"label":"aaron-prindle:mount-interface","ref":"mount-interface","sha":"2c8ff771c48799d369f0fe47af02a44e7b1586a8","user":{"login":"aaron-prindle","id":1951658,"avatar_url":"https://avatars3.githubusercontent.com/u/1951658?v=3","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"repo":{"id":59083977,"name":"minikube","full_name":"aaron-prindle/minikube","owner":{"login":"aaron-prindle","id":1951658,"avatar_url":"https://avatars3.githubusercontent.com/u/1951658?v=3","gravatar_id":"","url":"https://api.github.com/users/aaron-prindle","html_url":"https://github.com/aaron-prindle","followers_url":"https://api.github.com/users/aaron-prindle/followers","following_url":"https://api.github.com/users/aaron-prindle/following{/other_user}","gists_url":"https://api.github.com/users/aaron-prindle/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-prindle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-prindle/subscriptions","organizations_url":"https://api.github.com/users/aaron-prindle/orgs","repos_url":"https://api.github.com/users/aaron-prindle/repos","events_url":"https://api.github.com/users/aaron-prindle/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-prindle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaron-prindle/minikube","description":"Run Kubernetes locally","fork":true,"url":"https://api.github.com/repos/aaron-prindle/minikube","forks_url":"https://api.github.com/repos/aaron-prindle/minikube/forks","keys_url":"https://api.github.com/repos/aaron-prindle/minikube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaron-prindle/minikube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaron-prindle/minikube/teams","hooks_url":"https://api.github.com/repos/aaron-prindle/minikube/hooks","issue_events_url":"https://api.github.com/repos/aaron-prindle/minikube/issues/events{/number}","events_url":"https://api.github.com/repos/aaron-prindle/minikube/events","assignees_url":"https://api.github.com/repos/aaron-prindle/minikube/assignees{/user}","branches_url":"https://api.github.com/repos/aaron-prindle/minikube/branches{/branch}","tags_url":"https://api.github.com/repos/aaron-prindle/minikube/tags","blobs_url":"https://api.github.com/repos/aaron-prindle/minikube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaron-prindle/minikube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaron-prindle/minikube/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaron-prindle/minikube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaron-prindle/minikube/statuses/{sha}","languages_url":"https://api.github.com/repos/aaron-prindle/minikube/languages","stargazers_url":"https://api.github.com/repos/aaron-prindle/minikube/stargazers","contributors_url":"https://api.github.com/repos/aaron-prindle/minikube/contributors","subscribers_url":"https://api.github.com/repos/aaron-prindle/minikube/subscribers","subscription_url":"https://api.github.com/repos/aaron-prindle/minikube/subscription","commits_url":"https://api.github.com/repos/aaron-prindle/minikube/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaron-prindle/minikube/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaron-prindle/minikube/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaron-prindle/minikube/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaron-prindle/minikube/contents/{+path}","compare_url":"https://api.github.com/repos/aaron-prindle/minikube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaron-prindle/minikube/merges","archive_url":"https://api.github.com/repos/aaron-prindle/minikube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaron-prindle/minikube/downloads","issues_url":"https://api.github.com/repos/aaron-prindle/minikube/issues{/number}","pulls_url":"https://api.github.com/repos/aaron-prindle/minikube/pulls{/number}","milestones_url":"https://api.github.com/repos/aaron-prindle/minikube/milestones{/number}","notifications_url":"https://api.github.com/repos/aaron-prindle/minikube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaron-prindle/minikube/labels{/name}","releases_url":"https://api.github.com/repos/aaron-prindle/minikube/releases{/id}","deployments_url":"https://api.github.com/repos/aaron-prindle/minikube/deployments","created_at":"2016-05-18T05:15:16Z","updated_at":"2016-05-18T05:15:17Z","pushed_at":"2017-04-21T18:28:44Z","git_url":"git://github.com/aaron-prindle/minikube.git","ssh_url":"git@github.com:aaron-prindle/minikube.git","clone_url":"https://github.com/aaron-prindle/minikube.git","svn_url":"https://github.com/aaron-prindle/minikube","homepage":null,"size":31620,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"43239ac7711432ea269f51a6264c2a938140e27f","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":56353740,"name":"minikube","full_name":"kubernetes/minikube","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/minikube","description":"Run Kubernetes locally","fork":false,"url":"https://api.github.com/repos/kubernetes/minikube","forks_url":"https://api.github.com/repos/kubernetes/minikube/forks","keys_url":"https://api.github.com/repos/kubernetes/minikube/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/minikube/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/minikube/teams","hooks_url":"https://api.github.com/repos/kubernetes/minikube/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/minikube/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/minikube/events","assignees_url":"https://api.github.com/repos/kubernetes/minikube/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/minikube/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/minikube/tags","blobs_url":"https://api.github.com/repos/kubernetes/minikube/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/minikube/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/minikube/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/minikube/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/minikube/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/minikube/languages","stargazers_url":"https://api.github.com/repos/kubernetes/minikube/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/minikube/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/minikube/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/minikube/subscription","commits_url":"https://api.github.com/repos/kubernetes/minikube/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/minikube/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/minikube/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/minikube/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/minikube/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/minikube/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/minikube/merges","archive_url":"https://api.github.com/repos/kubernetes/minikube/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/minikube/downloads","issues_url":"https://api.github.com/repos/kubernetes/minikube/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/minikube/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/minikube/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/minikube/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/minikube/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/minikube/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/minikube/deployments","created_at":"2016-04-15T22:38:35Z","updated_at":"2017-04-21T15:31:56Z","pushed_at":"2017-04-21T18:28:45Z","git_url":"git://github.com/kubernetes/minikube.git","ssh_url":"git@github.com:kubernetes/minikube.git","clone_url":"https://github.com/kubernetes/minikube.git","svn_url":"https://github.com/kubernetes/minikube","homepage":null,"size":32282,"stargazers_count":3647,"watchers_count":3647,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":445,"mirror_url":null,"open_issues_count":137,"forks":445,"open_issues":137,"watchers":3647,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/1388"},"html":{"href":"https://github.com/kubernetes/minikube/pull/1388"},"issue":{"href":"https://api.github.com/repos/kubernetes/minikube/issues/1388"},"comments":{"href":"https://api.github.com/repos/kubernetes/minikube/issues/1388/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/1388/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/minikube/pulls/1388/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/minikube/statuses/2c8ff771c48799d369f0fe47af02a44e7b1586a8"}}}}
{"actor":{"display_login":"dlorenc"}}