{"action":"created","comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/153018536","pull_request_review_id":78974348,"id":153018536,"diff_hunk":"@@ -152,32 +152,35 @@ export class SeoForm extends React.Component {\n \t\t}\n \n \t\t// Don't update state for fields the user has edited\n-\t\tnextState = omit( nextState, dirtyFields.toArray() );\n+\t\tnextState = omit( nextState, [ ...dirtyFields ] );","path":"client/my-sites/site-settings/seo-settings/form.jsx","position":51,"original_position":51,"commit_id":"c50eb20bf6f4fa3bf499abe7c2d1cac91d1590f2","original_commit_id":"c50eb20bf6f4fa3bf499abe7c2d1cac91d1590f2","user":{"login":"samouri","id":4656974,"avatar_url":"https://avatars1.githubusercontent.com/u/4656974?v=4","gravatar_id":"","url":"https://api.github.com/users/samouri","html_url":"https://github.com/samouri","followers_url":"https://api.github.com/users/samouri/followers","following_url":"https://api.github.com/users/samouri/following{/other_user}","gists_url":"https://api.github.com/users/samouri/gists{/gist_id}","starred_url":"https://api.github.com/users/samouri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samouri/subscriptions","organizations_url":"https://api.github.com/users/samouri/orgs","repos_url":"https://api.github.com/users/samouri/repos","events_url":"https://api.github.com/users/samouri/events{/privacy}","received_events_url":"https://api.github.com/users/samouri/received_events","type":"User","site_admin":false},"body":"> Array.from()\r\n\r\nHopefully we polyfill it! We have a number of uses throughout the codebase!","created_at":"2017-11-24T19:05:22Z","updated_at":"2017-11-24T19:05:22Z","html_url":"https://github.com/Automattic/wp-calypso/pull/20182#discussion_r153018536","pull_request_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments/153018536"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/20182#discussion_r153018536"},"pull_request":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20182"}},"in_reply_to_id":153016529},"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20182","id":154468159,"html_url":"https://github.com/Automattic/wp-calypso/pull/20182","diff_url":"https://github.com/Automattic/wp-calypso/pull/20182.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/20182.patch","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20182","number":20182,"state":"open","locked":false,"title":"SEO Settings: Replace Immutable with native Set","user":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars3.githubusercontent.com/u/5431237?v=4","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"body":"Previously we were using an `Immutable.js` `Set` to store the dirty\r\nfields on the SEO form so we could know which fields to update.\r\n\r\nWe don't need Immutable though and if we can get rid of our references\r\nto it then we'll be able to drop a large dependency from Calypso.\r\n\r\n**Testing**\r\n\r\nThis should involve no functional or visual changes.\r\n\r\nIt affects saving and updating fields in the SEO _Traffic_ form.\r\nWe need to try updating subsets of fields, hit save, then make\r\nsure they operate as we expect.\r\n\r\nOnce we have started changing the values for any given field in\r\nthe settings page we should be hitting the code changed in this\r\nPR. I would greatly appreciate some help just changing settings\r\nand seeing what if anything goes bad.","created_at":"2017-11-24T03:25:40Z","updated_at":"2017-11-24T19:05:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"327cb652a2f034c29e4346841fa955fe788983c4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lancewillett","id":66797,"avatar_url":"https://avatars1.githubusercontent.com/u/66797?v=4","gravatar_id":"","url":"https://api.github.com/users/lancewillett","html_url":"https://github.com/lancewillett","followers_url":"https://api.github.com/users/lancewillett/followers","following_url":"https://api.github.com/users/lancewillett/following{/other_user}","gists_url":"https://api.github.com/users/lancewillett/gists{/gist_id}","starred_url":"https://api.github.com/users/lancewillett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lancewillett/subscriptions","organizations_url":"https://api.github.com/users/lancewillett/orgs","repos_url":"https://api.github.com/users/lancewillett/repos","events_url":"https://api.github.com/users/lancewillett/events{/privacy}","received_events_url":"https://api.github.com/users/lancewillett/received_events","type":"User","site_admin":false},{"login":"aidvu","id":1103398,"avatar_url":"https://avatars2.githubusercontent.com/u/1103398?v=4","gravatar_id":"","url":"https://api.github.com/users/aidvu","html_url":"https://github.com/aidvu","followers_url":"https://api.github.com/users/aidvu/followers","following_url":"https://api.github.com/users/aidvu/following{/other_user}","gists_url":"https://api.github.com/users/aidvu/gists{/gist_id}","starred_url":"https://api.github.com/users/aidvu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aidvu/subscriptions","organizations_url":"https://api.github.com/users/aidvu/orgs","repos_url":"https://api.github.com/users/aidvu/repos","events_url":"https://api.github.com/users/aidvu/events{/privacy}","received_events_url":"https://api.github.com/users/aidvu/received_events","type":"User","site_admin":false},{"login":"gwwar","id":1270189,"avatar_url":"https://avatars3.githubusercontent.com/u/1270189?v=4","gravatar_id":"","url":"https://api.github.com/users/gwwar","html_url":"https://github.com/gwwar","followers_url":"https://api.github.com/users/gwwar/followers","following_url":"https://api.github.com/users/gwwar/following{/other_user}","gists_url":"https://api.github.com/users/gwwar/gists{/gist_id}","starred_url":"https://api.github.com/users/gwwar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwwar/subscriptions","organizations_url":"https://api.github.com/users/gwwar/orgs","repos_url":"https://api.github.com/users/gwwar/repos","events_url":"https://api.github.com/users/gwwar/events{/privacy}","received_events_url":"https://api.github.com/users/gwwar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/223","html_url":"https://github.com/Automattic/wp-calypso/milestone/223","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones/223/labels","id":2934678,"number":223,"title":"Remove Immutable.js","description":"It's big and we don't need it","creator":{"login":"dmsnell","id":5431237,"avatar_url":"https://avatars3.githubusercontent.com/u/5431237?v=4","gravatar_id":"","url":"https://api.github.com/users/dmsnell","html_url":"https://github.com/dmsnell","followers_url":"https://api.github.com/users/dmsnell/followers","following_url":"https://api.github.com/users/dmsnell/following{/other_user}","gists_url":"https://api.github.com/users/dmsnell/gists{/gist_id}","starred_url":"https://api.github.com/users/dmsnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmsnell/subscriptions","organizations_url":"https://api.github.com/users/dmsnell/orgs","repos_url":"https://api.github.com/users/dmsnell/repos","events_url":"https://api.github.com/users/dmsnell/events{/privacy}","received_events_url":"https://api.github.com/users/dmsnell/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":1,"state":"open","created_at":"2017-11-24T03:22:05Z","updated_at":"2017-11-24T17:25:03Z","due_on":"2018-01-01T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20182/commits","review_comments_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20182/comments","review_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/20182/comments","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/c50eb20bf6f4fa3bf499abe7c2d1cac91d1590f2","head":{"label":"Automattic:refactor/remove-immutable-set-settings-form","ref":"refactor/remove-immutable-set-settings-form","sha":"c50eb20bf6f4fa3bf499abe7c2d1cac91d1590f2","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-11-24T13:32:16Z","pushed_at":"2017-11-24T19:03:19Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":71186,"stargazers_count":9441,"watchers_count":9441,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1298,"mirror_url":null,"archived":false,"open_issues_count":2281,"forks":1298,"open_issues":2281,"watchers":9441,"default_branch":"master"}},"base":{"label":"Automattic:master","ref":"master","sha":"8d708e40e9112a1e4cccd23fc9d72d3a5ea50b98","user":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"repo":{"id":45936895,"name":"wp-calypso","full_name":"Automattic/wp-calypso","owner":{"login":"Automattic","id":887802,"avatar_url":"https://avatars1.githubusercontent.com/u/887802?v=4","gravatar_id":"","url":"https://api.github.com/users/Automattic","html_url":"https://github.com/Automattic","followers_url":"https://api.github.com/users/Automattic/followers","following_url":"https://api.github.com/users/Automattic/following{/other_user}","gists_url":"https://api.github.com/users/Automattic/gists{/gist_id}","starred_url":"https://api.github.com/users/Automattic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Automattic/subscriptions","organizations_url":"https://api.github.com/users/Automattic/orgs","repos_url":"https://api.github.com/users/Automattic/repos","events_url":"https://api.github.com/users/Automattic/events{/privacy}","received_events_url":"https://api.github.com/users/Automattic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Automattic/wp-calypso","description":"The new JavaScript- and API-powered WordPress.com","fork":false,"url":"https://api.github.com/repos/Automattic/wp-calypso","forks_url":"https://api.github.com/repos/Automattic/wp-calypso/forks","keys_url":"https://api.github.com/repos/Automattic/wp-calypso/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Automattic/wp-calypso/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Automattic/wp-calypso/teams","hooks_url":"https://api.github.com/repos/Automattic/wp-calypso/hooks","issue_events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/events{/number}","events_url":"https://api.github.com/repos/Automattic/wp-calypso/events","assignees_url":"https://api.github.com/repos/Automattic/wp-calypso/assignees{/user}","branches_url":"https://api.github.com/repos/Automattic/wp-calypso/branches{/branch}","tags_url":"https://api.github.com/repos/Automattic/wp-calypso/tags","blobs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Automattic/wp-calypso/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Automattic/wp-calypso/git/refs{/sha}","trees_url":"https://api.github.com/repos/Automattic/wp-calypso/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Automattic/wp-calypso/statuses/{sha}","languages_url":"https://api.github.com/repos/Automattic/wp-calypso/languages","stargazers_url":"https://api.github.com/repos/Automattic/wp-calypso/stargazers","contributors_url":"https://api.github.com/repos/Automattic/wp-calypso/contributors","subscribers_url":"https://api.github.com/repos/Automattic/wp-calypso/subscribers","subscription_url":"https://api.github.com/repos/Automattic/wp-calypso/subscription","commits_url":"https://api.github.com/repos/Automattic/wp-calypso/commits{/sha}","git_commits_url":"https://api.github.com/repos/Automattic/wp-calypso/git/commits{/sha}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/comments{/number}","issue_comment_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments{/number}","contents_url":"https://api.github.com/repos/Automattic/wp-calypso/contents/{+path}","compare_url":"https://api.github.com/repos/Automattic/wp-calypso/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Automattic/wp-calypso/merges","archive_url":"https://api.github.com/repos/Automattic/wp-calypso/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Automattic/wp-calypso/downloads","issues_url":"https://api.github.com/repos/Automattic/wp-calypso/issues{/number}","pulls_url":"https://api.github.com/repos/Automattic/wp-calypso/pulls{/number}","milestones_url":"https://api.github.com/repos/Automattic/wp-calypso/milestones{/number}","notifications_url":"https://api.github.com/repos/Automattic/wp-calypso/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/labels{/name}","releases_url":"https://api.github.com/repos/Automattic/wp-calypso/releases{/id}","deployments_url":"https://api.github.com/repos/Automattic/wp-calypso/deployments","created_at":"2015-11-10T20:00:16Z","updated_at":"2017-11-24T13:32:16Z","pushed_at":"2017-11-24T19:03:19Z","git_url":"git://github.com/Automattic/wp-calypso.git","ssh_url":"git@github.com:Automattic/wp-calypso.git","clone_url":"https://github.com/Automattic/wp-calypso.git","svn_url":"https://github.com/Automattic/wp-calypso","homepage":"https://developer.wordpress.com/calypso/","size":71186,"stargazers_count":9441,"watchers_count":9441,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1298,"mirror_url":null,"archived":false,"open_issues_count":2281,"forks":1298,"open_issues":2281,"watchers":9441,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20182"},"html":{"href":"https://github.com/Automattic/wp-calypso/pull/20182"},"issue":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/20182"},"comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/issues/20182/comments"},"review_comments":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20182/comments"},"review_comment":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Automattic/wp-calypso/pulls/20182/commits"},"statuses":{"href":"https://api.github.com/repos/Automattic/wp-calypso/statuses/c50eb20bf6f4fa3bf499abe7c2d1cac91d1590f2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"samouri"}}