{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/138487101","pull_request_review_id":62289379,"id":138487101,"diff_hunk":"@@ -408,6 +414,39 @@ var _ = SIGDescribe(\"Dynamic Provisioning\", func() {\n \t\t\t}\n \t\t})\n \n+\t\tIt(\"should provision storage with different reclaim policy\", func() {\n+\t\t\tframework.SkipUnlessProviderIs(\"gce\", \"gke\")\n+\n+\t\t\ttest := storageClassTest{\n+\t\t\t\t\"HDD PD on GCE/GKE\",\n+\t\t\t\t[]string{\"gce\", \"gke\"},\n+\t\t\t\t\"kubernetes.io/gce-pd\",\n+\t\t\t\tmap[string]string{\n+\t\t\t\t\t\"type\": \"pd-standard\",\n+\t\t\t\t},\n+\t\t\t\t\"1Gi\",\n+\t\t\t\t\"1Gi\",\n+\t\t\t\tfunc(volume *v1.PersistentVolume) error {\n+\t\t\t\t\treturn checkGCEPD(volume, \"pd-standard\")\n+\t\t\t\t},\n+\t\t\t}\n+\t\t\tclass := newStorageClass(test, ns, \"reclaimPolicy\")\n+\t\t\tretain := v1.PersistentVolumeReclaimRetain\n+\t\t\tclass.ReclaimPolicy = &retain\n+\t\t\tclaim := newClaim(test, ns, \"reclaimPolicy\")\n+\t\t\tclaim.Spec.StorageClassName = &class.Name\n+\t\t\tpv := testDynamicProvisioning(test, c, claim, class)\n+\n+\t\t\tBy(fmt.Sprintf(\"waiting for the provisioned PV %q to enter phase %s\", pv.Name, v1.VolumeReleased))\n+\t\t\tframework.ExpectNoError(framework.WaitForPersistentVolumePhase(v1.VolumeReleased, c, pv.Name, 1*time.Second, 30*time.Second))\n+\n+\t\t\tBy(fmt.Sprintf(\"deleting the storage asset backing the PV %q\", pv.Name))\n+\t\t\tframework.ExpectNoError(framework.DeletePDWithRetry(pv.Spec.GCEPersistentDisk.PDName))\n+\n+\t\t\tBy(fmt.Sprintf(\"deleting the PV %q\", pv.Name))\n+\t\t\tframework.ExpectNoError(framework.DeletePersistentVolume(c, pv.Name), \"Failed to delete PV \", pv.Name)","path":"test/e2e/storage/volume_provisioning.go","position":75,"original_position":75,"commit_id":"fce891e96d569d3fde96327efe97755671017c66","original_commit_id":"fce891e96d569d3fde96327efe97755671017c66","user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars0.githubusercontent.com/u/13111288?v=4","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"body":"okay, wouldn't hurt: will add WaitForPersistentVolumeDeleted after this line","created_at":"2017-09-12T22:53:49Z","updated_at":"2017-09-12T22:53:49Z","html_url":"https://github.com/kubernetes/kubernetes/pull/52350#discussion_r138487101","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52350","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/138487101"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/52350#discussion_r138487101"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52350"}},"in_reply_to_id":138419598},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52350","id":140637008,"html_url":"https://github.com/kubernetes/kubernetes/pull/52350","diff_url":"https://github.com/kubernetes/kubernetes/pull/52350.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/52350.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52350","number":52350,"state":"open","locked":false,"title":"Add e2e test for storageclass.reclaimpolicy","user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars0.githubusercontent.com/u/13111288?v=4","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**: Adds another dynamic provisioning test where the storageclass.reclaimpolicy == retain. Have to manually delete the PV at the end of the test.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: https://github.com/kubernetes/kubernetes/issues/52138\r\n\r\n**Special notes for your reviewer**: I have not tested it but it's ready for review, I will comment and edit this when i've verified it actually works.\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2017-09-12T17:12:37Z","updated_at":"2017-09-12T22:53:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f6216c10c0ae0a2700df9ebe5c011ce9a68fb90e","assignee":{"login":"jeffvance","id":3076896,"avatar_url":"https://avatars3.githubusercontent.com/u/3076896?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffvance","html_url":"https://github.com/jeffvance","followers_url":"https://api.github.com/users/jeffvance/followers","following_url":"https://api.github.com/users/jeffvance/following{/other_user}","gists_url":"https://api.github.com/users/jeffvance/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffvance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffvance/subscriptions","organizations_url":"https://api.github.com/users/jeffvance/orgs","repos_url":"https://api.github.com/users/jeffvance/repos","events_url":"https://api.github.com/users/jeffvance/events{/privacy}","received_events_url":"https://api.github.com/users/jeffvance/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeffvance","id":3076896,"avatar_url":"https://avatars3.githubusercontent.com/u/3076896?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffvance","html_url":"https://github.com/jeffvance","followers_url":"https://api.github.com/users/jeffvance/followers","following_url":"https://api.github.com/users/jeffvance/following{/other_user}","gists_url":"https://api.github.com/users/jeffvance/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffvance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffvance/subscriptions","organizations_url":"https://api.github.com/users/jeffvance/orgs","repos_url":"https://api.github.com/users/jeffvance/repos","events_url":"https://api.github.com/users/jeffvance/events{/privacy}","received_events_url":"https://api.github.com/users/jeffvance/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars1.githubusercontent.com/u/10052848?v=4","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52350/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52350/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/52350/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/fce891e96d569d3fde96327efe97755671017c66","head":{"label":"wongma7:reclaim-e2e","ref":"reclaim-e2e","sha":"fce891e96d569d3fde96327efe97755671017c66","user":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars0.githubusercontent.com/u/13111288?v=4","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"repo":{"id":59241959,"name":"kubernetes","full_name":"wongma7/kubernetes","owner":{"login":"wongma7","id":13111288,"avatar_url":"https://avatars0.githubusercontent.com/u/13111288?v=4","gravatar_id":"","url":"https://api.github.com/users/wongma7","html_url":"https://github.com/wongma7","followers_url":"https://api.github.com/users/wongma7/followers","following_url":"https://api.github.com/users/wongma7/following{/other_user}","gists_url":"https://api.github.com/users/wongma7/gists{/gist_id}","starred_url":"https://api.github.com/users/wongma7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wongma7/subscriptions","organizations_url":"https://api.github.com/users/wongma7/orgs","repos_url":"https://api.github.com/users/wongma7/repos","events_url":"https://api.github.com/users/wongma7/events{/privacy}","received_events_url":"https://api.github.com/users/wongma7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wongma7/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/wongma7/kubernetes","forks_url":"https://api.github.com/repos/wongma7/kubernetes/forks","keys_url":"https://api.github.com/repos/wongma7/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wongma7/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wongma7/kubernetes/teams","hooks_url":"https://api.github.com/repos/wongma7/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/wongma7/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/wongma7/kubernetes/events","assignees_url":"https://api.github.com/repos/wongma7/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/wongma7/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/wongma7/kubernetes/tags","blobs_url":"https://api.github.com/repos/wongma7/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wongma7/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wongma7/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/wongma7/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wongma7/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/wongma7/kubernetes/languages","stargazers_url":"https://api.github.com/repos/wongma7/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/wongma7/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/wongma7/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/wongma7/kubernetes/subscription","commits_url":"https://api.github.com/repos/wongma7/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/wongma7/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/wongma7/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/wongma7/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/wongma7/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/wongma7/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wongma7/kubernetes/merges","archive_url":"https://api.github.com/repos/wongma7/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wongma7/kubernetes/downloads","issues_url":"https://api.github.com/repos/wongma7/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/wongma7/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/wongma7/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/wongma7/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wongma7/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/wongma7/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/wongma7/kubernetes/deployments","created_at":"2016-05-19T20:53:26Z","updated_at":"2016-05-19T20:53:49Z","pushed_at":"2017-09-12T17:10:16Z","git_url":"git://github.com/wongma7/kubernetes.git","ssh_url":"git@github.com:wongma7/kubernetes.git","clone_url":"https://github.com/wongma7/kubernetes.git","svn_url":"https://github.com/wongma7/kubernetes","homepage":"http://kubernetes.io","size":475286,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"6b6b1e5779449a63079c9ff400da752975fe8a06","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-09-12T21:44:56Z","pushed_at":"2017-09-12T22:45:08Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":693307,"stargazers_count":26763,"watchers_count":26763,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9562,"mirror_url":null,"open_issues_count":5414,"forks":9562,"open_issues":5414,"watchers":26763,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52350"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/52350"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/52350"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/52350/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52350/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/52350/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/fce891e96d569d3fde96327efe97755671017c66"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wongma7"}}