{"action":"created","comment":{"url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/comments/154495919","pull_request_review_id":80674706,"id":154495919,"diff_hunk":"@@ -13,21 +13,68 @@ def servo(wpilib):\n def servo_data(hal_data):\n     return hal_data['pwm'][2]\n \n+\n+@pytest.fixture(scope=\"function\")\n+def servo_table(networktables):\n+    return networktables.NetworkTables.getTable(\"whereitshouldreallygotodo\")","path":"wpilib/tests/test_servo.py","position":null,"original_position":14,"commit_id":"99a14fefecc360c1966ea97e35e1d5139a153ebd","original_commit_id":"5f6e70fc5929568baf01793a5d69a39cddbf28a6","user":{"login":"virtuald","id":567900,"avatar_url":"https://avatars3.githubusercontent.com/u/567900?v=4","gravatar_id":"","url":"https://api.github.com/users/virtuald","html_url":"https://github.com/virtuald","followers_url":"https://api.github.com/users/virtuald/followers","following_url":"https://api.github.com/users/virtuald/following{/other_user}","gists_url":"https://api.github.com/users/virtuald/gists{/gist_id}","starred_url":"https://api.github.com/users/virtuald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/virtuald/subscriptions","organizations_url":"https://api.github.com/users/virtuald/orgs","repos_url":"https://api.github.com/users/virtuald/repos","events_url":"https://api.github.com/users/virtuald/events{/privacy}","received_events_url":"https://api.github.com/users/virtuald/received_events","type":"User","site_admin":false},"body":"Perhaps we should create a test helper to help testing LiveWindow related things?","created_at":"2017-12-02T13:02:00Z","updated_at":"2017-12-02T13:02:00Z","html_url":"https://github.com/robotpy/robotpy-wpilib/pull/337#discussion_r154495919","pull_request_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/337","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/comments/154495919"},"html":{"href":"https://github.com/robotpy/robotpy-wpilib/pull/337#discussion_r154495919"},"pull_request":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/337"}},"in_reply_to_id":153987553},"pull_request":{"url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/337","id":155489226,"html_url":"https://github.com/robotpy/robotpy-wpilib/pull/337","diff_url":"https://github.com/robotpy/robotpy-wpilib/pull/337.diff","patch_url":"https://github.com/robotpy/robotpy-wpilib/pull/337.patch","issue_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/337","number":337,"state":"closed","locked":false,"title":"add unit tests for servo","user":{"login":"ariovistus","id":842452,"avatar_url":"https://avatars2.githubusercontent.com/u/842452?v=4","gravatar_id":"","url":"https://api.github.com/users/ariovistus","html_url":"https://github.com/ariovistus","followers_url":"https://api.github.com/users/ariovistus/followers","following_url":"https://api.github.com/users/ariovistus/following{/other_user}","gists_url":"https://api.github.com/users/ariovistus/gists{/gist_id}","starred_url":"https://api.github.com/users/ariovistus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ariovistus/subscriptions","organizations_url":"https://api.github.com/users/ariovistus/orgs","repos_url":"https://api.github.com/users/ariovistus/repos","events_url":"https://api.github.com/users/ariovistus/events{/privacy}","received_events_url":"https://api.github.com/users/ariovistus/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-11-30T00:26:45Z","updated_at":"2017-12-02T13:02:00Z","closed_at":"2017-12-02T13:01:28Z","merged_at":"2017-12-02T13:01:28Z","merge_commit_sha":"458c304d526cda4fbd0f87f8a2e9f7eb3598528c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/337/commits","review_comments_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/337/comments","review_comment_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/337/comments","statuses_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/statuses/99a14fefecc360c1966ea97e35e1d5139a153ebd","head":{"label":"Retro3223:servo","ref":"servo","sha":"99a14fefecc360c1966ea97e35e1d5139a153ebd","user":{"login":"Retro3223","id":6465744,"avatar_url":"https://avatars0.githubusercontent.com/u/6465744?v=4","gravatar_id":"","url":"https://api.github.com/users/Retro3223","html_url":"https://github.com/Retro3223","followers_url":"https://api.github.com/users/Retro3223/followers","following_url":"https://api.github.com/users/Retro3223/following{/other_user}","gists_url":"https://api.github.com/users/Retro3223/gists{/gist_id}","starred_url":"https://api.github.com/users/Retro3223/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Retro3223/subscriptions","organizations_url":"https://api.github.com/users/Retro3223/orgs","repos_url":"https://api.github.com/users/Retro3223/repos","events_url":"https://api.github.com/users/Retro3223/events{/privacy}","received_events_url":"https://api.github.com/users/Retro3223/received_events","type":"Organization","site_admin":false},"repo":{"id":105498436,"name":"robotpy-wpilib","full_name":"Retro3223/robotpy-wpilib","owner":{"login":"Retro3223","id":6465744,"avatar_url":"https://avatars0.githubusercontent.com/u/6465744?v=4","gravatar_id":"","url":"https://api.github.com/users/Retro3223","html_url":"https://github.com/Retro3223","followers_url":"https://api.github.com/users/Retro3223/followers","following_url":"https://api.github.com/users/Retro3223/following{/other_user}","gists_url":"https://api.github.com/users/Retro3223/gists{/gist_id}","starred_url":"https://api.github.com/users/Retro3223/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Retro3223/subscriptions","organizations_url":"https://api.github.com/users/Retro3223/orgs","repos_url":"https://api.github.com/users/Retro3223/repos","events_url":"https://api.github.com/users/Retro3223/events{/privacy}","received_events_url":"https://api.github.com/users/Retro3223/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Retro3223/robotpy-wpilib","description":"Pure python implementation of WPILib for FIRST Robotics Competition (FRC)","fork":true,"url":"https://api.github.com/repos/Retro3223/robotpy-wpilib","forks_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/forks","keys_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/teams","hooks_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/hooks","issue_events_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/issues/events{/number}","events_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/events","assignees_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/assignees{/user}","branches_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/branches{/branch}","tags_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/tags","blobs_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/statuses/{sha}","languages_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/languages","stargazers_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/stargazers","contributors_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/contributors","subscribers_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/subscribers","subscription_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/subscription","commits_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/contents/{+path}","compare_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/merges","archive_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/downloads","issues_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/issues{/number}","pulls_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/pulls{/number}","milestones_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/milestones{/number}","notifications_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/labels{/name}","releases_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/releases{/id}","deployments_url":"https://api.github.com/repos/Retro3223/robotpy-wpilib/deployments","created_at":"2017-10-02T04:35:43Z","updated_at":"2017-10-02T04:35:45Z","pushed_at":"2017-12-02T04:21:00Z","git_url":"git://github.com/Retro3223/robotpy-wpilib.git","ssh_url":"git@github.com:Retro3223/robotpy-wpilib.git","clone_url":"https://github.com/Retro3223/robotpy-wpilib.git","svn_url":"https://github.com/Retro3223/robotpy-wpilib","homepage":"https://robotpy.github.io","size":1627,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robotpy:master","ref":"master","sha":"b967a4fd8f2754049ac63e24144de1e12c29033c","user":{"login":"robotpy","id":640276,"avatar_url":"https://avatars1.githubusercontent.com/u/640276?v=4","gravatar_id":"","url":"https://api.github.com/users/robotpy","html_url":"https://github.com/robotpy","followers_url":"https://api.github.com/users/robotpy/followers","following_url":"https://api.github.com/users/robotpy/following{/other_user}","gists_url":"https://api.github.com/users/robotpy/gists{/gist_id}","starred_url":"https://api.github.com/users/robotpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotpy/subscriptions","organizations_url":"https://api.github.com/users/robotpy/orgs","repos_url":"https://api.github.com/users/robotpy/repos","events_url":"https://api.github.com/users/robotpy/events{/privacy}","received_events_url":"https://api.github.com/users/robotpy/received_events","type":"Organization","site_admin":false},"repo":{"id":24757484,"name":"robotpy-wpilib","full_name":"robotpy/robotpy-wpilib","owner":{"login":"robotpy","id":640276,"avatar_url":"https://avatars1.githubusercontent.com/u/640276?v=4","gravatar_id":"","url":"https://api.github.com/users/robotpy","html_url":"https://github.com/robotpy","followers_url":"https://api.github.com/users/robotpy/followers","following_url":"https://api.github.com/users/robotpy/following{/other_user}","gists_url":"https://api.github.com/users/robotpy/gists{/gist_id}","starred_url":"https://api.github.com/users/robotpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotpy/subscriptions","organizations_url":"https://api.github.com/users/robotpy/orgs","repos_url":"https://api.github.com/users/robotpy/repos","events_url":"https://api.github.com/users/robotpy/events{/privacy}","received_events_url":"https://api.github.com/users/robotpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotpy/robotpy-wpilib","description":"Pure python implementation of WPILib for FIRST Robotics Competition (FRC)","fork":false,"url":"https://api.github.com/repos/robotpy/robotpy-wpilib","forks_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/forks","keys_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/teams","hooks_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/hooks","issue_events_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/events{/number}","events_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/events","assignees_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/assignees{/user}","branches_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/branches{/branch}","tags_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/tags","blobs_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/statuses/{sha}","languages_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/languages","stargazers_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/stargazers","contributors_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/contributors","subscribers_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/subscribers","subscription_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/subscription","commits_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/contents/{+path}","compare_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/merges","archive_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/downloads","issues_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues{/number}","pulls_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls{/number}","milestones_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/milestones{/number}","notifications_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/labels{/name}","releases_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/releases{/id}","deployments_url":"https://api.github.com/repos/robotpy/robotpy-wpilib/deployments","created_at":"2014-10-03T12:25:01Z","updated_at":"2017-11-28T07:57:43Z","pushed_at":"2017-12-02T13:01:28Z","git_url":"git://github.com/robotpy/robotpy-wpilib.git","ssh_url":"git@github.com:robotpy/robotpy-wpilib.git","clone_url":"https://github.com/robotpy/robotpy-wpilib.git","svn_url":"https://github.com/robotpy/robotpy-wpilib","homepage":"https://robotpy.github.io","size":1606,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":32,"open_issues":25,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/337"},"html":{"href":"https://github.com/robotpy/robotpy-wpilib/pull/337"},"issue":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/337"},"comments":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/robotpy/robotpy-wpilib/statuses/99a14fefecc360c1966ea97e35e1d5139a153ebd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"virtuald"}}