{"action":"closed","number":72,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls/72","id":111090507,"html_url":"https://github.com/ONSdigital/eq-terraform/pull/72","diff_url":"https://github.com/ONSdigital/eq-terraform/pull/72.diff","patch_url":"https://github.com/ONSdigital/eq-terraform/pull/72.patch","issue_url":"https://api.github.com/repos/ONSdigital/eq-terraform/issues/72","number":72,"state":"closed","locked":false,"title":"Disable root ebs delete_on_termination","user":{"login":"benjefferies","id":15050019,"avatar_url":"https://avatars1.githubusercontent.com/u/15050019?v=3","gravatar_id":"","url":"https://api.github.com/users/benjefferies","html_url":"https://github.com/benjefferies","followers_url":"https://api.github.com/users/benjefferies/followers","following_url":"https://api.github.com/users/benjefferies/following{/other_user}","gists_url":"https://api.github.com/users/benjefferies/gists{/gist_id}","starred_url":"https://api.github.com/users/benjefferies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjefferies/subscriptions","organizations_url":"https://api.github.com/users/benjefferies/orgs","repos_url":"https://api.github.com/users/benjefferies/repos","events_url":"https://api.github.com/users/benjefferies/events{/privacy}","received_events_url":"https://api.github.com/users/benjefferies/received_events","type":"User","site_admin":false},"body":"## What is the context of this PR?\r\n[trello](https://trello.com/c/JnsvipYm/1009-disable-delete-on-terminate-for-rabbit-volume)\r\n\r\nThis won't have any effect on existing instances. See note on\r\nhttps://www.terraform.io/docs/providers/aws/r/instance.html.\r\n\r\nTo manually apply to an existing instance run `aws ec2\r\nmodify-instance-attribute --instance-id i-XXXXXXXXXXXX\r\n--block-device-mappings \"[{\\\"DeviceName\\\":\r\n\\\"/dev/sda1\\\",\\\"Ebs\\\":{\\\"DeleteOnTermination\\\":false}}]\"`\r\n\r\n### How to review\r\nDeploy rabbit infrastructure and check `delete on termination` flag\r\n1. Go to EC2 console\r\n1. Click on RabbitMQ EC2 instance\r\n1. Click on `Root device` in description tab\r\n1. Observe `delete on termination` status\r\n","created_at":"2017-03-16T15:09:10Z","updated_at":"2017-03-21T17:39:45Z","closed_at":"2017-03-21T17:39:45Z","merged_at":"2017-03-21T17:39:45Z","merge_commit_sha":"ba96c3d149b4ed6e4d1da0a0f9edd9ffe50cb5fa","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls/72/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls/72/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/eq-terraform/issues/72/comments","statuses_url":"https://api.github.com/repos/ONSdigital/eq-terraform/statuses/565228f6be469c8cc77f3af761ad315efcd85b2f","head":{"label":"ONSdigital:1009-disable-delete-on-terminate-for-rabbit-volume","ref":"1009-disable-delete-on-terminate-for-rabbit-volume","sha":"565228f6be469c8cc77f3af761ad315efcd85b2f","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars3.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":49879277,"name":"eq-terraform","full_name":"ONSdigital/eq-terraform","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars3.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/eq-terraform","description":"Infrastructure as code for the eq system. ","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-terraform","forks_url":"https://api.github.com/repos/ONSdigital/eq-terraform/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-terraform/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-terraform/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-terraform/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-terraform/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-terraform/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-terraform/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-terraform/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-terraform/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-terraform/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-terraform/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-terraform/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-terraform/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-terraform/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-terraform/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-terraform/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-terraform/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-terraform/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-terraform/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-terraform/deployments","created_at":"2016-01-18T13:41:38Z","updated_at":"2017-01-25T10:49:44Z","pushed_at":"2017-03-21T17:39:45Z","git_url":"git://github.com/ONSdigital/eq-terraform.git","ssh_url":"git@github.com:ONSdigital/eq-terraform.git","clone_url":"https://github.com/ONSdigital/eq-terraform.git","svn_url":"https://github.com/ONSdigital/eq-terraform","homepage":"","size":152,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"ONSdigital:master","ref":"master","sha":"f54011bcf2ce79a943c9d8d214020483b5c2b616","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars3.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":49879277,"name":"eq-terraform","full_name":"ONSdigital/eq-terraform","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars3.githubusercontent.com/u/6865137?v=3","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/eq-terraform","description":"Infrastructure as code for the eq system. ","fork":false,"url":"https://api.github.com/repos/ONSdigital/eq-terraform","forks_url":"https://api.github.com/repos/ONSdigital/eq-terraform/forks","keys_url":"https://api.github.com/repos/ONSdigital/eq-terraform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/eq-terraform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/eq-terraform/teams","hooks_url":"https://api.github.com/repos/ONSdigital/eq-terraform/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/eq-terraform/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/eq-terraform/events","assignees_url":"https://api.github.com/repos/ONSdigital/eq-terraform/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/eq-terraform/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/eq-terraform/tags","blobs_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/eq-terraform/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/eq-terraform/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/eq-terraform/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/eq-terraform/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/eq-terraform/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/eq-terraform/subscription","commits_url":"https://api.github.com/repos/ONSdigital/eq-terraform/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/eq-terraform/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/eq-terraform/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/eq-terraform/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/eq-terraform/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/eq-terraform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/eq-terraform/merges","archive_url":"https://api.github.com/repos/ONSdigital/eq-terraform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/eq-terraform/downloads","issues_url":"https://api.github.com/repos/ONSdigital/eq-terraform/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/eq-terraform/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/eq-terraform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/eq-terraform/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/eq-terraform/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/eq-terraform/deployments","created_at":"2016-01-18T13:41:38Z","updated_at":"2017-01-25T10:49:44Z","pushed_at":"2017-03-21T17:39:45Z","git_url":"git://github.com/ONSdigital/eq-terraform.git","ssh_url":"git@github.com:ONSdigital/eq-terraform.git","clone_url":"https://github.com/ONSdigital/eq-terraform.git","svn_url":"https://github.com/ONSdigital/eq-terraform","homepage":"","size":152,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls/72"},"html":{"href":"https://github.com/ONSdigital/eq-terraform/pull/72"},"issue":{"href":"https://api.github.com/repos/ONSdigital/eq-terraform/issues/72"},"comments":{"href":"https://api.github.com/repos/ONSdigital/eq-terraform/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/eq-terraform/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/eq-terraform/statuses/565228f6be469c8cc77f3af761ad315efcd85b2f"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"ajmaddaford","id":1754822,"avatar_url":"https://avatars0.githubusercontent.com/u/1754822?v=3","gravatar_id":"","url":"https://api.github.com/users/ajmaddaford","html_url":"https://github.com/ajmaddaford","followers_url":"https://api.github.com/users/ajmaddaford/followers","following_url":"https://api.github.com/users/ajmaddaford/following{/other_user}","gists_url":"https://api.github.com/users/ajmaddaford/gists{/gist_id}","starred_url":"https://api.github.com/users/ajmaddaford/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajmaddaford/subscriptions","organizations_url":"https://api.github.com/users/ajmaddaford/orgs","repos_url":"https://api.github.com/users/ajmaddaford/repos","events_url":"https://api.github.com/users/ajmaddaford/events{/privacy}","received_events_url":"https://api.github.com/users/ajmaddaford/received_events","type":"User","site_admin":false},"comments":1,"review_comments":8,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":1,"changed_files":4}}
{"actor":{"display_login":"ajmaddaford"}}