{"action":"created","comment":{"url":"https://api.github.com/repos/AlexSananka/Instat/pulls/comments/136296373","pull_request_review_id":59812184,"id":136296373,"diff_hunk":"@@ -166,18 +171,10 @@ Public Class dlgDuplicatesConstructed\n \r\n     Private Sub SetIgnoreVals()\r\n         If ucrChkOmitValues.Checked Then\r\n-            If Not ucrReceiverForDuplicates.IsEmpty Then\r\n-                Dim strVarToEvaluate As String\r\n-                strVarToEvaluate = ucrReceiverForDuplicates.GetVariableNames\r\n-                If Not ucrInputConditions.IsEmpty AndAlso ucrNudOmit.GetText <> \"\" Then\r","path":"instat/dlgDuplicatesConstructed.vb","position":44,"original_position":44,"commit_id":"9ada089186596909caa49800e6fa5ee591fe037e","original_commit_id":"9ada089186596909caa49800e6fa5ee591fe037e","user":{"login":"lilyclements","id":21180424,"avatar_url":"https://avatars1.githubusercontent.com/u/21180424?v=4","gravatar_id":"","url":"https://api.github.com/users/lilyclements","html_url":"https://github.com/lilyclements","followers_url":"https://api.github.com/users/lilyclements/followers","following_url":"https://api.github.com/users/lilyclements/following{/other_user}","gists_url":"https://api.github.com/users/lilyclements/gists{/gist_id}","starred_url":"https://api.github.com/users/lilyclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilyclements/subscriptions","organizations_url":"https://api.github.com/users/lilyclements/orgs","repos_url":"https://api.github.com/users/lilyclements/repos","events_url":"https://api.github.com/users/lilyclements/events{/privacy}","received_events_url":"https://api.github.com/users/lilyclements/received_events","type":"User","site_admin":false},"body":"We only need to have one if statement: if ucrChkOmitValues is checked.\r\nWe can still re-run the sub when the ucrInputConditions, ucrNudOmit or ucrReceiver change because that will change the contents of this sub. But, we only need ucrChkOmitValues in the if statement","created_at":"2017-08-31T10:09:55Z","updated_at":"2017-08-31T10:12:43Z","html_url":"https://github.com/AlexSananka/Instat/pull/179#discussion_r136296373","pull_request_url":"https://api.github.com/repos/AlexSananka/Instat/pulls/179","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/AlexSananka/Instat/pulls/comments/136296373"},"html":{"href":"https://github.com/AlexSananka/Instat/pull/179#discussion_r136296373"},"pull_request":{"href":"https://api.github.com/repos/AlexSananka/Instat/pulls/179"}}},"pull_request":{"url":"https://api.github.com/repos/AlexSananka/Instat/pulls/179","id":138627960,"html_url":"https://github.com/AlexSananka/Instat/pull/179","diff_url":"https://github.com/AlexSananka/Instat/pull/179.diff","patch_url":"https://github.com/AlexSananka/Instat/pull/179.patch","issue_url":"https://api.github.com/repos/AlexSananka/Instat/issues/179","number":179,"state":"open","locked":false,"title":"Alex duplicates","user":{"login":"lilyclements","id":21180424,"avatar_url":"https://avatars1.githubusercontent.com/u/21180424?v=4","gravatar_id":"","url":"https://api.github.com/users/lilyclements","html_url":"https://github.com/lilyclements","followers_url":"https://api.github.com/users/lilyclements/followers","following_url":"https://api.github.com/users/lilyclements/following{/other_user}","gists_url":"https://api.github.com/users/lilyclements/gists{/gist_id}","starred_url":"https://api.github.com/users/lilyclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilyclements/subscriptions","organizations_url":"https://api.github.com/users/lilyclements/orgs","repos_url":"https://api.github.com/users/lilyclements/repos","events_url":"https://api.github.com/users/lilyclements/events{/privacy}","received_events_url":"https://api.github.com/users/lilyclements/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-31T10:06:02Z","updated_at":"2017-08-31T10:12:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33f6c72d1ddd49a43071ceb50d5dc28f77a14e54","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/AlexSananka/Instat/pulls/179/commits","review_comments_url":"https://api.github.com/repos/AlexSananka/Instat/pulls/179/comments","review_comment_url":"https://api.github.com/repos/AlexSananka/Instat/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AlexSananka/Instat/issues/179/comments","statuses_url":"https://api.github.com/repos/AlexSananka/Instat/statuses/9ada089186596909caa49800e6fa5ee591fe037e","head":{"label":"lilyclements:AlexDuplicates","ref":"AlexDuplicates","sha":"9ada089186596909caa49800e6fa5ee591fe037e","user":{"login":"lilyclements","id":21180424,"avatar_url":"https://avatars1.githubusercontent.com/u/21180424?v=4","gravatar_id":"","url":"https://api.github.com/users/lilyclements","html_url":"https://github.com/lilyclements","followers_url":"https://api.github.com/users/lilyclements/followers","following_url":"https://api.github.com/users/lilyclements/following{/other_user}","gists_url":"https://api.github.com/users/lilyclements/gists{/gist_id}","starred_url":"https://api.github.com/users/lilyclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilyclements/subscriptions","organizations_url":"https://api.github.com/users/lilyclements/orgs","repos_url":"https://api.github.com/users/lilyclements/repos","events_url":"https://api.github.com/users/lilyclements/events{/privacy}","received_events_url":"https://api.github.com/users/lilyclements/received_events","type":"User","site_admin":false},"repo":{"id":66364277,"name":"R-Instat","full_name":"lilyclements/R-Instat","owner":{"login":"lilyclements","id":21180424,"avatar_url":"https://avatars1.githubusercontent.com/u/21180424?v=4","gravatar_id":"","url":"https://api.github.com/users/lilyclements","html_url":"https://github.com/lilyclements","followers_url":"https://api.github.com/users/lilyclements/followers","following_url":"https://api.github.com/users/lilyclements/following{/other_user}","gists_url":"https://api.github.com/users/lilyclements/gists{/gist_id}","starred_url":"https://api.github.com/users/lilyclements/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilyclements/subscriptions","organizations_url":"https://api.github.com/users/lilyclements/orgs","repos_url":"https://api.github.com/users/lilyclements/repos","events_url":"https://api.github.com/users/lilyclements/events{/privacy}","received_events_url":"https://api.github.com/users/lilyclements/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lilyclements/R-Instat","description":"Development of the new version of Instat","fork":true,"url":"https://api.github.com/repos/lilyclements/R-Instat","forks_url":"https://api.github.com/repos/lilyclements/R-Instat/forks","keys_url":"https://api.github.com/repos/lilyclements/R-Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lilyclements/R-Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lilyclements/R-Instat/teams","hooks_url":"https://api.github.com/repos/lilyclements/R-Instat/hooks","issue_events_url":"https://api.github.com/repos/lilyclements/R-Instat/issues/events{/number}","events_url":"https://api.github.com/repos/lilyclements/R-Instat/events","assignees_url":"https://api.github.com/repos/lilyclements/R-Instat/assignees{/user}","branches_url":"https://api.github.com/repos/lilyclements/R-Instat/branches{/branch}","tags_url":"https://api.github.com/repos/lilyclements/R-Instat/tags","blobs_url":"https://api.github.com/repos/lilyclements/R-Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lilyclements/R-Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lilyclements/R-Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/lilyclements/R-Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lilyclements/R-Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/lilyclements/R-Instat/languages","stargazers_url":"https://api.github.com/repos/lilyclements/R-Instat/stargazers","contributors_url":"https://api.github.com/repos/lilyclements/R-Instat/contributors","subscribers_url":"https://api.github.com/repos/lilyclements/R-Instat/subscribers","subscription_url":"https://api.github.com/repos/lilyclements/R-Instat/subscription","commits_url":"https://api.github.com/repos/lilyclements/R-Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/lilyclements/R-Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/lilyclements/R-Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/lilyclements/R-Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/lilyclements/R-Instat/contents/{+path}","compare_url":"https://api.github.com/repos/lilyclements/R-Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lilyclements/R-Instat/merges","archive_url":"https://api.github.com/repos/lilyclements/R-Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lilyclements/R-Instat/downloads","issues_url":"https://api.github.com/repos/lilyclements/R-Instat/issues{/number}","pulls_url":"https://api.github.com/repos/lilyclements/R-Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/lilyclements/R-Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/lilyclements/R-Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lilyclements/R-Instat/labels{/name}","releases_url":"https://api.github.com/repos/lilyclements/R-Instat/releases{/id}","deployments_url":"https://api.github.com/repos/lilyclements/R-Instat/deployments","created_at":"2016-08-23T12:19:50Z","updated_at":"2017-05-30T13:48:31Z","pushed_at":"2017-08-31T10:05:04Z","git_url":"git://github.com/lilyclements/R-Instat.git","ssh_url":"git@github.com:lilyclements/R-Instat.git","clone_url":"https://github.com/lilyclements/R-Instat.git","svn_url":"https://github.com/lilyclements/R-Instat","homepage":null,"size":1528923,"stargazers_count":0,"watchers_count":0,"language":"Visual Basic","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"frmMain"}},"base":{"label":"AlexSananka:DuplicatesAdditionalOption","ref":"DuplicatesAdditionalOption","sha":"a440adf184493b545d976447be83d0214552f573","user":{"login":"AlexSananka","id":25578150,"avatar_url":"https://avatars2.githubusercontent.com/u/25578150?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexSananka","html_url":"https://github.com/AlexSananka","followers_url":"https://api.github.com/users/AlexSananka/followers","following_url":"https://api.github.com/users/AlexSananka/following{/other_user}","gists_url":"https://api.github.com/users/AlexSananka/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexSananka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexSananka/subscriptions","organizations_url":"https://api.github.com/users/AlexSananka/orgs","repos_url":"https://api.github.com/users/AlexSananka/repos","events_url":"https://api.github.com/users/AlexSananka/events{/privacy}","received_events_url":"https://api.github.com/users/AlexSananka/received_events","type":"User","site_admin":false},"repo":{"id":81092050,"name":"Instat","full_name":"AlexSananka/Instat","owner":{"login":"AlexSananka","id":25578150,"avatar_url":"https://avatars2.githubusercontent.com/u/25578150?v=4","gravatar_id":"","url":"https://api.github.com/users/AlexSananka","html_url":"https://github.com/AlexSananka","followers_url":"https://api.github.com/users/AlexSananka/followers","following_url":"https://api.github.com/users/AlexSananka/following{/other_user}","gists_url":"https://api.github.com/users/AlexSananka/gists{/gist_id}","starred_url":"https://api.github.com/users/AlexSananka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlexSananka/subscriptions","organizations_url":"https://api.github.com/users/AlexSananka/orgs","repos_url":"https://api.github.com/users/AlexSananka/repos","events_url":"https://api.github.com/users/AlexSananka/events{/privacy}","received_events_url":"https://api.github.com/users/AlexSananka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AlexSananka/Instat","description":"A statistics software package powered by R","fork":true,"url":"https://api.github.com/repos/AlexSananka/Instat","forks_url":"https://api.github.com/repos/AlexSananka/Instat/forks","keys_url":"https://api.github.com/repos/AlexSananka/Instat/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AlexSananka/Instat/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AlexSananka/Instat/teams","hooks_url":"https://api.github.com/repos/AlexSananka/Instat/hooks","issue_events_url":"https://api.github.com/repos/AlexSananka/Instat/issues/events{/number}","events_url":"https://api.github.com/repos/AlexSananka/Instat/events","assignees_url":"https://api.github.com/repos/AlexSananka/Instat/assignees{/user}","branches_url":"https://api.github.com/repos/AlexSananka/Instat/branches{/branch}","tags_url":"https://api.github.com/repos/AlexSananka/Instat/tags","blobs_url":"https://api.github.com/repos/AlexSananka/Instat/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AlexSananka/Instat/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AlexSananka/Instat/git/refs{/sha}","trees_url":"https://api.github.com/repos/AlexSananka/Instat/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AlexSananka/Instat/statuses/{sha}","languages_url":"https://api.github.com/repos/AlexSananka/Instat/languages","stargazers_url":"https://api.github.com/repos/AlexSananka/Instat/stargazers","contributors_url":"https://api.github.com/repos/AlexSananka/Instat/contributors","subscribers_url":"https://api.github.com/repos/AlexSananka/Instat/subscribers","subscription_url":"https://api.github.com/repos/AlexSananka/Instat/subscription","commits_url":"https://api.github.com/repos/AlexSananka/Instat/commits{/sha}","git_commits_url":"https://api.github.com/repos/AlexSananka/Instat/git/commits{/sha}","comments_url":"https://api.github.com/repos/AlexSananka/Instat/comments{/number}","issue_comment_url":"https://api.github.com/repos/AlexSananka/Instat/issues/comments{/number}","contents_url":"https://api.github.com/repos/AlexSananka/Instat/contents/{+path}","compare_url":"https://api.github.com/repos/AlexSananka/Instat/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AlexSananka/Instat/merges","archive_url":"https://api.github.com/repos/AlexSananka/Instat/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AlexSananka/Instat/downloads","issues_url":"https://api.github.com/repos/AlexSananka/Instat/issues{/number}","pulls_url":"https://api.github.com/repos/AlexSananka/Instat/pulls{/number}","milestones_url":"https://api.github.com/repos/AlexSananka/Instat/milestones{/number}","notifications_url":"https://api.github.com/repos/AlexSananka/Instat/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AlexSananka/Instat/labels{/name}","releases_url":"https://api.github.com/repos/AlexSananka/Instat/releases{/id}","deployments_url":"https://api.github.com/repos/AlexSananka/Instat/deployments","created_at":"2017-02-06T13:53:12Z","updated_at":"2017-02-06T13:53:18Z","pushed_at":"2017-08-31T10:06:03Z","git_url":"git://github.com/AlexSananka/Instat.git","ssh_url":"git@github.com:AlexSananka/Instat.git","clone_url":"https://github.com/AlexSananka/Instat.git","svn_url":"https://github.com/AlexSananka/Instat","homepage":"https://chuffed.org/project/africandatainitiative","size":1528720,"stargazers_count":0,"watchers_count":0,"language":"Visual Basic","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AlexSananka/Instat/pulls/179"},"html":{"href":"https://github.com/AlexSananka/Instat/pull/179"},"issue":{"href":"https://api.github.com/repos/AlexSananka/Instat/issues/179"},"comments":{"href":"https://api.github.com/repos/AlexSananka/Instat/issues/179/comments"},"review_comments":{"href":"https://api.github.com/repos/AlexSananka/Instat/pulls/179/comments"},"review_comment":{"href":"https://api.github.com/repos/AlexSananka/Instat/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AlexSananka/Instat/pulls/179/commits"},"statuses":{"href":"https://api.github.com/repos/AlexSananka/Instat/statuses/9ada089186596909caa49800e6fa5ee591fe037e"}},"author_association":"NONE"}}
{"actor":{"display_login":"lilyclements"}}