{"action":"created","issue":{"url":"https://api.github.com/repos/kata-containers/agent/issues/56","repository_url":"https://api.github.com/repos/kata-containers/agent","labels_url":"https://api.github.com/repos/kata-containers/agent/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/kata-containers/agent/issues/56/comments","events_url":"https://api.github.com/repos/kata-containers/agent/issues/56/events","html_url":"https://github.com/kata-containers/agent/pull/56","id":281401752,"number":56,"title":"[RFC] make UpdateInterface() declarative","user":{"login":"laijs","id":125671,"avatar_url":"https://avatars1.githubusercontent.com/u/125671?v=4","gravatar_id":"","url":"https://api.github.com/users/laijs","html_url":"https://github.com/laijs","followers_url":"https://api.github.com/users/laijs/followers","following_url":"https://api.github.com/users/laijs/following{/other_user}","gists_url":"https://api.github.com/users/laijs/gists{/gist_id}","starred_url":"https://api.github.com/users/laijs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laijs/subscriptions","organizations_url":"https://api.github.com/users/laijs/orgs","repos_url":"https://api.github.com/users/laijs/repos","events_url":"https://api.github.com/users/laijs/events{/privacy}","received_events_url":"https://api.github.com/users/laijs/received_events","type":"User","site_admin":false},"labels":[{"id":764365107,"url":"https://api.github.com/repos/kata-containers/agent/labels/do-not-merge","name":"do-not-merge","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2017-12-12T14:23:21Z","updated_at":"2017-12-20T10:51:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kata-containers/agent/pulls/56","html_url":"https://github.com/kata-containers/agent/pull/56","diff_url":"https://github.com/kata-containers/agent/pull/56.diff","patch_url":"https://github.com/kata-containers/agent/pull/56.patch"},"body":"make UpdateInterface() declarative\r\n\r\nAnd add interface_id to identify interfaces.\r\n\r\nUpdateInterface() is using bitwise operation which is\r\ntoo lowel and it doesn't support remove&add IPs at the\r\nsame grpc request. So it is changed to declarative way.\r\n\r\nOn declarative way, the agent should roll back when failed.\r\nRolling back can also fail again, the runtime need to know\r\nthe final result of the interface in this case, so the API\r\nalso returns the interface regardless its success or not.\r\n\r\nSigned-off-by: Lai Jiangshan <jiangshanlai@gmail.com>"},"comment":{"url":"https://api.github.com/repos/kata-containers/agent/issues/comments/353031245","html_url":"https://github.com/kata-containers/agent/pull/56#issuecomment-353031245","issue_url":"https://api.github.com/repos/kata-containers/agent/issues/56","id":353031245,"user":{"login":"sameo","id":1043863,"avatar_url":"https://avatars2.githubusercontent.com/u/1043863?v=4","gravatar_id":"","url":"https://api.github.com/users/sameo","html_url":"https://github.com/sameo","followers_url":"https://api.github.com/users/sameo/followers","following_url":"https://api.github.com/users/sameo/following{/other_user}","gists_url":"https://api.github.com/users/sameo/gists{/gist_id}","starred_url":"https://api.github.com/users/sameo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameo/subscriptions","organizations_url":"https://api.github.com/users/sameo/orgs","repos_url":"https://api.github.com/users/sameo/repos","events_url":"https://api.github.com/users/sameo/events{/privacy}","received_events_url":"https://api.github.com/users/sameo/received_events","type":"User","site_admin":false},"created_at":"2017-12-20T10:51:54Z","updated_at":"2017-12-20T10:51:54Z","author_association":"CONTRIBUTOR","body":"@WeiZhang555 @bergwolf \r\n> As I'm also not sure if we will have a scenario that allows two interface having same MAC in single VM\r\n\r\nAFAIK several interfaces with the same MAC can only be supported if they're in different broadcast domains. I can't see how we would ever want to support that in the same VM, in a container/Kubernetes context. I feel we're trying to find a solution for a non existing problem here."}}
{"actor":{"display_login":"sameo"}}