{"action":"created","issue":{"url":"https://api.github.com/repos/dotnet/corert/issues/4112","repository_url":"https://api.github.com/repos/dotnet/corert","labels_url":"https://api.github.com/repos/dotnet/corert/issues/4112/labels{/name}","comments_url":"https://api.github.com/repos/dotnet/corert/issues/4112/comments","events_url":"https://api.github.com/repos/dotnet/corert/issues/4112/events","html_url":"https://github.com/dotnet/corert/pull/4112","id":241519153,"number":4112,"title":"TimeZoneInfo binary serialization test failures on uapaot","user":{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars2.githubusercontent.com/u/7412651?v=3","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"labels":[{"id":453378635,"url":"https://api.github.com/repos/dotnet/corert/labels/*%20NO%20MERGE%20*","name":"* NO MERGE *","color":"e11d21","default":false},{"id":283405909,"url":"https://api.github.com/repos/dotnet/corert/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false},{"id":287649050,"url":"https://api.github.com/repos/dotnet/corert/labels/CoreLib","name":"CoreLib","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars2.githubusercontent.com/u/7412651?v=3","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false},"assignees":[{"login":"ViktorHofer","id":7412651,"avatar_url":"https://avatars2.githubusercontent.com/u/7412651?v=3","gravatar_id":"","url":"https://api.github.com/users/ViktorHofer","html_url":"https://github.com/ViktorHofer","followers_url":"https://api.github.com/users/ViktorHofer/followers","following_url":"https://api.github.com/users/ViktorHofer/following{/other_user}","gists_url":"https://api.github.com/users/ViktorHofer/gists{/gist_id}","starred_url":"https://api.github.com/users/ViktorHofer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ViktorHofer/subscriptions","organizations_url":"https://api.github.com/users/ViktorHofer/orgs","repos_url":"https://api.github.com/users/ViktorHofer/repos","events_url":"https://api.github.com/users/ViktorHofer/events{/privacy}","received_events_url":"https://api.github.com/users/ViktorHofer/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/dotnet/corert/milestones/13","html_url":"https://github.com/dotnet/corert/milestone/13","labels_url":"https://api.github.com/repos/dotnet/corert/milestones/13/labels","id":2555071,"number":13,"title":"UWP6.0","description":"UWP 6.0, implementation of .NET Standard 2.0 for UWP. All changes in this milestone will flow also into 2.1.0 milestone. See [official release dates](https://github.com/dotnet/core/blob/master/roadmap.md) for details. Due date currently tracks ZBB (zero bug bounce) milestone.","creator":{"login":"joshfree","id":1302850,"avatar_url":"https://avatars2.githubusercontent.com/u/1302850?v=3","gravatar_id":"","url":"https://api.github.com/users/joshfree","html_url":"https://github.com/joshfree","followers_url":"https://api.github.com/users/joshfree/followers","following_url":"https://api.github.com/users/joshfree/following{/other_user}","gists_url":"https://api.github.com/users/joshfree/gists{/gist_id}","starred_url":"https://api.github.com/users/joshfree/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshfree/subscriptions","organizations_url":"https://api.github.com/users/joshfree/orgs","repos_url":"https://api.github.com/users/joshfree/repos","events_url":"https://api.github.com/users/joshfree/events{/privacy}","received_events_url":"https://api.github.com/users/joshfree/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":24,"state":"open","created_at":"2017-06-01T00:15:33Z","updated_at":"2017-07-09T15:38:08Z","due_on":"2017-07-14T07:00:00Z","closed_at":null},"comments":8,"created_at":"2017-07-09T11:41:02Z","updated_at":"2017-07-10T16:54:02Z","closed_at":"2017-07-09T15:38:08Z","pull_request":{"url":"https://api.github.com/repos/dotnet/corert/pulls/4112","html_url":"https://github.com/dotnet/corert/pull/4112","diff_url":"https://github.com/dotnet/corert/pull/4112.diff","patch_url":"https://github.com/dotnet/corert/pull/4112.patch"},"body":"Fixing the TypeForwardedFrom attribute to correctly point to System.Core instead of mscorlib (like in coreclr and netfx).\r\n\r\nI noticed that there are more differences, the code looks like it diverged a lot. @tarekgh is that intentional? E.g. the field `_noDaylightTransitionTime` does not exist in corert but in coreclr. As it is used for serialization and netfx expects it, serialization fails for this type. https://github.com/dotnet/coreclr/blob/master/src/mscorlib/src/System/TimeZoneInfo.AdjustmentRule.cs#L21\r\n\r\nThese differences resolve in the following serialization errors on uapaot:\r\n\r\n1. TimeZoneInfo\r\n```\r\n<test name=\"System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.ValidateAgainstBlobs(obj: UTC, blobs: [\\&quot;AAEAAAD/////AQAAAAAAAAAMAgAAAE5TeXN0ZW0uQ29yZSwgVm\\&quot;..., \\&quot;AAEAAAD/////AQAAAAAAAAAMAgAAAE5TeXN0ZW0uQ29yZSwgVm\\&quot;...])\" type=\"System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests\" method=\"ValidateAgainstBlobs\" time=\"0.0017598\" result=\"Fail\">\r\n        <failure exception-type=\"Xunit.Sdk.TrueException\">\r\n          <message><![CDATA[The stored blob for type System.TimeZoneInfo is outdated and needs to be updated.\\r\\nStored blob: AAEAAAD/////AQAAAAAAAAAMAgAAAE5TeXN0ZW0uQ29yZSwgVmVyc2lvbj0zLjUuMC4wLCBDdWx0dXJlPU5ldXRyYWwsIFB1YmxpY0tleVRva2VuPWI3N2E1YzU2MTkzNGUwODkFAQAAABNTeXN0ZW0uVGltZVpvbmVJbmZvBwAAAAJJZAtEaXNwbGF5TmFtZQxTdGFuZGFyZE5hbWUMRGF5bGlnaHROYW1lDUJhc2VVdGNPZmZzZXQPQWRqdXN0bWVudFJ1bGVzGlN1cHBvcnRzRGF5bGlnaHRTYXZpbmdUaW1lAQEBAQACAAwBAgAAAAYDAAAAA1VUQwkDAAAACQMAAAAJAwAAAAAAAAAAAAAACgAL\\r\\nGenerated runtime blob: AAEAAAD/////AQAAAAAAAAAEAQAAABNTeXN0ZW0uVGltZVpvbmVJbmZvBwAAAAJJZAtEaXNwbGF5TmFtZQxTdGFuZGFyZE5hbWUMRGF5bGlnaHROYW1lDUJhc2VVdGNPZmZzZXQPQWRqdXN0bWVudFJ1bGVzGlN1cHBvcnRzRGF5bGlnaHRTYXZpbmdUaW1lAQEBAQACAAwBBgIAAAADVVRDCQIAAAAJAgAAAAkCAAAAAAAAAAAAAAAKAAs=\\r\\nExpected: True\\r\\nActual:   False]]></message>\r\n          <stack-trace><![CDATA[   at System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.SanityCheckBlob(Object obj, String[] blobs)\r\n   at System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.ValidateAgainstBlobs(Object obj, String[] blobs)\r\n   at xunit.console.netcore!<BaseAddress>+0x10d66cf\r\n   at xunit.console.netcore!<BaseAddress>+0x1064945\r\n   at xunit.console.netcore!<BaseAddress>+0x10646d1]]></stack-trace>\r\n        </failure>\r\n      </test>\r\n```\r\n\r\n2. TimeZoneInfo+AdjustmentRule\r\n\r\n```\r\n<test name=\"System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.ValidateAgainstBlobs(obj: AdjustmentRule { DateEnd = 1955-12-31T00:00:00.0000000, DateStart = 1900-01-01T00:00:00.0000000, DaylightDelta = 02:00:00, DaylightTransitionEnd = System.TimeZoneInfo+TransitionTime, DaylightTransitionStart = System.TimeZoneInfo+TransitionTime }, blobs: [\\&quot;AAEAAAD/////AQAAAAAAAAAEAQAAACJTeXN0ZW0uVGltZVpvbm\\&quot;..., \\&quot;AAEAAAD/////AQAAAAAAAAAMAgAAAE5TeXN0ZW0uQ29yZSwgVm\\&quot;...])\" type=\"System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests\" method=\"ValidateAgainstBlobs\" time=\"0.0013659\" result=\"Fail\">\r\n        <failure exception-type=\"Xunit.Sdk.TrueException\">\r\n          <message><![CDATA[The stored blob for type System.TimeZoneInfo+AdjustmentRule is outdated and needs to be updated.\\r\\nStored blob: AAEAAAD/////AQAAAAAAAAAEAQAAACJTeXN0ZW0uVGltZVpvbmVJbmZvK0FkanVzdG1lbnRSdWxlBwAAAAlEYXRlU3RhcnQHRGF0ZUVuZA1EYXlsaWdodERlbHRhF0RheWxpZ2h0VHJhbnNpdGlvblN0YXJ0FURheWxpZ2h0VHJhbnNpdGlvbkVuZBJCYXNlVXRjT2Zmc2V0RGVsdGEVTm9EYXlsaWdodFRyYW5zaXRpb25zAAAAAwMAAA0NDCJTeXN0ZW0uVGltZVpvbmVJbmZvK1RyYW5zaXRpb25UaW1lIlN5c3RlbS5UaW1lWm9uZUluZm8rVHJhbnNpdGlvblRpbWUMAQBAVyBTBVEIAEDGiJPMjwgA0IjDEAAAAAT+////IlN5c3RlbS5UaW1lWm9uZUluZm8rVHJhbnNpdGlvblRpbWUGAAAACVRpbWVPZkRheQVNb250aARXZWVrA0RheQlEYXlPZldlZWsPSXNGaXhlZERhdGVSdWxlAAAAAAMADQICAhBTeXN0ZW0uRGF5T2ZXZWVrAQDQiMMQAAAAAgEDBP3///8QU3lzdGVtLkRheU9mV2VlawEAAAAHdmFsdWVfXwAIAAAAAAEB/P////7///8A0IjDEAAAAAMBBAH7/////f///wAAAAABAAAAAAAAAAAACw==\\r\\nGenerated runtime blob: AAEAAAD/////AQAAAAAAAAAEAQAAACJTeXN0ZW0uVGltZVpvbmVJbmZvK0FkanVzdG1lbnRSdWxlBgAAAAlEYXRlU3RhcnQHRGF0ZUVuZA1EYXlsaWdodERlbHRhF0RheWxpZ2h0VHJhbnNpdGlvblN0YXJ0FURheWxpZ2h0VHJhbnNpdGlvbkVuZBJCYXNlVXRjT2Zmc2V0RGVsdGEAAAADAwANDQwiU3lzdGVtLlRpbWVab25lSW5mbytUcmFuc2l0aW9uVGltZSJTeXN0ZW0uVGltZVpvbmVJbmZvK1RyYW5zaXRpb25UaW1lDABAVyBTBVEIAEDGiJPMjwgA0IjDEAAAAAT+////IlN5c3RlbS5UaW1lWm9uZUluZm8rVHJhbnNpdGlvblRpbWUGAAAACVRpbWVPZkRheQVNb250aARXZWVrA0RheQlEYXlPZldlZWsPSXNGaXhlZERhdGVSdWxlAAAAAAMADQICAhBTeXN0ZW0uRGF5T2ZXZWVrAQDQiMMQAAAAAgEDBP3///8QU3lzdGVtLkRheU9mV2VlawEAAAAHdmFsdWVfXwAIAAAAAAEB/P////7///8A0IjDEAAAAAMBBAH7/////f///wAAAAABAAAAAAAAAAAL\\r\\nExpected: True\\r\\nActual:   False]]></message>\r\n          <stack-trace><![CDATA[   at System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.SanityCheckBlob(Object obj, String[] blobs)\r\n   at System.Runtime.Serialization.Formatters.Tests.BinaryFormatterTests.ValidateAgainstBlobs(Object obj, String[] blobs)\r\n   at xunit.console.netcore!<BaseAddress>+0x10d66cf\r\n   at xunit.console.netcore!<BaseAddress>+0x1064945\r\n   at xunit.console.netcore!<BaseAddress>+0x10646d1]]></stack-trace>\r\n        </failure>\r\n      </test>\r\n```\r\n\r\n_No Merge until question is answered_"},"comment":{"url":"https://api.github.com/repos/dotnet/corert/issues/comments/314167338","html_url":"https://github.com/dotnet/corert/pull/4112#issuecomment-314167338","issue_url":"https://api.github.com/repos/dotnet/corert/issues/4112","id":314167338,"user":{"login":"jkotas","id":6668460,"avatar_url":"https://avatars1.githubusercontent.com/u/6668460?v=3","gravatar_id":"","url":"https://api.github.com/users/jkotas","html_url":"https://github.com/jkotas","followers_url":"https://api.github.com/users/jkotas/followers","following_url":"https://api.github.com/users/jkotas/following{/other_user}","gists_url":"https://api.github.com/users/jkotas/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotas/subscriptions","organizations_url":"https://api.github.com/users/jkotas/orgs","repos_url":"https://api.github.com/users/jkotas/repos","events_url":"https://api.github.com/users/jkotas/events{/privacy}","received_events_url":"https://api.github.com/users/jkotas/received_events","type":"User","site_admin":false},"created_at":"2017-07-10T16:54:02Z","updated_at":"2017-07-10T16:54:02Z","body":"Right. The unified CoreLib code should follow the corefx coding guidelines, e.g. here are the guidelines for file syructure of platform specific code: https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/project-guidelines.md#conventions-for-forked-code"}}
{"actor":{"display_login":"jkotas"}}