{"action":"created","issue":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3448","repository_url":"https://api.github.com/repos/greenplum-db/gpdb","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3448/labels{/name}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3448/comments","events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3448/events","html_url":"https://github.com/greenplum-db/gpdb/pull/3448","id":262698934,"number":3448,"title":"Fix crash with a ROLLUP query.","user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars2.githubusercontent.com/u/191602?v=4","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-04T08:02:51Z","updated_at":"2017-10-11T15:25:41Z","closed_at":"2017-10-11T15:25:25Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/3448","html_url":"https://github.com/greenplum-db/gpdb/pull/3448","diff_url":"https://github.com/greenplum-db/gpdb/pull/3448.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/3448.patch"},"body":"This was broken by commit 7e268107f3, which refactored the code that deals\r\nwith path keys and sorts in plangroupext.c. The new function\r\nmake_sort_from_pathkeys_and_groupingcol(), which replaced the old\r\nmake_sort_from_reordered_groupcols() function, didn't work quite the same\r\nas the old function. I'm not sure what exactly went wrong there, but the\r\ncaller already has the column number and operator information at hand, so\r\nwe can use it to construct the Sort directly, without trying to re-find the\r\noriginal target list entries of the sort columns.\r\n\r\nCommit 7e268107f3 also neglected the comments in\r\nmake_sort_from_pathkeys_and_groupingcol(), but this commit removes the whole\r\nfunction.\r\n\r\nFixes github issue #3447."},"comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments/335848749","html_url":"https://github.com/greenplum-db/gpdb/pull/3448#issuecomment-335848749","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/3448","id":335848749,"user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars2.githubusercontent.com/u/191602?v=4","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"created_at":"2017-10-11T15:25:41Z","updated_at":"2017-10-11T15:25:41Z","author_association":"MEMBER","body":"Pushed, so that we can move on."}}
{"actor":{"display_login":"hlinnaka"}}