{"action":"created","issue":{"url":"https://api.github.com/repos/apache/activemq-artemis/issues/1466","repository_url":"https://api.github.com/repos/apache/activemq-artemis","labels_url":"https://api.github.com/repos/apache/activemq-artemis/issues/1466/labels{/name}","comments_url":"https://api.github.com/repos/apache/activemq-artemis/issues/1466/comments","events_url":"https://api.github.com/repos/apache/activemq-artemis/issues/1466/events","html_url":"https://github.com/apache/activemq-artemis/pull/1466","id":250737839,"number":1466,"title":"ARTEMIS-1353 ensure replication packet order","user":{"login":"jbertram","id":1336948,"avatar_url":"https://avatars2.githubusercontent.com/u/1336948?v=4","gravatar_id":"","url":"https://api.github.com/users/jbertram","html_url":"https://github.com/jbertram","followers_url":"https://api.github.com/users/jbertram/followers","following_url":"https://api.github.com/users/jbertram/following{/other_user}","gists_url":"https://api.github.com/users/jbertram/gists{/gist_id}","starred_url":"https://api.github.com/users/jbertram/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbertram/subscriptions","organizations_url":"https://api.github.com/users/jbertram/orgs","repos_url":"https://api.github.com/users/jbertram/repos","events_url":"https://api.github.com/users/jbertram/events{/privacy}","received_events_url":"https://api.github.com/users/jbertram/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-16T19:43:23Z","updated_at":"2017-08-17T00:38:21Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/activemq-artemis/pulls/1466","html_url":"https://github.com/apache/activemq-artemis/pull/1466","diff_url":"https://github.com/apache/activemq-artemis/pull/1466.diff","patch_url":"https://github.com/apache/activemq-artemis/pull/1466.patch"},"body":"Incorrect ordering of replication packets may happen because of\r\nuseExecutor parameter in the sendReplicatePacket method.\r\nReplicationStartSyncMessage packets are sent as first, but they are sent\r\nwith useExecutor=true. Although ReplicationSyncFileMessage packets are\r\nsent after ReplicationStartSyncMessage packets, they are sent with\r\nuseExecutor=false. So sending of ReplicationStartSyncMessage packets is\r\nscheduled to executor and there is no guarantee when the task will be\r\nexecuted, whereas ReplicationStartSyncMessage packets are sent\r\nimmediately.\r\n\r\nThe solution is to wait for an ack for ReplicationStartSyncMessages."},"comment":{"url":"https://api.github.com/repos/apache/activemq-artemis/issues/comments/322936964","html_url":"https://github.com/apache/activemq-artemis/pull/1466#issuecomment-322936964","issue_url":"https://api.github.com/repos/apache/activemq-artemis/issues/1466","id":322936964,"user":{"login":"clebertsuconic","id":750514,"avatar_url":"https://avatars3.githubusercontent.com/u/750514?v=4","gravatar_id":"","url":"https://api.github.com/users/clebertsuconic","html_url":"https://github.com/clebertsuconic","followers_url":"https://api.github.com/users/clebertsuconic/followers","following_url":"https://api.github.com/users/clebertsuconic/following{/other_user}","gists_url":"https://api.github.com/users/clebertsuconic/gists{/gist_id}","starred_url":"https://api.github.com/users/clebertsuconic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clebertsuconic/subscriptions","organizations_url":"https://api.github.com/users/clebertsuconic/orgs","repos_url":"https://api.github.com/users/clebertsuconic/repos","events_url":"https://api.github.com/users/clebertsuconic/events{/privacy}","received_events_url":"https://api.github.com/users/clebertsuconic/received_events","type":"User","site_admin":false},"created_at":"2017-08-17T00:38:21Z","updated_at":"2017-08-17T00:38:21Z","body":"Please wait me to merge this?  I want to review this carefully tomorrow. "}}
{"actor":{"display_login":"clebertsuconic"}}