{"action":"created","issue":{"url":"https://api.github.com/repos/mono/mono/issues/4719","repository_url":"https://api.github.com/repos/mono/mono","labels_url":"https://api.github.com/repos/mono/mono/issues/4719/labels{/name}","comments_url":"https://api.github.com/repos/mono/mono/issues/4719/comments","events_url":"https://api.github.com/repos/mono/mono/issues/4719/events","html_url":"https://github.com/mono/mono/pull/4719","id":222580338,"number":4719,"title":"[Mono.Options] Write to NULL if we are building for PCL/NetStandard","user":{"login":"mattleibow","id":1096616,"avatar_url":"https://avatars3.githubusercontent.com/u/1096616?v=3","gravatar_id":"","url":"https://api.github.com/users/mattleibow","html_url":"https://github.com/mattleibow","followers_url":"https://api.github.com/users/mattleibow/followers","following_url":"https://api.github.com/users/mattleibow/following{/other_user}","gists_url":"https://api.github.com/users/mattleibow/gists{/gist_id}","starred_url":"https://api.github.com/users/mattleibow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattleibow/subscriptions","organizations_url":"https://api.github.com/users/mattleibow/orgs","repos_url":"https://api.github.com/users/mattleibow/repos","events_url":"https://api.github.com/users/mattleibow/events{/privacy}","received_events_url":"https://api.github.com/users/mattleibow/received_events","type":"User","site_admin":false},"labels":[{"id":350732214,"url":"https://api.github.com/repos/mono/mono/labels/cla-already-signed","name":"cla-already-signed","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-19T00:11:06Z","updated_at":"2017-04-19T01:44:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mono/mono/pulls/4719","html_url":"https://github.com/mono/mono/pull/4719","diff_url":"https://github.com/mono/mono/pull/4719.diff","patch_url":"https://github.com/mono/mono/pull/4719.patch"},"body":"Mono.Options is built for:\r\n - net4\r\n - pcl/portable\r\n - netstandard/netcore\r\n\r\nIn the cross-platform instances, `System.Console` is not always available. This PR makes this \"optional\" by requiring the user to specify a writer. "},"comment":{"url":"https://api.github.com/repos/mono/mono/issues/comments/295037794","html_url":"https://github.com/mono/mono/pull/4719#issuecomment-295037794","issue_url":"https://api.github.com/repos/mono/mono/issues/4719","id":295037794,"user":{"login":"jonpryor","id":155958,"avatar_url":"https://avatars0.githubusercontent.com/u/155958?v=3","gravatar_id":"","url":"https://api.github.com/users/jonpryor","html_url":"https://github.com/jonpryor","followers_url":"https://api.github.com/users/jonpryor/followers","following_url":"https://api.github.com/users/jonpryor/following{/other_user}","gists_url":"https://api.github.com/users/jonpryor/gists{/gist_id}","starred_url":"https://api.github.com/users/jonpryor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonpryor/subscriptions","organizations_url":"https://api.github.com/users/jonpryor/orgs","repos_url":"https://api.github.com/users/jonpryor/repos","events_url":"https://api.github.com/users/jonpryor/events{/privacy}","received_events_url":"https://api.github.com/users/jonpryor/received_events","type":"User","site_admin":false},"created_at":"2017-04-19T01:44:53Z","updated_at":"2017-04-19T01:44:53Z","body":"Uh....no? At least, not without seeing your NuGet package?\r\n\r\nMy concern is that developers may/will see the PCL version and immediately consider it the \"superior\" version, because it can be used everywhere. At which point they'll use `CommandSet` and wonder why nothing happens.\r\n\r\nThat's *really* a poor experience.\r\n\r\nI can see three \"sane\" solutions here:\r\n\r\n1. Provide a `TextWriter` subclass which uses `Debug.WriteLine()`. This is also not entirely desirable, as `Debug.WriteLine()` output is also frequently (usually?) not shown, but at least it's *possibly* shown.\r\n2. Use the \"Bait and Switch\" PCL trick in the NuGet package, so that on \"decent\" platforms/profiles -- those with `System.Console` -- the non-PCL version is used.\r\n3. Require that `output` and `error` be non-`null`, and remove the default to `Console.Out`/`Console.Error`.\r\n\r\nMaking a likely-to-be-widely-used version *useless* \"by default\" is not acceptable."}}
{"actor":{"display_login":"jonpryor"}}