{"action":"closed","number":4,"pull_request":{"url":"https://api.github.com/repos/ArteMisc/libsalty/pulls/4","id":153893025,"html_url":"https://github.com/ArteMisc/libsalty/pull/4","diff_url":"https://github.com/ArteMisc/libsalty/pull/4.diff","patch_url":"https://github.com/ArteMisc/libsalty/pull/4.patch","issue_url":"https://api.github.com/repos/ArteMisc/libsalty/issues/4","number":4,"state":"closed","locked":false,"title":"Box seal fixes","user":{"login":"magnetised","id":17374,"avatar_url":"https://avatars1.githubusercontent.com/u/17374?v=4","gravatar_id":"","url":"https://api.github.com/users/magnetised","html_url":"https://github.com/magnetised","followers_url":"https://api.github.com/users/magnetised/followers","following_url":"https://api.github.com/users/magnetised/following{/other_user}","gists_url":"https://api.github.com/users/magnetised/gists{/gist_id}","starred_url":"https://api.github.com/users/magnetised/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnetised/subscriptions","organizations_url":"https://api.github.com/users/magnetised/orgs","repos_url":"https://api.github.com/users/magnetised/repos","events_url":"https://api.github.com/users/magnetised/events{/privacy}","received_events_url":"https://api.github.com/users/magnetised/received_events","type":"User","site_admin":false},"body":"Thanks for the library. \r\n\r\nI found a few problems when experimenting with Salty that are fixed by this PR:\r\n\r\n1. `Salty.Box.Curve25519xsalsa20poly1305.seal/2` was calling the wrong NIF primitive\r\n2. the NIF function for `box_curve25519xsalsa20poly1305_seal_open` was returning the original ciphertext, not the decrypted plaintext, and\r\n3. Compiling salty was deleting other dependencies.\r\n\r\n3 is a bit weird: don't know if its an elixir/mix bug but having the compile alias call `[\"compile\", &make/1]` in that order was deleting other compiled dependencies in my project, i.e. the directories under `_build/dev/lib` were being deleted. This is on Elixir 1.5.2, OTP 20.\r\n\r\nSwitching the order of the compile commands fixed it (luckily). ","created_at":"2017-11-21T13:41:20Z","updated_at":"2017-11-22T23:25:59Z","closed_at":"2017-11-22T23:25:59Z","merged_at":"2017-11-22T23:25:59Z","merge_commit_sha":"fc8bdc248e260cc8a7093d4ffa7908348a71c87b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArteMisc/libsalty/pulls/4/commits","review_comments_url":"https://api.github.com/repos/ArteMisc/libsalty/pulls/4/comments","review_comment_url":"https://api.github.com/repos/ArteMisc/libsalty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArteMisc/libsalty/issues/4/comments","statuses_url":"https://api.github.com/repos/ArteMisc/libsalty/statuses/e872c9e88e4a932819207cfb73bb8a89bc97b6d0","head":{"label":"anon-ai:box-seal-fixes","ref":"box-seal-fixes","sha":"e872c9e88e4a932819207cfb73bb8a89bc97b6d0","user":{"login":"anon-ai","id":28966349,"avatar_url":"https://avatars3.githubusercontent.com/u/28966349?v=4","gravatar_id":"","url":"https://api.github.com/users/anon-ai","html_url":"https://github.com/anon-ai","followers_url":"https://api.github.com/users/anon-ai/followers","following_url":"https://api.github.com/users/anon-ai/following{/other_user}","gists_url":"https://api.github.com/users/anon-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/anon-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anon-ai/subscriptions","organizations_url":"https://api.github.com/users/anon-ai/orgs","repos_url":"https://api.github.com/users/anon-ai/repos","events_url":"https://api.github.com/users/anon-ai/events{/privacy}","received_events_url":"https://api.github.com/users/anon-ai/received_events","type":"Organization","site_admin":false},"repo":{"id":111544001,"name":"libsalty","full_name":"anon-ai/libsalty","owner":{"login":"anon-ai","id":28966349,"avatar_url":"https://avatars3.githubusercontent.com/u/28966349?v=4","gravatar_id":"","url":"https://api.github.com/users/anon-ai","html_url":"https://github.com/anon-ai","followers_url":"https://api.github.com/users/anon-ai/followers","following_url":"https://api.github.com/users/anon-ai/following{/other_user}","gists_url":"https://api.github.com/users/anon-ai/gists{/gist_id}","starred_url":"https://api.github.com/users/anon-ai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anon-ai/subscriptions","organizations_url":"https://api.github.com/users/anon-ai/orgs","repos_url":"https://api.github.com/users/anon-ai/repos","events_url":"https://api.github.com/users/anon-ai/events{/privacy}","received_events_url":"https://api.github.com/users/anon-ai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/anon-ai/libsalty","description":"Elixir bindings for libsodium (NIF)","fork":true,"url":"https://api.github.com/repos/anon-ai/libsalty","forks_url":"https://api.github.com/repos/anon-ai/libsalty/forks","keys_url":"https://api.github.com/repos/anon-ai/libsalty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anon-ai/libsalty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anon-ai/libsalty/teams","hooks_url":"https://api.github.com/repos/anon-ai/libsalty/hooks","issue_events_url":"https://api.github.com/repos/anon-ai/libsalty/issues/events{/number}","events_url":"https://api.github.com/repos/anon-ai/libsalty/events","assignees_url":"https://api.github.com/repos/anon-ai/libsalty/assignees{/user}","branches_url":"https://api.github.com/repos/anon-ai/libsalty/branches{/branch}","tags_url":"https://api.github.com/repos/anon-ai/libsalty/tags","blobs_url":"https://api.github.com/repos/anon-ai/libsalty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anon-ai/libsalty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anon-ai/libsalty/git/refs{/sha}","trees_url":"https://api.github.com/repos/anon-ai/libsalty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anon-ai/libsalty/statuses/{sha}","languages_url":"https://api.github.com/repos/anon-ai/libsalty/languages","stargazers_url":"https://api.github.com/repos/anon-ai/libsalty/stargazers","contributors_url":"https://api.github.com/repos/anon-ai/libsalty/contributors","subscribers_url":"https://api.github.com/repos/anon-ai/libsalty/subscribers","subscription_url":"https://api.github.com/repos/anon-ai/libsalty/subscription","commits_url":"https://api.github.com/repos/anon-ai/libsalty/commits{/sha}","git_commits_url":"https://api.github.com/repos/anon-ai/libsalty/git/commits{/sha}","comments_url":"https://api.github.com/repos/anon-ai/libsalty/comments{/number}","issue_comment_url":"https://api.github.com/repos/anon-ai/libsalty/issues/comments{/number}","contents_url":"https://api.github.com/repos/anon-ai/libsalty/contents/{+path}","compare_url":"https://api.github.com/repos/anon-ai/libsalty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anon-ai/libsalty/merges","archive_url":"https://api.github.com/repos/anon-ai/libsalty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anon-ai/libsalty/downloads","issues_url":"https://api.github.com/repos/anon-ai/libsalty/issues{/number}","pulls_url":"https://api.github.com/repos/anon-ai/libsalty/pulls{/number}","milestones_url":"https://api.github.com/repos/anon-ai/libsalty/milestones{/number}","notifications_url":"https://api.github.com/repos/anon-ai/libsalty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anon-ai/libsalty/labels{/name}","releases_url":"https://api.github.com/repos/anon-ai/libsalty/releases{/id}","deployments_url":"https://api.github.com/repos/anon-ai/libsalty/deployments","created_at":"2017-11-21T12:06:32Z","updated_at":"2017-11-21T12:06:34Z","pushed_at":"2017-11-21T13:35:07Z","git_url":"git://github.com/anon-ai/libsalty.git","ssh_url":"git@github.com:anon-ai/libsalty.git","clone_url":"https://github.com/anon-ai/libsalty.git","svn_url":"https://github.com/anon-ai/libsalty","homepage":"","size":55,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArteMisc:master","ref":"master","sha":"1e89e9cd6abde3e0a3c27fd5ddf0eb2a216c6c06","user":{"login":"ArteMisc","id":2099574,"avatar_url":"https://avatars1.githubusercontent.com/u/2099574?v=4","gravatar_id":"","url":"https://api.github.com/users/ArteMisc","html_url":"https://github.com/ArteMisc","followers_url":"https://api.github.com/users/ArteMisc/followers","following_url":"https://api.github.com/users/ArteMisc/following{/other_user}","gists_url":"https://api.github.com/users/ArteMisc/gists{/gist_id}","starred_url":"https://api.github.com/users/ArteMisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArteMisc/subscriptions","organizations_url":"https://api.github.com/users/ArteMisc/orgs","repos_url":"https://api.github.com/users/ArteMisc/repos","events_url":"https://api.github.com/users/ArteMisc/events{/privacy}","received_events_url":"https://api.github.com/users/ArteMisc/received_events","type":"User","site_admin":false},"repo":{"id":94912213,"name":"libsalty","full_name":"ArteMisc/libsalty","owner":{"login":"ArteMisc","id":2099574,"avatar_url":"https://avatars1.githubusercontent.com/u/2099574?v=4","gravatar_id":"","url":"https://api.github.com/users/ArteMisc","html_url":"https://github.com/ArteMisc","followers_url":"https://api.github.com/users/ArteMisc/followers","following_url":"https://api.github.com/users/ArteMisc/following{/other_user}","gists_url":"https://api.github.com/users/ArteMisc/gists{/gist_id}","starred_url":"https://api.github.com/users/ArteMisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArteMisc/subscriptions","organizations_url":"https://api.github.com/users/ArteMisc/orgs","repos_url":"https://api.github.com/users/ArteMisc/repos","events_url":"https://api.github.com/users/ArteMisc/events{/privacy}","received_events_url":"https://api.github.com/users/ArteMisc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ArteMisc/libsalty","description":"Elixir bindings for libsodium (NIF)","fork":false,"url":"https://api.github.com/repos/ArteMisc/libsalty","forks_url":"https://api.github.com/repos/ArteMisc/libsalty/forks","keys_url":"https://api.github.com/repos/ArteMisc/libsalty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArteMisc/libsalty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArteMisc/libsalty/teams","hooks_url":"https://api.github.com/repos/ArteMisc/libsalty/hooks","issue_events_url":"https://api.github.com/repos/ArteMisc/libsalty/issues/events{/number}","events_url":"https://api.github.com/repos/ArteMisc/libsalty/events","assignees_url":"https://api.github.com/repos/ArteMisc/libsalty/assignees{/user}","branches_url":"https://api.github.com/repos/ArteMisc/libsalty/branches{/branch}","tags_url":"https://api.github.com/repos/ArteMisc/libsalty/tags","blobs_url":"https://api.github.com/repos/ArteMisc/libsalty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArteMisc/libsalty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArteMisc/libsalty/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArteMisc/libsalty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArteMisc/libsalty/statuses/{sha}","languages_url":"https://api.github.com/repos/ArteMisc/libsalty/languages","stargazers_url":"https://api.github.com/repos/ArteMisc/libsalty/stargazers","contributors_url":"https://api.github.com/repos/ArteMisc/libsalty/contributors","subscribers_url":"https://api.github.com/repos/ArteMisc/libsalty/subscribers","subscription_url":"https://api.github.com/repos/ArteMisc/libsalty/subscription","commits_url":"https://api.github.com/repos/ArteMisc/libsalty/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArteMisc/libsalty/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArteMisc/libsalty/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArteMisc/libsalty/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArteMisc/libsalty/contents/{+path}","compare_url":"https://api.github.com/repos/ArteMisc/libsalty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArteMisc/libsalty/merges","archive_url":"https://api.github.com/repos/ArteMisc/libsalty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArteMisc/libsalty/downloads","issues_url":"https://api.github.com/repos/ArteMisc/libsalty/issues{/number}","pulls_url":"https://api.github.com/repos/ArteMisc/libsalty/pulls{/number}","milestones_url":"https://api.github.com/repos/ArteMisc/libsalty/milestones{/number}","notifications_url":"https://api.github.com/repos/ArteMisc/libsalty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArteMisc/libsalty/labels{/name}","releases_url":"https://api.github.com/repos/ArteMisc/libsalty/releases{/id}","deployments_url":"https://api.github.com/repos/ArteMisc/libsalty/deployments","created_at":"2017-06-20T16:25:47Z","updated_at":"2017-08-09T22:06:59Z","pushed_at":"2017-11-22T23:25:58Z","git_url":"git://github.com/ArteMisc/libsalty.git","ssh_url":"git@github.com:ArteMisc/libsalty.git","clone_url":"https://github.com/ArteMisc/libsalty.git","svn_url":"https://github.com/ArteMisc/libsalty","homepage":"","size":54,"stargazers_count":4,"watchers_count":4,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArteMisc/libsalty/pulls/4"},"html":{"href":"https://github.com/ArteMisc/libsalty/pull/4"},"issue":{"href":"https://api.github.com/repos/ArteMisc/libsalty/issues/4"},"comments":{"href":"https://api.github.com/repos/ArteMisc/libsalty/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/ArteMisc/libsalty/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/ArteMisc/libsalty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArteMisc/libsalty/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/ArteMisc/libsalty/statuses/e872c9e88e4a932819207cfb73bb8a89bc97b6d0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ArteMisc","id":2099574,"avatar_url":"https://avatars1.githubusercontent.com/u/2099574?v=4","gravatar_id":"","url":"https://api.github.com/users/ArteMisc","html_url":"https://github.com/ArteMisc","followers_url":"https://api.github.com/users/ArteMisc/followers","following_url":"https://api.github.com/users/ArteMisc/following{/other_user}","gists_url":"https://api.github.com/users/ArteMisc/gists{/gist_id}","starred_url":"https://api.github.com/users/ArteMisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArteMisc/subscriptions","organizations_url":"https://api.github.com/users/ArteMisc/orgs","repos_url":"https://api.github.com/users/ArteMisc/repos","events_url":"https://api.github.com/users/ArteMisc/events{/privacy}","received_events_url":"https://api.github.com/users/ArteMisc/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":3,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"ArteMisc"}}