{"action":"created","issue":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10301","repository_url":"https://api.github.com/repos/bitcoin/bitcoin","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10301/labels{/name}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10301/comments","events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10301/events","html_url":"https://github.com/bitcoin/bitcoin/pull/10301","id":225305540,"number":10301,"title":"Check if sys/random.h is required for getentropy.","user":{"login":"jameshilliard","id":3298484,"avatar_url":"https://avatars0.githubusercontent.com/u/3298484?v=3","gravatar_id":"","url":"https://api.github.com/users/jameshilliard","html_url":"https://github.com/jameshilliard","followers_url":"https://api.github.com/users/jameshilliard/followers","following_url":"https://api.github.com/users/jameshilliard/following{/other_user}","gists_url":"https://api.github.com/users/jameshilliard/gists{/gist_id}","starred_url":"https://api.github.com/users/jameshilliard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jameshilliard/subscriptions","organizations_url":"https://api.github.com/users/jameshilliard/orgs","repos_url":"https://api.github.com/users/jameshilliard/repos","events_url":"https://api.github.com/users/jameshilliard/events{/privacy}","received_events_url":"https://api.github.com/users/jameshilliard/received_events","type":"User","site_admin":false},"labels":[{"id":234879,"url":"https://api.github.com/repos/bitcoin/bitcoin/labels/MacOSX","name":"MacOSX","color":"660000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-04-30T05:26:54Z","updated_at":"2017-05-01T14:26:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/10301","html_url":"https://github.com/bitcoin/bitcoin/pull/10301","diff_url":"https://github.com/bitcoin/bitcoin/pull/10301.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/10301.patch"},"body":"This should check and include sys/random.h if required for osx as mentioned [here](https://github.com/bitcoin/bitcoin/pull/9821#issuecomment-290936636)."},"comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments/298342471","html_url":"https://github.com/bitcoin/bitcoin/pull/10301#issuecomment-298342471","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/10301","id":298342471,"user":{"login":"laanwj","id":126646,"avatar_url":"https://avatars3.githubusercontent.com/u/126646?v=3","gravatar_id":"","url":"https://api.github.com/users/laanwj","html_url":"https://github.com/laanwj","followers_url":"https://api.github.com/users/laanwj/followers","following_url":"https://api.github.com/users/laanwj/following{/other_user}","gists_url":"https://api.github.com/users/laanwj/gists{/gist_id}","starred_url":"https://api.github.com/users/laanwj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laanwj/subscriptions","organizations_url":"https://api.github.com/users/laanwj/orgs","repos_url":"https://api.github.com/users/laanwj/repos","events_url":"https://api.github.com/users/laanwj/events{/privacy}","received_events_url":"https://api.github.com/users/laanwj/received_events","type":"User","site_admin":false},"created_at":"2017-05-01T14:26:04Z","updated_at":"2017-05-01T14:26:04Z","body":"> I tested this on MacOSX 10.12.4 myself, should we have a runtime /dev/random fallback for getentropy like we do for the linux SYS_getrandom?\r\n\r\nAs I understand it, MacOSX guarantees that anything compiled with the MacOSX 10.12 SDK, which is necessary to get autotools to detect this in the first place doesn't work on earlier versions of the OS. In which case this would be unnecessary.\r\n\r\nFeel free to correct me though @jonasschnelli @theuni."}}
{"actor":{"display_login":"laanwj"}}