{"action":"created","issue":{"url":"https://api.github.com/repos/decred/dcrwallet/issues/738","repository_url":"https://api.github.com/repos/decred/dcrwallet","labels_url":"https://api.github.com/repos/decred/dcrwallet/issues/738/labels{/name}","comments_url":"https://api.github.com/repos/decred/dcrwallet/issues/738/comments","events_url":"https://api.github.com/repos/decred/dcrwallet/issues/738/events","html_url":"https://github.com/decred/dcrwallet/pull/738","id":228451851,"number":738,"title":"Refactor test to avoid data race.","user":{"login":"jrick","id":1420313,"avatar_url":"https://avatars0.githubusercontent.com/u/1420313?v=3","gravatar_id":"","url":"https://api.github.com/users/jrick","html_url":"https://github.com/jrick","followers_url":"https://api.github.com/users/jrick/followers","following_url":"https://api.github.com/users/jrick/following{/other_user}","gists_url":"https://api.github.com/users/jrick/gists{/gist_id}","starred_url":"https://api.github.com/users/jrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrick/subscriptions","organizations_url":"https://api.github.com/users/jrick/orgs","repos_url":"https://api.github.com/users/jrick/repos","events_url":"https://api.github.com/users/jrick/events{/privacy}","received_events_url":"https://api.github.com/users/jrick/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-05-13T05:54:10Z","updated_at":"2017-05-15T13:44:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/decred/dcrwallet/pulls/738","html_url":"https://github.com/decred/dcrwallet/pull/738","diff_url":"https://github.com/decred/dcrwallet/pull/738.diff","patch_url":"https://github.com/decred/dcrwallet/pull/738.patch"},"body":"This refactors the udb TestUpgrades function to avoid a data race\r\n(potentially a Go issue, see golang/go#20339) by replacing the\r\nconcurrent t.Run and sync.WaitGroup usage with a subtest composed of\r\nother parallel subtests.  This allows cleanup to be run outside of the\r\nouter subtest.\r\n\r\nFixes #711."},"comment":{"url":"https://api.github.com/repos/decred/dcrwallet/issues/comments/301478973","html_url":"https://github.com/decred/dcrwallet/pull/738#issuecomment-301478973","issue_url":"https://api.github.com/repos/decred/dcrwallet/issues/738","id":301478973,"user":{"login":"jrick","id":1420313,"avatar_url":"https://avatars0.githubusercontent.com/u/1420313?v=3","gravatar_id":"","url":"https://api.github.com/users/jrick","html_url":"https://github.com/jrick","followers_url":"https://api.github.com/users/jrick/followers","following_url":"https://api.github.com/users/jrick/following{/other_user}","gists_url":"https://api.github.com/users/jrick/gists{/gist_id}","starred_url":"https://api.github.com/users/jrick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jrick/subscriptions","organizations_url":"https://api.github.com/users/jrick/orgs","repos_url":"https://api.github.com/users/jrick/repos","events_url":"https://api.github.com/users/jrick/events{/privacy}","received_events_url":"https://api.github.com/users/jrick/received_events","type":"User","site_admin":false},"created_at":"2017-05-15T13:44:25Z","updated_at":"2017-05-15T13:44:25Z","body":"@cespare thanks, I found that out during my testing.  However this way matches how the documentation explains how to perform parallel testing with teardown (see the TestTeardownParallel example) so I'm inclined to stick with this."}}
{"actor":{"display_login":"jrick"}}