{"action":"created","issue":{"url":"https://api.github.com/repos/NyxStudios/TShock/issues/1423","repository_url":"https://api.github.com/repos/NyxStudios/TShock","labels_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1423/labels{/name}","comments_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1423/comments","events_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1423/events","html_url":"https://github.com/NyxStudios/TShock/pull/1423","id":222919364,"number":1423,"title":"Add Terraria 1.3.5.x Compatibility","user":{"login":"hakusaro","id":532647,"avatar_url":"https://avatars0.githubusercontent.com/u/532647?v=3","gravatar_id":"","url":"https://api.github.com/users/hakusaro","html_url":"https://github.com/hakusaro","followers_url":"https://api.github.com/users/hakusaro/followers","following_url":"https://api.github.com/users/hakusaro/following{/other_user}","gists_url":"https://api.github.com/users/hakusaro/gists{/gist_id}","starred_url":"https://api.github.com/users/hakusaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakusaro/subscriptions","organizations_url":"https://api.github.com/users/hakusaro/orgs","repos_url":"https://api.github.com/users/hakusaro/repos","events_url":"https://api.github.com/users/hakusaro/events{/privacy}","received_events_url":"https://api.github.com/users/hakusaro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"hakusaro","id":532647,"avatar_url":"https://avatars0.githubusercontent.com/u/532647?v=3","gravatar_id":"","url":"https://api.github.com/users/hakusaro","html_url":"https://github.com/hakusaro","followers_url":"https://api.github.com/users/hakusaro/followers","following_url":"https://api.github.com/users/hakusaro/following{/other_user}","gists_url":"https://api.github.com/users/hakusaro/gists{/gist_id}","starred_url":"https://api.github.com/users/hakusaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakusaro/subscriptions","organizations_url":"https://api.github.com/users/hakusaro/orgs","repos_url":"https://api.github.com/users/hakusaro/repos","events_url":"https://api.github.com/users/hakusaro/events{/privacy}","received_events_url":"https://api.github.com/users/hakusaro/received_events","type":"User","site_admin":false},"assignees":[{"login":"hakusaro","id":532647,"avatar_url":"https://avatars0.githubusercontent.com/u/532647?v=3","gravatar_id":"","url":"https://api.github.com/users/hakusaro","html_url":"https://github.com/hakusaro","followers_url":"https://api.github.com/users/hakusaro/followers","following_url":"https://api.github.com/users/hakusaro/following{/other_user}","gists_url":"https://api.github.com/users/hakusaro/gists{/gist_id}","starred_url":"https://api.github.com/users/hakusaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakusaro/subscriptions","organizations_url":"https://api.github.com/users/hakusaro/orgs","repos_url":"https://api.github.com/users/hakusaro/repos","events_url":"https://api.github.com/users/hakusaro/events{/privacy}","received_events_url":"https://api.github.com/users/hakusaro/received_events","type":"User","site_admin":false}],"milestone":null,"comments":40,"created_at":"2017-04-20T01:22:12Z","updated_at":"2017-04-26T00:24:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/NyxStudios/TShock/pulls/1423","html_url":"https://github.com/NyxStudios/TShock/pull/1423","diff_url":"https://github.com/NyxStudios/TShock/pull/1423.diff","patch_url":"https://github.com/NyxStudios/TShock/pull/1423.patch"},"body":"This comprises the changes required to get TShock on 1.3.5.1. A lot of things had to change due to the new item system and the new localization system. This is the accompanying PR to https://github.com/NyxStudios/TerrariaAPI-Server/pull/129.\r\n\r\nCurrent bugs:\r\n\r\n- [x] Server crashes on first player join (on macOS? on my box only?)\r\n- [x] No chat text from clients to server if the server _doesn't crash_ on first join.\r\n- [x] No world data on macOS.\r\n- [x] Can't delete corrupted worlds on macOS.\r\n\r\nThis is being worked on in progress, but there are still a lot of questions about what will probably not work:\r\n\r\n- [x] Do NPC spawning and teleporting commands work?\r\n- [x] Do item spawning commands work?\r\n\r\nCurrent issues that need to be done:\r\n- [x] I'm 95% sure that we aren't forming SmartText properly.\r\n- [ ] If the API fixes `/me` then our fix here needs to be removed again.\r\n- [x] #1426 has been merged.\r\n\r\nOnce those are done, this can be merged if everything is running okay."},"comment":{"url":"https://api.github.com/repos/NyxStudios/TShock/issues/comments/297202713","html_url":"https://github.com/NyxStudios/TShock/pull/1423#issuecomment-297202713","issue_url":"https://api.github.com/repos/NyxStudios/TShock/issues/1423","id":297202713,"user":{"login":"hakusaro","id":532647,"avatar_url":"https://avatars0.githubusercontent.com/u/532647?v=3","gravatar_id":"","url":"https://api.github.com/users/hakusaro","html_url":"https://github.com/hakusaro","followers_url":"https://api.github.com/users/hakusaro/followers","following_url":"https://api.github.com/users/hakusaro/following{/other_user}","gists_url":"https://api.github.com/users/hakusaro/gists{/gist_id}","starred_url":"https://api.github.com/users/hakusaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakusaro/subscriptions","organizations_url":"https://api.github.com/users/hakusaro/orgs","repos_url":"https://api.github.com/users/hakusaro/repos","events_url":"https://api.github.com/users/hakusaro/events{/privacy}","received_events_url":"https://api.github.com/users/hakusaro/received_events","type":"User","site_admin":false},"created_at":"2017-04-26T00:24:29Z","updated_at":"2017-04-26T00:24:29Z","body":"Reported by off: PvP status messages look like this to the player that changes PvP:\r\n\r\n![ejwfwdsrgyaqambekac4b9xhnwgamxorefzkppfsfs1zf8xijjn7wjwrtdn6huw6a-7dlut0ec5cjnnrczimeaktscdhl8lsymeghdcpimgquic-cmyscq47icowa8hqs4kdvnnqe3uz3x8rksok](https://cloud.githubusercontent.com/assets/532647/25413032/65c1b680-29e4-11e7-88b9-004ed1a2efa1.png)\r\n\r\nThey're formatted oddly and may or may not display to other clients. Nto sure."}}
{"actor":{"display_login":"hakusaro"}}