{"action":"opened","number":4613,"pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4613","id":159001564,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4613","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4613.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4613.patch","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4613","number":4613,"state":"open","locked":false,"title":"Moving `will_accept()` check out of `PublisherClient.batch()` factory.","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"body":"This is the first stage of moving that check directly into `Batch.publish()`. This check **must** occur when the message is being published because concurrent access to the messages and futures on a `Batch` make it impossible to reliably do an LBYL \"will accept?\" check.\r\n\r\nTowards #4575.","created_at":"2017-12-18T19:48:35Z","updated_at":"2017-12-18T19:48:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"lukesneeringer","id":4346,"avatar_url":"https://avatars0.githubusercontent.com/u/4346?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesneeringer","html_url":"https://github.com/lukesneeringer","followers_url":"https://api.github.com/users/lukesneeringer/followers","following_url":"https://api.github.com/users/lukesneeringer/following{/other_user}","gists_url":"https://api.github.com/users/lukesneeringer/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesneeringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesneeringer/subscriptions","organizations_url":"https://api.github.com/users/lukesneeringer/orgs","repos_url":"https://api.github.com/users/lukesneeringer/repos","events_url":"https://api.github.com/users/lukesneeringer/events{/privacy}","received_events_url":"https://api.github.com/users/lukesneeringer/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukesneeringer","id":4346,"avatar_url":"https://avatars0.githubusercontent.com/u/4346?v=4","gravatar_id":"","url":"https://api.github.com/users/lukesneeringer","html_url":"https://github.com/lukesneeringer","followers_url":"https://api.github.com/users/lukesneeringer/followers","following_url":"https://api.github.com/users/lukesneeringer/following{/other_user}","gists_url":"https://api.github.com/users/lukesneeringer/gists{/gist_id}","starred_url":"https://api.github.com/users/lukesneeringer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukesneeringer/subscriptions","organizations_url":"https://api.github.com/users/lukesneeringer/orgs","repos_url":"https://api.github.com/users/lukesneeringer/repos","events_url":"https://api.github.com/users/lukesneeringer/events{/privacy}","received_events_url":"https://api.github.com/users/lukesneeringer/received_events","type":"User","site_admin":false},{"login":"tseaver","id":242750,"avatar_url":"https://avatars2.githubusercontent.com/u/242750?v=4","gravatar_id":"","url":"https://api.github.com/users/tseaver","html_url":"https://github.com/tseaver","followers_url":"https://api.github.com/users/tseaver/followers","following_url":"https://api.github.com/users/tseaver/following{/other_user}","gists_url":"https://api.github.com/users/tseaver/gists{/gist_id}","starred_url":"https://api.github.com/users/tseaver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tseaver/subscriptions","organizations_url":"https://api.github.com/users/tseaver/orgs","repos_url":"https://api.github.com/users/tseaver/repos","events_url":"https://api.github.com/users/tseaver/events{/privacy}","received_events_url":"https://api.github.com/users/tseaver/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4613/commits","review_comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4613/comments","review_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4613/comments","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/39565c0985b74b4a2300aa7b60df146be219508d","head":{"label":"dhermes:pubsub-publisher-batch-refactor","ref":"pubsub-publisher-batch-refactor","sha":"39565c0985b74b4a2300aa7b60df146be219508d","user":{"login":"dhermes","id":520669,"avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"repo":{"id":23001795,"name":"google-cloud-python","full_name":"dhermes/google-cloud-python","owner":{"login":"dhermes","id":520669,"avatar_url":"https://avatars3.githubusercontent.com/u/520669?v=4","gravatar_id":"","url":"https://api.github.com/users/dhermes","html_url":"https://github.com/dhermes","followers_url":"https://api.github.com/users/dhermes/followers","following_url":"https://api.github.com/users/dhermes/following{/other_user}","gists_url":"https://api.github.com/users/dhermes/gists{/gist_id}","starred_url":"https://api.github.com/users/dhermes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhermes/subscriptions","organizations_url":"https://api.github.com/users/dhermes/orgs","repos_url":"https://api.github.com/users/dhermes/repos","events_url":"https://api.github.com/users/dhermes/events{/privacy}","received_events_url":"https://api.github.com/users/dhermes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhermes/google-cloud-python","description":"Google Cloud Python Client Library","fork":true,"url":"https://api.github.com/repos/dhermes/google-cloud-python","forks_url":"https://api.github.com/repos/dhermes/google-cloud-python/forks","keys_url":"https://api.github.com/repos/dhermes/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhermes/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhermes/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/dhermes/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/dhermes/google-cloud-python/events","assignees_url":"https://api.github.com/repos/dhermes/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/dhermes/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/dhermes/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhermes/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/dhermes/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/dhermes/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/dhermes/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/dhermes/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/dhermes/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/dhermes/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhermes/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhermes/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhermes/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/dhermes/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhermes/google-cloud-python/merges","archive_url":"https://api.github.com/repos/dhermes/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhermes/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/dhermes/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/dhermes/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/dhermes/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/dhermes/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhermes/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/dhermes/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/dhermes/google-cloud-python/deployments","created_at":"2014-08-15T20:18:30Z","updated_at":"2017-03-31T21:17:25Z","pushed_at":"2017-12-18T19:47:59Z","git_url":"git://github.com/dhermes/google-cloud-python.git","ssh_url":"git@github.com:dhermes/google-cloud-python.git","clone_url":"https://github.com/dhermes/google-cloud-python.git","svn_url":"https://github.com/dhermes/google-cloud-python","homepage":"http://googlecloudplatform.github.io/gcloud-python/","size":25253,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"GoogleCloudPlatform:master","ref":"master","sha":"25d93e6de578c4897516f52449cd61c30fc972ab","user":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"repo":{"id":16316451,"name":"google-cloud-python","full_name":"GoogleCloudPlatform/google-cloud-python","owner":{"login":"GoogleCloudPlatform","id":2810941,"avatar_url":"https://avatars0.githubusercontent.com/u/2810941?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleCloudPlatform","html_url":"https://github.com/GoogleCloudPlatform","followers_url":"https://api.github.com/users/GoogleCloudPlatform/followers","following_url":"https://api.github.com/users/GoogleCloudPlatform/following{/other_user}","gists_url":"https://api.github.com/users/GoogleCloudPlatform/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleCloudPlatform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleCloudPlatform/subscriptions","organizations_url":"https://api.github.com/users/GoogleCloudPlatform/orgs","repos_url":"https://api.github.com/users/GoogleCloudPlatform/repos","events_url":"https://api.github.com/users/GoogleCloudPlatform/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleCloudPlatform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","description":"Google Cloud Client Library for Python","fork":false,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python","forks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/forks","keys_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/teams","hooks_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/hooks","issue_events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/events","assignees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/tags","blobs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/languages","stargazers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/stargazers","contributors_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contributors","subscribers_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscribers","subscription_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/subscription","commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/merges","archive_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/downloads","issues_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/labels{/name}","releases_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/deployments","created_at":"2014-01-28T15:51:47Z","updated_at":"2017-12-18T17:28:03Z","pushed_at":"2017-12-18T19:31:57Z","git_url":"git://github.com/GoogleCloudPlatform/google-cloud-python.git","ssh_url":"git@github.com:GoogleCloudPlatform/google-cloud-python.git","clone_url":"https://github.com/GoogleCloudPlatform/google-cloud-python.git","svn_url":"https://github.com/GoogleCloudPlatform/google-cloud-python","homepage":"https://googlecloudplatform.github.io/google-cloud-python/","size":144888,"stargazers_count":1117,"watchers_count":1117,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":510,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":510,"open_issues":134,"watchers":1117,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4613"},"html":{"href":"https://github.com/GoogleCloudPlatform/google-cloud-python/pull/4613"},"issue":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4613"},"comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/issues/4613/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4613/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/pulls/4613/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-python/statuses/39565c0985b74b4a2300aa7b60df146be219508d"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":121,"deletions":62,"changed_files":2}}
{"actor":{"display_login":"dhermes"}}