{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/97117447","pull_request_review_id":17724713,"id":97117447,"diff_hunk":"@@ -3684,8 +3684,8 @@ void Hmac::HmacInit(const FunctionCallbackInfo<Value>& args) {\n bool Hmac::HmacUpdate(const char* data, int len) {\n   if (!initialised_)\n     return false;\n-  HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len);\n-  return true;\n+  int r = HMAC_Update(&ctx_, reinterpret_cast<const unsigned char*>(data), len);\n+  return r == 1;","path":"src/node_crypto.cc","position":7,"original_position":7,"commit_id":"2dc99208b06c319d2fca8be0fa5148f2bb665cd9","original_commit_id":"2dc99208b06c319d2fca8be0fa5148f2bb665cd9","user":{"login":"sam-github","id":17607,"avatar_url":"https://avatars.githubusercontent.com/u/17607?v=3","gravatar_id":"","url":"https://api.github.com/users/sam-github","html_url":"https://github.com/sam-github","followers_url":"https://api.github.com/users/sam-github/followers","following_url":"https://api.github.com/users/sam-github/following{/other_user}","gists_url":"https://api.github.com/users/sam-github/gists{/gist_id}","starred_url":"https://api.github.com/users/sam-github/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam-github/subscriptions","organizations_url":"https://api.github.com/users/sam-github/orgs","repos_url":"https://api.github.com/users/sam-github/repos","events_url":"https://api.github.com/users/sam-github/events{/privacy}","received_events_url":"https://api.github.com/users/sam-github/received_events","type":"User","site_admin":false},"body":"And https://github.com/openssl/openssl/commit/2dc769a1c17e1e0c7ae\r\n\r\nI think this routine can return error codes, not just `1`, so the check should be against `!= 0`.","created_at":"2017-01-20T17:31:11Z","updated_at":"2017-01-20T17:31:18Z","html_url":"https://github.com/nodejs/node/pull/10891#discussion_r97117447","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/10891","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/97117447"},"html":{"href":"https://github.com/nodejs/node/pull/10891#discussion_r97117447"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/10891"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10891","id":102200462,"html_url":"https://github.com/nodejs/node/pull/10891","diff_url":"https://github.com/nodejs/node/pull/10891.diff","patch_url":"https://github.com/nodejs/node/pull/10891.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/10891","number":10891,"state":"open","locked":false,"title":"crypto: return result of openssl HMAC_Update instead of just true.","user":{"login":"tmeisenh","id":108959,"avatar_url":"https://avatars.githubusercontent.com/u/108959?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeisenh","html_url":"https://github.com/tmeisenh","followers_url":"https://api.github.com/users/tmeisenh/followers","following_url":"https://api.github.com/users/tmeisenh/following{/other_user}","gists_url":"https://api.github.com/users/tmeisenh/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeisenh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeisenh/subscriptions","organizations_url":"https://api.github.com/users/tmeisenh/orgs","repos_url":"https://api.github.com/users/tmeisenh/repos","events_url":"https://api.github.com/users/tmeisenh/events{/privacy}","received_events_url":"https://api.github.com/users/tmeisenh/received_events","type":"User","site_admin":false},"body":"Addresses coverity scan issue [55489](https://scan9.coverity.com/reports.htm#v30475/p10075/fileInstanceId=12280692&defectInstanceId=2400164&mergedDefectId=55489)\r\n\r\nThe existing tests pass but I did not add any new tests.  I did not see any existing tests around error handling of openssl functions nor any test harness to allow you to do so.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] tests and/or benchmarks are included\r\n- [X] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ncrypto","created_at":"2017-01-19T04:40:11Z","updated_at":"2017-01-20T17:31:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"64f63ab5da061e7d161dd64d54aa8c260f0545fe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/10891/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/10891/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10891/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/2dc99208b06c319d2fca8be0fa5148f2bb665cd9","head":{"label":"tmeisenh:crypto_fixes","ref":"crypto_fixes","sha":"2dc99208b06c319d2fca8be0fa5148f2bb665cd9","user":{"login":"tmeisenh","id":108959,"avatar_url":"https://avatars.githubusercontent.com/u/108959?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeisenh","html_url":"https://github.com/tmeisenh","followers_url":"https://api.github.com/users/tmeisenh/followers","following_url":"https://api.github.com/users/tmeisenh/following{/other_user}","gists_url":"https://api.github.com/users/tmeisenh/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeisenh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeisenh/subscriptions","organizations_url":"https://api.github.com/users/tmeisenh/orgs","repos_url":"https://api.github.com/users/tmeisenh/repos","events_url":"https://api.github.com/users/tmeisenh/events{/privacy}","received_events_url":"https://api.github.com/users/tmeisenh/received_events","type":"User","site_admin":false},"repo":{"id":79399545,"name":"node","full_name":"tmeisenh/node","owner":{"login":"tmeisenh","id":108959,"avatar_url":"https://avatars.githubusercontent.com/u/108959?v=3","gravatar_id":"","url":"https://api.github.com/users/tmeisenh","html_url":"https://github.com/tmeisenh","followers_url":"https://api.github.com/users/tmeisenh/followers","following_url":"https://api.github.com/users/tmeisenh/following{/other_user}","gists_url":"https://api.github.com/users/tmeisenh/gists{/gist_id}","starred_url":"https://api.github.com/users/tmeisenh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmeisenh/subscriptions","organizations_url":"https://api.github.com/users/tmeisenh/orgs","repos_url":"https://api.github.com/users/tmeisenh/repos","events_url":"https://api.github.com/users/tmeisenh/events{/privacy}","received_events_url":"https://api.github.com/users/tmeisenh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tmeisenh/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/tmeisenh/node","forks_url":"https://api.github.com/repos/tmeisenh/node/forks","keys_url":"https://api.github.com/repos/tmeisenh/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tmeisenh/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tmeisenh/node/teams","hooks_url":"https://api.github.com/repos/tmeisenh/node/hooks","issue_events_url":"https://api.github.com/repos/tmeisenh/node/issues/events{/number}","events_url":"https://api.github.com/repos/tmeisenh/node/events","assignees_url":"https://api.github.com/repos/tmeisenh/node/assignees{/user}","branches_url":"https://api.github.com/repos/tmeisenh/node/branches{/branch}","tags_url":"https://api.github.com/repos/tmeisenh/node/tags","blobs_url":"https://api.github.com/repos/tmeisenh/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tmeisenh/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tmeisenh/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/tmeisenh/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tmeisenh/node/statuses/{sha}","languages_url":"https://api.github.com/repos/tmeisenh/node/languages","stargazers_url":"https://api.github.com/repos/tmeisenh/node/stargazers","contributors_url":"https://api.github.com/repos/tmeisenh/node/contributors","subscribers_url":"https://api.github.com/repos/tmeisenh/node/subscribers","subscription_url":"https://api.github.com/repos/tmeisenh/node/subscription","commits_url":"https://api.github.com/repos/tmeisenh/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/tmeisenh/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/tmeisenh/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/tmeisenh/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/tmeisenh/node/contents/{+path}","compare_url":"https://api.github.com/repos/tmeisenh/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tmeisenh/node/merges","archive_url":"https://api.github.com/repos/tmeisenh/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tmeisenh/node/downloads","issues_url":"https://api.github.com/repos/tmeisenh/node/issues{/number}","pulls_url":"https://api.github.com/repos/tmeisenh/node/pulls{/number}","milestones_url":"https://api.github.com/repos/tmeisenh/node/milestones{/number}","notifications_url":"https://api.github.com/repos/tmeisenh/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tmeisenh/node/labels{/name}","releases_url":"https://api.github.com/repos/tmeisenh/node/releases{/id}","deployments_url":"https://api.github.com/repos/tmeisenh/node/deployments","created_at":"2017-01-19T00:40:08Z","updated_at":"2017-01-19T00:40:36Z","pushed_at":"2017-01-20T12:49:04Z","git_url":"git://github.com/tmeisenh/node.git","ssh_url":"git@github.com:tmeisenh/node.git","clone_url":"https://github.com/tmeisenh/node.git","svn_url":"https://github.com/tmeisenh/node","homepage":"https://nodejs.org","size":255470,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"974ecb05988da472d9f8cb58bf5e9d725539daeb","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-01-20T16:49:49Z","pushed_at":"2017-01-20T17:18:59Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":255525,"stargazers_count":30835,"watchers_count":30835,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5652,"mirror_url":null,"open_issues_count":1021,"forks":5652,"open_issues":1021,"watchers":30835,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/10891"},"html":{"href":"https://github.com/nodejs/node/pull/10891"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/10891"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/10891/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/10891/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/10891/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/2dc99208b06c319d2fca8be0fa5148f2bb665cd9"}}}}
{"actor":{"display_login":"sam-github"}}