{"action":"created","comment":{"url":"https://api.github.com/repos/jwilm/alacritty/pulls/comments/98117344","pull_request_review_id":18750469,"id":98117344,"diff_hunk":"@@ -87,15 +127,32 @@ impl<'a> Drop for RenderableCellsIter<'a> {\n     /// Resets temporary render state on the grid\n     fn drop(&mut self) {\n         if self.cursor_is_visible() {\n-            self.grid[self.cursor].swap_fg_and_bg();\n+            let cursor_cell = match self.cursor_cell {\n+                CursorCell::Extra(ref mut cell) => cell,\n+                CursorCell::Replacement(ref mut cell) => cell,\n+            };\n+            match self.cursor_type.0 {\n+                ansi::CursorType::BlinkBlock => {\n+                    cursor_cell.inner.swap_fg_and_bg();\n+                }\n+                ansi::CursorType::SteadyBlock => {\n+                    cursor_cell.inner.swap_fg_and_bg();\n+                }\n+                ansi::CursorType::BlinkUnderline => {}\n+                ansi::CursorType::SteadyUnderline => {}\n+                ansi::CursorType::BlinkBeam => {}\n+                ansi::CursorType::SteadyBeam => {\n+                    cursor_cell.inner = self.grid[self.cursor];\n+                }\n+            }\n         }\n     }\n }\n \n pub struct IndexedCell {\n     pub line: Line,\n     pub column: Column,\n-    pub inner: Cell\n+    pub inner: Cell,","path":"src/term/mod.rs","position":135,"original_position":135,"commit_id":"7d976cf611b2ed96df4fd72db4379a1829343dc8","original_commit_id":"7d976cf611b2ed96df4fd72db4379a1829343dc8","user":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"body":"There's a bunch of stylistic changes in here that make it difficult to review the parts that are actually relevant to your feature.","created_at":"2017-01-26T23:32:29Z","updated_at":"2017-01-26T23:35:08Z","html_url":"https://github.com/jwilm/alacritty/pull/349#discussion_r98117344","pull_request_url":"https://api.github.com/repos/jwilm/alacritty/pulls/349","_links":{"self":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/comments/98117344"},"html":{"href":"https://github.com/jwilm/alacritty/pull/349#discussion_r98117344"},"pull_request":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/349"}}},"pull_request":{"url":"https://api.github.com/repos/jwilm/alacritty/pulls/349","id":102770620,"html_url":"https://github.com/jwilm/alacritty/pull/349","diff_url":"https://github.com/jwilm/alacritty/pull/349.diff","patch_url":"https://github.com/jwilm/alacritty/pull/349.patch","issue_url":"https://api.github.com/repos/jwilm/alacritty/issues/349","number":349,"state":"open","locked":false,"title":"Cursor type & blinking DECSCUSR","user":{"login":"impowski","id":6883168,"avatar_url":"https://avatars.githubusercontent.com/u/6883168?v=3","gravatar_id":"","url":"https://api.github.com/users/impowski","html_url":"https://github.com/impowski","followers_url":"https://api.github.com/users/impowski/followers","following_url":"https://api.github.com/users/impowski/following{/other_user}","gists_url":"https://api.github.com/users/impowski/gists{/gist_id}","starred_url":"https://api.github.com/users/impowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impowski/subscriptions","organizations_url":"https://api.github.com/users/impowski/orgs","repos_url":"https://api.github.com/users/impowski/repos","events_url":"https://api.github.com/users/impowski/events{/privacy}","received_events_url":"https://api.github.com/users/impowski/received_events","type":"User","site_admin":false},"body":"This PR basically will solve #171 in future because right now it's still kinda bad looking patch and I hope I'll implement everything in a right way in couple days.\r\n\r\nWhat works right now:\r\n\r\n- [x] Specifying from config file\r\n- [x] Steady block\r\n- [x] Steady beam (only in basic way)\r\n- [x] Steady underline\r\n- [ ] Fix rendering\r\n\r\nThe way it works right now is pretty hacky and I hope we will manage it with @jwilm because I don't really like how it works right now and I still have a couple of bugs so...yeah.","created_at":"2017-01-23T18:08:30Z","updated_at":"2017-01-26T23:35:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b7e3b6134f3b02191a6186feef053ee9c5acb1de","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/jwilm/alacritty/pulls/349/commits","review_comments_url":"https://api.github.com/repos/jwilm/alacritty/pulls/349/comments","review_comment_url":"https://api.github.com/repos/jwilm/alacritty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwilm/alacritty/issues/349/comments","statuses_url":"https://api.github.com/repos/jwilm/alacritty/statuses/7d976cf611b2ed96df4fd72db4379a1829343dc8","head":{"label":"impowski:cursor_shape","ref":"cursor_shape","sha":"7d976cf611b2ed96df4fd72db4379a1829343dc8","user":{"login":"impowski","id":6883168,"avatar_url":"https://avatars.githubusercontent.com/u/6883168?v=3","gravatar_id":"","url":"https://api.github.com/users/impowski","html_url":"https://github.com/impowski","followers_url":"https://api.github.com/users/impowski/followers","following_url":"https://api.github.com/users/impowski/following{/other_user}","gists_url":"https://api.github.com/users/impowski/gists{/gist_id}","starred_url":"https://api.github.com/users/impowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impowski/subscriptions","organizations_url":"https://api.github.com/users/impowski/orgs","repos_url":"https://api.github.com/users/impowski/repos","events_url":"https://api.github.com/users/impowski/events{/privacy}","received_events_url":"https://api.github.com/users/impowski/received_events","type":"User","site_admin":false},"repo":{"id":79558387,"name":"alacritty","full_name":"impowski/alacritty","owner":{"login":"impowski","id":6883168,"avatar_url":"https://avatars.githubusercontent.com/u/6883168?v=3","gravatar_id":"","url":"https://api.github.com/users/impowski","html_url":"https://github.com/impowski","followers_url":"https://api.github.com/users/impowski/followers","following_url":"https://api.github.com/users/impowski/following{/other_user}","gists_url":"https://api.github.com/users/impowski/gists{/gist_id}","starred_url":"https://api.github.com/users/impowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/impowski/subscriptions","organizations_url":"https://api.github.com/users/impowski/orgs","repos_url":"https://api.github.com/users/impowski/repos","events_url":"https://api.github.com/users/impowski/events{/privacy}","received_events_url":"https://api.github.com/users/impowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/impowski/alacritty","description":"A cross-platform, GPU-accelerated terminal emulator","fork":true,"url":"https://api.github.com/repos/impowski/alacritty","forks_url":"https://api.github.com/repos/impowski/alacritty/forks","keys_url":"https://api.github.com/repos/impowski/alacritty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/impowski/alacritty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/impowski/alacritty/teams","hooks_url":"https://api.github.com/repos/impowski/alacritty/hooks","issue_events_url":"https://api.github.com/repos/impowski/alacritty/issues/events{/number}","events_url":"https://api.github.com/repos/impowski/alacritty/events","assignees_url":"https://api.github.com/repos/impowski/alacritty/assignees{/user}","branches_url":"https://api.github.com/repos/impowski/alacritty/branches{/branch}","tags_url":"https://api.github.com/repos/impowski/alacritty/tags","blobs_url":"https://api.github.com/repos/impowski/alacritty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/impowski/alacritty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/impowski/alacritty/git/refs{/sha}","trees_url":"https://api.github.com/repos/impowski/alacritty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/impowski/alacritty/statuses/{sha}","languages_url":"https://api.github.com/repos/impowski/alacritty/languages","stargazers_url":"https://api.github.com/repos/impowski/alacritty/stargazers","contributors_url":"https://api.github.com/repos/impowski/alacritty/contributors","subscribers_url":"https://api.github.com/repos/impowski/alacritty/subscribers","subscription_url":"https://api.github.com/repos/impowski/alacritty/subscription","commits_url":"https://api.github.com/repos/impowski/alacritty/commits{/sha}","git_commits_url":"https://api.github.com/repos/impowski/alacritty/git/commits{/sha}","comments_url":"https://api.github.com/repos/impowski/alacritty/comments{/number}","issue_comment_url":"https://api.github.com/repos/impowski/alacritty/issues/comments{/number}","contents_url":"https://api.github.com/repos/impowski/alacritty/contents/{+path}","compare_url":"https://api.github.com/repos/impowski/alacritty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/impowski/alacritty/merges","archive_url":"https://api.github.com/repos/impowski/alacritty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/impowski/alacritty/downloads","issues_url":"https://api.github.com/repos/impowski/alacritty/issues{/number}","pulls_url":"https://api.github.com/repos/impowski/alacritty/pulls{/number}","milestones_url":"https://api.github.com/repos/impowski/alacritty/milestones{/number}","notifications_url":"https://api.github.com/repos/impowski/alacritty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/impowski/alacritty/labels{/name}","releases_url":"https://api.github.com/repos/impowski/alacritty/releases{/id}","deployments_url":"https://api.github.com/repos/impowski/alacritty/deployments","created_at":"2017-01-20T12:47:00Z","updated_at":"2017-01-20T12:47:04Z","pushed_at":"2017-01-26T16:54:34Z","git_url":"git://github.com/impowski/alacritty.git","ssh_url":"git@github.com:impowski/alacritty.git","clone_url":"https://github.com/impowski/alacritty.git","svn_url":"https://github.com/impowski/alacritty","homepage":"","size":773,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jwilm:master","ref":"master","sha":"08f348ecea0b782cd8539850abe6309d0e5b06c9","user":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"repo":{"id":51980455,"name":"alacritty","full_name":"jwilm/alacritty","owner":{"login":"jwilm","id":4285147,"avatar_url":"https://avatars.githubusercontent.com/u/4285147?v=3","gravatar_id":"","url":"https://api.github.com/users/jwilm","html_url":"https://github.com/jwilm","followers_url":"https://api.github.com/users/jwilm/followers","following_url":"https://api.github.com/users/jwilm/following{/other_user}","gists_url":"https://api.github.com/users/jwilm/gists{/gist_id}","starred_url":"https://api.github.com/users/jwilm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwilm/subscriptions","organizations_url":"https://api.github.com/users/jwilm/orgs","repos_url":"https://api.github.com/users/jwilm/repos","events_url":"https://api.github.com/users/jwilm/events{/privacy}","received_events_url":"https://api.github.com/users/jwilm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwilm/alacritty","description":"A cross-platform, GPU-accelerated terminal emulator","fork":false,"url":"https://api.github.com/repos/jwilm/alacritty","forks_url":"https://api.github.com/repos/jwilm/alacritty/forks","keys_url":"https://api.github.com/repos/jwilm/alacritty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwilm/alacritty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwilm/alacritty/teams","hooks_url":"https://api.github.com/repos/jwilm/alacritty/hooks","issue_events_url":"https://api.github.com/repos/jwilm/alacritty/issues/events{/number}","events_url":"https://api.github.com/repos/jwilm/alacritty/events","assignees_url":"https://api.github.com/repos/jwilm/alacritty/assignees{/user}","branches_url":"https://api.github.com/repos/jwilm/alacritty/branches{/branch}","tags_url":"https://api.github.com/repos/jwilm/alacritty/tags","blobs_url":"https://api.github.com/repos/jwilm/alacritty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwilm/alacritty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwilm/alacritty/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwilm/alacritty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwilm/alacritty/statuses/{sha}","languages_url":"https://api.github.com/repos/jwilm/alacritty/languages","stargazers_url":"https://api.github.com/repos/jwilm/alacritty/stargazers","contributors_url":"https://api.github.com/repos/jwilm/alacritty/contributors","subscribers_url":"https://api.github.com/repos/jwilm/alacritty/subscribers","subscription_url":"https://api.github.com/repos/jwilm/alacritty/subscription","commits_url":"https://api.github.com/repos/jwilm/alacritty/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwilm/alacritty/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwilm/alacritty/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwilm/alacritty/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwilm/alacritty/contents/{+path}","compare_url":"https://api.github.com/repos/jwilm/alacritty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwilm/alacritty/merges","archive_url":"https://api.github.com/repos/jwilm/alacritty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwilm/alacritty/downloads","issues_url":"https://api.github.com/repos/jwilm/alacritty/issues{/number}","pulls_url":"https://api.github.com/repos/jwilm/alacritty/pulls{/number}","milestones_url":"https://api.github.com/repos/jwilm/alacritty/milestones{/number}","notifications_url":"https://api.github.com/repos/jwilm/alacritty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwilm/alacritty/labels{/name}","releases_url":"https://api.github.com/repos/jwilm/alacritty/releases{/id}","deployments_url":"https://api.github.com/repos/jwilm/alacritty/deployments","created_at":"2016-02-18T05:02:30Z","updated_at":"2017-01-26T20:42:00Z","pushed_at":"2017-01-26T18:34:38Z","git_url":"git://github.com/jwilm/alacritty.git","ssh_url":"git@github.com:jwilm/alacritty.git","clone_url":"https://github.com/jwilm/alacritty.git","svn_url":"https://github.com/jwilm/alacritty","homepage":"","size":762,"stargazers_count":4603,"watchers_count":4603,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":124,"mirror_url":null,"open_issues_count":171,"forks":124,"open_issues":171,"watchers":4603,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/349"},"html":{"href":"https://github.com/jwilm/alacritty/pull/349"},"issue":{"href":"https://api.github.com/repos/jwilm/alacritty/issues/349"},"comments":{"href":"https://api.github.com/repos/jwilm/alacritty/issues/349/comments"},"review_comments":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/349/comments"},"review_comment":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwilm/alacritty/pulls/349/commits"},"statuses":{"href":"https://api.github.com/repos/jwilm/alacritty/statuses/7d976cf611b2ed96df4fd72db4379a1829343dc8"}}}}
{"actor":{"display_login":"jwilm"}}