{"action":"created","comment":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/comments/147573522","pull_request_review_id":72690216,"id":147573522,"diff_hunk":"@@ -0,0 +1,41 @@\n+package org.jabref.preferences;\n+\n+import org.junit.Test;\n+\n+import java.util.List;\n+\n+public class PreviewPreferenceTest {\n+\n+    private List<String> previewCycle = null;\n+    private int previewCyclePosition = 0;\n+    private int previewPanelHeight = 0;\n+    private boolean previewPanelEnabled = false;\n+    private String previewStyle = \"\";\n+    private String previewStyleDefault = \"\";\n+\n+    @Test\n+    public void givenNothingWhenCreatingPreviewPreferenceThenNothingThrown() {","path":"src/test/java/org/jabref/preferences/PreviewPreferenceTest.java","position":19,"original_position":17,"commit_id":"86f79488d13dfa83fb41ec24190d05596092ead6","original_commit_id":"570f5362a7ad0414648023ed32cf6535e65150d0","user":{"login":"sammann-fnordbedarf-de","id":8333551,"avatar_url":"https://avatars3.githubusercontent.com/u/8333551?v=4","gravatar_id":"","url":"https://api.github.com/users/sammann-fnordbedarf-de","html_url":"https://github.com/sammann-fnordbedarf-de","followers_url":"https://api.github.com/users/sammann-fnordbedarf-de/followers","following_url":"https://api.github.com/users/sammann-fnordbedarf-de/following{/other_user}","gists_url":"https://api.github.com/users/sammann-fnordbedarf-de/gists{/gist_id}","starred_url":"https://api.github.com/users/sammann-fnordbedarf-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammann-fnordbedarf-de/subscriptions","organizations_url":"https://api.github.com/users/sammann-fnordbedarf-de/orgs","repos_url":"https://api.github.com/users/sammann-fnordbedarf-de/repos","events_url":"https://api.github.com/users/sammann-fnordbedarf-de/events{/privacy}","received_events_url":"https://api.github.com/users/sammann-fnordbedarf-de/received_events","type":"User","site_admin":false},"body":"I get your point. \r\nImplementing this test helped me understand jabref / Preview Preference better. And as there was not a basic test yet, I thought it might be useful for others to see a \"skeleton\" constructor. \r\n\r\nOn another level, to which I have not jet gained enought understanding: May I ask, what is the benefit of not having this test?  If it hinders good design, then I would argue to implement good design, instead of not testing not so good design. Unfortunately, I cannot contribute to this level of discussion or programming yet (I am working on it, though). ","created_at":"2017-10-29T08:14:51Z","updated_at":"2017-10-29T08:14:52Z","html_url":"https://github.com/JabRef/jabref/pull/3224#discussion_r147573522","pull_request_url":"https://api.github.com/repos/JabRef/jabref/pulls/3224","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments/147573522"},"html":{"href":"https://github.com/JabRef/jabref/pull/3224#discussion_r147573522"},"pull_request":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/3224"}},"in_reply_to_id":141749069},"pull_request":{"url":"https://api.github.com/repos/JabRef/jabref/pulls/3224","id":141477436,"html_url":"https://github.com/JabRef/jabref/pull/3224","diff_url":"https://github.com/JabRef/jabref/pull/3224.diff","patch_url":"https://github.com/JabRef/jabref/pull/3224.patch","issue_url":"https://api.github.com/repos/JabRef/jabref/issues/3224","number":3224,"state":"open","locked":false,"title":"Testcoverage preferences","user":{"login":"sammann-fnordbedarf-de","id":8333551,"avatar_url":"https://avatars3.githubusercontent.com/u/8333551?v=4","gravatar_id":"","url":"https://api.github.com/users/sammann-fnordbedarf-de","html_url":"https://github.com/sammann-fnordbedarf-de","followers_url":"https://api.github.com/users/sammann-fnordbedarf-de/followers","following_url":"https://api.github.com/users/sammann-fnordbedarf-de/following{/other_user}","gists_url":"https://api.github.com/users/sammann-fnordbedarf-de/gists{/gist_id}","starred_url":"https://api.github.com/users/sammann-fnordbedarf-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammann-fnordbedarf-de/subscriptions","organizations_url":"https://api.github.com/users/sammann-fnordbedarf-de/orgs","repos_url":"https://api.github.com/users/sammann-fnordbedarf-de/repos","events_url":"https://api.github.com/users/sammann-fnordbedarf-de/events{/privacy}","received_events_url":"https://api.github.com/users/sammann-fnordbedarf-de/received_events","type":"User","site_admin":false},"body":"<!-- describe the changes you have made here: what, why, ... -->\r\n\r\nFixed a typo in https://github.com/JabRef/jabref/compare/master...sammann-fnordbedarf-de:testcoverage-preferences?expand=1#diff-b58b89dd0bdb3e1dad1c0ae7801bae2b: from previe to preview\r\n\r\nAdded tests for creating and building classes in preferences-package in order to increase text coverage of classes. \r\n\r\nConstructing classes expects nothing thrown, building classes also. Where needed the most trivial variables were used. \r\n\r\nIncreasing tests for methods will be more rigid and are planned after (nearly) full class coverage. \r\n\r\n- [ ] Change in CHANGELOG.md described\r\n- [ ] Tests created for changes\r\n- [ ] Screenshots added (for bigger UI changes)\r\n- [X] Manually tested changed features in running JabRef\r\n- [ ] Check documentation status (Issue created for outdated help page at [help.jabref.org](https://github.com/JabRef/help.jabref.org/issues)?)\r\n- [ ] If you changed the localization: Did you run `gradle localizationUpdate`?\r\n","created_at":"2017-09-17T08:20:00Z","updated_at":"2017-10-29T08:14:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a9db5b44096ac513e7dffe1806c28f7aadd44f6b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JabRef/jabref/pulls/3224/commits","review_comments_url":"https://api.github.com/repos/JabRef/jabref/pulls/3224/comments","review_comment_url":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JabRef/jabref/issues/3224/comments","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/86f79488d13dfa83fb41ec24190d05596092ead6","head":{"label":"sammann-fnordbedarf-de:testcoverage-preferences","ref":"testcoverage-preferences","sha":"86f79488d13dfa83fb41ec24190d05596092ead6","user":{"login":"sammann-fnordbedarf-de","id":8333551,"avatar_url":"https://avatars3.githubusercontent.com/u/8333551?v=4","gravatar_id":"","url":"https://api.github.com/users/sammann-fnordbedarf-de","html_url":"https://github.com/sammann-fnordbedarf-de","followers_url":"https://api.github.com/users/sammann-fnordbedarf-de/followers","following_url":"https://api.github.com/users/sammann-fnordbedarf-de/following{/other_user}","gists_url":"https://api.github.com/users/sammann-fnordbedarf-de/gists{/gist_id}","starred_url":"https://api.github.com/users/sammann-fnordbedarf-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammann-fnordbedarf-de/subscriptions","organizations_url":"https://api.github.com/users/sammann-fnordbedarf-de/orgs","repos_url":"https://api.github.com/users/sammann-fnordbedarf-de/repos","events_url":"https://api.github.com/users/sammann-fnordbedarf-de/events{/privacy}","received_events_url":"https://api.github.com/users/sammann-fnordbedarf-de/received_events","type":"User","site_admin":false},"repo":{"id":103781313,"name":"jabref","full_name":"sammann-fnordbedarf-de/jabref","owner":{"login":"sammann-fnordbedarf-de","id":8333551,"avatar_url":"https://avatars3.githubusercontent.com/u/8333551?v=4","gravatar_id":"","url":"https://api.github.com/users/sammann-fnordbedarf-de","html_url":"https://github.com/sammann-fnordbedarf-de","followers_url":"https://api.github.com/users/sammann-fnordbedarf-de/followers","following_url":"https://api.github.com/users/sammann-fnordbedarf-de/following{/other_user}","gists_url":"https://api.github.com/users/sammann-fnordbedarf-de/gists{/gist_id}","starred_url":"https://api.github.com/users/sammann-fnordbedarf-de/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sammann-fnordbedarf-de/subscriptions","organizations_url":"https://api.github.com/users/sammann-fnordbedarf-de/orgs","repos_url":"https://api.github.com/users/sammann-fnordbedarf-de/repos","events_url":"https://api.github.com/users/sammann-fnordbedarf-de/events{/privacy}","received_events_url":"https://api.github.com/users/sammann-fnordbedarf-de/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sammann-fnordbedarf-de/jabref","description":"Graphical Java application for managing BibTeX and BibLaTeX (.bib) databases","fork":true,"url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref","forks_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/forks","keys_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/teams","hooks_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/hooks","issue_events_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/events","assignees_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/tags","blobs_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/languages","stargazers_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/stargazers","contributors_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/contributors","subscribers_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/subscribers","subscription_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/subscription","commits_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/merges","archive_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/downloads","issues_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/labels{/name}","releases_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/sammann-fnordbedarf-de/jabref/deployments","created_at":"2017-09-16T20:19:00Z","updated_at":"2017-09-16T20:19:07Z","pushed_at":"2017-10-29T08:08:42Z","git_url":"git://github.com/sammann-fnordbedarf-de/jabref.git","ssh_url":"git@github.com:sammann-fnordbedarf-de/jabref.git","clone_url":"https://github.com/sammann-fnordbedarf-de/jabref.git","svn_url":"https://github.com/sammann-fnordbedarf-de/jabref","homepage":"https://www.jabref.org/","size":102357,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JabRef:master","ref":"master","sha":"821067364e02e97e6b5c9cf804c41e742d89bd71","user":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars1.githubusercontent.com/u/3914421?v=4","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"repo":{"id":17634071,"name":"jabref","full_name":"JabRef/jabref","owner":{"login":"JabRef","id":3914421,"avatar_url":"https://avatars1.githubusercontent.com/u/3914421?v=4","gravatar_id":"","url":"https://api.github.com/users/JabRef","html_url":"https://github.com/JabRef","followers_url":"https://api.github.com/users/JabRef/followers","following_url":"https://api.github.com/users/JabRef/following{/other_user}","gists_url":"https://api.github.com/users/JabRef/gists{/gist_id}","starred_url":"https://api.github.com/users/JabRef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JabRef/subscriptions","organizations_url":"https://api.github.com/users/JabRef/orgs","repos_url":"https://api.github.com/users/JabRef/repos","events_url":"https://api.github.com/users/JabRef/events{/privacy}","received_events_url":"https://api.github.com/users/JabRef/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JabRef/jabref","description":"Graphical Java application for managing BibTeX and BibLaTeX (.bib) databases","fork":false,"url":"https://api.github.com/repos/JabRef/jabref","forks_url":"https://api.github.com/repos/JabRef/jabref/forks","keys_url":"https://api.github.com/repos/JabRef/jabref/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JabRef/jabref/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JabRef/jabref/teams","hooks_url":"https://api.github.com/repos/JabRef/jabref/hooks","issue_events_url":"https://api.github.com/repos/JabRef/jabref/issues/events{/number}","events_url":"https://api.github.com/repos/JabRef/jabref/events","assignees_url":"https://api.github.com/repos/JabRef/jabref/assignees{/user}","branches_url":"https://api.github.com/repos/JabRef/jabref/branches{/branch}","tags_url":"https://api.github.com/repos/JabRef/jabref/tags","blobs_url":"https://api.github.com/repos/JabRef/jabref/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JabRef/jabref/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JabRef/jabref/git/refs{/sha}","trees_url":"https://api.github.com/repos/JabRef/jabref/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JabRef/jabref/statuses/{sha}","languages_url":"https://api.github.com/repos/JabRef/jabref/languages","stargazers_url":"https://api.github.com/repos/JabRef/jabref/stargazers","contributors_url":"https://api.github.com/repos/JabRef/jabref/contributors","subscribers_url":"https://api.github.com/repos/JabRef/jabref/subscribers","subscription_url":"https://api.github.com/repos/JabRef/jabref/subscription","commits_url":"https://api.github.com/repos/JabRef/jabref/commits{/sha}","git_commits_url":"https://api.github.com/repos/JabRef/jabref/git/commits{/sha}","comments_url":"https://api.github.com/repos/JabRef/jabref/comments{/number}","issue_comment_url":"https://api.github.com/repos/JabRef/jabref/issues/comments{/number}","contents_url":"https://api.github.com/repos/JabRef/jabref/contents/{+path}","compare_url":"https://api.github.com/repos/JabRef/jabref/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JabRef/jabref/merges","archive_url":"https://api.github.com/repos/JabRef/jabref/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JabRef/jabref/downloads","issues_url":"https://api.github.com/repos/JabRef/jabref/issues{/number}","pulls_url":"https://api.github.com/repos/JabRef/jabref/pulls{/number}","milestones_url":"https://api.github.com/repos/JabRef/jabref/milestones{/number}","notifications_url":"https://api.github.com/repos/JabRef/jabref/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JabRef/jabref/labels{/name}","releases_url":"https://api.github.com/repos/JabRef/jabref/releases{/id}","deployments_url":"https://api.github.com/repos/JabRef/jabref/deployments","created_at":"2014-03-11T14:48:42Z","updated_at":"2017-10-28T11:16:41Z","pushed_at":"2017-10-29T08:08:44Z","git_url":"git://github.com/JabRef/jabref.git","ssh_url":"git@github.com:JabRef/jabref.git","clone_url":"https://github.com/JabRef/jabref.git","svn_url":"https://github.com/JabRef/jabref","homepage":"https://www.jabref.org/","size":99130,"stargazers_count":672,"watchers_count":672,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":478,"mirror_url":null,"archived":false,"open_issues_count":209,"forks":478,"open_issues":209,"watchers":672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/3224"},"html":{"href":"https://github.com/JabRef/jabref/pull/3224"},"issue":{"href":"https://api.github.com/repos/JabRef/jabref/issues/3224"},"comments":{"href":"https://api.github.com/repos/JabRef/jabref/issues/3224/comments"},"review_comments":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/3224/comments"},"review_comment":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JabRef/jabref/pulls/3224/commits"},"statuses":{"href":"https://api.github.com/repos/JabRef/jabref/statuses/86f79488d13dfa83fb41ec24190d05596092ead6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sammann-fnordbedarf-de"}}