{"action":"created","issue":{"url":"https://api.github.com/repos/callemall/material-ui/issues/8223","repository_url":"https://api.github.com/repos/callemall/material-ui","labels_url":"https://api.github.com/repos/callemall/material-ui/issues/8223/labels{/name}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/8223/comments","events_url":"https://api.github.com/repos/callemall/material-ui/issues/8223/events","html_url":"https://github.com/callemall/material-ui/issues/8223","id":258094754,"number":8223,"title":"V1 production build - classnames conflicts","user":{"login":"darkowic","id":11510581,"avatar_url":"https://avatars2.githubusercontent.com/u/11510581?v=4","gravatar_id":"","url":"https://api.github.com/users/darkowic","html_url":"https://github.com/darkowic","followers_url":"https://api.github.com/users/darkowic/followers","following_url":"https://api.github.com/users/darkowic/following{/other_user}","gists_url":"https://api.github.com/users/darkowic/gists{/gist_id}","starred_url":"https://api.github.com/users/darkowic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkowic/subscriptions","organizations_url":"https://api.github.com/users/darkowic/orgs","repos_url":"https://api.github.com/users/darkowic/repos","events_url":"https://api.github.com/users/darkowic/events{/privacy}","received_events_url":"https://api.github.com/users/darkowic/received_events","type":"User","site_admin":false},"labels":[{"id":416834291,"url":"https://api.github.com/repos/callemall/material-ui/labels/v1","name":"v1","color":"5319e7","default":false},{"id":460153592,"url":"https://api.github.com/repos/callemall/material-ui/labels/waiting%20for%20user%20feedback","name":"waiting for user feedback","color":"e99695","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-09-15T16:23:57Z","updated_at":"2017-09-19T09:01:54Z","closed_at":"2017-09-15T23:22:23Z","author_association":"NONE","body":"<!--- Provide a general summary of the issue in the Title above -->\r\nThe css class names definitions are duplicated for some components  - in my case it is duplicated (I guess from my debugging) for `MuiIconButton` and `MuiModal` - check current behavior\r\n\r\n<!-- Checked checkbox should look like this: [x] -->\r\n- [ x] I have searched the [issues](https://github.com/callemall/material-ui/issues) of this repository and believe that this is not a duplicate.\r\n\r\n## Expected Behavior\r\nThe class names should not be duplicated across components.\r\n\r\n## Current Behavior\r\n<!--- \r\n    If describing a bug, tell us what happens instead of the expected behavior.\r\n    If suggesting a change/improvement, explain the difference from current behavior. \r\n-->\r\n\r\nMy button styles:\r\n![classnames_conflict](https://user-images.githubusercontent.com/11510581/30492845-37fd9560-9a42-11e7-8251-f04b1efb2ee3.png)\r\nThe class is duplicated.\r\nStyles definition:\r\n![classnames_conflit_2](https://user-images.githubusercontent.com/11510581/30492862-461c21d4-9a42-11e7-8774-5baf1fd74e83.png)\r\n\r\nIt is working in development mode:\r\nMy buttons styles:\r\n![development_class](https://user-images.githubusercontent.com/11510581/30492876-528b3d7e-9a42-11e7-8ac9-fca2627dbeb7.png)\r\n\r\nand found the definitions:\r\n![mui-icon-button-dev](https://user-images.githubusercontent.com/11510581/30492889-5dc28472-9a42-11e7-99cb-916781efde94.png)\r\n\r\nand from modal:\r\n![mui-modal-dev](https://user-images.githubusercontent.com/11510581/30492896-63b9ba12-9a42-11e7-8937-3c24535ac8a1.png)\r\n\r\n## Steps to Reproduce (for bugs)\r\n<!--- \r\n    Provide a link to a live example (you can use codesandbox.io) and an unambiguous set of steps to reproduce this bug. \r\n    Include code to reproduce, if relevant. This codesandbox.io template _may_ be a good starting point: \r\n    https://codesandbox.io/s/github/callemall/material-ui/tree/v1-beta/examples/create-react-app\r\n-->\r\n\r\nI can try to prepare the environment to reproduce the problem but right now I just wanted to report it here.\r\n\r\n## Context\r\n<!--- \r\n    How has this issue affected you? What are you trying to accomplish? \r\n    Providing context helps us come up with a solution that is most useful in the real world.\r\n-->  \r\nI'm trying to release my application with the production environment.\r\n\r\n## Your Environment\r\n<!--- Include as many relevant details about the environment with which you experienced the bug. -->\r\n\r\n| Tech         | Version |\r\n|--------------|---------|\r\n| Material-UI  |1.0.0-beta.10  |\r\n| React        |15.6.1         |\r\n| browser      |  any       |\r\n| webpack    |    ^3.3.0    |\r\n\r\n\r\n\r\nI need some hints where may be the problem. I'm not using `withStyles` solution anywhere - I use styled components for styles overriding. "},"comment":{"url":"https://api.github.com/repos/callemall/material-ui/issues/comments/330476511","html_url":"https://github.com/callemall/material-ui/issues/8223#issuecomment-330476511","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/8223","id":330476511,"user":{"login":"darkowic","id":11510581,"avatar_url":"https://avatars2.githubusercontent.com/u/11510581?v=4","gravatar_id":"","url":"https://api.github.com/users/darkowic","html_url":"https://github.com/darkowic","followers_url":"https://api.github.com/users/darkowic/followers","following_url":"https://api.github.com/users/darkowic/following{/other_user}","gists_url":"https://api.github.com/users/darkowic/gists{/gist_id}","starred_url":"https://api.github.com/users/darkowic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darkowic/subscriptions","organizations_url":"https://api.github.com/users/darkowic/orgs","repos_url":"https://api.github.com/users/darkowic/repos","events_url":"https://api.github.com/users/darkowic/events{/privacy}","received_events_url":"https://api.github.com/users/darkowic/received_events","type":"User","site_admin":false},"created_at":"2017-09-19T09:01:54Z","updated_at":"2017-09-19T09:01:54Z","author_association":"NONE","body":"@oliviertassinari I think I'm doing it using my custom `ThemeProvider`\r\n```\r\n  <JssProvider registry={context.sheetsRegistry} jss={context.jss}>\r\n    <MuiThemeProvider\r\n      theme={context.theme}\r\n      sheetManage={context.sheetsManager}\r\n      {...props}\r\n    />\r\n  </JssProvider>\r\n```\r\nI wrap my every react tree with this.  "}}
{"actor":{"display_login":"darkowic"}}