{"action":"created","comment":{"url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/comments/146664379","pull_request_review_id":71639435,"id":146664379,"diff_hunk":"@@ -29,23 +29,23 @@ module \"public_subnets\" {\n \n # Inputs\n \n-| Name                 | Default | Description                                                                                                         | Required |\n-|:---------------------|:-------:|:--------------------------------------------------------------------------------------------------------------------|:--------:|\n-| `namespace`          |   ``    | Namespace (e.g. `cp` or `cloudposse`)                                                                               |   Yes    |\n-| `stage`              |   ``    | Stage (e.g. `prod`, `dev`, `staging`)                                                                               |   Yes    |\n-| `name`               |   ``    | Name  (e.g. `bastion` or `db`)                                                                                      |   Yes    |\n-| `attributes`         |  `[]`   | Additional attributes (e.g. `policy` or `role`)                                                                     |    No    |\n-| `tags`               |  `{}`   | Additional tags  (e.g. `map(\"BusinessUnit\",\"XYZ\")`                                                                  |    No    |\n-| `names`              |   ``    | List of subnets names (e.g. `[\"apples\", \"oranges\", \"grapes\"]`)                                                      |   Yes    |\n-| `vpc_id`             |   ``    | The VPC ID where subnets will be created (e.g. `vpc-aceb2723`). If empty, a new VPC will be created                 |   Yes    |\n-| `base_cidr`          |   ``    | The base CIDR block which will be divided into subnet CIDR blocks (e.g. `10.0.0.0/16`)                              |    No    |\n-| `igw_id`             |   ``    | The Internet Gateway ID public route table will point to (e.g. `igw-9c26a123`). Conflicts with `nat_enabled = true` |    No    |\n-| `nat_enabled`        | `false` | Flag to enable/disable NAT gateways. Conflicts with non-empty `igw_id`                                              |    No    |\n-| `availability_zones` |   ``    | The  list of Availability Zones where subnets will be created (e.g. `[\"us-east-1a\", \"us-east-1b\"]`).                |   Yes    |\n-| `network_acl_id`     |   ``    | Network ACL ID that will be added to the subnets.  If empty, a new ACL will be created                              |    No    |\n-| `additional_routes`  |  `{}`   | Map of Additional routes for subnets (e.g. `{\"10.0.0.2/24\" = igw-0038f979}`)                                        |    No    |\n-| `egress`             |  `[]`   | List of Network ACL CIDRs permitted egress                                                                          |    No    |\n-| `ingress`            |  `[]`   | List of Network ACL CIDRs permitted ingress                                                                         |    No    |\n+| Name                  | Default | Description                                                                                                         | Required |\n+|:----------------------|:-------:|:--------------------------------------------------------------------------------------------------------------------|:--------:|\n+| `namespace`           |   ``    | Namespace (e.g. `cp` or `cloudposse`)                                                                               |   Yes    |\n+| `stage`               |   ``    | Stage (e.g. `prod`, `dev`, `staging`)                                                                               |   Yes    |\n+| `name`                |   ``    | Name  (e.g. `bastion` or `db`)                                                                                      |   Yes    |","path":"README.md","position":42,"original_position":25,"commit_id":"f5ae9be10d1fee5fd09a57108224e66c23c391f3","original_commit_id":"8d19d4d50aba6b9ab959bf5b1054ff2559ad63f8","user":{"login":"osterman","id":52489,"avatar_url":"https://avatars3.githubusercontent.com/u/52489?v=4","gravatar_id":"","url":"https://api.github.com/users/osterman","html_url":"https://github.com/osterman","followers_url":"https://api.github.com/users/osterman/followers","following_url":"https://api.github.com/users/osterman/following{/other_user}","gists_url":"https://api.github.com/users/osterman/gists{/gist_id}","starred_url":"https://api.github.com/users/osterman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osterman/subscriptions","organizations_url":"https://api.github.com/users/osterman/orgs","repos_url":"https://api.github.com/users/osterman/repos","events_url":"https://api.github.com/users/osterman/events{/privacy}","received_events_url":"https://api.github.com/users/osterman/received_events","type":"User","site_admin":false},"body":"if you set name to `\"\"` it will drop out.","created_at":"2017-10-24T19:15:30Z","updated_at":"2017-10-24T19:15:30Z","html_url":"https://github.com/cloudposse/terraform-aws-named-subnets/pull/1#discussion_r146664379","pull_request_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/comments/146664379"},"html":{"href":"https://github.com/cloudposse/terraform-aws-named-subnets/pull/1#discussion_r146664379"},"pull_request":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/1"}},"in_reply_to_id":146152887},"pull_request":{"url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/1","id":147571007,"html_url":"https://github.com/cloudposse/terraform-aws-named-subnets/pull/1","diff_url":"https://github.com/cloudposse/terraform-aws-named-subnets/pull/1.diff","patch_url":"https://github.com/cloudposse/terraform-aws-named-subnets/pull/1.patch","issue_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues/1","number":1,"state":"open","locked":false,"title":"Add code","user":{"login":"SweetOps","id":26582191,"avatar_url":"https://avatars1.githubusercontent.com/u/26582191?v=4","gravatar_id":"","url":"https://api.github.com/users/SweetOps","html_url":"https://github.com/SweetOps","followers_url":"https://api.github.com/users/SweetOps/followers","following_url":"https://api.github.com/users/SweetOps/following{/other_user}","gists_url":"https://api.github.com/users/SweetOps/gists{/gist_id}","starred_url":"https://api.github.com/users/SweetOps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SweetOps/subscriptions","organizations_url":"https://api.github.com/users/SweetOps/orgs","repos_url":"https://api.github.com/users/SweetOps/repos","events_url":"https://api.github.com/users/SweetOps/events{/privacy}","received_events_url":"https://api.github.com/users/SweetOps/received_events","type":"User","site_admin":false},"body":"## What\r\n* Add code\r\n\r\n## Why\r\n* Need module for named `subnets`","created_at":"2017-10-19T14:25:24Z","updated_at":"2017-10-24T19:15:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e38a5607da45a4598a29e76cb4eec6a14a58c7a","assignee":{"login":"SweetOps","id":26582191,"avatar_url":"https://avatars1.githubusercontent.com/u/26582191?v=4","gravatar_id":"","url":"https://api.github.com/users/SweetOps","html_url":"https://github.com/SweetOps","followers_url":"https://api.github.com/users/SweetOps/followers","following_url":"https://api.github.com/users/SweetOps/following{/other_user}","gists_url":"https://api.github.com/users/SweetOps/gists{/gist_id}","starred_url":"https://api.github.com/users/SweetOps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SweetOps/subscriptions","organizations_url":"https://api.github.com/users/SweetOps/orgs","repos_url":"https://api.github.com/users/SweetOps/repos","events_url":"https://api.github.com/users/SweetOps/events{/privacy}","received_events_url":"https://api.github.com/users/SweetOps/received_events","type":"User","site_admin":false},"assignees":[{"login":"SweetOps","id":26582191,"avatar_url":"https://avatars1.githubusercontent.com/u/26582191?v=4","gravatar_id":"","url":"https://api.github.com/users/SweetOps","html_url":"https://github.com/SweetOps","followers_url":"https://api.github.com/users/SweetOps/followers","following_url":"https://api.github.com/users/SweetOps/following{/other_user}","gists_url":"https://api.github.com/users/SweetOps/gists{/gist_id}","starred_url":"https://api.github.com/users/SweetOps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SweetOps/subscriptions","organizations_url":"https://api.github.com/users/SweetOps/orgs","repos_url":"https://api.github.com/users/SweetOps/repos","events_url":"https://api.github.com/users/SweetOps/events{/privacy}","received_events_url":"https://api.github.com/users/SweetOps/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/1/commits","review_comments_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/1/comments","review_comment_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues/1/comments","statuses_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/statuses/f5ae9be10d1fee5fd09a57108224e66c23c391f3","head":{"label":"cloudposse:add_code","ref":"add_code","sha":"f5ae9be10d1fee5fd09a57108224e66c23c391f3","user":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"repo":{"id":107419111,"name":"terraform-aws-named-subnets","full_name":"cloudposse/terraform-aws-named-subnets","owner":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudposse/terraform-aws-named-subnets","description":null,"fork":false,"url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets","forks_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/forks","keys_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/teams","hooks_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/hooks","issue_events_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues/events{/number}","events_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/events","assignees_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/assignees{/user}","branches_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/branches{/branch}","tags_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/tags","blobs_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/languages","stargazers_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/stargazers","contributors_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/contributors","subscribers_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/subscribers","subscription_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/subscription","commits_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/contents/{+path}","compare_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/merges","archive_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/downloads","issues_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues{/number}","pulls_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/labels{/name}","releases_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/releases{/id}","deployments_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/deployments","created_at":"2017-10-18T14:24:51Z","updated_at":"2017-10-20T16:03:40Z","pushed_at":"2017-10-24T19:06:35Z","git_url":"git://github.com/cloudposse/terraform-aws-named-subnets.git","ssh_url":"git@github.com:cloudposse/terraform-aws-named-subnets.git","clone_url":"https://github.com/cloudposse/terraform-aws-named-subnets.git","svn_url":"https://github.com/cloudposse/terraform-aws-named-subnets","homepage":null,"size":29,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"cloudposse:master","ref":"master","sha":"91e73ac0023c21672ce57085b28952171ac63dc1","user":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"repo":{"id":107419111,"name":"terraform-aws-named-subnets","full_name":"cloudposse/terraform-aws-named-subnets","owner":{"login":"cloudposse","id":16398900,"avatar_url":"https://avatars2.githubusercontent.com/u/16398900?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudposse","html_url":"https://github.com/cloudposse","followers_url":"https://api.github.com/users/cloudposse/followers","following_url":"https://api.github.com/users/cloudposse/following{/other_user}","gists_url":"https://api.github.com/users/cloudposse/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudposse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudposse/subscriptions","organizations_url":"https://api.github.com/users/cloudposse/orgs","repos_url":"https://api.github.com/users/cloudposse/repos","events_url":"https://api.github.com/users/cloudposse/events{/privacy}","received_events_url":"https://api.github.com/users/cloudposse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudposse/terraform-aws-named-subnets","description":null,"fork":false,"url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets","forks_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/forks","keys_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/teams","hooks_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/hooks","issue_events_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues/events{/number}","events_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/events","assignees_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/assignees{/user}","branches_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/branches{/branch}","tags_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/tags","blobs_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/languages","stargazers_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/stargazers","contributors_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/contributors","subscribers_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/subscribers","subscription_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/subscription","commits_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/contents/{+path}","compare_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/merges","archive_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/downloads","issues_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues{/number}","pulls_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/labels{/name}","releases_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/releases{/id}","deployments_url":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/deployments","created_at":"2017-10-18T14:24:51Z","updated_at":"2017-10-20T16:03:40Z","pushed_at":"2017-10-24T19:06:35Z","git_url":"git://github.com/cloudposse/terraform-aws-named-subnets.git","ssh_url":"git@github.com:cloudposse/terraform-aws-named-subnets.git","clone_url":"https://github.com/cloudposse/terraform-aws-named-subnets.git","svn_url":"https://github.com/cloudposse/terraform-aws-named-subnets","homepage":null,"size":29,"stargazers_count":1,"watchers_count":1,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/1"},"html":{"href":"https://github.com/cloudposse/terraform-aws-named-subnets/pull/1"},"issue":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues/1"},"comments":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/cloudposse/terraform-aws-named-subnets/statuses/f5ae9be10d1fee5fd09a57108224e66c23c391f3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"osterman"}}