{"action":"created","issue":{"url":"https://api.github.com/repos/kiwix/kiwix-android/issues/227","repository_url":"https://api.github.com/repos/kiwix/kiwix-android","labels_url":"https://api.github.com/repos/kiwix/kiwix-android/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/kiwix/kiwix-android/issues/227/comments","events_url":"https://api.github.com/repos/kiwix/kiwix-android/issues/227/events","html_url":"https://github.com/kiwix/kiwix-android/issues/227","id":249158314,"number":227,"title":"Mock Network revisited...","user":{"login":"julianharty","id":785891,"avatar_url":"https://avatars1.githubusercontent.com/u/785891?v=4","gravatar_id":"","url":"https://api.github.com/users/julianharty","html_url":"https://github.com/julianharty","followers_url":"https://api.github.com/users/julianharty/followers","following_url":"https://api.github.com/users/julianharty/following{/other_user}","gists_url":"https://api.github.com/users/julianharty/gists{/gist_id}","starred_url":"https://api.github.com/users/julianharty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianharty/subscriptions","organizations_url":"https://api.github.com/users/julianharty/orgs","repos_url":"https://api.github.com/users/julianharty/repos","events_url":"https://api.github.com/users/julianharty/events{/privacy}","received_events_url":"https://api.github.com/users/julianharty/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-09T20:54:09Z","updated_at":"2017-08-09T21:00:32Z","closed_at":null,"body":"@mhutti1 In https://github.com/kiwix/kiwix-android/issues/103 you added support for a mock web-server, and support for 3 specific downloads:\r\n\r\n1. library.xml\r\n2. test.zim.meta4\r\n3. testzim.zim\r\n\r\nThese seem enough to test the download e.g. a list of (1) ZIM file, and enable it to be downloaded.\r\n\r\nHowever, when I try running these tests with the Android device in flight-mode or with WiFi disabled the networkTest fails (as does the downloadTest). Generally when the device has an internet connection the test passes. I wondered whether you intend the tests to be able to run successfully on a device with no active network connection (e.g. when it's in Flight Mode)? If so, perhaps there's a bit more work to do on the code?\r\n\r\nI'm happy to help once I understand what's intended to happen."},"comment":{"url":"https://api.github.com/repos/kiwix/kiwix-android/issues/comments/321380038","html_url":"https://github.com/kiwix/kiwix-android/issues/227#issuecomment-321380038","issue_url":"https://api.github.com/repos/kiwix/kiwix-android/issues/227","id":321380038,"user":{"login":"mhutti1","id":2286937,"avatar_url":"https://avatars1.githubusercontent.com/u/2286937?v=4","gravatar_id":"","url":"https://api.github.com/users/mhutti1","html_url":"https://github.com/mhutti1","followers_url":"https://api.github.com/users/mhutti1/followers","following_url":"https://api.github.com/users/mhutti1/following{/other_user}","gists_url":"https://api.github.com/users/mhutti1/gists{/gist_id}","starred_url":"https://api.github.com/users/mhutti1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhutti1/subscriptions","organizations_url":"https://api.github.com/users/mhutti1/orgs","repos_url":"https://api.github.com/users/mhutti1/repos","events_url":"https://api.github.com/users/mhutti1/events{/privacy}","received_events_url":"https://api.github.com/users/mhutti1/received_events","type":"User","site_admin":false},"created_at":"2017-08-09T21:00:32Z","updated_at":"2017-08-09T21:00:32Z","body":"Yeah thats a good point. I guess we should probably look at overriding the network connectivity checks in the test so that they still attempt to download. As well as this on testdroid lots of tests fail due to random device connectivity issues so we might look at fully mocking the network. What are your thoughts on this?"}}
{"actor":{"display_login":"mhutti1"}}