{"action":"created","comment":{"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments/113609036","pull_request_review_id":35011468,"id":113609036,"diff_hunk":"@@ -241,24 +241,24 @@ AC_SEARCH_LIBS([clock_gettime], [rt],\n dnl check for libraries\n \n OMPI_CHECK_PORTALS4([portals4],\n-    [transport=\"portals4\"\n-     transport_portals4=\"yes\"],\n+    [transport_portals4=\"yes\"],\n     [transport_portals4=\"no\"])\n \n OPAL_CHECK_OFI([ofi],\n-    [transport=\"ofi\"\n-     transport_ofi=\"yes\"],\n+    [transport_ofi=\"yes\"],\n     [transport_ofi=\"no\"])\n \n # assure that only ofi is enabled if portals4 is also detected\n-if test -n \"$with_ofi\" ; then\n+if test \"$transport_ofi\" = \"yes\" ; then","path":"configure.ac","position":null,"original_position":17,"commit_id":"0684af92a7b8e5017dfa3152c53888293e5af5dc","original_commit_id":"0684af92a7b8e5017dfa3152c53888293e5af5dc","user":{"login":"davidozog","id":1834947,"avatar_url":"https://avatars2.githubusercontent.com/u/1834947?v=3","gravatar_id":"","url":"https://api.github.com/users/davidozog","html_url":"https://github.com/davidozog","followers_url":"https://api.github.com/users/davidozog/followers","following_url":"https://api.github.com/users/davidozog/following{/other_user}","gists_url":"https://api.github.com/users/davidozog/gists{/gist_id}","starred_url":"https://api.github.com/users/davidozog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidozog/subscriptions","organizations_url":"https://api.github.com/users/davidozog/orgs","repos_url":"https://api.github.com/users/davidozog/repos","events_url":"https://api.github.com/users/davidozog/events{/privacy}","received_events_url":"https://api.github.com/users/davidozog/received_events","type":"User","site_admin":false},"body":"Ah, right.  How about ```if test -n $with_ofi -a $with_ofi -ne \"no\"```?","created_at":"2017-04-27T03:35:21Z","updated_at":"2017-04-27T03:35:21Z","html_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/390#discussion_r113609036","pull_request_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/390","_links":{"self":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments/113609036"},"html":{"href":"https://github.com/Sandia-OpenSHMEM/SOS/pull/390#discussion_r113609036"},"pull_request":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/390"}}},"pull_request":{"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/390","id":117324189,"html_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/390","diff_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/390.diff","patch_url":"https://github.com/Sandia-OpenSHMEM/SOS/pull/390.patch","issue_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/390","number":390,"state":"open","locked":false,"title":"Update to upstream OPAL_CHECK_OFI script","user":{"login":"davidozog","id":1834947,"avatar_url":"https://avatars2.githubusercontent.com/u/1834947?v=3","gravatar_id":"","url":"https://api.github.com/users/davidozog","html_url":"https://github.com/davidozog","followers_url":"https://api.github.com/users/davidozog/followers","following_url":"https://api.github.com/users/davidozog/following{/other_user}","gists_url":"https://api.github.com/users/davidozog/gists{/gist_id}","starred_url":"https://api.github.com/users/davidozog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidozog/subscriptions","organizations_url":"https://api.github.com/users/davidozog/orgs","repos_url":"https://api.github.com/users/davidozog/repos","events_url":"https://api.github.com/users/davidozog/events{/privacy}","received_events_url":"https://api.github.com/users/davidozog/received_events","type":"User","site_admin":false},"body":"OMPI recently switched from --with-libfabric to --with-ofi.  This commit pulls in those changes (making --with-ofi the preferred flag and deprecating --with-libfabric).  I also added some logic that separates ofi and portals4 if both are detected (as well as XPMEM and CMA).\r\n","created_at":"2017-04-24T18:06:10Z","updated_at":"2017-04-27T03:35:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16ed458f2a4fad1810a4f02bb454836ef4edfdbe","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/390/commits","review_comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/390/comments","review_comment_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/390/comments","statuses_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/0684af92a7b8e5017dfa3152c53888293e5af5dc","head":{"label":"davidozog:pr/update_opal_ofi_check","ref":"pr/update_opal_ofi_check","sha":"0684af92a7b8e5017dfa3152c53888293e5af5dc","user":{"login":"davidozog","id":1834947,"avatar_url":"https://avatars2.githubusercontent.com/u/1834947?v=3","gravatar_id":"","url":"https://api.github.com/users/davidozog","html_url":"https://github.com/davidozog","followers_url":"https://api.github.com/users/davidozog/followers","following_url":"https://api.github.com/users/davidozog/following{/other_user}","gists_url":"https://api.github.com/users/davidozog/gists{/gist_id}","starred_url":"https://api.github.com/users/davidozog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidozog/subscriptions","organizations_url":"https://api.github.com/users/davidozog/orgs","repos_url":"https://api.github.com/users/davidozog/repos","events_url":"https://api.github.com/users/davidozog/events{/privacy}","received_events_url":"https://api.github.com/users/davidozog/received_events","type":"User","site_admin":false},"repo":{"id":78573880,"name":"sandia-shmem","full_name":"davidozog/sandia-shmem","owner":{"login":"davidozog","id":1834947,"avatar_url":"https://avatars2.githubusercontent.com/u/1834947?v=3","gravatar_id":"","url":"https://api.github.com/users/davidozog","html_url":"https://github.com/davidozog","followers_url":"https://api.github.com/users/davidozog/followers","following_url":"https://api.github.com/users/davidozog/following{/other_user}","gists_url":"https://api.github.com/users/davidozog/gists{/gist_id}","starred_url":"https://api.github.com/users/davidozog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidozog/subscriptions","organizations_url":"https://api.github.com/users/davidozog/orgs","repos_url":"https://api.github.com/users/davidozog/repos","events_url":"https://api.github.com/users/davidozog/events{/privacy}","received_events_url":"https://api.github.com/users/davidozog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidozog/sandia-shmem","description":"Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4 and the Open Fabric Interface (OFI).  Please click on the Wiki tab for help with building and using SOS.","fork":true,"url":"https://api.github.com/repos/davidozog/sandia-shmem","forks_url":"https://api.github.com/repos/davidozog/sandia-shmem/forks","keys_url":"https://api.github.com/repos/davidozog/sandia-shmem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidozog/sandia-shmem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidozog/sandia-shmem/teams","hooks_url":"https://api.github.com/repos/davidozog/sandia-shmem/hooks","issue_events_url":"https://api.github.com/repos/davidozog/sandia-shmem/issues/events{/number}","events_url":"https://api.github.com/repos/davidozog/sandia-shmem/events","assignees_url":"https://api.github.com/repos/davidozog/sandia-shmem/assignees{/user}","branches_url":"https://api.github.com/repos/davidozog/sandia-shmem/branches{/branch}","tags_url":"https://api.github.com/repos/davidozog/sandia-shmem/tags","blobs_url":"https://api.github.com/repos/davidozog/sandia-shmem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidozog/sandia-shmem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidozog/sandia-shmem/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidozog/sandia-shmem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidozog/sandia-shmem/statuses/{sha}","languages_url":"https://api.github.com/repos/davidozog/sandia-shmem/languages","stargazers_url":"https://api.github.com/repos/davidozog/sandia-shmem/stargazers","contributors_url":"https://api.github.com/repos/davidozog/sandia-shmem/contributors","subscribers_url":"https://api.github.com/repos/davidozog/sandia-shmem/subscribers","subscription_url":"https://api.github.com/repos/davidozog/sandia-shmem/subscription","commits_url":"https://api.github.com/repos/davidozog/sandia-shmem/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidozog/sandia-shmem/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidozog/sandia-shmem/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidozog/sandia-shmem/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidozog/sandia-shmem/contents/{+path}","compare_url":"https://api.github.com/repos/davidozog/sandia-shmem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidozog/sandia-shmem/merges","archive_url":"https://api.github.com/repos/davidozog/sandia-shmem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidozog/sandia-shmem/downloads","issues_url":"https://api.github.com/repos/davidozog/sandia-shmem/issues{/number}","pulls_url":"https://api.github.com/repos/davidozog/sandia-shmem/pulls{/number}","milestones_url":"https://api.github.com/repos/davidozog/sandia-shmem/milestones{/number}","notifications_url":"https://api.github.com/repos/davidozog/sandia-shmem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidozog/sandia-shmem/labels{/name}","releases_url":"https://api.github.com/repos/davidozog/sandia-shmem/releases{/id}","deployments_url":"https://api.github.com/repos/davidozog/sandia-shmem/deployments","created_at":"2017-01-10T21:04:51Z","updated_at":"2017-01-11T19:41:34Z","pushed_at":"2017-04-25T22:01:40Z","git_url":"git://github.com/davidozog/sandia-shmem.git","ssh_url":"git@github.com:davidozog/sandia-shmem.git","clone_url":"https://github.com/davidozog/sandia-shmem.git","svn_url":"https://github.com/davidozog/sandia-shmem","homepage":"","size":2223,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Sandia-OpenSHMEM:master","ref":"master","sha":"a62b678b6cdb4e96a687431a474918a810526d9c","user":{"login":"Sandia-OpenSHMEM","id":16339082,"avatar_url":"https://avatars3.githubusercontent.com/u/16339082?v=3","gravatar_id":"","url":"https://api.github.com/users/Sandia-OpenSHMEM","html_url":"https://github.com/Sandia-OpenSHMEM","followers_url":"https://api.github.com/users/Sandia-OpenSHMEM/followers","following_url":"https://api.github.com/users/Sandia-OpenSHMEM/following{/other_user}","gists_url":"https://api.github.com/users/Sandia-OpenSHMEM/gists{/gist_id}","starred_url":"https://api.github.com/users/Sandia-OpenSHMEM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sandia-OpenSHMEM/subscriptions","organizations_url":"https://api.github.com/users/Sandia-OpenSHMEM/orgs","repos_url":"https://api.github.com/users/Sandia-OpenSHMEM/repos","events_url":"https://api.github.com/users/Sandia-OpenSHMEM/events{/privacy}","received_events_url":"https://api.github.com/users/Sandia-OpenSHMEM/received_events","type":"Organization","site_admin":false},"repo":{"id":42528680,"name":"SOS","full_name":"Sandia-OpenSHMEM/SOS","owner":{"login":"Sandia-OpenSHMEM","id":16339082,"avatar_url":"https://avatars3.githubusercontent.com/u/16339082?v=3","gravatar_id":"","url":"https://api.github.com/users/Sandia-OpenSHMEM","html_url":"https://github.com/Sandia-OpenSHMEM","followers_url":"https://api.github.com/users/Sandia-OpenSHMEM/followers","following_url":"https://api.github.com/users/Sandia-OpenSHMEM/following{/other_user}","gists_url":"https://api.github.com/users/Sandia-OpenSHMEM/gists{/gist_id}","starred_url":"https://api.github.com/users/Sandia-OpenSHMEM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sandia-OpenSHMEM/subscriptions","organizations_url":"https://api.github.com/users/Sandia-OpenSHMEM/orgs","repos_url":"https://api.github.com/users/Sandia-OpenSHMEM/repos","events_url":"https://api.github.com/users/Sandia-OpenSHMEM/events{/privacy}","received_events_url":"https://api.github.com/users/Sandia-OpenSHMEM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sandia-OpenSHMEM/SOS","description":"Sandia OpenSHMEM is an implementation of the OpenSHMEM specification over multiple Networking APIs, including Portals 4 and the Open Fabric Interface (OFI).  Please click on the Wiki tab for help with building and using SOS.","fork":false,"url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS","forks_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/forks","keys_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/teams","hooks_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/hooks","issue_events_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/events{/number}","events_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/events","assignees_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/assignees{/user}","branches_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/branches{/branch}","tags_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/tags","blobs_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/{sha}","languages_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/languages","stargazers_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/stargazers","contributors_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/contributors","subscribers_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/subscribers","subscription_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/subscription","commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/contents/{+path}","compare_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/merges","archive_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/downloads","issues_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues{/number}","pulls_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls{/number}","milestones_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/milestones{/number}","notifications_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/labels{/name}","releases_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/releases{/id}","deployments_url":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/deployments","created_at":"2015-09-15T15:34:37Z","updated_at":"2017-02-08T11:30:46Z","pushed_at":"2017-04-27T02:55:17Z","git_url":"git://github.com/Sandia-OpenSHMEM/SOS.git","ssh_url":"git@github.com:Sandia-OpenSHMEM/SOS.git","clone_url":"https://github.com/Sandia-OpenSHMEM/SOS.git","svn_url":"https://github.com/Sandia-OpenSHMEM/SOS","homepage":"","size":2178,"stargazers_count":12,"watchers_count":12,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"open_issues_count":45,"forks":22,"open_issues":45,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/390"},"html":{"href":"https://github.com/Sandia-OpenSHMEM/SOS/pull/390"},"issue":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/390"},"comments":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/issues/390/comments"},"review_comments":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/390/comments"},"review_comment":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/pulls/390/commits"},"statuses":{"href":"https://api.github.com/repos/Sandia-OpenSHMEM/SOS/statuses/0684af92a7b8e5017dfa3152c53888293e5af5dc"}}}}
{"actor":{"display_login":"davidozog"}}