{"action":"created","comment":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/102952911","pull_request_review_id":23726994,"id":102952911,"diff_hunk":"@@ -0,0 +1,16 @@\n+\n+CREATE TABLE IF NOT EXISTS `cockatrice_audit` (\n+  `id` int(7) unsigned zerofill NOT NULL auto_increment,\n+  `id_server` tinyint(3) NOT NULL,\n+  `name` varchar(35) NOT NULL,\n+  `ip_address` varchar(255) NOT NULL,\n+  `clientid` varchar(15) NOT NULL,\n+  `incidentDate` datetime NOT NULL default '0000-00-00 00:00:00',\n+  `action` varchar(35) NOT NULL,\n+  `results` ENUM('fail', 'success') NOT NULL DEFAULT 'fail',\n+  `details` varchar(255) NOT NULL,","path":"servatrice/migrations/servatrice_0021_to_0022.sql","position":11,"original_position":11,"commit_id":"b66c2c6411b3e5582bb097162648e8d63190dd98","original_commit_id":"b66c2c6411b3e5582bb097162648e8d63190dd98","user":{"login":"woogerboy21","id":1361287,"avatar_url":"https://avatars.githubusercontent.com/u/1361287?v=3","gravatar_id":"","url":"https://api.github.com/users/woogerboy21","html_url":"https://github.com/woogerboy21","followers_url":"https://api.github.com/users/woogerboy21/followers","following_url":"https://api.github.com/users/woogerboy21/following{/other_user}","gists_url":"https://api.github.com/users/woogerboy21/gists{/gist_id}","starred_url":"https://api.github.com/users/woogerboy21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogerboy21/subscriptions","organizations_url":"https://api.github.com/users/woogerboy21/orgs","repos_url":"https://api.github.com/users/woogerboy21/repos","events_url":"https://api.github.com/users/woogerboy21/events{/privacy}","received_events_url":"https://api.github.com/users/woogerboy21/received_events","type":"User","site_admin":false},"body":"Oh another thing about the details column, its original concept was for more of a scratch space for relevant details to the action.  Not so much for the result.  However I found  on failure describing why the failure happened to be helpful.  Thought I would mention what its original intentions were for and maybe others could brainstorm other idea's .","created_at":"2017-02-24T14:39:25Z","updated_at":"2017-02-24T14:39:25Z","html_url":"https://github.com/Cockatrice/Cockatrice/pull/2423#discussion_r102952911","pull_request_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2423","_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments/102952911"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/2423#discussion_r102952911"},"pull_request":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2423"}}},"pull_request":{"url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2423","id":107724286,"html_url":"https://github.com/Cockatrice/Cockatrice/pull/2423","diff_url":"https://github.com/Cockatrice/Cockatrice/pull/2423.diff","patch_url":"https://github.com/Cockatrice/Cockatrice/pull/2423.patch","issue_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/2423","number":2423,"state":"open","locked":false,"title":"Server audit table","user":{"login":"woogerboy21","id":1361287,"avatar_url":"https://avatars.githubusercontent.com/u/1361287?v=3","gravatar_id":"","url":"https://api.github.com/users/woogerboy21","html_url":"https://github.com/woogerboy21","followers_url":"https://api.github.com/users/woogerboy21/followers","following_url":"https://api.github.com/users/woogerboy21/following{/other_user}","gists_url":"https://api.github.com/users/woogerboy21/gists{/gist_id}","starred_url":"https://api.github.com/users/woogerboy21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogerboy21/subscriptions","organizations_url":"https://api.github.com/users/woogerboy21/orgs","repos_url":"https://api.github.com/users/woogerboy21/repos","events_url":"https://api.github.com/users/woogerboy21/events{/privacy}","received_events_url":"https://api.github.com/users/woogerboy21/received_events","type":"User","site_admin":false},"body":"Added the ability for servatrice to store user registration and forgot password attempts to a database (audit) table.  The audit functionality can be enabled/disabled as a whole OR individual auditable items can be enabled/disabled.\r\n\r\nOne thing to note and want people's opinions on it.  While adding the auditing functionality to the account registration activation block of code I noticed the clientid is not sent with the activation command container.  It's sent with the registration request, but not with the following activation command (if that functionality is enabled).  Should I expand the protocol to include the clientid when sending the activation command or leave it as it sits with the db function call passing an \"UNKNOWN\" string value that gets stored in the DB audit table?","created_at":"2017-02-23T22:09:42Z","updated_at":"2017-02-24T14:39:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"65f9b4adee841231b6bbbd4832569943cb0edcbc","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2423/commits","review_comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2423/comments","review_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/2423/comments","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/b66c2c6411b3e5582bb097162648e8d63190dd98","head":{"label":"woogerboy21:server_audit_table","ref":"server_audit_table","sha":"b66c2c6411b3e5582bb097162648e8d63190dd98","user":{"login":"woogerboy21","id":1361287,"avatar_url":"https://avatars.githubusercontent.com/u/1361287?v=3","gravatar_id":"","url":"https://api.github.com/users/woogerboy21","html_url":"https://github.com/woogerboy21","followers_url":"https://api.github.com/users/woogerboy21/followers","following_url":"https://api.github.com/users/woogerboy21/following{/other_user}","gists_url":"https://api.github.com/users/woogerboy21/gists{/gist_id}","starred_url":"https://api.github.com/users/woogerboy21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogerboy21/subscriptions","organizations_url":"https://api.github.com/users/woogerboy21/orgs","repos_url":"https://api.github.com/users/woogerboy21/repos","events_url":"https://api.github.com/users/woogerboy21/events{/privacy}","received_events_url":"https://api.github.com/users/woogerboy21/received_events","type":"User","site_admin":false},"repo":{"id":54280436,"name":"Cockatrice","full_name":"woogerboy21/Cockatrice","owner":{"login":"woogerboy21","id":1361287,"avatar_url":"https://avatars.githubusercontent.com/u/1361287?v=3","gravatar_id":"","url":"https://api.github.com/users/woogerboy21","html_url":"https://github.com/woogerboy21","followers_url":"https://api.github.com/users/woogerboy21/followers","following_url":"https://api.github.com/users/woogerboy21/following{/other_user}","gists_url":"https://api.github.com/users/woogerboy21/gists{/gist_id}","starred_url":"https://api.github.com/users/woogerboy21/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/woogerboy21/subscriptions","organizations_url":"https://api.github.com/users/woogerboy21/orgs","repos_url":"https://api.github.com/users/woogerboy21/repos","events_url":"https://api.github.com/users/woogerboy21/events{/privacy}","received_events_url":"https://api.github.com/users/woogerboy21/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/woogerboy21/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":true,"url":"https://api.github.com/repos/woogerboy21/Cockatrice","forks_url":"https://api.github.com/repos/woogerboy21/Cockatrice/forks","keys_url":"https://api.github.com/repos/woogerboy21/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/woogerboy21/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/woogerboy21/Cockatrice/teams","hooks_url":"https://api.github.com/repos/woogerboy21/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/woogerboy21/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/woogerboy21/Cockatrice/events","assignees_url":"https://api.github.com/repos/woogerboy21/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/woogerboy21/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/woogerboy21/Cockatrice/tags","blobs_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/woogerboy21/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/woogerboy21/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/woogerboy21/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/woogerboy21/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/woogerboy21/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/woogerboy21/Cockatrice/subscription","commits_url":"https://api.github.com/repos/woogerboy21/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/woogerboy21/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/woogerboy21/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/woogerboy21/Cockatrice/issues/comments{/number}","contents_url":"https://api.github.com/repos/woogerboy21/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/woogerboy21/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/woogerboy21/Cockatrice/merges","archive_url":"https://api.github.com/repos/woogerboy21/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/woogerboy21/Cockatrice/downloads","issues_url":"https://api.github.com/repos/woogerboy21/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/woogerboy21/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/woogerboy21/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/woogerboy21/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/woogerboy21/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/woogerboy21/Cockatrice/releases{/id}","deployments_url":"https://api.github.com/repos/woogerboy21/Cockatrice/deployments","created_at":"2016-03-19T18:15:16Z","updated_at":"2016-10-08T22:49:49Z","pushed_at":"2017-02-23T22:26:34Z","git_url":"git://github.com/woogerboy21/Cockatrice.git","ssh_url":"git@github.com:woogerboy21/Cockatrice.git","clone_url":"https://github.com/woogerboy21/Cockatrice.git","svn_url":"https://github.com/woogerboy21/Cockatrice","homepage":"https://cockatrice.github.io","size":35886,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Cockatrice:master","ref":"master","sha":"47cafde5214832fb4ffacd582344631ac5053e71","user":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars.githubusercontent.com/u/9746249?v=3","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"repo":{"id":2907031,"name":"Cockatrice","full_name":"Cockatrice/Cockatrice","owner":{"login":"Cockatrice","id":9746249,"avatar_url":"https://avatars.githubusercontent.com/u/9746249?v=3","gravatar_id":"","url":"https://api.github.com/users/Cockatrice","html_url":"https://github.com/Cockatrice","followers_url":"https://api.github.com/users/Cockatrice/followers","following_url":"https://api.github.com/users/Cockatrice/following{/other_user}","gists_url":"https://api.github.com/users/Cockatrice/gists{/gist_id}","starred_url":"https://api.github.com/users/Cockatrice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cockatrice/subscriptions","organizations_url":"https://api.github.com/users/Cockatrice/orgs","repos_url":"https://api.github.com/users/Cockatrice/repos","events_url":"https://api.github.com/users/Cockatrice/events{/privacy}","received_events_url":"https://api.github.com/users/Cockatrice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Cockatrice/Cockatrice","description":"A cross-platform virtual tabletop for multiplayer card games","fork":false,"url":"https://api.github.com/repos/Cockatrice/Cockatrice","forks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/forks","keys_url":"https://api.github.com/repos/Cockatrice/Cockatrice/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Cockatrice/Cockatrice/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Cockatrice/Cockatrice/teams","hooks_url":"https://api.github.com/repos/Cockatrice/Cockatrice/hooks","issue_events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/events{/number}","events_url":"https://api.github.com/repos/Cockatrice/Cockatrice/events","assignees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/assignees{/user}","branches_url":"https://api.github.com/repos/Cockatrice/Cockatrice/branches{/branch}","tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/tags","blobs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/refs{/sha}","trees_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/{sha}","languages_url":"https://api.github.com/repos/Cockatrice/Cockatrice/languages","stargazers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/stargazers","contributors_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contributors","subscribers_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscribers","subscription_url":"https://api.github.com/repos/Cockatrice/Cockatrice/subscription","commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/commits{/sha}","git_commits_url":"https://api.github.com/repos/Cockatrice/Cockatrice/git/commits{/sha}","comments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/comments{/number}","issue_comment_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/comments{/number}","contents_url":"https://api.github.com/repos/Cockatrice/Cockatrice/contents/{+path}","compare_url":"https://api.github.com/repos/Cockatrice/Cockatrice/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Cockatrice/Cockatrice/merges","archive_url":"https://api.github.com/repos/Cockatrice/Cockatrice/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Cockatrice/Cockatrice/downloads","issues_url":"https://api.github.com/repos/Cockatrice/Cockatrice/issues{/number}","pulls_url":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls{/number}","milestones_url":"https://api.github.com/repos/Cockatrice/Cockatrice/milestones{/number}","notifications_url":"https://api.github.com/repos/Cockatrice/Cockatrice/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Cockatrice/Cockatrice/labels{/name}","releases_url":"https://api.github.com/repos/Cockatrice/Cockatrice/releases{/id}","deployments_url":"https://api.github.com/repos/Cockatrice/Cockatrice/deployments","created_at":"2011-12-03T20:58:09Z","updated_at":"2017-02-23T17:25:00Z","pushed_at":"2017-02-24T06:13:43Z","git_url":"git://github.com/Cockatrice/Cockatrice.git","ssh_url":"git@github.com:Cockatrice/Cockatrice.git","clone_url":"https://github.com/Cockatrice/Cockatrice.git","svn_url":"https://github.com/Cockatrice/Cockatrice","homepage":"https://cockatrice.github.io","size":37975,"stargazers_count":492,"watchers_count":492,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":248,"mirror_url":null,"open_issues_count":434,"forks":248,"open_issues":434,"watchers":492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2423"},"html":{"href":"https://github.com/Cockatrice/Cockatrice/pull/2423"},"issue":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/2423"},"comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/issues/2423/comments"},"review_comments":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2423/comments"},"review_comment":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/pulls/2423/commits"},"statuses":{"href":"https://api.github.com/repos/Cockatrice/Cockatrice/statuses/b66c2c6411b3e5582bb097162648e8d63190dd98"}}}}
{"actor":{"display_login":"woogerboy21"}}