{"action":"created","comment":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/152744921","pull_request_review_id":78651452,"id":152744921,"diff_hunk":"@@ -644,9 +674,91 @@ private void resetHeartbeats() {\n     /** Remove the {@code member}'s heartbeat timestamps */\n     void removeMember(MemberImpl member) {\n         heartbeatFailureDetector.remove(member);\n+        if (icmpParallelMode) {\n+            icmpFailureDetector.remove(member);\n+        }\n     }\n \n     void reset() {\n         heartbeatFailureDetector.reset();\n+        if (icmpParallelMode) {\n+            icmpFailureDetector.reset();\n+        }\n+    }\n+\n+    private class PingTask\n+            implements Runnable {\n+\n+        final Member member;\n+\n+        PingTask(Member member) {\n+            this.member = member;\n+        }\n+\n+        public void run() {\n+            try {\n+                Address address = member.getAddress();\n+                logger.warning(format(\"%s will ping %s\", node.getThisAddress(), address));\n+                for (int i = 0; i < MAX_PING_RETRY_COUNT; i++) {\n+                    if (doPing(address)) {\n+                        return;\n+                    }\n+                }\n+                // host not reachable\n+                String reason = format(\"%s could not ping %s\", node.getThisAddress(), address);\n+                logger.warning(reason);\n+                clusterService.suspectMember(member, reason, true);\n+            } catch (Throwable ignored) {\n+                EmptyStatement.ignore(ignored);\n+            }\n+        }\n+\n+        boolean doPing(Address address)\n+                throws IOException {\n+            try {\n+                if (address.getInetAddress().isReachable(null, icmpTtl, icmpTimeoutMillis)) {\n+                    logger.info(format(\"%s pinged %s successfully\", node.getThisAddress(), address));","path":"hazelcast/src/main/java/com/hazelcast/internal/cluster/impl/ClusterHeartbeatManager.java","position":207,"original_position":207,"commit_id":"61f3b5d787700e71f339ea9942e2a57451bb5a90","original_commit_id":"61f3b5d787700e71f339ea9942e2a57451bb5a90","user":{"login":"Holmistr","id":4253850,"avatar_url":"https://avatars0.githubusercontent.com/u/4253850?v=4","gravatar_id":"","url":"https://api.github.com/users/Holmistr","html_url":"https://github.com/Holmistr","followers_url":"https://api.github.com/users/Holmistr/followers","following_url":"https://api.github.com/users/Holmistr/following{/other_user}","gists_url":"https://api.github.com/users/Holmistr/gists{/gist_id}","starred_url":"https://api.github.com/users/Holmistr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Holmistr/subscriptions","organizations_url":"https://api.github.com/users/Holmistr/orgs","repos_url":"https://api.github.com/users/Holmistr/repos","events_url":"https://api.github.com/users/Holmistr/events{/privacy}","received_events_url":"https://api.github.com/users/Holmistr/received_events","type":"User","site_admin":false},"body":"I believe this should not be an INFO level, it's flooding the member's output if working properly.","created_at":"2017-11-23T08:52:23Z","updated_at":"2017-11-23T08:52:23Z","html_url":"https://github.com/hazelcast/hazelcast/pull/11808#discussion_r152744921","pull_request_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11808","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments/152744921"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/11808#discussion_r152744921"},"pull_request":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11808"}}},"pull_request":{"url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11808","id":153077245,"html_url":"https://github.com/hazelcast/hazelcast/pull/11808","diff_url":"https://github.com/hazelcast/hazelcast/pull/11808.diff","patch_url":"https://github.com/hazelcast/hazelcast/pull/11808.patch","issue_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/11808","number":11808,"state":"open","locked":false,"title":"Parallel ping failure detector","user":{"login":"tkountis","id":3369598,"avatar_url":"https://avatars2.githubusercontent.com/u/3369598?v=4","gravatar_id":"","url":"https://api.github.com/users/tkountis","html_url":"https://github.com/tkountis","followers_url":"https://api.github.com/users/tkountis/followers","following_url":"https://api.github.com/users/tkountis/following{/other_user}","gists_url":"https://api.github.com/users/tkountis/gists{/gist_id}","starred_url":"https://api.github.com/users/tkountis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkountis/subscriptions","organizations_url":"https://api.github.com/users/tkountis/orgs","repos_url":"https://api.github.com/users/tkountis/repos","events_url":"https://api.github.com/users/tkountis/events{/privacy}","received_events_url":"https://api.github.com/users/tkountis/received_events","type":"User","site_admin":false},"body":"Introduce parallel ping failure detector\r\n\r\n- [x] JavaDoc\r\n- [x] Documentation (https://github.com/hazelcast/hazelcast-reference-manual/pull/432)\r\n- [x] Decide on the ping details and if fail-fast is needed\r\n- [x] Tests\r\n- [x] Feature toggle, to keep old behavior by default","created_at":"2017-11-16T15:50:56Z","updated_at":"2017-11-23T08:52:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0188e507d0d82a13b9e70b9028eddfd03d421a83","assignee":{"login":"tkountis","id":3369598,"avatar_url":"https://avatars2.githubusercontent.com/u/3369598?v=4","gravatar_id":"","url":"https://api.github.com/users/tkountis","html_url":"https://github.com/tkountis","followers_url":"https://api.github.com/users/tkountis/followers","following_url":"https://api.github.com/users/tkountis/following{/other_user}","gists_url":"https://api.github.com/users/tkountis/gists{/gist_id}","starred_url":"https://api.github.com/users/tkountis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkountis/subscriptions","organizations_url":"https://api.github.com/users/tkountis/orgs","repos_url":"https://api.github.com/users/tkountis/repos","events_url":"https://api.github.com/users/tkountis/events{/privacy}","received_events_url":"https://api.github.com/users/tkountis/received_events","type":"User","site_admin":false},"assignees":[{"login":"tkountis","id":3369598,"avatar_url":"https://avatars2.githubusercontent.com/u/3369598?v=4","gravatar_id":"","url":"https://api.github.com/users/tkountis","html_url":"https://github.com/tkountis","followers_url":"https://api.github.com/users/tkountis/followers","following_url":"https://api.github.com/users/tkountis/following{/other_user}","gists_url":"https://api.github.com/users/tkountis/gists{/gist_id}","starred_url":"https://api.github.com/users/tkountis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkountis/subscriptions","organizations_url":"https://api.github.com/users/tkountis/orgs","repos_url":"https://api.github.com/users/tkountis/repos","events_url":"https://api.github.com/users/tkountis/events{/privacy}","received_events_url":"https://api.github.com/users/tkountis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/101","html_url":"https://github.com/hazelcast/hazelcast/milestone/101","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones/101/labels","id":2708218,"number":101,"title":"3.9.1","description":null,"creator":{"login":"jerrinot","id":158619,"avatar_url":"https://avatars1.githubusercontent.com/u/158619?v=4","gravatar_id":"","url":"https://api.github.com/users/jerrinot","html_url":"https://github.com/jerrinot","followers_url":"https://api.github.com/users/jerrinot/followers","following_url":"https://api.github.com/users/jerrinot/following{/other_user}","gists_url":"https://api.github.com/users/jerrinot/gists{/gist_id}","starred_url":"https://api.github.com/users/jerrinot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerrinot/subscriptions","organizations_url":"https://api.github.com/users/jerrinot/orgs","repos_url":"https://api.github.com/users/jerrinot/repos","events_url":"https://api.github.com/users/jerrinot/events{/privacy}","received_events_url":"https://api.github.com/users/jerrinot/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":62,"state":"open","created_at":"2017-08-17T22:03:13Z","updated_at":"2017-11-23T07:45:21Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11808/commits","review_comments_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11808/comments","review_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/11808/comments","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/61f3b5d787700e71f339ea9942e2a57451bb5a90","head":{"label":"tkountis:feature/3.10/icmp-isreachable","ref":"feature/3.10/icmp-isreachable","sha":"61f3b5d787700e71f339ea9942e2a57451bb5a90","user":{"login":"tkountis","id":3369598,"avatar_url":"https://avatars2.githubusercontent.com/u/3369598?v=4","gravatar_id":"","url":"https://api.github.com/users/tkountis","html_url":"https://github.com/tkountis","followers_url":"https://api.github.com/users/tkountis/followers","following_url":"https://api.github.com/users/tkountis/following{/other_user}","gists_url":"https://api.github.com/users/tkountis/gists{/gist_id}","starred_url":"https://api.github.com/users/tkountis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkountis/subscriptions","organizations_url":"https://api.github.com/users/tkountis/orgs","repos_url":"https://api.github.com/users/tkountis/repos","events_url":"https://api.github.com/users/tkountis/events{/privacy}","received_events_url":"https://api.github.com/users/tkountis/received_events","type":"User","site_admin":false},"repo":{"id":66834097,"name":"hazelcast","full_name":"tkountis/hazelcast","owner":{"login":"tkountis","id":3369598,"avatar_url":"https://avatars2.githubusercontent.com/u/3369598?v=4","gravatar_id":"","url":"https://api.github.com/users/tkountis","html_url":"https://github.com/tkountis","followers_url":"https://api.github.com/users/tkountis/followers","following_url":"https://api.github.com/users/tkountis/following{/other_user}","gists_url":"https://api.github.com/users/tkountis/gists{/gist_id}","starred_url":"https://api.github.com/users/tkountis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkountis/subscriptions","organizations_url":"https://api.github.com/users/tkountis/orgs","repos_url":"https://api.github.com/users/tkountis/repos","events_url":"https://api.github.com/users/tkountis/events{/privacy}","received_events_url":"https://api.github.com/users/tkountis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tkountis/hazelcast","description":"Open Source In-Memory Data Grid","fork":true,"url":"https://api.github.com/repos/tkountis/hazelcast","forks_url":"https://api.github.com/repos/tkountis/hazelcast/forks","keys_url":"https://api.github.com/repos/tkountis/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tkountis/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tkountis/hazelcast/teams","hooks_url":"https://api.github.com/repos/tkountis/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/tkountis/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/tkountis/hazelcast/events","assignees_url":"https://api.github.com/repos/tkountis/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/tkountis/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/tkountis/hazelcast/tags","blobs_url":"https://api.github.com/repos/tkountis/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tkountis/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tkountis/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/tkountis/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tkountis/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/tkountis/hazelcast/languages","stargazers_url":"https://api.github.com/repos/tkountis/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/tkountis/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/tkountis/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/tkountis/hazelcast/subscription","commits_url":"https://api.github.com/repos/tkountis/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/tkountis/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/tkountis/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/tkountis/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/tkountis/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/tkountis/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tkountis/hazelcast/merges","archive_url":"https://api.github.com/repos/tkountis/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tkountis/hazelcast/downloads","issues_url":"https://api.github.com/repos/tkountis/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/tkountis/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/tkountis/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/tkountis/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tkountis/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/tkountis/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/tkountis/hazelcast/deployments","created_at":"2016-08-29T10:27:48Z","updated_at":"2016-08-29T10:28:03Z","pushed_at":"2017-11-22T16:56:52Z","git_url":"git://github.com/tkountis/hazelcast.git","ssh_url":"git@github.com:tkountis/hazelcast.git","clone_url":"https://github.com/tkountis/hazelcast.git","svn_url":"https://github.com/tkountis/hazelcast","homepage":"www.hazelcast.com","size":117685,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hazelcast:master","ref":"master","sha":"f4bb883b96328e0e64da17e571ede0569d9bcc02","user":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"repo":{"id":3786237,"name":"hazelcast","full_name":"hazelcast/hazelcast","owner":{"login":"hazelcast","id":1453152,"avatar_url":"https://avatars2.githubusercontent.com/u/1453152?v=4","gravatar_id":"","url":"https://api.github.com/users/hazelcast","html_url":"https://github.com/hazelcast","followers_url":"https://api.github.com/users/hazelcast/followers","following_url":"https://api.github.com/users/hazelcast/following{/other_user}","gists_url":"https://api.github.com/users/hazelcast/gists{/gist_id}","starred_url":"https://api.github.com/users/hazelcast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hazelcast/subscriptions","organizations_url":"https://api.github.com/users/hazelcast/orgs","repos_url":"https://api.github.com/users/hazelcast/repos","events_url":"https://api.github.com/users/hazelcast/events{/privacy}","received_events_url":"https://api.github.com/users/hazelcast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hazelcast/hazelcast","description":"Open Source In-Memory Data Grid","fork":false,"url":"https://api.github.com/repos/hazelcast/hazelcast","forks_url":"https://api.github.com/repos/hazelcast/hazelcast/forks","keys_url":"https://api.github.com/repos/hazelcast/hazelcast/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hazelcast/hazelcast/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hazelcast/hazelcast/teams","hooks_url":"https://api.github.com/repos/hazelcast/hazelcast/hooks","issue_events_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/events{/number}","events_url":"https://api.github.com/repos/hazelcast/hazelcast/events","assignees_url":"https://api.github.com/repos/hazelcast/hazelcast/assignees{/user}","branches_url":"https://api.github.com/repos/hazelcast/hazelcast/branches{/branch}","tags_url":"https://api.github.com/repos/hazelcast/hazelcast/tags","blobs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hazelcast/hazelcast/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hazelcast/hazelcast/git/refs{/sha}","trees_url":"https://api.github.com/repos/hazelcast/hazelcast/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hazelcast/hazelcast/statuses/{sha}","languages_url":"https://api.github.com/repos/hazelcast/hazelcast/languages","stargazers_url":"https://api.github.com/repos/hazelcast/hazelcast/stargazers","contributors_url":"https://api.github.com/repos/hazelcast/hazelcast/contributors","subscribers_url":"https://api.github.com/repos/hazelcast/hazelcast/subscribers","subscription_url":"https://api.github.com/repos/hazelcast/hazelcast/subscription","commits_url":"https://api.github.com/repos/hazelcast/hazelcast/commits{/sha}","git_commits_url":"https://api.github.com/repos/hazelcast/hazelcast/git/commits{/sha}","comments_url":"https://api.github.com/repos/hazelcast/hazelcast/comments{/number}","issue_comment_url":"https://api.github.com/repos/hazelcast/hazelcast/issues/comments{/number}","contents_url":"https://api.github.com/repos/hazelcast/hazelcast/contents/{+path}","compare_url":"https://api.github.com/repos/hazelcast/hazelcast/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hazelcast/hazelcast/merges","archive_url":"https://api.github.com/repos/hazelcast/hazelcast/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hazelcast/hazelcast/downloads","issues_url":"https://api.github.com/repos/hazelcast/hazelcast/issues{/number}","pulls_url":"https://api.github.com/repos/hazelcast/hazelcast/pulls{/number}","milestones_url":"https://api.github.com/repos/hazelcast/hazelcast/milestones{/number}","notifications_url":"https://api.github.com/repos/hazelcast/hazelcast/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hazelcast/hazelcast/labels{/name}","releases_url":"https://api.github.com/repos/hazelcast/hazelcast/releases{/id}","deployments_url":"https://api.github.com/repos/hazelcast/hazelcast/deployments","created_at":"2012-03-21T12:25:18Z","updated_at":"2017-11-22T09:49:30Z","pushed_at":"2017-11-23T06:51:21Z","git_url":"git://github.com/hazelcast/hazelcast.git","ssh_url":"git@github.com:hazelcast/hazelcast.git","clone_url":"https://github.com/hazelcast/hazelcast.git","svn_url":"https://github.com/hazelcast/hazelcast","homepage":"http://www.hazelcast.org","size":118136,"stargazers_count":2314,"watchers_count":2314,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":953,"mirror_url":null,"archived":false,"open_issues_count":656,"forks":953,"open_issues":656,"watchers":2314,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11808"},"html":{"href":"https://github.com/hazelcast/hazelcast/pull/11808"},"issue":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/11808"},"comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/issues/11808/comments"},"review_comments":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11808/comments"},"review_comment":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hazelcast/hazelcast/pulls/11808/commits"},"statuses":{"href":"https://api.github.com/repos/hazelcast/hazelcast/statuses/61f3b5d787700e71f339ea9942e2a57451bb5a90"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Holmistr"}}