{"action":"created","comment":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/116469255","pull_request_review_id":38092441,"id":116469255,"diff_hunk":"@@ -238,40 +239,10 @@ qulonglong Utils::Fs::freeDiskSpaceOnPath(const QString &path)\n {","path":"src/base/utils/fs.cpp","position":9,"original_position":9,"commit_id":"f364835a6bbc57e75d28a3d6d542dad4d64d2474","original_commit_id":"f364835a6bbc57e75d28a3d6d542dad4d64d2474","user":{"login":"KingLucius","id":17493070,"avatar_url":"https://avatars1.githubusercontent.com/u/17493070?v=3","gravatar_id":"","url":"https://api.github.com/users/KingLucius","html_url":"https://github.com/KingLucius","followers_url":"https://api.github.com/users/KingLucius/followers","following_url":"https://api.github.com/users/KingLucius/following{/other_user}","gists_url":"https://api.github.com/users/KingLucius/gists{/gist_id}","starred_url":"https://api.github.com/users/KingLucius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingLucius/subscriptions","organizations_url":"https://api.github.com/users/KingLucius/orgs","repos_url":"https://api.github.com/users/KingLucius/repos","events_url":"https://api.github.com/users/KingLucius/events{/privacy}","received_events_url":"https://api.github.com/users/KingLucius/received_events","type":"User","site_admin":false},"body":"I make it return 0 but cause the old check for empty path which returns 0\r\nQStorageInfo::bytesAvailable already returns -1 on failure.\r\n-1 will cause (unknown) when friendly convert it using \"friendlyunit\" method.\r\nSorry for not quoting the code, I am currently using mobile.","created_at":"2017-05-15T11:43:07Z","updated_at":"2017-05-15T11:43:07Z","html_url":"https://github.com/qbittorrent/qBittorrent/pull/6785#discussion_r116469255","pull_request_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/6785","_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments/116469255"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/6785#discussion_r116469255"},"pull_request":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/6785"}}},"pull_request":{"url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/6785","id":120499604,"html_url":"https://github.com/qbittorrent/qBittorrent/pull/6785","diff_url":"https://github.com/qbittorrent/qBittorrent/pull/6785.diff","patch_url":"https://github.com/qbittorrent/qBittorrent/pull/6785.patch","issue_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/6785","number":6785,"state":"open","locked":false,"title":"cross-platform free space on disk (Closes #6780)","user":{"login":"KingLucius","id":17493070,"avatar_url":"https://avatars1.githubusercontent.com/u/17493070?v=3","gravatar_id":"","url":"https://api.github.com/users/KingLucius","html_url":"https://github.com/KingLucius","followers_url":"https://api.github.com/users/KingLucius/followers","following_url":"https://api.github.com/users/KingLucius/following{/other_user}","gists_url":"https://api.github.com/users/KingLucius/gists{/gist_id}","starred_url":"https://api.github.com/users/KingLucius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingLucius/subscriptions","organizations_url":"https://api.github.com/users/KingLucius/orgs","repos_url":"https://api.github.com/users/KingLucius/repos","events_url":"https://api.github.com/users/KingLucius/events{/privacy}","received_events_url":"https://api.github.com/users/KingLucius/received_events","type":"User","site_admin":false},"body":"Uses [QStorageInfo](https://doc.qt.io/qt-5/qstorageinfo.html) Instead of using native APIs/#if for each platform.","created_at":"2017-05-14T19:56:12Z","updated_at":"2017-05-15T11:43:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96590ff46315c3ffab972ade3c44c90c39709bc4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/6785/commits","review_comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/6785/comments","review_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/6785/comments","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/f364835a6bbc57e75d28a3d6d542dad4d64d2474","head":{"label":"KingLucius:freespaceondisk","ref":"freespaceondisk","sha":"f364835a6bbc57e75d28a3d6d542dad4d64d2474","user":{"login":"KingLucius","id":17493070,"avatar_url":"https://avatars1.githubusercontent.com/u/17493070?v=3","gravatar_id":"","url":"https://api.github.com/users/KingLucius","html_url":"https://github.com/KingLucius","followers_url":"https://api.github.com/users/KingLucius/followers","following_url":"https://api.github.com/users/KingLucius/following{/other_user}","gists_url":"https://api.github.com/users/KingLucius/gists{/gist_id}","starred_url":"https://api.github.com/users/KingLucius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingLucius/subscriptions","organizations_url":"https://api.github.com/users/KingLucius/orgs","repos_url":"https://api.github.com/users/KingLucius/repos","events_url":"https://api.github.com/users/KingLucius/events{/privacy}","received_events_url":"https://api.github.com/users/KingLucius/received_events","type":"User","site_admin":false},"repo":{"id":91207403,"name":"qBittorrent","full_name":"KingLucius/qBittorrent","owner":{"login":"KingLucius","id":17493070,"avatar_url":"https://avatars1.githubusercontent.com/u/17493070?v=3","gravatar_id":"","url":"https://api.github.com/users/KingLucius","html_url":"https://github.com/KingLucius","followers_url":"https://api.github.com/users/KingLucius/followers","following_url":"https://api.github.com/users/KingLucius/following{/other_user}","gists_url":"https://api.github.com/users/KingLucius/gists{/gist_id}","starred_url":"https://api.github.com/users/KingLucius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KingLucius/subscriptions","organizations_url":"https://api.github.com/users/KingLucius/orgs","repos_url":"https://api.github.com/users/KingLucius/repos","events_url":"https://api.github.com/users/KingLucius/events{/privacy}","received_events_url":"https://api.github.com/users/KingLucius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KingLucius/qBittorrent","description":"qBittorrent BitTorrent client","fork":true,"url":"https://api.github.com/repos/KingLucius/qBittorrent","forks_url":"https://api.github.com/repos/KingLucius/qBittorrent/forks","keys_url":"https://api.github.com/repos/KingLucius/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KingLucius/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KingLucius/qBittorrent/teams","hooks_url":"https://api.github.com/repos/KingLucius/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/KingLucius/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/KingLucius/qBittorrent/events","assignees_url":"https://api.github.com/repos/KingLucius/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/KingLucius/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/KingLucius/qBittorrent/tags","blobs_url":"https://api.github.com/repos/KingLucius/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KingLucius/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KingLucius/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/KingLucius/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KingLucius/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/KingLucius/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/KingLucius/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/KingLucius/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/KingLucius/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/KingLucius/qBittorrent/subscription","commits_url":"https://api.github.com/repos/KingLucius/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/KingLucius/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/KingLucius/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/KingLucius/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/KingLucius/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/KingLucius/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KingLucius/qBittorrent/merges","archive_url":"https://api.github.com/repos/KingLucius/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KingLucius/qBittorrent/downloads","issues_url":"https://api.github.com/repos/KingLucius/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/KingLucius/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/KingLucius/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/KingLucius/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KingLucius/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/KingLucius/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/KingLucius/qBittorrent/deployments","created_at":"2017-05-13T22:58:45Z","updated_at":"2017-05-13T22:58:50Z","pushed_at":"2017-05-14T22:01:56Z","git_url":"git://github.com/KingLucius/qBittorrent.git","ssh_url":"git@github.com:KingLucius/qBittorrent.git","clone_url":"https://github.com/KingLucius/qBittorrent.git","svn_url":"https://github.com/KingLucius/qBittorrent","homepage":"http://www.qbittorrent.org","size":148134,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qbittorrent:master","ref":"master","sha":"a2d5d48affb46abc66672e9328eeda070dcde661","user":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars1.githubusercontent.com/u/2131270?v=3","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"repo":{"id":3351871,"name":"qBittorrent","full_name":"qbittorrent/qBittorrent","owner":{"login":"qbittorrent","id":2131270,"avatar_url":"https://avatars1.githubusercontent.com/u/2131270?v=3","gravatar_id":"","url":"https://api.github.com/users/qbittorrent","html_url":"https://github.com/qbittorrent","followers_url":"https://api.github.com/users/qbittorrent/followers","following_url":"https://api.github.com/users/qbittorrent/following{/other_user}","gists_url":"https://api.github.com/users/qbittorrent/gists{/gist_id}","starred_url":"https://api.github.com/users/qbittorrent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qbittorrent/subscriptions","organizations_url":"https://api.github.com/users/qbittorrent/orgs","repos_url":"https://api.github.com/users/qbittorrent/repos","events_url":"https://api.github.com/users/qbittorrent/events{/privacy}","received_events_url":"https://api.github.com/users/qbittorrent/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qbittorrent/qBittorrent","description":"qBittorrent BitTorrent client","fork":false,"url":"https://api.github.com/repos/qbittorrent/qBittorrent","forks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/forks","keys_url":"https://api.github.com/repos/qbittorrent/qBittorrent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qbittorrent/qBittorrent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qbittorrent/qBittorrent/teams","hooks_url":"https://api.github.com/repos/qbittorrent/qBittorrent/hooks","issue_events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/events{/number}","events_url":"https://api.github.com/repos/qbittorrent/qBittorrent/events","assignees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/assignees{/user}","branches_url":"https://api.github.com/repos/qbittorrent/qBittorrent/branches{/branch}","tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/tags","blobs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/refs{/sha}","trees_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/{sha}","languages_url":"https://api.github.com/repos/qbittorrent/qBittorrent/languages","stargazers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/stargazers","contributors_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contributors","subscribers_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscribers","subscription_url":"https://api.github.com/repos/qbittorrent/qBittorrent/subscription","commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/commits{/sha}","git_commits_url":"https://api.github.com/repos/qbittorrent/qBittorrent/git/commits{/sha}","comments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/comments{/number}","issue_comment_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/comments{/number}","contents_url":"https://api.github.com/repos/qbittorrent/qBittorrent/contents/{+path}","compare_url":"https://api.github.com/repos/qbittorrent/qBittorrent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qbittorrent/qBittorrent/merges","archive_url":"https://api.github.com/repos/qbittorrent/qBittorrent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qbittorrent/qBittorrent/downloads","issues_url":"https://api.github.com/repos/qbittorrent/qBittorrent/issues{/number}","pulls_url":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls{/number}","milestones_url":"https://api.github.com/repos/qbittorrent/qBittorrent/milestones{/number}","notifications_url":"https://api.github.com/repos/qbittorrent/qBittorrent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qbittorrent/qBittorrent/labels{/name}","releases_url":"https://api.github.com/repos/qbittorrent/qBittorrent/releases{/id}","deployments_url":"https://api.github.com/repos/qbittorrent/qBittorrent/deployments","created_at":"2012-02-04T09:37:46Z","updated_at":"2017-05-14T21:38:48Z","pushed_at":"2017-05-15T08:12:35Z","git_url":"git://github.com/qbittorrent/qBittorrent.git","ssh_url":"git@github.com:qbittorrent/qBittorrent.git","clone_url":"https://github.com/qbittorrent/qBittorrent.git","svn_url":"https://github.com/qbittorrent/qBittorrent","homepage":"http://www.qbittorrent.org","size":148148,"stargazers_count":2517,"watchers_count":2517,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":602,"mirror_url":null,"open_issues_count":2059,"forks":602,"open_issues":2059,"watchers":2517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/6785"},"html":{"href":"https://github.com/qbittorrent/qBittorrent/pull/6785"},"issue":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/6785"},"comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/issues/6785/comments"},"review_comments":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/6785/comments"},"review_comment":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/pulls/6785/commits"},"statuses":{"href":"https://api.github.com/repos/qbittorrent/qBittorrent/statuses/f364835a6bbc57e75d28a3d6d542dad4d64d2474"}}}}
{"actor":{"display_login":"KingLucius"}}