{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/149350164","pull_request_review_id":74723972,"id":149350164,"diff_hunk":"@@ -295,91 +377,107 @@ void show_goto_trace(\n       break;\n \n     case goto_trace_stept::typet::ASSIGNMENT:\n-      if(step.pc->is_assign() ||\n-         step.pc->is_return() || // returns have a lhs!\n-         step.pc->is_function_call() ||\n-         (step.pc->is_other() && step.lhs_object.is_not_nil()))\n+      if(config.trace_config.show_value_assignments)\n       {\n-        if(prev_step_nr!=step.step_nr || first_step)\n+        if(step.pc->is_assign() || step.pc->is_return()\n+            || // returns have a lhs!\n+            step.pc->is_function_call()\n+            || (step.pc->is_other() && step.lhs_object.is_not_nil()))\n         {\n-          first_step=false;\n-          prev_step_nr=step.step_nr;\n-          show_state_header(out, step, step.pc->source_location, step.step_nr);\n+          if(prev_step_nr != step.step_nr || first_step)\n+          {\n+            first_step = false;\n+            prev_step_nr = step.step_nr;\n+            show_state_header(out, ns, step);\n+          }\n+          trace_value(out, ns, step);\n         }\n-\n-        // see if the full lhs is something clean\n-        if(is_index_member_symbol(step.full_lhs))\n-          trace_value(\n-            out, ns, step.lhs_object, step.full_lhs, step.full_lhs_value);\n-        else\n-          trace_value(\n-            out, ns, step.lhs_object, step.lhs_object, step.lhs_object_value);\n       }\n       break;\n \n     case goto_trace_stept::typet::DECL:\n-      if(prev_step_nr!=step.step_nr || first_step)\n+      if(config.trace_config.show_value_assignments)","path":"src/goto-programs/goto_trace.cpp","position":340,"original_position":340,"commit_id":"94391c1901b0319d1b55fdd30d59884dd268d5f1","original_commit_id":"94391c1901b0319d1b55fdd30d59884dd268d5f1","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars3.githubusercontent.com/u/283483?v=4","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"body":"Similar","created_at":"2017-11-07T12:19:19Z","updated_at":"2017-11-07T12:32:32Z","html_url":"https://github.com/diffblue/cbmc/pull/1565#discussion_r149350164","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1565","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/149350164"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1565#discussion_r149350164"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1565"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1565","id":151087735,"html_url":"https://github.com/diffblue/cbmc/pull/1565","diff_url":"https://github.com/diffblue/cbmc/pull/1565.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1565.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1565","number":1565,"state":"open","locked":false,"title":"Trace output configuration options","user":{"login":"polgreen","id":17899331,"avatar_url":"https://avatars3.githubusercontent.com/u/17899331?v=4","gravatar_id":"","url":"https://api.github.com/users/polgreen","html_url":"https://github.com/polgreen","followers_url":"https://api.github.com/users/polgreen/followers","following_url":"https://api.github.com/users/polgreen/following{/other_user}","gists_url":"https://api.github.com/users/polgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/polgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polgreen/subscriptions","organizations_url":"https://api.github.com/users/polgreen/orgs","repos_url":"https://api.github.com/users/polgreen/repos","events_url":"https://api.github.com/users/polgreen/events{/privacy}","received_events_url":"https://api.github.com/users/polgreen/received_events","type":"User","site_admin":false},"body":"This pull request adds the following configuration options for the trace output:\r\n\r\n--trace-show-function-calls  show functions calls and returns in trace (default is to hide)\r\n--trace-hide-assignments     hide all assignments in trace (default is to show)\r\n--trace-hide-inputs          hide all inputs in trace (default is to show)\r\n--trace-hide-outputs         hide all outputs in trace (default is to show)\r\n--trace-show-source-code     show lines of source code (default is to hide)\r\n--trace-hex                  outputs assignments to variables in hex (default is binary)\r\n--trace-html                 outputs trace in html format\r\n\r\nThe default, if no command line options are used, maintains the same output as before. The xml and json outputs are unaffected.","created_at":"2017-11-07T11:24:21Z","updated_at":"2017-11-07T12:32:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"107b3f56e476c49376fda38caa4203741640fad0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars3.githubusercontent.com/u/1144736?v=4","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},{"login":"kroening","id":1830565,"avatar_url":"https://avatars0.githubusercontent.com/u/1830565?v=4","gravatar_id":"","url":"https://api.github.com/users/kroening","html_url":"https://github.com/kroening","followers_url":"https://api.github.com/users/kroening/followers","following_url":"https://api.github.com/users/kroening/following{/other_user}","gists_url":"https://api.github.com/users/kroening/gists{/gist_id}","starred_url":"https://api.github.com/users/kroening/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroening/subscriptions","organizations_url":"https://api.github.com/users/kroening/orgs","repos_url":"https://api.github.com/users/kroening/repos","events_url":"https://api.github.com/users/kroening/events{/privacy}","received_events_url":"https://api.github.com/users/kroening/received_events","type":"User","site_admin":false},{"login":"peterschrammel","id":4222448,"avatar_url":"https://avatars3.githubusercontent.com/u/4222448?v=4","gravatar_id":"","url":"https://api.github.com/users/peterschrammel","html_url":"https://github.com/peterschrammel","followers_url":"https://api.github.com/users/peterschrammel/followers","following_url":"https://api.github.com/users/peterschrammel/following{/other_user}","gists_url":"https://api.github.com/users/peterschrammel/gists{/gist_id}","starred_url":"https://api.github.com/users/peterschrammel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peterschrammel/subscriptions","organizations_url":"https://api.github.com/users/peterschrammel/orgs","repos_url":"https://api.github.com/users/peterschrammel/repos","events_url":"https://api.github.com/users/peterschrammel/events{/privacy}","received_events_url":"https://api.github.com/users/peterschrammel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1565/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1565/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1565/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/94391c1901b0319d1b55fdd30d59884dd268d5f1","head":{"label":"polgreen:trace_output","ref":"trace_output","sha":"94391c1901b0319d1b55fdd30d59884dd268d5f1","user":{"login":"polgreen","id":17899331,"avatar_url":"https://avatars3.githubusercontent.com/u/17899331?v=4","gravatar_id":"","url":"https://api.github.com/users/polgreen","html_url":"https://github.com/polgreen","followers_url":"https://api.github.com/users/polgreen/followers","following_url":"https://api.github.com/users/polgreen/following{/other_user}","gists_url":"https://api.github.com/users/polgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/polgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polgreen/subscriptions","organizations_url":"https://api.github.com/users/polgreen/orgs","repos_url":"https://api.github.com/users/polgreen/repos","events_url":"https://api.github.com/users/polgreen/events{/privacy}","received_events_url":"https://api.github.com/users/polgreen/received_events","type":"User","site_admin":false},"repo":{"id":97494073,"name":"cbmc","full_name":"polgreen/cbmc","owner":{"login":"polgreen","id":17899331,"avatar_url":"https://avatars3.githubusercontent.com/u/17899331?v=4","gravatar_id":"","url":"https://api.github.com/users/polgreen","html_url":"https://github.com/polgreen","followers_url":"https://api.github.com/users/polgreen/followers","following_url":"https://api.github.com/users/polgreen/following{/other_user}","gists_url":"https://api.github.com/users/polgreen/gists{/gist_id}","starred_url":"https://api.github.com/users/polgreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/polgreen/subscriptions","organizations_url":"https://api.github.com/users/polgreen/orgs","repos_url":"https://api.github.com/users/polgreen/repos","events_url":"https://api.github.com/users/polgreen/events{/privacy}","received_events_url":"https://api.github.com/users/polgreen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/polgreen/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/polgreen/cbmc","forks_url":"https://api.github.com/repos/polgreen/cbmc/forks","keys_url":"https://api.github.com/repos/polgreen/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/polgreen/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/polgreen/cbmc/teams","hooks_url":"https://api.github.com/repos/polgreen/cbmc/hooks","issue_events_url":"https://api.github.com/repos/polgreen/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/polgreen/cbmc/events","assignees_url":"https://api.github.com/repos/polgreen/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/polgreen/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/polgreen/cbmc/tags","blobs_url":"https://api.github.com/repos/polgreen/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/polgreen/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/polgreen/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/polgreen/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/polgreen/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/polgreen/cbmc/languages","stargazers_url":"https://api.github.com/repos/polgreen/cbmc/stargazers","contributors_url":"https://api.github.com/repos/polgreen/cbmc/contributors","subscribers_url":"https://api.github.com/repos/polgreen/cbmc/subscribers","subscription_url":"https://api.github.com/repos/polgreen/cbmc/subscription","commits_url":"https://api.github.com/repos/polgreen/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/polgreen/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/polgreen/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/polgreen/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/polgreen/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/polgreen/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/polgreen/cbmc/merges","archive_url":"https://api.github.com/repos/polgreen/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/polgreen/cbmc/downloads","issues_url":"https://api.github.com/repos/polgreen/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/polgreen/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/polgreen/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/polgreen/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/polgreen/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/polgreen/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/polgreen/cbmc/deployments","created_at":"2017-07-17T15:52:09Z","updated_at":"2017-07-17T15:52:17Z","pushed_at":"2017-11-07T11:56:43Z","git_url":"git://github.com/polgreen/cbmc.git","ssh_url":"git@github.com:polgreen/cbmc.git","clone_url":"https://github.com/polgreen/cbmc.git","svn_url":"https://github.com/polgreen/cbmc","homepage":"http://www.cprover.org/cbmc","size":28429,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:develop","ref":"develop","sha":"0361c2af6d709ef593828ca6b99df0fa09c87a5f","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars0.githubusercontent.com/u/17216098?v=4","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2017-11-02T11:40:08Z","pushed_at":"2017-11-07T11:56:45Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":26408,"stargazers_count":80,"watchers_count":80,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":75,"mirror_url":null,"archived":false,"open_issues_count":259,"forks":75,"open_issues":259,"watchers":80,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1565"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1565"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1565"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1565/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1565/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1565/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/94391c1901b0319d1b55fdd30d59884dd268d5f1"}},"author_association":"NONE"}}
{"actor":{"display_login":"smowton"}}