{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/comments/122501406","pull_request_review_id":44627866,"id":122501406,"diff_hunk":"@@ -518,9 +518,9 @@\n                         (:uri %) (:remoteaddress %)))))))))\n \n (defn- on-error\n-  \"OnError WebSocket event handler. Just log the event.\"\n+  \"OnError WebSocket event handler. Just log the event if the connection is active that is.\"","path":"src/puppetlabs/pcp/broker/core.clj","position":5,"original_position":5,"commit_id":"376ff12e3e4f4c1efee1a40c8b810b4b8261130f","original_commit_id":"376ff12e3e4f4c1efee1a40c8b810b4b8261130f","user":{"login":"MikaelSmith","id":8162496,"avatar_url":"https://avatars3.githubusercontent.com/u/8162496?v=3","gravatar_id":"","url":"https://api.github.com/users/MikaelSmith","html_url":"https://github.com/MikaelSmith","followers_url":"https://api.github.com/users/MikaelSmith/followers","following_url":"https://api.github.com/users/MikaelSmith/following{/other_user}","gists_url":"https://api.github.com/users/MikaelSmith/gists{/gist_id}","starred_url":"https://api.github.com/users/MikaelSmith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MikaelSmith/subscriptions","organizations_url":"https://api.github.com/users/MikaelSmith/orgs","repos_url":"https://api.github.com/users/MikaelSmith/repos","events_url":"https://api.github.com/users/MikaelSmith/events{/privacy}","received_events_url":"https://api.github.com/users/MikaelSmith/received_events","type":"User","site_admin":false},"body":"Sentence reads a bit funny. Maybe rephrase to \"Log the event if the connection is active.\"","created_at":"2017-06-16T18:09:27Z","updated_at":"2017-06-16T18:09:27Z","html_url":"https://github.com/puppetlabs/pcp-broker/pull/197#discussion_r122501406","pull_request_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/197","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/comments/122501406"},"html":{"href":"https://github.com/puppetlabs/pcp-broker/pull/197#discussion_r122501406"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/197"}}},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/197","id":126051064,"html_url":"https://github.com/puppetlabs/pcp-broker/pull/197","diff_url":"https://github.com/puppetlabs/pcp-broker/pull/197.diff","patch_url":"https://github.com/puppetlabs/pcp-broker/pull/197.patch","issue_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/197","number":197,"state":"open","locked":false,"title":"(PCP-737) Ignore stale connection errors","user":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars3.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"body":"This PR makes sure errors on stale websocket connections are ignored. A stale connection in this context means a connection which is not present in the broker's inventory any longer.\r\nPreviously it was not the case which could lead to validation errors when there was an attempt to log the connection details for connection which was not found in the broker's inventory.","created_at":"2017-06-16T14:56:15Z","updated_at":"2017-06-16T18:09:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e4a0eafb2d67d395c187b0b24a09bbe5eed747e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/197/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/197/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/197/comments","statuses_url":"https://api.github.com/repos/puppetlabs/pcp-broker/statuses/376ff12e3e4f4c1efee1a40c8b810b4b8261130f","head":{"label":"mruzicka:PCP-737_ignore_stale_connection_errors","ref":"PCP-737_ignore_stale_connection_errors","sha":"376ff12e3e4f4c1efee1a40c8b810b4b8261130f","user":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars3.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"repo":{"id":51078298,"name":"pcp-broker","full_name":"mruzicka/pcp-broker","owner":{"login":"mruzicka","id":562920,"avatar_url":"https://avatars3.githubusercontent.com/u/562920?v=3","gravatar_id":"","url":"https://api.github.com/users/mruzicka","html_url":"https://github.com/mruzicka","followers_url":"https://api.github.com/users/mruzicka/followers","following_url":"https://api.github.com/users/mruzicka/following{/other_user}","gists_url":"https://api.github.com/users/mruzicka/gists{/gist_id}","starred_url":"https://api.github.com/users/mruzicka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruzicka/subscriptions","organizations_url":"https://api.github.com/users/mruzicka/orgs","repos_url":"https://api.github.com/users/mruzicka/repos","events_url":"https://api.github.com/users/mruzicka/events{/privacy}","received_events_url":"https://api.github.com/users/mruzicka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mruzicka/pcp-broker","description":"PCP message broker","fork":true,"url":"https://api.github.com/repos/mruzicka/pcp-broker","forks_url":"https://api.github.com/repos/mruzicka/pcp-broker/forks","keys_url":"https://api.github.com/repos/mruzicka/pcp-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mruzicka/pcp-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mruzicka/pcp-broker/teams","hooks_url":"https://api.github.com/repos/mruzicka/pcp-broker/hooks","issue_events_url":"https://api.github.com/repos/mruzicka/pcp-broker/issues/events{/number}","events_url":"https://api.github.com/repos/mruzicka/pcp-broker/events","assignees_url":"https://api.github.com/repos/mruzicka/pcp-broker/assignees{/user}","branches_url":"https://api.github.com/repos/mruzicka/pcp-broker/branches{/branch}","tags_url":"https://api.github.com/repos/mruzicka/pcp-broker/tags","blobs_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mruzicka/pcp-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/mruzicka/pcp-broker/languages","stargazers_url":"https://api.github.com/repos/mruzicka/pcp-broker/stargazers","contributors_url":"https://api.github.com/repos/mruzicka/pcp-broker/contributors","subscribers_url":"https://api.github.com/repos/mruzicka/pcp-broker/subscribers","subscription_url":"https://api.github.com/repos/mruzicka/pcp-broker/subscription","commits_url":"https://api.github.com/repos/mruzicka/pcp-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/mruzicka/pcp-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/mruzicka/pcp-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/mruzicka/pcp-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/mruzicka/pcp-broker/contents/{+path}","compare_url":"https://api.github.com/repos/mruzicka/pcp-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mruzicka/pcp-broker/merges","archive_url":"https://api.github.com/repos/mruzicka/pcp-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mruzicka/pcp-broker/downloads","issues_url":"https://api.github.com/repos/mruzicka/pcp-broker/issues{/number}","pulls_url":"https://api.github.com/repos/mruzicka/pcp-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/mruzicka/pcp-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/mruzicka/pcp-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mruzicka/pcp-broker/labels{/name}","releases_url":"https://api.github.com/repos/mruzicka/pcp-broker/releases{/id}","deployments_url":"https://api.github.com/repos/mruzicka/pcp-broker/deployments","created_at":"2016-02-04T13:40:10Z","updated_at":"2016-02-04T13:40:11Z","pushed_at":"2017-06-16T14:55:08Z","git_url":"git://github.com/mruzicka/pcp-broker.git","ssh_url":"git@github.com:mruzicka/pcp-broker.git","clone_url":"https://github.com/mruzicka/pcp-broker.git","svn_url":"https://github.com/mruzicka/pcp-broker","homepage":"","size":1104,"stargazers_count":0,"watchers_count":0,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"1a6931a26db5bf4e3484b3d53f682241214696b4","user":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars3.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":22723510,"name":"pcp-broker","full_name":"puppetlabs/pcp-broker","owner":{"login":"puppetlabs","id":234268,"avatar_url":"https://avatars3.githubusercontent.com/u/234268?v=3","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/pcp-broker","description":"PCP message broker","fork":false,"url":"https://api.github.com/repos/puppetlabs/pcp-broker","forks_url":"https://api.github.com/repos/puppetlabs/pcp-broker/forks","keys_url":"https://api.github.com/repos/puppetlabs/pcp-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/pcp-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/pcp-broker/teams","hooks_url":"https://api.github.com/repos/puppetlabs/pcp-broker/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/pcp-broker/events","assignees_url":"https://api.github.com/repos/puppetlabs/pcp-broker/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/pcp-broker/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/pcp-broker/tags","blobs_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/pcp-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/pcp-broker/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/pcp-broker/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/pcp-broker/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/pcp-broker/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/pcp-broker/subscription","commits_url":"https://api.github.com/repos/puppetlabs/pcp-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/pcp-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/pcp-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/pcp-broker/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/pcp-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/pcp-broker/merges","archive_url":"https://api.github.com/repos/puppetlabs/pcp-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/pcp-broker/downloads","issues_url":"https://api.github.com/repos/puppetlabs/pcp-broker/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/pcp-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/pcp-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/pcp-broker/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/pcp-broker/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/pcp-broker/deployments","created_at":"2014-08-07T14:07:55Z","updated_at":"2016-12-11T22:42:05Z","pushed_at":"2017-06-16T14:56:16Z","git_url":"git://github.com/puppetlabs/pcp-broker.git","ssh_url":"git@github.com:puppetlabs/pcp-broker.git","clone_url":"https://github.com/puppetlabs/pcp-broker.git","svn_url":"https://github.com/puppetlabs/pcp-broker","homepage":"","size":1098,"stargazers_count":1,"watchers_count":1,"language":"Clojure","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":3,"forks":19,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/197"},"html":{"href":"https://github.com/puppetlabs/pcp-broker/pull/197"},"issue":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/197"},"comments":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/issues/197/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/197/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/pulls/197/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/pcp-broker/statuses/376ff12e3e4f4c1efee1a40c8b810b4b8261130f"}}}}
{"actor":{"display_login":"MikaelSmith"}}