{"action":"created","issue":{"url":"https://api.github.com/repos/openMF/self-service-app/issues/104","repository_url":"https://api.github.com/repos/openMF/self-service-app","labels_url":"https://api.github.com/repos/openMF/self-service-app/issues/104/labels{/name}","comments_url":"https://api.github.com/repos/openMF/self-service-app/issues/104/comments","events_url":"https://api.github.com/repos/openMF/self-service-app/issues/104/events","html_url":"https://github.com/openMF/self-service-app/pull/104","id":211334210,"number":104,"title":"Added checks for empty login fields and some more tweaks","user":{"login":"Pritom14","id":16569570,"avatar_url":"https://avatars1.githubusercontent.com/u/16569570?v=3","gravatar_id":"","url":"https://api.github.com/users/Pritom14","html_url":"https://github.com/Pritom14","followers_url":"https://api.github.com/users/Pritom14/followers","following_url":"https://api.github.com/users/Pritom14/following{/other_user}","gists_url":"https://api.github.com/users/Pritom14/gists{/gist_id}","starred_url":"https://api.github.com/users/Pritom14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pritom14/subscriptions","organizations_url":"https://api.github.com/users/Pritom14/orgs","repos_url":"https://api.github.com/users/Pritom14/repos","events_url":"https://api.github.com/users/Pritom14/events{/privacy}","received_events_url":"https://api.github.com/users/Pritom14/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-02T09:26:37Z","updated_at":"2017-03-02T19:45:53Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openMF/self-service-app/pulls/104","html_url":"https://github.com/openMF/self-service-app/pull/104","diff_url":"https://github.com/openMF/self-service-app/pull/104.diff","patch_url":"https://github.com/openMF/self-service-app/pull/104.patch"},"body":"Please make sure these boxes are checked before submitting your pull request - thanks!\r\n\r\n- [x] Apply the `MifosStyle.xml` style template to your code in Android Studio.\r\n\r\n- [x] Run the unit tests with `./gradlew check` to make sure you didn't break anything\r\n\r\n- [x] If you have multiple commits please combine them into one commit by squashing them."},"comment":{"url":"https://api.github.com/repos/openMF/self-service-app/issues/comments/283758931","html_url":"https://github.com/openMF/self-service-app/pull/104#issuecomment-283758931","issue_url":"https://api.github.com/repos/openMF/self-service-app/issues/104","id":283758931,"user":{"login":"Pritom14","id":16569570,"avatar_url":"https://avatars1.githubusercontent.com/u/16569570?v=3","gravatar_id":"","url":"https://api.github.com/users/Pritom14","html_url":"https://github.com/Pritom14","followers_url":"https://api.github.com/users/Pritom14/followers","following_url":"https://api.github.com/users/Pritom14/following{/other_user}","gists_url":"https://api.github.com/users/Pritom14/gists{/gist_id}","starred_url":"https://api.github.com/users/Pritom14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pritom14/subscriptions","organizations_url":"https://api.github.com/users/Pritom14/orgs","repos_url":"https://api.github.com/users/Pritom14/repos","events_url":"https://api.github.com/users/Pritom14/events{/privacy}","received_events_url":"https://api.github.com/users/Pritom14/received_events","type":"User","site_admin":false},"created_at":"2017-03-02T19:45:53Z","updated_at":"2017-03-02T19:45:53Z","body":"```\r\nprivate boolean isCredentialsValid(final String username, final String password) {\r\n\r\n        final Resources resources = context.getResources();\r\n\r\n        if (isCredentialsValid(username, password)){\r\n            getMvpView().showProgress();\r\n        }\r\n\r\n        if (username == null || username.trim().isEmpty()) {\r\n            showEmptyInputError(context.getString(R.string.username));\r\n            return false;\r\n        } else if (username.length() < 5) {\r\n            showMinimumInputLengthNotAchievedError(username,\r\n                    resources.getInteger(R.integer.username_minimum_length));\r\n            return false;\r\n        } else if (username.contains(\" \")) {\r\n            getMvpView().showMessage(context.getString(\r\n                    R.string.error_validation_cannot_contain_spaces,\r\n                    username, context.getString(R.string.not_contain_username)));\r\n            return false;\r\n        } else if (password == null || password.trim().isEmpty()) {\r\n            showEmptyInputError(context.getString(R.string.password));\r\n            return false;\r\n        } else if (password.length() < 6) {\r\n            showMinimumInputLengthNotAchievedError(resources.getString(R.string.password),\r\n                    resources.getInteger(R.integer.password_minimum_length));\r\n            return false;\r\n        }\r\n\r\n        return true;\r\n    }\r\n```\r\n\r\n@therajanmaurya Sir, as you said I did this , but when I run the app and press the login button it does not respond."}}
{"actor":{"display_login":"Pritom14"}}