{"action":"closed","number":32,"pull_request":{"url":"https://api.github.com/repos/BlueBrain/MVDTool/pulls/32","id":128591325,"html_url":"https://github.com/BlueBrain/MVDTool/pull/32","diff_url":"https://github.com/BlueBrain/MVDTool/pull/32.diff","patch_url":"https://github.com/BlueBrain/MVDTool/pull/32.patch","issue_url":"https://api.github.com/repos/BlueBrain/MVDTool/issues/32","number":32,"state":"closed","locked":false,"title":"MVD2 and MVD3 common API","user":{"login":"ferdonline","id":915100,"avatar_url":"https://avatars1.githubusercontent.com/u/915100?v=3","gravatar_id":"","url":"https://api.github.com/users/ferdonline","html_url":"https://github.com/ferdonline","followers_url":"https://api.github.com/users/ferdonline/followers","following_url":"https://api.github.com/users/ferdonline/following{/other_user}","gists_url":"https://api.github.com/users/ferdonline/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdonline/subscriptions","organizations_url":"https://api.github.com/users/ferdonline/orgs","repos_url":"https://api.github.com/users/ferdonline/repos","events_url":"https://api.github.com/users/ferdonline/events{/privacy}","received_events_url":"https://api.github.com/users/ferdonline/received_events","type":"User","site_admin":false},"body":"Hey.\r\n\r\nthis PR implements a common API between MVD2 and MVD3.\r\nIt is intended to efficiently handle large datasets, loading into memory only the required data, and skipping data as desired using the Range object as was used in MVD3. Therefore MVD3::Range was promoted to MVD::Range, just like MVDType.\r\n\r\nThe common interface between MVD2File and MVD3File is MVD::MVDFile.\r\n\r\nTo untangle dependencies, these base MVD:: classes were moved to mvd_base.hpp, and a generic mvd_open implemented in mvd_generic.hpp. \r\n\r\nUnit tests were implemented too ;)","created_at":"2017-07-03T09:49:08Z","updated_at":"2017-07-07T10:53:58Z","closed_at":"2017-07-07T10:53:58Z","merged_at":"2017-07-07T10:53:58Z","merge_commit_sha":"e023420c094d3f06808b1181b88fdf390e0eb99b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/BlueBrain/MVDTool/pulls/32/commits","review_comments_url":"https://api.github.com/repos/BlueBrain/MVDTool/pulls/32/comments","review_comment_url":"https://api.github.com/repos/BlueBrain/MVDTool/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BlueBrain/MVDTool/issues/32/comments","statuses_url":"https://api.github.com/repos/BlueBrain/MVDTool/statuses/bae141bc0fbb6e7f2735d64c94385dc73f2f461f","head":{"label":"ferdonline:mvd3_mvd3_api","ref":"mvd3_mvd3_api","sha":"bae141bc0fbb6e7f2735d64c94385dc73f2f461f","user":{"login":"ferdonline","id":915100,"avatar_url":"https://avatars1.githubusercontent.com/u/915100?v=3","gravatar_id":"","url":"https://api.github.com/users/ferdonline","html_url":"https://github.com/ferdonline","followers_url":"https://api.github.com/users/ferdonline/followers","following_url":"https://api.github.com/users/ferdonline/following{/other_user}","gists_url":"https://api.github.com/users/ferdonline/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdonline/subscriptions","organizations_url":"https://api.github.com/users/ferdonline/orgs","repos_url":"https://api.github.com/users/ferdonline/repos","events_url":"https://api.github.com/users/ferdonline/events{/privacy}","received_events_url":"https://api.github.com/users/ferdonline/received_events","type":"User","site_admin":false},"repo":{"id":95670712,"name":"MVDTool","full_name":"ferdonline/MVDTool","owner":{"login":"ferdonline","id":915100,"avatar_url":"https://avatars1.githubusercontent.com/u/915100?v=3","gravatar_id":"","url":"https://api.github.com/users/ferdonline","html_url":"https://github.com/ferdonline","followers_url":"https://api.github.com/users/ferdonline/followers","following_url":"https://api.github.com/users/ferdonline/following{/other_user}","gists_url":"https://api.github.com/users/ferdonline/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdonline/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdonline/subscriptions","organizations_url":"https://api.github.com/users/ferdonline/orgs","repos_url":"https://api.github.com/users/ferdonline/repos","events_url":"https://api.github.com/users/ferdonline/events{/privacy}","received_events_url":"https://api.github.com/users/ferdonline/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferdonline/MVDTool","description":"Parser and command line tool for MVD file format","fork":true,"url":"https://api.github.com/repos/ferdonline/MVDTool","forks_url":"https://api.github.com/repos/ferdonline/MVDTool/forks","keys_url":"https://api.github.com/repos/ferdonline/MVDTool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferdonline/MVDTool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferdonline/MVDTool/teams","hooks_url":"https://api.github.com/repos/ferdonline/MVDTool/hooks","issue_events_url":"https://api.github.com/repos/ferdonline/MVDTool/issues/events{/number}","events_url":"https://api.github.com/repos/ferdonline/MVDTool/events","assignees_url":"https://api.github.com/repos/ferdonline/MVDTool/assignees{/user}","branches_url":"https://api.github.com/repos/ferdonline/MVDTool/branches{/branch}","tags_url":"https://api.github.com/repos/ferdonline/MVDTool/tags","blobs_url":"https://api.github.com/repos/ferdonline/MVDTool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferdonline/MVDTool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferdonline/MVDTool/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferdonline/MVDTool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferdonline/MVDTool/statuses/{sha}","languages_url":"https://api.github.com/repos/ferdonline/MVDTool/languages","stargazers_url":"https://api.github.com/repos/ferdonline/MVDTool/stargazers","contributors_url":"https://api.github.com/repos/ferdonline/MVDTool/contributors","subscribers_url":"https://api.github.com/repos/ferdonline/MVDTool/subscribers","subscription_url":"https://api.github.com/repos/ferdonline/MVDTool/subscription","commits_url":"https://api.github.com/repos/ferdonline/MVDTool/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferdonline/MVDTool/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferdonline/MVDTool/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferdonline/MVDTool/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferdonline/MVDTool/contents/{+path}","compare_url":"https://api.github.com/repos/ferdonline/MVDTool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferdonline/MVDTool/merges","archive_url":"https://api.github.com/repos/ferdonline/MVDTool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferdonline/MVDTool/downloads","issues_url":"https://api.github.com/repos/ferdonline/MVDTool/issues{/number}","pulls_url":"https://api.github.com/repos/ferdonline/MVDTool/pulls{/number}","milestones_url":"https://api.github.com/repos/ferdonline/MVDTool/milestones{/number}","notifications_url":"https://api.github.com/repos/ferdonline/MVDTool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferdonline/MVDTool/labels{/name}","releases_url":"https://api.github.com/repos/ferdonline/MVDTool/releases{/id}","deployments_url":"https://api.github.com/repos/ferdonline/MVDTool/deployments","created_at":"2017-06-28T13:14:58Z","updated_at":"2017-06-28T13:14:59Z","pushed_at":"2017-07-04T12:48:34Z","git_url":"git://github.com/ferdonline/MVDTool.git","ssh_url":"git@github.com:ferdonline/MVDTool.git","clone_url":"https://github.com/ferdonline/MVDTool.git","svn_url":"https://github.com/ferdonline/MVDTool","homepage":null,"size":513,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BlueBrain:master","ref":"master","sha":"c4bb572080a77069e68c4f0c87510003b4b6d8b9","user":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars2.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"repo":{"id":51370254,"name":"MVDTool","full_name":"BlueBrain/MVDTool","owner":{"login":"BlueBrain","id":1479142,"avatar_url":"https://avatars2.githubusercontent.com/u/1479142?v=3","gravatar_id":"","url":"https://api.github.com/users/BlueBrain","html_url":"https://github.com/BlueBrain","followers_url":"https://api.github.com/users/BlueBrain/followers","following_url":"https://api.github.com/users/BlueBrain/following{/other_user}","gists_url":"https://api.github.com/users/BlueBrain/gists{/gist_id}","starred_url":"https://api.github.com/users/BlueBrain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BlueBrain/subscriptions","organizations_url":"https://api.github.com/users/BlueBrain/orgs","repos_url":"https://api.github.com/users/BlueBrain/repos","events_url":"https://api.github.com/users/BlueBrain/events{/privacy}","received_events_url":"https://api.github.com/users/BlueBrain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BlueBrain/MVDTool","description":"Parser and command line tool for MVD file format","fork":false,"url":"https://api.github.com/repos/BlueBrain/MVDTool","forks_url":"https://api.github.com/repos/BlueBrain/MVDTool/forks","keys_url":"https://api.github.com/repos/BlueBrain/MVDTool/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BlueBrain/MVDTool/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BlueBrain/MVDTool/teams","hooks_url":"https://api.github.com/repos/BlueBrain/MVDTool/hooks","issue_events_url":"https://api.github.com/repos/BlueBrain/MVDTool/issues/events{/number}","events_url":"https://api.github.com/repos/BlueBrain/MVDTool/events","assignees_url":"https://api.github.com/repos/BlueBrain/MVDTool/assignees{/user}","branches_url":"https://api.github.com/repos/BlueBrain/MVDTool/branches{/branch}","tags_url":"https://api.github.com/repos/BlueBrain/MVDTool/tags","blobs_url":"https://api.github.com/repos/BlueBrain/MVDTool/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BlueBrain/MVDTool/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BlueBrain/MVDTool/git/refs{/sha}","trees_url":"https://api.github.com/repos/BlueBrain/MVDTool/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BlueBrain/MVDTool/statuses/{sha}","languages_url":"https://api.github.com/repos/BlueBrain/MVDTool/languages","stargazers_url":"https://api.github.com/repos/BlueBrain/MVDTool/stargazers","contributors_url":"https://api.github.com/repos/BlueBrain/MVDTool/contributors","subscribers_url":"https://api.github.com/repos/BlueBrain/MVDTool/subscribers","subscription_url":"https://api.github.com/repos/BlueBrain/MVDTool/subscription","commits_url":"https://api.github.com/repos/BlueBrain/MVDTool/commits{/sha}","git_commits_url":"https://api.github.com/repos/BlueBrain/MVDTool/git/commits{/sha}","comments_url":"https://api.github.com/repos/BlueBrain/MVDTool/comments{/number}","issue_comment_url":"https://api.github.com/repos/BlueBrain/MVDTool/issues/comments{/number}","contents_url":"https://api.github.com/repos/BlueBrain/MVDTool/contents/{+path}","compare_url":"https://api.github.com/repos/BlueBrain/MVDTool/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BlueBrain/MVDTool/merges","archive_url":"https://api.github.com/repos/BlueBrain/MVDTool/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BlueBrain/MVDTool/downloads","issues_url":"https://api.github.com/repos/BlueBrain/MVDTool/issues{/number}","pulls_url":"https://api.github.com/repos/BlueBrain/MVDTool/pulls{/number}","milestones_url":"https://api.github.com/repos/BlueBrain/MVDTool/milestones{/number}","notifications_url":"https://api.github.com/repos/BlueBrain/MVDTool/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BlueBrain/MVDTool/labels{/name}","releases_url":"https://api.github.com/repos/BlueBrain/MVDTool/releases{/id}","deployments_url":"https://api.github.com/repos/BlueBrain/MVDTool/deployments","created_at":"2016-02-09T13:59:50Z","updated_at":"2017-03-07T15:15:43Z","pushed_at":"2017-07-07T10:53:58Z","git_url":"git://github.com/BlueBrain/MVDTool.git","ssh_url":"git@github.com:BlueBrain/MVDTool.git","clone_url":"https://github.com/BlueBrain/MVDTool.git","svn_url":"https://github.com/BlueBrain/MVDTool","homepage":null,"size":330,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BlueBrain/MVDTool/pulls/32"},"html":{"href":"https://github.com/BlueBrain/MVDTool/pull/32"},"issue":{"href":"https://api.github.com/repos/BlueBrain/MVDTool/issues/32"},"comments":{"href":"https://api.github.com/repos/BlueBrain/MVDTool/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/BlueBrain/MVDTool/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/BlueBrain/MVDTool/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BlueBrain/MVDTool/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/BlueBrain/MVDTool/statuses/bae141bc0fbb6e7f2735d64c94385dc73f2f461f"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"adevress","id":1773511,"avatar_url":"https://avatars1.githubusercontent.com/u/1773511?v=3","gravatar_id":"","url":"https://api.github.com/users/adevress","html_url":"https://github.com/adevress","followers_url":"https://api.github.com/users/adevress/followers","following_url":"https://api.github.com/users/adevress/following{/other_user}","gists_url":"https://api.github.com/users/adevress/gists{/gist_id}","starred_url":"https://api.github.com/users/adevress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adevress/subscriptions","organizations_url":"https://api.github.com/users/adevress/orgs","repos_url":"https://api.github.com/users/adevress/repos","events_url":"https://api.github.com/users/adevress/events{/privacy}","received_events_url":"https://api.github.com/users/adevress/received_events","type":"User","site_admin":false},"comments":3,"review_comments":8,"maintainer_can_modify":false,"commits":5,"additions":2472,"deletions":2515,"changed_files":23}}
{"actor":{"display_login":"adevress"}}