{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/13569","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/13569/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/13569/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/13569/events","html_url":"https://github.com/openshift/origin/pull/13569","id":217903180,"number":13569,"title":"Redirect to relative subpath for approval, relative parent path on success","user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars3.githubusercontent.com/u/980082?v=3","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"enj","id":7001223,"avatar_url":"https://avatars3.githubusercontent.com/u/7001223?v=3","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false},"assignees":[{"login":"enj","id":7001223,"avatar_url":"https://avatars3.githubusercontent.com/u/7001223?v=3","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false},{"login":"deads2k","id":8225098,"avatar_url":"https://avatars3.githubusercontent.com/u/8225098?v=3","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-03-29T14:53:13Z","updated_at":"2017-04-04T19:37:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/13569","html_url":"https://github.com/openshift/origin/pull/13569","diff_url":"https://github.com/openshift/origin/pull/13569.diff","patch_url":"https://github.com/openshift/origin/pull/13569.patch"},"body":"Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1434983\r\n\r\n* Moves grant approval endpoint from `/oauth/approve` to `/oauth/authorize/approve`\r\n* Changes the redirect to the grant approval flow to be a relative path redirect (`Location: authorize/approve`)\r\n* Changes the grant approval form action to be relative (`action=\"approve\"`)\r\n* Changes the redirect from the approval flow back to the authorize endpoint to be relative (`Location: ../authorize`)\r\n* Adds validation to RequestHeaderIdentityProvider loginURL to catch two scenarios that would prevent relative redirects from working (trailing `/` and the proxy path not ending in `/authorize`)\r\n\r\nTODO:\r\n* [x] Test:\r\n  * [x] Firefox\r\n  * [x] IE 11\r\n  * [x] IE 11 Intranet mode\r\n  * [x] Safari\r\n  * [x] Chrome\r\n  * [x] iOS\r\n* [x] Update unit/integration tests\r\n* [ ] Update documentation\r\n  * [ ] the auth proxy endpoint that proxies to `/oauth/authorize` must also proxy subpaths (notably `/oauth/authorize/approve`)\r\n  * [ ] the auth proxy endpoint that proxies to `/oauth/authorize` must end with `.../authorize` (with no trailing slash)\r\n"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/291609076","html_url":"https://github.com/openshift/origin/pull/13569#issuecomment-291609076","issue_url":"https://api.github.com/repos/openshift/origin/issues/13569","id":291609076,"user":{"login":"openshift-bot","id":1779249,"avatar_url":"https://avatars1.githubusercontent.com/u/1779249?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift-bot","html_url":"https://github.com/openshift-bot","followers_url":"https://api.github.com/users/openshift-bot/followers","following_url":"https://api.github.com/users/openshift-bot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-bot/subscriptions","organizations_url":"https://api.github.com/users/openshift-bot/orgs","repos_url":"https://api.github.com/users/openshift-bot/repos","events_url":"https://api.github.com/users/openshift-bot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-bot/received_events","type":"User","site_admin":false},"created_at":"2017-04-04T19:37:41Z","updated_at":"2017-04-04T19:37:41Z","body":"continuous-integration/openshift-jenkins/test SUCCESS (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/556/) (Base Commit: f0670dfb707d5d0e21fc375792d44a8a07a2f1dd)"}}
{"actor":{"display_login":"openshift-bot"}}