{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/142198906","pull_request_review_id":66525804,"id":142198906,"diff_hunk":"@@ -143,4 +148,25 @@ impl MirPass for NLL {\n             let _results = visitor.into_results();\n         })\n     }\n-}\n\\ No newline at end of file\n+}\n+\n+#[derive(Clone, Debug, Default, PartialEq, Eq)]\n+struct Region {\n+    points: FxHashSet<Location>,\n+}\n+\n+#[derive(Copy, Clone, Hash, Eq, PartialEq, Ord, PartialOrd, Debug)]\n+pub struct RegionIndex(pub u32);","path":"src/librustc_mir/transform/nll.rs","position":null,"original_position":49,"commit_id":"224e87f227621e42f0ee6e351c1b2977bc9a7e9a","original_commit_id":"a6c107c88bc96893a23ee22380b91aadb0254b12","user":{"login":"spastorino","id":52642,"avatar_url":"https://avatars0.githubusercontent.com/u/52642?v=4","gravatar_id":"","url":"https://api.github.com/users/spastorino","html_url":"https://github.com/spastorino","followers_url":"https://api.github.com/users/spastorino/followers","following_url":"https://api.github.com/users/spastorino/following{/other_user}","gists_url":"https://api.github.com/users/spastorino/gists{/gist_id}","starred_url":"https://api.github.com/users/spastorino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spastorino/subscriptions","organizations_url":"https://api.github.com/users/spastorino/orgs","repos_url":"https://api.github.com/users/spastorino/repos","events_url":"https://api.github.com/users/spastorino/events{/privacy}","received_events_url":"https://api.github.com/users/spastorino/received_events","type":"User","site_admin":false},"body":"After deciding and addressing this last comments, I think we are fine to make this thing mergeable again.","created_at":"2017-10-02T17:12:34Z","updated_at":"2017-10-02T17:12:34Z","html_url":"https://github.com/rust-lang/rust/pull/44878#discussion_r142198906","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/44878","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/142198906"},"html":{"href":"https://github.com/rust-lang/rust/pull/44878#discussion_r142198906"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44878"}},"in_reply_to_id":141449348},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/44878","id":143284863,"html_url":"https://github.com/rust-lang/rust/pull/44878","diff_url":"https://github.com/rust-lang/rust/pull/44878.diff","patch_url":"https://github.com/rust-lang/rust/pull/44878.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/44878","number":44878,"state":"open","locked":false,"title":"Store a new Region value every time we create a new region variable","user":{"login":"Nashenas88","id":1673130,"avatar_url":"https://avatars0.githubusercontent.com/u/1673130?v=4","gravatar_id":"","url":"https://api.github.com/users/Nashenas88","html_url":"https://github.com/Nashenas88","followers_url":"https://api.github.com/users/Nashenas88/followers","following_url":"https://api.github.com/users/Nashenas88/following{/other_user}","gists_url":"https://api.github.com/users/Nashenas88/gists{/gist_id}","starred_url":"https://api.github.com/users/Nashenas88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nashenas88/subscriptions","organizations_url":"https://api.github.com/users/Nashenas88/orgs","repos_url":"https://api.github.com/users/Nashenas88/repos","events_url":"https://api.github.com/users/Nashenas88/events{/privacy}","received_events_url":"https://api.github.com/users/Nashenas88/received_events","type":"User","site_admin":false},"body":"Paired with @spastorino to walk through this and implement #44870.","created_at":"2017-09-27T02:29:08Z","updated_at":"2017-10-02T17:12:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53c2eb9f9b3c7948ae0768205f28ded5de8e4bcb","assignee":{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikomatsakis","id":155238,"avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/44878/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/44878/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/44878/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/224e87f227621e42f0ee6e351c1b2977bc9a7e9a","head":{"label":"Nashenas88:master","ref":"master","sha":"224e87f227621e42f0ee6e351c1b2977bc9a7e9a","user":{"login":"Nashenas88","id":1673130,"avatar_url":"https://avatars0.githubusercontent.com/u/1673130?v=4","gravatar_id":"","url":"https://api.github.com/users/Nashenas88","html_url":"https://github.com/Nashenas88","followers_url":"https://api.github.com/users/Nashenas88/followers","following_url":"https://api.github.com/users/Nashenas88/following{/other_user}","gists_url":"https://api.github.com/users/Nashenas88/gists{/gist_id}","starred_url":"https://api.github.com/users/Nashenas88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nashenas88/subscriptions","organizations_url":"https://api.github.com/users/Nashenas88/orgs","repos_url":"https://api.github.com/users/Nashenas88/repos","events_url":"https://api.github.com/users/Nashenas88/events{/privacy}","received_events_url":"https://api.github.com/users/Nashenas88/received_events","type":"User","site_admin":false},"repo":{"id":35624913,"name":"rust","full_name":"Nashenas88/rust","owner":{"login":"Nashenas88","id":1673130,"avatar_url":"https://avatars0.githubusercontent.com/u/1673130?v=4","gravatar_id":"","url":"https://api.github.com/users/Nashenas88","html_url":"https://github.com/Nashenas88","followers_url":"https://api.github.com/users/Nashenas88/followers","following_url":"https://api.github.com/users/Nashenas88/following{/other_user}","gists_url":"https://api.github.com/users/Nashenas88/gists{/gist_id}","starred_url":"https://api.github.com/users/Nashenas88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nashenas88/subscriptions","organizations_url":"https://api.github.com/users/Nashenas88/orgs","repos_url":"https://api.github.com/users/Nashenas88/repos","events_url":"https://api.github.com/users/Nashenas88/events{/privacy}","received_events_url":"https://api.github.com/users/Nashenas88/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nashenas88/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/Nashenas88/rust","forks_url":"https://api.github.com/repos/Nashenas88/rust/forks","keys_url":"https://api.github.com/repos/Nashenas88/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nashenas88/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nashenas88/rust/teams","hooks_url":"https://api.github.com/repos/Nashenas88/rust/hooks","issue_events_url":"https://api.github.com/repos/Nashenas88/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Nashenas88/rust/events","assignees_url":"https://api.github.com/repos/Nashenas88/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Nashenas88/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Nashenas88/rust/tags","blobs_url":"https://api.github.com/repos/Nashenas88/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nashenas88/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nashenas88/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nashenas88/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nashenas88/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Nashenas88/rust/languages","stargazers_url":"https://api.github.com/repos/Nashenas88/rust/stargazers","contributors_url":"https://api.github.com/repos/Nashenas88/rust/contributors","subscribers_url":"https://api.github.com/repos/Nashenas88/rust/subscribers","subscription_url":"https://api.github.com/repos/Nashenas88/rust/subscription","commits_url":"https://api.github.com/repos/Nashenas88/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nashenas88/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nashenas88/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nashenas88/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nashenas88/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Nashenas88/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nashenas88/rust/merges","archive_url":"https://api.github.com/repos/Nashenas88/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nashenas88/rust/downloads","issues_url":"https://api.github.com/repos/Nashenas88/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Nashenas88/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Nashenas88/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Nashenas88/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nashenas88/rust/labels{/name}","releases_url":"https://api.github.com/repos/Nashenas88/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Nashenas88/rust/deployments","created_at":"2015-05-14T17:17:09Z","updated_at":"2017-02-09T23:50:41Z","pushed_at":"2017-09-29T03:25:51Z","git_url":"git://github.com/Nashenas88/rust.git","ssh_url":"git@github.com:Nashenas88/rust.git","clone_url":"https://github.com/Nashenas88/rust.git","svn_url":"https://github.com/Nashenas88/rust","homepage":"http://www.rust-lang.org","size":323298,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"46ef6208f8a3dd0629a9d6c592c2a980e52c9bee","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-10-02T16:26:06Z","pushed_at":"2017-10-02T17:06:46Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":327790,"stargazers_count":23655,"watchers_count":23655,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4369,"mirror_url":null,"open_issues_count":2897,"forks":4369,"open_issues":2897,"watchers":23655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44878"},"html":{"href":"https://github.com/rust-lang/rust/pull/44878"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/44878"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/44878/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44878/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/44878/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/224e87f227621e42f0ee6e351c1b2977bc9a7e9a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"spastorino"}}