{"action":"created","issue":{"url":"https://api.github.com/repos/kevin-wayne/algs4/issues/25","repository_url":"https://api.github.com/repos/kevin-wayne/algs4","labels_url":"https://api.github.com/repos/kevin-wayne/algs4/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/kevin-wayne/algs4/issues/25/comments","events_url":"https://api.github.com/repos/kevin-wayne/algs4/issues/25/events","html_url":"https://github.com/kevin-wayne/algs4/issues/25","id":210018528,"number":25,"title":"QuickX.sort(Comparable[] a, int lo, int hi) ","user":{"login":"nikkekin","id":4420520,"avatar_url":"https://avatars2.githubusercontent.com/u/4420520?v=3","gravatar_id":"","url":"https://api.github.com/users/nikkekin","html_url":"https://github.com/nikkekin","followers_url":"https://api.github.com/users/nikkekin/followers","following_url":"https://api.github.com/users/nikkekin/following{/other_user}","gists_url":"https://api.github.com/users/nikkekin/gists{/gist_id}","starred_url":"https://api.github.com/users/nikkekin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikkekin/subscriptions","organizations_url":"https://api.github.com/users/nikkekin/orgs","repos_url":"https://api.github.com/users/nikkekin/repos","events_url":"https://api.github.com/users/nikkekin/events{/privacy}","received_events_url":"https://api.github.com/users/nikkekin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-02-24T10:57:12Z","updated_at":"2017-04-01T09:10:23Z","closed_at":null,"body":"Hey,\r\n\r\nCould it be possible to make QuickX.sort(Comparable[] a, int lo, int hi) public instead of having it private?\r\n\r\nJust by looking at the code I don't see any reason why it couldn't be public, but perhaps I am missing something here?\r\n\r\n-niklas"},"comment":{"url":"https://api.github.com/repos/kevin-wayne/algs4/issues/comments/290907615","html_url":"https://github.com/kevin-wayne/algs4/issues/25#issuecomment-290907615","issue_url":"https://api.github.com/repos/kevin-wayne/algs4/issues/25","id":290907615,"user":{"login":"kevin-wayne","id":5225666,"avatar_url":"https://avatars2.githubusercontent.com/u/5225666?v=3","gravatar_id":"","url":"https://api.github.com/users/kevin-wayne","html_url":"https://github.com/kevin-wayne","followers_url":"https://api.github.com/users/kevin-wayne/followers","following_url":"https://api.github.com/users/kevin-wayne/following{/other_user}","gists_url":"https://api.github.com/users/kevin-wayne/gists{/gist_id}","starred_url":"https://api.github.com/users/kevin-wayne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevin-wayne/subscriptions","organizations_url":"https://api.github.com/users/kevin-wayne/orgs","repos_url":"https://api.github.com/users/kevin-wayne/repos","events_url":"https://api.github.com/users/kevin-wayne/events{/privacy}","received_events_url":"https://api.github.com/users/kevin-wayne/received_events","type":"User","site_admin":false},"created_at":"2017-04-01T09:10:23Z","updated_at":"2017-04-01T09:10:23Z","body":"Sorry for the delay. We chose not to make it public because the convention in Java for subarrays is to make the left endpoint inclusive and the right endpoint exclusive, whereas, for this helper method, it’s both left and right inclusive.\n\nThe sorting routines are meant primarily for pedagogical purposes; in practice, you would probably want to use Arrays.sort(), which has the full spectrum of variants, including arrays of primitive types and subarrays.\n\nBest,\nKevin\n\n> On Apr 1, 2017, at 3:36 AM, Nikke <notifications@github.com> wrote:\n> \n> As I wrote, I was just asking if it would be possible to add signature\n> \n> QuickX.sort(Comparable[] a, int lo, int hi)\n> \n> To the public api of the class. It is already a static function and based on a short read of the source none class invariants are broken in case you make it public.\n> \n> I can also just fork your codebase (already did it) but at the same time it would be a lot nicer for future maintenance in case it was just part of the api.\n> \n> I understand if you don't want to support it.\n> \n> -niklas\n> \n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n> \n\nKevin Wayne\nPhillip Y. Goldman '86 Senior Lecturer\nDepartment of Computer Science\nPrinceton University\n\n\n\n\n"}}
{"actor":{"display_login":"kevin-wayne"}}