{"action":"created","comment":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/comments/104538867","pull_request_review_id":25380736,"id":104538867,"diff_hunk":"@@ -0,0 +1,51 @@\n+import React, {Component} from 'react';\n+import SelectField from 'material-ui/SelectField';\n+import MenuItem from 'material-ui/MenuItem';\n+\n+const names = [\n+  'Oliver Hansen',\n+  'Van Henry',\n+  'April Tucker',\n+  'Ralph Hubbard',\n+  'Omar Alexander',\n+  'Carlos Abbott',\n+  'Miriam Wagner',\n+  'Bradley Wilkerson',\n+  'Virginia Andrews',\n+  'Kelly Snyder',\n+];\n+\n+export default class SelectFieldExampleMultiSelect extends Component {\n+  state = {\n+    values: [],\n+  };\n+\n+  handleChange = (event, index, values) => this.setState({values});\n+\n+  menuItems(values) {\n+    return names.map((name) => (\n+      <MenuItem\n+        key={name}\n+        insetChildren={true}\n+        checked={values && values.includes(name)}\n+        value={name}\n+        primaryText={name}\n+      />\n+    ));\n+  }\n+\n+  render() {\n+    const {values} = this.state;","path":"docs/src/app/components/pages/components/SelectField/ExampleMultiSelect.js","position":38,"original_position":38,"commit_id":"7341071c4ab9b6c3a5bfc4ee0fcc3c3384cfb89a","original_commit_id":"7341071c4ab9b6c3a5bfc4ee0fcc3c3384cfb89a","user":{"login":"oliviertassinari","id":3165635,"avatar_url":"https://avatars1.githubusercontent.com/u/3165635?v=3","gravatar_id":"","url":"https://api.github.com/users/oliviertassinari","html_url":"https://github.com/oliviertassinari","followers_url":"https://api.github.com/users/oliviertassinari/followers","following_url":"https://api.github.com/users/oliviertassinari/following{/other_user}","gists_url":"https://api.github.com/users/oliviertassinari/gists{/gist_id}","starred_url":"https://api.github.com/users/oliviertassinari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oliviertassinari/subscriptions","organizations_url":"https://api.github.com/users/oliviertassinari/orgs","repos_url":"https://api.github.com/users/oliviertassinari/repos","events_url":"https://api.github.com/users/oliviertassinari/events{/privacy}","received_events_url":"https://api.github.com/users/oliviertassinari/received_events","type":"User","site_admin":false},"body":"Some would consider destructuration overkill here, I'm fine either way.","created_at":"2017-03-06T22:19:08Z","updated_at":"2017-03-06T22:37:11Z","html_url":"https://github.com/callemall/material-ui/pull/6165#discussion_r104538867","pull_request_url":"https://api.github.com/repos/callemall/material-ui/pulls/6165","_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments/104538867"},"html":{"href":"https://github.com/callemall/material-ui/pull/6165#discussion_r104538867"},"pull_request":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/6165"}}},"pull_request":{"url":"https://api.github.com/repos/callemall/material-ui/pulls/6165","id":106530970,"html_url":"https://github.com/callemall/material-ui/pull/6165","diff_url":"https://github.com/callemall/material-ui/pull/6165.diff","patch_url":"https://github.com/callemall/material-ui/pull/6165.patch","issue_url":"https://api.github.com/repos/callemall/material-ui/issues/6165","number":6165,"state":"open","locked":false,"title":"[SelectField] [DropDownMenu] Support multi select","user":{"login":"JessThrysoee","id":238102,"avatar_url":"https://avatars1.githubusercontent.com/u/238102?v=3","gravatar_id":"","url":"https://api.github.com/users/JessThrysoee","html_url":"https://github.com/JessThrysoee","followers_url":"https://api.github.com/users/JessThrysoee/followers","following_url":"https://api.github.com/users/JessThrysoee/following{/other_user}","gists_url":"https://api.github.com/users/JessThrysoee/gists{/gist_id}","starred_url":"https://api.github.com/users/JessThrysoee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JessThrysoee/subscriptions","organizations_url":"https://api.github.com/users/JessThrysoee/orgs","repos_url":"https://api.github.com/users/JessThrysoee/repos","events_url":"https://api.github.com/users/JessThrysoee/events{/privacy}","received_events_url":"https://api.github.com/users/JessThrysoee/received_events","type":"User","site_admin":false},"body":"Multi select in SelectField is requested in #1956, but progress doesn't seem to have been made (I'm new to material-ui so I might just be uninformed :-).\r\n\r\nTo get the ball rolling, this PR simply makes `Menu`s multi select support available in `SelectField` and `DropDownMenu`. A demo of what it looks like can be seen here: http://thrysoee.dk/material-ui/\r\n\r\nI haven't looked into updating docs/tests/... yet. I thought I'd hear what you guys think before going any further. \r\n","created_at":"2017-02-16T14:01:37Z","updated_at":"2017-03-06T22:37:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41cf0ffed65d251c02e070c45ab1ae13eab0290e","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/callemall/material-ui/pulls/6165/commits","review_comments_url":"https://api.github.com/repos/callemall/material-ui/pulls/6165/comments","review_comment_url":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/callemall/material-ui/issues/6165/comments","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/7341071c4ab9b6c3a5bfc4ee0fcc3c3384cfb89a","head":{"label":"JessThrysoee:multiselectfield","ref":"multiselectfield","sha":"7341071c4ab9b6c3a5bfc4ee0fcc3c3384cfb89a","user":{"login":"JessThrysoee","id":238102,"avatar_url":"https://avatars1.githubusercontent.com/u/238102?v=3","gravatar_id":"","url":"https://api.github.com/users/JessThrysoee","html_url":"https://github.com/JessThrysoee","followers_url":"https://api.github.com/users/JessThrysoee/followers","following_url":"https://api.github.com/users/JessThrysoee/following{/other_user}","gists_url":"https://api.github.com/users/JessThrysoee/gists{/gist_id}","starred_url":"https://api.github.com/users/JessThrysoee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JessThrysoee/subscriptions","organizations_url":"https://api.github.com/users/JessThrysoee/orgs","repos_url":"https://api.github.com/users/JessThrysoee/repos","events_url":"https://api.github.com/users/JessThrysoee/events{/privacy}","received_events_url":"https://api.github.com/users/JessThrysoee/received_events","type":"User","site_admin":false},"repo":{"id":82164753,"name":"material-ui","full_name":"JessThrysoee/material-ui","owner":{"login":"JessThrysoee","id":238102,"avatar_url":"https://avatars1.githubusercontent.com/u/238102?v=3","gravatar_id":"","url":"https://api.github.com/users/JessThrysoee","html_url":"https://github.com/JessThrysoee","followers_url":"https://api.github.com/users/JessThrysoee/followers","following_url":"https://api.github.com/users/JessThrysoee/following{/other_user}","gists_url":"https://api.github.com/users/JessThrysoee/gists{/gist_id}","starred_url":"https://api.github.com/users/JessThrysoee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JessThrysoee/subscriptions","organizations_url":"https://api.github.com/users/JessThrysoee/orgs","repos_url":"https://api.github.com/users/JessThrysoee/repos","events_url":"https://api.github.com/users/JessThrysoee/events{/privacy}","received_events_url":"https://api.github.com/users/JessThrysoee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/JessThrysoee/material-ui","description":"React Components that Implement Google's Material Design.","fork":true,"url":"https://api.github.com/repos/JessThrysoee/material-ui","forks_url":"https://api.github.com/repos/JessThrysoee/material-ui/forks","keys_url":"https://api.github.com/repos/JessThrysoee/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JessThrysoee/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JessThrysoee/material-ui/teams","hooks_url":"https://api.github.com/repos/JessThrysoee/material-ui/hooks","issue_events_url":"https://api.github.com/repos/JessThrysoee/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/JessThrysoee/material-ui/events","assignees_url":"https://api.github.com/repos/JessThrysoee/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/JessThrysoee/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/JessThrysoee/material-ui/tags","blobs_url":"https://api.github.com/repos/JessThrysoee/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JessThrysoee/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JessThrysoee/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/JessThrysoee/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JessThrysoee/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/JessThrysoee/material-ui/languages","stargazers_url":"https://api.github.com/repos/JessThrysoee/material-ui/stargazers","contributors_url":"https://api.github.com/repos/JessThrysoee/material-ui/contributors","subscribers_url":"https://api.github.com/repos/JessThrysoee/material-ui/subscribers","subscription_url":"https://api.github.com/repos/JessThrysoee/material-ui/subscription","commits_url":"https://api.github.com/repos/JessThrysoee/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/JessThrysoee/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/JessThrysoee/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/JessThrysoee/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/JessThrysoee/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/JessThrysoee/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JessThrysoee/material-ui/merges","archive_url":"https://api.github.com/repos/JessThrysoee/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JessThrysoee/material-ui/downloads","issues_url":"https://api.github.com/repos/JessThrysoee/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/JessThrysoee/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/JessThrysoee/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/JessThrysoee/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JessThrysoee/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/JessThrysoee/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/JessThrysoee/material-ui/deployments","created_at":"2017-02-16T09:44:53Z","updated_at":"2017-02-16T09:44:58Z","pushed_at":"2017-03-02T21:29:42Z","git_url":"git://github.com/JessThrysoee/material-ui.git","ssh_url":"git@github.com:JessThrysoee/material-ui.git","clone_url":"https://github.com/JessThrysoee/material-ui.git","svn_url":"https://github.com/JessThrysoee/material-ui","homepage":"http://www.material-ui.com","size":80688,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"callemall:master","ref":"master","sha":"c5a98a9a7c99537fa03e2dbed720db5f6b0ea0bd","user":{"login":"callemall","id":1262264,"avatar_url":"https://avatars2.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"repo":{"id":23083156,"name":"material-ui","full_name":"callemall/material-ui","owner":{"login":"callemall","id":1262264,"avatar_url":"https://avatars2.githubusercontent.com/u/1262264?v=3","gravatar_id":"","url":"https://api.github.com/users/callemall","html_url":"https://github.com/callemall","followers_url":"https://api.github.com/users/callemall/followers","following_url":"https://api.github.com/users/callemall/following{/other_user}","gists_url":"https://api.github.com/users/callemall/gists{/gist_id}","starred_url":"https://api.github.com/users/callemall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/callemall/subscriptions","organizations_url":"https://api.github.com/users/callemall/orgs","repos_url":"https://api.github.com/users/callemall/repos","events_url":"https://api.github.com/users/callemall/events{/privacy}","received_events_url":"https://api.github.com/users/callemall/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/callemall/material-ui","description":"React Components that Implement Google's Material Design.","fork":false,"url":"https://api.github.com/repos/callemall/material-ui","forks_url":"https://api.github.com/repos/callemall/material-ui/forks","keys_url":"https://api.github.com/repos/callemall/material-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/callemall/material-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/callemall/material-ui/teams","hooks_url":"https://api.github.com/repos/callemall/material-ui/hooks","issue_events_url":"https://api.github.com/repos/callemall/material-ui/issues/events{/number}","events_url":"https://api.github.com/repos/callemall/material-ui/events","assignees_url":"https://api.github.com/repos/callemall/material-ui/assignees{/user}","branches_url":"https://api.github.com/repos/callemall/material-ui/branches{/branch}","tags_url":"https://api.github.com/repos/callemall/material-ui/tags","blobs_url":"https://api.github.com/repos/callemall/material-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/callemall/material-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/callemall/material-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/callemall/material-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/callemall/material-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/callemall/material-ui/languages","stargazers_url":"https://api.github.com/repos/callemall/material-ui/stargazers","contributors_url":"https://api.github.com/repos/callemall/material-ui/contributors","subscribers_url":"https://api.github.com/repos/callemall/material-ui/subscribers","subscription_url":"https://api.github.com/repos/callemall/material-ui/subscription","commits_url":"https://api.github.com/repos/callemall/material-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/callemall/material-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/callemall/material-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/callemall/material-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/callemall/material-ui/contents/{+path}","compare_url":"https://api.github.com/repos/callemall/material-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/callemall/material-ui/merges","archive_url":"https://api.github.com/repos/callemall/material-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/callemall/material-ui/downloads","issues_url":"https://api.github.com/repos/callemall/material-ui/issues{/number}","pulls_url":"https://api.github.com/repos/callemall/material-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/callemall/material-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/callemall/material-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/callemall/material-ui/labels{/name}","releases_url":"https://api.github.com/repos/callemall/material-ui/releases{/id}","deployments_url":"https://api.github.com/repos/callemall/material-ui/deployments","created_at":"2014-08-18T19:11:54Z","updated_at":"2017-03-06T22:28:02Z","pushed_at":"2017-03-06T22:34:29Z","git_url":"git://github.com/callemall/material-ui.git","ssh_url":"git@github.com:callemall/material-ui.git","clone_url":"https://github.com/callemall/material-ui.git","svn_url":"https://github.com/callemall/material-ui","homepage":"http://www.material-ui.com","size":80719,"stargazers_count":23656,"watchers_count":23656,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4260,"mirror_url":null,"open_issues_count":624,"forks":4260,"open_issues":624,"watchers":23656,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/6165"},"html":{"href":"https://github.com/callemall/material-ui/pull/6165"},"issue":{"href":"https://api.github.com/repos/callemall/material-ui/issues/6165"},"comments":{"href":"https://api.github.com/repos/callemall/material-ui/issues/6165/comments"},"review_comments":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/6165/comments"},"review_comment":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/callemall/material-ui/pulls/6165/commits"},"statuses":{"href":"https://api.github.com/repos/callemall/material-ui/statuses/7341071c4ab9b6c3a5bfc4ee0fcc3c3384cfb89a"}}}}
{"actor":{"display_login":"oliviertassinari"}}