{"action":"created","comment":{"url":"https://api.github.com/repos/Stampie/Stampie/pulls/comments/157981318","pull_request_review_id":84713544,"id":157981318,"diff_hunk":"@@ -2,120 +2,100 @@\n \n namespace Stampie\\Tests\\Mailer;\n \n+use GuzzleHttp\\Psr7\\Request;\n+use GuzzleHttp\\Psr7\\Response;\n+use Http\\Client\\HttpClient;\n use Stampie\\Mailer\\MailGun;\n+use Stampie\\Tests\\BaseMailerTest;\n \n /**\n  * @author Henrik Bjornskov <henrik@bjrnskov.dk>\n  */\n-class MailGunTest extends \\Stampie\\Tests\\BaseMailerTest\n+class MailGunTest extends BaseMailerTest\n {\n     const SERVER_TOKEN = 'henrik.bjrnskov.dk:myCustomKey';\n \n+    /**\n+     * @var MailGun\n+     */\n+    private $mailer;\n+\n+    /**\n+     * @var HttpClient|\\PHPUnit_Framework_MockObject_MockObject\n+     */\n+    private $httpClient;","path":"tests/Stampie/Tests/Mailer/MailGunTest.php","position":26,"original_position":26,"commit_id":"545264d5f0ee8f80d9982432d2e3118984891f37","original_commit_id":"545264d5f0ee8f80d9982432d2e3118984891f37","user":{"login":"fbourigault","id":1116116,"avatar_url":"https://avatars0.githubusercontent.com/u/1116116?v=4","gravatar_id":"","url":"https://api.github.com/users/fbourigault","html_url":"https://github.com/fbourigault","followers_url":"https://api.github.com/users/fbourigault/followers","following_url":"https://api.github.com/users/fbourigault/following{/other_user}","gists_url":"https://api.github.com/users/fbourigault/gists{/gist_id}","starred_url":"https://api.github.com/users/fbourigault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbourigault/subscriptions","organizations_url":"https://api.github.com/users/fbourigault/orgs","repos_url":"https://api.github.com/users/fbourigault/repos","events_url":"https://api.github.com/users/fbourigault/events{/privacy}","received_events_url":"https://api.github.com/users/fbourigault/received_events","type":"User","site_admin":false},"body":"The idea is to remove the adapter property from the parent and keep only helper methods in the parent class. Having an HttpClient is an implementation detail.","created_at":"2017-12-20T10:03:51Z","updated_at":"2017-12-20T10:03:51Z","html_url":"https://github.com/Stampie/Stampie/pull/97#discussion_r157981318","pull_request_url":"https://api.github.com/repos/Stampie/Stampie/pulls/97","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Stampie/Stampie/pulls/comments/157981318"},"html":{"href":"https://github.com/Stampie/Stampie/pull/97#discussion_r157981318"},"pull_request":{"href":"https://api.github.com/repos/Stampie/Stampie/pulls/97"}},"in_reply_to_id":157979991},"pull_request":{"url":"https://api.github.com/repos/Stampie/Stampie/pulls/97","id":159282438,"html_url":"https://github.com/Stampie/Stampie/pull/97","diff_url":"https://github.com/Stampie/Stampie/pull/97.diff","patch_url":"https://github.com/Stampie/Stampie/pull/97.patch","issue_url":"https://api.github.com/repos/Stampie/Stampie/issues/97","number":97,"state":"open","locked":false,"title":"[WIP]Tests cleanup","user":{"login":"fbourigault","id":1116116,"avatar_url":"https://avatars0.githubusercontent.com/u/1116116?v=4","gravatar_id":"","url":"https://api.github.com/users/fbourigault","html_url":"https://github.com/fbourigault","followers_url":"https://api.github.com/users/fbourigault/followers","following_url":"https://api.github.com/users/fbourigault/following{/other_user}","gists_url":"https://api.github.com/users/fbourigault/gists{/gist_id}","starred_url":"https://api.github.com/users/fbourigault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbourigault/subscriptions","organizations_url":"https://api.github.com/users/fbourigault/orgs","repos_url":"https://api.github.com/users/fbourigault/repos","events_url":"https://api.github.com/users/fbourigault/events{/privacy}","received_events_url":"https://api.github.com/users/fbourigault/received_events","type":"User","site_admin":false},"body":"This aim to clean the test suite to reduce tests complexity.\r\n\r\n@stof is it what you have in mind for #96?\r\n\r\n- [x] Rewrite MailGun tests.\r\n- [ ] Rewrite Mandrill tests.\r\n- [ ] Rewrite Postmark tests.\r\n- [ ] Rewrite SendGrid tests.\r\n\r\n","created_at":"2017-12-19T22:00:39Z","updated_at":"2017-12-20T10:03:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ecde0a98b47d7f83e8f610f7ad8f676bf04d7287","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Stampie/Stampie/pulls/97/commits","review_comments_url":"https://api.github.com/repos/Stampie/Stampie/pulls/97/comments","review_comment_url":"https://api.github.com/repos/Stampie/Stampie/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Stampie/Stampie/issues/97/comments","statuses_url":"https://api.github.com/repos/Stampie/Stampie/statuses/545264d5f0ee8f80d9982432d2e3118984891f37","head":{"label":"fbourigault:avoid-partial-mocks","ref":"avoid-partial-mocks","sha":"545264d5f0ee8f80d9982432d2e3118984891f37","user":{"login":"fbourigault","id":1116116,"avatar_url":"https://avatars0.githubusercontent.com/u/1116116?v=4","gravatar_id":"","url":"https://api.github.com/users/fbourigault","html_url":"https://github.com/fbourigault","followers_url":"https://api.github.com/users/fbourigault/followers","following_url":"https://api.github.com/users/fbourigault/following{/other_user}","gists_url":"https://api.github.com/users/fbourigault/gists{/gist_id}","starred_url":"https://api.github.com/users/fbourigault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbourigault/subscriptions","organizations_url":"https://api.github.com/users/fbourigault/orgs","repos_url":"https://api.github.com/users/fbourigault/repos","events_url":"https://api.github.com/users/fbourigault/events{/privacy}","received_events_url":"https://api.github.com/users/fbourigault/received_events","type":"User","site_admin":false},"repo":{"id":110888582,"name":"Stampie","full_name":"fbourigault/Stampie","owner":{"login":"fbourigault","id":1116116,"avatar_url":"https://avatars0.githubusercontent.com/u/1116116?v=4","gravatar_id":"","url":"https://api.github.com/users/fbourigault","html_url":"https://github.com/fbourigault","followers_url":"https://api.github.com/users/fbourigault/followers","following_url":"https://api.github.com/users/fbourigault/following{/other_user}","gists_url":"https://api.github.com/users/fbourigault/gists{/gist_id}","starred_url":"https://api.github.com/users/fbourigault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fbourigault/subscriptions","organizations_url":"https://api.github.com/users/fbourigault/orgs","repos_url":"https://api.github.com/users/fbourigault/repos","events_url":"https://api.github.com/users/fbourigault/events{/privacy}","received_events_url":"https://api.github.com/users/fbourigault/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fbourigault/Stampie","description":"Library for using online Email providers","fork":true,"url":"https://api.github.com/repos/fbourigault/Stampie","forks_url":"https://api.github.com/repos/fbourigault/Stampie/forks","keys_url":"https://api.github.com/repos/fbourigault/Stampie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fbourigault/Stampie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fbourigault/Stampie/teams","hooks_url":"https://api.github.com/repos/fbourigault/Stampie/hooks","issue_events_url":"https://api.github.com/repos/fbourigault/Stampie/issues/events{/number}","events_url":"https://api.github.com/repos/fbourigault/Stampie/events","assignees_url":"https://api.github.com/repos/fbourigault/Stampie/assignees{/user}","branches_url":"https://api.github.com/repos/fbourigault/Stampie/branches{/branch}","tags_url":"https://api.github.com/repos/fbourigault/Stampie/tags","blobs_url":"https://api.github.com/repos/fbourigault/Stampie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fbourigault/Stampie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fbourigault/Stampie/git/refs{/sha}","trees_url":"https://api.github.com/repos/fbourigault/Stampie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fbourigault/Stampie/statuses/{sha}","languages_url":"https://api.github.com/repos/fbourigault/Stampie/languages","stargazers_url":"https://api.github.com/repos/fbourigault/Stampie/stargazers","contributors_url":"https://api.github.com/repos/fbourigault/Stampie/contributors","subscribers_url":"https://api.github.com/repos/fbourigault/Stampie/subscribers","subscription_url":"https://api.github.com/repos/fbourigault/Stampie/subscription","commits_url":"https://api.github.com/repos/fbourigault/Stampie/commits{/sha}","git_commits_url":"https://api.github.com/repos/fbourigault/Stampie/git/commits{/sha}","comments_url":"https://api.github.com/repos/fbourigault/Stampie/comments{/number}","issue_comment_url":"https://api.github.com/repos/fbourigault/Stampie/issues/comments{/number}","contents_url":"https://api.github.com/repos/fbourigault/Stampie/contents/{+path}","compare_url":"https://api.github.com/repos/fbourigault/Stampie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fbourigault/Stampie/merges","archive_url":"https://api.github.com/repos/fbourigault/Stampie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fbourigault/Stampie/downloads","issues_url":"https://api.github.com/repos/fbourigault/Stampie/issues{/number}","pulls_url":"https://api.github.com/repos/fbourigault/Stampie/pulls{/number}","milestones_url":"https://api.github.com/repos/fbourigault/Stampie/milestones{/number}","notifications_url":"https://api.github.com/repos/fbourigault/Stampie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fbourigault/Stampie/labels{/name}","releases_url":"https://api.github.com/repos/fbourigault/Stampie/releases{/id}","deployments_url":"https://api.github.com/repos/fbourigault/Stampie/deployments","created_at":"2017-11-15T21:28:47Z","updated_at":"2017-11-15T21:28:49Z","pushed_at":"2017-12-19T22:10:24Z","git_url":"git://github.com/fbourigault/Stampie.git","ssh_url":"git@github.com:fbourigault/Stampie.git","clone_url":"https://github.com/fbourigault/Stampie.git","svn_url":"https://github.com/fbourigault/Stampie","homepage":"http://henrik.bjrnskov.dk","size":1188,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Stampie:master","ref":"master","sha":"c67ceb12c725b982e7f25c5a57910603327738bd","user":{"login":"Stampie","id":25911053,"avatar_url":"https://avatars1.githubusercontent.com/u/25911053?v=4","gravatar_id":"","url":"https://api.github.com/users/Stampie","html_url":"https://github.com/Stampie","followers_url":"https://api.github.com/users/Stampie/followers","following_url":"https://api.github.com/users/Stampie/following{/other_user}","gists_url":"https://api.github.com/users/Stampie/gists{/gist_id}","starred_url":"https://api.github.com/users/Stampie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stampie/subscriptions","organizations_url":"https://api.github.com/users/Stampie/orgs","repos_url":"https://api.github.com/users/Stampie/repos","events_url":"https://api.github.com/users/Stampie/events{/privacy}","received_events_url":"https://api.github.com/users/Stampie/received_events","type":"Organization","site_admin":false},"repo":{"id":2869331,"name":"Stampie","full_name":"Stampie/Stampie","owner":{"login":"Stampie","id":25911053,"avatar_url":"https://avatars1.githubusercontent.com/u/25911053?v=4","gravatar_id":"","url":"https://api.github.com/users/Stampie","html_url":"https://github.com/Stampie","followers_url":"https://api.github.com/users/Stampie/followers","following_url":"https://api.github.com/users/Stampie/following{/other_user}","gists_url":"https://api.github.com/users/Stampie/gists{/gist_id}","starred_url":"https://api.github.com/users/Stampie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stampie/subscriptions","organizations_url":"https://api.github.com/users/Stampie/orgs","repos_url":"https://api.github.com/users/Stampie/repos","events_url":"https://api.github.com/users/Stampie/events{/privacy}","received_events_url":"https://api.github.com/users/Stampie/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Stampie/Stampie","description":"Library for using online Email providers","fork":false,"url":"https://api.github.com/repos/Stampie/Stampie","forks_url":"https://api.github.com/repos/Stampie/Stampie/forks","keys_url":"https://api.github.com/repos/Stampie/Stampie/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Stampie/Stampie/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Stampie/Stampie/teams","hooks_url":"https://api.github.com/repos/Stampie/Stampie/hooks","issue_events_url":"https://api.github.com/repos/Stampie/Stampie/issues/events{/number}","events_url":"https://api.github.com/repos/Stampie/Stampie/events","assignees_url":"https://api.github.com/repos/Stampie/Stampie/assignees{/user}","branches_url":"https://api.github.com/repos/Stampie/Stampie/branches{/branch}","tags_url":"https://api.github.com/repos/Stampie/Stampie/tags","blobs_url":"https://api.github.com/repos/Stampie/Stampie/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Stampie/Stampie/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Stampie/Stampie/git/refs{/sha}","trees_url":"https://api.github.com/repos/Stampie/Stampie/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Stampie/Stampie/statuses/{sha}","languages_url":"https://api.github.com/repos/Stampie/Stampie/languages","stargazers_url":"https://api.github.com/repos/Stampie/Stampie/stargazers","contributors_url":"https://api.github.com/repos/Stampie/Stampie/contributors","subscribers_url":"https://api.github.com/repos/Stampie/Stampie/subscribers","subscription_url":"https://api.github.com/repos/Stampie/Stampie/subscription","commits_url":"https://api.github.com/repos/Stampie/Stampie/commits{/sha}","git_commits_url":"https://api.github.com/repos/Stampie/Stampie/git/commits{/sha}","comments_url":"https://api.github.com/repos/Stampie/Stampie/comments{/number}","issue_comment_url":"https://api.github.com/repos/Stampie/Stampie/issues/comments{/number}","contents_url":"https://api.github.com/repos/Stampie/Stampie/contents/{+path}","compare_url":"https://api.github.com/repos/Stampie/Stampie/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Stampie/Stampie/merges","archive_url":"https://api.github.com/repos/Stampie/Stampie/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Stampie/Stampie/downloads","issues_url":"https://api.github.com/repos/Stampie/Stampie/issues{/number}","pulls_url":"https://api.github.com/repos/Stampie/Stampie/pulls{/number}","milestones_url":"https://api.github.com/repos/Stampie/Stampie/milestones{/number}","notifications_url":"https://api.github.com/repos/Stampie/Stampie/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Stampie/Stampie/labels{/name}","releases_url":"https://api.github.com/repos/Stampie/Stampie/releases{/id}","deployments_url":"https://api.github.com/repos/Stampie/Stampie/deployments","created_at":"2011-11-28T18:52:39Z","updated_at":"2017-11-22T08:23:12Z","pushed_at":"2017-12-19T22:10:25Z","git_url":"git://github.com/Stampie/Stampie.git","ssh_url":"git@github.com:Stampie/Stampie.git","clone_url":"https://github.com/Stampie/Stampie.git","svn_url":"https://github.com/Stampie/Stampie","homepage":"http://henrik.bjrnskov.dk","size":1191,"stargazers_count":235,"watchers_count":235,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":27,"open_issues":12,"watchers":235,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Stampie/Stampie/pulls/97"},"html":{"href":"https://github.com/Stampie/Stampie/pull/97"},"issue":{"href":"https://api.github.com/repos/Stampie/Stampie/issues/97"},"comments":{"href":"https://api.github.com/repos/Stampie/Stampie/issues/97/comments"},"review_comments":{"href":"https://api.github.com/repos/Stampie/Stampie/pulls/97/comments"},"review_comment":{"href":"https://api.github.com/repos/Stampie/Stampie/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Stampie/Stampie/pulls/97/commits"},"statuses":{"href":"https://api.github.com/repos/Stampie/Stampie/statuses/545264d5f0ee8f80d9982432d2e3118984891f37"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"fbourigault"}}