{"action":"created","comment":{"url":"https://api.github.com/repos/docker/cli/pulls/comments/114712889","pull_request_review_id":36199980,"id":114712889,"diff_hunk":"@@ -8,12 +8,13 @@ import (\n )\n \n // NewSecretCommand returns a cobra command for `secret` subcommands\n+// nolint: interfacer\n func NewSecretCommand(dockerCli *command.DockerCli) *cobra.Command {","path":"cli/command/secret/cmd.go","position":5,"original_position":5,"commit_id":"cb8667862f0b996c0c6222bcd9c238efcd02eb15","original_commit_id":"cb8667862f0b996c0c6222bcd9c238efcd02eb15","user":{"login":"vdemeester","id":6508,"avatar_url":"https://avatars3.githubusercontent.com/u/6508?v=3","gravatar_id":"","url":"https://api.github.com/users/vdemeester","html_url":"https://github.com/vdemeester","followers_url":"https://api.github.com/users/vdemeester/followers","following_url":"https://api.github.com/users/vdemeester/following{/other_user}","gists_url":"https://api.github.com/users/vdemeester/gists{/gist_id}","starred_url":"https://api.github.com/users/vdemeester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vdemeester/subscriptions","organizations_url":"https://api.github.com/users/vdemeester/orgs","repos_url":"https://api.github.com/users/vdemeester/repos","events_url":"https://api.github.com/users/vdemeester/events{/privacy}","received_events_url":"https://api.github.com/users/vdemeester/received_events","type":"User","site_admin":false},"body":"here too, and below 😛 ","created_at":"2017-05-04T07:30:10Z","updated_at":"2017-05-04T07:32:01Z","html_url":"https://github.com/docker/cli/pull/27#discussion_r114712889","pull_request_url":"https://api.github.com/repos/docker/cli/pulls/27","_links":{"self":{"href":"https://api.github.com/repos/docker/cli/pulls/comments/114712889"},"html":{"href":"https://github.com/docker/cli/pull/27#discussion_r114712889"},"pull_request":{"href":"https://api.github.com/repos/docker/cli/pulls/27"}}},"pull_request":{"url":"https://api.github.com/repos/docker/cli/pulls/27","id":118868212,"html_url":"https://github.com/docker/cli/pull/27","diff_url":"https://github.com/docker/cli/pull/27.diff","patch_url":"https://github.com/docker/cli/pull/27.patch","issue_url":"https://api.github.com/repos/docker/cli/issues/27","number":27,"state":"open","locked":false,"title":"More linters and better circle-ci config","user":{"login":"dnephin","id":442180,"avatar_url":"https://avatars2.githubusercontent.com/u/442180?v=3","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"body":"Add the last 2 linters.\r\n\r\n`lll` checks line length. 200 is rather long, but it's a start\r\n`interfacer` checks for when an unnecessarily large interface is used.\r\n\r\nI've also updated the circleci config to run each of the steps in parallel. This cuts down the build time to just the slowest step, which is currently `cross`. With #26 cross is going to get even slower.\r\n\r\nWith this change we can also download binaries for each build: https://circleci.com/gh/docker/cli/51#artifacts/containers/1","created_at":"2017-05-03T22:26:23Z","updated_at":"2017-05-04T07:32:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"429acd76f7ebc805a55186db62680a6d80c8ee18","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/docker/cli/pulls/27/commits","review_comments_url":"https://api.github.com/repos/docker/cli/pulls/27/comments","review_comment_url":"https://api.github.com/repos/docker/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/docker/cli/issues/27/comments","statuses_url":"https://api.github.com/repos/docker/cli/statuses/cb8667862f0b996c0c6222bcd9c238efcd02eb15","head":{"label":"dnephin:more-linters","ref":"more-linters","sha":"cb8667862f0b996c0c6222bcd9c238efcd02eb15","user":{"login":"dnephin","id":442180,"avatar_url":"https://avatars2.githubusercontent.com/u/442180?v=3","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"repo":{"id":88645941,"name":"cli","full_name":"dnephin/cli","owner":{"login":"dnephin","id":442180,"avatar_url":"https://avatars2.githubusercontent.com/u/442180?v=3","gravatar_id":"","url":"https://api.github.com/users/dnephin","html_url":"https://github.com/dnephin","followers_url":"https://api.github.com/users/dnephin/followers","following_url":"https://api.github.com/users/dnephin/following{/other_user}","gists_url":"https://api.github.com/users/dnephin/gists{/gist_id}","starred_url":"https://api.github.com/users/dnephin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dnephin/subscriptions","organizations_url":"https://api.github.com/users/dnephin/orgs","repos_url":"https://api.github.com/users/dnephin/repos","events_url":"https://api.github.com/users/dnephin/events{/privacy}","received_events_url":"https://api.github.com/users/dnephin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dnephin/cli","description":"The Docker CLI","fork":true,"url":"https://api.github.com/repos/dnephin/cli","forks_url":"https://api.github.com/repos/dnephin/cli/forks","keys_url":"https://api.github.com/repos/dnephin/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dnephin/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dnephin/cli/teams","hooks_url":"https://api.github.com/repos/dnephin/cli/hooks","issue_events_url":"https://api.github.com/repos/dnephin/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dnephin/cli/events","assignees_url":"https://api.github.com/repos/dnephin/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dnephin/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dnephin/cli/tags","blobs_url":"https://api.github.com/repos/dnephin/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dnephin/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dnephin/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dnephin/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dnephin/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dnephin/cli/languages","stargazers_url":"https://api.github.com/repos/dnephin/cli/stargazers","contributors_url":"https://api.github.com/repos/dnephin/cli/contributors","subscribers_url":"https://api.github.com/repos/dnephin/cli/subscribers","subscription_url":"https://api.github.com/repos/dnephin/cli/subscription","commits_url":"https://api.github.com/repos/dnephin/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dnephin/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dnephin/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dnephin/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dnephin/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dnephin/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dnephin/cli/merges","archive_url":"https://api.github.com/repos/dnephin/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dnephin/cli/downloads","issues_url":"https://api.github.com/repos/dnephin/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dnephin/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dnephin/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dnephin/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dnephin/cli/labels{/name}","releases_url":"https://api.github.com/repos/dnephin/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dnephin/cli/deployments","created_at":"2017-04-18T16:17:25Z","updated_at":"2017-04-18T16:17:27Z","pushed_at":"2017-05-04T01:25:06Z","git_url":"git://github.com/dnephin/cli.git","ssh_url":"git@github.com:dnephin/cli.git","clone_url":"https://github.com/dnephin/cli.git","svn_url":"https://github.com/dnephin/cli","homepage":null,"size":4015,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"docker:master","ref":"master","sha":"1c0847b912ff6cf27c0e2d2f1531a9041f5fe12a","user":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"repo":{"id":88013053,"name":"cli","full_name":"docker/cli","owner":{"login":"docker","id":5429470,"avatar_url":"https://avatars2.githubusercontent.com/u/5429470?v=3","gravatar_id":"","url":"https://api.github.com/users/docker","html_url":"https://github.com/docker","followers_url":"https://api.github.com/users/docker/followers","following_url":"https://api.github.com/users/docker/following{/other_user}","gists_url":"https://api.github.com/users/docker/gists{/gist_id}","starred_url":"https://api.github.com/users/docker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/docker/subscriptions","organizations_url":"https://api.github.com/users/docker/orgs","repos_url":"https://api.github.com/users/docker/repos","events_url":"https://api.github.com/users/docker/events{/privacy}","received_events_url":"https://api.github.com/users/docker/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/docker/cli","description":"The Docker CLI","fork":false,"url":"https://api.github.com/repos/docker/cli","forks_url":"https://api.github.com/repos/docker/cli/forks","keys_url":"https://api.github.com/repos/docker/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/docker/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/docker/cli/teams","hooks_url":"https://api.github.com/repos/docker/cli/hooks","issue_events_url":"https://api.github.com/repos/docker/cli/issues/events{/number}","events_url":"https://api.github.com/repos/docker/cli/events","assignees_url":"https://api.github.com/repos/docker/cli/assignees{/user}","branches_url":"https://api.github.com/repos/docker/cli/branches{/branch}","tags_url":"https://api.github.com/repos/docker/cli/tags","blobs_url":"https://api.github.com/repos/docker/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/docker/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/docker/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/docker/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/docker/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/docker/cli/languages","stargazers_url":"https://api.github.com/repos/docker/cli/stargazers","contributors_url":"https://api.github.com/repos/docker/cli/contributors","subscribers_url":"https://api.github.com/repos/docker/cli/subscribers","subscription_url":"https://api.github.com/repos/docker/cli/subscription","commits_url":"https://api.github.com/repos/docker/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/docker/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/docker/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/docker/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/docker/cli/contents/{+path}","compare_url":"https://api.github.com/repos/docker/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/docker/cli/merges","archive_url":"https://api.github.com/repos/docker/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/docker/cli/downloads","issues_url":"https://api.github.com/repos/docker/cli/issues{/number}","pulls_url":"https://api.github.com/repos/docker/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/docker/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/docker/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/docker/cli/labels{/name}","releases_url":"https://api.github.com/repos/docker/cli/releases{/id}","deployments_url":"https://api.github.com/repos/docker/cli/deployments","created_at":"2017-04-12T05:27:42Z","updated_at":"2017-05-03T17:11:33Z","pushed_at":"2017-05-04T02:27:39Z","git_url":"git://github.com/docker/cli.git","ssh_url":"git@github.com:docker/cli.git","clone_url":"https://github.com/docker/cli.git","svn_url":"https://github.com/docker/cli","homepage":null,"size":4050,"stargazers_count":121,"watchers_count":121,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":6,"forks":20,"open_issues":6,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/docker/cli/pulls/27"},"html":{"href":"https://github.com/docker/cli/pull/27"},"issue":{"href":"https://api.github.com/repos/docker/cli/issues/27"},"comments":{"href":"https://api.github.com/repos/docker/cli/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/docker/cli/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/docker/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/docker/cli/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/docker/cli/statuses/cb8667862f0b996c0c6222bcd9c238efcd02eb15"}}}}
{"actor":{"display_login":"vdemeester"}}