{"action":"created","issue":{"url":"https://api.github.com/repos/eslint/eslint-release/issues/17","repository_url":"https://api.github.com/repos/eslint/eslint-release","labels_url":"https://api.github.com/repos/eslint/eslint-release/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/eslint/eslint-release/issues/17/comments","events_url":"https://api.github.com/repos/eslint/eslint-release/issues/17/events","html_url":"https://github.com/eslint/eslint-release/issues/17","id":225296411,"number":17,"title":"Handle globs in pkg.files","user":{"login":"btmills","id":1709537,"avatar_url":"https://avatars3.githubusercontent.com/u/1709537?v=3","gravatar_id":"","url":"https://api.github.com/users/btmills","html_url":"https://github.com/btmills","followers_url":"https://api.github.com/users/btmills/followers","following_url":"https://api.github.com/users/btmills/following{/other_user}","gists_url":"https://api.github.com/users/btmills/gists{/gist_id}","starred_url":"https://api.github.com/users/btmills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btmills/subscriptions","organizations_url":"https://api.github.com/users/btmills/orgs","repos_url":"https://api.github.com/users/btmills/repos","events_url":"https://api.github.com/users/btmills/events{/privacy}","received_events_url":"https://api.github.com/users/btmills/received_events","type":"User","site_admin":false},"labels":[{"id":318045416,"url":"https://api.github.com/repos/eslint/eslint-release/labels/triage","name":"triage","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-30T01:11:18Z","updated_at":"2017-04-30T01:24:26Z","closed_at":null,"body":"During the \"Fixing line endings\" step, eslint-release expects only exact file paths in `pkg.files`, not globs. Because of this, including `lib/*.js` in `pkg.files` causes eslint-release to throw an exception (included below) during the release process.\r\n\r\nThe other @eslint projects use `lib` and `index.js`, for example, but [eslint-plugin-markdown](https://github.com/eslint/eslint-plugin-markdown) includes a [`.eslintrc.yml` file](https://github.com/eslint/eslint-plugin-markdown/blob/8d5ae99455015f090f4f4c3311c0a17716765750/lib/.eslintrc.yml) in the `lib/` directory, which we don't want to include in the build.\r\n\r\nDiscovered in https://github.com/eslint/eslint-plugin-markdown/pull/67 due to a failed Jenkins build:\r\n\r\n```\r\nFixing line endings\r\nfs.js:839\r\n  return binding.lstat(pathModule._makeLong(path));\r\n                 ^\r\n\r\nError: ENOENT: no such file or directory, lstat 'lib/*.js'\r\n    at Error (native)\r\n    at Object.fs.lstatSync (fs.js:839:18)\r\n    at /var/lib/jenkins/workspace/Releases/eslint-plugin-markdown Release/eslint-plugin-markdown/node_modules/eslint-release/lib/release-ops.js:398:19\r\n    at Array.filter (native)\r\n    at Object.release (/var/lib/jenkins/workspace/Releases/eslint-plugin-markdown Release/eslint-plugin-markdown/node_modules/eslint-release/lib/release-ops.js:397:28)\r\n    at Object.<anonymous> (/var/lib/jenkins/workspace/Releases/eslint-plugin-markdown Release/eslint-plugin-markdown/node_modules/eslint-release/bin/eslint-prerelease.js:35:12)\r\n    at Module._compile (module.js:409:26)\r\n    at Object.Module._extensions..js (module.js:416:10)\r\n    at Module.load (module.js:343:32)\r\n    at Function.Module._load (module.js:300:12)\r\n```"},"comment":{"url":"https://api.github.com/repos/eslint/eslint-release/issues/comments/298204858","html_url":"https://github.com/eslint/eslint-release/issues/17#issuecomment-298204858","issue_url":"https://api.github.com/repos/eslint/eslint-release/issues/17","id":298204858,"user":{"login":"not-an-aardvark","id":11638619,"avatar_url":"https://avatars1.githubusercontent.com/u/11638619?v=3","gravatar_id":"","url":"https://api.github.com/users/not-an-aardvark","html_url":"https://github.com/not-an-aardvark","followers_url":"https://api.github.com/users/not-an-aardvark/followers","following_url":"https://api.github.com/users/not-an-aardvark/following{/other_user}","gists_url":"https://api.github.com/users/not-an-aardvark/gists{/gist_id}","starred_url":"https://api.github.com/users/not-an-aardvark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/not-an-aardvark/subscriptions","organizations_url":"https://api.github.com/users/not-an-aardvark/orgs","repos_url":"https://api.github.com/users/not-an-aardvark/repos","events_url":"https://api.github.com/users/not-an-aardvark/events{/privacy}","received_events_url":"https://api.github.com/users/not-an-aardvark/received_events","type":"User","site_admin":false},"created_at":"2017-04-30T01:24:26Z","updated_at":"2017-04-30T01:24:26Z","body":"It looks like we're expanding the globs so that we can convert all line endings to unix.\r\n\r\nIs it actually necessary to do this? It seems like it would be better to just use the `linebreak-style` rule and/or `.gitattributes` rather than changing the contents of the files as part of the release process."}}
{"actor":{"display_login":"not-an-aardvark"}}