{"action":"closed","issue":{"url":"https://api.github.com/repos/SIMEXP/niak/issues/296","repository_url":"https://api.github.com/repos/SIMEXP/niak","labels_url":"https://api.github.com/repos/SIMEXP/niak/issues/296/labels{/name}","comments_url":"https://api.github.com/repos/SIMEXP/niak/issues/296/comments","events_url":"https://api.github.com/repos/SIMEXP/niak/issues/296/events","html_url":"https://github.com/SIMEXP/niak/issues/296","id":208740871,"number":296,"title":"mask comparison in niak_brick_connectome_multiscale breaks","user":{"login":"surchs","id":1302022,"avatar_url":"https://avatars1.githubusercontent.com/u/1302022?v=3","gravatar_id":"","url":"https://api.github.com/users/surchs","html_url":"https://github.com/surchs","followers_url":"https://api.github.com/users/surchs/followers","following_url":"https://api.github.com/users/surchs/following{/other_user}","gists_url":"https://api.github.com/users/surchs/gists{/gist_id}","starred_url":"https://api.github.com/users/surchs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/surchs/subscriptions","organizations_url":"https://api.github.com/users/surchs/orgs","repos_url":"https://api.github.com/users/surchs/repos","events_url":"https://api.github.com/users/surchs/events{/privacy}","received_events_url":"https://api.github.com/users/surchs/received_events","type":"User","site_admin":false},"labels":[{"id":113072884,"url":"https://api.github.com/repos/SIMEXP/niak/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-02-19T19:43:18Z","updated_at":"2017-03-07T16:18:25Z","closed_at":"2017-03-07T16:18:25Z","body":"[niak_brick_connectome_multiscale](https://github.com/SIMEXP/niak/blob/master/extensions/glm_connectome/niak_brick_connectome_multiscale.m#L495) reads optional extra header information called `mask_suppressed` and `mask_scrubbing` and then performs a logical or on them. This breaks in Octave (4.0.2) and Matlab (2016b) if the two masks have different sizes (i.e. they have different length).\r\n\r\n```\r\nmx_el_or: nonconformant arguments (op1 is 122x1, op2 is 118x1)\r\nFile /usr/local/niak/extensions/glm_connectome/niak_brick_connectome_multiscale.m at line 495\r\nFile /usr/local/niak/extensions/glm_connectome/niak_brick_connectome_multiscale.m at line 377\r\nFile /usr/local/niak/extensions/psom-2.2.2/psom_run_job.m at line 185\r\nFile /usr/local/niak/extensions/psom-2.2.2/psom_run_job.m at line 106\r\nFile /usr/local/niak/extensions/psom-2.2.2/psom_worker.m at line 161\r\n```\r\n\r\nI don't know if these masks are of different size by design or if that itself is a bug but I encountered them in the simons_vip dataset. At least there should probably be some kind of shape check that lets this break gracefully if them having different sizes is unintended."}}
{"actor":{"display_login":"poquirion"}}