{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/141641291","pull_request_review_id":65887659,"id":141641291,"diff_hunk":"@@ -117,6 +117,10 @@\n \n   private static final String LOCAL_SEARCH_PARAMETER = \"local\";\n \n+  private static final String USERNAME_PROPERTY = \"username\";\n+\n+  private static final String PASSWORD_PROPERTY = \"password\";","path":"catalog/opensearch/catalog-opensearch-source/src/main/java/ddf/catalog/source/opensearch/impl/OpenSearchSource.java","position":6,"original_position":6,"commit_id":"ecdc00c9d6f97554a5c24cfdb4b18e5afa897b7d","original_commit_id":"ecdc00c9d6f97554a5c24cfdb4b18e5afa897b7d","user":{"login":"codice-bot","id":28742502,"avatar_url":"https://avatars1.githubusercontent.com/u/28742502?v=4","gravatar_id":"","url":"https://api.github.com/users/codice-bot","html_url":"https://github.com/codice-bot","followers_url":"https://api.github.com/users/codice-bot/followers","following_url":"https://api.github.com/users/codice-bot/following{/other_user}","gists_url":"https://api.github.com/users/codice-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codice-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice-bot/subscriptions","organizations_url":"https://api.github.com/users/codice-bot/orgs","repos_url":"https://api.github.com/users/codice-bot/repos","events_url":"https://api.github.com/users/codice-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codice-bot/received_events","type":"User","site_admin":false},"body":"![BLOCKER](https://sonarsource.github.io/sonar-github/severity-blocker.png 'Severity: BLOCKER') 'PASSWORD' detected in this expression, review this potentially hardcoded credential. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS2068)\n","created_at":"2017-09-28T14:52:17Z","updated_at":"2017-09-28T14:52:17Z","html_url":"https://github.com/codice/ddf/pull/2364#discussion_r141641291","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/2364","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/141641291"},"html":{"href":"https://github.com/codice/ddf/pull/2364#discussion_r141641291"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/2364"}}},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/2364","id":143191322,"html_url":"https://github.com/codice/ddf/pull/2364","diff_url":"https://github.com/codice/ddf/pull/2364.diff","patch_url":"https://github.com/codice/ddf/pull/2364.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/2364","number":2364,"state":"open","locked":false,"title":"DDF-3318 Update URLResourceReader usages to include basic auth info","user":{"login":"kcrowe01","id":6457885,"avatar_url":"https://avatars2.githubusercontent.com/u/6457885?v=4","gravatar_id":"","url":"https://api.github.com/users/kcrowe01","html_url":"https://github.com/kcrowe01","followers_url":"https://api.github.com/users/kcrowe01/followers","following_url":"https://api.github.com/users/kcrowe01/following{/other_user}","gists_url":"https://api.github.com/users/kcrowe01/gists{/gist_id}","starred_url":"https://api.github.com/users/kcrowe01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcrowe01/subscriptions","organizations_url":"https://api.github.com/users/kcrowe01/orgs","repos_url":"https://api.github.com/users/kcrowe01/repos","events_url":"https://api.github.com/users/kcrowe01/events{/privacy}","received_events_url":"https://api.github.com/users/kcrowe01/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nUpdate CSW and OpenSearch sources to include basic auth info in the retrieveResource properties map.\r\n#### Who is reviewing it? \r\n@vinamartin @mcalcote \r\n#### Choose 2 committers to review/merge the PR. \r\n@clockard\r\n@rzwiefel\r\n#### How should this be tested? (List steps with links to updated documentation)\r\nInstall DDF and setup federation to query over OpenSearch and CSW endpoints. The DDF being queried should be setup to only allow basic authentication for the OpenSearch and CSW endpoints. Verify that a resource can be downloaded over both of these endpoints only when a valid user/pass is provided in the source setup. \r\n#### What are the relevant tickets?\r\n[DDF-3318](https://codice.atlassian.net/browse/DDF-3318)\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2017-09-26T17:05:28Z","updated_at":"2017-09-28T14:52:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"970dce8a1a7bef8b7ab1ff8f0a34bc2faef44151","assignee":{"login":"clockard","id":5248090,"avatar_url":"https://avatars1.githubusercontent.com/u/5248090?v=4","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false},"assignees":[{"login":"clockard","id":5248090,"avatar_url":"https://avatars1.githubusercontent.com/u/5248090?v=4","gravatar_id":"","url":"https://api.github.com/users/clockard","html_url":"https://github.com/clockard","followers_url":"https://api.github.com/users/clockard/followers","following_url":"https://api.github.com/users/clockard/following{/other_user}","gists_url":"https://api.github.com/users/clockard/gists{/gist_id}","starred_url":"https://api.github.com/users/clockard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clockard/subscriptions","organizations_url":"https://api.github.com/users/clockard/orgs","repos_url":"https://api.github.com/users/clockard/repos","events_url":"https://api.github.com/users/clockard/events{/privacy}","received_events_url":"https://api.github.com/users/clockard/received_events","type":"User","site_admin":false},{"login":"rzwiefel","id":9013416,"avatar_url":"https://avatars0.githubusercontent.com/u/9013416?v=4","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bdeining","id":6551038,"avatar_url":"https://avatars2.githubusercontent.com/u/6551038?v=4","gravatar_id":"","url":"https://api.github.com/users/bdeining","html_url":"https://github.com/bdeining","followers_url":"https://api.github.com/users/bdeining/followers","following_url":"https://api.github.com/users/bdeining/following{/other_user}","gists_url":"https://api.github.com/users/bdeining/gists{/gist_id}","starred_url":"https://api.github.com/users/bdeining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdeining/subscriptions","organizations_url":"https://api.github.com/users/bdeining/orgs","repos_url":"https://api.github.com/users/bdeining/repos","events_url":"https://api.github.com/users/bdeining/events{/privacy}","received_events_url":"https://api.github.com/users/bdeining/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/2364/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/2364/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/2364/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/ecdc00c9d6f97554a5c24cfdb4b18e5afa897b7d","head":{"label":"kcrowe01:DDF-3318","ref":"DDF-3318","sha":"ecdc00c9d6f97554a5c24cfdb4b18e5afa897b7d","user":{"login":"kcrowe01","id":6457885,"avatar_url":"https://avatars2.githubusercontent.com/u/6457885?v=4","gravatar_id":"","url":"https://api.github.com/users/kcrowe01","html_url":"https://github.com/kcrowe01","followers_url":"https://api.github.com/users/kcrowe01/followers","following_url":"https://api.github.com/users/kcrowe01/following{/other_user}","gists_url":"https://api.github.com/users/kcrowe01/gists{/gist_id}","starred_url":"https://api.github.com/users/kcrowe01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcrowe01/subscriptions","organizations_url":"https://api.github.com/users/kcrowe01/orgs","repos_url":"https://api.github.com/users/kcrowe01/repos","events_url":"https://api.github.com/users/kcrowe01/events{/privacy}","received_events_url":"https://api.github.com/users/kcrowe01/received_events","type":"User","site_admin":false},"repo":{"id":83078224,"name":"ddf","full_name":"kcrowe01/ddf","owner":{"login":"kcrowe01","id":6457885,"avatar_url":"https://avatars2.githubusercontent.com/u/6457885?v=4","gravatar_id":"","url":"https://api.github.com/users/kcrowe01","html_url":"https://github.com/kcrowe01","followers_url":"https://api.github.com/users/kcrowe01/followers","following_url":"https://api.github.com/users/kcrowe01/following{/other_user}","gists_url":"https://api.github.com/users/kcrowe01/gists{/gist_id}","starred_url":"https://api.github.com/users/kcrowe01/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kcrowe01/subscriptions","organizations_url":"https://api.github.com/users/kcrowe01/orgs","repos_url":"https://api.github.com/users/kcrowe01/repos","events_url":"https://api.github.com/users/kcrowe01/events{/privacy}","received_events_url":"https://api.github.com/users/kcrowe01/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kcrowe01/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/kcrowe01/ddf","forks_url":"https://api.github.com/repos/kcrowe01/ddf/forks","keys_url":"https://api.github.com/repos/kcrowe01/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kcrowe01/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kcrowe01/ddf/teams","hooks_url":"https://api.github.com/repos/kcrowe01/ddf/hooks","issue_events_url":"https://api.github.com/repos/kcrowe01/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/kcrowe01/ddf/events","assignees_url":"https://api.github.com/repos/kcrowe01/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/kcrowe01/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/kcrowe01/ddf/tags","blobs_url":"https://api.github.com/repos/kcrowe01/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kcrowe01/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kcrowe01/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/kcrowe01/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kcrowe01/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/kcrowe01/ddf/languages","stargazers_url":"https://api.github.com/repos/kcrowe01/ddf/stargazers","contributors_url":"https://api.github.com/repos/kcrowe01/ddf/contributors","subscribers_url":"https://api.github.com/repos/kcrowe01/ddf/subscribers","subscription_url":"https://api.github.com/repos/kcrowe01/ddf/subscription","commits_url":"https://api.github.com/repos/kcrowe01/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/kcrowe01/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/kcrowe01/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/kcrowe01/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/kcrowe01/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/kcrowe01/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kcrowe01/ddf/merges","archive_url":"https://api.github.com/repos/kcrowe01/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kcrowe01/ddf/downloads","issues_url":"https://api.github.com/repos/kcrowe01/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/kcrowe01/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/kcrowe01/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/kcrowe01/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kcrowe01/ddf/labels{/name}","releases_url":"https://api.github.com/repos/kcrowe01/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/kcrowe01/ddf/deployments","created_at":"2017-02-24T20:03:37Z","updated_at":"2017-02-24T20:03:55Z","pushed_at":"2017-09-28T13:46:31Z","git_url":"git://github.com/kcrowe01/ddf.git","ssh_url":"git@github.com:kcrowe01/ddf.git","clone_url":"https://github.com/kcrowe01/ddf.git","svn_url":"https://github.com/kcrowe01/ddf","homepage":"http://ddf.codice.org","size":330522,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"9e51ea0e63f0d8683ef310ac602d728a01d2574f","user":{"login":"codice","id":2386734,"avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"name":"ddf","full_name":"codice/ddf","owner":{"login":"codice","id":2386734,"avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/codice/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2017-09-13T18:51:38Z","pushed_at":"2017-09-28T14:49:11Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":345563,"stargazers_count":63,"watchers_count":63,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":121,"mirror_url":null,"open_issues_count":43,"forks":121,"open_issues":43,"watchers":63,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/2364"},"html":{"href":"https://github.com/codice/ddf/pull/2364"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/2364"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/2364/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/2364/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/2364/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/ecdc00c9d6f97554a5c24cfdb4b18e5afa897b7d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codice-bot"}}