{"action":"closed","number":14065,"pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/14065","id":102727688,"html_url":"https://github.com/angular/angular/pull/14065","diff_url":"https://github.com/angular/angular/pull/14065.diff","patch_url":"https://github.com/angular/angular/pull/14065.patch","issue_url":"https://api.github.com/repos/angular/angular/issues/14065","number":14065,"state":"closed","locked":false,"title":"fix(upgrade/static): ensure upgraded injector is initialized early enough","user":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"body":"This change ensures that the upgraded AngularJS injector is initialized\r\nbefore the application run blocks are executed.\r\n\r\nCloses #13811\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [x] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n```\r\n[x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n**What is the current behavior?** (You can also link to an open issue here)\r\n\r\nThe upgraded injector is initialized in a run block that is executed after the application's run\r\nblocks are executed, which means that this injector is not available to downgraded Angular\r\nservices that are used in AngularJS run blocks.\r\n\r\n**What is the new behavior?**\r\n\r\nThe injector is now initialized before the application run blocks are executed.\r\n\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n```\r\n[ ] Yes\r\n[x] No\r\n```\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n\r\n**Other information**:\r\n\r\n","created_at":"2017-01-23T14:23:51Z","updated_at":"2017-01-24T22:48:03Z","closed_at":"2017-01-24T22:48:03Z","merged_at":"2017-01-24T22:48:03Z","merge_commit_sha":"6152eb24bc45660eaedba474e9b5559ee8e663ea","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/angular/angular/pulls/14065/commits","review_comments_url":"https://api.github.com/repos/angular/angular/pulls/14065/comments","review_comment_url":"https://api.github.com/repos/angular/angular/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/angular/issues/14065/comments","statuses_url":"https://api.github.com/repos/angular/angular/statuses/500ea4b96b6a2a252e8de07498ef9760de8f8bdb","head":{"label":"petebacondarwin:issue-13811","ref":"issue-13811","sha":"500ea4b96b6a2a252e8de07498ef9760de8f8bdb","user":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"repo":{"id":27181953,"name":"angular","full_name":"petebacondarwin/angular","owner":{"login":"petebacondarwin","id":15655,"avatar_url":"https://avatars.githubusercontent.com/u/15655?v=3","gravatar_id":"","url":"https://api.github.com/users/petebacondarwin","html_url":"https://github.com/petebacondarwin","followers_url":"https://api.github.com/users/petebacondarwin/followers","following_url":"https://api.github.com/users/petebacondarwin/following{/other_user}","gists_url":"https://api.github.com/users/petebacondarwin/gists{/gist_id}","starred_url":"https://api.github.com/users/petebacondarwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petebacondarwin/subscriptions","organizations_url":"https://api.github.com/users/petebacondarwin/orgs","repos_url":"https://api.github.com/users/petebacondarwin/repos","events_url":"https://api.github.com/users/petebacondarwin/events{/privacy}","received_events_url":"https://api.github.com/users/petebacondarwin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petebacondarwin/angular","description":null,"fork":true,"url":"https://api.github.com/repos/petebacondarwin/angular","forks_url":"https://api.github.com/repos/petebacondarwin/angular/forks","keys_url":"https://api.github.com/repos/petebacondarwin/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petebacondarwin/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petebacondarwin/angular/teams","hooks_url":"https://api.github.com/repos/petebacondarwin/angular/hooks","issue_events_url":"https://api.github.com/repos/petebacondarwin/angular/issues/events{/number}","events_url":"https://api.github.com/repos/petebacondarwin/angular/events","assignees_url":"https://api.github.com/repos/petebacondarwin/angular/assignees{/user}","branches_url":"https://api.github.com/repos/petebacondarwin/angular/branches{/branch}","tags_url":"https://api.github.com/repos/petebacondarwin/angular/tags","blobs_url":"https://api.github.com/repos/petebacondarwin/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petebacondarwin/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petebacondarwin/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/petebacondarwin/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petebacondarwin/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/petebacondarwin/angular/languages","stargazers_url":"https://api.github.com/repos/petebacondarwin/angular/stargazers","contributors_url":"https://api.github.com/repos/petebacondarwin/angular/contributors","subscribers_url":"https://api.github.com/repos/petebacondarwin/angular/subscribers","subscription_url":"https://api.github.com/repos/petebacondarwin/angular/subscription","commits_url":"https://api.github.com/repos/petebacondarwin/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/petebacondarwin/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/petebacondarwin/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/petebacondarwin/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/petebacondarwin/angular/contents/{+path}","compare_url":"https://api.github.com/repos/petebacondarwin/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petebacondarwin/angular/merges","archive_url":"https://api.github.com/repos/petebacondarwin/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petebacondarwin/angular/downloads","issues_url":"https://api.github.com/repos/petebacondarwin/angular/issues{/number}","pulls_url":"https://api.github.com/repos/petebacondarwin/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/petebacondarwin/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/petebacondarwin/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petebacondarwin/angular/labels{/name}","releases_url":"https://api.github.com/repos/petebacondarwin/angular/releases{/id}","deployments_url":"https://api.github.com/repos/petebacondarwin/angular/deployments","created_at":"2014-11-26T15:01:46Z","updated_at":"2016-10-14T11:50:54Z","pushed_at":"2017-01-23T14:20:23Z","git_url":"git://github.com/petebacondarwin/angular.git","ssh_url":"git@github.com:petebacondarwin/angular.git","clone_url":"https://github.com/petebacondarwin/angular.git","svn_url":"https://github.com/petebacondarwin/angular","homepage":null,"size":35381,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"0589f93e41f12eee59c18b9e6c29b2b4517facbc","user":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":24195339,"name":"angular","full_name":"angular/angular","owner":{"login":"angular","id":139426,"avatar_url":"https://avatars.githubusercontent.com/u/139426?v=3","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/angular","description":"One framework. Mobile & desktop.","fork":false,"url":"https://api.github.com/repos/angular/angular","forks_url":"https://api.github.com/repos/angular/angular/forks","keys_url":"https://api.github.com/repos/angular/angular/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/angular/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/angular/teams","hooks_url":"https://api.github.com/repos/angular/angular/hooks","issue_events_url":"https://api.github.com/repos/angular/angular/issues/events{/number}","events_url":"https://api.github.com/repos/angular/angular/events","assignees_url":"https://api.github.com/repos/angular/angular/assignees{/user}","branches_url":"https://api.github.com/repos/angular/angular/branches{/branch}","tags_url":"https://api.github.com/repos/angular/angular/tags","blobs_url":"https://api.github.com/repos/angular/angular/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/angular/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/angular/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/angular/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/angular/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/angular/languages","stargazers_url":"https://api.github.com/repos/angular/angular/stargazers","contributors_url":"https://api.github.com/repos/angular/angular/contributors","subscribers_url":"https://api.github.com/repos/angular/angular/subscribers","subscription_url":"https://api.github.com/repos/angular/angular/subscription","commits_url":"https://api.github.com/repos/angular/angular/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/angular/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/angular/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/angular/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/angular/contents/{+path}","compare_url":"https://api.github.com/repos/angular/angular/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/angular/merges","archive_url":"https://api.github.com/repos/angular/angular/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/angular/downloads","issues_url":"https://api.github.com/repos/angular/angular/issues{/number}","pulls_url":"https://api.github.com/repos/angular/angular/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/angular/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/angular/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/angular/labels{/name}","releases_url":"https://api.github.com/repos/angular/angular/releases{/id}","deployments_url":"https://api.github.com/repos/angular/angular/deployments","created_at":"2014-09-18T16:12:01Z","updated_at":"2017-01-24T22:34:39Z","pushed_at":"2017-01-24T22:48:03Z","git_url":"git://github.com/angular/angular.git","ssh_url":"git@github.com:angular/angular.git","clone_url":"https://github.com/angular/angular.git","svn_url":"https://github.com/angular/angular","homepage":"https://angular.io","size":36105,"stargazers_count":20026,"watchers_count":20026,"language":"TypeScript","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5184,"mirror_url":null,"open_issues_count":1071,"forks":5184,"open_issues":1071,"watchers":20026,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/angular/pulls/14065"},"html":{"href":"https://github.com/angular/angular/pull/14065"},"issue":{"href":"https://api.github.com/repos/angular/angular/issues/14065"},"comments":{"href":"https://api.github.com/repos/angular/angular/issues/14065/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/angular/pulls/14065/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/angular/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/angular/pulls/14065/commits"},"statuses":{"href":"https://api.github.com/repos/angular/angular/statuses/500ea4b96b6a2a252e8de07498ef9760de8f8bdb"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"alxhub","id":4175141,"avatar_url":"https://avatars.githubusercontent.com/u/4175141?v=3","gravatar_id":"","url":"https://api.github.com/users/alxhub","html_url":"https://github.com/alxhub","followers_url":"https://api.github.com/users/alxhub/followers","following_url":"https://api.github.com/users/alxhub/following{/other_user}","gists_url":"https://api.github.com/users/alxhub/gists{/gist_id}","starred_url":"https://api.github.com/users/alxhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alxhub/subscriptions","organizations_url":"https://api.github.com/users/alxhub/orgs","repos_url":"https://api.github.com/users/alxhub/repos","events_url":"https://api.github.com/users/alxhub/events{/privacy}","received_events_url":"https://api.github.com/users/alxhub/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":30,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"alxhub"}}