{"action":"created","issue":{"url":"https://api.github.com/repos/Ismaestro/angular4-example-app/issues/15","repository_url":"https://api.github.com/repos/Ismaestro/angular4-example-app","labels_url":"https://api.github.com/repos/Ismaestro/angular4-example-app/issues/15/labels{/name}","comments_url":"https://api.github.com/repos/Ismaestro/angular4-example-app/issues/15/comments","events_url":"https://api.github.com/repos/Ismaestro/angular4-example-app/issues/15/events","html_url":"https://github.com/Ismaestro/angular4-example-app/issues/15","id":266213141,"number":15,"title":"Angular styleguide","user":{"login":"verebelyin","id":5074662,"avatar_url":"https://avatars1.githubusercontent.com/u/5074662?v=4","gravatar_id":"","url":"https://api.github.com/users/verebelyin","html_url":"https://github.com/verebelyin","followers_url":"https://api.github.com/users/verebelyin/followers","following_url":"https://api.github.com/users/verebelyin/following{/other_user}","gists_url":"https://api.github.com/users/verebelyin/gists{/gist_id}","starred_url":"https://api.github.com/users/verebelyin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/verebelyin/subscriptions","organizations_url":"https://api.github.com/users/verebelyin/orgs","repos_url":"https://api.github.com/users/verebelyin/repos","events_url":"https://api.github.com/users/verebelyin/events{/privacy}","received_events_url":"https://api.github.com/users/verebelyin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-17T17:28:54Z","updated_at":"2017-10-18T09:07:22Z","closed_at":null,"author_association":"NONE","body":"Hi!\r\n\r\nI bumped into this project while I was looking for an example app that is following the the official [Angular styleguide](https://angular.io/guide/styleguide).\r\n\r\nI see that you are trying to follow the guidelines, but there is one thing, which is against it. Specifically against this [point](https://angular.io/guide/styleguide#shared-feature-module):\r\n```Avoid providing services in shared modules. Services are usually singletons that are provided once for the entire application or in a particular feature module.```\r\n\r\nIs it intentional that you have the `src/app/shared/services/` folder, and services in it, which are used throughout the app?\r\n\r\nAccording to the [Angular styleguide](https://angular.io/guide/styleguide#core-feature-module), it should be placed under `src/app/core`.\r\n\r\nThanks,\r\nNorbert"},"comment":{"url":"https://api.github.com/repos/Ismaestro/angular4-example-app/issues/comments/337515695","html_url":"https://github.com/Ismaestro/angular4-example-app/issues/15#issuecomment-337515695","issue_url":"https://api.github.com/repos/Ismaestro/angular4-example-app/issues/15","id":337515695,"user":{"login":"Ismaestro","id":10084945,"avatar_url":"https://avatars0.githubusercontent.com/u/10084945?v=4","gravatar_id":"","url":"https://api.github.com/users/Ismaestro","html_url":"https://github.com/Ismaestro","followers_url":"https://api.github.com/users/Ismaestro/followers","following_url":"https://api.github.com/users/Ismaestro/following{/other_user}","gists_url":"https://api.github.com/users/Ismaestro/gists{/gist_id}","starred_url":"https://api.github.com/users/Ismaestro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ismaestro/subscriptions","organizations_url":"https://api.github.com/users/Ismaestro/orgs","repos_url":"https://api.github.com/users/Ismaestro/repos","events_url":"https://api.github.com/users/Ismaestro/events{/privacy}","received_events_url":"https://api.github.com/users/Ismaestro/received_events","type":"User","site_admin":false},"created_at":"2017-10-18T09:07:22Z","updated_at":"2017-10-18T09:07:22Z","author_association":"OWNER","body":"Hi Norbert!\r\n\r\nYou are completely right, so I've made some changes.\r\n\r\nYou can see them [here](https://github.com/Ismaestro/angular4-example-app/commit/ae53c7847e9df48e1036b61a1e90c32cbaa2e956).\r\n\r\nThanks and best regards."}}
{"actor":{"display_login":"Ismaestro"}}