{"action":"created","issue":{"url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/165","repository_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite","labels_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/165/labels{/name}","comments_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/165/comments","events_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/165/events","html_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/165","id":224291978,"number":165,"title":"Hotfix/calendars","user":{"login":"ecbrady","id":12305705,"avatar_url":"https://avatars0.githubusercontent.com/u/12305705?v=3","gravatar_id":"","url":"https://api.github.com/users/ecbrady","html_url":"https://github.com/ecbrady","followers_url":"https://api.github.com/users/ecbrady/followers","following_url":"https://api.github.com/users/ecbrady/following{/other_user}","gists_url":"https://api.github.com/users/ecbrady/gists{/gist_id}","starred_url":"https://api.github.com/users/ecbrady/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ecbrady/subscriptions","organizations_url":"https://api.github.com/users/ecbrady/orgs","repos_url":"https://api.github.com/users/ecbrady/repos","events_url":"https://api.github.com/users/ecbrady/events{/privacy}","received_events_url":"https://api.github.com/users/ecbrady/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-04-25T22:35:19Z","updated_at":"2017-04-26T22:56:12Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/pulls/165","html_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/165","diff_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/165.diff","patch_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/165.patch"},"body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/byu-oit-appdev/ios-byusuite/165)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/comments/297564503","html_url":"https://github.com/byu-oit-appdev/ios-byuSuite/pull/165#issuecomment-297564503","issue_url":"https://api.github.com/repos/byu-oit-appdev/ios-byuSuite/issues/165","id":297564503,"user":{"login":"romrell4","id":15692420,"avatar_url":"https://avatars3.githubusercontent.com/u/15692420?v=3","gravatar_id":"","url":"https://api.github.com/users/romrell4","html_url":"https://github.com/romrell4","followers_url":"https://api.github.com/users/romrell4/followers","following_url":"https://api.github.com/users/romrell4/following{/other_user}","gists_url":"https://api.github.com/users/romrell4/gists{/gist_id}","starred_url":"https://api.github.com/users/romrell4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romrell4/subscriptions","organizations_url":"https://api.github.com/users/romrell4/orgs","repos_url":"https://api.github.com/users/romrell4/repos","events_url":"https://api.github.com/users/romrell4/events{/privacy}","received_events_url":"https://api.github.com/users/romrell4/received_events","type":"User","site_admin":false},"created_at":"2017-04-26T22:56:12Z","updated_at":"2017-04-26T22:56:12Z","body":"\n\n\n\nReviewed 1 of 8 files at r4, 3 of 3 files at r6.\nReview status: all files reviewed at latest revision, 8 unresolved discussions.\n\n---\n\n*[byuSuite/Apps/Calendars/controller/CalendarsEventDetailViewController.m, line 61 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/165#-Kif_5UdPoNiles1P4Pz:-KigS2MDOIXk5n1-fgGM:bkjhfbk) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/d8f381d4db4d0cc82505c165b9b0fde52d40d51a/byuSuite/Apps/Calendars/controller/CalendarsEventDetailViewController.m#L61)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nWhat do you mean?\n</blockquote></details>\n\nWhen you use \"dequeueReusableCell...\", it gives you a recycled cell... Sometime, it already has stuff from being previously loaded. You'll overwrite most of that, but if you don't have an else here, it might have started with userInteractionEnabled as YES, and you won't reset it. Talk to me if you have questions\n\n---\n\n*[byuSuite/Apps/Calendars/controller/CalendarsEventsViewController.m, line 88 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/165#-KifbSOemtfGBBHiPT7U:-KigS_tnW7rpnliwdbvC:b-u1fnkc) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/d8f381d4db4d0cc82505c165b9b0fde52d40d51a/byuSuite/Apps/Calendars/controller/CalendarsEventsViewController.m#L88)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nYeah because we're sorting by date they'll stay in order when added to the array. It makes more sense to me to sort before adding so we're only sorting a small packet instead of sorting the entire list multiple times.\n</blockquote></details>\n\nWhere do we do the sorting? If that's in the client, it should be here. \n\nThat makes sense. Let's put a comment explaining why that works (the sorting of small batches)\n\n---\n\n*[byuSuite/Apps/Calendars/controller/CalendarsViewController.m, line 69 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/165#-KifbjGZ1h4W--aUs2ow:-KigSt55fGzJvqpUwmZ-:bfik6t9) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/d8f381d4db4d0cc82505c165b9b0fde52d40d51a/byuSuite/Apps/Calendars/controller/CalendarsViewController.m#L69)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nNo. We do it in the client so that the view controller gets one list of all of them.\n</blockquote></details>\n\nMove that into here. That's business logic that the client shouldn't have to worry about. It should only be worried about making async calls and parsing data\n\n---\n\n*[byuSuite/Apps/Calendars/model/CalendarEvent.m, line 21 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/165#-KifcEzvpHA9TqQxxBZ0:-KigTISc4pT05Mt6VdtJ:b-9oxxji) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/d8f381d4db4d0cc82505c165b9b0fde52d40d51a/byuSuite/Apps/Calendars/model/CalendarEvent.m#L21)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nDone.\n</blockquote></details>\n\nReorder the other ones as well\n\n---\n\n*[byuSuite/Apps/Calendars/model/CalendarsClient.m, line 36 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/165#-KifcrB8jU24yMOjsbsL:-KigTVeiqB3KNYcWkVSk:b2nhtan) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/d8f381d4db4d0cc82505c165b9b0fde52d40d51a/byuSuite/Apps/Calendars/model/CalendarsClient.m#L36)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nWe'd be generating the CalendarCategory object from the VC. Would that be okay?\n</blockquote></details>\n\nYup\n\n---\n\n*[byuSuite/Apps/Calendars/model/CalendarsClient.m, line 49 at r4](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/165#-KifdIKn3CDREHw4aj3s:-KigT_YGCHRaRmjcakrg:b-u402xb) ([raw file](https://github.com/byu-oit-appdev/ios-byusuite/blob/d8f381d4db4d0cc82505c165b9b0fde52d40d51a/byuSuite/Apps/Calendars/model/CalendarsClient.m#L49)):*\n<details><summary><i>Previously, ecbrady (Erik Brady) wrote…</i></summary><blockquote>\n\nThey seem odd to me as well. Those are the query params Katria gave me. So far they seem to be working without being url encoded\n</blockquote></details>\n\nI think they'll break with swift.... Could you check if \"[\" and \"]\" will get urlencoded?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/byu-oit-appdev/ios-byusuite/165)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"romrell4"}}