{"action":"created","comment":{"url":"https://api.github.com/repos/kickstarter/android-oss/pulls/comments/115998825","pull_request_review_id":37583609,"id":115998825,"diff_hunk":"@@ -23,8 +23,9 @@\n   private final CompositeSubscription subscriptions = new CompositeSubscription();\n \n   private final PublishSubject<ActivityResult> activityResult = PublishSubject.create();\n-\n   private final PublishSubject<Intent> intent = PublishSubject.create();\n+  protected final PublishSubject<ActivityEvent> onResume = PublishSubject.create();","path":"app/src/main/java/com/kickstarter/libs/ActivityViewModel.java","position":6,"original_position":6,"commit_id":"4986115a0884f4bf67167de4b70e408624261c1c","original_commit_id":"576f28338369b6177730828797084125d4e78e04","user":{"login":"mbrandonw","id":135203,"avatar_url":"https://avatars2.githubusercontent.com/u/135203?v=3","gravatar_id":"","url":"https://api.github.com/users/mbrandonw","html_url":"https://github.com/mbrandonw","followers_url":"https://api.github.com/users/mbrandonw/followers","following_url":"https://api.github.com/users/mbrandonw/following{/other_user}","gists_url":"https://api.github.com/users/mbrandonw/gists{/gist_id}","starred_url":"https://api.github.com/users/mbrandonw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbrandonw/subscriptions","organizations_url":"https://api.github.com/users/mbrandonw/orgs","repos_url":"https://api.github.com/users/mbrandonw/repos","events_url":"https://api.github.com/users/mbrandonw/events{/privacy}","received_events_url":"https://api.github.com/users/mbrandonw/received_events","type":"User","site_admin":false},"body":"sorry, this was my suggestion, but after seeing it IRL now I think we should revert and go back to the explicit `resume` input you had before. I really don't wanna push more functional into this VM base class. there's a lot of benefit to making our VM's very explicit in what they require, so it's nice to see this VM say it has functionality built on top of the activity resuming. \r\n\r\ndo you mind reverting this commit? you can just do a `git revert` to do it cleanly. \r\n\r\nalso you can make the resume observable just a simple `<Void>` observable since we no longer need the activity lifecycle event.","created_at":"2017-05-11T14:06:23Z","updated_at":"2017-05-11T14:32:51Z","html_url":"https://github.com/kickstarter/android-oss/pull/102#discussion_r115998825","pull_request_url":"https://api.github.com/repos/kickstarter/android-oss/pulls/102","_links":{"self":{"href":"https://api.github.com/repos/kickstarter/android-oss/pulls/comments/115998825"},"html":{"href":"https://github.com/kickstarter/android-oss/pull/102#discussion_r115998825"},"pull_request":{"href":"https://api.github.com/repos/kickstarter/android-oss/pulls/102"}}},"pull_request":{"url":"https://api.github.com/repos/kickstarter/android-oss/pulls/102","id":119980462,"html_url":"https://github.com/kickstarter/android-oss/pull/102","diff_url":"https://github.com/kickstarter/android-oss/pull/102.diff","patch_url":"https://github.com/kickstarter/android-oss/pull/102.patch","issue_url":"https://api.github.com/repos/kickstarter/android-oss/issues/102","number":102,"state":"open","locked":false,"title":"Reward Surveys in Android","user":{"login":"coryroy","id":506808,"avatar_url":"https://avatars1.githubusercontent.com/u/506808?v=3","gravatar_id":"","url":"https://api.github.com/users/coryroy","html_url":"https://github.com/coryroy","followers_url":"https://api.github.com/users/coryroy/followers","following_url":"https://api.github.com/users/coryroy/following{/other_user}","gists_url":"https://api.github.com/users/coryroy/gists{/gist_id}","starred_url":"https://api.github.com/users/coryroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coryroy/subscriptions","organizations_url":"https://api.github.com/users/coryroy/orgs","repos_url":"https://api.github.com/users/coryroy/repos","events_url":"https://api.github.com/users/coryroy/events{/privacy}","received_events_url":"https://api.github.com/users/coryroy/received_events","type":"User","site_admin":false},"body":"## What\r\nAllow users to see unanswered surveys in the Android client\r\nPut this feature behind a feature flag since it will be a WIP for a little while\r\n\r\n## Why\r\nMissing feature that is wanted by all!","created_at":"2017-05-10T21:16:37Z","updated_at":"2017-05-11T14:32:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a963ae55afe9cf5de8b9d84e988ba620616ad191","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kickstarter/android-oss/pulls/102/commits","review_comments_url":"https://api.github.com/repos/kickstarter/android-oss/pulls/102/comments","review_comment_url":"https://api.github.com/repos/kickstarter/android-oss/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kickstarter/android-oss/issues/102/comments","statuses_url":"https://api.github.com/repos/kickstarter/android-oss/statuses/4986115a0884f4bf67167de4b70e408624261c1c","head":{"label":"kickstarter:activity-surveys","ref":"activity-surveys","sha":"4986115a0884f4bf67167de4b70e408624261c1c","user":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars2.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"repo":{"id":76278501,"name":"android-oss","full_name":"kickstarter/android-oss","owner":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars2.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kickstarter/android-oss","description":"Kickstarter for Android. Bring new ideas to life, anywhere.","fork":false,"url":"https://api.github.com/repos/kickstarter/android-oss","forks_url":"https://api.github.com/repos/kickstarter/android-oss/forks","keys_url":"https://api.github.com/repos/kickstarter/android-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kickstarter/android-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kickstarter/android-oss/teams","hooks_url":"https://api.github.com/repos/kickstarter/android-oss/hooks","issue_events_url":"https://api.github.com/repos/kickstarter/android-oss/issues/events{/number}","events_url":"https://api.github.com/repos/kickstarter/android-oss/events","assignees_url":"https://api.github.com/repos/kickstarter/android-oss/assignees{/user}","branches_url":"https://api.github.com/repos/kickstarter/android-oss/branches{/branch}","tags_url":"https://api.github.com/repos/kickstarter/android-oss/tags","blobs_url":"https://api.github.com/repos/kickstarter/android-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kickstarter/android-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kickstarter/android-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/kickstarter/android-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kickstarter/android-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/kickstarter/android-oss/languages","stargazers_url":"https://api.github.com/repos/kickstarter/android-oss/stargazers","contributors_url":"https://api.github.com/repos/kickstarter/android-oss/contributors","subscribers_url":"https://api.github.com/repos/kickstarter/android-oss/subscribers","subscription_url":"https://api.github.com/repos/kickstarter/android-oss/subscription","commits_url":"https://api.github.com/repos/kickstarter/android-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/kickstarter/android-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/kickstarter/android-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/kickstarter/android-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/kickstarter/android-oss/contents/{+path}","compare_url":"https://api.github.com/repos/kickstarter/android-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kickstarter/android-oss/merges","archive_url":"https://api.github.com/repos/kickstarter/android-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kickstarter/android-oss/downloads","issues_url":"https://api.github.com/repos/kickstarter/android-oss/issues{/number}","pulls_url":"https://api.github.com/repos/kickstarter/android-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/kickstarter/android-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/kickstarter/android-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kickstarter/android-oss/labels{/name}","releases_url":"https://api.github.com/repos/kickstarter/android-oss/releases{/id}","deployments_url":"https://api.github.com/repos/kickstarter/android-oss/deployments","created_at":"2016-12-12T17:15:41Z","updated_at":"2017-05-11T10:30:41Z","pushed_at":"2017-05-10T23:32:50Z","git_url":"git://github.com/kickstarter/android-oss.git","ssh_url":"git@github.com:kickstarter/android-oss.git","clone_url":"https://github.com/kickstarter/android-oss.git","svn_url":"https://github.com/kickstarter/android-oss","homepage":"https://www.kickstarter.com/mobile","size":16741,"stargazers_count":3723,"watchers_count":3723,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":567,"mirror_url":null,"open_issues_count":20,"forks":567,"open_issues":20,"watchers":3723,"default_branch":"master"}},"base":{"label":"kickstarter:master","ref":"master","sha":"4534c71097151dda664d7c15e245214f37354a0f","user":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars2.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"repo":{"id":76278501,"name":"android-oss","full_name":"kickstarter/android-oss","owner":{"login":"kickstarter","id":120676,"avatar_url":"https://avatars2.githubusercontent.com/u/120676?v=3","gravatar_id":"","url":"https://api.github.com/users/kickstarter","html_url":"https://github.com/kickstarter","followers_url":"https://api.github.com/users/kickstarter/followers","following_url":"https://api.github.com/users/kickstarter/following{/other_user}","gists_url":"https://api.github.com/users/kickstarter/gists{/gist_id}","starred_url":"https://api.github.com/users/kickstarter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kickstarter/subscriptions","organizations_url":"https://api.github.com/users/kickstarter/orgs","repos_url":"https://api.github.com/users/kickstarter/repos","events_url":"https://api.github.com/users/kickstarter/events{/privacy}","received_events_url":"https://api.github.com/users/kickstarter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kickstarter/android-oss","description":"Kickstarter for Android. Bring new ideas to life, anywhere.","fork":false,"url":"https://api.github.com/repos/kickstarter/android-oss","forks_url":"https://api.github.com/repos/kickstarter/android-oss/forks","keys_url":"https://api.github.com/repos/kickstarter/android-oss/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kickstarter/android-oss/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kickstarter/android-oss/teams","hooks_url":"https://api.github.com/repos/kickstarter/android-oss/hooks","issue_events_url":"https://api.github.com/repos/kickstarter/android-oss/issues/events{/number}","events_url":"https://api.github.com/repos/kickstarter/android-oss/events","assignees_url":"https://api.github.com/repos/kickstarter/android-oss/assignees{/user}","branches_url":"https://api.github.com/repos/kickstarter/android-oss/branches{/branch}","tags_url":"https://api.github.com/repos/kickstarter/android-oss/tags","blobs_url":"https://api.github.com/repos/kickstarter/android-oss/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kickstarter/android-oss/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kickstarter/android-oss/git/refs{/sha}","trees_url":"https://api.github.com/repos/kickstarter/android-oss/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kickstarter/android-oss/statuses/{sha}","languages_url":"https://api.github.com/repos/kickstarter/android-oss/languages","stargazers_url":"https://api.github.com/repos/kickstarter/android-oss/stargazers","contributors_url":"https://api.github.com/repos/kickstarter/android-oss/contributors","subscribers_url":"https://api.github.com/repos/kickstarter/android-oss/subscribers","subscription_url":"https://api.github.com/repos/kickstarter/android-oss/subscription","commits_url":"https://api.github.com/repos/kickstarter/android-oss/commits{/sha}","git_commits_url":"https://api.github.com/repos/kickstarter/android-oss/git/commits{/sha}","comments_url":"https://api.github.com/repos/kickstarter/android-oss/comments{/number}","issue_comment_url":"https://api.github.com/repos/kickstarter/android-oss/issues/comments{/number}","contents_url":"https://api.github.com/repos/kickstarter/android-oss/contents/{+path}","compare_url":"https://api.github.com/repos/kickstarter/android-oss/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kickstarter/android-oss/merges","archive_url":"https://api.github.com/repos/kickstarter/android-oss/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kickstarter/android-oss/downloads","issues_url":"https://api.github.com/repos/kickstarter/android-oss/issues{/number}","pulls_url":"https://api.github.com/repos/kickstarter/android-oss/pulls{/number}","milestones_url":"https://api.github.com/repos/kickstarter/android-oss/milestones{/number}","notifications_url":"https://api.github.com/repos/kickstarter/android-oss/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kickstarter/android-oss/labels{/name}","releases_url":"https://api.github.com/repos/kickstarter/android-oss/releases{/id}","deployments_url":"https://api.github.com/repos/kickstarter/android-oss/deployments","created_at":"2016-12-12T17:15:41Z","updated_at":"2017-05-11T10:30:41Z","pushed_at":"2017-05-10T23:32:50Z","git_url":"git://github.com/kickstarter/android-oss.git","ssh_url":"git@github.com:kickstarter/android-oss.git","clone_url":"https://github.com/kickstarter/android-oss.git","svn_url":"https://github.com/kickstarter/android-oss","homepage":"https://www.kickstarter.com/mobile","size":16741,"stargazers_count":3723,"watchers_count":3723,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":567,"mirror_url":null,"open_issues_count":20,"forks":567,"open_issues":20,"watchers":3723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kickstarter/android-oss/pulls/102"},"html":{"href":"https://github.com/kickstarter/android-oss/pull/102"},"issue":{"href":"https://api.github.com/repos/kickstarter/android-oss/issues/102"},"comments":{"href":"https://api.github.com/repos/kickstarter/android-oss/issues/102/comments"},"review_comments":{"href":"https://api.github.com/repos/kickstarter/android-oss/pulls/102/comments"},"review_comment":{"href":"https://api.github.com/repos/kickstarter/android-oss/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kickstarter/android-oss/pulls/102/commits"},"statuses":{"href":"https://api.github.com/repos/kickstarter/android-oss/statuses/4986115a0884f4bf67167de4b70e408624261c1c"}}}}
{"actor":{"display_login":"mbrandonw"}}