{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/98342424","pull_request_review_id":18984031,"id":98342424,"diff_hunk":"@@ -11,6 +11,7 @@\n fn main() {\n     let Box(a) = loop { };\n     //~^ ERROR expected tuple struct/variant, found struct `Box`\n+    //~| ERROR expected tuple struct/variant, found struct `Box`","path":"src/test/compile-fail/issue-38412.rs","position":null,"original_position":4,"commit_id":"d38a8ad488047b8acdeed44bb7c67dc776324624","original_commit_id":"d38a8ad488047b8acdeed44bb7c67dc776324624","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"body":"This is a compiletest bug. If one error has two labels, compiletest will require two \"expected errors\".","created_at":"2017-01-29T00:38:46Z","updated_at":"2017-01-29T00:38:46Z","html_url":"https://github.com/rust-lang/rust/pull/38932#discussion_r98342424","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/38932","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/98342424"},"html":{"href":"https://github.com/rust-lang/rust/pull/38932#discussion_r98342424"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38932"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/38932","id":100617853,"html_url":"https://github.com/rust-lang/rust/pull/38932","diff_url":"https://github.com/rust-lang/rust/pull/38932.diff","patch_url":"https://github.com/rust-lang/rust/pull/38932.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/38932","number":38932,"state":"open","locked":false,"title":"Privatize constructors of tuple structs with private fields","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"body":"This PR implements the strictest version of such \"privatization\" - it just sets visibilities for struct constructors, this affects everything including imports.\r\n```\r\nvisibility(struct_ctor) = min(visibility(struct), visibility(field_1), ..., visibility(field_N))\r\n```\r\nNeeds crater run before proceeding.\r\n\r\nResolves https://github.com/rust-lang/rfcs/issues/902\r\n\r\nr? @nikomatsakis ","created_at":"2017-01-08T21:56:34Z","updated_at":"2017-01-29T00:38:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30009444090b5b2f9cc527eb8ad0f817091a4289","assignee":{"login":"jseyfried","id":8652869,"avatar_url":"https://avatars.githubusercontent.com/u/8652869?v=3","gravatar_id":"","url":"https://api.github.com/users/jseyfried","html_url":"https://github.com/jseyfried","followers_url":"https://api.github.com/users/jseyfried/followers","following_url":"https://api.github.com/users/jseyfried/following{/other_user}","gists_url":"https://api.github.com/users/jseyfried/gists{/gist_id}","starred_url":"https://api.github.com/users/jseyfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseyfried/subscriptions","organizations_url":"https://api.github.com/users/jseyfried/orgs","repos_url":"https://api.github.com/users/jseyfried/repos","events_url":"https://api.github.com/users/jseyfried/events{/privacy}","received_events_url":"https://api.github.com/users/jseyfried/received_events","type":"User","site_admin":false},"assignees":[{"login":"jseyfried","id":8652869,"avatar_url":"https://avatars.githubusercontent.com/u/8652869?v=3","gravatar_id":"","url":"https://api.github.com/users/jseyfried","html_url":"https://github.com/jseyfried","followers_url":"https://api.github.com/users/jseyfried/followers","following_url":"https://api.github.com/users/jseyfried/following{/other_user}","gists_url":"https://api.github.com/users/jseyfried/gists{/gist_id}","starred_url":"https://api.github.com/users/jseyfried/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jseyfried/subscriptions","organizations_url":"https://api.github.com/users/jseyfried/orgs","repos_url":"https://api.github.com/users/jseyfried/repos","events_url":"https://api.github.com/users/jseyfried/events{/privacy}","received_events_url":"https://api.github.com/users/jseyfried/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/38932/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/38932/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/38932/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/d38a8ad488047b8acdeed44bb7c67dc776324624","head":{"label":"petrochenkov:privctor","ref":"privctor","sha":"d38a8ad488047b8acdeed44bb7c67dc776324624","user":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"repo":{"id":26977039,"name":"rust","full_name":"petrochenkov/rust","owner":{"login":"petrochenkov","id":5751617,"avatar_url":"https://avatars.githubusercontent.com/u/5751617?v=3","gravatar_id":"","url":"https://api.github.com/users/petrochenkov","html_url":"https://github.com/petrochenkov","followers_url":"https://api.github.com/users/petrochenkov/followers","following_url":"https://api.github.com/users/petrochenkov/following{/other_user}","gists_url":"https://api.github.com/users/petrochenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/petrochenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petrochenkov/subscriptions","organizations_url":"https://api.github.com/users/petrochenkov/orgs","repos_url":"https://api.github.com/users/petrochenkov/repos","events_url":"https://api.github.com/users/petrochenkov/events{/privacy}","received_events_url":"https://api.github.com/users/petrochenkov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/petrochenkov/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/petrochenkov/rust","forks_url":"https://api.github.com/repos/petrochenkov/rust/forks","keys_url":"https://api.github.com/repos/petrochenkov/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/petrochenkov/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/petrochenkov/rust/teams","hooks_url":"https://api.github.com/repos/petrochenkov/rust/hooks","issue_events_url":"https://api.github.com/repos/petrochenkov/rust/issues/events{/number}","events_url":"https://api.github.com/repos/petrochenkov/rust/events","assignees_url":"https://api.github.com/repos/petrochenkov/rust/assignees{/user}","branches_url":"https://api.github.com/repos/petrochenkov/rust/branches{/branch}","tags_url":"https://api.github.com/repos/petrochenkov/rust/tags","blobs_url":"https://api.github.com/repos/petrochenkov/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/petrochenkov/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/petrochenkov/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/petrochenkov/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/petrochenkov/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/petrochenkov/rust/languages","stargazers_url":"https://api.github.com/repos/petrochenkov/rust/stargazers","contributors_url":"https://api.github.com/repos/petrochenkov/rust/contributors","subscribers_url":"https://api.github.com/repos/petrochenkov/rust/subscribers","subscription_url":"https://api.github.com/repos/petrochenkov/rust/subscription","commits_url":"https://api.github.com/repos/petrochenkov/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/petrochenkov/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/petrochenkov/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/petrochenkov/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/petrochenkov/rust/contents/{+path}","compare_url":"https://api.github.com/repos/petrochenkov/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/petrochenkov/rust/merges","archive_url":"https://api.github.com/repos/petrochenkov/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/petrochenkov/rust/downloads","issues_url":"https://api.github.com/repos/petrochenkov/rust/issues{/number}","pulls_url":"https://api.github.com/repos/petrochenkov/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/petrochenkov/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/petrochenkov/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/petrochenkov/rust/labels{/name}","releases_url":"https://api.github.com/repos/petrochenkov/rust/releases{/id}","deployments_url":"https://api.github.com/repos/petrochenkov/rust/deployments","created_at":"2014-11-21T20:39:20Z","updated_at":"2016-01-14T18:00:04Z","pushed_at":"2017-01-29T00:33:56Z","git_url":"git://github.com/petrochenkov/rust.git","ssh_url":"git@github.com:petrochenkov/rust.git","clone_url":"https://github.com/petrochenkov/rust.git","svn_url":"https://github.com/petrochenkov/rust","homepage":"http://www.rust-lang.org","size":322290,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"1491e0425911806f2612f05ee8caf21666447128","user":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"avatar_url":"https://avatars.githubusercontent.com/u/5430905?v=3","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2017-01-29T00:04:05Z","pushed_at":"2017-01-29T00:33:58Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":324903,"stargazers_count":20151,"watchers_count":20151,"language":"Rust","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3826,"mirror_url":null,"open_issues_count":3043,"forks":3826,"open_issues":3043,"watchers":20151,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38932"},"html":{"href":"https://github.com/rust-lang/rust/pull/38932"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/38932"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/38932/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38932/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/38932/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/d38a8ad488047b8acdeed44bb7c67dc776324624"}}}}
{"actor":{"display_login":"petrochenkov"}}