{"action":"closed","number":355,"pull_request":{"url":"https://api.github.com/repos/laravel/dusk/pulls/355","id":139646375,"html_url":"https://github.com/laravel/dusk/pull/355","diff_url":"https://github.com/laravel/dusk/pull/355.diff","patch_url":"https://github.com/laravel/dusk/pull/355.patch","issue_url":"https://api.github.com/repos/laravel/dusk/issues/355","number":355,"state":"closed","locked":false,"title":"Let Firefox users disable console","user":{"login":"deleugpn","id":9533181,"avatar_url":"https://avatars1.githubusercontent.com/u/9533181?v=4","gravatar_id":"","url":"https://api.github.com/users/deleugpn","html_url":"https://github.com/deleugpn","followers_url":"https://api.github.com/users/deleugpn/followers","following_url":"https://api.github.com/users/deleugpn/following{/other_user}","gists_url":"https://api.github.com/users/deleugpn/gists{/gist_id}","starred_url":"https://api.github.com/users/deleugpn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deleugpn/subscriptions","organizations_url":"https://api.github.com/users/deleugpn/orgs","repos_url":"https://api.github.com/users/deleugpn/repos","events_url":"https://api.github.com/users/deleugpn/events{/privacy}","received_events_url":"https://api.github.com/users/deleugpn/received_events","type":"User","site_admin":false},"body":"An alternative to #354.\r\n\r\nWhen using Firefox, simply override the `setUp` method.\r\n\r\n```\r\n    protected function setUp()\r\n    {\r\n        parent::setUp();\r\n\r\n        // Any of the following will be a valid option. The user can choose one\r\n        Browser::$storeConsoleLogAt = null;\r\n        Browser::$storeConsoleLogAt = false;\r\n        Browser::$storeConsoleLogAt = '';\r\n        unset(Browser::$storeConsoleLogAt);\r\n    }\r\n```\r\n\r\n- Why Firefox users should disable this themselves?\r\n\r\nDusk relies on Selenium to communicate with the browser and Selenium does offer getLog API (https://github.com/SeleniumHQ/selenium/wiki/JsonWireProtocol#log-type). Firefox hasn't caught up with that yet so if you do use Selenium with Firefox and make this API call, Firefox driver will fail and bubble up to Selenium. It doesn't necessarily mean that only Chrome offers this. PhantomJS is an example of that.","created_at":"2017-09-06T19:33:15Z","updated_at":"2017-09-06T19:58:33Z","closed_at":"2017-09-06T19:58:33Z","merged_at":"2017-09-06T19:58:33Z","merge_commit_sha":"345d5a67fc2890b568257b8897808f0c23ef38f6","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/laravel/dusk/pulls/355/commits","review_comments_url":"https://api.github.com/repos/laravel/dusk/pulls/355/comments","review_comment_url":"https://api.github.com/repos/laravel/dusk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/laravel/dusk/issues/355/comments","statuses_url":"https://api.github.com/repos/laravel/dusk/statuses/0f6e88ef6c9687180a64f610475cb62460ab8a79","head":{"label":"deleugpn:2.0","ref":"2.0","sha":"0f6e88ef6c9687180a64f610475cb62460ab8a79","user":{"login":"deleugpn","id":9533181,"avatar_url":"https://avatars1.githubusercontent.com/u/9533181?v=4","gravatar_id":"","url":"https://api.github.com/users/deleugpn","html_url":"https://github.com/deleugpn","followers_url":"https://api.github.com/users/deleugpn/followers","following_url":"https://api.github.com/users/deleugpn/following{/other_user}","gists_url":"https://api.github.com/users/deleugpn/gists{/gist_id}","starred_url":"https://api.github.com/users/deleugpn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deleugpn/subscriptions","organizations_url":"https://api.github.com/users/deleugpn/orgs","repos_url":"https://api.github.com/users/deleugpn/repos","events_url":"https://api.github.com/users/deleugpn/events{/privacy}","received_events_url":"https://api.github.com/users/deleugpn/received_events","type":"User","site_admin":false},"repo":{"id":83728428,"name":"dusk","full_name":"deleugpn/dusk","owner":{"login":"deleugpn","id":9533181,"avatar_url":"https://avatars1.githubusercontent.com/u/9533181?v=4","gravatar_id":"","url":"https://api.github.com/users/deleugpn","html_url":"https://github.com/deleugpn","followers_url":"https://api.github.com/users/deleugpn/followers","following_url":"https://api.github.com/users/deleugpn/following{/other_user}","gists_url":"https://api.github.com/users/deleugpn/gists{/gist_id}","starred_url":"https://api.github.com/users/deleugpn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deleugpn/subscriptions","organizations_url":"https://api.github.com/users/deleugpn/orgs","repos_url":"https://api.github.com/users/deleugpn/repos","events_url":"https://api.github.com/users/deleugpn/events{/privacy}","received_events_url":"https://api.github.com/users/deleugpn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/deleugpn/dusk","description":null,"fork":true,"url":"https://api.github.com/repos/deleugpn/dusk","forks_url":"https://api.github.com/repos/deleugpn/dusk/forks","keys_url":"https://api.github.com/repos/deleugpn/dusk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/deleugpn/dusk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/deleugpn/dusk/teams","hooks_url":"https://api.github.com/repos/deleugpn/dusk/hooks","issue_events_url":"https://api.github.com/repos/deleugpn/dusk/issues/events{/number}","events_url":"https://api.github.com/repos/deleugpn/dusk/events","assignees_url":"https://api.github.com/repos/deleugpn/dusk/assignees{/user}","branches_url":"https://api.github.com/repos/deleugpn/dusk/branches{/branch}","tags_url":"https://api.github.com/repos/deleugpn/dusk/tags","blobs_url":"https://api.github.com/repos/deleugpn/dusk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/deleugpn/dusk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/deleugpn/dusk/git/refs{/sha}","trees_url":"https://api.github.com/repos/deleugpn/dusk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/deleugpn/dusk/statuses/{sha}","languages_url":"https://api.github.com/repos/deleugpn/dusk/languages","stargazers_url":"https://api.github.com/repos/deleugpn/dusk/stargazers","contributors_url":"https://api.github.com/repos/deleugpn/dusk/contributors","subscribers_url":"https://api.github.com/repos/deleugpn/dusk/subscribers","subscription_url":"https://api.github.com/repos/deleugpn/dusk/subscription","commits_url":"https://api.github.com/repos/deleugpn/dusk/commits{/sha}","git_commits_url":"https://api.github.com/repos/deleugpn/dusk/git/commits{/sha}","comments_url":"https://api.github.com/repos/deleugpn/dusk/comments{/number}","issue_comment_url":"https://api.github.com/repos/deleugpn/dusk/issues/comments{/number}","contents_url":"https://api.github.com/repos/deleugpn/dusk/contents/{+path}","compare_url":"https://api.github.com/repos/deleugpn/dusk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/deleugpn/dusk/merges","archive_url":"https://api.github.com/repos/deleugpn/dusk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/deleugpn/dusk/downloads","issues_url":"https://api.github.com/repos/deleugpn/dusk/issues{/number}","pulls_url":"https://api.github.com/repos/deleugpn/dusk/pulls{/number}","milestones_url":"https://api.github.com/repos/deleugpn/dusk/milestones{/number}","notifications_url":"https://api.github.com/repos/deleugpn/dusk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/deleugpn/dusk/labels{/name}","releases_url":"https://api.github.com/repos/deleugpn/dusk/releases{/id}","deployments_url":"https://api.github.com/repos/deleugpn/dusk/deployments","created_at":"2017-03-02T21:53:43Z","updated_at":"2017-03-02T21:53:45Z","pushed_at":"2017-09-06T19:48:36Z","git_url":"git://github.com/deleugpn/dusk.git","ssh_url":"git@github.com:deleugpn/dusk.git","clone_url":"https://github.com/deleugpn/dusk.git","svn_url":"https://github.com/deleugpn/dusk","homepage":null,"size":53271,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"laravel:2.0","ref":"2.0","sha":"5e0ceaa27c9a78897f201a26f176b23bef20210f","user":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"repo":{"id":75691991,"name":"dusk","full_name":"laravel/dusk","owner":{"login":"laravel","id":958072,"avatar_url":"https://avatars3.githubusercontent.com/u/958072?v=4","gravatar_id":"","url":"https://api.github.com/users/laravel","html_url":"https://github.com/laravel","followers_url":"https://api.github.com/users/laravel/followers","following_url":"https://api.github.com/users/laravel/following{/other_user}","gists_url":"https://api.github.com/users/laravel/gists{/gist_id}","starred_url":"https://api.github.com/users/laravel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laravel/subscriptions","organizations_url":"https://api.github.com/users/laravel/orgs","repos_url":"https://api.github.com/users/laravel/repos","events_url":"https://api.github.com/users/laravel/events{/privacy}","received_events_url":"https://api.github.com/users/laravel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/laravel/dusk","description":null,"fork":false,"url":"https://api.github.com/repos/laravel/dusk","forks_url":"https://api.github.com/repos/laravel/dusk/forks","keys_url":"https://api.github.com/repos/laravel/dusk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/laravel/dusk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/laravel/dusk/teams","hooks_url":"https://api.github.com/repos/laravel/dusk/hooks","issue_events_url":"https://api.github.com/repos/laravel/dusk/issues/events{/number}","events_url":"https://api.github.com/repos/laravel/dusk/events","assignees_url":"https://api.github.com/repos/laravel/dusk/assignees{/user}","branches_url":"https://api.github.com/repos/laravel/dusk/branches{/branch}","tags_url":"https://api.github.com/repos/laravel/dusk/tags","blobs_url":"https://api.github.com/repos/laravel/dusk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/laravel/dusk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/laravel/dusk/git/refs{/sha}","trees_url":"https://api.github.com/repos/laravel/dusk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/laravel/dusk/statuses/{sha}","languages_url":"https://api.github.com/repos/laravel/dusk/languages","stargazers_url":"https://api.github.com/repos/laravel/dusk/stargazers","contributors_url":"https://api.github.com/repos/laravel/dusk/contributors","subscribers_url":"https://api.github.com/repos/laravel/dusk/subscribers","subscription_url":"https://api.github.com/repos/laravel/dusk/subscription","commits_url":"https://api.github.com/repos/laravel/dusk/commits{/sha}","git_commits_url":"https://api.github.com/repos/laravel/dusk/git/commits{/sha}","comments_url":"https://api.github.com/repos/laravel/dusk/comments{/number}","issue_comment_url":"https://api.github.com/repos/laravel/dusk/issues/comments{/number}","contents_url":"https://api.github.com/repos/laravel/dusk/contents/{+path}","compare_url":"https://api.github.com/repos/laravel/dusk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/laravel/dusk/merges","archive_url":"https://api.github.com/repos/laravel/dusk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/laravel/dusk/downloads","issues_url":"https://api.github.com/repos/laravel/dusk/issues{/number}","pulls_url":"https://api.github.com/repos/laravel/dusk/pulls{/number}","milestones_url":"https://api.github.com/repos/laravel/dusk/milestones{/number}","notifications_url":"https://api.github.com/repos/laravel/dusk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/laravel/dusk/labels{/name}","releases_url":"https://api.github.com/repos/laravel/dusk/releases{/id}","deployments_url":"https://api.github.com/repos/laravel/dusk/deployments","created_at":"2016-12-06T03:43:52Z","updated_at":"2017-09-06T16:28:50Z","pushed_at":"2017-09-06T19:58:33Z","git_url":"git://github.com/laravel/dusk.git","ssh_url":"git@github.com:laravel/dusk.git","clone_url":"https://github.com/laravel/dusk.git","svn_url":"https://github.com/laravel/dusk","homepage":null,"size":53280,"stargazers_count":693,"watchers_count":693,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":129,"mirror_url":null,"open_issues_count":86,"forks":129,"open_issues":86,"watchers":693,"default_branch":"2.0"}},"_links":{"self":{"href":"https://api.github.com/repos/laravel/dusk/pulls/355"},"html":{"href":"https://github.com/laravel/dusk/pull/355"},"issue":{"href":"https://api.github.com/repos/laravel/dusk/issues/355"},"comments":{"href":"https://api.github.com/repos/laravel/dusk/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/laravel/dusk/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/laravel/dusk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/laravel/dusk/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/laravel/dusk/statuses/0f6e88ef6c9687180a64f610475cb62460ab8a79"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"taylorotwell","id":463230,"avatar_url":"https://avatars3.githubusercontent.com/u/463230?v=4","gravatar_id":"","url":"https://api.github.com/users/taylorotwell","html_url":"https://github.com/taylorotwell","followers_url":"https://api.github.com/users/taylorotwell/followers","following_url":"https://api.github.com/users/taylorotwell/following{/other_user}","gists_url":"https://api.github.com/users/taylorotwell/gists{/gist_id}","starred_url":"https://api.github.com/users/taylorotwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taylorotwell/subscriptions","organizations_url":"https://api.github.com/users/taylorotwell/orgs","repos_url":"https://api.github.com/users/taylorotwell/repos","events_url":"https://api.github.com/users/taylorotwell/events{/privacy}","received_events_url":"https://api.github.com/users/taylorotwell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":4,"additions":29,"deletions":7,"changed_files":2}}
{"actor":{"display_login":"taylorotwell"}}