{"action":"created","comment":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/146188776","pull_request_review_id":71094120,"id":146188776,"diff_hunk":"@@ -79,7 +78,7 @@ public function isEditor()\n      */\n     public function onSecurityInteractiveLogin(InteractiveLoginEvent $event)\n     {\n-        if ($this->getSecurityContext()->getToken() &&\n+        if ($this->container->get('security.token_storage')->getToken() &&","path":"CmsManager/CmsManagerSelector.php","position":13,"original_position":13,"commit_id":"3a8642ac611f5ad689c67ce0e88b26632fae787a","original_commit_id":"3a8642ac611f5ad689c67ce0e88b26632fae787a","user":{"login":"Soullivaneuh","id":1698357,"avatar_url":"https://avatars0.githubusercontent.com/u/1698357?v=4","gravatar_id":"","url":"https://api.github.com/users/Soullivaneuh","html_url":"https://github.com/Soullivaneuh","followers_url":"https://api.github.com/users/Soullivaneuh/followers","following_url":"https://api.github.com/users/Soullivaneuh/following{/other_user}","gists_url":"https://api.github.com/users/Soullivaneuh/gists{/gist_id}","starred_url":"https://api.github.com/users/Soullivaneuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Soullivaneuh/subscriptions","organizations_url":"https://api.github.com/users/Soullivaneuh/orgs","repos_url":"https://api.github.com/users/Soullivaneuh/repos","events_url":"https://api.github.com/users/Soullivaneuh/events{/privacy}","received_events_url":"https://api.github.com/users/Soullivaneuh/received_events","type":"User","site_admin":false},"body":"It would be great to start using dependency injection instead of using this ugly container.","created_at":"2017-10-23T07:59:47Z","updated_at":"2017-10-23T07:59:47Z","html_url":"https://github.com/sonata-project/SonataPageBundle/pull/886#discussion_r146188776","pull_request_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/886","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments/146188776"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/886#discussion_r146188776"},"pull_request":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/886"}}},"pull_request":{"url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/886","id":147958130,"html_url":"https://github.com/sonata-project/SonataPageBundle/pull/886","diff_url":"https://github.com/sonata-project/SonataPageBundle/pull/886.diff","patch_url":"https://github.com/sonata-project/SonataPageBundle/pull/886.patch","issue_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/886","number":886,"state":"open","locked":false,"title":"Remove code checks for <sf2.8","user":{"login":"acrobat","id":1374857,"avatar_url":"https://avatars3.githubusercontent.com/u/1374857?v=4","gravatar_id":"","url":"https://api.github.com/users/acrobat","html_url":"https://github.com/acrobat","followers_url":"https://api.github.com/users/acrobat/followers","following_url":"https://api.github.com/users/acrobat/following{/other_user}","gists_url":"https://api.github.com/users/acrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/acrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrobat/subscriptions","organizations_url":"https://api.github.com/users/acrobat/orgs","repos_url":"https://api.github.com/users/acrobat/repos","events_url":"https://api.github.com/users/acrobat/events{/privacy}","received_events_url":"https://api.github.com/users/acrobat/received_events","type":"User","site_admin":false},"body":"<!-- THE PR TEMPLATE IS NOT AN OPTION. DO NOT DELETE IT, MAKE SURE YOU READ AND EDIT IT! -->\r\n\r\n<!--\r\n    Show us you choose the right branch.\r\n    Different branches are used for different things :\r\n    - 3.x is for everything backwards compatible, like patches, features and deprecation notices\r\n    - master is for deprecation removals and other changes that cannot be done without a BC-break\r\n    More details here: https://github.com/sonata-project/SonataPageBundle/blob/3.x/CONTRIBUTING.md#the-base-branch\r\n-->\r\nI am targeting this branch, because of code cleanup after sf/php bump.\r\n\r\n<!--\r\n    Specify which issues will be fixed/closed.\r\n    Remove it if this is not related.\r\n-->\r\n\r\n## Changelog\r\n\r\n<!-- MANDATORY\r\n    Fill the changelog part inside the code block.\r\n    Follow this schema: http://keepachangelog.com/\r\n-->\r\n\r\n<!-- REMOVE EMPTY SECTIONS -->\r\n```markdown\r\n### Removed\r\n- pre sf2.8 code checks\r\n```\r\n\r\n## Subject\r\n\r\nSome code cleanup after the symfony/php version bump","created_at":"2017-10-21T19:08:21Z","updated_at":"2017-10-23T07:59:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea364e2d2a4b5895fbbc2cacdbd64734c7cd79b5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/886/commits","review_comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/886/comments","review_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/886/comments","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/3a8642ac611f5ad689c67ce0e88b26632fae787a","head":{"label":"acrobat:sf-2.8-cleanup","ref":"sf-2.8-cleanup","sha":"3a8642ac611f5ad689c67ce0e88b26632fae787a","user":{"login":"acrobat","id":1374857,"avatar_url":"https://avatars3.githubusercontent.com/u/1374857?v=4","gravatar_id":"","url":"https://api.github.com/users/acrobat","html_url":"https://github.com/acrobat","followers_url":"https://api.github.com/users/acrobat/followers","following_url":"https://api.github.com/users/acrobat/following{/other_user}","gists_url":"https://api.github.com/users/acrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/acrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrobat/subscriptions","organizations_url":"https://api.github.com/users/acrobat/orgs","repos_url":"https://api.github.com/users/acrobat/repos","events_url":"https://api.github.com/users/acrobat/events{/privacy}","received_events_url":"https://api.github.com/users/acrobat/received_events","type":"User","site_admin":false},"repo":{"id":102217621,"name":"SonataPageBundle","full_name":"acrobat/SonataPageBundle","owner":{"login":"acrobat","id":1374857,"avatar_url":"https://avatars3.githubusercontent.com/u/1374857?v=4","gravatar_id":"","url":"https://api.github.com/users/acrobat","html_url":"https://github.com/acrobat","followers_url":"https://api.github.com/users/acrobat/followers","following_url":"https://api.github.com/users/acrobat/following{/other_user}","gists_url":"https://api.github.com/users/acrobat/gists{/gist_id}","starred_url":"https://api.github.com/users/acrobat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acrobat/subscriptions","organizations_url":"https://api.github.com/users/acrobat/orgs","repos_url":"https://api.github.com/users/acrobat/repos","events_url":"https://api.github.com/users/acrobat/events{/privacy}","received_events_url":"https://api.github.com/users/acrobat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/acrobat/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":true,"url":"https://api.github.com/repos/acrobat/SonataPageBundle","forks_url":"https://api.github.com/repos/acrobat/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/acrobat/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/acrobat/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/acrobat/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/acrobat/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/acrobat/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/acrobat/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/acrobat/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/acrobat/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/acrobat/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/acrobat/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/acrobat/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/acrobat/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/acrobat/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/acrobat/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/acrobat/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/acrobat/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/acrobat/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/acrobat/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/acrobat/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/acrobat/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/acrobat/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/acrobat/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/acrobat/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/acrobat/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/acrobat/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/acrobat/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/acrobat/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/acrobat/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/acrobat/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/acrobat/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/acrobat/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/acrobat/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/acrobat/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/acrobat/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/acrobat/SonataPageBundle/deployments","created_at":"2017-09-02T19:03:03Z","updated_at":"2017-09-02T19:03:06Z","pushed_at":"2017-10-23T06:45:23Z","git_url":"git://github.com/acrobat/SonataPageBundle.git","ssh_url":"git@github.com:acrobat/SonataPageBundle.git","clone_url":"https://github.com/acrobat/SonataPageBundle.git","svn_url":"https://github.com/acrobat/SonataPageBundle","homepage":"http://sonata-project.org/bundles/page","size":3922,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.x"}},"base":{"label":"sonata-project:3.x","ref":"3.x","sha":"6e58f3f64adf3531f0fd4c2dcaad3b4f1753814b","user":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"repo":{"id":1141608,"name":"SonataPageBundle","full_name":"sonata-project/SonataPageBundle","owner":{"login":"sonata-project","id":404157,"avatar_url":"https://avatars0.githubusercontent.com/u/404157?v=4","gravatar_id":"","url":"https://api.github.com/users/sonata-project","html_url":"https://github.com/sonata-project","followers_url":"https://api.github.com/users/sonata-project/followers","following_url":"https://api.github.com/users/sonata-project/following{/other_user}","gists_url":"https://api.github.com/users/sonata-project/gists{/gist_id}","starred_url":"https://api.github.com/users/sonata-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sonata-project/subscriptions","organizations_url":"https://api.github.com/users/sonata-project/orgs","repos_url":"https://api.github.com/users/sonata-project/repos","events_url":"https://api.github.com/users/sonata-project/events{/privacy}","received_events_url":"https://api.github.com/users/sonata-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sonata-project/SonataPageBundle","description":"A Layout manager on top of Symfony2","fork":false,"url":"https://api.github.com/repos/sonata-project/SonataPageBundle","forks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/forks","keys_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/teams","hooks_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/hooks","issue_events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/events{/number}","events_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/events","assignees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/assignees{/user}","branches_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/branches{/branch}","tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/tags","blobs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/languages","stargazers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/stargazers","contributors_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contributors","subscribers_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscribers","subscription_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/subscription","commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/contents/{+path}","compare_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/merges","archive_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/downloads","issues_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues{/number}","pulls_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/labels{/name}","releases_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/releases{/id}","deployments_url":"https://api.github.com/repos/sonata-project/SonataPageBundle/deployments","created_at":"2010-12-06T00:18:21Z","updated_at":"2017-09-20T11:19:03Z","pushed_at":"2017-10-23T06:47:33Z","git_url":"git://github.com/sonata-project/SonataPageBundle.git","ssh_url":"git@github.com:sonata-project/SonataPageBundle.git","clone_url":"https://github.com/sonata-project/SonataPageBundle.git","svn_url":"https://github.com/sonata-project/SonataPageBundle","homepage":"https://sonata-project.org/","size":3938,"stargazers_count":152,"watchers_count":152,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":188,"mirror_url":null,"archived":false,"open_issues_count":63,"forks":188,"open_issues":63,"watchers":152,"default_branch":"3.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/886"},"html":{"href":"https://github.com/sonata-project/SonataPageBundle/pull/886"},"issue":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/886"},"comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/issues/886/comments"},"review_comments":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/886/comments"},"review_comment":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/pulls/886/commits"},"statuses":{"href":"https://api.github.com/repos/sonata-project/SonataPageBundle/statuses/3a8642ac611f5ad689c67ce0e88b26632fae787a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Soullivaneuh"}}