{"action":"created","issue":{"url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/145","repository_url":"https://api.github.com/repos/rubyide/vscode-ruby","labels_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/145/labels{/name}","comments_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/145/comments","events_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/145/events","html_url":"https://github.com/rubyide/vscode-ruby/pull/145","id":225980100,"number":145,"title":"Make stacktrace handling of missing files more robust","user":{"login":"simonomis","id":158660,"avatar_url":"https://avatars3.githubusercontent.com/u/158660?v=3","gravatar_id":"","url":"https://api.github.com/users/simonomis","html_url":"https://github.com/simonomis","followers_url":"https://api.github.com/users/simonomis/followers","following_url":"https://api.github.com/users/simonomis/following{/other_user}","gists_url":"https://api.github.com/users/simonomis/gists{/gist_id}","starred_url":"https://api.github.com/users/simonomis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonomis/subscriptions","organizations_url":"https://api.github.com/users/simonomis/orgs","repos_url":"https://api.github.com/users/simonomis/repos","events_url":"https://api.github.com/users/simonomis/events{/privacy}","received_events_url":"https://api.github.com/users/simonomis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-03T13:08:49Z","updated_at":"2017-05-03T19:08:49Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/rubyide/vscode-ruby/pulls/145","html_url":"https://github.com/rubyide/vscode-ruby/pull/145","diff_url":"https://github.com/rubyide/vscode-ruby/pull/145.diff","patch_url":"https://github.com/rubyide/vscode-ruby/pull/145.patch"},"body":"Improves the handling when files referenced in the stacktrace aren't available where vscode is running. Addresses two issues that were causing the debugger to throw an exception (and so fail to provide the call stack and current position) when debugging a rails app within a docker container:\r\n\r\n- The rails app ran within the `/app` directory in the container, so files such as `/usr/local/lib/gems/railties-3.0.20/lib/rails/application.rb` weren't being filtered out by the check on line 259, which resulted in an exception when attempting to read the file (as the file only exists within the docker container)\r\n- One stack frame reported by rdebug-ide had a line number of 0, which caused an exception when trying to get the line from the array (on line 275).\r\n\r\nThis PR changes the logic so that missing files aren't filtered out, because it's still useful to be able to see the stackframe even if you can't see the code. Instead, they are included as \"filename:linenum\", like this: `actionpack-3.0.20/lib/action_controller/base.rb:150 (Unknown Source:150)` (the gems directory path is stripped off to make it easier to read).\r\n\r\nMake sure these boxes are checked before submitting your PR -- thanks in advance!\r\n\r\n- [x] Build pass!\r\n- [x] Follow VS Code [Coding Guidelines](https://github.com/Microsoft/vscode/wiki/Coding-Guidelines)"},"comment":{"url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/comments/299006369","html_url":"https://github.com/rubyide/vscode-ruby/pull/145#issuecomment-299006369","issue_url":"https://api.github.com/repos/rubyide/vscode-ruby/issues/145","id":299006369,"user":{"login":"rebornix","id":876920,"avatar_url":"https://avatars2.githubusercontent.com/u/876920?v=3","gravatar_id":"","url":"https://api.github.com/users/rebornix","html_url":"https://github.com/rebornix","followers_url":"https://api.github.com/users/rebornix/followers","following_url":"https://api.github.com/users/rebornix/following{/other_user}","gists_url":"https://api.github.com/users/rebornix/gists{/gist_id}","starred_url":"https://api.github.com/users/rebornix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rebornix/subscriptions","organizations_url":"https://api.github.com/users/rebornix/orgs","repos_url":"https://api.github.com/users/rebornix/repos","events_url":"https://api.github.com/users/rebornix/events{/privacy}","received_events_url":"https://api.github.com/users/rebornix/received_events","type":"User","site_admin":false},"created_at":"2017-05-03T19:08:49Z","updated_at":"2017-05-03T19:08:49Z","body":"Thanks @simonomis it looks awesome!"}}
{"actor":{"display_login":"rebornix"}}