{"action":"created","comment":{"url":"https://api.github.com/repos/sosy-lab/benchexec/pulls/comments/141997686","pull_request_review_id":66304431,"id":141997686,"diff_hunk":"@@ -117,26 +119,127 @@ def cmdline(self, executable, options, tasks, spec, rlimits):\n \n             cmdline += tasks\n             return cmdline\n-        else:\n-            cmdline = [executable]\n-\n-            if spec:\n-                cmdline += ['--spec', spec]\n-\n+        \n+        if spec:\n+            # use the old wrapper script if a property file is given\n+            self._uses_propertyfile = True \n+            cmdline += ['--spec', spec]\n             if tasks:\n                 cmdline += ['--file'] + tasks\n-\n-            # Not sure if we should append --full-output for new Ultimate, too\n-\n             cmdline += options\n             return cmdline\n+        \n+        # if no property file is given and toolchain (-tc) is, use ultimate directly \n+        if '-tc' in options or '--toolchain' in options:\n+            # ignore executable (old executable is just around for backwards compatibility) \n+            mem_bytes = rlimits.get(MEMLIMIT, None)\n+            cmdline = ['java']\n+            if mem_bytes:\n+                cmdline += ['-Xmx' + str(mem_bytes)]\n+    \n+            ultimatedir = os.path.dirname(executable)\n+            launcher = os.path.join(ultimatedir, _LAUNCHER_JAR)            \n+            cmdline += ['-jar', launcher]\n+    \n+            if not '-data' in options:\n+                cmdline += ['-data', os.path.join(ultimatedir, 'data')]\n+    \n+            cmdline += options\n+            \n+            if tasks:\n+                cmdline += ['-i'] + tasks\n+            \n+            return cmdline\n+        \n+        # there is no way to run ultimate; not enough parameters ","path":"benchexec/tools/ultimate.py","position":70,"original_position":70,"commit_id":"a6177054d7a7aa2fc3683beab35bc317de30d38d","original_commit_id":"a6177054d7a7aa2fc3683beab35bc317de30d38d","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars1.githubusercontent.com/u/19940114?v=4","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: [Trailing whitespace](https://www.codacy.com/app/sosy-lab/benchexec/pullRequest?prid=556705)","created_at":"2017-09-30T04:30:29Z","updated_at":"2017-09-30T04:30:30Z","html_url":"https://github.com/sosy-lab/benchexec/pull/234#discussion_r141997686","pull_request_url":"https://api.github.com/repos/sosy-lab/benchexec/pulls/234","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sosy-lab/benchexec/pulls/comments/141997686"},"html":{"href":"https://github.com/sosy-lab/benchexec/pull/234#discussion_r141997686"},"pull_request":{"href":"https://api.github.com/repos/sosy-lab/benchexec/pulls/234"}}},"pull_request":{"url":"https://api.github.com/repos/sosy-lab/benchexec/pulls/234","id":110417947,"html_url":"https://github.com/sosy-lab/benchexec/pull/234","diff_url":"https://github.com/sosy-lab/benchexec/pull/234.diff","patch_url":"https://github.com/sosy-lab/benchexec/pull/234.patch","issue_url":"https://api.github.com/repos/sosy-lab/benchexec/issues/234","number":234,"state":"open","locked":false,"title":"Preparing for LTL demo category","user":{"login":"danieldietsch","id":3883391,"avatar_url":"https://avatars0.githubusercontent.com/u/3883391?v=4","gravatar_id":"","url":"https://api.github.com/users/danieldietsch","html_url":"https://github.com/danieldietsch","followers_url":"https://api.github.com/users/danieldietsch/followers","following_url":"https://api.github.com/users/danieldietsch/following{/other_user}","gists_url":"https://api.github.com/users/danieldietsch/gists{/gist_id}","starred_url":"https://api.github.com/users/danieldietsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danieldietsch/subscriptions","organizations_url":"https://api.github.com/users/danieldietsch/orgs","repos_url":"https://api.github.com/users/danieldietsch/repos","events_url":"https://api.github.com/users/danieldietsch/events{/privacy}","received_events_url":"https://api.github.com/users/danieldietsch/received_events","type":"User","site_admin":false},"body":"Let benchexec support valid-ltl property (similar to valid-deref). \r\n\r\nOne issue: LTL properties allow arbitrary formulas inside the LTL part of a check annotation. Without changing the matching code in result.py matching may become brittle. \r\n\r\nIntention would be: If nothing else matches and LTL is present, assume valid-ltl property. \r\n\r\n\r\n","created_at":"2017-03-13T14:38:19Z","updated_at":"2017-09-30T04:30:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d1b925fc6a621f12435e3af9d67eca535ec0eab1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dbeyer","id":2941008,"avatar_url":"https://avatars3.githubusercontent.com/u/2941008?v=4","gravatar_id":"","url":"https://api.github.com/users/dbeyer","html_url":"https://github.com/dbeyer","followers_url":"https://api.github.com/users/dbeyer/followers","following_url":"https://api.github.com/users/dbeyer/following{/other_user}","gists_url":"https://api.github.com/users/dbeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbeyer/subscriptions","organizations_url":"https://api.github.com/users/dbeyer/orgs","repos_url":"https://api.github.com/users/dbeyer/repos","events_url":"https://api.github.com/users/dbeyer/events{/privacy}","received_events_url":"https://api.github.com/users/dbeyer/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sosy-lab/benchexec/pulls/234/commits","review_comments_url":"https://api.github.com/repos/sosy-lab/benchexec/pulls/234/comments","review_comment_url":"https://api.github.com/repos/sosy-lab/benchexec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sosy-lab/benchexec/issues/234/comments","statuses_url":"https://api.github.com/repos/sosy-lab/benchexec/statuses/a6177054d7a7aa2fc3683beab35bc317de30d38d","head":{"label":"ultimate-pa:master","ref":"master","sha":"a6177054d7a7aa2fc3683beab35bc317de30d38d","user":{"login":"ultimate-pa","id":13460489,"avatar_url":"https://avatars1.githubusercontent.com/u/13460489?v=4","gravatar_id":"","url":"https://api.github.com/users/ultimate-pa","html_url":"https://github.com/ultimate-pa","followers_url":"https://api.github.com/users/ultimate-pa/followers","following_url":"https://api.github.com/users/ultimate-pa/following{/other_user}","gists_url":"https://api.github.com/users/ultimate-pa/gists{/gist_id}","starred_url":"https://api.github.com/users/ultimate-pa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultimate-pa/subscriptions","organizations_url":"https://api.github.com/users/ultimate-pa/orgs","repos_url":"https://api.github.com/users/ultimate-pa/repos","events_url":"https://api.github.com/users/ultimate-pa/events{/privacy}","received_events_url":"https://api.github.com/users/ultimate-pa/received_events","type":"Organization","site_admin":false},"repo":{"id":45307256,"name":"benchexec","full_name":"ultimate-pa/benchexec","owner":{"login":"ultimate-pa","id":13460489,"avatar_url":"https://avatars1.githubusercontent.com/u/13460489?v=4","gravatar_id":"","url":"https://api.github.com/users/ultimate-pa","html_url":"https://github.com/ultimate-pa","followers_url":"https://api.github.com/users/ultimate-pa/followers","following_url":"https://api.github.com/users/ultimate-pa/following{/other_user}","gists_url":"https://api.github.com/users/ultimate-pa/gists{/gist_id}","starred_url":"https://api.github.com/users/ultimate-pa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ultimate-pa/subscriptions","organizations_url":"https://api.github.com/users/ultimate-pa/orgs","repos_url":"https://api.github.com/users/ultimate-pa/repos","events_url":"https://api.github.com/users/ultimate-pa/events{/privacy}","received_events_url":"https://api.github.com/users/ultimate-pa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ultimate-pa/benchexec","description":"BenchExec: A Framework for Reliable Benchmarking and Resource Measurement","fork":true,"url":"https://api.github.com/repos/ultimate-pa/benchexec","forks_url":"https://api.github.com/repos/ultimate-pa/benchexec/forks","keys_url":"https://api.github.com/repos/ultimate-pa/benchexec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ultimate-pa/benchexec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ultimate-pa/benchexec/teams","hooks_url":"https://api.github.com/repos/ultimate-pa/benchexec/hooks","issue_events_url":"https://api.github.com/repos/ultimate-pa/benchexec/issues/events{/number}","events_url":"https://api.github.com/repos/ultimate-pa/benchexec/events","assignees_url":"https://api.github.com/repos/ultimate-pa/benchexec/assignees{/user}","branches_url":"https://api.github.com/repos/ultimate-pa/benchexec/branches{/branch}","tags_url":"https://api.github.com/repos/ultimate-pa/benchexec/tags","blobs_url":"https://api.github.com/repos/ultimate-pa/benchexec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ultimate-pa/benchexec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ultimate-pa/benchexec/git/refs{/sha}","trees_url":"https://api.github.com/repos/ultimate-pa/benchexec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ultimate-pa/benchexec/statuses/{sha}","languages_url":"https://api.github.com/repos/ultimate-pa/benchexec/languages","stargazers_url":"https://api.github.com/repos/ultimate-pa/benchexec/stargazers","contributors_url":"https://api.github.com/repos/ultimate-pa/benchexec/contributors","subscribers_url":"https://api.github.com/repos/ultimate-pa/benchexec/subscribers","subscription_url":"https://api.github.com/repos/ultimate-pa/benchexec/subscription","commits_url":"https://api.github.com/repos/ultimate-pa/benchexec/commits{/sha}","git_commits_url":"https://api.github.com/repos/ultimate-pa/benchexec/git/commits{/sha}","comments_url":"https://api.github.com/repos/ultimate-pa/benchexec/comments{/number}","issue_comment_url":"https://api.github.com/repos/ultimate-pa/benchexec/issues/comments{/number}","contents_url":"https://api.github.com/repos/ultimate-pa/benchexec/contents/{+path}","compare_url":"https://api.github.com/repos/ultimate-pa/benchexec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ultimate-pa/benchexec/merges","archive_url":"https://api.github.com/repos/ultimate-pa/benchexec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ultimate-pa/benchexec/downloads","issues_url":"https://api.github.com/repos/ultimate-pa/benchexec/issues{/number}","pulls_url":"https://api.github.com/repos/ultimate-pa/benchexec/pulls{/number}","milestones_url":"https://api.github.com/repos/ultimate-pa/benchexec/milestones{/number}","notifications_url":"https://api.github.com/repos/ultimate-pa/benchexec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ultimate-pa/benchexec/labels{/name}","releases_url":"https://api.github.com/repos/ultimate-pa/benchexec/releases{/id}","deployments_url":"https://api.github.com/repos/ultimate-pa/benchexec/deployments","created_at":"2015-10-31T15:37:40Z","updated_at":"2017-05-08T16:32:54Z","pushed_at":"2017-09-28T15:31:27Z","git_url":"git://github.com/ultimate-pa/benchexec.git","ssh_url":"git@github.com:ultimate-pa/benchexec.git","clone_url":"https://github.com/ultimate-pa/benchexec.git","svn_url":"https://github.com/ultimate-pa/benchexec","homepage":"","size":2931,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sosy-lab:master","ref":"master","sha":"4af2de8b4253f728865078d71a43f8b89ad38074","user":{"login":"sosy-lab","id":16129993,"avatar_url":"https://avatars0.githubusercontent.com/u/16129993?v=4","gravatar_id":"","url":"https://api.github.com/users/sosy-lab","html_url":"https://github.com/sosy-lab","followers_url":"https://api.github.com/users/sosy-lab/followers","following_url":"https://api.github.com/users/sosy-lab/following{/other_user}","gists_url":"https://api.github.com/users/sosy-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/sosy-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosy-lab/subscriptions","organizations_url":"https://api.github.com/users/sosy-lab/orgs","repos_url":"https://api.github.com/users/sosy-lab/repos","events_url":"https://api.github.com/users/sosy-lab/events{/privacy}","received_events_url":"https://api.github.com/users/sosy-lab/received_events","type":"Organization","site_admin":false},"repo":{"id":30758422,"name":"benchexec","full_name":"sosy-lab/benchexec","owner":{"login":"sosy-lab","id":16129993,"avatar_url":"https://avatars0.githubusercontent.com/u/16129993?v=4","gravatar_id":"","url":"https://api.github.com/users/sosy-lab","html_url":"https://github.com/sosy-lab","followers_url":"https://api.github.com/users/sosy-lab/followers","following_url":"https://api.github.com/users/sosy-lab/following{/other_user}","gists_url":"https://api.github.com/users/sosy-lab/gists{/gist_id}","starred_url":"https://api.github.com/users/sosy-lab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sosy-lab/subscriptions","organizations_url":"https://api.github.com/users/sosy-lab/orgs","repos_url":"https://api.github.com/users/sosy-lab/repos","events_url":"https://api.github.com/users/sosy-lab/events{/privacy}","received_events_url":"https://api.github.com/users/sosy-lab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sosy-lab/benchexec","description":"BenchExec: A Framework for Reliable Benchmarking and Resource Measurement","fork":false,"url":"https://api.github.com/repos/sosy-lab/benchexec","forks_url":"https://api.github.com/repos/sosy-lab/benchexec/forks","keys_url":"https://api.github.com/repos/sosy-lab/benchexec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sosy-lab/benchexec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sosy-lab/benchexec/teams","hooks_url":"https://api.github.com/repos/sosy-lab/benchexec/hooks","issue_events_url":"https://api.github.com/repos/sosy-lab/benchexec/issues/events{/number}","events_url":"https://api.github.com/repos/sosy-lab/benchexec/events","assignees_url":"https://api.github.com/repos/sosy-lab/benchexec/assignees{/user}","branches_url":"https://api.github.com/repos/sosy-lab/benchexec/branches{/branch}","tags_url":"https://api.github.com/repos/sosy-lab/benchexec/tags","blobs_url":"https://api.github.com/repos/sosy-lab/benchexec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sosy-lab/benchexec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sosy-lab/benchexec/git/refs{/sha}","trees_url":"https://api.github.com/repos/sosy-lab/benchexec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sosy-lab/benchexec/statuses/{sha}","languages_url":"https://api.github.com/repos/sosy-lab/benchexec/languages","stargazers_url":"https://api.github.com/repos/sosy-lab/benchexec/stargazers","contributors_url":"https://api.github.com/repos/sosy-lab/benchexec/contributors","subscribers_url":"https://api.github.com/repos/sosy-lab/benchexec/subscribers","subscription_url":"https://api.github.com/repos/sosy-lab/benchexec/subscription","commits_url":"https://api.github.com/repos/sosy-lab/benchexec/commits{/sha}","git_commits_url":"https://api.github.com/repos/sosy-lab/benchexec/git/commits{/sha}","comments_url":"https://api.github.com/repos/sosy-lab/benchexec/comments{/number}","issue_comment_url":"https://api.github.com/repos/sosy-lab/benchexec/issues/comments{/number}","contents_url":"https://api.github.com/repos/sosy-lab/benchexec/contents/{+path}","compare_url":"https://api.github.com/repos/sosy-lab/benchexec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sosy-lab/benchexec/merges","archive_url":"https://api.github.com/repos/sosy-lab/benchexec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sosy-lab/benchexec/downloads","issues_url":"https://api.github.com/repos/sosy-lab/benchexec/issues{/number}","pulls_url":"https://api.github.com/repos/sosy-lab/benchexec/pulls{/number}","milestones_url":"https://api.github.com/repos/sosy-lab/benchexec/milestones{/number}","notifications_url":"https://api.github.com/repos/sosy-lab/benchexec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sosy-lab/benchexec/labels{/name}","releases_url":"https://api.github.com/repos/sosy-lab/benchexec/releases{/id}","deployments_url":"https://api.github.com/repos/sosy-lab/benchexec/deployments","created_at":"2015-02-13T13:55:15Z","updated_at":"2017-09-08T06:03:37Z","pushed_at":"2017-09-28T15:31:28Z","git_url":"git://github.com/sosy-lab/benchexec.git","ssh_url":"git@github.com:sosy-lab/benchexec.git","clone_url":"https://github.com/sosy-lab/benchexec.git","svn_url":"https://github.com/sosy-lab/benchexec","homepage":"","size":3179,"stargazers_count":29,"watchers_count":29,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":55,"mirror_url":null,"open_issues_count":49,"forks":55,"open_issues":49,"watchers":29,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sosy-lab/benchexec/pulls/234"},"html":{"href":"https://github.com/sosy-lab/benchexec/pull/234"},"issue":{"href":"https://api.github.com/repos/sosy-lab/benchexec/issues/234"},"comments":{"href":"https://api.github.com/repos/sosy-lab/benchexec/issues/234/comments"},"review_comments":{"href":"https://api.github.com/repos/sosy-lab/benchexec/pulls/234/comments"},"review_comment":{"href":"https://api.github.com/repos/sosy-lab/benchexec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sosy-lab/benchexec/pulls/234/commits"},"statuses":{"href":"https://api.github.com/repos/sosy-lab/benchexec/statuses/a6177054d7a7aa2fc3683beab35bc317de30d38d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"codacy-bot"}}