{"action":"created","issue":{"url":"https://api.github.com/repos/esnet/pond/issues/76","repository_url":"https://api.github.com/repos/esnet/pond","labels_url":"https://api.github.com/repos/esnet/pond/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/esnet/pond/issues/76/comments","events_url":"https://api.github.com/repos/esnet/pond/issues/76/events","html_url":"https://github.com/esnet/pond/issues/76","id":243257124,"number":76,"title":"Better dependencies management","user":{"login":"NN---","id":580536,"avatar_url":"https://avatars2.githubusercontent.com/u/580536?v=4","gravatar_id":"","url":"https://api.github.com/users/NN---","html_url":"https://github.com/NN---","followers_url":"https://api.github.com/users/NN---/followers","following_url":"https://api.github.com/users/NN---/following{/other_user}","gists_url":"https://api.github.com/users/NN---/gists{/gist_id}","starred_url":"https://api.github.com/users/NN---/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NN---/subscriptions","organizations_url":"https://api.github.com/users/NN---/orgs","repos_url":"https://api.github.com/users/NN---/repos","events_url":"https://api.github.com/users/NN---/events{/privacy}","received_events_url":"https://api.github.com/users/NN---/received_events","type":"User","site_admin":false},"labels":[{"id":188474806,"url":"https://api.github.com/repos/esnet/pond/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-07-16T18:28:55Z","updated_at":"2017-08-18T16:47:25Z","closed_at":null,"body":"Please don't import everything like:\r\n\r\n```ts\r\nimport * as _ from \"lodash\";\r\nimport * as Immutable from \"immutable\";\r\n```\r\n\r\nInstead import what you exactly need in the file.\r\nIt will reduce size of the bundle."},"comment":{"url":"https://api.github.com/repos/esnet/pond/issues/comments/323404215","html_url":"https://github.com/esnet/pond/issues/76#issuecomment-323404215","issue_url":"https://api.github.com/repos/esnet/pond/issues/76","id":323404215,"user":{"login":"pjm17971","id":1288813,"avatar_url":"https://avatars1.githubusercontent.com/u/1288813?v=4","gravatar_id":"","url":"https://api.github.com/users/pjm17971","html_url":"https://github.com/pjm17971","followers_url":"https://api.github.com/users/pjm17971/followers","following_url":"https://api.github.com/users/pjm17971/following{/other_user}","gists_url":"https://api.github.com/users/pjm17971/gists{/gist_id}","starred_url":"https://api.github.com/users/pjm17971/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pjm17971/subscriptions","organizations_url":"https://api.github.com/users/pjm17971/orgs","repos_url":"https://api.github.com/users/pjm17971/repos","events_url":"https://api.github.com/users/pjm17971/events{/privacy}","received_events_url":"https://api.github.com/users/pjm17971/received_events","type":"User","site_admin":false},"created_at":"2017-08-18T16:47:25Z","updated_at":"2017-08-18T16:47:25Z","body":"While I agree with this in principle, in practice I don't think this is so straightforward\r\n\r\nFirstly, being more specific with immutable.js seems kind of pointless right now. Importing only say SortedSet saves just 1k. See this issue for a discussion of why: https://github.com/facebook/immutable-js/issues/1190\r\n\r\nSecondly, the future typescript version of this code imports moment-timezone, with timezone information included, and currently the size of that dependency greatly overwhelms either lodash or immutable. It also imports locales for moment, regardless, which it might be possible to remove with webpack, but still that's probably 75% of moment's size. Being specific with moment does not help at all.\r\n\r\nLodash could be more specific using sub modules and make some marginal differences.\r\n\r\nI'm keeping this open as a general task to reduce sizes, but I don't think it's so simple."}}
{"actor":{"display_login":"pjm17971"}}