{"action":"created","comment":{"url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments/142484291","pull_request_review_id":66851810,"id":142484291,"diff_hunk":"@@ -0,0 +1,200 @@\n+// Copyright (c) 2017 Tigera, Inc. All rights reserved.\n+\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+//     http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+package names_test\n+\n+import (\n+\t. \"github.com/onsi/ginkgo/extensions/table\"\n+\t. \"github.com/onsi/gomega\"\n+\tcerrors \"github.com/projectcalico/libcalico-go/lib/errors\"\n+\t\"github.com/projectcalico/libcalico-go/lib/names\"\n+)\n+\n+func init() {\n+\tDescribeTable(\"WorkloadEndpoint name construction, fully qualified names\",\n+\t\tfunc(ids names.WorkloadEndpointIdentifiers, name string, erroredField string) {","path":"lib/names/workloadendpoint_test.go","position":26,"original_position":26,"commit_id":"260bda4c5e2388d243e2c6b000f810964a11ea42","original_commit_id":"260bda4c5e2388d243e2c6b000f810964a11ea42","user":{"login":"gunjan5","id":5966968,"avatar_url":"https://avatars1.githubusercontent.com/u/5966968?v=4","gravatar_id":"","url":"https://api.github.com/users/gunjan5","html_url":"https://github.com/gunjan5","followers_url":"https://api.github.com/users/gunjan5/followers","following_url":"https://api.github.com/users/gunjan5/following{/other_user}","gists_url":"https://api.github.com/users/gunjan5/gists{/gist_id}","starred_url":"https://api.github.com/users/gunjan5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunjan5/subscriptions","organizations_url":"https://api.github.com/users/gunjan5/orgs","repos_url":"https://api.github.com/users/gunjan5/repos","events_url":"https://api.github.com/users/gunjan5/events{/privacy}","received_events_url":"https://api.github.com/users/gunjan5/received_events","type":"User","site_admin":false},"body":"nit: for table driven test, it's nice to have expected output variables named something like `expectedName` so it's easy to understand when someone is reading the test ","created_at":"2017-10-03T18:30:04Z","updated_at":"2017-10-03T18:50:26Z","html_url":"https://github.com/projectcalico/libcalico-go/pull/544#discussion_r142484291","pull_request_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/544","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments/142484291"},"html":{"href":"https://github.com/projectcalico/libcalico-go/pull/544#discussion_r142484291"},"pull_request":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/544"}}},"pull_request":{"url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/544","id":143772326,"html_url":"https://github.com/projectcalico/libcalico-go/pull/544","diff_url":"https://github.com/projectcalico/libcalico-go/pull/544.diff","patch_url":"https://github.com/projectcalico/libcalico-go/pull/544.patch","issue_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/544","number":544,"state":"open","locked":false,"title":"WorkloadEndpoint name construction helper","user":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars0.githubusercontent.com/u/3227729?v=4","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"body":"This will be useful for the CNI plugin integration and other integrations in the future.\r\n\r\nThis contains methods to construct the WEP name from a set of Identifiers, and to compare a WEP name against the set of identifiers (which will be required if you are doing a prefix list).","created_at":"2017-09-28T22:40:33Z","updated_at":"2017-10-03T18:50:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b886ad732c61bb9a5e1ebda070b2212f1a39ab44","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/544/commits","review_comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/544/comments","review_comment_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/544/comments","statuses_url":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/260bda4c5e2388d243e2c6b000f810964a11ea42","head":{"label":"robbrockbank:wep-name-helper","ref":"wep-name-helper","sha":"260bda4c5e2388d243e2c6b000f810964a11ea42","user":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars0.githubusercontent.com/u/3227729?v=4","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"repo":{"id":63622166,"name":"libcalico-go","full_name":"robbrockbank/libcalico-go","owner":{"login":"robbrockbank","id":3227729,"avatar_url":"https://avatars0.githubusercontent.com/u/3227729?v=4","gravatar_id":"","url":"https://api.github.com/users/robbrockbank","html_url":"https://github.com/robbrockbank","followers_url":"https://api.github.com/users/robbrockbank/followers","following_url":"https://api.github.com/users/robbrockbank/following{/other_user}","gists_url":"https://api.github.com/users/robbrockbank/gists{/gist_id}","starred_url":"https://api.github.com/users/robbrockbank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbrockbank/subscriptions","organizations_url":"https://api.github.com/users/robbrockbank/orgs","repos_url":"https://api.github.com/users/robbrockbank/repos","events_url":"https://api.github.com/users/robbrockbank/events{/privacy}","received_events_url":"https://api.github.com/users/robbrockbank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robbrockbank/libcalico-go","description":"Golang Calico library functions:  https://www.projectcalico.org","fork":true,"url":"https://api.github.com/repos/robbrockbank/libcalico-go","forks_url":"https://api.github.com/repos/robbrockbank/libcalico-go/forks","keys_url":"https://api.github.com/repos/robbrockbank/libcalico-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robbrockbank/libcalico-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robbrockbank/libcalico-go/teams","hooks_url":"https://api.github.com/repos/robbrockbank/libcalico-go/hooks","issue_events_url":"https://api.github.com/repos/robbrockbank/libcalico-go/issues/events{/number}","events_url":"https://api.github.com/repos/robbrockbank/libcalico-go/events","assignees_url":"https://api.github.com/repos/robbrockbank/libcalico-go/assignees{/user}","branches_url":"https://api.github.com/repos/robbrockbank/libcalico-go/branches{/branch}","tags_url":"https://api.github.com/repos/robbrockbank/libcalico-go/tags","blobs_url":"https://api.github.com/repos/robbrockbank/libcalico-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robbrockbank/libcalico-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robbrockbank/libcalico-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/robbrockbank/libcalico-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robbrockbank/libcalico-go/statuses/{sha}","languages_url":"https://api.github.com/repos/robbrockbank/libcalico-go/languages","stargazers_url":"https://api.github.com/repos/robbrockbank/libcalico-go/stargazers","contributors_url":"https://api.github.com/repos/robbrockbank/libcalico-go/contributors","subscribers_url":"https://api.github.com/repos/robbrockbank/libcalico-go/subscribers","subscription_url":"https://api.github.com/repos/robbrockbank/libcalico-go/subscription","commits_url":"https://api.github.com/repos/robbrockbank/libcalico-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/robbrockbank/libcalico-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/robbrockbank/libcalico-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/robbrockbank/libcalico-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/robbrockbank/libcalico-go/contents/{+path}","compare_url":"https://api.github.com/repos/robbrockbank/libcalico-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robbrockbank/libcalico-go/merges","archive_url":"https://api.github.com/repos/robbrockbank/libcalico-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robbrockbank/libcalico-go/downloads","issues_url":"https://api.github.com/repos/robbrockbank/libcalico-go/issues{/number}","pulls_url":"https://api.github.com/repos/robbrockbank/libcalico-go/pulls{/number}","milestones_url":"https://api.github.com/repos/robbrockbank/libcalico-go/milestones{/number}","notifications_url":"https://api.github.com/repos/robbrockbank/libcalico-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robbrockbank/libcalico-go/labels{/name}","releases_url":"https://api.github.com/repos/robbrockbank/libcalico-go/releases{/id}","deployments_url":"https://api.github.com/repos/robbrockbank/libcalico-go/deployments","created_at":"2016-07-18T17:12:42Z","updated_at":"2016-07-18T17:12:43Z","pushed_at":"2017-10-03T18:35:36Z","git_url":"git://github.com/robbrockbank/libcalico-go.git","ssh_url":"git@github.com:robbrockbank/libcalico-go.git","clone_url":"https://github.com/robbrockbank/libcalico-go.git","svn_url":"https://github.com/robbrockbank/libcalico-go","homepage":null,"size":2023,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"projectcalico:v3.0-integration","ref":"v3.0-integration","sha":"9beab9e35bc4b246571e08291674900906d4b40e","user":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"repo":{"id":63438319,"name":"libcalico-go","full_name":"projectcalico/libcalico-go","owner":{"login":"projectcalico","id":12304728,"avatar_url":"https://avatars3.githubusercontent.com/u/12304728?v=4","gravatar_id":"","url":"https://api.github.com/users/projectcalico","html_url":"https://github.com/projectcalico","followers_url":"https://api.github.com/users/projectcalico/followers","following_url":"https://api.github.com/users/projectcalico/following{/other_user}","gists_url":"https://api.github.com/users/projectcalico/gists{/gist_id}","starred_url":"https://api.github.com/users/projectcalico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/projectcalico/subscriptions","organizations_url":"https://api.github.com/users/projectcalico/orgs","repos_url":"https://api.github.com/users/projectcalico/repos","events_url":"https://api.github.com/users/projectcalico/events{/privacy}","received_events_url":"https://api.github.com/users/projectcalico/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/projectcalico/libcalico-go","description":"Golang Calico library functions:  https://www.projectcalico.org","fork":false,"url":"https://api.github.com/repos/projectcalico/libcalico-go","forks_url":"https://api.github.com/repos/projectcalico/libcalico-go/forks","keys_url":"https://api.github.com/repos/projectcalico/libcalico-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/projectcalico/libcalico-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/projectcalico/libcalico-go/teams","hooks_url":"https://api.github.com/repos/projectcalico/libcalico-go/hooks","issue_events_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/events{/number}","events_url":"https://api.github.com/repos/projectcalico/libcalico-go/events","assignees_url":"https://api.github.com/repos/projectcalico/libcalico-go/assignees{/user}","branches_url":"https://api.github.com/repos/projectcalico/libcalico-go/branches{/branch}","tags_url":"https://api.github.com/repos/projectcalico/libcalico-go/tags","blobs_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/{sha}","languages_url":"https://api.github.com/repos/projectcalico/libcalico-go/languages","stargazers_url":"https://api.github.com/repos/projectcalico/libcalico-go/stargazers","contributors_url":"https://api.github.com/repos/projectcalico/libcalico-go/contributors","subscribers_url":"https://api.github.com/repos/projectcalico/libcalico-go/subscribers","subscription_url":"https://api.github.com/repos/projectcalico/libcalico-go/subscription","commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/projectcalico/libcalico-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/projectcalico/libcalico-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/projectcalico/libcalico-go/contents/{+path}","compare_url":"https://api.github.com/repos/projectcalico/libcalico-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/projectcalico/libcalico-go/merges","archive_url":"https://api.github.com/repos/projectcalico/libcalico-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/projectcalico/libcalico-go/downloads","issues_url":"https://api.github.com/repos/projectcalico/libcalico-go/issues{/number}","pulls_url":"https://api.github.com/repos/projectcalico/libcalico-go/pulls{/number}","milestones_url":"https://api.github.com/repos/projectcalico/libcalico-go/milestones{/number}","notifications_url":"https://api.github.com/repos/projectcalico/libcalico-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/projectcalico/libcalico-go/labels{/name}","releases_url":"https://api.github.com/repos/projectcalico/libcalico-go/releases{/id}","deployments_url":"https://api.github.com/repos/projectcalico/libcalico-go/deployments","created_at":"2016-07-15T17:09:40Z","updated_at":"2017-09-29T22:38:49Z","pushed_at":"2017-10-03T18:35:37Z","git_url":"git://github.com/projectcalico/libcalico-go.git","ssh_url":"git@github.com:projectcalico/libcalico-go.git","clone_url":"https://github.com/projectcalico/libcalico-go.git","svn_url":"https://github.com/projectcalico/libcalico-go","homepage":null,"size":1737,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":47,"mirror_url":null,"open_issues_count":24,"forks":47,"open_issues":24,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/544"},"html":{"href":"https://github.com/projectcalico/libcalico-go/pull/544"},"issue":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/issues/544"},"comments":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/issues/544/comments"},"review_comments":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/544/comments"},"review_comment":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/pulls/544/commits"},"statuses":{"href":"https://api.github.com/repos/projectcalico/libcalico-go/statuses/260bda4c5e2388d243e2c6b000f810964a11ea42"}},"author_association":"OWNER"}}
{"actor":{"display_login":"gunjan5"}}