{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react/pulls/comments/145216195","pull_request_review_id":69979845,"id":145216195,"diff_hunk":"@@ -1304,6 +1331,30 @@ function ChildReconciler(shouldClone, shouldTrackSideEffects) {\n       // everything else as empty, but log a warning.\n       switch (newChild.$$typeof) {\n         case REACT_ELEMENT_TYPE:\n+          // If newChild is a top-level unkeyed fragment, don't create a fiber\n+          if (\n+            newChild.type === '#fragment' &&\n+            newChild.key === null &&\n+            (returnFiber.tag === HostRoot ||","path":"src/renderers/shared/fiber/ReactChildFiber.js","position":null,"original_position":85,"commit_id":"45d5cad10c10e57b36a5e13a820abc040f2a7dd1","original_commit_id":"6aa2c905a096c27fee883fc6a675b4c4753bc1d6","user":{"login":"acdlite","id":3624098,"avatar_url":"https://avatars0.githubusercontent.com/u/3624098?v=4","gravatar_id":"","url":"https://api.github.com/users/acdlite","html_url":"https://github.com/acdlite","followers_url":"https://api.github.com/users/acdlite/followers","following_url":"https://api.github.com/users/acdlite/following{/other_user}","gists_url":"https://api.github.com/users/acdlite/gists{/gist_id}","starred_url":"https://api.github.com/users/acdlite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acdlite/subscriptions","organizations_url":"https://api.github.com/users/acdlite/orgs","repos_url":"https://api.github.com/users/acdlite/repos","events_url":"https://api.github.com/users/acdlite/events{/privacy}","received_events_url":"https://api.github.com/users/acdlite/received_events","type":"User","site_admin":false},"body":"Why are you checking the type of return fiber? Does it matter?","created_at":"2017-10-17T18:31:48Z","updated_at":"2017-10-17T18:33:20Z","html_url":"https://github.com/facebook/react/pull/10783#discussion_r145216195","pull_request_url":"https://api.github.com/repos/facebook/react/pulls/10783","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/comments/145216195"},"html":{"href":"https://github.com/facebook/react/pull/10783#discussion_r145216195"},"pull_request":{"href":"https://api.github.com/repos/facebook/react/pulls/10783"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/react/pulls/10783","id":142676054,"html_url":"https://github.com/facebook/react/pull/10783","diff_url":"https://github.com/facebook/react/pull/10783.diff","patch_url":"https://github.com/facebook/react/pull/10783.patch","issue_url":"https://api.github.com/repos/facebook/react/issues/10783","number":10783,"state":"open","locked":false,"title":"Add Fragment as a named export to React","user":{"login":"clemmy","id":3696934,"avatar_url":"https://avatars0.githubusercontent.com/u/3696934?v=4","gravatar_id":"","url":"https://api.github.com/users/clemmy","html_url":"https://github.com/clemmy","followers_url":"https://api.github.com/users/clemmy/followers","following_url":"https://api.github.com/users/clemmy/following{/other_user}","gists_url":"https://api.github.com/users/clemmy/gists{/gist_id}","starred_url":"https://api.github.com/users/clemmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clemmy/subscriptions","organizations_url":"https://api.github.com/users/clemmy/orgs","repos_url":"https://api.github.com/users/clemmy/repos","events_url":"https://api.github.com/users/clemmy/events{/privacy}","received_events_url":"https://api.github.com/users/clemmy/received_events","type":"User","site_admin":false},"body":"This PR is a part of the bigger change to introduce `<></>` fragment syntax to JSX. With this named export, we'll be able to de-sugar `<></>` into `React.createElement(React.Fragment)` calls.\r\n\r\nSome concerns:\r\n\r\n- Not sure if the way I imported dependencies in `ReactFragment-test.js` is the best way to go about things. I initially tried requiring them all at the top, but I got the error `Invariant Violation: EventPluginRegistry: Cannot inject event plugin ordering more than once. You are likely trying to load more than one copy of React.`, and this was my way of getting around it.\r\n- Is there documentation somewhere that I should update for this PR?\r\n\r\n","created_at":"2017-09-22T21:46:04Z","updated_at":"2017-10-17T18:33:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a9effa9716228ffc0a6b476d16977ee135dfc82","assignee":null,"assignees":[],"requested_reviewers":[{"login":"flarnie","id":1114467,"avatar_url":"https://avatars2.githubusercontent.com/u/1114467?v=4","gravatar_id":"","url":"https://api.github.com/users/flarnie","html_url":"https://github.com/flarnie","followers_url":"https://api.github.com/users/flarnie/followers","following_url":"https://api.github.com/users/flarnie/following{/other_user}","gists_url":"https://api.github.com/users/flarnie/gists{/gist_id}","starred_url":"https://api.github.com/users/flarnie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flarnie/subscriptions","organizations_url":"https://api.github.com/users/flarnie/orgs","repos_url":"https://api.github.com/users/flarnie/repos","events_url":"https://api.github.com/users/flarnie/events{/privacy}","received_events_url":"https://api.github.com/users/flarnie/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react/pulls/10783/commits","review_comments_url":"https://api.github.com/repos/facebook/react/pulls/10783/comments","review_comment_url":"https://api.github.com/repos/facebook/react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react/issues/10783/comments","statuses_url":"https://api.github.com/repos/facebook/react/statuses/45d5cad10c10e57b36a5e13a820abc040f2a7dd1","head":{"label":"clemmy:react-fragment-export","ref":"react-fragment-export","sha":"45d5cad10c10e57b36a5e13a820abc040f2a7dd1","user":{"login":"clemmy","id":3696934,"avatar_url":"https://avatars0.githubusercontent.com/u/3696934?v=4","gravatar_id":"","url":"https://api.github.com/users/clemmy","html_url":"https://github.com/clemmy","followers_url":"https://api.github.com/users/clemmy/followers","following_url":"https://api.github.com/users/clemmy/following{/other_user}","gists_url":"https://api.github.com/users/clemmy/gists{/gist_id}","starred_url":"https://api.github.com/users/clemmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clemmy/subscriptions","organizations_url":"https://api.github.com/users/clemmy/orgs","repos_url":"https://api.github.com/users/clemmy/repos","events_url":"https://api.github.com/users/clemmy/events{/privacy}","received_events_url":"https://api.github.com/users/clemmy/received_events","type":"User","site_admin":false},"repo":{"id":102768879,"name":"react","full_name":"clemmy/react","owner":{"login":"clemmy","id":3696934,"avatar_url":"https://avatars0.githubusercontent.com/u/3696934?v=4","gravatar_id":"","url":"https://api.github.com/users/clemmy","html_url":"https://github.com/clemmy","followers_url":"https://api.github.com/users/clemmy/followers","following_url":"https://api.github.com/users/clemmy/following{/other_user}","gists_url":"https://api.github.com/users/clemmy/gists{/gist_id}","starred_url":"https://api.github.com/users/clemmy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clemmy/subscriptions","organizations_url":"https://api.github.com/users/clemmy/orgs","repos_url":"https://api.github.com/users/clemmy/repos","events_url":"https://api.github.com/users/clemmy/events{/privacy}","received_events_url":"https://api.github.com/users/clemmy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/clemmy/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":true,"url":"https://api.github.com/repos/clemmy/react","forks_url":"https://api.github.com/repos/clemmy/react/forks","keys_url":"https://api.github.com/repos/clemmy/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clemmy/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clemmy/react/teams","hooks_url":"https://api.github.com/repos/clemmy/react/hooks","issue_events_url":"https://api.github.com/repos/clemmy/react/issues/events{/number}","events_url":"https://api.github.com/repos/clemmy/react/events","assignees_url":"https://api.github.com/repos/clemmy/react/assignees{/user}","branches_url":"https://api.github.com/repos/clemmy/react/branches{/branch}","tags_url":"https://api.github.com/repos/clemmy/react/tags","blobs_url":"https://api.github.com/repos/clemmy/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clemmy/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clemmy/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/clemmy/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clemmy/react/statuses/{sha}","languages_url":"https://api.github.com/repos/clemmy/react/languages","stargazers_url":"https://api.github.com/repos/clemmy/react/stargazers","contributors_url":"https://api.github.com/repos/clemmy/react/contributors","subscribers_url":"https://api.github.com/repos/clemmy/react/subscribers","subscription_url":"https://api.github.com/repos/clemmy/react/subscription","commits_url":"https://api.github.com/repos/clemmy/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/clemmy/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/clemmy/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/clemmy/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/clemmy/react/contents/{+path}","compare_url":"https://api.github.com/repos/clemmy/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clemmy/react/merges","archive_url":"https://api.github.com/repos/clemmy/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clemmy/react/downloads","issues_url":"https://api.github.com/repos/clemmy/react/issues{/number}","pulls_url":"https://api.github.com/repos/clemmy/react/pulls{/number}","milestones_url":"https://api.github.com/repos/clemmy/react/milestones{/number}","notifications_url":"https://api.github.com/repos/clemmy/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clemmy/react/labels{/name}","releases_url":"https://api.github.com/repos/clemmy/react/releases{/id}","deployments_url":"https://api.github.com/repos/clemmy/react/deployments","created_at":"2017-09-07T17:56:37Z","updated_at":"2017-09-07T17:56:48Z","pushed_at":"2017-10-17T18:27:42Z","git_url":"git://github.com/clemmy/react.git","ssh_url":"git@github.com:clemmy/react.git","clone_url":"https://github.com/clemmy/react.git","svn_url":"https://github.com/clemmy/react","homepage":"https://facebook.github.io/react/","size":130513,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"a160f3ecfa2fff67d8dec9c22a63300b78d3ad0c","user":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":10270250,"name":"react","full_name":"facebook/react","owner":{"login":"facebook","id":69631,"avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react","description":"A declarative, efficient, and flexible JavaScript library for building user interfaces.","fork":false,"url":"https://api.github.com/repos/facebook/react","forks_url":"https://api.github.com/repos/facebook/react/forks","keys_url":"https://api.github.com/repos/facebook/react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react/teams","hooks_url":"https://api.github.com/repos/facebook/react/hooks","issue_events_url":"https://api.github.com/repos/facebook/react/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react/events","assignees_url":"https://api.github.com/repos/facebook/react/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react/tags","blobs_url":"https://api.github.com/repos/facebook/react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react/languages","stargazers_url":"https://api.github.com/repos/facebook/react/stargazers","contributors_url":"https://api.github.com/repos/facebook/react/contributors","subscribers_url":"https://api.github.com/repos/facebook/react/subscribers","subscription_url":"https://api.github.com/repos/facebook/react/subscription","commits_url":"https://api.github.com/repos/facebook/react/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react/merges","archive_url":"https://api.github.com/repos/facebook/react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react/downloads","issues_url":"https://api.github.com/repos/facebook/react/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react/deployments","created_at":"2013-05-24T16:15:54Z","updated_at":"2017-10-17T18:24:45Z","pushed_at":"2017-10-17T18:28:01Z","git_url":"git://github.com/facebook/react.git","ssh_url":"git@github.com:facebook/react.git","clone_url":"https://github.com/facebook/react.git","svn_url":"https://github.com/facebook/react","homepage":"https://reactjs.org","size":130117,"stargazers_count":78662,"watchers_count":78662,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14897,"mirror_url":null,"open_issues_count":394,"forks":14897,"open_issues":394,"watchers":78662,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react/pulls/10783"},"html":{"href":"https://github.com/facebook/react/pull/10783"},"issue":{"href":"https://api.github.com/repos/facebook/react/issues/10783"},"comments":{"href":"https://api.github.com/repos/facebook/react/issues/10783/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react/pulls/10783/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react/pulls/10783/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react/statuses/45d5cad10c10e57b36a5e13a820abc040f2a7dd1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"acdlite"}}