{"action":"created","comment":{"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/comments/149236524","pull_request_review_id":74599878,"id":149236524,"diff_hunk":"@@ -94,6 +97,25 @@ impl ::std::default::Default for Struct_dm_ioctl {\n         unsafe { ::std::mem::zeroed() }\n     }\n }\n+impl fmt::Debug for Struct_dm_ioctl {\n+    fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {\n+        f.debug_struct(\"Struct_dm_ioctl\")\n+            .field(\"version\", &self.version)\n+            .field(\"data_size\", &self.data_size)\n+            .field(\"data_start\", &self.data_start)\n+            .field(\"target_count\", &self.target_count)\n+            .field(\"open_count\", &self.open_count)\n+            .field(\"flags\", &self.flags)\n+            .field(\"event_nr\", &self.event_nr)\n+            .field(\"padding\", &self.padding)\n+            .field(\"dev\", &self.dev)\n+            .field(\"name\", &self.name.to_vec())","path":"src/dm_ioctl.rs","position":65,"original_position":32,"commit_id":"3ee29fec992481400cc70af707030094288a238a","original_commit_id":"514a2d24502cb880e76077433df88c2e8e13006c","user":{"login":"agrover","id":2305,"avatar_url":"https://avatars1.githubusercontent.com/u/2305?v=4","gravatar_id":"","url":"https://api.github.com/users/agrover","html_url":"https://github.com/agrover","followers_url":"https://api.github.com/users/agrover/followers","following_url":"https://api.github.com/users/agrover/following{/other_user}","gists_url":"https://api.github.com/users/agrover/gists{/gist_id}","starred_url":"https://api.github.com/users/agrover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrover/subscriptions","organizations_url":"https://api.github.com/users/agrover/orgs","repos_url":"https://api.github.com/users/agrover/repos","events_url":"https://api.github.com/users/agrover/events{/privacy}","received_events_url":"https://api.github.com/users/agrover/received_events","type":"User","site_admin":false},"body":"yup ok, let's defer prettifying and c_char questions.","created_at":"2017-11-06T23:38:02Z","updated_at":"2017-11-06T23:38:02Z","html_url":"https://github.com/stratis-storage/devicemapper-rs/pull/199#discussion_r149236524","pull_request_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/199","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/comments/149236524"},"html":{"href":"https://github.com/stratis-storage/devicemapper-rs/pull/199#discussion_r149236524"},"pull_request":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/199"}},"in_reply_to_id":149203339},"pull_request":{"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/199","id":150619004,"html_url":"https://github.com/stratis-storage/devicemapper-rs/pull/199","diff_url":"https://github.com/stratis-storage/devicemapper-rs/pull/199.diff","patch_url":"https://github.com/stratis-storage/devicemapper-rs/pull/199.patch","issue_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/199","number":199,"state":"open","locked":false,"title":"Have IoctlError include header struct field","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"body":"The purpose here is to have IoctlError include the header struct that was passed when the Ioctl called. It seems like the only obviously useful context.\r\n\r\nIn order to do that I had to implement Debug for ```Struct_dm_ioctl```. Then in passing, I noticed that ```Struct_dm_ioctl``` derived Copy, but was rather large for that, and that it wasn't really used, except to implement Clone, which I then implemented explicitly.","created_at":"2017-11-03T20:13:12Z","updated_at":"2017-11-06T23:38:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"17a72b6df4c089c76444ed2f649f1125c26e4deb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/199/commits","review_comments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/199/comments","review_comment_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/199/comments","statuses_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/statuses/3ee29fec992481400cc70af707030094288a238a","head":{"label":"mulkieran:master-error-chain-core","ref":"master-error-chain-core","sha":"3ee29fec992481400cc70af707030094288a238a","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"repo":{"id":86095047,"name":"devicemapper-rs","full_name":"mulkieran/devicemapper-rs","owner":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mulkieran/devicemapper-rs","description":"A Rust library for using Linux devicemapper","fork":true,"url":"https://api.github.com/repos/mulkieran/devicemapper-rs","forks_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/forks","keys_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/teams","hooks_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/hooks","issue_events_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/issues/events{/number}","events_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/events","assignees_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/assignees{/user}","branches_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/branches{/branch}","tags_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/tags","blobs_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/languages","stargazers_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/stargazers","contributors_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/contributors","subscribers_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/subscribers","subscription_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/subscription","commits_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/contents/{+path}","compare_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/merges","archive_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/downloads","issues_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/issues{/number}","pulls_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/labels{/name}","releases_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/releases{/id}","deployments_url":"https://api.github.com/repos/mulkieran/devicemapper-rs/deployments","created_at":"2017-03-24T17:40:16Z","updated_at":"2017-03-24T17:40:18Z","pushed_at":"2017-11-06T22:05:36Z","git_url":"git://github.com/mulkieran/devicemapper-rs.git","ssh_url":"git@github.com:mulkieran/devicemapper-rs.git","clone_url":"https://github.com/mulkieran/devicemapper-rs.git","svn_url":"https://github.com/mulkieran/devicemapper-rs","homepage":null,"size":2323,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratis-storage:master","ref":"master","sha":"57ddde6aaf6e7c83129b1928f3a24bc1a9a5a7fd","user":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"repo":{"id":41330009,"name":"devicemapper-rs","full_name":"stratis-storage/devicemapper-rs","owner":{"login":"stratis-storage","id":21202300,"avatar_url":"https://avatars2.githubusercontent.com/u/21202300?v=4","gravatar_id":"","url":"https://api.github.com/users/stratis-storage","html_url":"https://github.com/stratis-storage","followers_url":"https://api.github.com/users/stratis-storage/followers","following_url":"https://api.github.com/users/stratis-storage/following{/other_user}","gists_url":"https://api.github.com/users/stratis-storage/gists{/gist_id}","starred_url":"https://api.github.com/users/stratis-storage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratis-storage/subscriptions","organizations_url":"https://api.github.com/users/stratis-storage/orgs","repos_url":"https://api.github.com/users/stratis-storage/repos","events_url":"https://api.github.com/users/stratis-storage/events{/privacy}","received_events_url":"https://api.github.com/users/stratis-storage/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratis-storage/devicemapper-rs","description":"A Rust library for using Linux devicemapper","fork":false,"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs","forks_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/forks","keys_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/teams","hooks_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/hooks","issue_events_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/events{/number}","events_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/events","assignees_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/assignees{/user}","branches_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/branches{/branch}","tags_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/tags","blobs_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/statuses/{sha}","languages_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/languages","stargazers_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/stargazers","contributors_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/contributors","subscribers_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/subscribers","subscription_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/subscription","commits_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/contents/{+path}","compare_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/merges","archive_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/downloads","issues_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues{/number}","pulls_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls{/number}","milestones_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/milestones{/number}","notifications_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/labels{/name}","releases_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/releases{/id}","deployments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/deployments","created_at":"2015-08-24T22:25:32Z","updated_at":"2017-10-08T02:29:13Z","pushed_at":"2017-11-06T22:05:38Z","git_url":"git://github.com/stratis-storage/devicemapper-rs.git","ssh_url":"git@github.com:stratis-storage/devicemapper-rs.git","clone_url":"https://github.com/stratis-storage/devicemapper-rs.git","svn_url":"https://github.com/stratis-storage/devicemapper-rs","homepage":null,"size":2272,"stargazers_count":18,"watchers_count":18,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":17,"forks":9,"open_issues":17,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/199"},"html":{"href":"https://github.com/stratis-storage/devicemapper-rs/pull/199"},"issue":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/199"},"comments":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/199/comments"},"review_comments":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/199/comments"},"review_comment":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/199/commits"},"statuses":{"href":"https://api.github.com/repos/stratis-storage/devicemapper-rs/statuses/3ee29fec992481400cc70af707030094288a238a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"agrover"}}