{"action":"created","comment":{"url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/comments/126343841","pull_request_review_id":48817264,"id":126343841,"diff_hunk":"@@ -243,9 +243,53 @@ public String getTitleToolbar() {\n         return mContext.getString(R.string.confirm_edit_request_off);\n     }\n \n+    public String getStartDateHaveSalary() {\n+        if (mOffRequest != null && mOffRequest.getStartDayHaveSalary() != null) {\n+            if (!\"\".equals(mOffRequest.getStartDayHaveSalary().getOffPaidFrom())) {\n+                return mOffRequest.getStartDayHaveSalary().getOffPaidFrom()\n+                        + Constant.BLANK\n+                        + mOffRequest.getStartDayHaveSalary().getPaidFromPeriod();\n+            }\n+        }\n+        return \"\";\n+    }\n+\n+    public String getEndDateHaveSalary() {\n+        if (mOffRequest != null && mOffRequest.getEndDayHaveSalary() != null) {\n+            if (!\"\".equals(mOffRequest.getEndDayHaveSalary().getOffPaidTo())) {\n+                return mOffRequest.getEndDayHaveSalary().getOffPaidTo()\n+                        + Constant.BLANK\n+                        + mOffRequest.getEndDayHaveSalary().getPaidToPeriod();\n+            }\n+        }\n+        return \"\";\n+    }\n+\n+    public String getStartDateNoSalary() {\n+        if (mOffRequest != null && mOffRequest.getStartDayNoSalary() != null) {\n+            if (!\"\".equals(mOffRequest.getStartDayNoSalary().getOffFrom())) {\n+                return mOffRequest.getStartDayNoSalary().getOffFrom() + Constant.BLANK + mOffRequest\n+                        .getStartDayNoSalary()\n+                        .getOffFromPeriod();\n+            }\n+        }\n+        return \"\";\n+    }\n+\n+    public String getEndDateNoSalary() {\n+        if (mOffRequest != null && mOffRequest.getEndDayNoSalary() != null) {\n+            if (!\"\".equals(mOffRequest.getEndDayNoSalary().getOffTo())) {","path":"app/src/main/java/com/framgia/wsm/screen/confirmrequestoff/ConfirmRequestOffViewModel.java","position":39,"original_position":39,"commit_id":"996bca8cd6914da925d5b97918b844e60f9edea3","original_commit_id":"996bca8cd6914da925d5b97918b844e60f9edea3","user":{"login":"daolq3012","id":20784172,"avatar_url":"https://avatars3.githubusercontent.com/u/20784172?v=3","gravatar_id":"","url":"https://api.github.com/users/daolq3012","html_url":"https://github.com/daolq3012","followers_url":"https://api.github.com/users/daolq3012/followers","following_url":"https://api.github.com/users/daolq3012/following{/other_user}","gists_url":"https://api.github.com/users/daolq3012/gists{/gist_id}","starred_url":"https://api.github.com/users/daolq3012/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daolq3012/subscriptions","organizations_url":"https://api.github.com/users/daolq3012/orgs","repos_url":"https://api.github.com/users/daolq3012/repos","events_url":"https://api.github.com/users/daolq3012/events{/privacy}","received_events_url":"https://api.github.com/users/daolq3012/received_events","type":"User","site_admin":false},"body":"WARNING: [CollapsibleIfStatements] These nested if statements could be combined\nhttps://pmd.github.io/pmd-5.5.1/pmd-java/rules/java/basic.html#CollapsibleIfStatements","created_at":"2017-07-10T06:40:30Z","updated_at":"2017-07-10T06:40:30Z","html_url":"https://github.com/NguyenTienVinh/wsm_android/pull/51#discussion_r126343841","pull_request_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/51","_links":{"self":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/comments/126343841"},"html":{"href":"https://github.com/NguyenTienVinh/wsm_android/pull/51#discussion_r126343841"},"pull_request":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/51","id":129595360,"html_url":"https://github.com/NguyenTienVinh/wsm_android/pull/51","diff_url":"https://github.com/NguyenTienVinh/wsm_android/pull/51.diff","patch_url":"https://github.com/NguyenTienVinh/wsm_android/pull/51.patch","issue_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues/51","number":51,"state":"open","locked":false,"title":"fix request off detail","user":{"login":"NguyenTienVinh","id":24980167,"avatar_url":"https://avatars1.githubusercontent.com/u/24980167?v=3","gravatar_id":"","url":"https://api.github.com/users/NguyenTienVinh","html_url":"https://github.com/NguyenTienVinh","followers_url":"https://api.github.com/users/NguyenTienVinh/followers","following_url":"https://api.github.com/users/NguyenTienVinh/following{/other_user}","gists_url":"https://api.github.com/users/NguyenTienVinh/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenTienVinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenTienVinh/subscriptions","organizations_url":"https://api.github.com/users/NguyenTienVinh/orgs","repos_url":"https://api.github.com/users/NguyenTienVinh/repos","events_url":"https://api.github.com/users/NguyenTienVinh/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenTienVinh/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-07-10T03:30:30Z","updated_at":"2017-07-10T06:40:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2ea55aa63a2df5a7b83db7c7c5340f6a77763fa5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/51/commits","review_comments_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/51/comments","review_comment_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues/51/comments","statuses_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/statuses/996bca8cd6914da925d5b97918b844e60f9edea3","head":{"label":"NguyenTienVinh:feature_fix_request_off_detail","ref":"feature_fix_request_off_detail","sha":"996bca8cd6914da925d5b97918b844e60f9edea3","user":{"login":"NguyenTienVinh","id":24980167,"avatar_url":"https://avatars1.githubusercontent.com/u/24980167?v=3","gravatar_id":"","url":"https://api.github.com/users/NguyenTienVinh","html_url":"https://github.com/NguyenTienVinh","followers_url":"https://api.github.com/users/NguyenTienVinh/followers","following_url":"https://api.github.com/users/NguyenTienVinh/following{/other_user}","gists_url":"https://api.github.com/users/NguyenTienVinh/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenTienVinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenTienVinh/subscriptions","organizations_url":"https://api.github.com/users/NguyenTienVinh/orgs","repos_url":"https://api.github.com/users/NguyenTienVinh/repos","events_url":"https://api.github.com/users/NguyenTienVinh/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenTienVinh/received_events","type":"User","site_admin":false},"repo":{"id":91634333,"name":"wsm_android","full_name":"NguyenTienVinh/wsm_android","owner":{"login":"NguyenTienVinh","id":24980167,"avatar_url":"https://avatars1.githubusercontent.com/u/24980167?v=3","gravatar_id":"","url":"https://api.github.com/users/NguyenTienVinh","html_url":"https://github.com/NguyenTienVinh","followers_url":"https://api.github.com/users/NguyenTienVinh/followers","following_url":"https://api.github.com/users/NguyenTienVinh/following{/other_user}","gists_url":"https://api.github.com/users/NguyenTienVinh/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenTienVinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenTienVinh/subscriptions","organizations_url":"https://api.github.com/users/NguyenTienVinh/orgs","repos_url":"https://api.github.com/users/NguyenTienVinh/repos","events_url":"https://api.github.com/users/NguyenTienVinh/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenTienVinh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NguyenTienVinh/wsm_android","description":null,"fork":true,"url":"https://api.github.com/repos/NguyenTienVinh/wsm_android","forks_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/forks","keys_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/teams","hooks_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/hooks","issue_events_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues/events{/number}","events_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/events","assignees_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/assignees{/user}","branches_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/branches{/branch}","tags_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/tags","blobs_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/statuses/{sha}","languages_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/languages","stargazers_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/stargazers","contributors_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/contributors","subscribers_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/subscribers","subscription_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/subscription","commits_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/contents/{+path}","compare_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/merges","archive_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/downloads","issues_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues{/number}","pulls_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls{/number}","milestones_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/milestones{/number}","notifications_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/labels{/name}","releases_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/releases{/id}","deployments_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/deployments","created_at":"2017-05-18T01:10:53Z","updated_at":"2017-05-18T01:10:54Z","pushed_at":"2017-07-10T06:29:33Z","git_url":"git://github.com/NguyenTienVinh/wsm_android.git","ssh_url":"git@github.com:NguyenTienVinh/wsm_android.git","clone_url":"https://github.com/NguyenTienVinh/wsm_android.git","svn_url":"https://github.com/NguyenTienVinh/wsm_android","homepage":null,"size":12396,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"NguyenTienVinh:develop","ref":"develop","sha":"4edb9e91b88f507aeb24114cfe504a273026f678","user":{"login":"NguyenTienVinh","id":24980167,"avatar_url":"https://avatars1.githubusercontent.com/u/24980167?v=3","gravatar_id":"","url":"https://api.github.com/users/NguyenTienVinh","html_url":"https://github.com/NguyenTienVinh","followers_url":"https://api.github.com/users/NguyenTienVinh/followers","following_url":"https://api.github.com/users/NguyenTienVinh/following{/other_user}","gists_url":"https://api.github.com/users/NguyenTienVinh/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenTienVinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenTienVinh/subscriptions","organizations_url":"https://api.github.com/users/NguyenTienVinh/orgs","repos_url":"https://api.github.com/users/NguyenTienVinh/repos","events_url":"https://api.github.com/users/NguyenTienVinh/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenTienVinh/received_events","type":"User","site_admin":false},"repo":{"id":91634333,"name":"wsm_android","full_name":"NguyenTienVinh/wsm_android","owner":{"login":"NguyenTienVinh","id":24980167,"avatar_url":"https://avatars1.githubusercontent.com/u/24980167?v=3","gravatar_id":"","url":"https://api.github.com/users/NguyenTienVinh","html_url":"https://github.com/NguyenTienVinh","followers_url":"https://api.github.com/users/NguyenTienVinh/followers","following_url":"https://api.github.com/users/NguyenTienVinh/following{/other_user}","gists_url":"https://api.github.com/users/NguyenTienVinh/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenTienVinh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenTienVinh/subscriptions","organizations_url":"https://api.github.com/users/NguyenTienVinh/orgs","repos_url":"https://api.github.com/users/NguyenTienVinh/repos","events_url":"https://api.github.com/users/NguyenTienVinh/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenTienVinh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NguyenTienVinh/wsm_android","description":null,"fork":true,"url":"https://api.github.com/repos/NguyenTienVinh/wsm_android","forks_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/forks","keys_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/teams","hooks_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/hooks","issue_events_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues/events{/number}","events_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/events","assignees_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/assignees{/user}","branches_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/branches{/branch}","tags_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/tags","blobs_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/refs{/sha}","trees_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/statuses/{sha}","languages_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/languages","stargazers_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/stargazers","contributors_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/contributors","subscribers_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/subscribers","subscription_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/subscription","commits_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/commits{/sha}","git_commits_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/git/commits{/sha}","comments_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/comments{/number}","issue_comment_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues/comments{/number}","contents_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/contents/{+path}","compare_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/merges","archive_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/downloads","issues_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues{/number}","pulls_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls{/number}","milestones_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/milestones{/number}","notifications_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/labels{/name}","releases_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/releases{/id}","deployments_url":"https://api.github.com/repos/NguyenTienVinh/wsm_android/deployments","created_at":"2017-05-18T01:10:53Z","updated_at":"2017-05-18T01:10:54Z","pushed_at":"2017-07-10T06:29:33Z","git_url":"git://github.com/NguyenTienVinh/wsm_android.git","ssh_url":"git@github.com:NguyenTienVinh/wsm_android.git","clone_url":"https://github.com/NguyenTienVinh/wsm_android.git","svn_url":"https://github.com/NguyenTienVinh/wsm_android","homepage":null,"size":12396,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/51"},"html":{"href":"https://github.com/NguyenTienVinh/wsm_android/pull/51"},"issue":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues/51"},"comments":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/NguyenTienVinh/wsm_android/statuses/996bca8cd6914da925d5b97918b844e60f9edea3"}}}}
{"actor":{"display_login":"daolq3012"}}