{"action":"created","comment":{"url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/comments/115143970","pull_request_review_id":36665270,"id":115143970,"diff_hunk":"@@ -58,8 +58,30 @@ import ocean.transition;\n \n import ocean.stdc.string: strdup, strlen, strncmp;\n import core.sys.posix.unistd: unlink;\n-import core.sys.posix.libgen: basename;\n-import core.sys.posix.sys.time: gettimeofday, timeval, timersub;\n+\n+import core.sys.posix.sys.time: gettimeofday, timeval;\n+\n+static if (__VERSION__ >= 2000 && __VERSION__ < 2073)\n+{\n+    extern(C) char* basename(char*);\n+\n+    extern (D): pure: @safe: @nogc: nothrow:","path":"src/ocean/core/UnitTestRunner.d","position":13,"original_position":13,"commit_id":"2fcdcd93d3317e1f8f811512e3bbe451d3d698c1","original_commit_id":"6561f69ee3f967ebf247d36cab20d5fc75585c05","user":{"login":"daniel-zullo-sociomantic","id":6088143,"avatar_url":"https://avatars0.githubusercontent.com/u/6088143?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-zullo-sociomantic","html_url":"https://github.com/daniel-zullo-sociomantic","followers_url":"https://api.github.com/users/daniel-zullo-sociomantic/followers","following_url":"https://api.github.com/users/daniel-zullo-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/daniel-zullo-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-zullo-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-zullo-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/daniel-zullo-sociomantic/orgs","repos_url":"https://api.github.com/users/daniel-zullo-sociomantic/repos","events_url":"https://api.github.com/users/daniel-zullo-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-zullo-sociomantic/received_events","type":"User","site_admin":false},"body":"You are right, it'll be applied to the whole module in the current state. I'll write it within a scope. And we actually won't need to define the D2 attributes here.\r\n\r\nindeed `extern(D)` can be removed. ","created_at":"2017-05-07T14:01:00Z","updated_at":"2017-05-07T14:01:01Z","html_url":"https://github.com/sociomantic-tsunami/ocean/pull/105#discussion_r115143970","pull_request_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/105","_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/comments/115143970"},"html":{"href":"https://github.com/sociomantic-tsunami/ocean/pull/105#discussion_r115143970"},"pull_request":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/105"}}},"pull_request":{"url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/105","id":119338170,"html_url":"https://github.com/sociomantic-tsunami/ocean/pull/105","diff_url":"https://github.com/sociomantic-tsunami/ocean/pull/105.diff","patch_url":"https://github.com/sociomantic-tsunami/ocean/pull/105.patch","issue_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/105","number":105,"state":"open","locked":false,"title":"Compile with dmd v2.070.2","user":{"login":"daniel-zullo-sociomantic","id":6088143,"avatar_url":"https://avatars0.githubusercontent.com/u/6088143?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-zullo-sociomantic","html_url":"https://github.com/daniel-zullo-sociomantic","followers_url":"https://api.github.com/users/daniel-zullo-sociomantic/followers","following_url":"https://api.github.com/users/daniel-zullo-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/daniel-zullo-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-zullo-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-zullo-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/daniel-zullo-sociomantic/orgs","repos_url":"https://api.github.com/users/daniel-zullo-sociomantic/repos","events_url":"https://api.github.com/users/daniel-zullo-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-zullo-sociomantic/received_events","type":"User","site_admin":false},"body":"Defines the extenal functions and macros definitionto be able to compile with dmd v2.070.2","created_at":"2017-05-07T13:11:06Z","updated_at":"2017-05-07T14:01:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83f7ff4c62296da43ff70677b45b1ba3b29f1c93","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/105/commits","review_comments_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/105/comments","review_comment_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/105/comments","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/statuses/2fcdcd93d3317e1f8f811512e3bbe451d3d698c1","head":{"label":"daniel-zullo-sociomantic:dmd-v2.070.2","ref":"dmd-v2.070.2","sha":"2fcdcd93d3317e1f8f811512e3bbe451d3d698c1","user":{"login":"daniel-zullo-sociomantic","id":6088143,"avatar_url":"https://avatars0.githubusercontent.com/u/6088143?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-zullo-sociomantic","html_url":"https://github.com/daniel-zullo-sociomantic","followers_url":"https://api.github.com/users/daniel-zullo-sociomantic/followers","following_url":"https://api.github.com/users/daniel-zullo-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/daniel-zullo-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-zullo-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-zullo-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/daniel-zullo-sociomantic/orgs","repos_url":"https://api.github.com/users/daniel-zullo-sociomantic/repos","events_url":"https://api.github.com/users/daniel-zullo-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-zullo-sociomantic/received_events","type":"User","site_admin":false},"repo":{"id":85215425,"name":"ocean-1","full_name":"daniel-zullo-sociomantic/ocean-1","owner":{"login":"daniel-zullo-sociomantic","id":6088143,"avatar_url":"https://avatars0.githubusercontent.com/u/6088143?v=3","gravatar_id":"","url":"https://api.github.com/users/daniel-zullo-sociomantic","html_url":"https://github.com/daniel-zullo-sociomantic","followers_url":"https://api.github.com/users/daniel-zullo-sociomantic/followers","following_url":"https://api.github.com/users/daniel-zullo-sociomantic/following{/other_user}","gists_url":"https://api.github.com/users/daniel-zullo-sociomantic/gists{/gist_id}","starred_url":"https://api.github.com/users/daniel-zullo-sociomantic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daniel-zullo-sociomantic/subscriptions","organizations_url":"https://api.github.com/users/daniel-zullo-sociomantic/orgs","repos_url":"https://api.github.com/users/daniel-zullo-sociomantic/repos","events_url":"https://api.github.com/users/daniel-zullo-sociomantic/events{/privacy}","received_events_url":"https://api.github.com/users/daniel-zullo-sociomantic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/daniel-zullo-sociomantic/ocean-1","description":"General purpose, platform-dependant, high-performance library for D","fork":true,"url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1","forks_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/forks","keys_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/teams","hooks_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/hooks","issue_events_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/issues/events{/number}","events_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/events","assignees_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/assignees{/user}","branches_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/branches{/branch}","tags_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/tags","blobs_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/statuses/{sha}","languages_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/languages","stargazers_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/stargazers","contributors_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/contributors","subscribers_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/subscribers","subscription_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/subscription","commits_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/contents/{+path}","compare_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/merges","archive_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/downloads","issues_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/issues{/number}","pulls_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/pulls{/number}","milestones_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/milestones{/number}","notifications_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/labels{/name}","releases_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/releases{/id}","deployments_url":"https://api.github.com/repos/daniel-zullo-sociomantic/ocean-1/deployments","created_at":"2017-03-16T16:04:46Z","updated_at":"2017-03-16T16:04:50Z","pushed_at":"2017-05-07T13:20:16Z","git_url":"git://github.com/daniel-zullo-sociomantic/ocean-1.git","ssh_url":"git@github.com:daniel-zullo-sociomantic/ocean-1.git","clone_url":"https://github.com/daniel-zullo-sociomantic/ocean-1.git","svn_url":"https://github.com/daniel-zullo-sociomantic/ocean-1","homepage":null,"size":2620,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"v2.x.x"}},"base":{"label":"sociomantic-tsunami:v2.x.x","ref":"v2.x.x","sha":"cbb07a095d41e6971c6b007a284dcc6fa48cb98a","user":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars3.githubusercontent.com/u/16766217?v=3","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"repo":{"id":62304010,"name":"ocean","full_name":"sociomantic-tsunami/ocean","owner":{"login":"sociomantic-tsunami","id":16766217,"avatar_url":"https://avatars3.githubusercontent.com/u/16766217?v=3","gravatar_id":"","url":"https://api.github.com/users/sociomantic-tsunami","html_url":"https://github.com/sociomantic-tsunami","followers_url":"https://api.github.com/users/sociomantic-tsunami/followers","following_url":"https://api.github.com/users/sociomantic-tsunami/following{/other_user}","gists_url":"https://api.github.com/users/sociomantic-tsunami/gists{/gist_id}","starred_url":"https://api.github.com/users/sociomantic-tsunami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sociomantic-tsunami/subscriptions","organizations_url":"https://api.github.com/users/sociomantic-tsunami/orgs","repos_url":"https://api.github.com/users/sociomantic-tsunami/repos","events_url":"https://api.github.com/users/sociomantic-tsunami/events{/privacy}","received_events_url":"https://api.github.com/users/sociomantic-tsunami/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sociomantic-tsunami/ocean","description":"General purpose, platform-dependant, high-performance library for D","fork":false,"url":"https://api.github.com/repos/sociomantic-tsunami/ocean","forks_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/forks","keys_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/teams","hooks_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/hooks","issue_events_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/events{/number}","events_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/events","assignees_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/assignees{/user}","branches_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/branches{/branch}","tags_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/tags","blobs_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/refs{/sha}","trees_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/statuses/{sha}","languages_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/languages","stargazers_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/stargazers","contributors_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/contributors","subscribers_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/subscribers","subscription_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/subscription","commits_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/commits{/sha}","git_commits_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/git/commits{/sha}","comments_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/comments{/number}","issue_comment_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/comments{/number}","contents_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/contents/{+path}","compare_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/merges","archive_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/downloads","issues_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues{/number}","pulls_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls{/number}","milestones_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/milestones{/number}","notifications_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/labels{/name}","releases_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/releases{/id}","deployments_url":"https://api.github.com/repos/sociomantic-tsunami/ocean/deployments","created_at":"2016-06-30T11:01:55Z","updated_at":"2017-05-04T18:49:33Z","pushed_at":"2017-05-07T13:20:18Z","git_url":"git://github.com/sociomantic-tsunami/ocean.git","ssh_url":"git@github.com:sociomantic-tsunami/ocean.git","clone_url":"https://github.com/sociomantic-tsunami/ocean.git","svn_url":"https://github.com/sociomantic-tsunami/ocean","homepage":null,"size":2733,"stargazers_count":31,"watchers_count":31,"language":"D","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":28,"forks":23,"open_issues":28,"watchers":31,"default_branch":"v2.x.x"}},"_links":{"self":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/105"},"html":{"href":"https://github.com/sociomantic-tsunami/ocean/pull/105"},"issue":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/105"},"comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/issues/105/comments"},"review_comments":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/105/comments"},"review_comment":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/pulls/105/commits"},"statuses":{"href":"https://api.github.com/repos/sociomantic-tsunami/ocean/statuses/2fcdcd93d3317e1f8f811512e3bbe451d3d698c1"}}}}
{"actor":{"display_login":"daniel-zullo-sociomantic"}}