{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/stetho/issues/544","repository_url":"https://api.github.com/repos/facebook/stetho","labels_url":"https://api.github.com/repos/facebook/stetho/issues/544/labels{/name}","comments_url":"https://api.github.com/repos/facebook/stetho/issues/544/comments","events_url":"https://api.github.com/repos/facebook/stetho/issues/544/events","html_url":"https://github.com/facebook/stetho/pull/544","id":240671275,"number":544,"title":"Null check Interceptor.Chain.connection().","user":{"login":"naturalwarren","id":1113225,"avatar_url":"https://avatars0.githubusercontent.com/u/1113225?v=3","gravatar_id":"","url":"https://api.github.com/users/naturalwarren","html_url":"https://github.com/naturalwarren","followers_url":"https://api.github.com/users/naturalwarren/followers","following_url":"https://api.github.com/users/naturalwarren/following{/other_user}","gists_url":"https://api.github.com/users/naturalwarren/gists{/gist_id}","starred_url":"https://api.github.com/users/naturalwarren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naturalwarren/subscriptions","organizations_url":"https://api.github.com/users/naturalwarren/orgs","repos_url":"https://api.github.com/users/naturalwarren/repos","events_url":"https://api.github.com/users/naturalwarren/events{/privacy}","received_events_url":"https://api.github.com/users/naturalwarren/received_events","type":"User","site_admin":false},"labels":[{"id":196859534,"url":"https://api.github.com/repos/facebook/stetho/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-05T14:33:29Z","updated_at":"2017-07-05T14:40:44Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/stetho/pulls/544","html_url":"https://github.com/facebook/stetho/pull/544","diff_url":"https://github.com/facebook/stetho/pull/544.diff","patch_url":"https://github.com/facebook/stetho/pull/544.patch"},"body":"`Interceptor.Chain.connection()` was [marked nullable](https://github.com/square/okhttp/blob/master/okhttp/src/main/java/okhttp3/Interceptor.java#L38) in OkHttp 3.8.0. \r\n\r\nIn `StethoInterceptor` we retrieve a connection and don't check for `null`. This causes Stetho to crash when calling [`OkHttpInspectorResponse.connectionId()`](https://github.com/facebook/stetho/blob/master/stetho-okhttp3/src/main/java/com/facebook/stetho/okhttp3/StethoInterceptor.java#L226) when a connection is not present. \r\n\r\nAddresses #541 "},"comment":{"url":"https://api.github.com/repos/facebook/stetho/issues/comments/313123549","html_url":"https://github.com/facebook/stetho/pull/544#issuecomment-313123549","issue_url":"https://api.github.com/repos/facebook/stetho/issues/544","id":313123549,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars0.githubusercontent.com/u/6422482?v=3","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2017-07-05T14:40:44Z","updated_at":"2017-07-05T14:40:44Z","body":"Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!"}}
{"actor":{"display_login":"facebook-github-bot"}}