{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/119691320","pull_request_review_id":41595327,"id":119691320,"diff_hunk":"@@ -136,7 +164,11 @@ public override void ExecuteCmdlet()\n             newEnvironment.Endpoints[AzureEnvironment.Endpoint.AzureDataLakeStoreFileSystemEndpointSuffix] = AzureDataLakeStoreFileSystemEndpointSuffix;\n             newEnvironment.Endpoints[AzureEnvironment.Endpoint.AdTenant] = AdTenant;\n             newEnvironment.Endpoints[AzureEnvironment.Endpoint.GraphEndpointResourceId] = GraphAudience;\n-            WriteObject((PSAzureEnvironment)profileClient.AddOrSetEnvironment(newEnvironment));\n+\n+            if (ShouldProcess(Name, \"Adding new environment\"))","path":"src/ResourceManager/Profile/Commands.Profile/Environment/AddAzureRMEnvironment.cs","position":163,"original_position":163,"commit_id":"231831675063bab15c9808fa30985d1b942fdd34","original_commit_id":"231831675063bab15c9808fa30985d1b942fdd34","user":{"login":"viananth","id":21109279,"avatar_url":"https://avatars1.githubusercontent.com/u/21109279?v=3","gravatar_id":"","url":"https://api.github.com/users/viananth","html_url":"https://github.com/viananth","followers_url":"https://api.github.com/users/viananth/followers","following_url":"https://api.github.com/users/viananth/following{/other_user}","gists_url":"https://api.github.com/users/viananth/gists{/gist_id}","starred_url":"https://api.github.com/users/viananth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viananth/subscriptions","organizations_url":"https://api.github.com/users/viananth/orgs","repos_url":"https://api.github.com/users/viananth/repos","events_url":"https://api.github.com/users/viananth/events{/privacy}","received_events_url":"https://api.github.com/users/viananth/received_events","type":"User","site_admin":false},"body":"This is a requirement from the design discussion we had with Mark.","created_at":"2017-06-01T18:19:31Z","updated_at":"2017-06-01T18:19:31Z","html_url":"https://github.com/Azure/azure-powershell/pull/4058#discussion_r119691320","pull_request_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/4058","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments/119691320"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/4058#discussion_r119691320"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/4058"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-powershell/pulls/4058","id":123389632,"html_url":"https://github.com/Azure/azure-powershell/pull/4058","diff_url":"https://github.com/Azure/azure-powershell/pull/4058.diff","patch_url":"https://github.com/Azure/azure-powershell/pull/4058.patch","issue_url":"https://api.github.com/repos/Azure/azure-powershell/issues/4058","number":4058,"state":"open","locked":false,"title":"Add Azure Stack Environment using ARM Endpoint","user":{"login":"viananth","id":21109279,"avatar_url":"https://avatars1.githubusercontent.com/u/21109279?v=3","gravatar_id":"","url":"https://api.github.com/users/viananth","html_url":"https://github.com/viananth","followers_url":"https://api.github.com/users/viananth/followers","following_url":"https://api.github.com/users/viananth/following{/other_user}","gists_url":"https://api.github.com/users/viananth/gists{/gist_id}","starred_url":"https://api.github.com/users/viananth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viananth/subscriptions","organizations_url":"https://api.github.com/users/viananth/orgs","repos_url":"https://api.github.com/users/viananth/repos","events_url":"https://api.github.com/users/viananth/events{/privacy}","received_events_url":"https://api.github.com/users/viananth/received_events","type":"User","site_admin":false},"body":"<!-- DO NOT DELETE THIS TEMPLATE -->\r\n\r\n## Description\r\n<!--\r\nPlease add an informative description that covers the changes made by the pull request.\r\n\r\nIf applicable, reference the bug/issue that this pull request fixes here.\r\n-->\r\nEnables users to add azurermenvironment using ResourceManager url\r\nCloses  #3836\r\n---\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed. You can find a more complete discussion of PowerShell cmdlet best practices [here](https://msdn.microsoft.com/en-us/library/dd878270(v=vs.85).aspx).\r\n\r\n- [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md).**\r\n- [x] **If changes were made to any cmdlet, the XML help was regenerated using the [platyPSHelp module](https://github.com/Azure/azure-powershell/blob/dev/documentation/platyPSHelp-documentation.md).**\r\n- [x] **If any large changes are made to a service, they are reflected in the respective [change log](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#updating-the-change-log).**\r\n\r\n### [General Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#general-guidelines)\r\n- [ ] Title of the pull request is clear and informative.\r\n- [ ] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/dev/documentation/cleaning-up-commits.md).\r\n- [ ] The pull request does not introduce [breaking changes](https://github.com/Azure/azure-powershell/blob/dev/documentation/breaking-changes.md) (unless a major version change occurs in the assembly and module).\r\n\r\n### [Testing Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#testing-guidelines)\r\n- [ ] Pull request includes test coverage for the included changes.\r\n- [ ] PowerShell scripts used in tests should do any necessary setup as part of the test or suite setup, and should not use hard-coded values for locations or existing resources.\r\n\r\n### [Cmdlet Signature Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#cmdlet-signature-guidelines)\r\n- [ ] New cmdlets that make changes or have side effects should implement `ShouldProcess` and have `SupportShouldProcess=true` specified in the cmdlet attribute. You can find more information on `ShouldProcess` [here](https://gist.github.com/markcowl/338e16fe5c8bbf195aff9f8af0db585d#what-is-the-change).\r\n- [ ] Cmdlet specifies `OutputType` attribute if any output is produced - if the cmdlet produces no output, it should implement a `PassThru` parameter.\r\n\r\n### [Cmdlet Parameter Guidelines](https://github.com/Azure/azure-powershell/blob/dev/CONTRIBUTING.md#cmdlet-parameter-guidelines)\r\n- [ ] Parameter types should not expose types from the management library - complex parameter types should be defined in the module.\r\n- [ ] Complex parameter types are discouraged - a parameter type should be simple types as often as possible. If complex types are used, they should be shallow and easily creatable from a constructor or another cmdlet.\r\n- [ ] Cmdlet parameter sets should be mutually exclusive - each parameter set must have at least one mandatory parameter not in other parameter sets.\r\n","created_at":"2017-05-31T23:17:06Z","updated_at":"2017-06-01T18:19:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43ea334f1ea0a4cef7b77334f212c3a0e69d97c4","assignee":{"login":"viananth","id":21109279,"avatar_url":"https://avatars1.githubusercontent.com/u/21109279?v=3","gravatar_id":"","url":"https://api.github.com/users/viananth","html_url":"https://github.com/viananth","followers_url":"https://api.github.com/users/viananth/followers","following_url":"https://api.github.com/users/viananth/following{/other_user}","gists_url":"https://api.github.com/users/viananth/gists{/gist_id}","starred_url":"https://api.github.com/users/viananth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viananth/subscriptions","organizations_url":"https://api.github.com/users/viananth/orgs","repos_url":"https://api.github.com/users/viananth/repos","events_url":"https://api.github.com/users/viananth/events{/privacy}","received_events_url":"https://api.github.com/users/viananth/received_events","type":"User","site_admin":false},"assignees":[{"login":"viananth","id":21109279,"avatar_url":"https://avatars1.githubusercontent.com/u/21109279?v=3","gravatar_id":"","url":"https://api.github.com/users/viananth","html_url":"https://github.com/viananth","followers_url":"https://api.github.com/users/viananth/followers","following_url":"https://api.github.com/users/viananth/following{/other_user}","gists_url":"https://api.github.com/users/viananth/gists{/gist_id}","starred_url":"https://api.github.com/users/viananth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viananth/subscriptions","organizations_url":"https://api.github.com/users/viananth/orgs","repos_url":"https://api.github.com/users/viananth/repos","events_url":"https://api.github.com/users/viananth/events{/privacy}","received_events_url":"https://api.github.com/users/viananth/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"markcowl","id":1054056,"avatar_url":"https://avatars2.githubusercontent.com/u/1054056?v=3","gravatar_id":"","url":"https://api.github.com/users/markcowl","html_url":"https://github.com/markcowl","followers_url":"https://api.github.com/users/markcowl/followers","following_url":"https://api.github.com/users/markcowl/following{/other_user}","gists_url":"https://api.github.com/users/markcowl/gists{/gist_id}","starred_url":"https://api.github.com/users/markcowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markcowl/subscriptions","organizations_url":"https://api.github.com/users/markcowl/orgs","repos_url":"https://api.github.com/users/markcowl/repos","events_url":"https://api.github.com/users/markcowl/events{/privacy}","received_events_url":"https://api.github.com/users/markcowl/received_events","type":"User","site_admin":false},{"login":"vikasnav","id":17556369,"avatar_url":"https://avatars2.githubusercontent.com/u/17556369?v=3","gravatar_id":"","url":"https://api.github.com/users/vikasnav","html_url":"https://github.com/vikasnav","followers_url":"https://api.github.com/users/vikasnav/followers","following_url":"https://api.github.com/users/vikasnav/following{/other_user}","gists_url":"https://api.github.com/users/vikasnav/gists{/gist_id}","starred_url":"https://api.github.com/users/vikasnav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikasnav/subscriptions","organizations_url":"https://api.github.com/users/vikasnav/orgs","repos_url":"https://api.github.com/users/vikasnav/repos","events_url":"https://api.github.com/users/vikasnav/events{/privacy}","received_events_url":"https://api.github.com/users/vikasnav/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/4058/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/4058/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/issues/4058/comments","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/231831675063bab15c9808fa30985d1b942fdd34","head":{"label":"viananth:addstackenv","ref":"addstackenv","sha":"231831675063bab15c9808fa30985d1b942fdd34","user":{"login":"viananth","id":21109279,"avatar_url":"https://avatars1.githubusercontent.com/u/21109279?v=3","gravatar_id":"","url":"https://api.github.com/users/viananth","html_url":"https://github.com/viananth","followers_url":"https://api.github.com/users/viananth/followers","following_url":"https://api.github.com/users/viananth/following{/other_user}","gists_url":"https://api.github.com/users/viananth/gists{/gist_id}","starred_url":"https://api.github.com/users/viananth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viananth/subscriptions","organizations_url":"https://api.github.com/users/viananth/orgs","repos_url":"https://api.github.com/users/viananth/repos","events_url":"https://api.github.com/users/viananth/events{/privacy}","received_events_url":"https://api.github.com/users/viananth/received_events","type":"User","site_admin":false},"repo":{"id":80671778,"name":"azure-powershell","full_name":"viananth/azure-powershell","owner":{"login":"viananth","id":21109279,"avatar_url":"https://avatars1.githubusercontent.com/u/21109279?v=3","gravatar_id":"","url":"https://api.github.com/users/viananth","html_url":"https://github.com/viananth","followers_url":"https://api.github.com/users/viananth/followers","following_url":"https://api.github.com/users/viananth/following{/other_user}","gists_url":"https://api.github.com/users/viananth/gists{/gist_id}","starred_url":"https://api.github.com/users/viananth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viananth/subscriptions","organizations_url":"https://api.github.com/users/viananth/orgs","repos_url":"https://api.github.com/users/viananth/repos","events_url":"https://api.github.com/users/viananth/events{/privacy}","received_events_url":"https://api.github.com/users/viananth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/viananth/azure-powershell","description":"Microsoft Azure PowerShell","fork":true,"url":"https://api.github.com/repos/viananth/azure-powershell","forks_url":"https://api.github.com/repos/viananth/azure-powershell/forks","keys_url":"https://api.github.com/repos/viananth/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viananth/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viananth/azure-powershell/teams","hooks_url":"https://api.github.com/repos/viananth/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/viananth/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/viananth/azure-powershell/events","assignees_url":"https://api.github.com/repos/viananth/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/viananth/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/viananth/azure-powershell/tags","blobs_url":"https://api.github.com/repos/viananth/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viananth/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viananth/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/viananth/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viananth/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/viananth/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/viananth/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/viananth/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/viananth/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/viananth/azure-powershell/subscription","commits_url":"https://api.github.com/repos/viananth/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/viananth/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/viananth/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/viananth/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/viananth/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/viananth/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viananth/azure-powershell/merges","archive_url":"https://api.github.com/repos/viananth/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viananth/azure-powershell/downloads","issues_url":"https://api.github.com/repos/viananth/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/viananth/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/viananth/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/viananth/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viananth/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/viananth/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/viananth/azure-powershell/deployments","created_at":"2017-02-01T22:37:54Z","updated_at":"2017-02-01T22:38:29Z","pushed_at":"2017-05-31T23:13:36Z","git_url":"git://github.com/viananth/azure-powershell.git","ssh_url":"git@github.com:viananth/azure-powershell.git","clone_url":"https://github.com/viananth/azure-powershell.git","svn_url":"https://github.com/viananth/azure-powershell","homepage":null,"size":246660,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"Azure:stack-dev","ref":"stack-dev","sha":"a3138278ed8618b3929c47a5cc856231596f82cf","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":23891194,"name":"azure-powershell","full_name":"Azure/azure-powershell","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars3.githubusercontent.com/u/6844498?v=3","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-powershell","description":"Microsoft Azure PowerShell","fork":false,"url":"https://api.github.com/repos/Azure/azure-powershell","forks_url":"https://api.github.com/repos/Azure/azure-powershell/forks","keys_url":"https://api.github.com/repos/Azure/azure-powershell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-powershell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-powershell/teams","hooks_url":"https://api.github.com/repos/Azure/azure-powershell/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-powershell/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-powershell/events","assignees_url":"https://api.github.com/repos/Azure/azure-powershell/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-powershell/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-powershell/tags","blobs_url":"https://api.github.com/repos/Azure/azure-powershell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-powershell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-powershell/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-powershell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-powershell/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-powershell/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-powershell/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-powershell/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-powershell/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-powershell/subscription","commits_url":"https://api.github.com/repos/Azure/azure-powershell/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-powershell/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-powershell/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-powershell/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-powershell/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-powershell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-powershell/merges","archive_url":"https://api.github.com/repos/Azure/azure-powershell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-powershell/downloads","issues_url":"https://api.github.com/repos/Azure/azure-powershell/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-powershell/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-powershell/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-powershell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-powershell/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-powershell/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-powershell/deployments","created_at":"2014-09-10T20:35:18Z","updated_at":"2017-06-01T05:22:41Z","pushed_at":"2017-06-01T17:21:16Z","git_url":"git://github.com/Azure/azure-powershell.git","ssh_url":"git@github.com:Azure/azure-powershell.git","clone_url":"https://github.com/Azure/azure-powershell.git","svn_url":"https://github.com/Azure/azure-powershell","homepage":null,"size":256608,"stargazers_count":731,"watchers_count":731,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":712,"mirror_url":null,"open_issues_count":537,"forks":712,"open_issues":537,"watchers":731,"default_branch":"preview"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/4058"},"html":{"href":"https://github.com/Azure/azure-powershell/pull/4058"},"issue":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/4058"},"comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/issues/4058/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/4058/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-powershell/pulls/4058/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-powershell/statuses/231831675063bab15c9808fa30985d1b942fdd34"}}}}
{"actor":{"display_login":"viananth"}}