{"action":"created","comment":{"url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments/118826826","pull_request_review_id":40658679,"id":118826826,"diff_hunk":"@@ -0,0 +1,65 @@\n+﻿\n+#pragma once\n+\n+#include <string>\n+\n+#include \"geometry/r3_element.hpp\"\n+\n+namespace principia {\n+namespace geometry {\n+namespace internal_rp2_element {\n+\n+// An |RP2Element| is an element of ℝP², the real projective plane.  |Scalar|\n+// must be a 1-dimensional vector space over ℝ, typically represented by\n+// |Quantity| or |double|.\n+template<typename Scalar>\n+class RP2Element {\n+ public:\n+  // Constructs a point from a set of homogeneous coordinates.  The\n+  // coordinates may not all be zero.\n+  explicit RP2Element(Scalar const& x, Scalar const& y, double z);\n+\n+  // Returns true if and only if the point is at infinity.\n+  bool is_at_infinity() const;\n+\n+  // Returns the Euclidean (inhomogeneous) coordinates of the point.  May be\n+  // infinities.","path":"geometry/rp2_element.hpp","position":26,"original_position":26,"commit_id":"34682cf4afbbb15817fc790b53008208a046e86e","original_commit_id":"34682cf4afbbb15817fc790b53008208a046e86e","user":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars3.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"body":"Done.","created_at":"2017-05-27T18:52:25Z","updated_at":"2017-05-27T18:52:25Z","html_url":"https://github.com/mockingbirdnest/Principia/pull/1405#discussion_r118826826","pull_request_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/1405","_links":{"self":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments/118826826"},"html":{"href":"https://github.com/mockingbirdnest/Principia/pull/1405#discussion_r118826826"},"pull_request":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/1405"}}},"pull_request":{"url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/1405","id":122765538,"html_url":"https://github.com/mockingbirdnest/Principia/pull/1405","diff_url":"https://github.com/mockingbirdnest/Principia/pull/1405.diff","patch_url":"https://github.com/mockingbirdnest/Principia/pull/1405.patch","issue_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/1405","number":1405,"state":"open","locked":false,"title":"Support for the real projective plane","user":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars3.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-27T15:59:16Z","updated_at":"2017-05-27T18:52:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b19ec6375f34ce87e5cfbfb0a3c71ba81764aac3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/1405/commits","review_comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/1405/comments","review_comment_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/1405/comments","statuses_url":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/34682cf4afbbb15817fc790b53008208a046e86e","head":{"label":"pleroy:Projective","ref":"Projective","sha":"34682cf4afbbb15817fc790b53008208a046e86e","user":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars3.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"repo":{"id":19217274,"name":"Principia","full_name":"pleroy/Principia","owner":{"login":"pleroy","id":7423020,"avatar_url":"https://avatars3.githubusercontent.com/u/7423020?v=3","gravatar_id":"","url":"https://api.github.com/users/pleroy","html_url":"https://github.com/pleroy","followers_url":"https://api.github.com/users/pleroy/followers","following_url":"https://api.github.com/users/pleroy/following{/other_user}","gists_url":"https://api.github.com/users/pleroy/gists{/gist_id}","starred_url":"https://api.github.com/users/pleroy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pleroy/subscriptions","organizations_url":"https://api.github.com/users/pleroy/orgs","repos_url":"https://api.github.com/users/pleroy/repos","events_url":"https://api.github.com/users/pleroy/events{/privacy}","received_events_url":"https://api.github.com/users/pleroy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pleroy/Principia","description":"N-Body Gravitation and Better Integrators for Kerbal Space Program","fork":true,"url":"https://api.github.com/repos/pleroy/Principia","forks_url":"https://api.github.com/repos/pleroy/Principia/forks","keys_url":"https://api.github.com/repos/pleroy/Principia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pleroy/Principia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pleroy/Principia/teams","hooks_url":"https://api.github.com/repos/pleroy/Principia/hooks","issue_events_url":"https://api.github.com/repos/pleroy/Principia/issues/events{/number}","events_url":"https://api.github.com/repos/pleroy/Principia/events","assignees_url":"https://api.github.com/repos/pleroy/Principia/assignees{/user}","branches_url":"https://api.github.com/repos/pleroy/Principia/branches{/branch}","tags_url":"https://api.github.com/repos/pleroy/Principia/tags","blobs_url":"https://api.github.com/repos/pleroy/Principia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pleroy/Principia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pleroy/Principia/git/refs{/sha}","trees_url":"https://api.github.com/repos/pleroy/Principia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pleroy/Principia/statuses/{sha}","languages_url":"https://api.github.com/repos/pleroy/Principia/languages","stargazers_url":"https://api.github.com/repos/pleroy/Principia/stargazers","contributors_url":"https://api.github.com/repos/pleroy/Principia/contributors","subscribers_url":"https://api.github.com/repos/pleroy/Principia/subscribers","subscription_url":"https://api.github.com/repos/pleroy/Principia/subscription","commits_url":"https://api.github.com/repos/pleroy/Principia/commits{/sha}","git_commits_url":"https://api.github.com/repos/pleroy/Principia/git/commits{/sha}","comments_url":"https://api.github.com/repos/pleroy/Principia/comments{/number}","issue_comment_url":"https://api.github.com/repos/pleroy/Principia/issues/comments{/number}","contents_url":"https://api.github.com/repos/pleroy/Principia/contents/{+path}","compare_url":"https://api.github.com/repos/pleroy/Principia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pleroy/Principia/merges","archive_url":"https://api.github.com/repos/pleroy/Principia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pleroy/Principia/downloads","issues_url":"https://api.github.com/repos/pleroy/Principia/issues{/number}","pulls_url":"https://api.github.com/repos/pleroy/Principia/pulls{/number}","milestones_url":"https://api.github.com/repos/pleroy/Principia/milestones{/number}","notifications_url":"https://api.github.com/repos/pleroy/Principia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pleroy/Principia/labels{/name}","releases_url":"https://api.github.com/repos/pleroy/Principia/releases{/id}","deployments_url":"https://api.github.com/repos/pleroy/Principia/deployments","created_at":"2014-04-27T20:57:02Z","updated_at":"2017-02-11T23:23:23Z","pushed_at":"2017-05-27T17:19:25Z","git_url":"git://github.com/pleroy/Principia.git","ssh_url":"git@github.com:pleroy/Principia.git","clone_url":"https://github.com/pleroy/Principia.git","svn_url":"https://github.com/pleroy/Principia","homepage":"http://forum.kerbalspaceprogram.com/threads/68502-WIP-Principia-N-Body-Gravitation-and-Better-Integrators-for-Kerbal-Space-Program","size":29481,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mockingbirdnest:master","ref":"master","sha":"08a36b2f78c82b82ffb1a3713a97480590e5c785","user":{"login":"mockingbirdnest","id":7462691,"avatar_url":"https://avatars0.githubusercontent.com/u/7462691?v=3","gravatar_id":"","url":"https://api.github.com/users/mockingbirdnest","html_url":"https://github.com/mockingbirdnest","followers_url":"https://api.github.com/users/mockingbirdnest/followers","following_url":"https://api.github.com/users/mockingbirdnest/following{/other_user}","gists_url":"https://api.github.com/users/mockingbirdnest/gists{/gist_id}","starred_url":"https://api.github.com/users/mockingbirdnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockingbirdnest/subscriptions","organizations_url":"https://api.github.com/users/mockingbirdnest/orgs","repos_url":"https://api.github.com/users/mockingbirdnest/repos","events_url":"https://api.github.com/users/mockingbirdnest/events{/privacy}","received_events_url":"https://api.github.com/users/mockingbirdnest/received_events","type":"Organization","site_admin":false},"repo":{"id":16634370,"name":"Principia","full_name":"mockingbirdnest/Principia","owner":{"login":"mockingbirdnest","id":7462691,"avatar_url":"https://avatars0.githubusercontent.com/u/7462691?v=3","gravatar_id":"","url":"https://api.github.com/users/mockingbirdnest","html_url":"https://github.com/mockingbirdnest","followers_url":"https://api.github.com/users/mockingbirdnest/followers","following_url":"https://api.github.com/users/mockingbirdnest/following{/other_user}","gists_url":"https://api.github.com/users/mockingbirdnest/gists{/gist_id}","starred_url":"https://api.github.com/users/mockingbirdnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mockingbirdnest/subscriptions","organizations_url":"https://api.github.com/users/mockingbirdnest/orgs","repos_url":"https://api.github.com/users/mockingbirdnest/repos","events_url":"https://api.github.com/users/mockingbirdnest/events{/privacy}","received_events_url":"https://api.github.com/users/mockingbirdnest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mockingbirdnest/Principia","description":"𝑛-Body and Extended Body Gravitation for Kerbal Space Program","fork":false,"url":"https://api.github.com/repos/mockingbirdnest/Principia","forks_url":"https://api.github.com/repos/mockingbirdnest/Principia/forks","keys_url":"https://api.github.com/repos/mockingbirdnest/Principia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mockingbirdnest/Principia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mockingbirdnest/Principia/teams","hooks_url":"https://api.github.com/repos/mockingbirdnest/Principia/hooks","issue_events_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/events{/number}","events_url":"https://api.github.com/repos/mockingbirdnest/Principia/events","assignees_url":"https://api.github.com/repos/mockingbirdnest/Principia/assignees{/user}","branches_url":"https://api.github.com/repos/mockingbirdnest/Principia/branches{/branch}","tags_url":"https://api.github.com/repos/mockingbirdnest/Principia/tags","blobs_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/refs{/sha}","trees_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/{sha}","languages_url":"https://api.github.com/repos/mockingbirdnest/Principia/languages","stargazers_url":"https://api.github.com/repos/mockingbirdnest/Principia/stargazers","contributors_url":"https://api.github.com/repos/mockingbirdnest/Principia/contributors","subscribers_url":"https://api.github.com/repos/mockingbirdnest/Principia/subscribers","subscription_url":"https://api.github.com/repos/mockingbirdnest/Principia/subscription","commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/commits{/sha}","git_commits_url":"https://api.github.com/repos/mockingbirdnest/Principia/git/commits{/sha}","comments_url":"https://api.github.com/repos/mockingbirdnest/Principia/comments{/number}","issue_comment_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues/comments{/number}","contents_url":"https://api.github.com/repos/mockingbirdnest/Principia/contents/{+path}","compare_url":"https://api.github.com/repos/mockingbirdnest/Principia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mockingbirdnest/Principia/merges","archive_url":"https://api.github.com/repos/mockingbirdnest/Principia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mockingbirdnest/Principia/downloads","issues_url":"https://api.github.com/repos/mockingbirdnest/Principia/issues{/number}","pulls_url":"https://api.github.com/repos/mockingbirdnest/Principia/pulls{/number}","milestones_url":"https://api.github.com/repos/mockingbirdnest/Principia/milestones{/number}","notifications_url":"https://api.github.com/repos/mockingbirdnest/Principia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mockingbirdnest/Principia/labels{/name}","releases_url":"https://api.github.com/repos/mockingbirdnest/Principia/releases{/id}","deployments_url":"https://api.github.com/repos/mockingbirdnest/Principia/deployments","created_at":"2014-02-08T02:55:32Z","updated_at":"2017-05-24T11:46:30Z","pushed_at":"2017-05-27T17:44:53Z","git_url":"git://github.com/mockingbirdnest/Principia.git","ssh_url":"git@github.com:mockingbirdnest/Principia.git","clone_url":"https://github.com/mockingbirdnest/Principia.git","svn_url":"https://github.com/mockingbirdnest/Principia","homepage":"","size":29468,"stargazers_count":164,"watchers_count":164,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"open_issues_count":51,"forks":20,"open_issues":51,"watchers":164,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/1405"},"html":{"href":"https://github.com/mockingbirdnest/Principia/pull/1405"},"issue":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/issues/1405"},"comments":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/issues/1405/comments"},"review_comments":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/1405/comments"},"review_comment":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/pulls/1405/commits"},"statuses":{"href":"https://api.github.com/repos/mockingbirdnest/Principia/statuses/34682cf4afbbb15817fc790b53008208a046e86e"}}}}
{"actor":{"display_login":"pleroy"}}