{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/122269644","pull_request_review_id":44371769,"id":122269644,"diff_hunk":"@@ -91,6 +91,7 @@ spec:\n               path: /healthz\n               port: 10254\n               scheme: HTTP\n+          hostNetwork: {{ .Values.controller.hostNetwork }}","path":"stable/nginx-ingress/templates/controller-daemonset.yaml","position":4,"original_position":4,"commit_id":"1549cce43f1526b07ba7b4a5f29fa69094330f24","original_commit_id":"1549cce43f1526b07ba7b4a5f29fa69094330f24","user":{"login":"prydonius","id":1544861,"avatar_url":"https://avatars0.githubusercontent.com/u/1544861?v=3","gravatar_id":"","url":"https://api.github.com/users/prydonius","html_url":"https://github.com/prydonius","followers_url":"https://api.github.com/users/prydonius/followers","following_url":"https://api.github.com/users/prydonius/following{/other_user}","gists_url":"https://api.github.com/users/prydonius/gists{/gist_id}","starred_url":"https://api.github.com/users/prydonius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prydonius/subscriptions","organizations_url":"https://api.github.com/users/prydonius/orgs","repos_url":"https://api.github.com/users/prydonius/repos","events_url":"https://api.github.com/users/prydonius/events{/privacy}","received_events_url":"https://api.github.com/users/prydonius/received_events","type":"User","site_admin":false},"body":"this should be in the PodSpec not the Container","created_at":"2017-06-15T17:56:31Z","updated_at":"2017-06-15T17:56:31Z","html_url":"https://github.com/kubernetes/charts/pull/1250#discussion_r122269644","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/1250","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/122269644"},"html":{"href":"https://github.com/kubernetes/charts/pull/1250#discussion_r122269644"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/1250"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/1250","id":124100916,"html_url":"https://github.com/kubernetes/charts/pull/1250","diff_url":"https://github.com/kubernetes/charts/pull/1250.diff","patch_url":"https://github.com/kubernetes/charts/pull/1250.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/1250","number":1250,"state":"open","locked":false,"title":"[stable/nginx-ingress] Add hostNetwork option","user":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars1.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"body":"Required for use with kubeadm / CNI using bare-metal clusters,\r\nuntil https://github.com/kubernetes/kubernetes/issues/23920 is\r\nfixed","created_at":"2017-06-06T03:05:54Z","updated_at":"2017-06-15T17:56:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6cb5fba18dc7f8e7516eb8f1ece4a4fa82859cdb","assignee":{"login":"mgoodness","id":2781657,"avatar_url":"https://avatars3.githubusercontent.com/u/2781657?v=3","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false},"assignees":[{"login":"mgoodness","id":2781657,"avatar_url":"https://avatars3.githubusercontent.com/u/2781657?v=3","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/1250/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/1250/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/1250/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/1549cce43f1526b07ba7b4a5f29fa69094330f24","head":{"label":"yuvipanda:nginx-ingress-hostport","ref":"nginx-ingress-hostport","sha":"1549cce43f1526b07ba7b4a5f29fa69094330f24","user":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars1.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"repo":{"id":79048070,"name":"charts","full_name":"yuvipanda/charts","owner":{"login":"yuvipanda","id":30430,"avatar_url":"https://avatars1.githubusercontent.com/u/30430?v=3","gravatar_id":"","url":"https://api.github.com/users/yuvipanda","html_url":"https://github.com/yuvipanda","followers_url":"https://api.github.com/users/yuvipanda/followers","following_url":"https://api.github.com/users/yuvipanda/following{/other_user}","gists_url":"https://api.github.com/users/yuvipanda/gists{/gist_id}","starred_url":"https://api.github.com/users/yuvipanda/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuvipanda/subscriptions","organizations_url":"https://api.github.com/users/yuvipanda/orgs","repos_url":"https://api.github.com/users/yuvipanda/repos","events_url":"https://api.github.com/users/yuvipanda/events{/privacy}","received_events_url":"https://api.github.com/users/yuvipanda/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuvipanda/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/yuvipanda/charts","forks_url":"https://api.github.com/repos/yuvipanda/charts/forks","keys_url":"https://api.github.com/repos/yuvipanda/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuvipanda/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuvipanda/charts/teams","hooks_url":"https://api.github.com/repos/yuvipanda/charts/hooks","issue_events_url":"https://api.github.com/repos/yuvipanda/charts/issues/events{/number}","events_url":"https://api.github.com/repos/yuvipanda/charts/events","assignees_url":"https://api.github.com/repos/yuvipanda/charts/assignees{/user}","branches_url":"https://api.github.com/repos/yuvipanda/charts/branches{/branch}","tags_url":"https://api.github.com/repos/yuvipanda/charts/tags","blobs_url":"https://api.github.com/repos/yuvipanda/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuvipanda/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuvipanda/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuvipanda/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuvipanda/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/yuvipanda/charts/languages","stargazers_url":"https://api.github.com/repos/yuvipanda/charts/stargazers","contributors_url":"https://api.github.com/repos/yuvipanda/charts/contributors","subscribers_url":"https://api.github.com/repos/yuvipanda/charts/subscribers","subscription_url":"https://api.github.com/repos/yuvipanda/charts/subscription","commits_url":"https://api.github.com/repos/yuvipanda/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuvipanda/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuvipanda/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuvipanda/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuvipanda/charts/contents/{+path}","compare_url":"https://api.github.com/repos/yuvipanda/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuvipanda/charts/merges","archive_url":"https://api.github.com/repos/yuvipanda/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuvipanda/charts/downloads","issues_url":"https://api.github.com/repos/yuvipanda/charts/issues{/number}","pulls_url":"https://api.github.com/repos/yuvipanda/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/yuvipanda/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/yuvipanda/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuvipanda/charts/labels{/name}","releases_url":"https://api.github.com/repos/yuvipanda/charts/releases{/id}","deployments_url":"https://api.github.com/repos/yuvipanda/charts/deployments","created_at":"2017-01-15T17:36:12Z","updated_at":"2017-01-15T17:36:16Z","pushed_at":"2017-06-15T17:54:52Z","git_url":"git://github.com/yuvipanda/charts.git","ssh_url":"git@github.com:yuvipanda/charts.git","clone_url":"https://github.com/yuvipanda/charts.git","svn_url":"https://github.com/yuvipanda/charts","homepage":"","size":1490,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"ef895a0cb6903189a80f57d07cb7787ea009458e","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2017-06-15T13:09:51Z","pushed_at":"2017-06-15T17:54:52Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":1524,"stargazers_count":703,"watchers_count":703,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":525,"mirror_url":null,"open_issues_count":180,"forks":525,"open_issues":180,"watchers":703,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/1250"},"html":{"href":"https://github.com/kubernetes/charts/pull/1250"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/1250"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/1250/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/1250/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/1250/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/1549cce43f1526b07ba7b4a5f29fa69094330f24"}}}}
{"actor":{"display_login":"prydonius"}}