{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift-protobuf/issues/685","repository_url":"https://api.github.com/repos/apple/swift-protobuf","labels_url":"https://api.github.com/repos/apple/swift-protobuf/issues/685/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift-protobuf/issues/685/comments","events_url":"https://api.github.com/repos/apple/swift-protobuf/issues/685/events","html_url":"https://github.com/apple/swift-protobuf/pull/685","id":268387394,"number":685,"title":"Sources: remove now deprecated 'characters'","user":{"login":"zllak","id":140642,"avatar_url":"https://avatars1.githubusercontent.com/u/140642?v=4","gravatar_id":"","url":"https://api.github.com/users/zllak","html_url":"https://github.com/zllak","followers_url":"https://api.github.com/users/zllak/followers","following_url":"https://api.github.com/users/zllak/following{/other_user}","gists_url":"https://api.github.com/users/zllak/gists{/gist_id}","starred_url":"https://api.github.com/users/zllak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zllak/subscriptions","organizations_url":"https://api.github.com/users/zllak/orgs","repos_url":"https://api.github.com/users/zllak/repos","events_url":"https://api.github.com/users/zllak/events{/privacy}","received_events_url":"https://api.github.com/users/zllak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-25T12:58:00Z","updated_at":"2017-10-28T00:57:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apple/swift-protobuf/pulls/685","html_url":"https://github.com/apple/swift-protobuf/pull/685","diff_url":"https://github.com/apple/swift-protobuf/pull/685.diff","patch_url":"https://github.com/apple/swift-protobuf/pull/685.patch"},"body":"With latest Swift version and Xcode (9.1 beta), using `characters` now generates an error\r\n```\r\nApple Swift version 4.0.1 (swiftlang-900.0.68 clang-900.0.38)\r\nTarget: x86_64-apple-macosx10.9\r\n```"},"comment":{"url":"https://api.github.com/repos/apple/swift-protobuf/issues/comments/340128340","html_url":"https://github.com/apple/swift-protobuf/pull/685#issuecomment-340128340","issue_url":"https://api.github.com/repos/apple/swift-protobuf/issues/685","id":340128340,"user":{"login":"tbkka","id":21696764,"avatar_url":"https://avatars3.githubusercontent.com/u/21696764?v=4","gravatar_id":"","url":"https://api.github.com/users/tbkka","html_url":"https://github.com/tbkka","followers_url":"https://api.github.com/users/tbkka/followers","following_url":"https://api.github.com/users/tbkka/following{/other_user}","gists_url":"https://api.github.com/users/tbkka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbkka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbkka/subscriptions","organizations_url":"https://api.github.com/users/tbkka/orgs","repos_url":"https://api.github.com/users/tbkka/repos","events_url":"https://api.github.com/users/tbkka/events{/privacy}","received_events_url":"https://api.github.com/users/tbkka/received_events","type":"User","site_admin":false},"created_at":"2017-10-28T00:57:50Z","updated_at":"2017-10-28T00:57:50Z","author_association":"CONTRIBUTOR","body":"With these changes, Swift 3.1 is not happy:\r\n```\r\n/home/tkientzle/SwiftProtobuf/BUILDS/swift-protobuf-swift-3.0.1/Sources/SwiftProtobuf/Google_Protobuf_Duration+Extensions.swift:26:15: error: value of type 'String' has no member 'makeIterator'\r\n  var chars = text.makeIterator()\r\n              ^~~~ ~~~~~~~~~~~~\r\n/home/tkientzle/SwiftProtobuf/BUILDS/swift-protobuf-swift-3.1/Sources/SwiftProtobuf/Google_Protobuf_FieldMask+Extensions.swift:46:12: error: type 'String' does not conform to protocol 'Sequence'\r\n  for c in name {\r\n           ^\r\n/home/tkientzle/SwiftProtobuf/BUILDS/swift-protobuf-swift-3.1/Sources/SwiftProtobuf/Google_Protobuf_FieldMask+Extensions.swift:64:23: error: type 'String' does not conform to protocol 'Sequence'\r\n  for c: Character in names {\r\n                      ^\r\n/home/tkientzle/SwiftProtobuf/BUILDS/swift-protobuf-swift-3.1/Sources/SwiftProtobuf/Google_Protobuf_Duration+Extensions.swift:26:15: error: value of type 'String' has no member 'makeIterator'\r\n  var chars = text.makeIterator()\r\n              ^~~~ ~~~~~~~~~~~~\r\n/home/tkientzle/SwiftProtobuf/BUILDS/swift-protobuf-swift-3.1/Sources/SwiftProtobuf/NameMap.swift:27:14: error: type 'String' does not conform to protocol 'Sequence'\r\n    for c in s {\r\n             ^\r\n/home/tkientzle/SwiftProtobuf/BUILDS/swift-protobuf-swift-3.1/Sources/SwiftProtobuf/Google_Protobuf_Any+Registry.swift:24:28: error: value of type 'String' has no member 'last'\r\n  if typePrefix.isEmpty || typePrefix.last != \"/\" {\r\n                           ^~~~~~~~~~ ~~~~\r\n```"}}
{"actor":{"display_login":"tbkka"}}