{"action":"opened","number":3604,"pull_request":{"url":"https://api.github.com/repos/palantir/tslint/pulls/3604","id":159881565,"html_url":"https://github.com/palantir/tslint/pull/3604","diff_url":"https://github.com/palantir/tslint/pull/3604.diff","patch_url":"https://github.com/palantir/tslint/pull/3604.patch","issue_url":"https://api.github.com/repos/palantir/tslint/issues/3604","number":3604,"state":"open","locked":false,"title":"feat(new-rule-option): improve `strict-boolean-expressions` by adding `allow-enum`","user":{"login":"atsu85","id":1206512,"avatar_url":"https://avatars3.githubusercontent.com/u/1206512?v=4","gravatar_id":"","url":"https://api.github.com/users/atsu85","html_url":"https://github.com/atsu85","followers_url":"https://api.github.com/users/atsu85/followers","following_url":"https://api.github.com/users/atsu85/following{/other_user}","gists_url":"https://api.github.com/users/atsu85/gists{/gist_id}","starred_url":"https://api.github.com/users/atsu85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsu85/subscriptions","organizations_url":"https://api.github.com/users/atsu85/orgs","repos_url":"https://api.github.com/users/atsu85/repos","events_url":"https://api.github.com/users/atsu85/events{/privacy}","received_events_url":"https://api.github.com/users/atsu85/received_events","type":"User","site_admin":false},"body":"#### PR checklist\r\n\r\n- [x] Addresses an existing issue: #3571\r\n- [x] New feature(rule option), enhancement for \"strict-boolean-expressions\" rule\r\n  - [x] Includes tests\r\n- [x] Documentation update\r\n\r\n#### Overview of change:\r\nAdded new configuration option \"allow-enum\", that disables errors when using enum in boolean expression, so that error wouldn't be emitted\r\n\r\n#### Is there anything you'd like reviewers to focus on?\r\n\r\nI've added the motivation and detailed description to the issue #3571 - take a look at that as well.\r\n> I had 2 ideas to avoid emitting enum related errors:\r\n\r\nThis PR addresses that issue using approach `b` described in that issue.\r\n\r\n#### CHANGELOG.md entry:\r\n\r\n[new-rule-option] `strict-boolean-expressions` adds `allow-enum` to allow using enums in boolean expressions\r\n","created_at":"2017-12-22T14:53:23Z","updated_at":"2017-12-22T14:53:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/tslint/pulls/3604/commits","review_comments_url":"https://api.github.com/repos/palantir/tslint/pulls/3604/comments","review_comment_url":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/tslint/issues/3604/comments","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/3d818d2e00974c96ae88cacaa318f297190c8738","head":{"label":"atsu85:feature/issue-3571-strict-boolean-expressions_allow-enum","ref":"feature/issue-3571-strict-boolean-expressions_allow-enum","sha":"3d818d2e00974c96ae88cacaa318f297190c8738","user":{"login":"atsu85","id":1206512,"avatar_url":"https://avatars3.githubusercontent.com/u/1206512?v=4","gravatar_id":"","url":"https://api.github.com/users/atsu85","html_url":"https://github.com/atsu85","followers_url":"https://api.github.com/users/atsu85/followers","following_url":"https://api.github.com/users/atsu85/following{/other_user}","gists_url":"https://api.github.com/users/atsu85/gists{/gist_id}","starred_url":"https://api.github.com/users/atsu85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsu85/subscriptions","organizations_url":"https://api.github.com/users/atsu85/orgs","repos_url":"https://api.github.com/users/atsu85/repos","events_url":"https://api.github.com/users/atsu85/events{/privacy}","received_events_url":"https://api.github.com/users/atsu85/received_events","type":"User","site_admin":false},"repo":{"id":115121117,"name":"tslint","full_name":"atsu85/tslint","owner":{"login":"atsu85","id":1206512,"avatar_url":"https://avatars3.githubusercontent.com/u/1206512?v=4","gravatar_id":"","url":"https://api.github.com/users/atsu85","html_url":"https://github.com/atsu85","followers_url":"https://api.github.com/users/atsu85/followers","following_url":"https://api.github.com/users/atsu85/following{/other_user}","gists_url":"https://api.github.com/users/atsu85/gists{/gist_id}","starred_url":"https://api.github.com/users/atsu85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atsu85/subscriptions","organizations_url":"https://api.github.com/users/atsu85/orgs","repos_url":"https://api.github.com/users/atsu85/repos","events_url":"https://api.github.com/users/atsu85/events{/privacy}","received_events_url":"https://api.github.com/users/atsu85/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/atsu85/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":true,"url":"https://api.github.com/repos/atsu85/tslint","forks_url":"https://api.github.com/repos/atsu85/tslint/forks","keys_url":"https://api.github.com/repos/atsu85/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atsu85/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atsu85/tslint/teams","hooks_url":"https://api.github.com/repos/atsu85/tslint/hooks","issue_events_url":"https://api.github.com/repos/atsu85/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/atsu85/tslint/events","assignees_url":"https://api.github.com/repos/atsu85/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/atsu85/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/atsu85/tslint/tags","blobs_url":"https://api.github.com/repos/atsu85/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atsu85/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atsu85/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/atsu85/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atsu85/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/atsu85/tslint/languages","stargazers_url":"https://api.github.com/repos/atsu85/tslint/stargazers","contributors_url":"https://api.github.com/repos/atsu85/tslint/contributors","subscribers_url":"https://api.github.com/repos/atsu85/tslint/subscribers","subscription_url":"https://api.github.com/repos/atsu85/tslint/subscription","commits_url":"https://api.github.com/repos/atsu85/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/atsu85/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/atsu85/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/atsu85/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/atsu85/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/atsu85/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atsu85/tslint/merges","archive_url":"https://api.github.com/repos/atsu85/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atsu85/tslint/downloads","issues_url":"https://api.github.com/repos/atsu85/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/atsu85/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/atsu85/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/atsu85/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atsu85/tslint/labels{/name}","releases_url":"https://api.github.com/repos/atsu85/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/atsu85/tslint/deployments","created_at":"2017-12-22T14:12:46Z","updated_at":"2017-12-22T14:12:50Z","pushed_at":"2017-12-22T14:34:48Z","git_url":"git://github.com/atsu85/tslint.git","ssh_url":"git@github.com:atsu85/tslint.git","clone_url":"https://github.com/atsu85/tslint.git","svn_url":"https://github.com/atsu85/tslint","homepage":"http://palantir.github.io/tslint/","size":13642,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"palantir:master","ref":"master","sha":"3ca9f8c3cf0eba5d1438d052aacc95f6aaa2ba99","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":11672345,"name":"tslint","full_name":"palantir/tslint","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/tslint","description":":vertical_traffic_light: An extensible linter for the TypeScript language","fork":false,"url":"https://api.github.com/repos/palantir/tslint","forks_url":"https://api.github.com/repos/palantir/tslint/forks","keys_url":"https://api.github.com/repos/palantir/tslint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/tslint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/tslint/teams","hooks_url":"https://api.github.com/repos/palantir/tslint/hooks","issue_events_url":"https://api.github.com/repos/palantir/tslint/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/tslint/events","assignees_url":"https://api.github.com/repos/palantir/tslint/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/tslint/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/tslint/tags","blobs_url":"https://api.github.com/repos/palantir/tslint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/tslint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/tslint/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/tslint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/tslint/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/tslint/languages","stargazers_url":"https://api.github.com/repos/palantir/tslint/stargazers","contributors_url":"https://api.github.com/repos/palantir/tslint/contributors","subscribers_url":"https://api.github.com/repos/palantir/tslint/subscribers","subscription_url":"https://api.github.com/repos/palantir/tslint/subscription","commits_url":"https://api.github.com/repos/palantir/tslint/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/tslint/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/tslint/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/tslint/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/tslint/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/tslint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/tslint/merges","archive_url":"https://api.github.com/repos/palantir/tslint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/tslint/downloads","issues_url":"https://api.github.com/repos/palantir/tslint/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/tslint/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/tslint/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/tslint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/tslint/labels{/name}","releases_url":"https://api.github.com/repos/palantir/tslint/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/tslint/deployments","created_at":"2013-07-25T22:19:18Z","updated_at":"2017-12-22T13:20:14Z","pushed_at":"2017-12-21T23:45:38Z","git_url":"git://github.com/palantir/tslint.git","ssh_url":"git@github.com:palantir/tslint.git","clone_url":"https://github.com/palantir/tslint.git","svn_url":"https://github.com/palantir/tslint","homepage":"http://palantir.github.io/tslint/","size":13642,"stargazers_count":2710,"watchers_count":2710,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":533,"mirror_url":null,"archived":false,"open_issues_count":488,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":533,"open_issues":488,"watchers":2710,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3604"},"html":{"href":"https://github.com/palantir/tslint/pull/3604"},"issue":{"href":"https://api.github.com/repos/palantir/tslint/issues/3604"},"comments":{"href":"https://api.github.com/repos/palantir/tslint/issues/3604/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3604/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/tslint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/tslint/pulls/3604/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/tslint/statuses/3d818d2e00974c96ae88cacaa318f297190c8738"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":25,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"atsu85"}}