{"action":"created","comment":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/155559029","pull_request_review_id":81898110,"id":155559029,"diff_hunk":"@@ -118,10 +124,56 @@ public void checkDatabaseVersion() {\n \n     @Override\n     public void compactInternally() {\n+        if (config.compactIntervalMillis() > 0 && checkIfTableHasNotBeenCompactedForCompactIntervalMillis()) {\n+            runCompactOnTable();","path":"atlasdb-dbkvs/src/main/java/com/palantir/atlasdb/keyvalue/dbkvs/impl/postgres/PostgresDdlTable.java","position":51,"original_position":51,"commit_id":"0a7811cb02b661cd3c85cb0f55aa9745260c5a3c","original_commit_id":"0a7811cb02b661cd3c85cb0f55aa9745260c5a3c","user":{"login":"gmaretic","id":23168027,"avatar_url":"https://avatars0.githubusercontent.com/u/23168027?v=4","gravatar_id":"","url":"https://api.github.com/users/gmaretic","html_url":"https://github.com/gmaretic","followers_url":"https://api.github.com/users/gmaretic/followers","following_url":"https://api.github.com/users/gmaretic/following{/other_user}","gists_url":"https://api.github.com/users/gmaretic/gists{/gist_id}","starred_url":"https://api.github.com/users/gmaretic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmaretic/subscriptions","organizations_url":"https://api.github.com/users/gmaretic/orgs","repos_url":"https://api.github.com/users/gmaretic/repos","events_url":"https://api.github.com/users/gmaretic/events{/privacy}","received_events_url":"https://api.github.com/users/gmaretic/received_events","type":"User","site_admin":false},"body":"Have a Semaphore that guards this method call (make sure to release the permit in a finally block)","created_at":"2017-12-07T15:48:25Z","updated_at":"2017-12-07T15:58:32Z","html_url":"https://github.com/palantir/atlasdb/pull/2767#discussion_r155559029","pull_request_url":"https://api.github.com/repos/palantir/atlasdb/pulls/2767","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments/155559029"},"html":{"href":"https://github.com/palantir/atlasdb/pull/2767#discussion_r155559029"},"pull_request":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/2767"}}},"pull_request":{"url":"https://api.github.com/repos/palantir/atlasdb/pulls/2767","id":155981936,"html_url":"https://github.com/palantir/atlasdb/pull/2767","diff_url":"https://github.com/palantir/atlasdb/pull/2767.diff","patch_url":"https://github.com/palantir/atlasdb/pull/2767.patch","issue_url":"https://api.github.com/repos/palantir/atlasdb/issues/2767","number":2767,"state":"open","locked":false,"title":"Don't compact if Vacuum ran in the last N seconds","user":{"login":"hsaraogi","id":20421615,"avatar_url":"https://avatars2.githubusercontent.com/u/20421615?v=4","gravatar_id":"","url":"https://api.github.com/users/hsaraogi","html_url":"https://github.com/hsaraogi","followers_url":"https://api.github.com/users/hsaraogi/followers","following_url":"https://api.github.com/users/hsaraogi/following{/other_user}","gists_url":"https://api.github.com/users/hsaraogi/gists{/gist_id}","starred_url":"https://api.github.com/users/hsaraogi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsaraogi/subscriptions","organizations_url":"https://api.github.com/users/hsaraogi/orgs","repos_url":"https://api.github.com/users/hsaraogi/repos","events_url":"https://api.github.com/users/hsaraogi/events{/privacy}","received_events_url":"https://api.github.com/users/hsaraogi/received_events","type":"User","site_admin":false},"body":"**Goals (and why)**: Fix #2714.\r\n\r\n**Implementation Description (bullets)**: have a config for the min time interval between two Vaccums and enforce that.\r\n\r\n**Concerns (what feedback would you like?)**: NA\r\n\r\n**Where should we start reviewing?**: soon\r\n\r\n**Priority (whenever / two weeks / yesterday)**: soon\r\n\r\n<!---\r\nPlease remember to:\r\n- Add any necessary release notes (including breaking changes)\r\n- Make sure the documentation is up to date for your change\r\n--->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/palantir/atlasdb/2767)\n<!-- Reviewable:end -->\n","created_at":"2017-12-01T23:42:14Z","updated_at":"2017-12-07T15:58:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dd5b0b08dd890b4aa41fb71577ee33b50f3d7ef2","assignee":{"login":"berler","id":1030627,"avatar_url":"https://avatars3.githubusercontent.com/u/1030627?v=4","gravatar_id":"","url":"https://api.github.com/users/berler","html_url":"https://github.com/berler","followers_url":"https://api.github.com/users/berler/followers","following_url":"https://api.github.com/users/berler/following{/other_user}","gists_url":"https://api.github.com/users/berler/gists{/gist_id}","starred_url":"https://api.github.com/users/berler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berler/subscriptions","organizations_url":"https://api.github.com/users/berler/orgs","repos_url":"https://api.github.com/users/berler/repos","events_url":"https://api.github.com/users/berler/events{/privacy}","received_events_url":"https://api.github.com/users/berler/received_events","type":"User","site_admin":false},"assignees":[{"login":"berler","id":1030627,"avatar_url":"https://avatars3.githubusercontent.com/u/1030627?v=4","gravatar_id":"","url":"https://api.github.com/users/berler","html_url":"https://github.com/berler","followers_url":"https://api.github.com/users/berler/followers","following_url":"https://api.github.com/users/berler/following{/other_user}","gists_url":"https://api.github.com/users/berler/gists{/gist_id}","starred_url":"https://api.github.com/users/berler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berler/subscriptions","organizations_url":"https://api.github.com/users/berler/orgs","repos_url":"https://api.github.com/users/berler/repos","events_url":"https://api.github.com/users/berler/events{/privacy}","received_events_url":"https://api.github.com/users/berler/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"berler","id":1030627,"avatar_url":"https://avatars3.githubusercontent.com/u/1030627?v=4","gravatar_id":"","url":"https://api.github.com/users/berler","html_url":"https://github.com/berler","followers_url":"https://api.github.com/users/berler/followers","following_url":"https://api.github.com/users/berler/following{/other_user}","gists_url":"https://api.github.com/users/berler/gists{/gist_id}","starred_url":"https://api.github.com/users/berler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berler/subscriptions","organizations_url":"https://api.github.com/users/berler/orgs","repos_url":"https://api.github.com/users/berler/repos","events_url":"https://api.github.com/users/berler/events{/privacy}","received_events_url":"https://api.github.com/users/berler/received_events","type":"User","site_admin":false},{"login":"jeremyk-91","id":5955510,"avatar_url":"https://avatars2.githubusercontent.com/u/5955510?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyk-91","html_url":"https://github.com/jeremyk-91","followers_url":"https://api.github.com/users/jeremyk-91/followers","following_url":"https://api.github.com/users/jeremyk-91/following{/other_user}","gists_url":"https://api.github.com/users/jeremyk-91/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyk-91/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyk-91/subscriptions","organizations_url":"https://api.github.com/users/jeremyk-91/orgs","repos_url":"https://api.github.com/users/jeremyk-91/repos","events_url":"https://api.github.com/users/jeremyk-91/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyk-91/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/palantir/atlasdb/pulls/2767/commits","review_comments_url":"https://api.github.com/repos/palantir/atlasdb/pulls/2767/comments","review_comment_url":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/palantir/atlasdb/issues/2767/comments","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/0a7811cb02b661cd3c85cb0f55aa9745260c5a3c","head":{"label":"palantir:fix/postgres-vaccum","ref":"fix/postgres-vaccum","sha":"0a7811cb02b661cd3c85cb0f55aa9745260c5a3c","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2017-12-06T19:09:23Z","pushed_at":"2017-12-07T15:43:11Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":53849,"stargazers_count":540,"watchers_count":540,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":270,"license":null,"forks":95,"open_issues":270,"watchers":540,"default_branch":"develop"}},"base":{"label":"palantir:develop","ref":"develop","sha":"1e32e9dc2544f9e260d7b925f47dc57bbaf8d458","user":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"repo":{"id":36960637,"name":"atlasdb","full_name":"palantir/atlasdb","owner":{"login":"palantir","id":303157,"avatar_url":"https://avatars0.githubusercontent.com/u/303157?v=4","gravatar_id":"","url":"https://api.github.com/users/palantir","html_url":"https://github.com/palantir","followers_url":"https://api.github.com/users/palantir/followers","following_url":"https://api.github.com/users/palantir/following{/other_user}","gists_url":"https://api.github.com/users/palantir/gists{/gist_id}","starred_url":"https://api.github.com/users/palantir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/palantir/subscriptions","organizations_url":"https://api.github.com/users/palantir/orgs","repos_url":"https://api.github.com/users/palantir/repos","events_url":"https://api.github.com/users/palantir/events{/privacy}","received_events_url":"https://api.github.com/users/palantir/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/palantir/atlasdb","description":"Transactional Distributed Database Layer","fork":false,"url":"https://api.github.com/repos/palantir/atlasdb","forks_url":"https://api.github.com/repos/palantir/atlasdb/forks","keys_url":"https://api.github.com/repos/palantir/atlasdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/palantir/atlasdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/palantir/atlasdb/teams","hooks_url":"https://api.github.com/repos/palantir/atlasdb/hooks","issue_events_url":"https://api.github.com/repos/palantir/atlasdb/issues/events{/number}","events_url":"https://api.github.com/repos/palantir/atlasdb/events","assignees_url":"https://api.github.com/repos/palantir/atlasdb/assignees{/user}","branches_url":"https://api.github.com/repos/palantir/atlasdb/branches{/branch}","tags_url":"https://api.github.com/repos/palantir/atlasdb/tags","blobs_url":"https://api.github.com/repos/palantir/atlasdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/palantir/atlasdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/palantir/atlasdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/palantir/atlasdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/palantir/atlasdb/statuses/{sha}","languages_url":"https://api.github.com/repos/palantir/atlasdb/languages","stargazers_url":"https://api.github.com/repos/palantir/atlasdb/stargazers","contributors_url":"https://api.github.com/repos/palantir/atlasdb/contributors","subscribers_url":"https://api.github.com/repos/palantir/atlasdb/subscribers","subscription_url":"https://api.github.com/repos/palantir/atlasdb/subscription","commits_url":"https://api.github.com/repos/palantir/atlasdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/palantir/atlasdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/palantir/atlasdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/palantir/atlasdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/palantir/atlasdb/contents/{+path}","compare_url":"https://api.github.com/repos/palantir/atlasdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/palantir/atlasdb/merges","archive_url":"https://api.github.com/repos/palantir/atlasdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/palantir/atlasdb/downloads","issues_url":"https://api.github.com/repos/palantir/atlasdb/issues{/number}","pulls_url":"https://api.github.com/repos/palantir/atlasdb/pulls{/number}","milestones_url":"https://api.github.com/repos/palantir/atlasdb/milestones{/number}","notifications_url":"https://api.github.com/repos/palantir/atlasdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/palantir/atlasdb/labels{/name}","releases_url":"https://api.github.com/repos/palantir/atlasdb/releases{/id}","deployments_url":"https://api.github.com/repos/palantir/atlasdb/deployments","created_at":"2015-06-05T23:42:44Z","updated_at":"2017-12-06T19:09:23Z","pushed_at":"2017-12-07T15:43:11Z","git_url":"git://github.com/palantir/atlasdb.git","ssh_url":"git@github.com:palantir/atlasdb.git","clone_url":"https://github.com/palantir/atlasdb.git","svn_url":"https://github.com/palantir/atlasdb","homepage":"http://palantir.github.io/atlasdb/","size":53849,"stargazers_count":540,"watchers_count":540,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":95,"mirror_url":null,"archived":false,"open_issues_count":270,"license":null,"forks":95,"open_issues":270,"watchers":540,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/2767"},"html":{"href":"https://github.com/palantir/atlasdb/pull/2767"},"issue":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/2767"},"comments":{"href":"https://api.github.com/repos/palantir/atlasdb/issues/2767/comments"},"review_comments":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/2767/comments"},"review_comment":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/palantir/atlasdb/pulls/2767/commits"},"statuses":{"href":"https://api.github.com/repos/palantir/atlasdb/statuses/0a7811cb02b661cd3c85cb0f55aa9745260c5a3c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gmaretic"}}