{"action":"created","issue":{"url":"https://api.github.com/repos/PlusToolkit/PlusLib/issues/51","repository_url":"https://api.github.com/repos/PlusToolkit/PlusLib","labels_url":"https://api.github.com/repos/PlusToolkit/PlusLib/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/PlusToolkit/PlusLib/issues/51/comments","events_url":"https://api.github.com/repos/PlusToolkit/PlusLib/issues/51/events","html_url":"https://github.com/PlusToolkit/PlusLib/pull/51","id":229432922,"number":51,"title":"re #1194 Adding initial WinProbe support","user":{"login":"dzenanz","id":1792121,"avatar_url":"https://avatars0.githubusercontent.com/u/1792121?v=3","gravatar_id":"","url":"https://api.github.com/users/dzenanz","html_url":"https://github.com/dzenanz","followers_url":"https://api.github.com/users/dzenanz/followers","following_url":"https://api.github.com/users/dzenanz/following{/other_user}","gists_url":"https://api.github.com/users/dzenanz/gists{/gist_id}","starred_url":"https://api.github.com/users/dzenanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzenanz/subscriptions","organizations_url":"https://api.github.com/users/dzenanz/orgs","repos_url":"https://api.github.com/users/dzenanz/repos","events_url":"https://api.github.com/users/dzenanz/events{/privacy}","received_events_url":"https://api.github.com/users/dzenanz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-05-17T17:33:08Z","updated_at":"2017-05-17T18:11:22Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/PlusToolkit/PlusLib/pulls/51","html_url":"https://github.com/PlusToolkit/PlusLib/pull/51","diff_url":"https://github.com/PlusToolkit/PlusLib/pull/51.diff","patch_url":"https://github.com/PlusToolkit/PlusLib/pull/51.patch"},"body":"This PR only adds a basic level of support for WinProbe ultrasound system. In current version of the WinProbeSDK, some of the functions are not properly exported in x64 version, so a few function calls are commented out (Voltage, ADCfrequency).\r\n\r\nCurrently the test fails, probably because it cannot find the .net DLLs. I tried adding WORKING_DIRECTORY argument but it didn't help. Running the test from VisualStudio works, as long as I set working directory to _PlusBuild-bin\\bin\\Debug_.\r\n\r\nFeedback is welcome!"},"comment":{"url":"https://api.github.com/repos/PlusToolkit/PlusLib/issues/comments/302178865","html_url":"https://github.com/PlusToolkit/PlusLib/pull/51#issuecomment-302178865","issue_url":"https://api.github.com/repos/PlusToolkit/PlusLib/issues/51","id":302178865,"user":{"login":"adamrankin","id":3210398,"avatar_url":"https://avatars3.githubusercontent.com/u/3210398?v=3","gravatar_id":"","url":"https://api.github.com/users/adamrankin","html_url":"https://github.com/adamrankin","followers_url":"https://api.github.com/users/adamrankin/followers","following_url":"https://api.github.com/users/adamrankin/following{/other_user}","gists_url":"https://api.github.com/users/adamrankin/gists{/gist_id}","starred_url":"https://api.github.com/users/adamrankin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamrankin/subscriptions","organizations_url":"https://api.github.com/users/adamrankin/orgs","repos_url":"https://api.github.com/users/adamrankin/repos","events_url":"https://api.github.com/users/adamrankin/events{/privacy}","received_events_url":"https://api.github.com/users/adamrankin/received_events","type":"User","site_admin":false},"created_at":"2017-05-17T18:11:21Z","updated_at":"2017-05-17T18:11:21Z","body":"Perhaps a series of macros would be in order to standardise plus data\ncollection cmake.\n\nOn May 17, 2017 2:10 PM, \"Dženan Zukić\" <notifications@github.com> wrote:\n\n> ------------------------------\n> vtkWinProbeVideoSourceTest.exe - System Error The program can't start\n> because UltraVisionManagedDll.dll is missing from your computer. Try\n> reinstalling the program to fix this problem. OK\n>\n> My CMake code copies UltraVisionManagedDll.dll and other DLLs from\n> WinProbeSDK to bin folder, but only for Debug and Release variants. How to\n> accomplish the same with other configurations?\n>\n> —\n> You are receiving this because you are subscribed to this thread.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/PlusToolkit/PlusLib/pull/51#issuecomment-302178383>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/ADD8nps7Ufpp25oRnRlBx8C8FxM1qTx1ks5r6zgBgaJpZM4NeNNf>\n> .\n>\n"}}
{"actor":{"display_login":"adamrankin"}}