{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/117042311","pull_request_review_id":38712963,"id":117042311,"diff_hunk":"@@ -28,7 +28,7 @@\n             .form-horizontal.static\n               .form-group\n                 .col-md-9\n-                  - htm = @job.raw_stdout('html').gsub('\"', '\\\"').gsub(\"'\", \"\\\\\\\\'\")\n+                  - htm = @job.raw_stdout('html').gsub('\"', '\\\"').gsub(\"'\", \"\\\\\\\\'\").gsub(/{{/, '\\{\\{').gsub(/}}/, '\\}\\}')","path":"app/views/service/_svcs_show.html.haml","position":5,"original_position":5,"commit_id":"6d5e0d05121c699b64fbe9b379ecd09444f3576e","original_commit_id":"6d5e0d05121c699b64fbe9b379ecd09444f3576e","user":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars3.githubusercontent.com/u/2591569?v=3","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"body":"Each `gsub` call is going to return a copy of the original string, since these can be large output it would make more sense to do separate `gsub!` calls so the substitutions happens without duplicating the string.\r\n\r\nThere might also be a way to do this in one `gsub!` call.  For example:\r\n`'hello'.gsub(/[eo]/, 'e' => 3, 'o' => '*')    #=> \"h3ll*\"` (See https://ruby-doc.org/core-2.1.4/String.html)","created_at":"2017-05-17T15:56:20Z","updated_at":"2017-05-17T15:56:21Z","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1369#discussion_r117042311","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1369","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments/117042311"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1369#discussion_r117042311"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1369"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1369","id":121055323,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1369","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1369.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1369.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1369","number":1369,"state":"open","locked":false,"title":"Need to gsub occurrences of {{ }} in the output","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars2.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"body":"https://bugzilla.redhat.com/show_bug.cgi?id=1451352\r\nhttps://bugzilla.redhat.com/show_bug.cgi?id=1444853\r\n\r\n@syncrou @gmcculloug please test/review.","created_at":"2017-05-17T13:19:55Z","updated_at":"2017-05-17T15:56:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14c25e32f277b7a8a10d452471fe7b6c7847be3b","assignee":{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars0.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false},"assignees":[{"login":"dclarizio","id":3433754,"avatar_url":"https://avatars0.githubusercontent.com/u/3433754?v=3","gravatar_id":"","url":"https://api.github.com/users/dclarizio","html_url":"https://github.com/dclarizio","followers_url":"https://api.github.com/users/dclarizio/followers","following_url":"https://api.github.com/users/dclarizio/following{/other_user}","gists_url":"https://api.github.com/users/dclarizio/gists{/gist_id}","starred_url":"https://api.github.com/users/dclarizio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dclarizio/subscriptions","organizations_url":"https://api.github.com/users/dclarizio/orgs","repos_url":"https://api.github.com/users/dclarizio/repos","events_url":"https://api.github.com/users/dclarizio/events{/privacy}","received_events_url":"https://api.github.com/users/dclarizio/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1369/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1369/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1369/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/6d5e0d05121c699b64fbe9b379ecd09444f3576e","head":{"label":"h-kataria:stdout_fix","ref":"stdout_fix","sha":"6d5e0d05121c699b64fbe9b379ecd09444f3576e","user":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars2.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"repo":{"id":77159709,"name":"manageiq-ui-classic","full_name":"h-kataria/manageiq-ui-classic","owner":{"login":"h-kataria","id":3450808,"avatar_url":"https://avatars2.githubusercontent.com/u/3450808?v=3","gravatar_id":"","url":"https://api.github.com/users/h-kataria","html_url":"https://github.com/h-kataria","followers_url":"https://api.github.com/users/h-kataria/followers","following_url":"https://api.github.com/users/h-kataria/following{/other_user}","gists_url":"https://api.github.com/users/h-kataria/gists{/gist_id}","starred_url":"https://api.github.com/users/h-kataria/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-kataria/subscriptions","organizations_url":"https://api.github.com/users/h-kataria/orgs","repos_url":"https://api.github.com/users/h-kataria/repos","events_url":"https://api.github.com/users/h-kataria/events{/privacy}","received_events_url":"https://api.github.com/users/h-kataria/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/h-kataria/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic","forks_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/h-kataria/manageiq-ui-classic/deployments","created_at":"2016-12-22T16:29:36Z","updated_at":"2016-12-22T16:29:42Z","pushed_at":"2017-05-17T15:48:27Z","git_url":"git://github.com/h-kataria/manageiq-ui-classic.git","ssh_url":"git@github.com:h-kataria/manageiq-ui-classic.git","clone_url":"https://github.com/h-kataria/manageiq-ui-classic.git","svn_url":"https://github.com/h-kataria/manageiq-ui-classic","homepage":null,"size":42436,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"f09d99ec6e4ae89081f6db7c7266d32556569e17","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2017-04-28T15:50:11Z","pushed_at":"2017-05-17T15:50:58Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":43799,"stargazers_count":12,"watchers_count":12,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":138,"mirror_url":null,"open_issues_count":190,"forks":138,"open_issues":190,"watchers":12,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1369"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/1369"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1369"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/1369/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1369/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/1369/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/6d5e0d05121c699b64fbe9b379ecd09444f3576e"}}}}
{"actor":{"display_login":"gmcculloug"}}