{"action":"closed","number":48276,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/48276","id":128182769,"html_url":"https://github.com/kubernetes/kubernetes/pull/48276","diff_url":"https://github.com/kubernetes/kubernetes/pull/48276.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/48276.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48276","number":48276,"state":"closed","locked":false,"title":"client-go support IPv6 addresses for PortForwarder getListener()","user":{"login":"pmichali","id":2787783,"avatar_url":"https://avatars5.githubusercontent.com/u/2787783?v=4","gravatar_id":"","url":"https://api.github.com/users/pmichali","html_url":"https://github.com/pmichali","followers_url":"https://api.github.com/users/pmichali/followers","following_url":"https://api.github.com/users/pmichali/following{/other_user}","gists_url":"https://api.github.com/users/pmichali/gists{/gist_id}","starred_url":"https://api.github.com/users/pmichali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmichali/subscriptions","organizations_url":"https://api.github.com/users/pmichali/orgs","repos_url":"https://api.github.com/users/pmichali/repos","events_url":"https://api.github.com/users/pmichali/events{/privacy}","received_events_url":"https://api.github.com/users/pmichali/received_events","type":"User","site_admin":false},"body":"Currently, client-go requires that an IPv6 address string for hostname has\r\nsquare brackets surrounding, so that it can be used with address:port in\r\nan API request.\r\n\r\nThis change, removes that requirement, and has getListener() add the\r\nsquare brackets, if needed. If the hostname is a name, an IPv4 address\r\nstring, or an IPv6 address already with square brackets, no change is made.\r\n\r\nDecided to change here, rather than everywhere client-go is used (thinking\r\nthat there may be places where we DON'T want the square brackets applied).\r\n\r\nThis issue was found in kubelet, which, at startup, creates a listener for\r\nservices and nodes. If an IPv6 address is used, the URI was malformed.\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nEnsures that client-go will handle IPv6 addresses as hostnames, without any special encoding by caller.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #48225 \r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n","created_at":"2017-06-29T15:35:34Z","updated_at":"2017-07-14T11:43:44Z","closed_at":"2017-07-14T11:43:44Z","merged_at":"2017-07-14T11:43:44Z","merge_commit_sha":"a3ff0eaf697da88c2504622e6fd05c46607a2eb8","assignee":{"login":"vishh","id":7063592,"avatar_url":"https://avatars6.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"avatar_url":"https://avatars4.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"avatar_url":"https://avatars6.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/48276/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/48276/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/48276/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e17a501bcb7a3d2c5f4ff5c41f122fe155395dcd","head":{"label":"pmichali:issue48225","ref":"issue48225","sha":"e17a501bcb7a3d2c5f4ff5c41f122fe155395dcd","user":{"login":"pmichali","id":2787783,"avatar_url":"https://avatars5.githubusercontent.com/u/2787783?v=4","gravatar_id":"","url":"https://api.github.com/users/pmichali","html_url":"https://github.com/pmichali","followers_url":"https://api.github.com/users/pmichali/followers","following_url":"https://api.github.com/users/pmichali/following{/other_user}","gists_url":"https://api.github.com/users/pmichali/gists{/gist_id}","starred_url":"https://api.github.com/users/pmichali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmichali/subscriptions","organizations_url":"https://api.github.com/users/pmichali/orgs","repos_url":"https://api.github.com/users/pmichali/repos","events_url":"https://api.github.com/users/pmichali/events{/privacy}","received_events_url":"https://api.github.com/users/pmichali/received_events","type":"User","site_admin":false},"repo":{"id":75412741,"name":"kubernetes","full_name":"pmichali/kubernetes","owner":{"login":"pmichali","id":2787783,"avatar_url":"https://avatars5.githubusercontent.com/u/2787783?v=4","gravatar_id":"","url":"https://api.github.com/users/pmichali","html_url":"https://github.com/pmichali","followers_url":"https://api.github.com/users/pmichali/followers","following_url":"https://api.github.com/users/pmichali/following{/other_user}","gists_url":"https://api.github.com/users/pmichali/gists{/gist_id}","starred_url":"https://api.github.com/users/pmichali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmichali/subscriptions","organizations_url":"https://api.github.com/users/pmichali/orgs","repos_url":"https://api.github.com/users/pmichali/repos","events_url":"https://api.github.com/users/pmichali/events{/privacy}","received_events_url":"https://api.github.com/users/pmichali/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pmichali/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/pmichali/kubernetes","forks_url":"https://api.github.com/repos/pmichali/kubernetes/forks","keys_url":"https://api.github.com/repos/pmichali/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmichali/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmichali/kubernetes/teams","hooks_url":"https://api.github.com/repos/pmichali/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/pmichali/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/pmichali/kubernetes/events","assignees_url":"https://api.github.com/repos/pmichali/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/pmichali/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/pmichali/kubernetes/tags","blobs_url":"https://api.github.com/repos/pmichali/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmichali/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmichali/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmichali/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmichali/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/pmichali/kubernetes/languages","stargazers_url":"https://api.github.com/repos/pmichali/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/pmichali/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/pmichali/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/pmichali/kubernetes/subscription","commits_url":"https://api.github.com/repos/pmichali/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmichali/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmichali/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmichali/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmichali/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/pmichali/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmichali/kubernetes/merges","archive_url":"https://api.github.com/repos/pmichali/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmichali/kubernetes/downloads","issues_url":"https://api.github.com/repos/pmichali/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/pmichali/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/pmichali/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/pmichali/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmichali/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/pmichali/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/pmichali/kubernetes/deployments","created_at":"2016-12-02T16:35:34Z","updated_at":"2016-12-02T16:36:17Z","pushed_at":"2017-07-13T19:56:58Z","git_url":"git://github.com/pmichali/kubernetes.git","ssh_url":"git@github.com:pmichali/kubernetes.git","clone_url":"https://github.com/pmichali/kubernetes.git","svn_url":"https://github.com/pmichali/kubernetes","homepage":"http://kubernetes.io","size":443823,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"f818cbeaedd524c59dcd8b1ff3d02c4c14143855","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-07-14T11:38:53Z","pushed_at":"2017-07-14T11:43:44Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":663389,"stargazers_count":24918,"watchers_count":24918,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8859,"mirror_url":null,"open_issues_count":5014,"forks":8859,"open_issues":5014,"watchers":24918,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/48276"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/48276"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/48276"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/48276/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/48276/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/48276/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/e17a501bcb7a3d2c5f4ff5c41f122fe155395dcd"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars7.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":12,"review_comments":6,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":10,"changed_files":2}}
{"actor":{"display_login":"k8s-merge-robot"}}