{"action":"created","comment":{"url":"https://api.github.com/repos/Yomguithereal/baobab/pulls/comments/99558303","pull_request_review_id":20237101,"id":99558303,"diff_hunk":"@@ -223,6 +223,26 @@ describe('Helpers', function() {\n         [{name: 'John'}, {name: 'Paul'}]\n       );\n     });\n+\n+    describe('Issue #472 - tree/cursor.splice does not conform with the specification as of ES6 (ECMAScript 2015)', function () {\n+      it('should be possible to splice an array when omitting the nb (deleteCount) argument', function () {\n+        const array = [0, 1, 2, 3, 4];\n+\n+        assert.deepEqual(splice(array, 2), [0, 1]);\n+\n+        assert.deepEqual(splice(array, -2), [0, 1, 2]);\n+\n+        assert.deepEqual(splice(array, 2, null), [0, 1, 2, 3, 4]);\n+      });\n+\n+      it('should delete no values when supplying an argument which is not parseable as number', function () {","path":"test/suites/helpers.js","position":16,"original_position":16,"commit_id":"d28587d315de5dec2ccd2a02b8eb670acfbb5d21","original_commit_id":"d28587d315de5dec2ccd2a02b8eb670acfbb5d21","user":{"login":"Nimelrian","id":8960836,"avatar_url":"https://avatars.githubusercontent.com/u/8960836?v=3","gravatar_id":"","url":"https://api.github.com/users/Nimelrian","html_url":"https://github.com/Nimelrian","followers_url":"https://api.github.com/users/Nimelrian/followers","following_url":"https://api.github.com/users/Nimelrian/following{/other_user}","gists_url":"https://api.github.com/users/Nimelrian/gists{/gist_id}","starred_url":"https://api.github.com/users/Nimelrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nimelrian/subscriptions","organizations_url":"https://api.github.com/users/Nimelrian/orgs","repos_url":"https://api.github.com/users/Nimelrian/repos","events_url":"https://api.github.com/users/Nimelrian/events{/privacy}","received_events_url":"https://api.github.com/users/Nimelrian/received_events","type":"User","site_admin":false},"body":"A last note: If we decide to throw an error, we should also add an additional check for the splicer typechecker.","created_at":"2017-02-06T10:41:56Z","updated_at":"2017-02-06T10:41:56Z","html_url":"https://github.com/Yomguithereal/baobab/pull/473#discussion_r99558303","pull_request_url":"https://api.github.com/repos/Yomguithereal/baobab/pulls/473","_links":{"self":{"href":"https://api.github.com/repos/Yomguithereal/baobab/pulls/comments/99558303"},"html":{"href":"https://github.com/Yomguithereal/baobab/pull/473#discussion_r99558303"},"pull_request":{"href":"https://api.github.com/repos/Yomguithereal/baobab/pulls/473"}}},"pull_request":{"url":"https://api.github.com/repos/Yomguithereal/baobab/pulls/473","id":104331082,"html_url":"https://github.com/Yomguithereal/baobab/pull/473","diff_url":"https://github.com/Yomguithereal/baobab/pull/473.diff","patch_url":"https://github.com/Yomguithereal/baobab/pull/473.patch","issue_url":"https://api.github.com/repos/Yomguithereal/baobab/issues/473","number":473,"state":"open","locked":false,"title":"nb argument of splice now defaults to 0 if omitted","user":{"login":"Nimelrian","id":8960836,"avatar_url":"https://avatars.githubusercontent.com/u/8960836?v=3","gravatar_id":"","url":"https://api.github.com/users/Nimelrian","html_url":"https://github.com/Nimelrian","followers_url":"https://api.github.com/users/Nimelrian/followers","following_url":"https://api.github.com/users/Nimelrian/following{/other_user}","gists_url":"https://api.github.com/users/Nimelrian/gists{/gist_id}","starred_url":"https://api.github.com/users/Nimelrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nimelrian/subscriptions","organizations_url":"https://api.github.com/users/Nimelrian/orgs","repos_url":"https://api.github.com/users/Nimelrian/repos","events_url":"https://api.github.com/users/Nimelrian/events{/privacy}","received_events_url":"https://api.github.com/users/Nimelrian/received_events","type":"User","site_admin":false},"body":"This fixes Issue #472 ","created_at":"2017-02-02T12:48:39Z","updated_at":"2017-02-06T10:41:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d816285eff8bed367769136528e3bd8fbf50bca6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Yomguithereal/baobab/pulls/473/commits","review_comments_url":"https://api.github.com/repos/Yomguithereal/baobab/pulls/473/comments","review_comment_url":"https://api.github.com/repos/Yomguithereal/baobab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Yomguithereal/baobab/issues/473/comments","statuses_url":"https://api.github.com/repos/Yomguithereal/baobab/statuses/d28587d315de5dec2ccd2a02b8eb670acfbb5d21","head":{"label":"Nimelrian:master","ref":"master","sha":"d28587d315de5dec2ccd2a02b8eb670acfbb5d21","user":{"login":"Nimelrian","id":8960836,"avatar_url":"https://avatars.githubusercontent.com/u/8960836?v=3","gravatar_id":"","url":"https://api.github.com/users/Nimelrian","html_url":"https://github.com/Nimelrian","followers_url":"https://api.github.com/users/Nimelrian/followers","following_url":"https://api.github.com/users/Nimelrian/following{/other_user}","gists_url":"https://api.github.com/users/Nimelrian/gists{/gist_id}","starred_url":"https://api.github.com/users/Nimelrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nimelrian/subscriptions","organizations_url":"https://api.github.com/users/Nimelrian/orgs","repos_url":"https://api.github.com/users/Nimelrian/repos","events_url":"https://api.github.com/users/Nimelrian/events{/privacy}","received_events_url":"https://api.github.com/users/Nimelrian/received_events","type":"User","site_admin":false},"repo":{"id":80723335,"name":"baobab","full_name":"Nimelrian/baobab","owner":{"login":"Nimelrian","id":8960836,"avatar_url":"https://avatars.githubusercontent.com/u/8960836?v=3","gravatar_id":"","url":"https://api.github.com/users/Nimelrian","html_url":"https://github.com/Nimelrian","followers_url":"https://api.github.com/users/Nimelrian/followers","following_url":"https://api.github.com/users/Nimelrian/following{/other_user}","gists_url":"https://api.github.com/users/Nimelrian/gists{/gist_id}","starred_url":"https://api.github.com/users/Nimelrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nimelrian/subscriptions","organizations_url":"https://api.github.com/users/Nimelrian/orgs","repos_url":"https://api.github.com/users/Nimelrian/repos","events_url":"https://api.github.com/users/Nimelrian/events{/privacy}","received_events_url":"https://api.github.com/users/Nimelrian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Nimelrian/baobab","description":"JavaScript persistent and optionally immutable data tree with cursors.","fork":true,"url":"https://api.github.com/repos/Nimelrian/baobab","forks_url":"https://api.github.com/repos/Nimelrian/baobab/forks","keys_url":"https://api.github.com/repos/Nimelrian/baobab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nimelrian/baobab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nimelrian/baobab/teams","hooks_url":"https://api.github.com/repos/Nimelrian/baobab/hooks","issue_events_url":"https://api.github.com/repos/Nimelrian/baobab/issues/events{/number}","events_url":"https://api.github.com/repos/Nimelrian/baobab/events","assignees_url":"https://api.github.com/repos/Nimelrian/baobab/assignees{/user}","branches_url":"https://api.github.com/repos/Nimelrian/baobab/branches{/branch}","tags_url":"https://api.github.com/repos/Nimelrian/baobab/tags","blobs_url":"https://api.github.com/repos/Nimelrian/baobab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nimelrian/baobab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nimelrian/baobab/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nimelrian/baobab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nimelrian/baobab/statuses/{sha}","languages_url":"https://api.github.com/repos/Nimelrian/baobab/languages","stargazers_url":"https://api.github.com/repos/Nimelrian/baobab/stargazers","contributors_url":"https://api.github.com/repos/Nimelrian/baobab/contributors","subscribers_url":"https://api.github.com/repos/Nimelrian/baobab/subscribers","subscription_url":"https://api.github.com/repos/Nimelrian/baobab/subscription","commits_url":"https://api.github.com/repos/Nimelrian/baobab/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nimelrian/baobab/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nimelrian/baobab/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nimelrian/baobab/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nimelrian/baobab/contents/{+path}","compare_url":"https://api.github.com/repos/Nimelrian/baobab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nimelrian/baobab/merges","archive_url":"https://api.github.com/repos/Nimelrian/baobab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nimelrian/baobab/downloads","issues_url":"https://api.github.com/repos/Nimelrian/baobab/issues{/number}","pulls_url":"https://api.github.com/repos/Nimelrian/baobab/pulls{/number}","milestones_url":"https://api.github.com/repos/Nimelrian/baobab/milestones{/number}","notifications_url":"https://api.github.com/repos/Nimelrian/baobab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nimelrian/baobab/labels{/name}","releases_url":"https://api.github.com/repos/Nimelrian/baobab/releases{/id}","deployments_url":"https://api.github.com/repos/Nimelrian/baobab/deployments","created_at":"2017-02-02T12:36:57Z","updated_at":"2017-02-02T12:36:59Z","pushed_at":"2017-02-03T11:43:24Z","git_url":"git://github.com/Nimelrian/baobab.git","ssh_url":"git@github.com:Nimelrian/baobab.git","clone_url":"https://github.com/Nimelrian/baobab.git","svn_url":"https://github.com/Nimelrian/baobab","homepage":"","size":1363,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Yomguithereal:master","ref":"master","sha":"3e6a08a6cd9b1a529f4d0a4d46a7016b5c82c095","user":{"login":"Yomguithereal","id":2571951,"avatar_url":"https://avatars.githubusercontent.com/u/2571951?v=3","gravatar_id":"","url":"https://api.github.com/users/Yomguithereal","html_url":"https://github.com/Yomguithereal","followers_url":"https://api.github.com/users/Yomguithereal/followers","following_url":"https://api.github.com/users/Yomguithereal/following{/other_user}","gists_url":"https://api.github.com/users/Yomguithereal/gists{/gist_id}","starred_url":"https://api.github.com/users/Yomguithereal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yomguithereal/subscriptions","organizations_url":"https://api.github.com/users/Yomguithereal/orgs","repos_url":"https://api.github.com/users/Yomguithereal/repos","events_url":"https://api.github.com/users/Yomguithereal/events{/privacy}","received_events_url":"https://api.github.com/users/Yomguithereal/received_events","type":"User","site_admin":false},"repo":{"id":27480700,"name":"baobab","full_name":"Yomguithereal/baobab","owner":{"login":"Yomguithereal","id":2571951,"avatar_url":"https://avatars.githubusercontent.com/u/2571951?v=3","gravatar_id":"","url":"https://api.github.com/users/Yomguithereal","html_url":"https://github.com/Yomguithereal","followers_url":"https://api.github.com/users/Yomguithereal/followers","following_url":"https://api.github.com/users/Yomguithereal/following{/other_user}","gists_url":"https://api.github.com/users/Yomguithereal/gists{/gist_id}","starred_url":"https://api.github.com/users/Yomguithereal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yomguithereal/subscriptions","organizations_url":"https://api.github.com/users/Yomguithereal/orgs","repos_url":"https://api.github.com/users/Yomguithereal/repos","events_url":"https://api.github.com/users/Yomguithereal/events{/privacy}","received_events_url":"https://api.github.com/users/Yomguithereal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Yomguithereal/baobab","description":"JavaScript persistent and optionally immutable data tree with cursors.","fork":false,"url":"https://api.github.com/repos/Yomguithereal/baobab","forks_url":"https://api.github.com/repos/Yomguithereal/baobab/forks","keys_url":"https://api.github.com/repos/Yomguithereal/baobab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yomguithereal/baobab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yomguithereal/baobab/teams","hooks_url":"https://api.github.com/repos/Yomguithereal/baobab/hooks","issue_events_url":"https://api.github.com/repos/Yomguithereal/baobab/issues/events{/number}","events_url":"https://api.github.com/repos/Yomguithereal/baobab/events","assignees_url":"https://api.github.com/repos/Yomguithereal/baobab/assignees{/user}","branches_url":"https://api.github.com/repos/Yomguithereal/baobab/branches{/branch}","tags_url":"https://api.github.com/repos/Yomguithereal/baobab/tags","blobs_url":"https://api.github.com/repos/Yomguithereal/baobab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yomguithereal/baobab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yomguithereal/baobab/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yomguithereal/baobab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yomguithereal/baobab/statuses/{sha}","languages_url":"https://api.github.com/repos/Yomguithereal/baobab/languages","stargazers_url":"https://api.github.com/repos/Yomguithereal/baobab/stargazers","contributors_url":"https://api.github.com/repos/Yomguithereal/baobab/contributors","subscribers_url":"https://api.github.com/repos/Yomguithereal/baobab/subscribers","subscription_url":"https://api.github.com/repos/Yomguithereal/baobab/subscription","commits_url":"https://api.github.com/repos/Yomguithereal/baobab/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yomguithereal/baobab/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yomguithereal/baobab/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yomguithereal/baobab/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yomguithereal/baobab/contents/{+path}","compare_url":"https://api.github.com/repos/Yomguithereal/baobab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yomguithereal/baobab/merges","archive_url":"https://api.github.com/repos/Yomguithereal/baobab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yomguithereal/baobab/downloads","issues_url":"https://api.github.com/repos/Yomguithereal/baobab/issues{/number}","pulls_url":"https://api.github.com/repos/Yomguithereal/baobab/pulls{/number}","milestones_url":"https://api.github.com/repos/Yomguithereal/baobab/milestones{/number}","notifications_url":"https://api.github.com/repos/Yomguithereal/baobab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yomguithereal/baobab/labels{/name}","releases_url":"https://api.github.com/repos/Yomguithereal/baobab/releases{/id}","deployments_url":"https://api.github.com/repos/Yomguithereal/baobab/deployments","created_at":"2014-12-03T10:00:42Z","updated_at":"2017-02-05T19:44:53Z","pushed_at":"2017-02-03T11:43:26Z","git_url":"git://github.com/Yomguithereal/baobab.git","ssh_url":"git@github.com:Yomguithereal/baobab.git","clone_url":"https://github.com/Yomguithereal/baobab.git","svn_url":"https://github.com/Yomguithereal/baobab","homepage":"","size":1357,"stargazers_count":2422,"watchers_count":2422,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":101,"mirror_url":null,"open_issues_count":45,"forks":101,"open_issues":45,"watchers":2422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Yomguithereal/baobab/pulls/473"},"html":{"href":"https://github.com/Yomguithereal/baobab/pull/473"},"issue":{"href":"https://api.github.com/repos/Yomguithereal/baobab/issues/473"},"comments":{"href":"https://api.github.com/repos/Yomguithereal/baobab/issues/473/comments"},"review_comments":{"href":"https://api.github.com/repos/Yomguithereal/baobab/pulls/473/comments"},"review_comment":{"href":"https://api.github.com/repos/Yomguithereal/baobab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Yomguithereal/baobab/pulls/473/commits"},"statuses":{"href":"https://api.github.com/repos/Yomguithereal/baobab/statuses/d28587d315de5dec2ccd2a02b8eb670acfbb5d21"}}}}
{"actor":{"display_login":"Nimelrian"}}