{"action":"created","issue":{"url":"https://api.github.com/repos/freeciv/freeciv-web/issues/58","repository_url":"https://api.github.com/repos/freeciv/freeciv-web","labels_url":"https://api.github.com/repos/freeciv/freeciv-web/issues/58/labels{/name}","comments_url":"https://api.github.com/repos/freeciv/freeciv-web/issues/58/comments","events_url":"https://api.github.com/repos/freeciv/freeciv-web/issues/58/events","html_url":"https://github.com/freeciv/freeciv-web/pull/58","id":203834460,"number":58,"title":"Cleanup servlet code","user":{"login":"adaxi","id":474682,"avatar_url":"https://avatars.githubusercontent.com/u/474682?v=3","gravatar_id":"","url":"https://api.github.com/users/adaxi","html_url":"https://github.com/adaxi","followers_url":"https://api.github.com/users/adaxi/followers","following_url":"https://api.github.com/users/adaxi/following{/other_user}","gists_url":"https://api.github.com/users/adaxi/gists{/gist_id}","starred_url":"https://api.github.com/users/adaxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adaxi/subscriptions","organizations_url":"https://api.github.com/users/adaxi/orgs","repos_url":"https://api.github.com/users/adaxi/repos","events_url":"https://api.github.com/users/adaxi/events{/privacy}","received_events_url":"https://api.github.com/users/adaxi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2017-01-28T22:02:44Z","updated_at":"2017-02-04T22:05:08Z","closed_at":"2017-01-28T22:23:44Z","pull_request":{"url":"https://api.github.com/repos/freeciv/freeciv-web/pulls/58","html_url":"https://github.com/freeciv/freeciv-web/pull/58","diff_url":"https://github.com/freeciv/freeciv-web/pull/58.diff","patch_url":"https://github.com/freeciv/freeciv-web/pull/58.patch"},"body":"Github can ignore [whitespace](https://github.com/blog/967-github-secrets) when showing diffs. It might be useful when reviewing this pull request.\r\n\r\nI used [Eclipse Copyright Tool](https://wiki.eclipse.org/Development_Resources/How_to_Use_Eclipse_Copyright_Tool) to fix the licences. It altered a bit the existing formatting, but on the other side it ensures that no file is forgotten.\r\n\r\nChanges:\r\n* Updated copyright dates\r\n* Added license where license was missing.\r\n* Removed useless @SuppressWarnings(\"unchecked\")\r\n* Replaced complex if condition with switch in CivclientLauncher\r\n* Shortened long lines for easier readability on smaller screens\r\n* Instead of building the query by concatenating strings now we use statement.setString\r\n* Reply with 405 when using the GET method instead of 200.\r\n* Renamed some variables to be compliant with Java conventions.\r\n* Indented code. Please ignore whitespaces for more readable diff (-w)\r\n* Removed duplicate code where possible. (see stats servlet)"},"comment":{"url":"https://api.github.com/repos/freeciv/freeciv-web/issues/comments/277481462","html_url":"https://github.com/freeciv/freeciv-web/pull/58#issuecomment-277481462","issue_url":"https://api.github.com/repos/freeciv/freeciv-web/issues/58","id":277481462,"user":{"login":"adaxi","id":474682,"avatar_url":"https://avatars.githubusercontent.com/u/474682?v=3","gravatar_id":"","url":"https://api.github.com/users/adaxi","html_url":"https://github.com/adaxi","followers_url":"https://api.github.com/users/adaxi/followers","following_url":"https://api.github.com/users/adaxi/following{/other_user}","gists_url":"https://api.github.com/users/adaxi/gists{/gist_id}","starred_url":"https://api.github.com/users/adaxi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adaxi/subscriptions","organizations_url":"https://api.github.com/users/adaxi/orgs","repos_url":"https://api.github.com/users/adaxi/repos","events_url":"https://api.github.com/users/adaxi/events{/privacy}","received_events_url":"https://api.github.com/users/adaxi/received_events","type":"User","site_admin":false},"created_at":"2017-02-04T22:05:07Z","updated_at":"2017-02-04T22:05:07Z","body":"Unfortunately there are [more](https://github.com/freeciv/freeciv-web/blob/40ae7d2d046020887892bd6781c7bab757e2371e/freeciv-web/src/main/webapp/meta/metaserver.php#L379), in this case the ```$host``` and ```$port``` are obtained from the $server_port variable.\r\n\r\nI am currently working on the rewrite, I am testing/re-learning some stuff. "}}
{"actor":{"display_login":"adaxi"}}