{"push_id":2036624170,"size":24,"distinct_size":24,"ref":"refs/heads/master","head":"ec5140600bad39a594c5d2d1799498fd98913de2","before":"ba09cc934580994577aa3c8df2d59d336c5cec56","commits":[{"sha":"2da7d9b8207d9c35d199734da75fa2bb15f326b6","author":{"name":"Anatoli Papirovski","email":"22690e18c069d80597e9be856c6d53bbad5ecaec@mac.com"},"message":"http2: near full http1 compatibility, add tests\n\nExtensive re-work of http1 compatibility layer based on tests in\nexpress, on-finished and finalhandler. Fix handling of HEAD\nmethod to match http1. Adjust write, end, etc. to call writeHead\nas in http1 and as expected by user-land modules. Add socket\nproxy that instead uses the Http2Stream for the vast majority of\nsocket interactions. Add and change tests to closer represent\nhttp1 behaviour.\n\nRefs: https://github.com/nodejs/node/pull/15633\nRefs: https://github.com/expressjs/express/tree/master/test\nRefs: https://github.com/jshttp/on-finished/blob/master/test/test.js\nRefs: https://github.com/pillarjs/finalhandler/blob/master/test/test.js\nPR-URL: https://github.com/nodejs/node/pull/15702\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/2da7d9b8207d9c35d199734da75fa2bb15f326b6"},{"sha":"4552cf774d7fa203e02a4735959edd333f7a3ca4","author":{"name":"tshemsedinov","email":"0c082b334686f85d285eb4402f637dcc7c62cf54@gmail.com"},"message":"doc: fix incorrect vm.createContext usage\n\nIn code example `vm.createContext` called with new operator by mistake.\nIt is not a constructor.\n\nPR-URL: https://github.com/nodejs/node/pull/16059\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Timothy Gu <timothygu99@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Minwoo Jung <minwoo@nodesource.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/4552cf774d7fa203e02a4735959edd333f7a3ca4"},{"sha":"1b358f1fde0efc83058e85c7767c4f78a8e6d723","author":{"name":"Pavel Pomerantsev","email":"92dd01f3f7294e72644d61176eab0cb46db36e95@gmail.com"},"message":"doc: fix: correctly use `public key` instead of `private key`\n\nAlthough, as docs mention, private keys can be used instead of\npublic keys, I presume that these parameter explanations\nshould be corrected.\n\nFixes: https://github.com/nodejs/node/issues/13633\nPR-URL: https://github.com/nodejs/node/pull/16038\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/1b358f1fde0efc83058e85c7767c4f78a8e6d723"},{"sha":"ce4903426dac9b0c851cf8dba2511e3eebd5c352","author":{"name":"Daniela Borges Matos de Carvalho","email":"cf6853110db814acfe783a8ad73a8987b6285e63@gmail.com"},"message":"doc: fix http2 API docs typos\n\nPR-URL: https://github.com/nodejs/node/pull/15778\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Lance Ball <lball@redhat.com>\nReviewed-By: Bryan English <bryan@bryanenglish.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/ce4903426dac9b0c851cf8dba2511e3eebd5c352"},{"sha":"d6031bc1c6f6b5b630790cf916bebcfb51a948b1","author":{"name":"Trivikram Kamat","email":"a7ef9d7ee81df78a0d707a3850845abe505431a5@gmail.com"},"message":"test: http2 client destroy tests in one file\n\nRefs: #14985\nPR-URL: https://github.com/nodejs/node/pull/15749\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/d6031bc1c6f6b5b630790cf916bebcfb51a948b1"},{"sha":"3aea4c884ba3b5fff1f497f1918be747a4aa3887","author":{"name":"Timothy Gu","email":"8a9025e79cb317a8810938f6a1886403da1e71c9@gmail.com"},"message":"src: fix ^ in stack trace with vm's columnOffset\n\nWhile VM module's columnOffset option does succeed in applying an offset\nto the column number in the stack trace, the wavy diagram printed does\nnot account for potential offsets, resulting in erroneous location of\n`^` in the first line of the script.\n\nBefore:\n\n```\n> vm.runInThisContext('throw new Error()', { columnOffset: 5 })\nevalmachine.<anonymous>:1\nthrow new Error()\n     ^\n\nError\n    at evalmachine.<anonymous>:1:12\n    at ContextifyScript.Script.runInThisContext (vm.js:44:33)\n    at Object.runInThisContext (vm.js:116:38)\n```\n\nAfter:\n\n```\n> vm.runInThisContext('throw new Error()', { columnOffset: 5 })\nevalmachine.<anonymous>:1\nthrow new Error()\n^\n\nError\n    at evalmachine.<anonymous>:1:12\n    at ContextifyScript.Script.runInThisContext (vm.js:50:33)\n    at Object.runInThisContext (vm.js:139:38)\n    at repl:1:4\n```\n\nPR-URL: https://github.com/nodejs/node/pull/15771\nRefs: https://github.com/tmpvar/jsdom/pull/2003\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Rich Trott <rtrott@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/3aea4c884ba3b5fff1f497f1918be747a4aa3887"},{"sha":"fabd618eef9a502eaad2d482f063f86bdd3f8d7e","author":{"name":"Trivikram Kamat","email":"a7ef9d7ee81df78a0d707a3850845abe505431a5@gmail.com"},"message":"test: http2 stored settings returned when present\n\nRefs: #14985\nPR-URL: https://github.com/nodejs/node/pull/15751\nReviewed-By: Matteo Collina <matteo.collina@gmail.com>\nReviewed-By: James M Snell <jasnell@gmail.com>\nReviewed-By: Luigi Pinca <luigipinca@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/fabd618eef9a502eaad2d482f063f86bdd3f8d7e"},{"sha":"baa156f39dce577704aeba308a49f12be39bb992","author":{"name":"Bruce Fletcher","email":"b14f86c04f981a908134f50052f7505d3f9b823f@nani.ca"},"message":"test: add common.fixtures to https-req-split\n\nReplaced readFileSync with fixtures.readKey.\n\nPR-URL: https://github.com/nodejs/node/pull/15801\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>\nReviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Rich Trott <rtrott@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/baa156f39dce577704aeba308a49f12be39bb992"},{"sha":"be2a5b323e331aaef2991c7d7004f2ec833123f0","author":{"name":"Erin Spiceland","email":"1a0800387a849b1d104eb6091d9fdde905256f8b@erin.codes"},"message":"deps: cherry-pick f4a2b7f3 from V8 upstream.\n\nOriginal commit message:\n    should ignore asyncTask* with null\n\n    In V8Debugger code we don't expect task_id == null, e.g.\n    asyncTaskStartedForStepping will trigger debug break on null as task_id.\n    Let's filter task_id == null out.\n\n    This issue is originally filed in Node.js:\n    https://github.com/nodejs/node/issues/15464\n\n    R=dgozman@chromium.org\n\n    Bug: none\n    Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel\n    Change-Id: Icc9f96105b3c91ee1b102d545a7817f7ee93394c\n    Reviewed-on: https://chromium-review.googlesource.com/695808\n    Reviewed-by: Dmitry Gozman <dgozman@chromium.org>\n    Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>\n    Cr-Commit-Position: refs/heads/master@{#48265}\n\nFixes https://github.com/nodejs/node/issues/15464\n\nPR-URL: https://github.com/nodejs/node/pull/16053\nReviewed-By: Myles Borins <myles.borins@gmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>\nReviewed-By: Michaël Zasso <mic.besace@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/be2a5b323e331aaef2991c7d7004f2ec833123f0"},{"sha":"d36433e1b6ce070026ccd14a341f7a564d58ad4b","author":{"name":"Greg Byram","email":"8952803a140aef085feef90060e9454201c5d910@gregbyram.com"},"message":"test: use fixtures.readKey in https-agent test\n\nPR-URL: https://github.com/nodejs/node/pull/15913\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/d36433e1b6ce070026ccd14a341f7a564d58ad4b"},{"sha":"e14fd570fdcbf1259f170847244697f7ce047605","author":{"name":"Chowdhurian","email":"dd13acd140d0ef3f3afe1777770f9b96fb69ca4e@gmail.com"},"message":"test: replace common.fixturesDir in test-exception\n\nReplace common.fixturesDir with usage of the common.fixtures module in\ntext-exception.js\n\nPR-URL: https://github.com/nodejs/node/pull/15964\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Michaël Zasso <targos@protonmail.com>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/e14fd570fdcbf1259f170847244697f7ce047605"},{"sha":"ee587f39ae44150e9105c7e401712e52cb9254fb","author":{"name":"Jonathan Eskew","email":"7bbfc0107ba358776f2a9b03d5c032ea92db4a03@amazon.com"},"message":"test: add tests of querystring benchmark\n\nPR-URL: https://github.com/nodejs/node/pull/16052\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Timothy Gu <timothygu99@gmail.com>\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/ee587f39ae44150e9105c7e401712e52cb9254fb"},{"sha":"1c97fa76f3e4f3832023a36f8c4b2eee1195fbbb","author":{"name":"James M. Greene","email":"e07c3dc6e62e981c0a58b9f6aefeb5d0c56ce1fe@gmail.com"},"message":"test: update 'fixturesDir' refs in a test file\n\nThis was a task from Code & Learn at NINA17.\n\nPR-URL: https://github.com/nodejs/node/pull/15824\nReviewed-By: Ryan Graham <r.m.graham@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/1c97fa76f3e4f3832023a36f8c4b2eee1195fbbb"},{"sha":"d2c0978831a863c854177c80a53e1039d04aa787","author":{"name":"Pooya Paridel","email":"4207c6a2f4cde421160466fa6c35015818c008aa@outlook.com"},"message":"test: replace fixturesDir with common.fixtures\n\nPR-URL: https://github.com/nodejs/node/pull/15837\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/d2c0978831a863c854177c80a53e1039d04aa787"},{"sha":"6e1948ea06b5413c493c744b9409e7c6ef60c958","author":{"name":"Paul Berry","email":"54f65660711c038b3360dd7288dc12347ae58ba3@firesnap.io"},"message":"test: replace fixturesDir with common.fixtures\n\nPR-URL: https://github.com/nodejs/node/pull/15973\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/6e1948ea06b5413c493c744b9409e7c6ef60c958"},{"sha":"d56f03caebfed3c29d0c5749e730fed126ab2b7f","author":{"name":"bitandbang","email":"9cf5caf6c36f5cccde8c73fad8894c958f4983da@bnb.im"},"message":"test: update fixturesDir to fixtures.readKey\n\nPR-URL: https://github.com/nodejs/node/pull/16016\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Refael Ackermann <refack@gmail.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/d56f03caebfed3c29d0c5749e730fed126ab2b7f"},{"sha":"09d8b3576fbe473608e11c5045f42bb1d8df6137","author":{"name":"Ruxandra Fediuc","email":"60d9cc4866a214cb985fece6e9c62a3aaf7a1bd3@gmail.com"},"message":"test: improve coverage for 'internal/errors'\n\nPR-URL: https://github.com/nodejs/node/pull/16055\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Evan Lucas <evanlucas@me.com>\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Yuta Hiroto <hello@about-hiroppy.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>\nReviewed-By: Anna Henningsen <anna@addaleax.net>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/09d8b3576fbe473608e11c5045f42bb1d8df6137"},{"sha":"5843b2c945c66d3c21541ae9d15b9fbd9dde6622","author":{"name":"Saeed H","email":"969c220951a58467fdc34a69244a06ab2d13767b@navarik.com"},"message":"test: remove messages in assert.strictEqual\n\nPR-URL: https://github.com/nodejs/node/pull/16014\nReviewed-By: Colin Ihrig <cjihrig@gmail.com>\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Tobias Nießen <tniessen@tnie.de>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/5843b2c945c66d3c21541ae9d15b9fbd9dde6622"},{"sha":"bdf711dc62cb662b9390cd3d0b42e1c50582380d","author":{"name":"rachelnicole","email":"345bd5a8319b9169dd808c5f15df2c22c8323ac0@gmail.com"},"message":"test: replace fixturesDir with common.fixtures\n\nPR-URL: https://github.com/nodejs/node/pull/16051\nReviewed-By: Joyee Cheung <joyeec9h3@gmail.com>\nReviewed-By: Ruben Bridgewater <ruben@bridgewater.de>\nReviewed-By: Refael Ackermann <refack@gmail.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/bdf711dc62cb662b9390cd3d0b42e1c50582380d"},{"sha":"e0122299cf4ee7d97ca826a8f68eb799a5a56fe7","author":{"name":"Rich Trott","email":"c1321c10e42359e7caa6e441829d03e9d30a4048@gmail.com"},"message":"doc: update style guide for markdown extension\n\nThere are no longer files in the repository that use the `.markdown`\nextension so remove mention of them.\n\nPR-URL: https://github.com/nodejs/node/pull/15786\nReviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>\nReviewed-By: Lance Ball <lball@redhat.com>\nReviewed-By: Gibson Fahnestock <gibfahn@gmail.com>\nReviewed-By: Richard Lau <riclau@uk.ibm.com>","distinct":true,"url":"https://api.github.com/repos/pkandathil/node/commits/e0122299cf4ee7d97ca826a8f68eb799a5a56fe7"}]}
{"actor":{"display_login":"pkandathil"}}