{"action":"created","issue":{"url":"https://api.github.com/repos/natecavanaugh/check-source-formatting/issues/12","repository_url":"https://api.github.com/repos/natecavanaugh/check-source-formatting","labels_url":"https://api.github.com/repos/natecavanaugh/check-source-formatting/issues/12/labels{/name}","comments_url":"https://api.github.com/repos/natecavanaugh/check-source-formatting/issues/12/comments","events_url":"https://api.github.com/repos/natecavanaugh/check-source-formatting/issues/12/events","html_url":"https://github.com/natecavanaugh/check-source-formatting/pull/12","id":139306881,"number":12,"title":"v2","user":{"login":"natecavanaugh","id":116871,"avatar_url":"https://avatars2.githubusercontent.com/u/116871?v=4","gravatar_id":"","url":"https://api.github.com/users/natecavanaugh","html_url":"https://github.com/natecavanaugh","followers_url":"https://api.github.com/users/natecavanaugh/followers","following_url":"https://api.github.com/users/natecavanaugh/following{/other_user}","gists_url":"https://api.github.com/users/natecavanaugh/gists{/gist_id}","starred_url":"https://api.github.com/users/natecavanaugh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natecavanaugh/subscriptions","organizations_url":"https://api.github.com/users/natecavanaugh/orgs","repos_url":"https://api.github.com/users/natecavanaugh/repos","events_url":"https://api.github.com/users/natecavanaugh/events{/privacy}","received_events_url":"https://api.github.com/users/natecavanaugh/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":30,"created_at":"2016-03-08T15:33:25Z","updated_at":"2017-08-22T17:21:57Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/natecavanaugh/check-source-formatting/pulls/12","html_url":"https://github.com/natecavanaugh/check-source-formatting/pull/12","diff_url":"https://github.com/natecavanaugh/check-source-formatting/pull/12.diff","patch_url":"https://github.com/natecavanaugh/check-source-formatting/pull/12.patch"},"body":"This is a pull request to track progress on the next version.\nHere's generally what I'm hoping to get done:\n- [x] Update ESLint and other dependencies to support ES6/7\n- [x] Add support for linting React code\n- [x] Allow projects/people to define their own config [1]\n- [x] Use PostCSS to parse (S)CSS files and run rules against the AST rather than REGEX statements run on each line\n\nNice to haves:\n- [ ] One I've wanted for a while was a visual difference between outright errors and warnings.\n\n[1] There is a little bit of danger here with allowing people to define their own config, in that they could have certain rules turned off that they shouldn't (whether locally, or globally), and having their PR fail because it has errors that should have been spotted.\nI have a few ideas for handling this. One idea would be to still show the error, but mask it in someway (whether greyed out, or some other mechanism) so that it doesn't appear directly as an error but that you still know your local config is not catching certain issues.\nIf I go with this one, it would be possible to hide those errors (in case there's just too much noise), but it would have to explicitly be done with a long format parameter of some kind.\n\nThe other option would be to just print a line after each file with something like:\n\n```\n4 errors and 5 warnings were ignored by local configuration.\n```\n\nor at the very bottom of the report:\n\n```\n10 errors and 12 warnings across 3 files were ignored by the local configuration.\nRun the program with --no-config-rules in order to view the errors inline\n```\n\nSome of that still needs to be thought through a bit more though.\n"},"comment":{"url":"https://api.github.com/repos/natecavanaugh/check-source-formatting/issues/comments/324094745","html_url":"https://github.com/natecavanaugh/check-source-formatting/pull/12#issuecomment-324094745","issue_url":"https://api.github.com/repos/natecavanaugh/check-source-formatting/issues/12","id":324094745,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-08-22T17:21:56Z","updated_at":"2017-08-22T17:21:56Z","body":"\n[![Coverage Status](https://coveralls.io/builds/12941960/badge)](https://coveralls.io/builds/12941960)\n\nCoverage remained the same at 100.0% when pulling **85328e8cae6e2d203e933e164ab18054dce78dc8 on v2** into **7b58936e1dd7d1a8277ef752e7340ac03481e9cd on master**.\n"}}
{"actor":{"display_login":"coveralls"}}