{"action":"created","comment":{"url":"https://api.github.com/repos/google/trillian/pulls/comments/108702889","pull_request_review_id":29751213,"id":108702889,"diff_hunk":"@@ -382,6 +390,21 @@ func checkInclusionProofTreeSizeOutOfRange(logID int64, client trillian.Trillian\n // proofs returned should match ones computed by the alternate Merkle Tree implementation, which differs\n // from what the log uses.\n func checkInclusionProofsAtIndex(index int64, logID int64, tree *merkle.InMemoryMerkleTree, client trillian.TrillianLogClient, params TestParameters) error {\n+\t// Get MerkleLeafHash to use in VerifyInclusionProof.","path":"integration/log.go","position":null,"original_position":30,"commit_id":"aae6c815f231ff19ae8a91af51adcceec6b9a727","original_commit_id":"b556ba6c60c9fddc6f3a191a8d3c93118f215318","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars2.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"I didn't see a local copy of the leaf hash. Please point it out if I'm missing it. \r\n\r\nIn the meantime, I've adjusted the test to compute the MerkleLeafHash after fetching the leaf value. ","created_at":"2017-03-29T15:10:52Z","updated_at":"2017-03-29T15:10:52Z","html_url":"https://github.com/google/trillian/pull/483#discussion_r108702889","pull_request_url":"https://api.github.com/repos/google/trillian/pulls/483","_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/comments/108702889"},"html":{"href":"https://github.com/google/trillian/pull/483#discussion_r108702889"},"pull_request":{"href":"https://api.github.com/repos/google/trillian/pulls/483"}}},"pull_request":{"url":"https://api.github.com/repos/google/trillian/pulls/483","id":112943287,"html_url":"https://github.com/google/trillian/pull/483","diff_url":"https://github.com/google/trillian/pull/483.diff","patch_url":"https://github.com/google/trillian/pull/483.patch","issue_url":"https://api.github.com/repos/google/trillian/issues/483","number":483,"state":"open","locked":false,"title":"Use inclusion proof verifier in integration test","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars2.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"body":"Strengthen integration test by doing a full inclusion and consistency proof verification. \r\n\r\nSimplify the test by removing checks that are done inside of the Merkle proof verifier.\r\n\r\nCloses #333","created_at":"2017-03-28T11:03:51Z","updated_at":"2017-03-29T15:10:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c91521d5f34d8be603c6ca61c55c4cf17d0a894a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/trillian/pulls/483/commits","review_comments_url":"https://api.github.com/repos/google/trillian/pulls/483/comments","review_comment_url":"https://api.github.com/repos/google/trillian/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/trillian/issues/483/comments","statuses_url":"https://api.github.com/repos/google/trillian/statuses/aae6c815f231ff19ae8a91af51adcceec6b9a727","head":{"label":"gdbelvin:fix-test","ref":"fix-test","sha":"aae6c815f231ff19ae8a91af51adcceec6b9a727","user":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars2.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"repo":{"id":79220930,"name":"trillian","full_name":"gdbelvin/trillian","owner":{"login":"gdbelvin","id":198478,"avatar_url":"https://avatars2.githubusercontent.com/u/198478?v=3","gravatar_id":"","url":"https://api.github.com/users/gdbelvin","html_url":"https://github.com/gdbelvin","followers_url":"https://api.github.com/users/gdbelvin/followers","following_url":"https://api.github.com/users/gdbelvin/following{/other_user}","gists_url":"https://api.github.com/users/gdbelvin/gists{/gist_id}","starred_url":"https://api.github.com/users/gdbelvin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdbelvin/subscriptions","organizations_url":"https://api.github.com/users/gdbelvin/orgs","repos_url":"https://api.github.com/users/gdbelvin/repos","events_url":"https://api.github.com/users/gdbelvin/events{/privacy}","received_events_url":"https://api.github.com/users/gdbelvin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gdbelvin/trillian","description":null,"fork":true,"url":"https://api.github.com/repos/gdbelvin/trillian","forks_url":"https://api.github.com/repos/gdbelvin/trillian/forks","keys_url":"https://api.github.com/repos/gdbelvin/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdbelvin/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdbelvin/trillian/teams","hooks_url":"https://api.github.com/repos/gdbelvin/trillian/hooks","issue_events_url":"https://api.github.com/repos/gdbelvin/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/gdbelvin/trillian/events","assignees_url":"https://api.github.com/repos/gdbelvin/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/gdbelvin/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/gdbelvin/trillian/tags","blobs_url":"https://api.github.com/repos/gdbelvin/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdbelvin/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdbelvin/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdbelvin/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdbelvin/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/gdbelvin/trillian/languages","stargazers_url":"https://api.github.com/repos/gdbelvin/trillian/stargazers","contributors_url":"https://api.github.com/repos/gdbelvin/trillian/contributors","subscribers_url":"https://api.github.com/repos/gdbelvin/trillian/subscribers","subscription_url":"https://api.github.com/repos/gdbelvin/trillian/subscription","commits_url":"https://api.github.com/repos/gdbelvin/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdbelvin/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdbelvin/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdbelvin/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdbelvin/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/gdbelvin/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdbelvin/trillian/merges","archive_url":"https://api.github.com/repos/gdbelvin/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdbelvin/trillian/downloads","issues_url":"https://api.github.com/repos/gdbelvin/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/gdbelvin/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/gdbelvin/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/gdbelvin/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdbelvin/trillian/labels{/name}","releases_url":"https://api.github.com/repos/gdbelvin/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/gdbelvin/trillian/deployments","created_at":"2017-01-17T11:27:31Z","updated_at":"2017-01-17T11:27:34Z","pushed_at":"2017-03-29T15:10:13Z","git_url":"git://github.com/gdbelvin/trillian.git","ssh_url":"git@github.com:gdbelvin/trillian.git","clone_url":"https://github.com/gdbelvin/trillian.git","svn_url":"https://github.com/gdbelvin/trillian","homepage":null,"size":3129,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"4500128cba70cfec20d074aad8e351722c90a672","user":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":58654489,"name":"trillian","full_name":"google/trillian","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars2.githubusercontent.com/u/1342004?v=3","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/trillian","description":"Trillian implements a Merkle tree whose contents are served from a data storage layer, to allow scalability to extremely large trees.","fork":false,"url":"https://api.github.com/repos/google/trillian","forks_url":"https://api.github.com/repos/google/trillian/forks","keys_url":"https://api.github.com/repos/google/trillian/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/trillian/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/trillian/teams","hooks_url":"https://api.github.com/repos/google/trillian/hooks","issue_events_url":"https://api.github.com/repos/google/trillian/issues/events{/number}","events_url":"https://api.github.com/repos/google/trillian/events","assignees_url":"https://api.github.com/repos/google/trillian/assignees{/user}","branches_url":"https://api.github.com/repos/google/trillian/branches{/branch}","tags_url":"https://api.github.com/repos/google/trillian/tags","blobs_url":"https://api.github.com/repos/google/trillian/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/trillian/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/trillian/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/trillian/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/trillian/statuses/{sha}","languages_url":"https://api.github.com/repos/google/trillian/languages","stargazers_url":"https://api.github.com/repos/google/trillian/stargazers","contributors_url":"https://api.github.com/repos/google/trillian/contributors","subscribers_url":"https://api.github.com/repos/google/trillian/subscribers","subscription_url":"https://api.github.com/repos/google/trillian/subscription","commits_url":"https://api.github.com/repos/google/trillian/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/trillian/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/trillian/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/trillian/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/trillian/contents/{+path}","compare_url":"https://api.github.com/repos/google/trillian/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/trillian/merges","archive_url":"https://api.github.com/repos/google/trillian/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/trillian/downloads","issues_url":"https://api.github.com/repos/google/trillian/issues{/number}","pulls_url":"https://api.github.com/repos/google/trillian/pulls{/number}","milestones_url":"https://api.github.com/repos/google/trillian/milestones{/number}","notifications_url":"https://api.github.com/repos/google/trillian/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/trillian/labels{/name}","releases_url":"https://api.github.com/repos/google/trillian/releases{/id}","deployments_url":"https://api.github.com/repos/google/trillian/deployments","created_at":"2016-05-12T15:37:35Z","updated_at":"2017-03-28T07:17:26Z","pushed_at":"2017-03-29T15:10:14Z","git_url":"git://github.com/google/trillian.git","ssh_url":"git@github.com:google/trillian.git","clone_url":"https://github.com/google/trillian.git","svn_url":"https://github.com/google/trillian","homepage":"","size":2991,"stargazers_count":264,"watchers_count":264,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"open_issues_count":38,"forks":42,"open_issues":38,"watchers":264,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/trillian/pulls/483"},"html":{"href":"https://github.com/google/trillian/pull/483"},"issue":{"href":"https://api.github.com/repos/google/trillian/issues/483"},"comments":{"href":"https://api.github.com/repos/google/trillian/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/google/trillian/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/google/trillian/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/trillian/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/google/trillian/statuses/aae6c815f231ff19ae8a91af51adcceec6b9a727"}}}}
{"actor":{"display_login":"gdbelvin"}}