{"action":"created","issue":{"url":"https://api.github.com/repos/cellml/libcellml/issues/188","repository_url":"https://api.github.com/repos/cellml/libcellml","labels_url":"https://api.github.com/repos/cellml/libcellml/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/cellml/libcellml/issues/188/comments","events_url":"https://api.github.com/repos/cellml/libcellml/issues/188/events","html_url":"https://github.com/cellml/libcellml/issues/188","id":256967533,"number":188,"title":"setImport and getImport.","user":{"login":"hsorby","id":778048,"avatar_url":"https://avatars1.githubusercontent.com/u/778048?v=4","gravatar_id":"","url":"https://api.github.com/users/hsorby","html_url":"https://github.com/hsorby","followers_url":"https://api.github.com/users/hsorby/followers","following_url":"https://api.github.com/users/hsorby/following{/other_user}","gists_url":"https://api.github.com/users/hsorby/gists{/gist_id}","starred_url":"https://api.github.com/users/hsorby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hsorby/subscriptions","organizations_url":"https://api.github.com/users/hsorby/orgs","repos_url":"https://api.github.com/users/hsorby/repos","events_url":"https://api.github.com/users/hsorby/events{/privacy}","received_events_url":"https://api.github.com/users/hsorby/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-09-12T08:56:44Z","updated_at":"2017-09-12T09:40:30Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"In issue #187 it was mentioned that the getImport and setImport functions and documentation was unclear as to what was going to happen.  Should we make this clearer?"},"comment":{"url":"https://api.github.com/repos/cellml/libcellml/issues/comments/328800143","html_url":"https://github.com/cellml/libcellml/issues/188#issuecomment-328800143","issue_url":"https://api.github.com/repos/cellml/libcellml/issues/188","id":328800143,"user":{"login":"nickerso","id":811244,"avatar_url":"https://avatars1.githubusercontent.com/u/811244?v=4","gravatar_id":"","url":"https://api.github.com/users/nickerso","html_url":"https://github.com/nickerso","followers_url":"https://api.github.com/users/nickerso/followers","following_url":"https://api.github.com/users/nickerso/following{/other_user}","gists_url":"https://api.github.com/users/nickerso/gists{/gist_id}","starred_url":"https://api.github.com/users/nickerso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickerso/subscriptions","organizations_url":"https://api.github.com/users/nickerso/orgs","repos_url":"https://api.github.com/users/nickerso/repos","events_url":"https://api.github.com/users/nickerso/events{/privacy}","received_events_url":"https://api.github.com/users/nickerso/received_events","type":"User","site_admin":false},"created_at":"2017-09-12T09:40:30Z","updated_at":"2017-09-12T09:40:30Z","author_association":"CONTRIBUTOR","body":"Just to clarify in my own mind: `(set|get)Import` is setting or getting the instance of an imported model to use (i.e., an `Import` not a `Model`); `(set|get)ImportReference` is setting a reference to the name of the entity in that instance of an imported model (typically these are both used via the `Component::setSourceComponent()` or `Units::setSourceUnits()` methods).\r\n\r\nThe need for having a handle to the `Import` is simply to ensure that we are correctly grouping imported components and units with the correct instance of an imported model. `(set|get)Import` makes sense to me as we are dealing with `Import`s, not models per se.\r\n\r\nI don't think the current documentation (see [here](http://autotest.bioeng.auckland.ac.nz/libcellml-buildbot/b88e0a16a54ddb76c6dec855971bdb7d371f8e73/dox/code/classlibcellml_1_1ImportedEntity.html#a2f07fa682bbd7965ce76779228c8d47c) for example) is particularly clear in this regard and my preference would be to clarify the documentation rather than changing the method names."}}
{"actor":{"display_login":"nickerso"}}