{"action":"created","comment":{"url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments/148577356","pull_request_review_id":73841965,"id":148577356,"diff_hunk":"@@ -65,6 +73,15 @@ internal void DeSerialisationFixes(StreamingContext like_i_could_care)\n             {\n                 throw new BadMetadataKraken(null, \"Install stanzas must only include one of file, find, or find_regexp directives\");\n             }\n+\n+            // Make sure only filter or include_only fields exist but not both at the same time\n+            var filterCount = new[] { filter, filter_regexp }.Count(i => i != null);\n+            var includeOnlyCount = new[] { include_only, include_only_regexp }.Count(i => i != null);\n+\n+            if (filterCount > 0 && includeOnlyCount > 0)\n+            {\n+                throw new BadMetadataKraken(null, \"Install stanzas can only contain filter or include_only directives, not both\");\n+            }","path":"Core/Types/ModuleInstallDescriptor.cs","position":36,"original_position":36,"commit_id":"c814698af549ac4ea58e6fa04b19e2087cc18731","original_commit_id":"c814698af549ac4ea58e6fa04b19e2087cc18731","user":{"login":"HebaruSan","id":1559108,"avatar_url":"https://avatars2.githubusercontent.com/u/1559108?v=4","gravatar_id":"","url":"https://api.github.com/users/HebaruSan","html_url":"https://github.com/HebaruSan","followers_url":"https://api.github.com/users/HebaruSan/followers","following_url":"https://api.github.com/users/HebaruSan/following{/other_user}","gists_url":"https://api.github.com/users/HebaruSan/gists{/gist_id}","starred_url":"https://api.github.com/users/HebaruSan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HebaruSan/subscriptions","organizations_url":"https://api.github.com/users/HebaruSan/orgs","repos_url":"https://api.github.com/users/HebaruSan/repos","events_url":"https://api.github.com/users/HebaruSan/events{/privacy}","received_events_url":"https://api.github.com/users/HebaruSan/received_events","type":"User","site_admin":false},"body":"I was thinking that if both match, that would be treated as an exclude.","created_at":"2017-11-02T15:57:28Z","updated_at":"2017-11-02T15:57:28Z","html_url":"https://github.com/KSP-CKAN/CKAN/pull/2170#discussion_r148577356","pull_request_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2170","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments/148577356"},"html":{"href":"https://github.com/KSP-CKAN/CKAN/pull/2170#discussion_r148577356"},"pull_request":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2170"}},"in_reply_to_id":148412663},"pull_request":{"url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2170","id":150162102,"html_url":"https://github.com/KSP-CKAN/CKAN/pull/2170","diff_url":"https://github.com/KSP-CKAN/CKAN/pull/2170.diff","patch_url":"https://github.com/KSP-CKAN/CKAN/pull/2170.patch","issue_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2170","number":2170,"state":"open","locked":false,"title":"Add include_only fields","user":{"login":"Olympic1","id":8020752,"avatar_url":"https://avatars1.githubusercontent.com/u/8020752?v=4","gravatar_id":"","url":"https://api.github.com/users/Olympic1","html_url":"https://github.com/Olympic1","followers_url":"https://api.github.com/users/Olympic1/followers","following_url":"https://api.github.com/users/Olympic1/following{/other_user}","gists_url":"https://api.github.com/users/Olympic1/gists{/gist_id}","starred_url":"https://api.github.com/users/Olympic1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olympic1/subscriptions","organizations_url":"https://api.github.com/users/Olympic1/orgs","repos_url":"https://api.github.com/users/Olympic1/repos","events_url":"https://api.github.com/users/Olympic1/events{/privacy}","received_events_url":"https://api.github.com/users/Olympic1/received_events","type":"User","site_admin":false},"body":"This PR adds two fields which practically work as negative filter/filter_regexp.\r\nAlso includes a test and changes to the schema to make sure there are only filter or include_only fields but never both.\r\nAlso added the new \"filters\" to the spec.\r\n\r\nCloses #228\r\nCloses #1577","created_at":"2017-11-01T22:26:51Z","updated_at":"2017-11-02T15:57:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"76af61a4cd9ba818b5b9019ecdb6587ef5d63912","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2170/commits","review_comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2170/comments","review_comment_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2170/comments","statuses_url":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/c814698af549ac4ea58e6fa04b19e2087cc18731","head":{"label":"Olympic1:include","ref":"include","sha":"c814698af549ac4ea58e6fa04b19e2087cc18731","user":{"login":"Olympic1","id":8020752,"avatar_url":"https://avatars1.githubusercontent.com/u/8020752?v=4","gravatar_id":"","url":"https://api.github.com/users/Olympic1","html_url":"https://github.com/Olympic1","followers_url":"https://api.github.com/users/Olympic1/followers","following_url":"https://api.github.com/users/Olympic1/following{/other_user}","gists_url":"https://api.github.com/users/Olympic1/gists{/gist_id}","starred_url":"https://api.github.com/users/Olympic1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olympic1/subscriptions","organizations_url":"https://api.github.com/users/Olympic1/orgs","repos_url":"https://api.github.com/users/Olympic1/repos","events_url":"https://api.github.com/users/Olympic1/events{/privacy}","received_events_url":"https://api.github.com/users/Olympic1/received_events","type":"User","site_admin":false},"repo":{"id":52618438,"name":"CKAN","full_name":"Olympic1/CKAN","owner":{"login":"Olympic1","id":8020752,"avatar_url":"https://avatars1.githubusercontent.com/u/8020752?v=4","gravatar_id":"","url":"https://api.github.com/users/Olympic1","html_url":"https://github.com/Olympic1","followers_url":"https://api.github.com/users/Olympic1/followers","following_url":"https://api.github.com/users/Olympic1/following{/other_user}","gists_url":"https://api.github.com/users/Olympic1/gists{/gist_id}","starred_url":"https://api.github.com/users/Olympic1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olympic1/subscriptions","organizations_url":"https://api.github.com/users/Olympic1/orgs","repos_url":"https://api.github.com/users/Olympic1/repos","events_url":"https://api.github.com/users/Olympic1/events{/privacy}","received_events_url":"https://api.github.com/users/Olympic1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Olympic1/CKAN","description":"The Comprehensive Kerbal Archive Network","fork":true,"url":"https://api.github.com/repos/Olympic1/CKAN","forks_url":"https://api.github.com/repos/Olympic1/CKAN/forks","keys_url":"https://api.github.com/repos/Olympic1/CKAN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Olympic1/CKAN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Olympic1/CKAN/teams","hooks_url":"https://api.github.com/repos/Olympic1/CKAN/hooks","issue_events_url":"https://api.github.com/repos/Olympic1/CKAN/issues/events{/number}","events_url":"https://api.github.com/repos/Olympic1/CKAN/events","assignees_url":"https://api.github.com/repos/Olympic1/CKAN/assignees{/user}","branches_url":"https://api.github.com/repos/Olympic1/CKAN/branches{/branch}","tags_url":"https://api.github.com/repos/Olympic1/CKAN/tags","blobs_url":"https://api.github.com/repos/Olympic1/CKAN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Olympic1/CKAN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Olympic1/CKAN/git/refs{/sha}","trees_url":"https://api.github.com/repos/Olympic1/CKAN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Olympic1/CKAN/statuses/{sha}","languages_url":"https://api.github.com/repos/Olympic1/CKAN/languages","stargazers_url":"https://api.github.com/repos/Olympic1/CKAN/stargazers","contributors_url":"https://api.github.com/repos/Olympic1/CKAN/contributors","subscribers_url":"https://api.github.com/repos/Olympic1/CKAN/subscribers","subscription_url":"https://api.github.com/repos/Olympic1/CKAN/subscription","commits_url":"https://api.github.com/repos/Olympic1/CKAN/commits{/sha}","git_commits_url":"https://api.github.com/repos/Olympic1/CKAN/git/commits{/sha}","comments_url":"https://api.github.com/repos/Olympic1/CKAN/comments{/number}","issue_comment_url":"https://api.github.com/repos/Olympic1/CKAN/issues/comments{/number}","contents_url":"https://api.github.com/repos/Olympic1/CKAN/contents/{+path}","compare_url":"https://api.github.com/repos/Olympic1/CKAN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Olympic1/CKAN/merges","archive_url":"https://api.github.com/repos/Olympic1/CKAN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Olympic1/CKAN/downloads","issues_url":"https://api.github.com/repos/Olympic1/CKAN/issues{/number}","pulls_url":"https://api.github.com/repos/Olympic1/CKAN/pulls{/number}","milestones_url":"https://api.github.com/repos/Olympic1/CKAN/milestones{/number}","notifications_url":"https://api.github.com/repos/Olympic1/CKAN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Olympic1/CKAN/labels{/name}","releases_url":"https://api.github.com/repos/Olympic1/CKAN/releases{/id}","deployments_url":"https://api.github.com/repos/Olympic1/CKAN/deployments","created_at":"2016-02-26T16:46:46Z","updated_at":"2017-10-15T22:50:10Z","pushed_at":"2017-11-01T22:19:52Z","git_url":"git://github.com/Olympic1/CKAN.git","ssh_url":"git@github.com:Olympic1/CKAN.git","clone_url":"https://github.com/Olympic1/CKAN.git","svn_url":"https://github.com/Olympic1/CKAN","homepage":"","size":24708,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KSP-CKAN:master","ref":"master","sha":"3ac3cf6d1411addb4a9a05f4d270b799e5c2865e","user":{"login":"KSP-CKAN","id":9023970,"avatar_url":"https://avatars0.githubusercontent.com/u/9023970?v=4","gravatar_id":"","url":"https://api.github.com/users/KSP-CKAN","html_url":"https://github.com/KSP-CKAN","followers_url":"https://api.github.com/users/KSP-CKAN/followers","following_url":"https://api.github.com/users/KSP-CKAN/following{/other_user}","gists_url":"https://api.github.com/users/KSP-CKAN/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-CKAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-CKAN/subscriptions","organizations_url":"https://api.github.com/users/KSP-CKAN/orgs","repos_url":"https://api.github.com/users/KSP-CKAN/repos","events_url":"https://api.github.com/users/KSP-CKAN/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-CKAN/received_events","type":"Organization","site_admin":false},"repo":{"id":23050594,"name":"CKAN","full_name":"KSP-CKAN/CKAN","owner":{"login":"KSP-CKAN","id":9023970,"avatar_url":"https://avatars0.githubusercontent.com/u/9023970?v=4","gravatar_id":"","url":"https://api.github.com/users/KSP-CKAN","html_url":"https://github.com/KSP-CKAN","followers_url":"https://api.github.com/users/KSP-CKAN/followers","following_url":"https://api.github.com/users/KSP-CKAN/following{/other_user}","gists_url":"https://api.github.com/users/KSP-CKAN/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-CKAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-CKAN/subscriptions","organizations_url":"https://api.github.com/users/KSP-CKAN/orgs","repos_url":"https://api.github.com/users/KSP-CKAN/repos","events_url":"https://api.github.com/users/KSP-CKAN/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-CKAN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KSP-CKAN/CKAN","description":"The Comprehensive Kerbal Archive Network","fork":false,"url":"https://api.github.com/repos/KSP-CKAN/CKAN","forks_url":"https://api.github.com/repos/KSP-CKAN/CKAN/forks","keys_url":"https://api.github.com/repos/KSP-CKAN/CKAN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KSP-CKAN/CKAN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KSP-CKAN/CKAN/teams","hooks_url":"https://api.github.com/repos/KSP-CKAN/CKAN/hooks","issue_events_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/events{/number}","events_url":"https://api.github.com/repos/KSP-CKAN/CKAN/events","assignees_url":"https://api.github.com/repos/KSP-CKAN/CKAN/assignees{/user}","branches_url":"https://api.github.com/repos/KSP-CKAN/CKAN/branches{/branch}","tags_url":"https://api.github.com/repos/KSP-CKAN/CKAN/tags","blobs_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/refs{/sha}","trees_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/{sha}","languages_url":"https://api.github.com/repos/KSP-CKAN/CKAN/languages","stargazers_url":"https://api.github.com/repos/KSP-CKAN/CKAN/stargazers","contributors_url":"https://api.github.com/repos/KSP-CKAN/CKAN/contributors","subscribers_url":"https://api.github.com/repos/KSP-CKAN/CKAN/subscribers","subscription_url":"https://api.github.com/repos/KSP-CKAN/CKAN/subscription","commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/commits{/sha}","git_commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/commits{/sha}","comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/comments{/number}","issue_comment_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/comments{/number}","contents_url":"https://api.github.com/repos/KSP-CKAN/CKAN/contents/{+path}","compare_url":"https://api.github.com/repos/KSP-CKAN/CKAN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KSP-CKAN/CKAN/merges","archive_url":"https://api.github.com/repos/KSP-CKAN/CKAN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KSP-CKAN/CKAN/downloads","issues_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues{/number}","pulls_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls{/number}","milestones_url":"https://api.github.com/repos/KSP-CKAN/CKAN/milestones{/number}","notifications_url":"https://api.github.com/repos/KSP-CKAN/CKAN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KSP-CKAN/CKAN/labels{/name}","releases_url":"https://api.github.com/repos/KSP-CKAN/CKAN/releases{/id}","deployments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/deployments","created_at":"2014-08-17T21:11:54Z","updated_at":"2017-11-01T12:21:19Z","pushed_at":"2017-11-01T22:26:52Z","git_url":"git://github.com/KSP-CKAN/CKAN.git","ssh_url":"git@github.com:KSP-CKAN/CKAN.git","clone_url":"https://github.com/KSP-CKAN/CKAN.git","svn_url":"https://github.com/KSP-CKAN/CKAN","homepage":"","size":24704,"stargazers_count":590,"watchers_count":590,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":184,"mirror_url":null,"archived":false,"open_issues_count":285,"forks":184,"open_issues":285,"watchers":590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2170"},"html":{"href":"https://github.com/KSP-CKAN/CKAN/pull/2170"},"issue":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2170"},"comments":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2170/comments"},"review_comments":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2170/comments"},"review_comment":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2170/commits"},"statuses":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/c814698af549ac4ea58e6fa04b19e2087cc18731"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"HebaruSan"}}