{"action":"created","comment":{"url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/comments/123137181","pull_request_review_id":45310829,"id":123137181,"diff_hunk":"@@ -1,17 +1,15 @@\n <%\n-   status_symbol = (criterion.to_s + '_status').to_sym\n-   justification_symbol = (criterion.to_s + '_justification').to_sym\n-   project_criterion_status = project[status_symbol]\n-   project_criterion_justification = project[justification_symbol] %>\n+ status_symbol = (criterion.to_s + '_status').to_sym\n+ project_criterion_status = project[status_symbol]\n+ criterion_result = project.get_criterion_result(criterion)\n \n-<% cache [criterion.to_s, criteria_level, is_disabled, locale,\n-          project_criterion_status, project_criterion_justification ] do\n-     criterion_result = project.get_criterion_result(criterion)\n-     passing_class = ''\n-      if criterion_result == :criterion_passing && is_disabled\n-       passing_class = ' criterion-passing'\n-     end\n-  %>\n+ cache ['buttons', criterion.to_s, criteria_level, is_disabled, locale,\n+        project_criterion_status ] do\n+   passing_class = ''\n+   if criterion_result == :criterion_passing && is_disabled\n+     passing_class = ' criterion-passing'\n+   end\n+%>","path":"app/views/projects/_status_chooser.html.erb","position":24,"original_position":24,"commit_id":"2cfdf1788caad6b22d3d835b7a11aefc72600ffb","original_commit_id":"2cfdf1788caad6b22d3d835b7a11aefc72600ffb","user":{"login":"david-a-wheeler","id":813150,"avatar_url":"https://avatars3.githubusercontent.com/u/813150?v=3","gravatar_id":"","url":"https://api.github.com/users/david-a-wheeler","html_url":"https://github.com/david-a-wheeler","followers_url":"https://api.github.com/users/david-a-wheeler/followers","following_url":"https://api.github.com/users/david-a-wheeler/following{/other_user}","gists_url":"https://api.github.com/users/david-a-wheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/david-a-wheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-a-wheeler/subscriptions","organizations_url":"https://api.github.com/users/david-a-wheeler/orgs","repos_url":"https://api.github.com/users/david-a-wheeler/repos","events_url":"https://api.github.com/users/david-a-wheeler/events{/privacy}","received_events_url":"https://api.github.com/users/david-a-wheeler/received_events","type":"User","site_admin":false},"body":":-).","created_at":"2017-06-21T01:42:58Z","updated_at":"2017-06-21T01:42:58Z","html_url":"https://github.com/coreinfrastructure/best-practices-badge/pull/847#discussion_r123137181","pull_request_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/847","_links":{"self":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/comments/123137181"},"html":{"href":"https://github.com/coreinfrastructure/best-practices-badge/pull/847#discussion_r123137181"},"pull_request":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/847"}}},"pull_request":{"url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/847","id":126653227,"html_url":"https://github.com/coreinfrastructure/best-practices-badge/pull/847","diff_url":"https://github.com/coreinfrastructure/best-practices-badge/pull/847.diff","patch_url":"https://github.com/coreinfrastructure/best-practices-badge/pull/847.patch","issue_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues/847","number":847,"state":"open","locked":false,"title":"Split up caches in status_chooser","user":{"login":"david-a-wheeler","id":813150,"avatar_url":"https://avatars3.githubusercontent.com/u/813150?v=3","gravatar_id":"","url":"https://api.github.com/users/david-a-wheeler","html_url":"https://github.com/david-a-wheeler","followers_url":"https://api.github.com/users/david-a-wheeler/followers","following_url":"https://api.github.com/users/david-a-wheeler/following{/other_user}","gists_url":"https://api.github.com/users/david-a-wheeler/gists{/gist_id}","starred_url":"https://api.github.com/users/david-a-wheeler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-a-wheeler/subscriptions","organizations_url":"https://api.github.com/users/david-a-wheeler/orgs","repos_url":"https://api.github.com/users/david-a-wheeler/repos","events_url":"https://api.github.com/users/david-a-wheeler/events{/privacy}","received_events_url":"https://api.github.com/users/david-a-wheeler/received_events","type":"User","site_admin":false},"body":"The status_chooser is a performance hotpoint in this application.\r\nSplit the caches into multiple caches, so its results are more\r\nlikely to be shared, and completely eliminate the use of\r\nthe justification text as a cache key\r\n(this text can be long, make it less than ideal as a cache key).\r\n\r\nSigned-off-by: David A. Wheeler <dwheeler@dwheeler.com>","created_at":"2017-06-20T23:47:12Z","updated_at":"2017-06-21T01:42:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"147e64fc41e6d49544eddd6cf625b7723b6f7b6d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/847/commits","review_comments_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/847/comments","review_comment_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues/847/comments","statuses_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/statuses/2cfdf1788caad6b22d3d835b7a11aefc72600ffb","head":{"label":"coreinfrastructure:split-cache-status","ref":"split-cache-status","sha":"2cfdf1788caad6b22d3d835b7a11aefc72600ffb","user":{"login":"coreinfrastructure","id":29407097,"avatar_url":"https://avatars2.githubusercontent.com/u/29407097?v=3","gravatar_id":"","url":"https://api.github.com/users/coreinfrastructure","html_url":"https://github.com/coreinfrastructure","followers_url":"https://api.github.com/users/coreinfrastructure/followers","following_url":"https://api.github.com/users/coreinfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/coreinfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/coreinfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreinfrastructure/subscriptions","organizations_url":"https://api.github.com/users/coreinfrastructure/orgs","repos_url":"https://api.github.com/users/coreinfrastructure/repos","events_url":"https://api.github.com/users/coreinfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/coreinfrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":39528049,"name":"best-practices-badge","full_name":"coreinfrastructure/best-practices-badge","owner":{"login":"coreinfrastructure","id":29407097,"avatar_url":"https://avatars2.githubusercontent.com/u/29407097?v=3","gravatar_id":"","url":"https://api.github.com/users/coreinfrastructure","html_url":"https://github.com/coreinfrastructure","followers_url":"https://api.github.com/users/coreinfrastructure/followers","following_url":"https://api.github.com/users/coreinfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/coreinfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/coreinfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreinfrastructure/subscriptions","organizations_url":"https://api.github.com/users/coreinfrastructure/orgs","repos_url":"https://api.github.com/users/coreinfrastructure/repos","events_url":"https://api.github.com/users/coreinfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/coreinfrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreinfrastructure/best-practices-badge","description":"Core Infrastructure Initiative Best Practices Badge","fork":false,"url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge","forks_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/forks","keys_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/teams","hooks_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/hooks","issue_events_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues/events{/number}","events_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/events","assignees_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/assignees{/user}","branches_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/branches{/branch}","tags_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/tags","blobs_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/statuses/{sha}","languages_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/languages","stargazers_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/stargazers","contributors_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/contributors","subscribers_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/subscribers","subscription_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/subscription","commits_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/contents/{+path}","compare_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/merges","archive_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/downloads","issues_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues{/number}","pulls_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls{/number}","milestones_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/milestones{/number}","notifications_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/labels{/name}","releases_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/releases{/id}","deployments_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/deployments","created_at":"2015-07-22T20:14:25Z","updated_at":"2017-06-20T13:03:36Z","pushed_at":"2017-06-20T23:47:12Z","git_url":"git://github.com/coreinfrastructure/best-practices-badge.git","ssh_url":"git@github.com:coreinfrastructure/best-practices-badge.git","clone_url":"https://github.com/coreinfrastructure/best-practices-badge.git","svn_url":"https://github.com/coreinfrastructure/best-practices-badge","homepage":"https://bestpractices.coreinfrastructure.org","size":17598,"stargazers_count":414,"watchers_count":414,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":86,"forks":68,"open_issues":86,"watchers":414,"default_branch":"master"}},"base":{"label":"coreinfrastructure:master","ref":"master","sha":"dfea6beacaa2d26eeba56b4f6dbba96e12fd695b","user":{"login":"coreinfrastructure","id":29407097,"avatar_url":"https://avatars2.githubusercontent.com/u/29407097?v=3","gravatar_id":"","url":"https://api.github.com/users/coreinfrastructure","html_url":"https://github.com/coreinfrastructure","followers_url":"https://api.github.com/users/coreinfrastructure/followers","following_url":"https://api.github.com/users/coreinfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/coreinfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/coreinfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreinfrastructure/subscriptions","organizations_url":"https://api.github.com/users/coreinfrastructure/orgs","repos_url":"https://api.github.com/users/coreinfrastructure/repos","events_url":"https://api.github.com/users/coreinfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/coreinfrastructure/received_events","type":"Organization","site_admin":false},"repo":{"id":39528049,"name":"best-practices-badge","full_name":"coreinfrastructure/best-practices-badge","owner":{"login":"coreinfrastructure","id":29407097,"avatar_url":"https://avatars2.githubusercontent.com/u/29407097?v=3","gravatar_id":"","url":"https://api.github.com/users/coreinfrastructure","html_url":"https://github.com/coreinfrastructure","followers_url":"https://api.github.com/users/coreinfrastructure/followers","following_url":"https://api.github.com/users/coreinfrastructure/following{/other_user}","gists_url":"https://api.github.com/users/coreinfrastructure/gists{/gist_id}","starred_url":"https://api.github.com/users/coreinfrastructure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreinfrastructure/subscriptions","organizations_url":"https://api.github.com/users/coreinfrastructure/orgs","repos_url":"https://api.github.com/users/coreinfrastructure/repos","events_url":"https://api.github.com/users/coreinfrastructure/events{/privacy}","received_events_url":"https://api.github.com/users/coreinfrastructure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreinfrastructure/best-practices-badge","description":"Core Infrastructure Initiative Best Practices Badge","fork":false,"url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge","forks_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/forks","keys_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/teams","hooks_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/hooks","issue_events_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues/events{/number}","events_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/events","assignees_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/assignees{/user}","branches_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/branches{/branch}","tags_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/tags","blobs_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/statuses/{sha}","languages_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/languages","stargazers_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/stargazers","contributors_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/contributors","subscribers_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/subscribers","subscription_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/subscription","commits_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/contents/{+path}","compare_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/merges","archive_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/downloads","issues_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues{/number}","pulls_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls{/number}","milestones_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/milestones{/number}","notifications_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/labels{/name}","releases_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/releases{/id}","deployments_url":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/deployments","created_at":"2015-07-22T20:14:25Z","updated_at":"2017-06-20T13:03:36Z","pushed_at":"2017-06-20T23:47:12Z","git_url":"git://github.com/coreinfrastructure/best-practices-badge.git","ssh_url":"git@github.com:coreinfrastructure/best-practices-badge.git","clone_url":"https://github.com/coreinfrastructure/best-practices-badge.git","svn_url":"https://github.com/coreinfrastructure/best-practices-badge","homepage":"https://bestpractices.coreinfrastructure.org","size":17598,"stargazers_count":414,"watchers_count":414,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"open_issues_count":86,"forks":68,"open_issues":86,"watchers":414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/847"},"html":{"href":"https://github.com/coreinfrastructure/best-practices-badge/pull/847"},"issue":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues/847"},"comments":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/issues/847/comments"},"review_comments":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/847/comments"},"review_comment":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/pulls/847/commits"},"statuses":{"href":"https://api.github.com/repos/coreinfrastructure/best-practices-badge/statuses/2cfdf1788caad6b22d3d835b7a11aefc72600ffb"}}}}
{"actor":{"display_login":"david-a-wheeler"}}