{"action":"created","comment":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/comments/146097981","pull_request_review_id":71000316,"id":146097981,"diff_hunk":"@@ -151,6 +151,18 @@ extern \"C\" {\n  * up until mpv_opengl_cb_uninit_gl() is called. If the name is not anything\n  * you know/expected, return NULL from the function.\n  *\n+ * * Windowing system scaling\n+ * ------------------------------------\n+ *\n+ * When using GL, sometimes GL rendering window is upscaled to display buffer.\n+ * Typically with drm where GL framebuffer can be upscaled at later stage.\n+ * In That case glMPGetNativeDisplay(\"opengl-cb\") should return the GL window\n+ * dimensions, that is 4 elements:\n+ * 0 : left coordinates of window (usually 0)\n+ * 1 : top coordinates of window (usually 0)\n+ * 2 : width of GL window\n+ * 3 : height of GL window\n+ *","path":"libmpv/opengl_cb.h","position":15,"original_position":15,"commit_id":"2d26d058b070808774a2347e176ff5ba7200fff9","original_commit_id":"2d26d058b070808774a2347e176ff5ba7200fff9","user":{"login":"LongChair","id":2814651,"avatar_url":"https://avatars2.githubusercontent.com/u/2814651?v=4","gravatar_id":"","url":"https://api.github.com/users/LongChair","html_url":"https://github.com/LongChair","followers_url":"https://api.github.com/users/LongChair/followers","following_url":"https://api.github.com/users/LongChair/following{/other_user}","gists_url":"https://api.github.com/users/LongChair/gists{/gist_id}","starred_url":"https://api.github.com/users/LongChair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LongChair/subscriptions","organizations_url":"https://api.github.com/users/LongChair/orgs","repos_url":"https://api.github.com/users/LongChair/repos","events_url":"https://api.github.com/users/LongChair/events{/privacy}","received_events_url":"https://api.github.com/users/LongChair/received_events","type":"User","site_admin":false},"body":"Making a struct is fine, but i have a few questions about that. if we make a struct for this one, i suppose it makes sense to make also a struct for the drm one ? i suppose it should be `drm-params` then ?\r\nWould these structs need to be expose in mpv headers when using it from third party app so that the interop native struct can be reused or should the thrid party app redefine it, and we only expose a `void *` and third party app would have to redefine it ? \r\nEither ways, what's the best place to define those structs ? `opengl__cb.h` ?","created_at":"2017-10-21T06:20:59Z","updated_at":"2017-10-21T06:20:59Z","html_url":"https://github.com/mpv-player/mpv/pull/5008#discussion_r146097981","pull_request_url":"https://api.github.com/repos/mpv-player/mpv/pulls/5008","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/comments/146097981"},"html":{"href":"https://github.com/mpv-player/mpv/pull/5008#discussion_r146097981"},"pull_request":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/5008"}},"in_reply_to_id":145937585},"pull_request":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/5008","id":147210915,"html_url":"https://github.com/mpv-player/mpv/pull/5008","diff_url":"https://github.com/mpv-player/mpv/pull/5008.diff","patch_url":"https://github.com/mpv-player/mpv/pull/5008.patch","issue_url":"https://api.github.com/repos/mpv-player/mpv/issues/5008","number":5008,"state":"open","locked":false,"title":"RFC : Add DRM_PRIME Format Handling with KMS / DRM Atomic.","user":{"login":"LongChair","id":2814651,"avatar_url":"https://avatars2.githubusercontent.com/u/2814651?v=4","gravatar_id":"","url":"https://api.github.com/users/LongChair","html_url":"https://github.com/LongChair","followers_url":"https://api.github.com/users/LongChair/followers","following_url":"https://api.github.com/users/LongChair/following{/other_user}","gists_url":"https://api.github.com/users/LongChair/gists{/gist_id}","starred_url":"https://api.github.com/users/LongChair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LongChair/subscriptions","organizations_url":"https://api.github.com/users/LongChair/orgs","repos_url":"https://api.github.com/users/LongChair/repos","events_url":"https://api.github.com/users/LongChair/events{/privacy}","received_events_url":"https://api.github.com/users/LongChair/received_events","type":"User","site_admin":false},"body":"This commit allows to use the AV_PIX_FMT_DRM_PRIME newly introduced format in ffmpeg that allows decoders to provide an AVDRMFrameDescriptor struct.\r\n\r\nThat struct holds dmabuf fds and information allowing zerocopy rendering using KMS / DRM Atomic.\r\n\r\nThis has been tested on RockChip ROCK64 device.\r\n\r\nI agree that my changes can be relicensed to LGPL 2.1 or later.\r\n","created_at":"2017-10-18T05:14:17Z","updated_at":"2017-10-21T06:20:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e39e5b91cfadd6ab633b9281eea736e73b2727fa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mpv-player/mpv/pulls/5008/commits","review_comments_url":"https://api.github.com/repos/mpv-player/mpv/pulls/5008/comments","review_comment_url":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/5008/comments","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/2d26d058b070808774a2347e176ff5ba7200fff9","head":{"label":"LongChair:rockchip-drmprime-drm","ref":"rockchip-drmprime-drm","sha":"2d26d058b070808774a2347e176ff5ba7200fff9","user":{"login":"LongChair","id":2814651,"avatar_url":"https://avatars2.githubusercontent.com/u/2814651?v=4","gravatar_id":"","url":"https://api.github.com/users/LongChair","html_url":"https://github.com/LongChair","followers_url":"https://api.github.com/users/LongChair/followers","following_url":"https://api.github.com/users/LongChair/following{/other_user}","gists_url":"https://api.github.com/users/LongChair/gists{/gist_id}","starred_url":"https://api.github.com/users/LongChair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LongChair/subscriptions","organizations_url":"https://api.github.com/users/LongChair/orgs","repos_url":"https://api.github.com/users/LongChair/repos","events_url":"https://api.github.com/users/LongChair/events{/privacy}","received_events_url":"https://api.github.com/users/LongChair/received_events","type":"User","site_admin":false},"repo":{"id":59396048,"name":"mpv","full_name":"LongChair/mpv","owner":{"login":"LongChair","id":2814651,"avatar_url":"https://avatars2.githubusercontent.com/u/2814651?v=4","gravatar_id":"","url":"https://api.github.com/users/LongChair","html_url":"https://github.com/LongChair","followers_url":"https://api.github.com/users/LongChair/followers","following_url":"https://api.github.com/users/LongChair/following{/other_user}","gists_url":"https://api.github.com/users/LongChair/gists{/gist_id}","starred_url":"https://api.github.com/users/LongChair/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LongChair/subscriptions","organizations_url":"https://api.github.com/users/LongChair/orgs","repos_url":"https://api.github.com/users/LongChair/repos","events_url":"https://api.github.com/users/LongChair/events{/privacy}","received_events_url":"https://api.github.com/users/LongChair/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LongChair/mpv","description":"Personal working copy of mpv","fork":true,"url":"https://api.github.com/repos/LongChair/mpv","forks_url":"https://api.github.com/repos/LongChair/mpv/forks","keys_url":"https://api.github.com/repos/LongChair/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LongChair/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LongChair/mpv/teams","hooks_url":"https://api.github.com/repos/LongChair/mpv/hooks","issue_events_url":"https://api.github.com/repos/LongChair/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/LongChair/mpv/events","assignees_url":"https://api.github.com/repos/LongChair/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/LongChair/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/LongChair/mpv/tags","blobs_url":"https://api.github.com/repos/LongChair/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LongChair/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LongChair/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/LongChair/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LongChair/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/LongChair/mpv/languages","stargazers_url":"https://api.github.com/repos/LongChair/mpv/stargazers","contributors_url":"https://api.github.com/repos/LongChair/mpv/contributors","subscribers_url":"https://api.github.com/repos/LongChair/mpv/subscribers","subscription_url":"https://api.github.com/repos/LongChair/mpv/subscription","commits_url":"https://api.github.com/repos/LongChair/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/LongChair/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/LongChair/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/LongChair/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/LongChair/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/LongChair/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LongChair/mpv/merges","archive_url":"https://api.github.com/repos/LongChair/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LongChair/mpv/downloads","issues_url":"https://api.github.com/repos/LongChair/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/LongChair/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/LongChair/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/LongChair/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LongChair/mpv/labels{/name}","releases_url":"https://api.github.com/repos/LongChair/mpv/releases{/id}","deployments_url":"https://api.github.com/repos/LongChair/mpv/deployments","created_at":"2016-05-22T05:11:11Z","updated_at":"2017-04-05T22:04:06Z","pushed_at":"2017-10-19T06:00:48Z","git_url":"git://github.com/LongChair/mpv.git","ssh_url":"git@github.com:LongChair/mpv.git","clone_url":"https://github.com/LongChair/mpv.git","svn_url":"https://github.com/LongChair/mpv","homepage":"https://github.com/mpv-player/mpv","size":84010,"stargazers_count":2,"watchers_count":2,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"mpv-player:master","ref":"master","sha":"d9e3bad500e69508ad904205a8ddf234abd3c874","user":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars0.githubusercontent.com/u/2550273?v=4","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"repo":{"id":6201092,"name":"mpv","full_name":"mpv-player/mpv","owner":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars0.githubusercontent.com/u/2550273?v=4","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mpv-player/mpv","description":"🎥 Video player based on MPlayer/mplayer2","fork":false,"url":"https://api.github.com/repos/mpv-player/mpv","forks_url":"https://api.github.com/repos/mpv-player/mpv/forks","keys_url":"https://api.github.com/repos/mpv-player/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpv-player/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpv-player/mpv/teams","hooks_url":"https://api.github.com/repos/mpv-player/mpv/hooks","issue_events_url":"https://api.github.com/repos/mpv-player/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/mpv-player/mpv/events","assignees_url":"https://api.github.com/repos/mpv-player/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/mpv-player/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/mpv-player/mpv/tags","blobs_url":"https://api.github.com/repos/mpv-player/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpv-player/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpv-player/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpv-player/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/mpv-player/mpv/languages","stargazers_url":"https://api.github.com/repos/mpv-player/mpv/stargazers","contributors_url":"https://api.github.com/repos/mpv-player/mpv/contributors","subscribers_url":"https://api.github.com/repos/mpv-player/mpv/subscribers","subscription_url":"https://api.github.com/repos/mpv-player/mpv/subscription","commits_url":"https://api.github.com/repos/mpv-player/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpv-player/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpv-player/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpv-player/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpv-player/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/mpv-player/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpv-player/mpv/merges","archive_url":"https://api.github.com/repos/mpv-player/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpv-player/mpv/downloads","issues_url":"https://api.github.com/repos/mpv-player/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/mpv-player/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/mpv-player/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/mpv-player/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpv-player/mpv/labels{/name}","releases_url":"https://api.github.com/repos/mpv-player/mpv/releases{/id}","deployments_url":"https://api.github.com/repos/mpv-player/mpv/deployments","created_at":"2012-10-13T08:08:44Z","updated_at":"2017-10-21T04:04:41Z","pushed_at":"2017-10-20T20:31:11Z","git_url":"git://github.com/mpv-player/mpv.git","ssh_url":"git@github.com:mpv-player/mpv.git","clone_url":"https://github.com/mpv-player/mpv.git","svn_url":"https://github.com/mpv-player/mpv","homepage":"https://mpv.io","size":85812,"stargazers_count":6488,"watchers_count":6488,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":840,"mirror_url":null,"archived":false,"open_issues_count":412,"forks":840,"open_issues":412,"watchers":6488,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/5008"},"html":{"href":"https://github.com/mpv-player/mpv/pull/5008"},"issue":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/5008"},"comments":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/5008/comments"},"review_comments":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/5008/comments"},"review_comment":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/5008/commits"},"statuses":{"href":"https://api.github.com/repos/mpv-player/mpv/statuses/2d26d058b070808774a2347e176ff5ba7200fff9"}},"author_association":"NONE"}}
{"actor":{"display_login":"LongChair"}}