{"action":"created","issue":{"url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/17","repository_url":"https://api.github.com/repos/JuliaReach/LazySets.jl","labels_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/17/comments","events_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/17/events","html_url":"https://github.com/JuliaReach/LazySets.jl/issues/17","id":270014622,"number":17,"title":"Turn mutable structs into normal (immutable) structs","user":{"login":"schillic","id":9656686,"avatar_url":"https://avatars2.githubusercontent.com/u/9656686?v=4","gravatar_id":"","url":"https://api.github.com/users/schillic","html_url":"https://github.com/schillic","followers_url":"https://api.github.com/users/schillic/followers","following_url":"https://api.github.com/users/schillic/following{/other_user}","gists_url":"https://api.github.com/users/schillic/gists{/gist_id}","starred_url":"https://api.github.com/users/schillic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schillic/subscriptions","organizations_url":"https://api.github.com/users/schillic/orgs","repos_url":"https://api.github.com/users/schillic/repos","events_url":"https://api.github.com/users/schillic/events{/privacy}","received_events_url":"https://api.github.com/users/schillic/received_events","type":"User","site_admin":false},"labels":[{"id":717494536,"url":"https://api.github.com/repos/JuliaReach/LazySets.jl/labels/performance","name":"performance","color":"428bca","default":false}],"state":"open","locked":false,"assignee":{"login":"schillic","id":9656686,"avatar_url":"https://avatars2.githubusercontent.com/u/9656686?v=4","gravatar_id":"","url":"https://api.github.com/users/schillic","html_url":"https://github.com/schillic","followers_url":"https://api.github.com/users/schillic/followers","following_url":"https://api.github.com/users/schillic/following{/other_user}","gists_url":"https://api.github.com/users/schillic/gists{/gist_id}","starred_url":"https://api.github.com/users/schillic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schillic/subscriptions","organizations_url":"https://api.github.com/users/schillic/orgs","repos_url":"https://api.github.com/users/schillic/repos","events_url":"https://api.github.com/users/schillic/events{/privacy}","received_events_url":"https://api.github.com/users/schillic/received_events","type":"User","site_admin":false},"assignees":[{"login":"schillic","id":9656686,"avatar_url":"https://avatars2.githubusercontent.com/u/9656686?v=4","gravatar_id":"","url":"https://api.github.com/users/schillic","html_url":"https://github.com/schillic","followers_url":"https://api.github.com/users/schillic/followers","following_url":"https://api.github.com/users/schillic/following{/other_user}","gists_url":"https://api.github.com/users/schillic/gists{/gist_id}","starred_url":"https://api.github.com/users/schillic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schillic/subscriptions","organizations_url":"https://api.github.com/users/schillic/orgs","repos_url":"https://api.github.com/users/schillic/repos","events_url":"https://api.github.com/users/schillic/events{/privacy}","received_events_url":"https://api.github.com/users/schillic/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-10-31T15:56:57Z","updated_at":"2017-11-02T14:19:41Z","closed_at":null,"author_association":"OWNER","body":"Just need to review where we actually use mutability and otherwise change it..."},"comment":{"url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/comments/341435818","html_url":"https://github.com/JuliaReach/LazySets.jl/issues/17#issuecomment-341435818","issue_url":"https://api.github.com/repos/JuliaReach/LazySets.jl/issues/17","id":341435818,"user":{"login":"mforets","id":12424594,"avatar_url":"https://avatars3.githubusercontent.com/u/12424594?v=4","gravatar_id":"","url":"https://api.github.com/users/mforets","html_url":"https://github.com/mforets","followers_url":"https://api.github.com/users/mforets/followers","following_url":"https://api.github.com/users/mforets/following{/other_user}","gists_url":"https://api.github.com/users/mforets/gists{/gist_id}","starred_url":"https://api.github.com/users/mforets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mforets/subscriptions","organizations_url":"https://api.github.com/users/mforets/orgs","repos_url":"https://api.github.com/users/mforets/repos","events_url":"https://api.github.com/users/mforets/events{/privacy}","received_events_url":"https://api.github.com/users/mforets/received_events","type":"User","site_admin":false},"created_at":"2017-11-02T14:19:41Z","updated_at":"2017-11-02T14:19:41Z","author_association":"COLLABORATOR","body":">  If we remove the mutable, we may still modify the array; we are only not allowed to assign a new array anymore, which I think is fine (more docs here).\r\n\r\ngood point, let's do that.\r\n\r\n> I expect that in Polyhedron.jl the dimension dim should not change.\r\n\r\nyes. we wanted `dim` to be the ambient dimension, i.e. even this is square patch in 3d-space\r\n\r\n> The only place where I am not confident that the change is save is in HPolygonOpt.jl: Do we want to be able to modify the field ind?\r\n\r\nyes, i think that `ind` should be modified because it is updated at each iteration. @viryfrederic  do you agree?\r\n\r\n> One more thing: We have one occurrence of type, which should probably also become a struct:\r\n\r\nyes we should update that for future versions"}}
{"actor":{"display_login":"mforets"}}