{"action":"created","comment":{"url":"https://api.github.com/repos/seqan/seqan/pulls/comments/132959333","pull_request_review_id":56088636,"id":132959333,"diff_hunk":"@@ -92,95 +143,93 @@ class DPMatrixNavigator_<DPMatrix_<TValue, FullDPMatrix>, DPTraceMatrix<TTraceFl\n // ----------------------------------------------------------------------------\n \n // Initializes the navigator for unbanded alignments.\n-template <typename TValue, typename TTraceFlag>\n-inline void\n-_init(DPMatrixNavigator_<DPMatrix_<TValue, FullDPMatrix>, DPTraceMatrix<TTraceFlag>, NavigateColumnWise> & navigator,\n-      DPMatrix_<TValue, FullDPMatrix> & dpMatrix,\n-      DPBandConfig<BandOff> const &)\n-{\n-    if (IsSameType<TTraceFlag, TracebackOff>::VALUE)\n-        return;  // Leave navigator uninitialized because it is never used.\n-\n-    navigator._ptrDataContainer = &dpMatrix;\n-    navigator._activeColIterator = begin(dpMatrix, Standard());\n-    navigator._laneLeap = 1;\n-    assignValue(navigator._activeColIterator, TValue());\n-}\n+// template <typename TValue, typename TTraceFlag>","path":"include/seqan/align/dp_matrix_navigator_trace_matrix.h","position":87,"original_position":87,"commit_id":"4ce0aac4b5c79ec552b4b46d7f1f3ab9faf4a6dd","original_commit_id":"4ce0aac4b5c79ec552b4b46d7f1f3ab9faf4a6dd","user":{"login":"rrahn","id":1529364,"avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"body":"remove comments","created_at":"2017-08-14T14:08:10Z","updated_at":"2017-08-14T14:08:10Z","html_url":"https://github.com/seqan/seqan/pull/2106#discussion_r132959333","pull_request_url":"https://api.github.com/repos/seqan/seqan/pulls/2106","_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan/pulls/comments/132959333"},"html":{"href":"https://github.com/seqan/seqan/pull/2106#discussion_r132959333"},"pull_request":{"href":"https://api.github.com/repos/seqan/seqan/pulls/2106"}}},"pull_request":{"url":"https://api.github.com/repos/seqan/seqan/pulls/2106","id":135232828,"html_url":"https://github.com/seqan/seqan/pull/2106","diff_url":"https://github.com/seqan/seqan/pull/2106.diff","patch_url":"https://github.com/seqan/seqan/pull/2106.patch","issue_url":"https://api.github.com/repos/seqan/seqan/issues/2106","number":2106,"state":"open","locked":false,"title":"Improvement of DP code","user":{"login":"rrahn","id":1529364,"avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"body":"Refactors lots of internal structures of the DP algorithm to gain speedups for the alignment code.\r\n\r\n## Overview\r\n\r\n- Refactors the dp matrix navigator implementations by reducing lots of copied code.\r\n- Adds cache cells from outside to gain higher performance.\r\n- Refactors the recursion implementations for affine and linear gaps.\r\n- Changes the internal `_computeUnbanded...` and `_computeBanded...` to a common interface via tag dispatching\r\n- Adapts all tests\r\n- Fixes all overloads of `_computeCell...` or `_computeScore...` functions to new interface.","created_at":"2017-08-10T22:04:52Z","updated_at":"2017-08-14T14:08:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e97548988491b7198ca25a27ea56432f7498f80","assignee":{"login":"h-2","id":2996863,"avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false},"assignees":[{"login":"h-2","id":2996863,"avatar_url":"https://avatars2.githubusercontent.com/u/2996863?v=4","gravatar_id":"","url":"https://api.github.com/users/h-2","html_url":"https://github.com/h-2","followers_url":"https://api.github.com/users/h-2/followers","following_url":"https://api.github.com/users/h-2/following{/other_user}","gists_url":"https://api.github.com/users/h-2/gists{/gist_id}","starred_url":"https://api.github.com/users/h-2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h-2/subscriptions","organizations_url":"https://api.github.com/users/h-2/orgs","repos_url":"https://api.github.com/users/h-2/repos","events_url":"https://api.github.com/users/h-2/events{/privacy}","received_events_url":"https://api.github.com/users/h-2/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/seqan/seqan/pulls/2106/commits","review_comments_url":"https://api.github.com/repos/seqan/seqan/pulls/2106/comments","review_comment_url":"https://api.github.com/repos/seqan/seqan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/seqan/seqan/issues/2106/comments","statuses_url":"https://api.github.com/repos/seqan/seqan/statuses/4ce0aac4b5c79ec552b4b46d7f1f3ab9faf4a6dd","head":{"label":"rrahn:feature/dp_improvement","ref":"feature/dp_improvement","sha":"4ce0aac4b5c79ec552b4b46d7f1f3ab9faf4a6dd","user":{"login":"rrahn","id":1529364,"avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"repo":{"id":14363387,"name":"seqan","full_name":"rrahn/seqan","owner":{"login":"rrahn","id":1529364,"avatar_url":"https://avatars2.githubusercontent.com/u/1529364?v=4","gravatar_id":"","url":"https://api.github.com/users/rrahn","html_url":"https://github.com/rrahn","followers_url":"https://api.github.com/users/rrahn/followers","following_url":"https://api.github.com/users/rrahn/following{/other_user}","gists_url":"https://api.github.com/users/rrahn/gists{/gist_id}","starred_url":"https://api.github.com/users/rrahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rrahn/subscriptions","organizations_url":"https://api.github.com/users/rrahn/orgs","repos_url":"https://api.github.com/users/rrahn/repos","events_url":"https://api.github.com/users/rrahn/events{/privacy}","received_events_url":"https://api.github.com/users/rrahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rrahn/seqan","description":"Fork of the SeqAn repository under https://github.com/seqan/seqan ","fork":true,"url":"https://api.github.com/repos/rrahn/seqan","forks_url":"https://api.github.com/repos/rrahn/seqan/forks","keys_url":"https://api.github.com/repos/rrahn/seqan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rrahn/seqan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rrahn/seqan/teams","hooks_url":"https://api.github.com/repos/rrahn/seqan/hooks","issue_events_url":"https://api.github.com/repos/rrahn/seqan/issues/events{/number}","events_url":"https://api.github.com/repos/rrahn/seqan/events","assignees_url":"https://api.github.com/repos/rrahn/seqan/assignees{/user}","branches_url":"https://api.github.com/repos/rrahn/seqan/branches{/branch}","tags_url":"https://api.github.com/repos/rrahn/seqan/tags","blobs_url":"https://api.github.com/repos/rrahn/seqan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rrahn/seqan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rrahn/seqan/git/refs{/sha}","trees_url":"https://api.github.com/repos/rrahn/seqan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rrahn/seqan/statuses/{sha}","languages_url":"https://api.github.com/repos/rrahn/seqan/languages","stargazers_url":"https://api.github.com/repos/rrahn/seqan/stargazers","contributors_url":"https://api.github.com/repos/rrahn/seqan/contributors","subscribers_url":"https://api.github.com/repos/rrahn/seqan/subscribers","subscription_url":"https://api.github.com/repos/rrahn/seqan/subscription","commits_url":"https://api.github.com/repos/rrahn/seqan/commits{/sha}","git_commits_url":"https://api.github.com/repos/rrahn/seqan/git/commits{/sha}","comments_url":"https://api.github.com/repos/rrahn/seqan/comments{/number}","issue_comment_url":"https://api.github.com/repos/rrahn/seqan/issues/comments{/number}","contents_url":"https://api.github.com/repos/rrahn/seqan/contents/{+path}","compare_url":"https://api.github.com/repos/rrahn/seqan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rrahn/seqan/merges","archive_url":"https://api.github.com/repos/rrahn/seqan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rrahn/seqan/downloads","issues_url":"https://api.github.com/repos/rrahn/seqan/issues{/number}","pulls_url":"https://api.github.com/repos/rrahn/seqan/pulls{/number}","milestones_url":"https://api.github.com/repos/rrahn/seqan/milestones{/number}","notifications_url":"https://api.github.com/repos/rrahn/seqan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rrahn/seqan/labels{/name}","releases_url":"https://api.github.com/repos/rrahn/seqan/releases{/id}","deployments_url":"https://api.github.com/repos/rrahn/seqan/deployments","created_at":"2013-11-13T12:31:03Z","updated_at":"2016-10-28T07:43:39Z","pushed_at":"2017-08-14T13:26:33Z","git_url":"git://github.com/rrahn/seqan.git","ssh_url":"git@github.com:rrahn/seqan.git","clone_url":"https://github.com/rrahn/seqan.git","svn_url":"https://github.com/rrahn/seqan","homepage":"","size":152230,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":0,"forks":2,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"seqan:develop","ref":"develop","sha":"39e5efc488e5652e061b16399b1625676686ca3d","user":{"login":"seqan","id":1752144,"avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"repo":{"id":6383869,"name":"seqan","full_name":"seqan/seqan","owner":{"login":"seqan","id":1752144,"avatar_url":"https://avatars2.githubusercontent.com/u/1752144?v=4","gravatar_id":"","url":"https://api.github.com/users/seqan","html_url":"https://github.com/seqan","followers_url":"https://api.github.com/users/seqan/followers","following_url":"https://api.github.com/users/seqan/following{/other_user}","gists_url":"https://api.github.com/users/seqan/gists{/gist_id}","starred_url":"https://api.github.com/users/seqan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seqan/subscriptions","organizations_url":"https://api.github.com/users/seqan/orgs","repos_url":"https://api.github.com/users/seqan/repos","events_url":"https://api.github.com/users/seqan/events{/privacy}","received_events_url":"https://api.github.com/users/seqan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/seqan/seqan","description":"SeqAn's official repository.","fork":false,"url":"https://api.github.com/repos/seqan/seqan","forks_url":"https://api.github.com/repos/seqan/seqan/forks","keys_url":"https://api.github.com/repos/seqan/seqan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seqan/seqan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seqan/seqan/teams","hooks_url":"https://api.github.com/repos/seqan/seqan/hooks","issue_events_url":"https://api.github.com/repos/seqan/seqan/issues/events{/number}","events_url":"https://api.github.com/repos/seqan/seqan/events","assignees_url":"https://api.github.com/repos/seqan/seqan/assignees{/user}","branches_url":"https://api.github.com/repos/seqan/seqan/branches{/branch}","tags_url":"https://api.github.com/repos/seqan/seqan/tags","blobs_url":"https://api.github.com/repos/seqan/seqan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seqan/seqan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seqan/seqan/git/refs{/sha}","trees_url":"https://api.github.com/repos/seqan/seqan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seqan/seqan/statuses/{sha}","languages_url":"https://api.github.com/repos/seqan/seqan/languages","stargazers_url":"https://api.github.com/repos/seqan/seqan/stargazers","contributors_url":"https://api.github.com/repos/seqan/seqan/contributors","subscribers_url":"https://api.github.com/repos/seqan/seqan/subscribers","subscription_url":"https://api.github.com/repos/seqan/seqan/subscription","commits_url":"https://api.github.com/repos/seqan/seqan/commits{/sha}","git_commits_url":"https://api.github.com/repos/seqan/seqan/git/commits{/sha}","comments_url":"https://api.github.com/repos/seqan/seqan/comments{/number}","issue_comment_url":"https://api.github.com/repos/seqan/seqan/issues/comments{/number}","contents_url":"https://api.github.com/repos/seqan/seqan/contents/{+path}","compare_url":"https://api.github.com/repos/seqan/seqan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seqan/seqan/merges","archive_url":"https://api.github.com/repos/seqan/seqan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seqan/seqan/downloads","issues_url":"https://api.github.com/repos/seqan/seqan/issues{/number}","pulls_url":"https://api.github.com/repos/seqan/seqan/pulls{/number}","milestones_url":"https://api.github.com/repos/seqan/seqan/milestones{/number}","notifications_url":"https://api.github.com/repos/seqan/seqan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seqan/seqan/labels{/name}","releases_url":"https://api.github.com/repos/seqan/seqan/releases{/id}","deployments_url":"https://api.github.com/repos/seqan/seqan/deployments","created_at":"2012-10-25T08:02:15Z","updated_at":"2017-08-08T20:37:03Z","pushed_at":"2017-08-14T13:28:10Z","git_url":"git://github.com/seqan/seqan.git","ssh_url":"git@github.com:seqan/seqan.git","clone_url":"https://github.com/seqan/seqan.git","svn_url":"https://github.com/seqan/seqan","homepage":"https://www.seqan.de","size":150884,"stargazers_count":222,"watchers_count":222,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"open_issues_count":172,"forks":110,"open_issues":172,"watchers":222,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/seqan/seqan/pulls/2106"},"html":{"href":"https://github.com/seqan/seqan/pull/2106"},"issue":{"href":"https://api.github.com/repos/seqan/seqan/issues/2106"},"comments":{"href":"https://api.github.com/repos/seqan/seqan/issues/2106/comments"},"review_comments":{"href":"https://api.github.com/repos/seqan/seqan/pulls/2106/comments"},"review_comment":{"href":"https://api.github.com/repos/seqan/seqan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/seqan/seqan/pulls/2106/commits"},"statuses":{"href":"https://api.github.com/repos/seqan/seqan/statuses/4ce0aac4b5c79ec552b4b46d7f1f3ab9faf4a6dd"}}}}
{"actor":{"display_login":"rrahn"}}