{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/cli/pulls/comments/152443835","pull_request_review_id":78307436,"id":152443835,"diff_hunk":"@@ -0,0 +1,28 @@\n+﻿// Copyright (c) .NET Foundation and contributors. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+using System.IO;\n+\n+namespace Microsoft.DotNet.ExecutablePackageObtainer\n+{\n+    internal class PackageVersion\n+    {\n+        public PackageVersion(string packageVersion)\n+        {\n+            if (packageVersion == null)\n+            {\n+                Value = Path.GetRandomFileName();\n+                IsPlaceHolder = true;\n+            }\n+            else\n+            {\n+                Value = packageVersion;\n+                IsPlaceHolder = false;\n+            }\n+        }\n+\n+        public bool IsPlaceHolder { get; }","path":"src/dotnet/ExecutablePackageObtainer/PackageVersion.cs","position":null,"original_position":24,"commit_id":"13a5d064636b372530227eff1be3419210fd09ac","original_commit_id":"3a8374c3026f3dd9bc2d9fe376526f43d126ff53","user":{"login":"wli3","id":6993335,"avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"body":"Fixed","created_at":"2017-11-22T00:54:16Z","updated_at":"2017-11-22T00:54:16Z","html_url":"https://github.com/dotnet/cli/pull/8035#discussion_r152443835","pull_request_url":"https://api.github.com/repos/dotnet/cli/pulls/8035","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments/152443835"},"html":{"href":"https://github.com/dotnet/cli/pull/8035#discussion_r152443835"},"pull_request":{"href":"https://api.github.com/repos/dotnet/cli/pulls/8035"}},"in_reply_to_id":152377561},"pull_request":{"url":"https://api.github.com/repos/dotnet/cli/pulls/8035","id":153094770,"html_url":"https://github.com/dotnet/cli/pull/8035","diff_url":"https://github.com/dotnet/cli/pull/8035.diff","patch_url":"https://github.com/dotnet/cli/pull/8035.patch","issue_url":"https://api.github.com/repos/dotnet/cli/issues/8035","number":8035,"state":"open","locked":false,"title":"Global tools package obtain","user":{"login":"wli3","id":6993335,"avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"body":"This is a model. It is not used by dotnet.dll yet for easy code review. Given a tools package id, it can create a fake project and restore to correct folder\r\n\r\nIncludes:\r\n- DI, aka no circular dependency of commands\r\n- Parser of config XML\r\n- I try to create test nupkg at build time, so I can run test and debug\r\neasily with VSCode. The code is in test csproj.","created_at":"2017-11-16T16:54:48Z","updated_at":"2017-11-22T00:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a393998757523e26b0d41ea3691ac28937092d3e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dsplaisted","id":145043,"avatar_url":"https://avatars3.githubusercontent.com/u/145043?v=4","gravatar_id":"","url":"https://api.github.com/users/dsplaisted","html_url":"https://github.com/dsplaisted","followers_url":"https://api.github.com/users/dsplaisted/followers","following_url":"https://api.github.com/users/dsplaisted/following{/other_user}","gists_url":"https://api.github.com/users/dsplaisted/gists{/gist_id}","starred_url":"https://api.github.com/users/dsplaisted/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsplaisted/subscriptions","organizations_url":"https://api.github.com/users/dsplaisted/orgs","repos_url":"https://api.github.com/users/dsplaisted/repos","events_url":"https://api.github.com/users/dsplaisted/events{/privacy}","received_events_url":"https://api.github.com/users/dsplaisted/received_events","type":"User","site_admin":false},{"login":"tannergooding","id":10487869,"avatar_url":"https://avatars3.githubusercontent.com/u/10487869?v=4","gravatar_id":"","url":"https://api.github.com/users/tannergooding","html_url":"https://github.com/tannergooding","followers_url":"https://api.github.com/users/tannergooding/followers","following_url":"https://api.github.com/users/tannergooding/following{/other_user}","gists_url":"https://api.github.com/users/tannergooding/gists{/gist_id}","starred_url":"https://api.github.com/users/tannergooding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tannergooding/subscriptions","organizations_url":"https://api.github.com/users/tannergooding/orgs","repos_url":"https://api.github.com/users/tannergooding/repos","events_url":"https://api.github.com/users/tannergooding/events{/privacy}","received_events_url":"https://api.github.com/users/tannergooding/received_events","type":"User","site_admin":false},{"login":"johnbeisner","id":24683167,"avatar_url":"https://avatars0.githubusercontent.com/u/24683167?v=4","gravatar_id":"","url":"https://api.github.com/users/johnbeisner","html_url":"https://github.com/johnbeisner","followers_url":"https://api.github.com/users/johnbeisner/followers","following_url":"https://api.github.com/users/johnbeisner/following{/other_user}","gists_url":"https://api.github.com/users/johnbeisner/gists{/gist_id}","starred_url":"https://api.github.com/users/johnbeisner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnbeisner/subscriptions","organizations_url":"https://api.github.com/users/johnbeisner/orgs","repos_url":"https://api.github.com/users/johnbeisner/repos","events_url":"https://api.github.com/users/johnbeisner/events{/privacy}","received_events_url":"https://api.github.com/users/johnbeisner/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/cli/pulls/8035/commits","review_comments_url":"https://api.github.com/repos/dotnet/cli/pulls/8035/comments","review_comment_url":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/cli/issues/8035/comments","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/13a5d064636b372530227eff1be3419210fd09ac","head":{"label":"wli3:global-tools-package-obtain","ref":"global-tools-package-obtain","sha":"13a5d064636b372530227eff1be3419210fd09ac","user":{"login":"wli3","id":6993335,"avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"repo":{"id":67354897,"name":"cli","full_name":"wli3/cli","owner":{"login":"wli3","id":6993335,"avatar_url":"https://avatars1.githubusercontent.com/u/6993335?v=4","gravatar_id":"","url":"https://api.github.com/users/wli3","html_url":"https://github.com/wli3","followers_url":"https://api.github.com/users/wli3/followers","following_url":"https://api.github.com/users/wli3/following{/other_user}","gists_url":"https://api.github.com/users/wli3/gists{/gist_id}","starred_url":"https://api.github.com/users/wli3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wli3/subscriptions","organizations_url":"https://api.github.com/users/wli3/orgs","repos_url":"https://api.github.com/users/wli3/repos","events_url":"https://api.github.com/users/wli3/events{/privacy}","received_events_url":"https://api.github.com/users/wli3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wli3/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":true,"url":"https://api.github.com/repos/wli3/cli","forks_url":"https://api.github.com/repos/wli3/cli/forks","keys_url":"https://api.github.com/repos/wli3/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wli3/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wli3/cli/teams","hooks_url":"https://api.github.com/repos/wli3/cli/hooks","issue_events_url":"https://api.github.com/repos/wli3/cli/issues/events{/number}","events_url":"https://api.github.com/repos/wli3/cli/events","assignees_url":"https://api.github.com/repos/wli3/cli/assignees{/user}","branches_url":"https://api.github.com/repos/wli3/cli/branches{/branch}","tags_url":"https://api.github.com/repos/wli3/cli/tags","blobs_url":"https://api.github.com/repos/wli3/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wli3/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wli3/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/wli3/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wli3/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/wli3/cli/languages","stargazers_url":"https://api.github.com/repos/wli3/cli/stargazers","contributors_url":"https://api.github.com/repos/wli3/cli/contributors","subscribers_url":"https://api.github.com/repos/wli3/cli/subscribers","subscription_url":"https://api.github.com/repos/wli3/cli/subscription","commits_url":"https://api.github.com/repos/wli3/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/wli3/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/wli3/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/wli3/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/wli3/cli/contents/{+path}","compare_url":"https://api.github.com/repos/wli3/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wli3/cli/merges","archive_url":"https://api.github.com/repos/wli3/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wli3/cli/downloads","issues_url":"https://api.github.com/repos/wli3/cli/issues{/number}","pulls_url":"https://api.github.com/repos/wli3/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/wli3/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/wli3/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wli3/cli/labels{/name}","releases_url":"https://api.github.com/repos/wli3/cli/releases{/id}","deployments_url":"https://api.github.com/repos/wli3/cli/deployments","created_at":"2016-09-04T16:06:24Z","updated_at":"2016-09-04T16:06:28Z","pushed_at":"2017-11-22T00:52:21Z","git_url":"git://github.com/wli3/cli.git","ssh_url":"git@github.com:wli3/cli.git","clone_url":"https://github.com/wli3/cli.git","svn_url":"https://github.com/wli3/cli","homepage":"https://docs.microsoft.com/dotnet/ ","size":36362,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"rel/1.0.0"}},"base":{"label":"dotnet:master","ref":"master","sha":"2ee6aeb675933d5d889f84d918c590d976a4abe1","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":43568107,"name":"cli","full_name":"dotnet/cli","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/cli","description":"This repo contains the .NET Core command-line (CLI) tools, used for building .NET Core apps and libraries through your development flow (compiling, NuGet package management, running, testing, ...).","fork":false,"url":"https://api.github.com/repos/dotnet/cli","forks_url":"https://api.github.com/repos/dotnet/cli/forks","keys_url":"https://api.github.com/repos/dotnet/cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/cli/teams","hooks_url":"https://api.github.com/repos/dotnet/cli/hooks","issue_events_url":"https://api.github.com/repos/dotnet/cli/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/cli/events","assignees_url":"https://api.github.com/repos/dotnet/cli/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/cli/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/cli/tags","blobs_url":"https://api.github.com/repos/dotnet/cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/cli/languages","stargazers_url":"https://api.github.com/repos/dotnet/cli/stargazers","contributors_url":"https://api.github.com/repos/dotnet/cli/contributors","subscribers_url":"https://api.github.com/repos/dotnet/cli/subscribers","subscription_url":"https://api.github.com/repos/dotnet/cli/subscription","commits_url":"https://api.github.com/repos/dotnet/cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/cli/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/cli/merges","archive_url":"https://api.github.com/repos/dotnet/cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/cli/downloads","issues_url":"https://api.github.com/repos/dotnet/cli/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/cli/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/cli/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/cli/deployments","created_at":"2015-10-02T18:03:15Z","updated_at":"2017-11-22T00:24:04Z","pushed_at":"2017-11-22T00:52:22Z","git_url":"git://github.com/dotnet/cli.git","ssh_url":"git@github.com:dotnet/cli.git","clone_url":"https://github.com/dotnet/cli.git","svn_url":"https://github.com/dotnet/cli","homepage":"https://github.com/dotnet/core","size":35950,"stargazers_count":2428,"watchers_count":2428,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":786,"mirror_url":null,"archived":false,"open_issues_count":417,"forks":786,"open_issues":417,"watchers":2428,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/cli/pulls/8035"},"html":{"href":"https://github.com/dotnet/cli/pull/8035"},"issue":{"href":"https://api.github.com/repos/dotnet/cli/issues/8035"},"comments":{"href":"https://api.github.com/repos/dotnet/cli/issues/8035/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/cli/pulls/8035/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/cli/pulls/8035/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/cli/statuses/13a5d064636b372530227eff1be3419210fd09ac"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wli3"}}