{"action":"created","issue":{"url":"https://api.github.com/repos/ammaraskar/pyCraft/issues/68","repository_url":"https://api.github.com/repos/ammaraskar/pyCraft","labels_url":"https://api.github.com/repos/ammaraskar/pyCraft/issues/68/labels{/name}","comments_url":"https://api.github.com/repos/ammaraskar/pyCraft/issues/68/comments","events_url":"https://api.github.com/repos/ammaraskar/pyCraft/issues/68/events","html_url":"https://github.com/ammaraskar/pyCraft/pull/68","id":248138064,"number":68,"title":"Add more packets (and minor fixes)","user":{"login":"TheSnoozer","id":6849390,"avatar_url":"https://avatars2.githubusercontent.com/u/6849390?v=4","gravatar_id":"","url":"https://api.github.com/users/TheSnoozer","html_url":"https://github.com/TheSnoozer","followers_url":"https://api.github.com/users/TheSnoozer/followers","following_url":"https://api.github.com/users/TheSnoozer/following{/other_user}","gists_url":"https://api.github.com/users/TheSnoozer/gists{/gist_id}","starred_url":"https://api.github.com/users/TheSnoozer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheSnoozer/subscriptions","organizations_url":"https://api.github.com/users/TheSnoozer/orgs","repos_url":"https://api.github.com/users/TheSnoozer/repos","events_url":"https://api.github.com/users/TheSnoozer/events{/privacy}","received_events_url":"https://api.github.com/users/TheSnoozer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2017-08-04T23:17:52Z","updated_at":"2017-08-08T20:48:02Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ammaraskar/pyCraft/pulls/68","html_url":"https://github.com/ammaraskar/pyCraft/pull/68","diff_url":"https://github.com/ammaraskar/pyCraft/pull/68.diff","patch_url":"https://github.com/ammaraskar/pyCraft/pull/68.patch"},"body":"First of all: thanks for this awesome project!\r\nI decided to play around with it and added some packets to the python implementation (including respawning which seems to be the first actual client command that is not being dealt on server side).\r\n\r\nI also added some workaround that deals with faulty compression that for some reason gets introduced when using a specific plugin that supports the play to join a server with multiple versions. Not 100% what happens but based on the packets the server claims to have compression enabled but in fact it is not.\r\n\r\nI have tested with the following:\r\n* git-Spigot-21fe707-e1ebe52 (MC: 1.8.8) (Implementing API version 1.8.8-R0.1-SNAPSHOT)\r\n* git-Spigot-c6871e2-0cd0397 (MC: 1.9.4) (Implementing API version 1.9.4-R0.1-SNAPSHOT)\r\n* git-Spigot-de459a2-51263e9 (MC: 1.10.2) (Implementing API version 1.10.2-R0.1-SNAPSHOT)\r\n* git-Spigot-6f7aabf-c8ff651 (MC: 1.11) (Implementing API version 1.11-R0.1-SNAPSHOT)\r\n* git-Spigot-596221b-9a1fc1e (MC: 1.12) (Implementing API version 1.12-R0.1-SNAPSHOT)\r\n\r\neven though I have tested it with almost every major release I can't guarantee its bug free..."},"comment":{"url":"https://api.github.com/repos/ammaraskar/pyCraft/issues/comments/321077317","html_url":"https://github.com/ammaraskar/pyCraft/pull/68#issuecomment-321077317","issue_url":"https://api.github.com/repos/ammaraskar/pyCraft/issues/68","id":321077317,"user":{"login":"ammaraskar","id":773529,"avatar_url":"https://avatars1.githubusercontent.com/u/773529?v=4","gravatar_id":"","url":"https://api.github.com/users/ammaraskar","html_url":"https://github.com/ammaraskar","followers_url":"https://api.github.com/users/ammaraskar/followers","following_url":"https://api.github.com/users/ammaraskar/following{/other_user}","gists_url":"https://api.github.com/users/ammaraskar/gists{/gist_id}","starred_url":"https://api.github.com/users/ammaraskar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ammaraskar/subscriptions","organizations_url":"https://api.github.com/users/ammaraskar/orgs","repos_url":"https://api.github.com/users/ammaraskar/repos","events_url":"https://api.github.com/users/ammaraskar/events{/privacy}","received_events_url":"https://api.github.com/users/ammaraskar/received_events","type":"User","site_admin":false},"created_at":"2017-08-08T20:48:02Z","updated_at":"2017-08-08T20:48:02Z","body":"A better fix for the flake8 issue would be to add\r\n```python\r\nfrom .clientbound.handshake import get_packets as state_handshake_clientbound\r\n\r\n__all__ = ['state_handshake_clientbound', ...]\r\n```\r\n\r\nto show that the import is being used as an export"}}
{"actor":{"display_login":"ammaraskar"}}