{"action":"created","comment":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/137785052","pull_request_review_id":61498550,"id":137785052,"diff_hunk":"@@ -29,7 +29,7 @@ end\n # @test_throws ErrorException in(\"foobar\",\"bar\")\n @test_throws BoundsError search(b\"\\x1\\x2\",0x1,0)\n @test rsearchindex(b\"foo\",b\"o\",0) == 0\n-@test rsearchindex(SubString(\"\",1,1),SubString(\"\",1,1)) == 1\n+@test_throws BoundsError rsearchindex(SubString(\"\",1,1),SubString(\"\",1,1)) # == 1","path":"test/strings/search.jl","position":5,"original_position":5,"commit_id":"2f67f04a429f4c9679f377943a3fcb5851d8511e","original_commit_id":"2f67f04a429f4c9679f377943a3fcb5851d8511e","user":{"login":"nalimilan","id":1120448,"avatar_url":"https://avatars3.githubusercontent.com/u/1120448?v=4","gravatar_id":"","url":"https://api.github.com/users/nalimilan","html_url":"https://github.com/nalimilan","followers_url":"https://api.github.com/users/nalimilan/followers","following_url":"https://api.github.com/users/nalimilan/following{/other_user}","gists_url":"https://api.github.com/users/nalimilan/gists{/gist_id}","starred_url":"https://api.github.com/users/nalimilan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalimilan/subscriptions","organizations_url":"https://api.github.com/users/nalimilan/orgs","repos_url":"https://api.github.com/users/nalimilan/repos","events_url":"https://api.github.com/users/nalimilan/events{/privacy}","received_events_url":"https://api.github.com/users/nalimilan/received_events","type":"User","site_admin":false},"body":"Should return `1` just like for `String`, right?","created_at":"2017-09-08T13:04:36Z","updated_at":"2017-09-08T13:13:26Z","html_url":"https://github.com/JuliaLang/julia/pull/22511#discussion_r137785052","pull_request_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22511","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments/137785052"},"html":{"href":"https://github.com/JuliaLang/julia/pull/22511#discussion_r137785052"},"pull_request":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22511"}}},"pull_request":{"url":"https://api.github.com/repos/JuliaLang/julia/pulls/22511","id":127338878,"html_url":"https://github.com/JuliaLang/julia/pull/22511","diff_url":"https://github.com/JuliaLang/julia/pull/22511.diff","patch_url":"https://github.com/JuliaLang/julia/pull/22511.patch","issue_url":"https://api.github.com/repos/JuliaLang/julia/issues/22511","number":22511,"state":"open","locked":false,"title":"Fixes constructor of SubString from SubString","user":{"login":"bkamins","id":6187170,"avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"body":"PR following https://discourse.julialang.org/t/do-not-allow-substring-to-grow/4438","created_at":"2017-06-24T18:27:21Z","updated_at":"2017-09-08T13:13:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c2fc91509c3fa76a77927e687a9264d24c1e938","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22511/commits","review_comments_url":"https://api.github.com/repos/JuliaLang/julia/pulls/22511/comments","review_comment_url":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JuliaLang/julia/issues/22511/comments","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/2f67f04a429f4c9679f377943a3fcb5851d8511e","head":{"label":"bkamins:patch-9","ref":"patch-9","sha":"2f67f04a429f4c9679f377943a3fcb5851d8511e","user":{"login":"bkamins","id":6187170,"avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"repo":{"id":59789388,"name":"julia","full_name":"bkamins/julia","owner":{"login":"bkamins","id":6187170,"avatar_url":"https://avatars3.githubusercontent.com/u/6187170?v=4","gravatar_id":"","url":"https://api.github.com/users/bkamins","html_url":"https://github.com/bkamins","followers_url":"https://api.github.com/users/bkamins/followers","following_url":"https://api.github.com/users/bkamins/following{/other_user}","gists_url":"https://api.github.com/users/bkamins/gists{/gist_id}","starred_url":"https://api.github.com/users/bkamins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bkamins/subscriptions","organizations_url":"https://api.github.com/users/bkamins/orgs","repos_url":"https://api.github.com/users/bkamins/repos","events_url":"https://api.github.com/users/bkamins/events{/privacy}","received_events_url":"https://api.github.com/users/bkamins/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bkamins/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":true,"url":"https://api.github.com/repos/bkamins/julia","forks_url":"https://api.github.com/repos/bkamins/julia/forks","keys_url":"https://api.github.com/repos/bkamins/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bkamins/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bkamins/julia/teams","hooks_url":"https://api.github.com/repos/bkamins/julia/hooks","issue_events_url":"https://api.github.com/repos/bkamins/julia/issues/events{/number}","events_url":"https://api.github.com/repos/bkamins/julia/events","assignees_url":"https://api.github.com/repos/bkamins/julia/assignees{/user}","branches_url":"https://api.github.com/repos/bkamins/julia/branches{/branch}","tags_url":"https://api.github.com/repos/bkamins/julia/tags","blobs_url":"https://api.github.com/repos/bkamins/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bkamins/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bkamins/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/bkamins/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bkamins/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/bkamins/julia/languages","stargazers_url":"https://api.github.com/repos/bkamins/julia/stargazers","contributors_url":"https://api.github.com/repos/bkamins/julia/contributors","subscribers_url":"https://api.github.com/repos/bkamins/julia/subscribers","subscription_url":"https://api.github.com/repos/bkamins/julia/subscription","commits_url":"https://api.github.com/repos/bkamins/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/bkamins/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/bkamins/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/bkamins/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/bkamins/julia/contents/{+path}","compare_url":"https://api.github.com/repos/bkamins/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bkamins/julia/merges","archive_url":"https://api.github.com/repos/bkamins/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bkamins/julia/downloads","issues_url":"https://api.github.com/repos/bkamins/julia/issues{/number}","pulls_url":"https://api.github.com/repos/bkamins/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/bkamins/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/bkamins/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bkamins/julia/labels{/name}","releases_url":"https://api.github.com/repos/bkamins/julia/releases{/id}","deployments_url":"https://api.github.com/repos/bkamins/julia/deployments","created_at":"2016-05-26T23:21:20Z","updated_at":"2016-05-26T23:21:27Z","pushed_at":"2017-09-06T21:53:12Z","git_url":"git://github.com/bkamins/julia.git","ssh_url":"git@github.com:bkamins/julia.git","clone_url":"https://github.com/bkamins/julia.git","svn_url":"https://github.com/bkamins/julia","homepage":"http://julialang.org/","size":120871,"stargazers_count":0,"watchers_count":0,"language":"Julia","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"JuliaLang:master","ref":"master","sha":"7bb0d53a8e06b8caa14883c9768fead57c9aafda","user":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"repo":{"id":1644196,"name":"julia","full_name":"JuliaLang/julia","owner":{"login":"JuliaLang","id":743164,"avatar_url":"https://avatars0.githubusercontent.com/u/743164?v=4","gravatar_id":"","url":"https://api.github.com/users/JuliaLang","html_url":"https://github.com/JuliaLang","followers_url":"https://api.github.com/users/JuliaLang/followers","following_url":"https://api.github.com/users/JuliaLang/following{/other_user}","gists_url":"https://api.github.com/users/JuliaLang/gists{/gist_id}","starred_url":"https://api.github.com/users/JuliaLang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JuliaLang/subscriptions","organizations_url":"https://api.github.com/users/JuliaLang/orgs","repos_url":"https://api.github.com/users/JuliaLang/repos","events_url":"https://api.github.com/users/JuliaLang/events{/privacy}","received_events_url":"https://api.github.com/users/JuliaLang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JuliaLang/julia","description":"The Julia Language: A fresh approach to technical computing.","fork":false,"url":"https://api.github.com/repos/JuliaLang/julia","forks_url":"https://api.github.com/repos/JuliaLang/julia/forks","keys_url":"https://api.github.com/repos/JuliaLang/julia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JuliaLang/julia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JuliaLang/julia/teams","hooks_url":"https://api.github.com/repos/JuliaLang/julia/hooks","issue_events_url":"https://api.github.com/repos/JuliaLang/julia/issues/events{/number}","events_url":"https://api.github.com/repos/JuliaLang/julia/events","assignees_url":"https://api.github.com/repos/JuliaLang/julia/assignees{/user}","branches_url":"https://api.github.com/repos/JuliaLang/julia/branches{/branch}","tags_url":"https://api.github.com/repos/JuliaLang/julia/tags","blobs_url":"https://api.github.com/repos/JuliaLang/julia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JuliaLang/julia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JuliaLang/julia/git/refs{/sha}","trees_url":"https://api.github.com/repos/JuliaLang/julia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JuliaLang/julia/statuses/{sha}","languages_url":"https://api.github.com/repos/JuliaLang/julia/languages","stargazers_url":"https://api.github.com/repos/JuliaLang/julia/stargazers","contributors_url":"https://api.github.com/repos/JuliaLang/julia/contributors","subscribers_url":"https://api.github.com/repos/JuliaLang/julia/subscribers","subscription_url":"https://api.github.com/repos/JuliaLang/julia/subscription","commits_url":"https://api.github.com/repos/JuliaLang/julia/commits{/sha}","git_commits_url":"https://api.github.com/repos/JuliaLang/julia/git/commits{/sha}","comments_url":"https://api.github.com/repos/JuliaLang/julia/comments{/number}","issue_comment_url":"https://api.github.com/repos/JuliaLang/julia/issues/comments{/number}","contents_url":"https://api.github.com/repos/JuliaLang/julia/contents/{+path}","compare_url":"https://api.github.com/repos/JuliaLang/julia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JuliaLang/julia/merges","archive_url":"https://api.github.com/repos/JuliaLang/julia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JuliaLang/julia/downloads","issues_url":"https://api.github.com/repos/JuliaLang/julia/issues{/number}","pulls_url":"https://api.github.com/repos/JuliaLang/julia/pulls{/number}","milestones_url":"https://api.github.com/repos/JuliaLang/julia/milestones{/number}","notifications_url":"https://api.github.com/repos/JuliaLang/julia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JuliaLang/julia/labels{/name}","releases_url":"https://api.github.com/repos/JuliaLang/julia/releases{/id}","deployments_url":"https://api.github.com/repos/JuliaLang/julia/deployments","created_at":"2011-04-21T07:01:50Z","updated_at":"2017-09-08T00:02:35Z","pushed_at":"2017-09-08T13:12:51Z","git_url":"git://github.com/JuliaLang/julia.git","ssh_url":"git@github.com:JuliaLang/julia.git","clone_url":"https://github.com/JuliaLang/julia.git","svn_url":"https://github.com/JuliaLang/julia","homepage":"https://julialang.org/","size":253744,"stargazers_count":9124,"watchers_count":9124,"language":"Julia","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2068,"mirror_url":null,"open_issues_count":2351,"forks":2068,"open_issues":2351,"watchers":9124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22511"},"html":{"href":"https://github.com/JuliaLang/julia/pull/22511"},"issue":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/22511"},"comments":{"href":"https://api.github.com/repos/JuliaLang/julia/issues/22511/comments"},"review_comments":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22511/comments"},"review_comment":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JuliaLang/julia/pulls/22511/commits"},"statuses":{"href":"https://api.github.com/repos/JuliaLang/julia/statuses/2f67f04a429f4c9679f377943a3fcb5851d8511e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"nalimilan"}}