{"action":"closed","number":692,"pull_request":{"url":"https://api.github.com/repos/inversify/InversifyJS/pulls/692","id":154570389,"html_url":"https://github.com/inversify/InversifyJS/pull/692","diff_url":"https://github.com/inversify/InversifyJS/pull/692.diff","patch_url":"https://github.com/inversify/InversifyJS/pull/692.patch","issue_url":"https://api.github.com/repos/inversify/InversifyJS/issues/692","number":692,"state":"closed","locked":false,"title":"Fix imports of example code","user":{"login":"Razzeee","id":5943908,"avatar_url":"https://avatars2.githubusercontent.com/u/5943908?v=4","gravatar_id":"","url":"https://api.github.com/users/Razzeee","html_url":"https://github.com/Razzeee","followers_url":"https://api.github.com/users/Razzeee/followers","following_url":"https://api.github.com/users/Razzeee/following{/other_user}","gists_url":"https://api.github.com/users/Razzeee/gists{/gist_id}","starred_url":"https://api.github.com/users/Razzeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Razzeee/subscriptions","organizations_url":"https://api.github.com/users/Razzeee/orgs","repos_url":"https://api.github.com/users/Razzeee/repos","events_url":"https://api.github.com/users/Razzeee/events{/privacy}","received_events_url":"https://api.github.com/users/Razzeee/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n\r\n<!--- Describe your changes in detail -->\r\nWhile implementing the example code, I found some stuff that did not work out of the box for me. So here is an update for your readme to improve this.\r\n\r\n## Motivation and Context\r\n\r\n<!--- Why is this change required? What problem does it solve? -->\r\nBetter docs is always a good thing.\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n\r\n- [x] Updated docs / Refactor code / Added a tests case (non-breaking change)\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [x] I have updated the documentation accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [ ] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n","created_at":"2017-11-24T15:26:05Z","updated_at":"2017-11-24T19:03:35Z","closed_at":"2017-11-24T19:03:35Z","merged_at":"2017-11-24T19:03:35Z","merge_commit_sha":"7f438d0166d269d3f71e1faaafc6f54543181299","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/inversify/InversifyJS/pulls/692/commits","review_comments_url":"https://api.github.com/repos/inversify/InversifyJS/pulls/692/comments","review_comment_url":"https://api.github.com/repos/inversify/InversifyJS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inversify/InversifyJS/issues/692/comments","statuses_url":"https://api.github.com/repos/inversify/InversifyJS/statuses/8e6bf61e7ad316fd86669998b3838c451f2ba81c","head":{"label":"Razzeee:patch-1","ref":"patch-1","sha":"8e6bf61e7ad316fd86669998b3838c451f2ba81c","user":{"login":"Razzeee","id":5943908,"avatar_url":"https://avatars2.githubusercontent.com/u/5943908?v=4","gravatar_id":"","url":"https://api.github.com/users/Razzeee","html_url":"https://github.com/Razzeee","followers_url":"https://api.github.com/users/Razzeee/followers","following_url":"https://api.github.com/users/Razzeee/following{/other_user}","gists_url":"https://api.github.com/users/Razzeee/gists{/gist_id}","starred_url":"https://api.github.com/users/Razzeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Razzeee/subscriptions","organizations_url":"https://api.github.com/users/Razzeee/orgs","repos_url":"https://api.github.com/users/Razzeee/repos","events_url":"https://api.github.com/users/Razzeee/events{/privacy}","received_events_url":"https://api.github.com/users/Razzeee/received_events","type":"User","site_admin":false},"repo":{"id":111932023,"name":"InversifyJS","full_name":"Razzeee/InversifyJS","owner":{"login":"Razzeee","id":5943908,"avatar_url":"https://avatars2.githubusercontent.com/u/5943908?v=4","gravatar_id":"","url":"https://api.github.com/users/Razzeee","html_url":"https://github.com/Razzeee","followers_url":"https://api.github.com/users/Razzeee/followers","following_url":"https://api.github.com/users/Razzeee/following{/other_user}","gists_url":"https://api.github.com/users/Razzeee/gists{/gist_id}","starred_url":"https://api.github.com/users/Razzeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Razzeee/subscriptions","organizations_url":"https://api.github.com/users/Razzeee/orgs","repos_url":"https://api.github.com/users/Razzeee/repos","events_url":"https://api.github.com/users/Razzeee/events{/privacy}","received_events_url":"https://api.github.com/users/Razzeee/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Razzeee/InversifyJS","description":"A powerful and lightweight inversion of control container  for JavaScript & Node.js apps powered by TypeScript.","fork":true,"url":"https://api.github.com/repos/Razzeee/InversifyJS","forks_url":"https://api.github.com/repos/Razzeee/InversifyJS/forks","keys_url":"https://api.github.com/repos/Razzeee/InversifyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Razzeee/InversifyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Razzeee/InversifyJS/teams","hooks_url":"https://api.github.com/repos/Razzeee/InversifyJS/hooks","issue_events_url":"https://api.github.com/repos/Razzeee/InversifyJS/issues/events{/number}","events_url":"https://api.github.com/repos/Razzeee/InversifyJS/events","assignees_url":"https://api.github.com/repos/Razzeee/InversifyJS/assignees{/user}","branches_url":"https://api.github.com/repos/Razzeee/InversifyJS/branches{/branch}","tags_url":"https://api.github.com/repos/Razzeee/InversifyJS/tags","blobs_url":"https://api.github.com/repos/Razzeee/InversifyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Razzeee/InversifyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Razzeee/InversifyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/Razzeee/InversifyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Razzeee/InversifyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/Razzeee/InversifyJS/languages","stargazers_url":"https://api.github.com/repos/Razzeee/InversifyJS/stargazers","contributors_url":"https://api.github.com/repos/Razzeee/InversifyJS/contributors","subscribers_url":"https://api.github.com/repos/Razzeee/InversifyJS/subscribers","subscription_url":"https://api.github.com/repos/Razzeee/InversifyJS/subscription","commits_url":"https://api.github.com/repos/Razzeee/InversifyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/Razzeee/InversifyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/Razzeee/InversifyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/Razzeee/InversifyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/Razzeee/InversifyJS/contents/{+path}","compare_url":"https://api.github.com/repos/Razzeee/InversifyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Razzeee/InversifyJS/merges","archive_url":"https://api.github.com/repos/Razzeee/InversifyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Razzeee/InversifyJS/downloads","issues_url":"https://api.github.com/repos/Razzeee/InversifyJS/issues{/number}","pulls_url":"https://api.github.com/repos/Razzeee/InversifyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/Razzeee/InversifyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/Razzeee/InversifyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Razzeee/InversifyJS/labels{/name}","releases_url":"https://api.github.com/repos/Razzeee/InversifyJS/releases{/id}","deployments_url":"https://api.github.com/repos/Razzeee/InversifyJS/deployments","created_at":"2017-11-24T15:22:11Z","updated_at":"2017-11-24T15:22:13Z","pushed_at":"2017-11-24T15:23:32Z","git_url":"git://github.com/Razzeee/InversifyJS.git","ssh_url":"git@github.com:Razzeee/InversifyJS.git","clone_url":"https://github.com/Razzeee/InversifyJS.git","svn_url":"https://github.com/Razzeee/InversifyJS","homepage":"http://inversify.io/","size":1321,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inversify:master","ref":"master","sha":"b07fdce88e64085d05dba4207c402f4eb7d3f738","user":{"login":"inversify","id":11887183,"avatar_url":"https://avatars3.githubusercontent.com/u/11887183?v=4","gravatar_id":"","url":"https://api.github.com/users/inversify","html_url":"https://github.com/inversify","followers_url":"https://api.github.com/users/inversify/followers","following_url":"https://api.github.com/users/inversify/following{/other_user}","gists_url":"https://api.github.com/users/inversify/gists{/gist_id}","starred_url":"https://api.github.com/users/inversify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inversify/subscriptions","organizations_url":"https://api.github.com/users/inversify/orgs","repos_url":"https://api.github.com/users/inversify/repos","events_url":"https://api.github.com/users/inversify/events{/privacy}","received_events_url":"https://api.github.com/users/inversify/received_events","type":"Organization","site_admin":false},"repo":{"id":33568214,"name":"InversifyJS","full_name":"inversify/InversifyJS","owner":{"login":"inversify","id":11887183,"avatar_url":"https://avatars3.githubusercontent.com/u/11887183?v=4","gravatar_id":"","url":"https://api.github.com/users/inversify","html_url":"https://github.com/inversify","followers_url":"https://api.github.com/users/inversify/followers","following_url":"https://api.github.com/users/inversify/following{/other_user}","gists_url":"https://api.github.com/users/inversify/gists{/gist_id}","starred_url":"https://api.github.com/users/inversify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inversify/subscriptions","organizations_url":"https://api.github.com/users/inversify/orgs","repos_url":"https://api.github.com/users/inversify/repos","events_url":"https://api.github.com/users/inversify/events{/privacy}","received_events_url":"https://api.github.com/users/inversify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inversify/InversifyJS","description":"A powerful and lightweight inversion of control container  for JavaScript & Node.js apps powered by TypeScript.","fork":false,"url":"https://api.github.com/repos/inversify/InversifyJS","forks_url":"https://api.github.com/repos/inversify/InversifyJS/forks","keys_url":"https://api.github.com/repos/inversify/InversifyJS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inversify/InversifyJS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inversify/InversifyJS/teams","hooks_url":"https://api.github.com/repos/inversify/InversifyJS/hooks","issue_events_url":"https://api.github.com/repos/inversify/InversifyJS/issues/events{/number}","events_url":"https://api.github.com/repos/inversify/InversifyJS/events","assignees_url":"https://api.github.com/repos/inversify/InversifyJS/assignees{/user}","branches_url":"https://api.github.com/repos/inversify/InversifyJS/branches{/branch}","tags_url":"https://api.github.com/repos/inversify/InversifyJS/tags","blobs_url":"https://api.github.com/repos/inversify/InversifyJS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inversify/InversifyJS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inversify/InversifyJS/git/refs{/sha}","trees_url":"https://api.github.com/repos/inversify/InversifyJS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inversify/InversifyJS/statuses/{sha}","languages_url":"https://api.github.com/repos/inversify/InversifyJS/languages","stargazers_url":"https://api.github.com/repos/inversify/InversifyJS/stargazers","contributors_url":"https://api.github.com/repos/inversify/InversifyJS/contributors","subscribers_url":"https://api.github.com/repos/inversify/InversifyJS/subscribers","subscription_url":"https://api.github.com/repos/inversify/InversifyJS/subscription","commits_url":"https://api.github.com/repos/inversify/InversifyJS/commits{/sha}","git_commits_url":"https://api.github.com/repos/inversify/InversifyJS/git/commits{/sha}","comments_url":"https://api.github.com/repos/inversify/InversifyJS/comments{/number}","issue_comment_url":"https://api.github.com/repos/inversify/InversifyJS/issues/comments{/number}","contents_url":"https://api.github.com/repos/inversify/InversifyJS/contents/{+path}","compare_url":"https://api.github.com/repos/inversify/InversifyJS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inversify/InversifyJS/merges","archive_url":"https://api.github.com/repos/inversify/InversifyJS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inversify/InversifyJS/downloads","issues_url":"https://api.github.com/repos/inversify/InversifyJS/issues{/number}","pulls_url":"https://api.github.com/repos/inversify/InversifyJS/pulls{/number}","milestones_url":"https://api.github.com/repos/inversify/InversifyJS/milestones{/number}","notifications_url":"https://api.github.com/repos/inversify/InversifyJS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inversify/InversifyJS/labels{/name}","releases_url":"https://api.github.com/repos/inversify/InversifyJS/releases{/id}","deployments_url":"https://api.github.com/repos/inversify/InversifyJS/deployments","created_at":"2015-04-07T21:04:38Z","updated_at":"2017-11-24T15:00:47Z","pushed_at":"2017-11-24T19:03:35Z","git_url":"git://github.com/inversify/InversifyJS.git","ssh_url":"git@github.com:inversify/InversifyJS.git","clone_url":"https://github.com/inversify/InversifyJS.git","svn_url":"https://github.com/inversify/InversifyJS","homepage":"http://inversify.io/","size":1314,"stargazers_count":1870,"watchers_count":1870,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":138,"mirror_url":null,"archived":false,"open_issues_count":39,"forks":138,"open_issues":39,"watchers":1870,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inversify/InversifyJS/pulls/692"},"html":{"href":"https://github.com/inversify/InversifyJS/pull/692"},"issue":{"href":"https://api.github.com/repos/inversify/InversifyJS/issues/692"},"comments":{"href":"https://api.github.com/repos/inversify/InversifyJS/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/inversify/InversifyJS/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/inversify/InversifyJS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inversify/InversifyJS/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/inversify/InversifyJS/statuses/8e6bf61e7ad316fd86669998b3838c451f2ba81c"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"remojansen","id":10656223,"avatar_url":"https://avatars2.githubusercontent.com/u/10656223?v=4","gravatar_id":"","url":"https://api.github.com/users/remojansen","html_url":"https://github.com/remojansen","followers_url":"https://api.github.com/users/remojansen/followers","following_url":"https://api.github.com/users/remojansen/following{/other_user}","gists_url":"https://api.github.com/users/remojansen/gists{/gist_id}","starred_url":"https://api.github.com/users/remojansen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remojansen/subscriptions","organizations_url":"https://api.github.com/users/remojansen/orgs","repos_url":"https://api.github.com/users/remojansen/repos","events_url":"https://api.github.com/users/remojansen/events{/privacy}","received_events_url":"https://api.github.com/users/remojansen/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"remojansen"}}