{"action":"created","comment":{"url":"https://api.github.com/repos/Theano/Theano/pulls/comments/95430189","pull_request_review_id":15984616,"id":95430189,"diff_hunk":"@@ -450,12 +464,13 @@ def c_code(self, node, name, inp, outputs, sub):\n         }\n         if(%(sync)d)\n             GpuArray_sync(&(out->ga));\n+        Py_DECREF(pvals_copy);","path":"theano/gpuarray/multinomial.py","position":38,"original_position":38,"commit_id":"ca83a8be94e41be095db2980f7921a85c2cbe974","original_commit_id":"ca83a8be94e41be095db2980f7921a85c2cbe974","user":{"login":"abergeron","id":1002504,"avatar_url":"https://avatars.githubusercontent.com/u/1002504?v=3","gravatar_id":"","url":"https://api.github.com/users/abergeron","html_url":"https://github.com/abergeron","followers_url":"https://api.github.com/users/abergeron/followers","following_url":"https://api.github.com/users/abergeron/following{/other_user}","gists_url":"https://api.github.com/users/abergeron/gists{/gist_id}","starred_url":"https://api.github.com/users/abergeron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abergeron/subscriptions","organizations_url":"https://api.github.com/users/abergeron/orgs","repos_url":"https://api.github.com/users/abergeron/repos","events_url":"https://api.github.com/users/abergeron/events{/privacy}","received_events_url":"https://api.github.com/users/abergeron/received_events","type":"User","site_admin":false},"body":"Good catch, but there are other exit points before this where we should free it too.","created_at":"2017-01-10T18:47:16Z","updated_at":"2017-01-10T18:48:30Z","html_url":"https://github.com/Theano/Theano/pull/5346#discussion_r95430189","pull_request_url":"https://api.github.com/repos/Theano/Theano/pulls/5346","_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments/95430189"},"html":{"href":"https://github.com/Theano/Theano/pull/5346#discussion_r95430189"},"pull_request":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5346"}}},"pull_request":{"url":"https://api.github.com/repos/Theano/Theano/pulls/5346","id":98402507,"html_url":"https://github.com/Theano/Theano/pull/5346","diff_url":"https://github.com/Theano/Theano/pull/5346.diff","patch_url":"https://github.com/Theano/Theano/pull/5346.patch","issue_url":"https://api.github.com/repos/Theano/Theano/issues/5346","number":5346,"state":"open","locked":false,"title":"[ENH] Multinomial without replacement","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"body":"fix memory leak and speed up when there is few multinomials as in gh-5338.","created_at":"2016-12-16T21:02:35Z","updated_at":"2017-01-10T18:48:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a9146cc6642cab2149cfbd3f84869b69c93f6c3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Theano/Theano/pulls/5346/commits","review_comments_url":"https://api.github.com/repos/Theano/Theano/pulls/5346/comments","review_comment_url":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Theano/Theano/issues/5346/comments","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/ca83a8be94e41be095db2980f7921a85c2cbe974","head":{"label":"nouiz:multinomial_wor","ref":"multinomial_wor","sha":"ca83a8be94e41be095db2980f7921a85c2cbe974","user":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"repo":{"id":2255296,"name":"Theano","full_name":"nouiz/Theano","owner":{"login":"nouiz","id":180987,"avatar_url":"https://avatars.githubusercontent.com/u/180987?v=3","gravatar_id":"","url":"https://api.github.com/users/nouiz","html_url":"https://github.com/nouiz","followers_url":"https://api.github.com/users/nouiz/followers","following_url":"https://api.github.com/users/nouiz/following{/other_user}","gists_url":"https://api.github.com/users/nouiz/gists{/gist_id}","starred_url":"https://api.github.com/users/nouiz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nouiz/subscriptions","organizations_url":"https://api.github.com/users/nouiz/orgs","repos_url":"https://api.github.com/users/nouiz/repos","events_url":"https://api.github.com/users/nouiz/events{/privacy}","received_events_url":"https://api.github.com/users/nouiz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nouiz/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation. ","fork":true,"url":"https://api.github.com/repos/nouiz/Theano","forks_url":"https://api.github.com/repos/nouiz/Theano/forks","keys_url":"https://api.github.com/repos/nouiz/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nouiz/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nouiz/Theano/teams","hooks_url":"https://api.github.com/repos/nouiz/Theano/hooks","issue_events_url":"https://api.github.com/repos/nouiz/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/nouiz/Theano/events","assignees_url":"https://api.github.com/repos/nouiz/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/nouiz/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/nouiz/Theano/tags","blobs_url":"https://api.github.com/repos/nouiz/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nouiz/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nouiz/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/nouiz/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nouiz/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/nouiz/Theano/languages","stargazers_url":"https://api.github.com/repos/nouiz/Theano/stargazers","contributors_url":"https://api.github.com/repos/nouiz/Theano/contributors","subscribers_url":"https://api.github.com/repos/nouiz/Theano/subscribers","subscription_url":"https://api.github.com/repos/nouiz/Theano/subscription","commits_url":"https://api.github.com/repos/nouiz/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/nouiz/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/nouiz/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/nouiz/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/nouiz/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/nouiz/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nouiz/Theano/merges","archive_url":"https://api.github.com/repos/nouiz/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nouiz/Theano/downloads","issues_url":"https://api.github.com/repos/nouiz/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/nouiz/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/nouiz/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/nouiz/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nouiz/Theano/labels{/name}","releases_url":"https://api.github.com/repos/nouiz/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/nouiz/Theano/deployments","created_at":"2011-08-23T13:23:37Z","updated_at":"2016-12-02T08:04:38Z","pushed_at":"2017-01-10T17:59:04Z","git_url":"git://github.com/nouiz/Theano.git","ssh_url":"git@github.com:nouiz/Theano.git","clone_url":"https://github.com/nouiz/Theano.git","svn_url":"https://github.com/nouiz/Theano","homepage":"http://www.deeplearning.net/software/theano","size":61870,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":0,"forks":5,"open_issues":0,"watchers":8,"default_branch":"master"}},"base":{"label":"Theano:master","ref":"master","sha":"1a42bf9b2b0d02440f6968191e33c5fa858f365f","user":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"repo":{"id":2183193,"name":"Theano","full_name":"Theano/Theano","owner":{"login":"Theano","id":970517,"avatar_url":"https://avatars.githubusercontent.com/u/970517?v=3","gravatar_id":"","url":"https://api.github.com/users/Theano","html_url":"https://github.com/Theano","followers_url":"https://api.github.com/users/Theano/followers","following_url":"https://api.github.com/users/Theano/following{/other_user}","gists_url":"https://api.github.com/users/Theano/gists{/gist_id}","starred_url":"https://api.github.com/users/Theano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Theano/subscriptions","organizations_url":"https://api.github.com/users/Theano/orgs","repos_url":"https://api.github.com/users/Theano/repos","events_url":"https://api.github.com/users/Theano/events{/privacy}","received_events_url":"https://api.github.com/users/Theano/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Theano/Theano","description":"Theano is a Python library that allows you to define, optimize, and evaluate mathematical expressions involving multi-dimensional arrays efficiently. It can use GPUs and perform efficient symbolic differentiation.","fork":false,"url":"https://api.github.com/repos/Theano/Theano","forks_url":"https://api.github.com/repos/Theano/Theano/forks","keys_url":"https://api.github.com/repos/Theano/Theano/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Theano/Theano/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Theano/Theano/teams","hooks_url":"https://api.github.com/repos/Theano/Theano/hooks","issue_events_url":"https://api.github.com/repos/Theano/Theano/issues/events{/number}","events_url":"https://api.github.com/repos/Theano/Theano/events","assignees_url":"https://api.github.com/repos/Theano/Theano/assignees{/user}","branches_url":"https://api.github.com/repos/Theano/Theano/branches{/branch}","tags_url":"https://api.github.com/repos/Theano/Theano/tags","blobs_url":"https://api.github.com/repos/Theano/Theano/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Theano/Theano/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Theano/Theano/git/refs{/sha}","trees_url":"https://api.github.com/repos/Theano/Theano/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Theano/Theano/statuses/{sha}","languages_url":"https://api.github.com/repos/Theano/Theano/languages","stargazers_url":"https://api.github.com/repos/Theano/Theano/stargazers","contributors_url":"https://api.github.com/repos/Theano/Theano/contributors","subscribers_url":"https://api.github.com/repos/Theano/Theano/subscribers","subscription_url":"https://api.github.com/repos/Theano/Theano/subscription","commits_url":"https://api.github.com/repos/Theano/Theano/commits{/sha}","git_commits_url":"https://api.github.com/repos/Theano/Theano/git/commits{/sha}","comments_url":"https://api.github.com/repos/Theano/Theano/comments{/number}","issue_comment_url":"https://api.github.com/repos/Theano/Theano/issues/comments{/number}","contents_url":"https://api.github.com/repos/Theano/Theano/contents/{+path}","compare_url":"https://api.github.com/repos/Theano/Theano/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Theano/Theano/merges","archive_url":"https://api.github.com/repos/Theano/Theano/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Theano/Theano/downloads","issues_url":"https://api.github.com/repos/Theano/Theano/issues{/number}","pulls_url":"https://api.github.com/repos/Theano/Theano/pulls{/number}","milestones_url":"https://api.github.com/repos/Theano/Theano/milestones{/number}","notifications_url":"https://api.github.com/repos/Theano/Theano/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Theano/Theano/labels{/name}","releases_url":"https://api.github.com/repos/Theano/Theano/releases{/id}","deployments_url":"https://api.github.com/repos/Theano/Theano/deployments","created_at":"2011-08-10T03:48:06Z","updated_at":"2017-01-10T11:32:26Z","pushed_at":"2017-01-10T18:47:17Z","git_url":"git://github.com/Theano/Theano.git","ssh_url":"git@github.com:Theano/Theano.git","clone_url":"https://github.com/Theano/Theano.git","svn_url":"https://github.com/Theano/Theano","homepage":"http://www.deeplearning.net/software/theano","size":60888,"stargazers_count":5405,"watchers_count":5405,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1878,"mirror_url":null,"open_issues_count":703,"forks":1878,"open_issues":703,"watchers":5405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5346"},"html":{"href":"https://github.com/Theano/Theano/pull/5346"},"issue":{"href":"https://api.github.com/repos/Theano/Theano/issues/5346"},"comments":{"href":"https://api.github.com/repos/Theano/Theano/issues/5346/comments"},"review_comments":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5346/comments"},"review_comment":{"href":"https://api.github.com/repos/Theano/Theano/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Theano/Theano/pulls/5346/commits"},"statuses":{"href":"https://api.github.com/repos/Theano/Theano/statuses/ca83a8be94e41be095db2980f7921a85c2cbe974"}}}}
{"actor":{"display_login":"abergeron"}}