{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/20344","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/20344/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/20344/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/20344/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/20344","id":263344882,"number":20344,"title":"[aws-iot-device-sdk] - Fix references to the mqtt types","user":{"login":"thchia","id":21194045,"avatar_url":"https://avatars2.githubusercontent.com/u/21194045?v=4","gravatar_id":"","url":"https://api.github.com/users/thchia","html_url":"https://github.com/thchia","followers_url":"https://api.github.com/users/thchia/followers","following_url":"https://api.github.com/users/thchia/following{/other_user}","gists_url":"https://api.github.com/users/thchia/gists{/gist_id}","starred_url":"https://api.github.com/users/thchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thchia/subscriptions","organizations_url":"https://api.github.com/users/thchia/orgs","repos_url":"https://api.github.com/users/thchia/repos","events_url":"https://api.github.com/users/thchia/events{/privacy}","received_events_url":"https://api.github.com/users/thchia/received_events","type":"User","site_admin":false},"labels":[{"id":57534397,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/The%20Travis%20CI%20build%20failed","name":"The Travis CI build failed","color":"e11d21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-10-06T06:10:29Z","updated_at":"2017-10-06T08:24:51Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/20344","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/20344","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/20344.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/20344.patch"},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nIf changing an existing definition:\r\n- [x] Provide a URL to documentation or source code which provides context for the suggested changes: <<https://github.com/aws/aws-iot-device-sdk-js/blob/master/CHANGELOG.md#210-sep-28-2017>> **(Update of mqtt package from 2.2.x to 2.13.x)**\r\n- [x] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\n#20343 "},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/334691379","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/20344#issuecomment-334691379","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/20344","id":334691379,"user":{"login":"niik","id":634063,"avatar_url":"https://avatars2.githubusercontent.com/u/634063?v=4","gravatar_id":"","url":"https://api.github.com/users/niik","html_url":"https://github.com/niik","followers_url":"https://api.github.com/users/niik/followers","following_url":"https://api.github.com/users/niik/following{/other_user}","gists_url":"https://api.github.com/users/niik/gists{/gist_id}","starred_url":"https://api.github.com/users/niik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niik/subscriptions","organizations_url":"https://api.github.com/users/niik/orgs","repos_url":"https://api.github.com/users/niik/repos","events_url":"https://api.github.com/users/niik/events{/privacy}","received_events_url":"https://api.github.com/users/niik/received_events","type":"User","site_admin":true},"created_at":"2017-10-06T08:24:51Z","updated_at":"2017-10-06T08:24:51Z","author_association":"CONTRIBUTOR","body":"> The test case uses references to the old @types/mqtt. I'm not sure how to stop it from doing that.\r\n\r\n@thchia Ah, so I see that mqtt is providing its own types now, there was a PR opened by @andy-ms (https://github.com/DefinitelyTyped/DefinitelyTyped/pull/15560) to start using that instead but it got stale and was never merged. What you need to do here is to add mqtt as a dependency by creating a new package.json file. You can look at @andy-ms' PR for inspiration. Once you've done that you should be able to switch the import statements from `@types/mqtt` to just `mqtt`."}}
{"actor":{"display_login":"niik"}}