{"action":"created","issue":{"url":"https://api.github.com/repos/geodynamics/aspect/issues/1934","repository_url":"https://api.github.com/repos/geodynamics/aspect","labels_url":"https://api.github.com/repos/geodynamics/aspect/issues/1934/labels{/name}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/1934/comments","events_url":"https://api.github.com/repos/geodynamics/aspect/issues/1934/events","html_url":"https://github.com/geodynamics/aspect/pull/1934","id":260255861,"number":1934,"title":"Change shared pointer of melt in simulator_access to unique pointer.","user":{"login":"MFraters","id":7631629,"avatar_url":"https://avatars0.githubusercontent.com/u/7631629?v=4","gravatar_id":"","url":"https://api.github.com/users/MFraters","html_url":"https://github.com/MFraters","followers_url":"https://api.github.com/users/MFraters/followers","following_url":"https://api.github.com/users/MFraters/following{/other_user}","gists_url":"https://api.github.com/users/MFraters/gists{/gist_id}","starred_url":"https://api.github.com/users/MFraters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MFraters/subscriptions","organizations_url":"https://api.github.com/users/MFraters/orgs","repos_url":"https://api.github.com/users/MFraters/repos","events_url":"https://api.github.com/users/MFraters/events{/privacy}","received_events_url":"https://api.github.com/users/MFraters/received_events","type":"User","site_admin":false},"labels":[{"id":401645273,"url":"https://api.github.com/repos/geodynamics/aspect/labels/ready%20to%20merge","name":"ready to merge","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-09-25T12:23:01Z","updated_at":"2017-09-25T16:18:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/1934","html_url":"https://github.com/geodynamics/aspect/pull/1934","diff_url":"https://github.com/geodynamics/aspect/pull/1934.diff","patch_url":"https://github.com/geodynamics/aspect/pull/1934.patch"},"body":"split from #1707 "},"comment":{"url":"https://api.github.com/repos/geodynamics/aspect/issues/comments/331933926","html_url":"https://github.com/geodynamics/aspect/pull/1934#issuecomment-331933926","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/1934","id":331933926,"user":{"login":"bangerth","id":7504421,"avatar_url":"https://avatars2.githubusercontent.com/u/7504421?v=4","gravatar_id":"","url":"https://api.github.com/users/bangerth","html_url":"https://github.com/bangerth","followers_url":"https://api.github.com/users/bangerth/followers","following_url":"https://api.github.com/users/bangerth/following{/other_user}","gists_url":"https://api.github.com/users/bangerth/gists{/gist_id}","starred_url":"https://api.github.com/users/bangerth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bangerth/subscriptions","organizations_url":"https://api.github.com/users/bangerth/orgs","repos_url":"https://api.github.com/users/bangerth/repos","events_url":"https://api.github.com/users/bangerth/events{/privacy}","received_events_url":"https://api.github.com/users/bangerth/received_events","type":"User","site_admin":false},"created_at":"2017-09-25T16:18:26Z","updated_at":"2017-09-25T16:18:26Z","author_association":"CONTRIBUTOR","body":"Well, it doesn't compile:\r\n```\r\n/home/dealii/source/source/simulator/core.cc:156:44: error: no matching function for call to â€˜construct_variables(aspect::Parameters<2>&, aspect::SimulatorSignals<2>&, std::unique_ptr<aspect::MeltHandler<2>, std::default_delete<aspect::MeltHandler<2> > >&)â€™\r\n     introspection (construct_variables<dim>(parameters, signals, melt_handler), parameters),\r\n                    ~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n/home/dealii/source/source/simulator/core.cc:93:44: note: candidate: template<int dim> std::vector<aspect::VariableDeclaration<dim> > aspect::{anonymous}::construct_variables(const aspect::Parameters<dim>&, aspect::SimulatorSignals<dim>&, std::shared_ptr<aspect::MeltHandler<dim> >&)\r\n\r\n```"}}
{"actor":{"display_login":"bangerth"}}