{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/127749118","pull_request_review_id":50364391,"id":127749118,"diff_hunk":"@@ -650,4 +650,49 @@ public void testInvalidShapeWithConsecutiveDuplicatePoints() {\n         Exception e = expectThrows(InvalidShapeException.class, () -> builder.close().build());\n         assertThat(e.getMessage(), containsString(\"duplicate consecutive coordinates at: (\"));\n     }\n+\n+    public void testPolygon3D() {\n+        String expected = \"{\\n\" +\n+            \"  \\\"type\\\" : \\\"polygon\\\",\\n\" +\n+            \"  \\\"orientation\\\" : \\\"right\\\",\\n\" +\n+            \"  \\\"coordinates\\\" : [\\n\" +\n+            \"    [\\n\" +\n+            \"      [\\n\" +\n+            \"        -45.0,\\n\" +\n+            \"        30.0,\\n\" +\n+            \"        100.0\\n\" +\n+            \"      ],\\n\" +\n+            \"      [\\n\" +\n+            \"        45.0,\\n\" +\n+            \"        30.0,\\n\" +\n+            \"        75.0\\n\" +\n+            \"      ],\\n\" +\n+            \"      [\\n\" +\n+            \"        45.0,\\n\" +\n+            \"        -30.0,\\n\" +\n+            \"        77.0\\n\" +\n+            \"      ],\\n\" +\n+            \"      [\\n\" +\n+            \"        -45.0,\\n\" +\n+            \"        -30.0,\\n\" +\n+            \"        101.0\\n\" +\n+            \"      ],\\n\" +\n+            \"      [\\n\" +\n+            \"        -45.0,\\n\" +\n+            \"        30.0,\\n\" +\n+            \"        110.0\\n\" +\n+            \"      ]\\n\" +\n+            \"    ]\\n\" +\n+            \"  ]\\n\" +\n+            \"}\";\n+\n+        PolygonBuilder pb =  ShapeBuilders.newPolygon(new CoordinatesBuilder()\n+            .coordinate(new Coordinate(-45, 30, 100))\n+            .coordinate(new Coordinate(45, 30, 75))\n+            .coordinate(new Coordinate(45, -30, 77))\n+            .coordinate(new Coordinate(-45, -30, 101))\n+            .coordinate(new Coordinate(-45, 30, 110)));\n+\n+        assertEquals(expected, pb.toString());","path":"core/src/test/java/org/elasticsearch/common/geo/ShapeBuilderTests.java","position":47,"original_position":47,"commit_id":"618233323a660708ae88de1f735523fffc95289f","original_commit_id":"618233323a660708ae88de1f735523fffc95289f","user":{"login":"jpountz","id":299848,"avatar_url":"https://avatars6.githubusercontent.com/u/299848?v=4","gravatar_id":"","url":"https://api.github.com/users/jpountz","html_url":"https://github.com/jpountz","followers_url":"https://api.github.com/users/jpountz/followers","following_url":"https://api.github.com/users/jpountz/following{/other_user}","gists_url":"https://api.github.com/users/jpountz/gists{/gist_id}","starred_url":"https://api.github.com/users/jpountz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpountz/subscriptions","organizations_url":"https://api.github.com/users/jpountz/orgs","repos_url":"https://api.github.com/users/jpountz/repos","events_url":"https://api.github.com/users/jpountz/events{/privacy}","received_events_url":"https://api.github.com/users/jpountz/received_events","type":"User","site_admin":false},"body":"we should test parsing too?","created_at":"2017-07-17T16:02:05Z","updated_at":"2017-07-17T16:02:36Z","html_url":"https://github.com/elastic/elasticsearch/pull/25738#discussion_r127749118","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25738","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/127749118"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/25738#discussion_r127749118"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25738"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25738","id":130724074,"html_url":"https://github.com/elastic/elasticsearch/pull/25738","diff_url":"https://github.com/elastic/elasticsearch/pull/25738.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/25738.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/25738","number":25738,"state":"open","locked":false,"title":"Add Z value support to geo_shape","user":{"login":"nknize","id":830187,"avatar_url":"https://avatars7.githubusercontent.com/u/830187?v=4","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"body":"This enhancement adds Z value support (source only) to geo_shape fields. If vertices are provided with a third dimension, the third dimension is ignored for indexing but returned as part of source. Like before, any values greater than the 3rd dimension are ignored.\r\n\r\ncloses #22917","created_at":"2017-07-15T17:54:36Z","updated_at":"2017-07-17T16:02:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9707d280955c93351152e59ccf27576b72578087","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25738/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/25738/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/25738/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/618233323a660708ae88de1f735523fffc95289f","head":{"label":"nknize:enhancement/22917","ref":"enhancement/22917","sha":"618233323a660708ae88de1f735523fffc95289f","user":{"login":"nknize","id":830187,"avatar_url":"https://avatars7.githubusercontent.com/u/830187?v=4","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"repo":{"id":25872473,"name":"elasticsearch","full_name":"nknize/elasticsearch","owner":{"login":"nknize","id":830187,"avatar_url":"https://avatars7.githubusercontent.com/u/830187?v=4","gravatar_id":"","url":"https://api.github.com/users/nknize","html_url":"https://github.com/nknize","followers_url":"https://api.github.com/users/nknize/followers","following_url":"https://api.github.com/users/nknize/following{/other_user}","gists_url":"https://api.github.com/users/nknize/gists{/gist_id}","starred_url":"https://api.github.com/users/nknize/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknize/subscriptions","organizations_url":"https://api.github.com/users/nknize/orgs","repos_url":"https://api.github.com/users/nknize/repos","events_url":"https://api.github.com/users/nknize/events{/privacy}","received_events_url":"https://api.github.com/users/nknize/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nknize/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/nknize/elasticsearch","forks_url":"https://api.github.com/repos/nknize/elasticsearch/forks","keys_url":"https://api.github.com/repos/nknize/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nknize/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nknize/elasticsearch/teams","hooks_url":"https://api.github.com/repos/nknize/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/nknize/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/nknize/elasticsearch/events","assignees_url":"https://api.github.com/repos/nknize/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/nknize/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/nknize/elasticsearch/tags","blobs_url":"https://api.github.com/repos/nknize/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nknize/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nknize/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/nknize/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nknize/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/nknize/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/nknize/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/nknize/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/nknize/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/nknize/elasticsearch/subscription","commits_url":"https://api.github.com/repos/nknize/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/nknize/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/nknize/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/nknize/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/nknize/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/nknize/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nknize/elasticsearch/merges","archive_url":"https://api.github.com/repos/nknize/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nknize/elasticsearch/downloads","issues_url":"https://api.github.com/repos/nknize/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/nknize/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/nknize/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/nknize/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nknize/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/nknize/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/nknize/elasticsearch/deployments","created_at":"2014-10-28T14:11:03Z","updated_at":"2016-05-27T16:33:44Z","pushed_at":"2017-07-15T17:30:01Z","git_url":"git://github.com/nknize/elasticsearch.git","ssh_url":"git@github.com:nknize/elasticsearch.git","clone_url":"https://github.com/nknize/elasticsearch.git","svn_url":"https://github.com/nknize/elasticsearch","homepage":"http://elasticsearch.org","size":308769,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"a6bea1bf9746e22ad38e7980c00aff561b5d9ecf","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars4.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars4.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2017-07-17T14:23:20Z","pushed_at":"2017-07-17T15:45:23Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":357965,"stargazers_count":23801,"watchers_count":23801,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8408,"mirror_url":null,"open_issues_count":1297,"forks":8408,"open_issues":1297,"watchers":23801,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25738"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/25738"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/25738"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/25738/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25738/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/25738/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/618233323a660708ae88de1f735523fffc95289f"}}}}
{"actor":{"display_login":"jpountz"}}