{"action":"created","comment":{"url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/comments/156413454","pull_request_review_id":82884141,"id":156413454,"diff_hunk":"@@ -63,87 +65,102 @@\n     @Autowired\n     public SelectProtectionDomains(NodeService nodeService, DataServiceRepository repository)\n     {\n-        super(LOGGER, \"Select Protection Domains\");\n+        super(LOGGER,\"Select ProtectionDomain\");\n         this.nodeService = nodeService;\n         this.repository = repository;\n     }\n \n     @Override\n     public void delegateExecute(final DelegateExecution delegateExecution)\n     {\n-        NodeDetail nodeDetail = (NodeDetail) delegateExecution.getVariable(NODE_DETAIL);\n-        updateDelegateStatus(\"Selecting Protection Domain for Node \" + nodeDetail.getServiceTag() + \".\");\n-        EssValidateProtectionDomainsResponseMessage protectionDomainResponse = null;\n-        final List<ProtectionDomain> protectionDomainList = new ArrayList<>();\n+        LOGGER.info(\"Execute ProtectionDomain \");\n         try\n         {\n-            final NodeData nodeData = new NodeData();\n-            final String uuid = nodeDetail.getId();\n-            nodeData.setSymphonyUuid(uuid);\n-            nodeData.setType(getNodeType(uuid));\n+\n+            List<NodeDetail> nodeDetails = (List<NodeDetail>) delegateExecution.getVariable(NODE_DETAILS);\n+\n+            List<NodeData> nodeDataList = new ArrayList<>();\n+\n+            for(NodeDetail nodeDetail : nodeDetails)\n+            {\n+                NodeData nodeData = new NodeData();\n+                String uuid = nodeDetail.getId();\n+                nodeData.setSymphonyUuid(uuid);\n+                nodeData.setType(getNodeType(uuid));\n+                nodeDataList.add(nodeData);\n+            }\n+\n+            updateDelegateStatus(\"Selecting Protection Domain for Nodes\");\n+\n             final List<ScaleIOData> scaleIODataList = nodeService.listScaleIOData();\n \n             final ScaleIOData scaleIo = scaleIODataList.get(0);\n \n             final List<ScaleIOProtectionDomain> protectionDomains = scaleIo.getProtectionDomains();\n \n+            final List<ProtectionDomain> protectionDomainList = new ArrayList<>();\n+\n             if (!org.springframework.util.CollectionUtils.isEmpty(protectionDomains))","path":"dne-paqx/src/main/java/com/dell/cpsd/paqx/dne/service/delegates/SelectProtectionDomains.java","position":100,"original_position":100,"commit_id":"d86d38bf4da2937c9bf98e45ce9a9ffa3e35ddd1","original_commit_id":"d86d38bf4da2937c9bf98e45ce9a9ffa3e35ddd1","user":{"login":"aroberson","id":5630480,"avatar_url":"https://avatars1.githubusercontent.com/u/5630480?v=4","gravatar_id":"","url":"https://api.github.com/users/aroberson","html_url":"https://github.com/aroberson","followers_url":"https://api.github.com/users/aroberson/followers","following_url":"https://api.github.com/users/aroberson/following{/other_user}","gists_url":"https://api.github.com/users/aroberson/gists{/gist_id}","starred_url":"https://api.github.com/users/aroberson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aroberson/subscriptions","organizations_url":"https://api.github.com/users/aroberson/orgs","repos_url":"https://api.github.com/users/aroberson/repos","events_url":"https://api.github.com/users/aroberson/events{/privacy}","received_events_url":"https://api.github.com/users/aroberson/received_events","type":"User","site_admin":false},"body":"Use apache commons CollectionUtils.isNotEmpty()","created_at":"2017-12-12T16:09:35Z","updated_at":"2017-12-12T16:22:09Z","html_url":"https://github.com/dellemc-symphony/dne-paqx-parent/pull/472#discussion_r156413454","pull_request_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/472","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/comments/156413454"},"html":{"href":"https://github.com/dellemc-symphony/dne-paqx-parent/pull/472#discussion_r156413454"},"pull_request":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/472"}}},"pull_request":{"url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/472","id":157744825,"html_url":"https://github.com/dellemc-symphony/dne-paqx-parent/pull/472","diff_url":"https://github.com/dellemc-symphony/dne-paqx-parent/pull/472.diff","patch_url":"https://github.com/dellemc-symphony/dne-paqx-parent/pull/472.patch","issue_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/issues/472","number":472,"state":"open","locked":false,"title":"ESTS-137908 Selects Protection Domain for multi-node","user":{"login":"arunrordell","id":17710941,"avatar_url":"https://avatars3.githubusercontent.com/u/17710941?v=4","gravatar_id":"","url":"https://api.github.com/users/arunrordell","html_url":"https://github.com/arunrordell","followers_url":"https://api.github.com/users/arunrordell/followers","following_url":"https://api.github.com/users/arunrordell/following{/other_user}","gists_url":"https://api.github.com/users/arunrordell/gists{/gist_id}","starred_url":"https://api.github.com/users/arunrordell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunrordell/subscriptions","organizations_url":"https://api.github.com/users/arunrordell/orgs","repos_url":"https://api.github.com/users/arunrordell/repos","events_url":"https://api.github.com/users/arunrordell/events{/privacy}","received_events_url":"https://api.github.com/users/arunrordell/received_events","type":"User","site_admin":false},"body":" This PR send the nodeDataList and protectionDomainList to ESS. ESS\r\n will assign nodes based on the rules applied along with warning messages.\r\n NodeDetail gets protectionDomain Field gets updated based on the returned protectionDomains.","created_at":"2017-12-12T06:12:37Z","updated_at":"2017-12-12T16:22:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e314ea74fddd772ac9283bb293143e27bbc101e9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/472/commits","review_comments_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/472/comments","review_comment_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/issues/472/comments","statuses_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/statuses/d86d38bf4da2937c9bf98e45ce9a9ffa3e35ddd1","head":{"label":"arunrordell:tpd","ref":"tpd","sha":"d86d38bf4da2937c9bf98e45ce9a9ffa3e35ddd1","user":{"login":"arunrordell","id":17710941,"avatar_url":"https://avatars3.githubusercontent.com/u/17710941?v=4","gravatar_id":"","url":"https://api.github.com/users/arunrordell","html_url":"https://github.com/arunrordell","followers_url":"https://api.github.com/users/arunrordell/followers","following_url":"https://api.github.com/users/arunrordell/following{/other_user}","gists_url":"https://api.github.com/users/arunrordell/gists{/gist_id}","starred_url":"https://api.github.com/users/arunrordell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunrordell/subscriptions","organizations_url":"https://api.github.com/users/arunrordell/orgs","repos_url":"https://api.github.com/users/arunrordell/repos","events_url":"https://api.github.com/users/arunrordell/events{/privacy}","received_events_url":"https://api.github.com/users/arunrordell/received_events","type":"User","site_admin":false},"repo":{"id":112214498,"name":"dne-paqx-parent","full_name":"arunrordell/dne-paqx-parent","owner":{"login":"arunrordell","id":17710941,"avatar_url":"https://avatars3.githubusercontent.com/u/17710941?v=4","gravatar_id":"","url":"https://api.github.com/users/arunrordell","html_url":"https://github.com/arunrordell","followers_url":"https://api.github.com/users/arunrordell/followers","following_url":"https://api.github.com/users/arunrordell/following{/other_user}","gists_url":"https://api.github.com/users/arunrordell/gists{/gist_id}","starred_url":"https://api.github.com/users/arunrordell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arunrordell/subscriptions","organizations_url":"https://api.github.com/users/arunrordell/orgs","repos_url":"https://api.github.com/users/arunrordell/repos","events_url":"https://api.github.com/users/arunrordell/events{/privacy}","received_events_url":"https://api.github.com/users/arunrordell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arunrordell/dne-paqx-parent","description":null,"fork":true,"url":"https://api.github.com/repos/arunrordell/dne-paqx-parent","forks_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/forks","keys_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/teams","hooks_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/hooks","issue_events_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/issues/events{/number}","events_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/events","assignees_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/assignees{/user}","branches_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/branches{/branch}","tags_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/tags","blobs_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/git/refs{/sha}","trees_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/statuses/{sha}","languages_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/languages","stargazers_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/stargazers","contributors_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/contributors","subscribers_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/subscribers","subscription_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/subscription","commits_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/commits{/sha}","git_commits_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/git/commits{/sha}","comments_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/comments{/number}","issue_comment_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/issues/comments{/number}","contents_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/contents/{+path}","compare_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/merges","archive_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/downloads","issues_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/issues{/number}","pulls_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/pulls{/number}","milestones_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/milestones{/number}","notifications_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/labels{/name}","releases_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/releases{/id}","deployments_url":"https://api.github.com/repos/arunrordell/dne-paqx-parent/deployments","created_at":"2017-11-27T15:36:05Z","updated_at":"2017-11-27T15:36:08Z","pushed_at":"2017-12-12T16:02:26Z","git_url":"git://github.com/arunrordell/dne-paqx-parent.git","ssh_url":"git@github.com:arunrordell/dne-paqx-parent.git","clone_url":"https://github.com/arunrordell/dne-paqx-parent.git","svn_url":"https://github.com/arunrordell/dne-paqx-parent","homepage":null,"size":2228,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dellemc-symphony:master","ref":"master","sha":"0d81f4223c96b545edd8265b001c3580d0e25829","user":{"login":"dellemc-symphony","id":25174736,"avatar_url":"https://avatars0.githubusercontent.com/u/25174736?v=4","gravatar_id":"","url":"https://api.github.com/users/dellemc-symphony","html_url":"https://github.com/dellemc-symphony","followers_url":"https://api.github.com/users/dellemc-symphony/followers","following_url":"https://api.github.com/users/dellemc-symphony/following{/other_user}","gists_url":"https://api.github.com/users/dellemc-symphony/gists{/gist_id}","starred_url":"https://api.github.com/users/dellemc-symphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellemc-symphony/subscriptions","organizations_url":"https://api.github.com/users/dellemc-symphony/orgs","repos_url":"https://api.github.com/users/dellemc-symphony/repos","events_url":"https://api.github.com/users/dellemc-symphony/events{/privacy}","received_events_url":"https://api.github.com/users/dellemc-symphony/received_events","type":"Organization","site_admin":false},"repo":{"id":90753945,"name":"dne-paqx-parent","full_name":"dellemc-symphony/dne-paqx-parent","owner":{"login":"dellemc-symphony","id":25174736,"avatar_url":"https://avatars0.githubusercontent.com/u/25174736?v=4","gravatar_id":"","url":"https://api.github.com/users/dellemc-symphony","html_url":"https://github.com/dellemc-symphony","followers_url":"https://api.github.com/users/dellemc-symphony/followers","following_url":"https://api.github.com/users/dellemc-symphony/following{/other_user}","gists_url":"https://api.github.com/users/dellemc-symphony/gists{/gist_id}","starred_url":"https://api.github.com/users/dellemc-symphony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dellemc-symphony/subscriptions","organizations_url":"https://api.github.com/users/dellemc-symphony/orgs","repos_url":"https://api.github.com/users/dellemc-symphony/repos","events_url":"https://api.github.com/users/dellemc-symphony/events{/privacy}","received_events_url":"https://api.github.com/users/dellemc-symphony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dellemc-symphony/dne-paqx-parent","description":null,"fork":false,"url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent","forks_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/forks","keys_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/teams","hooks_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/hooks","issue_events_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/issues/events{/number}","events_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/events","assignees_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/assignees{/user}","branches_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/branches{/branch}","tags_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/tags","blobs_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/git/refs{/sha}","trees_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/statuses/{sha}","languages_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/languages","stargazers_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/stargazers","contributors_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/contributors","subscribers_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/subscribers","subscription_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/subscription","commits_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/commits{/sha}","git_commits_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/git/commits{/sha}","comments_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/comments{/number}","issue_comment_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/issues/comments{/number}","contents_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/contents/{+path}","compare_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/merges","archive_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/downloads","issues_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/issues{/number}","pulls_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls{/number}","milestones_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/milestones{/number}","notifications_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/labels{/name}","releases_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/releases{/id}","deployments_url":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/deployments","created_at":"2017-05-09T14:17:47Z","updated_at":"2017-11-10T02:20:46Z","pushed_at":"2017-12-12T16:02:28Z","git_url":"git://github.com/dellemc-symphony/dne-paqx-parent.git","ssh_url":"git@github.com:dellemc-symphony/dne-paqx-parent.git","clone_url":"https://github.com/dellemc-symphony/dne-paqx-parent.git","svn_url":"https://github.com/dellemc-symphony/dne-paqx-parent","homepage":null,"size":2219,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":15,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/472"},"html":{"href":"https://github.com/dellemc-symphony/dne-paqx-parent/pull/472"},"issue":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/issues/472"},"comments":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/issues/472/comments"},"review_comments":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/472/comments"},"review_comment":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/pulls/472/commits"},"statuses":{"href":"https://api.github.com/repos/dellemc-symphony/dne-paqx-parent/statuses/d86d38bf4da2937c9bf98e45ce9a9ffa3e35ddd1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aroberson"}}