{"action":"opened","number":5705,"pull_request":{"url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/5705","id":113915408,"html_url":"https://github.com/alphagov/govuk-puppet/pull/5705","diff_url":"https://github.com/alphagov/govuk-puppet/pull/5705.diff","patch_url":"https://github.com/alphagov/govuk-puppet/pull/5705.patch","issue_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/5705","number":5705,"state":"open","locked":false,"title":"Enable email notifications for the Jenkins Deploy App","user":{"login":"chrisroos","id":6556,"avatar_url":"https://avatars1.githubusercontent.com/u/6556?v=3","gravatar_id":"","url":"https://api.github.com/users/chrisroos","html_url":"https://github.com/chrisroos","followers_url":"https://api.github.com/users/chrisroos/followers","following_url":"https://api.github.com/users/chrisroos/following{/other_user}","gists_url":"https://api.github.com/users/chrisroos/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisroos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisroos/subscriptions","organizations_url":"https://api.github.com/users/chrisroos/orgs","repos_url":"https://api.github.com/users/chrisroos/repos","events_url":"https://api.github.com/users/chrisroos/events{/privacy}","received_events_url":"https://api.github.com/users/chrisroos/received_events","type":"User","site_admin":false},"body":"I want to be notified as soon as possible if any of my changes mean that\r\nan app can't be deployed to integration.\r\n\r\nA recent change to manuals-publisher caused the deployment to\r\nintegration to fail. We only became aware of this problem when we tried\r\nto deploy to production and were informed by 2ndline. We (Go Free Range)\r\nrecall having a similar problem when working on smart-answers.\r\n\r\nNOTE. Although my use case is for deployments to integration the change\r\nin this commit will mean that we're notified of deployment failures for\r\nall environments.\r\n\r\nI've looked through the history of this file to see whether we've\r\npreviously removed these notifications (i.e. whether this commit is\r\nreverting a previous commit) but that doesn't seem to be the case.\r\n\r\nI copied the email configuration from the\r\nintegration_app_deployment.yaml.erb file as I know I've seen email\r\nnotifications from that Job in Jenkins.\r\n\r\nI haven't added a test for this change as we don't appear to have added\r\ntests for similar changes in the past.","created_at":"2017-04-03T12:06:34Z","updated_at":"2017-04-03T12:06:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/5705/commits","review_comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/5705/comments","review_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/5705/comments","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/b4ffa4d44c552db5647f4d5665bc95b53610b1ee","head":{"label":"alphagov:enable-email-notifications-for-deploy-app-jenkins-job","ref":"enable-email-notifications-for-deploy-app-jenkins-job","sha":"b4ffa4d44c552db5647f4d5665bc95b53610b1ee","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":47834743,"name":"govuk-puppet","full_name":"alphagov/govuk-puppet","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-puppet","description":"Puppet manifests used to provision the main GOV.UK web stack","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-puppet","forks_url":"https://api.github.com/repos/alphagov/govuk-puppet/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-puppet/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-puppet/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-puppet/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-puppet/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-puppet/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-puppet/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-puppet/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-puppet/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-puppet/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-puppet/deployments","created_at":"2015-12-11T15:36:24Z","updated_at":"2017-03-24T08:54:26Z","pushed_at":"2017-04-03T12:06:01Z","git_url":"git://github.com/alphagov/govuk-puppet.git","ssh_url":"git@github.com:alphagov/govuk-puppet.git","clone_url":"https://github.com/alphagov/govuk-puppet.git","svn_url":"https://github.com/alphagov/govuk-puppet","homepage":"https://www.gov.uk/","size":26727,"stargazers_count":45,"watchers_count":45,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":16,"forks":19,"open_issues":16,"watchers":45,"default_branch":"master"}},"base":{"label":"alphagov:master","ref":"master","sha":"c9adb8f2d8ae49230470327a33baacf0ad8e9faa","user":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"repo":{"id":47834743,"name":"govuk-puppet","full_name":"alphagov/govuk-puppet","owner":{"login":"alphagov","id":596977,"avatar_url":"https://avatars3.githubusercontent.com/u/596977?v=3","gravatar_id":"","url":"https://api.github.com/users/alphagov","html_url":"https://github.com/alphagov","followers_url":"https://api.github.com/users/alphagov/followers","following_url":"https://api.github.com/users/alphagov/following{/other_user}","gists_url":"https://api.github.com/users/alphagov/gists{/gist_id}","starred_url":"https://api.github.com/users/alphagov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alphagov/subscriptions","organizations_url":"https://api.github.com/users/alphagov/orgs","repos_url":"https://api.github.com/users/alphagov/repos","events_url":"https://api.github.com/users/alphagov/events{/privacy}","received_events_url":"https://api.github.com/users/alphagov/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alphagov/govuk-puppet","description":"Puppet manifests used to provision the main GOV.UK web stack","fork":false,"url":"https://api.github.com/repos/alphagov/govuk-puppet","forks_url":"https://api.github.com/repos/alphagov/govuk-puppet/forks","keys_url":"https://api.github.com/repos/alphagov/govuk-puppet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alphagov/govuk-puppet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alphagov/govuk-puppet/teams","hooks_url":"https://api.github.com/repos/alphagov/govuk-puppet/hooks","issue_events_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/events{/number}","events_url":"https://api.github.com/repos/alphagov/govuk-puppet/events","assignees_url":"https://api.github.com/repos/alphagov/govuk-puppet/assignees{/user}","branches_url":"https://api.github.com/repos/alphagov/govuk-puppet/branches{/branch}","tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/tags","blobs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/refs{/sha}","trees_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/{sha}","languages_url":"https://api.github.com/repos/alphagov/govuk-puppet/languages","stargazers_url":"https://api.github.com/repos/alphagov/govuk-puppet/stargazers","contributors_url":"https://api.github.com/repos/alphagov/govuk-puppet/contributors","subscribers_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscribers","subscription_url":"https://api.github.com/repos/alphagov/govuk-puppet/subscription","commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/commits{/sha}","git_commits_url":"https://api.github.com/repos/alphagov/govuk-puppet/git/commits{/sha}","comments_url":"https://api.github.com/repos/alphagov/govuk-puppet/comments{/number}","issue_comment_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues/comments{/number}","contents_url":"https://api.github.com/repos/alphagov/govuk-puppet/contents/{+path}","compare_url":"https://api.github.com/repos/alphagov/govuk-puppet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alphagov/govuk-puppet/merges","archive_url":"https://api.github.com/repos/alphagov/govuk-puppet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alphagov/govuk-puppet/downloads","issues_url":"https://api.github.com/repos/alphagov/govuk-puppet/issues{/number}","pulls_url":"https://api.github.com/repos/alphagov/govuk-puppet/pulls{/number}","milestones_url":"https://api.github.com/repos/alphagov/govuk-puppet/milestones{/number}","notifications_url":"https://api.github.com/repos/alphagov/govuk-puppet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alphagov/govuk-puppet/labels{/name}","releases_url":"https://api.github.com/repos/alphagov/govuk-puppet/releases{/id}","deployments_url":"https://api.github.com/repos/alphagov/govuk-puppet/deployments","created_at":"2015-12-11T15:36:24Z","updated_at":"2017-03-24T08:54:26Z","pushed_at":"2017-04-03T12:06:01Z","git_url":"git://github.com/alphagov/govuk-puppet.git","ssh_url":"git@github.com:alphagov/govuk-puppet.git","clone_url":"https://github.com/alphagov/govuk-puppet.git","svn_url":"https://github.com/alphagov/govuk-puppet","homepage":"https://www.gov.uk/","size":26727,"stargazers_count":45,"watchers_count":45,"language":"Puppet","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"open_issues_count":16,"forks":19,"open_issues":16,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/5705"},"html":{"href":"https://github.com/alphagov/govuk-puppet/pull/5705"},"issue":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/issues/5705"},"comments":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/issues/5705/comments"},"review_comments":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/5705/comments"},"review_comment":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/pulls/5705/commits"},"statuses":{"href":"https://api.github.com/repos/alphagov/govuk-puppet/statuses/b4ffa4d44c552db5647f4d5665bc95b53610b1ee"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"chrisroos"}}