{"action":"created","comment":{"url":"https://api.github.com/repos/X-DataInitiative/tick/pulls/comments/137029223","pull_request_review_id":60636432,"id":137029223,"diff_hunk":"@@ -51,12 +53,15 @@ class SVRG(SolverFirstOrderSto):\n         Information along iteration is recorded in history each time the\n         iteration number of a multiple of ``record_every``\n \n-    variance_reduction : {'last', 'avg', 'rand'}, default = last\n+    Other Parameters\n+    ----------------\n+    variance_reduction : {'last', 'avg', 'rand'}, default='last'\n         Determine what is used as phase iterate for variance reduction.\n \n         * 'last' : the phase iterate is the last iterate of the previous epoch\n         * 'avg' : the phase iterate is the average over the iterates in the past\n-          epoch\n+          epoch. This is a really bad idea when using delayed updates (with\n+          sparse datasets, a warning will be raised in this case)","path":"tick/optim/solver/svrg.py","position":33,"original_position":33,"commit_id":"080e692361065e569cfccc66d765d84b2e214c60","original_commit_id":"080e692361065e569cfccc66d765d84b2e214c60","user":{"login":"Mbompr","id":1908833,"avatar_url":"https://avatars1.githubusercontent.com/u/1908833?v=4","gravatar_id":"","url":"https://api.github.com/users/Mbompr","html_url":"https://github.com/Mbompr","followers_url":"https://api.github.com/users/Mbompr/followers","following_url":"https://api.github.com/users/Mbompr/following{/other_user}","gists_url":"https://api.github.com/users/Mbompr/gists{/gist_id}","starred_url":"https://api.github.com/users/Mbompr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mbompr/subscriptions","organizations_url":"https://api.github.com/users/Mbompr/orgs","repos_url":"https://api.github.com/users/Mbompr/repos","events_url":"https://api.github.com/users/Mbompr/events{/privacy}","received_events_url":"https://api.github.com/users/Mbompr/received_events","type":"User","site_admin":false},"body":"We don't mention delayed updates anymore","created_at":"2017-09-05T15:47:55Z","updated_at":"2017-09-05T15:51:04Z","html_url":"https://github.com/X-DataInitiative/tick/pull/61#discussion_r137029223","pull_request_url":"https://api.github.com/repos/X-DataInitiative/tick/pulls/61","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/X-DataInitiative/tick/pulls/comments/137029223"},"html":{"href":"https://github.com/X-DataInitiative/tick/pull/61#discussion_r137029223"},"pull_request":{"href":"https://api.github.com/repos/X-DataInitiative/tick/pulls/61"}},"in_reply_to_id":137029160},"pull_request":{"url":"https://api.github.com/repos/X-DataInitiative/tick/pulls/61","id":134905214,"html_url":"https://github.com/X-DataInitiative/tick/pull/61","diff_url":"https://github.com/X-DataInitiative/tick/pull/61.diff","patch_url":"https://github.com/X-DataInitiative/tick/pull/61.patch","issue_url":"https://api.github.com/repos/X-DataInitiative/tick/issues/61","number":61,"state":"open","locked":false,"title":"TICK-373 Full sparse support in SVRG","user":{"login":"stephanegaiffas","id":3238780,"avatar_url":"https://avatars0.githubusercontent.com/u/3238780?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanegaiffas","html_url":"https://github.com/stephanegaiffas","followers_url":"https://api.github.com/users/stephanegaiffas/followers","following_url":"https://api.github.com/users/stephanegaiffas/following{/other_user}","gists_url":"https://api.github.com/users/stephanegaiffas/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanegaiffas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanegaiffas/subscriptions","organizations_url":"https://api.github.com/users/stephanegaiffas/orgs","repos_url":"https://api.github.com/users/stephanegaiffas/repos","events_url":"https://api.github.com/users/stephanegaiffas/events{/privacy}","received_events_url":"https://api.github.com/users/stephanegaiffas/received_events","type":"User","site_admin":false},"body":"Strong improvement of SVRG for sparse data, this adds :\r\n* Fully sparse updates in the case of sparse data, when the prox is separable. \r\n\r\nFor now, SVRG only supports the so-called 'probabilistic' approach, where a correction of the step-sizes is used for each feature.\r\nThe exact updates, based on delayed computations, will be added in a future version.","created_at":"2017-08-09T14:21:03Z","updated_at":"2017-09-05T15:51:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"225fc2f813f377e1fbb4412be13914e710bef5df","assignee":{"login":"stephanegaiffas","id":3238780,"avatar_url":"https://avatars0.githubusercontent.com/u/3238780?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanegaiffas","html_url":"https://github.com/stephanegaiffas","followers_url":"https://api.github.com/users/stephanegaiffas/followers","following_url":"https://api.github.com/users/stephanegaiffas/following{/other_user}","gists_url":"https://api.github.com/users/stephanegaiffas/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanegaiffas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanegaiffas/subscriptions","organizations_url":"https://api.github.com/users/stephanegaiffas/orgs","repos_url":"https://api.github.com/users/stephanegaiffas/repos","events_url":"https://api.github.com/users/stephanegaiffas/events{/privacy}","received_events_url":"https://api.github.com/users/stephanegaiffas/received_events","type":"User","site_admin":false},"assignees":[{"login":"stephanegaiffas","id":3238780,"avatar_url":"https://avatars0.githubusercontent.com/u/3238780?v=4","gravatar_id":"","url":"https://api.github.com/users/stephanegaiffas","html_url":"https://github.com/stephanegaiffas","followers_url":"https://api.github.com/users/stephanegaiffas/followers","following_url":"https://api.github.com/users/stephanegaiffas/following{/other_user}","gists_url":"https://api.github.com/users/stephanegaiffas/gists{/gist_id}","starred_url":"https://api.github.com/users/stephanegaiffas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephanegaiffas/subscriptions","organizations_url":"https://api.github.com/users/stephanegaiffas/orgs","repos_url":"https://api.github.com/users/stephanegaiffas/repos","events_url":"https://api.github.com/users/stephanegaiffas/events{/privacy}","received_events_url":"https://api.github.com/users/stephanegaiffas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/X-DataInitiative/tick/milestones/2","html_url":"https://github.com/X-DataInitiative/tick/milestone/2","labels_url":"https://api.github.com/repos/X-DataInitiative/tick/milestones/2/labels","id":2647872,"number":2,"title":"Version 0.3","description":"","creator":{"login":"Mbompr","id":1908833,"avatar_url":"https://avatars1.githubusercontent.com/u/1908833?v=4","gravatar_id":"","url":"https://api.github.com/users/Mbompr","html_url":"https://github.com/Mbompr","followers_url":"https://api.github.com/users/Mbompr/followers","following_url":"https://api.github.com/users/Mbompr/following{/other_user}","gists_url":"https://api.github.com/users/Mbompr/gists{/gist_id}","starred_url":"https://api.github.com/users/Mbompr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mbompr/subscriptions","organizations_url":"https://api.github.com/users/Mbompr/orgs","repos_url":"https://api.github.com/users/Mbompr/repos","events_url":"https://api.github.com/users/Mbompr/events{/privacy}","received_events_url":"https://api.github.com/users/Mbompr/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":7,"state":"open","created_at":"2017-07-18T15:51:01Z","updated_at":"2017-08-28T13:11:46Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/X-DataInitiative/tick/pulls/61/commits","review_comments_url":"https://api.github.com/repos/X-DataInitiative/tick/pulls/61/comments","review_comment_url":"https://api.github.com/repos/X-DataInitiative/tick/pulls/comments{/number}","comments_url":"https://api.github.com/repos/X-DataInitiative/tick/issues/61/comments","statuses_url":"https://api.github.com/repos/X-DataInitiative/tick/statuses/080e692361065e569cfccc66d765d84b2e214c60","head":{"label":"X-DataInitiative:TICK-373-svrg-lazy-updates","ref":"TICK-373-svrg-lazy-updates","sha":"080e692361065e569cfccc66d765d84b2e214c60","user":{"login":"X-DataInitiative","id":17986992,"avatar_url":"https://avatars2.githubusercontent.com/u/17986992?v=4","gravatar_id":"","url":"https://api.github.com/users/X-DataInitiative","html_url":"https://github.com/X-DataInitiative","followers_url":"https://api.github.com/users/X-DataInitiative/followers","following_url":"https://api.github.com/users/X-DataInitiative/following{/other_user}","gists_url":"https://api.github.com/users/X-DataInitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/X-DataInitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/X-DataInitiative/subscriptions","organizations_url":"https://api.github.com/users/X-DataInitiative/orgs","repos_url":"https://api.github.com/users/X-DataInitiative/repos","events_url":"https://api.github.com/users/X-DataInitiative/events{/privacy}","received_events_url":"https://api.github.com/users/X-DataInitiative/received_events","type":"Organization","site_admin":false},"repo":{"id":75284069,"name":"tick","full_name":"X-DataInitiative/tick","owner":{"login":"X-DataInitiative","id":17986992,"avatar_url":"https://avatars2.githubusercontent.com/u/17986992?v=4","gravatar_id":"","url":"https://api.github.com/users/X-DataInitiative","html_url":"https://github.com/X-DataInitiative","followers_url":"https://api.github.com/users/X-DataInitiative/followers","following_url":"https://api.github.com/users/X-DataInitiative/following{/other_user}","gists_url":"https://api.github.com/users/X-DataInitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/X-DataInitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/X-DataInitiative/subscriptions","organizations_url":"https://api.github.com/users/X-DataInitiative/orgs","repos_url":"https://api.github.com/users/X-DataInitiative/repos","events_url":"https://api.github.com/users/X-DataInitiative/events{/privacy}","received_events_url":"https://api.github.com/users/X-DataInitiative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/X-DataInitiative/tick","description":"Module for statistical learning, with a particular emphasis on time-dependent modelling","fork":false,"url":"https://api.github.com/repos/X-DataInitiative/tick","forks_url":"https://api.github.com/repos/X-DataInitiative/tick/forks","keys_url":"https://api.github.com/repos/X-DataInitiative/tick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/X-DataInitiative/tick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/X-DataInitiative/tick/teams","hooks_url":"https://api.github.com/repos/X-DataInitiative/tick/hooks","issue_events_url":"https://api.github.com/repos/X-DataInitiative/tick/issues/events{/number}","events_url":"https://api.github.com/repos/X-DataInitiative/tick/events","assignees_url":"https://api.github.com/repos/X-DataInitiative/tick/assignees{/user}","branches_url":"https://api.github.com/repos/X-DataInitiative/tick/branches{/branch}","tags_url":"https://api.github.com/repos/X-DataInitiative/tick/tags","blobs_url":"https://api.github.com/repos/X-DataInitiative/tick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/X-DataInitiative/tick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/X-DataInitiative/tick/git/refs{/sha}","trees_url":"https://api.github.com/repos/X-DataInitiative/tick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/X-DataInitiative/tick/statuses/{sha}","languages_url":"https://api.github.com/repos/X-DataInitiative/tick/languages","stargazers_url":"https://api.github.com/repos/X-DataInitiative/tick/stargazers","contributors_url":"https://api.github.com/repos/X-DataInitiative/tick/contributors","subscribers_url":"https://api.github.com/repos/X-DataInitiative/tick/subscribers","subscription_url":"https://api.github.com/repos/X-DataInitiative/tick/subscription","commits_url":"https://api.github.com/repos/X-DataInitiative/tick/commits{/sha}","git_commits_url":"https://api.github.com/repos/X-DataInitiative/tick/git/commits{/sha}","comments_url":"https://api.github.com/repos/X-DataInitiative/tick/comments{/number}","issue_comment_url":"https://api.github.com/repos/X-DataInitiative/tick/issues/comments{/number}","contents_url":"https://api.github.com/repos/X-DataInitiative/tick/contents/{+path}","compare_url":"https://api.github.com/repos/X-DataInitiative/tick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/X-DataInitiative/tick/merges","archive_url":"https://api.github.com/repos/X-DataInitiative/tick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/X-DataInitiative/tick/downloads","issues_url":"https://api.github.com/repos/X-DataInitiative/tick/issues{/number}","pulls_url":"https://api.github.com/repos/X-DataInitiative/tick/pulls{/number}","milestones_url":"https://api.github.com/repos/X-DataInitiative/tick/milestones{/number}","notifications_url":"https://api.github.com/repos/X-DataInitiative/tick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/X-DataInitiative/tick/labels{/name}","releases_url":"https://api.github.com/repos/X-DataInitiative/tick/releases{/id}","deployments_url":"https://api.github.com/repos/X-DataInitiative/tick/deployments","created_at":"2016-12-01T10:59:08Z","updated_at":"2017-09-05T03:31:24Z","pushed_at":"2017-09-05T15:38:25Z","git_url":"git://github.com/X-DataInitiative/tick.git","ssh_url":"git@github.com:X-DataInitiative/tick.git","clone_url":"https://github.com/X-DataInitiative/tick.git","svn_url":"https://github.com/X-DataInitiative/tick","homepage":"https://x-datainitiative.github.io/tick/","size":23357,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":77,"default_branch":"master"}},"base":{"label":"X-DataInitiative:master","ref":"master","sha":"5e5f522a67a48256371df04adc3470a6b17160c3","user":{"login":"X-DataInitiative","id":17986992,"avatar_url":"https://avatars2.githubusercontent.com/u/17986992?v=4","gravatar_id":"","url":"https://api.github.com/users/X-DataInitiative","html_url":"https://github.com/X-DataInitiative","followers_url":"https://api.github.com/users/X-DataInitiative/followers","following_url":"https://api.github.com/users/X-DataInitiative/following{/other_user}","gists_url":"https://api.github.com/users/X-DataInitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/X-DataInitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/X-DataInitiative/subscriptions","organizations_url":"https://api.github.com/users/X-DataInitiative/orgs","repos_url":"https://api.github.com/users/X-DataInitiative/repos","events_url":"https://api.github.com/users/X-DataInitiative/events{/privacy}","received_events_url":"https://api.github.com/users/X-DataInitiative/received_events","type":"Organization","site_admin":false},"repo":{"id":75284069,"name":"tick","full_name":"X-DataInitiative/tick","owner":{"login":"X-DataInitiative","id":17986992,"avatar_url":"https://avatars2.githubusercontent.com/u/17986992?v=4","gravatar_id":"","url":"https://api.github.com/users/X-DataInitiative","html_url":"https://github.com/X-DataInitiative","followers_url":"https://api.github.com/users/X-DataInitiative/followers","following_url":"https://api.github.com/users/X-DataInitiative/following{/other_user}","gists_url":"https://api.github.com/users/X-DataInitiative/gists{/gist_id}","starred_url":"https://api.github.com/users/X-DataInitiative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/X-DataInitiative/subscriptions","organizations_url":"https://api.github.com/users/X-DataInitiative/orgs","repos_url":"https://api.github.com/users/X-DataInitiative/repos","events_url":"https://api.github.com/users/X-DataInitiative/events{/privacy}","received_events_url":"https://api.github.com/users/X-DataInitiative/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/X-DataInitiative/tick","description":"Module for statistical learning, with a particular emphasis on time-dependent modelling","fork":false,"url":"https://api.github.com/repos/X-DataInitiative/tick","forks_url":"https://api.github.com/repos/X-DataInitiative/tick/forks","keys_url":"https://api.github.com/repos/X-DataInitiative/tick/keys{/key_id}","collaborators_url":"https://api.github.com/repos/X-DataInitiative/tick/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/X-DataInitiative/tick/teams","hooks_url":"https://api.github.com/repos/X-DataInitiative/tick/hooks","issue_events_url":"https://api.github.com/repos/X-DataInitiative/tick/issues/events{/number}","events_url":"https://api.github.com/repos/X-DataInitiative/tick/events","assignees_url":"https://api.github.com/repos/X-DataInitiative/tick/assignees{/user}","branches_url":"https://api.github.com/repos/X-DataInitiative/tick/branches{/branch}","tags_url":"https://api.github.com/repos/X-DataInitiative/tick/tags","blobs_url":"https://api.github.com/repos/X-DataInitiative/tick/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/X-DataInitiative/tick/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/X-DataInitiative/tick/git/refs{/sha}","trees_url":"https://api.github.com/repos/X-DataInitiative/tick/git/trees{/sha}","statuses_url":"https://api.github.com/repos/X-DataInitiative/tick/statuses/{sha}","languages_url":"https://api.github.com/repos/X-DataInitiative/tick/languages","stargazers_url":"https://api.github.com/repos/X-DataInitiative/tick/stargazers","contributors_url":"https://api.github.com/repos/X-DataInitiative/tick/contributors","subscribers_url":"https://api.github.com/repos/X-DataInitiative/tick/subscribers","subscription_url":"https://api.github.com/repos/X-DataInitiative/tick/subscription","commits_url":"https://api.github.com/repos/X-DataInitiative/tick/commits{/sha}","git_commits_url":"https://api.github.com/repos/X-DataInitiative/tick/git/commits{/sha}","comments_url":"https://api.github.com/repos/X-DataInitiative/tick/comments{/number}","issue_comment_url":"https://api.github.com/repos/X-DataInitiative/tick/issues/comments{/number}","contents_url":"https://api.github.com/repos/X-DataInitiative/tick/contents/{+path}","compare_url":"https://api.github.com/repos/X-DataInitiative/tick/compare/{base}...{head}","merges_url":"https://api.github.com/repos/X-DataInitiative/tick/merges","archive_url":"https://api.github.com/repos/X-DataInitiative/tick/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/X-DataInitiative/tick/downloads","issues_url":"https://api.github.com/repos/X-DataInitiative/tick/issues{/number}","pulls_url":"https://api.github.com/repos/X-DataInitiative/tick/pulls{/number}","milestones_url":"https://api.github.com/repos/X-DataInitiative/tick/milestones{/number}","notifications_url":"https://api.github.com/repos/X-DataInitiative/tick/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/X-DataInitiative/tick/labels{/name}","releases_url":"https://api.github.com/repos/X-DataInitiative/tick/releases{/id}","deployments_url":"https://api.github.com/repos/X-DataInitiative/tick/deployments","created_at":"2016-12-01T10:59:08Z","updated_at":"2017-09-05T03:31:24Z","pushed_at":"2017-09-05T15:38:25Z","git_url":"git://github.com/X-DataInitiative/tick.git","ssh_url":"git@github.com:X-DataInitiative/tick.git","clone_url":"https://github.com/X-DataInitiative/tick.git","svn_url":"https://github.com/X-DataInitiative/tick","homepage":"https://x-datainitiative.github.io/tick/","size":23357,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":11,"mirror_url":null,"open_issues_count":9,"forks":11,"open_issues":9,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/X-DataInitiative/tick/pulls/61"},"html":{"href":"https://github.com/X-DataInitiative/tick/pull/61"},"issue":{"href":"https://api.github.com/repos/X-DataInitiative/tick/issues/61"},"comments":{"href":"https://api.github.com/repos/X-DataInitiative/tick/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/X-DataInitiative/tick/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/X-DataInitiative/tick/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/X-DataInitiative/tick/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/X-DataInitiative/tick/statuses/080e692361065e569cfccc66d765d84b2e214c60"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Mbompr"}}