{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments/137789195","pull_request_review_id":61504020,"id":137789195,"diff_hunk":"@@ -0,0 +1,90 @@\n+﻿// Copyright (c) .NET Foundation. All rights reserved.\n+// Licensed under the MIT License. See License.txt in the project root for license information.\n+\n+using System;\n+using DurableTaskCore = DurableTask.Core;\n+\n+namespace Microsoft.Azure.WebJobs.Extensions.DurableTask","path":"src/WebJobs.Extensions.DurableTask/RetryOptions.cs","position":7,"original_position":7,"commit_id":"fc0946804541270564050c672db0d3c6f581a3cf","original_commit_id":"fc0946804541270564050c672db0d3c6f581a3cf","user":{"login":"cgillum","id":2704139,"avatar_url":"https://avatars2.githubusercontent.com/u/2704139?v=4","gravatar_id":"","url":"https://api.github.com/users/cgillum","html_url":"https://github.com/cgillum","followers_url":"https://api.github.com/users/cgillum/followers","following_url":"https://api.github.com/users/cgillum/following{/other_user}","gists_url":"https://api.github.com/users/cgillum/gists{/gist_id}","starred_url":"https://api.github.com/users/cgillum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgillum/subscriptions","organizations_url":"https://api.github.com/users/cgillum/orgs","repos_url":"https://api.github.com/users/cgillum/repos","events_url":"https://api.github.com/users/cgillum/events{/privacy}","received_events_url":"https://api.github.com/users/cgillum/received_events","type":"User","site_admin":false},"body":"Up until this point, all public types that are intended to be used by user code went into the `Microsoft.Azure.WebJobs` namespace. This is what I observed in other extensions as well. I think we should do the same here.","created_at":"2017-09-08T13:24:26Z","updated_at":"2017-09-08T13:50:28Z","html_url":"https://github.com/Azure/azure-functions-durable-extension/pull/51#discussion_r137789195","pull_request_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/51","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments/137789195"},"html":{"href":"https://github.com/Azure/azure-functions-durable-extension/pull/51#discussion_r137789195"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/51"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/51","id":139943228,"html_url":"https://github.com/Azure/azure-functions-durable-extension/pull/51","diff_url":"https://github.com/Azure/azure-functions-durable-extension/pull/51.diff","patch_url":"https://github.com/Azure/azure-functions-durable-extension/pull/51.patch","issue_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/51","number":51,"state":"open","locked":false,"title":"Added support for retry options for activity functions.","user":{"login":"tohling","id":14911331,"avatar_url":"https://avatars1.githubusercontent.com/u/14911331?v=4","gravatar_id":"","url":"https://api.github.com/users/tohling","html_url":"https://github.com/tohling","followers_url":"https://api.github.com/users/tohling/followers","following_url":"https://api.github.com/users/tohling/following{/other_user}","gists_url":"https://api.github.com/users/tohling/gists{/gist_id}","starred_url":"https://api.github.com/users/tohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tohling/subscriptions","organizations_url":"https://api.github.com/users/tohling/orgs","repos_url":"https://api.github.com/users/tohling/repos","events_url":"https://api.github.com/users/tohling/events{/privacy}","received_events_url":"https://api.github.com/users/tohling/received_events","type":"User","site_admin":false},"body":"Addressing issue https://github.com/Azure/azure-functions-durable-extension/issues/30\r\n\r\n1. Added support for retry options using `DurableTask.Core.OrchestrationContext.ScheduleWithRetry`.\r\n\r\n      **Sample client code snippet:**\r\n      ```\r\n     // Given RetryOptions scoped to Extensions.DurableTask.RetryOptions, \r\n     RetryOptions options = new RetryOptions(TimeSpan.FromSeconds(5), 3); // FirstRetryInterval = 5 seconds, MaxNumberOfAttempts = 3\r\n     await ctx.CallFunctionWithRetryAsync(nameof(TestActivities.Throw), options, message);\r\n     ```\r\n2. Added end-to-end tests.","created_at":"2017-09-08T02:30:04Z","updated_at":"2017-09-08T13:50:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb54792dfce98c27fdf5bd5221e95e9ba6eaa204","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/51/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/51/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/51/comments","statuses_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/fc0946804541270564050c672db0d3c6f581a3cf","head":{"label":"tohling:retry","ref":"retry","sha":"fc0946804541270564050c672db0d3c6f581a3cf","user":{"login":"tohling","id":14911331,"avatar_url":"https://avatars1.githubusercontent.com/u/14911331?v=4","gravatar_id":"","url":"https://api.github.com/users/tohling","html_url":"https://github.com/tohling","followers_url":"https://api.github.com/users/tohling/followers","following_url":"https://api.github.com/users/tohling/following{/other_user}","gists_url":"https://api.github.com/users/tohling/gists{/gist_id}","starred_url":"https://api.github.com/users/tohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tohling/subscriptions","organizations_url":"https://api.github.com/users/tohling/orgs","repos_url":"https://api.github.com/users/tohling/repos","events_url":"https://api.github.com/users/tohling/events{/privacy}","received_events_url":"https://api.github.com/users/tohling/received_events","type":"User","site_admin":false},"repo":{"id":99147165,"name":"azure-functions-durable-extension","full_name":"tohling/azure-functions-durable-extension","owner":{"login":"tohling","id":14911331,"avatar_url":"https://avatars1.githubusercontent.com/u/14911331?v=4","gravatar_id":"","url":"https://api.github.com/users/tohling","html_url":"https://github.com/tohling","followers_url":"https://api.github.com/users/tohling/followers","following_url":"https://api.github.com/users/tohling/following{/other_user}","gists_url":"https://api.github.com/users/tohling/gists{/gist_id}","starred_url":"https://api.github.com/users/tohling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tohling/subscriptions","organizations_url":"https://api.github.com/users/tohling/orgs","repos_url":"https://api.github.com/users/tohling/repos","events_url":"https://api.github.com/users/tohling/events{/privacy}","received_events_url":"https://api.github.com/users/tohling/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tohling/azure-functions-durable-extension","description":"Durable Task Framework extension for Azure Functions","fork":true,"url":"https://api.github.com/repos/tohling/azure-functions-durable-extension","forks_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/forks","keys_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/teams","hooks_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/hooks","issue_events_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/issues/events{/number}","events_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/events","assignees_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/assignees{/user}","branches_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/branches{/branch}","tags_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/tags","blobs_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/languages","stargazers_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/stargazers","contributors_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/contributors","subscribers_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/subscribers","subscription_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/subscription","commits_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/contents/{+path}","compare_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/merges","archive_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/downloads","issues_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/issues{/number}","pulls_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/labels{/name}","releases_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/releases{/id}","deployments_url":"https://api.github.com/repos/tohling/azure-functions-durable-extension/deployments","created_at":"2017-08-02T18:09:15Z","updated_at":"2017-08-02T18:09:17Z","pushed_at":"2017-09-08T02:22:49Z","git_url":"git://github.com/tohling/azure-functions-durable-extension.git","ssh_url":"git@github.com:tohling/azure-functions-durable-extension.git","clone_url":"https://github.com/tohling/azure-functions-durable-extension.git","svn_url":"https://github.com/tohling/azure-functions-durable-extension","homepage":null,"size":3823,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"e34644df6c35b9f15c283d7a1399ecc9646a0089","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":93190658,"name":"azure-functions-durable-extension","full_name":"Azure/azure-functions-durable-extension","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-functions-durable-extension","description":"Durable Task Framework extension for Azure Functions","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension","forks_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/deployments","created_at":"2017-06-02T17:51:30Z","updated_at":"2017-09-06T20:46:03Z","pushed_at":"2017-09-08T02:30:05Z","git_url":"git://github.com/Azure/azure-functions-durable-extension.git","ssh_url":"git@github.com:Azure/azure-functions-durable-extension.git","clone_url":"https://github.com/Azure/azure-functions-durable-extension.git","svn_url":"https://github.com/Azure/azure-functions-durable-extension","homepage":null,"size":3817,"stargazers_count":31,"watchers_count":31,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":29,"forks":9,"open_issues":29,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/51"},"html":{"href":"https://github.com/Azure/azure-functions-durable-extension/pull/51"},"issue":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/51"},"comments":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/51/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/51/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/51/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/fc0946804541270564050c672db0d3c6f581a3cf"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cgillum"}}