{"action":"created","issue":{"url":"https://api.github.com/repos/ionic-team/ionic-v1/issues/317","repository_url":"https://api.github.com/repos/ionic-team/ionic-v1","labels_url":"https://api.github.com/repos/ionic-team/ionic-v1/issues/317/labels{/name}","comments_url":"https://api.github.com/repos/ionic-team/ionic-v1/issues/317/comments","events_url":"https://api.github.com/repos/ionic-team/ionic-v1/issues/317/events","html_url":"https://github.com/ionic-team/ionic-v1/issues/317","id":258250374,"number":317,"title":"Rounded edges of the iPhone X on ionic","user":{"login":"kas84","id":5584,"avatar_url":"https://avatars3.githubusercontent.com/u/5584?v=4","gravatar_id":"","url":"https://api.github.com/users/kas84","html_url":"https://github.com/kas84","followers_url":"https://api.github.com/users/kas84/followers","following_url":"https://api.github.com/users/kas84/following{/other_user}","gists_url":"https://api.github.com/users/kas84/gists{/gist_id}","starred_url":"https://api.github.com/users/kas84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kas84/subscriptions","organizations_url":"https://api.github.com/users/kas84/orgs","repos_url":"https://api.github.com/users/kas84/repos","events_url":"https://api.github.com/users/kas84/events{/privacy}","received_events_url":"https://api.github.com/users/kas84/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-09-16T18:40:31Z","updated_at":"2017-09-29T03:00:54Z","closed_at":null,"author_association":"NONE","body":"Hi,\r\n\r\nAre we going to have support for iPhone X UI on ionic V1?\r\n<img width=\"239\" alt=\"captura de pantalla 2017-09-16 a las 20 39 17\" src=\"https://user-images.githubusercontent.com/5584/30514922-2d204e2a-9b1f-11e7-8722-6a9d77389ac0.png\">\r\n\r\nI guess it also needs some kind of support from Cordova!"},"comment":{"url":"https://api.github.com/repos/ionic-team/ionic-v1/issues/comments/333018773","html_url":"https://github.com/ionic-team/ionic-v1/issues/317#issuecomment-333018773","issue_url":"https://api.github.com/repos/ionic-team/ionic-v1/issues/317","id":333018773,"user":{"login":"mlynch","id":11214,"avatar_url":"https://avatars3.githubusercontent.com/u/11214?v=4","gravatar_id":"","url":"https://api.github.com/users/mlynch","html_url":"https://github.com/mlynch","followers_url":"https://api.github.com/users/mlynch/followers","following_url":"https://api.github.com/users/mlynch/following{/other_user}","gists_url":"https://api.github.com/users/mlynch/gists{/gist_id}","starred_url":"https://api.github.com/users/mlynch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlynch/subscriptions","organizations_url":"https://api.github.com/users/mlynch/orgs","repos_url":"https://api.github.com/users/mlynch/repos","events_url":"https://api.github.com/users/mlynch/events{/privacy}","received_events_url":"https://api.github.com/users/mlynch/received_events","type":"User","site_admin":false},"created_at":"2017-09-29T03:00:54Z","updated_at":"2017-09-29T03:00:54Z","author_association":"OWNER","body":"We are working on a long term fix, but for those needing a solution *today*, here is what you should do (for tabbed apps in portrait mode):\r\n\r\nFirst, read our [iOS 11 blog](http://blog.ionic.io/ios-11-checklist/) and follow the steps on installing WKWebView, the updated status bar plugin, and the viewport fit meta tag change. WKWebView is required, but be mindful of the new CORS enforcement.\r\n\r\nNext, add this CSS in your `<head>` after the Ionic CSS include:\r\n\r\n```html\r\n<style>\r\n.platform-ios.platform-cordova:not(.fullscreen) .bar-header:not(.bar-subheader) {\r\n  height: calc(44px + constant(safe-area-inset-top));\r\n}\r\n\r\n\r\n.platform-ios.platform-cordova:not(.fullscreen) .bar-header:not(.bar-subheader) > * {\r\n  margin-top: constant(safe-area-inset-top);\r\n}\r\n\r\ndiv.tab-nav.tabs {\r\n  height: calc(49px + constant(safe-area-inset-bottom));\r\n}\r\n\r\nion-content.padding.scroll-content.ionic-scroll.has-header.has-tabs {\r\n  top: calc(64px + constant(safe-area-inset-top));\r\n}\r\n</style>\r\n```\r\n\r\nWith these changes my starter tabs app looks like this now:\r\n\r\n<img width=\"429\" alt=\"screen shot 2017-09-28 at 9 51 00 pm\" src=\"https://user-images.githubusercontent.com/11214/30999078-6fadb958-a498-11e7-91b2-bd9f6bd8a786.png\">\r\n\r\n_We will have an official fix for all apps very soon, but this might help some that need something today for one reason or another_"}}
{"actor":{"display_login":"mlynch"}}