{"action":"closed","issue":{"url":"https://api.github.com/repos/sofa-framework/sofa/issues/401","repository_url":"https://api.github.com/repos/sofa-framework/sofa","labels_url":"https://api.github.com/repos/sofa-framework/sofa/issues/401/labels{/name}","comments_url":"https://api.github.com/repos/sofa-framework/sofa/issues/401/comments","events_url":"https://api.github.com/repos/sofa-framework/sofa/issues/401/events","html_url":"https://github.com/sofa-framework/sofa/issues/401","id":257715088,"number":401,"title":"Wrong cmake directive for the SofaDefaultType target","user":{"login":"jnbrunet","id":6951981,"avatar_url":"https://avatars1.githubusercontent.com/u/6951981?v=4","gravatar_id":"","url":"https://api.github.com/users/jnbrunet","html_url":"https://github.com/jnbrunet","followers_url":"https://api.github.com/users/jnbrunet/followers","following_url":"https://api.github.com/users/jnbrunet/following{/other_user}","gists_url":"https://api.github.com/users/jnbrunet/gists{/gist_id}","starred_url":"https://api.github.com/users/jnbrunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnbrunet/subscriptions","organizations_url":"https://api.github.com/users/jnbrunet/orgs","repos_url":"https://api.github.com/users/jnbrunet/repos","events_url":"https://api.github.com/users/jnbrunet/events{/privacy}","received_events_url":"https://api.github.com/users/jnbrunet/received_events","type":"User","site_admin":false},"labels":[{"id":385295640,"url":"https://api.github.com/repos/sofa-framework/sofa/labels/bug","name":"bug","color":"e60000","default":true}],"state":"closed","locked":false,"assignee":{"login":"jnbrunet","id":6951981,"avatar_url":"https://avatars1.githubusercontent.com/u/6951981?v=4","gravatar_id":"","url":"https://api.github.com/users/jnbrunet","html_url":"https://github.com/jnbrunet","followers_url":"https://api.github.com/users/jnbrunet/followers","following_url":"https://api.github.com/users/jnbrunet/following{/other_user}","gists_url":"https://api.github.com/users/jnbrunet/gists{/gist_id}","starred_url":"https://api.github.com/users/jnbrunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnbrunet/subscriptions","organizations_url":"https://api.github.com/users/jnbrunet/orgs","repos_url":"https://api.github.com/users/jnbrunet/repos","events_url":"https://api.github.com/users/jnbrunet/events{/privacy}","received_events_url":"https://api.github.com/users/jnbrunet/received_events","type":"User","site_admin":false},"assignees":[{"login":"jnbrunet","id":6951981,"avatar_url":"https://avatars1.githubusercontent.com/u/6951981?v=4","gravatar_id":"","url":"https://api.github.com/users/jnbrunet","html_url":"https://github.com/jnbrunet","followers_url":"https://api.github.com/users/jnbrunet/followers","following_url":"https://api.github.com/users/jnbrunet/following{/other_user}","gists_url":"https://api.github.com/users/jnbrunet/gists{/gist_id}","starred_url":"https://api.github.com/users/jnbrunet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jnbrunet/subscriptions","organizations_url":"https://api.github.com/users/jnbrunet/orgs","repos_url":"https://api.github.com/users/jnbrunet/repos","events_url":"https://api.github.com/users/jnbrunet/events{/privacy}","received_events_url":"https://api.github.com/users/jnbrunet/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-09-14T13:14:28Z","updated_at":"2017-09-18T19:04:48Z","closed_at":"2017-09-18T19:04:48Z","author_association":"CONTRIBUTOR","body":"Inside the file defaulttype/CMakeLists.txt, the line\r\n`target_include_directories(${PROJECT_NAME} PUBLIC \"$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}>/../..\")`\r\nshould be\r\n`target_include_directories(${PROJECT_NAME} PUBLIC \"$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/../..>\")`\r\n\r\nThis error makes IDE based on cmake bleed the symbol indexing since a relative path \"../..\" is wrongly added in the sofa's CMake installed filed:\r\n\r\n```\r\n$ grep -nr \"INTERFACE.*\\.\\.\\/\\.\\.\" build/install/lib/cmake\r\n./SofaFramework/SofaFrameworkTargets.cmake:66:  INTERFACE_INCLUDE_DIRECTORIES \"${_IMPORT_PREFIX}/include;/../..\"\r\n```\r\n\r\nIf, for exemple, you create an external projet that depends on Sofa, and that this external project is placed inside ~/source/project, than any IDE based on cmake for symbol indexing such as CLion will try to parse ~/source/project/../.. which is the home directory. This will end up take a lot of resources just for symbol indexing of a small project.\r\n______________________________________________________\r\n\r\nSuggested labels: <!--- see https://github.com/sofa-framework/sofa/labels -->"}}
{"actor":{"display_login":"jnbrunet"}}