{"action":"created","issue":{"url":"https://api.github.com/repos/appirio-tech/connect-app/issues/1443","repository_url":"https://api.github.com/repos/appirio-tech/connect-app","labels_url":"https://api.github.com/repos/appirio-tech/connect-app/issues/1443/labels{/name}","comments_url":"https://api.github.com/repos/appirio-tech/connect-app/issues/1443/comments","events_url":"https://api.github.com/repos/appirio-tech/connect-app/issues/1443/events","html_url":"https://github.com/appirio-tech/connect-app/issues/1443","id":281955597,"number":1443,"title":"Don't use random color numbers","user":{"login":"vic-topcoder","id":8484061,"avatar_url":"https://avatars3.githubusercontent.com/u/8484061?v=4","gravatar_id":"","url":"https://api.github.com/users/vic-topcoder","html_url":"https://github.com/vic-topcoder","followers_url":"https://api.github.com/users/vic-topcoder/followers","following_url":"https://api.github.com/users/vic-topcoder/following{/other_user}","gists_url":"https://api.github.com/users/vic-topcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/vic-topcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vic-topcoder/subscriptions","organizations_url":"https://api.github.com/users/vic-topcoder/orgs","repos_url":"https://api.github.com/users/vic-topcoder/repos","events_url":"https://api.github.com/users/vic-topcoder/events{/privacy}","received_events_url":"https://api.github.com/users/vic-topcoder/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"ThomasKranitsas","id":4612921,"avatar_url":"https://avatars0.githubusercontent.com/u/4612921?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasKranitsas","html_url":"https://github.com/ThomasKranitsas","followers_url":"https://api.github.com/users/ThomasKranitsas/followers","following_url":"https://api.github.com/users/ThomasKranitsas/following{/other_user}","gists_url":"https://api.github.com/users/ThomasKranitsas/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasKranitsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasKranitsas/subscriptions","organizations_url":"https://api.github.com/users/ThomasKranitsas/orgs","repos_url":"https://api.github.com/users/ThomasKranitsas/repos","events_url":"https://api.github.com/users/ThomasKranitsas/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasKranitsas/received_events","type":"User","site_admin":false},"assignees":[{"login":"ThomasKranitsas","id":4612921,"avatar_url":"https://avatars0.githubusercontent.com/u/4612921?v=4","gravatar_id":"","url":"https://api.github.com/users/ThomasKranitsas","html_url":"https://github.com/ThomasKranitsas","followers_url":"https://api.github.com/users/ThomasKranitsas/followers","following_url":"https://api.github.com/users/ThomasKranitsas/following{/other_user}","gists_url":"https://api.github.com/users/ThomasKranitsas/gists{/gist_id}","starred_url":"https://api.github.com/users/ThomasKranitsas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ThomasKranitsas/subscriptions","organizations_url":"https://api.github.com/users/ThomasKranitsas/orgs","repos_url":"https://api.github.com/users/ThomasKranitsas/repos","events_url":"https://api.github.com/users/ThomasKranitsas/events{/privacy}","received_events_url":"https://api.github.com/users/ThomasKranitsas/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/appirio-tech/connect-app/milestones/27","html_url":"https://github.com/appirio-tech/connect-app/milestone/27","labels_url":"https://api.github.com/repos/appirio-tech/connect-app/milestones/27/labels","id":2945317,"number":27,"title":"Community fixes 05","description":"Created from Aha! https://topcoder.aha.io/releases/TCCONNECT-R-48","creator":{"login":"vic-topcoder","id":8484061,"avatar_url":"https://avatars3.githubusercontent.com/u/8484061?v=4","gravatar_id":"","url":"https://api.github.com/users/vic-topcoder","html_url":"https://github.com/vic-topcoder","followers_url":"https://api.github.com/users/vic-topcoder/followers","following_url":"https://api.github.com/users/vic-topcoder/following{/other_user}","gists_url":"https://api.github.com/users/vic-topcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/vic-topcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vic-topcoder/subscriptions","organizations_url":"https://api.github.com/users/vic-topcoder/orgs","repos_url":"https://api.github.com/users/vic-topcoder/repos","events_url":"https://api.github.com/users/vic-topcoder/events{/privacy}","received_events_url":"https://api.github.com/users/vic-topcoder/received_events","type":"User","site_admin":false},"open_issues":25,"closed_issues":0,"state":"open","created_at":"2017-11-29T02:18:29Z","updated_at":"2017-12-14T22:20:33Z","due_on":"2017-12-18T08:00:00Z","closed_at":null},"comments":1,"created_at":"2017-12-14T01:48:03Z","updated_at":"2017-12-18T20:13:57Z","closed_at":null,"author_association":"MEMBER","body":"In your SCSS you should only use `$tc-[color-variable]` for specifying colors. Failure to do so breaks the consistency of code and makes it super hard to modify later. Only place you're allowed to use numerical values for colors are `box-shadow` - we don't have a mixin yet, but we should include one.\r\n\r\nPlease follow the https://github.com/appirio-tech/connect-app#code-style for all bugs. We might need to be more restrictive on the use of colors.\r\n\r\nIf you search the source code for `background: #` or `background: rgba` you'll find a lot of these.\r\n\r\nThis is from the current bug bash round:\r\n![screen shot 9](https://user-images.githubusercontent.com/8484061/33971519-a91e50aa-e02d-11e7-9ecb-63dfdcc29b2c.png)\r\n\r\nAnd search result\r\n![screen shot 10](https://user-images.githubusercontent.com/8484061/33971533-bc5101fe-e02d-11e7-944a-78908ea311b9.png)\r\n![screen shot 11](https://user-images.githubusercontent.com/8484061/33971534-bc632cee-e02d-11e7-85b2-b6c4b9e4b7e5.png)\r\n\r\n\r\n@vikasrohit @gondzo please make sure we do not accept code that introduces random colors and color values in the SCSS."},"comment":{"url":"https://api.github.com/repos/appirio-tech/connect-app/issues/comments/352544789","html_url":"https://github.com/appirio-tech/connect-app/issues/1443#issuecomment-352544789","issue_url":"https://api.github.com/repos/appirio-tech/connect-app/issues/1443","id":352544789,"user":{"login":"vic-topcoder","id":8484061,"avatar_url":"https://avatars3.githubusercontent.com/u/8484061?v=4","gravatar_id":"","url":"https://api.github.com/users/vic-topcoder","html_url":"https://github.com/vic-topcoder","followers_url":"https://api.github.com/users/vic-topcoder/followers","following_url":"https://api.github.com/users/vic-topcoder/following{/other_user}","gists_url":"https://api.github.com/users/vic-topcoder/gists{/gist_id}","starred_url":"https://api.github.com/users/vic-topcoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vic-topcoder/subscriptions","organizations_url":"https://api.github.com/users/vic-topcoder/orgs","repos_url":"https://api.github.com/users/vic-topcoder/repos","events_url":"https://api.github.com/users/vic-topcoder/events{/privacy}","received_events_url":"https://api.github.com/users/vic-topcoder/received_events","type":"User","site_admin":false},"created_at":"2017-12-18T20:13:57Z","updated_at":"2017-12-18T20:13:57Z","author_association":"MEMBER","body":"@ThomasKranitsas Ping me if you find colors that are not matching and need help to match to existing palette. "}}
{"actor":{"display_login":"vic-topcoder"}}