{"action":"opened","number":133,"pull_request":{"url":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls/133","id":132757091,"html_url":"https://github.com/gwillem/magento-malware-scanner/pull/133","diff_url":"https://github.com/gwillem/magento-malware-scanner/pull/133.diff","patch_url":"https://github.com/gwillem/magento-malware-scanner/pull/133.patch","issue_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/issues/133","number":133,"state":"open","locked":false,"title":"Altered eval(atob( rule","user":{"login":"Mooey28","id":23654964,"avatar_url":"https://avatars2.githubusercontent.com/u/23654964?v=4","gravatar_id":"","url":"https://api.github.com/users/Mooey28","html_url":"https://github.com/Mooey28","followers_url":"https://api.github.com/users/Mooey28/followers","following_url":"https://api.github.com/users/Mooey28/following{/other_user}","gists_url":"https://api.github.com/users/Mooey28/gists{/gist_id}","starred_url":"https://api.github.com/users/Mooey28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mooey28/subscriptions","organizations_url":"https://api.github.com/users/Mooey28/orgs","repos_url":"https://api.github.com/users/Mooey28/repos","events_url":"https://api.github.com/users/Mooey28/events{/privacy}","received_events_url":"https://api.github.com/users/Mooey28/received_events","type":"User","site_admin":false},"body":"I have altered the rule for `eval(atob(` so as to remove the `<script>` tag. This will ensure `eval(atob(` is captured even if it is not at the start of a script (i.e. directly following the `script` tag).\r\n\r\nPlease let me know if you think this may cause false positives however. Would you expect to see `eval(atob(` within the middle of a file legitimately? On a comparison with `eval(base64_decode(` some devs do use that function to legitimately impose a form of DRM on their code so perhaps they could use `eval(atob(` similarly?\r\n\r\nI have done a search across .js on a few sample sites and did not find any FPs.","created_at":"2017-07-27T14:05:43Z","updated_at":"2017-07-27T14:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls/133/commits","review_comments_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls/133/comments","review_comment_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/issues/133/comments","statuses_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/statuses/bfc59ef69e9236c4bb81991aa57c71dcace03b02","head":{"label":"Mooey28:atob_rule_change","ref":"atob_rule_change","sha":"bfc59ef69e9236c4bb81991aa57c71dcace03b02","user":{"login":"Mooey28","id":23654964,"avatar_url":"https://avatars2.githubusercontent.com/u/23654964?v=4","gravatar_id":"","url":"https://api.github.com/users/Mooey28","html_url":"https://github.com/Mooey28","followers_url":"https://api.github.com/users/Mooey28/followers","following_url":"https://api.github.com/users/Mooey28/following{/other_user}","gists_url":"https://api.github.com/users/Mooey28/gists{/gist_id}","starred_url":"https://api.github.com/users/Mooey28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mooey28/subscriptions","organizations_url":"https://api.github.com/users/Mooey28/orgs","repos_url":"https://api.github.com/users/Mooey28/repos","events_url":"https://api.github.com/users/Mooey28/events{/privacy}","received_events_url":"https://api.github.com/users/Mooey28/received_events","type":"User","site_admin":false},"repo":{"id":98540325,"name":"magento-malware-scanner","full_name":"Mooey28/magento-malware-scanner","owner":{"login":"Mooey28","id":23654964,"avatar_url":"https://avatars2.githubusercontent.com/u/23654964?v=4","gravatar_id":"","url":"https://api.github.com/users/Mooey28","html_url":"https://github.com/Mooey28","followers_url":"https://api.github.com/users/Mooey28/followers","following_url":"https://api.github.com/users/Mooey28/following{/other_user}","gists_url":"https://api.github.com/users/Mooey28/gists{/gist_id}","starred_url":"https://api.github.com/users/Mooey28/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mooey28/subscriptions","organizations_url":"https://api.github.com/users/Mooey28/orgs","repos_url":"https://api.github.com/users/Mooey28/repos","events_url":"https://api.github.com/users/Mooey28/events{/privacy}","received_events_url":"https://api.github.com/users/Mooey28/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Mooey28/magento-malware-scanner","description":"A collection of rules and samples to detect Magento malware ","fork":true,"url":"https://api.github.com/repos/Mooey28/magento-malware-scanner","forks_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/forks","keys_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/teams","hooks_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/hooks","issue_events_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/issues/events{/number}","events_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/events","assignees_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/assignees{/user}","branches_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/branches{/branch}","tags_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/tags","blobs_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/statuses/{sha}","languages_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/languages","stargazers_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/stargazers","contributors_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/contributors","subscribers_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/subscribers","subscription_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/subscription","commits_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/contents/{+path}","compare_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/merges","archive_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/downloads","issues_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/issues{/number}","pulls_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/pulls{/number}","milestones_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/milestones{/number}","notifications_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/labels{/name}","releases_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/releases{/id}","deployments_url":"https://api.github.com/repos/Mooey28/magento-malware-scanner/deployments","created_at":"2017-07-27T13:40:03Z","updated_at":"2017-07-27T13:40:05Z","pushed_at":"2017-07-27T13:55:43Z","git_url":"git://github.com/Mooey28/magento-malware-scanner.git","ssh_url":"git@github.com:Mooey28/magento-malware-scanner.git","clone_url":"https://github.com/Mooey28/magento-malware-scanner.git","svn_url":"https://github.com/Mooey28/magento-malware-scanner","homepage":"","size":3664,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gwillem:master","ref":"master","sha":"d8f9465cce222871cdf847e9e9e15e6f583caa91","user":{"login":"gwillem","id":1145479,"avatar_url":"https://avatars3.githubusercontent.com/u/1145479?v=4","gravatar_id":"","url":"https://api.github.com/users/gwillem","html_url":"https://github.com/gwillem","followers_url":"https://api.github.com/users/gwillem/followers","following_url":"https://api.github.com/users/gwillem/following{/other_user}","gists_url":"https://api.github.com/users/gwillem/gists{/gist_id}","starred_url":"https://api.github.com/users/gwillem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwillem/subscriptions","organizations_url":"https://api.github.com/users/gwillem/orgs","repos_url":"https://api.github.com/users/gwillem/repos","events_url":"https://api.github.com/users/gwillem/events{/privacy}","received_events_url":"https://api.github.com/users/gwillem/received_events","type":"User","site_admin":false},"repo":{"id":69248979,"name":"magento-malware-scanner","full_name":"gwillem/magento-malware-scanner","owner":{"login":"gwillem","id":1145479,"avatar_url":"https://avatars3.githubusercontent.com/u/1145479?v=4","gravatar_id":"","url":"https://api.github.com/users/gwillem","html_url":"https://github.com/gwillem","followers_url":"https://api.github.com/users/gwillem/followers","following_url":"https://api.github.com/users/gwillem/following{/other_user}","gists_url":"https://api.github.com/users/gwillem/gists{/gist_id}","starred_url":"https://api.github.com/users/gwillem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gwillem/subscriptions","organizations_url":"https://api.github.com/users/gwillem/orgs","repos_url":"https://api.github.com/users/gwillem/repos","events_url":"https://api.github.com/users/gwillem/events{/privacy}","received_events_url":"https://api.github.com/users/gwillem/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gwillem/magento-malware-scanner","description":"A collection of rules and samples to detect Magento malware ","fork":false,"url":"https://api.github.com/repos/gwillem/magento-malware-scanner","forks_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/forks","keys_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/teams","hooks_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/hooks","issue_events_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/issues/events{/number}","events_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/events","assignees_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/assignees{/user}","branches_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/branches{/branch}","tags_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/tags","blobs_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/git/refs{/sha}","trees_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/statuses/{sha}","languages_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/languages","stargazers_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/stargazers","contributors_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/contributors","subscribers_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/subscribers","subscription_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/subscription","commits_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/commits{/sha}","git_commits_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/git/commits{/sha}","comments_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/comments{/number}","issue_comment_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/issues/comments{/number}","contents_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/contents/{+path}","compare_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/merges","archive_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/downloads","issues_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/issues{/number}","pulls_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls{/number}","milestones_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/milestones{/number}","notifications_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/labels{/name}","releases_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/releases{/id}","deployments_url":"https://api.github.com/repos/gwillem/magento-malware-scanner/deployments","created_at":"2016-09-26T12:44:12Z","updated_at":"2017-07-27T12:50:42Z","pushed_at":"2017-07-25T15:00:16Z","git_url":"git://github.com/gwillem/magento-malware-scanner.git","ssh_url":"git@github.com:gwillem/magento-malware-scanner.git","clone_url":"https://github.com/gwillem/magento-malware-scanner.git","svn_url":"https://github.com/gwillem/magento-malware-scanner","homepage":"","size":3664,"stargazers_count":260,"watchers_count":260,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":59,"mirror_url":null,"open_issues_count":8,"forks":59,"open_issues":8,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls/133"},"html":{"href":"https://github.com/gwillem/magento-malware-scanner/pull/133"},"issue":{"href":"https://api.github.com/repos/gwillem/magento-malware-scanner/issues/133"},"comments":{"href":"https://api.github.com/repos/gwillem/magento-malware-scanner/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gwillem/magento-malware-scanner/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/gwillem/magento-malware-scanner/statuses/bfc59ef69e9236c4bb81991aa57c71dcace03b02"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":5,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"Mooey28"}}