{"action":"created","issue":{"url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/191","repository_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder","labels_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/191/labels{/name}","comments_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/191/comments","events_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/191/events","html_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/191","id":278754155,"number":191,"title":"String Manipulation to SimpleXML and DOMDocument","user":{"login":"stutteringp0et","id":310899,"avatar_url":"https://avatars1.githubusercontent.com/u/310899?v=4","gravatar_id":"","url":"https://api.github.com/users/stutteringp0et","html_url":"https://github.com/stutteringp0et","followers_url":"https://api.github.com/users/stutteringp0et/followers","following_url":"https://api.github.com/users/stutteringp0et/following{/other_user}","gists_url":"https://api.github.com/users/stutteringp0et/gists{/gist_id}","starred_url":"https://api.github.com/users/stutteringp0et/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stutteringp0et/subscriptions","organizations_url":"https://api.github.com/users/stutteringp0et/orgs","repos_url":"https://api.github.com/users/stutteringp0et/repos","events_url":"https://api.github.com/users/stutteringp0et/events{/privacy}","received_events_url":"https://api.github.com/users/stutteringp0et/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2017-12-03T08:10:38Z","updated_at":"2017-12-03T19:24:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/pulls/191","html_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/191","diff_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/191.diff","patch_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/191.patch"},"body":"I removed the string manipulation in favor of something more developer friendly.  The drawback is that the resulting XML is not as pretty, although I did run the processed fields through DOMDocument pretty printer.  The entire resultant XML could be run through a pretty printer, but still won't achieve the tab indented node attributes.\r\n\r\nThe entire process could be made much more efficient, but this was just an initial conversion.\r\n\r\n### Summary of Changes\r\n\r\nRemoved string manipulation in favor of direct xml manipulation\r\n\r\n### Testing Instructions\r\n\r\ngenerate a form\r\n\r\n### Expected result\r\n\r\na form is generated\r\n\r\n### Actual result\r\n\r\na form is generated\r\n\r\n### Documentation Changes Required\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/comments/348807331","html_url":"https://github.com/vdm-io/Joomla-Component-Builder/pull/191#issuecomment-348807331","issue_url":"https://api.github.com/repos/vdm-io/Joomla-Component-Builder/issues/191","id":348807331,"user":{"login":"ro-ot","id":2594383,"avatar_url":"https://avatars3.githubusercontent.com/u/2594383?v=4","gravatar_id":"","url":"https://api.github.com/users/ro-ot","html_url":"https://github.com/ro-ot","followers_url":"https://api.github.com/users/ro-ot/followers","following_url":"https://api.github.com/users/ro-ot/following{/other_user}","gists_url":"https://api.github.com/users/ro-ot/gists{/gist_id}","starred_url":"https://api.github.com/users/ro-ot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro-ot/subscriptions","organizations_url":"https://api.github.com/users/ro-ot/orgs","repos_url":"https://api.github.com/users/ro-ot/repos","events_url":"https://api.github.com/users/ro-ot/events{/privacy}","received_events_url":"https://api.github.com/users/ro-ot/received_events","type":"User","site_admin":false},"created_at":"2017-12-03T19:24:55Z","updated_at":"2017-12-03T19:24:55Z","author_association":"CONTRIBUTOR","body":"Hey noting cold here just been us two for long time, hope you understand the love :100: "}}
{"actor":{"display_login":"ro-ot"}}