{"action":"created","comment":{"url":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/comments/120097294","pull_request_review_id":42031556,"id":120097294,"diff_hunk":"@@ -51,18 +83,28 @@ def table_to_json(self, tablename):\n             if len(parsed_wd_items) > 0:\n                 dict_key = cells[0].contents.title().strip()\n                 for index, item in enumerate(parsed_wd_items):\n-                    itemID = item.params[0].title()\n-                    if itemID[0] != \"Q\":\n-                        itemID = \"Q\" + itemID\n-                    parsed_wd_items[index] = itemID\n-                lookup_dict[\"mappings\"][dict_key] = {\n+                    item_id = item.params[0].title()\n+                    if item_id[0] != \"Q\":","path":"importer/LookupTable.py","position":null,"original_position":78,"commit_id":"24349b031c6c23066e820a70d59615c026fedc4f","original_commit_id":"24349b031c6c23066e820a70d59615c026fedc4f","user":{"login":"lokal-profil","id":4129218,"avatar_url":"https://avatars0.githubusercontent.com/u/4129218?v=3","gravatar_id":"","url":"https://api.github.com/users/lokal-profil","html_url":"https://github.com/lokal-profil","followers_url":"https://api.github.com/users/lokal-profil/followers","following_url":"https://api.github.com/users/lokal-profil/following{/other_user}","gists_url":"https://api.github.com/users/lokal-profil/gists{/gist_id}","starred_url":"https://api.github.com/users/lokal-profil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lokal-profil/subscriptions","organizations_url":"https://api.github.com/users/lokal-profil/orgs","repos_url":"https://api.github.com/users/lokal-profil/repos","events_url":"https://api.github.com/users/lokal-profil/events{/privacy}","received_events_url":"https://api.github.com/users/lokal-profil/received_events","type":"User","site_admin":false},"body":"user `item_id.startswith(\"Q\")` instead.","created_at":"2017-06-05T12:24:08Z","updated_at":"2017-06-05T12:24:56Z","html_url":"https://github.com/Vesihiisi/COH-tools/pull/66#discussion_r120097294","pull_request_url":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/66","_links":{"self":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/comments/120097294"},"html":{"href":"https://github.com/Vesihiisi/COH-tools/pull/66#discussion_r120097294"},"pull_request":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/66","id":123504432,"html_url":"https://github.com/Vesihiisi/COH-tools/pull/66","diff_url":"https://github.com/Vesihiisi/COH-tools/pull/66.diff","patch_url":"https://github.com/Vesihiisi/COH-tools/pull/66.patch","issue_url":"https://api.github.com/repos/Vesihiisi/COH-tools/issues/66","number":66,"state":"open","locked":false,"title":"Lookup auto","user":{"login":"Vesihiisi","id":1749153,"avatar_url":"https://avatars1.githubusercontent.com/u/1749153?v=3","gravatar_id":"","url":"https://api.github.com/users/Vesihiisi","html_url":"https://github.com/Vesihiisi","followers_url":"https://api.github.com/users/Vesihiisi/followers","following_url":"https://api.github.com/users/Vesihiisi/following{/other_user}","gists_url":"https://api.github.com/users/Vesihiisi/gists{/gist_id}","starred_url":"https://api.github.com/users/Vesihiisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vesihiisi/subscriptions","organizations_url":"https://api.github.com/users/Vesihiisi/orgs","repos_url":"https://api.github.com/users/Vesihiisi/repos","events_url":"https://api.github.com/users/Vesihiisi/events{/privacy}","received_events_url":"https://api.github.com/users/Vesihiisi/received_events","type":"User","site_admin":false},"body":"Rewrite of `lookup_table_to_json.py` as a class incorporated into the Monument workflow, so that relevant lookup tables can be fetched automatically in the beginning of the process, rather than downloaded and saved manually.\r\n\r\nImplement this in SeFornmin just to make sure it works.\r\n\r\nTask: https://phabricator.wikimedia.org/T166790","created_at":"2017-06-01T13:53:27Z","updated_at":"2017-06-05T12:24:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ebf22f14f1330d46baa61e6b68febff6b7489089","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/66/commits","review_comments_url":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/66/comments","review_comment_url":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vesihiisi/COH-tools/issues/66/comments","statuses_url":"https://api.github.com/repos/Vesihiisi/COH-tools/statuses/24349b031c6c23066e820a70d59615c026fedc4f","head":{"label":"Vesihiisi:lookup_auto","ref":"lookup_auto","sha":"24349b031c6c23066e820a70d59615c026fedc4f","user":{"login":"Vesihiisi","id":1749153,"avatar_url":"https://avatars1.githubusercontent.com/u/1749153?v=3","gravatar_id":"","url":"https://api.github.com/users/Vesihiisi","html_url":"https://github.com/Vesihiisi","followers_url":"https://api.github.com/users/Vesihiisi/followers","following_url":"https://api.github.com/users/Vesihiisi/following{/other_user}","gists_url":"https://api.github.com/users/Vesihiisi/gists{/gist_id}","starred_url":"https://api.github.com/users/Vesihiisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vesihiisi/subscriptions","organizations_url":"https://api.github.com/users/Vesihiisi/orgs","repos_url":"https://api.github.com/users/Vesihiisi/repos","events_url":"https://api.github.com/users/Vesihiisi/events{/privacy}","received_events_url":"https://api.github.com/users/Vesihiisi/received_events","type":"User","site_admin":false},"repo":{"id":76935480,"name":"COH-tools","full_name":"Vesihiisi/COH-tools","owner":{"login":"Vesihiisi","id":1749153,"avatar_url":"https://avatars1.githubusercontent.com/u/1749153?v=3","gravatar_id":"","url":"https://api.github.com/users/Vesihiisi","html_url":"https://github.com/Vesihiisi","followers_url":"https://api.github.com/users/Vesihiisi/followers","following_url":"https://api.github.com/users/Vesihiisi/following{/other_user}","gists_url":"https://api.github.com/users/Vesihiisi/gists{/gist_id}","starred_url":"https://api.github.com/users/Vesihiisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vesihiisi/subscriptions","organizations_url":"https://api.github.com/users/Vesihiisi/orgs","repos_url":"https://api.github.com/users/Vesihiisi/repos","events_url":"https://api.github.com/users/Vesihiisi/events{/privacy}","received_events_url":"https://api.github.com/users/Vesihiisi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vesihiisi/COH-tools","description":"various tools for the Connected Open Heritage data migration project","fork":false,"url":"https://api.github.com/repos/Vesihiisi/COH-tools","forks_url":"https://api.github.com/repos/Vesihiisi/COH-tools/forks","keys_url":"https://api.github.com/repos/Vesihiisi/COH-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vesihiisi/COH-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vesihiisi/COH-tools/teams","hooks_url":"https://api.github.com/repos/Vesihiisi/COH-tools/hooks","issue_events_url":"https://api.github.com/repos/Vesihiisi/COH-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Vesihiisi/COH-tools/events","assignees_url":"https://api.github.com/repos/Vesihiisi/COH-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Vesihiisi/COH-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Vesihiisi/COH-tools/tags","blobs_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vesihiisi/COH-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Vesihiisi/COH-tools/languages","stargazers_url":"https://api.github.com/repos/Vesihiisi/COH-tools/stargazers","contributors_url":"https://api.github.com/repos/Vesihiisi/COH-tools/contributors","subscribers_url":"https://api.github.com/repos/Vesihiisi/COH-tools/subscribers","subscription_url":"https://api.github.com/repos/Vesihiisi/COH-tools/subscription","commits_url":"https://api.github.com/repos/Vesihiisi/COH-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vesihiisi/COH-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vesihiisi/COH-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vesihiisi/COH-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Vesihiisi/COH-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vesihiisi/COH-tools/merges","archive_url":"https://api.github.com/repos/Vesihiisi/COH-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vesihiisi/COH-tools/downloads","issues_url":"https://api.github.com/repos/Vesihiisi/COH-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Vesihiisi/COH-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Vesihiisi/COH-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vesihiisi/COH-tools/labels{/name}","releases_url":"https://api.github.com/repos/Vesihiisi/COH-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Vesihiisi/COH-tools/deployments","created_at":"2016-12-20T07:51:44Z","updated_at":"2017-05-29T13:08:22Z","pushed_at":"2017-06-05T09:57:05Z","git_url":"git://github.com/Vesihiisi/COH-tools.git","ssh_url":"git@github.com:Vesihiisi/COH-tools.git","clone_url":"https://github.com/Vesihiisi/COH-tools.git","svn_url":"https://github.com/Vesihiisi/COH-tools","homepage":null,"size":1298,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":3,"default_branch":"master"}},"base":{"label":"Vesihiisi:master","ref":"master","sha":"9a2bdbf04dcf3925b1882df434c887233f1b3d96","user":{"login":"Vesihiisi","id":1749153,"avatar_url":"https://avatars1.githubusercontent.com/u/1749153?v=3","gravatar_id":"","url":"https://api.github.com/users/Vesihiisi","html_url":"https://github.com/Vesihiisi","followers_url":"https://api.github.com/users/Vesihiisi/followers","following_url":"https://api.github.com/users/Vesihiisi/following{/other_user}","gists_url":"https://api.github.com/users/Vesihiisi/gists{/gist_id}","starred_url":"https://api.github.com/users/Vesihiisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vesihiisi/subscriptions","organizations_url":"https://api.github.com/users/Vesihiisi/orgs","repos_url":"https://api.github.com/users/Vesihiisi/repos","events_url":"https://api.github.com/users/Vesihiisi/events{/privacy}","received_events_url":"https://api.github.com/users/Vesihiisi/received_events","type":"User","site_admin":false},"repo":{"id":76935480,"name":"COH-tools","full_name":"Vesihiisi/COH-tools","owner":{"login":"Vesihiisi","id":1749153,"avatar_url":"https://avatars1.githubusercontent.com/u/1749153?v=3","gravatar_id":"","url":"https://api.github.com/users/Vesihiisi","html_url":"https://github.com/Vesihiisi","followers_url":"https://api.github.com/users/Vesihiisi/followers","following_url":"https://api.github.com/users/Vesihiisi/following{/other_user}","gists_url":"https://api.github.com/users/Vesihiisi/gists{/gist_id}","starred_url":"https://api.github.com/users/Vesihiisi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vesihiisi/subscriptions","organizations_url":"https://api.github.com/users/Vesihiisi/orgs","repos_url":"https://api.github.com/users/Vesihiisi/repos","events_url":"https://api.github.com/users/Vesihiisi/events{/privacy}","received_events_url":"https://api.github.com/users/Vesihiisi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Vesihiisi/COH-tools","description":"various tools for the Connected Open Heritage data migration project","fork":false,"url":"https://api.github.com/repos/Vesihiisi/COH-tools","forks_url":"https://api.github.com/repos/Vesihiisi/COH-tools/forks","keys_url":"https://api.github.com/repos/Vesihiisi/COH-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vesihiisi/COH-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vesihiisi/COH-tools/teams","hooks_url":"https://api.github.com/repos/Vesihiisi/COH-tools/hooks","issue_events_url":"https://api.github.com/repos/Vesihiisi/COH-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Vesihiisi/COH-tools/events","assignees_url":"https://api.github.com/repos/Vesihiisi/COH-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Vesihiisi/COH-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Vesihiisi/COH-tools/tags","blobs_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vesihiisi/COH-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Vesihiisi/COH-tools/languages","stargazers_url":"https://api.github.com/repos/Vesihiisi/COH-tools/stargazers","contributors_url":"https://api.github.com/repos/Vesihiisi/COH-tools/contributors","subscribers_url":"https://api.github.com/repos/Vesihiisi/COH-tools/subscribers","subscription_url":"https://api.github.com/repos/Vesihiisi/COH-tools/subscription","commits_url":"https://api.github.com/repos/Vesihiisi/COH-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vesihiisi/COH-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vesihiisi/COH-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vesihiisi/COH-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vesihiisi/COH-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Vesihiisi/COH-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vesihiisi/COH-tools/merges","archive_url":"https://api.github.com/repos/Vesihiisi/COH-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vesihiisi/COH-tools/downloads","issues_url":"https://api.github.com/repos/Vesihiisi/COH-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Vesihiisi/COH-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Vesihiisi/COH-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vesihiisi/COH-tools/labels{/name}","releases_url":"https://api.github.com/repos/Vesihiisi/COH-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Vesihiisi/COH-tools/deployments","created_at":"2016-12-20T07:51:44Z","updated_at":"2017-05-29T13:08:22Z","pushed_at":"2017-06-05T09:57:05Z","git_url":"git://github.com/Vesihiisi/COH-tools.git","ssh_url":"git@github.com:Vesihiisi/COH-tools.git","clone_url":"https://github.com/Vesihiisi/COH-tools.git","svn_url":"https://github.com/Vesihiisi/COH-tools","homepage":null,"size":1298,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":11,"forks":1,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/66"},"html":{"href":"https://github.com/Vesihiisi/COH-tools/pull/66"},"issue":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/issues/66"},"comments":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/Vesihiisi/COH-tools/statuses/24349b031c6c23066e820a70d59615c026fedc4f"}}}}
{"actor":{"display_login":"lokal-profil"}}