{"action":"closed","number":11075,"pull_request":{"url":"https://api.github.com/repos/driftyco/ionic/pulls/11075","id":114445110,"html_url":"https://github.com/driftyco/ionic/pull/11075","diff_url":"https://github.com/driftyco/ionic/pull/11075.diff","patch_url":"https://github.com/driftyco/ionic/pull/11075.patch","issue_url":"https://api.github.com/repos/driftyco/ionic/issues/11075","number":11075,"state":"closed","locked":false,"title":"Added a missing parameter in the doc in setLang()","user":{"login":"musahaidari","id":8165629,"avatar_url":"https://avatars1.githubusercontent.com/u/8165629?v=3","gravatar_id":"","url":"https://api.github.com/users/musahaidari","html_url":"https://github.com/musahaidari","followers_url":"https://api.github.com/users/musahaidari/followers","following_url":"https://api.github.com/users/musahaidari/following{/other_user}","gists_url":"https://api.github.com/users/musahaidari/gists{/gist_id}","starred_url":"https://api.github.com/users/musahaidari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musahaidari/subscriptions","organizations_url":"https://api.github.com/users/musahaidari/orgs","repos_url":"https://api.github.com/users/musahaidari/repos","events_url":"https://api.github.com/users/musahaidari/events{/privacy}","received_events_url":"https://api.github.com/users/musahaidari/received_events","type":"User","site_admin":false},"body":"#### Short description of what this resolves:\r\nThe doc did not mention a required parameter for setLang(), updateDocument\r\n\r\n#### Changes proposed in this pull request:\r\n\r\n- Added the missing parameter to the doc\r\n\r\n**Ionic Version**: 1.x / 2.x\r\n","created_at":"2017-04-05T18:40:51Z","updated_at":"2017-04-06T22:44:02Z","closed_at":"2017-04-06T22:44:02Z","merged_at":"2017-04-06T22:44:02Z","merge_commit_sha":"df269bf7fba79ed75f564775814dff48c68c8f69","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/driftyco/ionic/pulls/11075/commits","review_comments_url":"https://api.github.com/repos/driftyco/ionic/pulls/11075/comments","review_comment_url":"https://api.github.com/repos/driftyco/ionic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/driftyco/ionic/issues/11075/comments","statuses_url":"https://api.github.com/repos/driftyco/ionic/statuses/5eaa937c1068c3839774e2a529375aff62466113","head":{"label":"musahaidari:patch-3","ref":"patch-3","sha":"5eaa937c1068c3839774e2a529375aff62466113","user":{"login":"musahaidari","id":8165629,"avatar_url":"https://avatars1.githubusercontent.com/u/8165629?v=3","gravatar_id":"","url":"https://api.github.com/users/musahaidari","html_url":"https://github.com/musahaidari","followers_url":"https://api.github.com/users/musahaidari/followers","following_url":"https://api.github.com/users/musahaidari/following{/other_user}","gists_url":"https://api.github.com/users/musahaidari/gists{/gist_id}","starred_url":"https://api.github.com/users/musahaidari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musahaidari/subscriptions","organizations_url":"https://api.github.com/users/musahaidari/orgs","repos_url":"https://api.github.com/users/musahaidari/repos","events_url":"https://api.github.com/users/musahaidari/events{/privacy}","received_events_url":"https://api.github.com/users/musahaidari/received_events","type":"User","site_admin":false},"repo":{"id":74881289,"name":"ionic","full_name":"musahaidari/ionic","owner":{"login":"musahaidari","id":8165629,"avatar_url":"https://avatars1.githubusercontent.com/u/8165629?v=3","gravatar_id":"","url":"https://api.github.com/users/musahaidari","html_url":"https://github.com/musahaidari","followers_url":"https://api.github.com/users/musahaidari/followers","following_url":"https://api.github.com/users/musahaidari/following{/other_user}","gists_url":"https://api.github.com/users/musahaidari/gists{/gist_id}","starred_url":"https://api.github.com/users/musahaidari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/musahaidari/subscriptions","organizations_url":"https://api.github.com/users/musahaidari/orgs","repos_url":"https://api.github.com/users/musahaidari/repos","events_url":"https://api.github.com/users/musahaidari/events{/privacy}","received_events_url":"https://api.github.com/users/musahaidari/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/musahaidari/ionic","description":"Build amazing native and progressive web apps with Angular and open web technologies. One app running on everything 🎉","fork":true,"url":"https://api.github.com/repos/musahaidari/ionic","forks_url":"https://api.github.com/repos/musahaidari/ionic/forks","keys_url":"https://api.github.com/repos/musahaidari/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/musahaidari/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/musahaidari/ionic/teams","hooks_url":"https://api.github.com/repos/musahaidari/ionic/hooks","issue_events_url":"https://api.github.com/repos/musahaidari/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/musahaidari/ionic/events","assignees_url":"https://api.github.com/repos/musahaidari/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/musahaidari/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/musahaidari/ionic/tags","blobs_url":"https://api.github.com/repos/musahaidari/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/musahaidari/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/musahaidari/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/musahaidari/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/musahaidari/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/musahaidari/ionic/languages","stargazers_url":"https://api.github.com/repos/musahaidari/ionic/stargazers","contributors_url":"https://api.github.com/repos/musahaidari/ionic/contributors","subscribers_url":"https://api.github.com/repos/musahaidari/ionic/subscribers","subscription_url":"https://api.github.com/repos/musahaidari/ionic/subscription","commits_url":"https://api.github.com/repos/musahaidari/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/musahaidari/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/musahaidari/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/musahaidari/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/musahaidari/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/musahaidari/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/musahaidari/ionic/merges","archive_url":"https://api.github.com/repos/musahaidari/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/musahaidari/ionic/downloads","issues_url":"https://api.github.com/repos/musahaidari/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/musahaidari/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/musahaidari/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/musahaidari/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/musahaidari/ionic/labels{/name}","releases_url":"https://api.github.com/repos/musahaidari/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/musahaidari/ionic/deployments","created_at":"2016-11-27T10:38:41Z","updated_at":"2016-11-27T10:38:48Z","pushed_at":"2017-04-05T18:38:22Z","git_url":"git://github.com/musahaidari/ionic.git","ssh_url":"git@github.com:musahaidari/ionic.git","clone_url":"https://github.com/musahaidari/ionic.git","svn_url":"https://github.com/musahaidari/ionic","homepage":"http://ionicframework.com/","size":69830,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"driftyco:master","ref":"master","sha":"55dfd254e5554af296ce55db455e1862a4e2aef7","user":{"login":"driftyco","id":3171503,"avatar_url":"https://avatars3.githubusercontent.com/u/3171503?v=3","gravatar_id":"","url":"https://api.github.com/users/driftyco","html_url":"https://github.com/driftyco","followers_url":"https://api.github.com/users/driftyco/followers","following_url":"https://api.github.com/users/driftyco/following{/other_user}","gists_url":"https://api.github.com/users/driftyco/gists{/gist_id}","starred_url":"https://api.github.com/users/driftyco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driftyco/subscriptions","organizations_url":"https://api.github.com/users/driftyco/orgs","repos_url":"https://api.github.com/users/driftyco/repos","events_url":"https://api.github.com/users/driftyco/events{/privacy}","received_events_url":"https://api.github.com/users/driftyco/received_events","type":"Organization","site_admin":false},"repo":{"id":12256376,"name":"ionic","full_name":"driftyco/ionic","owner":{"login":"driftyco","id":3171503,"avatar_url":"https://avatars3.githubusercontent.com/u/3171503?v=3","gravatar_id":"","url":"https://api.github.com/users/driftyco","html_url":"https://github.com/driftyco","followers_url":"https://api.github.com/users/driftyco/followers","following_url":"https://api.github.com/users/driftyco/following{/other_user}","gists_url":"https://api.github.com/users/driftyco/gists{/gist_id}","starred_url":"https://api.github.com/users/driftyco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/driftyco/subscriptions","organizations_url":"https://api.github.com/users/driftyco/orgs","repos_url":"https://api.github.com/users/driftyco/repos","events_url":"https://api.github.com/users/driftyco/events{/privacy}","received_events_url":"https://api.github.com/users/driftyco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/driftyco/ionic","description":"Build amazing native and progressive web apps with Angular and open web technologies. One app running on everything 🎉","fork":false,"url":"https://api.github.com/repos/driftyco/ionic","forks_url":"https://api.github.com/repos/driftyco/ionic/forks","keys_url":"https://api.github.com/repos/driftyco/ionic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/driftyco/ionic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/driftyco/ionic/teams","hooks_url":"https://api.github.com/repos/driftyco/ionic/hooks","issue_events_url":"https://api.github.com/repos/driftyco/ionic/issues/events{/number}","events_url":"https://api.github.com/repos/driftyco/ionic/events","assignees_url":"https://api.github.com/repos/driftyco/ionic/assignees{/user}","branches_url":"https://api.github.com/repos/driftyco/ionic/branches{/branch}","tags_url":"https://api.github.com/repos/driftyco/ionic/tags","blobs_url":"https://api.github.com/repos/driftyco/ionic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/driftyco/ionic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/driftyco/ionic/git/refs{/sha}","trees_url":"https://api.github.com/repos/driftyco/ionic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/driftyco/ionic/statuses/{sha}","languages_url":"https://api.github.com/repos/driftyco/ionic/languages","stargazers_url":"https://api.github.com/repos/driftyco/ionic/stargazers","contributors_url":"https://api.github.com/repos/driftyco/ionic/contributors","subscribers_url":"https://api.github.com/repos/driftyco/ionic/subscribers","subscription_url":"https://api.github.com/repos/driftyco/ionic/subscription","commits_url":"https://api.github.com/repos/driftyco/ionic/commits{/sha}","git_commits_url":"https://api.github.com/repos/driftyco/ionic/git/commits{/sha}","comments_url":"https://api.github.com/repos/driftyco/ionic/comments{/number}","issue_comment_url":"https://api.github.com/repos/driftyco/ionic/issues/comments{/number}","contents_url":"https://api.github.com/repos/driftyco/ionic/contents/{+path}","compare_url":"https://api.github.com/repos/driftyco/ionic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/driftyco/ionic/merges","archive_url":"https://api.github.com/repos/driftyco/ionic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/driftyco/ionic/downloads","issues_url":"https://api.github.com/repos/driftyco/ionic/issues{/number}","pulls_url":"https://api.github.com/repos/driftyco/ionic/pulls{/number}","milestones_url":"https://api.github.com/repos/driftyco/ionic/milestones{/number}","notifications_url":"https://api.github.com/repos/driftyco/ionic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/driftyco/ionic/labels{/name}","releases_url":"https://api.github.com/repos/driftyco/ionic/releases{/id}","deployments_url":"https://api.github.com/repos/driftyco/ionic/deployments","created_at":"2013-08-20T23:06:02Z","updated_at":"2017-04-06T22:24:19Z","pushed_at":"2017-04-06T22:44:02Z","git_url":"git://github.com/driftyco/ionic.git","ssh_url":"git@github.com:driftyco/ionic.git","clone_url":"https://github.com/driftyco/ionic.git","svn_url":"https://github.com/driftyco/ionic","homepage":"http://ionicframework.com/","size":71306,"stargazers_count":28849,"watchers_count":28849,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7230,"mirror_url":null,"open_issues_count":756,"forks":7230,"open_issues":756,"watchers":28849,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11075"},"html":{"href":"https://github.com/driftyco/ionic/pull/11075"},"issue":{"href":"https://api.github.com/repos/driftyco/ionic/issues/11075"},"comments":{"href":"https://api.github.com/repos/driftyco/ionic/issues/11075/comments"},"review_comments":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11075/comments"},"review_comment":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/driftyco/ionic/pulls/11075/commits"},"statuses":{"href":"https://api.github.com/repos/driftyco/ionic/statuses/5eaa937c1068c3839774e2a529375aff62466113"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"brandyscarney","id":6577830,"avatar_url":"https://avatars2.githubusercontent.com/u/6577830?v=3","gravatar_id":"","url":"https://api.github.com/users/brandyscarney","html_url":"https://github.com/brandyscarney","followers_url":"https://api.github.com/users/brandyscarney/followers","following_url":"https://api.github.com/users/brandyscarney/following{/other_user}","gists_url":"https://api.github.com/users/brandyscarney/gists{/gist_id}","starred_url":"https://api.github.com/users/brandyscarney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brandyscarney/subscriptions","organizations_url":"https://api.github.com/users/brandyscarney/orgs","repos_url":"https://api.github.com/users/brandyscarney/repos","events_url":"https://api.github.com/users/brandyscarney/events{/privacy}","received_events_url":"https://api.github.com/users/brandyscarney/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"brandyscarney"}}