{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55112","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55112/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55112/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55112/events","html_url":"https://github.com/kubernetes/kubernetes/pull/55112","id":271245254,"number":55112,"title":"Block volume: Command line printer update","user":{"login":"mtanino","id":19844283,"avatar_url":"https://avatars0.githubusercontent.com/u/19844283?v=4","gravatar_id":"","url":"https://api.github.com/users/mtanino","html_url":"https://github.com/mtanino","followers_url":"https://api.github.com/users/mtanino/followers","following_url":"https://api.github.com/users/mtanino/following{/other_user}","gists_url":"https://api.github.com/users/mtanino/gists{/gist_id}","starred_url":"https://api.github.com/users/mtanino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtanino/subscriptions","organizations_url":"https://api.github.com/users/mtanino/orgs","repos_url":"https://api.github.com/users/mtanino/repos","events_url":"https://api.github.com/users/mtanino/events{/privacy}","received_events_url":"https://api.github.com/users/mtanino/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":261005360,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/api-change","name":"kind/api-change","color":"c7def8","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":169428334,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253451093,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"vishh","id":7063592,"avatar_url":"https://avatars2.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false},"assignees":[{"login":"screeley44","id":6773375,"avatar_url":"https://avatars2.githubusercontent.com/u/6773375?v=4","gravatar_id":"","url":"https://api.github.com/users/screeley44","html_url":"https://github.com/screeley44","followers_url":"https://api.github.com/users/screeley44/followers","following_url":"https://api.github.com/users/screeley44/following{/other_user}","gists_url":"https://api.github.com/users/screeley44/gists{/gist_id}","starred_url":"https://api.github.com/users/screeley44/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/screeley44/subscriptions","organizations_url":"https://api.github.com/users/screeley44/orgs","repos_url":"https://api.github.com/users/screeley44/repos","events_url":"https://api.github.com/users/screeley44/events{/privacy}","received_events_url":"https://api.github.com/users/screeley44/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"avatar_url":"https://avatars2.githubusercontent.com/u/7063592?v=4","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2017-11-05T03:25:54Z","updated_at":"2017-11-17T02:09:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/55112","html_url":"https://github.com/kubernetes/kubernetes/pull/55112","diff_url":"https://github.com/kubernetes/kubernetes/pull/55112.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/55112.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nAdd cmdline printer support changes.\r\n\r\n**Which issue this PR fixes**: \r\nBased on this proposal (kubernetes/community#805 & kubernetes/community#1265) and this feature issue: kubernetes/features#351\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThere are another PRs related to this functionality.\r\n\r\n(#50457) API Change\r\n(#53385) VolumeMode PV-PVC Binding change\r\n(#51494) Container runtime interface change, volumemanager changes, operationexecutor changes\r\n(#55112) Block volume: Command line printer update\r\nPlugins\r\n(#51493) Block volumes Support: FC plugin update\r\n(#54752) Block volumes Support: iSCSI plugin update\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```\r\nNONE\r\n```\r\n\r\n/sig storage\r\n/cc @msau42  @jsafrane @saad-ali  @erinboyd @screeley44 \r\n@kubernetes/sig-storage-pr-reviews\r\n\r\n\r\n- Command results\r\n```\r\n~/sample/storage/fc_loop/file % k get pv,pvc,pod                \r\nNAME              CAPACITY   ACCESS MODES   VOLUME MODE   RECLAIM POLICY   STATUS    CLAIM                       STORAGECLASS   REASON    AGE\r\npv/block-pv0001   1Gi        RWO            Block         Retain           Bound     default/nginx-block-pvc01   slow                     2m\r\npv/file-pv0001    1Gi        RWO            Filesystem    Retain           Bound     default/nginx-file-pvc01    slow                     24s\r\n\r\nNAME                    STATUS    VOLUME         CAPACITY   ACCESS MODES   VOLUME MODE   STORAGECLASS   AGE\r\npvc/nginx-block-pvc01   Bound     block-pv0001   1Gi        RWO            Block         slow           2m\r\npvc/nginx-file-pvc01    Bound     file-pv0001    1Gi        RWO            Filesystem    slow           25s\r\n\r\nNAME                 READY     STATUS              RESTARTS   AGE\r\npo/nginx-file-pod1   0/1       ContainerCreating   0          4s\r\npo/nginx-pod1        1/1       Running             0          2m\r\n ~/sample/storage/fc_loop/file % k get pv,pvc,pod\r\nNAME              CAPACITY   ACCESS MODES   VOLUME MODE   RECLAIM POLICY   STATUS    CLAIM                       STORAGECLASS   REASON    AGE\r\npv/block-pv0001   1Gi        RWO            Block         Retain           Bound     default/nginx-block-pvc01   slow                     2m\r\npv/file-pv0001    1Gi        RWO            Filesystem    Retain           Bound     default/nginx-file-pvc01    slow                     40s\r\n\r\nNAME                    STATUS    VOLUME         CAPACITY   ACCESS MODES   VOLUME MODE   STORAGECLASS   AGE\r\npvc/nginx-block-pvc01   Bound     block-pv0001   1Gi        RWO            Block         slow           2m\r\npvc/nginx-file-pvc01    Bound     file-pv0001    1Gi        RWO            Filesystem    slow           40s\r\n\r\nNAME                 READY     STATUS    RESTARTS   AGE\r\npo/nginx-file-pod1   1/1       Running   0          19s\r\npo/nginx-pod1        1/1       Running   0          2m\r\n\r\n ~/sample/storage/fc_loop/file % k describe pv/block-pv0001      \r\nName:            block-pv0001\r\nLabels:          <none>\r\nAnnotations:     pv.kubernetes.io/bound-by-controller=yes\r\n                 volume.beta.kubernetes.io/storage-class=slow\r\nStorageClass:    slow\r\nStatus:          Bound\r\nClaim:           default/nginx-block-pvc01\r\nReclaim Policy:  Retain\r\nAccess Modes:    RWO\r\nVolumeMode:      Block\r\nCapacity:        1Gi\r\nMessage:         \r\nSource:\r\n    Type:        FC (a Fibre Channel disk)\r\n    TargetWWNs:  28000001ff0414e2\r\n    LUN:         0\r\n    FSType:      \r\n    ReadOnly:    true\r\nEvents:          <none>\r\n\r\n ~/sample/storage/fc_loop/file % k describe pv/file-pv0001 \r\nName:            file-pv0001\r\nLabels:          <none>\r\nAnnotations:     pv.kubernetes.io/bound-by-controller=yes\r\n                 volume.beta.kubernetes.io/storage-class=slow\r\nStorageClass:    slow\r\nStatus:          Bound\r\nClaim:           default/nginx-file-pvc01\r\nReclaim Policy:  Retain\r\nAccess Modes:    RWO\r\nVolumeMode:      Filesystem\r\nCapacity:        1Gi\r\nMessage:         \r\nSource:\r\n    Type:        FC (a Fibre Channel disk)\r\n    TargetWWNs:  28000001ff0414e2\r\n    LUN:         0\r\n    FSType:      \r\n    ReadOnly:    true\r\nEvents:          <none>\r\n\r\n ~/sample/storage/fc_loop/file % k describe pvc/nginx-block-pvc01\r\nName:          nginx-block-pvc01\r\nNamespace:     default\r\nStorageClass:  slow\r\nStatus:        Bound\r\nVolume:        block-pv0001\r\nLabels:        <none>\r\nAnnotations:   pv.kubernetes.io/bind-completed=yes\r\n               pv.kubernetes.io/bound-by-controller=yes\r\n               volume.beta.kubernetes.io/storage-class=slow\r\nCapacity:      1Gi\r\nAccess Modes:  RWO\r\nVolumeMode:    Block\r\nEvents:        <none>\r\n ~/sample/storage/fc_loop/file % k describe pvc/nginx-file-pvc01 \r\nName:          nginx-file-pvc01\r\nNamespace:     default\r\nStorageClass:  slow\r\nStatus:        Bound\r\nVolume:        file-pv0001\r\nLabels:        <none>\r\nAnnotations:   pv.kubernetes.io/bind-completed=yes\r\n               pv.kubernetes.io/bound-by-controller=yes\r\n               volume.beta.kubernetes.io/storage-class=slow\r\nCapacity:      1Gi\r\nAccess Modes:  RWO\r\nVolumeMode:    Filesystem\r\nEvents:        <none>\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/345124151","html_url":"https://github.com/kubernetes/kubernetes/pull/55112#issuecomment-345124151","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/55112","id":345124151,"user":{"login":"k8s-ci-robot","id":20407524,"avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2017-11-17T02:09:32Z","updated_at":"2017-11-17T02:09:32Z","author_association":"COLLABORATOR","body":"@mtanino: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-bazel-test | e4902efd329a8f24f5bd6a5a8d0b2a7b3226c1ec | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/55112/pull-kubernetes-bazel-test/17041/) | `/test pull-kubernetes-bazel-test`\npull-kubernetes-verify | 605d63b3ce20f929389f1a1ffb4a3ac83d725e7b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/55112/pull-kubernetes-verify/63063/) | `/test pull-kubernetes-verify`\npull-kubernetes-e2e-kops-aws | 605d63b3ce20f929389f1a1ffb4a3ac83d725e7b | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/55112/pull-kubernetes-e2e-kops-aws/60428/) | `/test pull-kubernetes-e2e-kops-aws`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/55112). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/mtanino). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}