{"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/biosustain/OpenMS/pulls/63","id":155366369,"html_url":"https://github.com/biosustain/OpenMS/pull/63","diff_url":"https://github.com/biosustain/OpenMS/pull/63.diff","patch_url":"https://github.com/biosustain/OpenMS/pull/63.patch","issue_url":"https://api.github.com/repos/biosustain/OpenMS/issues/63","number":63,"state":"closed","locked":false,"title":"feat: Support even number of points for Simpson rule in integratePeak()","user":{"login":"pasqoo","id":1009863,"avatar_url":"https://avatars2.githubusercontent.com/u/1009863?v=4","gravatar_id":"","url":"https://api.github.com/users/pasqoo","html_url":"https://github.com/pasqoo","followers_url":"https://api.github.com/users/pasqoo/followers","following_url":"https://api.github.com/users/pasqoo/following{/other_user}","gists_url":"https://api.github.com/users/pasqoo/gists{/gist_id}","starred_url":"https://api.github.com/users/pasqoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasqoo/subscriptions","organizations_url":"https://api.github.com/users/pasqoo/orgs","repos_url":"https://api.github.com/users/pasqoo/repos","events_url":"https://api.github.com/users/pasqoo/events{/privacy}","received_events_url":"https://api.github.com/users/pasqoo/received_events","type":"User","site_admin":false},"body":"closes #62 \r\n\r\nThis should make possible to use the Simpson rule with an even number of points.\r\nI verify it in the tests by including one less point (comparing the test to the previous simpson test), but getting the same result as the previous test.","created_at":"2017-11-29T15:11:36Z","updated_at":"2017-11-30T09:16:38Z","closed_at":"2017-11-30T09:16:38Z","merged_at":null,"merge_commit_sha":"bd4f0bbe68da0310606305c8449bf21adfa2f0c2","assignee":{"login":"pasqoo","id":1009863,"avatar_url":"https://avatars2.githubusercontent.com/u/1009863?v=4","gravatar_id":"","url":"https://api.github.com/users/pasqoo","html_url":"https://github.com/pasqoo","followers_url":"https://api.github.com/users/pasqoo/followers","following_url":"https://api.github.com/users/pasqoo/following{/other_user}","gists_url":"https://api.github.com/users/pasqoo/gists{/gist_id}","starred_url":"https://api.github.com/users/pasqoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasqoo/subscriptions","organizations_url":"https://api.github.com/users/pasqoo/orgs","repos_url":"https://api.github.com/users/pasqoo/repos","events_url":"https://api.github.com/users/pasqoo/events{/privacy}","received_events_url":"https://api.github.com/users/pasqoo/received_events","type":"User","site_admin":false},"assignees":[{"login":"pasqoo","id":1009863,"avatar_url":"https://avatars2.githubusercontent.com/u/1009863?v=4","gravatar_id":"","url":"https://api.github.com/users/pasqoo","html_url":"https://github.com/pasqoo","followers_url":"https://api.github.com/users/pasqoo/followers","following_url":"https://api.github.com/users/pasqoo/following{/other_user}","gists_url":"https://api.github.com/users/pasqoo/gists{/gist_id}","starred_url":"https://api.github.com/users/pasqoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasqoo/subscriptions","organizations_url":"https://api.github.com/users/pasqoo/orgs","repos_url":"https://api.github.com/users/pasqoo/repos","events_url":"https://api.github.com/users/pasqoo/events{/privacy}","received_events_url":"https://api.github.com/users/pasqoo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/biosustain/OpenMS/pulls/63/commits","review_comments_url":"https://api.github.com/repos/biosustain/OpenMS/pulls/63/comments","review_comment_url":"https://api.github.com/repos/biosustain/OpenMS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/biosustain/OpenMS/issues/63/comments","statuses_url":"https://api.github.com/repos/biosustain/OpenMS/statuses/c29648bd06292fbcf3dbc41709941387afc280a9","head":{"label":"biosustain:feature/PeakIntegrator_simpson_even_n_points","ref":"feature/PeakIntegrator_simpson_even_n_points","sha":"c29648bd06292fbcf3dbc41709941387afc280a9","user":{"login":"biosustain","id":5499849,"avatar_url":"https://avatars3.githubusercontent.com/u/5499849?v=4","gravatar_id":"","url":"https://api.github.com/users/biosustain","html_url":"https://github.com/biosustain","followers_url":"https://api.github.com/users/biosustain/followers","following_url":"https://api.github.com/users/biosustain/following{/other_user}","gists_url":"https://api.github.com/users/biosustain/gists{/gist_id}","starred_url":"https://api.github.com/users/biosustain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biosustain/subscriptions","organizations_url":"https://api.github.com/users/biosustain/orgs","repos_url":"https://api.github.com/users/biosustain/repos","events_url":"https://api.github.com/users/biosustain/events{/privacy}","received_events_url":"https://api.github.com/users/biosustain/received_events","type":"Organization","site_admin":false},"repo":{"id":101999003,"name":"OpenMS","full_name":"biosustain/OpenMS","owner":{"login":"biosustain","id":5499849,"avatar_url":"https://avatars3.githubusercontent.com/u/5499849?v=4","gravatar_id":"","url":"https://api.github.com/users/biosustain","html_url":"https://github.com/biosustain","followers_url":"https://api.github.com/users/biosustain/followers","following_url":"https://api.github.com/users/biosustain/following{/other_user}","gists_url":"https://api.github.com/users/biosustain/gists{/gist_id}","starred_url":"https://api.github.com/users/biosustain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biosustain/subscriptions","organizations_url":"https://api.github.com/users/biosustain/orgs","repos_url":"https://api.github.com/users/biosustain/repos","events_url":"https://api.github.com/users/biosustain/events{/privacy}","received_events_url":"https://api.github.com/users/biosustain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biosustain/OpenMS","description":"The codebase of the OpenMS project","fork":true,"url":"https://api.github.com/repos/biosustain/OpenMS","forks_url":"https://api.github.com/repos/biosustain/OpenMS/forks","keys_url":"https://api.github.com/repos/biosustain/OpenMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biosustain/OpenMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biosustain/OpenMS/teams","hooks_url":"https://api.github.com/repos/biosustain/OpenMS/hooks","issue_events_url":"https://api.github.com/repos/biosustain/OpenMS/issues/events{/number}","events_url":"https://api.github.com/repos/biosustain/OpenMS/events","assignees_url":"https://api.github.com/repos/biosustain/OpenMS/assignees{/user}","branches_url":"https://api.github.com/repos/biosustain/OpenMS/branches{/branch}","tags_url":"https://api.github.com/repos/biosustain/OpenMS/tags","blobs_url":"https://api.github.com/repos/biosustain/OpenMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biosustain/OpenMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biosustain/OpenMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/biosustain/OpenMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biosustain/OpenMS/statuses/{sha}","languages_url":"https://api.github.com/repos/biosustain/OpenMS/languages","stargazers_url":"https://api.github.com/repos/biosustain/OpenMS/stargazers","contributors_url":"https://api.github.com/repos/biosustain/OpenMS/contributors","subscribers_url":"https://api.github.com/repos/biosustain/OpenMS/subscribers","subscription_url":"https://api.github.com/repos/biosustain/OpenMS/subscription","commits_url":"https://api.github.com/repos/biosustain/OpenMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/biosustain/OpenMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/biosustain/OpenMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/biosustain/OpenMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/biosustain/OpenMS/contents/{+path}","compare_url":"https://api.github.com/repos/biosustain/OpenMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biosustain/OpenMS/merges","archive_url":"https://api.github.com/repos/biosustain/OpenMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biosustain/OpenMS/downloads","issues_url":"https://api.github.com/repos/biosustain/OpenMS/issues{/number}","pulls_url":"https://api.github.com/repos/biosustain/OpenMS/pulls{/number}","milestones_url":"https://api.github.com/repos/biosustain/OpenMS/milestones{/number}","notifications_url":"https://api.github.com/repos/biosustain/OpenMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biosustain/OpenMS/labels{/name}","releases_url":"https://api.github.com/repos/biosustain/OpenMS/releases{/id}","deployments_url":"https://api.github.com/repos/biosustain/OpenMS/deployments","created_at":"2017-08-31T12:35:49Z","updated_at":"2017-08-31T12:36:21Z","pushed_at":"2017-11-30T09:15:39Z","git_url":"git://github.com/biosustain/OpenMS.git","ssh_url":"git@github.com:biosustain/OpenMS.git","clone_url":"https://github.com/biosustain/OpenMS.git","svn_url":"https://github.com/biosustain/OpenMS","homepage":"https://www.openms.de","size":255889,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":0,"default_branch":"develop"}},"base":{"label":"biosustain:feature/PeakIntegrator","ref":"feature/PeakIntegrator","sha":"831227ba4a5e35bc8322f5db1013ea871f46a5ff","user":{"login":"biosustain","id":5499849,"avatar_url":"https://avatars3.githubusercontent.com/u/5499849?v=4","gravatar_id":"","url":"https://api.github.com/users/biosustain","html_url":"https://github.com/biosustain","followers_url":"https://api.github.com/users/biosustain/followers","following_url":"https://api.github.com/users/biosustain/following{/other_user}","gists_url":"https://api.github.com/users/biosustain/gists{/gist_id}","starred_url":"https://api.github.com/users/biosustain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biosustain/subscriptions","organizations_url":"https://api.github.com/users/biosustain/orgs","repos_url":"https://api.github.com/users/biosustain/repos","events_url":"https://api.github.com/users/biosustain/events{/privacy}","received_events_url":"https://api.github.com/users/biosustain/received_events","type":"Organization","site_admin":false},"repo":{"id":101999003,"name":"OpenMS","full_name":"biosustain/OpenMS","owner":{"login":"biosustain","id":5499849,"avatar_url":"https://avatars3.githubusercontent.com/u/5499849?v=4","gravatar_id":"","url":"https://api.github.com/users/biosustain","html_url":"https://github.com/biosustain","followers_url":"https://api.github.com/users/biosustain/followers","following_url":"https://api.github.com/users/biosustain/following{/other_user}","gists_url":"https://api.github.com/users/biosustain/gists{/gist_id}","starred_url":"https://api.github.com/users/biosustain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/biosustain/subscriptions","organizations_url":"https://api.github.com/users/biosustain/orgs","repos_url":"https://api.github.com/users/biosustain/repos","events_url":"https://api.github.com/users/biosustain/events{/privacy}","received_events_url":"https://api.github.com/users/biosustain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/biosustain/OpenMS","description":"The codebase of the OpenMS project","fork":true,"url":"https://api.github.com/repos/biosustain/OpenMS","forks_url":"https://api.github.com/repos/biosustain/OpenMS/forks","keys_url":"https://api.github.com/repos/biosustain/OpenMS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/biosustain/OpenMS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/biosustain/OpenMS/teams","hooks_url":"https://api.github.com/repos/biosustain/OpenMS/hooks","issue_events_url":"https://api.github.com/repos/biosustain/OpenMS/issues/events{/number}","events_url":"https://api.github.com/repos/biosustain/OpenMS/events","assignees_url":"https://api.github.com/repos/biosustain/OpenMS/assignees{/user}","branches_url":"https://api.github.com/repos/biosustain/OpenMS/branches{/branch}","tags_url":"https://api.github.com/repos/biosustain/OpenMS/tags","blobs_url":"https://api.github.com/repos/biosustain/OpenMS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/biosustain/OpenMS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/biosustain/OpenMS/git/refs{/sha}","trees_url":"https://api.github.com/repos/biosustain/OpenMS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/biosustain/OpenMS/statuses/{sha}","languages_url":"https://api.github.com/repos/biosustain/OpenMS/languages","stargazers_url":"https://api.github.com/repos/biosustain/OpenMS/stargazers","contributors_url":"https://api.github.com/repos/biosustain/OpenMS/contributors","subscribers_url":"https://api.github.com/repos/biosustain/OpenMS/subscribers","subscription_url":"https://api.github.com/repos/biosustain/OpenMS/subscription","commits_url":"https://api.github.com/repos/biosustain/OpenMS/commits{/sha}","git_commits_url":"https://api.github.com/repos/biosustain/OpenMS/git/commits{/sha}","comments_url":"https://api.github.com/repos/biosustain/OpenMS/comments{/number}","issue_comment_url":"https://api.github.com/repos/biosustain/OpenMS/issues/comments{/number}","contents_url":"https://api.github.com/repos/biosustain/OpenMS/contents/{+path}","compare_url":"https://api.github.com/repos/biosustain/OpenMS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/biosustain/OpenMS/merges","archive_url":"https://api.github.com/repos/biosustain/OpenMS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/biosustain/OpenMS/downloads","issues_url":"https://api.github.com/repos/biosustain/OpenMS/issues{/number}","pulls_url":"https://api.github.com/repos/biosustain/OpenMS/pulls{/number}","milestones_url":"https://api.github.com/repos/biosustain/OpenMS/milestones{/number}","notifications_url":"https://api.github.com/repos/biosustain/OpenMS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/biosustain/OpenMS/labels{/name}","releases_url":"https://api.github.com/repos/biosustain/OpenMS/releases{/id}","deployments_url":"https://api.github.com/repos/biosustain/OpenMS/deployments","created_at":"2017-08-31T12:35:49Z","updated_at":"2017-08-31T12:36:21Z","pushed_at":"2017-11-30T09:15:39Z","git_url":"git://github.com/biosustain/OpenMS.git","ssh_url":"git@github.com:biosustain/OpenMS.git","clone_url":"https://github.com/biosustain/OpenMS.git","svn_url":"https://github.com/biosustain/OpenMS","homepage":"https://www.openms.de","size":255889,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":0,"open_issues":10,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/biosustain/OpenMS/pulls/63"},"html":{"href":"https://github.com/biosustain/OpenMS/pull/63"},"issue":{"href":"https://api.github.com/repos/biosustain/OpenMS/issues/63"},"comments":{"href":"https://api.github.com/repos/biosustain/OpenMS/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/biosustain/OpenMS/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/biosustain/OpenMS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/biosustain/OpenMS/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/biosustain/OpenMS/statuses/c29648bd06292fbcf3dbc41709941387afc280a9"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":17,"deletions":8,"changed_files":2}}
{"actor":{"display_login":"pasqoo"}}