{"action":"created","comment":{"url":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/comments/97206449","pull_request_review_id":17814512,"id":97206449,"diff_hunk":"@@ -144,6 +150,10 @@ public function resolveReferenceNodeToDefinition(Node $node)\n     {\n         // Variables are not indexed globally, as they stay in the file scope anyway\n         if ($node instanceof Node\\Expr\\Variable) {\n+            // Resolve $this\n+            if ($node->name === 'this' && $fqn = $this->getContainingClassFqn($node)) {\n+                return $this->index->getDefinition($fqn, false);\n+            }","path":"src/DefinitionResolver.php","position":34,"original_position":20,"commit_id":"412a88428ee9d29aad287e2ea31a4c2bf2b396c1","original_commit_id":"1b68c73186158df2e64879781952255255f96d39","user":{"login":"felixfbecker","id":10532611,"avatar_url":"https://avatars.githubusercontent.com/u/10532611?v=3","gravatar_id":"","url":"https://api.github.com/users/felixfbecker","html_url":"https://github.com/felixfbecker","followers_url":"https://api.github.com/users/felixfbecker/followers","following_url":"https://api.github.com/users/felixfbecker/following{/other_user}","gists_url":"https://api.github.com/users/felixfbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfbecker/subscriptions","organizations_url":"https://api.github.com/users/felixfbecker/orgs","repos_url":"https://api.github.com/users/felixfbecker/repos","events_url":"https://api.github.com/users/felixfbecker/events{/privacy}","received_events_url":"https://api.github.com/users/felixfbecker/received_events","type":"User","site_admin":false},"body":"Okay. If you do it in a separate PR I think I would merge it straight away, change looks good.","created_at":"2017-01-21T21:03:16Z","updated_at":"2017-01-21T21:03:16Z","html_url":"https://github.com/felixfbecker/php-language-server/pull/250#discussion_r97206449","pull_request_url":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/250","_links":{"self":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/comments/97206449"},"html":{"href":"https://github.com/felixfbecker/php-language-server/pull/250#discussion_r97206449"},"pull_request":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/250"}}},"pull_request":{"url":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/250","id":102486847,"html_url":"https://github.com/felixfbecker/php-language-server/pull/250","diff_url":"https://github.com/felixfbecker/php-language-server/pull/250.diff","patch_url":"https://github.com/felixfbecker/php-language-server/pull/250.patch","issue_url":"https://api.github.com/repos/felixfbecker/php-language-server/issues/250","number":250,"state":"open","locked":false,"title":"Signature help","user":{"login":"vakata","id":146052,"avatar_url":"https://avatars.githubusercontent.com/u/146052?v=3","gravatar_id":"","url":"https://api.github.com/users/vakata","html_url":"https://github.com/vakata","followers_url":"https://api.github.com/users/vakata/followers","following_url":"https://api.github.com/users/vakata/following{/other_user}","gists_url":"https://api.github.com/users/vakata/gists{/gist_id}","starred_url":"https://api.github.com/users/vakata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakata/subscriptions","organizations_url":"https://api.github.com/users/vakata/orgs","repos_url":"https://api.github.com/users/vakata/repos","events_url":"https://api.github.com/users/vakata/events{/privacy}","received_events_url":"https://api.github.com/users/vakata/received_events","type":"User","site_admin":false},"body":"Closes #18\r\nParameter counting is \"hackish\" and working with php://temp maybe undesired? I also had to store parsed parameters along with the definition (similar to `declarationLine`) to avoid parsing again.","created_at":"2017-01-20T15:53:34Z","updated_at":"2017-01-21T21:03:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f7a80412633ccf7d041a108897c5e7a0562d676","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/250/commits","review_comments_url":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/250/comments","review_comment_url":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/felixfbecker/php-language-server/issues/250/comments","statuses_url":"https://api.github.com/repos/felixfbecker/php-language-server/statuses/412a88428ee9d29aad287e2ea31a4c2bf2b396c1","head":{"label":"vakata:signatureHelp","ref":"signatureHelp","sha":"412a88428ee9d29aad287e2ea31a4c2bf2b396c1","user":{"login":"vakata","id":146052,"avatar_url":"https://avatars.githubusercontent.com/u/146052?v=3","gravatar_id":"","url":"https://api.github.com/users/vakata","html_url":"https://github.com/vakata","followers_url":"https://api.github.com/users/vakata/followers","following_url":"https://api.github.com/users/vakata/following{/other_user}","gists_url":"https://api.github.com/users/vakata/gists{/gist_id}","starred_url":"https://api.github.com/users/vakata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakata/subscriptions","organizations_url":"https://api.github.com/users/vakata/orgs","repos_url":"https://api.github.com/users/vakata/repos","events_url":"https://api.github.com/users/vakata/events{/privacy}","received_events_url":"https://api.github.com/users/vakata/received_events","type":"User","site_admin":false},"repo":{"id":79449441,"name":"php-language-server","full_name":"vakata/php-language-server","owner":{"login":"vakata","id":146052,"avatar_url":"https://avatars.githubusercontent.com/u/146052?v=3","gravatar_id":"","url":"https://api.github.com/users/vakata","html_url":"https://github.com/vakata","followers_url":"https://api.github.com/users/vakata/followers","following_url":"https://api.github.com/users/vakata/following{/other_user}","gists_url":"https://api.github.com/users/vakata/gists{/gist_id}","starred_url":"https://api.github.com/users/vakata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vakata/subscriptions","organizations_url":"https://api.github.com/users/vakata/orgs","repos_url":"https://api.github.com/users/vakata/repos","events_url":"https://api.github.com/users/vakata/events{/privacy}","received_events_url":"https://api.github.com/users/vakata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vakata/php-language-server","description":"PHP Implementation of the VS Code Language Server Protocol 🆚↔🖥","fork":true,"url":"https://api.github.com/repos/vakata/php-language-server","forks_url":"https://api.github.com/repos/vakata/php-language-server/forks","keys_url":"https://api.github.com/repos/vakata/php-language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vakata/php-language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vakata/php-language-server/teams","hooks_url":"https://api.github.com/repos/vakata/php-language-server/hooks","issue_events_url":"https://api.github.com/repos/vakata/php-language-server/issues/events{/number}","events_url":"https://api.github.com/repos/vakata/php-language-server/events","assignees_url":"https://api.github.com/repos/vakata/php-language-server/assignees{/user}","branches_url":"https://api.github.com/repos/vakata/php-language-server/branches{/branch}","tags_url":"https://api.github.com/repos/vakata/php-language-server/tags","blobs_url":"https://api.github.com/repos/vakata/php-language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vakata/php-language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vakata/php-language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/vakata/php-language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vakata/php-language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/vakata/php-language-server/languages","stargazers_url":"https://api.github.com/repos/vakata/php-language-server/stargazers","contributors_url":"https://api.github.com/repos/vakata/php-language-server/contributors","subscribers_url":"https://api.github.com/repos/vakata/php-language-server/subscribers","subscription_url":"https://api.github.com/repos/vakata/php-language-server/subscription","commits_url":"https://api.github.com/repos/vakata/php-language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/vakata/php-language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/vakata/php-language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/vakata/php-language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/vakata/php-language-server/contents/{+path}","compare_url":"https://api.github.com/repos/vakata/php-language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vakata/php-language-server/merges","archive_url":"https://api.github.com/repos/vakata/php-language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vakata/php-language-server/downloads","issues_url":"https://api.github.com/repos/vakata/php-language-server/issues{/number}","pulls_url":"https://api.github.com/repos/vakata/php-language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/vakata/php-language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/vakata/php-language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vakata/php-language-server/labels{/name}","releases_url":"https://api.github.com/repos/vakata/php-language-server/releases{/id}","deployments_url":"https://api.github.com/repos/vakata/php-language-server/deployments","created_at":"2017-01-19T12:05:29Z","updated_at":"2017-01-19T12:05:32Z","pushed_at":"2017-01-21T20:48:00Z","git_url":"git://github.com/vakata/php-language-server.git","ssh_url":"git@github.com:vakata/php-language-server.git","clone_url":"https://github.com/vakata/php-language-server.git","svn_url":"https://github.com/vakata/php-language-server","homepage":"","size":956,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"felixfbecker:master","ref":"master","sha":"43a91b0d0907542dd27991e19cae633192474a36","user":{"login":"felixfbecker","id":10532611,"avatar_url":"https://avatars.githubusercontent.com/u/10532611?v=3","gravatar_id":"","url":"https://api.github.com/users/felixfbecker","html_url":"https://github.com/felixfbecker","followers_url":"https://api.github.com/users/felixfbecker/followers","following_url":"https://api.github.com/users/felixfbecker/following{/other_user}","gists_url":"https://api.github.com/users/felixfbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfbecker/subscriptions","organizations_url":"https://api.github.com/users/felixfbecker/orgs","repos_url":"https://api.github.com/users/felixfbecker/repos","events_url":"https://api.github.com/users/felixfbecker/events{/privacy}","received_events_url":"https://api.github.com/users/felixfbecker/received_events","type":"User","site_admin":false},"repo":{"id":65535756,"name":"php-language-server","full_name":"felixfbecker/php-language-server","owner":{"login":"felixfbecker","id":10532611,"avatar_url":"https://avatars.githubusercontent.com/u/10532611?v=3","gravatar_id":"","url":"https://api.github.com/users/felixfbecker","html_url":"https://github.com/felixfbecker","followers_url":"https://api.github.com/users/felixfbecker/followers","following_url":"https://api.github.com/users/felixfbecker/following{/other_user}","gists_url":"https://api.github.com/users/felixfbecker/gists{/gist_id}","starred_url":"https://api.github.com/users/felixfbecker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felixfbecker/subscriptions","organizations_url":"https://api.github.com/users/felixfbecker/orgs","repos_url":"https://api.github.com/users/felixfbecker/repos","events_url":"https://api.github.com/users/felixfbecker/events{/privacy}","received_events_url":"https://api.github.com/users/felixfbecker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/felixfbecker/php-language-server","description":"PHP Implementation of the VS Code Language Server Protocol 🆚↔🖥","fork":false,"url":"https://api.github.com/repos/felixfbecker/php-language-server","forks_url":"https://api.github.com/repos/felixfbecker/php-language-server/forks","keys_url":"https://api.github.com/repos/felixfbecker/php-language-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/felixfbecker/php-language-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/felixfbecker/php-language-server/teams","hooks_url":"https://api.github.com/repos/felixfbecker/php-language-server/hooks","issue_events_url":"https://api.github.com/repos/felixfbecker/php-language-server/issues/events{/number}","events_url":"https://api.github.com/repos/felixfbecker/php-language-server/events","assignees_url":"https://api.github.com/repos/felixfbecker/php-language-server/assignees{/user}","branches_url":"https://api.github.com/repos/felixfbecker/php-language-server/branches{/branch}","tags_url":"https://api.github.com/repos/felixfbecker/php-language-server/tags","blobs_url":"https://api.github.com/repos/felixfbecker/php-language-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/felixfbecker/php-language-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/felixfbecker/php-language-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/felixfbecker/php-language-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/felixfbecker/php-language-server/statuses/{sha}","languages_url":"https://api.github.com/repos/felixfbecker/php-language-server/languages","stargazers_url":"https://api.github.com/repos/felixfbecker/php-language-server/stargazers","contributors_url":"https://api.github.com/repos/felixfbecker/php-language-server/contributors","subscribers_url":"https://api.github.com/repos/felixfbecker/php-language-server/subscribers","subscription_url":"https://api.github.com/repos/felixfbecker/php-language-server/subscription","commits_url":"https://api.github.com/repos/felixfbecker/php-language-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/felixfbecker/php-language-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/felixfbecker/php-language-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/felixfbecker/php-language-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/felixfbecker/php-language-server/contents/{+path}","compare_url":"https://api.github.com/repos/felixfbecker/php-language-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/felixfbecker/php-language-server/merges","archive_url":"https://api.github.com/repos/felixfbecker/php-language-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/felixfbecker/php-language-server/downloads","issues_url":"https://api.github.com/repos/felixfbecker/php-language-server/issues{/number}","pulls_url":"https://api.github.com/repos/felixfbecker/php-language-server/pulls{/number}","milestones_url":"https://api.github.com/repos/felixfbecker/php-language-server/milestones{/number}","notifications_url":"https://api.github.com/repos/felixfbecker/php-language-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/felixfbecker/php-language-server/labels{/name}","releases_url":"https://api.github.com/repos/felixfbecker/php-language-server/releases{/id}","deployments_url":"https://api.github.com/repos/felixfbecker/php-language-server/deployments","created_at":"2016-08-12T08:11:14Z","updated_at":"2017-01-19T15:04:35Z","pushed_at":"2017-01-21T20:48:02Z","git_url":"git://github.com/felixfbecker/php-language-server.git","ssh_url":"git@github.com:felixfbecker/php-language-server.git","clone_url":"https://github.com/felixfbecker/php-language-server.git","svn_url":"https://github.com/felixfbecker/php-language-server","homepage":"","size":866,"stargazers_count":103,"watchers_count":103,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":58,"forks":17,"open_issues":58,"watchers":103,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/250"},"html":{"href":"https://github.com/felixfbecker/php-language-server/pull/250"},"issue":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/issues/250"},"comments":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/issues/250/comments"},"review_comments":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/250/comments"},"review_comment":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/pulls/250/commits"},"statuses":{"href":"https://api.github.com/repos/felixfbecker/php-language-server/statuses/412a88428ee9d29aad287e2ea31a4c2bf2b396c1"}}}}
{"actor":{"display_login":"felixfbecker"}}