{"action":"created","issue":{"url":"https://api.github.com/repos/summernote/summernote/issues/2487","repository_url":"https://api.github.com/repos/summernote/summernote","labels_url":"https://api.github.com/repos/summernote/summernote/issues/2487/labels{/name}","comments_url":"https://api.github.com/repos/summernote/summernote/issues/2487/comments","events_url":"https://api.github.com/repos/summernote/summernote/issues/2487/events","html_url":"https://github.com/summernote/summernote/pull/2487","id":260094458,"number":2487,"title":"implements fontName command","user":{"login":"easylogic","id":591983,"avatar_url":"https://avatars0.githubusercontent.com/u/591983?v=4","gravatar_id":"","url":"https://api.github.com/users/easylogic","html_url":"https://github.com/easylogic","followers_url":"https://api.github.com/users/easylogic/followers","following_url":"https://api.github.com/users/easylogic/following{/other_user}","gists_url":"https://api.github.com/users/easylogic/gists{/gist_id}","starred_url":"https://api.github.com/users/easylogic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/easylogic/subscriptions","organizations_url":"https://api.github.com/users/easylogic/orgs","repos_url":"https://api.github.com/users/easylogic/repos","events_url":"https://api.github.com/users/easylogic/events{/privacy}","received_events_url":"https://api.github.com/users/easylogic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"hackerwins","id":2059311,"avatar_url":"https://avatars2.githubusercontent.com/u/2059311?v=4","gravatar_id":"","url":"https://api.github.com/users/hackerwins","html_url":"https://github.com/hackerwins","followers_url":"https://api.github.com/users/hackerwins/followers","following_url":"https://api.github.com/users/hackerwins/following{/other_user}","gists_url":"https://api.github.com/users/hackerwins/gists{/gist_id}","starred_url":"https://api.github.com/users/hackerwins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackerwins/subscriptions","organizations_url":"https://api.github.com/users/hackerwins/orgs","repos_url":"https://api.github.com/users/hackerwins/repos","events_url":"https://api.github.com/users/hackerwins/events{/privacy}","received_events_url":"https://api.github.com/users/hackerwins/received_events","type":"User","site_admin":false},"assignees":[{"login":"hackerwins","id":2059311,"avatar_url":"https://avatars2.githubusercontent.com/u/2059311?v=4","gravatar_id":"","url":"https://api.github.com/users/hackerwins","html_url":"https://github.com/hackerwins","followers_url":"https://api.github.com/users/hackerwins/followers","following_url":"https://api.github.com/users/hackerwins/following{/other_user}","gists_url":"https://api.github.com/users/hackerwins/gists{/gist_id}","starred_url":"https://api.github.com/users/hackerwins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hackerwins/subscriptions","organizations_url":"https://api.github.com/users/hackerwins/orgs","repos_url":"https://api.github.com/users/hackerwins/repos","events_url":"https://api.github.com/users/hackerwins/events{/privacy}","received_events_url":"https://api.github.com/users/hackerwins/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2017-09-24T15:50:10Z","updated_at":"2017-09-25T02:07:41Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/summernote/summernote/pulls/2487","html_url":"https://github.com/summernote/summernote/pull/2487","diff_url":"https://github.com/summernote/summernote/pull/2487.diff","patch_url":"https://github.com/summernote/summernote/pull/2487.patch"},"body":"#### What does this PR do?\r\n\r\n- implements fontName command \r\n- fixed the problem that font names with spaces were not used.\r\n\r\n#### Where should the reviewer start?\r\n\r\n- start on the src/base/module/Editor.js\r\n- fontName method \r\n\r\n#### How should this be manually tested?\r\n\r\n\r\n\r\n#### Any background context you want to provide?\r\n\r\n- this problem is exists only in chrome \r\n\r\n#### What are the relevant tickets?\r\n\r\n#2486 \r\n\r\n#### Screenshots (if for frontend)\r\n\r\n\r\n### Checklist\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/summernote/summernote/issues/comments/331759499","html_url":"https://github.com/summernote/summernote/pull/2487#issuecomment-331759499","issue_url":"https://api.github.com/repos/summernote/summernote/issues/2487","id":331759499,"user":{"login":"1der1","id":8316710,"avatar_url":"https://avatars2.githubusercontent.com/u/8316710?v=4","gravatar_id":"","url":"https://api.github.com/users/1der1","html_url":"https://github.com/1der1","followers_url":"https://api.github.com/users/1der1/followers","following_url":"https://api.github.com/users/1der1/following{/other_user}","gists_url":"https://api.github.com/users/1der1/gists{/gist_id}","starred_url":"https://api.github.com/users/1der1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/1der1/subscriptions","organizations_url":"https://api.github.com/users/1der1/orgs","repos_url":"https://api.github.com/users/1der1/repos","events_url":"https://api.github.com/users/1der1/events{/privacy}","received_events_url":"https://api.github.com/users/1der1/received_events","type":"User","site_admin":false},"created_at":"2017-09-25T02:07:41Z","updated_at":"2017-09-25T02:07:41Z","author_association":"NONE","body":"Thank you, Jinho,\r\n\r\nI love Summernote and 1der1 makes the most of it.\r\n\r\nI reported a Chrome bug. The font family parsing fails at the deepest level.\r\n\r\n“Exo 2“ should work exactly like “Times New Roman”.\r\n\r\nMaybe Summernote should not change anything regarding this issue, but support my proposal:\r\nhttps://bugs.chromium.org/p/chromium/issues/detail?id=768245&can=2&start=0&num=100&q=&colspec=ID%20Pri%20M%20Stars%20ReleaseBlock%20Component%20Status%20Owner%20Summary%20OS%20Modified&groupby=&sort=\r\n\r\nI made a 20-seconds video regarding usage of “Exo 2” and Summernote:\r\nhttps://www.youtube.com/watch?v=rfC1PlK87jU\r\n\r\nYou can use 1der1 to make promotional videos about Summernote and to finance Summernote:\r\nhttps://1der1.com/pages/business\r\n\r\n\r\nKindest regards,\r\n\r\nLothar Bongartz\r\n1der1<https://1der1.com/>\r\n\r\n\r\n\r\n\r\n\r\n[cid:image002.png@01D07AB8.1CF42D80]<https://1der1.com/>\r\n\r\n\r\n\r\n[cid:rsz_rsz_linkedin-icon0666be]<https://nz.linkedin.com/in/lotharbongartz>[Image result for icons youtube]<https://www.youtube.com/channel/UC5KmJrsB84mAQN83OCImCVw>[cid:image011.png@01D2B47C.7F3CC880]<https://www.facebook.com/1der1>[cid:rsz_rsz_1rsz_twitter-icond1307a]<https://twitter.com/1der1com>\r\n\r\n\r\n\r\n\r\n\r\n\r\nFrom: jinho park [mailto:notifications@github.com]\r\nSent: Monday, 25 September 2017 2:13 p.m.\r\nTo: summernote/summernote\r\nCc: Lothar Bongartz, 1der1.com; Comment\r\nSubject: Re: [summernote/summernote] implements fontName command (#2487)\r\n\r\n\r\nsee https://w3c.github.io/editing/execCommand.html#the-fontname-command\r\n\r\n...\r\n\r\n\r\n\r\nChrome 11 dev\r\n\r\nEmpty string does nothing, '\"monospace\"' same as 'monospace' (i.e., cannot escape font-family keywords because quotes are stripped, clearly wrong)\r\n\r\n\r\n\r\n...\r\n\r\n—\r\nYou are receiving this because you commented.\r\nReply to this email directly, view it on GitHub<https://github.com/summernote/summernote/pull/2487#issuecomment-331753906>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AH7nJpRVugJoJ3zbFL1vXqolYjjZolK5ks5slv4bgaJpZM4Ph7kp>.\r\n"}}
{"actor":{"display_login":"1der1"}}