{"action":"created","issue":{"url":"https://api.github.com/repos/MyEtherWallet/MyEtherWallet/issues/64","repository_url":"https://api.github.com/repos/MyEtherWallet/MyEtherWallet","labels_url":"https://api.github.com/repos/MyEtherWallet/MyEtherWallet/issues/64/labels{/name}","comments_url":"https://api.github.com/repos/MyEtherWallet/MyEtherWallet/issues/64/comments","events_url":"https://api.github.com/repos/MyEtherWallet/MyEtherWallet/issues/64/events","html_url":"https://github.com/MyEtherWallet/MyEtherWallet/issues/64","id":244433044,"number":64,"title":"Move to BN.js","user":{"login":"crptm","id":26779763,"avatar_url":"https://avatars0.githubusercontent.com/u/26779763?v=4","gravatar_id":"","url":"https://api.github.com/users/crptm","html_url":"https://github.com/crptm","followers_url":"https://api.github.com/users/crptm/followers","following_url":"https://api.github.com/users/crptm/following{/other_user}","gists_url":"https://api.github.com/users/crptm/gists{/gist_id}","starred_url":"https://api.github.com/users/crptm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crptm/subscriptions","organizations_url":"https://api.github.com/users/crptm/orgs","repos_url":"https://api.github.com/users/crptm/repos","events_url":"https://api.github.com/users/crptm/events{/privacy}","received_events_url":"https://api.github.com/users/crptm/received_events","type":"User","site_admin":false},"labels":[{"id":654890324,"url":"https://api.github.com/repos/MyEtherWallet/MyEtherWallet/labels/blocking%20V4%20full-launch","name":"blocking V4 full-launch","color":"f9d0c4","default":false}],"state":"open","locked":false,"assignee":{"login":"wbobeirne","id":649992,"avatar_url":"https://avatars0.githubusercontent.com/u/649992?v=4","gravatar_id":"","url":"https://api.github.com/users/wbobeirne","html_url":"https://github.com/wbobeirne","followers_url":"https://api.github.com/users/wbobeirne/followers","following_url":"https://api.github.com/users/wbobeirne/following{/other_user}","gists_url":"https://api.github.com/users/wbobeirne/gists{/gist_id}","starred_url":"https://api.github.com/users/wbobeirne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbobeirne/subscriptions","organizations_url":"https://api.github.com/users/wbobeirne/orgs","repos_url":"https://api.github.com/users/wbobeirne/repos","events_url":"https://api.github.com/users/wbobeirne/events{/privacy}","received_events_url":"https://api.github.com/users/wbobeirne/received_events","type":"User","site_admin":false},"assignees":[{"login":"wbobeirne","id":649992,"avatar_url":"https://avatars0.githubusercontent.com/u/649992?v=4","gravatar_id":"","url":"https://api.github.com/users/wbobeirne","html_url":"https://github.com/wbobeirne","followers_url":"https://api.github.com/users/wbobeirne/followers","following_url":"https://api.github.com/users/wbobeirne/following{/other_user}","gists_url":"https://api.github.com/users/wbobeirne/gists{/gist_id}","starred_url":"https://api.github.com/users/wbobeirne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbobeirne/subscriptions","organizations_url":"https://api.github.com/users/wbobeirne/orgs","repos_url":"https://api.github.com/users/wbobeirne/repos","events_url":"https://api.github.com/users/wbobeirne/events{/privacy}","received_events_url":"https://api.github.com/users/wbobeirne/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-07-20T17:04:39Z","updated_at":"2017-09-09T17:56:53Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"We already have it as dependency. It can into parsing/writing base16 values. \r\n\r\n- [ ] It does not support decimals so we need some helpers for that\r\n- [ ] we need flow definitions"},"comment":{"url":"https://api.github.com/repos/MyEtherWallet/MyEtherWallet/issues/comments/328293578","html_url":"https://github.com/MyEtherWallet/MyEtherWallet/issues/64#issuecomment-328293578","issue_url":"https://api.github.com/repos/MyEtherWallet/MyEtherWallet/issues/64","id":328293578,"user":{"login":"wbobeirne","id":649992,"avatar_url":"https://avatars0.githubusercontent.com/u/649992?v=4","gravatar_id":"","url":"https://api.github.com/users/wbobeirne","html_url":"https://github.com/wbobeirne","followers_url":"https://api.github.com/users/wbobeirne/followers","following_url":"https://api.github.com/users/wbobeirne/following{/other_user}","gists_url":"https://api.github.com/users/wbobeirne/gists{/gist_id}","starred_url":"https://api.github.com/users/wbobeirne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbobeirne/subscriptions","organizations_url":"https://api.github.com/users/wbobeirne/orgs","repos_url":"https://api.github.com/users/wbobeirne/repos","events_url":"https://api.github.com/users/wbobeirne/events{/privacy}","received_events_url":"https://api.github.com/users/wbobeirne/received_events","type":"User","site_admin":false},"created_at":"2017-09-09T17:56:53Z","updated_at":"2017-09-09T17:56:53Z","author_association":"COLLABORATOR","body":"Looks like this task is going to be a mild pain. I did a little audit of everywhere we use it (As of 8854d42fd99f3d494cdbd4ba4a038930f1e1720a)\r\n\r\nWe'll likely need to implement a big-numberless way of converting a decimal string into a wei unit string. Fortunately if we switch over to the libs/units classes, I think it should make the bulk of future bignumber handling pretty well contained, aside from gas and a few other instances.\r\n\r\n## bignumber.js uses\r\n|File|Conversion steps|\r\n|--------------------------------------|---------|\r\n|common/actions/deterministicWallets.js|1:1 (Type only)|\r\n|common/actions/wallet.js|1:1 (Type only)|\r\n|common/libs/erc20.js|1:1|\r\n|common/libs/transaction.js|Rework to only use wei|\r\n|common/libs/units.js|Rework to force everything into wei / use classes|\r\n|common/reducers/wallet.js|1:1 (Type only)|\r\n|common/selectors/wallet.js|1:1|\r\n|common/utils/formatters.js|Likely needs to be moved into libs/units.js, assumes decimals|\r\n|spec/libs/erc20.spec.js|Reworked to not use decimals|\r\n|spec/libs/contract.spec.js|Unused|\r\n|spec/libs/units.spec.js|Reworked to not make bigs from decimals|\r\n|spec/reducers/wallet.spec.js|1:1|\r\n|spec/utils/formatters.spec.js|Mostly removed, see common/utils/formatter.js|\r\n|common/components/BalanceSidebar/AccountInfo.jsx|1:1 (Type only)|\r\n|common/components/BalanceSidebar/EquivalentValues.jsx|Unused|\r\n|common/components/BalanceSidebar/index.jsx|Unused|\r\n|common/libs/nodes/INode.js|1:1 (Type only)|\r\n|common/libs/wallet/trezor.js|Uncertain, not sure what values a transaction `v` can be|\r\n|.../BalanceSidebar/TokenBalances/TokenRow.jsx|1:1 (Type only)|\r\n|common/containers/Tabs/SendTransaction/index.jsx|1:1|\r\n|common/libs/nodes/rpc/index.js|I think token values may need to be reworked, unsure if they come back in \"wei\"|\r\n|common/libs/nodes/rpc/utils.js|1:1 (Type only)|\r\n|spec/libs/nodes/rpc/rpc.spec.js|1:1|\r\n|.../SendTransaction/components/ConfirmationModal.jsx|Will need to stop using the toUnit function|"}}
{"actor":{"display_login":"wbobeirne"}}