{"action":"created","comment":{"url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments/158358075","pull_request_review_id":85155155,"id":158358075,"diff_hunk":"@@ -0,0 +1,70 @@\n+package cwl\n+\n+import cwl.InitialWorkDirRequirement.{ExpressionOrString, IwdrListingArrayEntry, _}\n+import eu.timepit.refined.W\n+import shapeless.{:+:, CNil, _}\n+\n+final case class InitialWorkDirRequirement(\n+                                            `class`: W.`\"InitialWorkDirRequirement\"`.T,\n+                                            listing: Array[IwdrListingArrayEntry] :+: ExpressionOrString :+: CNil\n+                                          ) {\n+  val listings: Array[IwdrListingArrayEntry] = listing match {\n+    case IwdrListingArray(array) => array\n+    case ExpressionOrString(eos) => Array(Coproduct[IwdrListingArrayEntry](eos))\n+  }\n+\n+  override def toString: WorkflowStepInputId =\n+    s\"\"\"InitialWorkDirRequirement(\n+      |  ${listings.mkString(System.lineSeparator + \"  \")}\n+      |)\"\"\".stripMargin\n+}\n+\n+/**\n+  *  Short for \"Directory Entry\"\n+  *  @see <a href=\"http://www.commonwl.org/v1.0/CommandLineTool.html#Dirent\">Dirent Specification</a>\n+  *\n+  *  Split into two cases because entryName is only optional if entry is an Expression\n+  */\n+trait Dirent {\n+  def writable: Option[Boolean]","path":"cwl/src/main/scala/cwl/InitialWorkDirRequirement.scala","position":29,"original_position":29,"commit_id":"fe2f3851d1a613c2471eebe4a75d04da0438d31e","original_commit_id":"fe2f3851d1a613c2471eebe4a75d04da0438d31e","user":{"login":"danbills","id":165320,"avatar_url":"https://avatars1.githubusercontent.com/u/165320?v=4","gravatar_id":"","url":"https://api.github.com/users/danbills","html_url":"https://github.com/danbills","followers_url":"https://api.github.com/users/danbills/followers","following_url":"https://api.github.com/users/danbills/following{/other_user}","gists_url":"https://api.github.com/users/danbills/gists{/gist_id}","starred_url":"https://api.github.com/users/danbills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbills/subscriptions","organizations_url":"https://api.github.com/users/danbills/orgs","repos_url":"https://api.github.com/users/danbills/repos","events_url":"https://api.github.com/users/danbills/events{/privacy}","received_events_url":"https://api.github.com/users/danbills/received_events","type":"User","site_admin":false},"body":"consider making this `protected`?  Seems like one would always want `writableWithDefault`.  \r\n\r\nAlthough off the top of my head I don't know how the override w/ case class would work, it might anger the compiler if it made the field public.","created_at":"2017-12-21T19:22:36Z","updated_at":"2017-12-21T19:26:24Z","html_url":"https://github.com/broadinstitute/cromwell/pull/3078#discussion_r158358075","pull_request_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/3078","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments/158358075"},"html":{"href":"https://github.com/broadinstitute/cromwell/pull/3078#discussion_r158358075"},"pull_request":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/3078"}}},"pull_request":{"url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/3078","id":159247905,"html_url":"https://github.com/broadinstitute/cromwell/pull/3078","diff_url":"https://github.com/broadinstitute/cromwell/pull/3078.diff","patch_url":"https://github.com/broadinstitute/cromwell/pull/3078.patch","issue_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/3078","number":3078,"state":"open","locked":false,"title":"InitialWorkDirRequirement for inline content","user":{"login":"cjllanwarne","id":13006282,"avatar_url":"https://avatars1.githubusercontent.com/u/13006282?v=4","gravatar_id":"","url":"https://api.github.com/users/cjllanwarne","html_url":"https://github.com/cjllanwarne","followers_url":"https://api.github.com/users/cjllanwarne/followers","following_url":"https://api.github.com/users/cjllanwarne/following{/other_user}","gists_url":"https://api.github.com/users/cjllanwarne/gists{/gist_id}","starred_url":"https://api.github.com/users/cjllanwarne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjllanwarne/subscriptions","organizations_url":"https://api.github.com/users/cjllanwarne/orgs","repos_url":"https://api.github.com/users/cjllanwarne/repos","events_url":"https://api.github.com/users/cjllanwarne/events{/privacy}","received_events_url":"https://api.github.com/users/cjllanwarne/received_events","type":"User","site_admin":false},"body":"See [the new centaur cwl](https://github.com/broadinstitute/cromwell/blob/cjl_initial_work_dir_requirement/centaur/src/main/resources/standardTestCases/InitialWorkDirRequirement/inline_file.cwl) for the specific case that this PR enables.\r\n\r\nThere's plenty more to come for the other scenarios of `InitialWorkDirRequirement`, but one PR at a time...","created_at":"2017-12-19T19:10:12Z","updated_at":"2017-12-21T19:26:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"69c87b27d557cab588133df30b64c86ce89b4c3b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/3078/commits","review_comments_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/3078/comments","review_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments{/number}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/3078/comments","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/fe2f3851d1a613c2471eebe4a75d04da0438d31e","head":{"label":"broadinstitute:cjl_initial_work_dir_requirement","ref":"cjl_initial_work_dir_requirement","sha":"fe2f3851d1a613c2471eebe4a75d04da0438d31e","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34136406,"name":"cromwell","full_name":"broadinstitute/cromwell","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/cromwell","description":"Workflow Execution Engine using WDL","fork":false,"url":"https://api.github.com/repos/broadinstitute/cromwell","forks_url":"https://api.github.com/repos/broadinstitute/cromwell/forks","keys_url":"https://api.github.com/repos/broadinstitute/cromwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/cromwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/cromwell/teams","hooks_url":"https://api.github.com/repos/broadinstitute/cromwell/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/cromwell/events","assignees_url":"https://api.github.com/repos/broadinstitute/cromwell/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/cromwell/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/cromwell/tags","blobs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/cromwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/cromwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/cromwell/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/cromwell/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/cromwell/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/cromwell/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/cromwell/subscription","commits_url":"https://api.github.com/repos/broadinstitute/cromwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/cromwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/cromwell/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/cromwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/cromwell/merges","archive_url":"https://api.github.com/repos/broadinstitute/cromwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/cromwell/downloads","issues_url":"https://api.github.com/repos/broadinstitute/cromwell/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/cromwell/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/cromwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/cromwell/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/cromwell/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/cromwell/deployments","created_at":"2015-04-17T19:39:36Z","updated_at":"2017-12-21T18:28:02Z","pushed_at":"2017-12-21T19:09:14Z","git_url":"git://github.com/broadinstitute/cromwell.git","ssh_url":"git@github.com:broadinstitute/cromwell.git","clone_url":"https://github.com/broadinstitute/cromwell.git","svn_url":"https://github.com/broadinstitute/cromwell","homepage":"","size":14454,"stargazers_count":188,"watchers_count":188,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":378,"license":null,"forks":48,"open_issues":378,"watchers":188,"default_branch":"develop"}},"base":{"label":"broadinstitute:develop","ref":"develop","sha":"e05710509da3745b04730326a3142b264a4aa5ac","user":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"repo":{"id":34136406,"name":"cromwell","full_name":"broadinstitute/cromwell","owner":{"login":"broadinstitute","id":393552,"avatar_url":"https://avatars0.githubusercontent.com/u/393552?v=4","gravatar_id":"","url":"https://api.github.com/users/broadinstitute","html_url":"https://github.com/broadinstitute","followers_url":"https://api.github.com/users/broadinstitute/followers","following_url":"https://api.github.com/users/broadinstitute/following{/other_user}","gists_url":"https://api.github.com/users/broadinstitute/gists{/gist_id}","starred_url":"https://api.github.com/users/broadinstitute/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/broadinstitute/subscriptions","organizations_url":"https://api.github.com/users/broadinstitute/orgs","repos_url":"https://api.github.com/users/broadinstitute/repos","events_url":"https://api.github.com/users/broadinstitute/events{/privacy}","received_events_url":"https://api.github.com/users/broadinstitute/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/broadinstitute/cromwell","description":"Workflow Execution Engine using WDL","fork":false,"url":"https://api.github.com/repos/broadinstitute/cromwell","forks_url":"https://api.github.com/repos/broadinstitute/cromwell/forks","keys_url":"https://api.github.com/repos/broadinstitute/cromwell/keys{/key_id}","collaborators_url":"https://api.github.com/repos/broadinstitute/cromwell/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/broadinstitute/cromwell/teams","hooks_url":"https://api.github.com/repos/broadinstitute/cromwell/hooks","issue_events_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/events{/number}","events_url":"https://api.github.com/repos/broadinstitute/cromwell/events","assignees_url":"https://api.github.com/repos/broadinstitute/cromwell/assignees{/user}","branches_url":"https://api.github.com/repos/broadinstitute/cromwell/branches{/branch}","tags_url":"https://api.github.com/repos/broadinstitute/cromwell/tags","blobs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/broadinstitute/cromwell/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/broadinstitute/cromwell/git/refs{/sha}","trees_url":"https://api.github.com/repos/broadinstitute/cromwell/git/trees{/sha}","statuses_url":"https://api.github.com/repos/broadinstitute/cromwell/statuses/{sha}","languages_url":"https://api.github.com/repos/broadinstitute/cromwell/languages","stargazers_url":"https://api.github.com/repos/broadinstitute/cromwell/stargazers","contributors_url":"https://api.github.com/repos/broadinstitute/cromwell/contributors","subscribers_url":"https://api.github.com/repos/broadinstitute/cromwell/subscribers","subscription_url":"https://api.github.com/repos/broadinstitute/cromwell/subscription","commits_url":"https://api.github.com/repos/broadinstitute/cromwell/commits{/sha}","git_commits_url":"https://api.github.com/repos/broadinstitute/cromwell/git/commits{/sha}","comments_url":"https://api.github.com/repos/broadinstitute/cromwell/comments{/number}","issue_comment_url":"https://api.github.com/repos/broadinstitute/cromwell/issues/comments{/number}","contents_url":"https://api.github.com/repos/broadinstitute/cromwell/contents/{+path}","compare_url":"https://api.github.com/repos/broadinstitute/cromwell/compare/{base}...{head}","merges_url":"https://api.github.com/repos/broadinstitute/cromwell/merges","archive_url":"https://api.github.com/repos/broadinstitute/cromwell/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/broadinstitute/cromwell/downloads","issues_url":"https://api.github.com/repos/broadinstitute/cromwell/issues{/number}","pulls_url":"https://api.github.com/repos/broadinstitute/cromwell/pulls{/number}","milestones_url":"https://api.github.com/repos/broadinstitute/cromwell/milestones{/number}","notifications_url":"https://api.github.com/repos/broadinstitute/cromwell/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/broadinstitute/cromwell/labels{/name}","releases_url":"https://api.github.com/repos/broadinstitute/cromwell/releases{/id}","deployments_url":"https://api.github.com/repos/broadinstitute/cromwell/deployments","created_at":"2015-04-17T19:39:36Z","updated_at":"2017-12-21T18:28:02Z","pushed_at":"2017-12-21T19:09:14Z","git_url":"git://github.com/broadinstitute/cromwell.git","ssh_url":"git@github.com:broadinstitute/cromwell.git","clone_url":"https://github.com/broadinstitute/cromwell.git","svn_url":"https://github.com/broadinstitute/cromwell","homepage":"","size":14454,"stargazers_count":188,"watchers_count":188,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":378,"license":null,"forks":48,"open_issues":378,"watchers":188,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/3078"},"html":{"href":"https://github.com/broadinstitute/cromwell/pull/3078"},"issue":{"href":"https://api.github.com/repos/broadinstitute/cromwell/issues/3078"},"comments":{"href":"https://api.github.com/repos/broadinstitute/cromwell/issues/3078/comments"},"review_comments":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/3078/comments"},"review_comment":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/broadinstitute/cromwell/pulls/3078/commits"},"statuses":{"href":"https://api.github.com/repos/broadinstitute/cromwell/statuses/fe2f3851d1a613c2471eebe4a75d04da0438d31e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danbills"}}