{"action":"created","comment":{"url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/comments/149195906","pull_request_review_id":74553032,"id":149195906,"diff_hunk":"@@ -1969,14 +1957,6 @@ def test_collections_post_edit(self):\n         eq_(\"website_id\", setting.key)\n         eq_(\"1234\", setting.value)\n \n-        setting = collection.external_integration.setting(\"default_loan_period\")\n-        eq_(\"default_loan_period\", setting.key)\n-        eq_(\"14\", setting.value)","path":"tests/admin/test_controller.py","position":15,"original_position":41,"commit_id":"7d63ac825602e598e910e13e8e0275db12b2576a","original_commit_id":"7d63ac825602e598e910e13e8e0275db12b2576a","user":{"login":"aslagle","id":3409215,"avatar_url":"https://avatars3.githubusercontent.com/u/3409215?v=4","gravatar_id":"","url":"https://api.github.com/users/aslagle","html_url":"https://github.com/aslagle","followers_url":"https://api.github.com/users/aslagle/followers","following_url":"https://api.github.com/users/aslagle/following{/other_user}","gists_url":"https://api.github.com/users/aslagle/gists{/gist_id}","starred_url":"https://api.github.com/users/aslagle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aslagle/subscriptions","organizations_url":"https://api.github.com/users/aslagle/orgs","repos_url":"https://api.github.com/users/aslagle/repos","events_url":"https://api.github.com/users/aslagle/events{/privacy}","received_events_url":"https://api.github.com/users/aslagle/received_events","type":"User","site_admin":false},"body":"I think you have it right, but this is testing with an Overdrive collection and Overdrive doesn't have that setting.","created_at":"2017-11-06T20:36:39Z","updated_at":"2017-11-06T20:36:39Z","html_url":"https://github.com/NYPL-Simplified/circulation/pull/764#discussion_r149195906","pull_request_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/764","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/comments/149195906"},"html":{"href":"https://github.com/NYPL-Simplified/circulation/pull/764#discussion_r149195906"},"pull_request":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/764"}},"in_reply_to_id":149194872},"pull_request":{"url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/764","id":150935050,"html_url":"https://github.com/NYPL-Simplified/circulation/pull/764","diff_url":"https://github.com/NYPL-Simplified/circulation/pull/764.diff","patch_url":"https://github.com/NYPL-Simplified/circulation/pull/764.patch","issue_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/764","number":764,"state":"open","locked":false,"title":"Make loan duration a per-library per-collection setting and make sure it's always corectly described.","user":{"login":"leonardr","id":662474,"avatar_url":"https://avatars0.githubusercontent.com/u/662474?v=4","gravatar_id":"","url":"https://api.github.com/users/leonardr","html_url":"https://github.com/leonardr","followers_url":"https://api.github.com/users/leonardr/followers","following_url":"https://api.github.com/users/leonardr/following{/other_user}","gists_url":"https://api.github.com/users/leonardr/gists{/gist_id}","starred_url":"https://api.github.com/users/leonardr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonardr/subscriptions","organizations_url":"https://api.github.com/users/leonardr/orgs","repos_url":"https://api.github.com/users/leonardr/repos","events_url":"https://api.github.com/users/leonardr/events{/privacy}","received_events_url":"https://api.github.com/users/leonardr/received_events","type":"User","site_admin":false},"body":"This branch makes sure that all of our CollectionAPI subclasses (except the ones that offer unlimited-length loans) have one (ebooks) or two (ebooks+audiobooks) settings relating to loan durations.\r\n\r\nFor Overdrive, Axis, and Bibliotheca, these settings are informative only. They reflect the _default_ or _assumed average_ lengths of loans but the circulation manager has no power over the lengths of loans created through these services.\r\n\r\nFor ODL and RBdigital, these settings are active. When a loan is created, the duration of the loan is taken from this setting.\r\n\r\nAll this code existed before, but ODL and RBdigital were handled inconsistently, the settings were per-collection instead of per-library per-collection, and the descriptions of the settings didn't make it clear when these settings were informative and when they were active.","created_at":"2017-11-06T19:14:39Z","updated_at":"2017-11-06T20:36:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6e20f96974da1f7475c6fd5abcdf52182639ae31","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/764/commits","review_comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/764/comments","review_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/764/comments","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation/statuses/7d63ac825602e598e910e13e8e0275db12b2576a","head":{"label":"NYPL-Simplified:normalized-loan-durations","ref":"normalized-loan-durations","sha":"7d63ac825602e598e910e13e8e0275db12b2576a","user":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":27605405,"name":"circulation","full_name":"NYPL-Simplified/circulation","owner":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL-Simplified/circulation","description":"Circulation manager for Library Simplified","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/circulation","forks_url":"https://api.github.com/repos/NYPL-Simplified/circulation/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/circulation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/circulation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/circulation/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/circulation/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/circulation/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/circulation/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/circulation/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/circulation/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/circulation/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/circulation/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/circulation/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/circulation/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/circulation/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/circulation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/circulation/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/circulation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/circulation/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/circulation/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/circulation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/circulation/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/circulation/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/deployments","created_at":"2014-12-05T18:53:04Z","updated_at":"2017-09-15T12:58:34Z","pushed_at":"2017-11-06T20:15:58Z","git_url":"git://github.com/NYPL-Simplified/circulation.git","ssh_url":"git@github.com:NYPL-Simplified/circulation.git","clone_url":"https://github.com/NYPL-Simplified/circulation.git","svn_url":"https://github.com/NYPL-Simplified/circulation","homepage":null,"size":5277,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":91,"forks":8,"open_issues":91,"watchers":4,"default_branch":"master"}},"base":{"label":"NYPL-Simplified:master","ref":"master","sha":"ad51a7c0e2cf724bdc2830283156c7cde8f1f392","user":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"repo":{"id":27605405,"name":"circulation","full_name":"NYPL-Simplified/circulation","owner":{"login":"NYPL-Simplified","id":16416905,"avatar_url":"https://avatars1.githubusercontent.com/u/16416905?v=4","gravatar_id":"","url":"https://api.github.com/users/NYPL-Simplified","html_url":"https://github.com/NYPL-Simplified","followers_url":"https://api.github.com/users/NYPL-Simplified/followers","following_url":"https://api.github.com/users/NYPL-Simplified/following{/other_user}","gists_url":"https://api.github.com/users/NYPL-Simplified/gists{/gist_id}","starred_url":"https://api.github.com/users/NYPL-Simplified/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NYPL-Simplified/subscriptions","organizations_url":"https://api.github.com/users/NYPL-Simplified/orgs","repos_url":"https://api.github.com/users/NYPL-Simplified/repos","events_url":"https://api.github.com/users/NYPL-Simplified/events{/privacy}","received_events_url":"https://api.github.com/users/NYPL-Simplified/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NYPL-Simplified/circulation","description":"Circulation manager for Library Simplified","fork":false,"url":"https://api.github.com/repos/NYPL-Simplified/circulation","forks_url":"https://api.github.com/repos/NYPL-Simplified/circulation/forks","keys_url":"https://api.github.com/repos/NYPL-Simplified/circulation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NYPL-Simplified/circulation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NYPL-Simplified/circulation/teams","hooks_url":"https://api.github.com/repos/NYPL-Simplified/circulation/hooks","issue_events_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/events{/number}","events_url":"https://api.github.com/repos/NYPL-Simplified/circulation/events","assignees_url":"https://api.github.com/repos/NYPL-Simplified/circulation/assignees{/user}","branches_url":"https://api.github.com/repos/NYPL-Simplified/circulation/branches{/branch}","tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation/tags","blobs_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/refs{/sha}","trees_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NYPL-Simplified/circulation/statuses/{sha}","languages_url":"https://api.github.com/repos/NYPL-Simplified/circulation/languages","stargazers_url":"https://api.github.com/repos/NYPL-Simplified/circulation/stargazers","contributors_url":"https://api.github.com/repos/NYPL-Simplified/circulation/contributors","subscribers_url":"https://api.github.com/repos/NYPL-Simplified/circulation/subscribers","subscription_url":"https://api.github.com/repos/NYPL-Simplified/circulation/subscription","commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/commits{/sha}","git_commits_url":"https://api.github.com/repos/NYPL-Simplified/circulation/git/commits{/sha}","comments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/comments{/number}","issue_comment_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/comments{/number}","contents_url":"https://api.github.com/repos/NYPL-Simplified/circulation/contents/{+path}","compare_url":"https://api.github.com/repos/NYPL-Simplified/circulation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NYPL-Simplified/circulation/merges","archive_url":"https://api.github.com/repos/NYPL-Simplified/circulation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NYPL-Simplified/circulation/downloads","issues_url":"https://api.github.com/repos/NYPL-Simplified/circulation/issues{/number}","pulls_url":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls{/number}","milestones_url":"https://api.github.com/repos/NYPL-Simplified/circulation/milestones{/number}","notifications_url":"https://api.github.com/repos/NYPL-Simplified/circulation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NYPL-Simplified/circulation/labels{/name}","releases_url":"https://api.github.com/repos/NYPL-Simplified/circulation/releases{/id}","deployments_url":"https://api.github.com/repos/NYPL-Simplified/circulation/deployments","created_at":"2014-12-05T18:53:04Z","updated_at":"2017-09-15T12:58:34Z","pushed_at":"2017-11-06T20:15:58Z","git_url":"git://github.com/NYPL-Simplified/circulation.git","ssh_url":"git@github.com:NYPL-Simplified/circulation.git","clone_url":"https://github.com/NYPL-Simplified/circulation.git","svn_url":"https://github.com/NYPL-Simplified/circulation","homepage":null,"size":5277,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":91,"forks":8,"open_issues":91,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/764"},"html":{"href":"https://github.com/NYPL-Simplified/circulation/pull/764"},"issue":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/764"},"comments":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/issues/764/comments"},"review_comments":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/764/comments"},"review_comment":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/pulls/764/commits"},"statuses":{"href":"https://api.github.com/repos/NYPL-Simplified/circulation/statuses/7d63ac825602e598e910e13e8e0275db12b2576a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aslagle"}}