{"action":"created","issue":{"url":"https://api.github.com/repos/inasafe/inasafe/issues/4555","repository_url":"https://api.github.com/repos/inasafe/inasafe","labels_url":"https://api.github.com/repos/inasafe/inasafe/issues/4555/labels{/name}","comments_url":"https://api.github.com/repos/inasafe/inasafe/issues/4555/comments","events_url":"https://api.github.com/repos/inasafe/inasafe/issues/4555/events","html_url":"https://github.com/inasafe/inasafe/pull/4555","id":269052906,"number":4555,"title":"Refactoring Post Processor to Avoid Circular Import","user":{"login":"ismailsunni","id":1421861,"avatar_url":"https://avatars3.githubusercontent.com/u/1421861?v=4","gravatar_id":"","url":"https://api.github.com/users/ismailsunni","html_url":"https://github.com/ismailsunni","followers_url":"https://api.github.com/users/ismailsunni/followers","following_url":"https://api.github.com/users/ismailsunni/following{/other_user}","gists_url":"https://api.github.com/users/ismailsunni/gists{/gist_id}","starred_url":"https://api.github.com/users/ismailsunni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismailsunni/subscriptions","organizations_url":"https://api.github.com/users/ismailsunni/orgs","repos_url":"https://api.github.com/users/ismailsunni/repos","events_url":"https://api.github.com/users/ismailsunni/events{/privacy}","received_events_url":"https://api.github.com/users/ismailsunni/received_events","type":"User","site_admin":false},"labels":[{"id":132340632,"url":"https://api.github.com/repos/inasafe/inasafe/labels/Needs%20review","name":"Needs review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-10-27T10:01:09Z","updated_at":"2017-10-28T08:23:28Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/inasafe/inasafe/pulls/4555","html_url":"https://github.com/inasafe/inasafe/pull/4555","diff_url":"https://github.com/inasafe/inasafe/pull/4555.diff","patch_url":"https://github.com/inasafe/inasafe/pull/4555.patch"},"body":"### What does it fix?\r\n* Ticket: #4482 \r\n* Funded by: DFAT\r\n* Description: \r\n   - Since I found circular import when using get_displacement_rate from the profile, I need to do refactoring of it. It's still on progress though.\r\n\r\n### Checklist:\r\n- [x] Commit messages are descriptive and explain the rationale for changes\r\n- [ ] Add to the changelog in metadata.txt if it's a new feature\r\n- [ ] Unit test for new code added\r\n- [ ] Request someone to review or test your PR\r\n"},"comment":{"url":"https://api.github.com/repos/inasafe/inasafe/issues/comments/340159288","html_url":"https://github.com/inasafe/inasafe/pull/4555#issuecomment-340159288","issue_url":"https://api.github.com/repos/inasafe/inasafe/issues/4555","id":340159288,"user":{"login":"Gustry","id":1609292,"avatar_url":"https://avatars2.githubusercontent.com/u/1609292?v=4","gravatar_id":"","url":"https://api.github.com/users/Gustry","html_url":"https://github.com/Gustry","followers_url":"https://api.github.com/users/Gustry/followers","following_url":"https://api.github.com/users/Gustry/following{/other_user}","gists_url":"https://api.github.com/users/Gustry/gists{/gist_id}","starred_url":"https://api.github.com/users/Gustry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gustry/subscriptions","organizations_url":"https://api.github.com/users/Gustry/orgs","repos_url":"https://api.github.com/users/Gustry/repos","events_url":"https://api.github.com/users/Gustry/events{/privacy}","received_events_url":"https://api.github.com/users/Gustry/received_events","type":"User","site_admin":false},"created_at":"2017-10-28T08:23:28Z","updated_at":"2017-10-28T08:23:28Z","author_association":"CONTRIBUTOR","body":"> It seems I still do not understand about it. Can you elaborate it @Gustry ?\r\n\r\nNext time I will run the \"optimize imports\", it will erase all your work of reordering imports. Then I run the script 'checkout_back_after_cleaning_from_pycharm.sh' to rollback pycharm's changes. So you need to add all files that you don't want to be updated by PyCharm.\r\n\r\nLGTM for the code ;-)\r\nSorry for the iface, I will try again, I know which test to check now."}}
{"actor":{"display_login":"Gustry"}}