{"action":"created","comment":{"url":"https://api.github.com/repos/zenhack/simp_le/pulls/comments/137934136","pull_request_review_id":61669982,"id":137934136,"diff_hunk":"@@ -0,0 +1,21 @@\n+FROM alpine:3.6\n+\n+MAINTAINER Ian Denhardt (@zenhack)\n+\n+ARG SIMP_LE_VERSION=master\n+\n+ENV PATH=/usr/local/bin:$PATH \\\n+    SIMP_LE_VERSION=${SIMP_LE_VERSION}\n+\n+RUN apk --no-cache add bash openssl python3 && \\\n+    apk --no-cache --virtual .build-deps add gcc git libffi-dev musl-dev openssl-dev py-pip python3-dev && \\\n+    pip3 install --no-cache-dir --upgrade pip setuptools wheel && \\","path":"docker/Dockerfile","position":12,"original_position":12,"commit_id":"85b1a20b311ef9bee123085fd9193f6094dc17d4","original_commit_id":"85b1a20b311ef9bee123085fd9193f6094dc17d4","user":{"login":"zenhack","id":883774,"avatar_url":"https://avatars2.githubusercontent.com/u/883774?v=4","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"body":"Is this line actually needed on alpine? We reinstall/upgrade pip/setuptools/wheel in the venv.sh script because it's supposed to work on a range of distributions, including really stuff like rhel/centos 6.x which has outdated versions of these tools, but it isn't needed on most systems -- part of my gripe about the two Dockerfiles is that there's a certain amount of common boilerplate, getting rid of this would reduce that somewhat.\r\n\r\nAlso, could we encapsulate the bulk of this RUN command in a shell script, and call it from both Dockerfiles?\r\n\r\nI've decided I'm okay having more than one, but I'd still like to factor out the common bits where we can.","created_at":"2017-09-09T20:02:29Z","updated_at":"2017-09-09T20:02:29Z","html_url":"https://github.com/zenhack/simp_le/pull/66#discussion_r137934136","pull_request_url":"https://api.github.com/repos/zenhack/simp_le/pulls/66","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zenhack/simp_le/pulls/comments/137934136"},"html":{"href":"https://github.com/zenhack/simp_le/pull/66#discussion_r137934136"},"pull_request":{"href":"https://api.github.com/repos/zenhack/simp_le/pulls/66"}}},"pull_request":{"url":"https://api.github.com/repos/zenhack/simp_le/pulls/66","id":139023479,"html_url":"https://github.com/zenhack/simp_le/pull/66","diff_url":"https://github.com/zenhack/simp_le/pull/66.diff","patch_url":"https://github.com/zenhack/simp_le/pull/66.patch","issue_url":"https://api.github.com/repos/zenhack/simp_le/issues/66","number":66,"state":"open","locked":false,"title":"Add Docker support","user":{"login":"buchdag","id":13685826,"avatar_url":"https://avatars1.githubusercontent.com/u/13685826?v=4","gravatar_id":"","url":"https://api.github.com/users/buchdag","html_url":"https://github.com/buchdag","followers_url":"https://api.github.com/users/buchdag/followers","following_url":"https://api.github.com/users/buchdag/following{/other_user}","gists_url":"https://api.github.com/users/buchdag/gists{/gist_id}","starred_url":"https://api.github.com/users/buchdag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchdag/subscriptions","organizations_url":"https://api.github.com/users/buchdag/orgs","repos_url":"https://api.github.com/users/buchdag/repos","events_url":"https://api.github.com/users/buchdag/events{/privacy}","received_events_url":"https://api.github.com/users/buchdag/received_events","type":"User","site_admin":false},"body":"This PR add Docker support to the project and the relevant Travis tests.\r\n\r\nThe image is based on Alpine linux 3.6 with Python 3 and weight ~ 85MB\r\n\r\nThe following:\r\n\r\n```\r\nservices:\r\n  - docker\r\n```\r\n\r\nhas been removed from the travis.yml file as [it isn't needed anymore with the Travis Trusty build environment](https://docs.travis-ci.com/user/reference/trusty/#Docker) and triggered a warning message.","created_at":"2017-09-02T19:19:37Z","updated_at":"2017-09-09T20:02:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf525e94021a636e4cde4598b563b410d73a7ade","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/zenhack/simp_le/pulls/66/commits","review_comments_url":"https://api.github.com/repos/zenhack/simp_le/pulls/66/comments","review_comment_url":"https://api.github.com/repos/zenhack/simp_le/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zenhack/simp_le/issues/66/comments","statuses_url":"https://api.github.com/repos/zenhack/simp_le/statuses/85b1a20b311ef9bee123085fd9193f6094dc17d4","head":{"label":"buchdag:docker","ref":"docker","sha":"85b1a20b311ef9bee123085fd9193f6094dc17d4","user":{"login":"buchdag","id":13685826,"avatar_url":"https://avatars1.githubusercontent.com/u/13685826?v=4","gravatar_id":"","url":"https://api.github.com/users/buchdag","html_url":"https://github.com/buchdag","followers_url":"https://api.github.com/users/buchdag/followers","following_url":"https://api.github.com/users/buchdag/following{/other_user}","gists_url":"https://api.github.com/users/buchdag/gists{/gist_id}","starred_url":"https://api.github.com/users/buchdag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchdag/subscriptions","organizations_url":"https://api.github.com/users/buchdag/orgs","repos_url":"https://api.github.com/users/buchdag/repos","events_url":"https://api.github.com/users/buchdag/events{/privacy}","received_events_url":"https://api.github.com/users/buchdag/received_events","type":"User","site_admin":false},"repo":{"id":95657926,"name":"simp_le","full_name":"buchdag/simp_le","owner":{"login":"buchdag","id":13685826,"avatar_url":"https://avatars1.githubusercontent.com/u/13685826?v=4","gravatar_id":"","url":"https://api.github.com/users/buchdag","html_url":"https://github.com/buchdag","followers_url":"https://api.github.com/users/buchdag/followers","following_url":"https://api.github.com/users/buchdag/following{/other_user}","gists_url":"https://api.github.com/users/buchdag/gists{/gist_id}","starred_url":"https://api.github.com/users/buchdag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/buchdag/subscriptions","organizations_url":"https://api.github.com/users/buchdag/orgs","repos_url":"https://api.github.com/users/buchdag/repos","events_url":"https://api.github.com/users/buchdag/events{/privacy}","received_events_url":"https://api.github.com/users/buchdag/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/buchdag/simp_le","description":"Simple Let's Encrypt client","fork":true,"url":"https://api.github.com/repos/buchdag/simp_le","forks_url":"https://api.github.com/repos/buchdag/simp_le/forks","keys_url":"https://api.github.com/repos/buchdag/simp_le/keys{/key_id}","collaborators_url":"https://api.github.com/repos/buchdag/simp_le/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/buchdag/simp_le/teams","hooks_url":"https://api.github.com/repos/buchdag/simp_le/hooks","issue_events_url":"https://api.github.com/repos/buchdag/simp_le/issues/events{/number}","events_url":"https://api.github.com/repos/buchdag/simp_le/events","assignees_url":"https://api.github.com/repos/buchdag/simp_le/assignees{/user}","branches_url":"https://api.github.com/repos/buchdag/simp_le/branches{/branch}","tags_url":"https://api.github.com/repos/buchdag/simp_le/tags","blobs_url":"https://api.github.com/repos/buchdag/simp_le/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/buchdag/simp_le/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/buchdag/simp_le/git/refs{/sha}","trees_url":"https://api.github.com/repos/buchdag/simp_le/git/trees{/sha}","statuses_url":"https://api.github.com/repos/buchdag/simp_le/statuses/{sha}","languages_url":"https://api.github.com/repos/buchdag/simp_le/languages","stargazers_url":"https://api.github.com/repos/buchdag/simp_le/stargazers","contributors_url":"https://api.github.com/repos/buchdag/simp_le/contributors","subscribers_url":"https://api.github.com/repos/buchdag/simp_le/subscribers","subscription_url":"https://api.github.com/repos/buchdag/simp_le/subscription","commits_url":"https://api.github.com/repos/buchdag/simp_le/commits{/sha}","git_commits_url":"https://api.github.com/repos/buchdag/simp_le/git/commits{/sha}","comments_url":"https://api.github.com/repos/buchdag/simp_le/comments{/number}","issue_comment_url":"https://api.github.com/repos/buchdag/simp_le/issues/comments{/number}","contents_url":"https://api.github.com/repos/buchdag/simp_le/contents/{+path}","compare_url":"https://api.github.com/repos/buchdag/simp_le/compare/{base}...{head}","merges_url":"https://api.github.com/repos/buchdag/simp_le/merges","archive_url":"https://api.github.com/repos/buchdag/simp_le/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/buchdag/simp_le/downloads","issues_url":"https://api.github.com/repos/buchdag/simp_le/issues{/number}","pulls_url":"https://api.github.com/repos/buchdag/simp_le/pulls{/number}","milestones_url":"https://api.github.com/repos/buchdag/simp_le/milestones{/number}","notifications_url":"https://api.github.com/repos/buchdag/simp_le/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/buchdag/simp_le/labels{/name}","releases_url":"https://api.github.com/repos/buchdag/simp_le/releases{/id}","deployments_url":"https://api.github.com/repos/buchdag/simp_le/deployments","created_at":"2017-06-28T10:35:40Z","updated_at":"2017-06-28T10:35:41Z","pushed_at":"2017-09-09T15:54:06Z","git_url":"git://github.com/buchdag/simp_le.git","ssh_url":"git@github.com:buchdag/simp_le.git","clone_url":"https://github.com/buchdag/simp_le.git","svn_url":"https://github.com/buchdag/simp_le","homepage":"","size":350,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zenhack:master","ref":"master","sha":"fd5666d5035cd8e6770e54fae994239ca32eea76","user":{"login":"zenhack","id":883774,"avatar_url":"https://avatars2.githubusercontent.com/u/883774?v=4","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"repo":{"id":46328743,"name":"simp_le","full_name":"zenhack/simp_le","owner":{"login":"zenhack","id":883774,"avatar_url":"https://avatars2.githubusercontent.com/u/883774?v=4","gravatar_id":"","url":"https://api.github.com/users/zenhack","html_url":"https://github.com/zenhack","followers_url":"https://api.github.com/users/zenhack/followers","following_url":"https://api.github.com/users/zenhack/following{/other_user}","gists_url":"https://api.github.com/users/zenhack/gists{/gist_id}","starred_url":"https://api.github.com/users/zenhack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zenhack/subscriptions","organizations_url":"https://api.github.com/users/zenhack/orgs","repos_url":"https://api.github.com/users/zenhack/repos","events_url":"https://api.github.com/users/zenhack/events{/privacy}","received_events_url":"https://api.github.com/users/zenhack/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zenhack/simp_le","description":"Simple Let's Encrypt client","fork":false,"url":"https://api.github.com/repos/zenhack/simp_le","forks_url":"https://api.github.com/repos/zenhack/simp_le/forks","keys_url":"https://api.github.com/repos/zenhack/simp_le/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zenhack/simp_le/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zenhack/simp_le/teams","hooks_url":"https://api.github.com/repos/zenhack/simp_le/hooks","issue_events_url":"https://api.github.com/repos/zenhack/simp_le/issues/events{/number}","events_url":"https://api.github.com/repos/zenhack/simp_le/events","assignees_url":"https://api.github.com/repos/zenhack/simp_le/assignees{/user}","branches_url":"https://api.github.com/repos/zenhack/simp_le/branches{/branch}","tags_url":"https://api.github.com/repos/zenhack/simp_le/tags","blobs_url":"https://api.github.com/repos/zenhack/simp_le/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zenhack/simp_le/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zenhack/simp_le/git/refs{/sha}","trees_url":"https://api.github.com/repos/zenhack/simp_le/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zenhack/simp_le/statuses/{sha}","languages_url":"https://api.github.com/repos/zenhack/simp_le/languages","stargazers_url":"https://api.github.com/repos/zenhack/simp_le/stargazers","contributors_url":"https://api.github.com/repos/zenhack/simp_le/contributors","subscribers_url":"https://api.github.com/repos/zenhack/simp_le/subscribers","subscription_url":"https://api.github.com/repos/zenhack/simp_le/subscription","commits_url":"https://api.github.com/repos/zenhack/simp_le/commits{/sha}","git_commits_url":"https://api.github.com/repos/zenhack/simp_le/git/commits{/sha}","comments_url":"https://api.github.com/repos/zenhack/simp_le/comments{/number}","issue_comment_url":"https://api.github.com/repos/zenhack/simp_le/issues/comments{/number}","contents_url":"https://api.github.com/repos/zenhack/simp_le/contents/{+path}","compare_url":"https://api.github.com/repos/zenhack/simp_le/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zenhack/simp_le/merges","archive_url":"https://api.github.com/repos/zenhack/simp_le/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zenhack/simp_le/downloads","issues_url":"https://api.github.com/repos/zenhack/simp_le/issues{/number}","pulls_url":"https://api.github.com/repos/zenhack/simp_le/pulls{/number}","milestones_url":"https://api.github.com/repos/zenhack/simp_le/milestones{/number}","notifications_url":"https://api.github.com/repos/zenhack/simp_le/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zenhack/simp_le/labels{/name}","releases_url":"https://api.github.com/repos/zenhack/simp_le/releases{/id}","deployments_url":"https://api.github.com/repos/zenhack/simp_le/deployments","created_at":"2015-11-17T06:50:48Z","updated_at":"2017-08-30T14:36:30Z","pushed_at":"2017-09-08T15:36:37Z","git_url":"git://github.com/zenhack/simp_le.git","ssh_url":"git@github.com:zenhack/simp_le.git","clone_url":"https://github.com/zenhack/simp_le.git","svn_url":"https://github.com/zenhack/simp_le","homepage":"","size":364,"stargazers_count":71,"watchers_count":71,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"open_issues_count":20,"forks":9,"open_issues":20,"watchers":71,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zenhack/simp_le/pulls/66"},"html":{"href":"https://github.com/zenhack/simp_le/pull/66"},"issue":{"href":"https://api.github.com/repos/zenhack/simp_le/issues/66"},"comments":{"href":"https://api.github.com/repos/zenhack/simp_le/issues/66/comments"},"review_comments":{"href":"https://api.github.com/repos/zenhack/simp_le/pulls/66/comments"},"review_comment":{"href":"https://api.github.com/repos/zenhack/simp_le/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zenhack/simp_le/pulls/66/commits"},"statuses":{"href":"https://api.github.com/repos/zenhack/simp_le/statuses/85b1a20b311ef9bee123085fd9193f6094dc17d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zenhack"}}