{"action":"created","issue":{"url":"https://api.github.com/repos/regl-project/regl/issues/411","repository_url":"https://api.github.com/repos/regl-project/regl","labels_url":"https://api.github.com/repos/regl-project/regl/issues/411/labels{/name}","comments_url":"https://api.github.com/repos/regl-project/regl/issues/411/comments","events_url":"https://api.github.com/repos/regl-project/regl/issues/411/events","html_url":"https://github.com/regl-project/regl/pull/411","id":227670687,"number":411,"title":"Adds support for Vertex Array Objects","user":{"login":"jwerle","id":1462973,"avatar_url":"https://avatars1.githubusercontent.com/u/1462973?v=4","gravatar_id":"","url":"https://api.github.com/users/jwerle","html_url":"https://github.com/jwerle","followers_url":"https://api.github.com/users/jwerle/followers","following_url":"https://api.github.com/users/jwerle/following{/other_user}","gists_url":"https://api.github.com/users/jwerle/gists{/gist_id}","starred_url":"https://api.github.com/users/jwerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwerle/subscriptions","organizations_url":"https://api.github.com/users/jwerle/orgs","repos_url":"https://api.github.com/users/jwerle/repos","events_url":"https://api.github.com/users/jwerle/events{/privacy}","received_events_url":"https://api.github.com/users/jwerle/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2017-05-10T12:56:39Z","updated_at":"2017-08-17T13:31:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/regl-project/regl/pulls/411","html_url":"https://github.com/regl-project/regl/pull/411","diff_url":"https://github.com/regl-project/regl/pull/411.diff","patch_url":"https://github.com/regl-project/regl/pull/411.patch"},"body":"This pull request adds support for vertex array objects. VAOs are created per command if attributes are given and if the underlying WebGL implementation provides support for vertex array objects through ~a native implementation or~ an extension (OES). The pull request includes tests and updates to API.md. This should address #312.\r\n\r\ncc @mikolalysenko @Erkaman @vipyne\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/regl-project/regl/411)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/regl-project/regl/issues/comments/323074236","html_url":"https://github.com/regl-project/regl/pull/411#issuecomment-323074236","issue_url":"https://api.github.com/repos/regl-project/regl/issues/411","id":323074236,"user":{"login":"jwerle","id":1462973,"avatar_url":"https://avatars1.githubusercontent.com/u/1462973?v=4","gravatar_id":"","url":"https://api.github.com/users/jwerle","html_url":"https://github.com/jwerle","followers_url":"https://api.github.com/users/jwerle/followers","following_url":"https://api.github.com/users/jwerle/following{/other_user}","gists_url":"https://api.github.com/users/jwerle/gists{/gist_id}","starred_url":"https://api.github.com/users/jwerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwerle/subscriptions","organizations_url":"https://api.github.com/users/jwerle/orgs","repos_url":"https://api.github.com/users/jwerle/repos","events_url":"https://api.github.com/users/jwerle/events{/privacy}","received_events_url":"https://api.github.com/users/jwerle/received_events","type":"User","site_admin":false},"created_at":"2017-08-17T13:31:23Z","updated_at":"2017-08-17T13:31:23Z","body":"@mikolalysenko in a fork of this, I've rewritten the VAO stuff..\r\n\r\n* A VAO is created and shared per instance of \"core\"  if extension opt-in and attributes found in `parseArguments()`\r\n* VAO is only bound when attributes are given in `emitAttributes`\r\n* VAO is binded when a draw call is made, and then unbind in `emitDraw`\r\n\r\nThis seems to work well... what do you think?\r\n"}}
{"actor":{"display_login":"jwerle"}}