{"action":"created","comment":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/158631675","pull_request_review_id":85472595,"id":158631675,"diff_hunk":"@@ -194,10 +194,10 @@ def build_latex(self):\n \n     def build_latexpdf(self):\n         # type: () -> int\n-        if self.run_generic_build('latex') > 0:\n+        if self.run_generic_build('latexpdf') > 0:\n             return 1\n-        with cd(self.builddir_join('latex')):\n-            return subprocess.call([self.makecmd, 'all-pdf'])\n+        print(\"Build finished; the PDF and LaTeX files are in %s.\" %\n+              self.builddir_join('latex'))","path":"sphinx/make_mode.py","position":10,"original_position":10,"commit_id":"d4be532fa57e6c919adebddb7557375b6af3c9b9","original_commit_id":"d4be532fa57e6c919adebddb7557375b6af3c9b9","user":{"login":"jfbu","id":2589111,"avatar_url":"https://avatars0.githubusercontent.com/u/2589111?v=4","gravatar_id":"","url":"https://api.github.com/users/jfbu","html_url":"https://github.com/jfbu","followers_url":"https://api.github.com/users/jfbu/followers","following_url":"https://api.github.com/users/jfbu/following{/other_user}","gists_url":"https://api.github.com/users/jfbu/gists{/gist_id}","starred_url":"https://api.github.com/users/jfbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jfbu/subscriptions","organizations_url":"https://api.github.com/users/jfbu/orgs","repos_url":"https://api.github.com/users/jfbu/repos","events_url":"https://api.github.com/users/jfbu/events{/privacy}","received_events_url":"https://api.github.com/users/jfbu/received_events","type":"User","site_admin":false},"body":"the py36 test on Travis complains about \"missing return statement\"","created_at":"2017-12-25T09:00:59Z","updated_at":"2017-12-25T09:01:37Z","html_url":"https://github.com/sphinx-doc/sphinx/pull/4343#discussion_r158631675","pull_request_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4343","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments/158631675"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/4343#discussion_r158631675"},"pull_request":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4343"}}},"pull_request":{"url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4343","id":160012327,"html_url":"https://github.com/sphinx-doc/sphinx/pull/4343","diff_url":"https://github.com/sphinx-doc/sphinx/pull/4343.diff","patch_url":"https://github.com/sphinx-doc/sphinx/pull/4343.patch","issue_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/4343","number":4343,"state":"open","locked":false,"title":"Add 'latexpdf' builder","user":{"login":"stephenfin","id":1690835,"avatar_url":"https://avatars2.githubusercontent.com/u/1690835?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenfin","html_url":"https://github.com/stephenfin","followers_url":"https://api.github.com/users/stephenfin/followers","following_url":"https://api.github.com/users/stephenfin/following{/other_user}","gists_url":"https://api.github.com/users/stephenfin/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenfin/subscriptions","organizations_url":"https://api.github.com/users/stephenfin/orgs","repos_url":"https://api.github.com/users/stephenfin/repos","events_url":"https://api.github.com/users/stephenfin/events{/privacy}","received_events_url":"https://api.github.com/users/stephenfin/received_events","type":"User","site_admin":false},"body":"Subject: Add `latexpdf` builder\r\n\r\n### Feature or Bugfix\r\n- Feature\r\n- Bugfix\r\n\r\n### Purpose\r\n- Add a `latexpdf` builder as a replacement for the equivalent target in make mode\r\n\r\n### Detail\r\n\r\n- make_mode: Convert to use 'pdflatex' builder\r\n    \r\n  This simplifies the file yet further.\r\n    \r\n- builders: Add LaTeXPDFBuilder\r\n    \r\n  This is a subclass of LaTeXBuilder that simply invokes the Makefile generated by same to build a PDF upon successful LaTeX generation. A future change may modify this to call the underlying commands natively instead of via `make`.\r\n","created_at":"2017-12-24T22:40:42Z","updated_at":"2017-12-25T09:01:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c53e1355ffef3b5e25f4ffcd4165191178ce6dbb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4343/commits","review_comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4343/comments","review_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/4343/comments","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/d4be532fa57e6c919adebddb7557375b6af3c9b9","head":{"label":"stephenfin:latexpdf-builder","ref":"latexpdf-builder","sha":"d4be532fa57e6c919adebddb7557375b6af3c9b9","user":{"login":"stephenfin","id":1690835,"avatar_url":"https://avatars2.githubusercontent.com/u/1690835?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenfin","html_url":"https://github.com/stephenfin","followers_url":"https://api.github.com/users/stephenfin/followers","following_url":"https://api.github.com/users/stephenfin/following{/other_user}","gists_url":"https://api.github.com/users/stephenfin/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenfin/subscriptions","organizations_url":"https://api.github.com/users/stephenfin/orgs","repos_url":"https://api.github.com/users/stephenfin/repos","events_url":"https://api.github.com/users/stephenfin/events{/privacy}","received_events_url":"https://api.github.com/users/stephenfin/received_events","type":"User","site_admin":false},"repo":{"id":83070347,"name":"sphinx","full_name":"stephenfin/sphinx","owner":{"login":"stephenfin","id":1690835,"avatar_url":"https://avatars2.githubusercontent.com/u/1690835?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenfin","html_url":"https://github.com/stephenfin","followers_url":"https://api.github.com/users/stephenfin/followers","following_url":"https://api.github.com/users/stephenfin/following{/other_user}","gists_url":"https://api.github.com/users/stephenfin/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenfin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenfin/subscriptions","organizations_url":"https://api.github.com/users/stephenfin/orgs","repos_url":"https://api.github.com/users/stephenfin/repos","events_url":"https://api.github.com/users/stephenfin/events{/privacy}","received_events_url":"https://api.github.com/users/stephenfin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/stephenfin/sphinx","description":"Main repository for the Sphinx documentation builder","fork":true,"url":"https://api.github.com/repos/stephenfin/sphinx","forks_url":"https://api.github.com/repos/stephenfin/sphinx/forks","keys_url":"https://api.github.com/repos/stephenfin/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stephenfin/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stephenfin/sphinx/teams","hooks_url":"https://api.github.com/repos/stephenfin/sphinx/hooks","issue_events_url":"https://api.github.com/repos/stephenfin/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/stephenfin/sphinx/events","assignees_url":"https://api.github.com/repos/stephenfin/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/stephenfin/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/stephenfin/sphinx/tags","blobs_url":"https://api.github.com/repos/stephenfin/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stephenfin/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stephenfin/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/stephenfin/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stephenfin/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/stephenfin/sphinx/languages","stargazers_url":"https://api.github.com/repos/stephenfin/sphinx/stargazers","contributors_url":"https://api.github.com/repos/stephenfin/sphinx/contributors","subscribers_url":"https://api.github.com/repos/stephenfin/sphinx/subscribers","subscription_url":"https://api.github.com/repos/stephenfin/sphinx/subscription","commits_url":"https://api.github.com/repos/stephenfin/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/stephenfin/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/stephenfin/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/stephenfin/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/stephenfin/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/stephenfin/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stephenfin/sphinx/merges","archive_url":"https://api.github.com/repos/stephenfin/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stephenfin/sphinx/downloads","issues_url":"https://api.github.com/repos/stephenfin/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/stephenfin/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/stephenfin/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/stephenfin/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stephenfin/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/stephenfin/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/stephenfin/sphinx/deployments","created_at":"2017-02-24T18:21:46Z","updated_at":"2017-02-24T18:21:49Z","pushed_at":"2017-12-24T22:58:45Z","git_url":"git://github.com/stephenfin/sphinx.git","ssh_url":"git@github.com:stephenfin/sphinx.git","clone_url":"https://github.com/stephenfin/sphinx.git","svn_url":"https://github.com/stephenfin/sphinx","homepage":"http://sphinx-doc.org","size":23122,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sphinx-doc:master","ref":"master","sha":"a9efb2517a0ccbd932f7e6be3e8984d78dc763b8","user":{"login":"sphinx-doc","id":9928167,"avatar_url":"https://avatars2.githubusercontent.com/u/9928167?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"repo":{"id":28710753,"name":"sphinx","full_name":"sphinx-doc/sphinx","owner":{"login":"sphinx-doc","id":9928167,"avatar_url":"https://avatars2.githubusercontent.com/u/9928167?v=4","gravatar_id":"","url":"https://api.github.com/users/sphinx-doc","html_url":"https://github.com/sphinx-doc","followers_url":"https://api.github.com/users/sphinx-doc/followers","following_url":"https://api.github.com/users/sphinx-doc/following{/other_user}","gists_url":"https://api.github.com/users/sphinx-doc/gists{/gist_id}","starred_url":"https://api.github.com/users/sphinx-doc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sphinx-doc/subscriptions","organizations_url":"https://api.github.com/users/sphinx-doc/orgs","repos_url":"https://api.github.com/users/sphinx-doc/repos","events_url":"https://api.github.com/users/sphinx-doc/events{/privacy}","received_events_url":"https://api.github.com/users/sphinx-doc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sphinx-doc/sphinx","description":"Main repository for the Sphinx documentation builder","fork":false,"url":"https://api.github.com/repos/sphinx-doc/sphinx","forks_url":"https://api.github.com/repos/sphinx-doc/sphinx/forks","keys_url":"https://api.github.com/repos/sphinx-doc/sphinx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sphinx-doc/sphinx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sphinx-doc/sphinx/teams","hooks_url":"https://api.github.com/repos/sphinx-doc/sphinx/hooks","issue_events_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/events{/number}","events_url":"https://api.github.com/repos/sphinx-doc/sphinx/events","assignees_url":"https://api.github.com/repos/sphinx-doc/sphinx/assignees{/user}","branches_url":"https://api.github.com/repos/sphinx-doc/sphinx/branches{/branch}","tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/tags","blobs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/refs{/sha}","trees_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/{sha}","languages_url":"https://api.github.com/repos/sphinx-doc/sphinx/languages","stargazers_url":"https://api.github.com/repos/sphinx-doc/sphinx/stargazers","contributors_url":"https://api.github.com/repos/sphinx-doc/sphinx/contributors","subscribers_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscribers","subscription_url":"https://api.github.com/repos/sphinx-doc/sphinx/subscription","commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/commits{/sha}","git_commits_url":"https://api.github.com/repos/sphinx-doc/sphinx/git/commits{/sha}","comments_url":"https://api.github.com/repos/sphinx-doc/sphinx/comments{/number}","issue_comment_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues/comments{/number}","contents_url":"https://api.github.com/repos/sphinx-doc/sphinx/contents/{+path}","compare_url":"https://api.github.com/repos/sphinx-doc/sphinx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sphinx-doc/sphinx/merges","archive_url":"https://api.github.com/repos/sphinx-doc/sphinx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sphinx-doc/sphinx/downloads","issues_url":"https://api.github.com/repos/sphinx-doc/sphinx/issues{/number}","pulls_url":"https://api.github.com/repos/sphinx-doc/sphinx/pulls{/number}","milestones_url":"https://api.github.com/repos/sphinx-doc/sphinx/milestones{/number}","notifications_url":"https://api.github.com/repos/sphinx-doc/sphinx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sphinx-doc/sphinx/labels{/name}","releases_url":"https://api.github.com/repos/sphinx-doc/sphinx/releases{/id}","deployments_url":"https://api.github.com/repos/sphinx-doc/sphinx/deployments","created_at":"2015-01-02T10:53:28Z","updated_at":"2017-12-25T04:50:09Z","pushed_at":"2017-12-25T04:31:32Z","git_url":"git://github.com/sphinx-doc/sphinx.git","ssh_url":"git@github.com:sphinx-doc/sphinx.git","clone_url":"https://github.com/sphinx-doc/sphinx.git","svn_url":"https://github.com/sphinx-doc/sphinx","homepage":"http://sphinx-doc.org","size":25208,"stargazers_count":1521,"watchers_count":1521,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":672,"mirror_url":null,"archived":false,"open_issues_count":724,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":672,"open_issues":724,"watchers":1521,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4343"},"html":{"href":"https://github.com/sphinx-doc/sphinx/pull/4343"},"issue":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/4343"},"comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/issues/4343/comments"},"review_comments":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4343/comments"},"review_comment":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/pulls/4343/commits"},"statuses":{"href":"https://api.github.com/repos/sphinx-doc/sphinx/statuses/d4be532fa57e6c919adebddb7557375b6af3c9b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jfbu"}}