{"push_id":1673578473,"size":4,"distinct_size":1,"ref":"refs/heads/openssl_ciphers_s","head":"2de41b5923f8fc6d6365124ed1ee1aeed068ea79","before":"506663873f42bd1ac8202811bff76aaf0a813fec","commits":[{"sha":"a1d4eac64db4a9d6776f3de9b39d2a64f8417b24","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Don't read tls_data.txt inside function\n\nI was doing some testing on my extended_tls_sockets branch and discovered that it was not fully working since the `TLS13_KEY_SHARES` array was empty. According to https://lists.gnu.org/archive/html/bug-bash/2012-06/msg00068.html, there is an issue when trying to initialize a global array inside a function. (The current code initializes `TLS12_CIPHER`, `TLS_CIPHER`, and `TLS13_KEY_SHARES` within `get_install_dir()`, since tls_data.txt is read in that function.) In fact, according to http://stackoverflow.com/questions/10806357/associative-arrays-are-local-by-default, in order to initialize a global variable in a function, one needs to provide the `-g` option, which was only added in Bash 4.2.\r\n\r\nThis PR seems to fix the problem by moving the reading of tls_data.txt to the main body of the code rather than reading it within the `get_install_dir()` function.","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/a1d4eac64db4a9d6776f3de9b39d2a64f8417b24"},{"sha":"3820e2c25c90bd925c43dc0405d7795b4dcbdffe","author":{"name":"Dirk Wetter","email":"df9a1bebbef55e31c4e4a0e37513ff4bffcc13e5@testssl.sh"},"message":"Merge pull request #705 from dcooper16/read_tls_data\n\nDon't read tls_data.txt inside function","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/3820e2c25c90bd925c43dc0405d7795b4dcbdffe"},{"sha":"ed2aa6698ddf0c37fe07ec404c3b1a7f2ce3c6fb","author":{"name":"Dirk","email":"df9a1bebbef55e31c4e4a0e37513ff4bffcc13e5@testssl.sh"},"message":"comments added for #705","distinct":false,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/ed2aa6698ddf0c37fe07ec404c3b1a7f2ce3c6fb"},{"sha":"2de41b5923f8fc6d6365124ed1ee1aeed068ea79","author":{"name":"David Cooper","email":"bd07968fe1548f762be87be0de640b4db395569f@gmail.com"},"message":"Merge branch '2.9dev' into openssl_ciphers_s","distinct":true,"url":"https://api.github.com/repos/dcooper16/testssl.sh/commits/2de41b5923f8fc6d6365124ed1ee1aeed068ea79"}]}
{"actor":{"display_login":"dcooper16"}}