{"action":"created","issue":{"url":"https://api.github.com/repos/pnp-software/cordetfw/issues/60","repository_url":"https://api.github.com/repos/pnp-software/cordetfw","labels_url":"https://api.github.com/repos/pnp-software/cordetfw/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/pnp-software/cordetfw/issues/60/comments","events_url":"https://api.github.com/repos/pnp-software/cordetfw/issues/60/events","html_url":"https://github.com/pnp-software/cordetfw/issues/60","id":245128846,"number":60,"title":"Outcome of Start Action of TC(17,4)","user":{"login":"pasetti","id":15838404,"avatar_url":"https://avatars2.githubusercontent.com/u/15838404?v=4","gravatar_id":"","url":"https://api.github.com/users/pasetti","html_url":"https://github.com/pasetti","followers_url":"https://api.github.com/users/pasetti/followers","following_url":"https://api.github.com/users/pasetti/following{/other_user}","gists_url":"https://api.github.com/users/pasetti/gists{/gist_id}","starred_url":"https://api.github.com/users/pasetti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pasetti/subscriptions","organizations_url":"https://api.github.com/users/pasetti/orgs","repos_url":"https://api.github.com/users/pasetti/repos","events_url":"https://api.github.com/users/pasetti/events{/privacy}","received_events_url":"https://api.github.com/users/pasetti/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"reimers","id":28513899,"avatar_url":"https://avatars0.githubusercontent.com/u/28513899?v=4","gravatar_id":"","url":"https://api.github.com/users/reimers","html_url":"https://github.com/reimers","followers_url":"https://api.github.com/users/reimers/followers","following_url":"https://api.github.com/users/reimers/following{/other_user}","gists_url":"https://api.github.com/users/reimers/gists{/gist_id}","starred_url":"https://api.github.com/users/reimers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reimers/subscriptions","organizations_url":"https://api.github.com/users/reimers/orgs","repos_url":"https://api.github.com/users/reimers/repos","events_url":"https://api.github.com/users/reimers/events{/privacy}","received_events_url":"https://api.github.com/users/reimers/received_events","type":"User","site_admin":false},"assignees":[{"login":"reimers","id":28513899,"avatar_url":"https://avatars0.githubusercontent.com/u/28513899?v=4","gravatar_id":"","url":"https://api.github.com/users/reimers","html_url":"https://github.com/reimers","followers_url":"https://api.github.com/users/reimers/followers","following_url":"https://api.github.com/users/reimers/following{/other_user}","gists_url":"https://api.github.com/users/reimers/gists{/gist_id}","starred_url":"https://api.github.com/users/reimers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reimers/subscriptions","organizations_url":"https://api.github.com/users/reimers/orgs","repos_url":"https://api.github.com/users/reimers/repos","events_url":"https://api.github.com/users/reimers/events{/privacy}","received_events_url":"https://api.github.com/users/reimers/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-07-24T16:02:03Z","updated_at":"2017-07-25T15:25:02Z","closed_at":null,"body":"I have looked at file CrPsCmd17s3StartFunc.c holding the implementation of the actions and guards of the Start Action of TC(17,4). Nodes N7 and N8 must report the outcome of the Start Action. At present, this is done using a global variable `outcomeStart` which, I believe, is defined in CrPsTestOnBoardConnection.c.\r\n\r\nI believe that we should avoid using this kind of global variables because this usage is normally precluded by coding standard for critical software.\r\n\r\nOne alternative option could be to use the data field of the procedure descriptor. In fact, this is a common situation (we have many procedures which must return an outcome), you might consider the same approach as used in the CORDET Framework where all components (either state machines or procedures) carry an instance of the same data structure of type `CrFwCmpData` and this data structure include a generic 'outcome' field."},"comment":{"url":"https://api.github.com/repos/pnp-software/cordetfw/issues/comments/317774476","html_url":"https://github.com/pnp-software/cordetfw/issues/60#issuecomment-317774476","issue_url":"https://api.github.com/repos/pnp-software/cordetfw/issues/60","id":317774476,"user":{"login":"Rockenbauer","id":30296161,"avatar_url":"https://avatars0.githubusercontent.com/u/30296161?v=4","gravatar_id":"","url":"https://api.github.com/users/Rockenbauer","html_url":"https://github.com/Rockenbauer","followers_url":"https://api.github.com/users/Rockenbauer/followers","following_url":"https://api.github.com/users/Rockenbauer/following{/other_user}","gists_url":"https://api.github.com/users/Rockenbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/Rockenbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rockenbauer/subscriptions","organizations_url":"https://api.github.com/users/Rockenbauer/orgs","repos_url":"https://api.github.com/users/Rockenbauer/repos","events_url":"https://api.github.com/users/Rockenbauer/events{/privacy}","received_events_url":"https://api.github.com/users/Rockenbauer/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T15:25:02Z","updated_at":"2017-07-25T15:25:02Z","body":"We will implement the outcome handover using the data field of the procedure descriptor."}}
{"actor":{"display_login":"Rockenbauer"}}