{"action":"closed","number":111,"pull_request":{"url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls/111","id":122769120,"html_url":"https://github.com/mrbelowski/CrewChiefV4/pull/111","diff_url":"https://github.com/mrbelowski/CrewChiefV4/pull/111.diff","patch_url":"https://github.com/mrbelowski/CrewChiefV4/pull/111.patch","issue_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues/111","number":111,"state":"closed","locked":false,"title":"Time span wrapper replacement","user":{"login":"mrbelowski","id":840170,"avatar_url":"https://avatars0.githubusercontent.com/u/840170?v=3","gravatar_id":"","url":"https://api.github.com/users/mrbelowski","html_url":"https://github.com/mrbelowski","followers_url":"https://api.github.com/users/mrbelowski/followers","following_url":"https://api.github.com/users/mrbelowski/following{/other_user}","gists_url":"https://api.github.com/users/mrbelowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbelowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbelowski/subscriptions","organizations_url":"https://api.github.com/users/mrbelowski/orgs","repos_url":"https://api.github.com/users/mrbelowski/repos","events_url":"https://api.github.com/users/mrbelowski/events{/privacy}","received_events_url":"https://api.github.com/users/mrbelowski/received_events","type":"User","site_admin":false},"body":"This is a bit invasive and a bit messy.\r\n\r\nI've changed the internal wiring a bit so instead of passing a TimeSpan to the message queue you can pass a TimeSpanWrapper which has a Precision enum. This is pretty simple. It gets a bit messy because 2 enums are automatic - auto_laptime and auto_gap. These allow the app to make a sensible choice as to what precision to use. For auto_gaps > 10 seconds, use whole seconds, for gaps < 0.2 use hundredths, otherwise tenths. With a similar rule for auto_laptime.\r\n\r\nThe rest of the change is to allow this precision stuff (and eventually other stuff) to access the track data because the trackLandmarks data now has an isOval flag (at the same level in the JSON as the track name / ID lists). If the track isOval, the auto_xxx precision stuff will always select hundredths.\r\n\r\nTo achieve this I've had to make the current trackDef accessible globally as a public static member of the CrewChief class. I know this is \"bad practice\", but to save you guys some typing, I also don't care that it's \"bad practice\" :)","created_at":"2017-05-27T17:49:17Z","updated_at":"2017-06-12T17:22:16Z","closed_at":"2017-06-12T17:22:16Z","merged_at":"2017-06-12T17:22:16Z","merge_commit_sha":"3239b3756bea84049a59a552e25bfe76651f8ae8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls/111/commits","review_comments_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls/111/comments","review_comment_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues/111/comments","statuses_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/statuses/ef8f80930a96784c092baf620f4c05ad34090b5e","head":{"label":"mrbelowski:TimeSpanWrapperReplacement","ref":"TimeSpanWrapperReplacement","sha":"ef8f80930a96784c092baf620f4c05ad34090b5e","user":{"login":"mrbelowski","id":840170,"avatar_url":"https://avatars0.githubusercontent.com/u/840170?v=3","gravatar_id":"","url":"https://api.github.com/users/mrbelowski","html_url":"https://github.com/mrbelowski","followers_url":"https://api.github.com/users/mrbelowski/followers","following_url":"https://api.github.com/users/mrbelowski/following{/other_user}","gists_url":"https://api.github.com/users/mrbelowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbelowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbelowski/subscriptions","organizations_url":"https://api.github.com/users/mrbelowski/orgs","repos_url":"https://api.github.com/users/mrbelowski/repos","events_url":"https://api.github.com/users/mrbelowski/events{/privacy}","received_events_url":"https://api.github.com/users/mrbelowski/received_events","type":"User","site_admin":false},"repo":{"id":48137227,"name":"CrewChiefV4","full_name":"mrbelowski/CrewChiefV4","owner":{"login":"mrbelowski","id":840170,"avatar_url":"https://avatars0.githubusercontent.com/u/840170?v=3","gravatar_id":"","url":"https://api.github.com/users/mrbelowski","html_url":"https://github.com/mrbelowski","followers_url":"https://api.github.com/users/mrbelowski/followers","following_url":"https://api.github.com/users/mrbelowski/following{/other_user}","gists_url":"https://api.github.com/users/mrbelowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbelowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbelowski/subscriptions","organizations_url":"https://api.github.com/users/mrbelowski/orgs","repos_url":"https://api.github.com/users/mrbelowski/repos","events_url":"https://api.github.com/users/mrbelowski/events{/privacy}","received_events_url":"https://api.github.com/users/mrbelowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrbelowski/CrewChiefV4","description":null,"fork":false,"url":"https://api.github.com/repos/mrbelowski/CrewChiefV4","forks_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/forks","keys_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/teams","hooks_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/hooks","issue_events_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues/events{/number}","events_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/events","assignees_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/assignees{/user}","branches_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/branches{/branch}","tags_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/tags","blobs_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/statuses/{sha}","languages_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/languages","stargazers_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/stargazers","contributors_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/contributors","subscribers_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/subscribers","subscription_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/subscription","commits_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/contents/{+path}","compare_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/merges","archive_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/downloads","issues_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues{/number}","pulls_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls{/number}","milestones_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/milestones{/number}","notifications_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/labels{/name}","releases_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/releases{/id}","deployments_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/deployments","created_at":"2015-12-16T21:51:18Z","updated_at":"2017-05-27T17:02:47Z","pushed_at":"2017-06-12T17:22:16Z","git_url":"git://github.com/mrbelowski/CrewChiefV4.git","ssh_url":"git@github.com:mrbelowski/CrewChiefV4.git","clone_url":"https://github.com/mrbelowski/CrewChiefV4.git","svn_url":"https://github.com/mrbelowski/CrewChiefV4","homepage":null,"size":413193,"stargazers_count":16,"watchers_count":16,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":16,"default_branch":"master"}},"base":{"label":"mrbelowski:master","ref":"master","sha":"60b2a7f7f8f3cb05ad1c5ec78c4d4f997e1f2fb6","user":{"login":"mrbelowski","id":840170,"avatar_url":"https://avatars0.githubusercontent.com/u/840170?v=3","gravatar_id":"","url":"https://api.github.com/users/mrbelowski","html_url":"https://github.com/mrbelowski","followers_url":"https://api.github.com/users/mrbelowski/followers","following_url":"https://api.github.com/users/mrbelowski/following{/other_user}","gists_url":"https://api.github.com/users/mrbelowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbelowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbelowski/subscriptions","organizations_url":"https://api.github.com/users/mrbelowski/orgs","repos_url":"https://api.github.com/users/mrbelowski/repos","events_url":"https://api.github.com/users/mrbelowski/events{/privacy}","received_events_url":"https://api.github.com/users/mrbelowski/received_events","type":"User","site_admin":false},"repo":{"id":48137227,"name":"CrewChiefV4","full_name":"mrbelowski/CrewChiefV4","owner":{"login":"mrbelowski","id":840170,"avatar_url":"https://avatars0.githubusercontent.com/u/840170?v=3","gravatar_id":"","url":"https://api.github.com/users/mrbelowski","html_url":"https://github.com/mrbelowski","followers_url":"https://api.github.com/users/mrbelowski/followers","following_url":"https://api.github.com/users/mrbelowski/following{/other_user}","gists_url":"https://api.github.com/users/mrbelowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbelowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbelowski/subscriptions","organizations_url":"https://api.github.com/users/mrbelowski/orgs","repos_url":"https://api.github.com/users/mrbelowski/repos","events_url":"https://api.github.com/users/mrbelowski/events{/privacy}","received_events_url":"https://api.github.com/users/mrbelowski/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrbelowski/CrewChiefV4","description":null,"fork":false,"url":"https://api.github.com/repos/mrbelowski/CrewChiefV4","forks_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/forks","keys_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/teams","hooks_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/hooks","issue_events_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues/events{/number}","events_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/events","assignees_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/assignees{/user}","branches_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/branches{/branch}","tags_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/tags","blobs_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/statuses/{sha}","languages_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/languages","stargazers_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/stargazers","contributors_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/contributors","subscribers_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/subscribers","subscription_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/subscription","commits_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/contents/{+path}","compare_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/merges","archive_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/downloads","issues_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues{/number}","pulls_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls{/number}","milestones_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/milestones{/number}","notifications_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/labels{/name}","releases_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/releases{/id}","deployments_url":"https://api.github.com/repos/mrbelowski/CrewChiefV4/deployments","created_at":"2015-12-16T21:51:18Z","updated_at":"2017-05-27T17:02:47Z","pushed_at":"2017-06-12T17:22:16Z","git_url":"git://github.com/mrbelowski/CrewChiefV4.git","ssh_url":"git@github.com:mrbelowski/CrewChiefV4.git","clone_url":"https://github.com/mrbelowski/CrewChiefV4.git","svn_url":"https://github.com/mrbelowski/CrewChiefV4","homepage":null,"size":413193,"stargazers_count":16,"watchers_count":16,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":5,"forks":5,"open_issues":5,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls/111"},"html":{"href":"https://github.com/mrbelowski/CrewChiefV4/pull/111"},"issue":{"href":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues/111"},"comments":{"href":"https://api.github.com/repos/mrbelowski/CrewChiefV4/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrbelowski/CrewChiefV4/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/mrbelowski/CrewChiefV4/statuses/ef8f80930a96784c092baf620f4c05ad34090b5e"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mrbelowski","id":840170,"avatar_url":"https://avatars0.githubusercontent.com/u/840170?v=3","gravatar_id":"","url":"https://api.github.com/users/mrbelowski","html_url":"https://github.com/mrbelowski","followers_url":"https://api.github.com/users/mrbelowski/followers","following_url":"https://api.github.com/users/mrbelowski/following{/other_user}","gists_url":"https://api.github.com/users/mrbelowski/gists{/gist_id}","starred_url":"https://api.github.com/users/mrbelowski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrbelowski/subscriptions","organizations_url":"https://api.github.com/users/mrbelowski/orgs","repos_url":"https://api.github.com/users/mrbelowski/repos","events_url":"https://api.github.com/users/mrbelowski/events{/privacy}","received_events_url":"https://api.github.com/users/mrbelowski/received_events","type":"User","site_admin":false},"comments":7,"review_comments":0,"maintainer_can_modify":false,"commits":35,"additions":1514,"deletions":975,"changed_files":326}}
{"actor":{"display_login":"mrbelowski"}}