{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/send/issues/587","repository_url":"https://api.github.com/repos/mozilla/send","labels_url":"https://api.github.com/repos/mozilla/send/issues/587/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/send/issues/587/comments","events_url":"https://api.github.com/repos/mozilla/send/issues/587/events","html_url":"https://github.com/mozilla/send/issues/587","id":264684015,"number":587,"title":"Remaining password UI bits","user":{"login":"dannycoates","id":87619,"avatar_url":"https://avatars1.githubusercontent.com/u/87619?v=4","gravatar_id":"","url":"https://api.github.com/users/dannycoates","html_url":"https://github.com/dannycoates","followers_url":"https://api.github.com/users/dannycoates/followers","following_url":"https://api.github.com/users/dannycoates/following{/other_user}","gists_url":"https://api.github.com/users/dannycoates/gists{/gist_id}","starred_url":"https://api.github.com/users/dannycoates/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannycoates/subscriptions","organizations_url":"https://api.github.com/users/dannycoates/orgs","repos_url":"https://api.github.com/users/dannycoates/repos","events_url":"https://api.github.com/users/dannycoates/events{/privacy}","received_events_url":"https://api.github.com/users/dannycoates/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-11T18:12:17Z","updated_at":"2017-10-13T12:52:45Z","closed_at":null,"author_association":"MEMBER","body":"There's a few remaining things from the design spec that aren't done and some areas where I intentionally didn't follow the spec that should be reviewed. https://mozilla.invisionapp.com/share/CTDDQDXME#/screens/252367497\r\n\r\n### Differences\r\n- The 'add password' input box is plain text so the dots for the placeholder seemed to imply the text would be hidden or was already set to something. I changed it to 'Password'.\r\n- I changed the label of the button from 'Submit' to 'Unlock'\r\n- I took a few liberties with the strings\r\n\r\n### Incomplete\r\n- [ ] responsive password input boxes\r\n- [ ] styled checkbox\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/mozilla/send/issues/comments/336444007","html_url":"https://github.com/mozilla/send/issues/587#issuecomment-336444007","issue_url":"https://api.github.com/repos/mozilla/send/issues/587","id":336444007,"user":{"login":"Softvision-CristinaBadescu","id":31244235,"avatar_url":"https://avatars0.githubusercontent.com/u/31244235?v=4","gravatar_id":"","url":"https://api.github.com/users/Softvision-CristinaBadescu","html_url":"https://github.com/Softvision-CristinaBadescu","followers_url":"https://api.github.com/users/Softvision-CristinaBadescu/followers","following_url":"https://api.github.com/users/Softvision-CristinaBadescu/following{/other_user}","gists_url":"https://api.github.com/users/Softvision-CristinaBadescu/gists{/gist_id}","starred_url":"https://api.github.com/users/Softvision-CristinaBadescu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Softvision-CristinaBadescu/subscriptions","organizations_url":"https://api.github.com/users/Softvision-CristinaBadescu/orgs","repos_url":"https://api.github.com/users/Softvision-CristinaBadescu/repos","events_url":"https://api.github.com/users/Softvision-CristinaBadescu/events{/privacy}","received_events_url":"https://api.github.com/users/Softvision-CristinaBadescu/received_events","type":"User","site_admin":false},"created_at":"2017-10-13T12:52:45Z","updated_at":"2017-10-13T12:52:45Z","author_association":"NONE","body":"Hello,\r\n\r\nI've went through the mock-ups in order to write test cases for password functionality and I've observed certain differences between the mock-ups and the experiment on dev server. For example:\r\n- The \"edit password\" mode doesn't exists at the moment.\r\n- When user checks box, the link field is not disabled.\r\n- The title is different from the mock-ups: \"The link to your file will expire after 1 download or in 24 hours.\" instead of \"This encrypted link will expire after 1 download or in 24 hours\".\r\n- When typing a wrong password, the text has another punctuation: \"Try again?\" instead of \"Try again:\".\r\n\r\nI strongly recommend using a hidden password instead of a plain text. Also, the user should have a \"show/hide\" option for the password when typing it; in this way some security issues can be avoided.\r\n \r\nAre we going to implement these on the next release? If yes, I can log them so it will be easier to track."}}
{"actor":{"display_login":"Softvision-CristinaBadescu"}}