{"action":"created","issue":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/812","repository_url":"https://api.github.com/repos/AutoFixture/AutoFixture","labels_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/812/labels{/name}","comments_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/812/comments","events_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/812/events","html_url":"https://github.com/AutoFixture/AutoFixture/pull/812","id":252853282,"number":812,"title":"Migrate AutoFakeItEasy to .NET Core","user":{"login":"zvirja","id":1074182,"avatar_url":"https://avatars1.githubusercontent.com/u/1074182?v=4","gravatar_id":"","url":"https://api.github.com/users/zvirja","html_url":"https://github.com/zvirja","followers_url":"https://api.github.com/users/zvirja/followers","following_url":"https://api.github.com/users/zvirja/following{/other_user}","gists_url":"https://api.github.com/users/zvirja/gists{/gist_id}","starred_url":"https://api.github.com/users/zvirja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvirja/subscriptions","organizations_url":"https://api.github.com/users/zvirja/orgs","repos_url":"https://api.github.com/users/zvirja/repos","events_url":"https://api.github.com/users/zvirja/events{/privacy}","received_events_url":"https://api.github.com/users/zvirja/received_events","type":"User","site_admin":false},"labels":[{"id":5910877,"url":"https://api.github.com/repos/AutoFixture/AutoFixture/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/milestones/3","html_url":"https://github.com/AutoFixture/AutoFixture/milestone/3","labels_url":"https://api.github.com/repos/AutoFixture/AutoFixture/milestones/3/labels","id":399179,"number":3,"title":"4.0","description":"AutoFixture 4.0.\r\n\r\nSince AutoFixture uses Semantic Versioning, all breaking changes should be assigned to this milestone.","creator":{"login":"ploeh","id":242165,"avatar_url":"https://avatars2.githubusercontent.com/u/242165?v=4","gravatar_id":"","url":"https://api.github.com/users/ploeh","html_url":"https://github.com/ploeh","followers_url":"https://api.github.com/users/ploeh/followers","following_url":"https://api.github.com/users/ploeh/following{/other_user}","gists_url":"https://api.github.com/users/ploeh/gists{/gist_id}","starred_url":"https://api.github.com/users/ploeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ploeh/subscriptions","organizations_url":"https://api.github.com/users/ploeh/orgs","repos_url":"https://api.github.com/users/ploeh/repos","events_url":"https://api.github.com/users/ploeh/events{/privacy}","received_events_url":"https://api.github.com/users/ploeh/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":19,"state":"open","created_at":"2013-08-11T13:21:38Z","updated_at":"2017-08-25T10:00:13Z","due_on":null,"closed_at":null},"comments":3,"created_at":"2017-08-25T10:00:13Z","updated_at":"2017-08-26T21:54:42Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/pulls/812","html_url":"https://github.com/AutoFixture/AutoFixture/pull/812","diff_url":"https://github.com/AutoFixture/AutoFixture/pull/812.diff","patch_url":"https://github.com/AutoFixture/AutoFixture/pull/812.patch"},"body":"Added support for .NET Core and AutoFakeItEasy. We have different dependencies depending on target:\r\n- `1.7.4109.1` for .NET Framework 4.5\r\n- `3.0.0` for .NET Standard 1.6\r\n\r\nIn our glue library I target .NET Standard 1.6 (instead of 1.5 we use everywhere else) as that's required by FakeItEasy.\r\n\r\nAdditionally I've added one more test project for AutoFakeItEasy to assert its support for FakeItEasy3. The reason is that previous versions (1 and 2) don't support .NET Core, so I needed at least one project where I can run tests under .NET Core runtime.\r\n\r\n@adamchester @moodmosaic Your review is expected! 😉\r\n@blairconrad If you have free time, it would be great if you look through and confirm everything looks fine to you ☺️"},"comment":{"url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/comments/325164031","html_url":"https://github.com/AutoFixture/AutoFixture/pull/812#issuecomment-325164031","issue_url":"https://api.github.com/repos/AutoFixture/AutoFixture/issues/812","id":325164031,"user":{"login":"zvirja","id":1074182,"avatar_url":"https://avatars1.githubusercontent.com/u/1074182?v=4","gravatar_id":"","url":"https://api.github.com/users/zvirja","html_url":"https://github.com/zvirja","followers_url":"https://api.github.com/users/zvirja/followers","following_url":"https://api.github.com/users/zvirja/following{/other_user}","gists_url":"https://api.github.com/users/zvirja/gists{/gist_id}","starred_url":"https://api.github.com/users/zvirja/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zvirja/subscriptions","organizations_url":"https://api.github.com/users/zvirja/orgs","repos_url":"https://api.github.com/users/zvirja/repos","events_url":"https://api.github.com/users/zvirja/events{/privacy}","received_events_url":"https://api.github.com/users/zvirja/received_events","type":"User","site_admin":false},"created_at":"2017-08-26T21:54:42Z","updated_at":"2017-08-26T21:54:42Z","body":"@blairconrad Thanks for reviewing that and confirming that everything is fine!\r\n\r\n> I had a similar question recently in one of my own projects: how to balance the need to maintain support for older versions and newer versions against the testing effort. \r\n\r\nActually, I haven't thought about that yet 😅 At the moment it doesn't look too scary as we have 3 test projects only. That isn't hard to maintain them as they consist of [single file only](https://github.com/AutoFixture/AutoFixture/blob/183b18df8c2beb1ce6f44625f1aee0fe8f85c193/Src/AutoFakeItEasy.FakeItEasy3UnitTest/AutoFakeItEasy.FakeItEasy3UnitTest.csproj). However, when we get more versions (e.g. enable FakeItEasy v4 support), we'll need one more..\r\n\r\nPersonally, I'd prefer to have tests for all the versions we support - who knows what will be changed in future.. That might be something that is broken in an intermediate version we support, but doesn't cover with tests 😕\r\n\r\nIf we end up having too much test projects, we could always create a sub-folder for them and move them\r\n all to dump as they are in fact empty 😄 However, that decision should be made later.\r\n\r\nIn any case thank you for raising this question.\r\n\r\n@moodmosaic @adamchester Would be interesting to know your opinion about the concerns Blair raised 😉"}}
{"actor":{"display_login":"zvirja"}}