{"push_id":1586534591,"size":55,"distinct_size":46,"ref":"refs/heads/manipulation","head":"91233a4d32f54202f17cc113fec14ebd02cacb64","before":"b31e5c7eb4fe644438ba5e6bd840aa8b43a6c6b0","commits":[{"sha":"d0dca7a92a363e8434069ed1e406d6866c6da705","author":{"name":"Daniel Dresser","email":"dd49e9f926c9714b0281368a1909b3ebc92aa882@gmail.com"},"message":"StandardLightVisualiser : Fixed colorIndicator failing for floating point values that lined up exactly wrong","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/d0dca7a92a363e8434069ed1e406d6866c6da705"},{"sha":"98689fb44731a71b5a4f8c7bf70c4c04dc679bfa","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Arnold renderer : Fix indentation","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/98689fb44731a71b5a4f8c7bf70c4c04dc679bfa"},{"sha":"7fd5fe9be0ff308a24b8637fc8d91e01aff0f282","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Arnold renderer : Fix occasional long hangs in `pause()`\n\nThe following appears to have been the problematic sequence :\n\n1. Main thread calls `render()`.\n2. Background thread starts up, but doesn't get as far as calling `AiRender()`.\n3. Main thread calls `pause()`.\n4. Main thread finds `AiRendering() == false` and skips straight to `thread.join()`.\n5. Background thread calls `AiRender()` and doesn't return until every refinement level is renderered, effectively hanging the IPR.\n\nThis problem could also occur in between refinement levels, where for a short while `AiRendering()` is again not true. We work around this issue by storing our own flag to say if we're rendering or not, and using it as an additional abort flag in the background thread.","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/7fd5fe9be0ff308a24b8637fc8d91e01aff0f282"},{"sha":"cec46a7cbd5a452fd23697180687594b6e3ff34d","author":{"name":"John Haddon","email":"febb44f0a3536761749f6c82b901d79bfa74cce8@image-engine.com"},"message":"Merge pull request #1982 from danieldresser/fixColorIndicator\n\nStandardLightVisualiser : Fixed colorIndicator failing in corner cases","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/cec46a7cbd5a452fd23697180687594b6e3ff34d"},{"sha":"13900dfc159e048542aa01a187163edd725e79ba","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"SceneReaderPathPreview : Work around browser app shutdown issues.\n\nWe were getting messages like the following where our Widgets were receiving signals but had already had their Qt part destroyed :\n\n```\nTraceback (most recent call last):\n  File \"/disk1/john/dev/build/gaffer/python/Gaffer/WeakMethod.py\", line 67, in __call__\n    return m( *args, **kwArgs )\n  File \"/disk1/john/dev/build/gaffer/python/GafferUI/PlugLayout.py\", line 502, in __plugDirtied\n    if not self.visible() or plug.direction() != plug.Direction.In :\n  File \"/disk1/john/dev/build/gaffer/python/GafferUI/Widget.py\", line 252, in visible\n    return self.__qtWidget.isVisibleTo( relativeTo )\nRuntimeError: Internal C++ object (PySide.QtGui.QWidget) already deleted.\n```\n\nThese appear to have been coming from the toolbar UIs in the Viewer within the SceneReaderPathPreview as the script node was being destroyed. Deferring the viewing of the scene, and only viewing valid scenes seems to fix the issue, although it's unclear why. The behaviour of the SceneReaderPathPreview is at least much closer to the behaviour of the main GUI app now, so there is some cause for hope that this will be robust.\n\nI searched in vain for a more satisfactory understanding of what was going on here, but I think it might simply be the case that we really don't have enough control over the order of destruction of python objects at shutdown.","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/13900dfc159e048542aa01a187163edd725e79ba"},{"sha":"5d237ed61751b43cc7f9c916249b4a8ece1fb115","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"WeakMethod : Include class name in ReferenceError exceptions.","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/5d237ed61751b43cc7f9c916249b4a8ece1fb115"},{"sha":"f359962bdbdcf185a0c80440b724deb819e6f456","author":{"name":"Andrew Kaufman","email":"ec979013f75148976dab5141b25077cde0e96c6b@gmail.com"},"message":"Merge pull request #1981 from johnhaddon/browserFixes\n\nSceneReaderPathPreview : Work around browser app shutdown issues.","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/f359962bdbdcf185a0c80440b724deb819e6f456"},{"sha":"7c714565bb0512b63b0d592fc73f585bbcfe76cd","author":{"name":"Andrew Kaufman","email":"ec979013f75148976dab5141b25077cde0e96c6b@gmail.com"},"message":"Merge pull request #1983 from johnhaddon/arnoldRaceCondition\n\nArnold renderer : Fix occasional long hangs in `pause()`","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/7c714565bb0512b63b0d592fc73f585bbcfe76cd"},{"sha":"ad7d6b2e3a3406e5db698926577acf7d87cbe3a2","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Update Changes","distinct":false,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/ad7d6b2e3a3406e5db698926577acf7d87cbe3a2"},{"sha":"109310a4525121cf95f645d13ba8d568b8110bf6","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"GLWidget : Support multiple overlays.\n\nIncompatibility :\n\n- Replaced setOverlay/getOverlay with addOverlay/removeOverlay.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/109310a4525121cf95f645d13ba8d568b8110bf6"},{"sha":"43f5d169deaf902ccbe3ebe98bed5f6bf86bc92e","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"GLWidget : Fix overlay drawing problems.\n\nWe weren't restoring the GL state properly, which resulted in overlays disappearing. The partial restore of `glPixelStorei()` settings that we were performing before is now done by the `glPopClientAttrib()`.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/43f5d169deaf902ccbe3ebe98bed5f6bf86bc92e"},{"sha":"d5527bfdb90c2f74fd80610cf6f71d922f551a67","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"GafferUI : Add WidgetAlgo.joinEdges()","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/d5527bfdb90c2f74fd80610cf6f71d922f551a67"},{"sha":"de8177e2e2f773475df3e64277dcfa09753c29f3","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Viewer : Support tool toolbars.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/de8177e2e2f773475df3e64277dcfa09753c29f3"},{"sha":"3fd7622ab5091b6dc5db230154f1d2189ad181f1","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Viewer : Add support for tool shortcuts.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/3fd7622ab5091b6dc5db230154f1d2189ad181f1"},{"sha":"144c9b2e4b4bb49b55f2371266862ecbcafe0713","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"BoolWidget : Add image and \"Tool\" display mode.\n\nThis makes the BoolWidget suitable for use as a tool selector.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/144c9b2e4b4bb49b55f2371266862ecbcafe0713"},{"sha":"a6fa6e92127e5458327cd08a63fc7bec7baffaf1","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Viewer : Add sidebar showing all available tools.\n\nThis makes them more discoverable than the old dropdown menu.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/a6fa6e92127e5458327cd08a63fc7bec7baffaf1"},{"sha":"3c09a4b85573a415bdfcff1baba27c7000ae00e7","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"SelectionToolUI : Add shortcut.\n\nAlso use `Metadata.registerNode()` to register all metadata in a single go.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/3c09a4b85573a415bdfcff1baba27c7000ae00e7"},{"sha":"aafd4119a59bb1915d3e94660d7bc0d46df78d24","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"SelectionTool : Allow subclassing.\n\nThis enables the creation of other tools with selection behaviours and other behaviours layered on top.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/aafd4119a59bb1915d3e94660d7bc0d46df78d24"},{"sha":"81561466095e8d956ea1863d31d858d1d13b28c5","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Handle : Make selection easier.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/81561466095e8d956ea1863d31d858d1d13b28c5"},{"sha":"e481a64a21435c40f5069d1a8efcf56f333e2950","author":{"name":"John Haddon","email":"8e632b0b91d9944dcbaafa6f76528b4f7cd7c6a2@gmail.com"},"message":"Handle : Add setRasterScale/getRasterScale accessors.\n\nThese allow handles to be drawn at a constant size in raster space, regardless of their position relative to the camera.","distinct":true,"url":"https://api.github.com/repos/johnhaddon/gaffer/commits/e481a64a21435c40f5069d1a8efcf56f333e2950"}]}
{"actor":{"display_login":"johnhaddon"}}