{"action":"created","comment":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/comments/130702708","pull_request_review_id":53594883,"id":130702708,"diff_hunk":"@@ -16,14 +16,27 @@\n \n package co.cask.cdap.internal.app.runtime.schedule.trigger;\n \n+import co.cask.cdap.internal.app.runtime.ProgramOptionConstants;\n import co.cask.cdap.internal.app.runtime.schedule.store.Schedulers;\n+import co.cask.cdap.internal.schedule.trigger.ScheduleTrigger;\n import co.cask.cdap.internal.schedule.trigger.Trigger;\n+import co.cask.cdap.proto.Notification;\n import co.cask.cdap.proto.ProtoTrigger;\n+import com.google.common.collect.ImmutableList;\n+import com.google.gson.Gson;\n+import com.google.gson.reflect.TypeToken;\n+\n+import java.util.List;\n+import java.util.Map;\n \n /**\n  * A Trigger that schedules a ProgramSchedule, based upon a particular cron expression.\n  */\n-public class TimeTrigger extends ProtoTrigger.TimeTrigger implements Trigger {\n+public class TimeTrigger extends ProtoTrigger.TimeTrigger implements Trigger, SatisfiableTrigger {","path":"cdap-app-fabric/src/main/java/co/cask/cdap/internal/app/runtime/schedule/trigger/TimeTrigger.java","position":21,"original_position":21,"commit_id":"40f59ca5373e4e8a20fe55b424fcecbbf89906f6","original_commit_id":"40f59ca5373e4e8a20fe55b424fcecbbf89906f6","user":{"login":"sameetandpotatoes","id":3608224,"avatar_url":"https://avatars2.githubusercontent.com/u/3608224?v=4","gravatar_id":"","url":"https://api.github.com/users/sameetandpotatoes","html_url":"https://github.com/sameetandpotatoes","followers_url":"https://api.github.com/users/sameetandpotatoes/followers","following_url":"https://api.github.com/users/sameetandpotatoes/following{/other_user}","gists_url":"https://api.github.com/users/sameetandpotatoes/gists{/gist_id}","starred_url":"https://api.github.com/users/sameetandpotatoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameetandpotatoes/subscriptions","organizations_url":"https://api.github.com/users/sameetandpotatoes/orgs","repos_url":"https://api.github.com/users/sameetandpotatoes/repos","events_url":"https://api.github.com/users/sameetandpotatoes/events{/privacy}","received_events_url":"https://api.github.com/users/sameetandpotatoes/received_events","type":"User","site_admin":false},"body":"Same comments as the other Trigger above","created_at":"2017-08-01T19:20:13Z","updated_at":"2017-08-01T19:46:16Z","html_url":"https://github.com/caskdata/cdap/pull/9315#discussion_r130702708","pull_request_url":"https://api.github.com/repos/caskdata/cdap/pulls/9315","_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments/130702708"},"html":{"href":"https://github.com/caskdata/cdap/pull/9315#discussion_r130702708"},"pull_request":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/9315"}}},"pull_request":{"url":"https://api.github.com/repos/caskdata/cdap/pulls/9315","id":133320766,"html_url":"https://github.com/caskdata/cdap/pull/9315","diff_url":"https://github.com/caskdata/cdap/pull/9315.diff","patch_url":"https://github.com/caskdata/cdap/pull/9315.patch","issue_url":"https://api.github.com/repos/caskdata/cdap/issues/9315","number":9315,"state":"open","locked":false,"title":"[CDAP-12232] Add composite trigger for scheduling","user":{"login":"maochf","id":5809268,"avatar_url":"https://avatars3.githubusercontent.com/u/5809268?v=4","gravatar_id":"","url":"https://api.github.com/users/maochf","html_url":"https://github.com/maochf","followers_url":"https://api.github.com/users/maochf/followers","following_url":"https://api.github.com/users/maochf/following{/other_user}","gists_url":"https://api.github.com/users/maochf/gists{/gist_id}","starred_url":"https://api.github.com/users/maochf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maochf/subscriptions","organizations_url":"https://api.github.com/users/maochf/orgs","repos_url":"https://api.github.com/users/maochf/repos","events_url":"https://api.github.com/users/maochf/events{/privacy}","received_events_url":"https://api.github.com/users/maochf/received_events","type":"User","site_admin":false},"body":"https://issues.cask.co/browse/CDAP-12232\r\nhttps://builds.cask.co/browse/CDAP-DUT6000-2","created_at":"2017-07-31T19:41:39Z","updated_at":"2017-08-01T19:46:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6f047acdb205342a038457fedc5af9df22141273","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/caskdata/cdap/pulls/9315/commits","review_comments_url":"https://api.github.com/repos/caskdata/cdap/pulls/9315/comments","review_comment_url":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/caskdata/cdap/issues/9315/comments","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/40f59ca5373e4e8a20fe55b424fcecbbf89906f6","head":{"label":"caskdata:feature/composite-trigger-new","ref":"feature/composite-trigger-new","sha":"40f59ca5373e4e8a20fe55b424fcecbbf89906f6","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2017-07-25T19:23:26Z","pushed_at":"2017-08-01T19:45:58Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"","size":505164,"stargazers_count":184,"watchers_count":184,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":96,"mirror_url":null,"open_issues_count":29,"forks":96,"open_issues":29,"watchers":184,"default_branch":"develop"}},"base":{"label":"caskdata:develop","ref":"develop","sha":"51b63909b6c1d5c65e16a4913d384288d9b71a27","user":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"repo":{"id":22542759,"name":"cdap","full_name":"caskdata/cdap","owner":{"login":"caskdata","id":8123023,"avatar_url":"https://avatars2.githubusercontent.com/u/8123023?v=4","gravatar_id":"","url":"https://api.github.com/users/caskdata","html_url":"https://github.com/caskdata","followers_url":"https://api.github.com/users/caskdata/followers","following_url":"https://api.github.com/users/caskdata/following{/other_user}","gists_url":"https://api.github.com/users/caskdata/gists{/gist_id}","starred_url":"https://api.github.com/users/caskdata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caskdata/subscriptions","organizations_url":"https://api.github.com/users/caskdata/orgs","repos_url":"https://api.github.com/users/caskdata/repos","events_url":"https://api.github.com/users/caskdata/events{/privacy}","received_events_url":"https://api.github.com/users/caskdata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/caskdata/cdap","description":"Cask Data Application Platform (CDAP)","fork":false,"url":"https://api.github.com/repos/caskdata/cdap","forks_url":"https://api.github.com/repos/caskdata/cdap/forks","keys_url":"https://api.github.com/repos/caskdata/cdap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/caskdata/cdap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/caskdata/cdap/teams","hooks_url":"https://api.github.com/repos/caskdata/cdap/hooks","issue_events_url":"https://api.github.com/repos/caskdata/cdap/issues/events{/number}","events_url":"https://api.github.com/repos/caskdata/cdap/events","assignees_url":"https://api.github.com/repos/caskdata/cdap/assignees{/user}","branches_url":"https://api.github.com/repos/caskdata/cdap/branches{/branch}","tags_url":"https://api.github.com/repos/caskdata/cdap/tags","blobs_url":"https://api.github.com/repos/caskdata/cdap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/caskdata/cdap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/caskdata/cdap/git/refs{/sha}","trees_url":"https://api.github.com/repos/caskdata/cdap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/caskdata/cdap/statuses/{sha}","languages_url":"https://api.github.com/repos/caskdata/cdap/languages","stargazers_url":"https://api.github.com/repos/caskdata/cdap/stargazers","contributors_url":"https://api.github.com/repos/caskdata/cdap/contributors","subscribers_url":"https://api.github.com/repos/caskdata/cdap/subscribers","subscription_url":"https://api.github.com/repos/caskdata/cdap/subscription","commits_url":"https://api.github.com/repos/caskdata/cdap/commits{/sha}","git_commits_url":"https://api.github.com/repos/caskdata/cdap/git/commits{/sha}","comments_url":"https://api.github.com/repos/caskdata/cdap/comments{/number}","issue_comment_url":"https://api.github.com/repos/caskdata/cdap/issues/comments{/number}","contents_url":"https://api.github.com/repos/caskdata/cdap/contents/{+path}","compare_url":"https://api.github.com/repos/caskdata/cdap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/caskdata/cdap/merges","archive_url":"https://api.github.com/repos/caskdata/cdap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/caskdata/cdap/downloads","issues_url":"https://api.github.com/repos/caskdata/cdap/issues{/number}","pulls_url":"https://api.github.com/repos/caskdata/cdap/pulls{/number}","milestones_url":"https://api.github.com/repos/caskdata/cdap/milestones{/number}","notifications_url":"https://api.github.com/repos/caskdata/cdap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/caskdata/cdap/labels{/name}","releases_url":"https://api.github.com/repos/caskdata/cdap/releases{/id}","deployments_url":"https://api.github.com/repos/caskdata/cdap/deployments","created_at":"2014-08-02T09:00:10Z","updated_at":"2017-07-25T19:23:26Z","pushed_at":"2017-08-01T19:45:58Z","git_url":"git://github.com/caskdata/cdap.git","ssh_url":"git@github.com:caskdata/cdap.git","clone_url":"https://github.com/caskdata/cdap.git","svn_url":"https://github.com/caskdata/cdap","homepage":"","size":505164,"stargazers_count":184,"watchers_count":184,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":96,"mirror_url":null,"open_issues_count":29,"forks":96,"open_issues":29,"watchers":184,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/9315"},"html":{"href":"https://github.com/caskdata/cdap/pull/9315"},"issue":{"href":"https://api.github.com/repos/caskdata/cdap/issues/9315"},"comments":{"href":"https://api.github.com/repos/caskdata/cdap/issues/9315/comments"},"review_comments":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/9315/comments"},"review_comment":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/caskdata/cdap/pulls/9315/commits"},"statuses":{"href":"https://api.github.com/repos/caskdata/cdap/statuses/40f59ca5373e4e8a20fe55b424fcecbbf89906f6"}}}}
{"actor":{"display_login":"sameetandpotatoes"}}