{"action":"created","issue":{"url":"https://api.github.com/repos/FormsCommunityToolkit/Effects/issues/48","repository_url":"https://api.github.com/repos/FormsCommunityToolkit/Effects","labels_url":"https://api.github.com/repos/FormsCommunityToolkit/Effects/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/FormsCommunityToolkit/Effects/issues/48/comments","events_url":"https://api.github.com/repos/FormsCommunityToolkit/Effects/issues/48/events","html_url":"https://github.com/FormsCommunityToolkit/Effects/issues/48","id":208038878,"number":48,"title":"Renaming effects - alignment","user":{"login":"Depechie","id":351693,"avatar_url":"https://avatars.githubusercontent.com/u/351693?v=3","gravatar_id":"","url":"https://api.github.com/users/Depechie","html_url":"https://github.com/Depechie","followers_url":"https://api.github.com/users/Depechie/followers","following_url":"https://api.github.com/users/Depechie/following{/other_user}","gists_url":"https://api.github.com/users/Depechie/gists{/gist_id}","starred_url":"https://api.github.com/users/Depechie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Depechie/subscriptions","organizations_url":"https://api.github.com/users/Depechie/orgs","repos_url":"https://api.github.com/users/Depechie/repos","events_url":"https://api.github.com/users/Depechie/events{/privacy}","received_events_url":"https://api.github.com/users/Depechie/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"jamesmontemagno","id":1676321,"avatar_url":"https://avatars.githubusercontent.com/u/1676321?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesmontemagno","html_url":"https://github.com/jamesmontemagno","followers_url":"https://api.github.com/users/jamesmontemagno/followers","following_url":"https://api.github.com/users/jamesmontemagno/following{/other_user}","gists_url":"https://api.github.com/users/jamesmontemagno/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmontemagno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmontemagno/subscriptions","organizations_url":"https://api.github.com/users/jamesmontemagno/orgs","repos_url":"https://api.github.com/users/jamesmontemagno/repos","events_url":"https://api.github.com/users/jamesmontemagno/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmontemagno/received_events","type":"User","site_admin":false},"assignees":[{"login":"jamesmontemagno","id":1676321,"avatar_url":"https://avatars.githubusercontent.com/u/1676321?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesmontemagno","html_url":"https://github.com/jamesmontemagno","followers_url":"https://api.github.com/users/jamesmontemagno/followers","following_url":"https://api.github.com/users/jamesmontemagno/following{/other_user}","gists_url":"https://api.github.com/users/jamesmontemagno/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmontemagno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmontemagno/subscriptions","organizations_url":"https://api.github.com/users/jamesmontemagno/orgs","repos_url":"https://api.github.com/users/jamesmontemagno/repos","events_url":"https://api.github.com/users/jamesmontemagno/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmontemagno/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-02-16T07:15:24Z","updated_at":"2017-02-16T14:14:43Z","closed_at":null,"body":"We are looking to rename the current effects, to streamline the naming.\r\nBut we are a bit stuck with the current proposal!\r\n\r\nProposal:\r\nCurrent name : public class CapitalizeKeyboardEffect : RoutingEffect\r\nNew name : public class EntryCapitalizeKeyboard : RoutingEffect\r\nSo prefix the control it targets and loose the suffix Effect\r\n\r\nBut if we uphold this, we get in trouble with the static classes that are needed for adding dependency properties to pass through to the actual RoutingEffect.\r\n\r\nProblem:\r\npublic static class ChangeColorEffect with tandem class > public class ChangeColorSwitchEffect : RoutingEffect ( https://github.com/FormsCommunityToolkit/Effects/blob/dev/src/Effects/ChangeColorEffect.cs )\r\npublic static class ChangePickerColorEffect with tandem class > public class ChangeColorPickerEffect : RoutingEffect ( https://github.com/FormsCommunityToolkit/Effects/blob/dev/src/Effects/ChangePickerColorEffect.cs )\r\n\r\nHow do we rename these? ChangeColorEffect would become SwitchChangeColor, but what would ChangeColorSwitchEffect be then?\r\nSame with the picker class...\r\n\r\nSuggestions?\r\n"},"comment":{"url":"https://api.github.com/repos/FormsCommunityToolkit/Effects/issues/comments/280340902","html_url":"https://github.com/FormsCommunityToolkit/Effects/issues/48#issuecomment-280340902","issue_url":"https://api.github.com/repos/FormsCommunityToolkit/Effects/issues/48","id":280340902,"user":{"login":"jamesmontemagno","id":1676321,"avatar_url":"https://avatars.githubusercontent.com/u/1676321?v=3","gravatar_id":"","url":"https://api.github.com/users/jamesmontemagno","html_url":"https://github.com/jamesmontemagno","followers_url":"https://api.github.com/users/jamesmontemagno/followers","following_url":"https://api.github.com/users/jamesmontemagno/following{/other_user}","gists_url":"https://api.github.com/users/jamesmontemagno/gists{/gist_id}","starred_url":"https://api.github.com/users/jamesmontemagno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jamesmontemagno/subscriptions","organizations_url":"https://api.github.com/users/jamesmontemagno/orgs","repos_url":"https://api.github.com/users/jamesmontemagno/repos","events_url":"https://api.github.com/users/jamesmontemagno/events{/privacy}","received_events_url":"https://api.github.com/users/jamesmontemagno/received_events","type":"User","site_admin":false},"created_at":"2017-02-16T14:14:43Z","updated_at":"2017-02-16T14:14:43Z","body":"Ahhhhhh I see now. Interesting."}}
{"actor":{"display_login":"jamesmontemagno"}}