{"action":"created","comment":{"url":"https://api.github.com/repos/istio/manager/pulls/comments/111635874","pull_request_review_id":32897588,"id":111635874,"diff_hunk":"@@ -148,7 +148,7 @@ func TestServiceConversion(t *testing.T) {\n \t\t\tlen(service.Ports), len(localSvc.Spec.Ports))\n \t}\n \n-\tif service.ExternalName != \"\" {\n+\tif service.ExternalName != \"\" || service.External() {","path":"platform/kube/conversion_test.go","position":5,"original_position":5,"commit_id":"879a93fc95f14823f92dcef67938407129c89a72","original_commit_id":"879a93fc95f14823f92dcef67938407129c89a72","user":{"login":"ijsnellf","id":19473346,"avatar_url":"https://avatars2.githubusercontent.com/u/19473346?v=3","gravatar_id":"","url":"https://api.github.com/users/ijsnellf","html_url":"https://github.com/ijsnellf","followers_url":"https://api.github.com/users/ijsnellf/followers","following_url":"https://api.github.com/users/ijsnellf/following{/other_user}","gists_url":"https://api.github.com/users/ijsnellf/gists{/gist_id}","starred_url":"https://api.github.com/users/ijsnellf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ijsnellf/subscriptions","organizations_url":"https://api.github.com/users/ijsnellf/orgs","repos_url":"https://api.github.com/users/ijsnellf/repos","events_url":"https://api.github.com/users/ijsnellf/events{/privacy}","received_events_url":"https://api.github.com/users/ijsnellf/received_events","type":"User","site_admin":false},"body":"Should just be `service.External()`, since\r\n```go\r\n// External predicate checks whether the service is external\r\nfunc (s *Service) External() bool {\r\n\treturn s.ExternalName != \"\"\r\n}\r\n```","created_at":"2017-04-14T21:04:47Z","updated_at":"2017-04-14T21:06:52Z","html_url":"https://github.com/istio/manager/pull/541#discussion_r111635874","pull_request_url":"https://api.github.com/repos/istio/manager/pulls/541","_links":{"self":{"href":"https://api.github.com/repos/istio/manager/pulls/comments/111635874"},"html":{"href":"https://github.com/istio/manager/pull/541#discussion_r111635874"},"pull_request":{"href":"https://api.github.com/repos/istio/manager/pulls/541"}}},"pull_request":{"url":"https://api.github.com/repos/istio/manager/pulls/541","id":115988309,"html_url":"https://github.com/istio/manager/pull/541","diff_url":"https://github.com/istio/manager/pull/541.diff","patch_url":"https://github.com/istio/manager/pull/541.patch","issue_url":"https://api.github.com/repos/istio/manager/issues/541","number":541,"state":"open","locked":false,"title":"[WIP] Egress support for https external services","user":{"login":"GregHanson","id":19473391,"avatar_url":"https://avatars0.githubusercontent.com/u/19473391?v=3","gravatar_id":"","url":"https://api.github.com/users/GregHanson","html_url":"https://github.com/GregHanson","followers_url":"https://api.github.com/users/GregHanson/followers","following_url":"https://api.github.com/users/GregHanson/following{/other_user}","gists_url":"https://api.github.com/users/GregHanson/gists{/gist_id}","starred_url":"https://api.github.com/users/GregHanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregHanson/subscriptions","organizations_url":"https://api.github.com/users/GregHanson/orgs","repos_url":"https://api.github.com/users/GregHanson/repos","events_url":"https://api.github.com/users/GregHanson/events{/privacy}","received_events_url":"https://api.github.com/users/GregHanson/received_events","type":"User","site_admin":false},"body":" - as it is now, clients will have to call `http://httpbin:443` vs `http://httpbin` for external services of type https\r\n - adds empty ssl_context block to cluster definition in egress service if type https","created_at":"2017-04-14T20:54:37Z","updated_at":"2017-04-14T21:06:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f647bf76a76715cef4ba19e81b217fd9389a2d5c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/manager/pulls/541/commits","review_comments_url":"https://api.github.com/repos/istio/manager/pulls/541/comments","review_comment_url":"https://api.github.com/repos/istio/manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/manager/issues/541/comments","statuses_url":"https://api.github.com/repos/istio/manager/statuses/879a93fc95f14823f92dcef67938407129c89a72","head":{"label":"GregHanson:egress_https","ref":"egress_https","sha":"879a93fc95f14823f92dcef67938407129c89a72","user":{"login":"GregHanson","id":19473391,"avatar_url":"https://avatars0.githubusercontent.com/u/19473391?v=3","gravatar_id":"","url":"https://api.github.com/users/GregHanson","html_url":"https://github.com/GregHanson","followers_url":"https://api.github.com/users/GregHanson/followers","following_url":"https://api.github.com/users/GregHanson/following{/other_user}","gists_url":"https://api.github.com/users/GregHanson/gists{/gist_id}","starred_url":"https://api.github.com/users/GregHanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregHanson/subscriptions","organizations_url":"https://api.github.com/users/GregHanson/orgs","repos_url":"https://api.github.com/users/GregHanson/repos","events_url":"https://api.github.com/users/GregHanson/events{/privacy}","received_events_url":"https://api.github.com/users/GregHanson/received_events","type":"User","site_admin":false},"repo":{"id":78883863,"name":"manager","full_name":"GregHanson/manager","owner":{"login":"GregHanson","id":19473391,"avatar_url":"https://avatars0.githubusercontent.com/u/19473391?v=3","gravatar_id":"","url":"https://api.github.com/users/GregHanson","html_url":"https://github.com/GregHanson","followers_url":"https://api.github.com/users/GregHanson/followers","following_url":"https://api.github.com/users/GregHanson/following{/other_user}","gists_url":"https://api.github.com/users/GregHanson/gists{/gist_id}","starred_url":"https://api.github.com/users/GregHanson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregHanson/subscriptions","organizations_url":"https://api.github.com/users/GregHanson/orgs","repos_url":"https://api.github.com/users/GregHanson/repos","events_url":"https://api.github.com/users/GregHanson/events{/privacy}","received_events_url":"https://api.github.com/users/GregHanson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GregHanson/manager","description":"The Istio manager implementation","fork":true,"url":"https://api.github.com/repos/GregHanson/manager","forks_url":"https://api.github.com/repos/GregHanson/manager/forks","keys_url":"https://api.github.com/repos/GregHanson/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GregHanson/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GregHanson/manager/teams","hooks_url":"https://api.github.com/repos/GregHanson/manager/hooks","issue_events_url":"https://api.github.com/repos/GregHanson/manager/issues/events{/number}","events_url":"https://api.github.com/repos/GregHanson/manager/events","assignees_url":"https://api.github.com/repos/GregHanson/manager/assignees{/user}","branches_url":"https://api.github.com/repos/GregHanson/manager/branches{/branch}","tags_url":"https://api.github.com/repos/GregHanson/manager/tags","blobs_url":"https://api.github.com/repos/GregHanson/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GregHanson/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GregHanson/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/GregHanson/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GregHanson/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/GregHanson/manager/languages","stargazers_url":"https://api.github.com/repos/GregHanson/manager/stargazers","contributors_url":"https://api.github.com/repos/GregHanson/manager/contributors","subscribers_url":"https://api.github.com/repos/GregHanson/manager/subscribers","subscription_url":"https://api.github.com/repos/GregHanson/manager/subscription","commits_url":"https://api.github.com/repos/GregHanson/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/GregHanson/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/GregHanson/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/GregHanson/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/GregHanson/manager/contents/{+path}","compare_url":"https://api.github.com/repos/GregHanson/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GregHanson/manager/merges","archive_url":"https://api.github.com/repos/GregHanson/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GregHanson/manager/downloads","issues_url":"https://api.github.com/repos/GregHanson/manager/issues{/number}","pulls_url":"https://api.github.com/repos/GregHanson/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/GregHanson/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/GregHanson/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GregHanson/manager/labels{/name}","releases_url":"https://api.github.com/repos/GregHanson/manager/releases{/id}","deployments_url":"https://api.github.com/repos/GregHanson/manager/deployments","created_at":"2017-01-13T20:24:52Z","updated_at":"2017-01-13T20:24:55Z","pushed_at":"2017-04-14T20:50:55Z","git_url":"git://github.com/GregHanson/manager.git","ssh_url":"git@github.com:GregHanson/manager.git","clone_url":"https://github.com/GregHanson/manager.git","svn_url":"https://github.com/GregHanson/manager","homepage":"","size":1020,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"96f48a22e872b9d0161e6e3bf24ba3fe39c2919a","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":75686596,"name":"manager","full_name":"istio/manager","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/manager","description":"The Istio manager implementation","fork":false,"url":"https://api.github.com/repos/istio/manager","forks_url":"https://api.github.com/repos/istio/manager/forks","keys_url":"https://api.github.com/repos/istio/manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/manager/teams","hooks_url":"https://api.github.com/repos/istio/manager/hooks","issue_events_url":"https://api.github.com/repos/istio/manager/issues/events{/number}","events_url":"https://api.github.com/repos/istio/manager/events","assignees_url":"https://api.github.com/repos/istio/manager/assignees{/user}","branches_url":"https://api.github.com/repos/istio/manager/branches{/branch}","tags_url":"https://api.github.com/repos/istio/manager/tags","blobs_url":"https://api.github.com/repos/istio/manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/manager/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/manager/languages","stargazers_url":"https://api.github.com/repos/istio/manager/stargazers","contributors_url":"https://api.github.com/repos/istio/manager/contributors","subscribers_url":"https://api.github.com/repos/istio/manager/subscribers","subscription_url":"https://api.github.com/repos/istio/manager/subscription","commits_url":"https://api.github.com/repos/istio/manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/manager/contents/{+path}","compare_url":"https://api.github.com/repos/istio/manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/manager/merges","archive_url":"https://api.github.com/repos/istio/manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/manager/downloads","issues_url":"https://api.github.com/repos/istio/manager/issues{/number}","pulls_url":"https://api.github.com/repos/istio/manager/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/manager/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/manager/labels{/name}","releases_url":"https://api.github.com/repos/istio/manager/releases{/id}","deployments_url":"https://api.github.com/repos/istio/manager/deployments","created_at":"2016-12-06T02:29:57Z","updated_at":"2017-04-12T20:31:58Z","pushed_at":"2017-04-14T20:54:38Z","git_url":"git://github.com/istio/manager.git","ssh_url":"git@github.com:istio/manager.git","clone_url":"https://github.com/istio/manager.git","svn_url":"https://github.com/istio/manager","homepage":"","size":1138,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":25,"mirror_url":null,"open_issues_count":48,"forks":25,"open_issues":48,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/manager/pulls/541"},"html":{"href":"https://github.com/istio/manager/pull/541"},"issue":{"href":"https://api.github.com/repos/istio/manager/issues/541"},"comments":{"href":"https://api.github.com/repos/istio/manager/issues/541/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/manager/pulls/541/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/manager/pulls/541/commits"},"statuses":{"href":"https://api.github.com/repos/istio/manager/statuses/879a93fc95f14823f92dcef67938407129c89a72"}}}}
{"actor":{"display_login":"ijsnellf"}}