{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/comments/156824580","pull_request_review_id":83365150,"id":156824580,"diff_hunk":"@@ -0,0 +1,90 @@\n+/**\n+ * DO NOT EDIT\n+ *\n+ * This file was automatically generated by\n+ *   https://github.com/Polymer/gen-typescript-declarations\n+ *\n+ * To modify these typings, edit the source file(s):\n+ *   lib/utils/flattened-nodes-observer.html\n+ */\n+\n+/// <reference path=\"boot.d.ts\" />\n+/// <reference path=\"array-splice.d.ts\" />\n+/// <reference path=\"async.d.ts\" />\n+\n+declare namespace Polymer {\n+\n+  /**\n+   * Class that listens for changes (additions or removals) to\n+   * \"flattened nodes\" on a given `node`. The list of flattened nodes consists\n+   * of a node's children and, for any children that are `<slot>` elements,\n+   * the expanded flattened list of `assignedNodes`.\n+   * For example, if the observed node has children `<a></a><slot></slot><b></b>`\n+   * and the `<slot>` has one `<div>` assigned to it, then the flattened\n+   * nodes list is `<a></a><div></div><b></b>`. If the `<slot>` has other\n+   * `<slot>` elements assigned to it, these are flattened as well.\n+   *\n+   * The provided `callback` is called whenever any change to this list\n+   * of flattened nodes occurs, where an addition or removal of a node is\n+   * considered a change. The `callback` is called with one argument, an object\n+   * containing an array of any `addedNodes` and `removedNodes`.\n+   *\n+   * Note: the callback is called asynchronous to any changes\n+   * at a microtask checkpoint. This is because observation is performed using\n+   * `MutationObserver` and the `<slot>` element's `slotchange` event which\n+   * are asynchronous.\n+   *\n+   * An example:\n+   * ```js\n+   * class TestSelfObserve extends Polymer.Element {\n+   *   static get is() { return 'test-self-observe';}\n+   *   connectedCallback() {\n+   *     super.connectedCallback();\n+   *     this._observer = new Polymer.FlattenedNodesObserver(this, (info) => {\n+   *       this.info = info;\n+   *     });\n+   *   }\n+   *   disconnectedCallback() {\n+   *     super.disconnectedCallback();\n+   *     this._observer.disconnect();\n+   *   }\n+   * }\n+   * customElements.define(TestSelfObserve.is, TestSelfObserve);\n+   * ```\n+   */\n+  class FlattenedNodesObserver {\n+    _shadyChildrenObserver: MutationObserver|null;\n+    _nativeChildrenObserver: MutationObserver|null;\n+    _boundSchedule: () => any;","path":"types/lib/utils/flattened-nodes-observer.d.ts","position":58,"original_position":58,"commit_id":"a77310af2c93d44f27f7c6293681a0e10339902f","original_commit_id":"c9be530d6450238a0ea64a06cf5fa1298a8f824c","user":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars0.githubusercontent.com/u/522948?v=4","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"body":"`@private` seems like the way to go, IMO","created_at":"2017-12-14T00:23:52Z","updated_at":"2017-12-14T00:23:52Z","html_url":"https://github.com/Polymer/polymer/pull/4928#discussion_r156824580","pull_request_url":"https://api.github.com/repos/Polymer/polymer/pulls/4928","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments/156824580"},"html":{"href":"https://github.com/Polymer/polymer/pull/4928#discussion_r156824580"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/4928"}},"in_reply_to_id":155948983},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/4928","id":151995608,"html_url":"https://github.com/Polymer/polymer/pull/4928","diff_url":"https://github.com/Polymer/polymer/pull/4928.diff","patch_url":"https://github.com/Polymer/polymer/pull/4928.patch","issue_url":"https://api.github.com/repos/Polymer/polymer/issues/4928","number":4928,"state":"open","locked":false,"title":"Add TypeScript declarations.","user":{"login":"aomarks","id":48894,"avatar_url":"https://avatars0.githubusercontent.com/u/48894?v=4","gravatar_id":"","url":"https://api.github.com/users/aomarks","html_url":"https://github.com/aomarks","followers_url":"https://api.github.com/users/aomarks/followers","following_url":"https://api.github.com/users/aomarks/following{/other_user}","gists_url":"https://api.github.com/users/aomarks/gists{/gist_id}","starred_url":"https://api.github.com/users/aomarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aomarks/subscriptions","organizations_url":"https://api.github.com/users/aomarks/orgs","repos_url":"https://api.github.com/users/aomarks/repos","events_url":"https://api.github.com/users/aomarks/events{/privacy}","received_events_url":"https://api.github.com/users/aomarks/received_events","type":"User","site_admin":false},"body":"Generated by https://github.com/Polymer/gen-typescript-declarations. Regenerate with `gulp generate-typescript`. Types are output to a `types/` directory.\r\n\r\nFixes #4025","created_at":"2017-11-10T20:27:52Z","updated_at":"2017-12-14T00:23:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0a4f3655694b46491186dad690997ecf3f7de039","assignee":{"login":"aomarks","id":48894,"avatar_url":"https://avatars0.githubusercontent.com/u/48894?v=4","gravatar_id":"","url":"https://api.github.com/users/aomarks","html_url":"https://github.com/aomarks","followers_url":"https://api.github.com/users/aomarks/followers","following_url":"https://api.github.com/users/aomarks/following{/other_user}","gists_url":"https://api.github.com/users/aomarks/gists{/gist_id}","starred_url":"https://api.github.com/users/aomarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aomarks/subscriptions","organizations_url":"https://api.github.com/users/aomarks/orgs","repos_url":"https://api.github.com/users/aomarks/repos","events_url":"https://api.github.com/users/aomarks/events{/privacy}","received_events_url":"https://api.github.com/users/aomarks/received_events","type":"User","site_admin":false},"assignees":[{"login":"aomarks","id":48894,"avatar_url":"https://avatars0.githubusercontent.com/u/48894?v=4","gravatar_id":"","url":"https://api.github.com/users/aomarks","html_url":"https://github.com/aomarks","followers_url":"https://api.github.com/users/aomarks/followers","following_url":"https://api.github.com/users/aomarks/following{/other_user}","gists_url":"https://api.github.com/users/aomarks/gists{/gist_id}","starred_url":"https://api.github.com/users/aomarks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aomarks/subscriptions","organizations_url":"https://api.github.com/users/aomarks/orgs","repos_url":"https://api.github.com/users/aomarks/repos","events_url":"https://api.github.com/users/aomarks/events{/privacy}","received_events_url":"https://api.github.com/users/aomarks/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars0.githubusercontent.com/u/522948?v=4","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer/pulls/4928/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer/pulls/4928/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer/issues/4928/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/a77310af2c93d44f27f7c6293681a0e10339902f","head":{"label":"Polymer:aomarks-typescript","ref":"aomarks-typescript","sha":"a77310af2c93d44f27f7c6293681a0e10339902f","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":5532320,"name":"polymer","full_name":"Polymer/polymer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer","description":"Build modern apps using web components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer","forks_url":"https://api.github.com/repos/Polymer/polymer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer/deployments","created_at":"2012-08-23T20:56:30Z","updated_at":"2017-12-13T21:35:50Z","pushed_at":"2017-12-13T23:43:21Z","git_url":"git://github.com/Polymer/polymer.git","ssh_url":"git@github.com:Polymer/polymer.git","clone_url":"https://github.com/Polymer/polymer.git","svn_url":"https://github.com/Polymer/polymer","homepage":"https://www.polymer-project.org/","size":24106,"stargazers_count":18879,"watchers_count":18879,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1897,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1897,"open_issues":369,"watchers":18879,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"81add63e7a3e4367aeab0ba9660e02394e48ffe1","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":5532320,"name":"polymer","full_name":"Polymer/polymer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer","description":"Build modern apps using web components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer","forks_url":"https://api.github.com/repos/Polymer/polymer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer/deployments","created_at":"2012-08-23T20:56:30Z","updated_at":"2017-12-13T21:35:50Z","pushed_at":"2017-12-13T23:43:21Z","git_url":"git://github.com/Polymer/polymer.git","ssh_url":"git@github.com:Polymer/polymer.git","clone_url":"https://github.com/Polymer/polymer.git","svn_url":"https://github.com/Polymer/polymer","homepage":"https://www.polymer-project.org/","size":24106,"stargazers_count":18879,"watchers_count":18879,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1897,"mirror_url":null,"archived":false,"open_issues_count":369,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1897,"open_issues":369,"watchers":18879,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/4928"},"html":{"href":"https://github.com/Polymer/polymer/pull/4928"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer/issues/4928"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer/issues/4928/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/4928/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/4928/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer/statuses/a77310af2c93d44f27f7c6293681a0e10339902f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"justinfagnani"}}