{"action":"created","comment":{"url":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/comments/94282369","pull_request_review_id":14811988,"id":94282369,"diff_hunk":"@@ -0,0 +1,41 @@\n+from basetrigger import BaseTrigger\n+import alexapi.triggers as triggers\n+\n+\n+class PlatformTrigger(BaseTrigger):\n+\n+\ttype = triggers.TYPES.OTHER\n+\n+\t_platform_continuous_callback = None\n+\n+\tdef __init__(self, config, trigger_callback):\n+\n+\t\tsuper(PlatformTrigger, self).__init__(config, trigger_callback, 'platform')\n+\n+\t\tself._event_type = triggers.EVENT_TYPES.ONESHOT if self._tconfig['event_type'] == 'oneshot' \\","path":"src/alexapi/triggers/platformtrigger.py","position":15,"original_position":15,"commit_id":"81a7b2906c2b4ae29add714c389d8519182b264b","original_commit_id":"81a7b2906c2b4ae29add714c389d8519182b264b","user":{"login":"renekliment","id":156399,"avatar_url":"https://avatars.githubusercontent.com/u/156399?v=3","gravatar_id":"","url":"https://api.github.com/users/renekliment","html_url":"https://github.com/renekliment","followers_url":"https://api.github.com/users/renekliment/followers","following_url":"https://api.github.com/users/renekliment/following{/other_user}","gists_url":"https://api.github.com/users/renekliment/gists{/gist_id}","starred_url":"https://api.github.com/users/renekliment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renekliment/subscriptions","organizations_url":"https://api.github.com/users/renekliment/orgs","repos_url":"https://api.github.com/users/renekliment/repos","events_url":"https://api.github.com/users/renekliment/events{/privacy}","received_events_url":"https://api.github.com/users/renekliment/received_events","type":"User","site_admin":false},"body":"Yes, it should. Thanks.","created_at":"2017-01-01T10:34:27Z","updated_at":"2017-01-01T10:34:27Z","html_url":"https://github.com/alexa-pi/AlexaPi/pull/119#discussion_r94282369","pull_request_url":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/119","_links":{"self":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/comments/94282369"},"html":{"href":"https://github.com/alexa-pi/AlexaPi/pull/119#discussion_r94282369"},"pull_request":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/119"}}},"pull_request":{"url":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/119","id":99692348,"html_url":"https://github.com/alexa-pi/AlexaPi/pull/119","diff_url":"https://github.com/alexa-pi/AlexaPi/pull/119.diff","patch_url":"https://github.com/alexa-pi/AlexaPi/pull/119.patch","issue_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/119","number":119,"state":"open","locked":false,"title":"Triggering refactor","user":{"login":"renekliment","id":156399,"avatar_url":"https://avatars.githubusercontent.com/u/156399?v=3","gravatar_id":"","url":"https://api.github.com/users/renekliment","html_url":"https://github.com/renekliment","followers_url":"https://api.github.com/users/renekliment/followers","following_url":"https://api.github.com/users/renekliment/following{/other_user}","gists_url":"https://api.github.com/users/renekliment/gists{/gist_id}","starred_url":"https://api.github.com/users/renekliment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renekliment/subscriptions","organizations_url":"https://api.github.com/users/renekliment/orgs","repos_url":"https://api.github.com/users/renekliment/repos","events_url":"https://api.github.com/users/renekliment/events{/privacy}","received_events_url":"https://api.github.com/users/renekliment/received_events","type":"User","site_admin":false},"body":"This fixes #24.\r\n\r\nIt is a very important PR project-wise for these two reasons:\r\n- All the triggers can be enabled / disabled, therefore the voice activation is now optional and once this is released (in _v1.4_), we can recommend **all** the users of the original Sam's repos AlexaPi and AlexaCHIP to use the version from our repo. This is the one _feature_ that we've been missing so far and I believe there are people who don't want voice activation / the recognition engines are not available for their platform.\r\n- Since all the triggers are now modules, we can very, **very** easily add support for **snowboy** now. Yes, we got there! We need to be smart about how we distribute it though. It's not on pypi (yet?), so we might go for a git submodule. Also, it's a C library and it's not available for all the platforms, so the task is not that trivial. Of course just dumping the Raspberry Pi tarball in the repo is a way to do it (like all the other forks of AlexaPi with snowboy), but I believe this repo is all about doing things as right as possible. \r\n- Which brings me to the other thing that once we have snowboy, a substantial number of the forks become obsolete and with all the added features and fixes here, we'll have most of the \"merge all the forks\" task covered. After that, I'd like to ask all people with the forks to delete / redirect their repos here and fork our repo instead.\r\n\r\nTODO list:\r\n- [x] update ChangeLog (part of this PR)\r\n- [ ] update wiki section on config changes","created_at":"2016-12-29T19:52:52Z","updated_at":"2017-01-01T10:34:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4c8fec2fd86519484393ebf9d1a228d0e20cb83c","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/alexa-pi/AlexaPi/milestones/4","html_url":"https://github.com/alexa-pi/AlexaPi/milestone/4","labels_url":"https://api.github.com/repos/alexa-pi/AlexaPi/milestones/4/labels","id":2116212,"number":4,"title":"1.4","description":"The highlight of this milestone is to refactor triggering, which will, among other things, make voice triggering optional and it will bring **snowboy**, which should solve some of our triggering issues. This all means we will cover the functionality of the majority of the forks.","creator":{"login":"renekliment","id":156399,"avatar_url":"https://avatars.githubusercontent.com/u/156399?v=3","gravatar_id":"","url":"https://api.github.com/users/renekliment","html_url":"https://github.com/renekliment","followers_url":"https://api.github.com/users/renekliment/followers","following_url":"https://api.github.com/users/renekliment/following{/other_user}","gists_url":"https://api.github.com/users/renekliment/gists{/gist_id}","starred_url":"https://api.github.com/users/renekliment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renekliment/subscriptions","organizations_url":"https://api.github.com/users/renekliment/orgs","repos_url":"https://api.github.com/users/renekliment/repos","events_url":"https://api.github.com/users/renekliment/events{/privacy}","received_events_url":"https://api.github.com/users/renekliment/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":1,"state":"open","created_at":"2016-11-05T09:19:13Z","updated_at":"2016-12-30T11:22:28Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/119/commits","review_comments_url":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/119/comments","review_comment_url":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/119/comments","statuses_url":"https://api.github.com/repos/alexa-pi/AlexaPi/statuses/81a7b2906c2b4ae29add714c389d8519182b264b","head":{"label":"renekliment:24-triggering","ref":"24-triggering","sha":"81a7b2906c2b4ae29add714c389d8519182b264b","user":{"login":"renekliment","id":156399,"avatar_url":"https://avatars.githubusercontent.com/u/156399?v=3","gravatar_id":"","url":"https://api.github.com/users/renekliment","html_url":"https://github.com/renekliment","followers_url":"https://api.github.com/users/renekliment/followers","following_url":"https://api.github.com/users/renekliment/following{/other_user}","gists_url":"https://api.github.com/users/renekliment/gists{/gist_id}","starred_url":"https://api.github.com/users/renekliment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renekliment/subscriptions","organizations_url":"https://api.github.com/users/renekliment/orgs","repos_url":"https://api.github.com/users/renekliment/repos","events_url":"https://api.github.com/users/renekliment/events{/privacy}","received_events_url":"https://api.github.com/users/renekliment/received_events","type":"User","site_admin":false},"repo":{"id":67790503,"name":"AlexaPi","full_name":"renekliment/AlexaPi","owner":{"login":"renekliment","id":156399,"avatar_url":"https://avatars.githubusercontent.com/u/156399?v=3","gravatar_id":"","url":"https://api.github.com/users/renekliment","html_url":"https://github.com/renekliment","followers_url":"https://api.github.com/users/renekliment/followers","following_url":"https://api.github.com/users/renekliment/following{/other_user}","gists_url":"https://api.github.com/users/renekliment/gists{/gist_id}","starred_url":"https://api.github.com/users/renekliment/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/renekliment/subscriptions","organizations_url":"https://api.github.com/users/renekliment/orgs","repos_url":"https://api.github.com/users/renekliment/repos","events_url":"https://api.github.com/users/renekliment/events{/privacy}","received_events_url":"https://api.github.com/users/renekliment/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/renekliment/AlexaPi","description":"Alexa client for all your devices!","fork":true,"url":"https://api.github.com/repos/renekliment/AlexaPi","forks_url":"https://api.github.com/repos/renekliment/AlexaPi/forks","keys_url":"https://api.github.com/repos/renekliment/AlexaPi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/renekliment/AlexaPi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/renekliment/AlexaPi/teams","hooks_url":"https://api.github.com/repos/renekliment/AlexaPi/hooks","issue_events_url":"https://api.github.com/repos/renekliment/AlexaPi/issues/events{/number}","events_url":"https://api.github.com/repos/renekliment/AlexaPi/events","assignees_url":"https://api.github.com/repos/renekliment/AlexaPi/assignees{/user}","branches_url":"https://api.github.com/repos/renekliment/AlexaPi/branches{/branch}","tags_url":"https://api.github.com/repos/renekliment/AlexaPi/tags","blobs_url":"https://api.github.com/repos/renekliment/AlexaPi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/renekliment/AlexaPi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/renekliment/AlexaPi/git/refs{/sha}","trees_url":"https://api.github.com/repos/renekliment/AlexaPi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/renekliment/AlexaPi/statuses/{sha}","languages_url":"https://api.github.com/repos/renekliment/AlexaPi/languages","stargazers_url":"https://api.github.com/repos/renekliment/AlexaPi/stargazers","contributors_url":"https://api.github.com/repos/renekliment/AlexaPi/contributors","subscribers_url":"https://api.github.com/repos/renekliment/AlexaPi/subscribers","subscription_url":"https://api.github.com/repos/renekliment/AlexaPi/subscription","commits_url":"https://api.github.com/repos/renekliment/AlexaPi/commits{/sha}","git_commits_url":"https://api.github.com/repos/renekliment/AlexaPi/git/commits{/sha}","comments_url":"https://api.github.com/repos/renekliment/AlexaPi/comments{/number}","issue_comment_url":"https://api.github.com/repos/renekliment/AlexaPi/issues/comments{/number}","contents_url":"https://api.github.com/repos/renekliment/AlexaPi/contents/{+path}","compare_url":"https://api.github.com/repos/renekliment/AlexaPi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/renekliment/AlexaPi/merges","archive_url":"https://api.github.com/repos/renekliment/AlexaPi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/renekliment/AlexaPi/downloads","issues_url":"https://api.github.com/repos/renekliment/AlexaPi/issues{/number}","pulls_url":"https://api.github.com/repos/renekliment/AlexaPi/pulls{/number}","milestones_url":"https://api.github.com/repos/renekliment/AlexaPi/milestones{/number}","notifications_url":"https://api.github.com/repos/renekliment/AlexaPi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/renekliment/AlexaPi/labels{/name}","releases_url":"https://api.github.com/repos/renekliment/AlexaPi/releases{/id}","deployments_url":"https://api.github.com/repos/renekliment/AlexaPi/deployments","created_at":"2016-09-09T10:35:15Z","updated_at":"2016-10-26T20:25:27Z","pushed_at":"2016-12-30T13:15:17Z","git_url":"git://github.com/renekliment/AlexaPi.git","ssh_url":"git@github.com:renekliment/AlexaPi.git","clone_url":"https://github.com/renekliment/AlexaPi.git","svn_url":"https://github.com/renekliment/AlexaPi","homepage":null,"size":439,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alexa-pi:dev","ref":"dev","sha":"24b4990e95a47d4dbb2d76d733507dc0e8a04c6a","user":{"login":"alexa-pi","id":22049374,"avatar_url":"https://avatars.githubusercontent.com/u/22049374?v=3","gravatar_id":"","url":"https://api.github.com/users/alexa-pi","html_url":"https://github.com/alexa-pi","followers_url":"https://api.github.com/users/alexa-pi/followers","following_url":"https://api.github.com/users/alexa-pi/following{/other_user}","gists_url":"https://api.github.com/users/alexa-pi/gists{/gist_id}","starred_url":"https://api.github.com/users/alexa-pi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexa-pi/subscriptions","organizations_url":"https://api.github.com/users/alexa-pi/orgs","repos_url":"https://api.github.com/users/alexa-pi/repos","events_url":"https://api.github.com/users/alexa-pi/events{/privacy}","received_events_url":"https://api.github.com/users/alexa-pi/received_events","type":"Organization","site_admin":false},"repo":{"id":67783103,"name":"AlexaPi","full_name":"alexa-pi/AlexaPi","owner":{"login":"alexa-pi","id":22049374,"avatar_url":"https://avatars.githubusercontent.com/u/22049374?v=3","gravatar_id":"","url":"https://api.github.com/users/alexa-pi","html_url":"https://github.com/alexa-pi","followers_url":"https://api.github.com/users/alexa-pi/followers","following_url":"https://api.github.com/users/alexa-pi/following{/other_user}","gists_url":"https://api.github.com/users/alexa-pi/gists{/gist_id}","starred_url":"https://api.github.com/users/alexa-pi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexa-pi/subscriptions","organizations_url":"https://api.github.com/users/alexa-pi/orgs","repos_url":"https://api.github.com/users/alexa-pi/repos","events_url":"https://api.github.com/users/alexa-pi/events{/privacy}","received_events_url":"https://api.github.com/users/alexa-pi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/alexa-pi/AlexaPi","description":"Alexa client for all your devices!","fork":false,"url":"https://api.github.com/repos/alexa-pi/AlexaPi","forks_url":"https://api.github.com/repos/alexa-pi/AlexaPi/forks","keys_url":"https://api.github.com/repos/alexa-pi/AlexaPi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexa-pi/AlexaPi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexa-pi/AlexaPi/teams","hooks_url":"https://api.github.com/repos/alexa-pi/AlexaPi/hooks","issue_events_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/events{/number}","events_url":"https://api.github.com/repos/alexa-pi/AlexaPi/events","assignees_url":"https://api.github.com/repos/alexa-pi/AlexaPi/assignees{/user}","branches_url":"https://api.github.com/repos/alexa-pi/AlexaPi/branches{/branch}","tags_url":"https://api.github.com/repos/alexa-pi/AlexaPi/tags","blobs_url":"https://api.github.com/repos/alexa-pi/AlexaPi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexa-pi/AlexaPi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexa-pi/AlexaPi/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexa-pi/AlexaPi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexa-pi/AlexaPi/statuses/{sha}","languages_url":"https://api.github.com/repos/alexa-pi/AlexaPi/languages","stargazers_url":"https://api.github.com/repos/alexa-pi/AlexaPi/stargazers","contributors_url":"https://api.github.com/repos/alexa-pi/AlexaPi/contributors","subscribers_url":"https://api.github.com/repos/alexa-pi/AlexaPi/subscribers","subscription_url":"https://api.github.com/repos/alexa-pi/AlexaPi/subscription","commits_url":"https://api.github.com/repos/alexa-pi/AlexaPi/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexa-pi/AlexaPi/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexa-pi/AlexaPi/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexa-pi/AlexaPi/contents/{+path}","compare_url":"https://api.github.com/repos/alexa-pi/AlexaPi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexa-pi/AlexaPi/merges","archive_url":"https://api.github.com/repos/alexa-pi/AlexaPi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexa-pi/AlexaPi/downloads","issues_url":"https://api.github.com/repos/alexa-pi/AlexaPi/issues{/number}","pulls_url":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls{/number}","milestones_url":"https://api.github.com/repos/alexa-pi/AlexaPi/milestones{/number}","notifications_url":"https://api.github.com/repos/alexa-pi/AlexaPi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexa-pi/AlexaPi/labels{/name}","releases_url":"https://api.github.com/repos/alexa-pi/AlexaPi/releases{/id}","deployments_url":"https://api.github.com/repos/alexa-pi/AlexaPi/deployments","created_at":"2016-09-09T08:54:49Z","updated_at":"2017-01-01T09:01:23Z","pushed_at":"2016-12-30T13:15:18Z","git_url":"git://github.com/alexa-pi/AlexaPi.git","ssh_url":"git@github.com:alexa-pi/AlexaPi.git","clone_url":"https://github.com/alexa-pi/AlexaPi.git","svn_url":"https://github.com/alexa-pi/AlexaPi","homepage":null,"size":418,"stargazers_count":135,"watchers_count":135,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"open_issues_count":38,"forks":30,"open_issues":38,"watchers":135,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/119"},"html":{"href":"https://github.com/alexa-pi/AlexaPi/pull/119"},"issue":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/119"},"comments":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/issues/119/comments"},"review_comments":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/119/comments"},"review_comment":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/pulls/119/commits"},"statuses":{"href":"https://api.github.com/repos/alexa-pi/AlexaPi/statuses/81a7b2906c2b4ae29add714c389d8519182b264b"}}}}
{"actor":{"display_login":"renekliment"}}