{"action":"created","comment":{"url":"https://api.github.com/repos/mapsme/omim/pulls/comments/152487992","pull_request_review_id":78356328,"id":152487992,"diff_hunk":"@@ -358,8 +358,9 @@ typename AStarAlgorithm<TGraph>::Result AStarAlgorithm<TGraph>::FindPath(\n   if (resultCode == Result::OK)\n   {\n     context.ReconstructPath(finalVertex, result.m_path);\n-    result.m_distance =\n-        context.GetDistance(finalVertex) - graph.HeuristicCostEstimate(startVertex, finalVertex);\n+    result.m_distance = context.GetDistance(finalVertex) -\n+                        graph.HeuristicCostEstimate(finalVertex, finalVertex) +","path":"routing/base/astar_algorithm.hpp","position":7,"original_position":7,"commit_id":"f3f281355658ca480472d829e83ab61ed691b2d8","original_commit_id":"f3f281355658ca480472d829e83ab61ed691b2d8","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"body":"Добавила после комментария @mpimenov . A* всё-таки должен работать с эвристикой как с черным ящиком (хотя да, эвристика неперееоценивающая и от точки до себя будет 0).","created_at":"2017-11-22T07:48:00Z","updated_at":"2017-11-22T07:48:00Z","html_url":"https://github.com/mapsme/omim/pull/7609#discussion_r152487992","pull_request_url":"https://api.github.com/repos/mapsme/omim/pulls/7609","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments/152487992"},"html":{"href":"https://github.com/mapsme/omim/pull/7609#discussion_r152487992"},"pull_request":{"href":"https://api.github.com/repos/mapsme/omim/pulls/7609"}},"in_reply_to_id":152472145},"pull_request":{"url":"https://api.github.com/repos/mapsme/omim/pulls/7609","id":153925607,"html_url":"https://github.com/mapsme/omim/pull/7609","diff_url":"https://github.com/mapsme/omim/pull/7609.diff","patch_url":"https://github.com/mapsme/omim/pull/7609.patch","issue_url":"https://api.github.com/repos/mapsme/omim/issues/7609","number":7609,"state":"open","locked":false,"title":"Fix distance calculation for unidirectional AStar","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"body":"Начиная с этого PR:\r\nhttps://github.com/mapsme/omim/commit/e1ede4b1100a47b57e781d8bc9d77a9431f3bb18\r\n\r\nдумаю тут должен быть `+`:\r\n```math\r\nlr_i = l_i + h_i - h_(i-1)\r\nSUM(lr) = SUM(l) + h_ff - h_sf\r\nSUM(l) = SUM(lr) + h_sf \r\n```\r\nгде `lr_i` -- reduced length i-ого ребра, `l_i` -- длина i-ого ребра, `h_ff` -- эвристика от финиша до финиша равна 0, `h_sf` -- эвристика от старта до финиша. \r\n\r\nну и под дебаггером посмотрела что сейчас возвращаемый вес не соответствует сумме весов рёбер, после исправления соответствует.","created_at":"2017-11-21T15:43:14Z","updated_at":"2017-11-22T07:48:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5358e271cadf192f8dcce01b16764efc78ce0d63","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ygorshenin","id":454567,"avatar_url":"https://avatars2.githubusercontent.com/u/454567?v=4","gravatar_id":"","url":"https://api.github.com/users/ygorshenin","html_url":"https://github.com/ygorshenin","followers_url":"https://api.github.com/users/ygorshenin/followers","following_url":"https://api.github.com/users/ygorshenin/following{/other_user}","gists_url":"https://api.github.com/users/ygorshenin/gists{/gist_id}","starred_url":"https://api.github.com/users/ygorshenin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ygorshenin/subscriptions","organizations_url":"https://api.github.com/users/ygorshenin/orgs","repos_url":"https://api.github.com/users/ygorshenin/repos","events_url":"https://api.github.com/users/ygorshenin/events{/privacy}","received_events_url":"https://api.github.com/users/ygorshenin/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mapsme/omim/pulls/7609/commits","review_comments_url":"https://api.github.com/repos/mapsme/omim/pulls/7609/comments","review_comment_url":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapsme/omim/issues/7609/comments","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/f3f281355658ca480472d829e83ab61ed691b2d8","head":{"label":"tatiana-kondakova:fix_AStar_FindPath_result_distance","ref":"fix_AStar_FindPath_result_distance","sha":"f3f281355658ca480472d829e83ab61ed691b2d8","user":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"repo":{"id":98180090,"name":"omim","full_name":"tatiana-kondakova/omim","owner":{"login":"tatiana-kondakova","id":9213190,"avatar_url":"https://avatars3.githubusercontent.com/u/9213190?v=4","gravatar_id":"","url":"https://api.github.com/users/tatiana-kondakova","html_url":"https://github.com/tatiana-kondakova","followers_url":"https://api.github.com/users/tatiana-kondakova/followers","following_url":"https://api.github.com/users/tatiana-kondakova/following{/other_user}","gists_url":"https://api.github.com/users/tatiana-kondakova/gists{/gist_id}","starred_url":"https://api.github.com/users/tatiana-kondakova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tatiana-kondakova/subscriptions","organizations_url":"https://api.github.com/users/tatiana-kondakova/orgs","repos_url":"https://api.github.com/users/tatiana-kondakova/repos","events_url":"https://api.github.com/users/tatiana-kondakova/events{/privacy}","received_events_url":"https://api.github.com/users/tatiana-kondakova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tatiana-kondakova/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":true,"url":"https://api.github.com/repos/tatiana-kondakova/omim","forks_url":"https://api.github.com/repos/tatiana-kondakova/omim/forks","keys_url":"https://api.github.com/repos/tatiana-kondakova/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tatiana-kondakova/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tatiana-kondakova/omim/teams","hooks_url":"https://api.github.com/repos/tatiana-kondakova/omim/hooks","issue_events_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues/events{/number}","events_url":"https://api.github.com/repos/tatiana-kondakova/omim/events","assignees_url":"https://api.github.com/repos/tatiana-kondakova/omim/assignees{/user}","branches_url":"https://api.github.com/repos/tatiana-kondakova/omim/branches{/branch}","tags_url":"https://api.github.com/repos/tatiana-kondakova/omim/tags","blobs_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tatiana-kondakova/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/tatiana-kondakova/omim/languages","stargazers_url":"https://api.github.com/repos/tatiana-kondakova/omim/stargazers","contributors_url":"https://api.github.com/repos/tatiana-kondakova/omim/contributors","subscribers_url":"https://api.github.com/repos/tatiana-kondakova/omim/subscribers","subscription_url":"https://api.github.com/repos/tatiana-kondakova/omim/subscription","commits_url":"https://api.github.com/repos/tatiana-kondakova/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/tatiana-kondakova/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/tatiana-kondakova/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/tatiana-kondakova/omim/contents/{+path}","compare_url":"https://api.github.com/repos/tatiana-kondakova/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tatiana-kondakova/omim/merges","archive_url":"https://api.github.com/repos/tatiana-kondakova/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tatiana-kondakova/omim/downloads","issues_url":"https://api.github.com/repos/tatiana-kondakova/omim/issues{/number}","pulls_url":"https://api.github.com/repos/tatiana-kondakova/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/tatiana-kondakova/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/tatiana-kondakova/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tatiana-kondakova/omim/labels{/name}","releases_url":"https://api.github.com/repos/tatiana-kondakova/omim/releases{/id}","deployments_url":"https://api.github.com/repos/tatiana-kondakova/omim/deployments","created_at":"2017-07-24T10:44:21Z","updated_at":"2017-07-24T10:45:30Z","pushed_at":"2017-11-21T16:20:13Z","git_url":"git://github.com/tatiana-kondakova/omim.git","ssh_url":"git@github.com:tatiana-kondakova/omim.git","clone_url":"https://github.com/tatiana-kondakova/omim.git","svn_url":"https://github.com/tatiana-kondakova/omim","homepage":"","size":3469699,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mapsme:master","ref":"master","sha":"1a4858ebe218a45d3c2fc0c2707b5beabec0a9d4","user":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"repo":{"id":42798033,"name":"omim","full_name":"mapsme/omim","owner":{"login":"mapsme","id":14185141,"avatar_url":"https://avatars1.githubusercontent.com/u/14185141?v=4","gravatar_id":"","url":"https://api.github.com/users/mapsme","html_url":"https://github.com/mapsme","followers_url":"https://api.github.com/users/mapsme/followers","following_url":"https://api.github.com/users/mapsme/following{/other_user}","gists_url":"https://api.github.com/users/mapsme/gists{/gist_id}","starred_url":"https://api.github.com/users/mapsme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapsme/subscriptions","organizations_url":"https://api.github.com/users/mapsme/orgs","repos_url":"https://api.github.com/users/mapsme/repos","events_url":"https://api.github.com/users/mapsme/events{/privacy}","received_events_url":"https://api.github.com/users/mapsme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapsme/omim","description":"🗺️ MAPS.ME — Offline OpenStreetMap maps for iOS and Android","fork":false,"url":"https://api.github.com/repos/mapsme/omim","forks_url":"https://api.github.com/repos/mapsme/omim/forks","keys_url":"https://api.github.com/repos/mapsme/omim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapsme/omim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapsme/omim/teams","hooks_url":"https://api.github.com/repos/mapsme/omim/hooks","issue_events_url":"https://api.github.com/repos/mapsme/omim/issues/events{/number}","events_url":"https://api.github.com/repos/mapsme/omim/events","assignees_url":"https://api.github.com/repos/mapsme/omim/assignees{/user}","branches_url":"https://api.github.com/repos/mapsme/omim/branches{/branch}","tags_url":"https://api.github.com/repos/mapsme/omim/tags","blobs_url":"https://api.github.com/repos/mapsme/omim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapsme/omim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapsme/omim/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapsme/omim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapsme/omim/statuses/{sha}","languages_url":"https://api.github.com/repos/mapsme/omim/languages","stargazers_url":"https://api.github.com/repos/mapsme/omim/stargazers","contributors_url":"https://api.github.com/repos/mapsme/omim/contributors","subscribers_url":"https://api.github.com/repos/mapsme/omim/subscribers","subscription_url":"https://api.github.com/repos/mapsme/omim/subscription","commits_url":"https://api.github.com/repos/mapsme/omim/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapsme/omim/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapsme/omim/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapsme/omim/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapsme/omim/contents/{+path}","compare_url":"https://api.github.com/repos/mapsme/omim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapsme/omim/merges","archive_url":"https://api.github.com/repos/mapsme/omim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapsme/omim/downloads","issues_url":"https://api.github.com/repos/mapsme/omim/issues{/number}","pulls_url":"https://api.github.com/repos/mapsme/omim/pulls{/number}","milestones_url":"https://api.github.com/repos/mapsme/omim/milestones{/number}","notifications_url":"https://api.github.com/repos/mapsme/omim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapsme/omim/labels{/name}","releases_url":"https://api.github.com/repos/mapsme/omim/releases{/id}","deployments_url":"https://api.github.com/repos/mapsme/omim/deployments","created_at":"2015-09-20T02:57:13Z","updated_at":"2017-11-21T21:34:41Z","pushed_at":"2017-11-22T07:29:38Z","git_url":"git://github.com/mapsme/omim.git","ssh_url":"git@github.com:mapsme/omim.git","clone_url":"https://github.com/mapsme/omim.git","svn_url":"https://github.com/mapsme/omim","homepage":"","size":3480842,"stargazers_count":2471,"watchers_count":2471,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":540,"mirror_url":null,"archived":false,"open_issues_count":611,"forks":540,"open_issues":611,"watchers":2471,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapsme/omim/pulls/7609"},"html":{"href":"https://github.com/mapsme/omim/pull/7609"},"issue":{"href":"https://api.github.com/repos/mapsme/omim/issues/7609"},"comments":{"href":"https://api.github.com/repos/mapsme/omim/issues/7609/comments"},"review_comments":{"href":"https://api.github.com/repos/mapsme/omim/pulls/7609/comments"},"review_comment":{"href":"https://api.github.com/repos/mapsme/omim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapsme/omim/pulls/7609/commits"},"statuses":{"href":"https://api.github.com/repos/mapsme/omim/statuses/f3f281355658ca480472d829e83ab61ed691b2d8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tatiana-kondakova"}}