{"action":"created","comment":{"url":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/comments/136456130","pull_request_review_id":59998961,"id":136456130,"diff_hunk":"@@ -0,0 +1,28 @@\n+package com.microsoft.sqlserver.jdbc.CustomTrustManager;\n+\n+import java.security.cert.CertificateException;\n+import java.security.cert.X509Certificate;\n+\n+import javax.net.ssl.X509TrustManager;\n+\n+/**\n+ * This class implements an X509TrustManager that always accepts the X509Certificate chain offered to it.\n+ */\n+\n+public final class PermissiveTrustManager extends Object implements X509TrustManager {\n+    public PermissiveTrustManager() {\n+    }\n+\n+    public void checkClientTrusted(X509Certificate[] chain,\n+            String authType) throws CertificateException {\n+\n+    }\n+\n+    public void checkServerTrusted(X509Certificate[] chain,\n+            String authType) throws CertificateException {\n+    }\n+\n+    public X509Certificate[] getAcceptedIssuers() {\n+        return new X509Certificate[0];\n+    }\n+}","path":"src/test/java/com/microsoft/sqlserver/jdbc/CustomTrustManager/PermissiveTrustManager.java","position":28,"original_position":28,"commit_id":"d6808917fef06e5bed54235a199b1784ccdf9eef","original_commit_id":"d6808917fef06e5bed54235a199b1784ccdf9eef","user":{"login":"sehrope","id":1690926,"avatar_url":"https://avatars3.githubusercontent.com/u/1690926?v=4","gravatar_id":"","url":"https://api.github.com/users/sehrope","html_url":"https://github.com/sehrope","followers_url":"https://api.github.com/users/sehrope/followers","following_url":"https://api.github.com/users/sehrope/following{/other_user}","gists_url":"https://api.github.com/users/sehrope/gists{/gist_id}","starred_url":"https://api.github.com/users/sehrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sehrope/subscriptions","organizations_url":"https://api.github.com/users/sehrope/orgs","repos_url":"https://api.github.com/users/sehrope/repos","events_url":"https://api.github.com/users/sehrope/events{/privacy}","received_events_url":"https://api.github.com/users/sehrope/received_events","type":"User","site_admin":false},"body":"Missing newline.","created_at":"2017-08-31T21:42:19Z","updated_at":"2017-08-31T21:49:18Z","html_url":"https://github.com/sehrope/mssql-jdbc/pull/1#discussion_r136456130","pull_request_url":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/1","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/comments/136456130"},"html":{"href":"https://github.com/sehrope/mssql-jdbc/pull/1#discussion_r136456130"},"pull_request":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/1","id":138771970,"html_url":"https://github.com/sehrope/mssql-jdbc/pull/1","diff_url":"https://github.com/sehrope/mssql-jdbc/pull/1.diff","patch_url":"https://github.com/sehrope/mssql-jdbc/pull/1.patch","issue_url":"https://api.github.com/repos/sehrope/mssql-jdbc/issues/1","number":1,"state":"open","locked":false,"title":"Adding a few simple tests to verify the newly added connection properties","user":{"login":"ulvii","id":22036901,"avatar_url":"https://avatars3.githubusercontent.com/u/22036901?v=4","gravatar_id":"","url":"https://api.github.com/users/ulvii","html_url":"https://github.com/ulvii","followers_url":"https://api.github.com/users/ulvii/followers","following_url":"https://api.github.com/users/ulvii/following{/other_user}","gists_url":"https://api.github.com/users/ulvii/gists{/gist_id}","starred_url":"https://api.github.com/users/ulvii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulvii/subscriptions","organizations_url":"https://api.github.com/users/ulvii/orgs","repos_url":"https://api.github.com/users/ulvii/repos","events_url":"https://api.github.com/users/ulvii/events{/privacy}","received_events_url":"https://api.github.com/users/ulvii/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-31T21:36:59Z","updated_at":"2017-08-31T21:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"608533aa4edea26942cc09b907aca3d8f85034dc","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/1/commits","review_comments_url":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/1/comments","review_comment_url":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sehrope/mssql-jdbc/issues/1/comments","statuses_url":"https://api.github.com/repos/sehrope/mssql-jdbc/statuses/d6808917fef06e5bed54235a199b1784ccdf9eef","head":{"label":"ulvii:customTM","ref":"customTM","sha":"d6808917fef06e5bed54235a199b1784ccdf9eef","user":{"login":"ulvii","id":22036901,"avatar_url":"https://avatars3.githubusercontent.com/u/22036901?v=4","gravatar_id":"","url":"https://api.github.com/users/ulvii","html_url":"https://github.com/ulvii","followers_url":"https://api.github.com/users/ulvii/followers","following_url":"https://api.github.com/users/ulvii/following{/other_user}","gists_url":"https://api.github.com/users/ulvii/gists{/gist_id}","starred_url":"https://api.github.com/users/ulvii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulvii/subscriptions","organizations_url":"https://api.github.com/users/ulvii/orgs","repos_url":"https://api.github.com/users/ulvii/repos","events_url":"https://api.github.com/users/ulvii/events{/privacy}","received_events_url":"https://api.github.com/users/ulvii/received_events","type":"User","site_admin":false},"repo":{"id":97525193,"name":"mssql-jdbc","full_name":"ulvii/mssql-jdbc","owner":{"login":"ulvii","id":22036901,"avatar_url":"https://avatars3.githubusercontent.com/u/22036901?v=4","gravatar_id":"","url":"https://api.github.com/users/ulvii","html_url":"https://github.com/ulvii","followers_url":"https://api.github.com/users/ulvii/followers","following_url":"https://api.github.com/users/ulvii/following{/other_user}","gists_url":"https://api.github.com/users/ulvii/gists{/gist_id}","starred_url":"https://api.github.com/users/ulvii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulvii/subscriptions","organizations_url":"https://api.github.com/users/ulvii/orgs","repos_url":"https://api.github.com/users/ulvii/repos","events_url":"https://api.github.com/users/ulvii/events{/privacy}","received_events_url":"https://api.github.com/users/ulvii/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ulvii/mssql-jdbc","description":"The Microsoft JDBC Driver for SQL Server is a Type 4 JDBC driver that provides database connectivity with SQL Server through the standard JDBC application program interfaces (APIs).","fork":true,"url":"https://api.github.com/repos/ulvii/mssql-jdbc","forks_url":"https://api.github.com/repos/ulvii/mssql-jdbc/forks","keys_url":"https://api.github.com/repos/ulvii/mssql-jdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ulvii/mssql-jdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ulvii/mssql-jdbc/teams","hooks_url":"https://api.github.com/repos/ulvii/mssql-jdbc/hooks","issue_events_url":"https://api.github.com/repos/ulvii/mssql-jdbc/issues/events{/number}","events_url":"https://api.github.com/repos/ulvii/mssql-jdbc/events","assignees_url":"https://api.github.com/repos/ulvii/mssql-jdbc/assignees{/user}","branches_url":"https://api.github.com/repos/ulvii/mssql-jdbc/branches{/branch}","tags_url":"https://api.github.com/repos/ulvii/mssql-jdbc/tags","blobs_url":"https://api.github.com/repos/ulvii/mssql-jdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ulvii/mssql-jdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ulvii/mssql-jdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ulvii/mssql-jdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ulvii/mssql-jdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/ulvii/mssql-jdbc/languages","stargazers_url":"https://api.github.com/repos/ulvii/mssql-jdbc/stargazers","contributors_url":"https://api.github.com/repos/ulvii/mssql-jdbc/contributors","subscribers_url":"https://api.github.com/repos/ulvii/mssql-jdbc/subscribers","subscription_url":"https://api.github.com/repos/ulvii/mssql-jdbc/subscription","commits_url":"https://api.github.com/repos/ulvii/mssql-jdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ulvii/mssql-jdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ulvii/mssql-jdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ulvii/mssql-jdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ulvii/mssql-jdbc/contents/{+path}","compare_url":"https://api.github.com/repos/ulvii/mssql-jdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ulvii/mssql-jdbc/merges","archive_url":"https://api.github.com/repos/ulvii/mssql-jdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ulvii/mssql-jdbc/downloads","issues_url":"https://api.github.com/repos/ulvii/mssql-jdbc/issues{/number}","pulls_url":"https://api.github.com/repos/ulvii/mssql-jdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/ulvii/mssql-jdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/ulvii/mssql-jdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ulvii/mssql-jdbc/labels{/name}","releases_url":"https://api.github.com/repos/ulvii/mssql-jdbc/releases{/id}","deployments_url":"https://api.github.com/repos/ulvii/mssql-jdbc/deployments","created_at":"2017-07-17T21:47:33Z","updated_at":"2017-07-17T21:47:35Z","pushed_at":"2017-08-31T21:29:31Z","git_url":"git://github.com/ulvii/mssql-jdbc.git","ssh_url":"git@github.com:ulvii/mssql-jdbc.git","clone_url":"https://github.com/ulvii/mssql-jdbc.git","svn_url":"https://github.com/ulvii/mssql-jdbc","homepage":null,"size":4000,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sehrope:custom-trust-manager","ref":"custom-trust-manager","sha":"5f4100eebea72a42cdd0fc30a90ac9e186f47d49","user":{"login":"sehrope","id":1690926,"avatar_url":"https://avatars3.githubusercontent.com/u/1690926?v=4","gravatar_id":"","url":"https://api.github.com/users/sehrope","html_url":"https://github.com/sehrope","followers_url":"https://api.github.com/users/sehrope/followers","following_url":"https://api.github.com/users/sehrope/following{/other_user}","gists_url":"https://api.github.com/users/sehrope/gists{/gist_id}","starred_url":"https://api.github.com/users/sehrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sehrope/subscriptions","organizations_url":"https://api.github.com/users/sehrope/orgs","repos_url":"https://api.github.com/users/sehrope/repos","events_url":"https://api.github.com/users/sehrope/events{/privacy}","received_events_url":"https://api.github.com/users/sehrope/received_events","type":"User","site_admin":false},"repo":{"id":75764679,"name":"mssql-jdbc","full_name":"sehrope/mssql-jdbc","owner":{"login":"sehrope","id":1690926,"avatar_url":"https://avatars3.githubusercontent.com/u/1690926?v=4","gravatar_id":"","url":"https://api.github.com/users/sehrope","html_url":"https://github.com/sehrope","followers_url":"https://api.github.com/users/sehrope/followers","following_url":"https://api.github.com/users/sehrope/following{/other_user}","gists_url":"https://api.github.com/users/sehrope/gists{/gist_id}","starred_url":"https://api.github.com/users/sehrope/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sehrope/subscriptions","organizations_url":"https://api.github.com/users/sehrope/orgs","repos_url":"https://api.github.com/users/sehrope/repos","events_url":"https://api.github.com/users/sehrope/events{/privacy}","received_events_url":"https://api.github.com/users/sehrope/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sehrope/mssql-jdbc","description":"The Microsoft JDBC Driver for SQL Server is a Type 4 JDBC driver that provides database connectivity with SQL Server through the standard JDBC application program interfaces (APIs).","fork":true,"url":"https://api.github.com/repos/sehrope/mssql-jdbc","forks_url":"https://api.github.com/repos/sehrope/mssql-jdbc/forks","keys_url":"https://api.github.com/repos/sehrope/mssql-jdbc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sehrope/mssql-jdbc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sehrope/mssql-jdbc/teams","hooks_url":"https://api.github.com/repos/sehrope/mssql-jdbc/hooks","issue_events_url":"https://api.github.com/repos/sehrope/mssql-jdbc/issues/events{/number}","events_url":"https://api.github.com/repos/sehrope/mssql-jdbc/events","assignees_url":"https://api.github.com/repos/sehrope/mssql-jdbc/assignees{/user}","branches_url":"https://api.github.com/repos/sehrope/mssql-jdbc/branches{/branch}","tags_url":"https://api.github.com/repos/sehrope/mssql-jdbc/tags","blobs_url":"https://api.github.com/repos/sehrope/mssql-jdbc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sehrope/mssql-jdbc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sehrope/mssql-jdbc/git/refs{/sha}","trees_url":"https://api.github.com/repos/sehrope/mssql-jdbc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sehrope/mssql-jdbc/statuses/{sha}","languages_url":"https://api.github.com/repos/sehrope/mssql-jdbc/languages","stargazers_url":"https://api.github.com/repos/sehrope/mssql-jdbc/stargazers","contributors_url":"https://api.github.com/repos/sehrope/mssql-jdbc/contributors","subscribers_url":"https://api.github.com/repos/sehrope/mssql-jdbc/subscribers","subscription_url":"https://api.github.com/repos/sehrope/mssql-jdbc/subscription","commits_url":"https://api.github.com/repos/sehrope/mssql-jdbc/commits{/sha}","git_commits_url":"https://api.github.com/repos/sehrope/mssql-jdbc/git/commits{/sha}","comments_url":"https://api.github.com/repos/sehrope/mssql-jdbc/comments{/number}","issue_comment_url":"https://api.github.com/repos/sehrope/mssql-jdbc/issues/comments{/number}","contents_url":"https://api.github.com/repos/sehrope/mssql-jdbc/contents/{+path}","compare_url":"https://api.github.com/repos/sehrope/mssql-jdbc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sehrope/mssql-jdbc/merges","archive_url":"https://api.github.com/repos/sehrope/mssql-jdbc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sehrope/mssql-jdbc/downloads","issues_url":"https://api.github.com/repos/sehrope/mssql-jdbc/issues{/number}","pulls_url":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls{/number}","milestones_url":"https://api.github.com/repos/sehrope/mssql-jdbc/milestones{/number}","notifications_url":"https://api.github.com/repos/sehrope/mssql-jdbc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sehrope/mssql-jdbc/labels{/name}","releases_url":"https://api.github.com/repos/sehrope/mssql-jdbc/releases{/id}","deployments_url":"https://api.github.com/repos/sehrope/mssql-jdbc/deployments","created_at":"2016-12-06T19:37:19Z","updated_at":"2016-12-06T19:37:20Z","pushed_at":"2017-08-31T21:36:59Z","git_url":"git://github.com/sehrope/mssql-jdbc.git","ssh_url":"git@github.com:sehrope/mssql-jdbc.git","clone_url":"https://github.com/sehrope/mssql-jdbc.git","svn_url":"https://github.com/sehrope/mssql-jdbc","homepage":null,"size":2351,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/1"},"html":{"href":"https://github.com/sehrope/mssql-jdbc/pull/1"},"issue":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/issues/1"},"comments":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/sehrope/mssql-jdbc/statuses/d6808917fef06e5bed54235a199b1784ccdf9eef"}},"author_association":"NONE"}}
{"actor":{"display_login":"sehrope"}}