{"action":"created","comment":{"url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments/150491875","pull_request_review_id":76046868,"id":150491875,"diff_hunk":"@@ -10,14 +10,14 @@ Param (\n $NugetVersion       = \"4.4.0\"\n $UseExperimental    = $false\n $RootDir            = \"${PSScriptRoot}\"\n-$ScriptFile         = \"${RootDir}/build.cake\"\n-$BuildDir           = \"${RootDir}/_build\"\n-$ToolsDir           = \"${BuildDir}/tools\"\n-$PackagesDir        = \"${BuildDir}/lib/nuget\"\n-$NugetExe           = \"${ToolsDir}/NuGet/${NugetVersion}/nuget.exe\"\n-$PackagesConfigFile = \"${RootDir}/packages.config\"\n+$ScriptFile         = \"${RootDir}\\build.cake\"\n+$BuildDir           = \"${RootDir}\\_build\"\n+$ToolsDir           = \"${BuildDir}\\tools\"\n+$PackagesDir        = \"${BuildDir}\\lib\\nuget\"\n+$NugetExe           = \"${ToolsDir}\\NuGet\\${NugetVersion}\\nuget.exe\"\n+$PackagesConfigFile = \"${RootDir}\\packages.config\"\n $CakeVersion        = (Select-Xml -Xml ([xml](Get-Content $PackagesConfigFile)) -XPath \"//package[@id='Cake'][1]/@version\").Node.Value\n-$CakeExe            = \"${PackagesDir}/Cake.${CakeVersion}/Cake.exe\"\n+$CakeExe            = \"${PackagesDir}\\Cake.${CakeVersion}\\Cake.exe\"\n ","path":"build.ps1","position":19,"original_position":19,"commit_id":"449b94de2f7662804a3b2636569d0aba9983162b","original_commit_id":"449b94de2f7662804a3b2636569d0aba9983162b","user":{"login":"politas","id":2109967,"avatar_url":"https://avatars1.githubusercontent.com/u/2109967?v=4","gravatar_id":"","url":"https://api.github.com/users/politas","html_url":"https://github.com/politas","followers_url":"https://api.github.com/users/politas/followers","following_url":"https://api.github.com/users/politas/following{/other_user}","gists_url":"https://api.github.com/users/politas/gists{/gist_id}","starred_url":"https://api.github.com/users/politas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/politas/subscriptions","organizations_url":"https://api.github.com/users/politas/orgs","repos_url":"https://api.github.com/users/politas/repos","events_url":"https://api.github.com/users/politas/events{/privacy}","received_events_url":"https://api.github.com/users/politas/received_events","type":"User","site_admin":false},"body":"Since Windows is fine with the forward slashes, but Linux treats them as escape characters, it makes sense to me to use forward slashes to make the two build scripts easy to keep in sync. Is there a particular reason to switch to backslashes other than \"that's how Windows users see paths?\"","created_at":"2017-11-13T10:03:38Z","updated_at":"2017-11-13T10:03:57Z","html_url":"https://github.com/KSP-CKAN/CKAN/pull/2182#discussion_r150491875","pull_request_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2182","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments/150491875"},"html":{"href":"https://github.com/KSP-CKAN/CKAN/pull/2182#discussion_r150491875"},"pull_request":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2182"}}},"pull_request":{"url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2182","id":152026873,"html_url":"https://github.com/KSP-CKAN/CKAN/pull/2182","diff_url":"https://github.com/KSP-CKAN/CKAN/pull/2182.diff","patch_url":"https://github.com/KSP-CKAN/CKAN/pull/2182.patch","issue_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2182","number":2182,"state":"open","locked":false,"title":"Cleanup project","user":{"login":"Olympic1","id":8020752,"avatar_url":"https://avatars1.githubusercontent.com/u/8020752?v=4","gravatar_id":"","url":"https://api.github.com/users/Olympic1","html_url":"https://github.com/Olympic1","followers_url":"https://api.github.com/users/Olympic1/followers","following_url":"https://api.github.com/users/Olympic1/following{/other_user}","gists_url":"https://api.github.com/users/Olympic1/gists{/gist_id}","starred_url":"https://api.github.com/users/Olympic1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olympic1/subscriptions","organizations_url":"https://api.github.com/users/Olympic1/orgs","repos_url":"https://api.github.com/users/Olympic1/repos","events_url":"https://api.github.com/users/Olympic1/events{/privacy}","received_events_url":"https://api.github.com/users/Olympic1/received_events","type":"User","site_admin":false},"body":"Cleaned up the repo by removing unused references. Also fixed the paths in the powershell build script.\r\n\r\nI need some feedback on the powershell build script.\r\n\r\n**Changes:**\r\n* Removed remaining `.gitattributes` and `.gitignore` files, so we use the global ones\r\n* Removed a pattern in `.gitattributes`\r\n* Formatted `App.config`'s\r\n* Updated `ToolsVersion` to 15.0\r\n* Updated to `MSBuildToolsPath`, as `MSBuildBinPath` was deprecated\r\n* Sorted `Include`'s alphabetically\r\n* AutoUpdate\r\n    * Renamed `LICENSE` to `LICENSE.md`\r\n    * Removed `log4net`\r\n    * Removed `Newtonsoft.Json`\r\n    * Removed `Microsoft.CSharp`\r\n* CmdLine\r\n    * Updated `CommandLineParser` to 1.9.71.2 (now uses .NET 4.5)\r\n* Core\r\n    * Updated `TxFileManager` to use .NET 4.5\r\n    * Updated `SharpZipLib` to 0.86.5.1\r\n    * Removed `CommandLine`\r\n    * Removed `ChinhDo.Transactions.FileManager`\r\n    * Removed some `System.*` references\r\n* GUI\r\n    * Added target back in that were previously removed\r\n    * Removed `Microsoft.CSharp`\r\n    * Removed some `System.*` references\r\n    * Removed duplicate references\r\n    * Removed `userInstalled` tag, as this was deprecated 2 years ago\r\n* NetKAN\r\n    * Updated `SharpZipLib` to 0.86.5.1\r\n* Tests\r\n    * Updated `SharpZipLib` to 0.86.5.1\r\n    * Updated `Moq` to 4.7.145\r\n    * Updated `NUnit` to 3.9.0\r\n    * Removed `System.Configuration`\r\n    * Removed references that don't exist anymore\r\n    * Added some missing references\r\n* Fixed included `.version` files\r\n* `build.ps1`: Windows uses `\\` in paths instead of `/`\r\n","created_at":"2017-11-10T23:55:03Z","updated_at":"2017-11-13T10:03:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9aeb379f25c948bcb80b7b65fa37e8e15fa1fae1","assignee":{"login":"Olympic1","id":8020752,"avatar_url":"https://avatars1.githubusercontent.com/u/8020752?v=4","gravatar_id":"","url":"https://api.github.com/users/Olympic1","html_url":"https://github.com/Olympic1","followers_url":"https://api.github.com/users/Olympic1/followers","following_url":"https://api.github.com/users/Olympic1/following{/other_user}","gists_url":"https://api.github.com/users/Olympic1/gists{/gist_id}","starred_url":"https://api.github.com/users/Olympic1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olympic1/subscriptions","organizations_url":"https://api.github.com/users/Olympic1/orgs","repos_url":"https://api.github.com/users/Olympic1/repos","events_url":"https://api.github.com/users/Olympic1/events{/privacy}","received_events_url":"https://api.github.com/users/Olympic1/received_events","type":"User","site_admin":false},"assignees":[{"login":"Olympic1","id":8020752,"avatar_url":"https://avatars1.githubusercontent.com/u/8020752?v=4","gravatar_id":"","url":"https://api.github.com/users/Olympic1","html_url":"https://github.com/Olympic1","followers_url":"https://api.github.com/users/Olympic1/followers","following_url":"https://api.github.com/users/Olympic1/following{/other_user}","gists_url":"https://api.github.com/users/Olympic1/gists{/gist_id}","starred_url":"https://api.github.com/users/Olympic1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olympic1/subscriptions","organizations_url":"https://api.github.com/users/Olympic1/orgs","repos_url":"https://api.github.com/users/Olympic1/repos","events_url":"https://api.github.com/users/Olympic1/events{/privacy}","received_events_url":"https://api.github.com/users/Olympic1/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"dbent","id":1547727,"avatar_url":"https://avatars3.githubusercontent.com/u/1547727?v=4","gravatar_id":"","url":"https://api.github.com/users/dbent","html_url":"https://github.com/dbent","followers_url":"https://api.github.com/users/dbent/followers","following_url":"https://api.github.com/users/dbent/following{/other_user}","gists_url":"https://api.github.com/users/dbent/gists{/gist_id}","starred_url":"https://api.github.com/users/dbent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbent/subscriptions","organizations_url":"https://api.github.com/users/dbent/orgs","repos_url":"https://api.github.com/users/dbent/repos","events_url":"https://api.github.com/users/dbent/events{/privacy}","received_events_url":"https://api.github.com/users/dbent/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2182/commits","review_comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2182/comments","review_comment_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments{/number}","comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2182/comments","statuses_url":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/449b94de2f7662804a3b2636569d0aba9983162b","head":{"label":"Olympic1:Cleanup","ref":"Cleanup","sha":"449b94de2f7662804a3b2636569d0aba9983162b","user":{"login":"Olympic1","id":8020752,"avatar_url":"https://avatars1.githubusercontent.com/u/8020752?v=4","gravatar_id":"","url":"https://api.github.com/users/Olympic1","html_url":"https://github.com/Olympic1","followers_url":"https://api.github.com/users/Olympic1/followers","following_url":"https://api.github.com/users/Olympic1/following{/other_user}","gists_url":"https://api.github.com/users/Olympic1/gists{/gist_id}","starred_url":"https://api.github.com/users/Olympic1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olympic1/subscriptions","organizations_url":"https://api.github.com/users/Olympic1/orgs","repos_url":"https://api.github.com/users/Olympic1/repos","events_url":"https://api.github.com/users/Olympic1/events{/privacy}","received_events_url":"https://api.github.com/users/Olympic1/received_events","type":"User","site_admin":false},"repo":{"id":52618438,"name":"CKAN","full_name":"Olympic1/CKAN","owner":{"login":"Olympic1","id":8020752,"avatar_url":"https://avatars1.githubusercontent.com/u/8020752?v=4","gravatar_id":"","url":"https://api.github.com/users/Olympic1","html_url":"https://github.com/Olympic1","followers_url":"https://api.github.com/users/Olympic1/followers","following_url":"https://api.github.com/users/Olympic1/following{/other_user}","gists_url":"https://api.github.com/users/Olympic1/gists{/gist_id}","starred_url":"https://api.github.com/users/Olympic1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olympic1/subscriptions","organizations_url":"https://api.github.com/users/Olympic1/orgs","repos_url":"https://api.github.com/users/Olympic1/repos","events_url":"https://api.github.com/users/Olympic1/events{/privacy}","received_events_url":"https://api.github.com/users/Olympic1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Olympic1/CKAN","description":"The Comprehensive Kerbal Archive Network","fork":true,"url":"https://api.github.com/repos/Olympic1/CKAN","forks_url":"https://api.github.com/repos/Olympic1/CKAN/forks","keys_url":"https://api.github.com/repos/Olympic1/CKAN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Olympic1/CKAN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Olympic1/CKAN/teams","hooks_url":"https://api.github.com/repos/Olympic1/CKAN/hooks","issue_events_url":"https://api.github.com/repos/Olympic1/CKAN/issues/events{/number}","events_url":"https://api.github.com/repos/Olympic1/CKAN/events","assignees_url":"https://api.github.com/repos/Olympic1/CKAN/assignees{/user}","branches_url":"https://api.github.com/repos/Olympic1/CKAN/branches{/branch}","tags_url":"https://api.github.com/repos/Olympic1/CKAN/tags","blobs_url":"https://api.github.com/repos/Olympic1/CKAN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Olympic1/CKAN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Olympic1/CKAN/git/refs{/sha}","trees_url":"https://api.github.com/repos/Olympic1/CKAN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Olympic1/CKAN/statuses/{sha}","languages_url":"https://api.github.com/repos/Olympic1/CKAN/languages","stargazers_url":"https://api.github.com/repos/Olympic1/CKAN/stargazers","contributors_url":"https://api.github.com/repos/Olympic1/CKAN/contributors","subscribers_url":"https://api.github.com/repos/Olympic1/CKAN/subscribers","subscription_url":"https://api.github.com/repos/Olympic1/CKAN/subscription","commits_url":"https://api.github.com/repos/Olympic1/CKAN/commits{/sha}","git_commits_url":"https://api.github.com/repos/Olympic1/CKAN/git/commits{/sha}","comments_url":"https://api.github.com/repos/Olympic1/CKAN/comments{/number}","issue_comment_url":"https://api.github.com/repos/Olympic1/CKAN/issues/comments{/number}","contents_url":"https://api.github.com/repos/Olympic1/CKAN/contents/{+path}","compare_url":"https://api.github.com/repos/Olympic1/CKAN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Olympic1/CKAN/merges","archive_url":"https://api.github.com/repos/Olympic1/CKAN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Olympic1/CKAN/downloads","issues_url":"https://api.github.com/repos/Olympic1/CKAN/issues{/number}","pulls_url":"https://api.github.com/repos/Olympic1/CKAN/pulls{/number}","milestones_url":"https://api.github.com/repos/Olympic1/CKAN/milestones{/number}","notifications_url":"https://api.github.com/repos/Olympic1/CKAN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Olympic1/CKAN/labels{/name}","releases_url":"https://api.github.com/repos/Olympic1/CKAN/releases{/id}","deployments_url":"https://api.github.com/repos/Olympic1/CKAN/deployments","created_at":"2016-02-26T16:46:46Z","updated_at":"2017-10-15T22:50:10Z","pushed_at":"2017-11-13T01:47:46Z","git_url":"git://github.com/Olympic1/CKAN.git","ssh_url":"git@github.com:Olympic1/CKAN.git","clone_url":"https://github.com/Olympic1/CKAN.git","svn_url":"https://github.com/Olympic1/CKAN","homepage":"","size":24765,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"KSP-CKAN:master","ref":"master","sha":"bcdcdccf08b0377fb79fdc45e1b74392f73f4a0d","user":{"login":"KSP-CKAN","id":9023970,"avatar_url":"https://avatars0.githubusercontent.com/u/9023970?v=4","gravatar_id":"","url":"https://api.github.com/users/KSP-CKAN","html_url":"https://github.com/KSP-CKAN","followers_url":"https://api.github.com/users/KSP-CKAN/followers","following_url":"https://api.github.com/users/KSP-CKAN/following{/other_user}","gists_url":"https://api.github.com/users/KSP-CKAN/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-CKAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-CKAN/subscriptions","organizations_url":"https://api.github.com/users/KSP-CKAN/orgs","repos_url":"https://api.github.com/users/KSP-CKAN/repos","events_url":"https://api.github.com/users/KSP-CKAN/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-CKAN/received_events","type":"Organization","site_admin":false},"repo":{"id":23050594,"name":"CKAN","full_name":"KSP-CKAN/CKAN","owner":{"login":"KSP-CKAN","id":9023970,"avatar_url":"https://avatars0.githubusercontent.com/u/9023970?v=4","gravatar_id":"","url":"https://api.github.com/users/KSP-CKAN","html_url":"https://github.com/KSP-CKAN","followers_url":"https://api.github.com/users/KSP-CKAN/followers","following_url":"https://api.github.com/users/KSP-CKAN/following{/other_user}","gists_url":"https://api.github.com/users/KSP-CKAN/gists{/gist_id}","starred_url":"https://api.github.com/users/KSP-CKAN/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KSP-CKAN/subscriptions","organizations_url":"https://api.github.com/users/KSP-CKAN/orgs","repos_url":"https://api.github.com/users/KSP-CKAN/repos","events_url":"https://api.github.com/users/KSP-CKAN/events{/privacy}","received_events_url":"https://api.github.com/users/KSP-CKAN/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/KSP-CKAN/CKAN","description":"The Comprehensive Kerbal Archive Network","fork":false,"url":"https://api.github.com/repos/KSP-CKAN/CKAN","forks_url":"https://api.github.com/repos/KSP-CKAN/CKAN/forks","keys_url":"https://api.github.com/repos/KSP-CKAN/CKAN/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KSP-CKAN/CKAN/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KSP-CKAN/CKAN/teams","hooks_url":"https://api.github.com/repos/KSP-CKAN/CKAN/hooks","issue_events_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/events{/number}","events_url":"https://api.github.com/repos/KSP-CKAN/CKAN/events","assignees_url":"https://api.github.com/repos/KSP-CKAN/CKAN/assignees{/user}","branches_url":"https://api.github.com/repos/KSP-CKAN/CKAN/branches{/branch}","tags_url":"https://api.github.com/repos/KSP-CKAN/CKAN/tags","blobs_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/refs{/sha}","trees_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/{sha}","languages_url":"https://api.github.com/repos/KSP-CKAN/CKAN/languages","stargazers_url":"https://api.github.com/repos/KSP-CKAN/CKAN/stargazers","contributors_url":"https://api.github.com/repos/KSP-CKAN/CKAN/contributors","subscribers_url":"https://api.github.com/repos/KSP-CKAN/CKAN/subscribers","subscription_url":"https://api.github.com/repos/KSP-CKAN/CKAN/subscription","commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/commits{/sha}","git_commits_url":"https://api.github.com/repos/KSP-CKAN/CKAN/git/commits{/sha}","comments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/comments{/number}","issue_comment_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/comments{/number}","contents_url":"https://api.github.com/repos/KSP-CKAN/CKAN/contents/{+path}","compare_url":"https://api.github.com/repos/KSP-CKAN/CKAN/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KSP-CKAN/CKAN/merges","archive_url":"https://api.github.com/repos/KSP-CKAN/CKAN/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KSP-CKAN/CKAN/downloads","issues_url":"https://api.github.com/repos/KSP-CKAN/CKAN/issues{/number}","pulls_url":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls{/number}","milestones_url":"https://api.github.com/repos/KSP-CKAN/CKAN/milestones{/number}","notifications_url":"https://api.github.com/repos/KSP-CKAN/CKAN/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KSP-CKAN/CKAN/labels{/name}","releases_url":"https://api.github.com/repos/KSP-CKAN/CKAN/releases{/id}","deployments_url":"https://api.github.com/repos/KSP-CKAN/CKAN/deployments","created_at":"2014-08-17T21:11:54Z","updated_at":"2017-11-12T10:11:43Z","pushed_at":"2017-11-13T01:33:44Z","git_url":"git://github.com/KSP-CKAN/CKAN.git","ssh_url":"git@github.com:KSP-CKAN/CKAN.git","clone_url":"https://github.com/KSP-CKAN/CKAN.git","svn_url":"https://github.com/KSP-CKAN/CKAN","homepage":"http://forum.kerbalspaceprogram.com/index.php?/topic/154922-ckan","size":24759,"stargazers_count":597,"watchers_count":597,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":185,"mirror_url":null,"archived":false,"open_issues_count":281,"forks":185,"open_issues":281,"watchers":597,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2182"},"html":{"href":"https://github.com/KSP-CKAN/CKAN/pull/2182"},"issue":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2182"},"comments":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/issues/2182/comments"},"review_comments":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2182/comments"},"review_comment":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/pulls/2182/commits"},"statuses":{"href":"https://api.github.com/repos/KSP-CKAN/CKAN/statuses/449b94de2f7662804a3b2636569d0aba9983162b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"politas"}}