{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/106904718","pull_request_review_id":27847671,"id":106904718,"diff_hunk":"@@ -0,0 +1,476 @@\n+﻿namespace Microsoft.VisualStudio.FSharp.Editor\n+\n+open System\n+open System.Collections.Generic\n+open Microsoft.FSharp.Compiler\n+open Microsoft.FSharp.Compiler.Ast\n+open Microsoft.FSharp.Compiler.SourceCodeServices\n+open Microsoft.FSharp.Compiler.Range\n+\n+type RawOpenDeclaration =\n+    { Idents: Idents\n+      Parent: Idents option }\n+\n+type OpenDeclWithAutoOpens =\n+    { Declarations: Idents list\n+      Parent: Idents option\n+      IsUsed: bool }\n+\n+[<NoComparison>]\n+type internal OpenDeclaration =\n+    { Declarations: OpenDeclWithAutoOpens list\n+      DeclarationRange: Range.range\n+      ScopeRange: Range.range\n+      IsUsed: bool }\n+\n+[<CompilationRepresentation (CompilationRepresentationFlags.ModuleSuffix)>]\n+module OpenDeclWithAutoOpens =\n+    let updateBySymbolPrefix (symbolPrefix: Idents) (decl: OpenDeclWithAutoOpens) =\n+        let matched = decl.Declarations |> List.exists (Array.areEqual symbolPrefix)\n+        //if not decl.IsUsed && matched then debug \"OpenDeclarationWithAutoOpens %A is used by %A\" decl symbolPrefix\n+        matched, { decl with IsUsed = decl.IsUsed || matched }\n+\n+[<CompilationRepresentation (CompilationRepresentationFlags.ModuleSuffix)>]\n+module internal OpenDeclaration =\n+    let updateBySymbolPrefix (symbolPrefix: Idents) (decl: OpenDeclaration) =\n+        let decls =\n+            decl.Declarations \n+            |> List.map (OpenDeclWithAutoOpens.updateBySymbolPrefix symbolPrefix)\n+        let matched = decls |> List.exists fst\n+        let isUsed = decls |> List.exists (fun (_, decl) -> decl.IsUsed)\n+        //if not decl.IsUsed && isUsed then debug \"OpenDeclaration %A is used by %A\" decl symbolPrefix\n+        matched, { decl with Declarations = decls |> List.map snd; IsUsed = isUsed }\n+\n+module internal OpenDeclarationGetter =\n+    open System \n+    open System.Diagnostics\n+\n+    let private getAutoOpenModules entities =","path":"vsintegration/src/FSharp.Editor/Common/OpenDeclarationsGetter.fs","position":48,"original_position":48,"commit_id":"8011f05bfac3b30bb642c6a69a93e81d555d0cdf","original_commit_id":"8011f05bfac3b30bb642c6a69a93e81d555d0cdf","user":{"login":"dsyme","id":7204669,"avatar_url":"https://avatars2.githubusercontent.com/u/7204669?v=3","gravatar_id":"","url":"https://api.github.com/users/dsyme","html_url":"https://github.com/dsyme","followers_url":"https://api.github.com/users/dsyme/followers","following_url":"https://api.github.com/users/dsyme/following{/other_user}","gists_url":"https://api.github.com/users/dsyme/gists{/gist_id}","starred_url":"https://api.github.com/users/dsyme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsyme/subscriptions","organizations_url":"https://api.github.com/users/dsyme/orgs","repos_url":"https://api.github.com/users/dsyme/repos","events_url":"https://api.github.com/users/dsyme/events{/privacy}","received_events_url":"https://api.github.com/users/dsyme/received_events","type":"User","site_admin":false},"body":"Please try to make sure every new top-level function, module and type definition added to the codebase has a `///` comment.  (I'm seeing a huge amount of code flowing into the codebase in recent PRs that isn't following this - so it's a general comment for all contributors)","created_at":"2017-03-20T13:51:24Z","updated_at":"2017-03-20T13:51:25Z","html_url":"https://github.com/Microsoft/visualfsharp/pull/2658#discussion_r106904718","pull_request_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2658","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments/106904718"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/2658#discussion_r106904718"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2658"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2658","id":111436115,"html_url":"https://github.com/Microsoft/visualfsharp/pull/2658","diff_url":"https://github.com/Microsoft/visualfsharp/pull/2658.diff","patch_url":"https://github.com/Microsoft/visualfsharp/pull/2658.patch","issue_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2658","number":2658,"state":"open","locked":false,"title":"[WIP] GotoDefinition Generates Metadata Signature File For External Symbols","user":{"login":"cloudRoutine","id":680051,"avatar_url":"https://avatars0.githubusercontent.com/u/680051?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudRoutine","html_url":"https://github.com/cloudRoutine","followers_url":"https://api.github.com/users/cloudRoutine/followers","following_url":"https://api.github.com/users/cloudRoutine/following{/other_user}","gists_url":"https://api.github.com/users/cloudRoutine/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudRoutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudRoutine/subscriptions","organizations_url":"https://api.github.com/users/cloudRoutine/orgs","repos_url":"https://api.github.com/users/cloudRoutine/repos","events_url":"https://api.github.com/users/cloudRoutine/events{/privacy}","received_events_url":"https://api.github.com/users/cloudRoutine/received_events","type":"User","site_admin":false},"body":"Only one readonly window will open to show signature metadata, I tried a bunch of different ways to make it a preview/provisional texteditor, but nothing panned out.\r\n\r\n![](http://i.imgur.com/hQx7vKf.png)","created_at":"2017-03-19T04:00:48Z","updated_at":"2017-03-20T13:51:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57a495b254a9eeb8c73664f4d54f4767bac87ce5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2658/commits","review_comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2658/comments","review_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2658/comments","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/8011f05bfac3b30bb642c6a69a93e81d555d0cdf","head":{"label":"cloudRoutine:signature-metadata-nav","ref":"signature-metadata-nav","sha":"8011f05bfac3b30bb642c6a69a93e81d555d0cdf","user":{"login":"cloudRoutine","id":680051,"avatar_url":"https://avatars0.githubusercontent.com/u/680051?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudRoutine","html_url":"https://github.com/cloudRoutine","followers_url":"https://api.github.com/users/cloudRoutine/followers","following_url":"https://api.github.com/users/cloudRoutine/following{/other_user}","gists_url":"https://api.github.com/users/cloudRoutine/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudRoutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudRoutine/subscriptions","organizations_url":"https://api.github.com/users/cloudRoutine/orgs","repos_url":"https://api.github.com/users/cloudRoutine/repos","events_url":"https://api.github.com/users/cloudRoutine/events{/privacy}","received_events_url":"https://api.github.com/users/cloudRoutine/received_events","type":"User","site_admin":false},"repo":{"id":71214255,"name":"visualfsharp","full_name":"cloudRoutine/visualfsharp","owner":{"login":"cloudRoutine","id":680051,"avatar_url":"https://avatars0.githubusercontent.com/u/680051?v=3","gravatar_id":"","url":"https://api.github.com/users/cloudRoutine","html_url":"https://github.com/cloudRoutine","followers_url":"https://api.github.com/users/cloudRoutine/followers","following_url":"https://api.github.com/users/cloudRoutine/following{/other_user}","gists_url":"https://api.github.com/users/cloudRoutine/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudRoutine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudRoutine/subscriptions","organizations_url":"https://api.github.com/users/cloudRoutine/orgs","repos_url":"https://api.github.com/users/cloudRoutine/repos","events_url":"https://api.github.com/users/cloudRoutine/events{/privacy}","received_events_url":"https://api.github.com/users/cloudRoutine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cloudRoutine/visualfsharp","description":"The Visual F# compiler and tools","fork":true,"url":"https://api.github.com/repos/cloudRoutine/visualfsharp","forks_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/forks","keys_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/teams","hooks_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/events","assignees_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/tags","blobs_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/subscription","commits_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/merges","archive_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/downloads","issues_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/cloudRoutine/visualfsharp/deployments","created_at":"2016-10-18T06:04:16Z","updated_at":"2016-10-18T06:04:27Z","pushed_at":"2017-03-20T04:17:23Z","git_url":"git://github.com/cloudRoutine/visualfsharp.git","ssh_url":"git@github.com:cloudRoutine/visualfsharp.git","clone_url":"https://github.com/cloudRoutine/visualfsharp.git","svn_url":"https://github.com/cloudRoutine/visualfsharp","homepage":null,"size":86331,"stargazers_count":0,"watchers_count":0,"language":"F#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"be7a935d396ec177924936d27f2acf56e621c8a9","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":29048891,"name":"visualfsharp","full_name":"Microsoft/visualfsharp","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/visualfsharp","description":"The Visual F# compiler and tools","fork":false,"url":"https://api.github.com/repos/Microsoft/visualfsharp","forks_url":"https://api.github.com/repos/Microsoft/visualfsharp/forks","keys_url":"https://api.github.com/repos/Microsoft/visualfsharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/visualfsharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/visualfsharp/teams","hooks_url":"https://api.github.com/repos/Microsoft/visualfsharp/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/visualfsharp/events","assignees_url":"https://api.github.com/repos/Microsoft/visualfsharp/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/visualfsharp/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/tags","blobs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/visualfsharp/languages","stargazers_url":"https://api.github.com/repos/Microsoft/visualfsharp/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/visualfsharp/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/visualfsharp/subscription","commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/visualfsharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/visualfsharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/visualfsharp/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/visualfsharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/visualfsharp/merges","archive_url":"https://api.github.com/repos/Microsoft/visualfsharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/visualfsharp/downloads","issues_url":"https://api.github.com/repos/Microsoft/visualfsharp/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/visualfsharp/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/visualfsharp/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/visualfsharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/visualfsharp/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/visualfsharp/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/visualfsharp/deployments","created_at":"2015-01-10T05:58:43Z","updated_at":"2017-03-20T03:11:37Z","pushed_at":"2017-03-20T09:07:37Z","git_url":"git://github.com/Microsoft/visualfsharp.git","ssh_url":"git@github.com:Microsoft/visualfsharp.git","clone_url":"https://github.com/Microsoft/visualfsharp.git","svn_url":"https://github.com/Microsoft/visualfsharp","homepage":null,"size":85676,"stargazers_count":960,"watchers_count":960,"language":"F#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":246,"mirror_url":null,"open_issues_count":391,"forks":246,"open_issues":391,"watchers":960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2658"},"html":{"href":"https://github.com/Microsoft/visualfsharp/pull/2658"},"issue":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2658"},"comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/issues/2658/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2658/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/pulls/2658/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/visualfsharp/statuses/8011f05bfac3b30bb642c6a69a93e81d555d0cdf"}}}}
{"actor":{"display_login":"dsyme"}}