{"action":"created","comment":{"url":"https://api.github.com/repos/almin/almin/pulls/comments/108657061","pull_request_review_id":29700645,"id":108657061,"diff_hunk":"@@ -206,13 +206,15 @@ export class UseCaseExecutor {\n      * Notes: UseCaseExecutor doesn't return resolved value by design\n      * @param args\n      */\n-    execute<R>(...args: Array<any>): Promise<void> {\n+    execute(): Promise<void>;\n+    execute<T>(args: T): Promise<void>;\n+    execute(...args: Array<any>): Promise<void> {","path":"src/UseCaseExecutor.ts","position":7,"original_position":7,"commit_id":"0718a1a465d672f0bf9aabff239df5e6a8425161","original_commit_id":"0718a1a465d672f0bf9aabff239df5e6a8425161","user":{"login":"azu","id":19714,"avatar_url":"https://avatars2.githubusercontent.com/u/19714?v=3","gravatar_id":"","url":"https://api.github.com/users/azu","html_url":"https://github.com/azu","followers_url":"https://api.github.com/users/azu/followers","following_url":"https://api.github.com/users/azu/following{/other_user}","gists_url":"https://api.github.com/users/azu/gists{/gist_id}","starred_url":"https://api.github.com/users/azu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azu/subscriptions","organizations_url":"https://api.github.com/users/azu/orgs","repos_url":"https://api.github.com/users/azu/repos","events_url":"https://api.github.com/users/azu/events{/privacy}","received_events_url":"https://api.github.com/users/azu/received_events","type":"User","site_admin":false},"body":"Thie overloading realize following syntax.\r\n\r\nhttp://bit.ly/2nuoJOr\r\n\r\n```ts\r\n\r\nclass C {\r\n    f(): void;\r\n    f<T>(a: T): void;\r\n    f(...a: Array<any>): void {\r\n        console.log(a);\r\n    }\r\n}\r\nconst c = new C();\r\nc.f(); // ok\r\nc.f<string>(\"test\"); // ok\r\nc.f<string>(); // ng\r\n```","created_at":"2017-03-29T11:57:40Z","updated_at":"2017-03-29T11:57:45Z","html_url":"https://github.com/almin/almin/pull/137#discussion_r108657061","pull_request_url":"https://api.github.com/repos/almin/almin/pulls/137","_links":{"self":{"href":"https://api.github.com/repos/almin/almin/pulls/comments/108657061"},"html":{"href":"https://github.com/almin/almin/pull/137#discussion_r108657061"},"pull_request":{"href":"https://api.github.com/repos/almin/almin/pulls/137"}}},"pull_request":{"url":"https://api.github.com/repos/almin/almin/pulls/137","id":113102195,"html_url":"https://github.com/almin/almin/pull/137","diff_url":"https://github.com/almin/almin/pull/137.diff","patch_url":"https://github.com/almin/almin/pull/137.patch","issue_url":"https://api.github.com/repos/almin/almin/issues/137","number":137,"state":"open","locked":false,"title":"feat(TypeScript): add generic type to Context#useCase<T>","user":{"login":"azu","id":19714,"avatar_url":"https://avatars2.githubusercontent.com/u/19714?v=3","gravatar_id":"","url":"https://api.github.com/users/azu","html_url":"https://github.com/azu","followers_url":"https://api.github.com/users/azu/followers","following_url":"https://api.github.com/users/azu/following{/other_user}","gists_url":"https://api.github.com/users/azu/gists{/gist_id}","starred_url":"https://api.github.com/users/azu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azu/subscriptions","organizations_url":"https://api.github.com/users/azu/orgs","repos_url":"https://api.github.com/users/azu/repos","events_url":"https://api.github.com/users/azu/events{/privacy}","received_events_url":"https://api.github.com/users/azu/received_events","type":"User","site_admin":false},"body":"The user can create UseCase with typed arguments.\r\n\r\n```ts\r\ntype ParentUseCaseArgs = string;\r\nclass ParentUseCase extends UseCase {\r\n    execute(value: ParentUseCaseArgs) {\r\n        return this.context.useCase(new ChildUseCase()).execute(value);\r\n    }\r\n}\r\ncontext.useCase(parentUseCase).execute<ParentUseCaseArgs>(\"arg\").then(() => {\r\n    // do\r\n}).catch((error: Error) => {\r\n    console.error(error);\r\n});\r\n```\r\n\r\nA parts of #107 ","created_at":"2017-03-29T01:44:06Z","updated_at":"2017-03-29T11:57:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54e8dd4f9ab8fd905415292f9e61661f1d0edcf7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/almin/almin/pulls/137/commits","review_comments_url":"https://api.github.com/repos/almin/almin/pulls/137/comments","review_comment_url":"https://api.github.com/repos/almin/almin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/almin/almin/issues/137/comments","statuses_url":"https://api.github.com/repos/almin/almin/statuses/0718a1a465d672f0bf9aabff239df5e6a8425161","head":{"label":"almin:usecase-execute-args-typing","ref":"usecase-execute-args-typing","sha":"0718a1a465d672f0bf9aabff239df5e6a8425161","user":{"login":"almin","id":18663013,"avatar_url":"https://avatars2.githubusercontent.com/u/18663013?v=3","gravatar_id":"","url":"https://api.github.com/users/almin","html_url":"https://github.com/almin","followers_url":"https://api.github.com/users/almin/followers","following_url":"https://api.github.com/users/almin/following{/other_user}","gists_url":"https://api.github.com/users/almin/gists{/gist_id}","starred_url":"https://api.github.com/users/almin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almin/subscriptions","organizations_url":"https://api.github.com/users/almin/orgs","repos_url":"https://api.github.com/users/almin/repos","events_url":"https://api.github.com/users/almin/events{/privacy}","received_events_url":"https://api.github.com/users/almin/received_events","type":"Organization","site_admin":false},"repo":{"id":56744606,"name":"almin","full_name":"almin/almin","owner":{"login":"almin","id":18663013,"avatar_url":"https://avatars2.githubusercontent.com/u/18663013?v=3","gravatar_id":"","url":"https://api.github.com/users/almin","html_url":"https://github.com/almin","followers_url":"https://api.github.com/users/almin/followers","following_url":"https://api.github.com/users/almin/following{/other_user}","gists_url":"https://api.github.com/users/almin/gists{/gist_id}","starred_url":"https://api.github.com/users/almin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almin/subscriptions","organizations_url":"https://api.github.com/users/almin/orgs","repos_url":"https://api.github.com/users/almin/repos","events_url":"https://api.github.com/users/almin/events{/privacy}","received_events_url":"https://api.github.com/users/almin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almin/almin","description":"Almin.js provide Flux/CQRS patterns for JavaScript application","fork":false,"url":"https://api.github.com/repos/almin/almin","forks_url":"https://api.github.com/repos/almin/almin/forks","keys_url":"https://api.github.com/repos/almin/almin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almin/almin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almin/almin/teams","hooks_url":"https://api.github.com/repos/almin/almin/hooks","issue_events_url":"https://api.github.com/repos/almin/almin/issues/events{/number}","events_url":"https://api.github.com/repos/almin/almin/events","assignees_url":"https://api.github.com/repos/almin/almin/assignees{/user}","branches_url":"https://api.github.com/repos/almin/almin/branches{/branch}","tags_url":"https://api.github.com/repos/almin/almin/tags","blobs_url":"https://api.github.com/repos/almin/almin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almin/almin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almin/almin/git/refs{/sha}","trees_url":"https://api.github.com/repos/almin/almin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almin/almin/statuses/{sha}","languages_url":"https://api.github.com/repos/almin/almin/languages","stargazers_url":"https://api.github.com/repos/almin/almin/stargazers","contributors_url":"https://api.github.com/repos/almin/almin/contributors","subscribers_url":"https://api.github.com/repos/almin/almin/subscribers","subscription_url":"https://api.github.com/repos/almin/almin/subscription","commits_url":"https://api.github.com/repos/almin/almin/commits{/sha}","git_commits_url":"https://api.github.com/repos/almin/almin/git/commits{/sha}","comments_url":"https://api.github.com/repos/almin/almin/comments{/number}","issue_comment_url":"https://api.github.com/repos/almin/almin/issues/comments{/number}","contents_url":"https://api.github.com/repos/almin/almin/contents/{+path}","compare_url":"https://api.github.com/repos/almin/almin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almin/almin/merges","archive_url":"https://api.github.com/repos/almin/almin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almin/almin/downloads","issues_url":"https://api.github.com/repos/almin/almin/issues{/number}","pulls_url":"https://api.github.com/repos/almin/almin/pulls{/number}","milestones_url":"https://api.github.com/repos/almin/almin/milestones{/number}","notifications_url":"https://api.github.com/repos/almin/almin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almin/almin/labels{/name}","releases_url":"https://api.github.com/repos/almin/almin/releases{/id}","deployments_url":"https://api.github.com/repos/almin/almin/deployments","created_at":"2016-04-21T05:18:12Z","updated_at":"2017-03-28T06:47:55Z","pushed_at":"2017-03-29T11:22:52Z","git_url":"git://github.com/almin/almin.git","ssh_url":"git@github.com:almin/almin.git","clone_url":"https://github.com/almin/almin.git","svn_url":"https://github.com/almin/almin","homepage":"https://almin.js.org/","size":4929,"stargazers_count":146,"watchers_count":146,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":146,"default_branch":"master"}},"base":{"label":"almin:master","ref":"master","sha":"ec9eebea15944f970f0a717a11e4df56210ce56a","user":{"login":"almin","id":18663013,"avatar_url":"https://avatars2.githubusercontent.com/u/18663013?v=3","gravatar_id":"","url":"https://api.github.com/users/almin","html_url":"https://github.com/almin","followers_url":"https://api.github.com/users/almin/followers","following_url":"https://api.github.com/users/almin/following{/other_user}","gists_url":"https://api.github.com/users/almin/gists{/gist_id}","starred_url":"https://api.github.com/users/almin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almin/subscriptions","organizations_url":"https://api.github.com/users/almin/orgs","repos_url":"https://api.github.com/users/almin/repos","events_url":"https://api.github.com/users/almin/events{/privacy}","received_events_url":"https://api.github.com/users/almin/received_events","type":"Organization","site_admin":false},"repo":{"id":56744606,"name":"almin","full_name":"almin/almin","owner":{"login":"almin","id":18663013,"avatar_url":"https://avatars2.githubusercontent.com/u/18663013?v=3","gravatar_id":"","url":"https://api.github.com/users/almin","html_url":"https://github.com/almin","followers_url":"https://api.github.com/users/almin/followers","following_url":"https://api.github.com/users/almin/following{/other_user}","gists_url":"https://api.github.com/users/almin/gists{/gist_id}","starred_url":"https://api.github.com/users/almin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/almin/subscriptions","organizations_url":"https://api.github.com/users/almin/orgs","repos_url":"https://api.github.com/users/almin/repos","events_url":"https://api.github.com/users/almin/events{/privacy}","received_events_url":"https://api.github.com/users/almin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/almin/almin","description":"Almin.js provide Flux/CQRS patterns for JavaScript application","fork":false,"url":"https://api.github.com/repos/almin/almin","forks_url":"https://api.github.com/repos/almin/almin/forks","keys_url":"https://api.github.com/repos/almin/almin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/almin/almin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/almin/almin/teams","hooks_url":"https://api.github.com/repos/almin/almin/hooks","issue_events_url":"https://api.github.com/repos/almin/almin/issues/events{/number}","events_url":"https://api.github.com/repos/almin/almin/events","assignees_url":"https://api.github.com/repos/almin/almin/assignees{/user}","branches_url":"https://api.github.com/repos/almin/almin/branches{/branch}","tags_url":"https://api.github.com/repos/almin/almin/tags","blobs_url":"https://api.github.com/repos/almin/almin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/almin/almin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/almin/almin/git/refs{/sha}","trees_url":"https://api.github.com/repos/almin/almin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/almin/almin/statuses/{sha}","languages_url":"https://api.github.com/repos/almin/almin/languages","stargazers_url":"https://api.github.com/repos/almin/almin/stargazers","contributors_url":"https://api.github.com/repos/almin/almin/contributors","subscribers_url":"https://api.github.com/repos/almin/almin/subscribers","subscription_url":"https://api.github.com/repos/almin/almin/subscription","commits_url":"https://api.github.com/repos/almin/almin/commits{/sha}","git_commits_url":"https://api.github.com/repos/almin/almin/git/commits{/sha}","comments_url":"https://api.github.com/repos/almin/almin/comments{/number}","issue_comment_url":"https://api.github.com/repos/almin/almin/issues/comments{/number}","contents_url":"https://api.github.com/repos/almin/almin/contents/{+path}","compare_url":"https://api.github.com/repos/almin/almin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/almin/almin/merges","archive_url":"https://api.github.com/repos/almin/almin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/almin/almin/downloads","issues_url":"https://api.github.com/repos/almin/almin/issues{/number}","pulls_url":"https://api.github.com/repos/almin/almin/pulls{/number}","milestones_url":"https://api.github.com/repos/almin/almin/milestones{/number}","notifications_url":"https://api.github.com/repos/almin/almin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/almin/almin/labels{/name}","releases_url":"https://api.github.com/repos/almin/almin/releases{/id}","deployments_url":"https://api.github.com/repos/almin/almin/deployments","created_at":"2016-04-21T05:18:12Z","updated_at":"2017-03-28T06:47:55Z","pushed_at":"2017-03-29T11:22:52Z","git_url":"git://github.com/almin/almin.git","ssh_url":"git@github.com:almin/almin.git","clone_url":"https://github.com/almin/almin.git","svn_url":"https://github.com/almin/almin","homepage":"https://almin.js.org/","size":4929,"stargazers_count":146,"watchers_count":146,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"open_issues_count":13,"forks":8,"open_issues":13,"watchers":146,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/almin/almin/pulls/137"},"html":{"href":"https://github.com/almin/almin/pull/137"},"issue":{"href":"https://api.github.com/repos/almin/almin/issues/137"},"comments":{"href":"https://api.github.com/repos/almin/almin/issues/137/comments"},"review_comments":{"href":"https://api.github.com/repos/almin/almin/pulls/137/comments"},"review_comment":{"href":"https://api.github.com/repos/almin/almin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/almin/almin/pulls/137/commits"},"statuses":{"href":"https://api.github.com/repos/almin/almin/statuses/0718a1a465d672f0bf9aabff239df5e6a8425161"}}}}
{"actor":{"display_login":"azu"}}