{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/136034607","pull_request_review_id":59516662,"id":136034607,"diff_hunk":"@@ -0,0 +1,114 @@\n+'use strict';\n+\n+const { SafeSet, SafePromise } = require('internal/safe_globals');\n+const resolvedPromise = SafePromise.resolve();\n+const resolvedArrayPromise = SafePromise.resolve([]);\n+const { ModuleWrap } = require('internal/loader/ModuleWrap');\n+\n+class ModuleJob {","path":"lib/internal/loader/ModuleJob.js","position":8,"original_position":8,"commit_id":"0abbe2221d4e76370ef59220924309987c3565ff","original_commit_id":"0abbe2221d4e76370ef59220924309987c3565ff","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"body":"Name was used with intentionally abstract intent. It does many things related to loading, is used in the ModuleMap *after* loading, and acts as a task runner similar to other things [in spec](https://tc39.github.io/ecma262/#table-26)","created_at":"2017-08-30T10:49:24Z","updated_at":"2017-08-30T10:49:24Z","html_url":"https://github.com/nodejs/node/pull/14369#discussion_r136034607","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/14369","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/136034607"},"html":{"href":"https://github.com/nodejs/node/pull/14369#discussion_r136034607"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/14369"}},"in_reply_to_id":135923214},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/14369","id":131348383,"html_url":"https://github.com/nodejs/node/pull/14369","diff_url":"https://github.com/nodejs/node/pull/14369.diff","patch_url":"https://github.com/nodejs/node/pull/14369.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/14369","number":14369,"state":"open","locked":false,"title":"module: Allow runMain to be ESM","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"body":"This follows the EPS an allows the node CLI to have ESM as an entry point.\r\n`node ./example.mjs`. A newer V8 is needed for `import()` so that is not\r\nincluded. `import.meta` is still in specification stage so that also is not\r\nincluded.\r\n\r\nAuthor: Bradley Farias <bradley.meck@gmail.com>\r\nAuthor: Guy Bedford <guybedford@gmail.com>\r\nAuthor: Jan Krems <jan.krems@groupon.com>\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [ ] tests and/or benchmarks are included\r\n- [ ] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n","created_at":"2017-07-19T15:17:34Z","updated_at":"2017-08-30T10:49:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9891ac7f026f44a1b7aa2396a36c949869fa148c","assignee":{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars0.githubusercontent.com/u/1093990?v=4","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fishrock123","id":1093990,"avatar_url":"https://avatars0.githubusercontent.com/u/1093990?v=4","gravatar_id":"","url":"https://api.github.com/users/Fishrock123","html_url":"https://github.com/Fishrock123","followers_url":"https://api.github.com/users/Fishrock123/followers","following_url":"https://api.github.com/users/Fishrock123/following{/other_user}","gists_url":"https://api.github.com/users/Fishrock123/gists{/gist_id}","starred_url":"https://api.github.com/users/Fishrock123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fishrock123/subscriptions","organizations_url":"https://api.github.com/users/Fishrock123/orgs","repos_url":"https://api.github.com/users/Fishrock123/repos","events_url":"https://api.github.com/users/Fishrock123/events{/privacy}","received_events_url":"https://api.github.com/users/Fishrock123/received_events","type":"User","site_admin":false},{"login":"TimothyGu","id":1538624,"avatar_url":"https://avatars2.githubusercontent.com/u/1538624?v=4","gravatar_id":"","url":"https://api.github.com/users/TimothyGu","html_url":"https://github.com/TimothyGu","followers_url":"https://api.github.com/users/TimothyGu/followers","following_url":"https://api.github.com/users/TimothyGu/following{/other_user}","gists_url":"https://api.github.com/users/TimothyGu/gists{/gist_id}","starred_url":"https://api.github.com/users/TimothyGu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimothyGu/subscriptions","organizations_url":"https://api.github.com/users/TimothyGu/orgs","repos_url":"https://api.github.com/users/TimothyGu/repos","events_url":"https://api.github.com/users/TimothyGu/events{/privacy}","received_events_url":"https://api.github.com/users/TimothyGu/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"bnoordhuis","id":275871,"avatar_url":"https://avatars0.githubusercontent.com/u/275871?v=4","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/14369/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/14369/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/14369/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/0abbe2221d4e76370ef59220924309987c3565ff","head":{"label":"bmeck:initial-pr","ref":"initial-pr","sha":"0abbe2221d4e76370ef59220924309987c3565ff","user":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"repo":{"id":35897935,"name":"node","full_name":"bmeck/node","owner":{"login":"bmeck","id":234659,"avatar_url":"https://avatars1.githubusercontent.com/u/234659?v=4","gravatar_id":"","url":"https://api.github.com/users/bmeck","html_url":"https://github.com/bmeck","followers_url":"https://api.github.com/users/bmeck/followers","following_url":"https://api.github.com/users/bmeck/following{/other_user}","gists_url":"https://api.github.com/users/bmeck/gists{/gist_id}","starred_url":"https://api.github.com/users/bmeck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bmeck/subscriptions","organizations_url":"https://api.github.com/users/bmeck/orgs","repos_url":"https://api.github.com/users/bmeck/repos","events_url":"https://api.github.com/users/bmeck/events{/privacy}","received_events_url":"https://api.github.com/users/bmeck/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bmeck/node","description":"What should go in this box? https://github.com/nodejs/io.js/issues/1714","fork":true,"url":"https://api.github.com/repos/bmeck/node","forks_url":"https://api.github.com/repos/bmeck/node/forks","keys_url":"https://api.github.com/repos/bmeck/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bmeck/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bmeck/node/teams","hooks_url":"https://api.github.com/repos/bmeck/node/hooks","issue_events_url":"https://api.github.com/repos/bmeck/node/issues/events{/number}","events_url":"https://api.github.com/repos/bmeck/node/events","assignees_url":"https://api.github.com/repos/bmeck/node/assignees{/user}","branches_url":"https://api.github.com/repos/bmeck/node/branches{/branch}","tags_url":"https://api.github.com/repos/bmeck/node/tags","blobs_url":"https://api.github.com/repos/bmeck/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bmeck/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bmeck/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/bmeck/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bmeck/node/statuses/{sha}","languages_url":"https://api.github.com/repos/bmeck/node/languages","stargazers_url":"https://api.github.com/repos/bmeck/node/stargazers","contributors_url":"https://api.github.com/repos/bmeck/node/contributors","subscribers_url":"https://api.github.com/repos/bmeck/node/subscribers","subscription_url":"https://api.github.com/repos/bmeck/node/subscription","commits_url":"https://api.github.com/repos/bmeck/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/bmeck/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/bmeck/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/bmeck/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/bmeck/node/contents/{+path}","compare_url":"https://api.github.com/repos/bmeck/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bmeck/node/merges","archive_url":"https://api.github.com/repos/bmeck/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bmeck/node/downloads","issues_url":"https://api.github.com/repos/bmeck/node/issues{/number}","pulls_url":"https://api.github.com/repos/bmeck/node/pulls{/number}","milestones_url":"https://api.github.com/repos/bmeck/node/milestones{/number}","notifications_url":"https://api.github.com/repos/bmeck/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bmeck/node/labels{/name}","releases_url":"https://api.github.com/repos/bmeck/node/releases{/id}","deployments_url":"https://api.github.com/repos/bmeck/node/deployments","created_at":"2015-05-19T17:35:11Z","updated_at":"2015-08-22T18:38:45Z","pushed_at":"2017-08-24T22:27:37Z","git_url":"git://github.com/bmeck/node.git","ssh_url":"git@github.com:bmeck/node.git","clone_url":"https://github.com/bmeck/node.git","svn_url":"https://github.com/bmeck/node","homepage":"https://iojs.org","size":280971,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"3eb029794c61e013c236e70e99ff659f6ea0826a","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-08-30T10:40:36Z","pushed_at":"2017-08-30T10:10:59Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":309207,"stargazers_count":38722,"watchers_count":38722,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7730,"mirror_url":null,"open_issues_count":798,"forks":7730,"open_issues":798,"watchers":38722,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/14369"},"html":{"href":"https://github.com/nodejs/node/pull/14369"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/14369"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/14369/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/14369/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/14369/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/0abbe2221d4e76370ef59220924309987c3565ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bmeck"}}