{"action":"closed","number":391,"pull_request":{"url":"https://api.github.com/repos/getgrav/grav-learn/pulls/391","id":106296107,"html_url":"https://github.com/getgrav/grav-learn/pull/391","diff_url":"https://github.com/getgrav/grav-learn/pull/391.diff","patch_url":"https://github.com/getgrav/grav-learn/pull/391.patch","issue_url":"https://api.github.com/repos/getgrav/grav-learn/issues/391","number":391,"state":"closed","locked":false,"title":"Clarified the second example under Field Ordering","user":{"login":"OvidiuS","id":160977,"avatar_url":"https://avatars.githubusercontent.com/u/160977?v=3","gravatar_id":"","url":"https://api.github.com/users/OvidiuS","html_url":"https://github.com/OvidiuS","followers_url":"https://api.github.com/users/OvidiuS/followers","following_url":"https://api.github.com/users/OvidiuS/following{/other_user}","gists_url":"https://api.github.com/users/OvidiuS/gists{/gist_id}","starred_url":"https://api.github.com/users/OvidiuS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OvidiuS/subscriptions","organizations_url":"https://api.github.com/users/OvidiuS/orgs","repos_url":"https://api.github.com/users/OvidiuS/repos","events_url":"https://api.github.com/users/OvidiuS/events{/privacy}","received_events_url":"https://api.github.com/users/OvidiuS/received_events","type":"User","site_admin":false},"body":"Some new users might not notice that the example doesn't refer to a page blueprint (it defines a new field called `author`, not `header.author`). So they might try (as I did) to order a field in a page blueprint by doing `order@: title` instead of `order@: header.title`, which doesn't work.\r\nI added a notice that helps draw attention to this.\r\n\r\nChanges proposed in this pull request:\r\n - add a notice under the second example of ordering pages, that clarifies that the example doesn't refer to a page blueprint and shows how to correctly order fields in a page blueprint.\r\n\r\nHow to test this code:\r\n - read the docs page at [https://learn.getgrav.org/forms/blueprints/advanced-features#changing-field-ordering](https://learn.getgrav.org/forms/blueprints/advanced-features#changing-field-ordering)\r\n\r\nHas been tested on (remove any that don't apply):\r\n - Grav 1.10\r\n - Ubuntu 14 and above\r\n","created_at":"2017-02-15T11:59:41Z","updated_at":"2017-02-16T09:00:40Z","closed_at":"2017-02-16T09:00:40Z","merged_at":"2017-02-16T09:00:40Z","merge_commit_sha":"d9f1fb689a81af65c71daef2d0a6ff71d2fff277","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/getgrav/grav-learn/pulls/391/commits","review_comments_url":"https://api.github.com/repos/getgrav/grav-learn/pulls/391/comments","review_comment_url":"https://api.github.com/repos/getgrav/grav-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getgrav/grav-learn/issues/391/comments","statuses_url":"https://api.github.com/repos/getgrav/grav-learn/statuses/d10d2ce9e0b45cc4cfe3e7ec7bdba7be546c70b7","head":{"label":"OvidiuS:patch-1","ref":"patch-1","sha":"d10d2ce9e0b45cc4cfe3e7ec7bdba7be546c70b7","user":{"login":"OvidiuS","id":160977,"avatar_url":"https://avatars.githubusercontent.com/u/160977?v=3","gravatar_id":"","url":"https://api.github.com/users/OvidiuS","html_url":"https://github.com/OvidiuS","followers_url":"https://api.github.com/users/OvidiuS/followers","following_url":"https://api.github.com/users/OvidiuS/following{/other_user}","gists_url":"https://api.github.com/users/OvidiuS/gists{/gist_id}","starred_url":"https://api.github.com/users/OvidiuS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OvidiuS/subscriptions","organizations_url":"https://api.github.com/users/OvidiuS/orgs","repos_url":"https://api.github.com/users/OvidiuS/repos","events_url":"https://api.github.com/users/OvidiuS/events{/privacy}","received_events_url":"https://api.github.com/users/OvidiuS/received_events","type":"User","site_admin":false},"repo":{"id":82055058,"name":"grav-learn","full_name":"OvidiuS/grav-learn","owner":{"login":"OvidiuS","id":160977,"avatar_url":"https://avatars.githubusercontent.com/u/160977?v=3","gravatar_id":"","url":"https://api.github.com/users/OvidiuS","html_url":"https://github.com/OvidiuS","followers_url":"https://api.github.com/users/OvidiuS/followers","following_url":"https://api.github.com/users/OvidiuS/following{/other_user}","gists_url":"https://api.github.com/users/OvidiuS/gists{/gist_id}","starred_url":"https://api.github.com/users/OvidiuS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OvidiuS/subscriptions","organizations_url":"https://api.github.com/users/OvidiuS/orgs","repos_url":"https://api.github.com/users/OvidiuS/repos","events_url":"https://api.github.com/users/OvidiuS/events{/privacy}","received_events_url":"https://api.github.com/users/OvidiuS/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/OvidiuS/grav-learn","description":"Grav Learn (exhaustive grav documentation)","fork":true,"url":"https://api.github.com/repos/OvidiuS/grav-learn","forks_url":"https://api.github.com/repos/OvidiuS/grav-learn/forks","keys_url":"https://api.github.com/repos/OvidiuS/grav-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OvidiuS/grav-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OvidiuS/grav-learn/teams","hooks_url":"https://api.github.com/repos/OvidiuS/grav-learn/hooks","issue_events_url":"https://api.github.com/repos/OvidiuS/grav-learn/issues/events{/number}","events_url":"https://api.github.com/repos/OvidiuS/grav-learn/events","assignees_url":"https://api.github.com/repos/OvidiuS/grav-learn/assignees{/user}","branches_url":"https://api.github.com/repos/OvidiuS/grav-learn/branches{/branch}","tags_url":"https://api.github.com/repos/OvidiuS/grav-learn/tags","blobs_url":"https://api.github.com/repos/OvidiuS/grav-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OvidiuS/grav-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OvidiuS/grav-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/OvidiuS/grav-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OvidiuS/grav-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/OvidiuS/grav-learn/languages","stargazers_url":"https://api.github.com/repos/OvidiuS/grav-learn/stargazers","contributors_url":"https://api.github.com/repos/OvidiuS/grav-learn/contributors","subscribers_url":"https://api.github.com/repos/OvidiuS/grav-learn/subscribers","subscription_url":"https://api.github.com/repos/OvidiuS/grav-learn/subscription","commits_url":"https://api.github.com/repos/OvidiuS/grav-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/OvidiuS/grav-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/OvidiuS/grav-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/OvidiuS/grav-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/OvidiuS/grav-learn/contents/{+path}","compare_url":"https://api.github.com/repos/OvidiuS/grav-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OvidiuS/grav-learn/merges","archive_url":"https://api.github.com/repos/OvidiuS/grav-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OvidiuS/grav-learn/downloads","issues_url":"https://api.github.com/repos/OvidiuS/grav-learn/issues{/number}","pulls_url":"https://api.github.com/repos/OvidiuS/grav-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/OvidiuS/grav-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/OvidiuS/grav-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OvidiuS/grav-learn/labels{/name}","releases_url":"https://api.github.com/repos/OvidiuS/grav-learn/releases{/id}","deployments_url":"https://api.github.com/repos/OvidiuS/grav-learn/deployments","created_at":"2017-02-15T11:47:28Z","updated_at":"2017-02-15T11:47:31Z","pushed_at":"2017-02-16T07:27:21Z","git_url":"git://github.com/OvidiuS/grav-learn.git","ssh_url":"git@github.com:OvidiuS/grav-learn.git","clone_url":"https://github.com/OvidiuS/grav-learn.git","svn_url":"https://github.com/OvidiuS/grav-learn","homepage":"http://learn.getgrav.org","size":38012,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"getgrav:develop","ref":"develop","sha":"b081097881f6fd95388b978a09301a073a7a076d","user":{"login":"getgrav","id":8237355,"avatar_url":"https://avatars.githubusercontent.com/u/8237355?v=3","gravatar_id":"","url":"https://api.github.com/users/getgrav","html_url":"https://github.com/getgrav","followers_url":"https://api.github.com/users/getgrav/followers","following_url":"https://api.github.com/users/getgrav/following{/other_user}","gists_url":"https://api.github.com/users/getgrav/gists{/gist_id}","starred_url":"https://api.github.com/users/getgrav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getgrav/subscriptions","organizations_url":"https://api.github.com/users/getgrav/orgs","repos_url":"https://api.github.com/users/getgrav/repos","events_url":"https://api.github.com/users/getgrav/events{/privacy}","received_events_url":"https://api.github.com/users/getgrav/received_events","type":"Organization","site_admin":false},"repo":{"id":22618145,"name":"grav-learn","full_name":"getgrav/grav-learn","owner":{"login":"getgrav","id":8237355,"avatar_url":"https://avatars.githubusercontent.com/u/8237355?v=3","gravatar_id":"","url":"https://api.github.com/users/getgrav","html_url":"https://github.com/getgrav","followers_url":"https://api.github.com/users/getgrav/followers","following_url":"https://api.github.com/users/getgrav/following{/other_user}","gists_url":"https://api.github.com/users/getgrav/gists{/gist_id}","starred_url":"https://api.github.com/users/getgrav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getgrav/subscriptions","organizations_url":"https://api.github.com/users/getgrav/orgs","repos_url":"https://api.github.com/users/getgrav/repos","events_url":"https://api.github.com/users/getgrav/events{/privacy}","received_events_url":"https://api.github.com/users/getgrav/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getgrav/grav-learn","description":"Grav Learn (exhaustive grav documentation)","fork":false,"url":"https://api.github.com/repos/getgrav/grav-learn","forks_url":"https://api.github.com/repos/getgrav/grav-learn/forks","keys_url":"https://api.github.com/repos/getgrav/grav-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getgrav/grav-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getgrav/grav-learn/teams","hooks_url":"https://api.github.com/repos/getgrav/grav-learn/hooks","issue_events_url":"https://api.github.com/repos/getgrav/grav-learn/issues/events{/number}","events_url":"https://api.github.com/repos/getgrav/grav-learn/events","assignees_url":"https://api.github.com/repos/getgrav/grav-learn/assignees{/user}","branches_url":"https://api.github.com/repos/getgrav/grav-learn/branches{/branch}","tags_url":"https://api.github.com/repos/getgrav/grav-learn/tags","blobs_url":"https://api.github.com/repos/getgrav/grav-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getgrav/grav-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getgrav/grav-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/getgrav/grav-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getgrav/grav-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/getgrav/grav-learn/languages","stargazers_url":"https://api.github.com/repos/getgrav/grav-learn/stargazers","contributors_url":"https://api.github.com/repos/getgrav/grav-learn/contributors","subscribers_url":"https://api.github.com/repos/getgrav/grav-learn/subscribers","subscription_url":"https://api.github.com/repos/getgrav/grav-learn/subscription","commits_url":"https://api.github.com/repos/getgrav/grav-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/getgrav/grav-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/getgrav/grav-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/getgrav/grav-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/getgrav/grav-learn/contents/{+path}","compare_url":"https://api.github.com/repos/getgrav/grav-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getgrav/grav-learn/merges","archive_url":"https://api.github.com/repos/getgrav/grav-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getgrav/grav-learn/downloads","issues_url":"https://api.github.com/repos/getgrav/grav-learn/issues{/number}","pulls_url":"https://api.github.com/repos/getgrav/grav-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/getgrav/grav-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/getgrav/grav-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getgrav/grav-learn/labels{/name}","releases_url":"https://api.github.com/repos/getgrav/grav-learn/releases{/id}","deployments_url":"https://api.github.com/repos/getgrav/grav-learn/deployments","created_at":"2014-08-04T20:05:57Z","updated_at":"2017-02-16T04:13:57Z","pushed_at":"2017-02-16T09:00:40Z","git_url":"git://github.com/getgrav/grav-learn.git","ssh_url":"git@github.com:getgrav/grav-learn.git","clone_url":"https://github.com/getgrav/grav-learn.git","svn_url":"https://github.com/getgrav/grav-learn","homepage":"http://learn.getgrav.org","size":38027,"stargazers_count":98,"watchers_count":98,"language":"CSS","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":311,"mirror_url":null,"open_issues_count":14,"forks":311,"open_issues":14,"watchers":98,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/getgrav/grav-learn/pulls/391"},"html":{"href":"https://github.com/getgrav/grav-learn/pull/391"},"issue":{"href":"https://api.github.com/repos/getgrav/grav-learn/issues/391"},"comments":{"href":"https://api.github.com/repos/getgrav/grav-learn/issues/391/comments"},"review_comments":{"href":"https://api.github.com/repos/getgrav/grav-learn/pulls/391/comments"},"review_comment":{"href":"https://api.github.com/repos/getgrav/grav-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getgrav/grav-learn/pulls/391/commits"},"statuses":{"href":"https://api.github.com/repos/getgrav/grav-learn/statuses/d10d2ce9e0b45cc4cfe3e7ec7bdba7be546c70b7"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"flaviocopes","id":11783388,"avatar_url":"https://avatars.githubusercontent.com/u/11783388?v=3","gravatar_id":"","url":"https://api.github.com/users/flaviocopes","html_url":"https://github.com/flaviocopes","followers_url":"https://api.github.com/users/flaviocopes/followers","following_url":"https://api.github.com/users/flaviocopes/following{/other_user}","gists_url":"https://api.github.com/users/flaviocopes/gists{/gist_id}","starred_url":"https://api.github.com/users/flaviocopes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flaviocopes/subscriptions","organizations_url":"https://api.github.com/users/flaviocopes/orgs","repos_url":"https://api.github.com/users/flaviocopes/repos","events_url":"https://api.github.com/users/flaviocopes/events{/privacy}","received_events_url":"https://api.github.com/users/flaviocopes/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"flaviocopes"}}