{"action":"created","comment":{"url":"https://api.github.com/repos/prestodb/benchto/pulls/comments/108623034","pull_request_review_id":29664125,"id":108623034,"diff_hunk":"@@ -97,12 +96,12 @@ public String getBenchmarksDir()\n \n     public Path benchmarksFilesPath()\n     {\n-        return asPath(getBenchmarksDir());\n+        return Paths.get(getBenchmarksDir());","path":"benchto-driver/src/main/java/com/teradata/benchto/driver/BenchmarkProperties.java","position":38,"original_position":38,"commit_id":"19cd5b961e1d5c2e05480edd93e548526b22f167","original_commit_id":"19cd5b961e1d5c2e05480edd93e548526b22f167","user":{"login":"findepi","id":144328,"avatar_url":"https://avatars3.githubusercontent.com/u/144328?v=3","gravatar_id":"","url":"https://api.github.com/users/findepi","html_url":"https://github.com/findepi","followers_url":"https://api.github.com/users/findepi/followers","following_url":"https://api.github.com/users/findepi/following{/other_user}","gists_url":"https://api.github.com/users/findepi/gists{/gist_id}","starred_url":"https://api.github.com/users/findepi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/findepi/subscriptions","organizations_url":"https://api.github.com/users/findepi/orgs","repos_url":"https://api.github.com/users/findepi/repos","events_url":"https://api.github.com/users/findepi/events{/privacy}","received_events_url":"https://api.github.com/users/findepi/received_events","type":"User","site_admin":false},"body":"I guess you could just declare the `benchmarksDir` field as `Path`. (I didn't check though)","created_at":"2017-03-29T08:51:57Z","updated_at":"2017-03-29T08:53:13Z","html_url":"https://github.com/prestodb/benchto/pull/45#discussion_r108623034","pull_request_url":"https://api.github.com/repos/prestodb/benchto/pulls/45","_links":{"self":{"href":"https://api.github.com/repos/prestodb/benchto/pulls/comments/108623034"},"html":{"href":"https://github.com/prestodb/benchto/pull/45#discussion_r108623034"},"pull_request":{"href":"https://api.github.com/repos/prestodb/benchto/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/prestodb/benchto/pulls/45","id":112969290,"html_url":"https://github.com/prestodb/benchto/pull/45","diff_url":"https://github.com/prestodb/benchto/pull/45.diff","patch_url":"https://github.com/prestodb/benchto/pull/45.patch","issue_url":"https://api.github.com/repos/prestodb/benchto/issues/45","number":45,"state":"open","locked":false,"title":"Remove support for loading benchmarks from classpath","user":{"login":"sopel39","id":5989165,"avatar_url":"https://avatars2.githubusercontent.com/u/5989165?v=3","gravatar_id":"","url":"https://api.github.com/users/sopel39","html_url":"https://github.com/sopel39","followers_url":"https://api.github.com/users/sopel39/followers","following_url":"https://api.github.com/users/sopel39/following{/other_user}","gists_url":"https://api.github.com/users/sopel39/gists{/gist_id}","starred_url":"https://api.github.com/users/sopel39/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sopel39/subscriptions","organizations_url":"https://api.github.com/users/sopel39/orgs","repos_url":"https://api.github.com/users/sopel39/repos","events_url":"https://api.github.com/users/sopel39/events{/privacy}","received_events_url":"https://api.github.com/users/sopel39/received_events","type":"User","site_admin":false},"body":"FYI @idemura ","created_at":"2017-03-28T13:26:13Z","updated_at":"2017-03-29T08:53:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35166d3688e45943e3d3c8ec79d7cc26d858c391","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prestodb/benchto/pulls/45/commits","review_comments_url":"https://api.github.com/repos/prestodb/benchto/pulls/45/comments","review_comment_url":"https://api.github.com/repos/prestodb/benchto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prestodb/benchto/issues/45/comments","statuses_url":"https://api.github.com/repos/prestodb/benchto/statuses/19cd5b961e1d5c2e05480edd93e548526b22f167","head":{"label":"prestodb:remove_classpath_loading","ref":"remove_classpath_loading","sha":"19cd5b961e1d5c2e05480edd93e548526b22f167","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars3.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":62405919,"name":"benchto","full_name":"prestodb/benchto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars3.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/benchto","description":"Framework for running macro benchmarks in a clustered environment","fork":false,"url":"https://api.github.com/repos/prestodb/benchto","forks_url":"https://api.github.com/repos/prestodb/benchto/forks","keys_url":"https://api.github.com/repos/prestodb/benchto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/benchto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/benchto/teams","hooks_url":"https://api.github.com/repos/prestodb/benchto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/benchto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/benchto/events","assignees_url":"https://api.github.com/repos/prestodb/benchto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/benchto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/benchto/tags","blobs_url":"https://api.github.com/repos/prestodb/benchto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/benchto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/benchto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/benchto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/benchto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/benchto/languages","stargazers_url":"https://api.github.com/repos/prestodb/benchto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/benchto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/benchto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/benchto/subscription","commits_url":"https://api.github.com/repos/prestodb/benchto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/benchto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/benchto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/benchto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/benchto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/benchto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/benchto/merges","archive_url":"https://api.github.com/repos/prestodb/benchto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/benchto/downloads","issues_url":"https://api.github.com/repos/prestodb/benchto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/benchto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/benchto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/benchto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/benchto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/benchto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/benchto/deployments","created_at":"2016-07-01T16:25:50Z","updated_at":"2017-03-03T23:17:44Z","pushed_at":"2017-03-28T13:26:14Z","git_url":"git://github.com/prestodb/benchto.git","ssh_url":"git@github.com:prestodb/benchto.git","clone_url":"https://github.com/prestodb/benchto.git","svn_url":"https://github.com/prestodb/benchto","homepage":"","size":3700,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":19,"forks":3,"open_issues":19,"watchers":6,"default_branch":"master"}},"base":{"label":"prestodb:master","ref":"master","sha":"d7459e179cc223d4938de3c3d7c88ba6b3f358e3","user":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars3.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"repo":{"id":62405919,"name":"benchto","full_name":"prestodb/benchto","owner":{"login":"prestodb","id":6882181,"avatar_url":"https://avatars3.githubusercontent.com/u/6882181?v=3","gravatar_id":"","url":"https://api.github.com/users/prestodb","html_url":"https://github.com/prestodb","followers_url":"https://api.github.com/users/prestodb/followers","following_url":"https://api.github.com/users/prestodb/following{/other_user}","gists_url":"https://api.github.com/users/prestodb/gists{/gist_id}","starred_url":"https://api.github.com/users/prestodb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestodb/subscriptions","organizations_url":"https://api.github.com/users/prestodb/orgs","repos_url":"https://api.github.com/users/prestodb/repos","events_url":"https://api.github.com/users/prestodb/events{/privacy}","received_events_url":"https://api.github.com/users/prestodb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/prestodb/benchto","description":"Framework for running macro benchmarks in a clustered environment","fork":false,"url":"https://api.github.com/repos/prestodb/benchto","forks_url":"https://api.github.com/repos/prestodb/benchto/forks","keys_url":"https://api.github.com/repos/prestodb/benchto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prestodb/benchto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prestodb/benchto/teams","hooks_url":"https://api.github.com/repos/prestodb/benchto/hooks","issue_events_url":"https://api.github.com/repos/prestodb/benchto/issues/events{/number}","events_url":"https://api.github.com/repos/prestodb/benchto/events","assignees_url":"https://api.github.com/repos/prestodb/benchto/assignees{/user}","branches_url":"https://api.github.com/repos/prestodb/benchto/branches{/branch}","tags_url":"https://api.github.com/repos/prestodb/benchto/tags","blobs_url":"https://api.github.com/repos/prestodb/benchto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prestodb/benchto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prestodb/benchto/git/refs{/sha}","trees_url":"https://api.github.com/repos/prestodb/benchto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prestodb/benchto/statuses/{sha}","languages_url":"https://api.github.com/repos/prestodb/benchto/languages","stargazers_url":"https://api.github.com/repos/prestodb/benchto/stargazers","contributors_url":"https://api.github.com/repos/prestodb/benchto/contributors","subscribers_url":"https://api.github.com/repos/prestodb/benchto/subscribers","subscription_url":"https://api.github.com/repos/prestodb/benchto/subscription","commits_url":"https://api.github.com/repos/prestodb/benchto/commits{/sha}","git_commits_url":"https://api.github.com/repos/prestodb/benchto/git/commits{/sha}","comments_url":"https://api.github.com/repos/prestodb/benchto/comments{/number}","issue_comment_url":"https://api.github.com/repos/prestodb/benchto/issues/comments{/number}","contents_url":"https://api.github.com/repos/prestodb/benchto/contents/{+path}","compare_url":"https://api.github.com/repos/prestodb/benchto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prestodb/benchto/merges","archive_url":"https://api.github.com/repos/prestodb/benchto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prestodb/benchto/downloads","issues_url":"https://api.github.com/repos/prestodb/benchto/issues{/number}","pulls_url":"https://api.github.com/repos/prestodb/benchto/pulls{/number}","milestones_url":"https://api.github.com/repos/prestodb/benchto/milestones{/number}","notifications_url":"https://api.github.com/repos/prestodb/benchto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prestodb/benchto/labels{/name}","releases_url":"https://api.github.com/repos/prestodb/benchto/releases{/id}","deployments_url":"https://api.github.com/repos/prestodb/benchto/deployments","created_at":"2016-07-01T16:25:50Z","updated_at":"2017-03-03T23:17:44Z","pushed_at":"2017-03-28T13:26:14Z","git_url":"git://github.com/prestodb/benchto.git","ssh_url":"git@github.com:prestodb/benchto.git","clone_url":"https://github.com/prestodb/benchto.git","svn_url":"https://github.com/prestodb/benchto","homepage":"","size":3700,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":19,"forks":3,"open_issues":19,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prestodb/benchto/pulls/45"},"html":{"href":"https://github.com/prestodb/benchto/pull/45"},"issue":{"href":"https://api.github.com/repos/prestodb/benchto/issues/45"},"comments":{"href":"https://api.github.com/repos/prestodb/benchto/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/prestodb/benchto/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/prestodb/benchto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prestodb/benchto/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/prestodb/benchto/statuses/19cd5b961e1d5c2e05480edd93e548526b22f167"}}}}
{"actor":{"display_login":"findepi"}}