{"action":"opened","number":2832,"pull_request":{"url":"https://api.github.com/repos/18F/openFEC/pulls/2832","id":159883013,"html_url":"https://github.com/18F/openFEC/pull/2832","diff_url":"https://github.com/18F/openFEC/pull/2832.diff","patch_url":"https://github.com/18F/openFEC/pull/2832.patch","issue_url":"https://api.github.com/repos/18F/openFEC/issues/2832","number":2832,"state":"open","locked":false,"title":"AO/MUR document permalinks: Use filename instead of document_ID","user":{"login":"lbeaufort","id":31420082,"avatar_url":"https://avatars1.githubusercontent.com/u/31420082?v=4","gravatar_id":"","url":"https://api.github.com/users/lbeaufort","html_url":"https://github.com/lbeaufort","followers_url":"https://api.github.com/users/lbeaufort/followers","following_url":"https://api.github.com/users/lbeaufort/following{/other_user}","gists_url":"https://api.github.com/users/lbeaufort/gists{/gist_id}","starred_url":"https://api.github.com/users/lbeaufort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbeaufort/subscriptions","organizations_url":"https://api.github.com/users/lbeaufort/orgs","repos_url":"https://api.github.com/users/lbeaufort/repos","events_url":"https://api.github.com/users/lbeaufort/events{/privacy}","received_events_url":"https://api.github.com/users/lbeaufort/received_events","type":"User","site_admin":false},"body":"Use filename to create AO, MUR document pdfs instead of ID, ensuring we have permalinks. Add AO/MUR number to URL IE `legal/aos/2017-12/201712C_3.pdf`\r\n\r\nWe'll need to delete PDFs from S3 with old naming conventions.\r\n\r\n- [ ] Manually deploy local branch to `dev` and reload all the AO's and MURs and test the new links - do the ones that have filenames with spaces work or do we have to modify them? Should we just go ahead and replace spaces with \"_\" ? \"-\"? I think dashes might be better, but the new naming convention has underscores in them so underscores might be more consistent:  \"201712C_3.pdf\"\r\n \r\n- [ ] Reload all AOs, MURs with new naming convention in `prod`, `dev`, `stage`\r\n- [ ] Delete all the old, unlinked PDFs from s3 in `prod`, `dev`, `stage`","created_at":"2017-12-22T15:01:34Z","updated_at":"2017-12-22T15:01:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/18F/openFEC/pulls/2832/commits","review_comments_url":"https://api.github.com/repos/18F/openFEC/pulls/2832/comments","review_comment_url":"https://api.github.com/repos/18F/openFEC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/18F/openFEC/issues/2832/comments","statuses_url":"https://api.github.com/repos/18F/openFEC/statuses/16904cc8537f06a149ddb5d72c42a232b977f164","head":{"label":"18F:feature/ao-mur-document-permalinks","ref":"feature/ao-mur-document-permalinks","sha":"16904cc8537f06a149ddb5d72c42a232b977f164","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":23116127,"name":"openFEC","full_name":"18F/openFEC","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/openFEC","description":"The first RESTful API for the Federal Election Commission. We're aiming to make campaign finance more accessible for journalists, academics, developers, and other transparency seekers.","fork":false,"url":"https://api.github.com/repos/18F/openFEC","forks_url":"https://api.github.com/repos/18F/openFEC/forks","keys_url":"https://api.github.com/repos/18F/openFEC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/openFEC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/openFEC/teams","hooks_url":"https://api.github.com/repos/18F/openFEC/hooks","issue_events_url":"https://api.github.com/repos/18F/openFEC/issues/events{/number}","events_url":"https://api.github.com/repos/18F/openFEC/events","assignees_url":"https://api.github.com/repos/18F/openFEC/assignees{/user}","branches_url":"https://api.github.com/repos/18F/openFEC/branches{/branch}","tags_url":"https://api.github.com/repos/18F/openFEC/tags","blobs_url":"https://api.github.com/repos/18F/openFEC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/openFEC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/openFEC/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/openFEC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/openFEC/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/openFEC/languages","stargazers_url":"https://api.github.com/repos/18F/openFEC/stargazers","contributors_url":"https://api.github.com/repos/18F/openFEC/contributors","subscribers_url":"https://api.github.com/repos/18F/openFEC/subscribers","subscription_url":"https://api.github.com/repos/18F/openFEC/subscription","commits_url":"https://api.github.com/repos/18F/openFEC/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/openFEC/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/openFEC/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/openFEC/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/openFEC/contents/{+path}","compare_url":"https://api.github.com/repos/18F/openFEC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/openFEC/merges","archive_url":"https://api.github.com/repos/18F/openFEC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/openFEC/downloads","issues_url":"https://api.github.com/repos/18F/openFEC/issues{/number}","pulls_url":"https://api.github.com/repos/18F/openFEC/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/openFEC/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/openFEC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/openFEC/labels{/name}","releases_url":"https://api.github.com/repos/18F/openFEC/releases{/id}","deployments_url":"https://api.github.com/repos/18F/openFEC/deployments","created_at":"2014-08-19T15:51:14Z","updated_at":"2017-12-14T10:37:14Z","pushed_at":"2017-12-22T15:00:16Z","git_url":"git://github.com/18F/openFEC.git","ssh_url":"git@github.com:18F/openFEC.git","clone_url":"https://github.com/18F/openFEC.git","svn_url":"https://github.com/18F/openFEC","homepage":"https://api.open.fec.gov/developers","size":385231,"stargazers_count":242,"watchers_count":242,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":98,"watchers":242,"default_branch":"develop"}},"base":{"label":"18F:develop","ref":"develop","sha":"79198e277b6daa97cb65cd63fda7b64ead856100","user":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"repo":{"id":23116127,"name":"openFEC","full_name":"18F/openFEC","owner":{"login":"18F","id":6233994,"avatar_url":"https://avatars0.githubusercontent.com/u/6233994?v=4","gravatar_id":"","url":"https://api.github.com/users/18F","html_url":"https://github.com/18F","followers_url":"https://api.github.com/users/18F/followers","following_url":"https://api.github.com/users/18F/following{/other_user}","gists_url":"https://api.github.com/users/18F/gists{/gist_id}","starred_url":"https://api.github.com/users/18F/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/18F/subscriptions","organizations_url":"https://api.github.com/users/18F/orgs","repos_url":"https://api.github.com/users/18F/repos","events_url":"https://api.github.com/users/18F/events{/privacy}","received_events_url":"https://api.github.com/users/18F/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/18F/openFEC","description":"The first RESTful API for the Federal Election Commission. We're aiming to make campaign finance more accessible for journalists, academics, developers, and other transparency seekers.","fork":false,"url":"https://api.github.com/repos/18F/openFEC","forks_url":"https://api.github.com/repos/18F/openFEC/forks","keys_url":"https://api.github.com/repos/18F/openFEC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/18F/openFEC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/18F/openFEC/teams","hooks_url":"https://api.github.com/repos/18F/openFEC/hooks","issue_events_url":"https://api.github.com/repos/18F/openFEC/issues/events{/number}","events_url":"https://api.github.com/repos/18F/openFEC/events","assignees_url":"https://api.github.com/repos/18F/openFEC/assignees{/user}","branches_url":"https://api.github.com/repos/18F/openFEC/branches{/branch}","tags_url":"https://api.github.com/repos/18F/openFEC/tags","blobs_url":"https://api.github.com/repos/18F/openFEC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/18F/openFEC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/18F/openFEC/git/refs{/sha}","trees_url":"https://api.github.com/repos/18F/openFEC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/18F/openFEC/statuses/{sha}","languages_url":"https://api.github.com/repos/18F/openFEC/languages","stargazers_url":"https://api.github.com/repos/18F/openFEC/stargazers","contributors_url":"https://api.github.com/repos/18F/openFEC/contributors","subscribers_url":"https://api.github.com/repos/18F/openFEC/subscribers","subscription_url":"https://api.github.com/repos/18F/openFEC/subscription","commits_url":"https://api.github.com/repos/18F/openFEC/commits{/sha}","git_commits_url":"https://api.github.com/repos/18F/openFEC/git/commits{/sha}","comments_url":"https://api.github.com/repos/18F/openFEC/comments{/number}","issue_comment_url":"https://api.github.com/repos/18F/openFEC/issues/comments{/number}","contents_url":"https://api.github.com/repos/18F/openFEC/contents/{+path}","compare_url":"https://api.github.com/repos/18F/openFEC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/18F/openFEC/merges","archive_url":"https://api.github.com/repos/18F/openFEC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/18F/openFEC/downloads","issues_url":"https://api.github.com/repos/18F/openFEC/issues{/number}","pulls_url":"https://api.github.com/repos/18F/openFEC/pulls{/number}","milestones_url":"https://api.github.com/repos/18F/openFEC/milestones{/number}","notifications_url":"https://api.github.com/repos/18F/openFEC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/18F/openFEC/labels{/name}","releases_url":"https://api.github.com/repos/18F/openFEC/releases{/id}","deployments_url":"https://api.github.com/repos/18F/openFEC/deployments","created_at":"2014-08-19T15:51:14Z","updated_at":"2017-12-14T10:37:14Z","pushed_at":"2017-12-22T15:00:16Z","git_url":"git://github.com/18F/openFEC.git","ssh_url":"git@github.com:18F/openFEC.git","clone_url":"https://github.com/18F/openFEC.git","svn_url":"https://github.com/18F/openFEC","homepage":"https://api.open.fec.gov/developers","size":385231,"stargazers_count":242,"watchers_count":242,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":65,"mirror_url":null,"archived":false,"open_issues_count":98,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":65,"open_issues":98,"watchers":242,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/18F/openFEC/pulls/2832"},"html":{"href":"https://github.com/18F/openFEC/pull/2832"},"issue":{"href":"https://api.github.com/repos/18F/openFEC/issues/2832"},"comments":{"href":"https://api.github.com/repos/18F/openFEC/issues/2832/comments"},"review_comments":{"href":"https://api.github.com/repos/18F/openFEC/pulls/2832/comments"},"review_comment":{"href":"https://api.github.com/repos/18F/openFEC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/18F/openFEC/pulls/2832/commits"},"statuses":{"href":"https://api.github.com/repos/18F/openFEC/statuses/16904cc8537f06a149ddb5d72c42a232b977f164"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":37,"deletions":15,"changed_files":2}}
{"actor":{"display_login":"lbeaufort"}}