{"action":"created","issue":{"url":"https://api.github.com/repos/grasmash/yaml-expander/issues/5","repository_url":"https://api.github.com/repos/grasmash/yaml-expander","labels_url":"https://api.github.com/repos/grasmash/yaml-expander/issues/5/labels{/name}","comments_url":"https://api.github.com/repos/grasmash/yaml-expander/issues/5/comments","events_url":"https://api.github.com/repos/grasmash/yaml-expander/issues/5/events","html_url":"https://github.com/grasmash/yaml-expander/pull/5","id":243492474,"number":5,"title":"Remove symfony/console from 'require' section.","user":{"login":"greg-1-anderson","id":612191,"avatar_url":"https://avatars2.githubusercontent.com/u/612191?v=4","gravatar_id":"","url":"https://api.github.com/users/greg-1-anderson","html_url":"https://github.com/greg-1-anderson","followers_url":"https://api.github.com/users/greg-1-anderson/followers","following_url":"https://api.github.com/users/greg-1-anderson/following{/other_user}","gists_url":"https://api.github.com/users/greg-1-anderson/gists{/gist_id}","starred_url":"https://api.github.com/users/greg-1-anderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greg-1-anderson/subscriptions","organizations_url":"https://api.github.com/users/greg-1-anderson/orgs","repos_url":"https://api.github.com/users/greg-1-anderson/repos","events_url":"https://api.github.com/users/greg-1-anderson/events{/privacy}","received_events_url":"https://api.github.com/users/greg-1-anderson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-07-17T18:56:59Z","updated_at":"2017-07-17T19:00:24Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/grasmash/yaml-expander/pulls/5","html_url":"https://github.com/grasmash/yaml-expander/pull/5","diff_url":"https://github.com/grasmash/yaml-expander/pull/5.diff","patch_url":"https://github.com/grasmash/yaml-expander/pull/5.patch"},"body":"I'm doing some Drush work to use consolidation/config, which uses grasmash/yaml-expander.\r\n\r\nConfig has to be loaded very early in the bootstrap process. For various reasons, I'd like to limit the number of projects touched during this phase of the code.\r\n\r\ngrasmash/yaml-expander declares that it uses symfony/console, when in fact it does not. This PR removes symfony/console from the `require` section. This reduces the number of components loaded when installing with `no-dev`, but it has no affect on the packages loaded when including the require-dev packages, as satooshi/php-coveralls requires symfony/console.\r\n\r\nI don't want to remove satooshi/php-coveralls from grasmash/yaml-expander, of course, but if I remove it on my local system, then symfony/console is removed, and the `phpunit` tests still pass.\r\n\r\nSo, while this PR has no affect on the actual operation of this project, for documentation purposes, I would prefer it if symfony/console were not listed in the `require` section. `require-dev` would be fine, although this is not necessary AFIK due to satooshi/php-coveralls."},"comment":{"url":"https://api.github.com/repos/grasmash/yaml-expander/issues/comments/315849525","html_url":"https://github.com/grasmash/yaml-expander/pull/5#issuecomment-315849525","issue_url":"https://api.github.com/repos/grasmash/yaml-expander/issues/5","id":315849525,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2017-07-17T19:00:23Z","updated_at":"2017-07-17T19:00:23Z","body":"\n[![Coverage Status](https://coveralls.io/builds/12428044/badge)](https://coveralls.io/builds/12428044)\n\nCoverage remained the same at 100.0% when pulling **411574ed0b391d2faa64655da8a1124db816b970 on greg-1-anderson:no-console** into **95f9c876ca31f31bf5bfd9c8e89cc1f065c45528 on grasmash:master**.\n"}}
{"actor":{"display_login":"coveralls"}}