{"action":"created","comment":{"url":"https://api.github.com/repos/twitter/heron/pulls/comments/112564799","pull_request_review_id":33889783,"id":112564799,"diff_hunk":"@@ -135,61 +135,6 @@ proto_library(\n     ],\n )\n \n-java_library(","path":"heron/proto/BUILD","position":4,"original_position":4,"commit_id":"a742a8a2beb0564743a2191635855a6ab1029184","original_commit_id":"a742a8a2beb0564743a2191635855a6ab1029184","user":{"login":"nlu90","id":16407807,"avatar_url":"https://avatars3.githubusercontent.com/u/16407807?v=3","gravatar_id":"","url":"https://api.github.com/users/nlu90","html_url":"https://github.com/nlu90","followers_url":"https://api.github.com/users/nlu90/followers","following_url":"https://api.github.com/users/nlu90/following{/other_user}","gists_url":"https://api.github.com/users/nlu90/gists{/gist_id}","starred_url":"https://api.github.com/users/nlu90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nlu90/subscriptions","organizations_url":"https://api.github.com/users/nlu90/orgs","repos_url":"https://api.github.com/users/nlu90/repos","events_url":"https://api.github.com/users/nlu90/events{/privacy}","received_events_url":"https://api.github.com/users/nlu90/received_events","type":"User","site_admin":false},"body":"why `proto-java` and `proto-java-nl` are deleted?","created_at":"2017-04-20T21:26:37Z","updated_at":"2017-04-20T21:29:49Z","html_url":"https://github.com/twitter/heron/pull/1811#discussion_r112564799","pull_request_url":"https://api.github.com/repos/twitter/heron/pulls/1811","_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments/112564799"},"html":{"href":"https://github.com/twitter/heron/pull/1811#discussion_r112564799"},"pull_request":{"href":"https://api.github.com/repos/twitter/heron/pulls/1811"}}},"pull_request":{"url":"https://api.github.com/repos/twitter/heron/pulls/1811","id":116866575,"html_url":"https://github.com/twitter/heron/pull/1811","diff_url":"https://github.com/twitter/heron/pull/1811.diff","patch_url":"https://github.com/twitter/heron/pull/1811.patch","issue_url":"https://api.github.com/repos/twitter/heron/issues/1811","number":1811,"state":"open","locked":false,"title":"Properly shade + POM heron-api.jar and heron-storm.jar","user":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars3.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"body":"This PR includes multiple fixes, but its major purposes are:\r\n1. properly shade `heron-api.jar` (`//heron/api/src/java:heron-api`) and `heron-storm.jar` (`//heron/storm/src/java:heron-storm`)\r\n2. Kryo dependency will be specified in POM file, instead of being linked into the fatjar\r\n\r\nTo verify Kryo is not linked into these two jars, one can use `jar tf` and `grep` to verify.\r\n\r\nThis two fixes make Twitter internal tests pass when we switch to OSS Heron.\r\n\r\nMinor fixes include:\r\n1. Examples now use `org.apache.storm` instead of `backtype`. The missing `GlobalMetrics` is added under `heron/storm`.\r\n2. `heron-storm.jar` [will only include `org.apache.storm.***`](https://github.com/twitter/heron/compare/master...objmagic:no-fat-jar?expand=1#diff-cf85344880ea3bb51b03100c97fb7a82R23)\r\n3. Removed some unused protobuf build targets.\r\n\r\nSome other notes:\r\n1. Guava dependency is not touched at all. It is linked into jars and is shaded. It is trivial that we can remove Guava dependency from `heron-api.jar`, but this is not the case for `heron-storm.jar`. `heron-storm.jar` depends on Simulator, which further depends on lots of libraries that are using Guava. Thus we decide not to remove Guava.\r\n\r\nAlso attached are `heron-api.jar` and `heron-storm.jar`. Please feel free to use `jar tf` to examine their contents. \r\n\r\n[heron-api-and-heron-storm.zip](https://github.com/twitter/heron/files/945500/heron-api-and-heron-storm.zip)\r\n","created_at":"2017-04-20T21:17:53Z","updated_at":"2017-04-20T21:29:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b31fae18f16543ddcba4698a5fbcc69ed71c4985","assignee":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars3.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"assignees":[{"login":"objmagic","id":3656079,"avatar_url":"https://avatars3.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/twitter/heron/milestones/13","html_url":"https://github.com/twitter/heron/milestone/13","labels_url":"https://api.github.com/repos/twitter/heron/milestones/13/labels","id":2442196,"number":13,"title":"0.14.7","description":"","creator":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars3.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":16,"state":"open","created_at":"2017-04-07T00:01:05Z","updated_at":"2017-04-20T21:17:53Z","due_on":"2017-04-15T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/twitter/heron/pulls/1811/commits","review_comments_url":"https://api.github.com/repos/twitter/heron/pulls/1811/comments","review_comment_url":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}","comments_url":"https://api.github.com/repos/twitter/heron/issues/1811/comments","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/a742a8a2beb0564743a2191635855a6ab1029184","head":{"label":"objmagic:no-fat-jar","ref":"no-fat-jar","sha":"a742a8a2beb0564743a2191635855a6ab1029184","user":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars3.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"repo":{"id":59701078,"name":"heron","full_name":"objmagic/heron","owner":{"login":"objmagic","id":3656079,"avatar_url":"https://avatars3.githubusercontent.com/u/3656079?v=3","gravatar_id":"","url":"https://api.github.com/users/objmagic","html_url":"https://github.com/objmagic","followers_url":"https://api.github.com/users/objmagic/followers","following_url":"https://api.github.com/users/objmagic/following{/other_user}","gists_url":"https://api.github.com/users/objmagic/gists{/gist_id}","starred_url":"https://api.github.com/users/objmagic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/objmagic/subscriptions","organizations_url":"https://api.github.com/users/objmagic/orgs","repos_url":"https://api.github.com/users/objmagic/repos","events_url":"https://api.github.com/users/objmagic/events{/privacy}","received_events_url":"https://api.github.com/users/objmagic/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/objmagic/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":true,"url":"https://api.github.com/repos/objmagic/heron","forks_url":"https://api.github.com/repos/objmagic/heron/forks","keys_url":"https://api.github.com/repos/objmagic/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/objmagic/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/objmagic/heron/teams","hooks_url":"https://api.github.com/repos/objmagic/heron/hooks","issue_events_url":"https://api.github.com/repos/objmagic/heron/issues/events{/number}","events_url":"https://api.github.com/repos/objmagic/heron/events","assignees_url":"https://api.github.com/repos/objmagic/heron/assignees{/user}","branches_url":"https://api.github.com/repos/objmagic/heron/branches{/branch}","tags_url":"https://api.github.com/repos/objmagic/heron/tags","blobs_url":"https://api.github.com/repos/objmagic/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/objmagic/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/objmagic/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/objmagic/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/objmagic/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/objmagic/heron/languages","stargazers_url":"https://api.github.com/repos/objmagic/heron/stargazers","contributors_url":"https://api.github.com/repos/objmagic/heron/contributors","subscribers_url":"https://api.github.com/repos/objmagic/heron/subscribers","subscription_url":"https://api.github.com/repos/objmagic/heron/subscription","commits_url":"https://api.github.com/repos/objmagic/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/objmagic/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/objmagic/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/objmagic/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/objmagic/heron/contents/{+path}","compare_url":"https://api.github.com/repos/objmagic/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/objmagic/heron/merges","archive_url":"https://api.github.com/repos/objmagic/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/objmagic/heron/downloads","issues_url":"https://api.github.com/repos/objmagic/heron/issues{/number}","pulls_url":"https://api.github.com/repos/objmagic/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/objmagic/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/objmagic/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/objmagic/heron/labels{/name}","releases_url":"https://api.github.com/repos/objmagic/heron/releases{/id}","deployments_url":"https://api.github.com/repos/objmagic/heron/deployments","created_at":"2016-05-25T22:08:44Z","updated_at":"2016-09-08T23:53:46Z","pushed_at":"2017-04-20T20:59:08Z","git_url":"git://github.com/objmagic/heron.git","ssh_url":"git@github.com:objmagic/heron.git","clone_url":"https://github.com/objmagic/heron.git","svn_url":"https://github.com/objmagic/heron","homepage":"http://heronstreaming.io","size":121974,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"twitter:master","ref":"master","sha":"21c7bd2cf69d7547abb0878253aa33053a354118","user":{"login":"twitter","id":50278,"avatar_url":"https://avatars2.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"repo":{"id":43158694,"name":"heron","full_name":"twitter/heron","owner":{"login":"twitter","id":50278,"avatar_url":"https://avatars2.githubusercontent.com/u/50278?v=3","gravatar_id":"","url":"https://api.github.com/users/twitter","html_url":"https://github.com/twitter","followers_url":"https://api.github.com/users/twitter/followers","following_url":"https://api.github.com/users/twitter/following{/other_user}","gists_url":"https://api.github.com/users/twitter/gists{/gist_id}","starred_url":"https://api.github.com/users/twitter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twitter/subscriptions","organizations_url":"https://api.github.com/users/twitter/orgs","repos_url":"https://api.github.com/users/twitter/repos","events_url":"https://api.github.com/users/twitter/events{/privacy}","received_events_url":"https://api.github.com/users/twitter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/twitter/heron","description":"Heron is a realtime, distributed, fault-tolerant stream processing engine from Twitter","fork":false,"url":"https://api.github.com/repos/twitter/heron","forks_url":"https://api.github.com/repos/twitter/heron/forks","keys_url":"https://api.github.com/repos/twitter/heron/keys{/key_id}","collaborators_url":"https://api.github.com/repos/twitter/heron/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/twitter/heron/teams","hooks_url":"https://api.github.com/repos/twitter/heron/hooks","issue_events_url":"https://api.github.com/repos/twitter/heron/issues/events{/number}","events_url":"https://api.github.com/repos/twitter/heron/events","assignees_url":"https://api.github.com/repos/twitter/heron/assignees{/user}","branches_url":"https://api.github.com/repos/twitter/heron/branches{/branch}","tags_url":"https://api.github.com/repos/twitter/heron/tags","blobs_url":"https://api.github.com/repos/twitter/heron/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/twitter/heron/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/twitter/heron/git/refs{/sha}","trees_url":"https://api.github.com/repos/twitter/heron/git/trees{/sha}","statuses_url":"https://api.github.com/repos/twitter/heron/statuses/{sha}","languages_url":"https://api.github.com/repos/twitter/heron/languages","stargazers_url":"https://api.github.com/repos/twitter/heron/stargazers","contributors_url":"https://api.github.com/repos/twitter/heron/contributors","subscribers_url":"https://api.github.com/repos/twitter/heron/subscribers","subscription_url":"https://api.github.com/repos/twitter/heron/subscription","commits_url":"https://api.github.com/repos/twitter/heron/commits{/sha}","git_commits_url":"https://api.github.com/repos/twitter/heron/git/commits{/sha}","comments_url":"https://api.github.com/repos/twitter/heron/comments{/number}","issue_comment_url":"https://api.github.com/repos/twitter/heron/issues/comments{/number}","contents_url":"https://api.github.com/repos/twitter/heron/contents/{+path}","compare_url":"https://api.github.com/repos/twitter/heron/compare/{base}...{head}","merges_url":"https://api.github.com/repos/twitter/heron/merges","archive_url":"https://api.github.com/repos/twitter/heron/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/twitter/heron/downloads","issues_url":"https://api.github.com/repos/twitter/heron/issues{/number}","pulls_url":"https://api.github.com/repos/twitter/heron/pulls{/number}","milestones_url":"https://api.github.com/repos/twitter/heron/milestones{/number}","notifications_url":"https://api.github.com/repos/twitter/heron/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/twitter/heron/labels{/name}","releases_url":"https://api.github.com/repos/twitter/heron/releases{/id}","deployments_url":"https://api.github.com/repos/twitter/heron/deployments","created_at":"2015-09-25T16:09:24Z","updated_at":"2017-04-20T10:24:36Z","pushed_at":"2017-04-20T21:17:54Z","git_url":"git://github.com/twitter/heron.git","ssh_url":"git@github.com:twitter/heron.git","clone_url":"https://github.com/twitter/heron.git","svn_url":"https://github.com/twitter/heron","homepage":"http://heronstreaming.io","size":129412,"stargazers_count":2672,"watchers_count":2672,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":467,"mirror_url":null,"open_issues_count":250,"forks":467,"open_issues":250,"watchers":2672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/twitter/heron/pulls/1811"},"html":{"href":"https://github.com/twitter/heron/pull/1811"},"issue":{"href":"https://api.github.com/repos/twitter/heron/issues/1811"},"comments":{"href":"https://api.github.com/repos/twitter/heron/issues/1811/comments"},"review_comments":{"href":"https://api.github.com/repos/twitter/heron/pulls/1811/comments"},"review_comment":{"href":"https://api.github.com/repos/twitter/heron/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/twitter/heron/pulls/1811/commits"},"statuses":{"href":"https://api.github.com/repos/twitter/heron/statuses/a742a8a2beb0564743a2191635855a6ab1029184"}}}}
{"actor":{"display_login":"nlu90"}}