{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/comments/131545374","pull_request_review_id":54537439,"id":131545374,"diff_hunk":"@@ -111,6 +161,55 @@ export class FileDataSource implements IDataSource {\n \t\t}\n \t}\n \n+\tprivate resolveVirtualDirectories(files: FileStat[]) {\n+\t\tif (!this.enableVirtualDirectories) {","path":"src/vs/workbench/parts/files/browser/views/explorerViewer.ts","position":97,"original_position":97,"commit_id":"2e45c4564aab23e6b1feab4888e207cfdc14d46a","original_commit_id":"2e45c4564aab23e6b1feab4888e207cfdc14d46a","user":{"login":"jayoungers","id":6578515,"avatar_url":"https://avatars2.githubusercontent.com/u/6578515?v=4","gravatar_id":"","url":"https://api.github.com/users/jayoungers","html_url":"https://github.com/jayoungers","followers_url":"https://api.github.com/users/jayoungers/followers","following_url":"https://api.github.com/users/jayoungers/following{/other_user}","gists_url":"https://api.github.com/users/jayoungers/gists{/gist_id}","starred_url":"https://api.github.com/users/jayoungers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jayoungers/subscriptions","organizations_url":"https://api.github.com/users/jayoungers/orgs","repos_url":"https://api.github.com/users/jayoungers/repos","events_url":"https://api.github.com/users/jayoungers/events{/privacy}","received_events_url":"https://api.github.com/users/jayoungers/received_events","type":"User","site_admin":false},"body":"Based on the previous comment, this wouldn't be needed since it's already checked; however, we'd need a way to check to see if we've already done the calculations on this folder or not","created_at":"2017-08-06T15:15:45Z","updated_at":"2017-08-06T15:35:40Z","html_url":"https://github.com/Microsoft/vscode/pull/32061#discussion_r131545374","pull_request_url":"https://api.github.com/repos/Microsoft/vscode/pulls/32061","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/comments/131545374"},"html":{"href":"https://github.com/Microsoft/vscode/pull/32061#discussion_r131545374"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/32061"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/32061","id":134317563,"html_url":"https://github.com/Microsoft/vscode/pull/32061","diff_url":"https://github.com/Microsoft/vscode/pull/32061.diff","patch_url":"https://github.com/Microsoft/vscode/pull/32061.patch","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/32061","number":32061,"state":"open","locked":false,"title":"Feature/file nesting","user":{"login":"firelizzard18","id":879055,"avatar_url":"https://avatars2.githubusercontent.com/u/879055?v=4","gravatar_id":"","url":"https://api.github.com/users/firelizzard18","html_url":"https://github.com/firelizzard18","followers_url":"https://api.github.com/users/firelizzard18/followers","following_url":"https://api.github.com/users/firelizzard18/following{/other_user}","gists_url":"https://api.github.com/users/firelizzard18/gists{/gist_id}","starred_url":"https://api.github.com/users/firelizzard18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firelizzard18/subscriptions","organizations_url":"https://api.github.com/users/firelizzard18/orgs","repos_url":"https://api.github.com/users/firelizzard18/repos","events_url":"https://api.github.com/users/firelizzard18/events{/privacy}","received_events_url":"https://api.github.com/users/firelizzard18/received_events","type":"User","site_admin":false},"body":"Based on #13754.\r\n\r\nFile nesting operates based on the rules defined in `files.nesting.rules`, similar to `files.exclude`. The rule names are globs. If a file matches a glob, `$(basename)` and `$(ext)` in the `when` value or values. Any files that match the resulting glob are nested under the original file.\r\n\r\n**I am looking for advice** on how to properly handle the tree model. Without modifications to `src/vs/base/parts/tree/browser/treeModel.ts`, file nesting breaks VSCode with errors about items already having been registered. With modifications, it mostly works but has some buggy behavior.\r\n\r\n### Nesting `.dockerignore` under `Dockerfile`\r\n\r\n```json\r\n{\r\n    \"Dockerfile\": { \"when\": \".dockerignore\" }\r\n}\r\n```\r\n\r\n### Nesting `module.js`, `module.ts, `module.css`, etc under `module.html`\r\n\r\n```json\r\n{\r\n    \"*.html\": { \"when\": [\r\n        \"$(basename).js\",\r\n        \"$(basename).ts\",\r\n        \"$(basename).css\"\r\n    ] }\r\n}\r\n```\r\n\r\n### Nesting `module.sub.ext` under `module.ext`\r\n\r\n```json\r\n{\r\n    \"*\": { \"when\": \"$(basename).*.$(ext)\" }\r\n}\r\n```\r\n\r\n### Nesting `module.ext.sub` under `module.ext`\r\n\r\n```json\r\n{\r\n    \"*\": { \"when\": \"$(basename).$(ext).*\" }\r\n}\r\n```\r\n\r\n### Disabling a rule\r\n\r\n```json\r\n{\r\n    \"*.html\": false\r\n}\r\n```\r\n","created_at":"2017-08-06T07:38:03Z","updated_at":"2017-08-06T15:35:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5412282149526ec2119996593d7b9655aaf58a1c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/vscode/pulls/32061/commits","review_comments_url":"https://api.github.com/repos/Microsoft/vscode/pulls/32061/comments","review_comment_url":"https://api.github.com/repos/Microsoft/vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/32061/comments","statuses_url":"https://api.github.com/repos/Microsoft/vscode/statuses/2e45c4564aab23e6b1feab4888e207cfdc14d46a","head":{"label":"firelizzard18:feature/file-nesting","ref":"feature/file-nesting","sha":"2e45c4564aab23e6b1feab4888e207cfdc14d46a","user":{"login":"firelizzard18","id":879055,"avatar_url":"https://avatars2.githubusercontent.com/u/879055?v=4","gravatar_id":"","url":"https://api.github.com/users/firelizzard18","html_url":"https://github.com/firelizzard18","followers_url":"https://api.github.com/users/firelizzard18/followers","following_url":"https://api.github.com/users/firelizzard18/following{/other_user}","gists_url":"https://api.github.com/users/firelizzard18/gists{/gist_id}","starred_url":"https://api.github.com/users/firelizzard18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firelizzard18/subscriptions","organizations_url":"https://api.github.com/users/firelizzard18/orgs","repos_url":"https://api.github.com/users/firelizzard18/repos","events_url":"https://api.github.com/users/firelizzard18/events{/privacy}","received_events_url":"https://api.github.com/users/firelizzard18/received_events","type":"User","site_admin":false},"repo":{"id":97352532,"name":"vscode","full_name":"firelizzard18/vscode","owner":{"login":"firelizzard18","id":879055,"avatar_url":"https://avatars2.githubusercontent.com/u/879055?v=4","gravatar_id":"","url":"https://api.github.com/users/firelizzard18","html_url":"https://github.com/firelizzard18","followers_url":"https://api.github.com/users/firelizzard18/followers","following_url":"https://api.github.com/users/firelizzard18/following{/other_user}","gists_url":"https://api.github.com/users/firelizzard18/gists{/gist_id}","starred_url":"https://api.github.com/users/firelizzard18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firelizzard18/subscriptions","organizations_url":"https://api.github.com/users/firelizzard18/orgs","repos_url":"https://api.github.com/users/firelizzard18/repos","events_url":"https://api.github.com/users/firelizzard18/events{/privacy}","received_events_url":"https://api.github.com/users/firelizzard18/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/firelizzard18/vscode","description":"Visual Studio Code","fork":true,"url":"https://api.github.com/repos/firelizzard18/vscode","forks_url":"https://api.github.com/repos/firelizzard18/vscode/forks","keys_url":"https://api.github.com/repos/firelizzard18/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firelizzard18/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firelizzard18/vscode/teams","hooks_url":"https://api.github.com/repos/firelizzard18/vscode/hooks","issue_events_url":"https://api.github.com/repos/firelizzard18/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/firelizzard18/vscode/events","assignees_url":"https://api.github.com/repos/firelizzard18/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/firelizzard18/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/firelizzard18/vscode/tags","blobs_url":"https://api.github.com/repos/firelizzard18/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firelizzard18/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firelizzard18/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/firelizzard18/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firelizzard18/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/firelizzard18/vscode/languages","stargazers_url":"https://api.github.com/repos/firelizzard18/vscode/stargazers","contributors_url":"https://api.github.com/repos/firelizzard18/vscode/contributors","subscribers_url":"https://api.github.com/repos/firelizzard18/vscode/subscribers","subscription_url":"https://api.github.com/repos/firelizzard18/vscode/subscription","commits_url":"https://api.github.com/repos/firelizzard18/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/firelizzard18/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/firelizzard18/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/firelizzard18/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/firelizzard18/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/firelizzard18/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firelizzard18/vscode/merges","archive_url":"https://api.github.com/repos/firelizzard18/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firelizzard18/vscode/downloads","issues_url":"https://api.github.com/repos/firelizzard18/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/firelizzard18/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/firelizzard18/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/firelizzard18/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firelizzard18/vscode/labels{/name}","releases_url":"https://api.github.com/repos/firelizzard18/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/firelizzard18/vscode/deployments","created_at":"2017-07-16T01:36:58Z","updated_at":"2017-07-16T01:37:16Z","pushed_at":"2017-08-06T07:31:20Z","git_url":"git://github.com/firelizzard18/vscode.git","ssh_url":"git@github.com:firelizzard18/vscode.git","clone_url":"https://github.com/firelizzard18/vscode.git","svn_url":"https://github.com/firelizzard18/vscode","homepage":"https://code.visualstudio.com","size":93436,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"dd7adcc1615d86c33e139b677f5adf69f1c2cf91","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41881900,"name":"vscode","full_name":"Microsoft/vscode","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/vscode","description":"Visual Studio Code","fork":false,"url":"https://api.github.com/repos/Microsoft/vscode","forks_url":"https://api.github.com/repos/Microsoft/vscode/forks","keys_url":"https://api.github.com/repos/Microsoft/vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/vscode/teams","hooks_url":"https://api.github.com/repos/Microsoft/vscode/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/vscode/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/vscode/events","assignees_url":"https://api.github.com/repos/Microsoft/vscode/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/vscode/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/vscode/tags","blobs_url":"https://api.github.com/repos/Microsoft/vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/vscode/languages","stargazers_url":"https://api.github.com/repos/Microsoft/vscode/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/vscode/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/vscode/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/vscode/subscription","commits_url":"https://api.github.com/repos/Microsoft/vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/vscode/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/vscode/merges","archive_url":"https://api.github.com/repos/Microsoft/vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/vscode/downloads","issues_url":"https://api.github.com/repos/Microsoft/vscode/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/vscode/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/vscode/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/vscode/deployments","created_at":"2015-09-03T20:23:38Z","updated_at":"2017-08-06T15:20:33Z","pushed_at":"2017-08-06T07:38:04Z","git_url":"git://github.com/Microsoft/vscode.git","ssh_url":"git@github.com:Microsoft/vscode.git","clone_url":"https://github.com/Microsoft/vscode.git","svn_url":"https://github.com/Microsoft/vscode","homepage":"https://code.visualstudio.com","size":93341,"stargazers_count":31454,"watchers_count":31454,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4303,"mirror_url":null,"open_issues_count":4840,"forks":4303,"open_issues":4840,"watchers":31454,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/32061"},"html":{"href":"https://github.com/Microsoft/vscode/pull/32061"},"issue":{"href":"https://api.github.com/repos/Microsoft/vscode/issues/32061"},"comments":{"href":"https://api.github.com/repos/Microsoft/vscode/issues/32061/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/32061/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/vscode/pulls/32061/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/vscode/statuses/2e45c4564aab23e6b1feab4888e207cfdc14d46a"}}}}
{"actor":{"display_login":"jayoungers"}}