{"action":"created","issue":{"url":"https://api.github.com/repos/leandigo/django-oneall/issues/21","repository_url":"https://api.github.com/repos/leandigo/django-oneall","labels_url":"https://api.github.com/repos/leandigo/django-oneall/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/leandigo/django-oneall/issues/21/comments","events_url":"https://api.github.com/repos/leandigo/django-oneall/issues/21/events","html_url":"https://github.com/leandigo/django-oneall/issues/21","id":248844124,"number":21,"title":"issue when upgrading to Django 10+ when using 'store_user_info': False feature","user":{"login":"ckot","id":1091009,"avatar_url":"https://avatars3.githubusercontent.com/u/1091009?v=4","gravatar_id":"","url":"https://api.github.com/users/ckot","html_url":"https://github.com/ckot","followers_url":"https://api.github.com/users/ckot/followers","following_url":"https://api.github.com/users/ckot/following{/other_user}","gists_url":"https://api.github.com/users/ckot/gists{/gist_id}","starred_url":"https://api.github.com/users/ckot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckot/subscriptions","organizations_url":"https://api.github.com/users/ckot/orgs","repos_url":"https://api.github.com/users/ckot/repos","events_url":"https://api.github.com/users/ckot/events{/privacy}","received_events_url":"https://api.github.com/users/ckot/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-08T20:57:36Z","updated_at":"2017-08-08T21:50:47Z","closed_at":null,"body":"Django 1.10 up'd the length of auth_User.username from 30 to 150 chars.   \r\n\r\nThis is fine for new users and/or new installations, but it causes existing users prior to an upgrade to be mis-identified.\r\n\r\nI could put together a PR to fix this - just wanted some feedback first\r\n\r\nI was thinking of simply adding another config option (only relevant for the pseudorandom usernames), such as 'pre_django1_10_usernames' (default=False) , and it's set to True simply use 30 chars instead of getting the username field length from the User models meta data.  \r\n\r\nThe logic seems really simple, I imagine the main part is agreeing on the option name for the config.\r\n\r\n-Scott"},"comment":{"url":"https://api.github.com/repos/leandigo/django-oneall/issues/comments/321092224","html_url":"https://github.com/leandigo/django-oneall/issues/21#issuecomment-321092224","issue_url":"https://api.github.com/repos/leandigo/django-oneall/issues/21","id":321092224,"user":{"login":"ckot","id":1091009,"avatar_url":"https://avatars3.githubusercontent.com/u/1091009?v=4","gravatar_id":"","url":"https://api.github.com/users/ckot","html_url":"https://github.com/ckot","followers_url":"https://api.github.com/users/ckot/followers","following_url":"https://api.github.com/users/ckot/following{/other_user}","gists_url":"https://api.github.com/users/ckot/gists{/gist_id}","starred_url":"https://api.github.com/users/ckot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ckot/subscriptions","organizations_url":"https://api.github.com/users/ckot/orgs","repos_url":"https://api.github.com/users/ckot/repos","events_url":"https://api.github.com/users/ckot/events{/privacy}","received_events_url":"https://api.github.com/users/ckot/received_events","type":"User","site_admin":false},"created_at":"2017-08-08T21:50:47Z","updated_at":"2017-08-08T21:50:47Z","body":"wow! quick response!\r\n\r\nI'm glad I consulted you prior to my PR.  'max_username_length': (default 150) sounds much better.  \r\n\r\nAnd yes you have existing code which gets the max_length of the field via  get_user_model() - It will be simple to compare the option's value to that to determine if it's sane.\r\n"}}
{"actor":{"display_login":"ckot"}}