{"action":"created","comment":{"url":"https://api.github.com/repos/thoughtbot/administrate/pulls/comments/111136982","pull_request_review_id":32359565,"id":111136982,"diff_hunk":"@@ -15,3 +15,15 @@\n     font-weight: $bold-font-weight;\n   }\n }\n+\n+.pagination-with-total {\n+  margin-bottom: $base-spacing * 4;","path":"app/assets/stylesheets/administrate/components/_pagination.scss","position":null,"original_position":6,"commit_id":"c883c1b0a9b1dbc2a362c56d276a89a47b321beb","original_commit_id":"dc2b17da3036fa73cd37ee4421d5886c0cffa98c","user":{"login":"maxkwallace","id":3249377,"avatar_url":"https://avatars2.githubusercontent.com/u/3249377?v=3","gravatar_id":"","url":"https://api.github.com/users/maxkwallace","html_url":"https://github.com/maxkwallace","followers_url":"https://api.github.com/users/maxkwallace/followers","following_url":"https://api.github.com/users/maxkwallace/following{/other_user}","gists_url":"https://api.github.com/users/maxkwallace/gists{/gist_id}","starred_url":"https://api.github.com/users/maxkwallace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxkwallace/subscriptions","organizations_url":"https://api.github.com/users/maxkwallace/orgs","repos_url":"https://api.github.com/users/maxkwallace/repos","events_url":"https://api.github.com/users/maxkwallace/events{/privacy}","received_events_url":"https://api.github.com/users/maxkwallace/received_events","type":"User","site_admin":false},"body":"@tysongach the HTML looks like:\r\n\r\n```\r\n<div class=\"pagination--with-total\">\r\n  <nav class='pagination'>\r\n    ...\r\n  </nav>\r\n  <div class=\"pagination__total\">\r\n    ...\r\n  </div>\r\n</div>\r\n```\r\n\r\nThe pagination nav is, AFAIK, generated by Kaminari, and there's no way to customize that bit of markup without overriding Kaminari's default pagination helper, which seems out of scope for this PR.\r\n\r\nI think we do need this `margin-bottom`-- because `.pagination--with-total` is a wrapper around `.pagination`, the outer div should have the same margin bottom in the end.","created_at":"2017-04-12T12:37:05Z","updated_at":"2017-04-12T12:37:05Z","html_url":"https://github.com/thoughtbot/administrate/pull/804#discussion_r111136982","pull_request_url":"https://api.github.com/repos/thoughtbot/administrate/pulls/804","_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/administrate/pulls/comments/111136982"},"html":{"href":"https://github.com/thoughtbot/administrate/pull/804#discussion_r111136982"},"pull_request":{"href":"https://api.github.com/repos/thoughtbot/administrate/pulls/804"}}},"pull_request":{"url":"https://api.github.com/repos/thoughtbot/administrate/pulls/804","id":113464620,"html_url":"https://github.com/thoughtbot/administrate/pull/804","diff_url":"https://github.com/thoughtbot/administrate/pull/804.diff","patch_url":"https://github.com/thoughtbot/administrate/pull/804.patch","issue_url":"https://api.github.com/repos/thoughtbot/administrate/issues/804","number":804,"state":"open","locked":false,"title":"Show the total when paginating Field::HasMany","user":{"login":"maxkwallace","id":3249377,"avatar_url":"https://avatars2.githubusercontent.com/u/3249377?v=3","gravatar_id":"","url":"https://api.github.com/users/maxkwallace","html_url":"https://github.com/maxkwallace","followers_url":"https://api.github.com/users/maxkwallace/followers","following_url":"https://api.github.com/users/maxkwallace/following{/other_user}","gists_url":"https://api.github.com/users/maxkwallace/gists{/gist_id}","starred_url":"https://api.github.com/users/maxkwallace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxkwallace/subscriptions","organizations_url":"https://api.github.com/users/maxkwallace/orgs","repos_url":"https://api.github.com/users/maxkwallace/repos","events_url":"https://api.github.com/users/maxkwallace/events{/privacy}","received_events_url":"https://api.github.com/users/maxkwallace/received_events","type":"User","site_admin":false},"body":"The new pagination feature added in https://github.com/thoughtbot/administrate/commit/41a5e258c109fe44e80085bc2e4d27c476fa9879 is awesome-- but as soon as the total disappeared from the UI, our users asked for it back :)","created_at":"2017-03-30T15:59:58Z","updated_at":"2017-04-12T12:37:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f440561786c38d0be87fbde04d64a346f50016a7","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/thoughtbot/administrate/pulls/804/commits","review_comments_url":"https://api.github.com/repos/thoughtbot/administrate/pulls/804/comments","review_comment_url":"https://api.github.com/repos/thoughtbot/administrate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thoughtbot/administrate/issues/804/comments","statuses_url":"https://api.github.com/repos/thoughtbot/administrate/statuses/c883c1b0a9b1dbc2a362c56d276a89a47b321beb","head":{"label":"shearwaterintl:master","ref":"master","sha":"c883c1b0a9b1dbc2a362c56d276a89a47b321beb","user":{"login":"shearwaterintl","id":12503808,"avatar_url":"https://avatars0.githubusercontent.com/u/12503808?v=3","gravatar_id":"","url":"https://api.github.com/users/shearwaterintl","html_url":"https://github.com/shearwaterintl","followers_url":"https://api.github.com/users/shearwaterintl/followers","following_url":"https://api.github.com/users/shearwaterintl/following{/other_user}","gists_url":"https://api.github.com/users/shearwaterintl/gists{/gist_id}","starred_url":"https://api.github.com/users/shearwaterintl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shearwaterintl/subscriptions","organizations_url":"https://api.github.com/users/shearwaterintl/orgs","repos_url":"https://api.github.com/users/shearwaterintl/repos","events_url":"https://api.github.com/users/shearwaterintl/events{/privacy}","received_events_url":"https://api.github.com/users/shearwaterintl/received_events","type":"Organization","site_admin":false},"repo":{"id":85755463,"name":"administrate","full_name":"shearwaterintl/administrate","owner":{"login":"shearwaterintl","id":12503808,"avatar_url":"https://avatars0.githubusercontent.com/u/12503808?v=3","gravatar_id":"","url":"https://api.github.com/users/shearwaterintl","html_url":"https://github.com/shearwaterintl","followers_url":"https://api.github.com/users/shearwaterintl/followers","following_url":"https://api.github.com/users/shearwaterintl/following{/other_user}","gists_url":"https://api.github.com/users/shearwaterintl/gists{/gist_id}","starred_url":"https://api.github.com/users/shearwaterintl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shearwaterintl/subscriptions","organizations_url":"https://api.github.com/users/shearwaterintl/orgs","repos_url":"https://api.github.com/users/shearwaterintl/repos","events_url":"https://api.github.com/users/shearwaterintl/events{/privacy}","received_events_url":"https://api.github.com/users/shearwaterintl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shearwaterintl/administrate","description":"A Rails engine that helps you put together a super-flexible admin dashboard.","fork":true,"url":"https://api.github.com/repos/shearwaterintl/administrate","forks_url":"https://api.github.com/repos/shearwaterintl/administrate/forks","keys_url":"https://api.github.com/repos/shearwaterintl/administrate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shearwaterintl/administrate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shearwaterintl/administrate/teams","hooks_url":"https://api.github.com/repos/shearwaterintl/administrate/hooks","issue_events_url":"https://api.github.com/repos/shearwaterintl/administrate/issues/events{/number}","events_url":"https://api.github.com/repos/shearwaterintl/administrate/events","assignees_url":"https://api.github.com/repos/shearwaterintl/administrate/assignees{/user}","branches_url":"https://api.github.com/repos/shearwaterintl/administrate/branches{/branch}","tags_url":"https://api.github.com/repos/shearwaterintl/administrate/tags","blobs_url":"https://api.github.com/repos/shearwaterintl/administrate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shearwaterintl/administrate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shearwaterintl/administrate/git/refs{/sha}","trees_url":"https://api.github.com/repos/shearwaterintl/administrate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shearwaterintl/administrate/statuses/{sha}","languages_url":"https://api.github.com/repos/shearwaterintl/administrate/languages","stargazers_url":"https://api.github.com/repos/shearwaterintl/administrate/stargazers","contributors_url":"https://api.github.com/repos/shearwaterintl/administrate/contributors","subscribers_url":"https://api.github.com/repos/shearwaterintl/administrate/subscribers","subscription_url":"https://api.github.com/repos/shearwaterintl/administrate/subscription","commits_url":"https://api.github.com/repos/shearwaterintl/administrate/commits{/sha}","git_commits_url":"https://api.github.com/repos/shearwaterintl/administrate/git/commits{/sha}","comments_url":"https://api.github.com/repos/shearwaterintl/administrate/comments{/number}","issue_comment_url":"https://api.github.com/repos/shearwaterintl/administrate/issues/comments{/number}","contents_url":"https://api.github.com/repos/shearwaterintl/administrate/contents/{+path}","compare_url":"https://api.github.com/repos/shearwaterintl/administrate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shearwaterintl/administrate/merges","archive_url":"https://api.github.com/repos/shearwaterintl/administrate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shearwaterintl/administrate/downloads","issues_url":"https://api.github.com/repos/shearwaterintl/administrate/issues{/number}","pulls_url":"https://api.github.com/repos/shearwaterintl/administrate/pulls{/number}","milestones_url":"https://api.github.com/repos/shearwaterintl/administrate/milestones{/number}","notifications_url":"https://api.github.com/repos/shearwaterintl/administrate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shearwaterintl/administrate/labels{/name}","releases_url":"https://api.github.com/repos/shearwaterintl/administrate/releases{/id}","deployments_url":"https://api.github.com/repos/shearwaterintl/administrate/deployments","created_at":"2017-03-21T21:29:21Z","updated_at":"2017-03-21T21:29:23Z","pushed_at":"2017-04-12T12:30:54Z","git_url":"git://github.com/shearwaterintl/administrate.git","ssh_url":"git@github.com:shearwaterintl/administrate.git","clone_url":"https://github.com/shearwaterintl/administrate.git","svn_url":"https://github.com/shearwaterintl/administrate","homepage":"http://administrate-prototype.herokuapp.com/admin","size":891,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thoughtbot:master","ref":"master","sha":"be4a751f69ee3ebf3b460c53b9b00d3d0de6a159","user":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars0.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"repo":{"id":33739333,"name":"administrate","full_name":"thoughtbot/administrate","owner":{"login":"thoughtbot","id":6183,"avatar_url":"https://avatars0.githubusercontent.com/u/6183?v=3","gravatar_id":"","url":"https://api.github.com/users/thoughtbot","html_url":"https://github.com/thoughtbot","followers_url":"https://api.github.com/users/thoughtbot/followers","following_url":"https://api.github.com/users/thoughtbot/following{/other_user}","gists_url":"https://api.github.com/users/thoughtbot/gists{/gist_id}","starred_url":"https://api.github.com/users/thoughtbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoughtbot/subscriptions","organizations_url":"https://api.github.com/users/thoughtbot/orgs","repos_url":"https://api.github.com/users/thoughtbot/repos","events_url":"https://api.github.com/users/thoughtbot/events{/privacy}","received_events_url":"https://api.github.com/users/thoughtbot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/thoughtbot/administrate","description":"A Rails engine that helps you put together a super-flexible admin dashboard.","fork":false,"url":"https://api.github.com/repos/thoughtbot/administrate","forks_url":"https://api.github.com/repos/thoughtbot/administrate/forks","keys_url":"https://api.github.com/repos/thoughtbot/administrate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoughtbot/administrate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoughtbot/administrate/teams","hooks_url":"https://api.github.com/repos/thoughtbot/administrate/hooks","issue_events_url":"https://api.github.com/repos/thoughtbot/administrate/issues/events{/number}","events_url":"https://api.github.com/repos/thoughtbot/administrate/events","assignees_url":"https://api.github.com/repos/thoughtbot/administrate/assignees{/user}","branches_url":"https://api.github.com/repos/thoughtbot/administrate/branches{/branch}","tags_url":"https://api.github.com/repos/thoughtbot/administrate/tags","blobs_url":"https://api.github.com/repos/thoughtbot/administrate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoughtbot/administrate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoughtbot/administrate/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoughtbot/administrate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoughtbot/administrate/statuses/{sha}","languages_url":"https://api.github.com/repos/thoughtbot/administrate/languages","stargazers_url":"https://api.github.com/repos/thoughtbot/administrate/stargazers","contributors_url":"https://api.github.com/repos/thoughtbot/administrate/contributors","subscribers_url":"https://api.github.com/repos/thoughtbot/administrate/subscribers","subscription_url":"https://api.github.com/repos/thoughtbot/administrate/subscription","commits_url":"https://api.github.com/repos/thoughtbot/administrate/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoughtbot/administrate/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoughtbot/administrate/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoughtbot/administrate/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoughtbot/administrate/contents/{+path}","compare_url":"https://api.github.com/repos/thoughtbot/administrate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoughtbot/administrate/merges","archive_url":"https://api.github.com/repos/thoughtbot/administrate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoughtbot/administrate/downloads","issues_url":"https://api.github.com/repos/thoughtbot/administrate/issues{/number}","pulls_url":"https://api.github.com/repos/thoughtbot/administrate/pulls{/number}","milestones_url":"https://api.github.com/repos/thoughtbot/administrate/milestones{/number}","notifications_url":"https://api.github.com/repos/thoughtbot/administrate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoughtbot/administrate/labels{/name}","releases_url":"https://api.github.com/repos/thoughtbot/administrate/releases{/id}","deployments_url":"https://api.github.com/repos/thoughtbot/administrate/deployments","created_at":"2015-04-10T16:43:02Z","updated_at":"2017-04-12T09:46:48Z","pushed_at":"2017-04-12T12:30:55Z","git_url":"git://github.com/thoughtbot/administrate.git","ssh_url":"git@github.com:thoughtbot/administrate.git","clone_url":"https://github.com/thoughtbot/administrate.git","svn_url":"https://github.com/thoughtbot/administrate","homepage":"http://administrate-prototype.herokuapp.com/admin","size":903,"stargazers_count":3147,"watchers_count":3147,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":450,"mirror_url":null,"open_issues_count":180,"forks":450,"open_issues":180,"watchers":3147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thoughtbot/administrate/pulls/804"},"html":{"href":"https://github.com/thoughtbot/administrate/pull/804"},"issue":{"href":"https://api.github.com/repos/thoughtbot/administrate/issues/804"},"comments":{"href":"https://api.github.com/repos/thoughtbot/administrate/issues/804/comments"},"review_comments":{"href":"https://api.github.com/repos/thoughtbot/administrate/pulls/804/comments"},"review_comment":{"href":"https://api.github.com/repos/thoughtbot/administrate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thoughtbot/administrate/pulls/804/commits"},"statuses":{"href":"https://api.github.com/repos/thoughtbot/administrate/statuses/c883c1b0a9b1dbc2a362c56d276a89a47b321beb"}}}}
{"actor":{"display_login":"maxkwallace"}}