{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45805","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45805/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45805/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45805/events","html_url":"https://github.com/kubernetes/kubernetes/pull/45805","id":228603457,"number":45805,"title":"storageclass ceph add imageformat parameter","user":{"login":"weiwei04","id":2130651,"avatar_url":"https://avatars3.githubusercontent.com/u/2130651?v=3","gravatar_id":"","url":"https://api.github.com/users/weiwei04","html_url":"https://github.com/weiwei04","followers_url":"https://api.github.com/users/weiwei04/followers","following_url":"https://api.github.com/users/weiwei04/following{/other_user}","gists_url":"https://api.github.com/users/weiwei04/gists{/gist_id}","starred_url":"https://api.github.com/users/weiwei04/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weiwei04/subscriptions","organizations_url":"https://api.github.com/users/weiwei04/orgs","repos_url":"https://api.github.com/users/weiwei04/repos","events_url":"https://api.github.com/users/weiwei04/events{/privacy}","received_events_url":"https://api.github.com/users/weiwei04/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":148225179,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"state":"open","locked":false,"assignee":{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},"assignees":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars3.githubusercontent.com/u/1163175?v=3","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false},{"login":"rootfs","id":7062400,"avatar_url":"https://avatars3.githubusercontent.com/u/7062400?v=3","gravatar_id":"","url":"https://api.github.com/users/rootfs","html_url":"https://github.com/rootfs","followers_url":"https://api.github.com/users/rootfs/followers","following_url":"https://api.github.com/users/rootfs/following{/other_user}","gists_url":"https://api.github.com/users/rootfs/gists{/gist_id}","starred_url":"https://api.github.com/users/rootfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rootfs/subscriptions","organizations_url":"https://api.github.com/users/rootfs/orgs","repos_url":"https://api.github.com/users/rootfs/repos","events_url":"https://api.github.com/users/rootfs/events{/privacy}","received_events_url":"https://api.github.com/users/rootfs/received_events","type":"User","site_admin":false},{"login":"saad-ali","id":10052848,"avatar_url":"https://avatars2.githubusercontent.com/u/10052848?v=3","gravatar_id":"","url":"https://api.github.com/users/saad-ali","html_url":"https://github.com/saad-ali","followers_url":"https://api.github.com/users/saad-ali/followers","following_url":"https://api.github.com/users/saad-ali/following{/other_user}","gists_url":"https://api.github.com/users/saad-ali/gists{/gist_id}","starred_url":"https://api.github.com/users/saad-ali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saad-ali/subscriptions","organizations_url":"https://api.github.com/users/saad-ali/orgs","repos_url":"https://api.github.com/users/saad-ali/repos","events_url":"https://api.github.com/users/saad-ali/events{/privacy}","received_events_url":"https://api.github.com/users/saad-ali/received_events","type":"User","site_admin":false}],"milestone":null,"comments":28,"created_at":"2017-05-15T04:26:20Z","updated_at":"2017-06-23T23:00:59Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/45805","html_url":"https://github.com/kubernetes/kubernetes/pull/45805","diff_url":"https://github.com/kubernetes/kubernetes/pull/45805.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/45805.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#pull-request-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/faster_reviews.md\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#release-notes\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nAdd a imageformat parameter for StorageClass(ceph rbd)\r\n\r\nk8s hard coded ceph imageformat 1, according to [ceph manual](http://docs.ceph.com/docs/master/man/8/rbd/), imageformat 1 was deprecated, we should add an extra ceph parameter to set ceph rbd imageformat. Ceph rbd imageformat can only be 1 or 2, set the default value to 1.\r\n\r\n**Release note**:\r\n```release-note\r\nAllow StorageClass Ceph RBD to specify image format and image features.\r\n```"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/310791036","html_url":"https://github.com/kubernetes/kubernetes/pull/45805#issuecomment-310791036","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/45805","id":310791036,"user":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars3.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"created_at":"2017-06-23T23:00:59Z","updated_at":"2017-06-23T23:00:59Z","body":"[APPROVALNOTIFIER] This PR is **APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/45805#issuecomment-310440623\" title=\"Approved\">eparis</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/45805#issuecomment-310439298\" title=\"Approved\">rootfs</a>*, *<a href=\"https://github.com/kubernetes/kubernetes/pull/45805#\" title=\"Author self-approved\">weiwei04</a>*\n\nAssociated issue requirement bypassed by: *<a href=\"https://github.com/kubernetes/kubernetes/pull/45805#issuecomment-310440623\" title=\"Approved\">eparis</a>*\n\nThe full list of commands accepted by this bot can be found [here](https://github.com/kubernetes/test-infra/blob/master/commands.md).\n\n<details >\nNeeds approval from an approver in each of these OWNERS Files:\n\n- ~~[examples/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/examples/OWNERS)~~ [eparis]\n- ~~[pkg/volume/rbd/OWNERS](https://github.com/kubernetes/kubernetes/blob/master/pkg/volume/rbd/OWNERS)~~ [rootfs]\n\nYou can indicate your approval by writing `/approve` in a comment\nYou can cancel your approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[]} -->"}}
{"actor":{"display_login":"k8s-merge-robot"}}