{"action":"created","comment":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/154892338","pull_request_review_id":81121300,"id":154892338,"diff_hunk":"@@ -0,0 +1,108 @@\n+<?php\n+/**\n+ * @package     Joomla.Platform\n+ * @subpackage  Form\n+ *\n+ * @copyright   Copyright (C) 2005 - 2017 Open Source Matters, Inc. All rights reserved.\n+ * @license     GNU General Public License version 2 or later; see LICENSE.txt\n+ */\n+\n+defined('_JEXEC') or die;\n+\n+JLoader::register('InstallerHelper', JPATH_ADMINISTRATOR . '/components/com_installer/helpers/installer.php');\n+\n+JFormHelper::loadFieldClass('list');\n+\n+/**\n+ * Package field.\n+ *\n+ * Provides a list box of installed extension packages.\n+ *\n+ * @since  __DEPLOY_VERSION__\n+ */\n+class JFormFieldPackagelist extends JFormFieldList\n+{\n+\t/**\n+\t * The form field package.\n+\t *\n+\t * @var    string\n+\t * @since  __DEPLOY_VERSION__\n+\t */\n+\tprotected $type = 'Packagelist';\n+\n+\t/**\n+\t * Only packages containing extensions of specified type\n+\t *\n+\t * @var    float\n+\t * @since  __DEPLOY_VERSION__\n+\t */\n+\tprotected $extensiontype = null;\n+\n+\t/**\n+\t * Only packages with the given value of enabled field\n+\t *\n+\t * @var    float\n+\t * @since  __DEPLOY_VERSION__\n+\t */\n+\tprotected $packageenabled = null;\n+\n+\t/**\n+\t * Method to attach a JForm object to the field.\n+\t *\n+\t * @param   SimpleXMLElement  $element  The SimpleXMLElement object representing the `<field>` tag for the form field object.\n+\t * @param   mixed             $value    The form field value to validate.\n+\t * @param   string            $group    The field name group control value. This acts as an array container for the field.\n+\t *                                      For example if the field has name=\"foo\" and the group value is set to \"bar\" then the\n+\t *                                      full field name would end up being \"bar[foo]\".\n+\t *\n+\t * @return  boolean  True on success.\n+\t *\n+\t * @see     JFormField::setup()\n+\t * @since   __DEPLOY_VERSION__\n+\t */\n+\tpublic function setup(SimpleXMLElement $element, $value, $group = null)\n+\t{\n+\t\t$return = parent::setup($element, $value, $group);\n+\n+\t\tif ($return)\n+\t\t{\n+\t\t\t$this->extensiontype   = isset($this->element['extensiontype']) ? $this->element['extensiontype'] : null;\n+\t\t\t$this->packageenabled  = isset($this->element['packageenabled']) ? (int) $this->element['packageenabled'] : \"1\";\n+\t\t}\n+\n+\t\treturn $return;\n+\t}\n+\n+\t/**\n+\t * Method to get the field options.\n+\t *\n+\t * @return  array  The field option objects.\n+\t *\n+\t * @since   __DEPLOY_VERSION__\n+\t */\n+\tpublic function getOptions()\n+\t{\n+\t \t$db    = JFactory::getDbo();\n+\t \t$query = $db->getQuery(true)\n+\t\t\t    ->select('a.extension_id, a.name')\n+\t\t\t    ->from('#__extensions AS a')\n+\t\t\t    ->where('a.type = ' . $db->quote('package'))\n+\t\t\t    ->order('a.name');\n+\t\tif (!empty($this->extensiontype)) {\n+\t\t\t$query->where('EXISTS ( SELECT NULL FROM #__extensions AS b WHERE b.package_id = a.extension_id AND b.type = ' . $db->quote($this->extensiontype) . ')');\n+\t\t}\n+\t\tif (strlen($this->packageenabled)) {","path":"libraries/joomla/form/fields/packagelist.php","position":null,"original_position":94,"commit_id":"4171df91d7033ac8714145093ae7ee9341dae1ec","original_commit_id":"a5ea3c37c64679fddd0ea6531125112602e71200","user":{"login":"brainforgeUK","id":3941269,"avatar_url":"https://avatars3.githubusercontent.com/u/3941269?v=4","gravatar_id":"","url":"https://api.github.com/users/brainforgeUK","html_url":"https://github.com/brainforgeUK","followers_url":"https://api.github.com/users/brainforgeUK/followers","following_url":"https://api.github.com/users/brainforgeUK/following{/other_user}","gists_url":"https://api.github.com/users/brainforgeUK/gists{/gist_id}","starred_url":"https://api.github.com/users/brainforgeUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainforgeUK/subscriptions","organizations_url":"https://api.github.com/users/brainforgeUK/orgs","repos_url":"https://api.github.com/users/brainforgeUK/repos","events_url":"https://api.github.com/users/brainforgeUK/events{/privacy}","received_events_url":"https://api.github.com/users/brainforgeUK/received_events","type":"User","site_admin":false},"body":"Changed. Thanks for pointing out.","created_at":"2017-12-05T09:45:31Z","updated_at":"2017-12-05T09:45:31Z","html_url":"https://github.com/joomla/joomla-cms/pull/17585#discussion_r154892338","pull_request_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/17585","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments/154892338"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/17585#discussion_r154892338"},"pull_request":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/17585"}},"in_reply_to_id":154710548},"pull_request":{"url":"https://api.github.com/repos/joomla/joomla-cms/pulls/17585","id":136309660,"html_url":"https://github.com/joomla/joomla-cms/pull/17585","diff_url":"https://github.com/joomla/joomla-cms/pull/17585.diff","patch_url":"https://github.com/joomla/joomla-cms/pull/17585.patch","issue_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17585","number":17585,"state":"open","locked":false,"title":"Extension package management enhancement.","user":{"login":"brainforgeUK","id":3941269,"avatar_url":"https://avatars3.githubusercontent.com/u/3941269?v=4","gravatar_id":"","url":"https://api.github.com/users/brainforgeUK","html_url":"https://github.com/brainforgeUK","followers_url":"https://api.github.com/users/brainforgeUK/followers","following_url":"https://api.github.com/users/brainforgeUK/following{/other_user}","gists_url":"https://api.github.com/users/brainforgeUK/gists{/gist_id}","starred_url":"https://api.github.com/users/brainforgeUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainforgeUK/subscriptions","organizations_url":"https://api.github.com/users/brainforgeUK/orgs","repos_url":"https://api.github.com/users/brainforgeUK/repos","events_url":"https://api.github.com/users/brainforgeUK/events{/privacy}","received_events_url":"https://api.github.com/users/brainforgeUK/received_events","type":"User","site_admin":false},"body":"See issue #17579 - Managing extension packages\r\nhttps://issues.joomla.org/tracker/joomla-cms/17579\r\n\r\nPull Request for Issue # .\r\n\r\n### Summary of Changes\r\nAdded -- Select Package -- list to search tool in extension manager\r\nAdded links to plugin / template edit in extension manager list display\r\n\r\n\r\n\r\n### Testing Instructions\r\nGoto .../administrator/index.php?option=com_installer&view=manage\r\nGo to Search Tools and Select a Package\r\n\r\n\r\n\r\n### Expected result\r\n\r\n\r\n\r\n### Actual result\r\n\r\n\r\n\r\n### Documentation Changes Required\r\n\r\n","created_at":"2017-08-17T17:19:57Z","updated_at":"2017-12-05T09:45:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"75e8b38190c1cce8c7a6a798b4f038b474f843fd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/17585/commits","review_comments_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/17585/comments","review_comment_url":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/issues/17585/comments","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/4171df91d7033ac8714145093ae7ee9341dae1ec","head":{"label":"brainforgeUK:staging","ref":"staging","sha":"4171df91d7033ac8714145093ae7ee9341dae1ec","user":{"login":"brainforgeUK","id":3941269,"avatar_url":"https://avatars3.githubusercontent.com/u/3941269?v=4","gravatar_id":"","url":"https://api.github.com/users/brainforgeUK","html_url":"https://github.com/brainforgeUK","followers_url":"https://api.github.com/users/brainforgeUK/followers","following_url":"https://api.github.com/users/brainforgeUK/following{/other_user}","gists_url":"https://api.github.com/users/brainforgeUK/gists{/gist_id}","starred_url":"https://api.github.com/users/brainforgeUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainforgeUK/subscriptions","organizations_url":"https://api.github.com/users/brainforgeUK/orgs","repos_url":"https://api.github.com/users/brainforgeUK/repos","events_url":"https://api.github.com/users/brainforgeUK/events{/privacy}","received_events_url":"https://api.github.com/users/brainforgeUK/received_events","type":"User","site_admin":false},"repo":{"id":100626289,"name":"joomla-cms","full_name":"brainforgeUK/joomla-cms","owner":{"login":"brainforgeUK","id":3941269,"avatar_url":"https://avatars3.githubusercontent.com/u/3941269?v=4","gravatar_id":"","url":"https://api.github.com/users/brainforgeUK","html_url":"https://github.com/brainforgeUK","followers_url":"https://api.github.com/users/brainforgeUK/followers","following_url":"https://api.github.com/users/brainforgeUK/following{/other_user}","gists_url":"https://api.github.com/users/brainforgeUK/gists{/gist_id}","starred_url":"https://api.github.com/users/brainforgeUK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brainforgeUK/subscriptions","organizations_url":"https://api.github.com/users/brainforgeUK/orgs","repos_url":"https://api.github.com/users/brainforgeUK/repos","events_url":"https://api.github.com/users/brainforgeUK/events{/privacy}","received_events_url":"https://api.github.com/users/brainforgeUK/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brainforgeUK/joomla-cms","description":"Home of the Joomla! Content Management System","fork":true,"url":"https://api.github.com/repos/brainforgeUK/joomla-cms","forks_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/forks","keys_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/teams","hooks_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/events","assignees_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/tags","blobs_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/subscription","commits_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/merges","archive_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/downloads","issues_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/brainforgeUK/joomla-cms/deployments","created_at":"2017-08-17T16:57:36Z","updated_at":"2017-08-17T16:57:57Z","pushed_at":"2017-12-05T09:44:16Z","git_url":"git://github.com/brainforgeUK/joomla-cms.git","ssh_url":"git@github.com:brainforgeUK/joomla-cms.git","clone_url":"https://github.com/brainforgeUK/joomla-cms.git","svn_url":"https://github.com/brainforgeUK/joomla-cms","homepage":"https://www.joomla.org","size":204388,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"joomla:staging","ref":"staging","sha":"4711ba1ede505345ef822777a3643d0472be7e30","user":{"login":"joomla","id":751633,"avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"repo":{"id":2464908,"name":"joomla-cms","full_name":"joomla/joomla-cms","owner":{"login":"joomla","id":751633,"avatar_url":"https://avatars3.githubusercontent.com/u/751633?v=4","gravatar_id":"","url":"https://api.github.com/users/joomla","html_url":"https://github.com/joomla","followers_url":"https://api.github.com/users/joomla/followers","following_url":"https://api.github.com/users/joomla/following{/other_user}","gists_url":"https://api.github.com/users/joomla/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla/subscriptions","organizations_url":"https://api.github.com/users/joomla/orgs","repos_url":"https://api.github.com/users/joomla/repos","events_url":"https://api.github.com/users/joomla/events{/privacy}","received_events_url":"https://api.github.com/users/joomla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla/joomla-cms","description":"Home of the Joomla! Content Management System","fork":false,"url":"https://api.github.com/repos/joomla/joomla-cms","forks_url":"https://api.github.com/repos/joomla/joomla-cms/forks","keys_url":"https://api.github.com/repos/joomla/joomla-cms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla/joomla-cms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla/joomla-cms/teams","hooks_url":"https://api.github.com/repos/joomla/joomla-cms/hooks","issue_events_url":"https://api.github.com/repos/joomla/joomla-cms/issues/events{/number}","events_url":"https://api.github.com/repos/joomla/joomla-cms/events","assignees_url":"https://api.github.com/repos/joomla/joomla-cms/assignees{/user}","branches_url":"https://api.github.com/repos/joomla/joomla-cms/branches{/branch}","tags_url":"https://api.github.com/repos/joomla/joomla-cms/tags","blobs_url":"https://api.github.com/repos/joomla/joomla-cms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla/joomla-cms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla/joomla-cms/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla/joomla-cms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla/joomla-cms/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla/joomla-cms/languages","stargazers_url":"https://api.github.com/repos/joomla/joomla-cms/stargazers","contributors_url":"https://api.github.com/repos/joomla/joomla-cms/contributors","subscribers_url":"https://api.github.com/repos/joomla/joomla-cms/subscribers","subscription_url":"https://api.github.com/repos/joomla/joomla-cms/subscription","commits_url":"https://api.github.com/repos/joomla/joomla-cms/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla/joomla-cms/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla/joomla-cms/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla/joomla-cms/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla/joomla-cms/contents/{+path}","compare_url":"https://api.github.com/repos/joomla/joomla-cms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla/joomla-cms/merges","archive_url":"https://api.github.com/repos/joomla/joomla-cms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla/joomla-cms/downloads","issues_url":"https://api.github.com/repos/joomla/joomla-cms/issues{/number}","pulls_url":"https://api.github.com/repos/joomla/joomla-cms/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla/joomla-cms/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla/joomla-cms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla/joomla-cms/labels{/name}","releases_url":"https://api.github.com/repos/joomla/joomla-cms/releases{/id}","deployments_url":"https://api.github.com/repos/joomla/joomla-cms/deployments","created_at":"2011-09-27T02:07:38Z","updated_at":"2017-12-05T06:32:21Z","pushed_at":"2017-12-05T09:44:23Z","git_url":"git://github.com/joomla/joomla-cms.git","ssh_url":"git@github.com:joomla/joomla-cms.git","clone_url":"https://github.com/joomla/joomla-cms.git","svn_url":"https://github.com/joomla/joomla-cms","homepage":"https://www.joomla.org","size":217478,"stargazers_count":2571,"watchers_count":2571,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2611,"mirror_url":null,"archived":false,"open_issues_count":882,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":2611,"open_issues":882,"watchers":2571,"default_branch":"staging"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/17585"},"html":{"href":"https://github.com/joomla/joomla-cms/pull/17585"},"issue":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/17585"},"comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/issues/17585/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/17585/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla/joomla-cms/pulls/17585/commits"},"statuses":{"href":"https://api.github.com/repos/joomla/joomla-cms/statuses/4171df91d7033ac8714145093ae7ee9341dae1ec"}},"author_association":"NONE"}}
{"actor":{"display_login":"brainforgeUK"}}