{"action":"closed","number":685,"pull_request":{"url":"https://api.github.com/repos/nest/nest-simulator/pulls/685","id":111612797,"html_url":"https://github.com/nest/nest-simulator/pull/685","diff_url":"https://github.com/nest/nest-simulator/pull/685.diff","patch_url":"https://github.com/nest/nest-simulator/pull/685.patch","issue_url":"https://api.github.com/repos/nest/nest-simulator/issues/685","number":685,"state":"closed","locked":false,"title":"Avoid divisions/calulcation of steps","user":{"login":"jakobj","id":1562742,"avatar_url":"https://avatars3.githubusercontent.com/u/1562742?v=3","gravatar_id":"","url":"https://api.github.com/users/jakobj","html_url":"https://github.com/jakobj","followers_url":"https://api.github.com/users/jakobj/followers","following_url":"https://api.github.com/users/jakobj/following{/other_user}","gists_url":"https://api.github.com/users/jakobj/gists{/gist_id}","starred_url":"https://api.github.com/users/jakobj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakobj/subscriptions","organizations_url":"https://api.github.com/users/jakobj/orgs","repos_url":"https://api.github.com/users/jakobj/repos","events_url":"https://api.github.com/users/jakobj/events{/privacy}","received_events_url":"https://api.github.com/users/jakobj/received_events","type":"User","site_admin":false},"body":"This PR implements the changes suggested by Harald Servat to reduce run time by avoiding divisions and adding additional member in Event and Time objects that store frequently used values instead of calculating them from the other members on every invocation. Preliminary benchmarks show an increase of ~15% on JUQUEEN. Plots will follow.\r\nI suggest @heplesser @apeyser @terhorstd as reviewers. If Harald Servat could also have a look that would be great, unfortunately I don't know his GitHub handle.","created_at":"2017-03-20T17:52:57Z","updated_at":"2017-06-14T14:04:42Z","closed_at":"2017-06-14T14:04:42Z","merged_at":"2017-06-14T14:04:42Z","merge_commit_sha":"18bb2cc3bec660dcedcd6651d453bcf7c71a47a5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nest/nest-simulator/pulls/685/commits","review_comments_url":"https://api.github.com/repos/nest/nest-simulator/pulls/685/comments","review_comment_url":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nest/nest-simulator/issues/685/comments","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/566f73fdeea6446a611a6f2353cd0679d557438c","head":{"label":"jakobj:enh/avoid_divisions","ref":"enh/avoid_divisions","sha":"566f73fdeea6446a611a6f2353cd0679d557438c","user":{"login":"jakobj","id":1562742,"avatar_url":"https://avatars3.githubusercontent.com/u/1562742?v=3","gravatar_id":"","url":"https://api.github.com/users/jakobj","html_url":"https://github.com/jakobj","followers_url":"https://api.github.com/users/jakobj/followers","following_url":"https://api.github.com/users/jakobj/following{/other_user}","gists_url":"https://api.github.com/users/jakobj/gists{/gist_id}","starred_url":"https://api.github.com/users/jakobj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakobj/subscriptions","organizations_url":"https://api.github.com/users/jakobj/orgs","repos_url":"https://api.github.com/users/jakobj/repos","events_url":"https://api.github.com/users/jakobj/events{/privacy}","received_events_url":"https://api.github.com/users/jakobj/received_events","type":"User","site_admin":false},"repo":{"id":35839448,"name":"nest-simulator","full_name":"jakobj/nest-simulator","owner":{"login":"jakobj","id":1562742,"avatar_url":"https://avatars3.githubusercontent.com/u/1562742?v=3","gravatar_id":"","url":"https://api.github.com/users/jakobj","html_url":"https://github.com/jakobj","followers_url":"https://api.github.com/users/jakobj/followers","following_url":"https://api.github.com/users/jakobj/following{/other_user}","gists_url":"https://api.github.com/users/jakobj/gists{/gist_id}","starred_url":"https://api.github.com/users/jakobj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakobj/subscriptions","organizations_url":"https://api.github.com/users/jakobj/orgs","repos_url":"https://api.github.com/users/jakobj/repos","events_url":"https://api.github.com/users/jakobj/events{/privacy}","received_events_url":"https://api.github.com/users/jakobj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jakobj/nest-simulator","description":"The NEST simulator","fork":true,"url":"https://api.github.com/repos/jakobj/nest-simulator","forks_url":"https://api.github.com/repos/jakobj/nest-simulator/forks","keys_url":"https://api.github.com/repos/jakobj/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jakobj/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jakobj/nest-simulator/teams","hooks_url":"https://api.github.com/repos/jakobj/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/jakobj/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/jakobj/nest-simulator/events","assignees_url":"https://api.github.com/repos/jakobj/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/jakobj/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/jakobj/nest-simulator/tags","blobs_url":"https://api.github.com/repos/jakobj/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jakobj/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jakobj/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jakobj/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jakobj/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/jakobj/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/jakobj/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/jakobj/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/jakobj/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/jakobj/nest-simulator/subscription","commits_url":"https://api.github.com/repos/jakobj/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jakobj/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jakobj/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jakobj/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jakobj/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/jakobj/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jakobj/nest-simulator/merges","archive_url":"https://api.github.com/repos/jakobj/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jakobj/nest-simulator/downloads","issues_url":"https://api.github.com/repos/jakobj/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/jakobj/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/jakobj/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/jakobj/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jakobj/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/jakobj/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/jakobj/nest-simulator/deployments","created_at":"2015-05-18T19:59:20Z","updated_at":"2016-02-02T13:45:05Z","pushed_at":"2017-06-14T13:21:22Z","git_url":"git://github.com/jakobj/nest-simulator.git","ssh_url":"git@github.com:jakobj/nest-simulator.git","clone_url":"https://github.com/jakobj/nest-simulator.git","svn_url":"https://github.com/jakobj/nest-simulator","homepage":null,"size":27288,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nest:master","ref":"master","sha":"079581aab513480e6021934cbe117e81eee447fa","user":{"login":"nest","id":2377019,"avatar_url":"https://avatars2.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"repo":{"id":33933892,"name":"nest-simulator","full_name":"nest/nest-simulator","owner":{"login":"nest","id":2377019,"avatar_url":"https://avatars2.githubusercontent.com/u/2377019?v=3","gravatar_id":"","url":"https://api.github.com/users/nest","html_url":"https://github.com/nest","followers_url":"https://api.github.com/users/nest/followers","following_url":"https://api.github.com/users/nest/following{/other_user}","gists_url":"https://api.github.com/users/nest/gists{/gist_id}","starred_url":"https://api.github.com/users/nest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nest/subscriptions","organizations_url":"https://api.github.com/users/nest/orgs","repos_url":"https://api.github.com/users/nest/repos","events_url":"https://api.github.com/users/nest/events{/privacy}","received_events_url":"https://api.github.com/users/nest/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nest/nest-simulator","description":"The NEST simulator","fork":false,"url":"https://api.github.com/repos/nest/nest-simulator","forks_url":"https://api.github.com/repos/nest/nest-simulator/forks","keys_url":"https://api.github.com/repos/nest/nest-simulator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nest/nest-simulator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nest/nest-simulator/teams","hooks_url":"https://api.github.com/repos/nest/nest-simulator/hooks","issue_events_url":"https://api.github.com/repos/nest/nest-simulator/issues/events{/number}","events_url":"https://api.github.com/repos/nest/nest-simulator/events","assignees_url":"https://api.github.com/repos/nest/nest-simulator/assignees{/user}","branches_url":"https://api.github.com/repos/nest/nest-simulator/branches{/branch}","tags_url":"https://api.github.com/repos/nest/nest-simulator/tags","blobs_url":"https://api.github.com/repos/nest/nest-simulator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nest/nest-simulator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nest/nest-simulator/git/refs{/sha}","trees_url":"https://api.github.com/repos/nest/nest-simulator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nest/nest-simulator/statuses/{sha}","languages_url":"https://api.github.com/repos/nest/nest-simulator/languages","stargazers_url":"https://api.github.com/repos/nest/nest-simulator/stargazers","contributors_url":"https://api.github.com/repos/nest/nest-simulator/contributors","subscribers_url":"https://api.github.com/repos/nest/nest-simulator/subscribers","subscription_url":"https://api.github.com/repos/nest/nest-simulator/subscription","commits_url":"https://api.github.com/repos/nest/nest-simulator/commits{/sha}","git_commits_url":"https://api.github.com/repos/nest/nest-simulator/git/commits{/sha}","comments_url":"https://api.github.com/repos/nest/nest-simulator/comments{/number}","issue_comment_url":"https://api.github.com/repos/nest/nest-simulator/issues/comments{/number}","contents_url":"https://api.github.com/repos/nest/nest-simulator/contents/{+path}","compare_url":"https://api.github.com/repos/nest/nest-simulator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nest/nest-simulator/merges","archive_url":"https://api.github.com/repos/nest/nest-simulator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nest/nest-simulator/downloads","issues_url":"https://api.github.com/repos/nest/nest-simulator/issues{/number}","pulls_url":"https://api.github.com/repos/nest/nest-simulator/pulls{/number}","milestones_url":"https://api.github.com/repos/nest/nest-simulator/milestones{/number}","notifications_url":"https://api.github.com/repos/nest/nest-simulator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nest/nest-simulator/labels{/name}","releases_url":"https://api.github.com/repos/nest/nest-simulator/releases{/id}","deployments_url":"https://api.github.com/repos/nest/nest-simulator/deployments","created_at":"2015-04-14T13:39:12Z","updated_at":"2017-06-07T08:42:57Z","pushed_at":"2017-06-14T14:04:42Z","git_url":"git://github.com/nest/nest-simulator.git","ssh_url":"git@github.com:nest/nest-simulator.git","clone_url":"https://github.com/nest/nest-simulator.git","svn_url":"https://github.com/nest/nest-simulator","homepage":null,"size":34869,"stargazers_count":109,"watchers_count":109,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":118,"mirror_url":null,"open_issues_count":171,"forks":118,"open_issues":171,"watchers":109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/685"},"html":{"href":"https://github.com/nest/nest-simulator/pull/685"},"issue":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/685"},"comments":{"href":"https://api.github.com/repos/nest/nest-simulator/issues/685/comments"},"review_comments":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/685/comments"},"review_comment":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nest/nest-simulator/pulls/685/commits"},"statuses":{"href":"https://api.github.com/repos/nest/nest-simulator/statuses/566f73fdeea6446a611a6f2353cd0679d557438c"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"heplesser","id":1059644,"avatar_url":"https://avatars0.githubusercontent.com/u/1059644?v=3","gravatar_id":"","url":"https://api.github.com/users/heplesser","html_url":"https://github.com/heplesser","followers_url":"https://api.github.com/users/heplesser/followers","following_url":"https://api.github.com/users/heplesser/following{/other_user}","gists_url":"https://api.github.com/users/heplesser/gists{/gist_id}","starred_url":"https://api.github.com/users/heplesser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heplesser/subscriptions","organizations_url":"https://api.github.com/users/heplesser/orgs","repos_url":"https://api.github.com/users/heplesser/repos","events_url":"https://api.github.com/users/heplesser/events{/privacy}","received_events_url":"https://api.github.com/users/heplesser/received_events","type":"User","site_admin":false},"comments":18,"review_comments":40,"maintainer_can_modify":false,"commits":6,"additions":55,"deletions":13,"changed_files":8}}
{"actor":{"display_login":"heplesser"}}