{"action":"created","issue":{"url":"https://api.github.com/repos/danmar/cppcheck/issues/941","repository_url":"https://api.github.com/repos/danmar/cppcheck","labels_url":"https://api.github.com/repos/danmar/cppcheck/issues/941/labels{/name}","comments_url":"https://api.github.com/repos/danmar/cppcheck/issues/941/comments","events_url":"https://api.github.com/repos/danmar/cppcheck/issues/941/events","html_url":"https://github.com/danmar/cppcheck/pull/941","id":249479936,"number":941,"title":"Taking care of incorrect token definition","user":{"login":"Hinterwaeldlers","id":14948891,"avatar_url":"https://avatars1.githubusercontent.com/u/14948891?v=4","gravatar_id":"","url":"https://api.github.com/users/Hinterwaeldlers","html_url":"https://github.com/Hinterwaeldlers","followers_url":"https://api.github.com/users/Hinterwaeldlers/followers","following_url":"https://api.github.com/users/Hinterwaeldlers/following{/other_user}","gists_url":"https://api.github.com/users/Hinterwaeldlers/gists{/gist_id}","starred_url":"https://api.github.com/users/Hinterwaeldlers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hinterwaeldlers/subscriptions","organizations_url":"https://api.github.com/users/Hinterwaeldlers/orgs","repos_url":"https://api.github.com/users/Hinterwaeldlers/repos","events_url":"https://api.github.com/users/Hinterwaeldlers/events{/privacy}","received_events_url":"https://api.github.com/users/Hinterwaeldlers/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-08-10T21:19:54Z","updated_at":"2017-08-15T14:23:47Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/danmar/cppcheck/pulls/941","html_url":"https://github.com/danmar/cppcheck/pull/941","diff_url":"https://github.com/danmar/cppcheck/pull/941.diff","patch_url":"https://github.com/danmar/cppcheck/pull/941.patch"},"body":"Fix for http://trac.cppcheck.net/ticket/8152\r\n\r\nThe used CWE number is definitely incorrect, but found no list where I can map the description to the related number"},"comment":{"url":"https://api.github.com/repos/danmar/cppcheck/issues/comments/322481850","html_url":"https://github.com/danmar/cppcheck/pull/941#issuecomment-322481850","issue_url":"https://api.github.com/repos/danmar/cppcheck/issues/941","id":322481850,"user":{"login":"Hinterwaeldlers","id":14948891,"avatar_url":"https://avatars1.githubusercontent.com/u/14948891?v=4","gravatar_id":"","url":"https://api.github.com/users/Hinterwaeldlers","html_url":"https://github.com/Hinterwaeldlers","followers_url":"https://api.github.com/users/Hinterwaeldlers/followers","following_url":"https://api.github.com/users/Hinterwaeldlers/following{/other_user}","gists_url":"https://api.github.com/users/Hinterwaeldlers/gists{/gist_id}","starred_url":"https://api.github.com/users/Hinterwaeldlers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hinterwaeldlers/subscriptions","organizations_url":"https://api.github.com/users/Hinterwaeldlers/orgs","repos_url":"https://api.github.com/users/Hinterwaeldlers/repos","events_url":"https://api.github.com/users/Hinterwaeldlers/events{/privacy}","received_events_url":"https://api.github.com/users/Hinterwaeldlers/received_events","type":"User","site_admin":false},"created_at":"2017-08-15T14:23:47Z","updated_at":"2017-08-15T14:23:47Z","body":"After having a look what would be necessary, to move the stuff into garbage code, it looks like a larger rework would be necessary or most of the things done within the condition checker need a duplication.\r\n\r\nIn general a rework might make sense, but seems like it is necessary, to cut into the token generation itself, to abort any further execution if the null string is found.\r\nFor the moment I am not sure, if this is makes at all, as related code must be manipulated. As no compiler should be willing to accept such code, incorrect behavior in cppcheck sounds meaningful to me.\r\n\r\nAnyhow, I think cppcheck should not crash if such code is provided, so fixes like this should be part of the handling."}}
{"actor":{"display_login":"Hinterwaeldlers"}}