{"action":"created","issue":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/3646","repository_url":"https://api.github.com/repos/catapult-project/catapult","labels_url":"https://api.github.com/repos/catapult-project/catapult/issues/3646/labels{/name}","comments_url":"https://api.github.com/repos/catapult-project/catapult/issues/3646/comments","events_url":"https://api.github.com/repos/catapult-project/catapult/issues/3646/events","html_url":"https://github.com/catapult-project/catapult/issues/3646","id":235963677,"number":3646,"title":"Presubmit to ensure that most files in bin/ directories are executable","user":{"login":"benshayden","id":1566089,"avatar_url":"https://avatars1.githubusercontent.com/u/1566089?v=3","gravatar_id":"","url":"https://api.github.com/users/benshayden","html_url":"https://github.com/benshayden","followers_url":"https://api.github.com/users/benshayden/followers","following_url":"https://api.github.com/users/benshayden/following{/other_user}","gists_url":"https://api.github.com/users/benshayden/gists{/gist_id}","starred_url":"https://api.github.com/users/benshayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benshayden/subscriptions","organizations_url":"https://api.github.com/users/benshayden/orgs","repos_url":"https://api.github.com/users/benshayden/repos","events_url":"https://api.github.com/users/benshayden/events{/privacy}","received_events_url":"https://api.github.com/users/benshayden/received_events","type":"User","site_admin":false},"labels":[{"id":243063927,"url":"https://api.github.com/repos/catapult-project/catapult/labels/Code%20Health","name":"Code Health","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-06-14T18:07:01Z","updated_at":"2017-07-06T05:58:57Z","closed_at":null,"body":"Due to an oversight, a script was recently added to tracing/bin/ that was not made executable: validate_all_diagnostics.\r\nA presubmit could check that all files in bin/ directories are executable.\r\n\r\nThese are currently the files in bin/ directories that are not executable, excluding node_runner and third_party.\r\n\r\nTwo more files should be made executable:\r\n* ./common/battor/bin/run_py_tests\r\n* ./netlog_viewer/bin/run_dev_server_tests\r\n\r\nSome source files could be moved somewhere more appropriate:\r\n* ./firefighter/bin/packaging.py - move to firefighter/base/?\r\n* ./tracing/bin/index.html - move to tracing/tracing/?\r\n* ./tracing/bin/symbolize_trace_atos_regex.py - move to tracing/tracing/?\r\n* ./tracing/bin/symbolize_trace_atos_regex_unittest.py - move to tracing/tracing/?\r\n* ./tracing/bin/symbolize_trace_macho_reader.py - move to tracing/tracing/?\r\n* ./tracing/bin/symbolize_trace_macho_reader_unittest.py - move to tracing/tracing/?\r\n\r\nREADME and PRESUBMIT files can be whitelisted and remain non-executable:\r\n* ./telemetry/bin/README.chromium\r\n* ./telemetry/telemetry/internal/bin/README.md\r\n* ./tracing/bin/PRESUBMIT.py\r\n\r\n./systrace/bin/OWNERS looks partially redundant with systrace/OWNERS, and can be removed completely if zhenw and skyostil are added to systrace/OWNERS. Follow up with ccraik and jreck."},"comment":{"url":"https://api.github.com/repos/catapult-project/catapult/issues/comments/313303509","html_url":"https://github.com/catapult-project/catapult/issues/3646#issuecomment-313303509","issue_url":"https://api.github.com/repos/catapult-project/catapult/issues/3646","id":313303509,"user":{"login":"benshayden","id":1566089,"avatar_url":"https://avatars1.githubusercontent.com/u/1566089?v=3","gravatar_id":"","url":"https://api.github.com/users/benshayden","html_url":"https://github.com/benshayden","followers_url":"https://api.github.com/users/benshayden/followers","following_url":"https://api.github.com/users/benshayden/following{/other_user}","gists_url":"https://api.github.com/users/benshayden/gists{/gist_id}","starred_url":"https://api.github.com/users/benshayden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benshayden/subscriptions","organizations_url":"https://api.github.com/users/benshayden/orgs","repos_url":"https://api.github.com/users/benshayden/repos","events_url":"https://api.github.com/users/benshayden/events{/privacy}","received_events_url":"https://api.github.com/users/benshayden/received_events","type":"User","site_admin":false},"created_at":"2017-07-06T05:58:57Z","updated_at":"2017-07-06T05:58:57Z","body":"These 2 files still need to be moved:\r\n\r\n- ./firefighter/bin/packaging.py - move to firefighter/base/?\r\n- ./tracing/bin/index.html - move to tracing/tracing/?"}}
{"actor":{"display_login":"benshayden"}}