{"action":"opened","number":255,"pull_request":{"url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls/255","id":117649848,"html_url":"https://github.com/dotmailer/dotmailer-magento-extension/pull/255","diff_url":"https://github.com/dotmailer/dotmailer-magento-extension/pull/255.diff","patch_url":"https://github.com/dotmailer/dotmailer-magento-extension/pull/255.patch","issue_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/issues/255","number":255,"state":"open","locked":false,"title":"Use Zend_DB_Expr class for columns with expressions","user":{"login":"jasperzeinstra","id":9214557,"avatar_url":"https://avatars1.githubusercontent.com/u/9214557?v=3","gravatar_id":"","url":"https://api.github.com/users/jasperzeinstra","html_url":"https://github.com/jasperzeinstra","followers_url":"https://api.github.com/users/jasperzeinstra/followers","following_url":"https://api.github.com/users/jasperzeinstra/following{/other_user}","gists_url":"https://api.github.com/users/jasperzeinstra/gists{/gist_id}","starred_url":"https://api.github.com/users/jasperzeinstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasperzeinstra/subscriptions","organizations_url":"https://api.github.com/users/jasperzeinstra/orgs","repos_url":"https://api.github.com/users/jasperzeinstra/repos","events_url":"https://api.github.com/users/jasperzeinstra/events{/privacy}","received_events_url":"https://api.github.com/users/jasperzeinstra/received_events","type":"User","site_admin":false},"body":"Without this fix for columns with expressions the select is generated with backticks. Which results in an error like the one below for \\Dotdigitalgroup_Email_Model_Adminhtml_Dashboard_Tabs_Analysis_Rfm::getPreparedCollection.\r\n\r\n`Unknown column 'SUM((IFNULL(main_table.base_total_invoiced, 0) - IFNULL(main_table.base_tax_invoiced, 0) - IFNULL(main_table.base_shipping_invoiced, 0) - (IFNULL(main_table.base_total_refunded, 0) - IFNULL(ma' in 'field list'`\r\n\r\nYou already use this in `code/Dotdigitalgroup/Email/sql/email_connector_setup/mysql4-upgrade-4.1.3-5.0.0.php:436`\r\n\r\n","created_at":"2017-04-26T07:39:51Z","updated_at":"2017-04-26T07:39:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls/255/commits","review_comments_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls/255/comments","review_comment_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/issues/255/comments","statuses_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/statuses/52ecfba5f2fc180572422e4b87016eee40199ae3","head":{"label":"jasperzeinstra:feature/expression-fix","ref":"feature/expression-fix","sha":"52ecfba5f2fc180572422e4b87016eee40199ae3","user":{"login":"jasperzeinstra","id":9214557,"avatar_url":"https://avatars1.githubusercontent.com/u/9214557?v=3","gravatar_id":"","url":"https://api.github.com/users/jasperzeinstra","html_url":"https://github.com/jasperzeinstra","followers_url":"https://api.github.com/users/jasperzeinstra/followers","following_url":"https://api.github.com/users/jasperzeinstra/following{/other_user}","gists_url":"https://api.github.com/users/jasperzeinstra/gists{/gist_id}","starred_url":"https://api.github.com/users/jasperzeinstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasperzeinstra/subscriptions","organizations_url":"https://api.github.com/users/jasperzeinstra/orgs","repos_url":"https://api.github.com/users/jasperzeinstra/repos","events_url":"https://api.github.com/users/jasperzeinstra/events{/privacy}","received_events_url":"https://api.github.com/users/jasperzeinstra/received_events","type":"User","site_admin":false},"repo":{"id":89450769,"name":"dotmailer-magento-extension","full_name":"jasperzeinstra/dotmailer-magento-extension","owner":{"login":"jasperzeinstra","id":9214557,"avatar_url":"https://avatars1.githubusercontent.com/u/9214557?v=3","gravatar_id":"","url":"https://api.github.com/users/jasperzeinstra","html_url":"https://github.com/jasperzeinstra","followers_url":"https://api.github.com/users/jasperzeinstra/followers","following_url":"https://api.github.com/users/jasperzeinstra/following{/other_user}","gists_url":"https://api.github.com/users/jasperzeinstra/gists{/gist_id}","starred_url":"https://api.github.com/users/jasperzeinstra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasperzeinstra/subscriptions","organizations_url":"https://api.github.com/users/jasperzeinstra/orgs","repos_url":"https://api.github.com/users/jasperzeinstra/repos","events_url":"https://api.github.com/users/jasperzeinstra/events{/privacy}","received_events_url":"https://api.github.com/users/jasperzeinstra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jasperzeinstra/dotmailer-magento-extension","description":"The official dotmailer for Magento extension","fork":true,"url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension","forks_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/forks","keys_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/teams","hooks_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/hooks","issue_events_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/issues/events{/number}","events_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/events","assignees_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/assignees{/user}","branches_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/branches{/branch}","tags_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/tags","blobs_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/languages","stargazers_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/stargazers","contributors_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/contributors","subscribers_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/subscribers","subscription_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/subscription","commits_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/contents/{+path}","compare_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/merges","archive_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/downloads","issues_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/issues{/number}","pulls_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/labels{/name}","releases_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/releases{/id}","deployments_url":"https://api.github.com/repos/jasperzeinstra/dotmailer-magento-extension/deployments","created_at":"2017-04-26T07:21:48Z","updated_at":"2017-04-26T07:21:51Z","pushed_at":"2017-04-26T07:35:11Z","git_url":"git://github.com/jasperzeinstra/dotmailer-magento-extension.git","ssh_url":"git@github.com:jasperzeinstra/dotmailer-magento-extension.git","clone_url":"https://github.com/jasperzeinstra/dotmailer-magento-extension.git","svn_url":"https://github.com/jasperzeinstra/dotmailer-magento-extension","homepage":"http://magento.dotmailer.com","size":2410,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotmailer:master","ref":"master","sha":"90f190724eb89c6d36611b7ad862503a9e782cae","user":{"login":"dotmailer","id":3176979,"avatar_url":"https://avatars3.githubusercontent.com/u/3176979?v=3","gravatar_id":"","url":"https://api.github.com/users/dotmailer","html_url":"https://github.com/dotmailer","followers_url":"https://api.github.com/users/dotmailer/followers","following_url":"https://api.github.com/users/dotmailer/following{/other_user}","gists_url":"https://api.github.com/users/dotmailer/gists{/gist_id}","starred_url":"https://api.github.com/users/dotmailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotmailer/subscriptions","organizations_url":"https://api.github.com/users/dotmailer/orgs","repos_url":"https://api.github.com/users/dotmailer/repos","events_url":"https://api.github.com/users/dotmailer/events{/privacy}","received_events_url":"https://api.github.com/users/dotmailer/received_events","type":"Organization","site_admin":false},"repo":{"id":29732198,"name":"dotmailer-magento-extension","full_name":"dotmailer/dotmailer-magento-extension","owner":{"login":"dotmailer","id":3176979,"avatar_url":"https://avatars3.githubusercontent.com/u/3176979?v=3","gravatar_id":"","url":"https://api.github.com/users/dotmailer","html_url":"https://github.com/dotmailer","followers_url":"https://api.github.com/users/dotmailer/followers","following_url":"https://api.github.com/users/dotmailer/following{/other_user}","gists_url":"https://api.github.com/users/dotmailer/gists{/gist_id}","starred_url":"https://api.github.com/users/dotmailer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotmailer/subscriptions","organizations_url":"https://api.github.com/users/dotmailer/orgs","repos_url":"https://api.github.com/users/dotmailer/repos","events_url":"https://api.github.com/users/dotmailer/events{/privacy}","received_events_url":"https://api.github.com/users/dotmailer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotmailer/dotmailer-magento-extension","description":"The official dotmailer for Magento extension","fork":false,"url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension","forks_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/forks","keys_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/teams","hooks_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/hooks","issue_events_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/issues/events{/number}","events_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/events","assignees_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/assignees{/user}","branches_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/branches{/branch}","tags_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/tags","blobs_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/languages","stargazers_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/stargazers","contributors_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/contributors","subscribers_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/subscribers","subscription_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/subscription","commits_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/contents/{+path}","compare_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/merges","archive_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/downloads","issues_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/issues{/number}","pulls_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/labels{/name}","releases_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/releases{/id}","deployments_url":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/deployments","created_at":"2015-01-23T12:47:48Z","updated_at":"2016-11-16T13:25:07Z","pushed_at":"2017-04-21T15:22:41Z","git_url":"git://github.com/dotmailer/dotmailer-magento-extension.git","ssh_url":"git@github.com:dotmailer/dotmailer-magento-extension.git","clone_url":"https://github.com/dotmailer/dotmailer-magento-extension.git","svn_url":"https://github.com/dotmailer/dotmailer-magento-extension","homepage":"http://magento.dotmailer.com","size":2410,"stargazers_count":5,"watchers_count":5,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":22,"forks":13,"open_issues":22,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls/255"},"html":{"href":"https://github.com/dotmailer/dotmailer-magento-extension/pull/255"},"issue":{"href":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/issues/255"},"comments":{"href":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/issues/255/comments"},"review_comments":{"href":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls/255/comments"},"review_comment":{"href":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/pulls/255/commits"},"statuses":{"href":"https://api.github.com/repos/dotmailer/dotmailer-magento-extension/statuses/52ecfba5f2fc180572422e4b87016eee40199ae3"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":7,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"jasperzeinstra"}}