{"action":"created","comment":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/comments/159126115","pull_request_review_id":86033987,"id":159126115,"diff_hunk":"@@ -235,6 +235,64 @@\n     }\n   }\n \n+  /**\n+   * @function\n+   * @param {boolean=} deep\n+   * @return {!Node}\n+   */\n+  DomApi.prototype.cloneNode;\n+  /**\n+   * @function\n+   * @param {Node} node\n+   * @return {!Node}\n+   */\n+  DomApi.prototype.appendChild;\n+  /**\n+   * @function\n+   * @param {Node} newChild\n+   * @param {Node} refChild\n+   * @return {!Node}\n+   */\n+  DomApi.prototype.insertBefore;\n+  /**\n+   * @function\n+   * @param {Node} node\n+   * @return {!Node}\n+   */\n+  DomApi.prototype.removeChild;\n+  /**\n+   * @function\n+   * @param {Node} oldChild\n+   * @param {Node} newChild\n+   * @return {!Node}\n+   */\n+  DomApi.prototype.replaceChild;\n+  /**\n+   * @function\n+   * @param {string} name\n+   * @param {string} value\n+   * @return {void}\n+   */\n+  DomApi.prototype.setAttribute;","path":"lib/legacy/polymer.dom.html","position":99,"original_position":99,"commit_id":"67c6e5c3288421ec85a6a5d0fcb5d255405ba633","original_commit_id":"67c6e5c3288421ec85a6a5d0fcb5d255405ba633","user":{"login":"43081j","id":5677153,"avatar_url":"https://avatars1.githubusercontent.com/u/5677153?v=4","gravatar_id":"","url":"https://api.github.com/users/43081j","html_url":"https://github.com/43081j","followers_url":"https://api.github.com/users/43081j/followers","following_url":"https://api.github.com/users/43081j/following{/other_user}","gists_url":"https://api.github.com/users/43081j/gists{/gist_id}","starred_url":"https://api.github.com/users/43081j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/43081j/subscriptions","organizations_url":"https://api.github.com/users/43081j/orgs","repos_url":"https://api.github.com/users/43081j/repos","events_url":"https://api.github.com/users/43081j/events{/privacy}","received_events_url":"https://api.github.com/users/43081j/received_events","type":"User","site_admin":false},"body":"FYI closure's types define `setAttribute` as taking `(string|number|boolean)`, whereas typescript's lib defines it as taking only `string`. Here i took the typescript version, but let me know if you disagree.","created_at":"2017-12-30T17:46:58Z","updated_at":"2017-12-30T17:46:58Z","html_url":"https://github.com/Polymer/polymer/pull/5000#discussion_r159126115","pull_request_url":"https://api.github.com/repos/Polymer/polymer/pulls/5000","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments/159126115"},"html":{"href":"https://github.com/Polymer/polymer/pull/5000#discussion_r159126115"},"pull_request":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/5000"}}},"pull_request":{"url":"https://api.github.com/repos/Polymer/polymer/pulls/5000","id":159272452,"html_url":"https://github.com/Polymer/polymer/pull/5000","diff_url":"https://github.com/Polymer/polymer/pull/5000.diff","patch_url":"https://github.com/Polymer/polymer/pull/5000.patch","issue_url":"https://api.github.com/repos/Polymer/polymer/issues/5000","number":5000,"state":"open","locked":false,"title":"add void return type annotations","user":{"login":"43081j","id":5677153,"avatar_url":"https://avatars1.githubusercontent.com/u/5677153?v=4","gravatar_id":"","url":"https://api.github.com/users/43081j","html_url":"https://github.com/43081j","followers_url":"https://api.github.com/users/43081j/followers","following_url":"https://api.github.com/users/43081j/following{/other_user}","gists_url":"https://api.github.com/users/43081j/gists{/gist_id}","starred_url":"https://api.github.com/users/43081j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/43081j/subscriptions","organizations_url":"https://api.github.com/users/43081j/orgs","repos_url":"https://api.github.com/users/43081j/repos","events_url":"https://api.github.com/users/43081j/events{/privacy}","received_events_url":"https://api.github.com/users/43081j/received_events","type":"User","site_admin":false},"body":"This is just to add a few annotations for improving the types we just merged in #4928.\r\n\r\nI wasn't too sure about dom-repeat's `indexForElement` but if you follow it through the source, it seems it can only ever return a number.\r\n\r\n---\r\n\r\n* Adds type annotations to help with #5010.\r\n* Adds some annotations to getters, depends on polymer/polymer-analyzer#816","created_at":"2017-12-19T21:09:55Z","updated_at":"2017-12-30T17:46:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"82e45295142ff642d49de0f83009397b5ad350b1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Polymer/polymer/pulls/5000/commits","review_comments_url":"https://api.github.com/repos/Polymer/polymer/pulls/5000/comments","review_comment_url":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Polymer/polymer/issues/5000/comments","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/67c6e5c3288421ec85a6a5d0fcb5d255405ba633","head":{"label":"43081j:return-type","ref":"return-type","sha":"67c6e5c3288421ec85a6a5d0fcb5d255405ba633","user":{"login":"43081j","id":5677153,"avatar_url":"https://avatars1.githubusercontent.com/u/5677153?v=4","gravatar_id":"","url":"https://api.github.com/users/43081j","html_url":"https://github.com/43081j","followers_url":"https://api.github.com/users/43081j/followers","following_url":"https://api.github.com/users/43081j/following{/other_user}","gists_url":"https://api.github.com/users/43081j/gists{/gist_id}","starred_url":"https://api.github.com/users/43081j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/43081j/subscriptions","organizations_url":"https://api.github.com/users/43081j/orgs","repos_url":"https://api.github.com/users/43081j/repos","events_url":"https://api.github.com/users/43081j/events{/privacy}","received_events_url":"https://api.github.com/users/43081j/received_events","type":"User","site_admin":false},"repo":{"id":57602249,"name":"polymer","full_name":"43081j/polymer","owner":{"login":"43081j","id":5677153,"avatar_url":"https://avatars1.githubusercontent.com/u/5677153?v=4","gravatar_id":"","url":"https://api.github.com/users/43081j","html_url":"https://github.com/43081j","followers_url":"https://api.github.com/users/43081j/followers","following_url":"https://api.github.com/users/43081j/following{/other_user}","gists_url":"https://api.github.com/users/43081j/gists{/gist_id}","starred_url":"https://api.github.com/users/43081j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/43081j/subscriptions","organizations_url":"https://api.github.com/users/43081j/orgs","repos_url":"https://api.github.com/users/43081j/repos","events_url":"https://api.github.com/users/43081j/events{/privacy}","received_events_url":"https://api.github.com/users/43081j/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/43081j/polymer","description":"Build modern apps using web components","fork":true,"url":"https://api.github.com/repos/43081j/polymer","forks_url":"https://api.github.com/repos/43081j/polymer/forks","keys_url":"https://api.github.com/repos/43081j/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/43081j/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/43081j/polymer/teams","hooks_url":"https://api.github.com/repos/43081j/polymer/hooks","issue_events_url":"https://api.github.com/repos/43081j/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/43081j/polymer/events","assignees_url":"https://api.github.com/repos/43081j/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/43081j/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/43081j/polymer/tags","blobs_url":"https://api.github.com/repos/43081j/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/43081j/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/43081j/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/43081j/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/43081j/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/43081j/polymer/languages","stargazers_url":"https://api.github.com/repos/43081j/polymer/stargazers","contributors_url":"https://api.github.com/repos/43081j/polymer/contributors","subscribers_url":"https://api.github.com/repos/43081j/polymer/subscribers","subscription_url":"https://api.github.com/repos/43081j/polymer/subscription","commits_url":"https://api.github.com/repos/43081j/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/43081j/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/43081j/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/43081j/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/43081j/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/43081j/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/43081j/polymer/merges","archive_url":"https://api.github.com/repos/43081j/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/43081j/polymer/downloads","issues_url":"https://api.github.com/repos/43081j/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/43081j/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/43081j/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/43081j/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/43081j/polymer/labels{/name}","releases_url":"https://api.github.com/repos/43081j/polymer/releases{/id}","deployments_url":"https://api.github.com/repos/43081j/polymer/deployments","created_at":"2016-05-01T14:42:58Z","updated_at":"2016-05-01T14:43:00Z","pushed_at":"2017-12-30T17:45:33Z","git_url":"git://github.com/43081j/polymer.git","ssh_url":"git@github.com:43081j/polymer.git","clone_url":"https://github.com/43081j/polymer.git","svn_url":"https://github.com/43081j/polymer","homepage":"https://www.polymer-project.org/1.0/","size":24068,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Polymer:master","ref":"master","sha":"62dcb724ab853fdddbdea04ec462cc973cab946b","user":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"repo":{"id":5532320,"name":"polymer","full_name":"Polymer/polymer","owner":{"login":"Polymer","id":2159051,"avatar_url":"https://avatars3.githubusercontent.com/u/2159051?v=4","gravatar_id":"","url":"https://api.github.com/users/Polymer","html_url":"https://github.com/Polymer","followers_url":"https://api.github.com/users/Polymer/followers","following_url":"https://api.github.com/users/Polymer/following{/other_user}","gists_url":"https://api.github.com/users/Polymer/gists{/gist_id}","starred_url":"https://api.github.com/users/Polymer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Polymer/subscriptions","organizations_url":"https://api.github.com/users/Polymer/orgs","repos_url":"https://api.github.com/users/Polymer/repos","events_url":"https://api.github.com/users/Polymer/events{/privacy}","received_events_url":"https://api.github.com/users/Polymer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Polymer/polymer","description":"Build modern apps using web components","fork":false,"url":"https://api.github.com/repos/Polymer/polymer","forks_url":"https://api.github.com/repos/Polymer/polymer/forks","keys_url":"https://api.github.com/repos/Polymer/polymer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Polymer/polymer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Polymer/polymer/teams","hooks_url":"https://api.github.com/repos/Polymer/polymer/hooks","issue_events_url":"https://api.github.com/repos/Polymer/polymer/issues/events{/number}","events_url":"https://api.github.com/repos/Polymer/polymer/events","assignees_url":"https://api.github.com/repos/Polymer/polymer/assignees{/user}","branches_url":"https://api.github.com/repos/Polymer/polymer/branches{/branch}","tags_url":"https://api.github.com/repos/Polymer/polymer/tags","blobs_url":"https://api.github.com/repos/Polymer/polymer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Polymer/polymer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Polymer/polymer/git/refs{/sha}","trees_url":"https://api.github.com/repos/Polymer/polymer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Polymer/polymer/statuses/{sha}","languages_url":"https://api.github.com/repos/Polymer/polymer/languages","stargazers_url":"https://api.github.com/repos/Polymer/polymer/stargazers","contributors_url":"https://api.github.com/repos/Polymer/polymer/contributors","subscribers_url":"https://api.github.com/repos/Polymer/polymer/subscribers","subscription_url":"https://api.github.com/repos/Polymer/polymer/subscription","commits_url":"https://api.github.com/repos/Polymer/polymer/commits{/sha}","git_commits_url":"https://api.github.com/repos/Polymer/polymer/git/commits{/sha}","comments_url":"https://api.github.com/repos/Polymer/polymer/comments{/number}","issue_comment_url":"https://api.github.com/repos/Polymer/polymer/issues/comments{/number}","contents_url":"https://api.github.com/repos/Polymer/polymer/contents/{+path}","compare_url":"https://api.github.com/repos/Polymer/polymer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Polymer/polymer/merges","archive_url":"https://api.github.com/repos/Polymer/polymer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Polymer/polymer/downloads","issues_url":"https://api.github.com/repos/Polymer/polymer/issues{/number}","pulls_url":"https://api.github.com/repos/Polymer/polymer/pulls{/number}","milestones_url":"https://api.github.com/repos/Polymer/polymer/milestones{/number}","notifications_url":"https://api.github.com/repos/Polymer/polymer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Polymer/polymer/labels{/name}","releases_url":"https://api.github.com/repos/Polymer/polymer/releases{/id}","deployments_url":"https://api.github.com/repos/Polymer/polymer/deployments","created_at":"2012-08-23T20:56:30Z","updated_at":"2017-12-30T14:40:29Z","pushed_at":"2017-12-30T17:45:34Z","git_url":"git://github.com/Polymer/polymer.git","ssh_url":"git@github.com:Polymer/polymer.git","clone_url":"https://github.com/Polymer/polymer.git","svn_url":"https://github.com/Polymer/polymer","homepage":"https://www.polymer-project.org/","size":24259,"stargazers_count":18953,"watchers_count":18953,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1900,"mirror_url":null,"archived":false,"open_issues_count":367,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1900,"open_issues":367,"watchers":18953,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/5000"},"html":{"href":"https://github.com/Polymer/polymer/pull/5000"},"issue":{"href":"https://api.github.com/repos/Polymer/polymer/issues/5000"},"comments":{"href":"https://api.github.com/repos/Polymer/polymer/issues/5000/comments"},"review_comments":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/5000/comments"},"review_comment":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Polymer/polymer/pulls/5000/commits"},"statuses":{"href":"https://api.github.com/repos/Polymer/polymer/statuses/67c6e5c3288421ec85a6a5d0fcb5d255405ba633"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"43081j"}}