{"action":"closed","number":10,"pull_request":{"url":"https://api.github.com/repos/Starlink/starjava/pulls/10","id":107012811,"html_url":"https://github.com/Starlink/starjava/pull/10","diff_url":"https://github.com/Starlink/starjava/pull/10.diff","patch_url":"https://github.com/Starlink/starjava/pull/10.patch","issue_url":"https://api.github.com/repos/Starlink/starjava/issues/10","number":10,"state":"closed","locked":false,"title":"fits: Remove non-free copy of writeUTF","user":{"login":"olebole","id":397223,"avatar_url":"https://avatars.githubusercontent.com/u/397223?v=3","gravatar_id":"","url":"https://api.github.com/users/olebole","html_url":"https://github.com/olebole","followers_url":"https://api.github.com/users/olebole/followers","following_url":"https://api.github.com/users/olebole/following{/other_user}","gists_url":"https://api.github.com/users/olebole/gists{/gist_id}","starred_url":"https://api.github.com/users/olebole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olebole/subscriptions","organizations_url":"https://api.github.com/users/olebole/orgs","repos_url":"https://api.github.com/users/olebole/repos","events_url":"https://api.github.com/users/olebole/events{/privacy}","received_events_url":"https://api.github.com/users/olebole/received_events","type":"User","site_admin":false},"body":"According to the header, `AbstractArrayDataIO.java` contains SUN PROPRIETARY/CONFIDENTIAL code from 2002 as the static function `writeUTF(string, java.io.DataOutput)`. Although this code is now non-confidential (see [JDK-9 source](http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/java.base/share/classes/java/io/DataOutputStream.java#l346)), it is still published under [GPL-2 *only*](http://hg.openjdk.java.net/jdk9/client/jdk/file/tip/src/java.base/share/classes/java/io/DataOutputStream.java#l6). Starjava itself is LGPL-3, which makes it incompatible with the code copied from Sun.\r\n\r\nThe commit replaces the `writeUTF()` method with a simple call of `getBytes()`. The idea comes from a [JDK issue](https://bugs.openjdk.java.net/browse/JDK-5096572).","created_at":"2017-02-20T14:09:34Z","updated_at":"2017-02-22T11:05:12Z","closed_at":"2017-02-22T11:05:12Z","merged_at":"2017-02-22T11:05:12Z","merge_commit_sha":"b8116ca607ec7f5c7e6e7a0e970251e41ad9f7d5","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Starlink/starjava/pulls/10/commits","review_comments_url":"https://api.github.com/repos/Starlink/starjava/pulls/10/comments","review_comment_url":"https://api.github.com/repos/Starlink/starjava/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Starlink/starjava/issues/10/comments","statuses_url":"https://api.github.com/repos/Starlink/starjava/statuses/54fecf1b1f4fa055e23345ae12475696a32ee6fc","head":{"label":"olebole:remove-non-free","ref":"remove-non-free","sha":"54fecf1b1f4fa055e23345ae12475696a32ee6fc","user":{"login":"olebole","id":397223,"avatar_url":"https://avatars.githubusercontent.com/u/397223?v=3","gravatar_id":"","url":"https://api.github.com/users/olebole","html_url":"https://github.com/olebole","followers_url":"https://api.github.com/users/olebole/followers","following_url":"https://api.github.com/users/olebole/following{/other_user}","gists_url":"https://api.github.com/users/olebole/gists{/gist_id}","starred_url":"https://api.github.com/users/olebole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olebole/subscriptions","organizations_url":"https://api.github.com/users/olebole/orgs","repos_url":"https://api.github.com/users/olebole/repos","events_url":"https://api.github.com/users/olebole/events{/privacy}","received_events_url":"https://api.github.com/users/olebole/received_events","type":"User","site_admin":false},"repo":{"id":82562983,"name":"starjava","full_name":"olebole/starjava","owner":{"login":"olebole","id":397223,"avatar_url":"https://avatars.githubusercontent.com/u/397223?v=3","gravatar_id":"","url":"https://api.github.com/users/olebole","html_url":"https://github.com/olebole","followers_url":"https://api.github.com/users/olebole/followers","following_url":"https://api.github.com/users/olebole/following{/other_user}","gists_url":"https://api.github.com/users/olebole/gists{/gist_id}","starred_url":"https://api.github.com/users/olebole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olebole/subscriptions","organizations_url":"https://api.github.com/users/olebole/orgs","repos_url":"https://api.github.com/users/olebole/repos","events_url":"https://api.github.com/users/olebole/events{/privacy}","received_events_url":"https://api.github.com/users/olebole/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/olebole/starjava","description":"Java applications initially developed for the Starlink Project but now developed independently","fork":true,"url":"https://api.github.com/repos/olebole/starjava","forks_url":"https://api.github.com/repos/olebole/starjava/forks","keys_url":"https://api.github.com/repos/olebole/starjava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/olebole/starjava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/olebole/starjava/teams","hooks_url":"https://api.github.com/repos/olebole/starjava/hooks","issue_events_url":"https://api.github.com/repos/olebole/starjava/issues/events{/number}","events_url":"https://api.github.com/repos/olebole/starjava/events","assignees_url":"https://api.github.com/repos/olebole/starjava/assignees{/user}","branches_url":"https://api.github.com/repos/olebole/starjava/branches{/branch}","tags_url":"https://api.github.com/repos/olebole/starjava/tags","blobs_url":"https://api.github.com/repos/olebole/starjava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/olebole/starjava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/olebole/starjava/git/refs{/sha}","trees_url":"https://api.github.com/repos/olebole/starjava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/olebole/starjava/statuses/{sha}","languages_url":"https://api.github.com/repos/olebole/starjava/languages","stargazers_url":"https://api.github.com/repos/olebole/starjava/stargazers","contributors_url":"https://api.github.com/repos/olebole/starjava/contributors","subscribers_url":"https://api.github.com/repos/olebole/starjava/subscribers","subscription_url":"https://api.github.com/repos/olebole/starjava/subscription","commits_url":"https://api.github.com/repos/olebole/starjava/commits{/sha}","git_commits_url":"https://api.github.com/repos/olebole/starjava/git/commits{/sha}","comments_url":"https://api.github.com/repos/olebole/starjava/comments{/number}","issue_comment_url":"https://api.github.com/repos/olebole/starjava/issues/comments{/number}","contents_url":"https://api.github.com/repos/olebole/starjava/contents/{+path}","compare_url":"https://api.github.com/repos/olebole/starjava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/olebole/starjava/merges","archive_url":"https://api.github.com/repos/olebole/starjava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/olebole/starjava/downloads","issues_url":"https://api.github.com/repos/olebole/starjava/issues{/number}","pulls_url":"https://api.github.com/repos/olebole/starjava/pulls{/number}","milestones_url":"https://api.github.com/repos/olebole/starjava/milestones{/number}","notifications_url":"https://api.github.com/repos/olebole/starjava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/olebole/starjava/labels{/name}","releases_url":"https://api.github.com/repos/olebole/starjava/releases{/id}","deployments_url":"https://api.github.com/repos/olebole/starjava/deployments","created_at":"2017-02-20T13:49:28Z","updated_at":"2017-02-20T13:50:10Z","pushed_at":"2017-02-22T10:35:23Z","git_url":"git://github.com/olebole/starjava.git","ssh_url":"git@github.com:olebole/starjava.git","clone_url":"https://github.com/olebole/starjava.git","svn_url":"https://github.com/olebole/starjava","homepage":null,"size":749144,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Starlink:master","ref":"master","sha":"3cd436f68d64c4177bfa08b4d72b0bd5880492b9","user":{"login":"Starlink","id":2018671,"avatar_url":"https://avatars.githubusercontent.com/u/2018671?v=3","gravatar_id":"","url":"https://api.github.com/users/Starlink","html_url":"https://github.com/Starlink","followers_url":"https://api.github.com/users/Starlink/followers","following_url":"https://api.github.com/users/Starlink/following{/other_user}","gists_url":"https://api.github.com/users/Starlink/gists{/gist_id}","starred_url":"https://api.github.com/users/Starlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starlink/subscriptions","organizations_url":"https://api.github.com/users/Starlink/orgs","repos_url":"https://api.github.com/users/Starlink/repos","events_url":"https://api.github.com/users/Starlink/events{/privacy}","received_events_url":"https://api.github.com/users/Starlink/received_events","type":"Organization","site_admin":false},"repo":{"id":9678936,"name":"starjava","full_name":"Starlink/starjava","owner":{"login":"Starlink","id":2018671,"avatar_url":"https://avatars.githubusercontent.com/u/2018671?v=3","gravatar_id":"","url":"https://api.github.com/users/Starlink","html_url":"https://github.com/Starlink","followers_url":"https://api.github.com/users/Starlink/followers","following_url":"https://api.github.com/users/Starlink/following{/other_user}","gists_url":"https://api.github.com/users/Starlink/gists{/gist_id}","starred_url":"https://api.github.com/users/Starlink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Starlink/subscriptions","organizations_url":"https://api.github.com/users/Starlink/orgs","repos_url":"https://api.github.com/users/Starlink/repos","events_url":"https://api.github.com/users/Starlink/events{/privacy}","received_events_url":"https://api.github.com/users/Starlink/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Starlink/starjava","description":"Java applications initially developed for the Starlink Project but now developed independently","fork":false,"url":"https://api.github.com/repos/Starlink/starjava","forks_url":"https://api.github.com/repos/Starlink/starjava/forks","keys_url":"https://api.github.com/repos/Starlink/starjava/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Starlink/starjava/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Starlink/starjava/teams","hooks_url":"https://api.github.com/repos/Starlink/starjava/hooks","issue_events_url":"https://api.github.com/repos/Starlink/starjava/issues/events{/number}","events_url":"https://api.github.com/repos/Starlink/starjava/events","assignees_url":"https://api.github.com/repos/Starlink/starjava/assignees{/user}","branches_url":"https://api.github.com/repos/Starlink/starjava/branches{/branch}","tags_url":"https://api.github.com/repos/Starlink/starjava/tags","blobs_url":"https://api.github.com/repos/Starlink/starjava/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Starlink/starjava/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Starlink/starjava/git/refs{/sha}","trees_url":"https://api.github.com/repos/Starlink/starjava/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Starlink/starjava/statuses/{sha}","languages_url":"https://api.github.com/repos/Starlink/starjava/languages","stargazers_url":"https://api.github.com/repos/Starlink/starjava/stargazers","contributors_url":"https://api.github.com/repos/Starlink/starjava/contributors","subscribers_url":"https://api.github.com/repos/Starlink/starjava/subscribers","subscription_url":"https://api.github.com/repos/Starlink/starjava/subscription","commits_url":"https://api.github.com/repos/Starlink/starjava/commits{/sha}","git_commits_url":"https://api.github.com/repos/Starlink/starjava/git/commits{/sha}","comments_url":"https://api.github.com/repos/Starlink/starjava/comments{/number}","issue_comment_url":"https://api.github.com/repos/Starlink/starjava/issues/comments{/number}","contents_url":"https://api.github.com/repos/Starlink/starjava/contents/{+path}","compare_url":"https://api.github.com/repos/Starlink/starjava/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Starlink/starjava/merges","archive_url":"https://api.github.com/repos/Starlink/starjava/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Starlink/starjava/downloads","issues_url":"https://api.github.com/repos/Starlink/starjava/issues{/number}","pulls_url":"https://api.github.com/repos/Starlink/starjava/pulls{/number}","milestones_url":"https://api.github.com/repos/Starlink/starjava/milestones{/number}","notifications_url":"https://api.github.com/repos/Starlink/starjava/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Starlink/starjava/labels{/name}","releases_url":"https://api.github.com/repos/Starlink/starjava/releases{/id}","deployments_url":"https://api.github.com/repos/Starlink/starjava/deployments","created_at":"2013-04-25T18:51:07Z","updated_at":"2017-02-20T15:37:01Z","pushed_at":"2017-02-22T11:05:12Z","git_url":"git://github.com/Starlink/starjava.git","ssh_url":"git@github.com:Starlink/starjava.git","clone_url":"https://github.com/Starlink/starjava.git","svn_url":"https://github.com/Starlink/starjava","homepage":null,"size":750106,"stargazers_count":31,"watchers_count":31,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":2,"forks":10,"open_issues":2,"watchers":31,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Starlink/starjava/pulls/10"},"html":{"href":"https://github.com/Starlink/starjava/pull/10"},"issue":{"href":"https://api.github.com/repos/Starlink/starjava/issues/10"},"comments":{"href":"https://api.github.com/repos/Starlink/starjava/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/Starlink/starjava/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/Starlink/starjava/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Starlink/starjava/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/Starlink/starjava/statuses/54fecf1b1f4fa055e23345ae12475696a32ee6fc"}},"merged":true,"mergeable":null,"mergeable_state":"unknown","merged_by":{"login":"mbtaylor","id":2581893,"avatar_url":"https://avatars.githubusercontent.com/u/2581893?v=3","gravatar_id":"","url":"https://api.github.com/users/mbtaylor","html_url":"https://github.com/mbtaylor","followers_url":"https://api.github.com/users/mbtaylor/followers","following_url":"https://api.github.com/users/mbtaylor/following{/other_user}","gists_url":"https://api.github.com/users/mbtaylor/gists{/gist_id}","starred_url":"https://api.github.com/users/mbtaylor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbtaylor/subscriptions","organizations_url":"https://api.github.com/users/mbtaylor/orgs","repos_url":"https://api.github.com/users/mbtaylor/repos","events_url":"https://api.github.com/users/mbtaylor/events{/privacy}","received_events_url":"https://api.github.com/users/mbtaylor/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":75,"changed_files":1}}
{"actor":{"display_login":"mbtaylor"}}