{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/131240693","pull_request_review_id":54201673,"id":131240693,"diff_hunk":"@@ -467,16 +467,20 @@ class HotRunner extends ResidentRunner {\n       final String entryPath = fs.path.relative(mainPath, from: projectRootPath);\n       if (benchmarkMode)\n         vmReloadTimer.start();\n-      Map<String, dynamic> reloadReport;\n-      final List<Future<Map<String, dynamic>>> reloadReports = <Future<Map<String, dynamic>>>[];\n+      final List<Future<Map<String, dynamic>>> reloadReportFutures = <Future<Map<String, dynamic>>>[];\n       for (FlutterDevice device in flutterDevices) {\n         final List<Future<Map<String, dynamic>>> reports = device.reloadSources(\n           entryPath,\n           pause: pause\n         );\n-        reloadReports.addAll(reports);\n+        reloadReportFutures.addAll(reports);\n       }\n-      reloadReport = (await Future.wait(reloadReports)).first;\n+      final List<Map<String, dynamic>> reloadReports = await Future.wait(reloadReportFutures);\n+      if (reloadReports.isEmpty) {","path":"packages/flutter_tools/lib/src/run_hot.dart","position":null,"original_position":17,"commit_id":"40f64b3b7ce8b892a5784d6f54f9b4bb91020a7b","original_commit_id":"b626b1ef7483fb6f97ce74f95c713024b3fdd337","user":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars3.githubusercontent.com/u/14226037?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"body":"done","created_at":"2017-08-03T19:41:01Z","updated_at":"2017-08-03T19:41:01Z","html_url":"https://github.com/flutter/flutter/pull/11504#discussion_r131240693","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/11504","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/131240693"},"html":{"href":"https://github.com/flutter/flutter/pull/11504#discussion_r131240693"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11504"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/11504","id":134022776,"html_url":"https://github.com/flutter/flutter/pull/11504","diff_url":"https://github.com/flutter/flutter/pull/11504.diff","patch_url":"https://github.com/flutter/flutter/pull/11504.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/11504","number":11504,"state":"open","locked":false,"title":"Do not throw if a hot reload is attempted when all Flutter instances on the device have been stopped","user":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars3.githubusercontent.com/u/14226037?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-03T19:27:11Z","updated_at":"2017-08-03T19:41:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"40de73e7693ef87ba76f9bf70333666e5e49a712","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/11504/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/11504/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/11504/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/40f64b3b7ce8b892a5784d6f54f9b4bb91020a7b","head":{"label":"jason-simmons:reload_sources_empty","ref":"reload_sources_empty","sha":"40f64b3b7ce8b892a5784d6f54f9b4bb91020a7b","user":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars3.githubusercontent.com/u/14226037?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"repo":{"id":45646006,"name":"flutter","full_name":"jason-simmons/flutter","owner":{"login":"jason-simmons","id":14226037,"avatar_url":"https://avatars3.githubusercontent.com/u/14226037?v=4","gravatar_id":"","url":"https://api.github.com/users/jason-simmons","html_url":"https://github.com/jason-simmons","followers_url":"https://api.github.com/users/jason-simmons/followers","following_url":"https://api.github.com/users/jason-simmons/following{/other_user}","gists_url":"https://api.github.com/users/jason-simmons/gists{/gist_id}","starred_url":"https://api.github.com/users/jason-simmons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jason-simmons/subscriptions","organizations_url":"https://api.github.com/users/jason-simmons/orgs","repos_url":"https://api.github.com/users/jason-simmons/repos","events_url":"https://api.github.com/users/jason-simmons/events{/privacy}","received_events_url":"https://api.github.com/users/jason-simmons/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jason-simmons/flutter","description":"The Flutter framework","fork":true,"url":"https://api.github.com/repos/jason-simmons/flutter","forks_url":"https://api.github.com/repos/jason-simmons/flutter/forks","keys_url":"https://api.github.com/repos/jason-simmons/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jason-simmons/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jason-simmons/flutter/teams","hooks_url":"https://api.github.com/repos/jason-simmons/flutter/hooks","issue_events_url":"https://api.github.com/repos/jason-simmons/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/jason-simmons/flutter/events","assignees_url":"https://api.github.com/repos/jason-simmons/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/jason-simmons/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/jason-simmons/flutter/tags","blobs_url":"https://api.github.com/repos/jason-simmons/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jason-simmons/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jason-simmons/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/jason-simmons/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jason-simmons/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/jason-simmons/flutter/languages","stargazers_url":"https://api.github.com/repos/jason-simmons/flutter/stargazers","contributors_url":"https://api.github.com/repos/jason-simmons/flutter/contributors","subscribers_url":"https://api.github.com/repos/jason-simmons/flutter/subscribers","subscription_url":"https://api.github.com/repos/jason-simmons/flutter/subscription","commits_url":"https://api.github.com/repos/jason-simmons/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/jason-simmons/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/jason-simmons/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/jason-simmons/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/jason-simmons/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/jason-simmons/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jason-simmons/flutter/merges","archive_url":"https://api.github.com/repos/jason-simmons/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jason-simmons/flutter/downloads","issues_url":"https://api.github.com/repos/jason-simmons/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/jason-simmons/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/jason-simmons/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/jason-simmons/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jason-simmons/flutter/labels{/name}","releases_url":"https://api.github.com/repos/jason-simmons/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/jason-simmons/flutter/deployments","created_at":"2015-11-05T23:27:10Z","updated_at":"2015-11-09T18:41:37Z","pushed_at":"2017-08-03T19:40:59Z","git_url":"git://github.com/jason-simmons/flutter.git","ssh_url":"git@github.com:jason-simmons/flutter.git","clone_url":"https://github.com/jason-simmons/flutter.git","svn_url":"https://github.com/jason-simmons/flutter","homepage":"http://flutter.io","size":28774,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"8ee902c04bb700daf64a49bef7398928415372f2","user":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"name":"flutter","full_name":"flutter/flutter","owner":{"login":"flutter","id":14101776,"avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2017-08-03T15:57:38Z","pushed_at":"2017-08-03T19:41:01Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":28779,"stargazers_count":5711,"watchers_count":5711,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":578,"mirror_url":null,"open_issues_count":1749,"forks":578,"open_issues":1749,"watchers":5711,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11504"},"html":{"href":"https://github.com/flutter/flutter/pull/11504"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/11504"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/11504/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11504/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/11504/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/40f64b3b7ce8b892a5784d6f54f9b4bb91020a7b"}}}}
{"actor":{"display_login":"jason-simmons"}}