{"action":"created","comment":{"url":"https://api.github.com/repos/lhc70000/iina/pulls/comments/111689357","pull_request_review_id":32948997,"id":111689357,"diff_hunk":"@@ -96,7 +116,7 @@ class KeyBindingDataLoader {\n   }\n \n   static private func propertiesForMultiply() -> [KeyBindingItem] {\n-    return propertyList.filter { $0.1 != .bool }.map { (str, type) -> KeyBindingItem in\n+    return propertyList.filter { $0.1 != .bool && $0.1 != .string }.map { (str, type) -> KeyBindingItem in","path":"iina/KeyBindingDataLoader.swift","position":59,"original_position":59,"commit_id":"27ede31cfdb323f0c406e3e36958bc5a2499e7cb","original_commit_id":"e504d650dd32b1f2b81cd20aadb416914061e046","user":{"login":"saagarjha","id":13786931,"avatar_url":"https://avatars2.githubusercontent.com/u/13786931?v=3","gravatar_id":"","url":"https://api.github.com/users/saagarjha","html_url":"https://github.com/saagarjha","followers_url":"https://api.github.com/users/saagarjha/followers","following_url":"https://api.github.com/users/saagarjha/following{/other_user}","gists_url":"https://api.github.com/users/saagarjha/gists{/gist_id}","starred_url":"https://api.github.com/users/saagarjha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saagarjha/subscriptions","organizations_url":"https://api.github.com/users/saagarjha/orgs","repos_url":"https://api.github.com/users/saagarjha/repos","events_url":"https://api.github.com/users/saagarjha/events{/privacy}","received_events_url":"https://api.github.com/users/saagarjha/received_events","type":"User","site_admin":false},"body":"Well, no, but `flatMap` only requires a single pass.","created_at":"2017-04-16T18:29:52Z","updated_at":"2017-04-16T18:29:52Z","html_url":"https://github.com/lhc70000/iina/pull/572#discussion_r111689357","pull_request_url":"https://api.github.com/repos/lhc70000/iina/pulls/572","_links":{"self":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/comments/111689357"},"html":{"href":"https://github.com/lhc70000/iina/pull/572#discussion_r111689357"},"pull_request":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/572"}}},"pull_request":{"url":"https://api.github.com/repos/lhc70000/iina/pulls/572","id":115928942,"html_url":"https://github.com/lhc70000/iina/pull/572","diff_url":"https://github.com/lhc70000/iina/pull/572.diff","patch_url":"https://github.com/lhc70000/iina/pull/572.patch","issue_url":"https://api.github.com/repos/lhc70000/iina/issues/572","number":572,"state":"open","locked":false,"title":"Better handling key bindings","user":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars0.githubusercontent.com/u/8478049?v=3","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"body":"Implementation of #569.\r\n","created_at":"2017-04-14T13:09:03Z","updated_at":"2017-04-16T18:29:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8526ab34d3dd4be095525d2b4b13d5b3eb25a2c4","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/lhc70000/iina/pulls/572/commits","review_comments_url":"https://api.github.com/repos/lhc70000/iina/pulls/572/comments","review_comment_url":"https://api.github.com/repos/lhc70000/iina/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lhc70000/iina/issues/572/comments","statuses_url":"https://api.github.com/repos/lhc70000/iina/statuses/27ede31cfdb323f0c406e3e36958bc5a2499e7cb","head":{"label":"lhc70000:parse-key-bindings","ref":"parse-key-bindings","sha":"27ede31cfdb323f0c406e3e36958bc5a2499e7cb","user":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars0.githubusercontent.com/u/8478049?v=3","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"repo":{"id":76838017,"name":"iina","full_name":"lhc70000/iina","owner":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars0.githubusercontent.com/u/8478049?v=3","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhc70000/iina","description":"The modern video player for macOS.","fork":false,"url":"https://api.github.com/repos/lhc70000/iina","forks_url":"https://api.github.com/repos/lhc70000/iina/forks","keys_url":"https://api.github.com/repos/lhc70000/iina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhc70000/iina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhc70000/iina/teams","hooks_url":"https://api.github.com/repos/lhc70000/iina/hooks","issue_events_url":"https://api.github.com/repos/lhc70000/iina/issues/events{/number}","events_url":"https://api.github.com/repos/lhc70000/iina/events","assignees_url":"https://api.github.com/repos/lhc70000/iina/assignees{/user}","branches_url":"https://api.github.com/repos/lhc70000/iina/branches{/branch}","tags_url":"https://api.github.com/repos/lhc70000/iina/tags","blobs_url":"https://api.github.com/repos/lhc70000/iina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhc70000/iina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhc70000/iina/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhc70000/iina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhc70000/iina/statuses/{sha}","languages_url":"https://api.github.com/repos/lhc70000/iina/languages","stargazers_url":"https://api.github.com/repos/lhc70000/iina/stargazers","contributors_url":"https://api.github.com/repos/lhc70000/iina/contributors","subscribers_url":"https://api.github.com/repos/lhc70000/iina/subscribers","subscription_url":"https://api.github.com/repos/lhc70000/iina/subscription","commits_url":"https://api.github.com/repos/lhc70000/iina/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhc70000/iina/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhc70000/iina/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhc70000/iina/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhc70000/iina/contents/{+path}","compare_url":"https://api.github.com/repos/lhc70000/iina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhc70000/iina/merges","archive_url":"https://api.github.com/repos/lhc70000/iina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhc70000/iina/downloads","issues_url":"https://api.github.com/repos/lhc70000/iina/issues{/number}","pulls_url":"https://api.github.com/repos/lhc70000/iina/pulls{/number}","milestones_url":"https://api.github.com/repos/lhc70000/iina/milestones{/number}","notifications_url":"https://api.github.com/repos/lhc70000/iina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhc70000/iina/labels{/name}","releases_url":"https://api.github.com/repos/lhc70000/iina/releases{/id}","deployments_url":"https://api.github.com/repos/lhc70000/iina/deployments","created_at":"2016-12-19T07:18:45Z","updated_at":"2017-04-16T16:33:46Z","pushed_at":"2017-04-16T14:46:53Z","git_url":"git://github.com/lhc70000/iina.git","ssh_url":"git@github.com:lhc70000/iina.git","clone_url":"https://github.com/lhc70000/iina.git","svn_url":"https://github.com/lhc70000/iina","homepage":"https://lhc70000.github.io/iina/","size":81455,"stargazers_count":5453,"watchers_count":5453,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":357,"mirror_url":null,"open_issues_count":174,"forks":357,"open_issues":174,"watchers":5453,"default_branch":"develop"}},"base":{"label":"lhc70000:develop","ref":"develop","sha":"b79fc2790ba3d0584d20aa9dd431ef4d6afd3206","user":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars0.githubusercontent.com/u/8478049?v=3","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"repo":{"id":76838017,"name":"iina","full_name":"lhc70000/iina","owner":{"login":"lhc70000","id":8478049,"avatar_url":"https://avatars0.githubusercontent.com/u/8478049?v=3","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lhc70000/iina","description":"The modern video player for macOS.","fork":false,"url":"https://api.github.com/repos/lhc70000/iina","forks_url":"https://api.github.com/repos/lhc70000/iina/forks","keys_url":"https://api.github.com/repos/lhc70000/iina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhc70000/iina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhc70000/iina/teams","hooks_url":"https://api.github.com/repos/lhc70000/iina/hooks","issue_events_url":"https://api.github.com/repos/lhc70000/iina/issues/events{/number}","events_url":"https://api.github.com/repos/lhc70000/iina/events","assignees_url":"https://api.github.com/repos/lhc70000/iina/assignees{/user}","branches_url":"https://api.github.com/repos/lhc70000/iina/branches{/branch}","tags_url":"https://api.github.com/repos/lhc70000/iina/tags","blobs_url":"https://api.github.com/repos/lhc70000/iina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhc70000/iina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhc70000/iina/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhc70000/iina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhc70000/iina/statuses/{sha}","languages_url":"https://api.github.com/repos/lhc70000/iina/languages","stargazers_url":"https://api.github.com/repos/lhc70000/iina/stargazers","contributors_url":"https://api.github.com/repos/lhc70000/iina/contributors","subscribers_url":"https://api.github.com/repos/lhc70000/iina/subscribers","subscription_url":"https://api.github.com/repos/lhc70000/iina/subscription","commits_url":"https://api.github.com/repos/lhc70000/iina/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhc70000/iina/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhc70000/iina/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhc70000/iina/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhc70000/iina/contents/{+path}","compare_url":"https://api.github.com/repos/lhc70000/iina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhc70000/iina/merges","archive_url":"https://api.github.com/repos/lhc70000/iina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhc70000/iina/downloads","issues_url":"https://api.github.com/repos/lhc70000/iina/issues{/number}","pulls_url":"https://api.github.com/repos/lhc70000/iina/pulls{/number}","milestones_url":"https://api.github.com/repos/lhc70000/iina/milestones{/number}","notifications_url":"https://api.github.com/repos/lhc70000/iina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhc70000/iina/labels{/name}","releases_url":"https://api.github.com/repos/lhc70000/iina/releases{/id}","deployments_url":"https://api.github.com/repos/lhc70000/iina/deployments","created_at":"2016-12-19T07:18:45Z","updated_at":"2017-04-16T16:33:46Z","pushed_at":"2017-04-16T14:46:53Z","git_url":"git://github.com/lhc70000/iina.git","ssh_url":"git@github.com:lhc70000/iina.git","clone_url":"https://github.com/lhc70000/iina.git","svn_url":"https://github.com/lhc70000/iina","homepage":"https://lhc70000.github.io/iina/","size":81455,"stargazers_count":5453,"watchers_count":5453,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":357,"mirror_url":null,"open_issues_count":174,"forks":357,"open_issues":174,"watchers":5453,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/572"},"html":{"href":"https://github.com/lhc70000/iina/pull/572"},"issue":{"href":"https://api.github.com/repos/lhc70000/iina/issues/572"},"comments":{"href":"https://api.github.com/repos/lhc70000/iina/issues/572/comments"},"review_comments":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/572/comments"},"review_comment":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/572/commits"},"statuses":{"href":"https://api.github.com/repos/lhc70000/iina/statuses/27ede31cfdb323f0c406e3e36958bc5a2499e7cb"}}}}
{"actor":{"display_login":"saagarjha"}}