{"action":"created","comment":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/comments/111566865","pull_request_review_id":32821934,"id":111566865,"diff_hunk":"@@ -118,9 +118,43 @@\n     end\n   end\n \n+  shared_examples 'sign up with openid provider' do |provider|\n+    scenario \"#{provider} has option to log in\" do\n+      visit '/accounts/sign_in'\n+      expect(page.has_content?('or sign in using')).to be true","path":"spec/features/omniauth_spec.rb","position":7,"original_position":7,"commit_id":"6ae78d4cb9f6162b0aecae82f46529013c0ae124","original_commit_id":"6ae78d4cb9f6162b0aecae82f46529013c0ae124","user":{"login":"differentreality","id":4322737,"avatar_url":"https://avatars2.githubusercontent.com/u/4322737?v=3","gravatar_id":"","url":"https://api.github.com/users/differentreality","html_url":"https://github.com/differentreality","followers_url":"https://api.github.com/users/differentreality/followers","following_url":"https://api.github.com/users/differentreality/following{/other_user}","gists_url":"https://api.github.com/users/differentreality/gists{/gist_id}","starred_url":"https://api.github.com/users/differentreality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/differentreality/subscriptions","organizations_url":"https://api.github.com/users/differentreality/orgs","repos_url":"https://api.github.com/users/differentreality/repos","events_url":"https://api.github.com/users/differentreality/events{/privacy}","received_events_url":"https://api.github.com/users/differentreality/received_events","type":"User","site_admin":false},"body":"You can use `eq` instead of `be` here as well.","created_at":"2017-04-14T12:17:02Z","updated_at":"2017-04-14T12:17:07Z","html_url":"https://github.com/openSUSE/osem/pull/1452#discussion_r111566865","pull_request_url":"https://api.github.com/repos/openSUSE/osem/pulls/1452","_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments/111566865"},"html":{"href":"https://github.com/openSUSE/osem/pull/1452#discussion_r111566865"},"pull_request":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/1452"}}},"pull_request":{"url":"https://api.github.com/repos/openSUSE/osem/pulls/1452","id":115909693,"html_url":"https://github.com/openSUSE/osem/pull/1452","diff_url":"https://github.com/openSUSE/osem/pull/1452.diff","patch_url":"https://github.com/openSUSE/osem/pull/1452.patch","issue_url":"https://api.github.com/repos/openSUSE/osem/issues/1452","number":1452,"state":"open","locked":false,"title":"Normalize openid mock accounts' credentials and add tests","user":{"login":"AEtherC0r3","id":3638310,"avatar_url":"https://avatars2.githubusercontent.com/u/3638310?v=3","gravatar_id":"","url":"https://api.github.com/users/AEtherC0r3","html_url":"https://github.com/AEtherC0r3","followers_url":"https://api.github.com/users/AEtherC0r3/followers","following_url":"https://api.github.com/users/AEtherC0r3/following{/other_user}","gists_url":"https://api.github.com/users/AEtherC0r3/gists{/gist_id}","starred_url":"https://api.github.com/users/AEtherC0r3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AEtherC0r3/subscriptions","organizations_url":"https://api.github.com/users/AEtherC0r3/orgs","repos_url":"https://api.github.com/users/AEtherC0r3/repos","events_url":"https://api.github.com/users/AEtherC0r3/events{/privacy}","received_events_url":"https://api.github.com/users/AEtherC0r3/received_events","type":"User","site_admin":false},"body":"Issue:\r\n1. The emails of the mock accounts use email.com which is neither reserved nor controlled by osem\r\n2. The credentials of the mock accounts are arbitrary, thus they don't indicate to the user/developer the provider with which they are associated (in the web interface)\r\n3. The available specs don't test signup for every supported provider\r\n\r\nSolution:\r\n1.  Change email.com to example.com\r\n2. Change the credentials to comply with the following patterns:\r\n    * name: 'provider user'\r\n    * email: 'user-provider@example.com'\r\n    * username: 'userProvider'\r\n3. Add relevant tests and a \"trap\" to catch changes to the supported providers (addition, renaming, removal)\r\n\r\nCloses #1365 ","created_at":"2017-04-14T09:49:39Z","updated_at":"2017-04-14T12:17:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bc28db1bead702ea3dcb83ec5c3358b563679b1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openSUSE/osem/pulls/1452/commits","review_comments_url":"https://api.github.com/repos/openSUSE/osem/pulls/1452/comments","review_comment_url":"https://api.github.com/repos/openSUSE/osem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openSUSE/osem/issues/1452/comments","statuses_url":"https://api.github.com/repos/openSUSE/osem/statuses/6ae78d4cb9f6162b0aecae82f46529013c0ae124","head":{"label":"AEtherC0r3:openid_improvements","ref":"openid_improvements","sha":"6ae78d4cb9f6162b0aecae82f46529013c0ae124","user":{"login":"AEtherC0r3","id":3638310,"avatar_url":"https://avatars2.githubusercontent.com/u/3638310?v=3","gravatar_id":"","url":"https://api.github.com/users/AEtherC0r3","html_url":"https://github.com/AEtherC0r3","followers_url":"https://api.github.com/users/AEtherC0r3/followers","following_url":"https://api.github.com/users/AEtherC0r3/following{/other_user}","gists_url":"https://api.github.com/users/AEtherC0r3/gists{/gist_id}","starred_url":"https://api.github.com/users/AEtherC0r3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AEtherC0r3/subscriptions","organizations_url":"https://api.github.com/users/AEtherC0r3/orgs","repos_url":"https://api.github.com/users/AEtherC0r3/repos","events_url":"https://api.github.com/users/AEtherC0r3/events{/privacy}","received_events_url":"https://api.github.com/users/AEtherC0r3/received_events","type":"User","site_admin":false},"repo":{"id":68840751,"name":"osem","full_name":"AEtherC0r3/osem","owner":{"login":"AEtherC0r3","id":3638310,"avatar_url":"https://avatars2.githubusercontent.com/u/3638310?v=3","gravatar_id":"","url":"https://api.github.com/users/AEtherC0r3","html_url":"https://github.com/AEtherC0r3","followers_url":"https://api.github.com/users/AEtherC0r3/followers","following_url":"https://api.github.com/users/AEtherC0r3/following{/other_user}","gists_url":"https://api.github.com/users/AEtherC0r3/gists{/gist_id}","starred_url":"https://api.github.com/users/AEtherC0r3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AEtherC0r3/subscriptions","organizations_url":"https://api.github.com/users/AEtherC0r3/orgs","repos_url":"https://api.github.com/users/AEtherC0r3/repos","events_url":"https://api.github.com/users/AEtherC0r3/events{/privacy}","received_events_url":"https://api.github.com/users/AEtherC0r3/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AEtherC0r3/osem","description":"Open Source Event Manager. An event management tool tailored to Free and Open Source Software conferences.","fork":true,"url":"https://api.github.com/repos/AEtherC0r3/osem","forks_url":"https://api.github.com/repos/AEtherC0r3/osem/forks","keys_url":"https://api.github.com/repos/AEtherC0r3/osem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AEtherC0r3/osem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AEtherC0r3/osem/teams","hooks_url":"https://api.github.com/repos/AEtherC0r3/osem/hooks","issue_events_url":"https://api.github.com/repos/AEtherC0r3/osem/issues/events{/number}","events_url":"https://api.github.com/repos/AEtherC0r3/osem/events","assignees_url":"https://api.github.com/repos/AEtherC0r3/osem/assignees{/user}","branches_url":"https://api.github.com/repos/AEtherC0r3/osem/branches{/branch}","tags_url":"https://api.github.com/repos/AEtherC0r3/osem/tags","blobs_url":"https://api.github.com/repos/AEtherC0r3/osem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AEtherC0r3/osem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AEtherC0r3/osem/git/refs{/sha}","trees_url":"https://api.github.com/repos/AEtherC0r3/osem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AEtherC0r3/osem/statuses/{sha}","languages_url":"https://api.github.com/repos/AEtherC0r3/osem/languages","stargazers_url":"https://api.github.com/repos/AEtherC0r3/osem/stargazers","contributors_url":"https://api.github.com/repos/AEtherC0r3/osem/contributors","subscribers_url":"https://api.github.com/repos/AEtherC0r3/osem/subscribers","subscription_url":"https://api.github.com/repos/AEtherC0r3/osem/subscription","commits_url":"https://api.github.com/repos/AEtherC0r3/osem/commits{/sha}","git_commits_url":"https://api.github.com/repos/AEtherC0r3/osem/git/commits{/sha}","comments_url":"https://api.github.com/repos/AEtherC0r3/osem/comments{/number}","issue_comment_url":"https://api.github.com/repos/AEtherC0r3/osem/issues/comments{/number}","contents_url":"https://api.github.com/repos/AEtherC0r3/osem/contents/{+path}","compare_url":"https://api.github.com/repos/AEtherC0r3/osem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AEtherC0r3/osem/merges","archive_url":"https://api.github.com/repos/AEtherC0r3/osem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AEtherC0r3/osem/downloads","issues_url":"https://api.github.com/repos/AEtherC0r3/osem/issues{/number}","pulls_url":"https://api.github.com/repos/AEtherC0r3/osem/pulls{/number}","milestones_url":"https://api.github.com/repos/AEtherC0r3/osem/milestones{/number}","notifications_url":"https://api.github.com/repos/AEtherC0r3/osem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AEtherC0r3/osem/labels{/name}","releases_url":"https://api.github.com/repos/AEtherC0r3/osem/releases{/id}","deployments_url":"https://api.github.com/repos/AEtherC0r3/osem/deployments","created_at":"2016-09-21T17:21:13Z","updated_at":"2016-09-21T17:21:15Z","pushed_at":"2017-04-14T09:07:01Z","git_url":"git://github.com/AEtherC0r3/osem.git","ssh_url":"git@github.com:AEtherC0r3/osem.git","clone_url":"https://github.com/AEtherC0r3/osem.git","svn_url":"https://github.com/AEtherC0r3/osem","homepage":"http://osem.io","size":39433,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openSUSE:master","ref":"master","sha":"46a6a59622f8702e08495bee0191879a5c603774","user":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars1.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":5911225,"name":"osem","full_name":"openSUSE/osem","owner":{"login":"openSUSE","id":623819,"avatar_url":"https://avatars1.githubusercontent.com/u/623819?v=3","gravatar_id":"","url":"https://api.github.com/users/openSUSE","html_url":"https://github.com/openSUSE","followers_url":"https://api.github.com/users/openSUSE/followers","following_url":"https://api.github.com/users/openSUSE/following{/other_user}","gists_url":"https://api.github.com/users/openSUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/openSUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openSUSE/subscriptions","organizations_url":"https://api.github.com/users/openSUSE/orgs","repos_url":"https://api.github.com/users/openSUSE/repos","events_url":"https://api.github.com/users/openSUSE/events{/privacy}","received_events_url":"https://api.github.com/users/openSUSE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openSUSE/osem","description":"Open Source Event Manager. An event management tool tailored to Free and Open Source Software conferences.","fork":false,"url":"https://api.github.com/repos/openSUSE/osem","forks_url":"https://api.github.com/repos/openSUSE/osem/forks","keys_url":"https://api.github.com/repos/openSUSE/osem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openSUSE/osem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openSUSE/osem/teams","hooks_url":"https://api.github.com/repos/openSUSE/osem/hooks","issue_events_url":"https://api.github.com/repos/openSUSE/osem/issues/events{/number}","events_url":"https://api.github.com/repos/openSUSE/osem/events","assignees_url":"https://api.github.com/repos/openSUSE/osem/assignees{/user}","branches_url":"https://api.github.com/repos/openSUSE/osem/branches{/branch}","tags_url":"https://api.github.com/repos/openSUSE/osem/tags","blobs_url":"https://api.github.com/repos/openSUSE/osem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openSUSE/osem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openSUSE/osem/git/refs{/sha}","trees_url":"https://api.github.com/repos/openSUSE/osem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openSUSE/osem/statuses/{sha}","languages_url":"https://api.github.com/repos/openSUSE/osem/languages","stargazers_url":"https://api.github.com/repos/openSUSE/osem/stargazers","contributors_url":"https://api.github.com/repos/openSUSE/osem/contributors","subscribers_url":"https://api.github.com/repos/openSUSE/osem/subscribers","subscription_url":"https://api.github.com/repos/openSUSE/osem/subscription","commits_url":"https://api.github.com/repos/openSUSE/osem/commits{/sha}","git_commits_url":"https://api.github.com/repos/openSUSE/osem/git/commits{/sha}","comments_url":"https://api.github.com/repos/openSUSE/osem/comments{/number}","issue_comment_url":"https://api.github.com/repos/openSUSE/osem/issues/comments{/number}","contents_url":"https://api.github.com/repos/openSUSE/osem/contents/{+path}","compare_url":"https://api.github.com/repos/openSUSE/osem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openSUSE/osem/merges","archive_url":"https://api.github.com/repos/openSUSE/osem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openSUSE/osem/downloads","issues_url":"https://api.github.com/repos/openSUSE/osem/issues{/number}","pulls_url":"https://api.github.com/repos/openSUSE/osem/pulls{/number}","milestones_url":"https://api.github.com/repos/openSUSE/osem/milestones{/number}","notifications_url":"https://api.github.com/repos/openSUSE/osem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openSUSE/osem/labels{/name}","releases_url":"https://api.github.com/repos/openSUSE/osem/releases{/id}","deployments_url":"https://api.github.com/repos/openSUSE/osem/deployments","created_at":"2012-09-22T07:40:18Z","updated_at":"2017-04-13T17:48:02Z","pushed_at":"2017-04-14T09:49:39Z","git_url":"git://github.com/openSUSE/osem.git","ssh_url":"git@github.com:openSUSE/osem.git","clone_url":"https://github.com/openSUSE/osem.git","svn_url":"https://github.com/openSUSE/osem","homepage":"http://osem.io","size":39431,"stargazers_count":260,"watchers_count":260,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":222,"mirror_url":null,"open_issues_count":170,"forks":222,"open_issues":170,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/1452"},"html":{"href":"https://github.com/openSUSE/osem/pull/1452"},"issue":{"href":"https://api.github.com/repos/openSUSE/osem/issues/1452"},"comments":{"href":"https://api.github.com/repos/openSUSE/osem/issues/1452/comments"},"review_comments":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/1452/comments"},"review_comment":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openSUSE/osem/pulls/1452/commits"},"statuses":{"href":"https://api.github.com/repos/openSUSE/osem/statuses/6ae78d4cb9f6162b0aecae82f46529013c0ae124"}}}}
{"actor":{"display_login":"differentreality"}}