{"action":"created","issue":{"url":"https://api.github.com/repos/src-d/go-billy/issues/35","repository_url":"https://api.github.com/repos/src-d/go-billy","labels_url":"https://api.github.com/repos/src-d/go-billy/issues/35/labels{/name}","comments_url":"https://api.github.com/repos/src-d/go-billy/issues/35/comments","events_url":"https://api.github.com/repos/src-d/go-billy/issues/35/events","html_url":"https://github.com/src-d/go-billy/pull/35","id":236325872,"number":35,"title":"helper: new polyfill helper, and mount and chroot simplification","user":{"login":"mcuadros","id":1573114,"avatar_url":"https://avatars3.githubusercontent.com/u/1573114?v=3","gravatar_id":"","url":"https://api.github.com/users/mcuadros","html_url":"https://github.com/mcuadros","followers_url":"https://api.github.com/users/mcuadros/followers","following_url":"https://api.github.com/users/mcuadros/following{/other_user}","gists_url":"https://api.github.com/users/mcuadros/gists{/gist_id}","starred_url":"https://api.github.com/users/mcuadros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcuadros/subscriptions","organizations_url":"https://api.github.com/users/mcuadros/orgs","repos_url":"https://api.github.com/users/mcuadros/repos","events_url":"https://api.github.com/users/mcuadros/events{/privacy}","received_events_url":"https://api.github.com/users/mcuadros/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-06-15T21:58:29Z","updated_at":"2017-06-15T22:03:30Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/src-d/go-billy/pulls/35","html_url":"https://github.com/src-d/go-billy/pull/35","diff_url":"https://github.com/src-d/go-billy/pull/35.diff","patch_url":"https://github.com/src-d/go-billy/pull/35.patch"},"body":"After implementing the approach of split interfaces, I found a lot of frictions. So I decided to instead of work with partial implementation, help to the a Filesystem be filled with the missing method, to much the interface.\r\n\r\nThe previous approach fails at implementation like go-billy-siva, where has a very strong limitations, such not being able to read on file where are you writing, rename not being supported, etc. This ends with the idea that could be useful assert by interface if a fs fits the requirements, since the limitations transcend the interface limits. \r\n\r\n"},"comment":{"url":"https://api.github.com/repos/src-d/go-billy/issues/comments/308878334","html_url":"https://github.com/src-d/go-billy/pull/35#issuecomment-308878334","issue_url":"https://api.github.com/repos/src-d/go-billy/issues/35","id":308878334,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars1.githubusercontent.com/in/254?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2017-06-15T22:03:30Z","updated_at":"2017-06-15T22:03:30Z","body":"# [Codecov](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=h1) Report\n> Merging [#35](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=desc) into [master](https://codecov.io/gh/src-d/go-billy/commit/bfa45f02dce70a88802a0cccf0ac3391a9eca5ba?src=pr&el=desc) will **decrease** coverage by `1.88%`.\n> The diff coverage is `76%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/src-d/go-billy/pull/35/graphs/tree.svg?src=pr&token=CrXuQgpLeX&width=650&height=150)](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master      #35      +/-   ##\n==========================================\n- Coverage   88.41%   86.53%   -1.89%     \n==========================================\n  Files           6        7       +1     \n  Lines         630      646      +16     \n==========================================\n+ Hits          557      559       +2     \n- Misses         41       55      +14     \n  Partials       32       32\n```\n\n\n| [Impacted Files](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [helper/chroot/chroot.go](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=tree#diff-aGVscGVyL2Nocm9vdC9jaHJvb3QuZ28=) | `87.5% <100%> (+1.58%)` | :arrow_up: |\n| [helper/mount/mount.go](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=tree#diff-aGVscGVyL21vdW50L21vdW50Lmdv) | `80.43% <60%> (-5.48%)` | :arrow_down: |\n| [helper/polyfill/polyfill.go](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=tree#diff-aGVscGVyL3BvbHlmaWxsL3BvbHlmaWxsLmdv) | `75.6% <75.6%> (ø)` | |\n| [osfs/os.go](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=tree#diff-b3Nmcy9vcy5nbw==) | `71.42% <0%> (-4.09%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=footer). Last update [bfa45f0...572c6f8](https://codecov.io/gh/src-d/go-billy/pull/35?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}