{"action":"created","comment":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments/112659643","pull_request_review_id":33991363,"id":112659643,"diff_hunk":"@@ -99,6 +99,8 @@ check-changelog: $(BEST_PY3)\n \t$(BEST_PY3) scripts/check-changelog.py\n \n deploy: $(TOOL_VIRTUALENV)\n+\topenssl aes-256-cbc -K $encrypted_39cb4cc39a80_key -iv $encrypted_39cb4cc39a80_iv -in secrets.tar.enc -out secrets.tar -d","path":"Makefile","position":4,"original_position":4,"commit_id":"d6e2e2288927a74973a6b1b35c51e4e2ec0740b8","original_commit_id":"d6e2e2288927a74973a6b1b35c51e4e2ec0740b8","user":{"login":"DRMacIver","id":28623,"avatar_url":"https://avatars3.githubusercontent.com/u/28623?v=3","gravatar_id":"","url":"https://api.github.com/users/DRMacIver","html_url":"https://github.com/DRMacIver","followers_url":"https://api.github.com/users/DRMacIver/followers","following_url":"https://api.github.com/users/DRMacIver/following{/other_user}","gists_url":"https://api.github.com/users/DRMacIver/gists{/gist_id}","starred_url":"https://api.github.com/users/DRMacIver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DRMacIver/subscriptions","organizations_url":"https://api.github.com/users/DRMacIver/orgs","repos_url":"https://api.github.com/users/DRMacIver/repos","events_url":"https://api.github.com/users/DRMacIver/events{/privacy}","received_events_url":"https://api.github.com/users/DRMacIver/received_events","type":"User","site_admin":false},"body":"I am in fact sure that it does not: https://travis-ci.org/HypothesisWorks/hypothesis-python/jobs/224285869\r\n\r\nThis is part of why I wanted it to run on every job.","created_at":"2017-04-21T10:30:04Z","updated_at":"2017-04-21T10:30:04Z","html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/554#discussion_r112659643","pull_request_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/554","_links":{"self":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments/112659643"},"html":{"href":"https://github.com/HypothesisWorks/hypothesis-python/pull/554#discussion_r112659643"},"pull_request":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/554"}}},"pull_request":{"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/554","id":116949510,"html_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/554","diff_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/554.diff","patch_url":"https://github.com/HypothesisWorks/hypothesis-python/pull/554.patch","issue_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/554","number":554,"state":"open","locked":false,"title":"Move secret decryption to deploy task","user":{"login":"DRMacIver","id":28623,"avatar_url":"https://avatars3.githubusercontent.com/u/28623?v=3","gravatar_id":"","url":"https://api.github.com/users/DRMacIver","html_url":"https://github.com/DRMacIver","followers_url":"https://api.github.com/users/DRMacIver/followers","following_url":"https://api.github.com/users/DRMacIver/following{/other_user}","gists_url":"https://api.github.com/users/DRMacIver/gists{/gist_id}","starred_url":"https://api.github.com/users/DRMacIver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DRMacIver/subscriptions","organizations_url":"https://api.github.com/users/DRMacIver/orgs","repos_url":"https://api.github.com/users/DRMacIver/repos","events_url":"https://api.github.com/users/DRMacIver/events{/privacy}","received_events_url":"https://api.github.com/users/DRMacIver/received_events","type":"User","site_admin":false},"body":"First item in #551\r\n\r\nEvery time I encrypt a new file this causes Travis to change its decryption key. This means that under the recommended way of decrypting (in a before\\_install) *every single job in every single branch will start failing*.\r\n\r\nThis change instead localises those failures to the deploy task by running the decryption from the makefile. This will still be slightly annoying but I think is reasonable for detecting problems in the deployment before merge.","created_at":"2017-04-21T09:50:52Z","updated_at":"2017-04-21T10:30:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d7db4340dabbe1d8c93b0ae8cf9782789d0f9ee","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/554/commits","review_comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/554/comments","review_comment_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/554/comments","statuses_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/d6e2e2288927a74973a6b1b35c51e4e2ec0740b8","head":{"label":"HypothesisWorks:DRMacIver/secret-keeping","ref":"DRMacIver/secret-keeping","sha":"d6e2e2288927a74973a6b1b35c51e4e2ec0740b8","user":{"login":"HypothesisWorks","id":18481919,"avatar_url":"https://avatars2.githubusercontent.com/u/18481919?v=3","gravatar_id":"","url":"https://api.github.com/users/HypothesisWorks","html_url":"https://github.com/HypothesisWorks","followers_url":"https://api.github.com/users/HypothesisWorks/followers","following_url":"https://api.github.com/users/HypothesisWorks/following{/other_user}","gists_url":"https://api.github.com/users/HypothesisWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/HypothesisWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HypothesisWorks/subscriptions","organizations_url":"https://api.github.com/users/HypothesisWorks/orgs","repos_url":"https://api.github.com/users/HypothesisWorks/repos","events_url":"https://api.github.com/users/HypothesisWorks/events{/privacy}","received_events_url":"https://api.github.com/users/HypothesisWorks/received_events","type":"Organization","site_admin":false},"repo":{"id":8685799,"name":"hypothesis-python","full_name":"HypothesisWorks/hypothesis-python","owner":{"login":"HypothesisWorks","id":18481919,"avatar_url":"https://avatars2.githubusercontent.com/u/18481919?v=3","gravatar_id":"","url":"https://api.github.com/users/HypothesisWorks","html_url":"https://github.com/HypothesisWorks","followers_url":"https://api.github.com/users/HypothesisWorks/followers","following_url":"https://api.github.com/users/HypothesisWorks/following{/other_user}","gists_url":"https://api.github.com/users/HypothesisWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/HypothesisWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HypothesisWorks/subscriptions","organizations_url":"https://api.github.com/users/HypothesisWorks/orgs","repos_url":"https://api.github.com/users/HypothesisWorks/repos","events_url":"https://api.github.com/users/HypothesisWorks/events{/privacy}","received_events_url":"https://api.github.com/users/HypothesisWorks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HypothesisWorks/hypothesis-python","description":"Advanced property-based (QuickCheck-like) testing for Python","fork":false,"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python","forks_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/forks","keys_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/teams","hooks_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/hooks","issue_events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/events{/number}","events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/events","assignees_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/assignees{/user}","branches_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/branches{/branch}","tags_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/tags","blobs_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/{sha}","languages_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/languages","stargazers_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/stargazers","contributors_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/contributors","subscribers_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/subscribers","subscription_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/subscription","commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/contents/{+path}","compare_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/merges","archive_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/downloads","issues_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues{/number}","pulls_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls{/number}","milestones_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/milestones{/number}","notifications_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/labels{/name}","releases_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/releases{/id}","deployments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/deployments","created_at":"2013-03-10T13:51:19Z","updated_at":"2017-04-21T01:27:07Z","pushed_at":"2017-04-21T10:27:28Z","git_url":"git://github.com/HypothesisWorks/hypothesis-python.git","ssh_url":"git@github.com:HypothesisWorks/hypothesis-python.git","clone_url":"https://github.com/HypothesisWorks/hypothesis-python.git","svn_url":"https://github.com/HypothesisWorks/hypothesis-python","homepage":"http://hypothesis.works","size":5950,"stargazers_count":1859,"watchers_count":1859,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":113,"forks":168,"open_issues":113,"watchers":1859,"default_branch":"master"}},"base":{"label":"HypothesisWorks:master","ref":"master","sha":"aeb5051e0a3b9764552a6c0dada8bf621b11df99","user":{"login":"HypothesisWorks","id":18481919,"avatar_url":"https://avatars2.githubusercontent.com/u/18481919?v=3","gravatar_id":"","url":"https://api.github.com/users/HypothesisWorks","html_url":"https://github.com/HypothesisWorks","followers_url":"https://api.github.com/users/HypothesisWorks/followers","following_url":"https://api.github.com/users/HypothesisWorks/following{/other_user}","gists_url":"https://api.github.com/users/HypothesisWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/HypothesisWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HypothesisWorks/subscriptions","organizations_url":"https://api.github.com/users/HypothesisWorks/orgs","repos_url":"https://api.github.com/users/HypothesisWorks/repos","events_url":"https://api.github.com/users/HypothesisWorks/events{/privacy}","received_events_url":"https://api.github.com/users/HypothesisWorks/received_events","type":"Organization","site_admin":false},"repo":{"id":8685799,"name":"hypothesis-python","full_name":"HypothesisWorks/hypothesis-python","owner":{"login":"HypothesisWorks","id":18481919,"avatar_url":"https://avatars2.githubusercontent.com/u/18481919?v=3","gravatar_id":"","url":"https://api.github.com/users/HypothesisWorks","html_url":"https://github.com/HypothesisWorks","followers_url":"https://api.github.com/users/HypothesisWorks/followers","following_url":"https://api.github.com/users/HypothesisWorks/following{/other_user}","gists_url":"https://api.github.com/users/HypothesisWorks/gists{/gist_id}","starred_url":"https://api.github.com/users/HypothesisWorks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HypothesisWorks/subscriptions","organizations_url":"https://api.github.com/users/HypothesisWorks/orgs","repos_url":"https://api.github.com/users/HypothesisWorks/repos","events_url":"https://api.github.com/users/HypothesisWorks/events{/privacy}","received_events_url":"https://api.github.com/users/HypothesisWorks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HypothesisWorks/hypothesis-python","description":"Advanced property-based (QuickCheck-like) testing for Python","fork":false,"url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python","forks_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/forks","keys_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/teams","hooks_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/hooks","issue_events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/events{/number}","events_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/events","assignees_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/assignees{/user}","branches_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/branches{/branch}","tags_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/tags","blobs_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/{sha}","languages_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/languages","stargazers_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/stargazers","contributors_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/contributors","subscribers_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/subscribers","subscription_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/subscription","commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/contents/{+path}","compare_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/merges","archive_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/downloads","issues_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues{/number}","pulls_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls{/number}","milestones_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/milestones{/number}","notifications_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/labels{/name}","releases_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/releases{/id}","deployments_url":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/deployments","created_at":"2013-03-10T13:51:19Z","updated_at":"2017-04-21T01:27:07Z","pushed_at":"2017-04-21T10:27:28Z","git_url":"git://github.com/HypothesisWorks/hypothesis-python.git","ssh_url":"git@github.com:HypothesisWorks/hypothesis-python.git","clone_url":"https://github.com/HypothesisWorks/hypothesis-python.git","svn_url":"https://github.com/HypothesisWorks/hypothesis-python","homepage":"http://hypothesis.works","size":5950,"stargazers_count":1859,"watchers_count":1859,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":168,"mirror_url":null,"open_issues_count":113,"forks":168,"open_issues":113,"watchers":1859,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/554"},"html":{"href":"https://github.com/HypothesisWorks/hypothesis-python/pull/554"},"issue":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/554"},"comments":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/issues/554/comments"},"review_comments":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/554/comments"},"review_comment":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/pulls/554/commits"},"statuses":{"href":"https://api.github.com/repos/HypothesisWorks/hypothesis-python/statuses/d6e2e2288927a74973a6b1b35c51e4e2ec0740b8"}}}}
{"actor":{"display_login":"DRMacIver"}}