{"action":"created","issue":{"url":"https://api.github.com/repos/nmoehrle/libacc/issues/2","repository_url":"https://api.github.com/repos/nmoehrle/libacc","labels_url":"https://api.github.com/repos/nmoehrle/libacc/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/nmoehrle/libacc/issues/2/comments","events_url":"https://api.github.com/repos/nmoehrle/libacc/issues/2/events","html_url":"https://github.com/nmoehrle/libacc/issues/2","id":245398815,"number":2,"title":"Out of bounds error in BVH tree","user":{"login":"allo-","id":1482341,"avatar_url":"https://avatars3.githubusercontent.com/u/1482341?v=4","gravatar_id":"","url":"https://api.github.com/users/allo-","html_url":"https://github.com/allo-","followers_url":"https://api.github.com/users/allo-/followers","following_url":"https://api.github.com/users/allo-/following{/other_user}","gists_url":"https://api.github.com/users/allo-/gists{/gist_id}","starred_url":"https://api.github.com/users/allo-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allo-/subscriptions","organizations_url":"https://api.github.com/users/allo-/orgs","repos_url":"https://api.github.com/users/allo-/repos","events_url":"https://api.github.com/users/allo-/events{/privacy}","received_events_url":"https://api.github.com/users/allo-/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-07-25T13:20:40Z","updated_at":"2017-07-25T15:30:30Z","closed_at":null,"body":"I get an out of bounds error at [bvh_tree.h#L267](https://github.com/nmoehrle/libacc/blob/dcf3b3e068352b38fb04109ef50ad4fc7bd57b38/bvh_tree.h#L267), with ``node.last == indices.size()``.\r\n\r\nI guess this is a off by one error coming from somewhere else, but I do not see from where.\r\n\r\nCurrently I implemented a workaround to set ``node.last`` to ``indices.size()-1`` when its bigger, but I am not sure if this only changes the structure of the bounding volumes or if it changes the result.\r\n"},"comment":{"url":"https://api.github.com/repos/nmoehrle/libacc/issues/comments/317776203","html_url":"https://github.com/nmoehrle/libacc/issues/2#issuecomment-317776203","issue_url":"https://api.github.com/repos/nmoehrle/libacc/issues/2","id":317776203,"user":{"login":"allo-","id":1482341,"avatar_url":"https://avatars3.githubusercontent.com/u/1482341?v=4","gravatar_id":"","url":"https://api.github.com/users/allo-","html_url":"https://github.com/allo-","followers_url":"https://api.github.com/users/allo-/followers","following_url":"https://api.github.com/users/allo-/following{/other_user}","gists_url":"https://api.github.com/users/allo-/gists{/gist_id}","starred_url":"https://api.github.com/users/allo-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allo-/subscriptions","organizations_url":"https://api.github.com/users/allo-/orgs","repos_url":"https://api.github.com/users/allo-/repos","events_url":"https://api.github.com/users/allo-/events{/privacy}","received_events_url":"https://api.github.com/users/allo-/received_events","type":"User","site_admin":false},"created_at":"2017-07-25T15:30:30Z","updated_at":"2017-07-25T15:30:30Z","body":"I need to use MSVC here and it breaks.\r\nBut looking at it, it seems that std::sort uses the points like an iterator, because both \"*it\" and \"it++\" are working on pointers as on iterators, but probably it is not meant to work on something else than iterators."}}
{"actor":{"display_login":"allo-"}}