{"action":"created","comment":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/94353685","pull_request_review_id":14879152,"id":94353685,"diff_hunk":"@@ -47,38 +47,54 @@\n \t\t<!-- replace built-in triangulation with Earcut -->\n \t\t<script src=\"js/libs/earcut.js\"></script>\n \t\t<script>\n+\t\t\t\n+\t\t\tfunction removeDupEndPts(points) {","path":"examples/webgl_geometry_text_earcut.html","position":5,"original_position":5,"commit_id":"d324144d5e4c16aef5894ccceb9ff390e0a66d2f","original_commit_id":"d324144d5e4c16aef5894ccceb9ff390e0a66d2f","user":{"login":"WestLangley","id":1000017,"avatar_url":"https://avatars.githubusercontent.com/u/1000017?v=3","gravatar_id":"","url":"https://api.github.com/users/WestLangley","html_url":"https://github.com/WestLangley","followers_url":"https://api.github.com/users/WestLangley/followers","following_url":"https://api.github.com/users/WestLangley/following{/other_user}","gists_url":"https://api.github.com/users/WestLangley/gists{/gist_id}","starred_url":"https://api.github.com/users/WestLangley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WestLangley/subscriptions","organizations_url":"https://api.github.com/users/WestLangley/orgs","repos_url":"https://api.github.com/users/WestLangley/repos","events_url":"https://api.github.com/users/WestLangley/events{/privacy}","received_events_url":"https://api.github.com/users/WestLangley/received_events","type":"User","site_admin":false},"body":"This method would be better as a private function defined in the scope of `triangulateShape()`, as it is in the other examples, don't you think?","created_at":"2017-01-03T01:20:38Z","updated_at":"2017-01-03T01:20:38Z","html_url":"https://github.com/mrdoob/three.js/pull/10495#discussion_r94353685","pull_request_url":"https://api.github.com/repos/mrdoob/three.js/pulls/10495","_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments/94353685"},"html":{"href":"https://github.com/mrdoob/three.js/pull/10495#discussion_r94353685"},"pull_request":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10495"}}},"pull_request":{"url":"https://api.github.com/repos/mrdoob/three.js/pulls/10495","id":99900860,"html_url":"https://github.com/mrdoob/three.js/pull/10495","diff_url":"https://github.com/mrdoob/three.js/pull/10495.diff","patch_url":"https://github.com/mrdoob/three.js/pull/10495.patch","issue_url":"https://api.github.com/repos/mrdoob/three.js/issues/10495","number":10495,"state":"open","locked":false,"title":"text earcut example: remove duplicate start end points","user":{"login":"andreasplesch","id":6171115,"avatar_url":"https://avatars.githubusercontent.com/u/6171115?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasplesch","html_url":"https://github.com/andreasplesch","followers_url":"https://api.github.com/users/andreasplesch/followers","following_url":"https://api.github.com/users/andreasplesch/following{/other_user}","gists_url":"https://api.github.com/users/andreasplesch/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasplesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasplesch/subscriptions","organizations_url":"https://api.github.com/users/andreasplesch/orgs","repos_url":"https://api.github.com/users/andreasplesch/repos","events_url":"https://api.github.com/users/andreasplesch/events{/privacy}","received_events_url":"https://api.github.com/users/andreasplesch/received_events","type":"User","site_admin":false},"body":"align with native triangulate and with PnlTri text example by adding removeDupEndPts function and using it for outer contour and holes. Some white space added as well to conform better with general style.\r\nSee #10438 ","created_at":"2017-01-03T00:38:45Z","updated_at":"2017-01-03T01:20:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2e470b3fd39b4ecfd4f0281b506263cb58098f58","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/mrdoob/three.js/pulls/10495/commits","review_comments_url":"https://api.github.com/repos/mrdoob/three.js/pulls/10495/comments","review_comment_url":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mrdoob/three.js/issues/10495/comments","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/d324144d5e4c16aef5894ccceb9ff390e0a66d2f","head":{"label":"andreasplesch:dev","ref":"dev","sha":"d324144d5e4c16aef5894ccceb9ff390e0a66d2f","user":{"login":"andreasplesch","id":6171115,"avatar_url":"https://avatars.githubusercontent.com/u/6171115?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasplesch","html_url":"https://github.com/andreasplesch","followers_url":"https://api.github.com/users/andreasplesch/followers","following_url":"https://api.github.com/users/andreasplesch/following{/other_user}","gists_url":"https://api.github.com/users/andreasplesch/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasplesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasplesch/subscriptions","organizations_url":"https://api.github.com/users/andreasplesch/orgs","repos_url":"https://api.github.com/users/andreasplesch/repos","events_url":"https://api.github.com/users/andreasplesch/events{/privacy}","received_events_url":"https://api.github.com/users/andreasplesch/received_events","type":"User","site_admin":false},"repo":{"id":77804995,"name":"three.js","full_name":"andreasplesch/three.js","owner":{"login":"andreasplesch","id":6171115,"avatar_url":"https://avatars.githubusercontent.com/u/6171115?v=3","gravatar_id":"","url":"https://api.github.com/users/andreasplesch","html_url":"https://github.com/andreasplesch","followers_url":"https://api.github.com/users/andreasplesch/followers","following_url":"https://api.github.com/users/andreasplesch/following{/other_user}","gists_url":"https://api.github.com/users/andreasplesch/gists{/gist_id}","starred_url":"https://api.github.com/users/andreasplesch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreasplesch/subscriptions","organizations_url":"https://api.github.com/users/andreasplesch/orgs","repos_url":"https://api.github.com/users/andreasplesch/repos","events_url":"https://api.github.com/users/andreasplesch/events{/privacy}","received_events_url":"https://api.github.com/users/andreasplesch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreasplesch/three.js","description":"JavaScript 3D library.","fork":true,"url":"https://api.github.com/repos/andreasplesch/three.js","forks_url":"https://api.github.com/repos/andreasplesch/three.js/forks","keys_url":"https://api.github.com/repos/andreasplesch/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreasplesch/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreasplesch/three.js/teams","hooks_url":"https://api.github.com/repos/andreasplesch/three.js/hooks","issue_events_url":"https://api.github.com/repos/andreasplesch/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/andreasplesch/three.js/events","assignees_url":"https://api.github.com/repos/andreasplesch/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/andreasplesch/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/andreasplesch/three.js/tags","blobs_url":"https://api.github.com/repos/andreasplesch/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreasplesch/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreasplesch/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreasplesch/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreasplesch/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/andreasplesch/three.js/languages","stargazers_url":"https://api.github.com/repos/andreasplesch/three.js/stargazers","contributors_url":"https://api.github.com/repos/andreasplesch/three.js/contributors","subscribers_url":"https://api.github.com/repos/andreasplesch/three.js/subscribers","subscription_url":"https://api.github.com/repos/andreasplesch/three.js/subscription","commits_url":"https://api.github.com/repos/andreasplesch/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreasplesch/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreasplesch/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreasplesch/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreasplesch/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/andreasplesch/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreasplesch/three.js/merges","archive_url":"https://api.github.com/repos/andreasplesch/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreasplesch/three.js/downloads","issues_url":"https://api.github.com/repos/andreasplesch/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/andreasplesch/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/andreasplesch/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/andreasplesch/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreasplesch/three.js/labels{/name}","releases_url":"https://api.github.com/repos/andreasplesch/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/andreasplesch/three.js/deployments","created_at":"2017-01-02T01:38:04Z","updated_at":"2017-01-02T01:38:13Z","pushed_at":"2017-01-03T00:31:40Z","git_url":"git://github.com/andreasplesch/three.js.git","ssh_url":"git@github.com:andreasplesch/three.js.git","clone_url":"https://github.com/andreasplesch/three.js.git","svn_url":"https://github.com/andreasplesch/three.js","homepage":"https://threejs.org/","size":437169,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"mrdoob:dev","ref":"dev","sha":"f9582a1b1cccb50121abb8a61ee7e79cb2ff7406","user":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"repo":{"id":576201,"name":"three.js","full_name":"mrdoob/three.js","owner":{"login":"mrdoob","id":97088,"avatar_url":"https://avatars.githubusercontent.com/u/97088?v=3","gravatar_id":"","url":"https://api.github.com/users/mrdoob","html_url":"https://github.com/mrdoob","followers_url":"https://api.github.com/users/mrdoob/followers","following_url":"https://api.github.com/users/mrdoob/following{/other_user}","gists_url":"https://api.github.com/users/mrdoob/gists{/gist_id}","starred_url":"https://api.github.com/users/mrdoob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrdoob/subscriptions","organizations_url":"https://api.github.com/users/mrdoob/orgs","repos_url":"https://api.github.com/users/mrdoob/repos","events_url":"https://api.github.com/users/mrdoob/events{/privacy}","received_events_url":"https://api.github.com/users/mrdoob/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mrdoob/three.js","description":"JavaScript 3D library.","fork":false,"url":"https://api.github.com/repos/mrdoob/three.js","forks_url":"https://api.github.com/repos/mrdoob/three.js/forks","keys_url":"https://api.github.com/repos/mrdoob/three.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mrdoob/three.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mrdoob/three.js/teams","hooks_url":"https://api.github.com/repos/mrdoob/three.js/hooks","issue_events_url":"https://api.github.com/repos/mrdoob/three.js/issues/events{/number}","events_url":"https://api.github.com/repos/mrdoob/three.js/events","assignees_url":"https://api.github.com/repos/mrdoob/three.js/assignees{/user}","branches_url":"https://api.github.com/repos/mrdoob/three.js/branches{/branch}","tags_url":"https://api.github.com/repos/mrdoob/three.js/tags","blobs_url":"https://api.github.com/repos/mrdoob/three.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mrdoob/three.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mrdoob/three.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/mrdoob/three.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mrdoob/three.js/statuses/{sha}","languages_url":"https://api.github.com/repos/mrdoob/three.js/languages","stargazers_url":"https://api.github.com/repos/mrdoob/three.js/stargazers","contributors_url":"https://api.github.com/repos/mrdoob/three.js/contributors","subscribers_url":"https://api.github.com/repos/mrdoob/three.js/subscribers","subscription_url":"https://api.github.com/repos/mrdoob/three.js/subscription","commits_url":"https://api.github.com/repos/mrdoob/three.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/mrdoob/three.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/mrdoob/three.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/mrdoob/three.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/mrdoob/three.js/contents/{+path}","compare_url":"https://api.github.com/repos/mrdoob/three.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mrdoob/three.js/merges","archive_url":"https://api.github.com/repos/mrdoob/three.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mrdoob/three.js/downloads","issues_url":"https://api.github.com/repos/mrdoob/three.js/issues{/number}","pulls_url":"https://api.github.com/repos/mrdoob/three.js/pulls{/number}","milestones_url":"https://api.github.com/repos/mrdoob/three.js/milestones{/number}","notifications_url":"https://api.github.com/repos/mrdoob/three.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mrdoob/three.js/labels{/name}","releases_url":"https://api.github.com/repos/mrdoob/three.js/releases{/id}","deployments_url":"https://api.github.com/repos/mrdoob/three.js/deployments","created_at":"2010-03-23T18:58:01Z","updated_at":"2017-01-03T01:07:32Z","pushed_at":"2017-01-03T00:38:46Z","git_url":"git://github.com/mrdoob/three.js.git","ssh_url":"git@github.com:mrdoob/three.js.git","clone_url":"https://github.com/mrdoob/three.js.git","svn_url":"https://github.com/mrdoob/three.js","homepage":"https://threejs.org/","size":437146,"stargazers_count":29836,"watchers_count":29836,"language":"JavaScript","has_issues":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":10356,"mirror_url":null,"open_issues_count":852,"forks":10356,"open_issues":852,"watchers":29836,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10495"},"html":{"href":"https://github.com/mrdoob/three.js/pull/10495"},"issue":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/10495"},"comments":{"href":"https://api.github.com/repos/mrdoob/three.js/issues/10495/comments"},"review_comments":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10495/comments"},"review_comment":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mrdoob/three.js/pulls/10495/commits"},"statuses":{"href":"https://api.github.com/repos/mrdoob/three.js/statuses/d324144d5e4c16aef5894ccceb9ff390e0a66d2f"}}}}
{"actor":{"display_login":"WestLangley"}}