{"action":"created","issue":{"url":"https://api.github.com/repos/Tudat/tudat/issues/257","repository_url":"https://api.github.com/repos/Tudat/tudat","labels_url":"https://api.github.com/repos/Tudat/tudat/issues/257/labels{/name}","comments_url":"https://api.github.com/repos/Tudat/tudat/issues/257/comments","events_url":"https://api.github.com/repos/Tudat/tudat/issues/257/events","html_url":"https://github.com/Tudat/tudat/pull/257","id":263130652,"number":257,"title":"JSON Interface","user":{"login":"aleixpinardell","id":10518548,"avatar_url":"https://avatars1.githubusercontent.com/u/10518548?v=4","gravatar_id":"","url":"https://api.github.com/users/aleixpinardell","html_url":"https://github.com/aleixpinardell","followers_url":"https://api.github.com/users/aleixpinardell/followers","following_url":"https://api.github.com/users/aleixpinardell/following{/other_user}","gists_url":"https://api.github.com/users/aleixpinardell/gists{/gist_id}","starred_url":"https://api.github.com/users/aleixpinardell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleixpinardell/subscriptions","organizations_url":"https://api.github.com/users/aleixpinardell/orgs","repos_url":"https://api.github.com/users/aleixpinardell/repos","events_url":"https://api.github.com/users/aleixpinardell/events{/privacy}","received_events_url":"https://api.github.com/users/aleixpinardell/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-10-05T13:44:54Z","updated_at":"2017-10-07T08:53:53Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/Tudat/tudat/pulls/257","html_url":"https://github.com/Tudat/tudat/pull/257","diff_url":"https://github.com/Tudat/tudat/pull/257.diff","patch_url":"https://github.com/Tudat/tudat/pull/257.patch"},"body":"### Changes Tudat/tudat:development ... aleixpinardell/tudat:json\r\n\r\n* Ignore .DS_Store files\r\n\r\n      .gitignore\r\n    \r\n* Function `getAtmosphereTablesPath`\r\n\r\n      Tudat/Astrodynamics/Aerodynamics/UnitTests/unitTestNRLMSISE00Atmosphere.cpp\r\n      Tudat/Astrodynamics/Aerodynamics/UnitTests/unitTestTabulatedAtmosphere.cpp\r\n      Tudat/InputOutput/basicInputOutput.h\r\n      Tudat/SimulationSetup/EnvironmentSetup/createAtmosphereModel.cpp\r\n      Tudat/SimulationSetup/UnitTests/unitTestEnvironmentModelSetup.cpp\r\n      \r\n* Rename `central_gravity` to `point_mass_gravity`\r\n\r\n      Tudat/Astrodynamics/BasicAstrodynamics/accelerationModelTypes.h\r\n      \r\n* Typedef for `std::map< std::string, std::vector< boost::shared_ptr< MassRateModel > > >` as `MassRateModelMap`\r\n\r\n      Tudat/Astrodynamics/BasicAstrodynamics/massRateModel.h\r\n\r\n* Provide absolute path for non-standard Spice kernels:\r\n\r\n      Tudat/Astrodynamics/Gravitation/UnitTests/unitTestGravityFieldVariations.cpp\r\n      Tudat/Astrodynamics/OrbitDetermination/AccelerationPartials/UnitTests/unitTestSphericalHarmonicPartials.cpp\r\n      \r\n* SH gravity fields coefficients in External directory\r\n\r\n      Tudat/Astrodynamics/Gravitation/egm96_coefficients.dat\r\n      Tudat/Astrodynamics/Gravitation/gglp_lpe200_sha.tab\r\n      Tudat/Astrodynamics/Gravitation/jgmro_120d_sha.tab\r\n      Tudat/Astrodynamics/OrbitDetermination/AccelerationPartials/UnitTests/unitTestSphericalHarmonicPartials.cpp\r\n      Tudat/External/GravityModels/Earth/egm96.txt\r\n      Tudat/External/GravityModels/Earth/ggm02c.txt\r\n      Tudat/External/GravityModels/Earth/ggm02s.txt\r\n      Tudat/External/GravityModels/Mars/jgmro120d.txt\r\n      Tudat/External/GravityModels/Moon/glgm3150.txt\r\n      Tudat/External/GravityModels/Moon/lpe200.txt\r\n      Tudat/InputOutput/basicInputOutput.h\r\n      \r\n* Remove gomp\r\n\r\n      Tudat/Astrodynamics/GroundStations/CMakeLists.txt\r\n      \r\n* Fix adding cpp in list of headers\r\n\r\n      Tudat/Astrodynamics/Propagators/CMakeLists.txt\r\n      \r\n* Fix typo `body_transational_state_update`\r\n\r\n      Tudat/Astrodynamics/Propagators/environmentUpdateTypes.h\r\n      Tudat/Astrodynamics/Propagators/singleStateTypeDerivative.h\r\n      \r\n* CPU time\r\n\r\n      Tudat/Astrodynamics/Propagators/integrateEquations.h\r\n      Tudat/Mathematics/NumericalIntegrators/numericalIntegrator.h\r\n      Tudat/Mathematics/NumericalIntegrators/rungeKutta4Integrator.h\r\n      Tudat/Mathematics/NumericalIntegrators/rungeKuttaVariableStepSizeIntegrator.h\r\n      Tudat/SimulationSetup/PropagationSetup/dynamicsSimulator.h\r\n      Tudat/SimulationSetup/PropagationSetup/propagationTermination.cpp\r\n      Tudat/SimulationSetup/PropagationSetup/propagationTermination.h\r\n      Tudat/SimulationSetup/PropagationSetup/propagationTerminationSettings.h\r\n      Tudat/SimulationSetup/PropagationSetup/variationalEquationsSolver.h\r\n      \r\n* Add `DataInterpolationSettings` class\r\n\r\n      Tudat/Astrodynamics/Propulsion/UnitTests/unitTestThrustAcceleration.cpp\r\n      Tudat/Mathematics/Interpolators/createInterpolator.h\r\n      Tudat/SimulationSetup/PropagationSetup/accelerationSettings.h\r\n      \r\n* Fix typo `associatedThroustSource_`\r\n\r\n      Tudat/Astrodynamics/Propulsion/thrustAccelerationModel.h\r\n      Tudat/SimulationSetup/PropagationSetup/createMassRateModels.cpp\r\n      \r\n* Space weather data to External directory\r\n\r\n      Tudat/Astrodynamics/Aerodynamics/sw19571001.txt\r\n      Tudat/External/SpaceWeatherData/sw19571001.txt\r\n      Tudat/InputOutput/basicInputOutput.h\r\n      Tudat/SimulationSetup/UnitTests/unitTestEnvironmentModelSetup.cpp\r\n      \r\n* Fix typo `abberation`\r\n\r\n      Tudat/External/SpiceInterface/UnitTests/unitTestSpiceInterface.cpp\r\n      Tudat/External/SpiceInterface/spiceEphemeris.cpp\r\n      Tudat/External/SpiceInterface/spiceEphemeris.h\r\n      Tudat/External/SpiceInterface/spiceInterface.cpp\r\n      Tudat/External/SpiceInterface/spiceInterface.h\r\n      Tudat/SimulationSetup/EnvironmentSetup/createEphemeris.cpp\r\n      Tudat/SimulationSetup/EnvironmentSetup/createEphemeris.h\r\n      \r\n* Make `readMatrixFromFile` templated\r\n\r\n      Tudat/InputOutput/CMakeLists.txt\r\n      Tudat/InputOutput/matrixTextFileReader.h\r\n      Tudat/InputOutput/matrixTextFileReader.cpp\r\n      \r\n* Add overload of `writeDataMapToTextFile`\r\n\r\n      Tudat/InputOutput/basicInputOutput.h\r\n      \r\n* Add `readEigenVectorMapFromFile` function\r\n\r\n      Tudat/InputOutput/mapTextFileReader.h\r\n\r\n* More info in the error message when reading tabulated aerodynamics coefficients file\r\n\r\n      Tudat/InputOutput/multiDimensionalArrayReader.h\r\n      \r\n* Fix compile error\r\n\r\n      Tudat/Mathematics/Interpolators/jumpDataLinearInterpolator.h\r\n      \r\n* Remove `const`\r\n\r\n      Tudat/Mathematics/NumericalIntegrators/createNumericalIntegrator.h\r\n      \r\n* Add class `FromFileAerodynamicCoefficientSettings` and make `TabulatedAerodynamicCoefficientSettings<N>` and `TabulatedAerodynamicCoefficientSettings<1>` derive from it\r\n\r\n      Tudat/SimulationSetup/EnvironmentSetup/createAerodynamicCoefficientInterface.h\r\n\r\n* Add `constantMass` property for `BodySettings`\r\n\r\n      Tudat/SimulationSetup/EnvironmentSetup/createBodies.cpp\r\n      Tudat/SimulationSetup/EnvironmentSetup/createBodies.h\r\n\r\n* Add class `SphericalHarmonicsModelGravityFieldSettings` to load SH gravity files using the name of a SH model (enumeration)\r\n\r\n      Tudat/SimulationSetup/EnvironmentSetup/createGravityField.cpp\r\n      Tudat/SimulationSetup/EnvironmentSetup/createGravityField.h\r\n      Tudat/SimulationSetup/EnvironmentSetup/defaultBodies.cpp\r\n      \r\n* Add optional argument to function `getDefaultBodySettings` to be able to customise interpolation step for ephemeris (was fixed to 300.0 s before)\r\n\r\n      Tudat/SimulationSetup/EnvironmentSetup/defaultBodies.cpp\r\n\r\n* Move `createAccelerationModelsMap` function to avoid recursive file-inclusion cycle\r\n\r\n      Tudat/SimulationSetup/PropagationSetup/createAccelerationModels.cpp\r\n      Tudat/SimulationSetup/PropagationSetup/createAccelerationModels.h\r\n      Tudat/SimulationSetup/PropagationSetup/createNumericalSimulator.cpp\r\n      Tudat/SimulationSetup/PropagationSetup/createNumericalSimulator.h\r\n\r\n* Move `createTorqueModelsMap` function to avoid recursive file-inclusion cycle\r\n\r\n      Tudat/SimulationSetup/PropagationSetup/createNumericalSimulator.cpp\r\n      Tudat/SimulationSetup/PropagationSetup/createNumericalSimulator.h\r\n      Tudat/SimulationSetup/PropagationSetup/createTorqueModel.cpp\r\n      Tudat/SimulationSetup/PropagationSetup/createTorqueModel.h\r\n      \r\n* Add property `componentIndex_` to `SingleDependentVariableSaveSettings` to allow saving just one of the elements of the vector\r\n\r\n      Tudat/SimulationSetup/PropagationSetup/propagationOutput.cpp\r\n      Tudat/SimulationSetup/PropagationSetup/propagationOutput.h\r\n      \r\n* Move `getVectorDependentVariableFunction` above `getDoubleDependentVariableFunction`\r\n\r\n      Tudat/SimulationSetup/PropagationSetup/propagationOutput.h\r\n      \r\n* Create class `VariableSettings` to represent Tudat variables and make `SingleDependentVariableSaveSettings` derive from it\r\n\r\n      Tudat/SimulationSetup/PropagationSetup/propagationOutputSettings.cpp\r\n      Tudat/SimulationSetup/PropagationSetup/propagationOutputSettings.h\r\n      \r\n* Enable constructing `PropagatorSettings` using a map of `AccelerationSettings`\r\n\r\n      Tudat/SimulationSetup/PropagationSetup/propagationSettings.h\r\n      \r\n* Typedef for `std::map< std::string, std::map< std::string, std::vector< boost::shared_ptr< TorqueSettings > > > >` as `SelectedTorqueMap`\r\n\r\n      Tudat/SimulationSetup/PropagationSetup/torqueSettings.h\r\n      \r\n* Include `mapTextFileReader` in `tudatSimulationHeader`\r\n\r\n      Tudat/SimulationSetup/tudatSimulationHeader.h\r\n\r\n* JSON Interface\r\n\r\n      Tudat/CMakeLists.txt\r\n      Tudat/JsonInterface/*\r\n"},"comment":{"url":"https://api.github.com/repos/Tudat/tudat/issues/comments/334920883","html_url":"https://github.com/Tudat/tudat/pull/257#issuecomment-334920883","issue_url":"https://api.github.com/repos/Tudat/tudat/issues/257","id":334920883,"user":{"login":"DominicDirkx","id":5039068,"avatar_url":"https://avatars3.githubusercontent.com/u/5039068?v=4","gravatar_id":"","url":"https://api.github.com/users/DominicDirkx","html_url":"https://github.com/DominicDirkx","followers_url":"https://api.github.com/users/DominicDirkx/followers","following_url":"https://api.github.com/users/DominicDirkx/following{/other_user}","gists_url":"https://api.github.com/users/DominicDirkx/gists{/gist_id}","starred_url":"https://api.github.com/users/DominicDirkx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DominicDirkx/subscriptions","organizations_url":"https://api.github.com/users/DominicDirkx/orgs","repos_url":"https://api.github.com/users/DominicDirkx/repos","events_url":"https://api.github.com/users/DominicDirkx/events{/privacy}","received_events_url":"https://api.github.com/users/DominicDirkx/received_events","type":"User","site_admin":false},"created_at":"2017-10-07T08:53:53Z","updated_at":"2017-10-07T08:53:53Z","author_association":"OWNER","body":"Same results, both with the old and new regex....\r\n\r\nPerhaps it's good to simplify these functions. There is now a lot of if/else to check certain conditions, and use default settings for certain types of input. I understand why this is in there, and the feature is very nice. At this point, however, I wonder if it's worth it to invest your (limited) time in making this work cross-platform."}}
{"actor":{"display_login":"DominicDirkx"}}