{"action":"created","comment":{"url":"https://api.github.com/repos/Unity-Technologies/katana/pulls/comments/125294045","pull_request_review_id":47657978,"id":125294045,"diff_hunk":"@@ -379,6 +448,108 @@ def start(self):\n         self.setCommand(command)\n         ShellCommand.start(self)\n \n+    @defer.inlineCallbacks\n+    def _getBuildRequest(self):\n+        triggeredbybrid = self.build.requests[0].id\n+        br = yield self.master.db.buildrequests.getBuildRequestTriggered(triggeredbybrid, self.artifactBuilderName)\n+        defer.returnValue(br)\n+\n+\n+class DownloadArtifactFromParent(DownloadArtifact):\n+    @defer.inlineCallbacks\n+    def _getBuildRequest(self):\n+        triggeredbybrid = self.build.requests[0].id\n+        id = yield self.master.db.buildrequests.getTriggeredById(triggeredbybrid)\n+        br = yield self.master.db.buildrequests.getBuildRequestById(id)\n+        defer.returnValue(br)\n+\n+class DownloadArtifactFromChilden(LoggingBuildStep, CompositeStepMixin):\n+    def __init__(self, name=None, projectPrefix=None, targetConfig=None, artifactBuilderName=None,\n+                 artifact=None, artifactDirectory=None, artifactDestination=None,\n+                 artifactServer=None, artifactServerDir=None, artifactServerPort=None,\n+                 usePowerShell=True, baseLocalDir=None, **kwargs):\n+        self.workdir = 'build'\n+        self.artifactBuilderName = artifactBuilderName\n+        self.artifact = artifact","path":"master/buildbot/steps/artifact.py","position":313,"original_position":313,"commit_id":"c1c6bd0f7694dc3288133761ef4e2ffc621a76f2","original_commit_id":"c1c6bd0f7694dc3288133761ef4e2ffc621a76f2","user":{"login":"tdctaz","id":595295,"avatar_url":"https://avatars2.githubusercontent.com/u/595295?v=3","gravatar_id":"","url":"https://api.github.com/users/tdctaz","html_url":"https://github.com/tdctaz","followers_url":"https://api.github.com/users/tdctaz/followers","following_url":"https://api.github.com/users/tdctaz/following{/other_user}","gists_url":"https://api.github.com/users/tdctaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tdctaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdctaz/subscriptions","organizations_url":"https://api.github.com/users/tdctaz/orgs","repos_url":"https://api.github.com/users/tdctaz/repos","events_url":"https://api.github.com/users/tdctaz/events{/privacy}","received_events_url":"https://api.github.com/users/tdctaz/received_events","type":"User","site_admin":false},"body":"Is this used? - could we make it possible to download one specific artifact from all children if it is specified?","created_at":"2017-07-03T13:51:43Z","updated_at":"2017-07-03T13:56:46Z","html_url":"https://github.com/Unity-Technologies/katana/pull/254#discussion_r125294045","pull_request_url":"https://api.github.com/repos/Unity-Technologies/katana/pulls/254","_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/katana/pulls/comments/125294045"},"html":{"href":"https://github.com/Unity-Technologies/katana/pull/254#discussion_r125294045"},"pull_request":{"href":"https://api.github.com/repos/Unity-Technologies/katana/pulls/254"}}},"pull_request":{"url":"https://api.github.com/repos/Unity-Technologies/katana/pulls/254","id":127026399,"html_url":"https://github.com/Unity-Technologies/katana/pull/254","diff_url":"https://github.com/Unity-Technologies/katana/pull/254.diff","patch_url":"https://github.com/Unity-Technologies/katana/pull/254.patch","issue_url":"https://api.github.com/repos/Unity-Technologies/katana/issues/254","number":254,"state":"open","locked":false,"title":"Support for Parallel triggered builds","user":{"login":"tdctaz","id":595295,"avatar_url":"https://avatars2.githubusercontent.com/u/595295?v=3","gravatar_id":"","url":"https://api.github.com/users/tdctaz","html_url":"https://github.com/tdctaz","followers_url":"https://api.github.com/users/tdctaz/followers","following_url":"https://api.github.com/users/tdctaz/following{/other_user}","gists_url":"https://api.github.com/users/tdctaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tdctaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdctaz/subscriptions","organizations_url":"https://api.github.com/users/tdctaz/orgs","repos_url":"https://api.github.com/users/tdctaz/repos","events_url":"https://api.github.com/users/tdctaz/events{/privacy}","received_events_url":"https://api.github.com/users/tdctaz/received_events","type":"User","site_admin":false},"body":"This adds functionality for triggering schedulers multiple times, for example when we want to split a task into multiple partitions for parallelization purposes.\r\n\r\n- Adds a build step for triggering multiple copies of the same scheduler with different properties\r\n- Extends `FindPreviousSuccessfulBuild` and `CheckArtifactExists` to take any configured merge function into account (This is a breaking change). If no merge function has been configured then it works as before, so the extra overhead for getting the data for the merge function is only added when it is there.\r\n- Finally adds the option for a triggered build to download artifacts from the parent build that triggered it","created_at":"2017-06-22T15:50:11Z","updated_at":"2017-07-03T13:56:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"11b2f1772e0bcd430e6884fee8c23af314db4553","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sualitu","id":1204424,"avatar_url":"https://avatars3.githubusercontent.com/u/1204424?v=3","gravatar_id":"","url":"https://api.github.com/users/sualitu","html_url":"https://github.com/sualitu","followers_url":"https://api.github.com/users/sualitu/followers","following_url":"https://api.github.com/users/sualitu/following{/other_user}","gists_url":"https://api.github.com/users/sualitu/gists{/gist_id}","starred_url":"https://api.github.com/users/sualitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sualitu/subscriptions","organizations_url":"https://api.github.com/users/sualitu/orgs","repos_url":"https://api.github.com/users/sualitu/repos","events_url":"https://api.github.com/users/sualitu/events{/privacy}","received_events_url":"https://api.github.com/users/sualitu/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Unity-Technologies/katana/pulls/254/commits","review_comments_url":"https://api.github.com/repos/Unity-Technologies/katana/pulls/254/comments","review_comment_url":"https://api.github.com/repos/Unity-Technologies/katana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Unity-Technologies/katana/issues/254/comments","statuses_url":"https://api.github.com/repos/Unity-Technologies/katana/statuses/c1c6bd0f7694dc3288133761ef4e2ffc621a76f2","head":{"label":"tdctaz:toolsmiths/parallel-execution","ref":"toolsmiths/parallel-execution","sha":"c1c6bd0f7694dc3288133761ef4e2ffc621a76f2","user":{"login":"tdctaz","id":595295,"avatar_url":"https://avatars2.githubusercontent.com/u/595295?v=3","gravatar_id":"","url":"https://api.github.com/users/tdctaz","html_url":"https://github.com/tdctaz","followers_url":"https://api.github.com/users/tdctaz/followers","following_url":"https://api.github.com/users/tdctaz/following{/other_user}","gists_url":"https://api.github.com/users/tdctaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tdctaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdctaz/subscriptions","organizations_url":"https://api.github.com/users/tdctaz/orgs","repos_url":"https://api.github.com/users/tdctaz/repos","events_url":"https://api.github.com/users/tdctaz/events{/privacy}","received_events_url":"https://api.github.com/users/tdctaz/received_events","type":"User","site_admin":false},"repo":{"id":56670470,"name":"katana","full_name":"tdctaz/katana","owner":{"login":"tdctaz","id":595295,"avatar_url":"https://avatars2.githubusercontent.com/u/595295?v=3","gravatar_id":"","url":"https://api.github.com/users/tdctaz","html_url":"https://github.com/tdctaz","followers_url":"https://api.github.com/users/tdctaz/followers","following_url":"https://api.github.com/users/tdctaz/following{/other_user}","gists_url":"https://api.github.com/users/tdctaz/gists{/gist_id}","starred_url":"https://api.github.com/users/tdctaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdctaz/subscriptions","organizations_url":"https://api.github.com/users/tdctaz/orgs","repos_url":"https://api.github.com/users/tdctaz/repos","events_url":"https://api.github.com/users/tdctaz/events{/privacy}","received_events_url":"https://api.github.com/users/tdctaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tdctaz/katana","description":"Unity's fork of Buildbot, a Python-based continuous integration testing framework!","fork":true,"url":"https://api.github.com/repos/tdctaz/katana","forks_url":"https://api.github.com/repos/tdctaz/katana/forks","keys_url":"https://api.github.com/repos/tdctaz/katana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tdctaz/katana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tdctaz/katana/teams","hooks_url":"https://api.github.com/repos/tdctaz/katana/hooks","issue_events_url":"https://api.github.com/repos/tdctaz/katana/issues/events{/number}","events_url":"https://api.github.com/repos/tdctaz/katana/events","assignees_url":"https://api.github.com/repos/tdctaz/katana/assignees{/user}","branches_url":"https://api.github.com/repos/tdctaz/katana/branches{/branch}","tags_url":"https://api.github.com/repos/tdctaz/katana/tags","blobs_url":"https://api.github.com/repos/tdctaz/katana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tdctaz/katana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tdctaz/katana/git/refs{/sha}","trees_url":"https://api.github.com/repos/tdctaz/katana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tdctaz/katana/statuses/{sha}","languages_url":"https://api.github.com/repos/tdctaz/katana/languages","stargazers_url":"https://api.github.com/repos/tdctaz/katana/stargazers","contributors_url":"https://api.github.com/repos/tdctaz/katana/contributors","subscribers_url":"https://api.github.com/repos/tdctaz/katana/subscribers","subscription_url":"https://api.github.com/repos/tdctaz/katana/subscription","commits_url":"https://api.github.com/repos/tdctaz/katana/commits{/sha}","git_commits_url":"https://api.github.com/repos/tdctaz/katana/git/commits{/sha}","comments_url":"https://api.github.com/repos/tdctaz/katana/comments{/number}","issue_comment_url":"https://api.github.com/repos/tdctaz/katana/issues/comments{/number}","contents_url":"https://api.github.com/repos/tdctaz/katana/contents/{+path}","compare_url":"https://api.github.com/repos/tdctaz/katana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tdctaz/katana/merges","archive_url":"https://api.github.com/repos/tdctaz/katana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tdctaz/katana/downloads","issues_url":"https://api.github.com/repos/tdctaz/katana/issues{/number}","pulls_url":"https://api.github.com/repos/tdctaz/katana/pulls{/number}","milestones_url":"https://api.github.com/repos/tdctaz/katana/milestones{/number}","notifications_url":"https://api.github.com/repos/tdctaz/katana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tdctaz/katana/labels{/name}","releases_url":"https://api.github.com/repos/tdctaz/katana/releases{/id}","deployments_url":"https://api.github.com/repos/tdctaz/katana/deployments","created_at":"2016-04-20T08:39:38Z","updated_at":"2016-04-20T08:39:42Z","pushed_at":"2017-07-03T12:35:19Z","git_url":"git://github.com/tdctaz/katana.git","ssh_url":"git@github.com:tdctaz/katana.git","clone_url":"https://github.com/tdctaz/katana.git","svn_url":"https://github.com/tdctaz/katana","homepage":"","size":79499,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"katana"}},"base":{"label":"Unity-Technologies:staging","ref":"staging","sha":"7dd98b2a5cdf4828a0f2a6178c0bc441dc2a6c19","user":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars3.githubusercontent.com/u/426196?v=3","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"repo":{"id":8049051,"name":"katana","full_name":"Unity-Technologies/katana","owner":{"login":"Unity-Technologies","id":426196,"avatar_url":"https://avatars3.githubusercontent.com/u/426196?v=3","gravatar_id":"","url":"https://api.github.com/users/Unity-Technologies","html_url":"https://github.com/Unity-Technologies","followers_url":"https://api.github.com/users/Unity-Technologies/followers","following_url":"https://api.github.com/users/Unity-Technologies/following{/other_user}","gists_url":"https://api.github.com/users/Unity-Technologies/gists{/gist_id}","starred_url":"https://api.github.com/users/Unity-Technologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Unity-Technologies/subscriptions","organizations_url":"https://api.github.com/users/Unity-Technologies/orgs","repos_url":"https://api.github.com/users/Unity-Technologies/repos","events_url":"https://api.github.com/users/Unity-Technologies/events{/privacy}","received_events_url":"https://api.github.com/users/Unity-Technologies/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Unity-Technologies/katana","description":"Unity's fork of Buildbot, a Python-based continuous integration testing framework!","fork":true,"url":"https://api.github.com/repos/Unity-Technologies/katana","forks_url":"https://api.github.com/repos/Unity-Technologies/katana/forks","keys_url":"https://api.github.com/repos/Unity-Technologies/katana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Unity-Technologies/katana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Unity-Technologies/katana/teams","hooks_url":"https://api.github.com/repos/Unity-Technologies/katana/hooks","issue_events_url":"https://api.github.com/repos/Unity-Technologies/katana/issues/events{/number}","events_url":"https://api.github.com/repos/Unity-Technologies/katana/events","assignees_url":"https://api.github.com/repos/Unity-Technologies/katana/assignees{/user}","branches_url":"https://api.github.com/repos/Unity-Technologies/katana/branches{/branch}","tags_url":"https://api.github.com/repos/Unity-Technologies/katana/tags","blobs_url":"https://api.github.com/repos/Unity-Technologies/katana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Unity-Technologies/katana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Unity-Technologies/katana/git/refs{/sha}","trees_url":"https://api.github.com/repos/Unity-Technologies/katana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Unity-Technologies/katana/statuses/{sha}","languages_url":"https://api.github.com/repos/Unity-Technologies/katana/languages","stargazers_url":"https://api.github.com/repos/Unity-Technologies/katana/stargazers","contributors_url":"https://api.github.com/repos/Unity-Technologies/katana/contributors","subscribers_url":"https://api.github.com/repos/Unity-Technologies/katana/subscribers","subscription_url":"https://api.github.com/repos/Unity-Technologies/katana/subscription","commits_url":"https://api.github.com/repos/Unity-Technologies/katana/commits{/sha}","git_commits_url":"https://api.github.com/repos/Unity-Technologies/katana/git/commits{/sha}","comments_url":"https://api.github.com/repos/Unity-Technologies/katana/comments{/number}","issue_comment_url":"https://api.github.com/repos/Unity-Technologies/katana/issues/comments{/number}","contents_url":"https://api.github.com/repos/Unity-Technologies/katana/contents/{+path}","compare_url":"https://api.github.com/repos/Unity-Technologies/katana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Unity-Technologies/katana/merges","archive_url":"https://api.github.com/repos/Unity-Technologies/katana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Unity-Technologies/katana/downloads","issues_url":"https://api.github.com/repos/Unity-Technologies/katana/issues{/number}","pulls_url":"https://api.github.com/repos/Unity-Technologies/katana/pulls{/number}","milestones_url":"https://api.github.com/repos/Unity-Technologies/katana/milestones{/number}","notifications_url":"https://api.github.com/repos/Unity-Technologies/katana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Unity-Technologies/katana/labels{/name}","releases_url":"https://api.github.com/repos/Unity-Technologies/katana/releases{/id}","deployments_url":"https://api.github.com/repos/Unity-Technologies/katana/deployments","created_at":"2013-02-06T10:22:01Z","updated_at":"2017-06-30T12:06:26Z","pushed_at":"2017-07-03T12:35:20Z","git_url":"git://github.com/Unity-Technologies/katana.git","ssh_url":"git@github.com:Unity-Technologies/katana.git","clone_url":"https://github.com/Unity-Technologies/katana.git","svn_url":"https://github.com/Unity-Technologies/katana","homepage":"","size":82389,"stargazers_count":111,"watchers_count":111,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"open_issues_count":8,"forks":23,"open_issues":8,"watchers":111,"default_branch":"katana"}},"_links":{"self":{"href":"https://api.github.com/repos/Unity-Technologies/katana/pulls/254"},"html":{"href":"https://github.com/Unity-Technologies/katana/pull/254"},"issue":{"href":"https://api.github.com/repos/Unity-Technologies/katana/issues/254"},"comments":{"href":"https://api.github.com/repos/Unity-Technologies/katana/issues/254/comments"},"review_comments":{"href":"https://api.github.com/repos/Unity-Technologies/katana/pulls/254/comments"},"review_comment":{"href":"https://api.github.com/repos/Unity-Technologies/katana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Unity-Technologies/katana/pulls/254/commits"},"statuses":{"href":"https://api.github.com/repos/Unity-Technologies/katana/statuses/c1c6bd0f7694dc3288133761ef4e2ffc621a76f2"}}}}
{"actor":{"display_login":"tdctaz"}}