{"action":"created","comment":{"url":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/comments/96400179","pull_request_review_id":16979450,"id":96400179,"diff_hunk":"@@ -13,4 +11,25 @@\n //#define LOCK_MUTEX(x) { //qDebug() << \"Locking mutex \" #x \" at line \" << __LINE__ << \" in file \" << __FILE__ << \" in object \" << (void*)this << \", thread \" << (void*)QThread::currentThread(); x.lock(); }\r\n //#define UNLOCK_MUTEX(x) { //qDebug() << \"Unlocking mutex \" #x \" at line \" << __LINE__ << \" in file \" << __FILE__ << \" in object \" << (void*)this << \", thread \" << (void*)QThread::currentThread(); x.unlock(); }\r\n \r\n+\r\n+// clang doesn't understand -Wterminate\r\n+#ifdef __clang__\r\n+#define HIDE_COMPILE_WARNINGS _Pragma(\"GCC diagnostic push\") \\\r\n+\t_Pragma(\"GCC diagnostic ignored \\\"-Weffc++\\\"\") \\\r\n+\t_Pragma(\"GCC diagnostic ignored \\\"-Wnon-virtual-dtor\\\"\")\r\n+#else\r\n+#define HIDE_COMPILE_WARNINGS _Pragma(\"GCC diagnostic push\") \\\r\n+\t_Pragma(\"GCC diagnostic ignored \\\"-Weffc++\\\"\") \\\r\n+\t_Pragma(\"GCC diagnostic ignored \\\"-Wnon-virtual-dtor\\\"\") \\\r\n+\t_Pragma(\"GCC diagnostic ignored \\\"-Wterminate\\\"\")\r\n+#endif\r\n+\r\n+#define UNHIDE_COMPILE_WARNINGS _Pragma(\"GCC diagnostic pop\")\r\n+\r","path":"main/global.h","position":27,"original_position":27,"commit_id":"41e170a0c09cd2028c8fa9c9e3aa0f158cd575ca","original_commit_id":"41e170a0c09cd2028c8fa9c9e3aa0f158cd575ca","user":{"login":"pento","id":352291,"avatar_url":"https://avatars.githubusercontent.com/u/352291?v=3","gravatar_id":"","url":"https://api.github.com/users/pento","html_url":"https://github.com/pento","followers_url":"https://api.github.com/users/pento/followers","following_url":"https://api.github.com/users/pento/following{/other_user}","gists_url":"https://api.github.com/users/pento/gists{/gist_id}","starred_url":"https://api.github.com/users/pento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pento/subscriptions","organizations_url":"https://api.github.com/users/pento/orgs","repos_url":"https://api.github.com/users/pento/repos","events_url":"https://api.github.com/users/pento/events{/privacy}","received_events_url":"https://api.github.com/users/pento/received_events","type":"User","site_admin":false},"body":"I think I have these macros right, but a sanity check would be nice.","created_at":"2017-01-17T12:25:29Z","updated_at":"2017-01-17T12:25:29Z","html_url":"https://github.com/PonyEdit/PonyEdit/pull/16#discussion_r96400179","pull_request_url":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/16","_links":{"self":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/comments/96400179"},"html":{"href":"https://github.com/PonyEdit/PonyEdit/pull/16#discussion_r96400179"},"pull_request":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/16"}}},"pull_request":{"url":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/16","id":101009894,"html_url":"https://github.com/PonyEdit/PonyEdit/pull/16","diff_url":"https://github.com/PonyEdit/PonyEdit/pull/16.diff","patch_url":"https://github.com/PonyEdit/PonyEdit/pull/16.patch","issue_url":"https://api.github.com/repos/PonyEdit/PonyEdit/issues/16","number":16,"state":"open","locked":false,"title":"Conform to -Weffc++","user":{"login":"pento","id":352291,"avatar_url":"https://avatars.githubusercontent.com/u/352291?v=3","gravatar_id":"","url":"https://api.github.com/users/pento","html_url":"https://github.com/pento","followers_url":"https://api.github.com/users/pento/followers","following_url":"https://api.github.com/users/pento/following{/other_user}","gists_url":"https://api.github.com/users/pento/gists{/gist_id}","starred_url":"https://api.github.com/users/pento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pento/subscriptions","organizations_url":"https://api.github.com/users/pento/orgs","repos_url":"https://api.github.com/users/pento/repos","events_url":"https://api.github.com/users/pento/events{/privacy}","received_events_url":"https://api.github.com/users/pento/received_events","type":"User","site_admin":false},"body":"There is still much to do. Much to do - this PR is in no state to be merged.","created_at":"2017-01-11T06:21:48Z","updated_at":"2017-01-17T12:25:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63c680ff0d8174fcf6745d8dc6e13dc784414046","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/16/commits","review_comments_url":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/16/comments","review_comment_url":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PonyEdit/PonyEdit/issues/16/comments","statuses_url":"https://api.github.com/repos/PonyEdit/PonyEdit/statuses/41e170a0c09cd2028c8fa9c9e3aa0f158cd575ca","head":{"label":"PonyEdit:feature/15-effective-cpp","ref":"feature/15-effective-cpp","sha":"41e170a0c09cd2028c8fa9c9e3aa0f158cd575ca","user":{"login":"PonyEdit","id":5423343,"avatar_url":"https://avatars.githubusercontent.com/u/5423343?v=3","gravatar_id":"","url":"https://api.github.com/users/PonyEdit","html_url":"https://github.com/PonyEdit","followers_url":"https://api.github.com/users/PonyEdit/followers","following_url":"https://api.github.com/users/PonyEdit/following{/other_user}","gists_url":"https://api.github.com/users/PonyEdit/gists{/gist_id}","starred_url":"https://api.github.com/users/PonyEdit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PonyEdit/subscriptions","organizations_url":"https://api.github.com/users/PonyEdit/orgs","repos_url":"https://api.github.com/users/PonyEdit/repos","events_url":"https://api.github.com/users/PonyEdit/events{/privacy}","received_events_url":"https://api.github.com/users/PonyEdit/received_events","type":"Organization","site_admin":false},"repo":{"id":11861723,"name":"PonyEdit","full_name":"PonyEdit/PonyEdit","owner":{"login":"PonyEdit","id":5423343,"avatar_url":"https://avatars.githubusercontent.com/u/5423343?v=3","gravatar_id":"","url":"https://api.github.com/users/PonyEdit","html_url":"https://github.com/PonyEdit","followers_url":"https://api.github.com/users/PonyEdit/followers","following_url":"https://api.github.com/users/PonyEdit/following{/other_user}","gists_url":"https://api.github.com/users/PonyEdit/gists{/gist_id}","starred_url":"https://api.github.com/users/PonyEdit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PonyEdit/subscriptions","organizations_url":"https://api.github.com/users/PonyEdit/orgs","repos_url":"https://api.github.com/users/PonyEdit/repos","events_url":"https://api.github.com/users/PonyEdit/events{/privacy}","received_events_url":"https://api.github.com/users/PonyEdit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PonyEdit/PonyEdit","description":"Coding at the speed of thought:","fork":false,"url":"https://api.github.com/repos/PonyEdit/PonyEdit","forks_url":"https://api.github.com/repos/PonyEdit/PonyEdit/forks","keys_url":"https://api.github.com/repos/PonyEdit/PonyEdit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PonyEdit/PonyEdit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PonyEdit/PonyEdit/teams","hooks_url":"https://api.github.com/repos/PonyEdit/PonyEdit/hooks","issue_events_url":"https://api.github.com/repos/PonyEdit/PonyEdit/issues/events{/number}","events_url":"https://api.github.com/repos/PonyEdit/PonyEdit/events","assignees_url":"https://api.github.com/repos/PonyEdit/PonyEdit/assignees{/user}","branches_url":"https://api.github.com/repos/PonyEdit/PonyEdit/branches{/branch}","tags_url":"https://api.github.com/repos/PonyEdit/PonyEdit/tags","blobs_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/refs{/sha}","trees_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PonyEdit/PonyEdit/statuses/{sha}","languages_url":"https://api.github.com/repos/PonyEdit/PonyEdit/languages","stargazers_url":"https://api.github.com/repos/PonyEdit/PonyEdit/stargazers","contributors_url":"https://api.github.com/repos/PonyEdit/PonyEdit/contributors","subscribers_url":"https://api.github.com/repos/PonyEdit/PonyEdit/subscribers","subscription_url":"https://api.github.com/repos/PonyEdit/PonyEdit/subscription","commits_url":"https://api.github.com/repos/PonyEdit/PonyEdit/commits{/sha}","git_commits_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/commits{/sha}","comments_url":"https://api.github.com/repos/PonyEdit/PonyEdit/comments{/number}","issue_comment_url":"https://api.github.com/repos/PonyEdit/PonyEdit/issues/comments{/number}","contents_url":"https://api.github.com/repos/PonyEdit/PonyEdit/contents/{+path}","compare_url":"https://api.github.com/repos/PonyEdit/PonyEdit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PonyEdit/PonyEdit/merges","archive_url":"https://api.github.com/repos/PonyEdit/PonyEdit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PonyEdit/PonyEdit/downloads","issues_url":"https://api.github.com/repos/PonyEdit/PonyEdit/issues{/number}","pulls_url":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls{/number}","milestones_url":"https://api.github.com/repos/PonyEdit/PonyEdit/milestones{/number}","notifications_url":"https://api.github.com/repos/PonyEdit/PonyEdit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PonyEdit/PonyEdit/labels{/name}","releases_url":"https://api.github.com/repos/PonyEdit/PonyEdit/releases{/id}","deployments_url":"https://api.github.com/repos/PonyEdit/PonyEdit/deployments","created_at":"2013-08-03T10:35:51Z","updated_at":"2017-01-07T04:53:16Z","pushed_at":"2017-01-17T12:22:06Z","git_url":"git://github.com/PonyEdit/PonyEdit.git","ssh_url":"git@github.com:PonyEdit/PonyEdit.git","clone_url":"https://github.com/PonyEdit/PonyEdit.git","svn_url":"https://github.com/PonyEdit/PonyEdit","homepage":"http://ponyedit.com/","size":32940,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":18,"forks":3,"open_issues":18,"watchers":9,"default_branch":"master"}},"base":{"label":"PonyEdit:master","ref":"master","sha":"5960f442fb0e1dcd1dc4b33d4b4ef459c6d80a14","user":{"login":"PonyEdit","id":5423343,"avatar_url":"https://avatars.githubusercontent.com/u/5423343?v=3","gravatar_id":"","url":"https://api.github.com/users/PonyEdit","html_url":"https://github.com/PonyEdit","followers_url":"https://api.github.com/users/PonyEdit/followers","following_url":"https://api.github.com/users/PonyEdit/following{/other_user}","gists_url":"https://api.github.com/users/PonyEdit/gists{/gist_id}","starred_url":"https://api.github.com/users/PonyEdit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PonyEdit/subscriptions","organizations_url":"https://api.github.com/users/PonyEdit/orgs","repos_url":"https://api.github.com/users/PonyEdit/repos","events_url":"https://api.github.com/users/PonyEdit/events{/privacy}","received_events_url":"https://api.github.com/users/PonyEdit/received_events","type":"Organization","site_admin":false},"repo":{"id":11861723,"name":"PonyEdit","full_name":"PonyEdit/PonyEdit","owner":{"login":"PonyEdit","id":5423343,"avatar_url":"https://avatars.githubusercontent.com/u/5423343?v=3","gravatar_id":"","url":"https://api.github.com/users/PonyEdit","html_url":"https://github.com/PonyEdit","followers_url":"https://api.github.com/users/PonyEdit/followers","following_url":"https://api.github.com/users/PonyEdit/following{/other_user}","gists_url":"https://api.github.com/users/PonyEdit/gists{/gist_id}","starred_url":"https://api.github.com/users/PonyEdit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PonyEdit/subscriptions","organizations_url":"https://api.github.com/users/PonyEdit/orgs","repos_url":"https://api.github.com/users/PonyEdit/repos","events_url":"https://api.github.com/users/PonyEdit/events{/privacy}","received_events_url":"https://api.github.com/users/PonyEdit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PonyEdit/PonyEdit","description":"Coding at the speed of thought:","fork":false,"url":"https://api.github.com/repos/PonyEdit/PonyEdit","forks_url":"https://api.github.com/repos/PonyEdit/PonyEdit/forks","keys_url":"https://api.github.com/repos/PonyEdit/PonyEdit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PonyEdit/PonyEdit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PonyEdit/PonyEdit/teams","hooks_url":"https://api.github.com/repos/PonyEdit/PonyEdit/hooks","issue_events_url":"https://api.github.com/repos/PonyEdit/PonyEdit/issues/events{/number}","events_url":"https://api.github.com/repos/PonyEdit/PonyEdit/events","assignees_url":"https://api.github.com/repos/PonyEdit/PonyEdit/assignees{/user}","branches_url":"https://api.github.com/repos/PonyEdit/PonyEdit/branches{/branch}","tags_url":"https://api.github.com/repos/PonyEdit/PonyEdit/tags","blobs_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/refs{/sha}","trees_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PonyEdit/PonyEdit/statuses/{sha}","languages_url":"https://api.github.com/repos/PonyEdit/PonyEdit/languages","stargazers_url":"https://api.github.com/repos/PonyEdit/PonyEdit/stargazers","contributors_url":"https://api.github.com/repos/PonyEdit/PonyEdit/contributors","subscribers_url":"https://api.github.com/repos/PonyEdit/PonyEdit/subscribers","subscription_url":"https://api.github.com/repos/PonyEdit/PonyEdit/subscription","commits_url":"https://api.github.com/repos/PonyEdit/PonyEdit/commits{/sha}","git_commits_url":"https://api.github.com/repos/PonyEdit/PonyEdit/git/commits{/sha}","comments_url":"https://api.github.com/repos/PonyEdit/PonyEdit/comments{/number}","issue_comment_url":"https://api.github.com/repos/PonyEdit/PonyEdit/issues/comments{/number}","contents_url":"https://api.github.com/repos/PonyEdit/PonyEdit/contents/{+path}","compare_url":"https://api.github.com/repos/PonyEdit/PonyEdit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PonyEdit/PonyEdit/merges","archive_url":"https://api.github.com/repos/PonyEdit/PonyEdit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PonyEdit/PonyEdit/downloads","issues_url":"https://api.github.com/repos/PonyEdit/PonyEdit/issues{/number}","pulls_url":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls{/number}","milestones_url":"https://api.github.com/repos/PonyEdit/PonyEdit/milestones{/number}","notifications_url":"https://api.github.com/repos/PonyEdit/PonyEdit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PonyEdit/PonyEdit/labels{/name}","releases_url":"https://api.github.com/repos/PonyEdit/PonyEdit/releases{/id}","deployments_url":"https://api.github.com/repos/PonyEdit/PonyEdit/deployments","created_at":"2013-08-03T10:35:51Z","updated_at":"2017-01-07T04:53:16Z","pushed_at":"2017-01-17T12:22:06Z","git_url":"git://github.com/PonyEdit/PonyEdit.git","ssh_url":"git@github.com:PonyEdit/PonyEdit.git","clone_url":"https://github.com/PonyEdit/PonyEdit.git","svn_url":"https://github.com/PonyEdit/PonyEdit","homepage":"http://ponyedit.com/","size":32940,"stargazers_count":9,"watchers_count":9,"language":"C++","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":18,"forks":3,"open_issues":18,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/16"},"html":{"href":"https://github.com/PonyEdit/PonyEdit/pull/16"},"issue":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/issues/16"},"comments":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/PonyEdit/PonyEdit/statuses/41e170a0c09cd2028c8fa9c9e3aa0f158cd575ca"}}}}
{"actor":{"display_login":"pento"}}