{"action":"created","issue":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/19367","repository_url":"https://api.github.com/repos/cms-sw/cmssw","labels_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19367/labels{/name}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19367/comments","events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19367/events","html_url":"https://github.com/cms-sw/cmssw/pull/19367","id":236919270,"number":19367,"title":"Add include to CandDecaySelector.h to ObjectSelector.h","user":{"login":"Teemperor","id":736001,"avatar_url":"https://avatars3.githubusercontent.com/u/736001?v=3","gravatar_id":"","url":"https://api.github.com/users/Teemperor","html_url":"https://github.com/Teemperor","followers_url":"https://api.github.com/users/Teemperor/followers","following_url":"https://api.github.com/users/Teemperor/following{/other_user}","gists_url":"https://api.github.com/users/Teemperor/gists{/gist_id}","starred_url":"https://api.github.com/users/Teemperor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teemperor/subscriptions","organizations_url":"https://api.github.com/users/Teemperor/orgs","repos_url":"https://api.github.com/users/Teemperor/repos","events_url":"https://api.github.com/users/Teemperor/events{/privacy}","received_events_url":"https://api.github.com/users/Teemperor/received_events","type":"User","site_admin":false},"labels":[{"id":52881179,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/analysis-pending","name":"analysis-pending","color":"fbca04","default":false},{"id":88653795,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"eb6420","default":false},{"id":52820010,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/reconstruction-pending","name":"reconstruction-pending","color":"fbca04","default":false},{"id":170521617,"url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66","html_url":"https://github.com/cms-sw/cmssw/milestone/66","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/66/labels","id":2497352,"number":66,"title":"CMSSW_9_2_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars0.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":160,"closed_issues":525,"state":"open","created_at":"2017-05-03T13:18:43Z","updated_at":"2017-06-19T15:38:11Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2017-06-19T14:56:43Z","updated_at":"2017-06-19T18:00:13Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/19367","html_url":"https://github.com/cms-sw/cmssw/pull/19367","diff_url":"https://github.com/cms-sw/cmssw/pull/19367.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/19367.patch"},"body":"There is specialization for StoreManagerTrait in CandDecaySelector.h\r\nthat is sometimes selected in some headers that use ObjectSelector.h\r\n(ObjectShallowCloneSelector.h and SingleObjectShallowCloneSelector.h\r\nto be precise).\r\n\r\nPreviously clang/gcc wasn't aware of this specialization because it wasn't\r\ndirectly included from those headers, but with C++ modules clang sees\r\nthe non-included specialization and requests us to include CandDecaySelector.h."},"comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments/309518362","html_url":"https://github.com/cms-sw/cmssw/pull/19367#issuecomment-309518362","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/19367","id":309518362,"user":{"login":"cmsbuild","id":4170616,"avatar_url":"https://avatars2.githubusercontent.com/u/4170616?v=3","gravatar_id":"","url":"https://api.github.com/users/cmsbuild","html_url":"https://github.com/cmsbuild","followers_url":"https://api.github.com/users/cmsbuild/followers","following_url":"https://api.github.com/users/cmsbuild/following{/other_user}","gists_url":"https://api.github.com/users/cmsbuild/gists{/gist_id}","starred_url":"https://api.github.com/users/cmsbuild/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmsbuild/subscriptions","organizations_url":"https://api.github.com/users/cmsbuild/orgs","repos_url":"https://api.github.com/users/cmsbuild/repos","events_url":"https://api.github.com/users/cmsbuild/events{/privacy}","received_events_url":"https://api.github.com/users/cmsbuild/received_events","type":"User","site_admin":false},"created_at":"2017-06-19T18:00:13Z","updated_at":"2017-06-19T18:00:13Z","body":"-1\n\nTested at: dcddb80ef531c3cc07cc9162b89bd3097065fb93\n\nYou can see the results of the tests here:\nhttps://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-19367/20758/summary.html\n\nI found follow errors while testing this PR\n\n**Failed tests:  Build  ClangBuild**\n\n* **Build**:\n\nI found an error when building: \n \n <pre>                                                               ^\n\f>> Compiling edm plugin /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/RecoHI/HiTracking/plugins/HIPixelMedianVtxProducer.cc \n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/UtilAlgos/interface/ObjectSelector.h:20:0,\n\f                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/UtilAlgos/interface/ObjectSelectorStream.h:23,\n\f                 from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/RecoHI/HiTracking/plugins/HIBestVertexSelector.cc:3:\n\f/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/CandAlgos/interface/CandDecaySelector.h:47:10: error: 'StoreManagerTrait' is not a class template\n\f\f   struct StoreManagerTrait<reco::CandidateCollection, EdmFilter> {\r\n\f          ^\n\f/build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/CandAlgos/interface/CandDecaySelector.h:49:13: error: 'ObjectSelectorBase' does not name a type\n\f     typedef ObjectSelectorBase<reco::CandidateCollection, EdmFilter> base;\r\n\f             ^\n\f</pre>\n\n* **Clang**:\n\nI found a compilation error while trying to compile with clang: \nI used this command: \n scram b vclean && scram build -k -j 16 USER_CXXFLAGS='-fsyntax-only' COMPILER='llvm compile'\n\n\n <pre>                                                              //\n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/UtilAlgos/plugins/SealModule.cc:3:\n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/UtilAlgos/plugins/DeltaROverlapExclusionSelector.h:2:\n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/UtilAlgos/interface/SingleObjectSelector.h:7:\n\fIn file included from /build/cmsbld/jenkins-workarea/workspace/ib-any-integration/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/UtilAlgos/interface/ObjectSelector.h:20:\n\f/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/CandAlgos/interface/CandDecaySelector.h:47:10: error: explicit specialization of non-template struct 'StoreManagerTrait'\n\f\f  struct StoreManagerTrait<reco::CandidateCollection, EdmFilter> {\n\f         ^                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\n\f/cvmfs/cms-ib.cern.ch/nweek-02477/slc6_amd64_gcc530/cms/cmssw-patch/CMSSW_9_2_X_2017-06-19-1100/src/CommonTools/CandAlgos/interface/CandDecaySelector.h:49:13: error: unknown type name 'ObjectSelectorBase'\n\f    typedef ObjectSelectorBase<reco::CandidateCollection, EdmFilter> base;\n\f            ^\n\f</pre>\n"}}
{"actor":{"display_login":"cmsbuild"}}