{"action":"closed","number":6359,"pull_request":{"url":"https://api.github.com/repos/babel/babel/pulls/6359","id":144120165,"html_url":"https://github.com/babel/babel/pull/6359","diff_url":"https://github.com/babel/babel/pull/6359.diff","patch_url":"https://github.com/babel/babel/pull/6359.patch","issue_url":"https://api.github.com/repos/babel/babel/issues/6359","number":6359,"state":"closed","locked":false,"title":"Split up babel-core's File class and add Flowtype annotations","user":{"login":"loganfsmyth","id":132260,"avatar_url":"https://avatars1.githubusercontent.com/u/132260?v=4","gravatar_id":"","url":"https://api.github.com/users/loganfsmyth","html_url":"https://github.com/loganfsmyth","followers_url":"https://api.github.com/users/loganfsmyth/followers","following_url":"https://api.github.com/users/loganfsmyth/following{/other_user}","gists_url":"https://api.github.com/users/loganfsmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/loganfsmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganfsmyth/subscriptions","organizations_url":"https://api.github.com/users/loganfsmyth/orgs","repos_url":"https://api.github.com/users/loganfsmyth/repos","events_url":"https://api.github.com/users/loganfsmyth/events{/privacy}","received_events_url":"https://api.github.com/users/loganfsmyth/received_events","type":"User","site_admin":false},"body":"| Q                        | A <!--(can use an emoji 👍 ) -->\r\n| ------------------------ | ---\r\n| Fixed Issues             | \r\n| Patch: Bug Fix?          | N\r\n| Major: Breaking Change?  | N, unless you're using undocumented methods/props on `File`.\r\n| Minor: New Feature?      | \r\n| Tests Added/Pass?        | \r\n| Spec Compliancy?         | \r\n| License                  | MIT\r\n| Doc PR                   | <!-- if yes, can add `[skip ci]` to your commit message to skip CI builds -->\r\n| Any Dependency Changes?  | \r\n\r\nFYI, may be easiest to review by commit. Mostly refactoring. I've removed the parts of the `File` class that weren't part of the user-facing API and moved then to be their own files.\r\n\r\nActual features in here:\r\n* Added `browser` files for the 2 `transformFile*` files that actually rely on `fs` so Webpack will complain less.\r\n* Flowtype on every file in `babel-core` now except `build-external-helpers`.\r\n* We now get useful code snippets in exceptions thrown by `babel-template` \r\n* It's a bit easier to follow the transform process now that it's not a chain of class methods.","created_at":"2017-10-02T06:57:53Z","updated_at":"2017-10-02T21:08:57Z","closed_at":"2017-10-02T21:08:57Z","merged_at":"2017-10-02T21:08:57Z","merge_commit_sha":"cc8109cdc307f5b50fb4dd5236ecda2fd1720e30","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/babel/babel/pulls/6359/commits","review_comments_url":"https://api.github.com/repos/babel/babel/pulls/6359/comments","review_comment_url":"https://api.github.com/repos/babel/babel/pulls/comments{/number}","comments_url":"https://api.github.com/repos/babel/babel/issues/6359/comments","statuses_url":"https://api.github.com/repos/babel/babel/statuses/f02e6847cf91f5d0f6bef94648ab93919e53a648","head":{"label":"loganfsmyth:file-simplification","ref":"file-simplification","sha":"f02e6847cf91f5d0f6bef94648ab93919e53a648","user":{"login":"loganfsmyth","id":132260,"avatar_url":"https://avatars1.githubusercontent.com/u/132260?v=4","gravatar_id":"","url":"https://api.github.com/users/loganfsmyth","html_url":"https://github.com/loganfsmyth","followers_url":"https://api.github.com/users/loganfsmyth/followers","following_url":"https://api.github.com/users/loganfsmyth/following{/other_user}","gists_url":"https://api.github.com/users/loganfsmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/loganfsmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganfsmyth/subscriptions","organizations_url":"https://api.github.com/users/loganfsmyth/orgs","repos_url":"https://api.github.com/users/loganfsmyth/repos","events_url":"https://api.github.com/users/loganfsmyth/events{/privacy}","received_events_url":"https://api.github.com/users/loganfsmyth/received_events","type":"User","site_admin":false},"repo":{"id":34920245,"name":"babel","full_name":"loganfsmyth/babel","owner":{"login":"loganfsmyth","id":132260,"avatar_url":"https://avatars1.githubusercontent.com/u/132260?v=4","gravatar_id":"","url":"https://api.github.com/users/loganfsmyth","html_url":"https://github.com/loganfsmyth","followers_url":"https://api.github.com/users/loganfsmyth/followers","following_url":"https://api.github.com/users/loganfsmyth/following{/other_user}","gists_url":"https://api.github.com/users/loganfsmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/loganfsmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganfsmyth/subscriptions","organizations_url":"https://api.github.com/users/loganfsmyth/orgs","repos_url":"https://api.github.com/users/loganfsmyth/repos","events_url":"https://api.github.com/users/loganfsmyth/events{/privacy}","received_events_url":"https://api.github.com/users/loganfsmyth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/loganfsmyth/babel","description":"Babel is a compiler for writing next generation JavaScript.","fork":true,"url":"https://api.github.com/repos/loganfsmyth/babel","forks_url":"https://api.github.com/repos/loganfsmyth/babel/forks","keys_url":"https://api.github.com/repos/loganfsmyth/babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loganfsmyth/babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loganfsmyth/babel/teams","hooks_url":"https://api.github.com/repos/loganfsmyth/babel/hooks","issue_events_url":"https://api.github.com/repos/loganfsmyth/babel/issues/events{/number}","events_url":"https://api.github.com/repos/loganfsmyth/babel/events","assignees_url":"https://api.github.com/repos/loganfsmyth/babel/assignees{/user}","branches_url":"https://api.github.com/repos/loganfsmyth/babel/branches{/branch}","tags_url":"https://api.github.com/repos/loganfsmyth/babel/tags","blobs_url":"https://api.github.com/repos/loganfsmyth/babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loganfsmyth/babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loganfsmyth/babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/loganfsmyth/babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loganfsmyth/babel/statuses/{sha}","languages_url":"https://api.github.com/repos/loganfsmyth/babel/languages","stargazers_url":"https://api.github.com/repos/loganfsmyth/babel/stargazers","contributors_url":"https://api.github.com/repos/loganfsmyth/babel/contributors","subscribers_url":"https://api.github.com/repos/loganfsmyth/babel/subscribers","subscription_url":"https://api.github.com/repos/loganfsmyth/babel/subscription","commits_url":"https://api.github.com/repos/loganfsmyth/babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/loganfsmyth/babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/loganfsmyth/babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/loganfsmyth/babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/loganfsmyth/babel/contents/{+path}","compare_url":"https://api.github.com/repos/loganfsmyth/babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loganfsmyth/babel/merges","archive_url":"https://api.github.com/repos/loganfsmyth/babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loganfsmyth/babel/downloads","issues_url":"https://api.github.com/repos/loganfsmyth/babel/issues{/number}","pulls_url":"https://api.github.com/repos/loganfsmyth/babel/pulls{/number}","milestones_url":"https://api.github.com/repos/loganfsmyth/babel/milestones{/number}","notifications_url":"https://api.github.com/repos/loganfsmyth/babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loganfsmyth/babel/labels{/name}","releases_url":"https://api.github.com/repos/loganfsmyth/babel/releases{/id}","deployments_url":"https://api.github.com/repos/loganfsmyth/babel/deployments","created_at":"2015-05-01T19:33:26Z","updated_at":"2015-05-01T19:33:28Z","pushed_at":"2017-10-02T20:57:14Z","git_url":"git://github.com/loganfsmyth/babel.git","ssh_url":"git@github.com:loganfsmyth/babel.git","clone_url":"https://github.com/loganfsmyth/babel.git","svn_url":"https://github.com/loganfsmyth/babel","homepage":"https://babeljs.io/","size":19462,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"babel:master","ref":"master","sha":"4a8137c6b42a6ac7ad20b791453861f520bd3044","user":{"login":"babel","id":9637642,"avatar_url":"https://avatars1.githubusercontent.com/u/9637642?v=4","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"repo":{"id":24560307,"name":"babel","full_name":"babel/babel","owner":{"login":"babel","id":9637642,"avatar_url":"https://avatars1.githubusercontent.com/u/9637642?v=4","gravatar_id":"","url":"https://api.github.com/users/babel","html_url":"https://github.com/babel","followers_url":"https://api.github.com/users/babel/followers","following_url":"https://api.github.com/users/babel/following{/other_user}","gists_url":"https://api.github.com/users/babel/gists{/gist_id}","starred_url":"https://api.github.com/users/babel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/babel/subscriptions","organizations_url":"https://api.github.com/users/babel/orgs","repos_url":"https://api.github.com/users/babel/repos","events_url":"https://api.github.com/users/babel/events{/privacy}","received_events_url":"https://api.github.com/users/babel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/babel/babel","description":":tropical_fish: Babel is a compiler for writing next generation JavaScript.","fork":false,"url":"https://api.github.com/repos/babel/babel","forks_url":"https://api.github.com/repos/babel/babel/forks","keys_url":"https://api.github.com/repos/babel/babel/keys{/key_id}","collaborators_url":"https://api.github.com/repos/babel/babel/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/babel/babel/teams","hooks_url":"https://api.github.com/repos/babel/babel/hooks","issue_events_url":"https://api.github.com/repos/babel/babel/issues/events{/number}","events_url":"https://api.github.com/repos/babel/babel/events","assignees_url":"https://api.github.com/repos/babel/babel/assignees{/user}","branches_url":"https://api.github.com/repos/babel/babel/branches{/branch}","tags_url":"https://api.github.com/repos/babel/babel/tags","blobs_url":"https://api.github.com/repos/babel/babel/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/babel/babel/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/babel/babel/git/refs{/sha}","trees_url":"https://api.github.com/repos/babel/babel/git/trees{/sha}","statuses_url":"https://api.github.com/repos/babel/babel/statuses/{sha}","languages_url":"https://api.github.com/repos/babel/babel/languages","stargazers_url":"https://api.github.com/repos/babel/babel/stargazers","contributors_url":"https://api.github.com/repos/babel/babel/contributors","subscribers_url":"https://api.github.com/repos/babel/babel/subscribers","subscription_url":"https://api.github.com/repos/babel/babel/subscription","commits_url":"https://api.github.com/repos/babel/babel/commits{/sha}","git_commits_url":"https://api.github.com/repos/babel/babel/git/commits{/sha}","comments_url":"https://api.github.com/repos/babel/babel/comments{/number}","issue_comment_url":"https://api.github.com/repos/babel/babel/issues/comments{/number}","contents_url":"https://api.github.com/repos/babel/babel/contents/{+path}","compare_url":"https://api.github.com/repos/babel/babel/compare/{base}...{head}","merges_url":"https://api.github.com/repos/babel/babel/merges","archive_url":"https://api.github.com/repos/babel/babel/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/babel/babel/downloads","issues_url":"https://api.github.com/repos/babel/babel/issues{/number}","pulls_url":"https://api.github.com/repos/babel/babel/pulls{/number}","milestones_url":"https://api.github.com/repos/babel/babel/milestones{/number}","notifications_url":"https://api.github.com/repos/babel/babel/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/babel/babel/labels{/name}","releases_url":"https://api.github.com/repos/babel/babel/releases{/id}","deployments_url":"https://api.github.com/repos/babel/babel/deployments","created_at":"2014-09-28T13:38:23Z","updated_at":"2017-10-02T20:43:50Z","pushed_at":"2017-10-02T21:08:57Z","git_url":"git://github.com/babel/babel.git","ssh_url":"git@github.com:babel/babel.git","clone_url":"https://github.com/babel/babel.git","svn_url":"https://github.com/babel/babel","homepage":"https://babeljs.io/","size":19336,"stargazers_count":22754,"watchers_count":22754,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2121,"mirror_url":null,"open_issues_count":302,"forks":2121,"open_issues":302,"watchers":22754,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/babel/babel/pulls/6359"},"html":{"href":"https://github.com/babel/babel/pull/6359"},"issue":{"href":"https://api.github.com/repos/babel/babel/issues/6359"},"comments":{"href":"https://api.github.com/repos/babel/babel/issues/6359/comments"},"review_comments":{"href":"https://api.github.com/repos/babel/babel/pulls/6359/comments"},"review_comment":{"href":"https://api.github.com/repos/babel/babel/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/babel/babel/pulls/6359/commits"},"statuses":{"href":"https://api.github.com/repos/babel/babel/statuses/f02e6847cf91f5d0f6bef94648ab93919e53a648"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"loganfsmyth","id":132260,"avatar_url":"https://avatars1.githubusercontent.com/u/132260?v=4","gravatar_id":"","url":"https://api.github.com/users/loganfsmyth","html_url":"https://github.com/loganfsmyth","followers_url":"https://api.github.com/users/loganfsmyth/followers","following_url":"https://api.github.com/users/loganfsmyth/following{/other_user}","gists_url":"https://api.github.com/users/loganfsmyth/gists{/gist_id}","starred_url":"https://api.github.com/users/loganfsmyth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loganfsmyth/subscriptions","organizations_url":"https://api.github.com/users/loganfsmyth/orgs","repos_url":"https://api.github.com/users/loganfsmyth/repos","events_url":"https://api.github.com/users/loganfsmyth/events{/privacy}","received_events_url":"https://api.github.com/users/loganfsmyth/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":3,"additions":719,"deletions":653,"changed_files":27}}
{"actor":{"display_login":"loganfsmyth"}}