{"action":"created","issue":{"url":"https://api.github.com/repos/git/git-scm.com/issues/918","repository_url":"https://api.github.com/repos/git/git-scm.com","labels_url":"https://api.github.com/repos/git/git-scm.com/issues/918/labels{/name}","comments_url":"https://api.github.com/repos/git/git-scm.com/issues/918/comments","events_url":"https://api.github.com/repos/git/git-scm.com/issues/918/events","html_url":"https://github.com/git/git-scm.com/pull/918","id":199143657,"number":918,"title":"Build generated command lists","user":{"login":"snh","id":2051768,"avatar_url":"https://avatars.githubusercontent.com/u/2051768?v=3","gravatar_id":"","url":"https://api.github.com/users/snh","html_url":"https://github.com/snh","followers_url":"https://api.github.com/users/snh/followers","following_url":"https://api.github.com/users/snh/following{/other_user}","gists_url":"https://api.github.com/users/snh/gists{/gist_id}","starred_url":"https://api.github.com/users/snh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snh/subscriptions","organizations_url":"https://api.github.com/users/snh/orgs","repos_url":"https://api.github.com/users/snh/repos","events_url":"https://api.github.com/users/snh/events{/privacy}","received_events_url":"https://api.github.com/users/snh/received_events","type":"User","site_admin":true},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-01-06T07:55:54Z","updated_at":"2017-01-08T03:34:02Z","closed_at":"2017-01-08T03:22:21Z","pull_request":{"url":"https://api.github.com/repos/git/git-scm.com/pulls/918","html_url":"https://github.com/git/git-scm.com/pull/918","diff_url":"https://github.com/git/git-scm.com/pull/918.diff","patch_url":"https://github.com/git/git-scm.com/pull/918.patch"},"body":"When rendered on the website, the [_Git Commands_ sections](https://git-scm.com/docs/git#_git_commands) of [git(1)](https://github.com/git/git/blob/e05806da9ec4aff8adfed142ab2a2b3b02e33c8c/Documentation/git.txt) are currently blank for recent versions of Git. This is occurring because the underlying included files, such as `cmds-mainporcelain.txt`, are built dynamically by the [Documentation Makefile](https://github.com/git/git/blob/e05806da9ec4aff8adfed142ab2a2b3b02e33c8c/Documentation/Makefile#L276-L291).\r\n\r\nIt appears that we did begin handling these in the _preindex_ Rake task in https://github.com/git/git-scm.com/commit/68f5440d36bc22ec08f8f2a3b659206c273fee8e, but then removed support in https://github.com/git/git-scm.com/commit/4f921265326fcfa2540b3ed833adb4b44270f859.\r\n\r\nThis PR reintroduces this functionality to the _preindex_ Rake task, and also adds it to the _local_index_ Rake task, dynamically generating these files as required."},"comment":{"url":"https://api.github.com/repos/git/git-scm.com/issues/comments/271127254","html_url":"https://github.com/git/git-scm.com/pull/918#issuecomment-271127254","issue_url":"https://api.github.com/repos/git/git-scm.com/issues/918","id":271127254,"user":{"login":"peff","id":45925,"avatar_url":"https://avatars.githubusercontent.com/u/45925?v=3","gravatar_id":"","url":"https://api.github.com/users/peff","html_url":"https://github.com/peff","followers_url":"https://api.github.com/users/peff/followers","following_url":"https://api.github.com/users/peff/following{/other_user}","gists_url":"https://api.github.com/users/peff/gists{/gist_id}","starred_url":"https://api.github.com/users/peff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/peff/subscriptions","organizations_url":"https://api.github.com/users/peff/orgs","repos_url":"https://api.github.com/users/peff/repos","events_url":"https://api.github.com/users/peff/events{/privacy}","received_events_url":"https://api.github.com/users/peff/received_events","type":"User","site_admin":true},"created_at":"2017-01-08T03:34:02Z","updated_at":"2017-01-08T03:34:02Z","body":"Hmm. I spoke too soon. The `local_index` task works, but `preindex` seems broken:\r\n\r\n```\r\n** Execute preindex\r\nv2.11.0\r\nv2.11.0: 2016-11-29 20:23:07 UTC, 454cb6bd, a7e3983d\r\nFound 189 entries\r\n   build: diff-config\r\nrake aborted!\r\nNoMethodError: undefined method `sha' for nil:NilClass\r\n/app/lib/tasks/index.rake:88:in `block in expand!'\r\n/app/lib/tasks/index.rake:85:in `gsub!'\r\n/app/lib/tasks/index.rake:85:in `expand!'\r\n/app/lib/tasks/index.rake:103:in `block (3 levels) in <top (required)>'\r\n/app/lib/tasks/index.rake:96:in `each'\r\n/app/lib/tasks/index.rake:96:in `block (2 levels) in <top (required)>'\r\n/app/lib/tasks/index.rake:30:in `each'\r\n/app/lib/tasks/index.rake:30:in `block in <top (required)>'\r\n```"}}
{"actor":{"display_login":"peff"}}