{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/156029566","pull_request_review_id":82434032,"id":156029566,"diff_hunk":"@@ -197,7 +197,7 @@ public virtual void ProcessBlock(Block block)\n                 }\n                 else\n                 {\n-                    ChainedBlock findTip = this.walletTip.FindAncestorOrSelf(newTip.HashBlock);\n+                    ChainedBlock findTip = this.walletTip.GetAncestor(newTip.Height);","path":"src/Stratis.Bitcoin.Features.Wallet/WalletSyncManager.cs","position":14,"original_position":14,"commit_id":"d664e33f47fc31215146aa17d8823b64b9a915a2","original_commit_id":"d664e33f47fc31215146aa17d8823b64b9a915a2","user":{"login":"Aprogiena","id":30052221,"avatar_url":"https://avatars0.githubusercontent.com/u/30052221?v=4","gravatar_id":"","url":"https://api.github.com/users/Aprogiena","html_url":"https://github.com/Aprogiena","followers_url":"https://api.github.com/users/Aprogiena/followers","following_url":"https://api.github.com/users/Aprogiena/following{/other_user}","gists_url":"https://api.github.com/users/Aprogiena/gists{/gist_id}","starred_url":"https://api.github.com/users/Aprogiena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aprogiena/subscriptions","organizations_url":"https://api.github.com/users/Aprogiena/orgs","repos_url":"https://api.github.com/users/Aprogiena/repos","events_url":"https://api.github.com/users/Aprogiena/events{/privacy}","received_events_url":"https://api.github.com/users/Aprogiena/received_events","type":"User","site_admin":false},"body":"same here, this change is wrong\r\nyou can use get ancestor for this instead of FAOS, but in fact it would be better to change implementation of FAOS (and maybe add tests to it)\r\n\r\n","created_at":"2017-12-11T10:13:59Z","updated_at":"2017-12-11T10:14:26Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/878#discussion_r156029566","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/878","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/156029566"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/878#discussion_r156029566"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/878"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/878","id":157402759,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/878","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/878.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/878.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/878","number":878,"state":"open","locked":false,"title":"For chain searches use skip list method instead of linear searches","user":{"login":"mikedennis","id":24234359,"avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"body":"This PR \r\n* Replaces linear searches on chain headers with GetAncestor which uses skip list to search for block heights which will improve performance\r\n* Move FindFork method that was only used by tests into tests\r\n\r\nIssue #659 \r\n","created_at":"2017-12-09T20:18:21Z","updated_at":"2017-12-11T10:14:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b50d6e9e79cb5c61199f507291a03f3c170a1f3d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/878/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/878/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/878/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/d664e33f47fc31215146aa17d8823b64b9a915a2","head":{"label":"mikedennis:skiplist-enum","ref":"skiplist-enum","sha":"d664e33f47fc31215146aa17d8823b64b9a915a2","user":{"login":"mikedennis","id":24234359,"avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"repo":{"id":96908927,"name":"StratisBitcoinFullNode","full_name":"mikedennis/StratisBitcoinFullNode","owner":{"login":"mikedennis","id":24234359,"avatar_url":"https://avatars0.githubusercontent.com/u/24234359?v=4","gravatar_id":"","url":"https://api.github.com/users/mikedennis","html_url":"https://github.com/mikedennis","followers_url":"https://api.github.com/users/mikedennis/followers","following_url":"https://api.github.com/users/mikedennis/following{/other_user}","gists_url":"https://api.github.com/users/mikedennis/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedennis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedennis/subscriptions","organizations_url":"https://api.github.com/users/mikedennis/orgs","repos_url":"https://api.github.com/users/mikedennis/repos","events_url":"https://api.github.com/users/mikedennis/events{/privacy}","received_events_url":"https://api.github.com/users/mikedennis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikedennis/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/mikedennis/StratisBitcoinFullNode/deployments","created_at":"2017-07-11T15:32:38Z","updated_at":"2017-07-11T15:32:41Z","pushed_at":"2017-12-09T20:14:43Z","git_url":"git://github.com/mikedennis/StratisBitcoinFullNode.git","ssh_url":"git@github.com:mikedennis/StratisBitcoinFullNode.git","clone_url":"https://github.com/mikedennis/StratisBitcoinFullNode.git","svn_url":"https://github.com/mikedennis/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":13301,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"63f6af06cf470fdef2495509e845a8b65689f578","user":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2017-12-10T23:15:38Z","pushed_at":"2017-12-11T05:58:51Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":13201,"stargazers_count":247,"watchers_count":247,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":112,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":112,"open_issues":75,"watchers":247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/878"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/878"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/878"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/878/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/878/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/878/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/d664e33f47fc31215146aa17d8823b64b9a915a2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Aprogiena"}}