{"action":"created","comment":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/comments/153705666","pull_request_review_id":79742566,"id":153705666,"diff_hunk":"@@ -29,76 +29,93 @@ class PytorchSeq2SeqWrapper(Seq2SeqEncoder):\n     Note that we *require* you to pass sequence lengths when you call this module, to avoid subtle","path":"allennlp/modules/seq2seq_encoders/pytorch_seq2seq_wrapper.py","position":13,"original_position":13,"commit_id":"98a168f24793004f8e37f976d9508b5a4d05bfd3","original_commit_id":"98a168f24793004f8e37f976d9508b5a4d05bfd3","user":{"login":"matt-gardner","id":3291951,"avatar_url":"https://avatars2.githubusercontent.com/u/3291951?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-gardner","html_url":"https://github.com/matt-gardner","followers_url":"https://api.github.com/users/matt-gardner/followers","following_url":"https://api.github.com/users/matt-gardner/following{/other_user}","gists_url":"https://api.github.com/users/matt-gardner/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-gardner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-gardner/subscriptions","organizations_url":"https://api.github.com/users/matt-gardner/orgs","repos_url":"https://api.github.com/users/matt-gardner/repos","events_url":"https://api.github.com/users/matt-gardner/events{/privacy}","received_events_url":"https://api.github.com/users/matt-gardner/received_events","type":"User","site_admin":false},"body":"Just noticed that this is out-dated - you don't pass sequence lengths, you pass a mask.","created_at":"2017-11-29T07:00:07Z","updated_at":"2017-11-29T07:46:47Z","html_url":"https://github.com/allenai/allennlp/pull/518#discussion_r153705666","pull_request_url":"https://api.github.com/repos/allenai/allennlp/pulls/518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments/153705666"},"html":{"href":"https://github.com/allenai/allennlp/pull/518#discussion_r153705666"},"pull_request":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/518"}}},"pull_request":{"url":"https://api.github.com/repos/allenai/allennlp/pulls/518","id":153770527,"html_url":"https://github.com/allenai/allennlp/pull/518","diff_url":"https://github.com/allenai/allennlp/pull/518.diff","patch_url":"https://github.com/allenai/allennlp/pull/518.patch","issue_url":"https://api.github.com/repos/allenai/allennlp/issues/518","number":518,"state":"open","locked":false,"title":"Encoder abstractions","user":{"login":"DeNeutoy","id":16001974,"avatar_url":"https://avatars1.githubusercontent.com/u/16001974?v=4","gravatar_id":"","url":"https://api.github.com/users/DeNeutoy","html_url":"https://github.com/DeNeutoy","followers_url":"https://api.github.com/users/DeNeutoy/followers","following_url":"https://api.github.com/users/DeNeutoy/following{/other_user}","gists_url":"https://api.github.com/users/DeNeutoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DeNeutoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeNeutoy/subscriptions","organizations_url":"https://api.github.com/users/DeNeutoy/orgs","repos_url":"https://api.github.com/users/DeNeutoy/repos","events_url":"https://api.github.com/users/DeNeutoy/events{/privacy}","received_events_url":"https://api.github.com/users/DeNeutoy/received_events","type":"User","site_admin":false},"body":"- Adds a `Seq2StackEncoder` abstraction\r\n- Pulls out the sorting of the batch, forward pass through the model and statefulness for all encoders into a `_EncoderBase` class. \r\n- Refactors `Seq2SeqEncoders` and `Seq2StackEncoders` to allow them to be stateful.\r\n\r\nDepends on #509 \r\n","created_at":"2017-11-21T00:41:43Z","updated_at":"2017-11-29T07:46:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f32eb2ef40b6eb3bfa801d12d56e384988a7710c","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/allenai/allennlp/pulls/518/commits","review_comments_url":"https://api.github.com/repos/allenai/allennlp/pulls/518/comments","review_comment_url":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/allenai/allennlp/issues/518/comments","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/98a168f24793004f8e37f976d9508b5a4d05bfd3","head":{"label":"DeNeutoy:encoder-abstractions","ref":"encoder-abstractions","sha":"98a168f24793004f8e37f976d9508b5a4d05bfd3","user":{"login":"DeNeutoy","id":16001974,"avatar_url":"https://avatars1.githubusercontent.com/u/16001974?v=4","gravatar_id":"","url":"https://api.github.com/users/DeNeutoy","html_url":"https://github.com/DeNeutoy","followers_url":"https://api.github.com/users/DeNeutoy/followers","following_url":"https://api.github.com/users/DeNeutoy/following{/other_user}","gists_url":"https://api.github.com/users/DeNeutoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DeNeutoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeNeutoy/subscriptions","organizations_url":"https://api.github.com/users/DeNeutoy/orgs","repos_url":"https://api.github.com/users/DeNeutoy/repos","events_url":"https://api.github.com/users/DeNeutoy/events{/privacy}","received_events_url":"https://api.github.com/users/DeNeutoy/received_events","type":"User","site_admin":false},"repo":{"id":95490219,"name":"allennlp","full_name":"DeNeutoy/allennlp","owner":{"login":"DeNeutoy","id":16001974,"avatar_url":"https://avatars1.githubusercontent.com/u/16001974?v=4","gravatar_id":"","url":"https://api.github.com/users/DeNeutoy","html_url":"https://github.com/DeNeutoy","followers_url":"https://api.github.com/users/DeNeutoy/followers","following_url":"https://api.github.com/users/DeNeutoy/following{/other_user}","gists_url":"https://api.github.com/users/DeNeutoy/gists{/gist_id}","starred_url":"https://api.github.com/users/DeNeutoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeNeutoy/subscriptions","organizations_url":"https://api.github.com/users/DeNeutoy/orgs","repos_url":"https://api.github.com/users/DeNeutoy/repos","events_url":"https://api.github.com/users/DeNeutoy/events{/privacy}","received_events_url":"https://api.github.com/users/DeNeutoy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DeNeutoy/allennlp","description":"A natural language processing toolkit using state-of-the-art deep learning models.","fork":true,"url":"https://api.github.com/repos/DeNeutoy/allennlp","forks_url":"https://api.github.com/repos/DeNeutoy/allennlp/forks","keys_url":"https://api.github.com/repos/DeNeutoy/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DeNeutoy/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DeNeutoy/allennlp/teams","hooks_url":"https://api.github.com/repos/DeNeutoy/allennlp/hooks","issue_events_url":"https://api.github.com/repos/DeNeutoy/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/DeNeutoy/allennlp/events","assignees_url":"https://api.github.com/repos/DeNeutoy/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/DeNeutoy/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/DeNeutoy/allennlp/tags","blobs_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DeNeutoy/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/DeNeutoy/allennlp/languages","stargazers_url":"https://api.github.com/repos/DeNeutoy/allennlp/stargazers","contributors_url":"https://api.github.com/repos/DeNeutoy/allennlp/contributors","subscribers_url":"https://api.github.com/repos/DeNeutoy/allennlp/subscribers","subscription_url":"https://api.github.com/repos/DeNeutoy/allennlp/subscription","commits_url":"https://api.github.com/repos/DeNeutoy/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/DeNeutoy/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/DeNeutoy/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/DeNeutoy/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/DeNeutoy/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/DeNeutoy/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DeNeutoy/allennlp/merges","archive_url":"https://api.github.com/repos/DeNeutoy/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DeNeutoy/allennlp/downloads","issues_url":"https://api.github.com/repos/DeNeutoy/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/DeNeutoy/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/DeNeutoy/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/DeNeutoy/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DeNeutoy/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/DeNeutoy/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/DeNeutoy/allennlp/deployments","created_at":"2017-06-26T21:16:53Z","updated_at":"2017-06-26T21:16:54Z","pushed_at":"2017-11-28T00:21:25Z","git_url":"git://github.com/DeNeutoy/allennlp.git","ssh_url":"git@github.com:DeNeutoy/allennlp.git","clone_url":"https://github.com/DeNeutoy/allennlp.git","svn_url":"https://github.com/DeNeutoy/allennlp","homepage":null,"size":6275,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"allenai:master","ref":"master","sha":"e82f225d1ff157cd896092a9cf8ec414e9277282","user":{"login":"allenai","id":5667695,"avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"repo":{"id":91356408,"name":"allennlp","full_name":"allenai/allennlp","owner":{"login":"allenai","id":5667695,"avatar_url":"https://avatars3.githubusercontent.com/u/5667695?v=4","gravatar_id":"","url":"https://api.github.com/users/allenai","html_url":"https://github.com/allenai","followers_url":"https://api.github.com/users/allenai/followers","following_url":"https://api.github.com/users/allenai/following{/other_user}","gists_url":"https://api.github.com/users/allenai/gists{/gist_id}","starred_url":"https://api.github.com/users/allenai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allenai/subscriptions","organizations_url":"https://api.github.com/users/allenai/orgs","repos_url":"https://api.github.com/users/allenai/repos","events_url":"https://api.github.com/users/allenai/events{/privacy}","received_events_url":"https://api.github.com/users/allenai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/allenai/allennlp","description":"An open-source NLP research library, built on PyTorch.","fork":false,"url":"https://api.github.com/repos/allenai/allennlp","forks_url":"https://api.github.com/repos/allenai/allennlp/forks","keys_url":"https://api.github.com/repos/allenai/allennlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/allenai/allennlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/allenai/allennlp/teams","hooks_url":"https://api.github.com/repos/allenai/allennlp/hooks","issue_events_url":"https://api.github.com/repos/allenai/allennlp/issues/events{/number}","events_url":"https://api.github.com/repos/allenai/allennlp/events","assignees_url":"https://api.github.com/repos/allenai/allennlp/assignees{/user}","branches_url":"https://api.github.com/repos/allenai/allennlp/branches{/branch}","tags_url":"https://api.github.com/repos/allenai/allennlp/tags","blobs_url":"https://api.github.com/repos/allenai/allennlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/allenai/allennlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/allenai/allennlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/allenai/allennlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/allenai/allennlp/statuses/{sha}","languages_url":"https://api.github.com/repos/allenai/allennlp/languages","stargazers_url":"https://api.github.com/repos/allenai/allennlp/stargazers","contributors_url":"https://api.github.com/repos/allenai/allennlp/contributors","subscribers_url":"https://api.github.com/repos/allenai/allennlp/subscribers","subscription_url":"https://api.github.com/repos/allenai/allennlp/subscription","commits_url":"https://api.github.com/repos/allenai/allennlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/allenai/allennlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/allenai/allennlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/allenai/allennlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/allenai/allennlp/contents/{+path}","compare_url":"https://api.github.com/repos/allenai/allennlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/allenai/allennlp/merges","archive_url":"https://api.github.com/repos/allenai/allennlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/allenai/allennlp/downloads","issues_url":"https://api.github.com/repos/allenai/allennlp/issues{/number}","pulls_url":"https://api.github.com/repos/allenai/allennlp/pulls{/number}","milestones_url":"https://api.github.com/repos/allenai/allennlp/milestones{/number}","notifications_url":"https://api.github.com/repos/allenai/allennlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/allenai/allennlp/labels{/name}","releases_url":"https://api.github.com/repos/allenai/allennlp/releases{/id}","deployments_url":"https://api.github.com/repos/allenai/allennlp/deployments","created_at":"2017-05-15T15:52:41Z","updated_at":"2017-11-28T21:02:09Z","pushed_at":"2017-11-29T05:37:31Z","git_url":"git://github.com/allenai/allennlp.git","ssh_url":"git@github.com:allenai/allennlp.git","clone_url":"https://github.com/allenai/allennlp.git","svn_url":"https://github.com/allenai/allennlp","homepage":"http://www.allennlp.org/","size":5958,"stargazers_count":1091,"watchers_count":1091,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":54,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":125,"open_issues":54,"watchers":1091,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/518"},"html":{"href":"https://github.com/allenai/allennlp/pull/518"},"issue":{"href":"https://api.github.com/repos/allenai/allennlp/issues/518"},"comments":{"href":"https://api.github.com/repos/allenai/allennlp/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/allenai/allennlp/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/allenai/allennlp/statuses/98a168f24793004f8e37f976d9508b5a4d05bfd3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matt-gardner"}}