{"action":"created","issue":{"url":"https://api.github.com/repos/servo/servo/issues/18313","repository_url":"https://api.github.com/repos/servo/servo","labels_url":"https://api.github.com/repos/servo/servo/issues/18313/labels{/name}","comments_url":"https://api.github.com/repos/servo/servo/issues/18313/comments","events_url":"https://api.github.com/repos/servo/servo/issues/18313/events","html_url":"https://github.com/servo/servo/pull/18313","id":253986018,"number":18313,"title":"WIP(Parse srcset) - Need to add more test cases","user":{"login":"iamneha","id":13752837,"avatar_url":"https://avatars0.githubusercontent.com/u/13752837?v=4","gravatar_id":"","url":"https://api.github.com/users/iamneha","html_url":"https://github.com/iamneha","followers_url":"https://api.github.com/users/iamneha/followers","following_url":"https://api.github.com/users/iamneha/following{/other_user}","gists_url":"https://api.github.com/users/iamneha/gists{/gist_id}","starred_url":"https://api.github.com/users/iamneha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamneha/subscriptions","organizations_url":"https://api.github.com/users/iamneha/orgs","repos_url":"https://api.github.com/users/iamneha/repos","events_url":"https://api.github.com/users/iamneha/events{/privacy}","received_events_url":"https://api.github.com/users/iamneha/received_events","type":"User","site_admin":false},"labels":[{"id":152310043,"url":"https://api.github.com/repos/servo/servo/labels/S-awaiting-review","name":"S-awaiting-review","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":{"login":"jdm","id":27658,"avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdm","id":27658,"avatar_url":"https://avatars1.githubusercontent.com/u/27658?v=4","gravatar_id":"","url":"https://api.github.com/users/jdm","html_url":"https://github.com/jdm","followers_url":"https://api.github.com/users/jdm/followers","following_url":"https://api.github.com/users/jdm/following{/other_user}","gists_url":"https://api.github.com/users/jdm/gists{/gist_id}","starred_url":"https://api.github.com/users/jdm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdm/subscriptions","organizations_url":"https://api.github.com/users/jdm/orgs","repos_url":"https://api.github.com/users/jdm/repos","events_url":"https://api.github.com/users/jdm/events{/privacy}","received_events_url":"https://api.github.com/users/jdm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-08-30T12:44:59Z","updated_at":"2017-09-04T13:33:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/servo/servo/pulls/18313","html_url":"https://github.com/servo/servo/pull/18313","diff_url":"https://github.com/servo/servo/pull/18313.diff","patch_url":"https://github.com/servo/servo/pull/18313.patch"},"body":"<!-- Please describe your changes on the following line: -->\r\n\r\n\r\n---\r\n<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->\r\n- [ ] `./mach build -d` does not report any errors\r\n- [ ] `./mach test-tidy` does not report any errors\r\n- [ ] These changes fix #__ (github issue number if applicable).\r\n\r\n<!-- Either: -->\r\n- [ ] There are tests for these changes OR\r\n- [ ] These changes do not require tests because _____\r\n\r\n<!-- Also, please make sure that \"Allow edits from maintainers\" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->\r\n\r\n<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/servo/servo/18313)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/servo/servo/issues/comments/326964619","html_url":"https://github.com/servo/servo/pull/18313#issuecomment-326964619","issue_url":"https://api.github.com/repos/servo/servo/issues/18313","id":326964619,"user":{"login":"wafflespeanut","id":6691262,"avatar_url":"https://avatars2.githubusercontent.com/u/6691262?v=4","gravatar_id":"","url":"https://api.github.com/users/wafflespeanut","html_url":"https://github.com/wafflespeanut","followers_url":"https://api.github.com/users/wafflespeanut/followers","following_url":"https://api.github.com/users/wafflespeanut/following{/other_user}","gists_url":"https://api.github.com/users/wafflespeanut/gists{/gist_id}","starred_url":"https://api.github.com/users/wafflespeanut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wafflespeanut/subscriptions","organizations_url":"https://api.github.com/users/wafflespeanut/orgs","repos_url":"https://api.github.com/users/wafflespeanut/repos","events_url":"https://api.github.com/users/wafflespeanut/events{/privacy}","received_events_url":"https://api.github.com/users/wafflespeanut/received_events","type":"User","site_admin":false},"created_at":"2017-09-04T13:33:46Z","updated_at":"2017-09-04T13:33:46Z","author_association":"MEMBER","body":"Step 13 [in the spec](https://html.spec.whatwg.org/multipage/images.html#parsing-a-srcset-attribute) looks funny.\r\n\r\n> If the descriptor consists of a valid non-negative integer followed by a U+0068 LATIN SMALL LETTER H character\r\n\r\n>    This is a parse error.\r\n\r\nIf it's a parse error, then there's no reason to parse it. The value for *future-compat-h* is not being used after parsing (probably because it's planned for the future?), but that shouldn't mean that the entire descriptor should be rejected with a parse error. We should probably skip the value and still use the descriptor?\r\n\r\n/cc @jdm"}}
{"actor":{"display_login":"wafflespeanut"}}