{"action":"created","issue":{"url":"https://api.github.com/repos/apple/swift/issues/6530","repository_url":"https://api.github.com/repos/apple/swift","labels_url":"https://api.github.com/repos/apple/swift/issues/6530/labels{/name}","comments_url":"https://api.github.com/repos/apple/swift/issues/6530/comments","events_url":"https://api.github.com/repos/apple/swift/issues/6530/events","html_url":"https://github.com/apple/swift/pull/6530","id":198404160,"number":6530,"title":"[SR-2402][ClangImporter] Import nullary function macros","user":{"login":"modocache","id":552921,"avatar_url":"https://avatars.githubusercontent.com/u/552921?v=3","gravatar_id":"","url":"https://api.github.com/users/modocache","html_url":"https://github.com/modocache","followers_url":"https://api.github.com/users/modocache/followers","following_url":"https://api.github.com/users/modocache/following{/other_user}","gists_url":"https://api.github.com/users/modocache/gists{/gist_id}","starred_url":"https://api.github.com/users/modocache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modocache/subscriptions","organizations_url":"https://api.github.com/users/modocache/orgs","repos_url":"https://api.github.com/users/modocache/repos","events_url":"https://api.github.com/users/modocache/events{/privacy}","received_events_url":"https://api.github.com/users/modocache/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-01-03T03:15:52Z","updated_at":"2017-01-04T22:28:26Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/6530","html_url":"https://github.com/apple/swift/pull/6530","diff_url":"https://github.com/apple/swift/pull/6530.diff","patch_url":"https://github.com/apple/swift/pull/6530.patch"},"body":"Resolves [SR-2402](https://bugs.swift.org/browse/SR-2402).\r\n\r\nImport function-like macros that take no arguments, assuming their bodies are something ClangImporter would otherwise be able to import.\r\n\r\n* Modify `shouldIgnoreMacro` such that it only ignores function-like macros if they take more than zero arguments.\r\n* ClangImporter's macro importing normally creates `VarDecl`. Modify that to create FuncDecl if the original macro is function-like.\r\n\r\n---\r\n\r\nThe implementation might be gross, I'm not sure. Another problem: importing macros from another module doesn't really work. Does anyone know what I'm missing here?"},"comment":{"url":"https://api.github.com/repos/apple/swift/issues/comments/270505649","html_url":"https://github.com/apple/swift/pull/6530#issuecomment-270505649","issue_url":"https://api.github.com/repos/apple/swift/issues/6530","id":270505649,"user":{"login":"slavapestov","id":66486,"avatar_url":"https://avatars.githubusercontent.com/u/66486?v=3","gravatar_id":"","url":"https://api.github.com/users/slavapestov","html_url":"https://github.com/slavapestov","followers_url":"https://api.github.com/users/slavapestov/followers","following_url":"https://api.github.com/users/slavapestov/following{/other_user}","gists_url":"https://api.github.com/users/slavapestov/gists{/gist_id}","starred_url":"https://api.github.com/users/slavapestov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slavapestov/subscriptions","organizations_url":"https://api.github.com/users/slavapestov/orgs","repos_url":"https://api.github.com/users/slavapestov/repos","events_url":"https://api.github.com/users/slavapestov/events{/privacy}","received_events_url":"https://api.github.com/users/slavapestov/received_events","type":"User","site_admin":false},"created_at":"2017-01-04T22:28:26Z","updated_at":"2017-01-04T22:28:26Z","body":"I wonder if we need a general solution to deal with potentially source-breaking clangimporter changes like these."}}
{"actor":{"display_login":"slavapestov"}}