{"action":"opened","number":1,"pull_request":{"url":"https://api.github.com/repos/Thomson42/adventure-game/pulls/1","id":136594561,"html_url":"https://github.com/Thomson42/adventure-game/pull/1","diff_url":"https://github.com/Thomson42/adventure-game/pull/1.diff","patch_url":"https://github.com/Thomson42/adventure-game/pull/1.patch","issue_url":"https://api.github.com/repos/Thomson42/adventure-game/issues/1","number":1,"state":"open","locked":false,"title":"Tested alternative implementation of random item placement","user":{"login":"sevfitz","id":25647466,"avatar_url":"https://avatars1.githubusercontent.com/u/25647466?v=4","gravatar_id":"","url":"https://api.github.com/users/sevfitz","html_url":"https://github.com/sevfitz","followers_url":"https://api.github.com/users/sevfitz/followers","following_url":"https://api.github.com/users/sevfitz/following{/other_user}","gists_url":"https://api.github.com/users/sevfitz/gists{/gist_id}","starred_url":"https://api.github.com/users/sevfitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sevfitz/subscriptions","organizations_url":"https://api.github.com/users/sevfitz/orgs","repos_url":"https://api.github.com/users/sevfitz/repos","events_url":"https://api.github.com/users/sevfitz/events{/privacy}","received_events_url":"https://api.github.com/users/sevfitz/received_events","type":"User","site_admin":false},"body":"This is my implementation of that alternative method of randomly placing items in rooms. Don't feel you need to merge this - we can discuss it on Monday when we have the chance. I did it without including a max number of items per room (though I did note that after ten or so checks, I really only saw up to three items landing in any single room). The items are just fill-ins, too. Here is the code:\r\n\r\n```\r\nconst items = ['cell phone', 'hall pass', 'math homework', 'banana peel', 'toilet paper statue', 'incriminating photograph', 'greasy pizza box'];\r\n\r\nitems.forEach(item => {\r\n  let randomIndex = Math.floor((Math.random() * rooms.length));\r\n  rooms[randomIndex].items.push(item);\r\n});\r\n```","created_at":"2017-08-19T05:40:54Z","updated_at":"2017-08-19T05:40:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Thomson42/adventure-game/pulls/1/commits","review_comments_url":"https://api.github.com/repos/Thomson42/adventure-game/pulls/1/comments","review_comment_url":"https://api.github.com/repos/Thomson42/adventure-game/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Thomson42/adventure-game/issues/1/comments","statuses_url":"https://api.github.com/repos/Thomson42/adventure-game/statuses/ac6d1a9616c4754361edf42113fc464f10dcbc4b","head":{"label":"Thomson42:steph","ref":"steph","sha":"ac6d1a9616c4754361edf42113fc464f10dcbc4b","user":{"login":"Thomson42","id":16906336,"avatar_url":"https://avatars2.githubusercontent.com/u/16906336?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomson42","html_url":"https://github.com/Thomson42","followers_url":"https://api.github.com/users/Thomson42/followers","following_url":"https://api.github.com/users/Thomson42/following{/other_user}","gists_url":"https://api.github.com/users/Thomson42/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomson42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomson42/subscriptions","organizations_url":"https://api.github.com/users/Thomson42/orgs","repos_url":"https://api.github.com/users/Thomson42/repos","events_url":"https://api.github.com/users/Thomson42/events{/privacy}","received_events_url":"https://api.github.com/users/Thomson42/received_events","type":"User","site_admin":false},"repo":{"id":100730195,"name":"adventure-game","full_name":"Thomson42/adventure-game","owner":{"login":"Thomson42","id":16906336,"avatar_url":"https://avatars2.githubusercontent.com/u/16906336?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomson42","html_url":"https://github.com/Thomson42","followers_url":"https://api.github.com/users/Thomson42/followers","following_url":"https://api.github.com/users/Thomson42/following{/other_user}","gists_url":"https://api.github.com/users/Thomson42/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomson42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomson42/subscriptions","organizations_url":"https://api.github.com/users/Thomson42/orgs","repos_url":"https://api.github.com/users/Thomson42/repos","events_url":"https://api.github.com/users/Thomson42/events{/privacy}","received_events_url":"https://api.github.com/users/Thomson42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Thomson42/adventure-game","description":null,"fork":true,"url":"https://api.github.com/repos/Thomson42/adventure-game","forks_url":"https://api.github.com/repos/Thomson42/adventure-game/forks","keys_url":"https://api.github.com/repos/Thomson42/adventure-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thomson42/adventure-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thomson42/adventure-game/teams","hooks_url":"https://api.github.com/repos/Thomson42/adventure-game/hooks","issue_events_url":"https://api.github.com/repos/Thomson42/adventure-game/issues/events{/number}","events_url":"https://api.github.com/repos/Thomson42/adventure-game/events","assignees_url":"https://api.github.com/repos/Thomson42/adventure-game/assignees{/user}","branches_url":"https://api.github.com/repos/Thomson42/adventure-game/branches{/branch}","tags_url":"https://api.github.com/repos/Thomson42/adventure-game/tags","blobs_url":"https://api.github.com/repos/Thomson42/adventure-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thomson42/adventure-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thomson42/adventure-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thomson42/adventure-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thomson42/adventure-game/statuses/{sha}","languages_url":"https://api.github.com/repos/Thomson42/adventure-game/languages","stargazers_url":"https://api.github.com/repos/Thomson42/adventure-game/stargazers","contributors_url":"https://api.github.com/repos/Thomson42/adventure-game/contributors","subscribers_url":"https://api.github.com/repos/Thomson42/adventure-game/subscribers","subscription_url":"https://api.github.com/repos/Thomson42/adventure-game/subscription","commits_url":"https://api.github.com/repos/Thomson42/adventure-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thomson42/adventure-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thomson42/adventure-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thomson42/adventure-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thomson42/adventure-game/contents/{+path}","compare_url":"https://api.github.com/repos/Thomson42/adventure-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thomson42/adventure-game/merges","archive_url":"https://api.github.com/repos/Thomson42/adventure-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thomson42/adventure-game/downloads","issues_url":"https://api.github.com/repos/Thomson42/adventure-game/issues{/number}","pulls_url":"https://api.github.com/repos/Thomson42/adventure-game/pulls{/number}","milestones_url":"https://api.github.com/repos/Thomson42/adventure-game/milestones{/number}","notifications_url":"https://api.github.com/repos/Thomson42/adventure-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thomson42/adventure-game/labels{/name}","releases_url":"https://api.github.com/repos/Thomson42/adventure-game/releases{/id}","deployments_url":"https://api.github.com/repos/Thomson42/adventure-game/deployments","created_at":"2017-08-18T16:19:51Z","updated_at":"2017-08-18T18:03:40Z","pushed_at":"2017-08-19T05:30:23Z","git_url":"git://github.com/Thomson42/adventure-game.git","ssh_url":"git@github.com:Thomson42/adventure-game.git","clone_url":"https://github.com/Thomson42/adventure-game.git","svn_url":"https://github.com/Thomson42/adventure-game","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Thomson42:master","ref":"master","sha":"2e75cbaca07602c800f82b8c65a20968358cf6f9","user":{"login":"Thomson42","id":16906336,"avatar_url":"https://avatars2.githubusercontent.com/u/16906336?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomson42","html_url":"https://github.com/Thomson42","followers_url":"https://api.github.com/users/Thomson42/followers","following_url":"https://api.github.com/users/Thomson42/following{/other_user}","gists_url":"https://api.github.com/users/Thomson42/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomson42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomson42/subscriptions","organizations_url":"https://api.github.com/users/Thomson42/orgs","repos_url":"https://api.github.com/users/Thomson42/repos","events_url":"https://api.github.com/users/Thomson42/events{/privacy}","received_events_url":"https://api.github.com/users/Thomson42/received_events","type":"User","site_admin":false},"repo":{"id":100730195,"name":"adventure-game","full_name":"Thomson42/adventure-game","owner":{"login":"Thomson42","id":16906336,"avatar_url":"https://avatars2.githubusercontent.com/u/16906336?v=4","gravatar_id":"","url":"https://api.github.com/users/Thomson42","html_url":"https://github.com/Thomson42","followers_url":"https://api.github.com/users/Thomson42/followers","following_url":"https://api.github.com/users/Thomson42/following{/other_user}","gists_url":"https://api.github.com/users/Thomson42/gists{/gist_id}","starred_url":"https://api.github.com/users/Thomson42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Thomson42/subscriptions","organizations_url":"https://api.github.com/users/Thomson42/orgs","repos_url":"https://api.github.com/users/Thomson42/repos","events_url":"https://api.github.com/users/Thomson42/events{/privacy}","received_events_url":"https://api.github.com/users/Thomson42/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Thomson42/adventure-game","description":null,"fork":true,"url":"https://api.github.com/repos/Thomson42/adventure-game","forks_url":"https://api.github.com/repos/Thomson42/adventure-game/forks","keys_url":"https://api.github.com/repos/Thomson42/adventure-game/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Thomson42/adventure-game/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Thomson42/adventure-game/teams","hooks_url":"https://api.github.com/repos/Thomson42/adventure-game/hooks","issue_events_url":"https://api.github.com/repos/Thomson42/adventure-game/issues/events{/number}","events_url":"https://api.github.com/repos/Thomson42/adventure-game/events","assignees_url":"https://api.github.com/repos/Thomson42/adventure-game/assignees{/user}","branches_url":"https://api.github.com/repos/Thomson42/adventure-game/branches{/branch}","tags_url":"https://api.github.com/repos/Thomson42/adventure-game/tags","blobs_url":"https://api.github.com/repos/Thomson42/adventure-game/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Thomson42/adventure-game/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Thomson42/adventure-game/git/refs{/sha}","trees_url":"https://api.github.com/repos/Thomson42/adventure-game/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Thomson42/adventure-game/statuses/{sha}","languages_url":"https://api.github.com/repos/Thomson42/adventure-game/languages","stargazers_url":"https://api.github.com/repos/Thomson42/adventure-game/stargazers","contributors_url":"https://api.github.com/repos/Thomson42/adventure-game/contributors","subscribers_url":"https://api.github.com/repos/Thomson42/adventure-game/subscribers","subscription_url":"https://api.github.com/repos/Thomson42/adventure-game/subscription","commits_url":"https://api.github.com/repos/Thomson42/adventure-game/commits{/sha}","git_commits_url":"https://api.github.com/repos/Thomson42/adventure-game/git/commits{/sha}","comments_url":"https://api.github.com/repos/Thomson42/adventure-game/comments{/number}","issue_comment_url":"https://api.github.com/repos/Thomson42/adventure-game/issues/comments{/number}","contents_url":"https://api.github.com/repos/Thomson42/adventure-game/contents/{+path}","compare_url":"https://api.github.com/repos/Thomson42/adventure-game/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Thomson42/adventure-game/merges","archive_url":"https://api.github.com/repos/Thomson42/adventure-game/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Thomson42/adventure-game/downloads","issues_url":"https://api.github.com/repos/Thomson42/adventure-game/issues{/number}","pulls_url":"https://api.github.com/repos/Thomson42/adventure-game/pulls{/number}","milestones_url":"https://api.github.com/repos/Thomson42/adventure-game/milestones{/number}","notifications_url":"https://api.github.com/repos/Thomson42/adventure-game/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Thomson42/adventure-game/labels{/name}","releases_url":"https://api.github.com/repos/Thomson42/adventure-game/releases{/id}","deployments_url":"https://api.github.com/repos/Thomson42/adventure-game/deployments","created_at":"2017-08-18T16:19:51Z","updated_at":"2017-08-18T18:03:40Z","pushed_at":"2017-08-19T05:30:23Z","git_url":"git://github.com/Thomson42/adventure-game.git","ssh_url":"git@github.com:Thomson42/adventure-game.git","clone_url":"https://github.com/Thomson42/adventure-game.git","svn_url":"https://github.com/Thomson42/adventure-game","homepage":null,"size":137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Thomson42/adventure-game/pulls/1"},"html":{"href":"https://github.com/Thomson42/adventure-game/pull/1"},"issue":{"href":"https://api.github.com/repos/Thomson42/adventure-game/issues/1"},"comments":{"href":"https://api.github.com/repos/Thomson42/adventure-game/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/Thomson42/adventure-game/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/Thomson42/adventure-game/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Thomson42/adventure-game/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/Thomson42/adventure-game/statuses/ac6d1a9616c4754361edf42113fc464f10dcbc4b"}},"merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":834,"deletions":29,"changed_files":2}}
{"actor":{"display_login":"sevfitz"}}