{"action":"created","comment":{"url":"https://api.github.com/repos/mlr-org/mlr/pulls/comments/104881044","pull_request_review_id":25734669,"id":104881044,"diff_hunk":"@@ -0,0 +1,43 @@\n+#' @title Functional data regression task.\n+#'\n+#' @description\n+#' Create a functional data regression task. This means that some features\n+#' in the task will be so-called functional covariates / functional features,\n+#' measured on a grid or time scale.\n+#'\n+#' @inheritParams Task\n+#' @template arg_fdatask_pars\n+#' @return See [\\code{\\link{FDARegrTask}}].\n+#' @export\n+#' @example\n+#'   dat = data.frame(matrix(rnorm(20), nrow = 2))\n+#'   dat$target = c(1,2)\n+#'   # X1 to X5 is channel 1 and X6 to X10 channel 2\n+#'   # grd specifies the time points the curves were sampled at.\n+#'   grd = list(ch_1 = 1:5, ch_2 = 1:5)\n+#'   # One row per Observation\n+#'   tsk = makeFDARegrTask(data = dat, fd.features = list(ch_1 = 1:5, ch_2 = 6:10),\n+#'     target = \"target\", fd.grid = grd)\n+#' @aliases FDARegrTask\n+makeFDARegrTask = function(id = deparse(substitute(data)), data, target, weights = NULL,\n+  blocking = NULL, fixup.data = \"warn\", check.data = TRUE, fd.features = NULL, fd.grids = NULL) {\n+  task = makeRegrTask(id, data, target, weights, blocking, fixup.data, check.data)\n+  # arg checks for fd.features adn fd.grids are done in next call\n+  makeFDATask(task, \"fdaregr\", fd.features, fd.grids, \"FDARegrTask\", \"FDARegrTaskDesc\")","path":"R/FDARegrTask.R","position":26,"original_position":26,"commit_id":"f4d34b24429f8f00b7522e193d09be3863c49804","original_commit_id":"c36981dbda87bc99b403fbf2ee4fd412eab59d87","user":{"login":"smilesun","id":570694,"avatar_url":"https://avatars3.githubusercontent.com/u/570694?v=3","gravatar_id":"","url":"https://api.github.com/users/smilesun","html_url":"https://github.com/smilesun","followers_url":"https://api.github.com/users/smilesun/followers","following_url":"https://api.github.com/users/smilesun/following{/other_user}","gists_url":"https://api.github.com/users/smilesun/gists{/gist_id}","starred_url":"https://api.github.com/users/smilesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smilesun/subscriptions","organizations_url":"https://api.github.com/users/smilesun/orgs","repos_url":"https://api.github.com/users/smilesun/repos","events_url":"https://api.github.com/users/smilesun/events{/privacy}","received_events_url":"https://api.github.com/users/smilesun/received_events","type":"User","site_admin":false},"body":"?","created_at":"2017-03-08T09:53:23Z","updated_at":"2017-03-08T09:53:23Z","html_url":"https://github.com/mlr-org/mlr/pull/1596#discussion_r104881044","pull_request_url":"https://api.github.com/repos/mlr-org/mlr/pulls/1596","_links":{"self":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/comments/104881044"},"html":{"href":"https://github.com/mlr-org/mlr/pull/1596#discussion_r104881044"},"pull_request":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/1596"}}},"pull_request":{"url":"https://api.github.com/repos/mlr-org/mlr/pulls/1596","id":109317405,"html_url":"https://github.com/mlr-org/mlr/pull/1596","diff_url":"https://github.com/mlr-org/mlr/pull/1596.diff","patch_url":"https://github.com/mlr-org/mlr/pull/1596.patch","issue_url":"https://api.github.com/repos/mlr-org/mlr/issues/1596","number":1596,"state":"open","locked":false,"title":"Fda pull1 task","user":{"login":"smilesun","id":570694,"avatar_url":"https://avatars3.githubusercontent.com/u/570694?v=3","gravatar_id":"","url":"https://api.github.com/users/smilesun","html_url":"https://github.com/smilesun","followers_url":"https://api.github.com/users/smilesun/followers","following_url":"https://api.github.com/users/smilesun/following{/other_user}","gists_url":"https://api.github.com/users/smilesun/gists{/gist_id}","starred_url":"https://api.github.com/users/smilesun/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smilesun/subscriptions","organizations_url":"https://api.github.com/users/smilesun/orgs","repos_url":"https://api.github.com/users/smilesun/repos","events_url":"https://api.github.com/users/smilesun/events{/privacy}","received_events_url":"https://api.github.com/users/smilesun/received_events","type":"User","site_admin":false},"body":"Laura, Florian and I finished this first pull request which only contain the minimal version of FDA since we want the review to go smoothly to merge to master. After this is done, we will add more functionalities to this. ","created_at":"2017-03-06T18:17:29Z","updated_at":"2017-03-08T09:53:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cc7556e680e19ca32a78074dea754d12b794f5ac","assignee":{"login":"berndbischl","id":1225974,"avatar_url":"https://avatars0.githubusercontent.com/u/1225974?v=3","gravatar_id":"","url":"https://api.github.com/users/berndbischl","html_url":"https://github.com/berndbischl","followers_url":"https://api.github.com/users/berndbischl/followers","following_url":"https://api.github.com/users/berndbischl/following{/other_user}","gists_url":"https://api.github.com/users/berndbischl/gists{/gist_id}","starred_url":"https://api.github.com/users/berndbischl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndbischl/subscriptions","organizations_url":"https://api.github.com/users/berndbischl/orgs","repos_url":"https://api.github.com/users/berndbischl/repos","events_url":"https://api.github.com/users/berndbischl/events{/privacy}","received_events_url":"https://api.github.com/users/berndbischl/received_events","type":"User","site_admin":false},"assignees":[{"login":"berndbischl","id":1225974,"avatar_url":"https://avatars0.githubusercontent.com/u/1225974?v=3","gravatar_id":"","url":"https://api.github.com/users/berndbischl","html_url":"https://github.com/berndbischl","followers_url":"https://api.github.com/users/berndbischl/followers","following_url":"https://api.github.com/users/berndbischl/following{/other_user}","gists_url":"https://api.github.com/users/berndbischl/gists{/gist_id}","starred_url":"https://api.github.com/users/berndbischl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berndbischl/subscriptions","organizations_url":"https://api.github.com/users/berndbischl/orgs","repos_url":"https://api.github.com/users/berndbischl/repos","events_url":"https://api.github.com/users/berndbischl/events{/privacy}","received_events_url":"https://api.github.com/users/berndbischl/received_events","type":"User","site_admin":false},{"login":"giuseppec","id":4238748,"avatar_url":"https://avatars2.githubusercontent.com/u/4238748?v=3","gravatar_id":"","url":"https://api.github.com/users/giuseppec","html_url":"https://github.com/giuseppec","followers_url":"https://api.github.com/users/giuseppec/followers","following_url":"https://api.github.com/users/giuseppec/following{/other_user}","gists_url":"https://api.github.com/users/giuseppec/gists{/gist_id}","starred_url":"https://api.github.com/users/giuseppec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giuseppec/subscriptions","organizations_url":"https://api.github.com/users/giuseppec/orgs","repos_url":"https://api.github.com/users/giuseppec/repos","events_url":"https://api.github.com/users/giuseppec/events{/privacy}","received_events_url":"https://api.github.com/users/giuseppec/received_events","type":"User","site_admin":false},{"login":"pfistfl","id":7313671,"avatar_url":"https://avatars2.githubusercontent.com/u/7313671?v=3","gravatar_id":"","url":"https://api.github.com/users/pfistfl","html_url":"https://github.com/pfistfl","followers_url":"https://api.github.com/users/pfistfl/followers","following_url":"https://api.github.com/users/pfistfl/following{/other_user}","gists_url":"https://api.github.com/users/pfistfl/gists{/gist_id}","starred_url":"https://api.github.com/users/pfistfl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfistfl/subscriptions","organizations_url":"https://api.github.com/users/pfistfl/orgs","repos_url":"https://api.github.com/users/pfistfl/repos","events_url":"https://api.github.com/users/pfistfl/events{/privacy}","received_events_url":"https://api.github.com/users/pfistfl/received_events","type":"User","site_admin":false},{"login":"lbeggel","id":17455074,"avatar_url":"https://avatars2.githubusercontent.com/u/17455074?v=3","gravatar_id":"","url":"https://api.github.com/users/lbeggel","html_url":"https://github.com/lbeggel","followers_url":"https://api.github.com/users/lbeggel/followers","following_url":"https://api.github.com/users/lbeggel/following{/other_user}","gists_url":"https://api.github.com/users/lbeggel/gists{/gist_id}","starred_url":"https://api.github.com/users/lbeggel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbeggel/subscriptions","organizations_url":"https://api.github.com/users/lbeggel/orgs","repos_url":"https://api.github.com/users/lbeggel/repos","events_url":"https://api.github.com/users/lbeggel/events{/privacy}","received_events_url":"https://api.github.com/users/lbeggel/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mlr-org/mlr/pulls/1596/commits","review_comments_url":"https://api.github.com/repos/mlr-org/mlr/pulls/1596/comments","review_comment_url":"https://api.github.com/repos/mlr-org/mlr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlr-org/mlr/issues/1596/comments","statuses_url":"https://api.github.com/repos/mlr-org/mlr/statuses/f4d34b24429f8f00b7522e193d09be3863c49804","head":{"label":"mlr-org:fda_pull1_task","ref":"fda_pull1_task","sha":"f4d34b24429f8f00b7522e193d09be3863c49804","user":{"login":"mlr-org","id":12941794,"avatar_url":"https://avatars3.githubusercontent.com/u/12941794?v=3","gravatar_id":"","url":"https://api.github.com/users/mlr-org","html_url":"https://github.com/mlr-org","followers_url":"https://api.github.com/users/mlr-org/followers","following_url":"https://api.github.com/users/mlr-org/following{/other_user}","gists_url":"https://api.github.com/users/mlr-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mlr-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlr-org/subscriptions","organizations_url":"https://api.github.com/users/mlr-org/orgs","repos_url":"https://api.github.com/users/mlr-org/repos","events_url":"https://api.github.com/users/mlr-org/events{/privacy}","received_events_url":"https://api.github.com/users/mlr-org/received_events","type":"Organization","site_admin":false},"repo":{"id":12465340,"name":"mlr","full_name":"mlr-org/mlr","owner":{"login":"mlr-org","id":12941794,"avatar_url":"https://avatars3.githubusercontent.com/u/12941794?v=3","gravatar_id":"","url":"https://api.github.com/users/mlr-org","html_url":"https://github.com/mlr-org","followers_url":"https://api.github.com/users/mlr-org/followers","following_url":"https://api.github.com/users/mlr-org/following{/other_user}","gists_url":"https://api.github.com/users/mlr-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mlr-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlr-org/subscriptions","organizations_url":"https://api.github.com/users/mlr-org/orgs","repos_url":"https://api.github.com/users/mlr-org/repos","events_url":"https://api.github.com/users/mlr-org/events{/privacy}","received_events_url":"https://api.github.com/users/mlr-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlr-org/mlr","description":"mlr: Machine Learning in R ","fork":false,"url":"https://api.github.com/repos/mlr-org/mlr","forks_url":"https://api.github.com/repos/mlr-org/mlr/forks","keys_url":"https://api.github.com/repos/mlr-org/mlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlr-org/mlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlr-org/mlr/teams","hooks_url":"https://api.github.com/repos/mlr-org/mlr/hooks","issue_events_url":"https://api.github.com/repos/mlr-org/mlr/issues/events{/number}","events_url":"https://api.github.com/repos/mlr-org/mlr/events","assignees_url":"https://api.github.com/repos/mlr-org/mlr/assignees{/user}","branches_url":"https://api.github.com/repos/mlr-org/mlr/branches{/branch}","tags_url":"https://api.github.com/repos/mlr-org/mlr/tags","blobs_url":"https://api.github.com/repos/mlr-org/mlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlr-org/mlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlr-org/mlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlr-org/mlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlr-org/mlr/statuses/{sha}","languages_url":"https://api.github.com/repos/mlr-org/mlr/languages","stargazers_url":"https://api.github.com/repos/mlr-org/mlr/stargazers","contributors_url":"https://api.github.com/repos/mlr-org/mlr/contributors","subscribers_url":"https://api.github.com/repos/mlr-org/mlr/subscribers","subscription_url":"https://api.github.com/repos/mlr-org/mlr/subscription","commits_url":"https://api.github.com/repos/mlr-org/mlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlr-org/mlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlr-org/mlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlr-org/mlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlr-org/mlr/contents/{+path}","compare_url":"https://api.github.com/repos/mlr-org/mlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlr-org/mlr/merges","archive_url":"https://api.github.com/repos/mlr-org/mlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlr-org/mlr/downloads","issues_url":"https://api.github.com/repos/mlr-org/mlr/issues{/number}","pulls_url":"https://api.github.com/repos/mlr-org/mlr/pulls{/number}","milestones_url":"https://api.github.com/repos/mlr-org/mlr/milestones{/number}","notifications_url":"https://api.github.com/repos/mlr-org/mlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlr-org/mlr/labels{/name}","releases_url":"https://api.github.com/repos/mlr-org/mlr/releases{/id}","deployments_url":"https://api.github.com/repos/mlr-org/mlr/deployments","created_at":"2013-08-29T16:26:13Z","updated_at":"2017-03-07T23:43:34Z","pushed_at":"2017-03-08T09:52:29Z","git_url":"git://github.com/mlr-org/mlr.git","ssh_url":"git@github.com:mlr-org/mlr.git","clone_url":"https://github.com/mlr-org/mlr.git","svn_url":"https://github.com/mlr-org/mlr","homepage":null,"size":90685,"stargazers_count":593,"watchers_count":593,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":178,"mirror_url":null,"open_issues_count":268,"forks":178,"open_issues":268,"watchers":593,"default_branch":"master"}},"base":{"label":"mlr-org:master","ref":"master","sha":"0601e4ef4fca1a2760d374209b5ee6b300c73e96","user":{"login":"mlr-org","id":12941794,"avatar_url":"https://avatars3.githubusercontent.com/u/12941794?v=3","gravatar_id":"","url":"https://api.github.com/users/mlr-org","html_url":"https://github.com/mlr-org","followers_url":"https://api.github.com/users/mlr-org/followers","following_url":"https://api.github.com/users/mlr-org/following{/other_user}","gists_url":"https://api.github.com/users/mlr-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mlr-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlr-org/subscriptions","organizations_url":"https://api.github.com/users/mlr-org/orgs","repos_url":"https://api.github.com/users/mlr-org/repos","events_url":"https://api.github.com/users/mlr-org/events{/privacy}","received_events_url":"https://api.github.com/users/mlr-org/received_events","type":"Organization","site_admin":false},"repo":{"id":12465340,"name":"mlr","full_name":"mlr-org/mlr","owner":{"login":"mlr-org","id":12941794,"avatar_url":"https://avatars3.githubusercontent.com/u/12941794?v=3","gravatar_id":"","url":"https://api.github.com/users/mlr-org","html_url":"https://github.com/mlr-org","followers_url":"https://api.github.com/users/mlr-org/followers","following_url":"https://api.github.com/users/mlr-org/following{/other_user}","gists_url":"https://api.github.com/users/mlr-org/gists{/gist_id}","starred_url":"https://api.github.com/users/mlr-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlr-org/subscriptions","organizations_url":"https://api.github.com/users/mlr-org/orgs","repos_url":"https://api.github.com/users/mlr-org/repos","events_url":"https://api.github.com/users/mlr-org/events{/privacy}","received_events_url":"https://api.github.com/users/mlr-org/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlr-org/mlr","description":"mlr: Machine Learning in R ","fork":false,"url":"https://api.github.com/repos/mlr-org/mlr","forks_url":"https://api.github.com/repos/mlr-org/mlr/forks","keys_url":"https://api.github.com/repos/mlr-org/mlr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlr-org/mlr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlr-org/mlr/teams","hooks_url":"https://api.github.com/repos/mlr-org/mlr/hooks","issue_events_url":"https://api.github.com/repos/mlr-org/mlr/issues/events{/number}","events_url":"https://api.github.com/repos/mlr-org/mlr/events","assignees_url":"https://api.github.com/repos/mlr-org/mlr/assignees{/user}","branches_url":"https://api.github.com/repos/mlr-org/mlr/branches{/branch}","tags_url":"https://api.github.com/repos/mlr-org/mlr/tags","blobs_url":"https://api.github.com/repos/mlr-org/mlr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlr-org/mlr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlr-org/mlr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlr-org/mlr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlr-org/mlr/statuses/{sha}","languages_url":"https://api.github.com/repos/mlr-org/mlr/languages","stargazers_url":"https://api.github.com/repos/mlr-org/mlr/stargazers","contributors_url":"https://api.github.com/repos/mlr-org/mlr/contributors","subscribers_url":"https://api.github.com/repos/mlr-org/mlr/subscribers","subscription_url":"https://api.github.com/repos/mlr-org/mlr/subscription","commits_url":"https://api.github.com/repos/mlr-org/mlr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlr-org/mlr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlr-org/mlr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlr-org/mlr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlr-org/mlr/contents/{+path}","compare_url":"https://api.github.com/repos/mlr-org/mlr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlr-org/mlr/merges","archive_url":"https://api.github.com/repos/mlr-org/mlr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlr-org/mlr/downloads","issues_url":"https://api.github.com/repos/mlr-org/mlr/issues{/number}","pulls_url":"https://api.github.com/repos/mlr-org/mlr/pulls{/number}","milestones_url":"https://api.github.com/repos/mlr-org/mlr/milestones{/number}","notifications_url":"https://api.github.com/repos/mlr-org/mlr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlr-org/mlr/labels{/name}","releases_url":"https://api.github.com/repos/mlr-org/mlr/releases{/id}","deployments_url":"https://api.github.com/repos/mlr-org/mlr/deployments","created_at":"2013-08-29T16:26:13Z","updated_at":"2017-03-07T23:43:34Z","pushed_at":"2017-03-08T09:52:29Z","git_url":"git://github.com/mlr-org/mlr.git","ssh_url":"git@github.com:mlr-org/mlr.git","clone_url":"https://github.com/mlr-org/mlr.git","svn_url":"https://github.com/mlr-org/mlr","homepage":null,"size":90685,"stargazers_count":593,"watchers_count":593,"language":"R","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":178,"mirror_url":null,"open_issues_count":268,"forks":178,"open_issues":268,"watchers":593,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/1596"},"html":{"href":"https://github.com/mlr-org/mlr/pull/1596"},"issue":{"href":"https://api.github.com/repos/mlr-org/mlr/issues/1596"},"comments":{"href":"https://api.github.com/repos/mlr-org/mlr/issues/1596/comments"},"review_comments":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/1596/comments"},"review_comment":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlr-org/mlr/pulls/1596/commits"},"statuses":{"href":"https://api.github.com/repos/mlr-org/mlr/statuses/f4d34b24429f8f00b7522e193d09be3863c49804"}}}}
{"actor":{"display_login":"smilesun"}}