{"action":"created","issue":{"url":"https://api.github.com/repos/choran/airline_seating/issues/17","repository_url":"https://api.github.com/repos/choran/airline_seating","labels_url":"https://api.github.com/repos/choran/airline_seating/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/choran/airline_seating/issues/17/comments","events_url":"https://api.github.com/repos/choran/airline_seating/issues/17/events","html_url":"https://github.com/choran/airline_seating/pull/17","id":206923412,"number":17,"title":"Updating sort_dict and related function calls","user":{"login":"choran","id":15954251,"avatar_url":"https://avatars.githubusercontent.com/u/15954251?v=3","gravatar_id":"","url":"https://api.github.com/users/choran","html_url":"https://github.com/choran","followers_url":"https://api.github.com/users/choran/followers","following_url":"https://api.github.com/users/choran/following{/other_user}","gists_url":"https://api.github.com/users/choran/gists{/gist_id}","starred_url":"https://api.github.com/users/choran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/choran/subscriptions","organizations_url":"https://api.github.com/users/choran/orgs","repos_url":"https://api.github.com/users/choran/repos","events_url":"https://api.github.com/users/choran/events{/privacy}","received_events_url":"https://api.github.com/users/choran/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-02-10T22:31:02Z","updated_at":"2017-02-11T13:50:13Z","closed_at":"2017-02-11T13:33:43Z","pull_request":{"url":"https://api.github.com/repos/choran/airline_seating/pulls/17","html_url":"https://github.com/choran/airline_seating/pull/17","diff_url":"https://github.com/choran/airline_seating/pull/17.diff","patch_url":"https://github.com/choran/airline_seating/pull/17.patch"},"body":"Currently there is an error with check_seat_ref. It appears to be just with the mapping from seat to letter. i.e it is trying to access the dict with a seat num but the keys are letter so getting a key error. \r\nWanted to check with ye first before changing anything in that function. \r\n\r\n{'D': 3, 'A': 1, 'C': 2, 'F': 4}\r\nTraceback (most recent call last):\r\n  File \"seat_assign_16200385_16201212_03783821.py\", line 13, in <module>\r\n    seating.allocate_bookings()\r\n  File \"/Users/cathalhoran/airline_seating/code/lib/seat_assign.py\", line 105, in allocate_bookings\r\n    self.check_booking(partyName,partyNum,True)\r\n  File \"/Users/cathalhoran/airline_seating/code/lib/seat_assign.py\", line 84, in check_booking\r\n    self.allocate_seats(name,partyNum,seat)\r\n  File \"/Users/cathalhoran/airline_seating/code/lib/seat_assign.py\", line 111, in allocate_seats\r\n    seat = self.check_seat_ref(seat[0]+partyNum-i)\r\n  File \"/Users/cathalhoran/airline_seating/code/lib/seat_assign.py\", line 126, in check_seat_ref\r\n    seatLetter = self.let_to_num_mapping[seatMap]\r\nKeyError: 4"},"comment":{"url":"https://api.github.com/repos/choran/airline_seating/issues/comments/279144918","html_url":"https://github.com/choran/airline_seating/pull/17#issuecomment-279144918","issue_url":"https://api.github.com/repos/choran/airline_seating/issues/17","id":279144918,"user":{"login":"oreills9","id":23108106,"avatar_url":"https://avatars.githubusercontent.com/u/23108106?v=3","gravatar_id":"","url":"https://api.github.com/users/oreills9","html_url":"https://github.com/oreills9","followers_url":"https://api.github.com/users/oreills9/followers","following_url":"https://api.github.com/users/oreills9/following{/other_user}","gists_url":"https://api.github.com/users/oreills9/gists{/gist_id}","starred_url":"https://api.github.com/users/oreills9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oreills9/subscriptions","organizations_url":"https://api.github.com/users/oreills9/orgs","repos_url":"https://api.github.com/users/oreills9/repos","events_url":"https://api.github.com/users/oreills9/events{/privacy}","received_events_url":"https://api.github.com/users/oreills9/received_events","type":"User","site_admin":false},"created_at":"2017-02-11T13:50:12Z","updated_at":"2017-02-11T13:50:12Z","body":"Which issue exactly? It this still the mapping code?\n\nOn 11 February 2017 at 12:18, Cathal Horan <notifications@github.com> wrote:\n\n> Below is a picture of the issue. I can select any type other than object\n> in the array and it works, sting, int ... they are all fine. But when I\n> select object I dont see any \"Edit JSON\" button or \"Object Properties\"\n> button. So it looks like an empty object in the array. It works fine for\n> the object above where you can see the two buttons. But not when it is part\n> of an array.\n>\n> [image: array_object_example]\n> <https://cloud.githubusercontent.com/assets/15954251/22853633/c5a2c924-f053-11e6-938f-e8826a124d71.png>\n>\n> —\n> You are receiving this because you commented.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/choran/airline_seating/pull/17#issuecomment-279140349>,\n> or mute the thread\n> <https://github.com/notifications/unsubscribe-auth/AWCaCvPLToPFk34EbW8wg4H3Y7guw3lvks5rbacYgaJpZM4L97Ta>\n> .\n>\n"}}
{"actor":{"display_login":"oreills9"}}