{"action":"created","comment":{"url":"https://api.github.com/repos/jmcardon/tsec/pulls/comments/156155633","pull_request_review_id":82587977,"id":156155633,"diff_hunk":"@@ -0,0 +1,18 @@\n+package tsec.libsodium.authentication.internal\n+\n+import cats.effect.Sync\n+import tsec.libsodium.ScalaSodium\n+import tsec.libsodium.authentication.{SodiumMAC, SodiumMACKey}\n+\n+trait SodiumMacAlgebra[A] {","path":"tsec-libsodium/src/main/scala/tsec/libsodium/authentication/internal/SodiumMacAlgebra.scala","position":7,"original_position":7,"commit_id":"2ab5fa46c17cfb740772dad94e137800de51102d","original_commit_id":"2ab5fa46c17cfb740772dad94e137800de51102d","user":{"login":"jmcardon","id":15273652,"avatar_url":"https://avatars3.githubusercontent.com/u/15273652?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcardon","html_url":"https://github.com/jmcardon","followers_url":"https://api.github.com/users/jmcardon/followers","following_url":"https://api.github.com/users/jmcardon/following{/other_user}","gists_url":"https://api.github.com/users/jmcardon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcardon/subscriptions","organizations_url":"https://api.github.com/users/jmcardon/orgs","repos_url":"https://api.github.com/users/jmcardon/repos","events_url":"https://api.github.com/users/jmcardon/events{/privacy}","received_events_url":"https://api.github.com/users/jmcardon/received_events","type":"User","site_admin":false},"body":"one was meant to be `SodumMacAlgorithm` and another `SodiumMacAlgebra` but I got lazy. great point though.","created_at":"2017-12-11T18:19:52Z","updated_at":"2017-12-11T18:19:52Z","html_url":"https://github.com/jmcardon/tsec/pull/61#discussion_r156155633","pull_request_url":"https://api.github.com/repos/jmcardon/tsec/pulls/61","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jmcardon/tsec/pulls/comments/156155633"},"html":{"href":"https://github.com/jmcardon/tsec/pull/61#discussion_r156155633"},"pull_request":{"href":"https://api.github.com/repos/jmcardon/tsec/pulls/61"}},"in_reply_to_id":156087639},"pull_request":{"url":"https://api.github.com/repos/jmcardon/tsec/pulls/61","id":157453887,"html_url":"https://github.com/jmcardon/tsec/pull/61","diff_url":"https://github.com/jmcardon/tsec/pull/61.diff","patch_url":"https://github.com/jmcardon/tsec/pull/61.patch","issue_url":"https://api.github.com/repos/jmcardon/tsec/issues/61","number":61,"state":"open","locked":false,"title":"(WIP) tsec-libsodium PR","user":{"login":"jmcardon","id":15273652,"avatar_url":"https://avatars3.githubusercontent.com/u/15273652?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcardon","html_url":"https://github.com/jmcardon","followers_url":"https://api.github.com/users/jmcardon/followers","following_url":"https://api.github.com/users/jmcardon/following{/other_user}","gists_url":"https://api.github.com/users/jmcardon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcardon/subscriptions","organizations_url":"https://api.github.com/users/jmcardon/orgs","repos_url":"https://api.github.com/users/jmcardon/repos","events_url":"https://api.github.com/users/jmcardon/events{/privacy}","received_events_url":"https://api.github.com/users/jmcardon/received_events","type":"User","site_admin":false},"body":"This giant PR adds `tsec-libsodium`, a JNI bridge between the JVM and [libsodium](https://download.libsodium.org/doc/).\r\n\r\nAside from cats (for the FP abstractions), this is a completely dependency-free package as far as libraries are concerned.\r\n\r\nA lot of the lines of code come from the files `sodium.i`, `SodiumJNI.java` and `ScalaSodium.scala`.\r\n\r\nAnyone reviewing can ignore these three files in that they contribute only the primitives for the JNI interface. The first two are swig related (SodiumJNI.java is autogenerated), and the trait is literally just a bridge between the JNI code and the actual scala code.\r\n\r\nWe are supporting the majority of the libsodium library in `SodiumJNI`, but key exchange will most likely be provided in a later milestone.We will not support using the raw stream ciphers (under the libsodium docs), nor Ed25519 to Curve25519, nor Diffie-Helman, and possibly no Key Derivation (in the kdf interface. We will eventually support key derivation coming from the password hashing algorithms and blake)","created_at":"2017-12-10T22:38:37Z","updated_at":"2017-12-11T18:19:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jmcardon/tsec/pulls/61/commits","review_comments_url":"https://api.github.com/repos/jmcardon/tsec/pulls/61/comments","review_comment_url":"https://api.github.com/repos/jmcardon/tsec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jmcardon/tsec/issues/61/comments","statuses_url":"https://api.github.com/repos/jmcardon/tsec/statuses/2ab5fa46c17cfb740772dad94e137800de51102d","head":{"label":"jmcardon:tryswig","ref":"tryswig","sha":"2ab5fa46c17cfb740772dad94e137800de51102d","user":{"login":"jmcardon","id":15273652,"avatar_url":"https://avatars3.githubusercontent.com/u/15273652?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcardon","html_url":"https://github.com/jmcardon","followers_url":"https://api.github.com/users/jmcardon/followers","following_url":"https://api.github.com/users/jmcardon/following{/other_user}","gists_url":"https://api.github.com/users/jmcardon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcardon/subscriptions","organizations_url":"https://api.github.com/users/jmcardon/orgs","repos_url":"https://api.github.com/users/jmcardon/repos","events_url":"https://api.github.com/users/jmcardon/events{/privacy}","received_events_url":"https://api.github.com/users/jmcardon/received_events","type":"User","site_admin":false},"repo":{"id":99377204,"name":"tsec","full_name":"jmcardon/tsec","owner":{"login":"jmcardon","id":15273652,"avatar_url":"https://avatars3.githubusercontent.com/u/15273652?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcardon","html_url":"https://github.com/jmcardon","followers_url":"https://api.github.com/users/jmcardon/followers","following_url":"https://api.github.com/users/jmcardon/following{/other_user}","gists_url":"https://api.github.com/users/jmcardon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcardon/subscriptions","organizations_url":"https://api.github.com/users/jmcardon/orgs","repos_url":"https://api.github.com/users/jmcardon/repos","events_url":"https://api.github.com/users/jmcardon/events{/privacy}","received_events_url":"https://api.github.com/users/jmcardon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmcardon/tsec","description":"Type-safe general-cryptography library - https://jmcardon.github.io/tsec/","fork":false,"url":"https://api.github.com/repos/jmcardon/tsec","forks_url":"https://api.github.com/repos/jmcardon/tsec/forks","keys_url":"https://api.github.com/repos/jmcardon/tsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmcardon/tsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmcardon/tsec/teams","hooks_url":"https://api.github.com/repos/jmcardon/tsec/hooks","issue_events_url":"https://api.github.com/repos/jmcardon/tsec/issues/events{/number}","events_url":"https://api.github.com/repos/jmcardon/tsec/events","assignees_url":"https://api.github.com/repos/jmcardon/tsec/assignees{/user}","branches_url":"https://api.github.com/repos/jmcardon/tsec/branches{/branch}","tags_url":"https://api.github.com/repos/jmcardon/tsec/tags","blobs_url":"https://api.github.com/repos/jmcardon/tsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmcardon/tsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmcardon/tsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmcardon/tsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmcardon/tsec/statuses/{sha}","languages_url":"https://api.github.com/repos/jmcardon/tsec/languages","stargazers_url":"https://api.github.com/repos/jmcardon/tsec/stargazers","contributors_url":"https://api.github.com/repos/jmcardon/tsec/contributors","subscribers_url":"https://api.github.com/repos/jmcardon/tsec/subscribers","subscription_url":"https://api.github.com/repos/jmcardon/tsec/subscription","commits_url":"https://api.github.com/repos/jmcardon/tsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmcardon/tsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmcardon/tsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmcardon/tsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmcardon/tsec/contents/{+path}","compare_url":"https://api.github.com/repos/jmcardon/tsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmcardon/tsec/merges","archive_url":"https://api.github.com/repos/jmcardon/tsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmcardon/tsec/downloads","issues_url":"https://api.github.com/repos/jmcardon/tsec/issues{/number}","pulls_url":"https://api.github.com/repos/jmcardon/tsec/pulls{/number}","milestones_url":"https://api.github.com/repos/jmcardon/tsec/milestones{/number}","notifications_url":"https://api.github.com/repos/jmcardon/tsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmcardon/tsec/labels{/name}","releases_url":"https://api.github.com/repos/jmcardon/tsec/releases{/id}","deployments_url":"https://api.github.com/repos/jmcardon/tsec/deployments","created_at":"2017-08-04T20:25:11Z","updated_at":"2017-12-10T06:11:39Z","pushed_at":"2017-12-11T03:55:48Z","git_url":"git://github.com/jmcardon/tsec.git","ssh_url":"git@github.com:jmcardon/tsec.git","clone_url":"https://github.com/jmcardon/tsec.git","svn_url":"https://github.com/jmcardon/tsec","homepage":"","size":1851,"stargazers_count":37,"watchers_count":37,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":8,"watchers":37,"default_branch":"master"}},"base":{"label":"jmcardon:master","ref":"master","sha":"50733c2db0f38c2be1c8735e746efadd1fc67163","user":{"login":"jmcardon","id":15273652,"avatar_url":"https://avatars3.githubusercontent.com/u/15273652?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcardon","html_url":"https://github.com/jmcardon","followers_url":"https://api.github.com/users/jmcardon/followers","following_url":"https://api.github.com/users/jmcardon/following{/other_user}","gists_url":"https://api.github.com/users/jmcardon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcardon/subscriptions","organizations_url":"https://api.github.com/users/jmcardon/orgs","repos_url":"https://api.github.com/users/jmcardon/repos","events_url":"https://api.github.com/users/jmcardon/events{/privacy}","received_events_url":"https://api.github.com/users/jmcardon/received_events","type":"User","site_admin":false},"repo":{"id":99377204,"name":"tsec","full_name":"jmcardon/tsec","owner":{"login":"jmcardon","id":15273652,"avatar_url":"https://avatars3.githubusercontent.com/u/15273652?v=4","gravatar_id":"","url":"https://api.github.com/users/jmcardon","html_url":"https://github.com/jmcardon","followers_url":"https://api.github.com/users/jmcardon/followers","following_url":"https://api.github.com/users/jmcardon/following{/other_user}","gists_url":"https://api.github.com/users/jmcardon/gists{/gist_id}","starred_url":"https://api.github.com/users/jmcardon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmcardon/subscriptions","organizations_url":"https://api.github.com/users/jmcardon/orgs","repos_url":"https://api.github.com/users/jmcardon/repos","events_url":"https://api.github.com/users/jmcardon/events{/privacy}","received_events_url":"https://api.github.com/users/jmcardon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmcardon/tsec","description":"Type-safe general-cryptography library - https://jmcardon.github.io/tsec/","fork":false,"url":"https://api.github.com/repos/jmcardon/tsec","forks_url":"https://api.github.com/repos/jmcardon/tsec/forks","keys_url":"https://api.github.com/repos/jmcardon/tsec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmcardon/tsec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmcardon/tsec/teams","hooks_url":"https://api.github.com/repos/jmcardon/tsec/hooks","issue_events_url":"https://api.github.com/repos/jmcardon/tsec/issues/events{/number}","events_url":"https://api.github.com/repos/jmcardon/tsec/events","assignees_url":"https://api.github.com/repos/jmcardon/tsec/assignees{/user}","branches_url":"https://api.github.com/repos/jmcardon/tsec/branches{/branch}","tags_url":"https://api.github.com/repos/jmcardon/tsec/tags","blobs_url":"https://api.github.com/repos/jmcardon/tsec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmcardon/tsec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmcardon/tsec/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmcardon/tsec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmcardon/tsec/statuses/{sha}","languages_url":"https://api.github.com/repos/jmcardon/tsec/languages","stargazers_url":"https://api.github.com/repos/jmcardon/tsec/stargazers","contributors_url":"https://api.github.com/repos/jmcardon/tsec/contributors","subscribers_url":"https://api.github.com/repos/jmcardon/tsec/subscribers","subscription_url":"https://api.github.com/repos/jmcardon/tsec/subscription","commits_url":"https://api.github.com/repos/jmcardon/tsec/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmcardon/tsec/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmcardon/tsec/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmcardon/tsec/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmcardon/tsec/contents/{+path}","compare_url":"https://api.github.com/repos/jmcardon/tsec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmcardon/tsec/merges","archive_url":"https://api.github.com/repos/jmcardon/tsec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmcardon/tsec/downloads","issues_url":"https://api.github.com/repos/jmcardon/tsec/issues{/number}","pulls_url":"https://api.github.com/repos/jmcardon/tsec/pulls{/number}","milestones_url":"https://api.github.com/repos/jmcardon/tsec/milestones{/number}","notifications_url":"https://api.github.com/repos/jmcardon/tsec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmcardon/tsec/labels{/name}","releases_url":"https://api.github.com/repos/jmcardon/tsec/releases{/id}","deployments_url":"https://api.github.com/repos/jmcardon/tsec/deployments","created_at":"2017-08-04T20:25:11Z","updated_at":"2017-12-10T06:11:39Z","pushed_at":"2017-12-11T03:55:48Z","git_url":"git://github.com/jmcardon/tsec.git","ssh_url":"git@github.com:jmcardon/tsec.git","clone_url":"https://github.com/jmcardon/tsec.git","svn_url":"https://github.com/jmcardon/tsec","homepage":"","size":1851,"stargazers_count":37,"watchers_count":37,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":8,"open_issues":8,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jmcardon/tsec/pulls/61"},"html":{"href":"https://github.com/jmcardon/tsec/pull/61"},"issue":{"href":"https://api.github.com/repos/jmcardon/tsec/issues/61"},"comments":{"href":"https://api.github.com/repos/jmcardon/tsec/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/jmcardon/tsec/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/jmcardon/tsec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jmcardon/tsec/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/jmcardon/tsec/statuses/2ab5fa46c17cfb740772dad94e137800de51102d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jmcardon"}}