{"action":"created","comment":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/128912689","pull_request_review_id":51637712,"id":128912689,"diff_hunk":"@@ -24,44 +24,48 @@ limitations under the License.\n \n namespace common {\n \n-    namespace config {\n-        using namespace rapidjson;\n+  namespace config {\n+    using namespace rapidjson;\n \n-        ConfigLoader::ConfigLoader(const std::string& file_name){\n-            std::ifstream ifs(file_name);\n-            if(ifs.is_open()){\n-                IStreamWrapper isw(ifs);\n-                doc.ParseStream(isw);\n-                if(doc.HasParseError()){\n-                    throw std::runtime_error(\"parse error\");\n-                }\n-            }\n+    ConfigLoader::ConfigLoader(const std::string& file_name) {\n+      std::ifstream ifs(file_name);\n+         \n+      if (ifs.is_open()) {\n+           \n+        IStreamWrapper isw(ifs);\n+        doc.ParseStream(isw);\n+           \n+        if (doc.HasParseError()) {\n+          // ToDo log failed to logger\n+          doc.Parse(\"{}\");\n         }\n+      }\n+    }\n \n-        int ConfigLoader::getIntOrElse(const std::string& key, int def){\n-            if(doc[key.c_str()].IsInt()){\n-                return doc[key.c_str()].GetInt();\n-            }else{\n-                return def;\n-            };\n-        }\n+    int ConfigLoader::getIntOrElse(const std::string& key, int def) {","path":"irohad/common/config.cpp","position":40,"original_position":40,"commit_id":"71e9267b0d02f4f52a1f6d3ee663c845c1d93660","original_commit_id":"71e9267b0d02f4f52a1f6d3ee663c845c1d93660","user":{"login":"takemiyamakoto","id":20982317,"avatar_url":"https://avatars0.githubusercontent.com/u/20982317?v=4","gravatar_id":"","url":"https://api.github.com/users/takemiyamakoto","html_url":"https://github.com/takemiyamakoto","followers_url":"https://api.github.com/users/takemiyamakoto/followers","following_url":"https://api.github.com/users/takemiyamakoto/following{/other_user}","gists_url":"https://api.github.com/users/takemiyamakoto/gists{/gist_id}","starred_url":"https://api.github.com/users/takemiyamakoto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takemiyamakoto/subscriptions","organizations_url":"https://api.github.com/users/takemiyamakoto/orgs","repos_url":"https://api.github.com/users/takemiyamakoto/repos","events_url":"https://api.github.com/users/takemiyamakoto/events{/privacy}","received_events_url":"https://api.github.com/users/takemiyamakoto/received_events","type":"User","site_admin":false},"body":"Yes, that's a better name","created_at":"2017-07-23T07:51:24Z","updated_at":"2017-07-23T07:51:24Z","html_url":"https://github.com/hyperledger/iroha/pull/450#discussion_r128912689","pull_request_url":"https://api.github.com/repos/hyperledger/iroha/pulls/450","_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments/128912689"},"html":{"href":"https://github.com/hyperledger/iroha/pull/450#discussion_r128912689"},"pull_request":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/450"}}},"pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/450","id":130723507,"html_url":"https://github.com/hyperledger/iroha/pull/450","diff_url":"https://github.com/hyperledger/iroha/pull/450.diff","patch_url":"https://github.com/hyperledger/iroha/pull/450.patch","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/450","number":450,"state":"open","locked":false,"title":"Feature/add config to main","user":{"login":"MizukiSonoko","id":6281583,"avatar_url":"https://avatars1.githubusercontent.com/u/6281583?v=4","gravatar_id":"","url":"https://api.github.com/users/MizukiSonoko","html_url":"https://github.com/MizukiSonoko","followers_url":"https://api.github.com/users/MizukiSonoko/followers","following_url":"https://api.github.com/users/MizukiSonoko/following{/other_user}","gists_url":"https://api.github.com/users/MizukiSonoko/gists{/gist_id}","starred_url":"https://api.github.com/users/MizukiSonoko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MizukiSonoko/subscriptions","organizations_url":"https://api.github.com/users/MizukiSonoko/orgs","repos_url":"https://api.github.com/users/MizukiSonoko/repos","events_url":"https://api.github.com/users/MizukiSonoko/events{/privacy}","received_events_url":"https://api.github.com/users/MizukiSonoko/received_events","type":"User","site_admin":false},"body":"\r\n## What is this pull request?\r\nAdd config loader to main\r\n   \r\n## Why do you implement it? Why do we need this pull request?\r\nIn initialize, we use config file\r\n \r\n## Details/Features\r\nList of features / major commits\r\n- Add config loader to main\r\n- Add test for config loader\r\n\r\n","created_at":"2017-07-15T17:37:33Z","updated_at":"2017-07-23T07:51:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0c76536fdf25501b3e3c349109670cc1beb34501","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Warchant","id":1867551,"avatar_url":"https://avatars0.githubusercontent.com/u/1867551?v=4","gravatar_id":"","url":"https://api.github.com/users/Warchant","html_url":"https://github.com/Warchant","followers_url":"https://api.github.com/users/Warchant/followers","following_url":"https://api.github.com/users/Warchant/following{/other_user}","gists_url":"https://api.github.com/users/Warchant/gists{/gist_id}","starred_url":"https://api.github.com/users/Warchant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Warchant/subscriptions","organizations_url":"https://api.github.com/users/Warchant/orgs","repos_url":"https://api.github.com/users/Warchant/repos","events_url":"https://api.github.com/users/Warchant/events{/privacy}","received_events_url":"https://api.github.com/users/Warchant/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/hyperledger/iroha/pulls/450/commits","review_comments_url":"https://api.github.com/repos/hyperledger/iroha/pulls/450/comments","review_comment_url":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/450/comments","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/71e9267b0d02f4f52a1f6d3ee663c845c1d93660","head":{"label":"hyperledger:feature/add-config-to-main","ref":"feature/add-config-to-main","sha":"71e9267b0d02f4f52a1f6d3ee663c845c1d93660","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2017-07-22T17:27:38Z","pushed_at":"2017-07-23T07:37:10Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":34241,"stargazers_count":267,"watchers_count":267,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":30,"forks":99,"open_issues":30,"watchers":267,"default_branch":"master"}},"base":{"label":"hyperledger:develop","ref":"develop","sha":"8af422177a165206fc599a6d6a863a863450b868","user":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"repo":{"id":67340575,"name":"iroha","full_name":"hyperledger/iroha","owner":{"login":"hyperledger","id":7657900,"avatar_url":"https://avatars2.githubusercontent.com/u/7657900?v=4","gravatar_id":"","url":"https://api.github.com/users/hyperledger","html_url":"https://github.com/hyperledger","followers_url":"https://api.github.com/users/hyperledger/followers","following_url":"https://api.github.com/users/hyperledger/following{/other_user}","gists_url":"https://api.github.com/users/hyperledger/gists{/gist_id}","starred_url":"https://api.github.com/users/hyperledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hyperledger/subscriptions","organizations_url":"https://api.github.com/users/hyperledger/orgs","repos_url":"https://api.github.com/users/hyperledger/repos","events_url":"https://api.github.com/users/hyperledger/events{/privacy}","received_events_url":"https://api.github.com/users/hyperledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hyperledger/iroha","description":"Iroha - A simple, decentralized ledger","fork":false,"url":"https://api.github.com/repos/hyperledger/iroha","forks_url":"https://api.github.com/repos/hyperledger/iroha/forks","keys_url":"https://api.github.com/repos/hyperledger/iroha/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hyperledger/iroha/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hyperledger/iroha/teams","hooks_url":"https://api.github.com/repos/hyperledger/iroha/hooks","issue_events_url":"https://api.github.com/repos/hyperledger/iroha/issues/events{/number}","events_url":"https://api.github.com/repos/hyperledger/iroha/events","assignees_url":"https://api.github.com/repos/hyperledger/iroha/assignees{/user}","branches_url":"https://api.github.com/repos/hyperledger/iroha/branches{/branch}","tags_url":"https://api.github.com/repos/hyperledger/iroha/tags","blobs_url":"https://api.github.com/repos/hyperledger/iroha/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hyperledger/iroha/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hyperledger/iroha/git/refs{/sha}","trees_url":"https://api.github.com/repos/hyperledger/iroha/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hyperledger/iroha/statuses/{sha}","languages_url":"https://api.github.com/repos/hyperledger/iroha/languages","stargazers_url":"https://api.github.com/repos/hyperledger/iroha/stargazers","contributors_url":"https://api.github.com/repos/hyperledger/iroha/contributors","subscribers_url":"https://api.github.com/repos/hyperledger/iroha/subscribers","subscription_url":"https://api.github.com/repos/hyperledger/iroha/subscription","commits_url":"https://api.github.com/repos/hyperledger/iroha/commits{/sha}","git_commits_url":"https://api.github.com/repos/hyperledger/iroha/git/commits{/sha}","comments_url":"https://api.github.com/repos/hyperledger/iroha/comments{/number}","issue_comment_url":"https://api.github.com/repos/hyperledger/iroha/issues/comments{/number}","contents_url":"https://api.github.com/repos/hyperledger/iroha/contents/{+path}","compare_url":"https://api.github.com/repos/hyperledger/iroha/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hyperledger/iroha/merges","archive_url":"https://api.github.com/repos/hyperledger/iroha/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hyperledger/iroha/downloads","issues_url":"https://api.github.com/repos/hyperledger/iroha/issues{/number}","pulls_url":"https://api.github.com/repos/hyperledger/iroha/pulls{/number}","milestones_url":"https://api.github.com/repos/hyperledger/iroha/milestones{/number}","notifications_url":"https://api.github.com/repos/hyperledger/iroha/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hyperledger/iroha/labels{/name}","releases_url":"https://api.github.com/repos/hyperledger/iroha/releases{/id}","deployments_url":"https://api.github.com/repos/hyperledger/iroha/deployments","created_at":"2016-09-04T11:17:53Z","updated_at":"2017-07-22T17:27:38Z","pushed_at":"2017-07-23T07:37:10Z","git_url":"git://github.com/hyperledger/iroha.git","ssh_url":"git@github.com:hyperledger/iroha.git","clone_url":"https://github.com/hyperledger/iroha.git","svn_url":"https://github.com/hyperledger/iroha","homepage":"http://iroha.tech","size":34241,"stargazers_count":267,"watchers_count":267,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":99,"mirror_url":null,"open_issues_count":30,"forks":99,"open_issues":30,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/450"},"html":{"href":"https://github.com/hyperledger/iroha/pull/450"},"issue":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/450"},"comments":{"href":"https://api.github.com/repos/hyperledger/iroha/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hyperledger/iroha/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/hyperledger/iroha/statuses/71e9267b0d02f4f52a1f6d3ee663c845c1d93660"}}}}
{"actor":{"display_login":"takemiyamakoto"}}