{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/141615561","pull_request_review_id":65856418,"id":141615561,"diff_hunk":"@@ -41,75 +50,23 @@ if ((\"${CMAKE_CXX_COMPILER_ID}\" MATCHES \"GNU\") OR (\"${CMAKE_CXX_COMPILER_ID}\" MA\n \t\tendif ()\n \tendif ()\n \n-\t# Additional GCC-specific compiler settings.\n+\t# Check GCC compiler version.\n \tif (\"${CMAKE_CXX_COMPILER_ID}\" MATCHES \"GNU\")\n-\n-\t\t# Check that we've got GCC 4.7 or newer.\n-\t\texecute_process(\n-\t\t\tCOMMAND ${CMAKE_CXX_COMPILER} -dumpversion OUTPUT_VARIABLE GCC_VERSION)\n-\t\tif (NOT (GCC_VERSION VERSION_GREATER 4.7 OR GCC_VERSION VERSION_EQUAL 4.7))\n-\t\t\tmessage(FATAL_ERROR \"${PROJECT_NAME} requires g++ 4.7 or greater.\")\n-\t\tendif ()\n-\n-\t\t# Strong stack protection was only added in GCC 4.9.\n-\t\t# Use it if we have the option to do so.\n-\t\t# See https://lwn.net/Articles/584225/\n-\t\tif (GCC_VERSION VERSION_GREATER 4.9 OR GCC_VERSION VERSION_EQUAL 4.9)\n-\t\t\tadd_compile_options(-fstack-protector-strong)\n-\t\t\tadd_compile_options(-fstack-protector)\n+\t\tif(\"${CMAKE_CXX_COMPILER_VERSION}\" VERSION_LESS 4.8)\n+\t\t\tmessage(FATAL_ERROR \"This compiler ${CMAKE_CXX_COMPILER_ID} ${CMAKE_CXX_COMPILER_VERSION} is not supported. GCC 4.8 or newer is required.\")\n \t\tendif()\n \n-\t# Additional Clang-specific compiler settings.\n-\telseif (\"${CMAKE_CXX_COMPILER_ID}\" MATCHES \"Clang\")\n-\n-\t\t# Stop if buggy clang compiler detected.\n-\t\tif(\"${CMAKE_CXX_COMPILER_ID}\" MATCHES AppleClang)\n-\t\t\tif(\"${CMAKE_CXX_COMPILER_VERSION}\" VERSION_LESS 8.4)\n-\t\t\t\tmessage(FATAL_ERROR \"This compiler ${CMAKE_CXX_COMPILER_ID} ${CMAKE_CXX_COMPILER_VERSION} is not able to compile required libff. Install clang 4+ from Homebrew.\")\n-\t\t\tendif()\n-\t\tendif()\n-\n-\n-\t\tadd_compile_options(-fstack-protector)\n-\n-\t\t# Enable strong stack protection only on Mac and only for OS X Yosemite\n-\t\t# or newer (AppleClang 7.0+).  We should be able to re-enable this setting\n-\t\t# on non-Apple Clang as well, if we can work out what expression to use for\n-\t\t# the version detection.\n-\n-\t\t# The fact that the version-reporting for AppleClang loses the original\n-\t\t# Clang versioning is rather annoying.  Ideally we could just have\n-\t\t# a single cross-platform \"if version >= 3.4.1\" check.\n-\t\t#\n-\t\t# There is debug text in the else clause below, to help us work out what\n-\t\t# such an expression should be, if we can get this running on a Trusty box\n-\t\t# with Clang.  Greg Colvin previously replicated the issue there too.\n-\t\t#\n-\t\t# See https://github.com/ethereum/webthree-umbrella/issues/594\n-\n-\t\tif (APPLE)\n-\t\t\tif (CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7.0)\n-\t\t\t\tadd_compile_options(-fstack-protector-strong)\n-\t\t\tendif()\n-\t\telse()\n-\t\t\tmessage(WARNING \"CMAKE_CXX_COMPILER_VERSION = ${CMAKE_CXX_COMPILER_VERSION}\")\n-\t\tendif()\n-\n-\t\t# Some Linux-specific Clang settings.  We don't want these for OS X.\n-\t\tif (\"${CMAKE_SYSTEM_NAME}\" MATCHES \"Linux\")\n-\n-\t\t\t# Tell Boost that we're using Clang's libc++.   Not sure exactly why we need to do.\n-\t\t\tadd_definitions(-DBOOST_ASIO_HAS_CLANG_LIBCXX)\n-\n-\t\t\t# Use fancy colors in the compiler diagnostics\n-\t\t\tadd_compile_options(-fcolor-diagnostics)","path":"cmake/EthCompilerSettings.cmake","position":84,"original_position":84,"commit_id":"0e41f4b690120649278b6bbad71c327a8a984e35","original_commit_id":"0e41f4b690120649278b6bbad71c327a8a984e35","user":{"login":"chfast","id":573380,"avatar_url":"https://avatars1.githubusercontent.com/u/573380?v=4","gravatar_id":"","url":"https://api.github.com/users/chfast","html_url":"https://github.com/chfast","followers_url":"https://api.github.com/users/chfast/followers","following_url":"https://api.github.com/users/chfast/following{/other_user}","gists_url":"https://api.github.com/users/chfast/gists{/gist_id}","starred_url":"https://api.github.com/users/chfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfast/subscriptions","organizations_url":"https://api.github.com/users/chfast/orgs","repos_url":"https://api.github.com/users/chfast/repos","events_url":"https://api.github.com/users/chfast/events{/privacy}","received_events_url":"https://api.github.com/users/chfast/received_events","type":"User","site_admin":false},"body":"None of them are relevant any more.\r\n1. We actually are using libstdc++ not libc++ on Linux.\r\n2. Clang is using colors in terminal by default. That was for some old version.","created_at":"2017-09-28T13:23:59Z","updated_at":"2017-09-28T13:27:06Z","html_url":"https://github.com/ethereum/cpp-ethereum/pull/4551#discussion_r141615561","pull_request_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4551","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments/141615561"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/4551#discussion_r141615561"},"pull_request":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4551"}},"in_reply_to_id":141305641},"pull_request":{"url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4551","id":143120279,"html_url":"https://github.com/ethereum/cpp-ethereum/pull/4551","diff_url":"https://github.com/ethereum/cpp-ethereum/pull/4551.diff","patch_url":"https://github.com/ethereum/cpp-ethereum/pull/4551.patch","issue_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4551","number":4551,"state":"open","locked":false,"title":"CMake: Pull some changes from solidity","user":{"login":"chfast","id":573380,"avatar_url":"https://avatars1.githubusercontent.com/u/573380?v=4","gravatar_id":"","url":"https://api.github.com/users/chfast","html_url":"https://github.com/chfast","followers_url":"https://api.github.com/users/chfast/followers","following_url":"https://api.github.com/users/chfast/following{/other_user}","gists_url":"https://api.github.com/users/chfast/gists{/gist_id}","starred_url":"https://api.github.com/users/chfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chfast/subscriptions","organizations_url":"https://api.github.com/users/chfast/orgs","repos_url":"https://api.github.com/users/chfast/repos","events_url":"https://api.github.com/users/chfast/events{/privacy}","received_events_url":"https://api.github.com/users/chfast/received_events","type":"User","site_admin":false},"body":"In contains https://github.com/ethereum/solidity/pull/2946 changes.","created_at":"2017-09-26T12:26:35Z","updated_at":"2017-09-28T13:27:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e25ca2f800274177424e1704929a5bcbc397d3b","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4551/commits","review_comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4551/comments","review_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4551/comments","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/0e41f4b690120649278b6bbad71c327a8a984e35","head":{"label":"ethereum:cmake","ref":"cmake","sha":"0e41f4b690120649278b6bbad71c327a8a984e35","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Ethereum C++ client","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/deployments","created_at":"2013-12-26T21:26:06Z","updated_at":"2017-09-28T10:27:39Z","pushed_at":"2017-09-28T12:47:38Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"http://cpp-ethereum.org","size":52739,"stargazers_count":1684,"watchers_count":1684,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1151,"mirror_url":null,"open_issues_count":335,"forks":1151,"open_issues":335,"watchers":1684,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"e8f79586d6424464f7779745fbf4c1e10509ca2b","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":15460666,"name":"cpp-ethereum","full_name":"ethereum/cpp-ethereum","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/cpp-ethereum","description":"Ethereum C++ client","fork":false,"url":"https://api.github.com/repos/ethereum/cpp-ethereum","forks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/forks","keys_url":"https://api.github.com/repos/ethereum/cpp-ethereum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/cpp-ethereum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/cpp-ethereum/teams","hooks_url":"https://api.github.com/repos/ethereum/cpp-ethereum/hooks","issue_events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/cpp-ethereum/events","assignees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/cpp-ethereum/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/tags","blobs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/cpp-ethereum/languages","stargazers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/stargazers","contributors_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contributors","subscribers_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscribers","subscription_url":"https://api.github.com/repos/ethereum/cpp-ethereum/subscription","commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/cpp-ethereum/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/cpp-ethereum/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/cpp-ethereum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/cpp-ethereum/merges","archive_url":"https://api.github.com/repos/ethereum/cpp-ethereum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/cpp-ethereum/downloads","issues_url":"https://api.github.com/repos/ethereum/cpp-ethereum/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/cpp-ethereum/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/cpp-ethereum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/cpp-ethereum/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/cpp-ethereum/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/cpp-ethereum/deployments","created_at":"2013-12-26T21:26:06Z","updated_at":"2017-09-28T10:27:39Z","pushed_at":"2017-09-28T12:47:38Z","git_url":"git://github.com/ethereum/cpp-ethereum.git","ssh_url":"git@github.com:ethereum/cpp-ethereum.git","clone_url":"https://github.com/ethereum/cpp-ethereum.git","svn_url":"https://github.com/ethereum/cpp-ethereum","homepage":"http://cpp-ethereum.org","size":52739,"stargazers_count":1684,"watchers_count":1684,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1151,"mirror_url":null,"open_issues_count":335,"forks":1151,"open_issues":335,"watchers":1684,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4551"},"html":{"href":"https://github.com/ethereum/cpp-ethereum/pull/4551"},"issue":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4551"},"comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/issues/4551/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4551/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/pulls/4551/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/cpp-ethereum/statuses/0e41f4b690120649278b6bbad71c327a8a984e35"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"chfast"}}