{"action":"created","comment":{"url":"https://api.github.com/repos/uf-mil/NaviGator/pulls/comments/141758693","pull_request_review_id":66025118,"id":141758693,"diff_hunk":"@@ -0,0 +1,205 @@\n+#!/usr/bin/env python\n+import rospy\n+import unittest\n+from nav_msgs.msg import Odometry\n+from sensor_msgs.msg import Image, CameraInfo, PointCloud2\n+\n+PKG = \"navigator_gazebo\"\n+\n+\n+class TestSimIntegration(unittest.TestCase):\n+\n+    def __init__(self, *args):\n+        super(TestSimIntegration, self).__init__(*args)\n+        rospy.sleep(1)\n+\n+    def test_odom(self):\n+        rospy.Subscriber(\"/odom\", Odometry, self.verify_odom)\n+\n+    def verify_odom(self, data):\n+        beg_pos_x = -1.2319","path":"simulation/navigator_gazebo/test/test_sim_integration.py","position":20,"original_position":20,"commit_id":"51b7f6cb9f3548ee76057518f80a7193fe8f431a","original_commit_id":"51b7f6cb9f3548ee76057518f80a7193fe8f431a","user":{"login":"ironmig","id":9502636,"avatar_url":"https://avatars3.githubusercontent.com/u/9502636?v=4","gravatar_id":"","url":"https://api.github.com/users/ironmig","html_url":"https://github.com/ironmig","followers_url":"https://api.github.com/users/ironmig/followers","following_url":"https://api.github.com/users/ironmig/following{/other_user}","gists_url":"https://api.github.com/users/ironmig/gists{/gist_id}","starred_url":"https://api.github.com/users/ironmig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ironmig/subscriptions","organizations_url":"https://api.github.com/users/ironmig/orgs","repos_url":"https://api.github.com/users/ironmig/repos","events_url":"https://api.github.com/users/ironmig/events{/privacy}","received_events_url":"https://api.github.com/users/ironmig/received_events","type":"User","site_admin":false},"body":"Leave a comment saying why it's these numbers. Also suggest setting the near zero values to 0 as you are checking almost equal anyways","created_at":"2017-09-28T23:18:07Z","updated_at":"2017-09-28T23:29:34Z","html_url":"https://github.com/uf-mil/NaviGator/pull/241#discussion_r141758693","pull_request_url":"https://api.github.com/repos/uf-mil/NaviGator/pulls/241","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/uf-mil/NaviGator/pulls/comments/141758693"},"html":{"href":"https://github.com/uf-mil/NaviGator/pull/241#discussion_r141758693"},"pull_request":{"href":"https://api.github.com/repos/uf-mil/NaviGator/pulls/241"}}},"pull_request":{"url":"https://api.github.com/repos/uf-mil/NaviGator/pulls/241","id":143743116,"html_url":"https://github.com/uf-mil/NaviGator/pull/241","diff_url":"https://github.com/uf-mil/NaviGator/pull/241.diff","patch_url":"https://github.com/uf-mil/NaviGator/pull/241.patch","issue_url":"https://api.github.com/repos/uf-mil/NaviGator/issues/241","number":241,"state":"open","locked":false,"title":"TEST: Sim Integration Test","user":{"login":"jmmarotta","id":25044559,"avatar_url":"https://avatars2.githubusercontent.com/u/25044559?v=4","gravatar_id":"","url":"https://api.github.com/users/jmmarotta","html_url":"https://github.com/jmmarotta","followers_url":"https://api.github.com/users/jmmarotta/followers","following_url":"https://api.github.com/users/jmmarotta/following{/other_user}","gists_url":"https://api.github.com/users/jmmarotta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmarotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmarotta/subscriptions","organizations_url":"https://api.github.com/users/jmmarotta/orgs","repos_url":"https://api.github.com/users/jmmarotta/repos","events_url":"https://api.github.com/users/jmmarotta/events{/privacy}","received_events_url":"https://api.github.com/users/jmmarotta/received_events","type":"User","site_admin":false},"body":"A completed basic sim integration test.  This tests initial odometry, camera, and lidar data.","created_at":"2017-09-28T20:06:18Z","updated_at":"2017-09-28T23:29:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d72f26dffb8af34ae4dbf7eb710546abf6a3bc08","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/uf-mil/NaviGator/pulls/241/commits","review_comments_url":"https://api.github.com/repos/uf-mil/NaviGator/pulls/241/comments","review_comment_url":"https://api.github.com/repos/uf-mil/NaviGator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/uf-mil/NaviGator/issues/241/comments","statuses_url":"https://api.github.com/repos/uf-mil/NaviGator/statuses/51b7f6cb9f3548ee76057518f80a7193fe8f431a","head":{"label":"jmmarotta:kinetic-upgrade","ref":"kinetic-upgrade","sha":"51b7f6cb9f3548ee76057518f80a7193fe8f431a","user":{"login":"jmmarotta","id":25044559,"avatar_url":"https://avatars2.githubusercontent.com/u/25044559?v=4","gravatar_id":"","url":"https://api.github.com/users/jmmarotta","html_url":"https://github.com/jmmarotta","followers_url":"https://api.github.com/users/jmmarotta/followers","following_url":"https://api.github.com/users/jmmarotta/following{/other_user}","gists_url":"https://api.github.com/users/jmmarotta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmarotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmarotta/subscriptions","organizations_url":"https://api.github.com/users/jmmarotta/orgs","repos_url":"https://api.github.com/users/jmmarotta/repos","events_url":"https://api.github.com/users/jmmarotta/events{/privacy}","received_events_url":"https://api.github.com/users/jmmarotta/received_events","type":"User","site_admin":false},"repo":{"id":102032424,"name":"NaviGator","full_name":"jmmarotta/NaviGator","owner":{"login":"jmmarotta","id":25044559,"avatar_url":"https://avatars2.githubusercontent.com/u/25044559?v=4","gravatar_id":"","url":"https://api.github.com/users/jmmarotta","html_url":"https://github.com/jmmarotta","followers_url":"https://api.github.com/users/jmmarotta/followers","following_url":"https://api.github.com/users/jmmarotta/following{/other_user}","gists_url":"https://api.github.com/users/jmmarotta/gists{/gist_id}","starred_url":"https://api.github.com/users/jmmarotta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmmarotta/subscriptions","organizations_url":"https://api.github.com/users/jmmarotta/orgs","repos_url":"https://api.github.com/users/jmmarotta/repos","events_url":"https://api.github.com/users/jmmarotta/events{/privacy}","received_events_url":"https://api.github.com/users/jmmarotta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmmarotta/NaviGator","description":"NaviGator ASV on-board software","fork":true,"url":"https://api.github.com/repos/jmmarotta/NaviGator","forks_url":"https://api.github.com/repos/jmmarotta/NaviGator/forks","keys_url":"https://api.github.com/repos/jmmarotta/NaviGator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmmarotta/NaviGator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmmarotta/NaviGator/teams","hooks_url":"https://api.github.com/repos/jmmarotta/NaviGator/hooks","issue_events_url":"https://api.github.com/repos/jmmarotta/NaviGator/issues/events{/number}","events_url":"https://api.github.com/repos/jmmarotta/NaviGator/events","assignees_url":"https://api.github.com/repos/jmmarotta/NaviGator/assignees{/user}","branches_url":"https://api.github.com/repos/jmmarotta/NaviGator/branches{/branch}","tags_url":"https://api.github.com/repos/jmmarotta/NaviGator/tags","blobs_url":"https://api.github.com/repos/jmmarotta/NaviGator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmmarotta/NaviGator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmmarotta/NaviGator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmmarotta/NaviGator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmmarotta/NaviGator/statuses/{sha}","languages_url":"https://api.github.com/repos/jmmarotta/NaviGator/languages","stargazers_url":"https://api.github.com/repos/jmmarotta/NaviGator/stargazers","contributors_url":"https://api.github.com/repos/jmmarotta/NaviGator/contributors","subscribers_url":"https://api.github.com/repos/jmmarotta/NaviGator/subscribers","subscription_url":"https://api.github.com/repos/jmmarotta/NaviGator/subscription","commits_url":"https://api.github.com/repos/jmmarotta/NaviGator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmmarotta/NaviGator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmmarotta/NaviGator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmmarotta/NaviGator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmmarotta/NaviGator/contents/{+path}","compare_url":"https://api.github.com/repos/jmmarotta/NaviGator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmmarotta/NaviGator/merges","archive_url":"https://api.github.com/repos/jmmarotta/NaviGator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmmarotta/NaviGator/downloads","issues_url":"https://api.github.com/repos/jmmarotta/NaviGator/issues{/number}","pulls_url":"https://api.github.com/repos/jmmarotta/NaviGator/pulls{/number}","milestones_url":"https://api.github.com/repos/jmmarotta/NaviGator/milestones{/number}","notifications_url":"https://api.github.com/repos/jmmarotta/NaviGator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmmarotta/NaviGator/labels{/name}","releases_url":"https://api.github.com/repos/jmmarotta/NaviGator/releases{/id}","deployments_url":"https://api.github.com/repos/jmmarotta/NaviGator/deployments","created_at":"2017-08-31T18:32:25Z","updated_at":"2017-08-31T18:32:27Z","pushed_at":"2017-09-28T22:26:53Z","git_url":"git://github.com/jmmarotta/NaviGator.git","ssh_url":"git@github.com:jmmarotta/NaviGator.git","clone_url":"https://github.com/jmmarotta/NaviGator.git","svn_url":"https://github.com/jmmarotta/NaviGator","homepage":"","size":12440,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"uf-mil:kinetic-upgrade","ref":"kinetic-upgrade","sha":"5fb00c32e3d4069ba0a5b93111993f5e1f925df6","user":{"login":"uf-mil","id":6162945,"avatar_url":"https://avatars0.githubusercontent.com/u/6162945?v=4","gravatar_id":"","url":"https://api.github.com/users/uf-mil","html_url":"https://github.com/uf-mil","followers_url":"https://api.github.com/users/uf-mil/followers","following_url":"https://api.github.com/users/uf-mil/following{/other_user}","gists_url":"https://api.github.com/users/uf-mil/gists{/gist_id}","starred_url":"https://api.github.com/users/uf-mil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uf-mil/subscriptions","organizations_url":"https://api.github.com/users/uf-mil/orgs","repos_url":"https://api.github.com/users/uf-mil/repos","events_url":"https://api.github.com/users/uf-mil/events{/privacy}","received_events_url":"https://api.github.com/users/uf-mil/received_events","type":"Organization","site_admin":false},"repo":{"id":42456121,"name":"NaviGator","full_name":"uf-mil/NaviGator","owner":{"login":"uf-mil","id":6162945,"avatar_url":"https://avatars0.githubusercontent.com/u/6162945?v=4","gravatar_id":"","url":"https://api.github.com/users/uf-mil","html_url":"https://github.com/uf-mil","followers_url":"https://api.github.com/users/uf-mil/followers","following_url":"https://api.github.com/users/uf-mil/following{/other_user}","gists_url":"https://api.github.com/users/uf-mil/gists{/gist_id}","starred_url":"https://api.github.com/users/uf-mil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uf-mil/subscriptions","organizations_url":"https://api.github.com/users/uf-mil/orgs","repos_url":"https://api.github.com/users/uf-mil/repos","events_url":"https://api.github.com/users/uf-mil/events{/privacy}","received_events_url":"https://api.github.com/users/uf-mil/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/uf-mil/NaviGator","description":"NaviGator ASV on-board software","fork":false,"url":"https://api.github.com/repos/uf-mil/NaviGator","forks_url":"https://api.github.com/repos/uf-mil/NaviGator/forks","keys_url":"https://api.github.com/repos/uf-mil/NaviGator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/uf-mil/NaviGator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/uf-mil/NaviGator/teams","hooks_url":"https://api.github.com/repos/uf-mil/NaviGator/hooks","issue_events_url":"https://api.github.com/repos/uf-mil/NaviGator/issues/events{/number}","events_url":"https://api.github.com/repos/uf-mil/NaviGator/events","assignees_url":"https://api.github.com/repos/uf-mil/NaviGator/assignees{/user}","branches_url":"https://api.github.com/repos/uf-mil/NaviGator/branches{/branch}","tags_url":"https://api.github.com/repos/uf-mil/NaviGator/tags","blobs_url":"https://api.github.com/repos/uf-mil/NaviGator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/uf-mil/NaviGator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/uf-mil/NaviGator/git/refs{/sha}","trees_url":"https://api.github.com/repos/uf-mil/NaviGator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/uf-mil/NaviGator/statuses/{sha}","languages_url":"https://api.github.com/repos/uf-mil/NaviGator/languages","stargazers_url":"https://api.github.com/repos/uf-mil/NaviGator/stargazers","contributors_url":"https://api.github.com/repos/uf-mil/NaviGator/contributors","subscribers_url":"https://api.github.com/repos/uf-mil/NaviGator/subscribers","subscription_url":"https://api.github.com/repos/uf-mil/NaviGator/subscription","commits_url":"https://api.github.com/repos/uf-mil/NaviGator/commits{/sha}","git_commits_url":"https://api.github.com/repos/uf-mil/NaviGator/git/commits{/sha}","comments_url":"https://api.github.com/repos/uf-mil/NaviGator/comments{/number}","issue_comment_url":"https://api.github.com/repos/uf-mil/NaviGator/issues/comments{/number}","contents_url":"https://api.github.com/repos/uf-mil/NaviGator/contents/{+path}","compare_url":"https://api.github.com/repos/uf-mil/NaviGator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/uf-mil/NaviGator/merges","archive_url":"https://api.github.com/repos/uf-mil/NaviGator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/uf-mil/NaviGator/downloads","issues_url":"https://api.github.com/repos/uf-mil/NaviGator/issues{/number}","pulls_url":"https://api.github.com/repos/uf-mil/NaviGator/pulls{/number}","milestones_url":"https://api.github.com/repos/uf-mil/NaviGator/milestones{/number}","notifications_url":"https://api.github.com/repos/uf-mil/NaviGator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/uf-mil/NaviGator/labels{/name}","releases_url":"https://api.github.com/repos/uf-mil/NaviGator/releases{/id}","deployments_url":"https://api.github.com/repos/uf-mil/NaviGator/deployments","created_at":"2015-09-14T15:07:13Z","updated_at":"2017-09-13T18:55:14Z","pushed_at":"2017-09-28T23:14:47Z","git_url":"git://github.com/uf-mil/NaviGator.git","ssh_url":"git@github.com:uf-mil/NaviGator.git","clone_url":"https://github.com/uf-mil/NaviGator.git","svn_url":"https://github.com/uf-mil/NaviGator","homepage":"","size":12434,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"open_issues_count":21,"forks":24,"open_issues":21,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/uf-mil/NaviGator/pulls/241"},"html":{"href":"https://github.com/uf-mil/NaviGator/pull/241"},"issue":{"href":"https://api.github.com/repos/uf-mil/NaviGator/issues/241"},"comments":{"href":"https://api.github.com/repos/uf-mil/NaviGator/issues/241/comments"},"review_comments":{"href":"https://api.github.com/repos/uf-mil/NaviGator/pulls/241/comments"},"review_comment":{"href":"https://api.github.com/repos/uf-mil/NaviGator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/uf-mil/NaviGator/pulls/241/commits"},"statuses":{"href":"https://api.github.com/repos/uf-mil/NaviGator/statuses/51b7f6cb9f3548ee76057518f80a7193fe8f431a"}},"author_association":"NONE"}}
{"actor":{"display_login":"ironmig"}}