{"action":"created","comment":{"url":"https://api.github.com/repos/mpvader/venus-signalk/pulls/comments/154538292","pull_request_review_id":80714970,"id":154538292,"diff_hunk":"@@ -40,14 +41,75 @@ const mappings = {\n       return 'notifications.' + makePath(msg, '${instance}.error')\n     },\n     conversion: convertErrorToNotification\n-  }\n+  },\n+  '/Alarms/Alarm': {","path":"venusToDeltas.js","position":12,"original_position":12,"commit_id":"191ec9d07578b477029db30551ffbfd7a3092e10","original_commit_id":"191ec9d07578b477029db30551ffbfd7a3092e10","user":{"login":"mpvader","id":5200296,"avatar_url":"https://avatars1.githubusercontent.com/u/5200296?v=4","gravatar_id":"","url":"https://api.github.com/users/mpvader","html_url":"https://github.com/mpvader","followers_url":"https://api.github.com/users/mpvader/followers","following_url":"https://api.github.com/users/mpvader/following{/other_user}","gists_url":"https://api.github.com/users/mpvader/gists{/gist_id}","starred_url":"https://api.github.com/users/mpvader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpvader/subscriptions","organizations_url":"https://api.github.com/users/mpvader/orgs","repos_url":"https://api.github.com/users/mpvader/repos","events_url":"https://api.github.com/users/mpvader/events{/privacy}","received_events_url":"https://api.github.com/users/mpvader/received_events","type":"User","site_admin":false},"body":"I'm not sure if its necessary to handle the generic path as well: the result will be that you get the alarms twice in Signalk, once generic, and once the details. Handling only the details should be good enough I think.","created_at":"2017-12-03T22:02:07Z","updated_at":"2017-12-03T22:05:26Z","html_url":"https://github.com/mpvader/venus-signalk/pull/11#discussion_r154538292","pull_request_url":"https://api.github.com/repos/mpvader/venus-signalk/pulls/11","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/mpvader/venus-signalk/pulls/comments/154538292"},"html":{"href":"https://github.com/mpvader/venus-signalk/pull/11#discussion_r154538292"},"pull_request":{"href":"https://api.github.com/repos/mpvader/venus-signalk/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/mpvader/venus-signalk/pulls/11","id":156028194,"html_url":"https://github.com/mpvader/venus-signalk/pull/11","diff_url":"https://github.com/mpvader/venus-signalk/pull/11.diff","patch_url":"https://github.com/mpvader/venus-signalk/pull/11.patch","issue_url":"https://api.github.com/repos/mpvader/venus-signalk/issues/11","number":11,"state":"open","locked":false,"title":"Updates to fix issues and add new supported paths","user":{"login":"sbender9","id":7853683,"avatar_url":"https://avatars3.githubusercontent.com/u/7853683?v=4","gravatar_id":"","url":"https://api.github.com/users/sbender9","html_url":"https://github.com/sbender9","followers_url":"https://api.github.com/users/sbender9/followers","following_url":"https://api.github.com/users/sbender9/following{/other_user}","gists_url":"https://api.github.com/users/sbender9/gists{/gist_id}","starred_url":"https://api.github.com/users/sbender9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbender9/subscriptions","organizations_url":"https://api.github.com/users/sbender9/orgs","repos_url":"https://api.github.com/users/sbender9/repos","events_url":"https://api.github.com/users/sbender9/events{/privacy}","received_events_url":"https://api.github.com/users/sbender9/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-12-02T19:47:23Z","updated_at":"2017-12-03T22:05:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98176e0eca7df10cf10c26dafbed39f409b9af41","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mpvader/venus-signalk/pulls/11/commits","review_comments_url":"https://api.github.com/repos/mpvader/venus-signalk/pulls/11/comments","review_comment_url":"https://api.github.com/repos/mpvader/venus-signalk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpvader/venus-signalk/issues/11/comments","statuses_url":"https://api.github.com/repos/mpvader/venus-signalk/statuses/191ec9d07578b477029db30551ffbfd7a3092e10","head":{"label":"sbender9:updates","ref":"updates","sha":"191ec9d07578b477029db30551ffbfd7a3092e10","user":{"login":"sbender9","id":7853683,"avatar_url":"https://avatars3.githubusercontent.com/u/7853683?v=4","gravatar_id":"","url":"https://api.github.com/users/sbender9","html_url":"https://github.com/sbender9","followers_url":"https://api.github.com/users/sbender9/followers","following_url":"https://api.github.com/users/sbender9/following{/other_user}","gists_url":"https://api.github.com/users/sbender9/gists{/gist_id}","starred_url":"https://api.github.com/users/sbender9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbender9/subscriptions","organizations_url":"https://api.github.com/users/sbender9/orgs","repos_url":"https://api.github.com/users/sbender9/repos","events_url":"https://api.github.com/users/sbender9/events{/privacy}","received_events_url":"https://api.github.com/users/sbender9/received_events","type":"User","site_admin":false},"repo":{"id":112263180,"name":"venus-signalk","full_name":"sbender9/venus-signalk","owner":{"login":"sbender9","id":7853683,"avatar_url":"https://avatars3.githubusercontent.com/u/7853683?v=4","gravatar_id":"","url":"https://api.github.com/users/sbender9","html_url":"https://github.com/sbender9","followers_url":"https://api.github.com/users/sbender9/followers","following_url":"https://api.github.com/users/sbender9/following{/other_user}","gists_url":"https://api.github.com/users/sbender9/gists{/gist_id}","starred_url":"https://api.github.com/users/sbender9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbender9/subscriptions","organizations_url":"https://api.github.com/users/sbender9/orgs","repos_url":"https://api.github.com/users/sbender9/repos","events_url":"https://api.github.com/users/sbender9/events{/privacy}","received_events_url":"https://api.github.com/users/sbender9/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbender9/venus-signalk","description":"reading venus-style dbus signals to go into signalk - eventually","fork":true,"url":"https://api.github.com/repos/sbender9/venus-signalk","forks_url":"https://api.github.com/repos/sbender9/venus-signalk/forks","keys_url":"https://api.github.com/repos/sbender9/venus-signalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbender9/venus-signalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbender9/venus-signalk/teams","hooks_url":"https://api.github.com/repos/sbender9/venus-signalk/hooks","issue_events_url":"https://api.github.com/repos/sbender9/venus-signalk/issues/events{/number}","events_url":"https://api.github.com/repos/sbender9/venus-signalk/events","assignees_url":"https://api.github.com/repos/sbender9/venus-signalk/assignees{/user}","branches_url":"https://api.github.com/repos/sbender9/venus-signalk/branches{/branch}","tags_url":"https://api.github.com/repos/sbender9/venus-signalk/tags","blobs_url":"https://api.github.com/repos/sbender9/venus-signalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbender9/venus-signalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbender9/venus-signalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbender9/venus-signalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbender9/venus-signalk/statuses/{sha}","languages_url":"https://api.github.com/repos/sbender9/venus-signalk/languages","stargazers_url":"https://api.github.com/repos/sbender9/venus-signalk/stargazers","contributors_url":"https://api.github.com/repos/sbender9/venus-signalk/contributors","subscribers_url":"https://api.github.com/repos/sbender9/venus-signalk/subscribers","subscription_url":"https://api.github.com/repos/sbender9/venus-signalk/subscription","commits_url":"https://api.github.com/repos/sbender9/venus-signalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbender9/venus-signalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbender9/venus-signalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbender9/venus-signalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbender9/venus-signalk/contents/{+path}","compare_url":"https://api.github.com/repos/sbender9/venus-signalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbender9/venus-signalk/merges","archive_url":"https://api.github.com/repos/sbender9/venus-signalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbender9/venus-signalk/downloads","issues_url":"https://api.github.com/repos/sbender9/venus-signalk/issues{/number}","pulls_url":"https://api.github.com/repos/sbender9/venus-signalk/pulls{/number}","milestones_url":"https://api.github.com/repos/sbender9/venus-signalk/milestones{/number}","notifications_url":"https://api.github.com/repos/sbender9/venus-signalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbender9/venus-signalk/labels{/name}","releases_url":"https://api.github.com/repos/sbender9/venus-signalk/releases{/id}","deployments_url":"https://api.github.com/repos/sbender9/venus-signalk/deployments","created_at":"2017-11-28T00:04:26Z","updated_at":"2017-11-28T00:04:28Z","pushed_at":"2017-12-02T20:48:26Z","git_url":"git://github.com/sbender9/venus-signalk.git","ssh_url":"git@github.com:sbender9/venus-signalk.git","clone_url":"https://github.com/sbender9/venus-signalk.git","svn_url":"https://github.com/sbender9/venus-signalk","homepage":null,"size":44,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mpvader:master","ref":"master","sha":"b8c08184b3460e9445b16aee92315ac3c965223e","user":{"login":"mpvader","id":5200296,"avatar_url":"https://avatars1.githubusercontent.com/u/5200296?v=4","gravatar_id":"","url":"https://api.github.com/users/mpvader","html_url":"https://github.com/mpvader","followers_url":"https://api.github.com/users/mpvader/followers","following_url":"https://api.github.com/users/mpvader/following{/other_user}","gists_url":"https://api.github.com/users/mpvader/gists{/gist_id}","starred_url":"https://api.github.com/users/mpvader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpvader/subscriptions","organizations_url":"https://api.github.com/users/mpvader/orgs","repos_url":"https://api.github.com/users/mpvader/repos","events_url":"https://api.github.com/users/mpvader/events{/privacy}","received_events_url":"https://api.github.com/users/mpvader/received_events","type":"User","site_admin":false},"repo":{"id":111851355,"name":"venus-signalk","full_name":"mpvader/venus-signalk","owner":{"login":"mpvader","id":5200296,"avatar_url":"https://avatars1.githubusercontent.com/u/5200296?v=4","gravatar_id":"","url":"https://api.github.com/users/mpvader","html_url":"https://github.com/mpvader","followers_url":"https://api.github.com/users/mpvader/followers","following_url":"https://api.github.com/users/mpvader/following{/other_user}","gists_url":"https://api.github.com/users/mpvader/gists{/gist_id}","starred_url":"https://api.github.com/users/mpvader/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpvader/subscriptions","organizations_url":"https://api.github.com/users/mpvader/orgs","repos_url":"https://api.github.com/users/mpvader/repos","events_url":"https://api.github.com/users/mpvader/events{/privacy}","received_events_url":"https://api.github.com/users/mpvader/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mpvader/venus-signalk","description":"reading venus-style dbus signals to go into signalk - eventually","fork":false,"url":"https://api.github.com/repos/mpvader/venus-signalk","forks_url":"https://api.github.com/repos/mpvader/venus-signalk/forks","keys_url":"https://api.github.com/repos/mpvader/venus-signalk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpvader/venus-signalk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpvader/venus-signalk/teams","hooks_url":"https://api.github.com/repos/mpvader/venus-signalk/hooks","issue_events_url":"https://api.github.com/repos/mpvader/venus-signalk/issues/events{/number}","events_url":"https://api.github.com/repos/mpvader/venus-signalk/events","assignees_url":"https://api.github.com/repos/mpvader/venus-signalk/assignees{/user}","branches_url":"https://api.github.com/repos/mpvader/venus-signalk/branches{/branch}","tags_url":"https://api.github.com/repos/mpvader/venus-signalk/tags","blobs_url":"https://api.github.com/repos/mpvader/venus-signalk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpvader/venus-signalk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpvader/venus-signalk/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpvader/venus-signalk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpvader/venus-signalk/statuses/{sha}","languages_url":"https://api.github.com/repos/mpvader/venus-signalk/languages","stargazers_url":"https://api.github.com/repos/mpvader/venus-signalk/stargazers","contributors_url":"https://api.github.com/repos/mpvader/venus-signalk/contributors","subscribers_url":"https://api.github.com/repos/mpvader/venus-signalk/subscribers","subscription_url":"https://api.github.com/repos/mpvader/venus-signalk/subscription","commits_url":"https://api.github.com/repos/mpvader/venus-signalk/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpvader/venus-signalk/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpvader/venus-signalk/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpvader/venus-signalk/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpvader/venus-signalk/contents/{+path}","compare_url":"https://api.github.com/repos/mpvader/venus-signalk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpvader/venus-signalk/merges","archive_url":"https://api.github.com/repos/mpvader/venus-signalk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpvader/venus-signalk/downloads","issues_url":"https://api.github.com/repos/mpvader/venus-signalk/issues{/number}","pulls_url":"https://api.github.com/repos/mpvader/venus-signalk/pulls{/number}","milestones_url":"https://api.github.com/repos/mpvader/venus-signalk/milestones{/number}","notifications_url":"https://api.github.com/repos/mpvader/venus-signalk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpvader/venus-signalk/labels{/name}","releases_url":"https://api.github.com/repos/mpvader/venus-signalk/releases{/id}","deployments_url":"https://api.github.com/repos/mpvader/venus-signalk/deployments","created_at":"2017-11-23T21:25:38Z","updated_at":"2017-11-23T21:36:21Z","pushed_at":"2017-12-03T21:55:33Z","git_url":"git://github.com/mpvader/venus-signalk.git","ssh_url":"git@github.com:mpvader/venus-signalk.git","clone_url":"https://github.com/mpvader/venus-signalk.git","svn_url":"https://github.com/mpvader/venus-signalk","homepage":null,"size":36,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":1,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpvader/venus-signalk/pulls/11"},"html":{"href":"https://github.com/mpvader/venus-signalk/pull/11"},"issue":{"href":"https://api.github.com/repos/mpvader/venus-signalk/issues/11"},"comments":{"href":"https://api.github.com/repos/mpvader/venus-signalk/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/mpvader/venus-signalk/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/mpvader/venus-signalk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpvader/venus-signalk/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/mpvader/venus-signalk/statuses/191ec9d07578b477029db30551ffbfd7a3092e10"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mpvader"}}