{"action":"created","issue":{"url":"https://api.github.com/repos/lyft/envoy/issues/1167","repository_url":"https://api.github.com/repos/lyft/envoy","labels_url":"https://api.github.com/repos/lyft/envoy/issues/1167/labels{/name}","comments_url":"https://api.github.com/repos/lyft/envoy/issues/1167/comments","events_url":"https://api.github.com/repos/lyft/envoy/issues/1167/events","html_url":"https://github.com/lyft/envoy/pull/1167","id":238002276,"number":1167,"title":"Parameterize the repository locations of the bazel based dependencies","user":{"login":"mattwoodyard","id":451957,"avatar_url":"https://avatars3.githubusercontent.com/u/451957?v=3","gravatar_id":"","url":"https://api.github.com/users/mattwoodyard","html_url":"https://github.com/mattwoodyard","followers_url":"https://api.github.com/users/mattwoodyard/followers","following_url":"https://api.github.com/users/mattwoodyard/following{/other_user}","gists_url":"https://api.github.com/users/mattwoodyard/gists{/gist_id}","starred_url":"https://api.github.com/users/mattwoodyard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattwoodyard/subscriptions","organizations_url":"https://api.github.com/users/mattwoodyard/orgs","repos_url":"https://api.github.com/users/mattwoodyard/repos","events_url":"https://api.github.com/users/mattwoodyard/events{/privacy}","received_events_url":"https://api.github.com/users/mattwoodyard/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-22T23:35:48Z","updated_at":"2017-06-24T19:24:28Z","closed_at":"2017-06-23T15:36:41Z","pull_request":{"url":"https://api.github.com/repos/lyft/envoy/pulls/1167","html_url":"https://github.com/lyft/envoy/pull/1167","diff_url":"https://github.com/lyft/envoy/pull/1167.diff","patch_url":"https://github.com/lyft/envoy/pull/1167.patch"},"body":"The repository locations are now stored in a external file, allowing sites to provide\r\nalternate sources for the referenced code, without introducing merge conflicts"},"comment":{"url":"https://api.github.com/repos/lyft/envoy/issues/comments/310860707","html_url":"https://github.com/lyft/envoy/pull/1167#issuecomment-310860707","issue_url":"https://api.github.com/repos/lyft/envoy/issues/1167","id":310860707,"user":{"login":"lizan","id":1016047,"avatar_url":"https://avatars2.githubusercontent.com/u/1016047?v=3","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},"created_at":"2017-06-24T19:24:28Z","updated_at":"2017-06-24T19:24:28Z","body":"@mattwoodyard For example, if you want to change `envoy-api` to your own fork, then you need to modify the location of the repo, in `bazel/repository_locations.bzl`, but you still have to modify `bazel/repositories.bzl`, to change the SHA of `envoy-api` specified in that file. If you're using same SHA, then you don't need change the location since it is same.\r\n\r\nHaving SHA together with the repo location in `bazel/repository_locations.bzl` is better, though IMO it is still not good enough. Happy to discuss on Gitter, etc. I'm not very clearly understand what you're trying to solve here. "}}
{"actor":{"display_login":"lizan"}}