{"action":"closed","number":36,"pull_request":{"url":"https://api.github.com/repos/python-hyper/hyperlink/pulls/36","id":134276646,"html_url":"https://github.com/python-hyper/hyperlink/pull/36","diff_url":"https://github.com/python-hyper/hyperlink/pull/36.diff","patch_url":"https://github.com/python-hyper/hyperlink/pull/36.patch","issue_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/36","number":36,"state":"closed","locked":false,"title":"URL.click() for URL objects","user":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars0.githubusercontent.com/u/130193?v=4","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"body":"This PR makes URL.click work with URL objects, not just text, fixing #35.\r\n\r\nThere is one slightly outstanding issue, detailed in a `TODO` comment, which is that I need to remove the error message checks in Twisted's test suite. I haven't known anybody to depend on the byte-for-byte unchangingness of error messages as a public API, and in this case, it's restricting usability.","created_at":"2017-08-05T02:40:38Z","updated_at":"2017-08-05T19:10:17Z","closed_at":"2017-08-05T19:10:17Z","merged_at":"2017-08-05T19:10:17Z","merge_commit_sha":"d259a0774200ad9fb5ece96673cde77daf9fdf91","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/python-hyper/hyperlink/pulls/36/commits","review_comments_url":"https://api.github.com/repos/python-hyper/hyperlink/pulls/36/comments","review_comment_url":"https://api.github.com/repos/python-hyper/hyperlink/pulls/comments{/number}","comments_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/36/comments","statuses_url":"https://api.github.com/repos/python-hyper/hyperlink/statuses/003709e8646682240d0b8e0f73b6c1a5bd8dd8a5","head":{"label":"python-hyper:click_url","ref":"click_url","sha":"003709e8646682240d0b8e0f73b6c1a5bd8dd8a5","user":{"login":"python-hyper","id":13035907,"avatar_url":"https://avatars0.githubusercontent.com/u/13035907?v=4","gravatar_id":"","url":"https://api.github.com/users/python-hyper","html_url":"https://github.com/python-hyper","followers_url":"https://api.github.com/users/python-hyper/followers","following_url":"https://api.github.com/users/python-hyper/following{/other_user}","gists_url":"https://api.github.com/users/python-hyper/gists{/gist_id}","starred_url":"https://api.github.com/users/python-hyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-hyper/subscriptions","organizations_url":"https://api.github.com/users/python-hyper/orgs","repos_url":"https://api.github.com/users/python-hyper/repos","events_url":"https://api.github.com/users/python-hyper/events{/privacy}","received_events_url":"https://api.github.com/users/python-hyper/received_events","type":"Organization","site_admin":false},"repo":{"id":82321340,"name":"hyperlink","full_name":"python-hyper/hyperlink","owner":{"login":"python-hyper","id":13035907,"avatar_url":"https://avatars0.githubusercontent.com/u/13035907?v=4","gravatar_id":"","url":"https://api.github.com/users/python-hyper","html_url":"https://github.com/python-hyper","followers_url":"https://api.github.com/users/python-hyper/followers","following_url":"https://api.github.com/users/python-hyper/following{/other_user}","gists_url":"https://api.github.com/users/python-hyper/gists{/gist_id}","starred_url":"https://api.github.com/users/python-hyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-hyper/subscriptions","organizations_url":"https://api.github.com/users/python-hyper/orgs","repos_url":"https://api.github.com/users/python-hyper/repos","events_url":"https://api.github.com/users/python-hyper/events{/privacy}","received_events_url":"https://api.github.com/users/python-hyper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-hyper/hyperlink","description":"Immutable, Pythonic, correct URLs.","fork":false,"url":"https://api.github.com/repos/python-hyper/hyperlink","forks_url":"https://api.github.com/repos/python-hyper/hyperlink/forks","keys_url":"https://api.github.com/repos/python-hyper/hyperlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-hyper/hyperlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-hyper/hyperlink/teams","hooks_url":"https://api.github.com/repos/python-hyper/hyperlink/hooks","issue_events_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/events{/number}","events_url":"https://api.github.com/repos/python-hyper/hyperlink/events","assignees_url":"https://api.github.com/repos/python-hyper/hyperlink/assignees{/user}","branches_url":"https://api.github.com/repos/python-hyper/hyperlink/branches{/branch}","tags_url":"https://api.github.com/repos/python-hyper/hyperlink/tags","blobs_url":"https://api.github.com/repos/python-hyper/hyperlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-hyper/hyperlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-hyper/hyperlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-hyper/hyperlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-hyper/hyperlink/statuses/{sha}","languages_url":"https://api.github.com/repos/python-hyper/hyperlink/languages","stargazers_url":"https://api.github.com/repos/python-hyper/hyperlink/stargazers","contributors_url":"https://api.github.com/repos/python-hyper/hyperlink/contributors","subscribers_url":"https://api.github.com/repos/python-hyper/hyperlink/subscribers","subscription_url":"https://api.github.com/repos/python-hyper/hyperlink/subscription","commits_url":"https://api.github.com/repos/python-hyper/hyperlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-hyper/hyperlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-hyper/hyperlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-hyper/hyperlink/contents/{+path}","compare_url":"https://api.github.com/repos/python-hyper/hyperlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-hyper/hyperlink/merges","archive_url":"https://api.github.com/repos/python-hyper/hyperlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-hyper/hyperlink/downloads","issues_url":"https://api.github.com/repos/python-hyper/hyperlink/issues{/number}","pulls_url":"https://api.github.com/repos/python-hyper/hyperlink/pulls{/number}","milestones_url":"https://api.github.com/repos/python-hyper/hyperlink/milestones{/number}","notifications_url":"https://api.github.com/repos/python-hyper/hyperlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-hyper/hyperlink/labels{/name}","releases_url":"https://api.github.com/repos/python-hyper/hyperlink/releases{/id}","deployments_url":"https://api.github.com/repos/python-hyper/hyperlink/deployments","created_at":"2017-02-17T17:28:01Z","updated_at":"2017-08-02T17:03:54Z","pushed_at":"2017-08-05T19:10:17Z","git_url":"git://github.com/python-hyper/hyperlink.git","ssh_url":"git@github.com:python-hyper/hyperlink.git","clone_url":"https://github.com/python-hyper/hyperlink.git","svn_url":"https://github.com/python-hyper/hyperlink","homepage":null,"size":328,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":37,"default_branch":"master"}},"base":{"label":"python-hyper:master","ref":"master","sha":"7e9ce26ecf8e650312f1e5c3b76e7740e1538b00","user":{"login":"python-hyper","id":13035907,"avatar_url":"https://avatars0.githubusercontent.com/u/13035907?v=4","gravatar_id":"","url":"https://api.github.com/users/python-hyper","html_url":"https://github.com/python-hyper","followers_url":"https://api.github.com/users/python-hyper/followers","following_url":"https://api.github.com/users/python-hyper/following{/other_user}","gists_url":"https://api.github.com/users/python-hyper/gists{/gist_id}","starred_url":"https://api.github.com/users/python-hyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-hyper/subscriptions","organizations_url":"https://api.github.com/users/python-hyper/orgs","repos_url":"https://api.github.com/users/python-hyper/repos","events_url":"https://api.github.com/users/python-hyper/events{/privacy}","received_events_url":"https://api.github.com/users/python-hyper/received_events","type":"Organization","site_admin":false},"repo":{"id":82321340,"name":"hyperlink","full_name":"python-hyper/hyperlink","owner":{"login":"python-hyper","id":13035907,"avatar_url":"https://avatars0.githubusercontent.com/u/13035907?v=4","gravatar_id":"","url":"https://api.github.com/users/python-hyper","html_url":"https://github.com/python-hyper","followers_url":"https://api.github.com/users/python-hyper/followers","following_url":"https://api.github.com/users/python-hyper/following{/other_user}","gists_url":"https://api.github.com/users/python-hyper/gists{/gist_id}","starred_url":"https://api.github.com/users/python-hyper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/python-hyper/subscriptions","organizations_url":"https://api.github.com/users/python-hyper/orgs","repos_url":"https://api.github.com/users/python-hyper/repos","events_url":"https://api.github.com/users/python-hyper/events{/privacy}","received_events_url":"https://api.github.com/users/python-hyper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/python-hyper/hyperlink","description":"Immutable, Pythonic, correct URLs.","fork":false,"url":"https://api.github.com/repos/python-hyper/hyperlink","forks_url":"https://api.github.com/repos/python-hyper/hyperlink/forks","keys_url":"https://api.github.com/repos/python-hyper/hyperlink/keys{/key_id}","collaborators_url":"https://api.github.com/repos/python-hyper/hyperlink/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/python-hyper/hyperlink/teams","hooks_url":"https://api.github.com/repos/python-hyper/hyperlink/hooks","issue_events_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/events{/number}","events_url":"https://api.github.com/repos/python-hyper/hyperlink/events","assignees_url":"https://api.github.com/repos/python-hyper/hyperlink/assignees{/user}","branches_url":"https://api.github.com/repos/python-hyper/hyperlink/branches{/branch}","tags_url":"https://api.github.com/repos/python-hyper/hyperlink/tags","blobs_url":"https://api.github.com/repos/python-hyper/hyperlink/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/python-hyper/hyperlink/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/python-hyper/hyperlink/git/refs{/sha}","trees_url":"https://api.github.com/repos/python-hyper/hyperlink/git/trees{/sha}","statuses_url":"https://api.github.com/repos/python-hyper/hyperlink/statuses/{sha}","languages_url":"https://api.github.com/repos/python-hyper/hyperlink/languages","stargazers_url":"https://api.github.com/repos/python-hyper/hyperlink/stargazers","contributors_url":"https://api.github.com/repos/python-hyper/hyperlink/contributors","subscribers_url":"https://api.github.com/repos/python-hyper/hyperlink/subscribers","subscription_url":"https://api.github.com/repos/python-hyper/hyperlink/subscription","commits_url":"https://api.github.com/repos/python-hyper/hyperlink/commits{/sha}","git_commits_url":"https://api.github.com/repos/python-hyper/hyperlink/git/commits{/sha}","comments_url":"https://api.github.com/repos/python-hyper/hyperlink/comments{/number}","issue_comment_url":"https://api.github.com/repos/python-hyper/hyperlink/issues/comments{/number}","contents_url":"https://api.github.com/repos/python-hyper/hyperlink/contents/{+path}","compare_url":"https://api.github.com/repos/python-hyper/hyperlink/compare/{base}...{head}","merges_url":"https://api.github.com/repos/python-hyper/hyperlink/merges","archive_url":"https://api.github.com/repos/python-hyper/hyperlink/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/python-hyper/hyperlink/downloads","issues_url":"https://api.github.com/repos/python-hyper/hyperlink/issues{/number}","pulls_url":"https://api.github.com/repos/python-hyper/hyperlink/pulls{/number}","milestones_url":"https://api.github.com/repos/python-hyper/hyperlink/milestones{/number}","notifications_url":"https://api.github.com/repos/python-hyper/hyperlink/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/python-hyper/hyperlink/labels{/name}","releases_url":"https://api.github.com/repos/python-hyper/hyperlink/releases{/id}","deployments_url":"https://api.github.com/repos/python-hyper/hyperlink/deployments","created_at":"2017-02-17T17:28:01Z","updated_at":"2017-08-02T17:03:54Z","pushed_at":"2017-08-05T19:10:17Z","git_url":"git://github.com/python-hyper/hyperlink.git","ssh_url":"git@github.com:python-hyper/hyperlink.git","clone_url":"https://github.com/python-hyper/hyperlink.git","svn_url":"https://github.com/python-hyper/hyperlink","homepage":null,"size":328,"stargazers_count":37,"watchers_count":37,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"open_issues_count":10,"forks":3,"open_issues":10,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/python-hyper/hyperlink/pulls/36"},"html":{"href":"https://github.com/python-hyper/hyperlink/pull/36"},"issue":{"href":"https://api.github.com/repos/python-hyper/hyperlink/issues/36"},"comments":{"href":"https://api.github.com/repos/python-hyper/hyperlink/issues/36/comments"},"review_comments":{"href":"https://api.github.com/repos/python-hyper/hyperlink/pulls/36/comments"},"review_comment":{"href":"https://api.github.com/repos/python-hyper/hyperlink/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/python-hyper/hyperlink/pulls/36/commits"},"statuses":{"href":"https://api.github.com/repos/python-hyper/hyperlink/statuses/003709e8646682240d0b8e0f73b6c1a5bd8dd8a5"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mahmoud","id":130193,"avatar_url":"https://avatars0.githubusercontent.com/u/130193?v=4","gravatar_id":"","url":"https://api.github.com/users/mahmoud","html_url":"https://github.com/mahmoud","followers_url":"https://api.github.com/users/mahmoud/followers","following_url":"https://api.github.com/users/mahmoud/following{/other_user}","gists_url":"https://api.github.com/users/mahmoud/gists{/gist_id}","starred_url":"https://api.github.com/users/mahmoud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mahmoud/subscriptions","organizations_url":"https://api.github.com/users/mahmoud/orgs","repos_url":"https://api.github.com/users/mahmoud/repos","events_url":"https://api.github.com/users/mahmoud/events{/privacy}","received_events_url":"https://api.github.com/users/mahmoud/received_events","type":"User","site_admin":false},"comments":1,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":14,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"mahmoud"}}