{"action":"closed","number":231,"pull_request":{"url":"https://api.github.com/repos/prime31/Nez/pulls/231","id":118938866,"html_url":"https://github.com/prime31/Nez/pull/231","diff_url":"https://github.com/prime31/Nez/pull/231.diff","patch_url":"https://github.com/prime31/Nez/pull/231.patch","issue_url":"https://api.github.com/repos/prime31/Nez/issues/231","number":231,"state":"closed","locked":false,"title":"Adding support for PrimitiveType.TriangleStrip in Mesh","user":{"login":"robert-wallis","id":145938,"avatar_url":"https://avatars2.githubusercontent.com/u/145938?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-wallis","html_url":"https://github.com/robert-wallis","followers_url":"https://api.github.com/users/robert-wallis/followers","following_url":"https://api.github.com/users/robert-wallis/following{/other_user}","gists_url":"https://api.github.com/users/robert-wallis/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-wallis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-wallis/subscriptions","organizations_url":"https://api.github.com/users/robert-wallis/orgs","repos_url":"https://api.github.com/users/robert-wallis/repos","events_url":"https://api.github.com/users/robert-wallis/events{/privacy}","received_events_url":"https://api.github.com/users/robert-wallis/received_events","type":"User","site_admin":false},"body":"TriangleStrips are nicer than TriangleLists because the triangle indices don't need to be calculated.  Many modeling programs export data as strips.\r\n\r\nThe primitive count (number of tris) in a triangle strip is `_verts.Length - 2`. \r\n3 verts are 1 triangle (first triangle is vert 0, 1, 2)\r\n4 verts are 2 triangles (the second triangle is vert 1, 2, and 3)\r\n\r\nThis PR keeps the current default functionality of Mesh to use TriangleLists, and adds a new function `Mesh.setPrimitiveType(PrimitiveType)`  If the primitive type is set to strips, then the cheaper DrawUserPrimitives call is made which sends less data to the GPU.","created_at":"2017-05-04T10:12:50Z","updated_at":"2017-05-05T04:21:13Z","closed_at":"2017-05-05T04:21:13Z","merged_at":"2017-05-05T04:21:13Z","merge_commit_sha":"63824faf7c1cd51830187fd5fcf5b6970923d295","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/prime31/Nez/pulls/231/commits","review_comments_url":"https://api.github.com/repos/prime31/Nez/pulls/231/comments","review_comment_url":"https://api.github.com/repos/prime31/Nez/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prime31/Nez/issues/231/comments","statuses_url":"https://api.github.com/repos/prime31/Nez/statuses/64ef8ddccc4d9a411c2415159f0f66938a56157f","head":{"label":"robert-wallis:Mesh-TriangleStrip","ref":"Mesh-TriangleStrip","sha":"64ef8ddccc4d9a411c2415159f0f66938a56157f","user":{"login":"robert-wallis","id":145938,"avatar_url":"https://avatars2.githubusercontent.com/u/145938?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-wallis","html_url":"https://github.com/robert-wallis","followers_url":"https://api.github.com/users/robert-wallis/followers","following_url":"https://api.github.com/users/robert-wallis/following{/other_user}","gists_url":"https://api.github.com/users/robert-wallis/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-wallis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-wallis/subscriptions","organizations_url":"https://api.github.com/users/robert-wallis/orgs","repos_url":"https://api.github.com/users/robert-wallis/repos","events_url":"https://api.github.com/users/robert-wallis/events{/privacy}","received_events_url":"https://api.github.com/users/robert-wallis/received_events","type":"User","site_admin":false},"repo":{"id":89605988,"name":"Nez","full_name":"robert-wallis/Nez","owner":{"login":"robert-wallis","id":145938,"avatar_url":"https://avatars2.githubusercontent.com/u/145938?v=3","gravatar_id":"","url":"https://api.github.com/users/robert-wallis","html_url":"https://github.com/robert-wallis","followers_url":"https://api.github.com/users/robert-wallis/followers","following_url":"https://api.github.com/users/robert-wallis/following{/other_user}","gists_url":"https://api.github.com/users/robert-wallis/gists{/gist_id}","starred_url":"https://api.github.com/users/robert-wallis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robert-wallis/subscriptions","organizations_url":"https://api.github.com/users/robert-wallis/orgs","repos_url":"https://api.github.com/users/robert-wallis/repos","events_url":"https://api.github.com/users/robert-wallis/events{/privacy}","received_events_url":"https://api.github.com/users/robert-wallis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robert-wallis/Nez","description":"Nez is a free 2D focused framework that works with MonoGame and FNA","fork":true,"url":"https://api.github.com/repos/robert-wallis/Nez","forks_url":"https://api.github.com/repos/robert-wallis/Nez/forks","keys_url":"https://api.github.com/repos/robert-wallis/Nez/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robert-wallis/Nez/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robert-wallis/Nez/teams","hooks_url":"https://api.github.com/repos/robert-wallis/Nez/hooks","issue_events_url":"https://api.github.com/repos/robert-wallis/Nez/issues/events{/number}","events_url":"https://api.github.com/repos/robert-wallis/Nez/events","assignees_url":"https://api.github.com/repos/robert-wallis/Nez/assignees{/user}","branches_url":"https://api.github.com/repos/robert-wallis/Nez/branches{/branch}","tags_url":"https://api.github.com/repos/robert-wallis/Nez/tags","blobs_url":"https://api.github.com/repos/robert-wallis/Nez/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robert-wallis/Nez/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robert-wallis/Nez/git/refs{/sha}","trees_url":"https://api.github.com/repos/robert-wallis/Nez/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robert-wallis/Nez/statuses/{sha}","languages_url":"https://api.github.com/repos/robert-wallis/Nez/languages","stargazers_url":"https://api.github.com/repos/robert-wallis/Nez/stargazers","contributors_url":"https://api.github.com/repos/robert-wallis/Nez/contributors","subscribers_url":"https://api.github.com/repos/robert-wallis/Nez/subscribers","subscription_url":"https://api.github.com/repos/robert-wallis/Nez/subscription","commits_url":"https://api.github.com/repos/robert-wallis/Nez/commits{/sha}","git_commits_url":"https://api.github.com/repos/robert-wallis/Nez/git/commits{/sha}","comments_url":"https://api.github.com/repos/robert-wallis/Nez/comments{/number}","issue_comment_url":"https://api.github.com/repos/robert-wallis/Nez/issues/comments{/number}","contents_url":"https://api.github.com/repos/robert-wallis/Nez/contents/{+path}","compare_url":"https://api.github.com/repos/robert-wallis/Nez/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robert-wallis/Nez/merges","archive_url":"https://api.github.com/repos/robert-wallis/Nez/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robert-wallis/Nez/downloads","issues_url":"https://api.github.com/repos/robert-wallis/Nez/issues{/number}","pulls_url":"https://api.github.com/repos/robert-wallis/Nez/pulls{/number}","milestones_url":"https://api.github.com/repos/robert-wallis/Nez/milestones{/number}","notifications_url":"https://api.github.com/repos/robert-wallis/Nez/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robert-wallis/Nez/labels{/name}","releases_url":"https://api.github.com/repos/robert-wallis/Nez/releases{/id}","deployments_url":"https://api.github.com/repos/robert-wallis/Nez/deployments","created_at":"2017-04-27T14:22:47Z","updated_at":"2017-04-27T14:22:50Z","pushed_at":"2017-05-05T00:25:04Z","git_url":"git://github.com/robert-wallis/Nez.git","ssh_url":"git@github.com:robert-wallis/Nez.git","clone_url":"https://github.com/robert-wallis/Nez.git","svn_url":"https://github.com/robert-wallis/Nez","homepage":null,"size":11732,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"prime31:master","ref":"master","sha":"270877cd609c3c310a4d5b685a5f074774045d8a","user":{"login":"prime31","id":60377,"avatar_url":"https://avatars2.githubusercontent.com/u/60377?v=3","gravatar_id":"","url":"https://api.github.com/users/prime31","html_url":"https://github.com/prime31","followers_url":"https://api.github.com/users/prime31/followers","following_url":"https://api.github.com/users/prime31/following{/other_user}","gists_url":"https://api.github.com/users/prime31/gists{/gist_id}","starred_url":"https://api.github.com/users/prime31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prime31/subscriptions","organizations_url":"https://api.github.com/users/prime31/orgs","repos_url":"https://api.github.com/users/prime31/repos","events_url":"https://api.github.com/users/prime31/events{/privacy}","received_events_url":"https://api.github.com/users/prime31/received_events","type":"User","site_admin":false},"repo":{"id":51316128,"name":"Nez","full_name":"prime31/Nez","owner":{"login":"prime31","id":60377,"avatar_url":"https://avatars2.githubusercontent.com/u/60377?v=3","gravatar_id":"","url":"https://api.github.com/users/prime31","html_url":"https://github.com/prime31","followers_url":"https://api.github.com/users/prime31/followers","following_url":"https://api.github.com/users/prime31/following{/other_user}","gists_url":"https://api.github.com/users/prime31/gists{/gist_id}","starred_url":"https://api.github.com/users/prime31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prime31/subscriptions","organizations_url":"https://api.github.com/users/prime31/orgs","repos_url":"https://api.github.com/users/prime31/repos","events_url":"https://api.github.com/users/prime31/events{/privacy}","received_events_url":"https://api.github.com/users/prime31/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/prime31/Nez","description":"Nez is a free 2D focused framework that works with MonoGame and FNA","fork":false,"url":"https://api.github.com/repos/prime31/Nez","forks_url":"https://api.github.com/repos/prime31/Nez/forks","keys_url":"https://api.github.com/repos/prime31/Nez/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prime31/Nez/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prime31/Nez/teams","hooks_url":"https://api.github.com/repos/prime31/Nez/hooks","issue_events_url":"https://api.github.com/repos/prime31/Nez/issues/events{/number}","events_url":"https://api.github.com/repos/prime31/Nez/events","assignees_url":"https://api.github.com/repos/prime31/Nez/assignees{/user}","branches_url":"https://api.github.com/repos/prime31/Nez/branches{/branch}","tags_url":"https://api.github.com/repos/prime31/Nez/tags","blobs_url":"https://api.github.com/repos/prime31/Nez/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prime31/Nez/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prime31/Nez/git/refs{/sha}","trees_url":"https://api.github.com/repos/prime31/Nez/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prime31/Nez/statuses/{sha}","languages_url":"https://api.github.com/repos/prime31/Nez/languages","stargazers_url":"https://api.github.com/repos/prime31/Nez/stargazers","contributors_url":"https://api.github.com/repos/prime31/Nez/contributors","subscribers_url":"https://api.github.com/repos/prime31/Nez/subscribers","subscription_url":"https://api.github.com/repos/prime31/Nez/subscription","commits_url":"https://api.github.com/repos/prime31/Nez/commits{/sha}","git_commits_url":"https://api.github.com/repos/prime31/Nez/git/commits{/sha}","comments_url":"https://api.github.com/repos/prime31/Nez/comments{/number}","issue_comment_url":"https://api.github.com/repos/prime31/Nez/issues/comments{/number}","contents_url":"https://api.github.com/repos/prime31/Nez/contents/{+path}","compare_url":"https://api.github.com/repos/prime31/Nez/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prime31/Nez/merges","archive_url":"https://api.github.com/repos/prime31/Nez/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prime31/Nez/downloads","issues_url":"https://api.github.com/repos/prime31/Nez/issues{/number}","pulls_url":"https://api.github.com/repos/prime31/Nez/pulls{/number}","milestones_url":"https://api.github.com/repos/prime31/Nez/milestones{/number}","notifications_url":"https://api.github.com/repos/prime31/Nez/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prime31/Nez/labels{/name}","releases_url":"https://api.github.com/repos/prime31/Nez/releases{/id}","deployments_url":"https://api.github.com/repos/prime31/Nez/deployments","created_at":"2016-02-08T18:09:46Z","updated_at":"2017-05-04T21:13:28Z","pushed_at":"2017-05-05T04:21:13Z","git_url":"git://github.com/prime31/Nez.git","ssh_url":"git@github.com:prime31/Nez.git","clone_url":"https://github.com/prime31/Nez.git","svn_url":"https://github.com/prime31/Nez","homepage":null,"size":11721,"stargazers_count":385,"watchers_count":385,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"open_issues_count":18,"forks":78,"open_issues":18,"watchers":385,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prime31/Nez/pulls/231"},"html":{"href":"https://github.com/prime31/Nez/pull/231"},"issue":{"href":"https://api.github.com/repos/prime31/Nez/issues/231"},"comments":{"href":"https://api.github.com/repos/prime31/Nez/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/prime31/Nez/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/prime31/Nez/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prime31/Nez/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/prime31/Nez/statuses/64ef8ddccc4d9a411c2415159f0f66938a56157f"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"prime31","id":60377,"avatar_url":"https://avatars2.githubusercontent.com/u/60377?v=3","gravatar_id":"","url":"https://api.github.com/users/prime31","html_url":"https://github.com/prime31","followers_url":"https://api.github.com/users/prime31/followers","following_url":"https://api.github.com/users/prime31/following{/other_user}","gists_url":"https://api.github.com/users/prime31/gists{/gist_id}","starred_url":"https://api.github.com/users/prime31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prime31/subscriptions","organizations_url":"https://api.github.com/users/prime31/orgs","repos_url":"https://api.github.com/users/prime31/repos","events_url":"https://api.github.com/users/prime31/events{/privacy}","received_events_url":"https://api.github.com/users/prime31/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":22,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"prime31"}}