{"action":"created","comment":{"url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/comments/137497226","pull_request_review_id":61170892,"id":137497226,"diff_hunk":"@@ -1,16 +1,61 @@\n require 'spec_helper_acceptance'\n \n-describe 'nodejs class:', unless: UNSUPPORTED_PLATFORMS.include?(fact('osfamily')) do\n-  it 'runs successfully' do\n-    pp = <<-EOS\n-    class { 'nodejs': }\n-    if $::osfamily == 'RedHat' and $::operatingsystemrelease =~ /^5\\.(\\d+)/ {\n-      class { 'epel': }\n-      Class['epel'] -> Class['nodejs']\n-    }\n-    EOS\n+describe 'nodejs class:', unless: UNSUPPORTED_PLATFORMS.include?(fact('os.family')) do\n+  case fact('os.family')\n+  when 'RedHat'\n+    pkg_cmd = 'yum info nodejs | grep \"^From repo\"'\n+  when 'Debian'\n+    pkg_cmd = 'dpkg -s nodejs | grep ^Maintainer'\n+  end\n+\n+  context 'default parameters' do\n+    it 'runs successfully' do\n+      pp = <<-EOS\n+      class { 'nodejs': }\n+      if $::osfamily == 'RedHat' and $::operatingsystemrelease =~ /^5\\.(\\d+)/ {\n+        class { 'epel': }\n+        Class['epel'] -> Class['nodejs']\n+      }\n+      EOS\n+      # Run it twice and test for idempotency","path":"spec/acceptance/class_spec.rb","position":29,"original_position":29,"commit_id":"56b6d6c3b9c2950c68505caacae34db93982fef3","original_commit_id":"56b6d6c3b9c2950c68505caacae34db93982fef3","user":{"login":"ekohl","id":155810,"avatar_url":"https://avatars0.githubusercontent.com/u/155810?v=4","gravatar_id":"","url":"https://api.github.com/users/ekohl","html_url":"https://github.com/ekohl","followers_url":"https://api.github.com/users/ekohl/followers","following_url":"https://api.github.com/users/ekohl/following{/other_user}","gists_url":"https://api.github.com/users/ekohl/gists{/gist_id}","starred_url":"https://api.github.com/users/ekohl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekohl/subscriptions","organizations_url":"https://api.github.com/users/ekohl/orgs","repos_url":"https://api.github.com/users/ekohl/repos","events_url":"https://api.github.com/users/ekohl/events{/privacy}","received_events_url":"https://api.github.com/users/ekohl/received_events","type":"User","site_admin":false},"body":"I like https://github.com/theforeman/foreman-installer-modulesync/blob/0ee390953528a18b48ffdf94a97b71aa5029b1ad/moduleroot/spec/spec_helper_acceptance.rb.erb#L39-L47","created_at":"2017-09-07T10:00:44Z","updated_at":"2017-09-07T10:04:03Z","html_url":"https://github.com/voxpupuli/puppet-nodejs/pull/308#discussion_r137497226","pull_request_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/308","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/comments/137497226"},"html":{"href":"https://github.com/voxpupuli/puppet-nodejs/pull/308#discussion_r137497226"},"pull_request":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/308","id":139721217,"html_url":"https://github.com/voxpupuli/puppet-nodejs/pull/308","diff_url":"https://github.com/voxpupuli/puppet-nodejs/pull/308.diff","patch_url":"https://github.com/voxpupuli/puppet-nodejs/pull/308.patch","issue_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/issues/308","number":308,"state":"open","locked":false,"title":"Update acceptance tests, add EPEL test case for RedHat acceptance tests","user":{"login":"wyardley","id":10714426,"avatar_url":"https://avatars3.githubusercontent.com/u/10714426?v=4","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false},"body":"This does a few things:\r\n\r\n1. Updates `spec_helper_acceptance` to use `puppet_install_helper`\r\n1. Updates `.travis.yml` / `.sync.yml` to run acceptance tests in CI (CentOS 7 and Ubuntu 14)\r\n1. Verifies some extra stuff, including the package source. This will fail as of now, because of the problem mentioned in #307 / https://bugzilla.redhat.com/show_bug.cgi?id=1481008\r\n\r\nThere are still some issues that running these tests exposes. It seems like Ubuntu 16.04 installs the Ubuntu version of nodejs vs. the nodesource one; I'm not trying to fix that one (or test for it) here.","created_at":"2017-09-07T05:50:56Z","updated_at":"2017-09-07T10:04:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e24808d173182a1fe534674a2e807117d7dea6e","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/308/commits","review_comments_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/308/comments","review_comment_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/issues/308/comments","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/statuses/56b6d6c3b9c2950c68505caacae34db93982fef3","head":{"label":"wyardley:update_acceptance_tests","ref":"update_acceptance_tests","sha":"56b6d6c3b9c2950c68505caacae34db93982fef3","user":{"login":"wyardley","id":10714426,"avatar_url":"https://avatars3.githubusercontent.com/u/10714426?v=4","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false},"repo":{"id":102669767,"name":"puppet-nodejs","full_name":"wyardley/puppet-nodejs","owner":{"login":"wyardley","id":10714426,"avatar_url":"https://avatars3.githubusercontent.com/u/10714426?v=4","gravatar_id":"","url":"https://api.github.com/users/wyardley","html_url":"https://github.com/wyardley","followers_url":"https://api.github.com/users/wyardley/followers","following_url":"https://api.github.com/users/wyardley/following{/other_user}","gists_url":"https://api.github.com/users/wyardley/gists{/gist_id}","starred_url":"https://api.github.com/users/wyardley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wyardley/subscriptions","organizations_url":"https://api.github.com/users/wyardley/orgs","repos_url":"https://api.github.com/users/wyardley/repos","events_url":"https://api.github.com/users/wyardley/events{/privacy}","received_events_url":"https://api.github.com/users/wyardley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/wyardley/puppet-nodejs","description":"Puppet module to install nodejs and global npm packages","fork":true,"url":"https://api.github.com/repos/wyardley/puppet-nodejs","forks_url":"https://api.github.com/repos/wyardley/puppet-nodejs/forks","keys_url":"https://api.github.com/repos/wyardley/puppet-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wyardley/puppet-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wyardley/puppet-nodejs/teams","hooks_url":"https://api.github.com/repos/wyardley/puppet-nodejs/hooks","issue_events_url":"https://api.github.com/repos/wyardley/puppet-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/wyardley/puppet-nodejs/events","assignees_url":"https://api.github.com/repos/wyardley/puppet-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/wyardley/puppet-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/wyardley/puppet-nodejs/tags","blobs_url":"https://api.github.com/repos/wyardley/puppet-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wyardley/puppet-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wyardley/puppet-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/wyardley/puppet-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wyardley/puppet-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/wyardley/puppet-nodejs/languages","stargazers_url":"https://api.github.com/repos/wyardley/puppet-nodejs/stargazers","contributors_url":"https://api.github.com/repos/wyardley/puppet-nodejs/contributors","subscribers_url":"https://api.github.com/repos/wyardley/puppet-nodejs/subscribers","subscription_url":"https://api.github.com/repos/wyardley/puppet-nodejs/subscription","commits_url":"https://api.github.com/repos/wyardley/puppet-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/wyardley/puppet-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/wyardley/puppet-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/wyardley/puppet-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/wyardley/puppet-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/wyardley/puppet-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wyardley/puppet-nodejs/merges","archive_url":"https://api.github.com/repos/wyardley/puppet-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wyardley/puppet-nodejs/downloads","issues_url":"https://api.github.com/repos/wyardley/puppet-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/wyardley/puppet-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/wyardley/puppet-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/wyardley/puppet-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wyardley/puppet-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/wyardley/puppet-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/wyardley/puppet-nodejs/deployments","created_at":"2017-09-06T23:58:24Z","updated_at":"2017-09-06T23:58:26Z","pushed_at":"2017-09-07T05:46:04Z","git_url":"git://github.com/wyardley/puppet-nodejs.git","ssh_url":"git@github.com:wyardley/puppet-nodejs.git","clone_url":"https://github.com/wyardley/puppet-nodejs.git","svn_url":"https://github.com/wyardley/puppet-nodejs","homepage":"https://forge.puppet.com/puppet/nodejs","size":388,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"voxpupuli:master","ref":"master","sha":"8fc47fb1644ca1818da3cc834819286a93b7c20f","user":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"repo":{"id":3944274,"name":"puppet-nodejs","full_name":"voxpupuli/puppet-nodejs","owner":{"login":"voxpupuli","id":8693967,"avatar_url":"https://avatars3.githubusercontent.com/u/8693967?v=4","gravatar_id":"","url":"https://api.github.com/users/voxpupuli","html_url":"https://github.com/voxpupuli","followers_url":"https://api.github.com/users/voxpupuli/followers","following_url":"https://api.github.com/users/voxpupuli/following{/other_user}","gists_url":"https://api.github.com/users/voxpupuli/gists{/gist_id}","starred_url":"https://api.github.com/users/voxpupuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/voxpupuli/subscriptions","organizations_url":"https://api.github.com/users/voxpupuli/orgs","repos_url":"https://api.github.com/users/voxpupuli/repos","events_url":"https://api.github.com/users/voxpupuli/events{/privacy}","received_events_url":"https://api.github.com/users/voxpupuli/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/voxpupuli/puppet-nodejs","description":"Puppet module to install nodejs and global npm packages","fork":false,"url":"https://api.github.com/repos/voxpupuli/puppet-nodejs","forks_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/forks","keys_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/teams","hooks_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/hooks","issue_events_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/issues/events{/number}","events_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/events","assignees_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/assignees{/user}","branches_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/branches{/branch}","tags_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/tags","blobs_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/git/refs{/sha}","trees_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/statuses/{sha}","languages_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/languages","stargazers_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/stargazers","contributors_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/contributors","subscribers_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/subscribers","subscription_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/subscription","commits_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/commits{/sha}","git_commits_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/git/commits{/sha}","comments_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/comments{/number}","issue_comment_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/issues/comments{/number}","contents_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/contents/{+path}","compare_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/merges","archive_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/downloads","issues_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/issues{/number}","pulls_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls{/number}","milestones_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/milestones{/number}","notifications_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/labels{/name}","releases_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/releases{/id}","deployments_url":"https://api.github.com/repos/voxpupuli/puppet-nodejs/deployments","created_at":"2012-04-05T21:19:54Z","updated_at":"2017-08-07T14:54:03Z","pushed_at":"2017-09-07T05:50:57Z","git_url":"git://github.com/voxpupuli/puppet-nodejs.git","ssh_url":"git@github.com:voxpupuli/puppet-nodejs.git","clone_url":"https://github.com/voxpupuli/puppet-nodejs.git","svn_url":"https://github.com/voxpupuli/puppet-nodejs","homepage":"https://forge.puppet.com/puppet/nodejs","size":387,"stargazers_count":106,"watchers_count":106,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":247,"mirror_url":null,"open_issues_count":18,"forks":247,"open_issues":18,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/308"},"html":{"href":"https://github.com/voxpupuli/puppet-nodejs/pull/308"},"issue":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/issues/308"},"comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/voxpupuli/puppet-nodejs/statuses/56b6d6c3b9c2950c68505caacae34db93982fef3"}},"author_association":"NONE"}}
{"actor":{"display_login":"ekohl"}}