{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony-demo/pulls/comments/118723729","pull_request_review_id":40545763,"id":118723729,"diff_hunk":"@@ -1,83 +1,47 @@\n services:\n-    # First we define some basic services to make these utilities available in\n-    # the entire application\n-    slugger:\n-        class: AppBundle\\Utils\\Slugger\n-\n-    markdown:\n-        class: AppBundle\\Utils\\Markdown\n-\n-    # These are the Twig extensions that create new filters and functions for\n-    # using them in the templates\n-    app.twig.app_extension:\n-        public:    false\n-        class:     AppBundle\\Twig\\AppExtension\n-        arguments: ['@markdown', '%app_locales%']\n-        tags:\n-            - { name: twig.extension }\n-\n-    app.twig.intl_extension:\n+    # default configuration for services in *this* file\n+    _defaults:\n+        # automatically injects dependencies in your services\n+        autowire: true\n+        # automatically registers your services as commands, event subscribers, etc.\n+        autoconfigure: true\n+        # this means you cannot fetch services directly from the container via $container->get()\n+        # if you need to do this, you can override this setting on individual services\n         public: false\n-        class:  Twig_Extensions_Extension_Intl\n-        tags:\n-            - { name: twig.extension }\n-\n-    # Defining a form type as a service is only required when the form type\n-    # needs to use some other services, such as the entity manager.\n-    # See https://symfony.com/doc/current/best_practices/forms.html\n-    app.form.type.tagsinput:\n-        class: AppBundle\\Form\\Type\\TagsInputType\n-        arguments: ['@doctrine.orm.entity_manager']\n-        tags:\n-            - { name: form.type }\n-\n-    # Event Listeners are classes that listen to one or more specific events.\n-    # Those events are defined in the tags added to the service definition.\n-    # See https://symfony.com/doc/current/event_dispatcher.html#creating-an-event-listener\n-    app.redirect_to_preferred_locale_listener:\n-        class: AppBundle\\EventListener\\RedirectToPreferredLocaleListener\n-        arguments: ['@router', '%app_locales%', '%locale%']\n-        tags:\n-            - { name: kernel.event_listener, event: kernel.request, method: onKernelRequest }\n \n-    app.comment_notification:\n-        class: AppBundle\\EventListener\\CommentNotificationListener\n-        arguments: ['@mailer', '@router', '@translator', '%app.notifications.email_sender%']\n-        # The \"method\" attribute of this tag is optional and defaults to \"on + camelCasedEventName\"\n-        # If the event is \"comment.created\" the method executed by default is \"onCommentCreated()\".\n-        tags:\n-            - { name: kernel.event_listener, event: comment.created, method: onCommentCreated }\n-\n-    # Event subscribers are similar to event listeners but they don't need service tags.\n-    # Instead, the PHP class of the event subscriber includes a method that returns\n-    # the list of events listened by that class.\n-    # See https://symfony.com/doc/current/event_dispatcher.html#creating-an-event-subscriber\n-    app.requirements_subscriber:\n-        class: AppBundle\\EventListener\\CheckRequirementsSubscriber\n-        arguments: ['@doctrine.orm.entity_manager']\n-        tags:\n-            - { name: kernel.event_subscriber }\n-\n-    # To inject the voter into the security layer, you must declare it as a service and tag it with security.voter.\n-    # See https://symfony.com/doc/current/security/voters.html#configuring-the-voter\n-    app.post_voter:\n-        class: AppBundle\\Security\\PostVoter\n-        public: false\n-        tags:\n-            - { name: security.voter }\n-\n-    # Uncomment the following lines to define a service for the Post Doctrine repository.\n-    # It's not mandatory to create these services, but if you use repositories a lot,\n-    # these services simplify your code:\n-    #\n-    # app.post_repository:\n-    #     class:     Doctrine\\ORM\\EntityRepository\n-    #     factory:   ['@doctrine.orm.entity_manager', getRepository]\n-    #     arguments: [AppBundle\\Entity\\Post]\n-    #\n-    # // traditional code inside a controller\n-    # $entityManager = $this->getDoctrine()->getManager();\n-    # $posts = $entityManager->getRepository('AppBundle:Post')->findAll();\n-    #\n-    # // same code using repository services\n-    # $posts = $this->get('app.post_repository')->findAll();\n+    # makes classes in src/AppBundle available to be used as services\n+    # this creates a service per class whose id is the fully-qualified class name\n+    AppBundle\\:\n+        resource: '../../src/AppBundle/*'\n+        # you can exclude directories or files\n+        # but if a service is unused, it's removed anyway\n+        exclude: '../../src/AppBundle/{Controller,Entity,Repository}'\n+\n+    # controllers are imported separately to make sure they're public\n+    # and have a tag that allows actions to type-hint services\n+    AppBundle\\Controller\\:\n+        resource: '../../src/AppBundle/Controller'\n+        public: true\n+        tags: ['controller.service_arguments']\n+\n+    # Autowiring can't guess the constructor arguments that are not type-hinted with\n+    # classes (e.g. container parameters) so you must define those arguments explicitly\n+    AppBundle\\Command\\ListUsersCommand:\n+        arguments:\n+            $emailSender: '%app.notifications.email_sender%'\n+\n+    AppBundle\\Twig\\AppExtension:\n+        arguments:\n+            $locales: '%app_locales%'\n+\n+    AppBundle\\EventListener\\CommentNotificationSubscriber:\n+        arguments:\n+            $sender: '%app.notifications.email_sender%'\n+\n+    AppBundle\\EventListener\\RedirectToPreferredLocaleSubscriber:\n+        arguments:\n+            $locales: '%app_locales%'\n+            $defaultLocale: '%locale%'\n+\n+    Twig_Extensions_Extension_Intl:\n+        class:  Twig_Extensions_Extension_Intl","path":"app/config/services.yml","position":127,"original_position":127,"commit_id":"b04612853b53f994791d26dd60f5c64e1329c889","original_commit_id":"b04612853b53f994791d26dd60f5c64e1329c889","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars0.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"So nice! Thanks.","created_at":"2017-05-26T15:10:28Z","updated_at":"2017-05-26T15:10:28Z","html_url":"https://github.com/symfony/symfony-demo/pull/562#discussion_r118723729","pull_request_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/562","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/comments/118723729"},"html":{"href":"https://github.com/symfony/symfony-demo/pull/562#discussion_r118723729"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/562"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony-demo/pulls/562","id":121717553,"html_url":"https://github.com/symfony/symfony-demo/pull/562","diff_url":"https://github.com/symfony/symfony-demo/pull/562.diff","patch_url":"https://github.com/symfony/symfony-demo/pull/562.patch","issue_url":"https://api.github.com/repos/symfony/symfony-demo/issues/562","number":562,"state":"open","locked":false,"title":"Updated the application to Symfony 3.3.0 RC1","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars0.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"body":"This finishes #483 and uses the all the new 3.3 features for DI services.","created_at":"2017-05-22T07:54:47Z","updated_at":"2017-05-26T15:10:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2c09eade6d65a2df4a0124bf73af496844f1fc2a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/562/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/562/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony-demo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony-demo/issues/562/comments","statuses_url":"https://api.github.com/repos/symfony/symfony-demo/statuses/b04612853b53f994791d26dd60f5c64e1329c889","head":{"label":"javiereguiluz:finish_483","ref":"finish_483","sha":"b04612853b53f994791d26dd60f5c64e1329c889","user":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars0.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"repo":{"id":32811328,"name":"symfony-demo","full_name":"javiereguiluz/symfony-demo","owner":{"login":"javiereguiluz","id":73419,"avatar_url":"https://avatars0.githubusercontent.com/u/73419?v=3","gravatar_id":"","url":"https://api.github.com/users/javiereguiluz","html_url":"https://github.com/javiereguiluz","followers_url":"https://api.github.com/users/javiereguiluz/followers","following_url":"https://api.github.com/users/javiereguiluz/following{/other_user}","gists_url":"https://api.github.com/users/javiereguiluz/gists{/gist_id}","starred_url":"https://api.github.com/users/javiereguiluz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiereguiluz/subscriptions","organizations_url":"https://api.github.com/users/javiereguiluz/orgs","repos_url":"https://api.github.com/users/javiereguiluz/repos","events_url":"https://api.github.com/users/javiereguiluz/events{/privacy}","received_events_url":"https://api.github.com/users/javiereguiluz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/javiereguiluz/symfony-demo","description":null,"fork":true,"url":"https://api.github.com/repos/javiereguiluz/symfony-demo","forks_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/forks","keys_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/teams","hooks_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/hooks","issue_events_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/issues/events{/number}","events_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/events","assignees_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/assignees{/user}","branches_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/branches{/branch}","tags_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/tags","blobs_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/languages","stargazers_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/stargazers","contributors_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/contributors","subscribers_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/subscribers","subscription_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/subscription","commits_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/contents/{+path}","compare_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/merges","archive_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/downloads","issues_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/issues{/number}","pulls_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/labels{/name}","releases_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/releases{/id}","deployments_url":"https://api.github.com/repos/javiereguiluz/symfony-demo/deployments","created_at":"2015-03-24T16:39:10Z","updated_at":"2015-03-24T16:39:11Z","pushed_at":"2017-05-26T09:56:45Z","git_url":"git://github.com/javiereguiluz/symfony-demo.git","ssh_url":"git@github.com:javiereguiluz/symfony-demo.git","clone_url":"https://github.com/javiereguiluz/symfony-demo.git","svn_url":"https://github.com/javiereguiluz/symfony-demo","homepage":null,"size":3339,"stargazers_count":0,"watchers_count":0,"language":"CSS","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"1dfa804f0c26ba159652c9ad8372d39308b8958e","user":{"login":"symfony","id":143937,"avatar_url":"https://avatars0.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":32792088,"name":"symfony-demo","full_name":"symfony/symfony-demo","owner":{"login":"symfony","id":143937,"avatar_url":"https://avatars0.githubusercontent.com/u/143937?v=3","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony-demo","description":"Symfony Demo Application","fork":false,"url":"https://api.github.com/repos/symfony/symfony-demo","forks_url":"https://api.github.com/repos/symfony/symfony-demo/forks","keys_url":"https://api.github.com/repos/symfony/symfony-demo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony-demo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony-demo/teams","hooks_url":"https://api.github.com/repos/symfony/symfony-demo/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony-demo/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony-demo/events","assignees_url":"https://api.github.com/repos/symfony/symfony-demo/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony-demo/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony-demo/tags","blobs_url":"https://api.github.com/repos/symfony/symfony-demo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony-demo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony-demo/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony-demo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony-demo/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony-demo/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony-demo/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony-demo/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony-demo/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony-demo/subscription","commits_url":"https://api.github.com/repos/symfony/symfony-demo/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony-demo/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony-demo/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony-demo/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony-demo/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony-demo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony-demo/merges","archive_url":"https://api.github.com/repos/symfony/symfony-demo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony-demo/downloads","issues_url":"https://api.github.com/repos/symfony/symfony-demo/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony-demo/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony-demo/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony-demo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony-demo/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony-demo/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony-demo/deployments","created_at":"2015-03-24T10:37:08Z","updated_at":"2017-05-24T15:58:30Z","pushed_at":"2017-05-26T09:56:47Z","git_url":"git://github.com/symfony/symfony-demo.git","ssh_url":"git@github.com:symfony/symfony-demo.git","clone_url":"https://github.com/symfony/symfony-demo.git","svn_url":"https://github.com/symfony/symfony-demo","homepage":"https://symfony.com/","size":3321,"stargazers_count":789,"watchers_count":789,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":494,"mirror_url":null,"open_issues_count":22,"forks":494,"open_issues":22,"watchers":789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/562"},"html":{"href":"https://github.com/symfony/symfony-demo/pull/562"},"issue":{"href":"https://api.github.com/repos/symfony/symfony-demo/issues/562"},"comments":{"href":"https://api.github.com/repos/symfony/symfony-demo/issues/562/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/562/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony-demo/pulls/562/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony-demo/statuses/b04612853b53f994791d26dd60f5c64e1329c889"}}}}
{"actor":{"display_login":"javiereguiluz"}}