{"action":"opened","issue":{"url":"https://api.github.com/repos/mprego/NBA_Player/issues/2","repository_url":"https://api.github.com/repos/mprego/NBA_Player","labels_url":"https://api.github.com/repos/mprego/NBA_Player/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/mprego/NBA_Player/issues/2/comments","events_url":"https://api.github.com/repos/mprego/NBA_Player/issues/2/events","html_url":"https://github.com/mprego/NBA_Player/issues/2","id":273240669,"number":2,"title":"Scoring Sample for today's games don't include last game","user":{"login":"mprego","id":16636727,"avatar_url":"https://avatars0.githubusercontent.com/u/16636727?v=4","gravatar_id":"","url":"https://api.github.com/users/mprego","html_url":"https://github.com/mprego","followers_url":"https://api.github.com/users/mprego/followers","following_url":"https://api.github.com/users/mprego/following{/other_user}","gists_url":"https://api.github.com/users/mprego/gists{/gist_id}","starred_url":"https://api.github.com/users/mprego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprego/subscriptions","organizations_url":"https://api.github.com/users/mprego/orgs","repos_url":"https://api.github.com/users/mprego/repos","events_url":"https://api.github.com/users/mprego/events{/privacy}","received_events_url":"https://api.github.com/users/mprego/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-11-12T15:52:21Z","updated_at":"2017-11-12T15:52:21Z","closed_at":null,"author_association":"OWNER","body":"When `Get_todays_ss` is run, it then calls `Create_today_scoring_set` to create the scoring sample of players.  This function merely gets the latest games played for each Player and calculates the last n game metrics.  To calculate those metrics, it looks at the last completed game and then looks at the games before it.  As a result, we don't incorporate the most recent game.\r\n\r\nTo solve this, I'd make a modified perf DF that includes just the game data for today.  I think i'd do this to implement it:\r\n- rename `Create_today_scoring_set` to `Create_scoring_set`\r\n- rename `Get_todays_ss` to `Create_today_scoring_set`\r\n- in `Update_player_stats`, have a new boolean parameter about including today's games.  If true, it requires getting todays games and appends that to DF of performance\r\n- in new `Create_today_scoring_set`, also require `Update_player_stats` and `Pull_player_info`\r\n- for `Update_player_stats`, include true for new boolean parameter.  Then it merges those two DFs and then calls `filter_today_ss`"}}
{"actor":{"display_login":"mprego"}}