{"action":"created","issue":{"url":"https://api.github.com/repos/opentracing/opentracing-cpp/issues/14","repository_url":"https://api.github.com/repos/opentracing/opentracing-cpp","labels_url":"https://api.github.com/repos/opentracing/opentracing-cpp/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/opentracing/opentracing-cpp/issues/14/comments","events_url":"https://api.github.com/repos/opentracing/opentracing-cpp/issues/14/events","html_url":"https://github.com/opentracing/opentracing-cpp/pull/14","id":253748858,"number":14,"title":"Extremely basic cmake find module file to allow the use of find_package.","user":{"login":"pantoss","id":25120458,"avatar_url":"https://avatars0.githubusercontent.com/u/25120458?v=4","gravatar_id":"","url":"https://api.github.com/users/pantoss","html_url":"https://github.com/pantoss","followers_url":"https://api.github.com/users/pantoss/followers","following_url":"https://api.github.com/users/pantoss/following{/other_user}","gists_url":"https://api.github.com/users/pantoss/gists{/gist_id}","starred_url":"https://api.github.com/users/pantoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantoss/subscriptions","organizations_url":"https://api.github.com/users/pantoss/orgs","repos_url":"https://api.github.com/users/pantoss/repos","events_url":"https://api.github.com/users/pantoss/events{/privacy}","received_events_url":"https://api.github.com/users/pantoss/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2017-08-29T17:47:40Z","updated_at":"2017-08-31T18:01:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/opentracing/opentracing-cpp/pulls/14","html_url":"https://github.com/opentracing/opentracing-cpp/pull/14","diff_url":"https://github.com/opentracing/opentracing-cpp/pull/14.diff","patch_url":"https://github.com/opentracing/opentracing-cpp/pull/14.patch"},"body":"I'm not entirely sure where to put this cmake find module but I thought others might find it useful."},"comment":{"url":"https://api.github.com/repos/opentracing/opentracing-cpp/issues/comments/326375603","html_url":"https://github.com/opentracing/opentracing-cpp/pull/14#issuecomment-326375603","issue_url":"https://api.github.com/repos/opentracing/opentracing-cpp/issues/14","id":326375603,"user":{"login":"pantoss","id":25120458,"avatar_url":"https://avatars0.githubusercontent.com/u/25120458?v=4","gravatar_id":"","url":"https://api.github.com/users/pantoss","html_url":"https://github.com/pantoss","followers_url":"https://api.github.com/users/pantoss/followers","following_url":"https://api.github.com/users/pantoss/following{/other_user}","gists_url":"https://api.github.com/users/pantoss/gists{/gist_id}","starred_url":"https://api.github.com/users/pantoss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pantoss/subscriptions","organizations_url":"https://api.github.com/users/pantoss/orgs","repos_url":"https://api.github.com/users/pantoss/repos","events_url":"https://api.github.com/users/pantoss/events{/privacy}","received_events_url":"https://api.github.com/users/pantoss/received_events","type":"User","site_admin":false},"created_at":"2017-08-31T18:01:32Z","updated_at":"2017-08-31T18:01:32Z","author_association":"NONE","body":"So I've had another go. I've tried to resolve all your points. \r\n- Hope I didn't miss any places with the lower case T\r\n- I've changed the namespace to camel case but left the target as lower case to match the library. I wasn't really sure which way around was better.\r\n- Sorted formatting I think. At least it looks better than it did. Ashamed I hadn't done this already.\r\n- Hope the comments are clear enough and cover what you require.\r\n\r\nIt seems that the modern method doesn't set the <package>_INCLUDE_DIR and <package>_LIBRARIES variables. All you get is the namespace targets. I've asked about and the advice was, if it is new package then there isn't any point in adding them because there is nothing to be backwards compatible with. If you require them I think I can put them in.\r\n\r\nLet me know what you think."}}
{"actor":{"display_login":"pantoss"}}