{"action":"opened","issue":{"url":"https://api.github.com/repos/paypal/glamorous/issues/332","repository_url":"https://api.github.com/repos/paypal/glamorous","labels_url":"https://api.github.com/repos/paypal/glamorous/issues/332/labels{/name}","comments_url":"https://api.github.com/repos/paypal/glamorous/issues/332/comments","events_url":"https://api.github.com/repos/paypal/glamorous/issues/332/events","html_url":"https://github.com/paypal/glamorous/issues/332","id":259237474,"number":332,"title":"Glamor css prop w/ glamorous fails PropType validation","user":{"login":"Tibfib","id":290380,"avatar_url":"https://avatars1.githubusercontent.com/u/290380?v=4","gravatar_id":"","url":"https://api.github.com/users/Tibfib","html_url":"https://github.com/Tibfib","followers_url":"https://api.github.com/users/Tibfib/followers","following_url":"https://api.github.com/users/Tibfib/following{/other_user}","gists_url":"https://api.github.com/users/Tibfib/gists{/gist_id}","starred_url":"https://api.github.com/users/Tibfib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tibfib/subscriptions","organizations_url":"https://api.github.com/users/Tibfib/orgs","repos_url":"https://api.github.com/users/Tibfib/repos","events_url":"https://api.github.com/users/Tibfib/events{/privacy}","received_events_url":"https://api.github.com/users/Tibfib/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-09-20T17:12:00Z","updated_at":"2017-09-20T17:12:00Z","closed_at":null,"author_association":"NONE","body":"Hi there!\r\n\r\n- `glamorous` version: 4.9.2\r\n- `glamor` version: 2.20.40\r\n- `react` version: 15.6.1\r\n<!--\r\nIf you are using glamorous with typescript and believe the issue is with the\r\ndefinitions please also include the typescript version you are using\r\n- `typescript` version:\r\n-->\r\n\r\nRelevant code.\r\n\r\n```jsx\r\nimport glamorous from 'glamorous';\r\n\r\nconst GlamDiv = glamorous.div({\r\n  color: 'orange'\r\n});\r\n\r\nclass App extends Component {\r\n  render() {\r\n    return (\r\n      <div>\r\n        <div css={{ textDecoration: 'underline' }}>glamor css prop</div>\r\n        <GlamDiv>glamorous div</GlamDiv>\r\n        <GlamDiv css={{ textDecoration: 'underline' }}>\r\n          glamor css prop on glamorous div. Look at console.\r\n        </GlamDiv>\r\n      </div>\r\n    );\r\n  }\r\n}\r\n```\r\n\r\nWhat you did:\r\n\r\nI've been using glamor + glamorous and I recently discovered glamor's `css` prop (https://github.com/threepointone/glamor/blob/master/docs/createElement.md). It's awesome! However, I've found that it doesn't play well with `glamorous`. \r\n\r\n\r\nWhat happened:\r\n\r\n![screenshot](https://user-images.githubusercontent.com/290380/30656430-597b7628-9df1-11e7-8a2e-cf18406e842e.png)\r\n\r\n\r\nReproduction:\r\n\r\n<!--\r\nPlease reproduce your issue with one of the following:\r\n* javascript - https://help.glamorous.rocks\r\n* typescript - https://stackblitz.com/edit/react-ts-glamorous-help\r\nwith as minimal amount of code possible. Then paste a link below:\r\n-->\r\n\r\nHere's a reproduction in codesandbox: https://codesandbox.io/s/mqqq7k5z18\r\n\r\nI also made this repo before I realized I _could_ use codesandbox: https://github.com/Tibfib/glamor-glamorous-css-bug\r\n\r\nProblem description:\r\n\r\nWhen using both glamorous and glamor's `css` prop there is a PropTypes validation error. For all I can tell it works perfectly–it just complains about PropTypes.\r\n\r\nI do think there's a use case for using both glamorous and the css prop.\r\n\r\nSuggested solution:\r\n\r\nPlay nicely with `glamor`'s CSS prop. I think this is a `glamorous` issue but it could be an issue with how `glamor` does the `css` prop. \r\n\r\nThanks for reading!"}}
{"actor":{"display_login":"Tibfib"}}