{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/SCXcore/pulls/comments/139174052","pull_request_review_id":63072551,"id":139174052,"diff_hunk":"@@ -461,6 +462,17 @@ static int DoGenerate(const wstring & targetPath, int startDays, int endDays,\n         if (0 != rc) {\n             throw SCXCoreLib::SCXErrnoFileException(L\"chmod\", keyPath.Get(), errno, SCXSRCLOCATION);\n         }\n+\n+        struct passwd *pwd=NULL;\n+        if ((pwd = getpwnam(\"omi\")) != NULL) {","path":"source/code/shared/tools/scx_ssl_config/scx_ssl_config.cpp","position":14,"original_position":14,"commit_id":"6f6142252aadeb42f27178d36a2e3aa76d8b2460","original_commit_id":"6f6142252aadeb42f27178d36a2e3aa76d8b2460","user":{"login":"jeffaco","id":13700943,"avatar_url":"https://avatars2.githubusercontent.com/u/13700943?v=4","gravatar_id":"","url":"https://api.github.com/users/jeffaco","html_url":"https://github.com/jeffaco","followers_url":"https://api.github.com/users/jeffaco/followers","following_url":"https://api.github.com/users/jeffaco/following{/other_user}","gists_url":"https://api.github.com/users/jeffaco/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffaco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffaco/subscriptions","organizations_url":"https://api.github.com/users/jeffaco/orgs","repos_url":"https://api.github.com/users/jeffaco/repos","events_url":"https://api.github.com/users/jeffaco/events{/privacy}","received_events_url":"https://api.github.com/users/jeffaco/received_events","type":"User","site_admin":false},"body":"Weird. Check this [page](https://linux.die.net/man/3/getpwnam). Note that I have limited resources while out of town, but this appears to be a valid manpage, and it states that errno should be set to zero before calling `getpwnam` if you want to check for error afterwards.\r\n\r\nPlease check a \"real\" manpage on one of our systems and, if it agrees, please set errno to zero before the call to `getpwnam`. This is odd, as I've never noted that before. But if that's what the manpage says, then that's what the manpage says.","created_at":"2017-09-15T15:06:16Z","updated_at":"2017-09-15T15:06:35Z","html_url":"https://github.com/Microsoft/SCXcore/pull/84#discussion_r139174052","pull_request_url":"https://api.github.com/repos/Microsoft/SCXcore/pulls/84","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/SCXcore/pulls/comments/139174052"},"html":{"href":"https://github.com/Microsoft/SCXcore/pull/84#discussion_r139174052"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/SCXcore/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/SCXcore/pulls/84","id":140985994,"html_url":"https://github.com/Microsoft/SCXcore/pull/84","diff_url":"https://github.com/Microsoft/SCXcore/pull/84.diff","patch_url":"https://github.com/Microsoft/SCXcore/pull/84.patch","issue_url":"https://api.github.com/repos/Microsoft/SCXcore/issues/84","number":84,"state":"open","locked":false,"title":"Set ownership of omikey.pem file to omi:omi","user":{"login":"sarojcare","id":20577196,"avatar_url":"https://avatars3.githubusercontent.com/u/20577196?v=4","gravatar_id":"","url":"https://api.github.com/users/sarojcare","html_url":"https://github.com/sarojcare","followers_url":"https://api.github.com/users/sarojcare/followers","following_url":"https://api.github.com/users/sarojcare/following{/other_user}","gists_url":"https://api.github.com/users/sarojcare/gists{/gist_id}","starred_url":"https://api.github.com/users/sarojcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarojcare/subscriptions","organizations_url":"https://api.github.com/users/sarojcare/orgs","repos_url":"https://api.github.com/users/sarojcare/repos","events_url":"https://api.github.com/users/sarojcare/events{/privacy}","received_events_url":"https://api.github.com/users/sarojcare/received_events","type":"User","site_admin":false},"body":"This change will set ownership for certificate files to omi:omi.\r\n\r\nTest:\r\npbuild passed.\r\nInstalled on AIX 6, Solaris 5.11, HPUX 11.31 and SUSE 10. After installation omiengine comes up.\r\nVerified the ownership omikey.pem file which is set to omi:omi.\r\n","created_at":"2017-09-14T05:30:46Z","updated_at":"2017-09-15T15:06:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"838472dd2a8a849aed45a702d822dcfafa1203fd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"lilyfang","id":6433822,"avatar_url":"https://avatars0.githubusercontent.com/u/6433822?v=4","gravatar_id":"","url":"https://api.github.com/users/lilyfang","html_url":"https://github.com/lilyfang","followers_url":"https://api.github.com/users/lilyfang/followers","following_url":"https://api.github.com/users/lilyfang/following{/other_user}","gists_url":"https://api.github.com/users/lilyfang/gists{/gist_id}","starred_url":"https://api.github.com/users/lilyfang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lilyfang/subscriptions","organizations_url":"https://api.github.com/users/lilyfang/orgs","repos_url":"https://api.github.com/users/lilyfang/repos","events_url":"https://api.github.com/users/lilyfang/events{/privacy}","received_events_url":"https://api.github.com/users/lilyfang/received_events","type":"User","site_admin":false},{"login":"vimish","id":17244345,"avatar_url":"https://avatars0.githubusercontent.com/u/17244345?v=4","gravatar_id":"","url":"https://api.github.com/users/vimish","html_url":"https://github.com/vimish","followers_url":"https://api.github.com/users/vimish/followers","following_url":"https://api.github.com/users/vimish/following{/other_user}","gists_url":"https://api.github.com/users/vimish/gists{/gist_id}","starred_url":"https://api.github.com/users/vimish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vimish/subscriptions","organizations_url":"https://api.github.com/users/vimish/orgs","repos_url":"https://api.github.com/users/vimish/repos","events_url":"https://api.github.com/users/vimish/events{/privacy}","received_events_url":"https://api.github.com/users/vimish/received_events","type":"User","site_admin":false},{"login":"nirsingh","id":21101516,"avatar_url":"https://avatars1.githubusercontent.com/u/21101516?v=4","gravatar_id":"","url":"https://api.github.com/users/nirsingh","html_url":"https://github.com/nirsingh","followers_url":"https://api.github.com/users/nirsingh/followers","following_url":"https://api.github.com/users/nirsingh/following{/other_user}","gists_url":"https://api.github.com/users/nirsingh/gists{/gist_id}","starred_url":"https://api.github.com/users/nirsingh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nirsingh/subscriptions","organizations_url":"https://api.github.com/users/nirsingh/orgs","repos_url":"https://api.github.com/users/nirsingh/repos","events_url":"https://api.github.com/users/nirsingh/events{/privacy}","received_events_url":"https://api.github.com/users/nirsingh/received_events","type":"User","site_admin":false},{"login":"uashok","id":23328603,"avatar_url":"https://avatars0.githubusercontent.com/u/23328603?v=4","gravatar_id":"","url":"https://api.github.com/users/uashok","html_url":"https://github.com/uashok","followers_url":"https://api.github.com/users/uashok/followers","following_url":"https://api.github.com/users/uashok/following{/other_user}","gists_url":"https://api.github.com/users/uashok/gists{/gist_id}","starred_url":"https://api.github.com/users/uashok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/uashok/subscriptions","organizations_url":"https://api.github.com/users/uashok/orgs","repos_url":"https://api.github.com/users/uashok/repos","events_url":"https://api.github.com/users/uashok/events{/privacy}","received_events_url":"https://api.github.com/users/uashok/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/SCXcore/pulls/84/commits","review_comments_url":"https://api.github.com/repos/Microsoft/SCXcore/pulls/84/comments","review_comment_url":"https://api.github.com/repos/Microsoft/SCXcore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/SCXcore/issues/84/comments","statuses_url":"https://api.github.com/repos/Microsoft/SCXcore/statuses/6f6142252aadeb42f27178d36a2e3aa76d8b2460","head":{"label":"Microsoft:opsmgr_Non-Root_User_Support","ref":"opsmgr_Non-Root_User_Support","sha":"6f6142252aadeb42f27178d36a2e3aa76d8b2460","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":46682294,"name":"SCXcore","full_name":"Microsoft/SCXcore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/SCXcore","description":"System Center Cross Platform Provider for Operations Manager","fork":false,"url":"https://api.github.com/repos/Microsoft/SCXcore","forks_url":"https://api.github.com/repos/Microsoft/SCXcore/forks","keys_url":"https://api.github.com/repos/Microsoft/SCXcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/SCXcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/SCXcore/teams","hooks_url":"https://api.github.com/repos/Microsoft/SCXcore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/SCXcore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/SCXcore/events","assignees_url":"https://api.github.com/repos/Microsoft/SCXcore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/SCXcore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/SCXcore/tags","blobs_url":"https://api.github.com/repos/Microsoft/SCXcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/SCXcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/SCXcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/SCXcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/SCXcore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/SCXcore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/SCXcore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/SCXcore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/SCXcore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/SCXcore/subscription","commits_url":"https://api.github.com/repos/Microsoft/SCXcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/SCXcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/SCXcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/SCXcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/SCXcore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/SCXcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/SCXcore/merges","archive_url":"https://api.github.com/repos/Microsoft/SCXcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/SCXcore/downloads","issues_url":"https://api.github.com/repos/Microsoft/SCXcore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/SCXcore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/SCXcore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/SCXcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/SCXcore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/SCXcore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/SCXcore/deployments","created_at":"2015-11-22T21:58:55Z","updated_at":"2016-10-24T23:50:39Z","pushed_at":"2017-09-15T06:25:45Z","git_url":"git://github.com/Microsoft/SCXcore.git","ssh_url":"git@github.com:Microsoft/SCXcore.git","clone_url":"https://github.com/Microsoft/SCXcore.git","svn_url":"https://github.com/Microsoft/SCXcore","homepage":null,"size":2621,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"8a00c69fe00ccb7628fdf485b7776d2de3136326","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":46682294,"name":"SCXcore","full_name":"Microsoft/SCXcore","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/SCXcore","description":"System Center Cross Platform Provider for Operations Manager","fork":false,"url":"https://api.github.com/repos/Microsoft/SCXcore","forks_url":"https://api.github.com/repos/Microsoft/SCXcore/forks","keys_url":"https://api.github.com/repos/Microsoft/SCXcore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/SCXcore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/SCXcore/teams","hooks_url":"https://api.github.com/repos/Microsoft/SCXcore/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/SCXcore/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/SCXcore/events","assignees_url":"https://api.github.com/repos/Microsoft/SCXcore/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/SCXcore/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/SCXcore/tags","blobs_url":"https://api.github.com/repos/Microsoft/SCXcore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/SCXcore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/SCXcore/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/SCXcore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/SCXcore/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/SCXcore/languages","stargazers_url":"https://api.github.com/repos/Microsoft/SCXcore/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/SCXcore/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/SCXcore/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/SCXcore/subscription","commits_url":"https://api.github.com/repos/Microsoft/SCXcore/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/SCXcore/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/SCXcore/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/SCXcore/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/SCXcore/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/SCXcore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/SCXcore/merges","archive_url":"https://api.github.com/repos/Microsoft/SCXcore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/SCXcore/downloads","issues_url":"https://api.github.com/repos/Microsoft/SCXcore/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/SCXcore/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/SCXcore/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/SCXcore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/SCXcore/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/SCXcore/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/SCXcore/deployments","created_at":"2015-11-22T21:58:55Z","updated_at":"2016-10-24T23:50:39Z","pushed_at":"2017-09-15T06:25:45Z","git_url":"git://github.com/Microsoft/SCXcore.git","ssh_url":"git@github.com:Microsoft/SCXcore.git","clone_url":"https://github.com/Microsoft/SCXcore.git","svn_url":"https://github.com/Microsoft/SCXcore","homepage":null,"size":2621,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":4,"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/SCXcore/pulls/84"},"html":{"href":"https://github.com/Microsoft/SCXcore/pull/84"},"issue":{"href":"https://api.github.com/repos/Microsoft/SCXcore/issues/84"},"comments":{"href":"https://api.github.com/repos/Microsoft/SCXcore/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/SCXcore/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/SCXcore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/SCXcore/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/SCXcore/statuses/6f6142252aadeb42f27178d36a2e3aa76d8b2460"}},"author_association":"NONE"}}
{"actor":{"display_login":"jeffaco"}}