{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/fresco/issues/1677","repository_url":"https://api.github.com/repos/facebook/fresco","labels_url":"https://api.github.com/repos/facebook/fresco/issues/1677/labels{/name}","comments_url":"https://api.github.com/repos/facebook/fresco/issues/1677/comments","events_url":"https://api.github.com/repos/facebook/fresco/issues/1677/events","html_url":"https://github.com/facebook/fresco/pull/1677","id":210009676,"number":1677,"title":"Fix for #1676, setRetainImageOnFailure does not work IncreasingQualit…","user":{"login":"yunarta","id":8254829,"avatar_url":"https://avatars.githubusercontent.com/u/8254829?v=3","gravatar_id":"","url":"https://api.github.com/users/yunarta","html_url":"https://github.com/yunarta","followers_url":"https://api.github.com/users/yunarta/followers","following_url":"https://api.github.com/users/yunarta/following{/other_user}","gists_url":"https://api.github.com/users/yunarta/gists{/gist_id}","starred_url":"https://api.github.com/users/yunarta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunarta/subscriptions","organizations_url":"https://api.github.com/users/yunarta/orgs","repos_url":"https://api.github.com/users/yunarta/repos","events_url":"https://api.github.com/users/yunarta/events{/privacy}","received_events_url":"https://api.github.com/users/yunarta/received_events","type":"User","site_admin":false},"labels":[{"id":196858477,"url":"https://api.github.com/repos/facebook/fresco/labels/CLA%20Signed","name":"CLA Signed","color":"bfe5bf","default":false},{"id":276214983,"url":"https://api.github.com/repos/facebook/fresco/labels/GH%20Review:%20review-needed","name":"GH Review: review-needed","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-02-24T10:17:48Z","updated_at":"2017-02-27T02:54:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/facebook/fresco/pulls/1677","html_url":"https://github.com/facebook/fresco/pull/1677","diff_url":"https://github.com/facebook/fresco/pull/1677.diff","patch_url":"https://github.com/facebook/fresco/pull/1677.patch"},"body":"By delaying the error until all the image data source is completed, now retain image on failure is working, however now the side effect is the retry image is not drawn.\r\n\r\nShould the retry image to be drawn above failed image? "},"comment":{"url":"https://api.github.com/repos/facebook/fresco/issues/comments/282615909","html_url":"https://github.com/facebook/fresco/pull/1677#issuecomment-282615909","issue_url":"https://api.github.com/repos/facebook/fresco/issues/1677","id":282615909,"user":{"login":"yunarta","id":8254829,"avatar_url":"https://avatars.githubusercontent.com/u/8254829?v=3","gravatar_id":"","url":"https://api.github.com/users/yunarta","html_url":"https://github.com/yunarta","followers_url":"https://api.github.com/users/yunarta/followers","following_url":"https://api.github.com/users/yunarta/following{/other_user}","gists_url":"https://api.github.com/users/yunarta/gists{/gist_id}","starred_url":"https://api.github.com/users/yunarta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yunarta/subscriptions","organizations_url":"https://api.github.com/users/yunarta/orgs","repos_url":"https://api.github.com/users/yunarta/repos","events_url":"https://api.github.com/users/yunarta/events{/privacy}","received_events_url":"https://api.github.com/users/yunarta/received_events","type":"User","site_admin":false},"created_at":"2017-02-27T02:54:01Z","updated_at":"2017-02-27T02:54:01Z","body":"Seems that the test failed due to new changes that will send all the increasing quality result regardless of the highest quality failed state.\r\n\r\nHowever this is required is set retain images to be fixed.\r\n\r\nThis situation actually can be solve easily with Reactive programming, since the caller can define whether they wanted to delay the error or not.\r\n\r\nAny advice?"}}
{"actor":{"display_login":"yunarta"}}