{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/151869137","pull_request_review_id":77645530,"id":151869137,"diff_hunk":"@@ -0,0 +1,78 @@\n+\"\"\"Support for ADS binary sensors.\"\"\"\n+\n+import logging\n+\n+import voluptuous as vol\n+\n+from homeassistant.components.binary_sensor import BinarySensorDevice, \\\n+    PLATFORM_SCHEMA, DEVICE_CLASSES_SCHEMA\n+from homeassistant.components.ads import DATA_ADS, CONF_ADSVAR\n+from homeassistant.const import CONF_NAME, CONF_DEVICE_CLASS\n+import homeassistant.helpers.config_validation as cv\n+\n+\n+_LOGGER = logging.getLogger(__name__)\n+\n+DEPENDENCIES = ['ads']\n+DEFAULT_NAME = 'ADS binary sensor'\n+\n+\n+PLATFORM_SCHEMA = PLATFORM_SCHEMA.extend({\n+    vol.Required(CONF_ADSVAR): cv.string,\n+    vol.Optional(CONF_NAME, default=DEFAULT_NAME): cv.string,\n+    vol.Optional(CONF_DEVICE_CLASS): DEVICE_CLASSES_SCHEMA,\n+})\n+\n+\n+def setup_platform(hass, config, add_devices, discovery_info=None):\n+    \"\"\"Set up the Binary Sensor platform for ADS.\"\"\"\n+    ads_hub = hass.data.get(DATA_ADS)\n+    if not ads_hub:\n+        return False\n+\n+    adsvar = config.get(CONF_ADSVAR)\n+    name = config.get(CONF_NAME)\n+    device_class = config.get(CONF_DEVICE_CLASS)\n+\n+    ads_sensor = AdsBinarySensor(ads_hub, name, adsvar, device_class)\n+    add_devices([ads_sensor], True)\n+\n+    ads_hub.add_device_notification(adsvar, ads_hub.PLCTYPE_BOOL,","path":"homeassistant/components/binary_sensor/ads.py","position":40,"original_position":40,"commit_id":"7da420f82385a4a5c66a929af7025c00ed197e86","original_commit_id":"7da420f82385a4a5c66a929af7025c00ed197e86","user":{"login":"MartinHjelmare","id":3181692,"avatar_url":"https://avatars0.githubusercontent.com/u/3181692?v=4","gravatar_id":"","url":"https://api.github.com/users/MartinHjelmare","html_url":"https://github.com/MartinHjelmare","followers_url":"https://api.github.com/users/MartinHjelmare/followers","following_url":"https://api.github.com/users/MartinHjelmare/following{/other_user}","gists_url":"https://api.github.com/users/MartinHjelmare/gists{/gist_id}","starred_url":"https://api.github.com/users/MartinHjelmare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MartinHjelmare/subscriptions","organizations_url":"https://api.github.com/users/MartinHjelmare/orgs","repos_url":"https://api.github.com/users/MartinHjelmare/repos","events_url":"https://api.github.com/users/MartinHjelmare/events{/privacy}","received_events_url":"https://api.github.com/users/MartinHjelmare/received_events","type":"User","site_admin":false},"body":"To avoid errors in the entity callback. the registration of the callback should move to a method on the entity called `async_added_to_hass` which is a coroutine that will be called when the entity has been added to home assistant. See eg:\r\nhttps://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/android_ip_webcam.py#L259","created_at":"2017-11-19T16:05:31Z","updated_at":"2017-11-19T16:39:58Z","html_url":"https://github.com/home-assistant/home-assistant/pull/10142#discussion_r151869137","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/10142","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/151869137"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/10142#discussion_r151869137"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/10142"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/10142","id":148729982,"html_url":"https://github.com/home-assistant/home-assistant/pull/10142","diff_url":"https://github.com/home-assistant/home-assistant/pull/10142.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/10142.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/10142","number":10142,"state":"open","locked":false,"title":"add ADS component","user":{"login":"MrLeeh","id":4641542,"avatar_url":"https://avatars1.githubusercontent.com/u/4641542?v=4","gravatar_id":"","url":"https://api.github.com/users/MrLeeh","html_url":"https://github.com/MrLeeh","followers_url":"https://api.github.com/users/MrLeeh/followers","following_url":"https://api.github.com/users/MrLeeh/following{/other_user}","gists_url":"https://api.github.com/users/MrLeeh/gists{/gist_id}","starred_url":"https://api.github.com/users/MrLeeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrLeeh/subscriptions","organizations_url":"https://api.github.com/users/MrLeeh/orgs","repos_url":"https://api.github.com/users/MrLeeh/repos","events_url":"https://api.github.com/users/MrLeeh/events{/privacy}","received_events_url":"https://api.github.com/users/MrLeeh/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nThis PR aims to implement a new component called *ADS* which allows to communicate with devices using the *ADS* protocol. Beckhoff® uses this standard to allow communication with its TwinCAT® devices (e.g. PLCs, Soft-PLCs). With this new component a plc based on TwinCAT® can be integrated in your home automation solution.\r\n\r\nThe ADS component adds the platforms *sensor.ads*, *binary_sensor.ads*, *light.ads* and *switch.ads*.\r\n\r\n**Related issue (if applicable):**\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#3777\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nsensor:\r\n  - platform: ads\r\n    adsvar: .i1\r\n\r\nbinary_sensor:\r\n  - platform: ads\r\n    adsvar: .b1\r\n\r\nlight:\r\n  - platform: ads\r\n    adsvar: .b1\r\n\r\nswitch:\r\n  - platform: ads\r\n    adsvar: b1\r\n\r\nads:\r\n  device: 127.0.0.1.1.1\r\n  port: 48898\r\n\r\n```\r\n\r\n## Checklist:\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [x] New dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [x] New files were added to `.coveragerc`.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2017-10-25T17:19:19Z","updated_at":"2017-11-19T16:39:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58a184a468c25bc1ff7173b0294124fb04522055","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrey-git","id":5478779,"avatar_url":"https://avatars0.githubusercontent.com/u/5478779?v=4","gravatar_id":"","url":"https://api.github.com/users/andrey-git","html_url":"https://github.com/andrey-git","followers_url":"https://api.github.com/users/andrey-git/followers","following_url":"https://api.github.com/users/andrey-git/following{/other_user}","gists_url":"https://api.github.com/users/andrey-git/gists{/gist_id}","starred_url":"https://api.github.com/users/andrey-git/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrey-git/subscriptions","organizations_url":"https://api.github.com/users/andrey-git/orgs","repos_url":"https://api.github.com/users/andrey-git/repos","events_url":"https://api.github.com/users/andrey-git/events{/privacy}","received_events_url":"https://api.github.com/users/andrey-git/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/10142/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/10142/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/10142/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/7da420f82385a4a5c66a929af7025c00ed197e86","head":{"label":"MrLeeh:ads","ref":"ads","sha":"7da420f82385a4a5c66a929af7025c00ed197e86","user":{"login":"MrLeeh","id":4641542,"avatar_url":"https://avatars1.githubusercontent.com/u/4641542?v=4","gravatar_id":"","url":"https://api.github.com/users/MrLeeh","html_url":"https://github.com/MrLeeh","followers_url":"https://api.github.com/users/MrLeeh/followers","following_url":"https://api.github.com/users/MrLeeh/following{/other_user}","gists_url":"https://api.github.com/users/MrLeeh/gists{/gist_id}","starred_url":"https://api.github.com/users/MrLeeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrLeeh/subscriptions","organizations_url":"https://api.github.com/users/MrLeeh/orgs","repos_url":"https://api.github.com/users/MrLeeh/repos","events_url":"https://api.github.com/users/MrLeeh/events{/privacy}","received_events_url":"https://api.github.com/users/MrLeeh/received_events","type":"User","site_admin":false},"repo":{"id":103428987,"name":"home-assistant","full_name":"MrLeeh/home-assistant","owner":{"login":"MrLeeh","id":4641542,"avatar_url":"https://avatars1.githubusercontent.com/u/4641542?v=4","gravatar_id":"","url":"https://api.github.com/users/MrLeeh","html_url":"https://github.com/MrLeeh","followers_url":"https://api.github.com/users/MrLeeh/followers","following_url":"https://api.github.com/users/MrLeeh/following{/other_user}","gists_url":"https://api.github.com/users/MrLeeh/gists{/gist_id}","starred_url":"https://api.github.com/users/MrLeeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrLeeh/subscriptions","organizations_url":"https://api.github.com/users/MrLeeh/orgs","repos_url":"https://api.github.com/users/MrLeeh/repos","events_url":"https://api.github.com/users/MrLeeh/events{/privacy}","received_events_url":"https://api.github.com/users/MrLeeh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrLeeh/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/MrLeeh/home-assistant","forks_url":"https://api.github.com/repos/MrLeeh/home-assistant/forks","keys_url":"https://api.github.com/repos/MrLeeh/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrLeeh/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrLeeh/home-assistant/teams","hooks_url":"https://api.github.com/repos/MrLeeh/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/MrLeeh/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/MrLeeh/home-assistant/events","assignees_url":"https://api.github.com/repos/MrLeeh/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/MrLeeh/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/MrLeeh/home-assistant/tags","blobs_url":"https://api.github.com/repos/MrLeeh/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrLeeh/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrLeeh/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrLeeh/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrLeeh/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/MrLeeh/home-assistant/languages","stargazers_url":"https://api.github.com/repos/MrLeeh/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/MrLeeh/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/MrLeeh/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/MrLeeh/home-assistant/subscription","commits_url":"https://api.github.com/repos/MrLeeh/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrLeeh/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrLeeh/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrLeeh/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrLeeh/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/MrLeeh/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrLeeh/home-assistant/merges","archive_url":"https://api.github.com/repos/MrLeeh/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrLeeh/home-assistant/downloads","issues_url":"https://api.github.com/repos/MrLeeh/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/MrLeeh/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/MrLeeh/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/MrLeeh/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrLeeh/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/MrLeeh/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/MrLeeh/home-assistant/deployments","created_at":"2017-09-13T17:18:24Z","updated_at":"2017-09-13T17:18:32Z","pushed_at":"2017-11-19T14:03:36Z","git_url":"git://github.com/MrLeeh/home-assistant.git","ssh_url":"git@github.com:MrLeeh/home-assistant.git","clone_url":"https://github.com/MrLeeh/home-assistant.git","svn_url":"https://github.com/MrLeeh/home-assistant","homepage":"https://home-assistant.io","size":73455,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"7987065ad753242b6155c7d1046be9b8adefca99","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2017-11-19T12:56:52Z","pushed_at":"2017-11-19T16:05:15Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":75334,"stargazers_count":10309,"watchers_count":10309,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2938,"mirror_url":null,"archived":false,"open_issues_count":607,"forks":2938,"open_issues":607,"watchers":10309,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/10142"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/10142"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/10142"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/10142/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/10142/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/10142/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/7da420f82385a4a5c66a929af7025c00ed197e86"}},"author_association":"NONE"}}
{"actor":{"display_login":"MartinHjelmare"}}