{"action":"closed","number":4935,"pull_request":{"url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4935","id":114950477,"html_url":"https://github.com/ReactTraining/react-router/pull/4935","diff_url":"https://github.com/ReactTraining/react-router/pull/4935.diff","patch_url":"https://github.com/ReactTraining/react-router/pull/4935.patch","issue_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4935","number":4935,"state":"closed","locked":false,"title":"Fix linter errors","user":{"login":"Calyhre","id":3692274,"avatar_url":"https://avatars1.githubusercontent.com/u/3692274?v=3","gravatar_id":"","url":"https://api.github.com/users/Calyhre","html_url":"https://github.com/Calyhre","followers_url":"https://api.github.com/users/Calyhre/followers","following_url":"https://api.github.com/users/Calyhre/following{/other_user}","gists_url":"https://api.github.com/users/Calyhre/gists{/gist_id}","starred_url":"https://api.github.com/users/Calyhre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Calyhre/subscriptions","organizations_url":"https://api.github.com/users/Calyhre/orgs","repos_url":"https://api.github.com/users/Calyhre/repos","events_url":"https://api.github.com/users/Calyhre/events{/privacy}","received_events_url":"https://api.github.com/users/Calyhre/received_events","type":"User","site_admin":false},"body":"Couple of small linter errors fixed.\r\n\r\nI also updated eslint for the main package in order to took advantage of the new no-unuser-vars option, ignorerestsiblings, and allow the omit pattern used like here: https://github.com/Calyhre/react-router/blob/master/packages/react-router/modules/StaticRouter.js#L114","created_at":"2017-04-08T16:03:02Z","updated_at":"2017-04-09T13:45:01Z","closed_at":"2017-04-09T13:45:01Z","merged_at":"2017-04-09T13:45:01Z","merge_commit_sha":"46395dcd2fd26710a7a441425b097f91717d8155","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4935/commits","review_comments_url":"https://api.github.com/repos/ReactTraining/react-router/pulls/4935/comments","review_comment_url":"https://api.github.com/repos/ReactTraining/react-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReactTraining/react-router/issues/4935/comments","statuses_url":"https://api.github.com/repos/ReactTraining/react-router/statuses/341f4712f710f2703ba0a16014387772215d5b4f","head":{"label":"Calyhre:fix/linter-errors","ref":"fix/linter-errors","sha":"341f4712f710f2703ba0a16014387772215d5b4f","user":{"login":"Calyhre","id":3692274,"avatar_url":"https://avatars1.githubusercontent.com/u/3692274?v=3","gravatar_id":"","url":"https://api.github.com/users/Calyhre","html_url":"https://github.com/Calyhre","followers_url":"https://api.github.com/users/Calyhre/followers","following_url":"https://api.github.com/users/Calyhre/following{/other_user}","gists_url":"https://api.github.com/users/Calyhre/gists{/gist_id}","starred_url":"https://api.github.com/users/Calyhre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Calyhre/subscriptions","organizations_url":"https://api.github.com/users/Calyhre/orgs","repos_url":"https://api.github.com/users/Calyhre/repos","events_url":"https://api.github.com/users/Calyhre/events{/privacy}","received_events_url":"https://api.github.com/users/Calyhre/received_events","type":"User","site_admin":false},"repo":{"id":87640264,"name":"react-router","full_name":"Calyhre/react-router","owner":{"login":"Calyhre","id":3692274,"avatar_url":"https://avatars1.githubusercontent.com/u/3692274?v=3","gravatar_id":"","url":"https://api.github.com/users/Calyhre","html_url":"https://github.com/Calyhre","followers_url":"https://api.github.com/users/Calyhre/followers","following_url":"https://api.github.com/users/Calyhre/following{/other_user}","gists_url":"https://api.github.com/users/Calyhre/gists{/gist_id}","starred_url":"https://api.github.com/users/Calyhre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Calyhre/subscriptions","organizations_url":"https://api.github.com/users/Calyhre/orgs","repos_url":"https://api.github.com/users/Calyhre/repos","events_url":"https://api.github.com/users/Calyhre/events{/privacy}","received_events_url":"https://api.github.com/users/Calyhre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Calyhre/react-router","description":"Declarative routing for React","fork":true,"url":"https://api.github.com/repos/Calyhre/react-router","forks_url":"https://api.github.com/repos/Calyhre/react-router/forks","keys_url":"https://api.github.com/repos/Calyhre/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Calyhre/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Calyhre/react-router/teams","hooks_url":"https://api.github.com/repos/Calyhre/react-router/hooks","issue_events_url":"https://api.github.com/repos/Calyhre/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/Calyhre/react-router/events","assignees_url":"https://api.github.com/repos/Calyhre/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/Calyhre/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/Calyhre/react-router/tags","blobs_url":"https://api.github.com/repos/Calyhre/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Calyhre/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Calyhre/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/Calyhre/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Calyhre/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/Calyhre/react-router/languages","stargazers_url":"https://api.github.com/repos/Calyhre/react-router/stargazers","contributors_url":"https://api.github.com/repos/Calyhre/react-router/contributors","subscribers_url":"https://api.github.com/repos/Calyhre/react-router/subscribers","subscription_url":"https://api.github.com/repos/Calyhre/react-router/subscription","commits_url":"https://api.github.com/repos/Calyhre/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/Calyhre/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/Calyhre/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/Calyhre/react-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/Calyhre/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/Calyhre/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Calyhre/react-router/merges","archive_url":"https://api.github.com/repos/Calyhre/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Calyhre/react-router/downloads","issues_url":"https://api.github.com/repos/Calyhre/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/Calyhre/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/Calyhre/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/Calyhre/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Calyhre/react-router/labels{/name}","releases_url":"https://api.github.com/repos/Calyhre/react-router/releases{/id}","deployments_url":"https://api.github.com/repos/Calyhre/react-router/deployments","created_at":"2017-04-08T14:36:56Z","updated_at":"2017-04-08T14:37:00Z","pushed_at":"2017-04-08T16:00:17Z","git_url":"git://github.com/Calyhre/react-router.git","ssh_url":"git@github.com:Calyhre/react-router.git","clone_url":"https://github.com/Calyhre/react-router.git","svn_url":"https://github.com/Calyhre/react-router","homepage":"https://reacttraining.com/react-router/","size":7026,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ReactTraining:master","ref":"master","sha":"3bd61b32184f98b73188dc593ff46483836f3794","user":{"login":"ReactTraining","id":11823761,"avatar_url":"https://avatars2.githubusercontent.com/u/11823761?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactTraining","html_url":"https://github.com/ReactTraining","followers_url":"https://api.github.com/users/ReactTraining/followers","following_url":"https://api.github.com/users/ReactTraining/following{/other_user}","gists_url":"https://api.github.com/users/ReactTraining/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactTraining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactTraining/subscriptions","organizations_url":"https://api.github.com/users/ReactTraining/orgs","repos_url":"https://api.github.com/users/ReactTraining/repos","events_url":"https://api.github.com/users/ReactTraining/events{/privacy}","received_events_url":"https://api.github.com/users/ReactTraining/received_events","type":"Organization","site_admin":false},"repo":{"id":19872456,"name":"react-router","full_name":"ReactTraining/react-router","owner":{"login":"ReactTraining","id":11823761,"avatar_url":"https://avatars2.githubusercontent.com/u/11823761?v=3","gravatar_id":"","url":"https://api.github.com/users/ReactTraining","html_url":"https://github.com/ReactTraining","followers_url":"https://api.github.com/users/ReactTraining/followers","following_url":"https://api.github.com/users/ReactTraining/following{/other_user}","gists_url":"https://api.github.com/users/ReactTraining/gists{/gist_id}","starred_url":"https://api.github.com/users/ReactTraining/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReactTraining/subscriptions","organizations_url":"https://api.github.com/users/ReactTraining/orgs","repos_url":"https://api.github.com/users/ReactTraining/repos","events_url":"https://api.github.com/users/ReactTraining/events{/privacy}","received_events_url":"https://api.github.com/users/ReactTraining/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReactTraining/react-router","description":"Declarative routing for React","fork":false,"url":"https://api.github.com/repos/ReactTraining/react-router","forks_url":"https://api.github.com/repos/ReactTraining/react-router/forks","keys_url":"https://api.github.com/repos/ReactTraining/react-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReactTraining/react-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReactTraining/react-router/teams","hooks_url":"https://api.github.com/repos/ReactTraining/react-router/hooks","issue_events_url":"https://api.github.com/repos/ReactTraining/react-router/issues/events{/number}","events_url":"https://api.github.com/repos/ReactTraining/react-router/events","assignees_url":"https://api.github.com/repos/ReactTraining/react-router/assignees{/user}","branches_url":"https://api.github.com/repos/ReactTraining/react-router/branches{/branch}","tags_url":"https://api.github.com/repos/ReactTraining/react-router/tags","blobs_url":"https://api.github.com/repos/ReactTraining/react-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReactTraining/react-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReactTraining/react-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReactTraining/react-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReactTraining/react-router/statuses/{sha}","languages_url":"https://api.github.com/repos/ReactTraining/react-router/languages","stargazers_url":"https://api.github.com/repos/ReactTraining/react-router/stargazers","contributors_url":"https://api.github.com/repos/ReactTraining/react-router/contributors","subscribers_url":"https://api.github.com/repos/ReactTraining/react-router/subscribers","subscription_url":"https://api.github.com/repos/ReactTraining/react-router/subscription","commits_url":"https://api.github.com/repos/ReactTraining/react-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReactTraining/react-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReactTraining/react-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReactTraining/react-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReactTraining/react-router/contents/{+path}","compare_url":"https://api.github.com/repos/ReactTraining/react-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReactTraining/react-router/merges","archive_url":"https://api.github.com/repos/ReactTraining/react-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReactTraining/react-router/downloads","issues_url":"https://api.github.com/repos/ReactTraining/react-router/issues{/number}","pulls_url":"https://api.github.com/repos/ReactTraining/react-router/pulls{/number}","milestones_url":"https://api.github.com/repos/ReactTraining/react-router/milestones{/number}","notifications_url":"https://api.github.com/repos/ReactTraining/react-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReactTraining/react-router/labels{/name}","releases_url":"https://api.github.com/repos/ReactTraining/react-router/releases{/id}","deployments_url":"https://api.github.com/repos/ReactTraining/react-router/deployments","created_at":"2014-05-16T22:22:51Z","updated_at":"2017-04-09T13:31:28Z","pushed_at":"2017-04-09T13:45:01Z","git_url":"git://github.com/ReactTraining/react-router.git","ssh_url":"git@github.com:ReactTraining/react-router.git","clone_url":"https://github.com/ReactTraining/react-router.git","svn_url":"https://github.com/ReactTraining/react-router","homepage":"https://reacttraining.com/react-router/","size":7013,"stargazers_count":21240,"watchers_count":21240,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5039,"mirror_url":null,"open_issues_count":32,"forks":5039,"open_issues":32,"watchers":21240,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/4935"},"html":{"href":"https://github.com/ReactTraining/react-router/pull/4935"},"issue":{"href":"https://api.github.com/repos/ReactTraining/react-router/issues/4935"},"comments":{"href":"https://api.github.com/repos/ReactTraining/react-router/issues/4935/comments"},"review_comments":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/4935/comments"},"review_comment":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReactTraining/react-router/pulls/4935/commits"},"statuses":{"href":"https://api.github.com/repos/ReactTraining/react-router/statuses/341f4712f710f2703ba0a16014387772215d5b4f"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"timdorr","id":17882,"avatar_url":"https://avatars1.githubusercontent.com/u/17882?v=3","gravatar_id":"","url":"https://api.github.com/users/timdorr","html_url":"https://github.com/timdorr","followers_url":"https://api.github.com/users/timdorr/followers","following_url":"https://api.github.com/users/timdorr/following{/other_user}","gists_url":"https://api.github.com/users/timdorr/gists{/gist_id}","starred_url":"https://api.github.com/users/timdorr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timdorr/subscriptions","organizations_url":"https://api.github.com/users/timdorr/orgs","repos_url":"https://api.github.com/users/timdorr/repos","events_url":"https://api.github.com/users/timdorr/events{/privacy}","received_events_url":"https://api.github.com/users/timdorr/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":8,"changed_files":4}}
{"actor":{"display_login":"timdorr"}}