{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio-py/pulls/comments/142034223","pull_request_review_id":66341149,"id":142034223,"diff_hunk":"@@ -602,6 +602,8 @@ def test_get_bucket_policy(client, log_output):\n         policy_name = client.get_bucket_policy(bucket_name)\n         if policy_name != Policy.NONE:\n             raise ValueError('Policy name is invalid: ' + policy_name)\n+    except APINotImplemented:\n+        pass","path":"tests/functional/tests.py","position":14,"original_position":14,"commit_id":"1429c1b78fe3146a892f9aef52bb773e268fcdde","original_commit_id":"1429c1b78fe3146a892f9aef52bb773e268fcdde","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars1.githubusercontent.com/u/283197?v=4","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"body":"so @balamurugana, do you recommend any change in this PR ?","created_at":"2017-10-01T16:37:52Z","updated_at":"2017-10-01T16:37:52Z","html_url":"https://github.com/minio/minio-py/pull/582#discussion_r142034223","pull_request_url":"https://api.github.com/repos/minio/minio-py/pulls/582","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/minio/minio-py/pulls/comments/142034223"},"html":{"href":"https://github.com/minio/minio-py/pull/582#discussion_r142034223"},"pull_request":{"href":"https://api.github.com/repos/minio/minio-py/pulls/582"}},"in_reply_to_id":141711132},"pull_request":{"url":"https://api.github.com/repos/minio/minio-py/pulls/582","id":143533339,"html_url":"https://github.com/minio/minio-py/pull/582","diff_url":"https://github.com/minio/minio-py/pull/582.diff","patch_url":"https://github.com/minio/minio-py/pull/582.patch","issue_url":"https://api.github.com/repos/minio/minio-py/issues/582","number":582,"state":"open","locked":false,"title":"tests: Ignore APINotImplemented for get/set bucket policy","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars1.githubusercontent.com/u/283197?v=4","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"body":"We need this temporary behavior is Mint can succeed. This will be revert\r\nonce bucket policy will be implemented in all gateways.\r\n\r\nFixes #579 ","created_at":"2017-09-28T00:57:17Z","updated_at":"2017-10-01T16:37:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5243d54130a4c015e4e9d52a736d0888bf6adc5","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio-py/pulls/582/commits","review_comments_url":"https://api.github.com/repos/minio/minio-py/pulls/582/comments","review_comment_url":"https://api.github.com/repos/minio/minio-py/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio-py/issues/582/comments","statuses_url":"https://api.github.com/repos/minio/minio-py/statuses/1429c1b78fe3146a892f9aef52bb773e268fcdde","head":{"label":"vadmeste:issue/579","ref":"issue/579","sha":"1429c1b78fe3146a892f9aef52bb773e268fcdde","user":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars1.githubusercontent.com/u/283197?v=4","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"repo":{"id":73414185,"name":"minio-py","full_name":"vadmeste/minio-py","owner":{"login":"vadmeste","id":283197,"avatar_url":"https://avatars1.githubusercontent.com/u/283197?v=4","gravatar_id":"","url":"https://api.github.com/users/vadmeste","html_url":"https://github.com/vadmeste","followers_url":"https://api.github.com/users/vadmeste/followers","following_url":"https://api.github.com/users/vadmeste/following{/other_user}","gists_url":"https://api.github.com/users/vadmeste/gists{/gist_id}","starred_url":"https://api.github.com/users/vadmeste/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vadmeste/subscriptions","organizations_url":"https://api.github.com/users/vadmeste/orgs","repos_url":"https://api.github.com/users/vadmeste/repos","events_url":"https://api.github.com/users/vadmeste/events{/privacy}","received_events_url":"https://api.github.com/users/vadmeste/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vadmeste/minio-py","description":"Minio Python Library for Amazon S3 compatible cloud storage","fork":true,"url":"https://api.github.com/repos/vadmeste/minio-py","forks_url":"https://api.github.com/repos/vadmeste/minio-py/forks","keys_url":"https://api.github.com/repos/vadmeste/minio-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vadmeste/minio-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vadmeste/minio-py/teams","hooks_url":"https://api.github.com/repos/vadmeste/minio-py/hooks","issue_events_url":"https://api.github.com/repos/vadmeste/minio-py/issues/events{/number}","events_url":"https://api.github.com/repos/vadmeste/minio-py/events","assignees_url":"https://api.github.com/repos/vadmeste/minio-py/assignees{/user}","branches_url":"https://api.github.com/repos/vadmeste/minio-py/branches{/branch}","tags_url":"https://api.github.com/repos/vadmeste/minio-py/tags","blobs_url":"https://api.github.com/repos/vadmeste/minio-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vadmeste/minio-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vadmeste/minio-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/vadmeste/minio-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vadmeste/minio-py/statuses/{sha}","languages_url":"https://api.github.com/repos/vadmeste/minio-py/languages","stargazers_url":"https://api.github.com/repos/vadmeste/minio-py/stargazers","contributors_url":"https://api.github.com/repos/vadmeste/minio-py/contributors","subscribers_url":"https://api.github.com/repos/vadmeste/minio-py/subscribers","subscription_url":"https://api.github.com/repos/vadmeste/minio-py/subscription","commits_url":"https://api.github.com/repos/vadmeste/minio-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/vadmeste/minio-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/vadmeste/minio-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/vadmeste/minio-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/vadmeste/minio-py/contents/{+path}","compare_url":"https://api.github.com/repos/vadmeste/minio-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vadmeste/minio-py/merges","archive_url":"https://api.github.com/repos/vadmeste/minio-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vadmeste/minio-py/downloads","issues_url":"https://api.github.com/repos/vadmeste/minio-py/issues{/number}","pulls_url":"https://api.github.com/repos/vadmeste/minio-py/pulls{/number}","milestones_url":"https://api.github.com/repos/vadmeste/minio-py/milestones{/number}","notifications_url":"https://api.github.com/repos/vadmeste/minio-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vadmeste/minio-py/labels{/name}","releases_url":"https://api.github.com/repos/vadmeste/minio-py/releases{/id}","deployments_url":"https://api.github.com/repos/vadmeste/minio-py/deployments","created_at":"2016-11-10T19:29:02Z","updated_at":"2016-11-10T19:29:04Z","pushed_at":"2017-09-28T00:56:34Z","git_url":"git://github.com/vadmeste/minio-py.git","ssh_url":"git@github.com:vadmeste/minio-py.git","clone_url":"https://github.com/vadmeste/minio-py.git","svn_url":"https://github.com/vadmeste/minio-py","homepage":"http://minio.io/downloads/#minio-sdk","size":1041,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"8528b7f3be11ec34efe63a3bd1d8791a6dfc0996","user":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":37571213,"name":"minio-py","full_name":"minio/minio-py","owner":{"login":"minio","id":695951,"avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minio/minio-py","description":"Minio Client SDK for Python","fork":false,"url":"https://api.github.com/repos/minio/minio-py","forks_url":"https://api.github.com/repos/minio/minio-py/forks","keys_url":"https://api.github.com/repos/minio/minio-py/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio-py/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio-py/teams","hooks_url":"https://api.github.com/repos/minio/minio-py/hooks","issue_events_url":"https://api.github.com/repos/minio/minio-py/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio-py/events","assignees_url":"https://api.github.com/repos/minio/minio-py/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio-py/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio-py/tags","blobs_url":"https://api.github.com/repos/minio/minio-py/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio-py/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio-py/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio-py/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio-py/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio-py/languages","stargazers_url":"https://api.github.com/repos/minio/minio-py/stargazers","contributors_url":"https://api.github.com/repos/minio/minio-py/contributors","subscribers_url":"https://api.github.com/repos/minio/minio-py/subscribers","subscription_url":"https://api.github.com/repos/minio/minio-py/subscription","commits_url":"https://api.github.com/repos/minio/minio-py/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio-py/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio-py/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio-py/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio-py/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio-py/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio-py/merges","archive_url":"https://api.github.com/repos/minio/minio-py/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio-py/downloads","issues_url":"https://api.github.com/repos/minio/minio-py/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio-py/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio-py/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio-py/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio-py/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio-py/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio-py/deployments","created_at":"2015-06-17T03:51:15Z","updated_at":"2017-09-26T07:27:19Z","pushed_at":"2017-09-30T01:40:19Z","git_url":"git://github.com/minio/minio-py.git","ssh_url":"git@github.com:minio/minio-py.git","clone_url":"https://github.com/minio/minio-py.git","svn_url":"https://github.com/minio/minio-py","homepage":"https://docs.minio.io/docs/python-client-quickstart-guide","size":1025,"stargazers_count":83,"watchers_count":83,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":21,"forks":49,"open_issues":21,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio-py/pulls/582"},"html":{"href":"https://github.com/minio/minio-py/pull/582"},"issue":{"href":"https://api.github.com/repos/minio/minio-py/issues/582"},"comments":{"href":"https://api.github.com/repos/minio/minio-py/issues/582/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio-py/pulls/582/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio-py/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio-py/pulls/582/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio-py/statuses/1429c1b78fe3146a892f9aef52bb773e268fcdde"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vadmeste"}}