{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/14811","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/14811/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/14811/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/14811/events","html_url":"https://github.com/cockroachdb/cockroach/pull/14811","id":221051844,"number":14811,"title":"util/log: all internal scope calls now ignore -show-logs","user":{"login":"BramGruneir","id":1614265,"avatar_url":"https://avatars2.githubusercontent.com/u/1614265?v=3","gravatar_id":"","url":"https://api.github.com/users/BramGruneir","html_url":"https://github.com/BramGruneir","followers_url":"https://api.github.com/users/BramGruneir/followers","following_url":"https://api.github.com/users/BramGruneir/following{/other_user}","gists_url":"https://api.github.com/users/BramGruneir/gists{/gist_id}","starred_url":"https://api.github.com/users/BramGruneir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BramGruneir/subscriptions","organizations_url":"https://api.github.com/users/BramGruneir/orgs","repos_url":"https://api.github.com/users/BramGruneir/repos","events_url":"https://api.github.com/users/BramGruneir/events{/privacy}","received_events_url":"https://api.github.com/users/BramGruneir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":21,"created_at":"2017-04-11T19:12:58Z","updated_at":"2017-04-13T18:40:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/14811","html_url":"https://github.com/cockroachdb/cockroach/pull/14811","diff_url":"https://github.com/cockroachdb/cockroach/pull/14811.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/14811.patch"},"body":"All of these tests require actual files to be written to disk and when testing with -show-logs it can corrupt the tests."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/293987166","html_url":"https://github.com/cockroachdb/cockroach/pull/14811#issuecomment-293987166","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/14811","id":293987166,"user":{"login":"BramGruneir","id":1614265,"avatar_url":"https://avatars2.githubusercontent.com/u/1614265?v=3","gravatar_id":"","url":"https://api.github.com/users/BramGruneir","html_url":"https://github.com/BramGruneir","followers_url":"https://api.github.com/users/BramGruneir/followers","following_url":"https://api.github.com/users/BramGruneir/following{/other_user}","gists_url":"https://api.github.com/users/BramGruneir/gists{/gist_id}","starred_url":"https://api.github.com/users/BramGruneir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BramGruneir/subscriptions","organizations_url":"https://api.github.com/users/BramGruneir/orgs","repos_url":"https://api.github.com/users/BramGruneir/repos","events_url":"https://api.github.com/users/BramGruneir/events{/privacy}","received_events_url":"https://api.github.com/users/BramGruneir/received_events","type":"User","site_admin":false},"created_at":"2017-04-13T18:40:38Z","updated_at":"2017-04-13T18:40:38Z","body":"\n\n\n\n\n\n\n\n*[pkg/server/status_test.go, line 201 at r3](https://reviewable.io:443/reviews/cockroachdb/cockroach/14811#-KhcH5HCX9oZMAjzTxiV:-KhcbHEfVjYcxV3koxqz:bmuovp2) ([raw file](https://github.com/cockroachdb/cockroach/blob/3c4d8cd69d578e79cd755f0b87baa5bf9ad34e24/pkg/server/status_test.go#L201)):*\n<details><summary><i>Previously, knz (kena) wrote…</i></summary><blockquote>\n\n+1 on making a comment.\n\nThen for the delay I simply recommend a loop that waits until time.Now() is greated by 1 microsecond, e.g. `for time.Now().Sub(prevTS) < time.Microsecond {}` or something.\n</blockquote></details>\n\nHow is that any different better than just sleeping for 1 microsecond?  (and as Tamir mentioned earlier, it would have to be 10 microseconds)\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/14811)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"BramGruneir"}}