{"action":"created","comment":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/124519006","pull_request_review_id":46813444,"id":124519006,"diff_hunk":"@@ -0,0 +1,43 @@\n+","path":"regression/invariants/driver.cpp","position":1,"original_position":1,"commit_id":"e449526382b54bb732bc94bd272eb7561bd8e11c","original_commit_id":"e449526382b54bb732bc94bd272eb7561bd8e11c","user":{"login":"tautschnig","id":1144736,"avatar_url":"https://avatars0.githubusercontent.com/u/1144736?v=3","gravatar_id":"","url":"https://api.github.com/users/tautschnig","html_url":"https://github.com/tautschnig","followers_url":"https://api.github.com/users/tautschnig/followers","following_url":"https://api.github.com/users/tautschnig/following{/other_user}","gists_url":"https://api.github.com/users/tautschnig/gists{/gist_id}","starred_url":"https://api.github.com/users/tautschnig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tautschnig/subscriptions","organizations_url":"https://api.github.com/users/tautschnig/orgs","repos_url":"https://api.github.com/users/tautschnig/repos","events_url":"https://api.github.com/users/tautschnig/events{/privacy}","received_events_url":"https://api.github.com/users/tautschnig/received_events","type":"User","site_admin":false},"body":"Missing copyright header?","created_at":"2017-06-28T11:46:05Z","updated_at":"2017-06-28T11:55:53Z","html_url":"https://github.com/diffblue/cbmc/pull/1063#discussion_r124519006","pull_request_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1063","_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments/124519006"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1063#discussion_r124519006"},"pull_request":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1063"}}},"pull_request":{"url":"https://api.github.com/repos/diffblue/cbmc/pulls/1063","id":127655927,"html_url":"https://github.com/diffblue/cbmc/pull/1063","diff_url":"https://github.com/diffblue/cbmc/pull/1063.diff","patch_url":"https://github.com/diffblue/cbmc/pull/1063.patch","issue_url":"https://api.github.com/repos/diffblue/cbmc/issues/1063","number":1063,"state":"open","locked":false,"title":"Improved invariants","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"body":"Based on recent discussions about the shortcomings of the `INVARIANT` family of macros, here are some improvements:\r\n\r\n1. Most importantly, invariants can now be structured. `INVARIANT(false, \"Hello world\")` still works and produces an `invariant_failedt` as before, but one can also derive from `invariant_failedt`, add fields to describe an error in a more useful way, and override `pretty_print` to render them into a human-readable error message. This means that even before catching invariants becomes allowed practice we can be producing structured invariants ready for if and when that changes. The update to tests demonstrates this feature in use.\r\n2. For consistency, the throw / abort behaviour of invariants is no longer dependent on compile-time conditional definitions; it will now function one way and do that dependably on both development and production builds, hopefully reducing the chance of a surprise in production. Currently it *always aborts* owing to @martin-cs concerns that a `catch(...)` may accidentally swallow in invariant it didn't mean to.\r\n3. (Incidental) the `reason` expression, whether structured or a simple string, is now lazily evaluated (e.g. `INVARIANT(x==y, str1+str2)` will only perform the string concatenation if the test fails).\r\n\r\nPlease get in there *now* with your design concerns rather than objecting to down-the-line PRs that use these features!","created_at":"2017-06-27T10:03:14Z","updated_at":"2017-06-28T11:55:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"436adc7ee6f00264308b1b1c54a3e5b9b9a92c7f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"reuk","id":3016418,"avatar_url":"https://avatars2.githubusercontent.com/u/3016418?v=3","gravatar_id":"","url":"https://api.github.com/users/reuk","html_url":"https://github.com/reuk","followers_url":"https://api.github.com/users/reuk/followers","following_url":"https://api.github.com/users/reuk/following{/other_user}","gists_url":"https://api.github.com/users/reuk/gists{/gist_id}","starred_url":"https://api.github.com/users/reuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reuk/subscriptions","organizations_url":"https://api.github.com/users/reuk/orgs","repos_url":"https://api.github.com/users/reuk/repos","events_url":"https://api.github.com/users/reuk/events{/privacy}","received_events_url":"https://api.github.com/users/reuk/received_events","type":"User","site_admin":false},{"login":"martin-cs","id":5333188,"avatar_url":"https://avatars3.githubusercontent.com/u/5333188?v=3","gravatar_id":"","url":"https://api.github.com/users/martin-cs","html_url":"https://github.com/martin-cs","followers_url":"https://api.github.com/users/martin-cs/followers","following_url":"https://api.github.com/users/martin-cs/following{/other_user}","gists_url":"https://api.github.com/users/martin-cs/gists{/gist_id}","starred_url":"https://api.github.com/users/martin-cs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martin-cs/subscriptions","organizations_url":"https://api.github.com/users/martin-cs/orgs","repos_url":"https://api.github.com/users/martin-cs/repos","events_url":"https://api.github.com/users/martin-cs/events{/privacy}","received_events_url":"https://api.github.com/users/martin-cs/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1063/commits","review_comments_url":"https://api.github.com/repos/diffblue/cbmc/pulls/1063/comments","review_comment_url":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diffblue/cbmc/issues/1063/comments","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/e449526382b54bb732bc94bd272eb7561bd8e11c","head":{"label":"smowton:smowton/feature/improved_invariants","ref":"smowton/feature/improved_invariants","sha":"e449526382b54bb732bc94bd272eb7561bd8e11c","user":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"repo":{"id":75178953,"name":"cbmc","full_name":"smowton/cbmc","owner":{"login":"smowton","id":283483,"avatar_url":"https://avatars0.githubusercontent.com/u/283483?v=3","gravatar_id":"","url":"https://api.github.com/users/smowton","html_url":"https://github.com/smowton","followers_url":"https://api.github.com/users/smowton/followers","following_url":"https://api.github.com/users/smowton/following{/other_user}","gists_url":"https://api.github.com/users/smowton/gists{/gist_id}","starred_url":"https://api.github.com/users/smowton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smowton/subscriptions","organizations_url":"https://api.github.com/users/smowton/orgs","repos_url":"https://api.github.com/users/smowton/repos","events_url":"https://api.github.com/users/smowton/events{/privacy}","received_events_url":"https://api.github.com/users/smowton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/smowton/cbmc","description":"C Bounded Model Checker","fork":true,"url":"https://api.github.com/repos/smowton/cbmc","forks_url":"https://api.github.com/repos/smowton/cbmc/forks","keys_url":"https://api.github.com/repos/smowton/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/smowton/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/smowton/cbmc/teams","hooks_url":"https://api.github.com/repos/smowton/cbmc/hooks","issue_events_url":"https://api.github.com/repos/smowton/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/smowton/cbmc/events","assignees_url":"https://api.github.com/repos/smowton/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/smowton/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/smowton/cbmc/tags","blobs_url":"https://api.github.com/repos/smowton/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/smowton/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/smowton/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/smowton/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/smowton/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/smowton/cbmc/languages","stargazers_url":"https://api.github.com/repos/smowton/cbmc/stargazers","contributors_url":"https://api.github.com/repos/smowton/cbmc/contributors","subscribers_url":"https://api.github.com/repos/smowton/cbmc/subscribers","subscription_url":"https://api.github.com/repos/smowton/cbmc/subscription","commits_url":"https://api.github.com/repos/smowton/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/smowton/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/smowton/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/smowton/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/smowton/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/smowton/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/smowton/cbmc/merges","archive_url":"https://api.github.com/repos/smowton/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/smowton/cbmc/downloads","issues_url":"https://api.github.com/repos/smowton/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/smowton/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/smowton/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/smowton/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/smowton/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/smowton/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/smowton/cbmc/deployments","created_at":"2016-11-30T11:02:38Z","updated_at":"2016-11-30T11:02:46Z","pushed_at":"2017-06-28T11:11:33Z","git_url":"git://github.com/smowton/cbmc.git","ssh_url":"git@github.com:smowton/cbmc.git","clone_url":"https://github.com/smowton/cbmc.git","svn_url":"https://github.com/smowton/cbmc","homepage":"http://www.cprover.org/cbmc","size":26897,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diffblue:master","ref":"master","sha":"e0b45158389556bc0f705ba3400a358a367bd9ef","user":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars3.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"repo":{"id":51877056,"name":"cbmc","full_name":"diffblue/cbmc","owner":{"login":"diffblue","id":17216098,"avatar_url":"https://avatars3.githubusercontent.com/u/17216098?v=3","gravatar_id":"","url":"https://api.github.com/users/diffblue","html_url":"https://github.com/diffblue","followers_url":"https://api.github.com/users/diffblue/followers","following_url":"https://api.github.com/users/diffblue/following{/other_user}","gists_url":"https://api.github.com/users/diffblue/gists{/gist_id}","starred_url":"https://api.github.com/users/diffblue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diffblue/subscriptions","organizations_url":"https://api.github.com/users/diffblue/orgs","repos_url":"https://api.github.com/users/diffblue/repos","events_url":"https://api.github.com/users/diffblue/events{/privacy}","received_events_url":"https://api.github.com/users/diffblue/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/diffblue/cbmc","description":"C Bounded Model Checker","fork":false,"url":"https://api.github.com/repos/diffblue/cbmc","forks_url":"https://api.github.com/repos/diffblue/cbmc/forks","keys_url":"https://api.github.com/repos/diffblue/cbmc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diffblue/cbmc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diffblue/cbmc/teams","hooks_url":"https://api.github.com/repos/diffblue/cbmc/hooks","issue_events_url":"https://api.github.com/repos/diffblue/cbmc/issues/events{/number}","events_url":"https://api.github.com/repos/diffblue/cbmc/events","assignees_url":"https://api.github.com/repos/diffblue/cbmc/assignees{/user}","branches_url":"https://api.github.com/repos/diffblue/cbmc/branches{/branch}","tags_url":"https://api.github.com/repos/diffblue/cbmc/tags","blobs_url":"https://api.github.com/repos/diffblue/cbmc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diffblue/cbmc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diffblue/cbmc/git/refs{/sha}","trees_url":"https://api.github.com/repos/diffblue/cbmc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diffblue/cbmc/statuses/{sha}","languages_url":"https://api.github.com/repos/diffblue/cbmc/languages","stargazers_url":"https://api.github.com/repos/diffblue/cbmc/stargazers","contributors_url":"https://api.github.com/repos/diffblue/cbmc/contributors","subscribers_url":"https://api.github.com/repos/diffblue/cbmc/subscribers","subscription_url":"https://api.github.com/repos/diffblue/cbmc/subscription","commits_url":"https://api.github.com/repos/diffblue/cbmc/commits{/sha}","git_commits_url":"https://api.github.com/repos/diffblue/cbmc/git/commits{/sha}","comments_url":"https://api.github.com/repos/diffblue/cbmc/comments{/number}","issue_comment_url":"https://api.github.com/repos/diffblue/cbmc/issues/comments{/number}","contents_url":"https://api.github.com/repos/diffblue/cbmc/contents/{+path}","compare_url":"https://api.github.com/repos/diffblue/cbmc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diffblue/cbmc/merges","archive_url":"https://api.github.com/repos/diffblue/cbmc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diffblue/cbmc/downloads","issues_url":"https://api.github.com/repos/diffblue/cbmc/issues{/number}","pulls_url":"https://api.github.com/repos/diffblue/cbmc/pulls{/number}","milestones_url":"https://api.github.com/repos/diffblue/cbmc/milestones{/number}","notifications_url":"https://api.github.com/repos/diffblue/cbmc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diffblue/cbmc/labels{/name}","releases_url":"https://api.github.com/repos/diffblue/cbmc/releases{/id}","deployments_url":"https://api.github.com/repos/diffblue/cbmc/deployments","created_at":"2016-02-16T23:03:52Z","updated_at":"2017-06-28T11:31:48Z","pushed_at":"2017-06-28T11:11:34Z","git_url":"git://github.com/diffblue/cbmc.git","ssh_url":"git@github.com:diffblue/cbmc.git","clone_url":"https://github.com/diffblue/cbmc.git","svn_url":"https://github.com/diffblue/cbmc","homepage":"http://www.cprover.org/cbmc","size":20785,"stargazers_count":53,"watchers_count":53,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"open_issues_count":259,"forks":60,"open_issues":259,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1063"},"html":{"href":"https://github.com/diffblue/cbmc/pull/1063"},"issue":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1063"},"comments":{"href":"https://api.github.com/repos/diffblue/cbmc/issues/1063/comments"},"review_comments":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1063/comments"},"review_comment":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diffblue/cbmc/pulls/1063/commits"},"statuses":{"href":"https://api.github.com/repos/diffblue/cbmc/statuses/e449526382b54bb732bc94bd272eb7561bd8e11c"}}}}
{"actor":{"display_login":"tautschnig"}}