{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/116168625","pull_request_review_id":37770841,"id":116168625,"diff_hunk":"@@ -38,83 +40,96 @@ def check(*cmd, **keyargs):\n     subprocess.check_call(*cmd, **keyargs)\n \n def validate_metric_name(name):\n-    \"\"\"Validates that a string is useable as a metric name (Can be used as GCS object name).\"\"\"\n-    # Regex '$' symbol matches an optional terminating new line so we have to check that the name\n+    \"\"\"Raise if name is non-trivial.\"\"\"\n+    # Regex '$' symbol matches an optional terminating new line\n+    # so we have to check that the name\n     # doesn't have one if the regex matches.\n     if not re.match(r'^[\\w-]+$', name) or name[-1] == '\\n':\n-        raise ValueError('metric name must match the regular expression r\\'^[\\\\w-]+$\\'.')\n+        raise ValueError(name)\n \n def do_query(query, out_filename, project):\n     \"\"\"Executes a bigquery query, outputting the results to a file.\"\"\"\n     with open(out_filename, 'w') as out_file:\n-        check(['bq', 'query', '--format=prettyjson', '--project_id='+project], stdin=query,\n-              stdout=out_file)\n+        cmd = [","path":"scenarios/bigquery.py","position":37,"original_position":37,"commit_id":"4b2bddece829a209b93db8e765ec6a9922de4e2c","original_commit_id":"daa9e718a2d8b6f469b5cab03640650d422e22f3","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars1.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"Doesn't fit in 80 chars. Also added comment for why the `-n` flag is necessary","created_at":"2017-05-12T07:40:51Z","updated_at":"2017-05-12T07:54:30Z","html_url":"https://github.com/kubernetes/test-infra/pull/2741#discussion_r116168625","pull_request_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2741","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments/116168625"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/2741#discussion_r116168625"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2741"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2741","id":120259555,"html_url":"https://github.com/kubernetes/test-infra/pull/2741","diff_url":"https://github.com/kubernetes/test-infra/pull/2741.diff","patch_url":"https://github.com/kubernetes/test-infra/pull/2741.patch","issue_url":"https://api.github.com/repos/kubernetes/test-infra/issues/2741","number":2741,"state":"open","locked":false,"title":"Refactor bigquery scenario, include more than 100 rows","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars1.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"body":"/assign @cjwagner @rmmh \r\n\r\n* Make scenario pass `pylint`\r\n* Make `--jq` argument optional\r\n* Fix a variety of line breaks\r\n* Require all files in metrics to be yaml files\r\n* Make it faster to find the latest results by using a different name for each one.\r\n* Make initial pydoc line less than 80 chars to match style guidelines.\r\n* Include daily filtered result\r\n* Put latest result in root\r\n* Catch specific exceptions\r\n","created_at":"2017-05-12T06:57:17Z","updated_at":"2017-05-12T07:54:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1321e2efaacfbe337c527517e396ef97dac04e7","assignee":{"login":"cjwagner","id":5334145,"avatar_url":"https://avatars0.githubusercontent.com/u/5334145?v=3","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmmh","id":211868,"avatar_url":"https://avatars3.githubusercontent.com/u/211868?v=3","gravatar_id":"","url":"https://api.github.com/users/rmmh","html_url":"https://github.com/rmmh","followers_url":"https://api.github.com/users/rmmh/followers","following_url":"https://api.github.com/users/rmmh/following{/other_user}","gists_url":"https://api.github.com/users/rmmh/gists{/gist_id}","starred_url":"https://api.github.com/users/rmmh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmmh/subscriptions","organizations_url":"https://api.github.com/users/rmmh/orgs","repos_url":"https://api.github.com/users/rmmh/repos","events_url":"https://api.github.com/users/rmmh/events{/privacy}","received_events_url":"https://api.github.com/users/rmmh/received_events","type":"User","site_admin":false},{"login":"cjwagner","id":5334145,"avatar_url":"https://avatars0.githubusercontent.com/u/5334145?v=3","gravatar_id":"","url":"https://api.github.com/users/cjwagner","html_url":"https://github.com/cjwagner","followers_url":"https://api.github.com/users/cjwagner/followers","following_url":"https://api.github.com/users/cjwagner/following{/other_user}","gists_url":"https://api.github.com/users/cjwagner/gists{/gist_id}","starred_url":"https://api.github.com/users/cjwagner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjwagner/subscriptions","organizations_url":"https://api.github.com/users/cjwagner/orgs","repos_url":"https://api.github.com/users/cjwagner/repos","events_url":"https://api.github.com/users/cjwagner/events{/privacy}","received_events_url":"https://api.github.com/users/cjwagner/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2741/commits","review_comments_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/2741/comments","review_comment_url":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/issues/2741/comments","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/4b2bddece829a209b93db8e765ec6a9922de4e2c","head":{"label":"fejta:del","ref":"del","sha":"4b2bddece829a209b93db8e765ec6a9922de4e2c","user":{"login":"fejta","id":940341,"avatar_url":"https://avatars1.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"repo":{"id":59241934,"name":"test-infra","full_name":"fejta/test-infra","owner":{"login":"fejta","id":940341,"avatar_url":"https://avatars1.githubusercontent.com/u/940341?v=3","gravatar_id":"","url":"https://api.github.com/users/fejta","html_url":"https://github.com/fejta","followers_url":"https://api.github.com/users/fejta/followers","following_url":"https://api.github.com/users/fejta/following{/other_user}","gists_url":"https://api.github.com/users/fejta/gists{/gist_id}","starred_url":"https://api.github.com/users/fejta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fejta/subscriptions","organizations_url":"https://api.github.com/users/fejta/orgs","repos_url":"https://api.github.com/users/fejta/repos","events_url":"https://api.github.com/users/fejta/events{/privacy}","received_events_url":"https://api.github.com/users/fejta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fejta/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":true,"url":"https://api.github.com/repos/fejta/test-infra","forks_url":"https://api.github.com/repos/fejta/test-infra/forks","keys_url":"https://api.github.com/repos/fejta/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fejta/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fejta/test-infra/teams","hooks_url":"https://api.github.com/repos/fejta/test-infra/hooks","issue_events_url":"https://api.github.com/repos/fejta/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/fejta/test-infra/events","assignees_url":"https://api.github.com/repos/fejta/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/fejta/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/fejta/test-infra/tags","blobs_url":"https://api.github.com/repos/fejta/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fejta/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fejta/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/fejta/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fejta/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/fejta/test-infra/languages","stargazers_url":"https://api.github.com/repos/fejta/test-infra/stargazers","contributors_url":"https://api.github.com/repos/fejta/test-infra/contributors","subscribers_url":"https://api.github.com/repos/fejta/test-infra/subscribers","subscription_url":"https://api.github.com/repos/fejta/test-infra/subscription","commits_url":"https://api.github.com/repos/fejta/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/fejta/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/fejta/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/fejta/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/fejta/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/fejta/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fejta/test-infra/merges","archive_url":"https://api.github.com/repos/fejta/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fejta/test-infra/downloads","issues_url":"https://api.github.com/repos/fejta/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/fejta/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/fejta/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/fejta/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fejta/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/fejta/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/fejta/test-infra/deployments","created_at":"2016-05-19T20:53:03Z","updated_at":"2017-01-21T20:00:13Z","pushed_at":"2017-05-12T07:54:25Z","git_url":"git://github.com/fejta/test-infra.git","ssh_url":"git@github.com:fejta/test-infra.git","clone_url":"https://github.com/fejta/test-infra.git","svn_url":"https://github.com/fejta/test-infra","homepage":null,"size":17724,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"4de8ae37daafb660921d4962697b9dfaf6924ef7","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57333709,"name":"test-infra","full_name":"kubernetes/test-infra","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/test-infra","description":"Test infrastructure for the Kubernetes project.","fork":false,"url":"https://api.github.com/repos/kubernetes/test-infra","forks_url":"https://api.github.com/repos/kubernetes/test-infra/forks","keys_url":"https://api.github.com/repos/kubernetes/test-infra/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/test-infra/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/test-infra/teams","hooks_url":"https://api.github.com/repos/kubernetes/test-infra/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/test-infra/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/test-infra/events","assignees_url":"https://api.github.com/repos/kubernetes/test-infra/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/test-infra/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/test-infra/tags","blobs_url":"https://api.github.com/repos/kubernetes/test-infra/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/test-infra/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/test-infra/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/test-infra/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/test-infra/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/test-infra/languages","stargazers_url":"https://api.github.com/repos/kubernetes/test-infra/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/test-infra/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/test-infra/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/test-infra/subscription","commits_url":"https://api.github.com/repos/kubernetes/test-infra/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/test-infra/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/test-infra/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/test-infra/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/test-infra/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/test-infra/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/test-infra/merges","archive_url":"https://api.github.com/repos/kubernetes/test-infra/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/test-infra/downloads","issues_url":"https://api.github.com/repos/kubernetes/test-infra/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/test-infra/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/test-infra/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/test-infra/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/test-infra/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/test-infra/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/test-infra/deployments","created_at":"2016-04-28T21:05:35Z","updated_at":"2017-05-10T22:25:46Z","pushed_at":"2017-05-12T07:54:27Z","git_url":"git://github.com/kubernetes/test-infra.git","ssh_url":"git@github.com:kubernetes/test-infra.git","clone_url":"https://github.com/kubernetes/test-infra.git","svn_url":"https://github.com/kubernetes/test-infra","homepage":null,"size":18504,"stargazers_count":82,"watchers_count":82,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":139,"mirror_url":null,"open_issues_count":192,"forks":139,"open_issues":192,"watchers":82,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2741"},"html":{"href":"https://github.com/kubernetes/test-infra/pull/2741"},"issue":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/2741"},"comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/issues/2741/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2741/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/test-infra/pulls/2741/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/test-infra/statuses/4b2bddece829a209b93db8e765ec6a9922de4e2c"}}}}
{"actor":{"display_login":"fejta"}}