{"action":"created","comment":{"url":"https://api.github.com/repos/ruslo/hunter/pulls/comments/118865825","pull_request_review_id":40697196,"id":118865825,"diff_hunk":"@@ -50,11 +52,17 @@ if(ANDROID)\n     hunter_user_error(\"Could not find android architecture. Please set ANDROID_ARCH_NAME in your toolchain or use CMake 3.7+\")\n   endif()\n   set(configure_command\n-      # Ignored. Prevents script from checking host uname\n-      RELEASE=2.6.37\n-      SYSTEM=android\n-      ARCH=${ANDROID_SSL_ARCH}\n-      ${configure_command})\n+      ${configure_command} ${CMAKE_C_FLAGS})\n+\n+  # Latest OpenSSL (1.1.1) still does not have correct android targets, so set generic with our CFLAGS\n+  string(COMPARE EQUAL \"${ANDROID_SSL_ARCH}\" \"arm64\" _is_arm64)\n+  string(COMPARE EQUAL \"${ANDROID_SSL_ARCH}\" \"mips64\" _is_mips64)\n+  string(COMPARE EQUAL \"${ANDROID_SSL_ARCH}\" \"x86_64\" _is_x8664)\n+  if (_is_arm64 OR _is_mips64 OR _is_x8664)\n+    set(configure_opts \"linux-generic64\")","path":"cmake/projects/OpenSSL/schemes/url_sha1_openssl.cmake.in","position":23,"original_position":25,"commit_id":"41ee0f7147526dc7ed8177d636b6c5b2aeb9ca4d","original_commit_id":"b20e1713da938256c2f63555684958015df26a09","user":{"login":"xsacha","id":61218,"avatar_url":"https://avatars0.githubusercontent.com/u/61218?v=3","gravatar_id":"","url":"https://api.github.com/users/xsacha","html_url":"https://github.com/xsacha","followers_url":"https://api.github.com/users/xsacha/followers","following_url":"https://api.github.com/users/xsacha/following{/other_user}","gists_url":"https://api.github.com/users/xsacha/gists{/gist_id}","starred_url":"https://api.github.com/users/xsacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsacha/subscriptions","organizations_url":"https://api.github.com/users/xsacha/orgs","repos_url":"https://api.github.com/users/xsacha/repos","events_url":"https://api.github.com/users/xsacha/events{/privacy}","received_events_url":"https://api.github.com/users/xsacha/received_events","type":"User","site_admin":false},"body":"It fails on GCC as evidenced by:\r\nhttps://github.com/ruslo/hunter/issues/756\r\n\r\nwhich is why we have this test disabled in Travis:\r\nhttps://travis-ci.org/ingenue/hunter/jobs/215460184","created_at":"2017-05-29T04:52:18Z","updated_at":"2017-05-29T04:52:19Z","html_url":"https://github.com/ruslo/hunter/pull/807#discussion_r118865825","pull_request_url":"https://api.github.com/repos/ruslo/hunter/pulls/807","_links":{"self":{"href":"https://api.github.com/repos/ruslo/hunter/pulls/comments/118865825"},"html":{"href":"https://github.com/ruslo/hunter/pull/807#discussion_r118865825"},"pull_request":{"href":"https://api.github.com/repos/ruslo/hunter/pulls/807"}}},"pull_request":{"url":"https://api.github.com/repos/ruslo/hunter/pulls/807","id":122350483,"html_url":"https://github.com/ruslo/hunter/pull/807","diff_url":"https://github.com/ruslo/hunter/pull/807.diff","patch_url":"https://github.com/ruslo/hunter/pull/807.patch","issue_url":"https://api.github.com/repos/ruslo/hunter/issues/807","number":807,"state":"open","locked":false,"title":"Fix OpenSSL compile on Android. Fixes CFLAG mangling in config script.","user":{"login":"xsacha","id":61218,"avatar_url":"https://avatars0.githubusercontent.com/u/61218?v=3","gravatar_id":"","url":"https://api.github.com/users/xsacha","html_url":"https://github.com/xsacha","followers_url":"https://api.github.com/users/xsacha/followers","following_url":"https://api.github.com/users/xsacha/following{/other_user}","gists_url":"https://api.github.com/users/xsacha/gists{/gist_id}","starred_url":"https://api.github.com/users/xsacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsacha/subscriptions","organizations_url":"https://api.github.com/users/xsacha/orgs","repos_url":"https://api.github.com/users/xsacha/repos","events_url":"https://api.github.com/users/xsacha/events{/privacy}","received_events_url":"https://api.github.com/users/xsacha/received_events","type":"User","site_admin":false},"body":"The OpenSSL config script runs a s/^--/- script that ruins our CFLAGS input.\r\nThe Android config uses -mandroid that doesn't work on clang.\r\n\r\n\r\nAs a solution, use our CFLAGS on top of a generic linux config and use the proper Configure script.\r\n\r\nAs far as I know, Configure should be used when you are bringing your own CFLAGS and config should be used to automatically set up sane flags.\r\nFor Android, the latter is not working very well.\r\n\r\nWith this change, Android now compiles for all versions of OpenSSL on GCC and Clang.","created_at":"2017-05-25T00:29:15Z","updated_at":"2017-05-29T04:52:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8d981325c5a2c3ad6b9b5cfbaaadd076a213b87","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ruslo/hunter/pulls/807/commits","review_comments_url":"https://api.github.com/repos/ruslo/hunter/pulls/807/comments","review_comment_url":"https://api.github.com/repos/ruslo/hunter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ruslo/hunter/issues/807/comments","statuses_url":"https://api.github.com/repos/ruslo/hunter/statuses/41ee0f7147526dc7ed8177d636b6c5b2aeb9ca4d","head":{"label":"xsacha:master","ref":"master","sha":"41ee0f7147526dc7ed8177d636b6c5b2aeb9ca4d","user":{"login":"xsacha","id":61218,"avatar_url":"https://avatars0.githubusercontent.com/u/61218?v=3","gravatar_id":"","url":"https://api.github.com/users/xsacha","html_url":"https://github.com/xsacha","followers_url":"https://api.github.com/users/xsacha/followers","following_url":"https://api.github.com/users/xsacha/following{/other_user}","gists_url":"https://api.github.com/users/xsacha/gists{/gist_id}","starred_url":"https://api.github.com/users/xsacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsacha/subscriptions","organizations_url":"https://api.github.com/users/xsacha/orgs","repos_url":"https://api.github.com/users/xsacha/repos","events_url":"https://api.github.com/users/xsacha/events{/privacy}","received_events_url":"https://api.github.com/users/xsacha/received_events","type":"User","site_admin":false},"repo":{"id":65790541,"name":"hunter","full_name":"xsacha/hunter","owner":{"login":"xsacha","id":61218,"avatar_url":"https://avatars0.githubusercontent.com/u/61218?v=3","gravatar_id":"","url":"https://api.github.com/users/xsacha","html_url":"https://github.com/xsacha","followers_url":"https://api.github.com/users/xsacha/followers","following_url":"https://api.github.com/users/xsacha/following{/other_user}","gists_url":"https://api.github.com/users/xsacha/gists{/gist_id}","starred_url":"https://api.github.com/users/xsacha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xsacha/subscriptions","organizations_url":"https://api.github.com/users/xsacha/orgs","repos_url":"https://api.github.com/users/xsacha/repos","events_url":"https://api.github.com/users/xsacha/events{/privacy}","received_events_url":"https://api.github.com/users/xsacha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xsacha/hunter","description":":package: CMake-driven cross-platform package manager for C++. Linux, Mac, Windows, iOS, Android, Raspberry Pi.","fork":true,"url":"https://api.github.com/repos/xsacha/hunter","forks_url":"https://api.github.com/repos/xsacha/hunter/forks","keys_url":"https://api.github.com/repos/xsacha/hunter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xsacha/hunter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xsacha/hunter/teams","hooks_url":"https://api.github.com/repos/xsacha/hunter/hooks","issue_events_url":"https://api.github.com/repos/xsacha/hunter/issues/events{/number}","events_url":"https://api.github.com/repos/xsacha/hunter/events","assignees_url":"https://api.github.com/repos/xsacha/hunter/assignees{/user}","branches_url":"https://api.github.com/repos/xsacha/hunter/branches{/branch}","tags_url":"https://api.github.com/repos/xsacha/hunter/tags","blobs_url":"https://api.github.com/repos/xsacha/hunter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xsacha/hunter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xsacha/hunter/git/refs{/sha}","trees_url":"https://api.github.com/repos/xsacha/hunter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xsacha/hunter/statuses/{sha}","languages_url":"https://api.github.com/repos/xsacha/hunter/languages","stargazers_url":"https://api.github.com/repos/xsacha/hunter/stargazers","contributors_url":"https://api.github.com/repos/xsacha/hunter/contributors","subscribers_url":"https://api.github.com/repos/xsacha/hunter/subscribers","subscription_url":"https://api.github.com/repos/xsacha/hunter/subscription","commits_url":"https://api.github.com/repos/xsacha/hunter/commits{/sha}","git_commits_url":"https://api.github.com/repos/xsacha/hunter/git/commits{/sha}","comments_url":"https://api.github.com/repos/xsacha/hunter/comments{/number}","issue_comment_url":"https://api.github.com/repos/xsacha/hunter/issues/comments{/number}","contents_url":"https://api.github.com/repos/xsacha/hunter/contents/{+path}","compare_url":"https://api.github.com/repos/xsacha/hunter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xsacha/hunter/merges","archive_url":"https://api.github.com/repos/xsacha/hunter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xsacha/hunter/downloads","issues_url":"https://api.github.com/repos/xsacha/hunter/issues{/number}","pulls_url":"https://api.github.com/repos/xsacha/hunter/pulls{/number}","milestones_url":"https://api.github.com/repos/xsacha/hunter/milestones{/number}","notifications_url":"https://api.github.com/repos/xsacha/hunter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xsacha/hunter/labels{/name}","releases_url":"https://api.github.com/repos/xsacha/hunter/releases{/id}","deployments_url":"https://api.github.com/repos/xsacha/hunter/deployments","created_at":"2016-08-16T05:38:29Z","updated_at":"2016-08-16T05:38:31Z","pushed_at":"2017-05-29T04:23:53Z","git_url":"git://github.com/xsacha/hunter.git","ssh_url":"git@github.com:xsacha/hunter.git","clone_url":"https://github.com/xsacha/hunter.git","svn_url":"https://github.com/xsacha/hunter","homepage":"http://goo.gl/wiAG","size":3552,"stargazers_count":0,"watchers_count":0,"language":"CMake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ruslo:master","ref":"master","sha":"c8f92f5e2bf3a024af7b416ff43f6e538638d0f5","user":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars1.githubusercontent.com/u/4346993?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"repo":{"id":14202056,"name":"hunter","full_name":"ruslo/hunter","owner":{"login":"ruslo","id":4346993,"avatar_url":"https://avatars1.githubusercontent.com/u/4346993?v=3","gravatar_id":"","url":"https://api.github.com/users/ruslo","html_url":"https://github.com/ruslo","followers_url":"https://api.github.com/users/ruslo/followers","following_url":"https://api.github.com/users/ruslo/following{/other_user}","gists_url":"https://api.github.com/users/ruslo/gists{/gist_id}","starred_url":"https://api.github.com/users/ruslo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ruslo/subscriptions","organizations_url":"https://api.github.com/users/ruslo/orgs","repos_url":"https://api.github.com/users/ruslo/repos","events_url":"https://api.github.com/users/ruslo/events{/privacy}","received_events_url":"https://api.github.com/users/ruslo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ruslo/hunter","description":":package: CMake-driven cross-platform package manager for C++. Linux, Mac, Windows, iOS, Android, Raspberry Pi.","fork":false,"url":"https://api.github.com/repos/ruslo/hunter","forks_url":"https://api.github.com/repos/ruslo/hunter/forks","keys_url":"https://api.github.com/repos/ruslo/hunter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ruslo/hunter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ruslo/hunter/teams","hooks_url":"https://api.github.com/repos/ruslo/hunter/hooks","issue_events_url":"https://api.github.com/repos/ruslo/hunter/issues/events{/number}","events_url":"https://api.github.com/repos/ruslo/hunter/events","assignees_url":"https://api.github.com/repos/ruslo/hunter/assignees{/user}","branches_url":"https://api.github.com/repos/ruslo/hunter/branches{/branch}","tags_url":"https://api.github.com/repos/ruslo/hunter/tags","blobs_url":"https://api.github.com/repos/ruslo/hunter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ruslo/hunter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ruslo/hunter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ruslo/hunter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ruslo/hunter/statuses/{sha}","languages_url":"https://api.github.com/repos/ruslo/hunter/languages","stargazers_url":"https://api.github.com/repos/ruslo/hunter/stargazers","contributors_url":"https://api.github.com/repos/ruslo/hunter/contributors","subscribers_url":"https://api.github.com/repos/ruslo/hunter/subscribers","subscription_url":"https://api.github.com/repos/ruslo/hunter/subscription","commits_url":"https://api.github.com/repos/ruslo/hunter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ruslo/hunter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ruslo/hunter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ruslo/hunter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ruslo/hunter/contents/{+path}","compare_url":"https://api.github.com/repos/ruslo/hunter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ruslo/hunter/merges","archive_url":"https://api.github.com/repos/ruslo/hunter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ruslo/hunter/downloads","issues_url":"https://api.github.com/repos/ruslo/hunter/issues{/number}","pulls_url":"https://api.github.com/repos/ruslo/hunter/pulls{/number}","milestones_url":"https://api.github.com/repos/ruslo/hunter/milestones{/number}","notifications_url":"https://api.github.com/repos/ruslo/hunter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ruslo/hunter/labels{/name}","releases_url":"https://api.github.com/repos/ruslo/hunter/releases{/id}","deployments_url":"https://api.github.com/repos/ruslo/hunter/deployments","created_at":"2013-11-07T11:32:19Z","updated_at":"2017-05-27T18:32:37Z","pushed_at":"2017-05-29T04:23:55Z","git_url":"git://github.com/ruslo/hunter.git","ssh_url":"git@github.com:ruslo/hunter.git","clone_url":"https://github.com/ruslo/hunter.git","svn_url":"https://github.com/ruslo/hunter","homepage":"http://goo.gl/wiAG","size":3438,"stargazers_count":747,"watchers_count":747,"language":"CMake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"open_issues_count":213,"forks":154,"open_issues":213,"watchers":747,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ruslo/hunter/pulls/807"},"html":{"href":"https://github.com/ruslo/hunter/pull/807"},"issue":{"href":"https://api.github.com/repos/ruslo/hunter/issues/807"},"comments":{"href":"https://api.github.com/repos/ruslo/hunter/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/ruslo/hunter/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/ruslo/hunter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ruslo/hunter/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/ruslo/hunter/statuses/41ee0f7147526dc7ed8177d636b6c5b2aeb9ca4d"}}}}
{"actor":{"display_login":"xsacha"}}