{"action":"created","comment":{"url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/comments/100681358","pull_request_review_id":21398237,"id":100681358,"diff_hunk":"@@ -22,6 +22,7 @@\n                 style=\"@style/BaseRecyclerView\"\n                 android:layout_width=\"match_parent\"\n                 android:layout_height=\"wrap_content\"\n+                android:background=\"@color/white\"","path":"app/src/main/res/layout/fragment_search.xml","position":4,"original_position":4,"commit_id":"0540b7b6f9f3c8d463e665fbaf0193f61c324a54","original_commit_id":"0540b7b6f9f3c8d463e665fbaf0193f61c324a54","user":{"login":"konifar","id":1269214,"avatar_url":"https://avatars.githubusercontent.com/u/1269214?v=3","gravatar_id":"","url":"https://api.github.com/users/konifar","html_url":"https://github.com/konifar","followers_url":"https://api.github.com/users/konifar/followers","following_url":"https://api.github.com/users/konifar/following{/other_user}","gists_url":"https://api.github.com/users/konifar/gists{/gist_id}","starred_url":"https://api.github.com/users/konifar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konifar/subscriptions","organizations_url":"https://api.github.com/users/konifar/orgs","repos_url":"https://api.github.com/users/konifar/repos","events_url":"https://api.github.com/users/konifar/events{/privacy}","received_events_url":"https://api.github.com/users/konifar/received_events","type":"User","site_admin":false},"body":"> Set white color to background of the RecyclerView in search page. without this, the alpha animation looks not good.\r\n\r\nUnderstood. Thanks for description 👍 ","created_at":"2017-02-12T01:52:59Z","updated_at":"2017-02-12T01:52:59Z","html_url":"https://github.com/DroidKaigi/conference-app-2017/pull/309#discussion_r100681358","pull_request_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/309","_links":{"self":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/comments/100681358"},"html":{"href":"https://github.com/DroidKaigi/conference-app-2017/pull/309#discussion_r100681358"},"pull_request":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/309","id":105775026,"html_url":"https://github.com/DroidKaigi/conference-app-2017/pull/309","diff_url":"https://github.com/DroidKaigi/conference-app-2017/pull/309.diff","patch_url":"https://github.com/DroidKaigi/conference-app-2017/pull/309.patch","issue_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/309","number":309,"state":"open","locked":false,"title":"Animate search result items when the result changes.","user":{"login":"yatatsu","id":949882,"avatar_url":"https://avatars.githubusercontent.com/u/949882?v=3","gravatar_id":"","url":"https://api.github.com/users/yatatsu","html_url":"https://github.com/yatatsu","followers_url":"https://api.github.com/users/yatatsu/followers","following_url":"https://api.github.com/users/yatatsu/following{/other_user}","gists_url":"https://api.github.com/users/yatatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/yatatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatatsu/subscriptions","organizations_url":"https://api.github.com/users/yatatsu/orgs","repos_url":"https://api.github.com/users/yatatsu/repos","events_url":"https://api.github.com/users/yatatsu/events{/privacy}","received_events_url":"https://api.github.com/users/yatatsu/received_events","type":"User","site_admin":false},"body":"## Issue\r\n- None\r\n\r\n## Overview (Required)\r\n- Animate search result items when the result changes. Please check screenshot gif.\r\n- `RecyclerView.Adapter.setHasStableIds` is efficient for layout performance, and it's easy way to introduce item animation.\r\n- For use above, SearchResultViewModel create id from session.id and which type of result (title, description, speaker).\r\n- Set white color to background of the RecyclerView in search page. without this, the alpha animation looks not good.\r\n\r\nThis PR is just a suggestion, so close If you don't like it or don't need it.\r\n\r\n## Links\r\n- [RecyclerView.Adapter#setHasStableIds(boolean)](https://developer.android.com/reference/android/support/v7/widget/RecyclerView.Adapter.html#setHasStableIds(boolean))\r\n\r\n## Screenshot\r\nBefore | After\r\n:--: | :--:\r\n<img src=\"https://cloud.githubusercontent.com/assets/949882/22855625/d36ee2ea-f0c6-11e6-817b-31a1bb984948.gif\" width=\"300\" /> | <img src=\"https://cloud.githubusercontent.com/assets/949882/22855619/bcc7ff2c-f0c6-11e6-9b58-d66ae81a3730.gif\" width=\"300\" />\r\n","created_at":"2017-02-12T01:20:27Z","updated_at":"2017-02-12T01:52:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa5a500dc8cd28496c0cbd78a43d2c62fedbaa53","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/309/commits","review_comments_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/309/comments","review_comment_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/309/comments","statuses_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/statuses/0540b7b6f9f3c8d463e665fbaf0193f61c324a54","head":{"label":"yatatsu:animate-search-result-items","ref":"animate-search-result-items","sha":"0540b7b6f9f3c8d463e665fbaf0193f61c324a54","user":{"login":"yatatsu","id":949882,"avatar_url":"https://avatars.githubusercontent.com/u/949882?v=3","gravatar_id":"","url":"https://api.github.com/users/yatatsu","html_url":"https://github.com/yatatsu","followers_url":"https://api.github.com/users/yatatsu/followers","following_url":"https://api.github.com/users/yatatsu/following{/other_user}","gists_url":"https://api.github.com/users/yatatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/yatatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatatsu/subscriptions","organizations_url":"https://api.github.com/users/yatatsu/orgs","repos_url":"https://api.github.com/users/yatatsu/repos","events_url":"https://api.github.com/users/yatatsu/events{/privacy}","received_events_url":"https://api.github.com/users/yatatsu/received_events","type":"User","site_admin":false},"repo":{"id":81226002,"name":"conference-app-2017","full_name":"yatatsu/conference-app-2017","owner":{"login":"yatatsu","id":949882,"avatar_url":"https://avatars.githubusercontent.com/u/949882?v=3","gravatar_id":"","url":"https://api.github.com/users/yatatsu","html_url":"https://github.com/yatatsu","followers_url":"https://api.github.com/users/yatatsu/followers","following_url":"https://api.github.com/users/yatatsu/following{/other_user}","gists_url":"https://api.github.com/users/yatatsu/gists{/gist_id}","starred_url":"https://api.github.com/users/yatatsu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yatatsu/subscriptions","organizations_url":"https://api.github.com/users/yatatsu/orgs","repos_url":"https://api.github.com/users/yatatsu/repos","events_url":"https://api.github.com/users/yatatsu/events{/privacy}","received_events_url":"https://api.github.com/users/yatatsu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yatatsu/conference-app-2017","description":"The Official Conference App for DroidKaigi 2017 Tokyo","fork":true,"url":"https://api.github.com/repos/yatatsu/conference-app-2017","forks_url":"https://api.github.com/repos/yatatsu/conference-app-2017/forks","keys_url":"https://api.github.com/repos/yatatsu/conference-app-2017/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yatatsu/conference-app-2017/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yatatsu/conference-app-2017/teams","hooks_url":"https://api.github.com/repos/yatatsu/conference-app-2017/hooks","issue_events_url":"https://api.github.com/repos/yatatsu/conference-app-2017/issues/events{/number}","events_url":"https://api.github.com/repos/yatatsu/conference-app-2017/events","assignees_url":"https://api.github.com/repos/yatatsu/conference-app-2017/assignees{/user}","branches_url":"https://api.github.com/repos/yatatsu/conference-app-2017/branches{/branch}","tags_url":"https://api.github.com/repos/yatatsu/conference-app-2017/tags","blobs_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/refs{/sha}","trees_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yatatsu/conference-app-2017/statuses/{sha}","languages_url":"https://api.github.com/repos/yatatsu/conference-app-2017/languages","stargazers_url":"https://api.github.com/repos/yatatsu/conference-app-2017/stargazers","contributors_url":"https://api.github.com/repos/yatatsu/conference-app-2017/contributors","subscribers_url":"https://api.github.com/repos/yatatsu/conference-app-2017/subscribers","subscription_url":"https://api.github.com/repos/yatatsu/conference-app-2017/subscription","commits_url":"https://api.github.com/repos/yatatsu/conference-app-2017/commits{/sha}","git_commits_url":"https://api.github.com/repos/yatatsu/conference-app-2017/git/commits{/sha}","comments_url":"https://api.github.com/repos/yatatsu/conference-app-2017/comments{/number}","issue_comment_url":"https://api.github.com/repos/yatatsu/conference-app-2017/issues/comments{/number}","contents_url":"https://api.github.com/repos/yatatsu/conference-app-2017/contents/{+path}","compare_url":"https://api.github.com/repos/yatatsu/conference-app-2017/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yatatsu/conference-app-2017/merges","archive_url":"https://api.github.com/repos/yatatsu/conference-app-2017/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yatatsu/conference-app-2017/downloads","issues_url":"https://api.github.com/repos/yatatsu/conference-app-2017/issues{/number}","pulls_url":"https://api.github.com/repos/yatatsu/conference-app-2017/pulls{/number}","milestones_url":"https://api.github.com/repos/yatatsu/conference-app-2017/milestones{/number}","notifications_url":"https://api.github.com/repos/yatatsu/conference-app-2017/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yatatsu/conference-app-2017/labels{/name}","releases_url":"https://api.github.com/repos/yatatsu/conference-app-2017/releases{/id}","deployments_url":"https://api.github.com/repos/yatatsu/conference-app-2017/deployments","created_at":"2017-02-07T15:57:11Z","updated_at":"2017-02-07T15:57:12Z","pushed_at":"2017-02-11T16:43:18Z","git_url":"git://github.com/yatatsu/conference-app-2017.git","ssh_url":"git@github.com:yatatsu/conference-app-2017.git","clone_url":"https://github.com/yatatsu/conference-app-2017.git","svn_url":"https://github.com/yatatsu/conference-app-2017","homepage":"","size":11641,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DroidKaigi:master","ref":"master","sha":"85bd5fe6e3da6e11625d3700605eae095a12ae8f","user":{"login":"DroidKaigi","id":10727543,"avatar_url":"https://avatars.githubusercontent.com/u/10727543?v=3","gravatar_id":"","url":"https://api.github.com/users/DroidKaigi","html_url":"https://github.com/DroidKaigi","followers_url":"https://api.github.com/users/DroidKaigi/followers","following_url":"https://api.github.com/users/DroidKaigi/following{/other_user}","gists_url":"https://api.github.com/users/DroidKaigi/gists{/gist_id}","starred_url":"https://api.github.com/users/DroidKaigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DroidKaigi/subscriptions","organizations_url":"https://api.github.com/users/DroidKaigi/orgs","repos_url":"https://api.github.com/users/DroidKaigi/repos","events_url":"https://api.github.com/users/DroidKaigi/events{/privacy}","received_events_url":"https://api.github.com/users/DroidKaigi/received_events","type":"Organization","site_admin":false},"repo":{"id":79104433,"name":"conference-app-2017","full_name":"DroidKaigi/conference-app-2017","owner":{"login":"DroidKaigi","id":10727543,"avatar_url":"https://avatars.githubusercontent.com/u/10727543?v=3","gravatar_id":"","url":"https://api.github.com/users/DroidKaigi","html_url":"https://github.com/DroidKaigi","followers_url":"https://api.github.com/users/DroidKaigi/followers","following_url":"https://api.github.com/users/DroidKaigi/following{/other_user}","gists_url":"https://api.github.com/users/DroidKaigi/gists{/gist_id}","starred_url":"https://api.github.com/users/DroidKaigi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DroidKaigi/subscriptions","organizations_url":"https://api.github.com/users/DroidKaigi/orgs","repos_url":"https://api.github.com/users/DroidKaigi/repos","events_url":"https://api.github.com/users/DroidKaigi/events{/privacy}","received_events_url":"https://api.github.com/users/DroidKaigi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DroidKaigi/conference-app-2017","description":"The Official Conference App for DroidKaigi 2017 Tokyo","fork":false,"url":"https://api.github.com/repos/DroidKaigi/conference-app-2017","forks_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/forks","keys_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/teams","hooks_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/hooks","issue_events_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/events{/number}","events_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/events","assignees_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/assignees{/user}","branches_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/branches{/branch}","tags_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/tags","blobs_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/refs{/sha}","trees_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/statuses/{sha}","languages_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/languages","stargazers_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/stargazers","contributors_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/contributors","subscribers_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/subscribers","subscription_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/subscription","commits_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/commits{/sha}","git_commits_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/git/commits{/sha}","comments_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/comments{/number}","issue_comment_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/comments{/number}","contents_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/contents/{+path}","compare_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/merges","archive_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/downloads","issues_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues{/number}","pulls_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls{/number}","milestones_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/milestones{/number}","notifications_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/labels{/name}","releases_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/releases{/id}","deployments_url":"https://api.github.com/repos/DroidKaigi/conference-app-2017/deployments","created_at":"2017-01-16T09:47:53Z","updated_at":"2017-02-11T22:44:58Z","pushed_at":"2017-02-12T01:20:27Z","git_url":"git://github.com/DroidKaigi/conference-app-2017.git","ssh_url":"git@github.com:DroidKaigi/conference-app-2017.git","clone_url":"https://github.com/DroidKaigi/conference-app-2017.git","svn_url":"https://github.com/DroidKaigi/conference-app-2017","homepage":"","size":11652,"stargazers_count":273,"watchers_count":273,"language":"HTML","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"open_issues_count":35,"forks":88,"open_issues":35,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/309"},"html":{"href":"https://github.com/DroidKaigi/conference-app-2017/pull/309"},"issue":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/309"},"comments":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/DroidKaigi/conference-app-2017/statuses/0540b7b6f9f3c8d463e665fbaf0193f61c324a54"}}}}
{"actor":{"display_login":"konifar"}}