{"action":"created","comment":{"url":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/comments/135419631","pull_request_review_id":58830295,"id":135419631,"diff_hunk":"@@ -0,0 +1,69 @@\n+/*\n+  Copyright (C) 2006-2008 Hans-Christoph Steiner.  All rights reserved.\n+  Copyright (C) 2010-2011 Paul Stoffregen.  All rights reserved.\n+  Copyright (C) 2009 Shigeru Kobayashi.  All rights reserved.\n+  Copyright (C) 2013 Norbert Truchsess. All rights reserved.\n+  Copyright (C) 2009-2016 Jeff Hoefs.  All rights reserved.\n+\n+  This library is free software; you can redistribute it and/or\n+  modify it under the terms of the GNU Lesser General Public\n+  License as published by the Free Software Foundation; either\n+  version 2.1 of the License, or (at your option) any later version.\n+\n+  See file LICENSE.txt for further informations on licensing terms.\n+*/\n+\n+#ifndef AccelStepperFirmata_h\n+#define AccelStepperFirmata_h\n+\n+#include <ConfigurableFirmata.h>\n+#include \"utility/AccelStepper.h\"\n+#include \"utility/MultiStepper.h\"\n+#include \"FirmataFeature.h\"\n+\n+#define MAX_STEPPERS 10 // arbitrary value... may need to adjust","path":"src/AccelStepperFirmata.h","position":24,"original_position":24,"commit_id":"0ff0b2ec20b9f8ad4c543f145fde1a2fd83c96c8","original_commit_id":"0ff0b2ec20b9f8ad4c543f145fde1a2fd83c96c8","user":{"login":"soundanalogous","id":401539,"avatar_url":"https://avatars3.githubusercontent.com/u/401539?v=4","gravatar_id":"","url":"https://api.github.com/users/soundanalogous","html_url":"https://github.com/soundanalogous","followers_url":"https://api.github.com/users/soundanalogous/followers","following_url":"https://api.github.com/users/soundanalogous/following{/other_user}","gists_url":"https://api.github.com/users/soundanalogous/gists{/gist_id}","starred_url":"https://api.github.com/users/soundanalogous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soundanalogous/subscriptions","organizations_url":"https://api.github.com/users/soundanalogous/orgs","repos_url":"https://api.github.com/users/soundanalogous/repos","events_url":"https://api.github.com/users/soundanalogous/events{/privacy}","received_events_url":"https://api.github.com/users/soundanalogous/received_events","type":"User","site_admin":false},"body":"The legacy stepper class declares `MAX_STEPPERS` as 6. In the rare event a user includes both stepper classes there is a potential conflict here.","created_at":"2017-08-27T19:54:47Z","updated_at":"2017-08-27T19:54:47Z","html_url":"https://github.com/firmata/ConfigurableFirmata/pull/72#discussion_r135419631","pull_request_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/72","_links":{"self":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/comments/135419631"},"html":{"href":"https://github.com/firmata/ConfigurableFirmata/pull/72#discussion_r135419631"},"pull_request":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/72"}}},"pull_request":{"url":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/72","id":128675124,"html_url":"https://github.com/firmata/ConfigurableFirmata/pull/72","diff_url":"https://github.com/firmata/ConfigurableFirmata/pull/72.diff","patch_url":"https://github.com/firmata/ConfigurableFirmata/pull/72.patch","issue_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/issues/72","number":72,"state":"open","locked":false,"title":"[WIP] accelStepper for configurable firmata","user":{"login":"dtex","id":854911,"avatar_url":"https://avatars0.githubusercontent.com/u/854911?v=4","gravatar_id":"","url":"https://api.github.com/users/dtex","html_url":"https://github.com/dtex","followers_url":"https://api.github.com/users/dtex/followers","following_url":"https://api.github.com/users/dtex/following{/other_user}","gists_url":"https://api.github.com/users/dtex/gists{/gist_id}","starred_url":"https://api.github.com/users/dtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtex/subscriptions","organizations_url":"https://api.github.com/users/dtex/orgs","repos_url":"https://api.github.com/users/dtex/repos","events_url":"https://api.github.com/users/dtex/events{/privacy}","received_events_url":"https://api.github.com/users/dtex/received_events","type":"User","site_admin":false},"body":"I have lots of testing to do here so don't merge. Need to track down lots of different steppers and drivers to test with hardware. Which micro controllers do you recommend testing on?\r\n\r\nNo hablo C++ so I am wide open to comments on code and style. \r\n\r\n@soundanalogous You mentioned that you want to just call this stepper instead of stepper2. It seems possible that you could get higher step speed from the original stepper code because there is less overhead. I need to test and prove that true, but maybe there is an argument to be made for having both. If so, maybe we could call this accelStepperFirmata instead of stepper2?\r\n\r\naccelStepper & multiStepper are unmodified from the original so should I remove them from the PR and just instruct user to install?","created_at":"2017-07-03T18:11:16Z","updated_at":"2017-08-27T19:54:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95ea0eeb5f10e9869977beca4e0f75826a019ddf","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/72/commits","review_comments_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/72/comments","review_comment_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/issues/72/comments","statuses_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/statuses/0ff0b2ec20b9f8ad4c543f145fde1a2fd83c96c8","head":{"label":"dtex:master","ref":"master","sha":"0ff0b2ec20b9f8ad4c543f145fde1a2fd83c96c8","user":{"login":"dtex","id":854911,"avatar_url":"https://avatars0.githubusercontent.com/u/854911?v=4","gravatar_id":"","url":"https://api.github.com/users/dtex","html_url":"https://github.com/dtex","followers_url":"https://api.github.com/users/dtex/followers","following_url":"https://api.github.com/users/dtex/following{/other_user}","gists_url":"https://api.github.com/users/dtex/gists{/gist_id}","starred_url":"https://api.github.com/users/dtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtex/subscriptions","organizations_url":"https://api.github.com/users/dtex/orgs","repos_url":"https://api.github.com/users/dtex/repos","events_url":"https://api.github.com/users/dtex/events{/privacy}","received_events_url":"https://api.github.com/users/dtex/received_events","type":"User","site_admin":false},"repo":{"id":60645607,"name":"ConfigurableFirmata","full_name":"dtex/ConfigurableFirmata","owner":{"login":"dtex","id":854911,"avatar_url":"https://avatars0.githubusercontent.com/u/854911?v=4","gravatar_id":"","url":"https://api.github.com/users/dtex","html_url":"https://github.com/dtex","followers_url":"https://api.github.com/users/dtex/followers","following_url":"https://api.github.com/users/dtex/following{/other_user}","gists_url":"https://api.github.com/users/dtex/gists{/gist_id}","starred_url":"https://api.github.com/users/dtex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtex/subscriptions","organizations_url":"https://api.github.com/users/dtex/orgs","repos_url":"https://api.github.com/users/dtex/repos","events_url":"https://api.github.com/users/dtex/events{/privacy}","received_events_url":"https://api.github.com/users/dtex/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtex/ConfigurableFirmata","description":"A plugin-based version of Firmata","fork":true,"url":"https://api.github.com/repos/dtex/ConfigurableFirmata","forks_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/forks","keys_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/teams","hooks_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/hooks","issue_events_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/issues/events{/number}","events_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/events","assignees_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/assignees{/user}","branches_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/branches{/branch}","tags_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/tags","blobs_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/statuses/{sha}","languages_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/languages","stargazers_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/stargazers","contributors_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/contributors","subscribers_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/subscribers","subscription_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/subscription","commits_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/contents/{+path}","compare_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/merges","archive_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/downloads","issues_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/issues{/number}","pulls_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/pulls{/number}","milestones_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/milestones{/number}","notifications_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/labels{/name}","releases_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/releases{/id}","deployments_url":"https://api.github.com/repos/dtex/ConfigurableFirmata/deployments","created_at":"2016-06-07T20:52:29Z","updated_at":"2016-06-07T20:52:30Z","pushed_at":"2017-08-05T22:17:51Z","git_url":"git://github.com/dtex/ConfigurableFirmata.git","ssh_url":"git@github.com:dtex/ConfigurableFirmata.git","clone_url":"https://github.com/dtex/ConfigurableFirmata.git","svn_url":"https://github.com/dtex/ConfigurableFirmata","homepage":null,"size":793,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"firmata:master","ref":"master","sha":"80df15693f3e165d9fe93e9be28b196c888c07c8","user":{"login":"firmata","id":1351140,"avatar_url":"https://avatars3.githubusercontent.com/u/1351140?v=4","gravatar_id":"","url":"https://api.github.com/users/firmata","html_url":"https://github.com/firmata","followers_url":"https://api.github.com/users/firmata/followers","following_url":"https://api.github.com/users/firmata/following{/other_user}","gists_url":"https://api.github.com/users/firmata/gists{/gist_id}","starred_url":"https://api.github.com/users/firmata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firmata/subscriptions","organizations_url":"https://api.github.com/users/firmata/orgs","repos_url":"https://api.github.com/users/firmata/repos","events_url":"https://api.github.com/users/firmata/events{/privacy}","received_events_url":"https://api.github.com/users/firmata/received_events","type":"Organization","site_admin":false},"repo":{"id":34223946,"name":"ConfigurableFirmata","full_name":"firmata/ConfigurableFirmata","owner":{"login":"firmata","id":1351140,"avatar_url":"https://avatars3.githubusercontent.com/u/1351140?v=4","gravatar_id":"","url":"https://api.github.com/users/firmata","html_url":"https://github.com/firmata","followers_url":"https://api.github.com/users/firmata/followers","following_url":"https://api.github.com/users/firmata/following{/other_user}","gists_url":"https://api.github.com/users/firmata/gists{/gist_id}","starred_url":"https://api.github.com/users/firmata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firmata/subscriptions","organizations_url":"https://api.github.com/users/firmata/orgs","repos_url":"https://api.github.com/users/firmata/repos","events_url":"https://api.github.com/users/firmata/events{/privacy}","received_events_url":"https://api.github.com/users/firmata/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/firmata/ConfigurableFirmata","description":"A plugin-based version of Firmata","fork":false,"url":"https://api.github.com/repos/firmata/ConfigurableFirmata","forks_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/forks","keys_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/teams","hooks_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/hooks","issue_events_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/issues/events{/number}","events_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/events","assignees_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/assignees{/user}","branches_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/branches{/branch}","tags_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/tags","blobs_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/git/refs{/sha}","trees_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/statuses/{sha}","languages_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/languages","stargazers_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/stargazers","contributors_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/contributors","subscribers_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/subscribers","subscription_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/subscription","commits_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/commits{/sha}","git_commits_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/git/commits{/sha}","comments_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/comments{/number}","issue_comment_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/issues/comments{/number}","contents_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/contents/{+path}","compare_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/merges","archive_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/downloads","issues_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/issues{/number}","pulls_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls{/number}","milestones_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/milestones{/number}","notifications_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/labels{/name}","releases_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/releases{/id}","deployments_url":"https://api.github.com/repos/firmata/ConfigurableFirmata/deployments","created_at":"2015-04-19T20:51:40Z","updated_at":"2017-08-02T17:56:43Z","pushed_at":"2017-08-05T22:17:52Z","git_url":"git://github.com/firmata/ConfigurableFirmata.git","ssh_url":"git@github.com:firmata/ConfigurableFirmata.git","clone_url":"https://github.com/firmata/ConfigurableFirmata.git","svn_url":"https://github.com/firmata/ConfigurableFirmata","homepage":null,"size":774,"stargazers_count":55,"watchers_count":55,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"open_issues_count":26,"forks":26,"open_issues":26,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/72"},"html":{"href":"https://github.com/firmata/ConfigurableFirmata/pull/72"},"issue":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/issues/72"},"comments":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/issues/72/comments"},"review_comments":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/72/comments"},"review_comment":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/pulls/72/commits"},"statuses":{"href":"https://api.github.com/repos/firmata/ConfigurableFirmata/statuses/0ff0b2ec20b9f8ad4c543f145fde1a2fd83c96c8"}}}}
{"actor":{"display_login":"soundanalogous"}}