{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/122942363","pull_request_review_id":45098752,"id":122942363,"diff_hunk":"@@ -0,0 +1,32 @@\n+class AddOptionsToExtManagementSystem < ActiveRecord::Migration[5.0]\n+  class ExtManagementSystem < ActiveRecord::Base\n+    self.inheritance_column = :_type_disabled\n+    serialize :options\n+  end\n+  class CustomAttribute < ActiveRecord::Base\n+    serialize :serialized_value\n+  end\n+\n+  def up\n+    add_column :ext_management_systems, :options, :text\n+\n+    say_with_time(\"Migrating Kubernetes provider options\") do\n+      ExtManagementSystem.where(:type => \"ManageIQ::Providers::Kubernetes::ContainerManager\").each do |cp|\n+        migrated_options = {}\n+        CustomAttribute.where(\n+          :resource_type => cp.type,\n+          :resource_id   => cp.id,\n+          :section       => ManageIQ::Providers::Kubernetes::ContainerManager::Scanning::Job::ATTRIBUTE_SECTION,\n+          :name          => ManageIQ::Providers::Kubernetes::ContainerManager::Scanning::Job::PROXY_ENV_VARIABLES","path":"db/migrate/20170619161514_add_options_to_ext_management_system.rb","position":20,"original_position":20,"commit_id":"fca068aa9054910e600787192d831027a79a0903","original_commit_id":"fca068aa9054910e600787192d831027a79a0903","user":{"login":"simon3z","id":130393,"avatar_url":"https://avatars2.githubusercontent.com/u/130393?v=3","gravatar_id":"","url":"https://api.github.com/users/simon3z","html_url":"https://github.com/simon3z","followers_url":"https://api.github.com/users/simon3z/followers","following_url":"https://api.github.com/users/simon3z/following{/other_user}","gists_url":"https://api.github.com/users/simon3z/gists{/gist_id}","starred_url":"https://api.github.com/users/simon3z/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simon3z/subscriptions","organizations_url":"https://api.github.com/users/simon3z/orgs","repos_url":"https://api.github.com/users/simon3z/repos","events_url":"https://api.github.com/users/simon3z/events{/privacy}","received_events_url":"https://api.github.com/users/simon3z/received_events","type":"User","site_admin":false},"body":"@enoodle as mentioned before I am not sure if we can afford this dependency to the Kubernetes module. cc @blomquisg You may have to hard-code the values here.","created_at":"2017-06-20T10:50:35Z","updated_at":"2017-06-20T10:50:35Z","html_url":"https://github.com/ManageIQ/manageiq/pull/15398#discussion_r122942363","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/15398","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/122942363"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/15398#discussion_r122942363"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/15398"}}},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/15398","id":126360759,"html_url":"https://github.com/ManageIQ/manageiq/pull/15398","diff_url":"https://github.com/ManageIQ/manageiq/pull/15398.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/15398.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/15398","number":15398,"state":"open","locked":false,"title":"Adding options field to ext_management_system","user":{"login":"enoodle","id":3123328,"avatar_url":"https://avatars1.githubusercontent.com/u/3123328?v=3","gravatar_id":"","url":"https://api.github.com/users/enoodle","html_url":"https://github.com/enoodle","followers_url":"https://api.github.com/users/enoodle/followers","following_url":"https://api.github.com/users/enoodle/following{/other_user}","gists_url":"https://api.github.com/users/enoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/enoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enoodle/subscriptions","organizations_url":"https://api.github.com/users/enoodle/orgs","repos_url":"https://api.github.com/users/enoodle/repos","events_url":"https://api.github.com/users/enoodle/events{/privacy}","received_events_url":"https://api.github.com/users/enoodle/received_events","type":"User","site_admin":false},"body":"This will add the serialzed column `options` to `ExtManagementSystem`.\r\nThere is also a migration for `ManageIQ::Providers::Kubernetes::ContainerManager` options that where saved in `CustomAttribute`s and general settings but should be there. This takes inspiration from https://github.com/ManageIQ/manageiq/pull/13826 and https://github.com/ManageIQ/manageiq/pull/14106 but the options details will be added in a later stage in the appropriate provider modules.\r\n\r\nRFE BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1462835","created_at":"2017-06-19T17:52:24Z","updated_at":"2017-06-20T10:50:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cf4ccf2689e7e87d9d0f85bf5035c0e5f8eb114","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/15398/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/15398/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/15398/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/fca068aa9054910e600787192d831027a79a0903","head":{"label":"enoodle:add_options_to_ems","ref":"add_options_to_ems","sha":"fca068aa9054910e600787192d831027a79a0903","user":{"login":"enoodle","id":3123328,"avatar_url":"https://avatars1.githubusercontent.com/u/3123328?v=3","gravatar_id":"","url":"https://api.github.com/users/enoodle","html_url":"https://github.com/enoodle","followers_url":"https://api.github.com/users/enoodle/followers","following_url":"https://api.github.com/users/enoodle/following{/other_user}","gists_url":"https://api.github.com/users/enoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/enoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enoodle/subscriptions","organizations_url":"https://api.github.com/users/enoodle/orgs","repos_url":"https://api.github.com/users/enoodle/repos","events_url":"https://api.github.com/users/enoodle/events{/privacy}","received_events_url":"https://api.github.com/users/enoodle/received_events","type":"User","site_admin":false},"repo":{"id":46660021,"name":"manageiq","full_name":"enoodle/manageiq","owner":{"login":"enoodle","id":3123328,"avatar_url":"https://avatars1.githubusercontent.com/u/3123328?v=3","gravatar_id":"","url":"https://api.github.com/users/enoodle","html_url":"https://github.com/enoodle","followers_url":"https://api.github.com/users/enoodle/followers","following_url":"https://api.github.com/users/enoodle/following{/other_user}","gists_url":"https://api.github.com/users/enoodle/gists{/gist_id}","starred_url":"https://api.github.com/users/enoodle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enoodle/subscriptions","organizations_url":"https://api.github.com/users/enoodle/orgs","repos_url":"https://api.github.com/users/enoodle/repos","events_url":"https://api.github.com/users/enoodle/events{/privacy}","received_events_url":"https://api.github.com/users/enoodle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/enoodle/manageiq","description":"ManageIQ Cloud Management Platform","fork":true,"url":"https://api.github.com/repos/enoodle/manageiq","forks_url":"https://api.github.com/repos/enoodle/manageiq/forks","keys_url":"https://api.github.com/repos/enoodle/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/enoodle/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/enoodle/manageiq/teams","hooks_url":"https://api.github.com/repos/enoodle/manageiq/hooks","issue_events_url":"https://api.github.com/repos/enoodle/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/enoodle/manageiq/events","assignees_url":"https://api.github.com/repos/enoodle/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/enoodle/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/enoodle/manageiq/tags","blobs_url":"https://api.github.com/repos/enoodle/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/enoodle/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/enoodle/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/enoodle/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/enoodle/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/enoodle/manageiq/languages","stargazers_url":"https://api.github.com/repos/enoodle/manageiq/stargazers","contributors_url":"https://api.github.com/repos/enoodle/manageiq/contributors","subscribers_url":"https://api.github.com/repos/enoodle/manageiq/subscribers","subscription_url":"https://api.github.com/repos/enoodle/manageiq/subscription","commits_url":"https://api.github.com/repos/enoodle/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/enoodle/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/enoodle/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/enoodle/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/enoodle/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/enoodle/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/enoodle/manageiq/merges","archive_url":"https://api.github.com/repos/enoodle/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/enoodle/manageiq/downloads","issues_url":"https://api.github.com/repos/enoodle/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/enoodle/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/enoodle/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/enoodle/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/enoodle/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/enoodle/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/enoodle/manageiq/deployments","created_at":"2015-11-22T12:39:19Z","updated_at":"2015-11-22T12:39:42Z","pushed_at":"2017-06-20T10:22:20Z","git_url":"git://github.com/enoodle/manageiq.git","ssh_url":"git@github.com:enoodle/manageiq.git","clone_url":"https://github.com/enoodle/manageiq.git","svn_url":"https://github.com/enoodle/manageiq","homepage":"manageiq.org","size":191913,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"acf668b1a4714aa9fff6257db36665bf70a7be84","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars3.githubusercontent.com/u/1125575?v=3","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2017-06-18T14:55:01Z","pushed_at":"2017-06-20T10:22:22Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":198452,"stargazers_count":476,"watchers_count":476,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":479,"mirror_url":null,"open_issues_count":864,"forks":479,"open_issues":864,"watchers":476,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/15398"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/15398"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/15398"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/15398/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/15398/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/15398/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/fca068aa9054910e600787192d831027a79a0903"}}}}
{"actor":{"display_login":"simon3z"}}