{"action":"created","comment":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/134768225","pull_request_review_id":58098820,"id":134768225,"diff_hunk":"@@ -14,6 +14,8 @@\n     \"lint\": \"lerna run lint\",\n     \"publish\": \"node scripts/publish.js\",\n     \"test\": \"lerna run test --concurrency 1\",\n+    \"test:without-system-tests\": \"lerna run test --ignore system-tests --concurrency 1\",","path":"package.json","position":13,"original_position":13,"commit_id":"c2d271d9139a474046797b284d8bb7a629097c3e","original_commit_id":"c2d271d9139a474046797b284d8bb7a629097c3e","user":{"login":"vazexqi","id":54414,"avatar_url":"https://avatars1.githubusercontent.com/u/54414?v=4","gravatar_id":"","url":"https://api.github.com/users/vazexqi","html_url":"https://github.com/vazexqi","followers_url":"https://api.github.com/users/vazexqi/followers","following_url":"https://api.github.com/users/vazexqi/following{/other_user}","gists_url":"https://api.github.com/users/vazexqi/gists{/gist_id}","starred_url":"https://api.github.com/users/vazexqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vazexqi/subscriptions","organizations_url":"https://api.github.com/users/vazexqi/orgs","repos_url":"https://api.github.com/users/vazexqi/repos","events_url":"https://api.github.com/users/vazexqi/events{/privacy}","received_events_url":"https://api.github.com/users/vazexqi/received_events","type":"User","site_admin":false},"body":"@guw I did separate out the tests (system vs non-system vs all) so we can use this if we decide to control where the system tests run. Right now, I am using this to control that the system tests do not run on OS X on Travis.","created_at":"2017-08-23T14:30:07Z","updated_at":"2017-08-23T14:30:07Z","html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/59#discussion_r134768225","pull_request_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/59","_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments/134768225"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/59#discussion_r134768225"},"pull_request":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/59"}}},"pull_request":{"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/59","id":136873492,"html_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/59","diff_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/59.diff","patch_url":"https://github.com/forcedotcom/salesforcedx-vscode/pull/59.patch","issue_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/59","number":59,"state":"closed","locked":false,"title":"End-to-end system tests with Spectron","user":{"login":"vazexqi","id":54414,"avatar_url":"https://avatars1.githubusercontent.com/u/54414?v=4","gravatar_id":"","url":"https://api.github.com/users/vazexqi","html_url":"https://github.com/vazexqi","followers_url":"https://api.github.com/users/vazexqi/followers","following_url":"https://api.github.com/users/vazexqi/following{/other_user}","gists_url":"https://api.github.com/users/vazexqi/gists{/gist_id}","starred_url":"https://api.github.com/users/vazexqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vazexqi/subscriptions","organizations_url":"https://api.github.com/users/vazexqi/orgs","repos_url":"https://api.github.com/users/vazexqi/repos","events_url":"https://api.github.com/users/vazexqi/events{/privacy}","received_events_url":"https://api.github.com/users/vazexqi/received_events","type":"User","site_admin":false},"body":"### What does this PR do?\r\n\r\nAdd end-to-end test for Apex class, Visualforce component, and Visualforce page creation through the Spectron framework and ensure that it can run on the CI systems and locally.\r\n\r\n### What is not in the scope of this PR?\r\n\r\nThis PR will not address code coverage with a custom runner yet. That will be done in a different PR to keep this one focused.\r\n\r\n### What issues does this PR fix or reference?\r\n\r\n@W-4248216@\r\n","created_at":"2017-08-22T01:22:17Z","updated_at":"2017-08-23T14:30:07Z","closed_at":"2017-08-23T05:58:42Z","merged_at":"2017-08-23T05:58:42Z","merge_commit_sha":"9e4e470de8ab2ae6e147c300adec2193d3006eae","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/59/commits","review_comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/59/comments","review_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/59/comments","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/c2d271d9139a474046797b284d8bb7a629097c3e","head":{"label":"forcedotcom:nick/end-to-end-tests-with-spectron","ref":"nick/end-to-end-tests-with-spectron","sha":"c2d271d9139a474046797b284d8bb7a629097c3e","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":null,"fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2017-08-23T13:09:50Z","pushed_at":"2017-08-23T05:58:45Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":21980,"stargazers_count":35,"watchers_count":35,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":35,"default_branch":"develop"}},"base":{"label":"forcedotcom:develop","ref":"develop","sha":"15f8fdded3a6e1f17ff89123b27395b4e65a788a","user":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"repo":{"id":95021029,"name":"salesforcedx-vscode","full_name":"forcedotcom/salesforcedx-vscode","owner":{"login":"forcedotcom","id":464563,"avatar_url":"https://avatars3.githubusercontent.com/u/464563?v=4","gravatar_id":"","url":"https://api.github.com/users/forcedotcom","html_url":"https://github.com/forcedotcom","followers_url":"https://api.github.com/users/forcedotcom/followers","following_url":"https://api.github.com/users/forcedotcom/following{/other_user}","gists_url":"https://api.github.com/users/forcedotcom/gists{/gist_id}","starred_url":"https://api.github.com/users/forcedotcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/forcedotcom/subscriptions","organizations_url":"https://api.github.com/users/forcedotcom/orgs","repos_url":"https://api.github.com/users/forcedotcom/repos","events_url":"https://api.github.com/users/forcedotcom/events{/privacy}","received_events_url":"https://api.github.com/users/forcedotcom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/forcedotcom/salesforcedx-vscode","description":null,"fork":false,"url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode","forks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/forks","keys_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/teams","hooks_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/hooks","issue_events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/events{/number}","events_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/events","assignees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/assignees{/user}","branches_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/branches{/branch}","tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/tags","blobs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/refs{/sha}","trees_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/{sha}","languages_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/languages","stargazers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/stargazers","contributors_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contributors","subscribers_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscribers","subscription_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/subscription","commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/commits{/sha}","git_commits_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/git/commits{/sha}","comments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/comments{/number}","issue_comment_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/comments{/number}","contents_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/contents/{+path}","compare_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/merges","archive_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/downloads","issues_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues{/number}","pulls_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls{/number}","milestones_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/milestones{/number}","notifications_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/labels{/name}","releases_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/releases{/id}","deployments_url":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/deployments","created_at":"2017-06-21T15:53:45Z","updated_at":"2017-08-23T13:09:50Z","pushed_at":"2017-08-23T05:58:45Z","git_url":"git://github.com/forcedotcom/salesforcedx-vscode.git","ssh_url":"git@github.com:forcedotcom/salesforcedx-vscode.git","clone_url":"https://github.com/forcedotcom/salesforcedx-vscode.git","svn_url":"https://github.com/forcedotcom/salesforcedx-vscode","homepage":"","size":21980,"stargazers_count":35,"watchers_count":35,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"open_issues_count":3,"forks":6,"open_issues":3,"watchers":35,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/59"},"html":{"href":"https://github.com/forcedotcom/salesforcedx-vscode/pull/59"},"issue":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/59"},"comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/issues/59/comments"},"review_comments":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/59/comments"},"review_comment":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/pulls/59/commits"},"statuses":{"href":"https://api.github.com/repos/forcedotcom/salesforcedx-vscode/statuses/c2d271d9139a474046797b284d8bb7a629097c3e"}}}}
{"actor":{"display_login":"vazexqi"}}