{"action":"created","comment":{"url":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/comments/128159318","pull_request_review_id":50810376,"id":128159318,"diff_hunk":"@@ -904,7 +903,6 @@ def device_request(ip, mac):\n         # Log request.\n         ng.db.cursor.execute(\"SELECT request.rid, request.active FROM request WHERE request.ip = ? ORDER BY updated DESC LIMIT 1\", (ip,))\n         seen = ng.db.cursor.fetchone()\n-        rid, active = (False, False)","path":"netgrasp/netgrasp.py","position":30,"original_position":30,"commit_id":"3830b9ca5e4c9478a34e91d6c5a907b1d7f31830","original_commit_id":"3830b9ca5e4c9478a34e91d6c5a907b1d7f31830","user":{"login":"jeremyandrews","id":402892,"avatar_url":"https://avatars3.githubusercontent.com/u/402892?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyandrews","html_url":"https://github.com/jeremyandrews","followers_url":"https://api.github.com/users/jeremyandrews/followers","following_url":"https://api.github.com/users/jeremyandrews/following{/other_user}","gists_url":"https://api.github.com/users/jeremyandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyandrews/subscriptions","organizations_url":"https://api.github.com/users/jeremyandrews/orgs","repos_url":"https://api.github.com/users/jeremyandrews/repos","events_url":"https://api.github.com/users/jeremyandrews/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyandrews/received_events","type":"User","site_admin":false},"body":"good catch; I was convinced we used these later but reading the code I see they get set before use in both code paths","created_at":"2017-07-19T06:05:05Z","updated_at":"2017-07-19T06:05:05Z","html_url":"https://github.com/jeremyandrews/netgrasp/pull/23#discussion_r128159318","pull_request_url":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/23","_links":{"self":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/comments/128159318"},"html":{"href":"https://github.com/jeremyandrews/netgrasp/pull/23#discussion_r128159318"},"pull_request":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/23","id":131168419,"html_url":"https://github.com/jeremyandrews/netgrasp/pull/23","diff_url":"https://github.com/jeremyandrews/netgrasp/pull/23.diff","patch_url":"https://github.com/jeremyandrews/netgrasp/pull/23.patch","issue_url":"https://api.github.com/repos/jeremyandrews/netgrasp/issues/23","number":23,"state":"open","locked":false,"title":"general bug fixes to utils/cli.py","user":{"login":"natej","id":4108463,"avatar_url":"https://avatars0.githubusercontent.com/u/4108463?v=4","gravatar_id":"","url":"https://api.github.com/users/natej","html_url":"https://github.com/natej","followers_url":"https://api.github.com/users/natej/followers","following_url":"https://api.github.com/users/natej/following{/other_user}","gists_url":"https://api.github.com/users/natej/gists{/gist_id}","starred_url":"https://api.github.com/users/natej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natej/subscriptions","organizations_url":"https://api.github.com/users/natej/orgs","repos_url":"https://api.github.com/users/natej/repos","events_url":"https://api.github.com/users/natej/events{/privacy}","received_events_url":"https://api.github.com/users/natej/received_events","type":"User","site_admin":false},"body":"So this started out as an attempt to be able to run ng in\r\nthe foreground and still send \"signals\"/commands to it (pidfile).\r\nIt ended up not being worth it with subprocesses, pipes, etc.\r\nI.e. just start it, let it daemonize/fork and tail -f.\r\nThat's why there's the pep8 \"collateral damage\" in pretty and\r\nnetgrasp.\r\n\r\n- Fix invalid var references.\r\n- Refactor module usage/redundant imports.\r\n- Minor formatting.","created_at":"2017-07-18T19:32:07Z","updated_at":"2017-07-19T06:05:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f54ac6651f83e745d064f21deae560acf1e727c4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/23/commits","review_comments_url":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/23/comments","review_comment_url":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeremyandrews/netgrasp/issues/23/comments","statuses_url":"https://api.github.com/repos/jeremyandrews/netgrasp/statuses/3830b9ca5e4c9478a34e91d6c5a907b1d7f31830","head":{"label":"natej:bugfix-cli","ref":"bugfix-cli","sha":"3830b9ca5e4c9478a34e91d6c5a907b1d7f31830","user":{"login":"natej","id":4108463,"avatar_url":"https://avatars0.githubusercontent.com/u/4108463?v=4","gravatar_id":"","url":"https://api.github.com/users/natej","html_url":"https://github.com/natej","followers_url":"https://api.github.com/users/natej/followers","following_url":"https://api.github.com/users/natej/following{/other_user}","gists_url":"https://api.github.com/users/natej/gists{/gist_id}","starred_url":"https://api.github.com/users/natej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natej/subscriptions","organizations_url":"https://api.github.com/users/natej/orgs","repos_url":"https://api.github.com/users/natej/repos","events_url":"https://api.github.com/users/natej/events{/privacy}","received_events_url":"https://api.github.com/users/natej/received_events","type":"User","site_admin":false},"repo":{"id":97168485,"name":"netgrasp","full_name":"natej/netgrasp","owner":{"login":"natej","id":4108463,"avatar_url":"https://avatars0.githubusercontent.com/u/4108463?v=4","gravatar_id":"","url":"https://api.github.com/users/natej","html_url":"https://github.com/natej","followers_url":"https://api.github.com/users/natej/followers","following_url":"https://api.github.com/users/natej/following{/other_user}","gists_url":"https://api.github.com/users/natej/gists{/gist_id}","starred_url":"https://api.github.com/users/natej/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natej/subscriptions","organizations_url":"https://api.github.com/users/natej/orgs","repos_url":"https://api.github.com/users/natej/repos","events_url":"https://api.github.com/users/natej/events{/privacy}","received_events_url":"https://api.github.com/users/natej/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/natej/netgrasp","description":"Passive network observation tool","fork":true,"url":"https://api.github.com/repos/natej/netgrasp","forks_url":"https://api.github.com/repos/natej/netgrasp/forks","keys_url":"https://api.github.com/repos/natej/netgrasp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natej/netgrasp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natej/netgrasp/teams","hooks_url":"https://api.github.com/repos/natej/netgrasp/hooks","issue_events_url":"https://api.github.com/repos/natej/netgrasp/issues/events{/number}","events_url":"https://api.github.com/repos/natej/netgrasp/events","assignees_url":"https://api.github.com/repos/natej/netgrasp/assignees{/user}","branches_url":"https://api.github.com/repos/natej/netgrasp/branches{/branch}","tags_url":"https://api.github.com/repos/natej/netgrasp/tags","blobs_url":"https://api.github.com/repos/natej/netgrasp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natej/netgrasp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natej/netgrasp/git/refs{/sha}","trees_url":"https://api.github.com/repos/natej/netgrasp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natej/netgrasp/statuses/{sha}","languages_url":"https://api.github.com/repos/natej/netgrasp/languages","stargazers_url":"https://api.github.com/repos/natej/netgrasp/stargazers","contributors_url":"https://api.github.com/repos/natej/netgrasp/contributors","subscribers_url":"https://api.github.com/repos/natej/netgrasp/subscribers","subscription_url":"https://api.github.com/repos/natej/netgrasp/subscription","commits_url":"https://api.github.com/repos/natej/netgrasp/commits{/sha}","git_commits_url":"https://api.github.com/repos/natej/netgrasp/git/commits{/sha}","comments_url":"https://api.github.com/repos/natej/netgrasp/comments{/number}","issue_comment_url":"https://api.github.com/repos/natej/netgrasp/issues/comments{/number}","contents_url":"https://api.github.com/repos/natej/netgrasp/contents/{+path}","compare_url":"https://api.github.com/repos/natej/netgrasp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natej/netgrasp/merges","archive_url":"https://api.github.com/repos/natej/netgrasp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natej/netgrasp/downloads","issues_url":"https://api.github.com/repos/natej/netgrasp/issues{/number}","pulls_url":"https://api.github.com/repos/natej/netgrasp/pulls{/number}","milestones_url":"https://api.github.com/repos/natej/netgrasp/milestones{/number}","notifications_url":"https://api.github.com/repos/natej/netgrasp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natej/netgrasp/labels{/name}","releases_url":"https://api.github.com/repos/natej/netgrasp/releases{/id}","deployments_url":"https://api.github.com/repos/natej/netgrasp/deployments","created_at":"2017-07-13T22:05:38Z","updated_at":"2017-07-13T22:05:40Z","pushed_at":"2017-07-18T20:01:06Z","git_url":"git://github.com/natej/netgrasp.git","ssh_url":"git@github.com:natej/netgrasp.git","clone_url":"https://github.com/natej/netgrasp.git","svn_url":"https://github.com/natej/netgrasp","homepage":"","size":361,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jeremyandrews:master","ref":"master","sha":"88d3c474e93679214a5fb755cc18beb4973624f7","user":{"login":"jeremyandrews","id":402892,"avatar_url":"https://avatars3.githubusercontent.com/u/402892?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyandrews","html_url":"https://github.com/jeremyandrews","followers_url":"https://api.github.com/users/jeremyandrews/followers","following_url":"https://api.github.com/users/jeremyandrews/following{/other_user}","gists_url":"https://api.github.com/users/jeremyandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyandrews/subscriptions","organizations_url":"https://api.github.com/users/jeremyandrews/orgs","repos_url":"https://api.github.com/users/jeremyandrews/repos","events_url":"https://api.github.com/users/jeremyandrews/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyandrews/received_events","type":"User","site_admin":false},"repo":{"id":23604023,"name":"netgrasp","full_name":"jeremyandrews/netgrasp","owner":{"login":"jeremyandrews","id":402892,"avatar_url":"https://avatars3.githubusercontent.com/u/402892?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyandrews","html_url":"https://github.com/jeremyandrews","followers_url":"https://api.github.com/users/jeremyandrews/followers","following_url":"https://api.github.com/users/jeremyandrews/following{/other_user}","gists_url":"https://api.github.com/users/jeremyandrews/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyandrews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyandrews/subscriptions","organizations_url":"https://api.github.com/users/jeremyandrews/orgs","repos_url":"https://api.github.com/users/jeremyandrews/repos","events_url":"https://api.github.com/users/jeremyandrews/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyandrews/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeremyandrews/netgrasp","description":"Passive network observation tool","fork":false,"url":"https://api.github.com/repos/jeremyandrews/netgrasp","forks_url":"https://api.github.com/repos/jeremyandrews/netgrasp/forks","keys_url":"https://api.github.com/repos/jeremyandrews/netgrasp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeremyandrews/netgrasp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeremyandrews/netgrasp/teams","hooks_url":"https://api.github.com/repos/jeremyandrews/netgrasp/hooks","issue_events_url":"https://api.github.com/repos/jeremyandrews/netgrasp/issues/events{/number}","events_url":"https://api.github.com/repos/jeremyandrews/netgrasp/events","assignees_url":"https://api.github.com/repos/jeremyandrews/netgrasp/assignees{/user}","branches_url":"https://api.github.com/repos/jeremyandrews/netgrasp/branches{/branch}","tags_url":"https://api.github.com/repos/jeremyandrews/netgrasp/tags","blobs_url":"https://api.github.com/repos/jeremyandrews/netgrasp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeremyandrews/netgrasp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeremyandrews/netgrasp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeremyandrews/netgrasp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeremyandrews/netgrasp/statuses/{sha}","languages_url":"https://api.github.com/repos/jeremyandrews/netgrasp/languages","stargazers_url":"https://api.github.com/repos/jeremyandrews/netgrasp/stargazers","contributors_url":"https://api.github.com/repos/jeremyandrews/netgrasp/contributors","subscribers_url":"https://api.github.com/repos/jeremyandrews/netgrasp/subscribers","subscription_url":"https://api.github.com/repos/jeremyandrews/netgrasp/subscription","commits_url":"https://api.github.com/repos/jeremyandrews/netgrasp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeremyandrews/netgrasp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeremyandrews/netgrasp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeremyandrews/netgrasp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeremyandrews/netgrasp/contents/{+path}","compare_url":"https://api.github.com/repos/jeremyandrews/netgrasp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeremyandrews/netgrasp/merges","archive_url":"https://api.github.com/repos/jeremyandrews/netgrasp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeremyandrews/netgrasp/downloads","issues_url":"https://api.github.com/repos/jeremyandrews/netgrasp/issues{/number}","pulls_url":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls{/number}","milestones_url":"https://api.github.com/repos/jeremyandrews/netgrasp/milestones{/number}","notifications_url":"https://api.github.com/repos/jeremyandrews/netgrasp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeremyandrews/netgrasp/labels{/name}","releases_url":"https://api.github.com/repos/jeremyandrews/netgrasp/releases{/id}","deployments_url":"https://api.github.com/repos/jeremyandrews/netgrasp/deployments","created_at":"2014-09-03T02:43:56Z","updated_at":"2017-07-18T17:03:44Z","pushed_at":"2017-07-18T19:32:07Z","git_url":"git://github.com/jeremyandrews/netgrasp.git","ssh_url":"git@github.com:jeremyandrews/netgrasp.git","clone_url":"https://github.com/jeremyandrews/netgrasp.git","svn_url":"https://github.com/jeremyandrews/netgrasp","homepage":"","size":369,"stargazers_count":25,"watchers_count":25,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":13,"forks":1,"open_issues":13,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/23"},"html":{"href":"https://github.com/jeremyandrews/netgrasp/pull/23"},"issue":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/issues/23"},"comments":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/jeremyandrews/netgrasp/statuses/3830b9ca5e4c9478a34e91d6c5a907b1d7f31830"}}}}
{"actor":{"display_login":"jeremyandrews"}}