{"action":"closed","number":10531,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/10531","id":99723689,"html_url":"https://github.com/nodejs/node/pull/10531","diff_url":"https://github.com/nodejs/node/pull/10531.diff","patch_url":"https://github.com/nodejs/node/pull/10531.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/10531","number":10531,"state":"closed","locked":false,"title":"test: refactor the code in test-util-debug.js","user":{"login":"sivaprs","id":5655189,"avatar_url":"https://avatars.githubusercontent.com/u/5655189?v=3","gravatar_id":"","url":"https://api.github.com/users/sivaprs","html_url":"https://github.com/sivaprs","followers_url":"https://api.github.com/users/sivaprs/followers","following_url":"https://api.github.com/users/sivaprs/following{/other_user}","gists_url":"https://api.github.com/users/sivaprs/gists{/gist_id}","starred_url":"https://api.github.com/users/sivaprs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivaprs/subscriptions","organizations_url":"https://api.github.com/users/sivaprs/orgs","repos_url":"https://api.github.com/users/sivaprs/repos","events_url":"https://api.github.com/users/sivaprs/events{/privacy}","received_events_url":"https://api.github.com/users/sivaprs/received_events","type":"User","site_admin":false},"body":"* use const and let instead of var\r\n* use assert.strictEqual instead of assert.equal\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows commit guidelines\r\n\r\n##### Affected core subsystem(s)\r\ntest\r\n\r\nDescription\r\n\r\n* use const and let instead of var\r\n* use assert.strictEqual instead of assert.equal","created_at":"2016-12-30T05:35:51Z","updated_at":"2017-01-06T17:52:01Z","closed_at":"2017-01-06T17:52:01Z","merged_at":null,"merge_commit_sha":"8d0f970ef374c2ff220361dc9b77be326e1e7ff1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/10531/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/10531/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/10531/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/40921a52ce78b0016d54fcff68c30cf246a112f8","head":{"label":"sivaprs:test-2016","ref":"test-2016","sha":"40921a52ce78b0016d54fcff68c30cf246a112f8","user":{"login":"sivaprs","id":5655189,"avatar_url":"https://avatars.githubusercontent.com/u/5655189?v=3","gravatar_id":"","url":"https://api.github.com/users/sivaprs","html_url":"https://github.com/sivaprs","followers_url":"https://api.github.com/users/sivaprs/followers","following_url":"https://api.github.com/users/sivaprs/following{/other_user}","gists_url":"https://api.github.com/users/sivaprs/gists{/gist_id}","starred_url":"https://api.github.com/users/sivaprs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivaprs/subscriptions","organizations_url":"https://api.github.com/users/sivaprs/orgs","repos_url":"https://api.github.com/users/sivaprs/repos","events_url":"https://api.github.com/users/sivaprs/events{/privacy}","received_events_url":"https://api.github.com/users/sivaprs/received_events","type":"User","site_admin":false},"repo":{"id":76954111,"name":"node","full_name":"sivaprs/node","owner":{"login":"sivaprs","id":5655189,"avatar_url":"https://avatars.githubusercontent.com/u/5655189?v=3","gravatar_id":"","url":"https://api.github.com/users/sivaprs","html_url":"https://github.com/sivaprs","followers_url":"https://api.github.com/users/sivaprs/followers","following_url":"https://api.github.com/users/sivaprs/following{/other_user}","gists_url":"https://api.github.com/users/sivaprs/gists{/gist_id}","starred_url":"https://api.github.com/users/sivaprs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sivaprs/subscriptions","organizations_url":"https://api.github.com/users/sivaprs/orgs","repos_url":"https://api.github.com/users/sivaprs/repos","events_url":"https://api.github.com/users/sivaprs/events{/privacy}","received_events_url":"https://api.github.com/users/sivaprs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sivaprs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/sivaprs/node","forks_url":"https://api.github.com/repos/sivaprs/node/forks","keys_url":"https://api.github.com/repos/sivaprs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sivaprs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sivaprs/node/teams","hooks_url":"https://api.github.com/repos/sivaprs/node/hooks","issue_events_url":"https://api.github.com/repos/sivaprs/node/issues/events{/number}","events_url":"https://api.github.com/repos/sivaprs/node/events","assignees_url":"https://api.github.com/repos/sivaprs/node/assignees{/user}","branches_url":"https://api.github.com/repos/sivaprs/node/branches{/branch}","tags_url":"https://api.github.com/repos/sivaprs/node/tags","blobs_url":"https://api.github.com/repos/sivaprs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sivaprs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sivaprs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/sivaprs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sivaprs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/sivaprs/node/languages","stargazers_url":"https://api.github.com/repos/sivaprs/node/stargazers","contributors_url":"https://api.github.com/repos/sivaprs/node/contributors","subscribers_url":"https://api.github.com/repos/sivaprs/node/subscribers","subscription_url":"https://api.github.com/repos/sivaprs/node/subscription","commits_url":"https://api.github.com/repos/sivaprs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/sivaprs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/sivaprs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/sivaprs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/sivaprs/node/contents/{+path}","compare_url":"https://api.github.com/repos/sivaprs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sivaprs/node/merges","archive_url":"https://api.github.com/repos/sivaprs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sivaprs/node/downloads","issues_url":"https://api.github.com/repos/sivaprs/node/issues{/number}","pulls_url":"https://api.github.com/repos/sivaprs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/sivaprs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/sivaprs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sivaprs/node/labels{/name}","releases_url":"https://api.github.com/repos/sivaprs/node/releases{/id}","deployments_url":"https://api.github.com/repos/sivaprs/node/deployments","created_at":"2016-12-20T12:20:19Z","updated_at":"2016-12-20T12:20:46Z","pushed_at":"2017-01-04T07:34:59Z","git_url":"git://github.com/sivaprs/node.git","ssh_url":"git@github.com:sivaprs/node.git","clone_url":"https://github.com/sivaprs/node.git","svn_url":"https://github.com/sivaprs/node","homepage":"https://nodejs.org","size":251480,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"f2f997ad1e416fd5ba295e84139848f77b37c40f","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars.githubusercontent.com/u/9950313?v=3","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-01-06T17:50:07Z","pushed_at":"2017-01-06T17:50:53Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":252227,"stargazers_count":30440,"watchers_count":30440,"language":"JavaScript","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5496,"mirror_url":null,"open_issues_count":1021,"forks":5496,"open_issues":1021,"watchers":30440,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/10531"},"html":{"href":"https://github.com/nodejs/node/pull/10531"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/10531"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/10531/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/10531/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/10531/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/40921a52ce78b0016d54fcff68c30cf246a112f8"}},"merged":false,"mergeable":true,"mergeable_state":"unstable","merged_by":null,"comments":10,"review_comments":7,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":12,"changed_files":1}}
{"actor":{"display_login":"jasnell"}}