{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/143931502","pull_request_review_id":68513304,"id":143931502,"diff_hunk":"@@ -36,6 +36,7 @@ const testRoot = process.env.NODE_TEST_DIR ?\n \n const noop = () => {};\n \n+exports.fixtures = fixturesDir;","path":"test/common/index.js","position":4,"original_position":4,"commit_id":"ea1fc0cd66962d8bc4db7b165dd956acf8f66037","original_commit_id":"ea1fc0cd66962d8bc4db7b165dd956acf8f66037","user":{"login":"kanikashah90","id":2753761,"avatar_url":"https://avatars0.githubusercontent.com/u/2753761?v=4","gravatar_id":"","url":"https://api.github.com/users/kanikashah90","html_url":"https://github.com/kanikashah90","followers_url":"https://api.github.com/users/kanikashah90/followers","following_url":"https://api.github.com/users/kanikashah90/following{/other_user}","gists_url":"https://api.github.com/users/kanikashah90/gists{/gist_id}","starred_url":"https://api.github.com/users/kanikashah90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanikashah90/subscriptions","organizations_url":"https://api.github.com/users/kanikashah90/orgs","repos_url":"https://api.github.com/users/kanikashah90/repos","events_url":"https://api.github.com/users/kanikashah90/events{/privacy}","received_events_url":"https://api.github.com/users/kanikashah90/received_events","type":"User","site_admin":false},"body":"Got it. Will push out the change with the recommendation provided.","created_at":"2017-10-11T07:34:17Z","updated_at":"2017-10-11T07:34:17Z","html_url":"https://github.com/nodejs/node/pull/15959#discussion_r143931502","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/15959","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/143931502"},"html":{"href":"https://github.com/nodejs/node/pull/15959#discussion_r143931502"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/15959"}},"in_reply_to_id":143337166},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/15959","id":145209183,"html_url":"https://github.com/nodejs/node/pull/15959","diff_url":"https://github.com/nodejs/node/pull/15959.diff","patch_url":"https://github.com/nodejs/node/pull/15959.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/15959","number":15959,"state":"open","locked":false,"title":"Add 'fixtures' property to common.js exports","user":{"login":"kanikashah90","id":2753761,"avatar_url":"https://avatars0.githubusercontent.com/u/2753761?v=4","gravatar_id":"","url":"https://api.github.com/users/kanikashah90","html_url":"https://github.com/kanikashah90","followers_url":"https://api.github.com/users/kanikashah90/followers","following_url":"https://api.github.com/users/kanikashah90/following{/other_user}","gists_url":"https://api.github.com/users/kanikashah90/gists{/gist_id}","starred_url":"https://api.github.com/users/kanikashah90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanikashah90/subscriptions","organizations_url":"https://api.github.com/users/kanikashah90/orgs","repos_url":"https://api.github.com/users/kanikashah90/repos","events_url":"https://api.github.com/users/kanikashah90/events{/privacy}","received_events_url":"https://api.github.com/users/kanikashah90/received_events","type":"User","site_admin":false},"body":"Two tasks are involved as part of this change:\r\n1. Add 'fixtures' property to common.js.\r\n2. Use the new 'fixtures' property of common.js in test-fs-error-messages.js instead of 'fixturesDir'\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-message-guidelines)\r\n\r\n<!--Affected core subsystem(s)\r\n Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\n","created_at":"2017-10-06T17:45:27Z","updated_at":"2017-10-11T07:34:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dcb916fab9ab4517346faf7f3e45ffb5ab55ea2","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/15959/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/15959/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/15959/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/ea1fc0cd66962d8bc4db7b165dd956acf8f66037","head":{"label":"kanikashah90:fixturesDirToFixtures","ref":"fixturesDirToFixtures","sha":"ea1fc0cd66962d8bc4db7b165dd956acf8f66037","user":{"login":"kanikashah90","id":2753761,"avatar_url":"https://avatars0.githubusercontent.com/u/2753761?v=4","gravatar_id":"","url":"https://api.github.com/users/kanikashah90","html_url":"https://github.com/kanikashah90","followers_url":"https://api.github.com/users/kanikashah90/followers","following_url":"https://api.github.com/users/kanikashah90/following{/other_user}","gists_url":"https://api.github.com/users/kanikashah90/gists{/gist_id}","starred_url":"https://api.github.com/users/kanikashah90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanikashah90/subscriptions","organizations_url":"https://api.github.com/users/kanikashah90/orgs","repos_url":"https://api.github.com/users/kanikashah90/repos","events_url":"https://api.github.com/users/kanikashah90/events{/privacy}","received_events_url":"https://api.github.com/users/kanikashah90/received_events","type":"User","site_admin":false},"repo":{"id":103697202,"name":"node","full_name":"kanikashah90/node","owner":{"login":"kanikashah90","id":2753761,"avatar_url":"https://avatars0.githubusercontent.com/u/2753761?v=4","gravatar_id":"","url":"https://api.github.com/users/kanikashah90","html_url":"https://github.com/kanikashah90","followers_url":"https://api.github.com/users/kanikashah90/followers","following_url":"https://api.github.com/users/kanikashah90/following{/other_user}","gists_url":"https://api.github.com/users/kanikashah90/gists{/gist_id}","starred_url":"https://api.github.com/users/kanikashah90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kanikashah90/subscriptions","organizations_url":"https://api.github.com/users/kanikashah90/orgs","repos_url":"https://api.github.com/users/kanikashah90/repos","events_url":"https://api.github.com/users/kanikashah90/events{/privacy}","received_events_url":"https://api.github.com/users/kanikashah90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kanikashah90/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/kanikashah90/node","forks_url":"https://api.github.com/repos/kanikashah90/node/forks","keys_url":"https://api.github.com/repos/kanikashah90/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kanikashah90/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kanikashah90/node/teams","hooks_url":"https://api.github.com/repos/kanikashah90/node/hooks","issue_events_url":"https://api.github.com/repos/kanikashah90/node/issues/events{/number}","events_url":"https://api.github.com/repos/kanikashah90/node/events","assignees_url":"https://api.github.com/repos/kanikashah90/node/assignees{/user}","branches_url":"https://api.github.com/repos/kanikashah90/node/branches{/branch}","tags_url":"https://api.github.com/repos/kanikashah90/node/tags","blobs_url":"https://api.github.com/repos/kanikashah90/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kanikashah90/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kanikashah90/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/kanikashah90/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kanikashah90/node/statuses/{sha}","languages_url":"https://api.github.com/repos/kanikashah90/node/languages","stargazers_url":"https://api.github.com/repos/kanikashah90/node/stargazers","contributors_url":"https://api.github.com/repos/kanikashah90/node/contributors","subscribers_url":"https://api.github.com/repos/kanikashah90/node/subscribers","subscription_url":"https://api.github.com/repos/kanikashah90/node/subscription","commits_url":"https://api.github.com/repos/kanikashah90/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/kanikashah90/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/kanikashah90/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/kanikashah90/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/kanikashah90/node/contents/{+path}","compare_url":"https://api.github.com/repos/kanikashah90/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kanikashah90/node/merges","archive_url":"https://api.github.com/repos/kanikashah90/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kanikashah90/node/downloads","issues_url":"https://api.github.com/repos/kanikashah90/node/issues{/number}","pulls_url":"https://api.github.com/repos/kanikashah90/node/pulls{/number}","milestones_url":"https://api.github.com/repos/kanikashah90/node/milestones{/number}","notifications_url":"https://api.github.com/repos/kanikashah90/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kanikashah90/node/labels{/name}","releases_url":"https://api.github.com/repos/kanikashah90/node/releases{/id}","deployments_url":"https://api.github.com/repos/kanikashah90/node/deployments","created_at":"2017-09-15T20:12:09Z","updated_at":"2017-09-15T20:12:46Z","pushed_at":"2017-10-06T17:42:33Z","git_url":"git://github.com/kanikashah90/node.git","ssh_url":"git@github.com:kanikashah90/node.git","clone_url":"https://github.com/kanikashah90/node.git","svn_url":"https://github.com/kanikashah90/node","homepage":"https://nodejs.org","size":315452,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"4f339b54e9cd8a2cb69b41d87832ad8ca3a6b5e2","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2017-10-11T07:13:00Z","pushed_at":"2017-10-11T06:57:11Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":320517,"stargazers_count":40365,"watchers_count":40365,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8373,"mirror_url":null,"open_issues_count":876,"forks":8373,"open_issues":876,"watchers":40365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/15959"},"html":{"href":"https://github.com/nodejs/node/pull/15959"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/15959"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/15959/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/15959/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/15959/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/ea1fc0cd66962d8bc4db7b165dd956acf8f66037"}},"author_association":"NONE"}}
{"actor":{"display_login":"kanikashah90"}}