{"action":"created","issue":{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/342","repository_url":"https://api.github.com/repos/wrye-bash/wrye-bash","labels_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/342/comments","events_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/342/events","html_url":"https://github.com/wrye-bash/wrye-bash/issues/342","id":187922549,"number":342,"title":"Add Form Version to class ModReader:","user":{"login":"Sharlikran","id":1912426,"avatar_url":"https://avatars3.githubusercontent.com/u/1912426?v=4","gravatar_id":"","url":"https://api.github.com/users/Sharlikran","html_url":"https://github.com/Sharlikran","followers_url":"https://api.github.com/users/Sharlikran/followers","following_url":"https://api.github.com/users/Sharlikran/following{/other_user}","gists_url":"https://api.github.com/users/Sharlikran/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharlikran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharlikran/subscriptions","organizations_url":"https://api.github.com/users/Sharlikran/orgs","repos_url":"https://api.github.com/users/Sharlikran/repos","events_url":"https://api.github.com/users/Sharlikran/events{/privacy}","received_events_url":"https://api.github.com/users/Sharlikran/received_events","type":"User","site_admin":false},"labels":[{"id":46413246,"url":"https://api.github.com/repos/wrye-bash/wrye-bash/labels/bug","name":"bug","color":"fc2929","default":true},{"id":46413248,"url":"https://api.github.com/repos/wrye-bash/wrye-bash/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/milestones/9","html_url":"https://github.com/wrye-bash/wrye-bash/milestone/9","labels_url":"https://api.github.com/repos/wrye-bash/wrye-bash/milestones/9/labels","id":711578,"number":9,"title":"307","description":"- bosh package / eliminate last Tank relics / Skyrim patchers / remove messages tab / finalize basher package / drop support for older pickle files / back to BAIN / fallout 4 support/ SSE support\r\n","creator":{"login":"Utumno","id":1365079,"avatar_url":"https://avatars3.githubusercontent.com/u/1365079?v=4","gravatar_id":"","url":"https://api.github.com/users/Utumno","html_url":"https://github.com/Utumno","followers_url":"https://api.github.com/users/Utumno/followers","following_url":"https://api.github.com/users/Utumno/following{/other_user}","gists_url":"https://api.github.com/users/Utumno/gists{/gist_id}","starred_url":"https://api.github.com/users/Utumno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Utumno/subscriptions","organizations_url":"https://api.github.com/users/Utumno/orgs","repos_url":"https://api.github.com/users/Utumno/repos","events_url":"https://api.github.com/users/Utumno/events{/privacy}","received_events_url":"https://api.github.com/users/Utumno/received_events","type":"User","site_admin":false},"open_issues":28,"closed_issues":58,"state":"open","created_at":"2014-07-06T19:50:11Z","updated_at":"2017-09-23T20:29:19Z","due_on":null,"closed_at":null},"comments":34,"created_at":"2016-11-08T07:41:59Z","updated_at":"2017-09-24T12:47:41Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"EDIT 11-7-2016 : Because of importing from [skyrim\\records.py](https://github.com/Sharlikran/wrye-bash/commit/ffdd72dfcab8b38e1f3d0ff56c4c401b2dbf9cbb#diff-ee6b65e7d33f57047cdeaa2df3d00d1cR30) it appeared something was being rewritten.  Those without any Python experience can't follow complex code changes.\r\n\r\nI wasn't going to ask for any new features and be very respectful of your work and time but I notice you removed all the code from class esp I was going to use to add a new message to Skyrim SE.  \r\n\r\nBethesda just released a new patch for both Skyrim SE and the CK.  SPGD is now larger in size and is rumored to be broken.  The old size was 48 the new size is 96 or 192 for some mods.  The fields are different so just unpacking the different size won't work.  What was field 2 is not field 3 and so on.\r\n\r\nThe way xEdit deals with changes like that are by reading the Form Version of the header.  What Zilav added eliminated the need for separate Skyrim and Skyrim SE files.  While Wrye bash can't do that exactly the same, I could use this in records.py and for the message.  This is not present in Oblivion.  Only Skyrim, Fallout 4 and Skyrim SE.\r\n\r\nSkyrim Header 24 bytes:\r\n```\r\nstruct TES4 HEADER {\r\n        char signature[4];\r\n        uint dataSize;\r\n        uint recordFlags;\r\n        uint nextFormID;\r\n        uint unknown1;\r\n        ushort formVersion;\r\n        ushort unknown2;\r\n    } plugin;\r\n```\r\nCurrently warn_mods in def warn_corrupted under class BashFrame uses the Version of the plugin from the main TES4 record and the HEDR subrecord.  I'm not asking to change that.  However, I'm asking to add another verification using \"ushort formVersion;\" by making it accessible as a global variable.\r\n\r\n ```Python\r\nif blah.blah.header.formVersion: \r\n     <code>\r\n```\r\n\r\nI was going to try and add the message to class BashFrame(wx.Frame):.  constants.py would need bush.game.currentFormVersion == 44 for Skyrim SE.   Then under BashFrame(wx.Frame): something like this.\r\n\r\n```Python\r\n    if fsname in ['Skyrim', 'Fallout 4', 'Skyrim Special edition']:\r\n        if blah.blah.header.formVersion != bush.game.currentFormVersion:\r\n            m = [_(u'Older Plugin Record Version'),\r\n                 _(u'The following mods don't use the current plugin Form Version: ')]\r\n            m.extend(sorted(oldPluginFormVersions))\r\n            message.append(m)\r\n            self.knownOldFormVersion |= oldPluginFormVersions\r\n```\r\n\r\nI not trying to impose however, if you are re-writing the entire section could you make an exception and add this please."},"comment":{"url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/comments/331707903","html_url":"https://github.com/wrye-bash/wrye-bash/issues/342#issuecomment-331707903","issue_url":"https://api.github.com/repos/wrye-bash/wrye-bash/issues/342","id":331707903,"user":{"login":"Sharlikran","id":1912426,"avatar_url":"https://avatars3.githubusercontent.com/u/1912426?v=4","gravatar_id":"","url":"https://api.github.com/users/Sharlikran","html_url":"https://github.com/Sharlikran","followers_url":"https://api.github.com/users/Sharlikran/followers","following_url":"https://api.github.com/users/Sharlikran/following{/other_user}","gists_url":"https://api.github.com/users/Sharlikran/gists{/gist_id}","starred_url":"https://api.github.com/users/Sharlikran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sharlikran/subscriptions","organizations_url":"https://api.github.com/users/Sharlikran/orgs","repos_url":"https://api.github.com/users/Sharlikran/repos","events_url":"https://api.github.com/users/Sharlikran/events{/privacy}","received_events_url":"https://api.github.com/users/Sharlikran/received_events","type":"User","site_admin":false},"created_at":"2017-09-24T12:47:41Z","updated_at":"2017-09-24T12:47:41Z","author_association":"CONTRIBUTOR","body":"Also I have church and family stuff to do today.  If they post I may not respond right away."}}
{"actor":{"display_login":"Sharlikran"}}