{"action":"created","comment":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/comments/154060070","pull_request_review_id":80163975,"id":154060070,"diff_hunk":"@@ -70,13 +67,16 @@ class ServerOptions : public PeerOptions\n     Security::ContextPointer staticContext;\n     SBuf staticContextSessionId; ///< \"session id context\" for staticContext\n \n+#if USE_OPENSSL\n     bool generateHostCertificates = true; ///< dynamically make host cert\n+#elif USE_GNUTLS || 1 /* requires --with-openssl for now */","path":"src/security/ServerOptions.h","position":33,"original_position":33,"commit_id":"6ec1a00a0933789af4330a4500f7e92c25e0067d","original_commit_id":"45633d404422026b1ebea1d54275ee6341363e6a","user":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"body":"Okay. Updated the clause and added comments to explain why it exists at all.","created_at":"2017-11-30T12:21:33Z","updated_at":"2017-11-30T12:21:34Z","html_url":"https://github.com/squid-cache/squid/pull/81#discussion_r154060070","pull_request_url":"https://api.github.com/repos/squid-cache/squid/pulls/81","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments/154060070"},"html":{"href":"https://github.com/squid-cache/squid/pull/81#discussion_r154060070"},"pull_request":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/81"}},"in_reply_to_id":153057802},"pull_request":{"url":"https://api.github.com/repos/squid-cache/squid/pulls/81","id":153453218,"html_url":"https://github.com/squid-cache/squid/pull/81","diff_url":"https://github.com/squid-cache/squid/pull/81.diff","patch_url":"https://github.com/squid-cache/squid/pull/81.patch","issue_url":"https://api.github.com/repos/squid-cache/squid/issues/81","number":81,"state":"open","locked":false,"title":"GnuTLS implementation for TLS listening ports and client connections","user":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"body":"Move the http_port cert= and key= options logic to libsecurity and add GnuTLS implementation for PEM file loading. Also adds some extra debugging to clarify listening port initialization problems with the PEM files.\r\n\r\nEnable most of the http(s)_port listening socket logic to always build except where OpenSSL-specific dependency still exists. GnuTLS implementation is added for the basic https_port logic pathway and TLS handshake.\r\n\r\nAlso fixes the definitions for the CertPointer and PrivateKeyPointer.","created_at":"2017-11-18T14:58:02Z","updated_at":"2017-11-30T12:21:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"235c46341d72076108c221eda960545b73b5ff7e","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chtsanti","id":30215174,"avatar_url":"https://avatars2.githubusercontent.com/u/30215174?v=4","gravatar_id":"","url":"https://api.github.com/users/chtsanti","html_url":"https://github.com/chtsanti","followers_url":"https://api.github.com/users/chtsanti/followers","following_url":"https://api.github.com/users/chtsanti/following{/other_user}","gists_url":"https://api.github.com/users/chtsanti/gists{/gist_id}","starred_url":"https://api.github.com/users/chtsanti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chtsanti/subscriptions","organizations_url":"https://api.github.com/users/chtsanti/orgs","repos_url":"https://api.github.com/users/chtsanti/repos","events_url":"https://api.github.com/users/chtsanti/events{/privacy}","received_events_url":"https://api.github.com/users/chtsanti/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/squid-cache/squid/pulls/81/commits","review_comments_url":"https://api.github.com/repos/squid-cache/squid/pulls/81/comments","review_comment_url":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/squid-cache/squid/issues/81/comments","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/6ec1a00a0933789af4330a4500f7e92c25e0067d","head":{"label":"yadij:tls-dynamic-cert-ui","ref":"tls-dynamic-cert-ui","sha":"6ec1a00a0933789af4330a4500f7e92c25e0067d","user":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"repo":{"id":97826891,"name":"squid","full_name":"yadij/squid","owner":{"login":"yadij","id":9123754,"avatar_url":"https://avatars0.githubusercontent.com/u/9123754?v=4","gravatar_id":"","url":"https://api.github.com/users/yadij","html_url":"https://github.com/yadij","followers_url":"https://api.github.com/users/yadij/followers","following_url":"https://api.github.com/users/yadij/following{/other_user}","gists_url":"https://api.github.com/users/yadij/gists{/gist_id}","starred_url":"https://api.github.com/users/yadij/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yadij/subscriptions","organizations_url":"https://api.github.com/users/yadij/orgs","repos_url":"https://api.github.com/users/yadij/repos","events_url":"https://api.github.com/users/yadij/events{/privacy}","received_events_url":"https://api.github.com/users/yadij/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yadij/squid","description":"Squid Web Proxy Cache","fork":true,"url":"https://api.github.com/repos/yadij/squid","forks_url":"https://api.github.com/repos/yadij/squid/forks","keys_url":"https://api.github.com/repos/yadij/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yadij/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yadij/squid/teams","hooks_url":"https://api.github.com/repos/yadij/squid/hooks","issue_events_url":"https://api.github.com/repos/yadij/squid/issues/events{/number}","events_url":"https://api.github.com/repos/yadij/squid/events","assignees_url":"https://api.github.com/repos/yadij/squid/assignees{/user}","branches_url":"https://api.github.com/repos/yadij/squid/branches{/branch}","tags_url":"https://api.github.com/repos/yadij/squid/tags","blobs_url":"https://api.github.com/repos/yadij/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yadij/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yadij/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/yadij/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yadij/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/yadij/squid/languages","stargazers_url":"https://api.github.com/repos/yadij/squid/stargazers","contributors_url":"https://api.github.com/repos/yadij/squid/contributors","subscribers_url":"https://api.github.com/repos/yadij/squid/subscribers","subscription_url":"https://api.github.com/repos/yadij/squid/subscription","commits_url":"https://api.github.com/repos/yadij/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/yadij/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/yadij/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/yadij/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/yadij/squid/contents/{+path}","compare_url":"https://api.github.com/repos/yadij/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yadij/squid/merges","archive_url":"https://api.github.com/repos/yadij/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yadij/squid/downloads","issues_url":"https://api.github.com/repos/yadij/squid/issues{/number}","pulls_url":"https://api.github.com/repos/yadij/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/yadij/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/yadij/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yadij/squid/labels{/name}","releases_url":"https://api.github.com/repos/yadij/squid/releases{/id}","deployments_url":"https://api.github.com/repos/yadij/squid/deployments","created_at":"2017-07-20T11:20:53Z","updated_at":"2017-07-20T11:21:02Z","pushed_at":"2017-11-29T16:56:03Z","git_url":"git://github.com/yadij/squid.git","ssh_url":"git@github.com:yadij/squid.git","clone_url":"https://github.com/yadij/squid.git","svn_url":"https://github.com/yadij/squid","homepage":"http://www.squid-cache.org/","size":137330,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"squid-cache:master","ref":"master","sha":"4d27d0ab7be057352a6a5d552f85a4181f1153a5","user":{"login":"squid-cache","id":363029,"avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"repo":{"id":24519987,"name":"squid","full_name":"squid-cache/squid","owner":{"login":"squid-cache","id":363029,"avatar_url":"https://avatars3.githubusercontent.com/u/363029?v=4","gravatar_id":"","url":"https://api.github.com/users/squid-cache","html_url":"https://github.com/squid-cache","followers_url":"https://api.github.com/users/squid-cache/followers","following_url":"https://api.github.com/users/squid-cache/following{/other_user}","gists_url":"https://api.github.com/users/squid-cache/gists{/gist_id}","starred_url":"https://api.github.com/users/squid-cache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/squid-cache/subscriptions","organizations_url":"https://api.github.com/users/squid-cache/orgs","repos_url":"https://api.github.com/users/squid-cache/repos","events_url":"https://api.github.com/users/squid-cache/events{/privacy}","received_events_url":"https://api.github.com/users/squid-cache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/squid-cache/squid","description":"Squid Web Proxy Cache","fork":false,"url":"https://api.github.com/repos/squid-cache/squid","forks_url":"https://api.github.com/repos/squid-cache/squid/forks","keys_url":"https://api.github.com/repos/squid-cache/squid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/squid-cache/squid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/squid-cache/squid/teams","hooks_url":"https://api.github.com/repos/squid-cache/squid/hooks","issue_events_url":"https://api.github.com/repos/squid-cache/squid/issues/events{/number}","events_url":"https://api.github.com/repos/squid-cache/squid/events","assignees_url":"https://api.github.com/repos/squid-cache/squid/assignees{/user}","branches_url":"https://api.github.com/repos/squid-cache/squid/branches{/branch}","tags_url":"https://api.github.com/repos/squid-cache/squid/tags","blobs_url":"https://api.github.com/repos/squid-cache/squid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/squid-cache/squid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/squid-cache/squid/git/refs{/sha}","trees_url":"https://api.github.com/repos/squid-cache/squid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/squid-cache/squid/statuses/{sha}","languages_url":"https://api.github.com/repos/squid-cache/squid/languages","stargazers_url":"https://api.github.com/repos/squid-cache/squid/stargazers","contributors_url":"https://api.github.com/repos/squid-cache/squid/contributors","subscribers_url":"https://api.github.com/repos/squid-cache/squid/subscribers","subscription_url":"https://api.github.com/repos/squid-cache/squid/subscription","commits_url":"https://api.github.com/repos/squid-cache/squid/commits{/sha}","git_commits_url":"https://api.github.com/repos/squid-cache/squid/git/commits{/sha}","comments_url":"https://api.github.com/repos/squid-cache/squid/comments{/number}","issue_comment_url":"https://api.github.com/repos/squid-cache/squid/issues/comments{/number}","contents_url":"https://api.github.com/repos/squid-cache/squid/contents/{+path}","compare_url":"https://api.github.com/repos/squid-cache/squid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/squid-cache/squid/merges","archive_url":"https://api.github.com/repos/squid-cache/squid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/squid-cache/squid/downloads","issues_url":"https://api.github.com/repos/squid-cache/squid/issues{/number}","pulls_url":"https://api.github.com/repos/squid-cache/squid/pulls{/number}","milestones_url":"https://api.github.com/repos/squid-cache/squid/milestones{/number}","notifications_url":"https://api.github.com/repos/squid-cache/squid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/squid-cache/squid/labels{/name}","releases_url":"https://api.github.com/repos/squid-cache/squid/releases{/id}","deployments_url":"https://api.github.com/repos/squid-cache/squid/deployments","created_at":"2014-09-27T00:59:40Z","updated_at":"2017-11-29T02:48:51Z","pushed_at":"2017-11-30T08:14:05Z","git_url":"git://github.com/squid-cache/squid.git","ssh_url":"git@github.com:squid-cache/squid.git","clone_url":"https://github.com/squid-cache/squid.git","svn_url":"https://github.com/squid-cache/squid","homepage":"http://www.squid-cache.org/","size":162554,"stargazers_count":236,"watchers_count":236,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0"},"forks":93,"open_issues":9,"watchers":236,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/81"},"html":{"href":"https://github.com/squid-cache/squid/pull/81"},"issue":{"href":"https://api.github.com/repos/squid-cache/squid/issues/81"},"comments":{"href":"https://api.github.com/repos/squid-cache/squid/issues/81/comments"},"review_comments":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/81/comments"},"review_comment":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/squid-cache/squid/pulls/81/commits"},"statuses":{"href":"https://api.github.com/repos/squid-cache/squid/statuses/6ec1a00a0933789af4330a4500f7e92c25e0067d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yadij"}}