{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/124909475","pull_request_review_id":47247923,"id":124909475,"diff_hunk":"@@ -48,6 +48,6 @@ D_HOST=${D_HOST%:*}    # remove trailing port #\n # Setup our credentials\n NO_TTY=1 kubectl config set-credentials service-catalog-creds --username=admin --password=admin\n #NO_TTY=1 kubectl config set-cluster service-catalog-cluster --server=https://${D_HOST}:${PORT} --certificate-authority=/var/run/kubernetes-service-catalog/apiserver.crt\n-NO_TTY=1 kubectl config set-cluster service-catalog-cluster --server=http://${D_HOST}:${PORT}\n+NO_TTY=1 kubectl config set-cluster service-catalog-cluster --server=https://${D_HOST}:${PORT}","path":"contrib/hack/setup-kubectl.sh","position":14,"original_position":14,"commit_id":"93bd09b8f525e0390c3e0061565e031635523c98","original_commit_id":"26b69af642988edb7b8ec81430d6524e4da3716c","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars1.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"body":"It's set later and has been set for a long time, it was just being overridden.\r\n\r\nSee \r\nhttps://github.com/kubernetes-incubator/service-catalog/pull/991/files#diff-6558d4846dfc9ea670e39f25e102e98fR41 \r\nfor the existing use of the CA\r\n\r\nand \r\nhttps://github.com/kubernetes-incubator/service-catalog/pull/991/files#diff-6c378e3d38ea115bb705ee0d2e9967f3L39\r\nfor the deleted hidden override","created_at":"2017-06-29T20:49:58Z","updated_at":"2017-06-29T20:49:58Z","html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/991#discussion_r124909475","pull_request_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/991","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments/124909475"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/991#discussion_r124909475"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/991"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/991","id":127791449,"html_url":"https://github.com/kubernetes-incubator/service-catalog/pull/991","diff_url":"https://github.com/kubernetes-incubator/service-catalog/pull/991.diff","patch_url":"https://github.com/kubernetes-incubator/service-catalog/pull/991.patch","issue_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/991","number":991,"state":"open","locked":false,"title":"make the apiserver test use tls","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars1.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"body":" - kubectl was hardcoded to use http\r\n\r\nIf the unsecure endpoint is really going away, we'll need this.\r\n\r\nI think we should be testing https anyway.","created_at":"2017-06-27T21:01:26Z","updated_at":"2017-06-29T20:49:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d34999bb53e7f1f1048a6bf5828c2b5f04162191","assignee":null,"assignees":[],"requested_reviewers":[{"login":"arschles","id":70865,"avatar_url":"https://avatars2.githubusercontent.com/u/70865?v=3","gravatar_id":"","url":"https://api.github.com/users/arschles","html_url":"https://github.com/arschles","followers_url":"https://api.github.com/users/arschles/followers","following_url":"https://api.github.com/users/arschles/following{/other_user}","gists_url":"https://api.github.com/users/arschles/gists{/gist_id}","starred_url":"https://api.github.com/users/arschles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arschles/subscriptions","organizations_url":"https://api.github.com/users/arschles/orgs","repos_url":"https://api.github.com/users/arschles/repos","events_url":"https://api.github.com/users/arschles/events{/privacy}","received_events_url":"https://api.github.com/users/arschles/received_events","type":"User","site_admin":false},{"login":"duglin","id":1944671,"avatar_url":"https://avatars2.githubusercontent.com/u/1944671?v=3","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},{"login":"vaikas-google","id":11279988,"avatar_url":"https://avatars0.githubusercontent.com/u/11279988?v=3","gravatar_id":"","url":"https://api.github.com/users/vaikas-google","html_url":"https://github.com/vaikas-google","followers_url":"https://api.github.com/users/vaikas-google/followers","following_url":"https://api.github.com/users/vaikas-google/following{/other_user}","gists_url":"https://api.github.com/users/vaikas-google/gists{/gist_id}","starred_url":"https://api.github.com/users/vaikas-google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaikas-google/subscriptions","organizations_url":"https://api.github.com/users/vaikas-google/orgs","repos_url":"https://api.github.com/users/vaikas-google/repos","events_url":"https://api.github.com/users/vaikas-google/events{/privacy}","received_events_url":"https://api.github.com/users/vaikas-google/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/991/commits","review_comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/991/comments","review_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/991/comments","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/93bd09b8f525e0390c3e0061565e031635523c98","head":{"label":"MHBauer:secure-apiserver-test","ref":"secure-apiserver-test","sha":"93bd09b8f525e0390c3e0061565e031635523c98","user":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars1.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"repo":{"id":70524191,"name":"service-catalog","full_name":"MHBauer/service-catalog","owner":{"login":"MHBauer","id":13337345,"avatar_url":"https://avatars1.githubusercontent.com/u/13337345?v=3","gravatar_id":"","url":"https://api.github.com/users/MHBauer","html_url":"https://github.com/MHBauer","followers_url":"https://api.github.com/users/MHBauer/followers","following_url":"https://api.github.com/users/MHBauer/following{/other_user}","gists_url":"https://api.github.com/users/MHBauer/gists{/gist_id}","starred_url":"https://api.github.com/users/MHBauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MHBauer/subscriptions","organizations_url":"https://api.github.com/users/MHBauer/orgs","repos_url":"https://api.github.com/users/MHBauer/repos","events_url":"https://api.github.com/users/MHBauer/events{/privacy}","received_events_url":"https://api.github.com/users/MHBauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MHBauer/service-catalog","description":"Share and consume services in Kubernetes using service brokers","fork":true,"url":"https://api.github.com/repos/MHBauer/service-catalog","forks_url":"https://api.github.com/repos/MHBauer/service-catalog/forks","keys_url":"https://api.github.com/repos/MHBauer/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MHBauer/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MHBauer/service-catalog/teams","hooks_url":"https://api.github.com/repos/MHBauer/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/MHBauer/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/MHBauer/service-catalog/events","assignees_url":"https://api.github.com/repos/MHBauer/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/MHBauer/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/MHBauer/service-catalog/tags","blobs_url":"https://api.github.com/repos/MHBauer/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MHBauer/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MHBauer/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/MHBauer/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MHBauer/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/MHBauer/service-catalog/languages","stargazers_url":"https://api.github.com/repos/MHBauer/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/MHBauer/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/MHBauer/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/MHBauer/service-catalog/subscription","commits_url":"https://api.github.com/repos/MHBauer/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/MHBauer/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/MHBauer/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/MHBauer/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/MHBauer/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/MHBauer/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MHBauer/service-catalog/merges","archive_url":"https://api.github.com/repos/MHBauer/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MHBauer/service-catalog/downloads","issues_url":"https://api.github.com/repos/MHBauer/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/MHBauer/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/MHBauer/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/MHBauer/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MHBauer/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/MHBauer/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/MHBauer/service-catalog/deployments","created_at":"2016-10-10T20:05:09Z","updated_at":"2016-12-19T22:54:54Z","pushed_at":"2017-06-28T23:43:23Z","git_url":"git://github.com/MHBauer/service-catalog.git","ssh_url":"git@github.com:MHBauer/service-catalog.git","clone_url":"https://github.com/MHBauer/service-catalog.git","svn_url":"https://github.com/MHBauer/service-catalog","homepage":"","size":69759,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-incubator:master","ref":"master","sha":"d5733393c1a3c43949c148f7a482b418ab18d6a7","user":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":68024288,"name":"service-catalog","full_name":"kubernetes-incubator/service-catalog","owner":{"login":"kubernetes-incubator","id":20862812,"avatar_url":"https://avatars1.githubusercontent.com/u/20862812?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes-incubator","html_url":"https://github.com/kubernetes-incubator","followers_url":"https://api.github.com/users/kubernetes-incubator/followers","following_url":"https://api.github.com/users/kubernetes-incubator/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-incubator/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-incubator/orgs","repos_url":"https://api.github.com/users/kubernetes-incubator/repos","events_url":"https://api.github.com/users/kubernetes-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-incubator/service-catalog","description":"Consume services in Kubernetes using the Open Service Broker API","fork":false,"url":"https://api.github.com/repos/kubernetes-incubator/service-catalog","forks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/forks","keys_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/teams","hooks_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/events","assignees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/tags","blobs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/languages","stargazers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/subscription","commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/merges","archive_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/downloads","issues_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-incubator/service-catalog/deployments","created_at":"2016-09-12T15:58:39Z","updated_at":"2017-06-27T05:37:59Z","pushed_at":"2017-06-29T14:46:45Z","git_url":"git://github.com/kubernetes-incubator/service-catalog.git","ssh_url":"git@github.com:kubernetes-incubator/service-catalog.git","clone_url":"https://github.com/kubernetes-incubator/service-catalog.git","svn_url":"https://github.com/kubernetes-incubator/service-catalog","homepage":"","size":69486,"stargazers_count":174,"watchers_count":174,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":71,"mirror_url":null,"open_issues_count":154,"forks":71,"open_issues":154,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/991"},"html":{"href":"https://github.com/kubernetes-incubator/service-catalog/pull/991"},"issue":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/991"},"comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/issues/991/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/991/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/pulls/991/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-incubator/service-catalog/statuses/93bd09b8f525e0390c3e0061565e031635523c98"}}}}
{"actor":{"display_login":"MHBauer"}}