{"action":"closed","issue":{"url":"https://api.github.com/repos/deployphp/deployer/issues/1153","repository_url":"https://api.github.com/repos/deployphp/deployer","labels_url":"https://api.github.com/repos/deployphp/deployer/issues/1153/labels{/name}","comments_url":"https://api.github.com/repos/deployphp/deployer/issues/1153/comments","events_url":"https://api.github.com/repos/deployphp/deployer/issues/1153/events","html_url":"https://github.com/deployphp/deployer/issues/1153","id":220147693,"number":1153,"title":"Versioning framework recipes","user":{"login":"barryvdh","id":973269,"avatar_url":"https://avatars2.githubusercontent.com/u/973269?v=4","gravatar_id":"","url":"https://api.github.com/users/barryvdh","html_url":"https://github.com/barryvdh","followers_url":"https://api.github.com/users/barryvdh/followers","following_url":"https://api.github.com/users/barryvdh/following{/other_user}","gists_url":"https://api.github.com/users/barryvdh/gists{/gist_id}","starred_url":"https://api.github.com/users/barryvdh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barryvdh/subscriptions","organizations_url":"https://api.github.com/users/barryvdh/orgs","repos_url":"https://api.github.com/users/barryvdh/repos","events_url":"https://api.github.com/users/barryvdh/events{/privacy}","received_events_url":"https://api.github.com/users/barryvdh/received_events","type":"User","site_admin":false},"labels":[{"id":459890664,"url":"https://api.github.com/repos/deployphp/deployer/labels/research","name":"research","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2017-04-07T08:38:47Z","updated_at":"2017-08-12T16:12:56Z","closed_at":"2017-08-12T16:12:56Z","body":"| Q                 | A\r\n| ----------------- | ---\r\n| Issue Type        | Discussion\r\n| Deployer Version  | 5\r\n\r\n### Description \r\nI think the default recipes are very nice, but sometimes I'm a bit worried about versioning. What if Laravel 5.5 adds a new command that should be added by default, will it be included in `laravel.php`? And will that break my existing L5.4 deployment? Or do we never add it, or create `laravel5.5.php`? Imho, the deployment should almost never change after we set it up, unless we explicitly do so.  This includes changes in shared folders, commands to run and possibly even flags (see Laravel 4 -> 5 added the --force flag to migrations).\r\nThis of course applies to all frameworks/apps.\r\n\r\n### Solution?\r\nThe `init` commands currently adds an initial recipe, extending `recipe/laravel.php` (in this example). But perhaps it would be better to also include all the `deploy` tasks, so it is more clear what you are running, and it won't change with an upgrade of deployer.\r\n\r\n2 possible solutions:\r\n - Split the task definitions and the `deploy` definition, to just include the `deploy` definition (and perhaps the shared/writable defaults) in the init\r\n- Copy the entire recipe to the initialised deploy script, perhaps after what is current in the init file. More verbose but won't break. Downside it that it's not easy to patch issues.\r\n"}}
{"actor":{"display_login":"antonmedv"}}