{"action":"closed","number":9433,"pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/9433","id":125483866,"html_url":"https://github.com/brave/browser-laptop/pull/9433","diff_url":"https://github.com/brave/browser-laptop/pull/9433.diff","patch_url":"https://github.com/brave/browser-laptop/pull/9433.patch","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/9433","number":9433,"state":"closed","locked":false,"title":"Enable importing passwords from Firefox","user":{"login":"evq","id":8796196,"avatar_url":"https://avatars0.githubusercontent.com/u/8796196?v=3","gravatar_id":"","url":"https://api.github.com/users/evq","html_url":"https://github.com/evq","followers_url":"https://api.github.com/users/evq/followers","following_url":"https://api.github.com/users/evq/following{/other_user}","gists_url":"https://api.github.com/users/evq/gists{/gist_id}","starred_url":"https://api.github.com/users/evq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evq/subscriptions","organizations_url":"https://api.github.com/users/evq/orgs","repos_url":"https://api.github.com/users/evq/repos","events_url":"https://api.github.com/users/evq/events{/privacy}","received_events_url":"https://api.github.com/users/evq/received_events","type":"User","site_admin":false},"body":"Auditors: @darkdh \r\n\r\nrequires https://github.com/brave/muon/pull/216\r\ncloses #9292\r\n\r\nSubmitter Checklist:\r\n\r\n- [ ] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [ ] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [ ] Ran `git rebase -i` to squash commits (if needed).\r\n- [ ] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n\r\nTest Plan:\r\n\r\n\r\nReviewer Checklist:\r\n\r\nTests\r\n\r\n\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n- [ ] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\n\r\n","created_at":"2017-06-13T23:36:28Z","updated_at":"2017-06-27T05:17:37Z","closed_at":"2017-06-27T05:17:37Z","merged_at":"2017-06-27T05:17:37Z","merge_commit_sha":"48a8169364623ccc213309355554513e301f7801","assignee":{"login":"evq","id":8796196,"avatar_url":"https://avatars0.githubusercontent.com/u/8796196?v=3","gravatar_id":"","url":"https://api.github.com/users/evq","html_url":"https://github.com/evq","followers_url":"https://api.github.com/users/evq/followers","following_url":"https://api.github.com/users/evq/following{/other_user}","gists_url":"https://api.github.com/users/evq/gists{/gist_id}","starred_url":"https://api.github.com/users/evq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evq/subscriptions","organizations_url":"https://api.github.com/users/evq/orgs","repos_url":"https://api.github.com/users/evq/repos","events_url":"https://api.github.com/users/evq/events{/privacy}","received_events_url":"https://api.github.com/users/evq/received_events","type":"User","site_admin":false},"assignees":[{"login":"evq","id":8796196,"avatar_url":"https://avatars0.githubusercontent.com/u/8796196?v=3","gravatar_id":"","url":"https://api.github.com/users/evq","html_url":"https://github.com/evq","followers_url":"https://api.github.com/users/evq/followers","following_url":"https://api.github.com/users/evq/following{/other_user}","gists_url":"https://api.github.com/users/evq/gists{/gist_id}","starred_url":"https://api.github.com/users/evq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evq/subscriptions","organizations_url":"https://api.github.com/users/evq/orgs","repos_url":"https://api.github.com/users/evq/repos","events_url":"https://api.github.com/users/evq/events{/privacy}","received_events_url":"https://api.github.com/users/evq/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"diracdeltas","id":549654,"avatar_url":"https://avatars2.githubusercontent.com/u/549654?v=3","gravatar_id":"","url":"https://api.github.com/users/diracdeltas","html_url":"https://github.com/diracdeltas","followers_url":"https://api.github.com/users/diracdeltas/followers","following_url":"https://api.github.com/users/diracdeltas/following{/other_user}","gists_url":"https://api.github.com/users/diracdeltas/gists{/gist_id}","starred_url":"https://api.github.com/users/diracdeltas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diracdeltas/subscriptions","organizations_url":"https://api.github.com/users/diracdeltas/orgs","repos_url":"https://api.github.com/users/diracdeltas/repos","events_url":"https://api.github.com/users/diracdeltas/events{/privacy}","received_events_url":"https://api.github.com/users/diracdeltas/received_events","type":"User","site_admin":false},{"login":"bbondy","id":831718,"avatar_url":"https://avatars1.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/72","html_url":"https://github.com/brave/browser-laptop/milestone/72","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/72/labels","id":2571677,"number":72,"title":"0.19.x (Nightly Channel)","description":"","creator":{"login":"bbondy","id":831718,"avatar_url":"https://avatars1.githubusercontent.com/u/831718?v=3","gravatar_id":"","url":"https://api.github.com/users/bbondy","html_url":"https://github.com/bbondy","followers_url":"https://api.github.com/users/bbondy/followers","following_url":"https://api.github.com/users/bbondy/following{/other_user}","gists_url":"https://api.github.com/users/bbondy/gists{/gist_id}","starred_url":"https://api.github.com/users/bbondy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbondy/subscriptions","organizations_url":"https://api.github.com/users/bbondy/orgs","repos_url":"https://api.github.com/users/bbondy/repos","events_url":"https://api.github.com/users/bbondy/events{/privacy}","received_events_url":"https://api.github.com/users/bbondy/received_events","type":"User","site_admin":false},"open_issues":82,"closed_issues":85,"state":"open","created_at":"2017-06-08T13:53:54Z","updated_at":"2017-06-27T05:17:37Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/brave/browser-laptop/pulls/9433/commits","review_comments_url":"https://api.github.com/repos/brave/browser-laptop/pulls/9433/comments","review_comment_url":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/9433/comments","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/baf81259b703fc30bab338671c90deb9b48c1de0","head":{"label":"evq:feature/password-import","ref":"feature/password-import","sha":"baf81259b703fc30bab338671c90deb9b48c1de0","user":{"login":"evq","id":8796196,"avatar_url":"https://avatars0.githubusercontent.com/u/8796196?v=3","gravatar_id":"","url":"https://api.github.com/users/evq","html_url":"https://github.com/evq","followers_url":"https://api.github.com/users/evq/followers","following_url":"https://api.github.com/users/evq/following{/other_user}","gists_url":"https://api.github.com/users/evq/gists{/gist_id}","starred_url":"https://api.github.com/users/evq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evq/subscriptions","organizations_url":"https://api.github.com/users/evq/orgs","repos_url":"https://api.github.com/users/evq/repos","events_url":"https://api.github.com/users/evq/events{/privacy}","received_events_url":"https://api.github.com/users/evq/received_events","type":"User","site_admin":false},"repo":{"id":83098274,"name":"browser-laptop","full_name":"evq/browser-laptop","owner":{"login":"evq","id":8796196,"avatar_url":"https://avatars0.githubusercontent.com/u/8796196?v=3","gravatar_id":"","url":"https://api.github.com/users/evq","html_url":"https://github.com/evq","followers_url":"https://api.github.com/users/evq/followers","following_url":"https://api.github.com/users/evq/following{/other_user}","gists_url":"https://api.github.com/users/evq/gists{/gist_id}","starred_url":"https://api.github.com/users/evq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evq/subscriptions","organizations_url":"https://api.github.com/users/evq/orgs","repos_url":"https://api.github.com/users/evq/repos","events_url":"https://api.github.com/users/evq/events{/privacy}","received_events_url":"https://api.github.com/users/evq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/evq/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":true,"url":"https://api.github.com/repos/evq/browser-laptop","forks_url":"https://api.github.com/repos/evq/browser-laptop/forks","keys_url":"https://api.github.com/repos/evq/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/evq/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/evq/browser-laptop/teams","hooks_url":"https://api.github.com/repos/evq/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/evq/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/evq/browser-laptop/events","assignees_url":"https://api.github.com/repos/evq/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/evq/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/evq/browser-laptop/tags","blobs_url":"https://api.github.com/repos/evq/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/evq/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/evq/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/evq/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/evq/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/evq/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/evq/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/evq/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/evq/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/evq/browser-laptop/subscription","commits_url":"https://api.github.com/repos/evq/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/evq/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/evq/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/evq/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/evq/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/evq/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/evq/browser-laptop/merges","archive_url":"https://api.github.com/repos/evq/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/evq/browser-laptop/downloads","issues_url":"https://api.github.com/repos/evq/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/evq/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/evq/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/evq/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/evq/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/evq/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/evq/browser-laptop/deployments","created_at":"2017-02-25T01:52:04Z","updated_at":"2017-02-25T01:52:08Z","pushed_at":"2017-06-20T02:31:45Z","git_url":"git://github.com/evq/browser-laptop.git","ssh_url":"git@github.com:evq/browser-laptop.git","clone_url":"https://github.com/evq/browser-laptop.git","svn_url":"https://github.com/evq/browser-laptop","homepage":"https://www.brave.com","size":48661,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brave:master","ref":"master","sha":"4688b1c372ee8eb8df684f27e9f57a68bcc14e6e","user":{"login":"brave","id":12301619,"avatar_url":"https://avatars2.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"repo":{"id":46891997,"name":"browser-laptop","full_name":"brave/browser-laptop","owner":{"login":"brave","id":12301619,"avatar_url":"https://avatars2.githubusercontent.com/u/12301619?v=3","gravatar_id":"","url":"https://api.github.com/users/brave","html_url":"https://github.com/brave","followers_url":"https://api.github.com/users/brave/followers","following_url":"https://api.github.com/users/brave/following{/other_user}","gists_url":"https://api.github.com/users/brave/gists{/gist_id}","starred_url":"https://api.github.com/users/brave/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brave/subscriptions","organizations_url":"https://api.github.com/users/brave/orgs","repos_url":"https://api.github.com/users/brave/repos","events_url":"https://api.github.com/users/brave/events{/privacy}","received_events_url":"https://api.github.com/users/brave/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brave/browser-laptop","description":"Brave browser for Desktop and Laptop computers running Windows, OSX, and Linux","fork":false,"url":"https://api.github.com/repos/brave/browser-laptop","forks_url":"https://api.github.com/repos/brave/browser-laptop/forks","keys_url":"https://api.github.com/repos/brave/browser-laptop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brave/browser-laptop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brave/browser-laptop/teams","hooks_url":"https://api.github.com/repos/brave/browser-laptop/hooks","issue_events_url":"https://api.github.com/repos/brave/browser-laptop/issues/events{/number}","events_url":"https://api.github.com/repos/brave/browser-laptop/events","assignees_url":"https://api.github.com/repos/brave/browser-laptop/assignees{/user}","branches_url":"https://api.github.com/repos/brave/browser-laptop/branches{/branch}","tags_url":"https://api.github.com/repos/brave/browser-laptop/tags","blobs_url":"https://api.github.com/repos/brave/browser-laptop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brave/browser-laptop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brave/browser-laptop/git/refs{/sha}","trees_url":"https://api.github.com/repos/brave/browser-laptop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brave/browser-laptop/statuses/{sha}","languages_url":"https://api.github.com/repos/brave/browser-laptop/languages","stargazers_url":"https://api.github.com/repos/brave/browser-laptop/stargazers","contributors_url":"https://api.github.com/repos/brave/browser-laptop/contributors","subscribers_url":"https://api.github.com/repos/brave/browser-laptop/subscribers","subscription_url":"https://api.github.com/repos/brave/browser-laptop/subscription","commits_url":"https://api.github.com/repos/brave/browser-laptop/commits{/sha}","git_commits_url":"https://api.github.com/repos/brave/browser-laptop/git/commits{/sha}","comments_url":"https://api.github.com/repos/brave/browser-laptop/comments{/number}","issue_comment_url":"https://api.github.com/repos/brave/browser-laptop/issues/comments{/number}","contents_url":"https://api.github.com/repos/brave/browser-laptop/contents/{+path}","compare_url":"https://api.github.com/repos/brave/browser-laptop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brave/browser-laptop/merges","archive_url":"https://api.github.com/repos/brave/browser-laptop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brave/browser-laptop/downloads","issues_url":"https://api.github.com/repos/brave/browser-laptop/issues{/number}","pulls_url":"https://api.github.com/repos/brave/browser-laptop/pulls{/number}","milestones_url":"https://api.github.com/repos/brave/browser-laptop/milestones{/number}","notifications_url":"https://api.github.com/repos/brave/browser-laptop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brave/browser-laptop/labels{/name}","releases_url":"https://api.github.com/repos/brave/browser-laptop/releases{/id}","deployments_url":"https://api.github.com/repos/brave/browser-laptop/deployments","created_at":"2015-11-25T22:55:10Z","updated_at":"2017-06-26T22:06:38Z","pushed_at":"2017-06-27T05:17:37Z","git_url":"git://github.com/brave/browser-laptop.git","ssh_url":"git@github.com:brave/browser-laptop.git","clone_url":"https://github.com/brave/browser-laptop.git","svn_url":"https://github.com/brave/browser-laptop","homepage":"https://www.brave.com","size":49404,"stargazers_count":5217,"watchers_count":5217,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":608,"mirror_url":null,"open_issues_count":2267,"forks":608,"open_issues":2267,"watchers":5217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/9433"},"html":{"href":"https://github.com/brave/browser-laptop/pull/9433"},"issue":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/9433"},"comments":{"href":"https://api.github.com/repos/brave/browser-laptop/issues/9433/comments"},"review_comments":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/9433/comments"},"review_comment":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brave/browser-laptop/pulls/9433/commits"},"statuses":{"href":"https://api.github.com/repos/brave/browser-laptop/statuses/baf81259b703fc30bab338671c90deb9b48c1de0"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars0.githubusercontent.com/u/4733304?v=3","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"bsclifton"}}