{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/pd/pulls/comments/101706829","pull_request_review_id":22443374,"id":101706829,"diff_hunk":"@@ -87,7 +87,9 @@ func loop() {\n \t\t\t}\n \t\t\tcontinue\n \t\t}\n-\n+\t\tif line == \"exit\" {","path":"cmd/pd-ctl/main.go","position":5,"original_position":5,"commit_id":"c0ec6b85af677fa71ed6616361578b5f30799638","original_commit_id":"c0ec6b85af677fa71ed6616361578b5f30799638","user":{"login":"nolouch","id":6428910,"avatar_url":"https://avatars.githubusercontent.com/u/6428910?v=3","gravatar_id":"","url":"https://api.github.com/users/nolouch","html_url":"https://github.com/nolouch","followers_url":"https://api.github.com/users/nolouch/followers","following_url":"https://api.github.com/users/nolouch/following{/other_user}","gists_url":"https://api.github.com/users/nolouch/gists{/gist_id}","starred_url":"https://api.github.com/users/nolouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolouch/subscriptions","organizations_url":"https://api.github.com/users/nolouch/orgs","repos_url":"https://api.github.com/users/nolouch/repos","events_url":"https://api.github.com/users/nolouch/events{/privacy}","received_events_url":"https://api.github.com/users/nolouch/received_events","type":"User","site_admin":false},"body":"if `InitPDClient` meet error, it will return error directly without execute the command. so I move `exit` to here. ","created_at":"2017-02-17T08:26:05Z","updated_at":"2017-02-17T08:26:06Z","html_url":"https://github.com/pingcap/pd/pull/528#discussion_r101706829","pull_request_url":"https://api.github.com/repos/pingcap/pd/pulls/528","_links":{"self":{"href":"https://api.github.com/repos/pingcap/pd/pulls/comments/101706829"},"html":{"href":"https://github.com/pingcap/pd/pull/528#discussion_r101706829"},"pull_request":{"href":"https://api.github.com/repos/pingcap/pd/pulls/528"}}},"pull_request":{"url":"https://api.github.com/repos/pingcap/pd/pulls/528","id":106682920,"html_url":"https://github.com/pingcap/pd/pull/528","diff_url":"https://github.com/pingcap/pd/pull/528.diff","patch_url":"https://github.com/pingcap/pd/pull/528.patch","issue_url":"https://api.github.com/repos/pingcap/pd/issues/528","number":528,"state":"open","locked":false,"title":"pdctl: verify pd address","user":{"login":"nolouch","id":6428910,"avatar_url":"https://avatars.githubusercontent.com/u/6428910?v=3","gravatar_id":"","url":"https://api.github.com/users/nolouch","html_url":"https://github.com/nolouch","followers_url":"https://api.github.com/users/nolouch/followers","following_url":"https://api.github.com/users/nolouch/following{/other_user}","gists_url":"https://api.github.com/users/nolouch/gists{/gist_id}","starred_url":"https://api.github.com/users/nolouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolouch/subscriptions","organizations_url":"https://api.github.com/users/nolouch/orgs","repos_url":"https://api.github.com/users/nolouch/repos","events_url":"https://api.github.com/users/nolouch/events{/privacy}","received_events_url":"https://api.github.com/users/nolouch/received_events","type":"User","site_admin":false},"body":"close https://github.com/pingcap/pd/issues/507\r\nPTAL @siddontang @overvenus @huachaohuang ","created_at":"2017-02-17T07:45:22Z","updated_at":"2017-02-17T08:26:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7858276845a0269458d8c78d40d26c926fc44ec9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/pd/pulls/528/commits","review_comments_url":"https://api.github.com/repos/pingcap/pd/pulls/528/comments","review_comment_url":"https://api.github.com/repos/pingcap/pd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/pd/issues/528/comments","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/c0ec6b85af677fa71ed6616361578b5f30799638","head":{"label":"pingcap:shuning/verify-address","ref":"shuning/verify-address","sha":"c0ec6b85af677fa71ed6616361578b5f30799638","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53311716,"name":"pd","full_name":"pingcap/pd","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/pd","description":"Placement driver for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/pd","forks_url":"https://api.github.com/repos/pingcap/pd/forks","keys_url":"https://api.github.com/repos/pingcap/pd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/pd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/pd/teams","hooks_url":"https://api.github.com/repos/pingcap/pd/hooks","issue_events_url":"https://api.github.com/repos/pingcap/pd/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/pd/events","assignees_url":"https://api.github.com/repos/pingcap/pd/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/pd/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/pd/tags","blobs_url":"https://api.github.com/repos/pingcap/pd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/pd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/pd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/pd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/pd/languages","stargazers_url":"https://api.github.com/repos/pingcap/pd/stargazers","contributors_url":"https://api.github.com/repos/pingcap/pd/contributors","subscribers_url":"https://api.github.com/repos/pingcap/pd/subscribers","subscription_url":"https://api.github.com/repos/pingcap/pd/subscription","commits_url":"https://api.github.com/repos/pingcap/pd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/pd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/pd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/pd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/pd/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/pd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/pd/merges","archive_url":"https://api.github.com/repos/pingcap/pd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/pd/downloads","issues_url":"https://api.github.com/repos/pingcap/pd/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/pd/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/pd/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/pd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/pd/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/pd/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/pd/deployments","created_at":"2016-03-07T09:13:06Z","updated_at":"2017-02-17T04:20:16Z","pushed_at":"2017-02-17T08:06:23Z","git_url":"git://github.com/pingcap/pd.git","ssh_url":"git@github.com:pingcap/pd.git","clone_url":"https://github.com/pingcap/pd.git","svn_url":"https://github.com/pingcap/pd","homepage":"","size":5140,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":54,"forks":17,"open_issues":54,"watchers":38,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"5723fd66eee6ce5916ea3c389130e43c0d780fe4","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53311716,"name":"pd","full_name":"pingcap/pd","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars.githubusercontent.com/u/11855343?v=3","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/pd","description":"Placement driver for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/pd","forks_url":"https://api.github.com/repos/pingcap/pd/forks","keys_url":"https://api.github.com/repos/pingcap/pd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/pd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/pd/teams","hooks_url":"https://api.github.com/repos/pingcap/pd/hooks","issue_events_url":"https://api.github.com/repos/pingcap/pd/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/pd/events","assignees_url":"https://api.github.com/repos/pingcap/pd/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/pd/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/pd/tags","blobs_url":"https://api.github.com/repos/pingcap/pd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/pd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/pd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/pd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/pd/languages","stargazers_url":"https://api.github.com/repos/pingcap/pd/stargazers","contributors_url":"https://api.github.com/repos/pingcap/pd/contributors","subscribers_url":"https://api.github.com/repos/pingcap/pd/subscribers","subscription_url":"https://api.github.com/repos/pingcap/pd/subscription","commits_url":"https://api.github.com/repos/pingcap/pd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/pd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/pd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/pd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/pd/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/pd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/pd/merges","archive_url":"https://api.github.com/repos/pingcap/pd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/pd/downloads","issues_url":"https://api.github.com/repos/pingcap/pd/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/pd/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/pd/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/pd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/pd/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/pd/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/pd/deployments","created_at":"2016-03-07T09:13:06Z","updated_at":"2017-02-17T04:20:16Z","pushed_at":"2017-02-17T08:06:23Z","git_url":"git://github.com/pingcap/pd.git","ssh_url":"git@github.com:pingcap/pd.git","clone_url":"https://github.com/pingcap/pd.git","svn_url":"https://github.com/pingcap/pd","homepage":"","size":5140,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"open_issues_count":54,"forks":17,"open_issues":54,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/pd/pulls/528"},"html":{"href":"https://github.com/pingcap/pd/pull/528"},"issue":{"href":"https://api.github.com/repos/pingcap/pd/issues/528"},"comments":{"href":"https://api.github.com/repos/pingcap/pd/issues/528/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/pd/pulls/528/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/pd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/pd/pulls/528/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/pd/statuses/c0ec6b85af677fa71ed6616361578b5f30799638"}}}}
{"actor":{"display_login":"nolouch"}}