{"action":"created","issue":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/2926","repository_url":"https://api.github.com/repos/facebook/rocksdb","labels_url":"https://api.github.com/repos/facebook/rocksdb/issues/2926/labels{/name}","comments_url":"https://api.github.com/repos/facebook/rocksdb/issues/2926/comments","events_url":"https://api.github.com/repos/facebook/rocksdb/issues/2926/events","html_url":"https://github.com/facebook/rocksdb/pull/2926","id":260361659,"number":2926,"title":"[WIP][Transaction] Compaction/Flush support for WritePreparedTxnDB","user":{"login":"yiwu-arbug","id":2606959,"avatar_url":"https://avatars3.githubusercontent.com/u/2606959?v=4","gravatar_id":"","url":"https://api.github.com/users/yiwu-arbug","html_url":"https://github.com/yiwu-arbug","followers_url":"https://api.github.com/users/yiwu-arbug/followers","following_url":"https://api.github.com/users/yiwu-arbug/following{/other_user}","gists_url":"https://api.github.com/users/yiwu-arbug/gists{/gist_id}","starred_url":"https://api.github.com/users/yiwu-arbug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yiwu-arbug/subscriptions","organizations_url":"https://api.github.com/users/yiwu-arbug/orgs","repos_url":"https://api.github.com/users/yiwu-arbug/repos","events_url":"https://api.github.com/users/yiwu-arbug/events{/privacy}","received_events_url":"https://api.github.com/users/yiwu-arbug/received_events","type":"User","site_admin":false},"labels":[{"id":196859108,"url":"https://api.github.com/repos/facebook/rocksdb/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-09-25T17:51:47Z","updated_at":"2017-09-25T21:13:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/facebook/rocksdb/pulls/2926","html_url":"https://github.com/facebook/rocksdb/pull/2926","diff_url":"https://github.com/facebook/rocksdb/pull/2926.diff","patch_url":"https://github.com/facebook/rocksdb/pull/2926.patch"},"body":"Summary:\r\nUpdate Compaction/Flush to support WritePreparedTxnDB: Add SnapshotChecker which is a proxy to query WritePreparedTxnDB::IsInSnapshot. Pass SnapshotChecker to DBImpl on WritePreparedTxnDB open. CompactionIterator use it to check if a key has been committed and if it is visible to a snapshot. In CompactionIterator:\r\n*check if key has been committed. If not, output uncommitted keys AS-IS.\r\n*use SnapshotChecker to check if key is visible to a snapshot when in need.\r\n\r\nTest Plan:\r\nPending."},"comment":{"url":"https://api.github.com/repos/facebook/rocksdb/issues/comments/332014673","html_url":"https://github.com/facebook/rocksdb/pull/2926#issuecomment-332014673","issue_url":"https://api.github.com/repos/facebook/rocksdb/issues/2926","id":332014673,"user":{"login":"facebook-github-bot","id":6422482,"avatar_url":"https://avatars3.githubusercontent.com/u/6422482?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook-github-bot","html_url":"https://github.com/facebook-github-bot","followers_url":"https://api.github.com/users/facebook-github-bot/followers","following_url":"https://api.github.com/users/facebook-github-bot/following{/other_user}","gists_url":"https://api.github.com/users/facebook-github-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook-github-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook-github-bot/subscriptions","organizations_url":"https://api.github.com/users/facebook-github-bot/orgs","repos_url":"https://api.github.com/users/facebook-github-bot/repos","events_url":"https://api.github.com/users/facebook-github-bot/events{/privacy}","received_events_url":"https://api.github.com/users/facebook-github-bot/received_events","type":"User","site_admin":false},"created_at":"2017-09-25T21:13:23Z","updated_at":"2017-09-25T21:13:23Z","author_association":"NONE","body":"[@yiwu-arbug](https://github.com/yiwu-arbug) has updated the pull request. View: [changes](https://github.com/facebook/rocksdb/pull/2926/files/3d1bbf65853e133e7b50f6a64642fcb3c3b168e6..5a6435223deb57bc0266ab587fd9675a178941d3), [changes since last import](https://github.com/facebook/rocksdb/pull/2926/files/3d1bbf65853e133e7b50f6a64642fcb3c3b168e6..5a6435223deb57bc0266ab587fd9675a178941d3)"}}
{"actor":{"display_login":"facebook-github-bot"}}