{"action":"created","issue":{"url":"https://api.github.com/repos/mcallegari/qlcplus/issues/996","repository_url":"https://api.github.com/repos/mcallegari/qlcplus","labels_url":"https://api.github.com/repos/mcallegari/qlcplus/issues/996/labels{/name}","comments_url":"https://api.github.com/repos/mcallegari/qlcplus/issues/996/comments","events_url":"https://api.github.com/repos/mcallegari/qlcplus/issues/996/events","html_url":"https://github.com/mcallegari/qlcplus/pull/996","id":252451801,"number":996,"title":"New feature: Split out a tab to a separate window on double-click","user":{"login":"kripton","id":823537,"avatar_url":"https://avatars3.githubusercontent.com/u/823537?v=4","gravatar_id":"","url":"https://api.github.com/users/kripton","html_url":"https://github.com/kripton","followers_url":"https://api.github.com/users/kripton/followers","following_url":"https://api.github.com/users/kripton/following{/other_user}","gists_url":"https://api.github.com/users/kripton/gists{/gist_id}","starred_url":"https://api.github.com/users/kripton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kripton/subscriptions","organizations_url":"https://api.github.com/users/kripton/orgs","repos_url":"https://api.github.com/users/kripton/repos","events_url":"https://api.github.com/users/kripton/events{/privacy}","received_events_url":"https://api.github.com/users/kripton/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-24T00:14:11Z","updated_at":"2017-08-24T09:32:23Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mcallegari/qlcplus/pulls/996","html_url":"https://github.com/mcallegari/qlcplus/pull/996","diff_url":"https://github.com/mcallegari/qlcplus/pull/996.diff","patch_url":"https://github.com/mcallegari/qlcplus/pull/996.patch"},"body":"Hi, I had this request from a colleague of mine. He wanted to be able to have the different tabs of the main window (Fixtures, Functions, Shows, Simple Desk, Virtual Console) on different screens. Since they currently are all in the main window, you can make the window span multiple screens but you can only display one tab at a time.\r\n\r\nThis PR make it possible (for Qt5.6+ only since Qt4 is missing the \"tabBarDoubleClicked\" SIGNAL) to double-click a tab to make it a separate window. If it shall be re-integrated again, just double-click the tab again. Closing the window has been prevented.\r\nIf a tab has been split out, it can be moved to another screen than the one displaying the main window.\r\n\r\nComments welcome!\r\n\r\nP.S.: Oh and it would be awesome if someone could please make me new windows build of this branch (or of master after it has been merged) since I'm on Linux and he is on Windows and he cannot use the feature until next release or someone builds this for me. He is not experienced enough to set up the build system on his machine and I don't have Windows at all. Thanks!"},"comment":{"url":"https://api.github.com/repos/mcallegari/qlcplus/issues/comments/324584631","html_url":"https://github.com/mcallegari/qlcplus/pull/996#issuecomment-324584631","issue_url":"https://api.github.com/repos/mcallegari/qlcplus/issues/996","id":324584631,"user":{"login":"mcallegari","id":2951337,"avatar_url":"https://avatars2.githubusercontent.com/u/2951337?v=4","gravatar_id":"","url":"https://api.github.com/users/mcallegari","html_url":"https://github.com/mcallegari","followers_url":"https://api.github.com/users/mcallegari/followers","following_url":"https://api.github.com/users/mcallegari/following{/other_user}","gists_url":"https://api.github.com/users/mcallegari/gists{/gist_id}","starred_url":"https://api.github.com/users/mcallegari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcallegari/subscriptions","organizations_url":"https://api.github.com/users/mcallegari/orgs","repos_url":"https://api.github.com/users/mcallegari/repos","events_url":"https://api.github.com/users/mcallegari/events{/privacy}","received_events_url":"https://api.github.com/users/mcallegari/received_events","type":"User","site_admin":false},"created_at":"2017-08-24T09:32:23Z","updated_at":"2017-08-24T09:32:23Z","body":"@kripton well, this was meant to be a new feature of QLC+ 5... :cry: \r\nIn QLC+ 5 I opted for the mouse right button (instead of double click) cause otherwise touchscreen devices can detach a context without actually having multiple screens.\r\nThe terminology I used is \"detach\" and \"re-attach\" a context.\r\n\r\nQuestion (I haven't tested your code yet): what happens if I close a detached window ? I don't see any code re-attaching the context. Does it mean the context is lost forever ?"}}
{"actor":{"display_login":"mcallegari"}}