{"action":"created","issue":{"url":"https://api.github.com/repos/PBSPro/pbspro/issues/471","repository_url":"https://api.github.com/repos/PBSPro/pbspro","labels_url":"https://api.github.com/repos/PBSPro/pbspro/issues/471/labels{/name}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/471/comments","events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/471/events","html_url":"https://github.com/PBSPro/pbspro/pull/471","id":277964755,"number":471,"title":"PP-1119 Creating Reservations Uses Memory after Free","user":{"login":"vstumpf","id":6844975,"avatar_url":"https://avatars1.githubusercontent.com/u/6844975?v=4","gravatar_id":"","url":"https://api.github.com/users/vstumpf","html_url":"https://github.com/vstumpf","followers_url":"https://api.github.com/users/vstumpf/followers","following_url":"https://api.github.com/users/vstumpf/following{/other_user}","gists_url":"https://api.github.com/users/vstumpf/gists{/gist_id}","starred_url":"https://api.github.com/users/vstumpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vstumpf/subscriptions","organizations_url":"https://api.github.com/users/vstumpf/orgs","repos_url":"https://api.github.com/users/vstumpf/repos","events_url":"https://api.github.com/users/vstumpf/events{/privacy}","received_events_url":"https://api.github.com/users/vstumpf/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-11-30T01:14:00Z","updated_at":"2017-11-30T18:14:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/471","html_url":"https://github.com/PBSPro/pbspro/pull/471","diff_url":"https://github.com/PBSPro/pbspro/pull/471.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/471.patch"},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Issue-ID\r\n<!--- Replace XXXX below (2 places) with the actual JIRA id -->\r\n* **[PP-1119](https://pbspro.atlassian.net/browse/PP-1119)**\r\n\r\n#### Problem description\r\n* AddressSanitizer complains when creating a reservation\r\n\r\n#### Cause / Analysis\r\n* req_confirmresv frees the batch request before using it later. \r\n\r\n#### Solution description\r\n* This was introduced in PP-1034, so I moved the accesses before the free.\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n- [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [ ] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n- [x] I have added  **manual test(s) to the Jira ticket and explained why PTL is not appropriate** for this case.\r\n- [x] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to the Jira ticket** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n"},"comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments/348273948","html_url":"https://github.com/PBSPro/pbspro/pull/471#issuecomment-348273948","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/471","id":348273948,"user":{"login":"mike0042","id":2702535,"avatar_url":"https://avatars3.githubusercontent.com/u/2702535?v=4","gravatar_id":"","url":"https://api.github.com/users/mike0042","html_url":"https://github.com/mike0042","followers_url":"https://api.github.com/users/mike0042/followers","following_url":"https://api.github.com/users/mike0042/following{/other_user}","gists_url":"https://api.github.com/users/mike0042/gists{/gist_id}","starred_url":"https://api.github.com/users/mike0042/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike0042/subscriptions","organizations_url":"https://api.github.com/users/mike0042/orgs","repos_url":"https://api.github.com/users/mike0042/repos","events_url":"https://api.github.com/users/mike0042/events{/privacy}","received_events_url":"https://api.github.com/users/mike0042/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T18:14:59Z","updated_at":"2017-11-30T18:14:59Z","author_association":"COLLABORATOR","body":"IMHO, failure to write an accounting record should prevent the reservation from being confirmed because the accounting log would be incomplete. It sounds like this is a change in behavior, so I suggest you post to the forum describing the change. I don't think a full design document is necessary since you'll be fixing something that is essentially broken to begin with. Once approved, this PR may move forward."}}
{"actor":{"display_login":"mike0042"}}