{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/17059","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/17059/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/17059/comments","events_url":"https://api.github.com/repos/apache/spark/issues/17059/events","html_url":"https://github.com/apache/spark/pull/17059","id":210185457,"number":17059,"title":"[SPARK-19733][ML]Removed unnecessary castings and refactored checked casts in ALS.","user":{"login":"datumbox","id":5347466,"avatar_url":"https://avatars2.githubusercontent.com/u/5347466?v=3","gravatar_id":"","url":"https://api.github.com/users/datumbox","html_url":"https://github.com/datumbox","followers_url":"https://api.github.com/users/datumbox/followers","following_url":"https://api.github.com/users/datumbox/following{/other_user}","gists_url":"https://api.github.com/users/datumbox/gists{/gist_id}","starred_url":"https://api.github.com/users/datumbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datumbox/subscriptions","organizations_url":"https://api.github.com/users/datumbox/orgs","repos_url":"https://api.github.com/users/datumbox/repos","events_url":"https://api.github.com/users/datumbox/events{/privacy}","received_events_url":"https://api.github.com/users/datumbox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":41,"created_at":"2017-02-24T23:30:32Z","updated_at":"2017-03-01T19:22:37Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/17059","html_url":"https://github.com/apache/spark/pull/17059","diff_url":"https://github.com/apache/spark/pull/17059.diff","patch_url":"https://github.com/apache/spark/pull/17059.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nThe original ALS was performing unnecessary casting to the user and item ids because the protected checkedCast() method required a double. I removed the castings and refactored the method to receive Any and efficiently handle all permitted numeric values.\r\n\r\n## How was this patch tested?\r\n\r\nI tested it by running the unit-tests and by manually validating the result of checkedCast for various legal and illegal values.\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/283441671","html_url":"https://github.com/apache/spark/pull/17059#issuecomment-283441671","issue_url":"https://api.github.com/repos/apache/spark/issues/17059","id":283441671,"user":{"login":"SparkQA","id":8108735,"avatar_url":"https://avatars2.githubusercontent.com/u/8108735?v=3","gravatar_id":"","url":"https://api.github.com/users/SparkQA","html_url":"https://github.com/SparkQA","followers_url":"https://api.github.com/users/SparkQA/followers","following_url":"https://api.github.com/users/SparkQA/following{/other_user}","gists_url":"https://api.github.com/users/SparkQA/gists{/gist_id}","starred_url":"https://api.github.com/users/SparkQA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SparkQA/subscriptions","organizations_url":"https://api.github.com/users/SparkQA/orgs","repos_url":"https://api.github.com/users/SparkQA/repos","events_url":"https://api.github.com/users/SparkQA/events{/privacy}","received_events_url":"https://api.github.com/users/SparkQA/received_events","type":"User","site_admin":false},"created_at":"2017-03-01T19:22:37Z","updated_at":"2017-03-01T19:22:37Z","body":"**[Test build #73706 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/73706/testReport)** for PR 17059 at commit [`361d9cb`](https://github.com/apache/spark/commit/361d9cb30fe87a2bd21a2476a7b549f14878df3c)."}}
{"actor":{"display_login":"SparkQA"}}