{"action":"created","comment":{"url":"https://api.github.com/repos/pret/pokeruby/pulls/comments/128821008","pull_request_review_id":51540578,"id":128821008,"diff_hunk":"@@ -22,17 +22,11 @@\n \n #define CLOCK_WIN_TOP (MSG_WIN_TOP - 4)\n \n-struct SaveFailedClockStruct\n-{\n-    bool16 clockRunning;\n-    u16 timer; // appears to be unused, the only case its \"used\" cannot be reached normally\n-    u8 unused[0xE]; // appears to be unused space. alternatively, there could have been multiple clock structs. however, neither of these cases are fulfilled, so the purpose of this space is unknown. one theory is that there is room for 3 more clock structs (2 16-bit values), so its possible GF intended there to be support for link-based save failed screens in case the synchronization failed, or it in fact was present in an earlier build but taken out for reasons.\n-};\n-\n extern u8 unk_2000000[];\n \n-extern u16 gSaveFailedType;\n-extern struct SaveFailedClockStruct gSaveFailedClockInfo;\n+static EWRAM_DATA u16 gSaveFailedType = 0;\n+static EWRAM_DATA u16 gSaveFailedClockInfo[9] = {0};","path":"src/save_failed_screen.c","position":16,"original_position":16,"commit_id":"e4a72cbff306e805606c3d95e5192e535fcb0ca8","original_commit_id":"e4a72cbff306e805606c3d95e5192e535fcb0ca8","user":{"login":"camthesaxman","id":17279765,"avatar_url":"https://avatars0.githubusercontent.com/u/17279765?v=4","gravatar_id":"","url":"https://api.github.com/users/camthesaxman","html_url":"https://github.com/camthesaxman","followers_url":"https://api.github.com/users/camthesaxman/followers","following_url":"https://api.github.com/users/camthesaxman/following{/other_user}","gists_url":"https://api.github.com/users/camthesaxman/gists{/gist_id}","starred_url":"https://api.github.com/users/camthesaxman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/camthesaxman/subscriptions","organizations_url":"https://api.github.com/users/camthesaxman/orgs","repos_url":"https://api.github.com/users/camthesaxman/repos","events_url":"https://api.github.com/users/camthesaxman/events{/privacy}","received_events_url":"https://api.github.com/users/camthesaxman/received_events","type":"User","site_admin":false},"body":"Why was this changed to a u16 array?","created_at":"2017-07-21T17:48:23Z","updated_at":"2017-07-21T17:48:23Z","html_url":"https://github.com/pret/pokeruby/pull/370#discussion_r128821008","pull_request_url":"https://api.github.com/repos/pret/pokeruby/pulls/370","_links":{"self":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/comments/128821008"},"html":{"href":"https://github.com/pret/pokeruby/pull/370#discussion_r128821008"},"pull_request":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/370"}}},"pull_request":{"url":"https://api.github.com/repos/pret/pokeruby/pulls/370","id":130737535,"html_url":"https://github.com/pret/pokeruby/pull/370","diff_url":"https://github.com/pret/pokeruby/pull/370.diff","patch_url":"https://github.com/pret/pokeruby/pull/370.patch","issue_url":"https://api.github.com/repos/pret/pokeruby/issues/370","number":370,"state":"open","locked":false,"title":"map out ram variables","user":{"login":"drifloony","id":30138208,"avatar_url":"https://avatars2.githubusercontent.com/u/30138208?v=4","gravatar_id":"","url":"https://api.github.com/users/drifloony","html_url":"https://github.com/drifloony","followers_url":"https://api.github.com/users/drifloony/followers","following_url":"https://api.github.com/users/drifloony/following{/other_user}","gists_url":"https://api.github.com/users/drifloony/gists{/gist_id}","starred_url":"https://api.github.com/users/drifloony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drifloony/subscriptions","organizations_url":"https://api.github.com/users/drifloony/orgs","repos_url":"https://api.github.com/users/drifloony/repos","events_url":"https://api.github.com/users/drifloony/events{/privacy}","received_events_url":"https://api.github.com/users/drifloony/received_events","type":"User","site_admin":false},"body":"I moved RAM variables into C files when possible and put comments for files that have not yet been decompiled.","created_at":"2017-07-16T03:23:47Z","updated_at":"2017-07-21T17:48:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cd0572c3d4940f67e8809636eeddd9386dd0a44d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/pret/pokeruby/pulls/370/commits","review_comments_url":"https://api.github.com/repos/pret/pokeruby/pulls/370/comments","review_comment_url":"https://api.github.com/repos/pret/pokeruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pret/pokeruby/issues/370/comments","statuses_url":"https://api.github.com/repos/pret/pokeruby/statuses/e4a72cbff306e805606c3d95e5192e535fcb0ca8","head":{"label":"drifloony:ram_variables","ref":"ram_variables","sha":"e4a72cbff306e805606c3d95e5192e535fcb0ca8","user":{"login":"drifloony","id":30138208,"avatar_url":"https://avatars2.githubusercontent.com/u/30138208?v=4","gravatar_id":"","url":"https://api.github.com/users/drifloony","html_url":"https://github.com/drifloony","followers_url":"https://api.github.com/users/drifloony/followers","following_url":"https://api.github.com/users/drifloony/following{/other_user}","gists_url":"https://api.github.com/users/drifloony/gists{/gist_id}","starred_url":"https://api.github.com/users/drifloony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drifloony/subscriptions","organizations_url":"https://api.github.com/users/drifloony/orgs","repos_url":"https://api.github.com/users/drifloony/repos","events_url":"https://api.github.com/users/drifloony/events{/privacy}","received_events_url":"https://api.github.com/users/drifloony/received_events","type":"User","site_admin":false},"repo":{"id":97082844,"name":"pokeruby","full_name":"drifloony/pokeruby","owner":{"login":"drifloony","id":30138208,"avatar_url":"https://avatars2.githubusercontent.com/u/30138208?v=4","gravatar_id":"","url":"https://api.github.com/users/drifloony","html_url":"https://github.com/drifloony","followers_url":"https://api.github.com/users/drifloony/followers","following_url":"https://api.github.com/users/drifloony/following{/other_user}","gists_url":"https://api.github.com/users/drifloony/gists{/gist_id}","starred_url":"https://api.github.com/users/drifloony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drifloony/subscriptions","organizations_url":"https://api.github.com/users/drifloony/orgs","repos_url":"https://api.github.com/users/drifloony/repos","events_url":"https://api.github.com/users/drifloony/events{/privacy}","received_events_url":"https://api.github.com/users/drifloony/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drifloony/pokeruby","description":"Disassembly of Pokémon Ruby/Sapphire","fork":true,"url":"https://api.github.com/repos/drifloony/pokeruby","forks_url":"https://api.github.com/repos/drifloony/pokeruby/forks","keys_url":"https://api.github.com/repos/drifloony/pokeruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drifloony/pokeruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drifloony/pokeruby/teams","hooks_url":"https://api.github.com/repos/drifloony/pokeruby/hooks","issue_events_url":"https://api.github.com/repos/drifloony/pokeruby/issues/events{/number}","events_url":"https://api.github.com/repos/drifloony/pokeruby/events","assignees_url":"https://api.github.com/repos/drifloony/pokeruby/assignees{/user}","branches_url":"https://api.github.com/repos/drifloony/pokeruby/branches{/branch}","tags_url":"https://api.github.com/repos/drifloony/pokeruby/tags","blobs_url":"https://api.github.com/repos/drifloony/pokeruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drifloony/pokeruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drifloony/pokeruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/drifloony/pokeruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drifloony/pokeruby/statuses/{sha}","languages_url":"https://api.github.com/repos/drifloony/pokeruby/languages","stargazers_url":"https://api.github.com/repos/drifloony/pokeruby/stargazers","contributors_url":"https://api.github.com/repos/drifloony/pokeruby/contributors","subscribers_url":"https://api.github.com/repos/drifloony/pokeruby/subscribers","subscription_url":"https://api.github.com/repos/drifloony/pokeruby/subscription","commits_url":"https://api.github.com/repos/drifloony/pokeruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/drifloony/pokeruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/drifloony/pokeruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/drifloony/pokeruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/drifloony/pokeruby/contents/{+path}","compare_url":"https://api.github.com/repos/drifloony/pokeruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drifloony/pokeruby/merges","archive_url":"https://api.github.com/repos/drifloony/pokeruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drifloony/pokeruby/downloads","issues_url":"https://api.github.com/repos/drifloony/pokeruby/issues{/number}","pulls_url":"https://api.github.com/repos/drifloony/pokeruby/pulls{/number}","milestones_url":"https://api.github.com/repos/drifloony/pokeruby/milestones{/number}","notifications_url":"https://api.github.com/repos/drifloony/pokeruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drifloony/pokeruby/labels{/name}","releases_url":"https://api.github.com/repos/drifloony/pokeruby/releases{/id}","deployments_url":"https://api.github.com/repos/drifloony/pokeruby/deployments","created_at":"2017-07-13T05:19:40Z","updated_at":"2017-07-13T05:19:47Z","pushed_at":"2017-07-21T16:14:36Z","git_url":"git://github.com/drifloony/pokeruby.git","ssh_url":"git@github.com:drifloony/pokeruby.git","clone_url":"https://github.com/drifloony/pokeruby.git","svn_url":"https://github.com/drifloony/pokeruby","homepage":"","size":38498,"stargazers_count":0,"watchers_count":0,"language":"Assembly","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pret:master","ref":"master","sha":"7d960d219fae9d0a14ef1974c11231f8de55b89c","user":{"login":"pret","id":10761592,"avatar_url":"https://avatars1.githubusercontent.com/u/10761592?v=4","gravatar_id":"","url":"https://api.github.com/users/pret","html_url":"https://github.com/pret","followers_url":"https://api.github.com/users/pret/followers","following_url":"https://api.github.com/users/pret/following{/other_user}","gists_url":"https://api.github.com/users/pret/gists{/gist_id}","starred_url":"https://api.github.com/users/pret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pret/subscriptions","organizations_url":"https://api.github.com/users/pret/orgs","repos_url":"https://api.github.com/users/pret/repos","events_url":"https://api.github.com/users/pret/events{/privacy}","received_events_url":"https://api.github.com/users/pret/received_events","type":"Organization","site_admin":false},"repo":{"id":50256891,"name":"pokeruby","full_name":"pret/pokeruby","owner":{"login":"pret","id":10761592,"avatar_url":"https://avatars1.githubusercontent.com/u/10761592?v=4","gravatar_id":"","url":"https://api.github.com/users/pret","html_url":"https://github.com/pret","followers_url":"https://api.github.com/users/pret/followers","following_url":"https://api.github.com/users/pret/following{/other_user}","gists_url":"https://api.github.com/users/pret/gists{/gist_id}","starred_url":"https://api.github.com/users/pret/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pret/subscriptions","organizations_url":"https://api.github.com/users/pret/orgs","repos_url":"https://api.github.com/users/pret/repos","events_url":"https://api.github.com/users/pret/events{/privacy}","received_events_url":"https://api.github.com/users/pret/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pret/pokeruby","description":"Disassembly of Pokémon Ruby/Sapphire","fork":false,"url":"https://api.github.com/repos/pret/pokeruby","forks_url":"https://api.github.com/repos/pret/pokeruby/forks","keys_url":"https://api.github.com/repos/pret/pokeruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pret/pokeruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pret/pokeruby/teams","hooks_url":"https://api.github.com/repos/pret/pokeruby/hooks","issue_events_url":"https://api.github.com/repos/pret/pokeruby/issues/events{/number}","events_url":"https://api.github.com/repos/pret/pokeruby/events","assignees_url":"https://api.github.com/repos/pret/pokeruby/assignees{/user}","branches_url":"https://api.github.com/repos/pret/pokeruby/branches{/branch}","tags_url":"https://api.github.com/repos/pret/pokeruby/tags","blobs_url":"https://api.github.com/repos/pret/pokeruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pret/pokeruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pret/pokeruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/pret/pokeruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pret/pokeruby/statuses/{sha}","languages_url":"https://api.github.com/repos/pret/pokeruby/languages","stargazers_url":"https://api.github.com/repos/pret/pokeruby/stargazers","contributors_url":"https://api.github.com/repos/pret/pokeruby/contributors","subscribers_url":"https://api.github.com/repos/pret/pokeruby/subscribers","subscription_url":"https://api.github.com/repos/pret/pokeruby/subscription","commits_url":"https://api.github.com/repos/pret/pokeruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/pret/pokeruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/pret/pokeruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/pret/pokeruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/pret/pokeruby/contents/{+path}","compare_url":"https://api.github.com/repos/pret/pokeruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pret/pokeruby/merges","archive_url":"https://api.github.com/repos/pret/pokeruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pret/pokeruby/downloads","issues_url":"https://api.github.com/repos/pret/pokeruby/issues{/number}","pulls_url":"https://api.github.com/repos/pret/pokeruby/pulls{/number}","milestones_url":"https://api.github.com/repos/pret/pokeruby/milestones{/number}","notifications_url":"https://api.github.com/repos/pret/pokeruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pret/pokeruby/labels{/name}","releases_url":"https://api.github.com/repos/pret/pokeruby/releases{/id}","deployments_url":"https://api.github.com/repos/pret/pokeruby/deployments","created_at":"2016-01-23T20:26:46Z","updated_at":"2017-07-19T18:10:18Z","pushed_at":"2017-07-21T17:15:22Z","git_url":"git://github.com/pret/pokeruby.git","ssh_url":"git@github.com:pret/pokeruby.git","clone_url":"https://github.com/pret/pokeruby.git","svn_url":"https://github.com/pret/pokeruby","homepage":"","size":38466,"stargazers_count":102,"watchers_count":102,"language":"Assembly","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":29,"mirror_url":null,"open_issues_count":33,"forks":29,"open_issues":33,"watchers":102,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/370"},"html":{"href":"https://github.com/pret/pokeruby/pull/370"},"issue":{"href":"https://api.github.com/repos/pret/pokeruby/issues/370"},"comments":{"href":"https://api.github.com/repos/pret/pokeruby/issues/370/comments"},"review_comments":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/370/comments"},"review_comment":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pret/pokeruby/pulls/370/commits"},"statuses":{"href":"https://api.github.com/repos/pret/pokeruby/statuses/e4a72cbff306e805606c3d95e5192e535fcb0ca8"}}}}
{"actor":{"display_login":"camthesaxman"}}