{"action":"created","issue":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4044","repository_url":"https://api.github.com/repos/SimpleMachines/SMF2.1","labels_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4044/labels{/name}","comments_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4044/comments","events_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4044/events","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/4044","id":228131005,"number":4044,"title":"Lets user specify width and height when inserting image attachments","user":{"login":"Sesquipedalian","id":191731,"avatar_url":"https://avatars3.githubusercontent.com/u/191731?v=3","gravatar_id":"","url":"https://api.github.com/users/Sesquipedalian","html_url":"https://github.com/Sesquipedalian","followers_url":"https://api.github.com/users/Sesquipedalian/followers","following_url":"https://api.github.com/users/Sesquipedalian/following{/other_user}","gists_url":"https://api.github.com/users/Sesquipedalian/gists{/gist_id}","starred_url":"https://api.github.com/users/Sesquipedalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sesquipedalian/subscriptions","organizations_url":"https://api.github.com/users/Sesquipedalian/orgs","repos_url":"https://api.github.com/users/Sesquipedalian/repos","events_url":"https://api.github.com/users/Sesquipedalian/events{/privacy}","received_events_url":"https://api.github.com/users/Sesquipedalian/received_events","type":"User","site_admin":false},"labels":[{"id":75478658,"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/labels/BBC","name":"BBC","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-11T21:48:13Z","updated_at":"2017-05-12T18:11:48Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/pulls/4044","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/4044","diff_url":"https://github.com/SimpleMachines/SMF2.1/pull/4044.diff","patch_url":"https://github.com/SimpleMachines/SMF2.1/pull/4044.patch"},"body":"This PR does two things:\r\n\r\n1. Lets user specify width and height when inserting image attachments. Two extra input fields are shown for image attachments so the user can type in an optional value for each. If either field contains a numerical value when the \"Insert\" button is clicked, the entered value will be used as a width/height parameter on the inserted BBCode.\r\n2. Rearranges the layout of the attachments list, which was kinda messy before."},"comment":{"url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/comments/301147830","html_url":"https://github.com/SimpleMachines/SMF2.1/pull/4044#issuecomment-301147830","issue_url":"https://api.github.com/repos/SimpleMachines/SMF2.1/issues/4044","id":301147830,"user":{"login":"Sesquipedalian","id":191731,"avatar_url":"https://avatars3.githubusercontent.com/u/191731?v=3","gravatar_id":"","url":"https://api.github.com/users/Sesquipedalian","html_url":"https://github.com/Sesquipedalian","followers_url":"https://api.github.com/users/Sesquipedalian/followers","following_url":"https://api.github.com/users/Sesquipedalian/following{/other_user}","gists_url":"https://api.github.com/users/Sesquipedalian/gists{/gist_id}","starred_url":"https://api.github.com/users/Sesquipedalian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sesquipedalian/subscriptions","organizations_url":"https://api.github.com/users/Sesquipedalian/orgs","repos_url":"https://api.github.com/users/Sesquipedalian/repos","events_url":"https://api.github.com/users/Sesquipedalian/events{/privacy}","received_events_url":"https://api.github.com/users/Sesquipedalian/received_events","type":"User","site_admin":false},"created_at":"2017-05-12T18:11:48Z","updated_at":"2017-05-12T18:11:48Z","body":"> IMO, separation of insert & delete buttons are kinda against SMF's usage. We always put related buttons next-to each. While I don't have official voice anymore, I suggest this keeps that way (at least for this version) to keep consistency.\r\n\r\nFair enough. I'll change that. :)\r\n\r\n> Also I can't see the image-size inputs, I'm on 25831ba... which seems the latest commit.\r\n\r\nIt only shows up for attachments that have a MIME type that starts with `image`. Can you send the file that is failing so I can test with it, @Antes? The email address I use to sign my commits will be fine."}}
{"actor":{"display_login":"Sesquipedalian"}}