{"action":"created","comment":{"url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/comments/132369943","pull_request_review_id":55441016,"id":132369943,"diff_hunk":"@@ -0,0 +1,177 @@\n+/*\n+ * Use of this source code is governed by the MIT license that can be\n+ * found in the LICENSE file.\n+ */\n+\n+package org.rust.ide.docs\n+\n+import com.intellij.codeInsight.documentation.DocumentationManagerUtil\n+import com.intellij.psi.PsiElement\n+import org.rust.ide.utils.escaped\n+import org.rust.lang.core.psi.*\n+import org.rust.lang.core.psi.ext.*\n+\n+internal fun PsiElement.generateDocumentation(buffer: StringBuilder, prefix: String = \"\", suffix: String = \"\") {","path":"src/main/kotlin/org/rust/ide/docs/DocumentationUtils.kt","position":14,"original_position":14,"commit_id":"b4ae082283593b438c52f84caa8ed968cf962d0a","original_commit_id":"b4ae082283593b438c52f84caa8ed968cf962d0a","user":{"login":"mkaput","id":3450050,"avatar_url":"https://avatars0.githubusercontent.com/u/3450050?v=4","gravatar_id":"","url":"https://api.github.com/users/mkaput","html_url":"https://github.com/mkaput","followers_url":"https://api.github.com/users/mkaput/followers","following_url":"https://api.github.com/users/mkaput/following{/other_user}","gists_url":"https://api.github.com/users/mkaput/gists{/gist_id}","starred_url":"https://api.github.com/users/mkaput/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkaput/subscriptions","organizations_url":"https://api.github.com/users/mkaput/orgs","repos_url":"https://api.github.com/users/mkaput/repos","events_url":"https://api.github.com/users/mkaput/events{/privacy}","received_events_url":"https://api.github.com/users/mkaput/received_events","type":"User","site_admin":false},"body":"`internal` doesn't make sense in our codebase, as it means *private outside module* not *private outside package* as Java's `package-local` does\r\n\r\nLet's just make it public, eventually leave a comment that this function is package internal","created_at":"2017-08-10T06:04:33Z","updated_at":"2017-08-10T06:11:49Z","html_url":"https://github.com/intellij-rust/intellij-rust/pull/1601#discussion_r132369943","pull_request_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1601","_links":{"self":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/comments/132369943"},"html":{"href":"https://github.com/intellij-rust/intellij-rust/pull/1601#discussion_r132369943"},"pull_request":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1601"}}},"pull_request":{"url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1601","id":134984703,"html_url":"https://github.com/intellij-rust/intellij-rust/pull/1601","diff_url":"https://github.com/intellij-rust/intellij-rust/pull/1601.diff","patch_url":"https://github.com/intellij-rust/intellij-rust/pull/1601.patch","issue_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1601","number":1601,"state":"open","locked":false,"title":"QDOC: links","user":{"login":"Undin","id":2539310,"avatar_url":"https://avatars0.githubusercontent.com/u/2539310?v=4","gravatar_id":"","url":"https://api.github.com/users/Undin","html_url":"https://github.com/Undin","followers_url":"https://api.github.com/users/Undin/followers","following_url":"https://api.github.com/users/Undin/following{/other_user}","gists_url":"https://api.github.com/users/Undin/gists{/gist_id}","starred_url":"https://api.github.com/users/Undin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Undin/subscriptions","organizations_url":"https://api.github.com/users/Undin/orgs","repos_url":"https://api.github.com/users/Undin/repos","events_url":"https://api.github.com/users/Undin/events{/privacy}","received_events_url":"https://api.github.com/users/Undin/received_events","type":"User","site_admin":false},"body":"Support links in quick documentation.","created_at":"2017-08-09T20:38:15Z","updated_at":"2017-08-10T06:11:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"16d6b0ca864f4903a063b6e896400e20c9e63bb1","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1601/commits","review_comments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1601/comments","review_comment_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1601/comments","statuses_url":"https://api.github.com/repos/intellij-rust/intellij-rust/statuses/b4ae082283593b438c52f84caa8ed968cf962d0a","head":{"label":"Undin:quick-doc-links","ref":"quick-doc-links","sha":"b4ae082283593b438c52f84caa8ed968cf962d0a","user":{"login":"Undin","id":2539310,"avatar_url":"https://avatars0.githubusercontent.com/u/2539310?v=4","gravatar_id":"","url":"https://api.github.com/users/Undin","html_url":"https://github.com/Undin","followers_url":"https://api.github.com/users/Undin/followers","following_url":"https://api.github.com/users/Undin/following{/other_user}","gists_url":"https://api.github.com/users/Undin/gists{/gist_id}","starred_url":"https://api.github.com/users/Undin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Undin/subscriptions","organizations_url":"https://api.github.com/users/Undin/orgs","repos_url":"https://api.github.com/users/Undin/repos","events_url":"https://api.github.com/users/Undin/events{/privacy}","received_events_url":"https://api.github.com/users/Undin/received_events","type":"User","site_admin":false},"repo":{"id":88418075,"name":"intellij-rust","full_name":"Undin/intellij-rust","owner":{"login":"Undin","id":2539310,"avatar_url":"https://avatars0.githubusercontent.com/u/2539310?v=4","gravatar_id":"","url":"https://api.github.com/users/Undin","html_url":"https://github.com/Undin","followers_url":"https://api.github.com/users/Undin/followers","following_url":"https://api.github.com/users/Undin/following{/other_user}","gists_url":"https://api.github.com/users/Undin/gists{/gist_id}","starred_url":"https://api.github.com/users/Undin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Undin/subscriptions","organizations_url":"https://api.github.com/users/Undin/orgs","repos_url":"https://api.github.com/users/Undin/repos","events_url":"https://api.github.com/users/Undin/events{/privacy}","received_events_url":"https://api.github.com/users/Undin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Undin/intellij-rust","description":"Rust IDE built using the IntelliJ Platform: https://intellij-rust.github.io/","fork":true,"url":"https://api.github.com/repos/Undin/intellij-rust","forks_url":"https://api.github.com/repos/Undin/intellij-rust/forks","keys_url":"https://api.github.com/repos/Undin/intellij-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Undin/intellij-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Undin/intellij-rust/teams","hooks_url":"https://api.github.com/repos/Undin/intellij-rust/hooks","issue_events_url":"https://api.github.com/repos/Undin/intellij-rust/issues/events{/number}","events_url":"https://api.github.com/repos/Undin/intellij-rust/events","assignees_url":"https://api.github.com/repos/Undin/intellij-rust/assignees{/user}","branches_url":"https://api.github.com/repos/Undin/intellij-rust/branches{/branch}","tags_url":"https://api.github.com/repos/Undin/intellij-rust/tags","blobs_url":"https://api.github.com/repos/Undin/intellij-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Undin/intellij-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Undin/intellij-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Undin/intellij-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Undin/intellij-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Undin/intellij-rust/languages","stargazers_url":"https://api.github.com/repos/Undin/intellij-rust/stargazers","contributors_url":"https://api.github.com/repos/Undin/intellij-rust/contributors","subscribers_url":"https://api.github.com/repos/Undin/intellij-rust/subscribers","subscription_url":"https://api.github.com/repos/Undin/intellij-rust/subscription","commits_url":"https://api.github.com/repos/Undin/intellij-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Undin/intellij-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Undin/intellij-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Undin/intellij-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Undin/intellij-rust/contents/{+path}","compare_url":"https://api.github.com/repos/Undin/intellij-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Undin/intellij-rust/merges","archive_url":"https://api.github.com/repos/Undin/intellij-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Undin/intellij-rust/downloads","issues_url":"https://api.github.com/repos/Undin/intellij-rust/issues{/number}","pulls_url":"https://api.github.com/repos/Undin/intellij-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Undin/intellij-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Undin/intellij-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Undin/intellij-rust/labels{/name}","releases_url":"https://api.github.com/repos/Undin/intellij-rust/releases{/id}","deployments_url":"https://api.github.com/repos/Undin/intellij-rust/deployments","created_at":"2017-04-16T14:19:01Z","updated_at":"2017-04-16T14:19:04Z","pushed_at":"2017-08-09T20:37:48Z","git_url":"git://github.com/Undin/intellij-rust.git","ssh_url":"git@github.com:Undin/intellij-rust.git","clone_url":"https://github.com/Undin/intellij-rust.git","svn_url":"https://github.com/Undin/intellij-rust","homepage":"","size":16426,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"intellij-rust:master","ref":"master","sha":"5d2026dc6da6fedbd12e124082e2cdabb0285cca","user":{"login":"intellij-rust","id":16057867,"avatar_url":"https://avatars0.githubusercontent.com/u/16057867?v=4","gravatar_id":"","url":"https://api.github.com/users/intellij-rust","html_url":"https://github.com/intellij-rust","followers_url":"https://api.github.com/users/intellij-rust/followers","following_url":"https://api.github.com/users/intellij-rust/following{/other_user}","gists_url":"https://api.github.com/users/intellij-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/intellij-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intellij-rust/subscriptions","organizations_url":"https://api.github.com/users/intellij-rust/orgs","repos_url":"https://api.github.com/users/intellij-rust/repos","events_url":"https://api.github.com/users/intellij-rust/events{/privacy}","received_events_url":"https://api.github.com/users/intellij-rust/received_events","type":"Organization","site_admin":false},"repo":{"id":42619487,"name":"intellij-rust","full_name":"intellij-rust/intellij-rust","owner":{"login":"intellij-rust","id":16057867,"avatar_url":"https://avatars0.githubusercontent.com/u/16057867?v=4","gravatar_id":"","url":"https://api.github.com/users/intellij-rust","html_url":"https://github.com/intellij-rust","followers_url":"https://api.github.com/users/intellij-rust/followers","following_url":"https://api.github.com/users/intellij-rust/following{/other_user}","gists_url":"https://api.github.com/users/intellij-rust/gists{/gist_id}","starred_url":"https://api.github.com/users/intellij-rust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/intellij-rust/subscriptions","organizations_url":"https://api.github.com/users/intellij-rust/orgs","repos_url":"https://api.github.com/users/intellij-rust/repos","events_url":"https://api.github.com/users/intellij-rust/events{/privacy}","received_events_url":"https://api.github.com/users/intellij-rust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/intellij-rust/intellij-rust","description":"Rust plugin for the IntelliJ Platform: https://intellij-rust.github.io/","fork":false,"url":"https://api.github.com/repos/intellij-rust/intellij-rust","forks_url":"https://api.github.com/repos/intellij-rust/intellij-rust/forks","keys_url":"https://api.github.com/repos/intellij-rust/intellij-rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/intellij-rust/intellij-rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/intellij-rust/intellij-rust/teams","hooks_url":"https://api.github.com/repos/intellij-rust/intellij-rust/hooks","issue_events_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/events{/number}","events_url":"https://api.github.com/repos/intellij-rust/intellij-rust/events","assignees_url":"https://api.github.com/repos/intellij-rust/intellij-rust/assignees{/user}","branches_url":"https://api.github.com/repos/intellij-rust/intellij-rust/branches{/branch}","tags_url":"https://api.github.com/repos/intellij-rust/intellij-rust/tags","blobs_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/intellij-rust/intellij-rust/statuses/{sha}","languages_url":"https://api.github.com/repos/intellij-rust/intellij-rust/languages","stargazers_url":"https://api.github.com/repos/intellij-rust/intellij-rust/stargazers","contributors_url":"https://api.github.com/repos/intellij-rust/intellij-rust/contributors","subscribers_url":"https://api.github.com/repos/intellij-rust/intellij-rust/subscribers","subscription_url":"https://api.github.com/repos/intellij-rust/intellij-rust/subscription","commits_url":"https://api.github.com/repos/intellij-rust/intellij-rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/intellij-rust/intellij-rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/intellij-rust/intellij-rust/contents/{+path}","compare_url":"https://api.github.com/repos/intellij-rust/intellij-rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/intellij-rust/intellij-rust/merges","archive_url":"https://api.github.com/repos/intellij-rust/intellij-rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/intellij-rust/intellij-rust/downloads","issues_url":"https://api.github.com/repos/intellij-rust/intellij-rust/issues{/number}","pulls_url":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls{/number}","milestones_url":"https://api.github.com/repos/intellij-rust/intellij-rust/milestones{/number}","notifications_url":"https://api.github.com/repos/intellij-rust/intellij-rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/intellij-rust/intellij-rust/labels{/name}","releases_url":"https://api.github.com/repos/intellij-rust/intellij-rust/releases{/id}","deployments_url":"https://api.github.com/repos/intellij-rust/intellij-rust/deployments","created_at":"2015-09-16T23:44:57Z","updated_at":"2017-08-10T03:02:07Z","pushed_at":"2017-08-09T20:38:16Z","git_url":"git://github.com/intellij-rust/intellij-rust.git","ssh_url":"git@github.com:intellij-rust/intellij-rust.git","clone_url":"https://github.com/intellij-rust/intellij-rust.git","svn_url":"https://github.com/intellij-rust/intellij-rust","homepage":"","size":16444,"stargazers_count":1393,"watchers_count":1393,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"open_issues_count":144,"forks":115,"open_issues":144,"watchers":1393,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1601"},"html":{"href":"https://github.com/intellij-rust/intellij-rust/pull/1601"},"issue":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1601"},"comments":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/issues/1601/comments"},"review_comments":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1601/comments"},"review_comment":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/pulls/1601/commits"},"statuses":{"href":"https://api.github.com/repos/intellij-rust/intellij-rust/statuses/b4ae082283593b438c52f84caa8ed968cf962d0a"}}}}
{"actor":{"display_login":"mkaput"}}