{"action":"created","issue":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/12757","repository_url":"https://api.github.com/repos/xbmc/xbmc","labels_url":"https://api.github.com/repos/xbmc/xbmc/issues/12757/labels{/name}","comments_url":"https://api.github.com/repos/xbmc/xbmc/issues/12757/comments","events_url":"https://api.github.com/repos/xbmc/xbmc/issues/12757/events","html_url":"https://github.com/xbmc/xbmc/pull/12757","id":254590088,"number":12757,"title":"ActiveAE: Fix crashing on 48khtz content in PAPlayer","user":{"login":"Albinoman887","id":1060921,"avatar_url":"https://avatars1.githubusercontent.com/u/1060921?v=4","gravatar_id":"","url":"https://api.github.com/users/Albinoman887","html_url":"https://github.com/Albinoman887","followers_url":"https://api.github.com/users/Albinoman887/followers","following_url":"https://api.github.com/users/Albinoman887/following{/other_user}","gists_url":"https://api.github.com/users/Albinoman887/gists{/gist_id}","starred_url":"https://api.github.com/users/Albinoman887/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Albinoman887/subscriptions","organizations_url":"https://api.github.com/users/Albinoman887/orgs","repos_url":"https://api.github.com/users/Albinoman887/repos","events_url":"https://api.github.com/users/Albinoman887/events{/privacy}","received_events_url":"https://api.github.com/users/Albinoman887/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2017-09-01T09:44:36Z","updated_at":"2017-09-04T05:03:30Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/xbmc/xbmc/pulls/12757","html_url":"https://github.com/xbmc/xbmc/pull/12757","diff_url":"https://github.com/xbmc/xbmc/pull/12757.diff","patch_url":"https://github.com/xbmc/xbmc/pull/12757.patch"},"body":"## Description\r\n\r\n* Bugfix: This has been present since the first alpha of v14.\r\n\r\n  if playing a mix of 44.1khtz and 48khtz music files when a\r\n  44.1kthz song ends and a 48khtz song begins AND while music\r\n  visualizations  are active, KODI will crash with a segfault\r\n  in the \"Stages()\" sections of AE. Revert the declaration of\r\n  the sample rate variables to values from last known revision\r\n  that does not suffer from this bug (Gotham 13.2)\r\n\r\n<!--- Provide a general summary of your change in the Title above -->\r\n\r\n\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n   When playing music with different sample rates when one song finishes and another beghins that is 48htz AND Visualizations are enabled (important! doesnt crash with em off. ANY ONE not just projectm) It also wont happen if you manually press skip + or - you have to let PAPlayer do it. it also does not happen with VideoPlayer\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\nNA\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your change -->\r\nPut my collection of the Band soundgarden on shuffle because it is a easy way for me to test with 48khtz since a whole album is in 48khtz. Let it play until it comes up on a 48kthz song. without my fix it would crash EVERY TIME. I tried different Linux flavors. different hardware... different PC.. doesnt happen on a raspbery Pi 3. only thing i didnt change was my AVR since i cant.\r\n\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\nUbuntu 14.04 LTS Minimal 3.13 Kernel Nvidia GT 550 , Drivers version 304.122 and 375.166 (currently 375)\r\n<!--- see how your change affects other areas of the code, etc -->\r\n\r\nTested for a few weeks. thrown all different sample rates etc at it. all seems fine. visuals still work and seem timed up\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of change\r\n<!--- What type of change does your code introduce? Put an `x` in all the boxes that apply like this: [X] -->\r\n- [* ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] Improvement (non-breaking change which improves existing functionality)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply like this: [X] -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] My code follows the [Code guidelines](https://codedocs.xyz/xbmc/xbmc/code_guidelines.html) of this project \r\n- [ ] My change requires a change to the documentation, either Doxygen or wiki\r\n- [ ] I have updated the documentation accordingly\r\n- [X] I have read the [CONTRIBUTING](https://github.com/xbmc/xbmc/blob/master/CONTRIBUTING.md) document\r\n- [ ] I have added tests to cover my change\r\n- [ ] All new and existing tests passed\r\n"},"comment":{"url":"https://api.github.com/repos/xbmc/xbmc/issues/comments/326866682","html_url":"https://github.com/xbmc/xbmc/pull/12757#issuecomment-326866682","issue_url":"https://api.github.com/repos/xbmc/xbmc/issues/12757","id":326866682,"user":{"login":"Albinoman887","id":1060921,"avatar_url":"https://avatars1.githubusercontent.com/u/1060921?v=4","gravatar_id":"","url":"https://api.github.com/users/Albinoman887","html_url":"https://github.com/Albinoman887","followers_url":"https://api.github.com/users/Albinoman887/followers","following_url":"https://api.github.com/users/Albinoman887/following{/other_user}","gists_url":"https://api.github.com/users/Albinoman887/gists{/gist_id}","starred_url":"https://api.github.com/users/Albinoman887/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Albinoman887/subscriptions","organizations_url":"https://api.github.com/users/Albinoman887/orgs","repos_url":"https://api.github.com/users/Albinoman887/repos","events_url":"https://api.github.com/users/Albinoman887/events{/privacy}","received_events_url":"https://api.github.com/users/Albinoman887/received_events","type":"User","site_admin":false},"created_at":"2017-09-04T05:03:30Z","updated_at":"2017-09-04T05:03:30Z","author_association":"NONE","body":"OK I'll get you the media and exact settings because I've had this bug for\na few versions . since 14\n\nOn Sep 3, 2017 9:40 PM, \"Rainer Hochecker\" <notifications@github.com> wrote:\n\n> that was what I did. I tried with setting optimized and best match, with\n> and without cross fading. no problem here\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/xbmc/xbmc/pull/12757#issuecomment-326864513>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/ABAwOf6A6yLrTgp8lDLBZW0ikMaRnP85ks5se39FgaJpZM4PJ7xZ>\n> .\n>\n"}}
{"actor":{"display_login":"Albinoman887"}}