{"action":"opened","number":1288,"pull_request":{"url":"https://api.github.com/repos/phan/phan/pulls/1288","id":152123662,"html_url":"https://github.com/phan/phan/pull/1288","diff_url":"https://github.com/phan/phan/pull/1288.diff","patch_url":"https://github.com/phan/phan/pull/1288.patch","issue_url":"https://api.github.com/repos/phan/phan/issues/1288","number":1288,"state":"open","locked":false,"title":" Fix false positives in self-analysis (unreferenced constants) ","user":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars2.githubusercontent.com/u/1904430?v=4","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"body":"Use $constant->isPHPInternal() instead of defined('constant_name') to check if a constant is internal before marking a constant as referenced.\r\nPhan's own constants were treated as internal and not marked as used, which meant dead code detection checks behaved incorrectly for those constants.\r\n\r\n","created_at":"2017-11-12T21:08:51Z","updated_at":"2017-11-12T21:08:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/phan/phan/pulls/1288/commits","review_comments_url":"https://api.github.com/repos/phan/phan/pulls/1288/comments","review_comment_url":"https://api.github.com/repos/phan/phan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/phan/phan/issues/1288/comments","statuses_url":"https://api.github.com/repos/phan/phan/statuses/b9d02d97fd1d18e007b25a4ab17f9b7fdc4ba403","head":{"label":"TysonAndre:fix-self-unreferenced-constant","ref":"fix-self-unreferenced-constant","sha":"b9d02d97fd1d18e007b25a4ab17f9b7fdc4ba403","user":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars2.githubusercontent.com/u/1904430?v=4","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"repo":{"id":70954730,"name":"phan","full_name":"TysonAndre/phan","owner":{"login":"TysonAndre","id":1904430,"avatar_url":"https://avatars2.githubusercontent.com/u/1904430?v=4","gravatar_id":"","url":"https://api.github.com/users/TysonAndre","html_url":"https://github.com/TysonAndre","followers_url":"https://api.github.com/users/TysonAndre/followers","following_url":"https://api.github.com/users/TysonAndre/following{/other_user}","gists_url":"https://api.github.com/users/TysonAndre/gists{/gist_id}","starred_url":"https://api.github.com/users/TysonAndre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TysonAndre/subscriptions","organizations_url":"https://api.github.com/users/TysonAndre/orgs","repos_url":"https://api.github.com/users/TysonAndre/repos","events_url":"https://api.github.com/users/TysonAndre/events{/privacy}","received_events_url":"https://api.github.com/users/TysonAndre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TysonAndre/phan","description":"Static analyzer for PHP","fork":true,"url":"https://api.github.com/repos/TysonAndre/phan","forks_url":"https://api.github.com/repos/TysonAndre/phan/forks","keys_url":"https://api.github.com/repos/TysonAndre/phan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TysonAndre/phan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TysonAndre/phan/teams","hooks_url":"https://api.github.com/repos/TysonAndre/phan/hooks","issue_events_url":"https://api.github.com/repos/TysonAndre/phan/issues/events{/number}","events_url":"https://api.github.com/repos/TysonAndre/phan/events","assignees_url":"https://api.github.com/repos/TysonAndre/phan/assignees{/user}","branches_url":"https://api.github.com/repos/TysonAndre/phan/branches{/branch}","tags_url":"https://api.github.com/repos/TysonAndre/phan/tags","blobs_url":"https://api.github.com/repos/TysonAndre/phan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TysonAndre/phan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TysonAndre/phan/git/refs{/sha}","trees_url":"https://api.github.com/repos/TysonAndre/phan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TysonAndre/phan/statuses/{sha}","languages_url":"https://api.github.com/repos/TysonAndre/phan/languages","stargazers_url":"https://api.github.com/repos/TysonAndre/phan/stargazers","contributors_url":"https://api.github.com/repos/TysonAndre/phan/contributors","subscribers_url":"https://api.github.com/repos/TysonAndre/phan/subscribers","subscription_url":"https://api.github.com/repos/TysonAndre/phan/subscription","commits_url":"https://api.github.com/repos/TysonAndre/phan/commits{/sha}","git_commits_url":"https://api.github.com/repos/TysonAndre/phan/git/commits{/sha}","comments_url":"https://api.github.com/repos/TysonAndre/phan/comments{/number}","issue_comment_url":"https://api.github.com/repos/TysonAndre/phan/issues/comments{/number}","contents_url":"https://api.github.com/repos/TysonAndre/phan/contents/{+path}","compare_url":"https://api.github.com/repos/TysonAndre/phan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TysonAndre/phan/merges","archive_url":"https://api.github.com/repos/TysonAndre/phan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TysonAndre/phan/downloads","issues_url":"https://api.github.com/repos/TysonAndre/phan/issues{/number}","pulls_url":"https://api.github.com/repos/TysonAndre/phan/pulls{/number}","milestones_url":"https://api.github.com/repos/TysonAndre/phan/milestones{/number}","notifications_url":"https://api.github.com/repos/TysonAndre/phan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TysonAndre/phan/labels{/name}","releases_url":"https://api.github.com/repos/TysonAndre/phan/releases{/id}","deployments_url":"https://api.github.com/repos/TysonAndre/phan/deployments","created_at":"2016-10-14T23:47:13Z","updated_at":"2017-09-21T20:15:48Z","pushed_at":"2017-11-12T21:08:18Z","git_url":"git://github.com/TysonAndre/phan.git","ssh_url":"git@github.com:TysonAndre/phan.git","clone_url":"https://github.com/TysonAndre/phan.git","svn_url":"https://github.com/TysonAndre/phan","homepage":null,"size":8558,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":69,"forks":0,"open_issues":69,"watchers":0,"default_branch":"master"}},"base":{"label":"phan:master","ref":"master","sha":"c0d31404a7fe66b5e4a250a660f3442c69872a95","user":{"login":"phan","id":31359272,"avatar_url":"https://avatars2.githubusercontent.com/u/31359272?v=4","gravatar_id":"","url":"https://api.github.com/users/phan","html_url":"https://github.com/phan","followers_url":"https://api.github.com/users/phan/followers","following_url":"https://api.github.com/users/phan/following{/other_user}","gists_url":"https://api.github.com/users/phan/gists{/gist_id}","starred_url":"https://api.github.com/users/phan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phan/subscriptions","organizations_url":"https://api.github.com/users/phan/orgs","repos_url":"https://api.github.com/users/phan/repos","events_url":"https://api.github.com/users/phan/events{/privacy}","received_events_url":"https://api.github.com/users/phan/received_events","type":"Organization","site_admin":false},"repo":{"id":44751102,"name":"phan","full_name":"phan/phan","owner":{"login":"phan","id":31359272,"avatar_url":"https://avatars2.githubusercontent.com/u/31359272?v=4","gravatar_id":"","url":"https://api.github.com/users/phan","html_url":"https://github.com/phan","followers_url":"https://api.github.com/users/phan/followers","following_url":"https://api.github.com/users/phan/following{/other_user}","gists_url":"https://api.github.com/users/phan/gists{/gist_id}","starred_url":"https://api.github.com/users/phan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phan/subscriptions","organizations_url":"https://api.github.com/users/phan/orgs","repos_url":"https://api.github.com/users/phan/repos","events_url":"https://api.github.com/users/phan/events{/privacy}","received_events_url":"https://api.github.com/users/phan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/phan/phan","description":"Phan is a static analyzer for PHP. Phan prefers to avoid false-positives and attempts to prove incorrectness rather than correctness.","fork":false,"url":"https://api.github.com/repos/phan/phan","forks_url":"https://api.github.com/repos/phan/phan/forks","keys_url":"https://api.github.com/repos/phan/phan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phan/phan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phan/phan/teams","hooks_url":"https://api.github.com/repos/phan/phan/hooks","issue_events_url":"https://api.github.com/repos/phan/phan/issues/events{/number}","events_url":"https://api.github.com/repos/phan/phan/events","assignees_url":"https://api.github.com/repos/phan/phan/assignees{/user}","branches_url":"https://api.github.com/repos/phan/phan/branches{/branch}","tags_url":"https://api.github.com/repos/phan/phan/tags","blobs_url":"https://api.github.com/repos/phan/phan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phan/phan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phan/phan/git/refs{/sha}","trees_url":"https://api.github.com/repos/phan/phan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phan/phan/statuses/{sha}","languages_url":"https://api.github.com/repos/phan/phan/languages","stargazers_url":"https://api.github.com/repos/phan/phan/stargazers","contributors_url":"https://api.github.com/repos/phan/phan/contributors","subscribers_url":"https://api.github.com/repos/phan/phan/subscribers","subscription_url":"https://api.github.com/repos/phan/phan/subscription","commits_url":"https://api.github.com/repos/phan/phan/commits{/sha}","git_commits_url":"https://api.github.com/repos/phan/phan/git/commits{/sha}","comments_url":"https://api.github.com/repos/phan/phan/comments{/number}","issue_comment_url":"https://api.github.com/repos/phan/phan/issues/comments{/number}","contents_url":"https://api.github.com/repos/phan/phan/contents/{+path}","compare_url":"https://api.github.com/repos/phan/phan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phan/phan/merges","archive_url":"https://api.github.com/repos/phan/phan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phan/phan/downloads","issues_url":"https://api.github.com/repos/phan/phan/issues{/number}","pulls_url":"https://api.github.com/repos/phan/phan/pulls{/number}","milestones_url":"https://api.github.com/repos/phan/phan/milestones{/number}","notifications_url":"https://api.github.com/repos/phan/phan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phan/phan/labels{/name}","releases_url":"https://api.github.com/repos/phan/phan/releases{/id}","deployments_url":"https://api.github.com/repos/phan/phan/deployments","created_at":"2015-10-22T14:34:09Z","updated_at":"2017-11-12T19:59:10Z","pushed_at":"2017-11-12T19:57:03Z","git_url":"git://github.com/phan/phan.git","ssh_url":"git@github.com:phan/phan.git","clone_url":"https://github.com/phan/phan.git","svn_url":"https://github.com/phan/phan","homepage":"","size":7336,"stargazers_count":2492,"watchers_count":2492,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":180,"mirror_url":null,"archived":false,"open_issues_count":179,"forks":180,"open_issues":179,"watchers":2492,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/phan/phan/pulls/1288"},"html":{"href":"https://github.com/phan/phan/pull/1288"},"issue":{"href":"https://api.github.com/repos/phan/phan/issues/1288"},"comments":{"href":"https://api.github.com/repos/phan/phan/issues/1288/comments"},"review_comments":{"href":"https://api.github.com/repos/phan/phan/pulls/1288/comments"},"review_comment":{"href":"https://api.github.com/repos/phan/phan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/phan/phan/pulls/1288/commits"},"statuses":{"href":"https://api.github.com/repos/phan/phan/statuses/b9d02d97fd1d18e007b25a4ab17f9b7fdc4ba403"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":5,"additions":118,"deletions":89,"changed_files":29}}
{"actor":{"display_login":"TysonAndre"}}