{"action":"created","issue":{"url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1225","repository_url":"https://api.github.com/repos/crowbar/crowbar-core","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1225/labels{/name}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1225/comments","events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1225/events","html_url":"https://github.com/crowbar/crowbar-core/pull/1225","id":223818191,"number":1225,"title":"crowbar: Do not save applied proposal as role too early in apply_role","user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars0.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-24T13:22:05Z","updated_at":"2017-04-25T09:37:55Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1225","html_url":"https://github.com/crowbar/crowbar-core/pull/1225","diff_url":"https://github.com/crowbar/crowbar-core/pull/1225.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/1225.patch"},"body":"Until now, we saved the role for the applied proposal early in\r\napply_role. However, apply_role could fail after that but still before\r\napply_role_pre_chef_client, resulting in the role containing incomplete\r\ndata (since apply_role_pre_chef_client is used to process the role and\r\nadd some info, like \"use HA\").\r\n\r\nIn case of such a failure (and that can happen when we fail to get a\r\nlock for a node), then a periodic chef-client run would use a role with\r\nincomplete information, possibly leading to changing the config on the\r\nnode wrongly.\r\n\r\nCloses https://github.com/sap-oc/crowbar-openstack/issues/34"},"comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments/296975151","html_url":"https://github.com/crowbar/crowbar-core/pull/1225#issuecomment-296975151","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1225","id":296975151,"user":{"login":"vuntz","id":1758783,"avatar_url":"https://avatars0.githubusercontent.com/u/1758783?v=3","gravatar_id":"","url":"https://api.github.com/users/vuntz","html_url":"https://github.com/vuntz","followers_url":"https://api.github.com/users/vuntz/followers","following_url":"https://api.github.com/users/vuntz/following{/other_user}","gists_url":"https://api.github.com/users/vuntz/gists{/gist_id}","starred_url":"https://api.github.com/users/vuntz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuntz/subscriptions","organizations_url":"https://api.github.com/users/vuntz/orgs","repos_url":"https://api.github.com/users/vuntz/repos","events_url":"https://api.github.com/users/vuntz/events{/privacy}","received_events_url":"https://api.github.com/users/vuntz/received_events","type":"User","site_admin":false},"created_at":"2017-04-25T09:37:55Z","updated_at":"2017-04-25T09:37:55Z","body":"@matelakat any +1 here, since you tested the patch? :-)"}}
{"actor":{"display_login":"vuntz"}}