{"action":"created","comment":{"url":"https://api.github.com/repos/OPM/ewoms/pulls/comments/149064752","pull_request_review_id":74399521,"id":149064752,"diff_hunk":"@@ -479,16 +479,24 @@ public:\n             Scalar initialDt = EWOMS_GET_PARAM(TypeTag, Scalar, InitialTimeStepSize);\n             dt = std::min(dt, initialDt);\n         }\n+        //NB pudateCell values is called before dt is updated to since it is based on the prevois step.\n+        // this put the model state set values which should be form the\n+        // prevois step\n+        ElementContext elemCtx(this->simulator());\n+        this->model().updateCellValues(elemCtx, this->simulator().gridManager().gridView() );\n \n         if (nextEpisodeIdx < numReportSteps) {\n             simulator.startNextEpisode(episodeLength);\n             simulator.setTimeStepSize(dt);\n         }\n \n+\n+\n         if (updateHysteresis_())\n             this->model().invalidateIntensiveQuantitiesCache(/*timeIdx=*/0);\n-\n-        this->model().updateMaxOilSaturations();\n+        // NB update MaxOilSaturation is called here instead of endEpisode to get correct output for the lagged evalauation\n+        // used in eclipse\n+        this->model().updateMaxOilSaturations();// this should be removed when cellValues is properly functions","path":"ebos/eclproblem.hh","position":23,"original_position":23,"commit_id":"1c0afe803fa28da6482afd633f3d89179e04d205","original_commit_id":"1c0afe803fa28da6482afd633f3d89179e04d205","user":{"login":"andlaus","id":1837735,"avatar_url":"https://avatars3.githubusercontent.com/u/1837735?v=4","gravatar_id":"","url":"https://api.github.com/users/andlaus","html_url":"https://github.com/andlaus","followers_url":"https://api.github.com/users/andlaus/followers","following_url":"https://api.github.com/users/andlaus/following{/other_user}","gists_url":"https://api.github.com/users/andlaus/gists{/gist_id}","starred_url":"https://api.github.com/users/andlaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andlaus/subscriptions","organizations_url":"https://api.github.com/users/andlaus/orgs","repos_url":"https://api.github.com/users/andlaus/repos","events_url":"https://api.github.com/users/andlaus/events{/privacy}","received_events_url":"https://api.github.com/users/andlaus/received_events","type":"User","site_admin":false},"body":"In my mind, as a general rule, everything which does not directly depend on the solution that is to be found for the current time level belongs into the problem, stuff that depends on that solution should be part of the model. I'm thinking in \"forward-mode\", though.","created_at":"2017-11-06T12:19:38Z","updated_at":"2017-11-06T12:19:38Z","html_url":"https://github.com/OPM/ewoms/pull/230#discussion_r149064752","pull_request_url":"https://api.github.com/repos/OPM/ewoms/pulls/230","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/comments/149064752"},"html":{"href":"https://github.com/OPM/ewoms/pull/230#discussion_r149064752"},"pull_request":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/230"}},"in_reply_to_id":148766473},"pull_request":{"url":"https://api.github.com/repos/OPM/ewoms/pulls/230","id":148431323,"html_url":"https://github.com/OPM/ewoms/pull/230","diff_url":"https://github.com/OPM/ewoms/pull/230.diff","patch_url":"https://github.com/OPM/ewoms/pull/230.patch","issue_url":"https://api.github.com/repos/OPM/ewoms/issues/230","number":230,"state":"open","locked":false,"title":"Drsdt work in progress","user":{"login":"hnil","id":1936524,"avatar_url":"https://avatars3.githubusercontent.com/u/1936524?v=4","gravatar_id":"","url":"https://api.github.com/users/hnil","html_url":"https://github.com/hnil","followers_url":"https://api.github.com/users/hnil/followers","following_url":"https://api.github.com/users/hnil/following{/other_user}","gists_url":"https://api.github.com/users/hnil/gists{/gist_id}","starred_url":"https://api.github.com/users/hnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnil/subscriptions","organizations_url":"https://api.github.com/users/hnil/orgs","repos_url":"https://api.github.com/users/hnil/repos","events_url":"https://api.github.com/users/hnil/events{/privacy}","received_events_url":"https://api.github.com/users/hnil/received_events","type":"User","site_admin":false},"body":"This is to discuss how to incorporate DRSDT.  This depend on branch hnil_work in opm-simulators and opm-materials. It brakes some of the codes in eworms at the moment.","created_at":"2017-10-24T15:26:41Z","updated_at":"2017-11-06T12:19:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5524220b7738087e1e98078c376acf52b716a9fa","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/OPM/ewoms/pulls/230/commits","review_comments_url":"https://api.github.com/repos/OPM/ewoms/pulls/230/comments","review_comment_url":"https://api.github.com/repos/OPM/ewoms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OPM/ewoms/issues/230/comments","statuses_url":"https://api.github.com/repos/OPM/ewoms/statuses/1c0afe803fa28da6482afd633f3d89179e04d205","head":{"label":"hnil:hnil_work","ref":"hnil_work","sha":"1c0afe803fa28da6482afd633f3d89179e04d205","user":{"login":"hnil","id":1936524,"avatar_url":"https://avatars3.githubusercontent.com/u/1936524?v=4","gravatar_id":"","url":"https://api.github.com/users/hnil","html_url":"https://github.com/hnil","followers_url":"https://api.github.com/users/hnil/followers","following_url":"https://api.github.com/users/hnil/following{/other_user}","gists_url":"https://api.github.com/users/hnil/gists{/gist_id}","starred_url":"https://api.github.com/users/hnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnil/subscriptions","organizations_url":"https://api.github.com/users/hnil/orgs","repos_url":"https://api.github.com/users/hnil/repos","events_url":"https://api.github.com/users/hnil/events{/privacy}","received_events_url":"https://api.github.com/users/hnil/received_events","type":"User","site_admin":false},"repo":{"id":102456999,"name":"ewoms","full_name":"hnil/ewoms","owner":{"login":"hnil","id":1936524,"avatar_url":"https://avatars3.githubusercontent.com/u/1936524?v=4","gravatar_id":"","url":"https://api.github.com/users/hnil","html_url":"https://github.com/hnil","followers_url":"https://api.github.com/users/hnil/followers","following_url":"https://api.github.com/users/hnil/following{/other_user}","gists_url":"https://api.github.com/users/hnil/gists{/gist_id}","starred_url":"https://api.github.com/users/hnil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hnil/subscriptions","organizations_url":"https://api.github.com/users/hnil/orgs","repos_url":"https://api.github.com/users/hnil/repos","events_url":"https://api.github.com/users/hnil/events{/privacy}","received_events_url":"https://api.github.com/users/hnil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hnil/ewoms","description":"The eWoms Porous Media Simulation Framework","fork":true,"url":"https://api.github.com/repos/hnil/ewoms","forks_url":"https://api.github.com/repos/hnil/ewoms/forks","keys_url":"https://api.github.com/repos/hnil/ewoms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hnil/ewoms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hnil/ewoms/teams","hooks_url":"https://api.github.com/repos/hnil/ewoms/hooks","issue_events_url":"https://api.github.com/repos/hnil/ewoms/issues/events{/number}","events_url":"https://api.github.com/repos/hnil/ewoms/events","assignees_url":"https://api.github.com/repos/hnil/ewoms/assignees{/user}","branches_url":"https://api.github.com/repos/hnil/ewoms/branches{/branch}","tags_url":"https://api.github.com/repos/hnil/ewoms/tags","blobs_url":"https://api.github.com/repos/hnil/ewoms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hnil/ewoms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hnil/ewoms/git/refs{/sha}","trees_url":"https://api.github.com/repos/hnil/ewoms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hnil/ewoms/statuses/{sha}","languages_url":"https://api.github.com/repos/hnil/ewoms/languages","stargazers_url":"https://api.github.com/repos/hnil/ewoms/stargazers","contributors_url":"https://api.github.com/repos/hnil/ewoms/contributors","subscribers_url":"https://api.github.com/repos/hnil/ewoms/subscribers","subscription_url":"https://api.github.com/repos/hnil/ewoms/subscription","commits_url":"https://api.github.com/repos/hnil/ewoms/commits{/sha}","git_commits_url":"https://api.github.com/repos/hnil/ewoms/git/commits{/sha}","comments_url":"https://api.github.com/repos/hnil/ewoms/comments{/number}","issue_comment_url":"https://api.github.com/repos/hnil/ewoms/issues/comments{/number}","contents_url":"https://api.github.com/repos/hnil/ewoms/contents/{+path}","compare_url":"https://api.github.com/repos/hnil/ewoms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hnil/ewoms/merges","archive_url":"https://api.github.com/repos/hnil/ewoms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hnil/ewoms/downloads","issues_url":"https://api.github.com/repos/hnil/ewoms/issues{/number}","pulls_url":"https://api.github.com/repos/hnil/ewoms/pulls{/number}","milestones_url":"https://api.github.com/repos/hnil/ewoms/milestones{/number}","notifications_url":"https://api.github.com/repos/hnil/ewoms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hnil/ewoms/labels{/name}","releases_url":"https://api.github.com/repos/hnil/ewoms/releases{/id}","deployments_url":"https://api.github.com/repos/hnil/ewoms/deployments","created_at":"2017-09-05T08:43:03Z","updated_at":"2017-09-05T08:43:06Z","pushed_at":"2017-11-05T17:56:18Z","git_url":"git://github.com/hnil/ewoms.git","ssh_url":"git@github.com:hnil/ewoms.git","clone_url":"https://github.com/hnil/ewoms.git","svn_url":"https://github.com/hnil/ewoms","homepage":null,"size":26009,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OPM:master","ref":"master","sha":"b8e159a5f69f4718c01223664bd8399c9d13d5e3","user":{"login":"OPM","id":1827197,"avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"repo":{"id":4859310,"name":"ewoms","full_name":"OPM/ewoms","owner":{"login":"OPM","id":1827197,"avatar_url":"https://avatars0.githubusercontent.com/u/1827197?v=4","gravatar_id":"","url":"https://api.github.com/users/OPM","html_url":"https://github.com/OPM","followers_url":"https://api.github.com/users/OPM/followers","following_url":"https://api.github.com/users/OPM/following{/other_user}","gists_url":"https://api.github.com/users/OPM/gists{/gist_id}","starred_url":"https://api.github.com/users/OPM/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OPM/subscriptions","organizations_url":"https://api.github.com/users/OPM/orgs","repos_url":"https://api.github.com/users/OPM/repos","events_url":"https://api.github.com/users/OPM/events{/privacy}","received_events_url":"https://api.github.com/users/OPM/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OPM/ewoms","description":"The eWoms Porous Media Simulation Framework","fork":false,"url":"https://api.github.com/repos/OPM/ewoms","forks_url":"https://api.github.com/repos/OPM/ewoms/forks","keys_url":"https://api.github.com/repos/OPM/ewoms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OPM/ewoms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OPM/ewoms/teams","hooks_url":"https://api.github.com/repos/OPM/ewoms/hooks","issue_events_url":"https://api.github.com/repos/OPM/ewoms/issues/events{/number}","events_url":"https://api.github.com/repos/OPM/ewoms/events","assignees_url":"https://api.github.com/repos/OPM/ewoms/assignees{/user}","branches_url":"https://api.github.com/repos/OPM/ewoms/branches{/branch}","tags_url":"https://api.github.com/repos/OPM/ewoms/tags","blobs_url":"https://api.github.com/repos/OPM/ewoms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OPM/ewoms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OPM/ewoms/git/refs{/sha}","trees_url":"https://api.github.com/repos/OPM/ewoms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OPM/ewoms/statuses/{sha}","languages_url":"https://api.github.com/repos/OPM/ewoms/languages","stargazers_url":"https://api.github.com/repos/OPM/ewoms/stargazers","contributors_url":"https://api.github.com/repos/OPM/ewoms/contributors","subscribers_url":"https://api.github.com/repos/OPM/ewoms/subscribers","subscription_url":"https://api.github.com/repos/OPM/ewoms/subscription","commits_url":"https://api.github.com/repos/OPM/ewoms/commits{/sha}","git_commits_url":"https://api.github.com/repos/OPM/ewoms/git/commits{/sha}","comments_url":"https://api.github.com/repos/OPM/ewoms/comments{/number}","issue_comment_url":"https://api.github.com/repos/OPM/ewoms/issues/comments{/number}","contents_url":"https://api.github.com/repos/OPM/ewoms/contents/{+path}","compare_url":"https://api.github.com/repos/OPM/ewoms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OPM/ewoms/merges","archive_url":"https://api.github.com/repos/OPM/ewoms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OPM/ewoms/downloads","issues_url":"https://api.github.com/repos/OPM/ewoms/issues{/number}","pulls_url":"https://api.github.com/repos/OPM/ewoms/pulls{/number}","milestones_url":"https://api.github.com/repos/OPM/ewoms/milestones{/number}","notifications_url":"https://api.github.com/repos/OPM/ewoms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OPM/ewoms/labels{/name}","releases_url":"https://api.github.com/repos/OPM/ewoms/releases{/id}","deployments_url":"https://api.github.com/repos/OPM/ewoms/deployments","created_at":"2012-07-02T12:07:07Z","updated_at":"2017-10-26T13:33:53Z","pushed_at":"2017-11-03T17:35:38Z","git_url":"git://github.com/OPM/ewoms.git","ssh_url":"git@github.com:OPM/ewoms.git","clone_url":"https://github.com/OPM/ewoms.git","svn_url":"https://github.com/OPM/ewoms","homepage":null,"size":25964,"stargazers_count":4,"watchers_count":4,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":27,"mirror_url":null,"archived":false,"open_issues_count":4,"forks":27,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/230"},"html":{"href":"https://github.com/OPM/ewoms/pull/230"},"issue":{"href":"https://api.github.com/repos/OPM/ewoms/issues/230"},"comments":{"href":"https://api.github.com/repos/OPM/ewoms/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OPM/ewoms/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/OPM/ewoms/statuses/1c0afe803fa28da6482afd633f3d89179e04d205"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"andlaus"}}