{"action":"created","comment":{"url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/comments/128592215","pull_request_review_id":51287615,"id":128592215,"diff_hunk":"@@ -960,14 +1001,405 @@ class ConversationTests: XCTestCase {\n         waitForExpectations()\n     }\n \n+    // MARK: - Entities\n+\n+    func testListAllEntities() {\n+        let description = \"List all entities\"\n+        let expectation = self.expectation(description: description)\n+\n+        conversation.listEntities(workspaceID: workspaceID, failure: failWithError){entities in\n+            for entity in entities.entities {\n+                XCTAssertNotNil(entity.entity)\n+                XCTAssertNotNil(entity.created)\n+                XCTAssertNotNil(entity.updated)\n+            }\n+            XCTAssert(entities.entities.count > 0)\n+            XCTAssertNotNil(entities.pagination.refreshUrl)\n+            XCTAssertNil(entities.pagination.nextUrl)\n+            XCTAssertNil(entities.pagination.total)\n+            XCTAssertNil(entities.pagination.matched)\n+            expectation.fulfill()\n+        }\n+        waitForExpectations()\n+    }\n+\n+    func testListAllEntitiesWithIncludeCount() {\n+        let description = \"List all the entities in a workspace with includeCount as true.\"\n+        let expectation = self.expectation(description: description)\n+\n+        conversation.listEntities(workspaceID: workspaceID, includeCount: true, failure: failWithError) { entities in\n+            for entity in entities.entities {\n+                XCTAssertNotNil(entity.entity)\n+                XCTAssertNotNil(entity.created)\n+                XCTAssertNotNil(entity.updated)\n+            }\n+            XCTAssertNotNil(entities.pagination.refreshUrl)\n+            XCTAssertNil(entities.pagination.nextUrl)\n+            XCTAssertNotNil(entities.pagination.total)\n+            XCTAssertNotNil(entities.pagination.matched)\n+            XCTAssertEqual(entities.pagination.total, entities.entities.count)\n+            expectation.fulfill()\n+        }\n+        waitForExpectations()\n+    }\n+\n+    func testListAllEntitiesWithPageLimit1() {\n+        let description = \"List all entities with page limit 1\"\n+        let expectation = self.expectation(description: description)\n+\n+        conversation.listEntities(workspaceID: workspaceID, pageLimit: 1, failure: failWithError){entities in\n+            for entity in entities.entities {\n+                XCTAssertNotNil(entity.entity)\n+                XCTAssertNotNil(entity.created)\n+                XCTAssertNotNil(entity.updated)\n+            }\n+            XCTAssertNotNil(entities.pagination.refreshUrl)\n+            XCTAssertNotNil(entities.pagination.nextUrl)\n+            XCTAssertNil(entities.pagination.total)\n+            XCTAssertNil(entities.pagination.matched)\n+\n+            XCTAssert(entities.entities.count > 0)\n+            expectation.fulfill()\n+        }\n+        waitForExpectations()\n+    }\n+\n+    func testListAllEntitiesWithExport() {\n+        let description = \"List all the entities in a workspace with export as true.\"\n+        let expectation = self.expectation(description: description)\n+\n+        conversation.listEntities(workspaceID: workspaceID, export: true, failure: failWithError) { entities in\n+            for entity in entities.entities {\n+                XCTAssertNotNil(entity.entity)\n+                XCTAssertNotNil(entity.created)\n+                XCTAssertNotNil(entity.updated)\n+            }\n+            XCTAssertNotNil(entities.entities)\n+            XCTAssertNil(entities.pagination.total)\n+            XCTAssertNil(entities.pagination.matched)\n+            XCTAssertNil(entities.pagination.nextUrl)\n+            expectation.fulfill()\n+        }\n+        waitForExpectations()\n+    }\n+\n+    func testCreateAndDeleteEntity(){\n+        let description = \"Create an Entity\"\n+        let expectation = self.expectation(description: description)\n+\n+        let newEntityName = \"swift-sdk-test-entity\" + UUID().uuidString\n+        //let firstVal = CreateValue.init(value: \"full\", synonyms: [\"filled\"])\n+        //let secondVal = CreateValue.init(value: \"empty\")","path":"Tests/ConversationV1Tests/ConversationTests.swift","position":224,"original_position":224,"commit_id":"0a178a342d51679035fc230ce6679499cee1ca41","original_commit_id":"0a178a342d51679035fc230ce6679499cee1ca41","user":{"login":"mkistler","id":800728,"avatar_url":"https://avatars3.githubusercontent.com/u/800728?v=4","gravatar_id":"","url":"https://api.github.com/users/mkistler","html_url":"https://github.com/mkistler","followers_url":"https://api.github.com/users/mkistler/followers","following_url":"https://api.github.com/users/mkistler/following{/other_user}","gists_url":"https://api.github.com/users/mkistler/gists{/gist_id}","starred_url":"https://api.github.com/users/mkistler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkistler/subscriptions","organizations_url":"https://api.github.com/users/mkistler/orgs","repos_url":"https://api.github.com/users/mkistler/repos","events_url":"https://api.github.com/users/mkistler/events{/privacy}","received_events_url":"https://api.github.com/users/mkistler/received_events","type":"User","site_admin":false},"body":"Yes.  Good catch.","created_at":"2017-07-20T18:17:04Z","updated_at":"2017-07-20T18:17:04Z","html_url":"https://github.com/watson-developer-cloud/swift-sdk/pull/651#discussion_r128592215","pull_request_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/651","_links":{"self":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/comments/128592215"},"html":{"href":"https://github.com/watson-developer-cloud/swift-sdk/pull/651#discussion_r128592215"},"pull_request":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/651"}}},"pull_request":{"url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/651","id":131227354,"html_url":"https://github.com/watson-developer-cloud/swift-sdk/pull/651","diff_url":"https://github.com/watson-developer-cloud/swift-sdk/pull/651.diff","patch_url":"https://github.com/watson-developer-cloud/swift-sdk/pull/651.patch","issue_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/651","number":651,"state":"open","locked":false,"title":"Update Conversation Service to 2017-05-26 API","user":{"login":"mkistler","id":800728,"avatar_url":"https://avatars3.githubusercontent.com/u/800728?v=4","gravatar_id":"","url":"https://api.github.com/users/mkistler","html_url":"https://github.com/mkistler","followers_url":"https://api.github.com/users/mkistler/followers","following_url":"https://api.github.com/users/mkistler/following{/other_user}","gists_url":"https://api.github.com/users/mkistler/gists{/gist_id}","starred_url":"https://api.github.com/users/mkistler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkistler/subscriptions","organizations_url":"https://api.github.com/users/mkistler/orgs","repos_url":"https://api.github.com/users/mkistler/repos","events_url":"https://api.github.com/users/mkistler/events{/privacy}","received_events_url":"https://api.github.com/users/mkistler/received_events","type":"User","site_admin":false},"body":"Updates Conversation service SDK to support new features of 2017-05-26 API version.","created_at":"2017-07-19T02:53:19Z","updated_at":"2017-07-20T18:17:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f4675ef4b2f84c24d2bd12b2bc6dd1de1d1d0bd8","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/651/commits","review_comments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/651/comments","review_comment_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/651/comments","statuses_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/statuses/0a178a342d51679035fc230ce6679499cee1ca41","head":{"label":"watson-developer-cloud:mdk/conversation-update","ref":"mdk/conversation-update","sha":"0a178a342d51679035fc230ce6679499cee1ca41","user":{"login":"watson-developer-cloud","id":10017763,"avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":42934262,"name":"swift-sdk","full_name":"watson-developer-cloud/swift-sdk","owner":{"login":"watson-developer-cloud","id":10017763,"avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/watson-developer-cloud/swift-sdk","description":":iphone: The Watson Swift SDK enables developers to quickly add Watson Cognitive Computing services to their Swift applications.","fork":false,"url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk","forks_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/forks","keys_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/teams","hooks_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/hooks","issue_events_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/events","assignees_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/tags","blobs_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/languages","stargazers_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/stargazers","contributors_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/contributors","subscribers_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/subscribers","subscription_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/subscription","commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/merges","archive_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/downloads","issues_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/labels{/name}","releases_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/deployments","created_at":"2015-09-22T13:07:37Z","updated_at":"2017-07-19T13:18:27Z","pushed_at":"2017-07-20T02:04:07Z","git_url":"git://github.com/watson-developer-cloud/swift-sdk.git","ssh_url":"git@github.com:watson-developer-cloud/swift-sdk.git","clone_url":"https://github.com/watson-developer-cloud/swift-sdk.git","svn_url":"https://github.com/watson-developer-cloud/swift-sdk","homepage":"","size":54809,"stargazers_count":581,"watchers_count":581,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":153,"mirror_url":null,"open_issues_count":56,"forks":153,"open_issues":56,"watchers":581,"default_branch":"master"}},"base":{"label":"watson-developer-cloud:master","ref":"master","sha":"220f94ec71318babf9757d1cfaafa8fd7bab3804","user":{"login":"watson-developer-cloud","id":10017763,"avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"repo":{"id":42934262,"name":"swift-sdk","full_name":"watson-developer-cloud/swift-sdk","owner":{"login":"watson-developer-cloud","id":10017763,"avatar_url":"https://avatars2.githubusercontent.com/u/10017763?v=4","gravatar_id":"","url":"https://api.github.com/users/watson-developer-cloud","html_url":"https://github.com/watson-developer-cloud","followers_url":"https://api.github.com/users/watson-developer-cloud/followers","following_url":"https://api.github.com/users/watson-developer-cloud/following{/other_user}","gists_url":"https://api.github.com/users/watson-developer-cloud/gists{/gist_id}","starred_url":"https://api.github.com/users/watson-developer-cloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/watson-developer-cloud/subscriptions","organizations_url":"https://api.github.com/users/watson-developer-cloud/orgs","repos_url":"https://api.github.com/users/watson-developer-cloud/repos","events_url":"https://api.github.com/users/watson-developer-cloud/events{/privacy}","received_events_url":"https://api.github.com/users/watson-developer-cloud/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/watson-developer-cloud/swift-sdk","description":":iphone: The Watson Swift SDK enables developers to quickly add Watson Cognitive Computing services to their Swift applications.","fork":false,"url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk","forks_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/forks","keys_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/teams","hooks_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/hooks","issue_events_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/events{/number}","events_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/events","assignees_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/assignees{/user}","branches_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/branches{/branch}","tags_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/tags","blobs_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/refs{/sha}","trees_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/statuses/{sha}","languages_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/languages","stargazers_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/stargazers","contributors_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/contributors","subscribers_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/subscribers","subscription_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/subscription","commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/commits{/sha}","git_commits_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/git/commits{/sha}","comments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/comments{/number}","issue_comment_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/comments{/number}","contents_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/contents/{+path}","compare_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/merges","archive_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/downloads","issues_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues{/number}","pulls_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls{/number}","milestones_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/milestones{/number}","notifications_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/labels{/name}","releases_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/releases{/id}","deployments_url":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/deployments","created_at":"2015-09-22T13:07:37Z","updated_at":"2017-07-19T13:18:27Z","pushed_at":"2017-07-20T02:04:07Z","git_url":"git://github.com/watson-developer-cloud/swift-sdk.git","ssh_url":"git@github.com:watson-developer-cloud/swift-sdk.git","clone_url":"https://github.com/watson-developer-cloud/swift-sdk.git","svn_url":"https://github.com/watson-developer-cloud/swift-sdk","homepage":"","size":54809,"stargazers_count":581,"watchers_count":581,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":153,"mirror_url":null,"open_issues_count":56,"forks":153,"open_issues":56,"watchers":581,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/651"},"html":{"href":"https://github.com/watson-developer-cloud/swift-sdk/pull/651"},"issue":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/651"},"comments":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/issues/651/comments"},"review_comments":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/651/comments"},"review_comment":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/pulls/651/commits"},"statuses":{"href":"https://api.github.com/repos/watson-developer-cloud/swift-sdk/statuses/0a178a342d51679035fc230ce6679499cee1ca41"}}}}
{"actor":{"display_login":"mkistler"}}