{"action":"created","comment":{"url":"https://api.github.com/repos/balancemymoney/balance-open/pulls/comments/153518833","pull_request_review_id":79535139,"id":153518833,"diff_hunk":"@@ -138,10 +138,15 @@ struct CoinbaseApi: ExchangeApi {\n         let task = certValidatedSession.dataTask(with: request) { maybeData, maybeResponse, maybeError in\n             do {\n                 // Make sure there's data\n-                guard let data = maybeData, maybeError == nil else {\n+                guard let data = maybeData else {\n                     throw BalanceError.noData\n                 }\n                 \n+                guard maybeError == nil else {\n+                    log.error(\"Failed with network error: \\(String(describing: maybeError))\")\n+                    throw BalanceError.networkError","path":"Balance/Shared/Data Model/APIs/Coinbase/CoinbaseApi.swift","position":11,"original_position":11,"commit_id":"64756d41eb08641cfb59fba51b2c87fe1cfe03cf","original_commit_id":"64756d41eb08641cfb59fba51b2c87fe1cfe03cf","user":{"login":"einsteinx2","id":350423,"avatar_url":"https://avatars3.githubusercontent.com/u/350423?v=4","gravatar_id":"","url":"https://api.github.com/users/einsteinx2","html_url":"https://github.com/einsteinx2","followers_url":"https://api.github.com/users/einsteinx2/followers","following_url":"https://api.github.com/users/einsteinx2/following{/other_user}","gists_url":"https://api.github.com/users/einsteinx2/gists{/gist_id}","starred_url":"https://api.github.com/users/einsteinx2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/einsteinx2/subscriptions","organizations_url":"https://api.github.com/users/einsteinx2/orgs","repos_url":"https://api.github.com/users/einsteinx2/repos","events_url":"https://api.github.com/users/einsteinx2/events{/privacy}","received_events_url":"https://api.github.com/users/einsteinx2/received_events","type":"User","site_admin":false},"body":"I changed this from unknownError to networkError","created_at":"2017-11-28T15:06:22Z","updated_at":"2017-11-28T15:06:22Z","html_url":"https://github.com/balancemymoney/balance-open/pull/308#discussion_r153518833","pull_request_url":"https://api.github.com/repos/balancemymoney/balance-open/pulls/308","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/balancemymoney/balance-open/pulls/comments/153518833"},"html":{"href":"https://github.com/balancemymoney/balance-open/pull/308#discussion_r153518833"},"pull_request":{"href":"https://api.github.com/repos/balancemymoney/balance-open/pulls/308"}}},"pull_request":{"url":"https://api.github.com/repos/balancemymoney/balance-open/pulls/308","id":155039214,"html_url":"https://github.com/balancemymoney/balance-open/pull/308","diff_url":"https://github.com/balancemymoney/balance-open/pull/308.diff","patch_url":"https://github.com/balancemymoney/balance-open/pull/308.patch","issue_url":"https://api.github.com/repos/balancemymoney/balance-open/issues/308","number":308,"state":"open","locked":false,"title":"Added Countly framework","user":{"login":"wolffan","id":1092080,"avatar_url":"https://avatars0.githubusercontent.com/u/1092080?v=4","gravatar_id":"","url":"https://api.github.com/users/wolffan","html_url":"https://github.com/wolffan","followers_url":"https://api.github.com/users/wolffan/followers","following_url":"https://api.github.com/users/wolffan/following{/other_user}","gists_url":"https://api.github.com/users/wolffan/gists{/gist_id}","starred_url":"https://api.github.com/users/wolffan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolffan/subscriptions","organizations_url":"https://api.github.com/users/wolffan/orgs","repos_url":"https://api.github.com/users/wolffan/repos","events_url":"https://api.github.com/users/wolffan/events{/privacy}","received_events_url":"https://api.github.com/users/wolffan/received_events","type":"User","site_admin":false},"body":"**Does this pull request close an issue? If so, which one?**\r\n#283 #countly\r\n\r\n**What does this pull request do? What does it change?**\r\nAdded to analytics wrapper\r\nincludes some changes on logging for sync\r\nAdded Countly framework via drag and drop\r\n\r\n","created_at":"2017-11-28T11:00:00Z","updated_at":"2017-11-28T15:06:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be98549acb56569260b01a2a07d466d4aac6bca7","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/balancemymoney/balance-open/pulls/308/commits","review_comments_url":"https://api.github.com/repos/balancemymoney/balance-open/pulls/308/comments","review_comment_url":"https://api.github.com/repos/balancemymoney/balance-open/pulls/comments{/number}","comments_url":"https://api.github.com/repos/balancemymoney/balance-open/issues/308/comments","statuses_url":"https://api.github.com/repos/balancemymoney/balance-open/statuses/64756d41eb08641cfb59fba51b2c87fe1cfe03cf","head":{"label":"balancemymoney:task/install-countly","ref":"task/install-countly","sha":"64756d41eb08641cfb59fba51b2c87fe1cfe03cf","user":{"login":"balancemymoney","id":19879255,"avatar_url":"https://avatars2.githubusercontent.com/u/19879255?v=4","gravatar_id":"","url":"https://api.github.com/users/balancemymoney","html_url":"https://github.com/balancemymoney","followers_url":"https://api.github.com/users/balancemymoney/followers","following_url":"https://api.github.com/users/balancemymoney/following{/other_user}","gists_url":"https://api.github.com/users/balancemymoney/gists{/gist_id}","starred_url":"https://api.github.com/users/balancemymoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balancemymoney/subscriptions","organizations_url":"https://api.github.com/users/balancemymoney/orgs","repos_url":"https://api.github.com/users/balancemymoney/repos","events_url":"https://api.github.com/users/balancemymoney/events{/privacy}","received_events_url":"https://api.github.com/users/balancemymoney/received_events","type":"Organization","site_admin":false},"repo":{"id":93853878,"name":"balance-open","full_name":"balancemymoney/balance-open","owner":{"login":"balancemymoney","id":19879255,"avatar_url":"https://avatars2.githubusercontent.com/u/19879255?v=4","gravatar_id":"","url":"https://api.github.com/users/balancemymoney","html_url":"https://github.com/balancemymoney","followers_url":"https://api.github.com/users/balancemymoney/followers","following_url":"https://api.github.com/users/balancemymoney/following{/other_user}","gists_url":"https://api.github.com/users/balancemymoney/gists{/gist_id}","starred_url":"https://api.github.com/users/balancemymoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balancemymoney/subscriptions","organizations_url":"https://api.github.com/users/balancemymoney/orgs","repos_url":"https://api.github.com/users/balancemymoney/repos","events_url":"https://api.github.com/users/balancemymoney/events{/privacy}","received_events_url":"https://api.github.com/users/balancemymoney/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/balancemymoney/balance-open","description":"Balance Open: A GPL3-licensed macOS menu bar app for all the world’s currencies.","fork":false,"url":"https://api.github.com/repos/balancemymoney/balance-open","forks_url":"https://api.github.com/repos/balancemymoney/balance-open/forks","keys_url":"https://api.github.com/repos/balancemymoney/balance-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balancemymoney/balance-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balancemymoney/balance-open/teams","hooks_url":"https://api.github.com/repos/balancemymoney/balance-open/hooks","issue_events_url":"https://api.github.com/repos/balancemymoney/balance-open/issues/events{/number}","events_url":"https://api.github.com/repos/balancemymoney/balance-open/events","assignees_url":"https://api.github.com/repos/balancemymoney/balance-open/assignees{/user}","branches_url":"https://api.github.com/repos/balancemymoney/balance-open/branches{/branch}","tags_url":"https://api.github.com/repos/balancemymoney/balance-open/tags","blobs_url":"https://api.github.com/repos/balancemymoney/balance-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balancemymoney/balance-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balancemymoney/balance-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/balancemymoney/balance-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balancemymoney/balance-open/statuses/{sha}","languages_url":"https://api.github.com/repos/balancemymoney/balance-open/languages","stargazers_url":"https://api.github.com/repos/balancemymoney/balance-open/stargazers","contributors_url":"https://api.github.com/repos/balancemymoney/balance-open/contributors","subscribers_url":"https://api.github.com/repos/balancemymoney/balance-open/subscribers","subscription_url":"https://api.github.com/repos/balancemymoney/balance-open/subscription","commits_url":"https://api.github.com/repos/balancemymoney/balance-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/balancemymoney/balance-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/balancemymoney/balance-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/balancemymoney/balance-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/balancemymoney/balance-open/contents/{+path}","compare_url":"https://api.github.com/repos/balancemymoney/balance-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balancemymoney/balance-open/merges","archive_url":"https://api.github.com/repos/balancemymoney/balance-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balancemymoney/balance-open/downloads","issues_url":"https://api.github.com/repos/balancemymoney/balance-open/issues{/number}","pulls_url":"https://api.github.com/repos/balancemymoney/balance-open/pulls{/number}","milestones_url":"https://api.github.com/repos/balancemymoney/balance-open/milestones{/number}","notifications_url":"https://api.github.com/repos/balancemymoney/balance-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balancemymoney/balance-open/labels{/name}","releases_url":"https://api.github.com/repos/balancemymoney/balance-open/releases{/id}","deployments_url":"https://api.github.com/repos/balancemymoney/balance-open/deployments","created_at":"2017-06-09T11:50:50Z","updated_at":"2017-11-22T14:45:25Z","pushed_at":"2017-11-28T15:05:52Z","git_url":"git://github.com/balancemymoney/balance-open.git","ssh_url":"git@github.com:balancemymoney/balance-open.git","clone_url":"https://github.com/balancemymoney/balance-open.git","svn_url":"https://github.com/balancemymoney/balance-open","homepage":"https://balancemy.money","size":270175,"stargazers_count":153,"watchers_count":153,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":73,"forks":18,"open_issues":73,"watchers":153,"default_branch":"master"}},"base":{"label":"balancemymoney:master","ref":"master","sha":"f158fcdacc3fc49f532febd921e422dfd1958a5a","user":{"login":"balancemymoney","id":19879255,"avatar_url":"https://avatars2.githubusercontent.com/u/19879255?v=4","gravatar_id":"","url":"https://api.github.com/users/balancemymoney","html_url":"https://github.com/balancemymoney","followers_url":"https://api.github.com/users/balancemymoney/followers","following_url":"https://api.github.com/users/balancemymoney/following{/other_user}","gists_url":"https://api.github.com/users/balancemymoney/gists{/gist_id}","starred_url":"https://api.github.com/users/balancemymoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balancemymoney/subscriptions","organizations_url":"https://api.github.com/users/balancemymoney/orgs","repos_url":"https://api.github.com/users/balancemymoney/repos","events_url":"https://api.github.com/users/balancemymoney/events{/privacy}","received_events_url":"https://api.github.com/users/balancemymoney/received_events","type":"Organization","site_admin":false},"repo":{"id":93853878,"name":"balance-open","full_name":"balancemymoney/balance-open","owner":{"login":"balancemymoney","id":19879255,"avatar_url":"https://avatars2.githubusercontent.com/u/19879255?v=4","gravatar_id":"","url":"https://api.github.com/users/balancemymoney","html_url":"https://github.com/balancemymoney","followers_url":"https://api.github.com/users/balancemymoney/followers","following_url":"https://api.github.com/users/balancemymoney/following{/other_user}","gists_url":"https://api.github.com/users/balancemymoney/gists{/gist_id}","starred_url":"https://api.github.com/users/balancemymoney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/balancemymoney/subscriptions","organizations_url":"https://api.github.com/users/balancemymoney/orgs","repos_url":"https://api.github.com/users/balancemymoney/repos","events_url":"https://api.github.com/users/balancemymoney/events{/privacy}","received_events_url":"https://api.github.com/users/balancemymoney/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/balancemymoney/balance-open","description":"Balance Open: A GPL3-licensed macOS menu bar app for all the world’s currencies.","fork":false,"url":"https://api.github.com/repos/balancemymoney/balance-open","forks_url":"https://api.github.com/repos/balancemymoney/balance-open/forks","keys_url":"https://api.github.com/repos/balancemymoney/balance-open/keys{/key_id}","collaborators_url":"https://api.github.com/repos/balancemymoney/balance-open/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/balancemymoney/balance-open/teams","hooks_url":"https://api.github.com/repos/balancemymoney/balance-open/hooks","issue_events_url":"https://api.github.com/repos/balancemymoney/balance-open/issues/events{/number}","events_url":"https://api.github.com/repos/balancemymoney/balance-open/events","assignees_url":"https://api.github.com/repos/balancemymoney/balance-open/assignees{/user}","branches_url":"https://api.github.com/repos/balancemymoney/balance-open/branches{/branch}","tags_url":"https://api.github.com/repos/balancemymoney/balance-open/tags","blobs_url":"https://api.github.com/repos/balancemymoney/balance-open/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/balancemymoney/balance-open/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/balancemymoney/balance-open/git/refs{/sha}","trees_url":"https://api.github.com/repos/balancemymoney/balance-open/git/trees{/sha}","statuses_url":"https://api.github.com/repos/balancemymoney/balance-open/statuses/{sha}","languages_url":"https://api.github.com/repos/balancemymoney/balance-open/languages","stargazers_url":"https://api.github.com/repos/balancemymoney/balance-open/stargazers","contributors_url":"https://api.github.com/repos/balancemymoney/balance-open/contributors","subscribers_url":"https://api.github.com/repos/balancemymoney/balance-open/subscribers","subscription_url":"https://api.github.com/repos/balancemymoney/balance-open/subscription","commits_url":"https://api.github.com/repos/balancemymoney/balance-open/commits{/sha}","git_commits_url":"https://api.github.com/repos/balancemymoney/balance-open/git/commits{/sha}","comments_url":"https://api.github.com/repos/balancemymoney/balance-open/comments{/number}","issue_comment_url":"https://api.github.com/repos/balancemymoney/balance-open/issues/comments{/number}","contents_url":"https://api.github.com/repos/balancemymoney/balance-open/contents/{+path}","compare_url":"https://api.github.com/repos/balancemymoney/balance-open/compare/{base}...{head}","merges_url":"https://api.github.com/repos/balancemymoney/balance-open/merges","archive_url":"https://api.github.com/repos/balancemymoney/balance-open/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/balancemymoney/balance-open/downloads","issues_url":"https://api.github.com/repos/balancemymoney/balance-open/issues{/number}","pulls_url":"https://api.github.com/repos/balancemymoney/balance-open/pulls{/number}","milestones_url":"https://api.github.com/repos/balancemymoney/balance-open/milestones{/number}","notifications_url":"https://api.github.com/repos/balancemymoney/balance-open/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/balancemymoney/balance-open/labels{/name}","releases_url":"https://api.github.com/repos/balancemymoney/balance-open/releases{/id}","deployments_url":"https://api.github.com/repos/balancemymoney/balance-open/deployments","created_at":"2017-06-09T11:50:50Z","updated_at":"2017-11-22T14:45:25Z","pushed_at":"2017-11-28T15:05:52Z","git_url":"git://github.com/balancemymoney/balance-open.git","ssh_url":"git@github.com:balancemymoney/balance-open.git","clone_url":"https://github.com/balancemymoney/balance-open.git","svn_url":"https://github.com/balancemymoney/balance-open","homepage":"https://balancemy.money","size":270175,"stargazers_count":153,"watchers_count":153,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":73,"forks":18,"open_issues":73,"watchers":153,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/balancemymoney/balance-open/pulls/308"},"html":{"href":"https://github.com/balancemymoney/balance-open/pull/308"},"issue":{"href":"https://api.github.com/repos/balancemymoney/balance-open/issues/308"},"comments":{"href":"https://api.github.com/repos/balancemymoney/balance-open/issues/308/comments"},"review_comments":{"href":"https://api.github.com/repos/balancemymoney/balance-open/pulls/308/comments"},"review_comment":{"href":"https://api.github.com/repos/balancemymoney/balance-open/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/balancemymoney/balance-open/pulls/308/commits"},"statuses":{"href":"https://api.github.com/repos/balancemymoney/balance-open/statuses/64756d41eb08641cfb59fba51b2c87fe1cfe03cf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"einsteinx2"}}