{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/158494553","pull_request_review_id":85317309,"id":158494553,"diff_hunk":"@@ -22,14 +23,20 @@\n public class BaseModuleHandler<T extends Module> implements ModuleHandler {\n \n     protected T module;\n+    protected RuleEngine ruleEngine;\n \n     public BaseModuleHandler(T module) {\n         this.module = module;\n     }\n \n+    @Override\n+    public void setRuleEngine(RuleEngine ruleEngine) {","path":"bundles/automation/org.eclipse.smarthome.automation.api/src/main/java/org/eclipse/smarthome/automation/handler/BaseModuleHandler.java","position":19,"original_position":19,"commit_id":"c41e262d83f1239a356f7b5ee6b54690f77bfc74","original_commit_id":"c41e262d83f1239a356f7b5ee6b54690f77bfc74","user":{"login":"kaikreuzer","id":3244965,"avatar_url":"https://avatars3.githubusercontent.com/u/3244965?v=4","gravatar_id":"","url":"https://api.github.com/users/kaikreuzer","html_url":"https://github.com/kaikreuzer","followers_url":"https://api.github.com/users/kaikreuzer/followers","following_url":"https://api.github.com/users/kaikreuzer/following{/other_user}","gists_url":"https://api.github.com/users/kaikreuzer/gists{/gist_id}","starred_url":"https://api.github.com/users/kaikreuzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaikreuzer/subscriptions","organizations_url":"https://api.github.com/users/kaikreuzer/orgs","repos_url":"https://api.github.com/users/kaikreuzer/repos","events_url":"https://api.github.com/users/kaikreuzer/events{/privacy}","received_events_url":"https://api.github.com/users/kaikreuzer/received_events","type":"User","site_admin":false},"body":"You seem to have forgotten that this whole issue is about removing this cyclic dependency.\r\nThe RuleEngine already depends on the handlers (through their factory), so we must not introduce the reverse dependency.\r\nThat's why the handlers get this as a callback. It is the same architecture as it is done in the Thing infrastructure.","created_at":"2017-12-22T13:46:42Z","updated_at":"2017-12-22T13:46:42Z","html_url":"https://github.com/eclipse/smarthome/pull/4468#discussion_r158494553","pull_request_url":"https://api.github.com/repos/eclipse/smarthome/pulls/4468","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments/158494553"},"html":{"href":"https://github.com/eclipse/smarthome/pull/4468#discussion_r158494553"},"pull_request":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/4468"}},"in_reply_to_id":158467562},"pull_request":{"url":"https://api.github.com/repos/eclipse/smarthome/pulls/4468","id":149500287,"html_url":"https://github.com/eclipse/smarthome/pull/4468","diff_url":"https://github.com/eclipse/smarthome/pull/4468.diff","patch_url":"https://github.com/eclipse/smarthome/pull/4468.patch","issue_url":"https://api.github.com/repos/eclipse/smarthome/issues/4468","number":4468,"state":"open","locked":false,"title":"Solves [Automation] circular service reference #3635","user":{"login":"adimova","id":13587297,"avatar_url":"https://avatars2.githubusercontent.com/u/13587297?v=4","gravatar_id":"","url":"https://api.github.com/users/adimova","html_url":"https://github.com/adimova","followers_url":"https://api.github.com/users/adimova/followers","following_url":"https://api.github.com/users/adimova/following{/other_user}","gists_url":"https://api.github.com/users/adimova/gists{/gist_id}","starred_url":"https://api.github.com/users/adimova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adimova/subscriptions","organizations_url":"https://api.github.com/users/adimova/orgs","repos_url":"https://api.github.com/users/adimova/repos","events_url":"https://api.github.com/users/adimova/events{/privacy}","received_events_url":"https://api.github.com/users/adimova/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Ana Dimova <a.dimova@prosyst.bg>\r\n\r\nCloses #3635","created_at":"2017-10-30T11:43:17Z","updated_at":"2017-12-22T13:46:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3477c1db085184f4bdea940ca1b9fff4b6e95dcd","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/smarthome/pulls/4468/commits","review_comments_url":"https://api.github.com/repos/eclipse/smarthome/pulls/4468/comments","review_comment_url":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/smarthome/issues/4468/comments","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/c41e262d83f1239a356f7b5ee6b54690f77bfc74","head":{"label":"adimova:circular_dependencies","ref":"circular_dependencies","sha":"c41e262d83f1239a356f7b5ee6b54690f77bfc74","user":{"login":"adimova","id":13587297,"avatar_url":"https://avatars2.githubusercontent.com/u/13587297?v=4","gravatar_id":"","url":"https://api.github.com/users/adimova","html_url":"https://github.com/adimova","followers_url":"https://api.github.com/users/adimova/followers","following_url":"https://api.github.com/users/adimova/following{/other_user}","gists_url":"https://api.github.com/users/adimova/gists{/gist_id}","starred_url":"https://api.github.com/users/adimova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adimova/subscriptions","organizations_url":"https://api.github.com/users/adimova/orgs","repos_url":"https://api.github.com/users/adimova/repos","events_url":"https://api.github.com/users/adimova/events{/privacy}","received_events_url":"https://api.github.com/users/adimova/received_events","type":"User","site_admin":false},"repo":{"id":40002172,"name":"smarthome","full_name":"adimova/smarthome","owner":{"login":"adimova","id":13587297,"avatar_url":"https://avatars2.githubusercontent.com/u/13587297?v=4","gravatar_id":"","url":"https://api.github.com/users/adimova","html_url":"https://github.com/adimova","followers_url":"https://api.github.com/users/adimova/followers","following_url":"https://api.github.com/users/adimova/following{/other_user}","gists_url":"https://api.github.com/users/adimova/gists{/gist_id}","starred_url":"https://api.github.com/users/adimova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adimova/subscriptions","organizations_url":"https://api.github.com/users/adimova/orgs","repos_url":"https://api.github.com/users/adimova/repos","events_url":"https://api.github.com/users/adimova/events{/privacy}","received_events_url":"https://api.github.com/users/adimova/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adimova/smarthome","description":"Eclipse SmartHome project","fork":true,"url":"https://api.github.com/repos/adimova/smarthome","forks_url":"https://api.github.com/repos/adimova/smarthome/forks","keys_url":"https://api.github.com/repos/adimova/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adimova/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adimova/smarthome/teams","hooks_url":"https://api.github.com/repos/adimova/smarthome/hooks","issue_events_url":"https://api.github.com/repos/adimova/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/adimova/smarthome/events","assignees_url":"https://api.github.com/repos/adimova/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/adimova/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/adimova/smarthome/tags","blobs_url":"https://api.github.com/repos/adimova/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adimova/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adimova/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/adimova/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adimova/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/adimova/smarthome/languages","stargazers_url":"https://api.github.com/repos/adimova/smarthome/stargazers","contributors_url":"https://api.github.com/repos/adimova/smarthome/contributors","subscribers_url":"https://api.github.com/repos/adimova/smarthome/subscribers","subscription_url":"https://api.github.com/repos/adimova/smarthome/subscription","commits_url":"https://api.github.com/repos/adimova/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/adimova/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/adimova/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/adimova/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/adimova/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/adimova/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adimova/smarthome/merges","archive_url":"https://api.github.com/repos/adimova/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adimova/smarthome/downloads","issues_url":"https://api.github.com/repos/adimova/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/adimova/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/adimova/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/adimova/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adimova/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/adimova/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/adimova/smarthome/deployments","created_at":"2015-07-31T11:25:46Z","updated_at":"2016-02-04T09:51:59Z","pushed_at":"2017-12-21T13:51:53Z","git_url":"git://github.com/adimova/smarthome.git","ssh_url":"git@github.com:adimova/smarthome.git","clone_url":"https://github.com/adimova/smarthome.git","svn_url":"https://github.com/adimova/smarthome","homepage":null,"size":33413,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"28499f3674d85e608089e7f6f57d49261aa83441","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":15778981,"name":"smarthome","full_name":"eclipse/smarthome","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/smarthome","description":"Eclipse SmartHome™ project","fork":false,"url":"https://api.github.com/repos/eclipse/smarthome","forks_url":"https://api.github.com/repos/eclipse/smarthome/forks","keys_url":"https://api.github.com/repos/eclipse/smarthome/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/smarthome/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/smarthome/teams","hooks_url":"https://api.github.com/repos/eclipse/smarthome/hooks","issue_events_url":"https://api.github.com/repos/eclipse/smarthome/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/smarthome/events","assignees_url":"https://api.github.com/repos/eclipse/smarthome/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/smarthome/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/smarthome/tags","blobs_url":"https://api.github.com/repos/eclipse/smarthome/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/smarthome/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/smarthome/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/smarthome/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/smarthome/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/smarthome/languages","stargazers_url":"https://api.github.com/repos/eclipse/smarthome/stargazers","contributors_url":"https://api.github.com/repos/eclipse/smarthome/contributors","subscribers_url":"https://api.github.com/repos/eclipse/smarthome/subscribers","subscription_url":"https://api.github.com/repos/eclipse/smarthome/subscription","commits_url":"https://api.github.com/repos/eclipse/smarthome/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/smarthome/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/smarthome/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/smarthome/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/smarthome/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/smarthome/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/smarthome/merges","archive_url":"https://api.github.com/repos/eclipse/smarthome/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/smarthome/downloads","issues_url":"https://api.github.com/repos/eclipse/smarthome/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/smarthome/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/smarthome/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/smarthome/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/smarthome/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/smarthome/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/smarthome/deployments","created_at":"2014-01-09T20:47:19Z","updated_at":"2017-12-19T18:36:28Z","pushed_at":"2017-12-22T12:46:40Z","git_url":"git://github.com/eclipse/smarthome.git","ssh_url":"git@github.com:eclipse/smarthome.git","clone_url":"https://github.com/eclipse/smarthome.git","svn_url":"https://github.com/eclipse/smarthome","homepage":"https://www.eclipse.org/smarthome/","size":41369,"stargazers_count":605,"watchers_count":605,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":605,"mirror_url":null,"archived":false,"open_issues_count":378,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":605,"open_issues":378,"watchers":605,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/4468"},"html":{"href":"https://github.com/eclipse/smarthome/pull/4468"},"issue":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/4468"},"comments":{"href":"https://api.github.com/repos/eclipse/smarthome/issues/4468/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/4468/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/smarthome/pulls/4468/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/smarthome/statuses/c41e262d83f1239a356f7b5ee6b54690f77bfc74"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kaikreuzer"}}