{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/16467","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/16467/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/16467/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/16467/events","html_url":"https://github.com/cockroachdb/cockroach/pull/16467","id":235289893,"number":16467,"title":"sql: more RowFetcher optimizations","user":{"login":"RaduBerinde","id":16544120,"avatar_url":"https://avatars2.githubusercontent.com/u/16544120?v=3","gravatar_id":"","url":"https://api.github.com/users/RaduBerinde","html_url":"https://github.com/RaduBerinde","followers_url":"https://api.github.com/users/RaduBerinde/followers","following_url":"https://api.github.com/users/RaduBerinde/following{/other_user}","gists_url":"https://api.github.com/users/RaduBerinde/gists{/gist_id}","starred_url":"https://api.github.com/users/RaduBerinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RaduBerinde/subscriptions","organizations_url":"https://api.github.com/users/RaduBerinde/orgs","repos_url":"https://api.github.com/users/RaduBerinde/repos","events_url":"https://api.github.com/users/RaduBerinde/events{/privacy}","received_events_url":"https://api.github.com/users/RaduBerinde/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-06-12T16:29:23Z","updated_at":"2017-06-12T16:29:29Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/16467","html_url":"https://github.com/cockroachdb/cockroach/pull/16467","diff_url":"https://github.com/cockroachdb/cockroach/pull/16467.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/16467.patch"},"body":"### sql: don't set composite columns as needed in row fetcher\r\nWe don't need to fully decode all key columns if they are not needed.\r\n\r\n### sql: remove unsetCols map\r\nRemoving the `unsetCols` map which is only used to avoid an assertion in\r\n`processValueSingle` (the corresponding `processValueTuple` doesn't have this\r\nassertion). Creating this map was about 3.7% in a profile of a large scan where\r\nwe don't need column values.\r\n\r\n### sql: avoid KV decoding altogether if no values are required\r\nSpecial optimization when no columns are needed in the row fetcher. This is only\r\nuseful for `COUNT(*)` but the speedup for that is significant (20%)."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/307842974","html_url":"https://github.com/cockroachdb/cockroach/pull/16467#issuecomment-307842974","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/16467","id":307842974,"user":{"login":"cockroach-teamcity","id":20559710,"avatar_url":"https://avatars3.githubusercontent.com/u/20559710?v=3","gravatar_id":"","url":"https://api.github.com/users/cockroach-teamcity","html_url":"https://github.com/cockroach-teamcity","followers_url":"https://api.github.com/users/cockroach-teamcity/followers","following_url":"https://api.github.com/users/cockroach-teamcity/following{/other_user}","gists_url":"https://api.github.com/users/cockroach-teamcity/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroach-teamcity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroach-teamcity/subscriptions","organizations_url":"https://api.github.com/users/cockroach-teamcity/orgs","repos_url":"https://api.github.com/users/cockroach-teamcity/repos","events_url":"https://api.github.com/users/cockroach-teamcity/events{/privacy}","received_events_url":"https://api.github.com/users/cockroach-teamcity/received_events","type":"User","site_admin":false},"created_at":"2017-06-12T16:29:29Z","updated_at":"2017-06-12T16:29:29Z","body":"\n\n<!-- Reviewable:start -->\nThis change is [<img src=\"https://reviewable.io/review_button.png\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/cockroachdb/cockroach/16467)\n<!-- Reviewable:end -->\n"}}
{"actor":{"display_login":"cockroach-teamcity"}}