{"action":"created","issue":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2175","repository_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel","labels_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2175/labels{/name}","comments_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2175/comments","events_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2175/events","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2175","id":278826292,"number":2175,"title":"[WiP] EZP-28337: As a Developer I want API Field Type properties to use consistent naming","user":{"login":"alongosz","id":7099219,"avatar_url":"https://avatars1.githubusercontent.com/u/7099219?v=4","gravatar_id":"","url":"https://api.github.com/users/alongosz","html_url":"https://github.com/alongosz","followers_url":"https://api.github.com/users/alongosz/followers","following_url":"https://api.github.com/users/alongosz/following{/other_user}","gists_url":"https://api.github.com/users/alongosz/gists{/gist_id}","starred_url":"https://api.github.com/users/alongosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alongosz/subscriptions","organizations_url":"https://api.github.com/users/alongosz/orgs","repos_url":"https://api.github.com/users/alongosz/repos","events_url":"https://api.github.com/users/alongosz/events{/privacy}","received_events_url":"https://api.github.com/users/alongosz/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-03T22:14:46Z","updated_at":"2017-12-05T10:57:39Z","closed_at":"2017-12-05T10:57:39Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/pulls/2175","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2175","diff_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2175.diff","patch_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2175.patch"},"body":"# PAPI FieldDefinition typeIdentifier property\r\n| Question | Answer |\r\n| --- | --- |\r\n| **Status** | Work in progress |\r\n| **JIRA issue** | [EZP-28337](https://jira.ez.no/browse/EZP-28337) |\r\n| **Related to** | #2168 |\r\n| **BC break**   | no, old property is still available via magic method and accessor |\r\n| **Type** | Improvement |\r\n| **Target version** | `6.x` |\r\n\r\nThis PR aligns `FieldDefinition::$fieldTypeIdentifier` property naming with changes introduced in #2168 by adding `FieldDefinition::$typeIdentifier` property in favor over the former one.\r\n\r\nTo keep BC `FieldDefinition::$fieldTypeIdentifier` is deprecated, with `E_USER_DEPRECATED` triggered when `FieldDefinition` is constructed using that property name and when this property is requested.\r\n\r\n**TODO**:\r\n- [x] Introduce `FieldDefinition::$typeIdentifier` property.\r\n- [x] Deprecate `FieldDefinition::$fieldTypeIdentifier` property.\r\n- [x] Trigger deprecation notice when accessing old property, without a BC break. [1]\r\n- [ ] Replace usages of deprecated property in this package code.\r\n- [ ] Send to QA (requires testing if it's possible to create content type and content).\r\n\r\n*[1] I discovered that Twig extension rendering depends on properties being explicitly defined. To workaround it, `getFieldTypeIdentifier` has been introduced which is used by Twig if property does not exist. In other cases `__get` should be enough.*"},"comment":{"url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/comments/349269665","html_url":"https://github.com/ezsystems/ezpublish-kernel/pull/2175#issuecomment-349269665","issue_url":"https://api.github.com/repos/ezsystems/ezpublish-kernel/issues/2175","id":349269665,"user":{"login":"alongosz","id":7099219,"avatar_url":"https://avatars1.githubusercontent.com/u/7099219?v=4","gravatar_id":"","url":"https://api.github.com/users/alongosz","html_url":"https://github.com/alongosz","followers_url":"https://api.github.com/users/alongosz/followers","following_url":"https://api.github.com/users/alongosz/following{/other_user}","gists_url":"https://api.github.com/users/alongosz/gists{/gist_id}","starred_url":"https://api.github.com/users/alongosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alongosz/subscriptions","organizations_url":"https://api.github.com/users/alongosz/orgs","repos_url":"https://api.github.com/users/alongosz/repos","events_url":"https://api.github.com/users/alongosz/events{/privacy}","received_events_url":"https://api.github.com/users/alongosz/received_events","type":"User","site_admin":false},"created_at":"2017-12-05T10:57:39Z","updated_at":"2017-12-05T10:57:39Z","author_association":"MEMBER","body":"Closing in favor of #2176"}}
{"actor":{"display_login":"alongosz"}}