{"action":"opened","number":540,"pull_request":{"url":"https://api.github.com/repos/jbeder/yaml-cpp/pulls/540","id":151740479,"html_url":"https://github.com/jbeder/yaml-cpp/pull/540","diff_url":"https://github.com/jbeder/yaml-cpp/pull/540.diff","patch_url":"https://github.com/jbeder/yaml-cpp/pull/540.patch","issue_url":"https://api.github.com/repos/jbeder/yaml-cpp/issues/540","number":540,"state":"open","locked":false,"title":"Fix some problems related to virtual methods","user":{"login":"mwoehlke-kitware","id":6474409,"avatar_url":"https://avatars3.githubusercontent.com/u/6474409?v=4","gravatar_id":"","url":"https://api.github.com/users/mwoehlke-kitware","html_url":"https://github.com/mwoehlke-kitware","followers_url":"https://api.github.com/users/mwoehlke-kitware/followers","following_url":"https://api.github.com/users/mwoehlke-kitware/following{/other_user}","gists_url":"https://api.github.com/users/mwoehlke-kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/mwoehlke-kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwoehlke-kitware/subscriptions","organizations_url":"https://api.github.com/users/mwoehlke-kitware/orgs","repos_url":"https://api.github.com/users/mwoehlke-kitware/repos","events_url":"https://api.github.com/users/mwoehlke-kitware/events{/privacy}","received_events_url":"https://api.github.com/users/mwoehlke-kitware/received_events","type":"User","site_admin":false},"body":"Fix two issues related to virtual methods:\r\n\r\n- `GraphBuilderInterface` had a non-virtual destructor, which tripped a `-Wnon-virtual-dtor` warning, and is potentially dangerous as deleting an instance (necessarily a derived type, as `GraphBuilderInterface` is abstract) via a pointer to the base type would invoke the wrong destructor. Add an explicit (abstract) virtual destructor to fix this.\r\n- A pair of methods  in `NullEventHandler` were shadowing base methods, tripping a `-Woverloaded-virtual` warning. It appears that these were intended to overload the base methods instead (especially as said methods are pure virtual), but did not, due to a mismatch of parameters. Correct the mismatch, and also add `override` keywords to prevent these going out of sync in the future.","created_at":"2017-11-09T19:25:01Z","updated_at":"2017-11-09T19:25:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/jbeder/yaml-cpp/pulls/540/commits","review_comments_url":"https://api.github.com/repos/jbeder/yaml-cpp/pulls/540/comments","review_comment_url":"https://api.github.com/repos/jbeder/yaml-cpp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jbeder/yaml-cpp/issues/540/comments","statuses_url":"https://api.github.com/repos/jbeder/yaml-cpp/statuses/e838a33e150833ea6ad5e12f420a328e8eb80edc","head":{"label":"mwoehlke-kitware:virtual-fixes","ref":"virtual-fixes","sha":"e838a33e150833ea6ad5e12f420a328e8eb80edc","user":{"login":"mwoehlke-kitware","id":6474409,"avatar_url":"https://avatars3.githubusercontent.com/u/6474409?v=4","gravatar_id":"","url":"https://api.github.com/users/mwoehlke-kitware","html_url":"https://github.com/mwoehlke-kitware","followers_url":"https://api.github.com/users/mwoehlke-kitware/followers","following_url":"https://api.github.com/users/mwoehlke-kitware/following{/other_user}","gists_url":"https://api.github.com/users/mwoehlke-kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/mwoehlke-kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwoehlke-kitware/subscriptions","organizations_url":"https://api.github.com/users/mwoehlke-kitware/orgs","repos_url":"https://api.github.com/users/mwoehlke-kitware/repos","events_url":"https://api.github.com/users/mwoehlke-kitware/events{/privacy}","received_events_url":"https://api.github.com/users/mwoehlke-kitware/received_events","type":"User","site_admin":false},"repo":{"id":110152471,"name":"yaml-cpp","full_name":"mwoehlke-kitware/yaml-cpp","owner":{"login":"mwoehlke-kitware","id":6474409,"avatar_url":"https://avatars3.githubusercontent.com/u/6474409?v=4","gravatar_id":"","url":"https://api.github.com/users/mwoehlke-kitware","html_url":"https://github.com/mwoehlke-kitware","followers_url":"https://api.github.com/users/mwoehlke-kitware/followers","following_url":"https://api.github.com/users/mwoehlke-kitware/following{/other_user}","gists_url":"https://api.github.com/users/mwoehlke-kitware/gists{/gist_id}","starred_url":"https://api.github.com/users/mwoehlke-kitware/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwoehlke-kitware/subscriptions","organizations_url":"https://api.github.com/users/mwoehlke-kitware/orgs","repos_url":"https://api.github.com/users/mwoehlke-kitware/repos","events_url":"https://api.github.com/users/mwoehlke-kitware/events{/privacy}","received_events_url":"https://api.github.com/users/mwoehlke-kitware/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mwoehlke-kitware/yaml-cpp","description":"A YAML parser and emitter in C++","fork":true,"url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp","forks_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/forks","keys_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/teams","hooks_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/hooks","issue_events_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/events","assignees_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/tags","blobs_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/languages","stargazers_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/stargazers","contributors_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/contributors","subscribers_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/subscribers","subscription_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/subscription","commits_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/merges","archive_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/downloads","issues_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/labels{/name}","releases_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/mwoehlke-kitware/yaml-cpp/deployments","created_at":"2017-11-09T18:38:05Z","updated_at":"2017-11-09T18:38:08Z","pushed_at":"2017-11-09T19:20:19Z","git_url":"git://github.com/mwoehlke-kitware/yaml-cpp.git","ssh_url":"git@github.com:mwoehlke-kitware/yaml-cpp.git","clone_url":"https://github.com/mwoehlke-kitware/yaml-cpp.git","svn_url":"https://github.com/mwoehlke-kitware/yaml-cpp","homepage":"","size":3035,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jbeder:master","ref":"master","sha":"46dcdc3ea2c19f60d0557569d3c24dffdf712781","user":{"login":"jbeder","id":1059334,"avatar_url":"https://avatars0.githubusercontent.com/u/1059334?v=4","gravatar_id":"","url":"https://api.github.com/users/jbeder","html_url":"https://github.com/jbeder","followers_url":"https://api.github.com/users/jbeder/followers","following_url":"https://api.github.com/users/jbeder/following{/other_user}","gists_url":"https://api.github.com/users/jbeder/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeder/subscriptions","organizations_url":"https://api.github.com/users/jbeder/orgs","repos_url":"https://api.github.com/users/jbeder/repos","events_url":"https://api.github.com/users/jbeder/events{/privacy}","received_events_url":"https://api.github.com/users/jbeder/received_events","type":"User","site_admin":false},"repo":{"id":33100064,"name":"yaml-cpp","full_name":"jbeder/yaml-cpp","owner":{"login":"jbeder","id":1059334,"avatar_url":"https://avatars0.githubusercontent.com/u/1059334?v=4","gravatar_id":"","url":"https://api.github.com/users/jbeder","html_url":"https://github.com/jbeder","followers_url":"https://api.github.com/users/jbeder/followers","following_url":"https://api.github.com/users/jbeder/following{/other_user}","gists_url":"https://api.github.com/users/jbeder/gists{/gist_id}","starred_url":"https://api.github.com/users/jbeder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jbeder/subscriptions","organizations_url":"https://api.github.com/users/jbeder/orgs","repos_url":"https://api.github.com/users/jbeder/repos","events_url":"https://api.github.com/users/jbeder/events{/privacy}","received_events_url":"https://api.github.com/users/jbeder/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jbeder/yaml-cpp","description":"A YAML parser and emitter in C++","fork":false,"url":"https://api.github.com/repos/jbeder/yaml-cpp","forks_url":"https://api.github.com/repos/jbeder/yaml-cpp/forks","keys_url":"https://api.github.com/repos/jbeder/yaml-cpp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jbeder/yaml-cpp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jbeder/yaml-cpp/teams","hooks_url":"https://api.github.com/repos/jbeder/yaml-cpp/hooks","issue_events_url":"https://api.github.com/repos/jbeder/yaml-cpp/issues/events{/number}","events_url":"https://api.github.com/repos/jbeder/yaml-cpp/events","assignees_url":"https://api.github.com/repos/jbeder/yaml-cpp/assignees{/user}","branches_url":"https://api.github.com/repos/jbeder/yaml-cpp/branches{/branch}","tags_url":"https://api.github.com/repos/jbeder/yaml-cpp/tags","blobs_url":"https://api.github.com/repos/jbeder/yaml-cpp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jbeder/yaml-cpp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jbeder/yaml-cpp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jbeder/yaml-cpp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jbeder/yaml-cpp/statuses/{sha}","languages_url":"https://api.github.com/repos/jbeder/yaml-cpp/languages","stargazers_url":"https://api.github.com/repos/jbeder/yaml-cpp/stargazers","contributors_url":"https://api.github.com/repos/jbeder/yaml-cpp/contributors","subscribers_url":"https://api.github.com/repos/jbeder/yaml-cpp/subscribers","subscription_url":"https://api.github.com/repos/jbeder/yaml-cpp/subscription","commits_url":"https://api.github.com/repos/jbeder/yaml-cpp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jbeder/yaml-cpp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jbeder/yaml-cpp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jbeder/yaml-cpp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jbeder/yaml-cpp/contents/{+path}","compare_url":"https://api.github.com/repos/jbeder/yaml-cpp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jbeder/yaml-cpp/merges","archive_url":"https://api.github.com/repos/jbeder/yaml-cpp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jbeder/yaml-cpp/downloads","issues_url":"https://api.github.com/repos/jbeder/yaml-cpp/issues{/number}","pulls_url":"https://api.github.com/repos/jbeder/yaml-cpp/pulls{/number}","milestones_url":"https://api.github.com/repos/jbeder/yaml-cpp/milestones{/number}","notifications_url":"https://api.github.com/repos/jbeder/yaml-cpp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jbeder/yaml-cpp/labels{/name}","releases_url":"https://api.github.com/repos/jbeder/yaml-cpp/releases{/id}","deployments_url":"https://api.github.com/repos/jbeder/yaml-cpp/deployments","created_at":"2015-03-30T02:52:32Z","updated_at":"2017-11-09T19:06:30Z","pushed_at":"2017-11-09T18:53:09Z","git_url":"git://github.com/jbeder/yaml-cpp.git","ssh_url":"git@github.com:jbeder/yaml-cpp.git","clone_url":"https://github.com/jbeder/yaml-cpp.git","svn_url":"https://github.com/jbeder/yaml-cpp","homepage":"","size":3035,"stargazers_count":791,"watchers_count":791,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":274,"mirror_url":null,"archived":false,"open_issues_count":158,"forks":274,"open_issues":158,"watchers":791,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jbeder/yaml-cpp/pulls/540"},"html":{"href":"https://github.com/jbeder/yaml-cpp/pull/540"},"issue":{"href":"https://api.github.com/repos/jbeder/yaml-cpp/issues/540"},"comments":{"href":"https://api.github.com/repos/jbeder/yaml-cpp/issues/540/comments"},"review_comments":{"href":"https://api.github.com/repos/jbeder/yaml-cpp/pulls/540/comments"},"review_comment":{"href":"https://api.github.com/repos/jbeder/yaml-cpp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jbeder/yaml-cpp/pulls/540/commits"},"statuses":{"href":"https://api.github.com/repos/jbeder/yaml-cpp/statuses/e838a33e150833ea6ad5e12f420a328e8eb80edc"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":13,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"mwoehlke-kitware"}}