{"action":"created","comment":{"url":"https://api.github.com/repos/redis/redis-rb/pulls/comments/135618982","pull_request_review_id":59051026,"id":135618982,"diff_hunk":"@@ -286,7 +286,10 @@ def self.connect(host, port, timeout, ssl_params)\n           ssl_sock = new(tcp_sock, ctx)\n           ssl_sock.hostname = host\n           ssl_sock.connect\n-          ssl_sock.post_connection_check(host)\n+\n+          unless ssl_params.has_key?(:verify_hostname) && ssl_params[:verify_hostname] == false","path":"lib/redis/connection/ruby.rb","position":6,"original_position":6,"commit_id":"e5f8ec25e269d074d4323ed5ac23ab612ac422e5","original_commit_id":"e5f8ec25e269d074d4323ed5ac23ab612ac422e5","user":{"login":"olleolleolle","id":211,"avatar_url":"https://avatars0.githubusercontent.com/u/211?v=4","gravatar_id":"","url":"https://api.github.com/users/olleolleolle","html_url":"https://github.com/olleolleolle","followers_url":"https://api.github.com/users/olleolleolle/followers","following_url":"https://api.github.com/users/olleolleolle/following{/other_user}","gists_url":"https://api.github.com/users/olleolleolle/gists{/gist_id}","starred_url":"https://api.github.com/users/olleolleolle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/olleolleolle/subscriptions","organizations_url":"https://api.github.com/users/olleolleolle/orgs","repos_url":"https://api.github.com/users/olleolleolle/repos","events_url":"https://api.github.com/users/olleolleolle/events{/privacy}","received_events_url":"https://api.github.com/users/olleolleolle/received_events","type":"User","site_admin":false},"body":"The last half of the check is benign, and the first part (`ssl_params.has_key?(:verify_hostname)`) _could_ be left out.\r\n\r\nExample:\r\n\r\n```\r\nirb(main):009:0> ssl_params = { }\r\n{}\r\nirb(main):010:0> ssl_params[:verify_hostname] == false\r\nfalse #   which is the value we are after\r\n```\r\n","created_at":"2017-08-28T20:01:38Z","updated_at":"2017-08-28T20:01:38Z","html_url":"https://github.com/redis/redis-rb/pull/690#discussion_r135618982","pull_request_url":"https://api.github.com/repos/redis/redis-rb/pulls/690","_links":{"self":{"href":"https://api.github.com/repos/redis/redis-rb/pulls/comments/135618982"},"html":{"href":"https://github.com/redis/redis-rb/pull/690#discussion_r135618982"},"pull_request":{"href":"https://api.github.com/repos/redis/redis-rb/pulls/690"}}},"pull_request":{"url":"https://api.github.com/repos/redis/redis-rb/pulls/690","id":118272291,"html_url":"https://github.com/redis/redis-rb/pull/690","diff_url":"https://github.com/redis/redis-rb/pull/690.diff","patch_url":"https://github.com/redis/redis-rb/pull/690.patch","issue_url":"https://api.github.com/repos/redis/redis-rb/issues/690","number":690,"state":"open","locked":false,"title":"Allow hostname checks to be disabled","user":{"login":"mattheworiordan","id":43789,"avatar_url":"https://avatars3.githubusercontent.com/u/43789?v=4","gravatar_id":"","url":"https://api.github.com/users/mattheworiordan","html_url":"https://github.com/mattheworiordan","followers_url":"https://api.github.com/users/mattheworiordan/followers","following_url":"https://api.github.com/users/mattheworiordan/following{/other_user}","gists_url":"https://api.github.com/users/mattheworiordan/gists{/gist_id}","starred_url":"https://api.github.com/users/mattheworiordan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattheworiordan/subscriptions","organizations_url":"https://api.github.com/users/mattheworiordan/orgs","repos_url":"https://api.github.com/users/mattheworiordan/repos","events_url":"https://api.github.com/users/mattheworiordan/events{/privacy}","received_events_url":"https://api.github.com/users/mattheworiordan/received_events","type":"User","site_admin":false},"body":"When using mutual certificate authentication, it is often unnecessary (and a blocker) to have the certificate match the host domain. The security model is provided with the client certificates.\r\n\r\n`verify_hostname` is firstly a valid option of [SSLContext](https://docs.ruby-lang.org/en/2.4.0/OpenSSL/SSL/SSLContext.html#method-i-set_params), so this option and intention should be carried through in this client when using TLS certificate authentication.","created_at":"2017-04-29T11:50:30Z","updated_at":"2017-08-28T20:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0b6eab0f4f01ddde98b33adaf3ef8868314476fb","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/redis/redis-rb/pulls/690/commits","review_comments_url":"https://api.github.com/repos/redis/redis-rb/pulls/690/comments","review_comment_url":"https://api.github.com/repos/redis/redis-rb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redis/redis-rb/issues/690/comments","statuses_url":"https://api.github.com/repos/redis/redis-rb/statuses/e5f8ec25e269d074d4323ed5ac23ab612ac422e5","head":{"label":"ably-forks:allow-verify-hostname-to-be-disabled","ref":"allow-verify-hostname-to-be-disabled","sha":"e5f8ec25e269d074d4323ed5ac23ab612ac422e5","user":{"login":"ably-forks","id":2515232,"avatar_url":"https://avatars2.githubusercontent.com/u/2515232?v=4","gravatar_id":"","url":"https://api.github.com/users/ably-forks","html_url":"https://github.com/ably-forks","followers_url":"https://api.github.com/users/ably-forks/followers","following_url":"https://api.github.com/users/ably-forks/following{/other_user}","gists_url":"https://api.github.com/users/ably-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/ably-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably-forks/subscriptions","organizations_url":"https://api.github.com/users/ably-forks/orgs","repos_url":"https://api.github.com/users/ably-forks/repos","events_url":"https://api.github.com/users/ably-forks/events{/privacy}","received_events_url":"https://api.github.com/users/ably-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":89781362,"name":"redis-rb","full_name":"ably-forks/redis-rb","owner":{"login":"ably-forks","id":2515232,"avatar_url":"https://avatars2.githubusercontent.com/u/2515232?v=4","gravatar_id":"","url":"https://api.github.com/users/ably-forks","html_url":"https://github.com/ably-forks","followers_url":"https://api.github.com/users/ably-forks/followers","following_url":"https://api.github.com/users/ably-forks/following{/other_user}","gists_url":"https://api.github.com/users/ably-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/ably-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ably-forks/subscriptions","organizations_url":"https://api.github.com/users/ably-forks/orgs","repos_url":"https://api.github.com/users/ably-forks/repos","events_url":"https://api.github.com/users/ably-forks/events{/privacy}","received_events_url":"https://api.github.com/users/ably-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ably-forks/redis-rb","description":"A Ruby client library for Redis","fork":true,"url":"https://api.github.com/repos/ably-forks/redis-rb","forks_url":"https://api.github.com/repos/ably-forks/redis-rb/forks","keys_url":"https://api.github.com/repos/ably-forks/redis-rb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ably-forks/redis-rb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ably-forks/redis-rb/teams","hooks_url":"https://api.github.com/repos/ably-forks/redis-rb/hooks","issue_events_url":"https://api.github.com/repos/ably-forks/redis-rb/issues/events{/number}","events_url":"https://api.github.com/repos/ably-forks/redis-rb/events","assignees_url":"https://api.github.com/repos/ably-forks/redis-rb/assignees{/user}","branches_url":"https://api.github.com/repos/ably-forks/redis-rb/branches{/branch}","tags_url":"https://api.github.com/repos/ably-forks/redis-rb/tags","blobs_url":"https://api.github.com/repos/ably-forks/redis-rb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ably-forks/redis-rb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ably-forks/redis-rb/git/refs{/sha}","trees_url":"https://api.github.com/repos/ably-forks/redis-rb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ably-forks/redis-rb/statuses/{sha}","languages_url":"https://api.github.com/repos/ably-forks/redis-rb/languages","stargazers_url":"https://api.github.com/repos/ably-forks/redis-rb/stargazers","contributors_url":"https://api.github.com/repos/ably-forks/redis-rb/contributors","subscribers_url":"https://api.github.com/repos/ably-forks/redis-rb/subscribers","subscription_url":"https://api.github.com/repos/ably-forks/redis-rb/subscription","commits_url":"https://api.github.com/repos/ably-forks/redis-rb/commits{/sha}","git_commits_url":"https://api.github.com/repos/ably-forks/redis-rb/git/commits{/sha}","comments_url":"https://api.github.com/repos/ably-forks/redis-rb/comments{/number}","issue_comment_url":"https://api.github.com/repos/ably-forks/redis-rb/issues/comments{/number}","contents_url":"https://api.github.com/repos/ably-forks/redis-rb/contents/{+path}","compare_url":"https://api.github.com/repos/ably-forks/redis-rb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ably-forks/redis-rb/merges","archive_url":"https://api.github.com/repos/ably-forks/redis-rb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ably-forks/redis-rb/downloads","issues_url":"https://api.github.com/repos/ably-forks/redis-rb/issues{/number}","pulls_url":"https://api.github.com/repos/ably-forks/redis-rb/pulls{/number}","milestones_url":"https://api.github.com/repos/ably-forks/redis-rb/milestones{/number}","notifications_url":"https://api.github.com/repos/ably-forks/redis-rb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ably-forks/redis-rb/labels{/name}","releases_url":"https://api.github.com/repos/ably-forks/redis-rb/releases{/id}","deployments_url":"https://api.github.com/repos/ably-forks/redis-rb/deployments","created_at":"2017-04-29T11:31:00Z","updated_at":"2017-04-29T11:31:02Z","pushed_at":"2017-04-29T11:44:09Z","git_url":"git://github.com/ably-forks/redis-rb.git","ssh_url":"git@github.com:ably-forks/redis-rb.git","clone_url":"https://github.com/ably-forks/redis-rb.git","svn_url":"https://github.com/ably-forks/redis-rb","homepage":"","size":1549,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"redis:master","ref":"master","sha":"71efca9f8a40b1defd51b35890c6837e5d6032dd","user":{"login":"redis","id":1529926,"avatar_url":"https://avatars2.githubusercontent.com/u/1529926?v=4","gravatar_id":"","url":"https://api.github.com/users/redis","html_url":"https://github.com/redis","followers_url":"https://api.github.com/users/redis/followers","following_url":"https://api.github.com/users/redis/following{/other_user}","gists_url":"https://api.github.com/users/redis/gists{/gist_id}","starred_url":"https://api.github.com/users/redis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redis/subscriptions","organizations_url":"https://api.github.com/users/redis/orgs","repos_url":"https://api.github.com/users/redis/repos","events_url":"https://api.github.com/users/redis/events{/privacy}","received_events_url":"https://api.github.com/users/redis/received_events","type":"Organization","site_admin":false},"repo":{"id":137805,"name":"redis-rb","full_name":"redis/redis-rb","owner":{"login":"redis","id":1529926,"avatar_url":"https://avatars2.githubusercontent.com/u/1529926?v=4","gravatar_id":"","url":"https://api.github.com/users/redis","html_url":"https://github.com/redis","followers_url":"https://api.github.com/users/redis/followers","following_url":"https://api.github.com/users/redis/following{/other_user}","gists_url":"https://api.github.com/users/redis/gists{/gist_id}","starred_url":"https://api.github.com/users/redis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redis/subscriptions","organizations_url":"https://api.github.com/users/redis/orgs","repos_url":"https://api.github.com/users/redis/repos","events_url":"https://api.github.com/users/redis/events{/privacy}","received_events_url":"https://api.github.com/users/redis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/redis/redis-rb","description":"A Ruby client library for Redis","fork":false,"url":"https://api.github.com/repos/redis/redis-rb","forks_url":"https://api.github.com/repos/redis/redis-rb/forks","keys_url":"https://api.github.com/repos/redis/redis-rb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redis/redis-rb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redis/redis-rb/teams","hooks_url":"https://api.github.com/repos/redis/redis-rb/hooks","issue_events_url":"https://api.github.com/repos/redis/redis-rb/issues/events{/number}","events_url":"https://api.github.com/repos/redis/redis-rb/events","assignees_url":"https://api.github.com/repos/redis/redis-rb/assignees{/user}","branches_url":"https://api.github.com/repos/redis/redis-rb/branches{/branch}","tags_url":"https://api.github.com/repos/redis/redis-rb/tags","blobs_url":"https://api.github.com/repos/redis/redis-rb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redis/redis-rb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redis/redis-rb/git/refs{/sha}","trees_url":"https://api.github.com/repos/redis/redis-rb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redis/redis-rb/statuses/{sha}","languages_url":"https://api.github.com/repos/redis/redis-rb/languages","stargazers_url":"https://api.github.com/repos/redis/redis-rb/stargazers","contributors_url":"https://api.github.com/repos/redis/redis-rb/contributors","subscribers_url":"https://api.github.com/repos/redis/redis-rb/subscribers","subscription_url":"https://api.github.com/repos/redis/redis-rb/subscription","commits_url":"https://api.github.com/repos/redis/redis-rb/commits{/sha}","git_commits_url":"https://api.github.com/repos/redis/redis-rb/git/commits{/sha}","comments_url":"https://api.github.com/repos/redis/redis-rb/comments{/number}","issue_comment_url":"https://api.github.com/repos/redis/redis-rb/issues/comments{/number}","contents_url":"https://api.github.com/repos/redis/redis-rb/contents/{+path}","compare_url":"https://api.github.com/repos/redis/redis-rb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redis/redis-rb/merges","archive_url":"https://api.github.com/repos/redis/redis-rb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redis/redis-rb/downloads","issues_url":"https://api.github.com/repos/redis/redis-rb/issues{/number}","pulls_url":"https://api.github.com/repos/redis/redis-rb/pulls{/number}","milestones_url":"https://api.github.com/repos/redis/redis-rb/milestones{/number}","notifications_url":"https://api.github.com/repos/redis/redis-rb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redis/redis-rb/labels{/name}","releases_url":"https://api.github.com/repos/redis/redis-rb/releases{/id}","deployments_url":"https://api.github.com/repos/redis/redis-rb/deployments","created_at":"2009-02-26T00:53:51Z","updated_at":"2017-08-28T06:12:40Z","pushed_at":"2017-08-25T16:40:58Z","git_url":"git://github.com/redis/redis-rb.git","ssh_url":"git@github.com:redis/redis-rb.git","clone_url":"https://github.com/redis/redis-rb.git","svn_url":"https://github.com/redis/redis-rb","homepage":"","size":1652,"stargazers_count":2942,"watchers_count":2942,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":674,"mirror_url":null,"open_issues_count":63,"forks":674,"open_issues":63,"watchers":2942,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redis/redis-rb/pulls/690"},"html":{"href":"https://github.com/redis/redis-rb/pull/690"},"issue":{"href":"https://api.github.com/repos/redis/redis-rb/issues/690"},"comments":{"href":"https://api.github.com/repos/redis/redis-rb/issues/690/comments"},"review_comments":{"href":"https://api.github.com/repos/redis/redis-rb/pulls/690/comments"},"review_comment":{"href":"https://api.github.com/repos/redis/redis-rb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redis/redis-rb/pulls/690/commits"},"statuses":{"href":"https://api.github.com/repos/redis/redis-rb/statuses/e5f8ec25e269d074d4323ed5ac23ab612ac422e5"}}}}
{"actor":{"display_login":"olleolleolle"}}