{"action":"created","comment":{"url":"https://api.github.com/repos/asciimoo/colly/pulls/comments/143360967","pull_request_review_id":67863449,"id":143360967,"diff_hunk":"@@ -1,11 +1,16 @@\n package colly\n \n import (\n+\t\"crypto/sha1\"","path":"http_backend.go","position":4,"original_position":4,"commit_id":"45c7962457b956e7e3c1a2e33640f554a2ff6e1f","original_commit_id":"45c7962457b956e7e3c1a2e33640f554a2ff6e1f","user":{"login":"asciimoo","id":20240,"avatar_url":"https://avatars3.githubusercontent.com/u/20240?v=4","gravatar_id":"","url":"https://api.github.com/users/asciimoo","html_url":"https://github.com/asciimoo","followers_url":"https://api.github.com/users/asciimoo/followers","following_url":"https://api.github.com/users/asciimoo/following{/other_user}","gists_url":"https://api.github.com/users/asciimoo/gists{/gist_id}","starred_url":"https://api.github.com/users/asciimoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciimoo/subscriptions","organizations_url":"https://api.github.com/users/asciimoo/orgs","repos_url":"https://api.github.com/users/asciimoo/repos","events_url":"https://api.github.com/users/asciimoo/events{/privacy}","received_events_url":"https://api.github.com/users/asciimoo/received_events","type":"User","site_admin":false},"body":"sha1 considered unsafe, please use sha256 instead.\r\n(https://www.schneier.com/blog/archives/2017/02/sha-1_collision.html)","created_at":"2017-10-08T17:35:41Z","updated_at":"2017-10-08T17:49:34Z","html_url":"https://github.com/asciimoo/colly/pull/15#discussion_r143360967","pull_request_url":"https://api.github.com/repos/asciimoo/colly/pulls/15","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/asciimoo/colly/pulls/comments/143360967"},"html":{"href":"https://github.com/asciimoo/colly/pull/15#discussion_r143360967"},"pull_request":{"href":"https://api.github.com/repos/asciimoo/colly/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/asciimoo/colly/pulls/15","id":145309042,"html_url":"https://github.com/asciimoo/colly/pull/15","diff_url":"https://github.com/asciimoo/colly/pull/15.diff","patch_url":"https://github.com/asciimoo/colly/pull/15.patch","issue_url":"https://api.github.com/repos/asciimoo/colly/issues/15","number":15,"state":"open","locked":false,"title":"Caching when CacheDir is defined","user":{"login":"meehow","id":56711,"avatar_url":"https://avatars1.githubusercontent.com/u/56711?v=4","gravatar_id":"","url":"https://api.github.com/users/meehow","html_url":"https://github.com/meehow","followers_url":"https://api.github.com/users/meehow/followers","following_url":"https://api.github.com/users/meehow/following{/other_user}","gists_url":"https://api.github.com/users/meehow/gists{/gist_id}","starred_url":"https://api.github.com/users/meehow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meehow/subscriptions","organizations_url":"https://api.github.com/users/meehow/orgs","repos_url":"https://api.github.com/users/meehow/repos","events_url":"https://api.github.com/users/meehow/events{/privacy}","received_events_url":"https://api.github.com/users/meehow/received_events","type":"User","site_admin":false},"body":"I added some basic caching support. Changes should be backward compatible and enable cache only when `CacheDir` is defined. I needed to make `ContextMap` public to make request object serializable with gob.","created_at":"2017-10-07T21:10:44Z","updated_at":"2017-10-08T17:49:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5a239e1f858df376771bfc17500b105d32028969","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/asciimoo/colly/pulls/15/commits","review_comments_url":"https://api.github.com/repos/asciimoo/colly/pulls/15/comments","review_comment_url":"https://api.github.com/repos/asciimoo/colly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/asciimoo/colly/issues/15/comments","statuses_url":"https://api.github.com/repos/asciimoo/colly/statuses/45c7962457b956e7e3c1a2e33640f554a2ff6e1f","head":{"label":"meehow:master","ref":"master","sha":"45c7962457b956e7e3c1a2e33640f554a2ff6e1f","user":{"login":"meehow","id":56711,"avatar_url":"https://avatars1.githubusercontent.com/u/56711?v=4","gravatar_id":"","url":"https://api.github.com/users/meehow","html_url":"https://github.com/meehow","followers_url":"https://api.github.com/users/meehow/followers","following_url":"https://api.github.com/users/meehow/following{/other_user}","gists_url":"https://api.github.com/users/meehow/gists{/gist_id}","starred_url":"https://api.github.com/users/meehow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meehow/subscriptions","organizations_url":"https://api.github.com/users/meehow/orgs","repos_url":"https://api.github.com/users/meehow/repos","events_url":"https://api.github.com/users/meehow/events{/privacy}","received_events_url":"https://api.github.com/users/meehow/received_events","type":"User","site_admin":false},"repo":{"id":106081640,"name":"colly","full_name":"meehow/colly","owner":{"login":"meehow","id":56711,"avatar_url":"https://avatars1.githubusercontent.com/u/56711?v=4","gravatar_id":"","url":"https://api.github.com/users/meehow","html_url":"https://github.com/meehow","followers_url":"https://api.github.com/users/meehow/followers","following_url":"https://api.github.com/users/meehow/following{/other_user}","gists_url":"https://api.github.com/users/meehow/gists{/gist_id}","starred_url":"https://api.github.com/users/meehow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meehow/subscriptions","organizations_url":"https://api.github.com/users/meehow/orgs","repos_url":"https://api.github.com/users/meehow/repos","events_url":"https://api.github.com/users/meehow/events{/privacy}","received_events_url":"https://api.github.com/users/meehow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/meehow/colly","description":"Lightning Fast and Elegant Scraping Framework for Gophers","fork":true,"url":"https://api.github.com/repos/meehow/colly","forks_url":"https://api.github.com/repos/meehow/colly/forks","keys_url":"https://api.github.com/repos/meehow/colly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/meehow/colly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/meehow/colly/teams","hooks_url":"https://api.github.com/repos/meehow/colly/hooks","issue_events_url":"https://api.github.com/repos/meehow/colly/issues/events{/number}","events_url":"https://api.github.com/repos/meehow/colly/events","assignees_url":"https://api.github.com/repos/meehow/colly/assignees{/user}","branches_url":"https://api.github.com/repos/meehow/colly/branches{/branch}","tags_url":"https://api.github.com/repos/meehow/colly/tags","blobs_url":"https://api.github.com/repos/meehow/colly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/meehow/colly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/meehow/colly/git/refs{/sha}","trees_url":"https://api.github.com/repos/meehow/colly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/meehow/colly/statuses/{sha}","languages_url":"https://api.github.com/repos/meehow/colly/languages","stargazers_url":"https://api.github.com/repos/meehow/colly/stargazers","contributors_url":"https://api.github.com/repos/meehow/colly/contributors","subscribers_url":"https://api.github.com/repos/meehow/colly/subscribers","subscription_url":"https://api.github.com/repos/meehow/colly/subscription","commits_url":"https://api.github.com/repos/meehow/colly/commits{/sha}","git_commits_url":"https://api.github.com/repos/meehow/colly/git/commits{/sha}","comments_url":"https://api.github.com/repos/meehow/colly/comments{/number}","issue_comment_url":"https://api.github.com/repos/meehow/colly/issues/comments{/number}","contents_url":"https://api.github.com/repos/meehow/colly/contents/{+path}","compare_url":"https://api.github.com/repos/meehow/colly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/meehow/colly/merges","archive_url":"https://api.github.com/repos/meehow/colly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/meehow/colly/downloads","issues_url":"https://api.github.com/repos/meehow/colly/issues{/number}","pulls_url":"https://api.github.com/repos/meehow/colly/pulls{/number}","milestones_url":"https://api.github.com/repos/meehow/colly/milestones{/number}","notifications_url":"https://api.github.com/repos/meehow/colly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/meehow/colly/labels{/name}","releases_url":"https://api.github.com/repos/meehow/colly/releases{/id}","deployments_url":"https://api.github.com/repos/meehow/colly/deployments","created_at":"2017-10-07T08:11:38Z","updated_at":"2017-10-07T08:11:40Z","pushed_at":"2017-10-07T21:07:26Z","git_url":"git://github.com/meehow/colly.git","ssh_url":"git@github.com:meehow/colly.git","clone_url":"https://github.com/meehow/colly.git","svn_url":"https://github.com/meehow/colly","homepage":"https://godoc.org/github.com/asciimoo/colly","size":164,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"asciimoo:master","ref":"master","sha":"e6dc915b444c6e064a77245073bb406202a68042","user":{"login":"asciimoo","id":20240,"avatar_url":"https://avatars3.githubusercontent.com/u/20240?v=4","gravatar_id":"","url":"https://api.github.com/users/asciimoo","html_url":"https://github.com/asciimoo","followers_url":"https://api.github.com/users/asciimoo/followers","following_url":"https://api.github.com/users/asciimoo/following{/other_user}","gists_url":"https://api.github.com/users/asciimoo/gists{/gist_id}","starred_url":"https://api.github.com/users/asciimoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciimoo/subscriptions","organizations_url":"https://api.github.com/users/asciimoo/orgs","repos_url":"https://api.github.com/users/asciimoo/repos","events_url":"https://api.github.com/users/asciimoo/events{/privacy}","received_events_url":"https://api.github.com/users/asciimoo/received_events","type":"User","site_admin":false},"repo":{"id":105279544,"name":"colly","full_name":"asciimoo/colly","owner":{"login":"asciimoo","id":20240,"avatar_url":"https://avatars3.githubusercontent.com/u/20240?v=4","gravatar_id":"","url":"https://api.github.com/users/asciimoo","html_url":"https://github.com/asciimoo","followers_url":"https://api.github.com/users/asciimoo/followers","following_url":"https://api.github.com/users/asciimoo/following{/other_user}","gists_url":"https://api.github.com/users/asciimoo/gists{/gist_id}","starred_url":"https://api.github.com/users/asciimoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asciimoo/subscriptions","organizations_url":"https://api.github.com/users/asciimoo/orgs","repos_url":"https://api.github.com/users/asciimoo/repos","events_url":"https://api.github.com/users/asciimoo/events{/privacy}","received_events_url":"https://api.github.com/users/asciimoo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asciimoo/colly","description":"Fast and Elegant Scraping Framework for Gophers","fork":false,"url":"https://api.github.com/repos/asciimoo/colly","forks_url":"https://api.github.com/repos/asciimoo/colly/forks","keys_url":"https://api.github.com/repos/asciimoo/colly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asciimoo/colly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asciimoo/colly/teams","hooks_url":"https://api.github.com/repos/asciimoo/colly/hooks","issue_events_url":"https://api.github.com/repos/asciimoo/colly/issues/events{/number}","events_url":"https://api.github.com/repos/asciimoo/colly/events","assignees_url":"https://api.github.com/repos/asciimoo/colly/assignees{/user}","branches_url":"https://api.github.com/repos/asciimoo/colly/branches{/branch}","tags_url":"https://api.github.com/repos/asciimoo/colly/tags","blobs_url":"https://api.github.com/repos/asciimoo/colly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asciimoo/colly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asciimoo/colly/git/refs{/sha}","trees_url":"https://api.github.com/repos/asciimoo/colly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asciimoo/colly/statuses/{sha}","languages_url":"https://api.github.com/repos/asciimoo/colly/languages","stargazers_url":"https://api.github.com/repos/asciimoo/colly/stargazers","contributors_url":"https://api.github.com/repos/asciimoo/colly/contributors","subscribers_url":"https://api.github.com/repos/asciimoo/colly/subscribers","subscription_url":"https://api.github.com/repos/asciimoo/colly/subscription","commits_url":"https://api.github.com/repos/asciimoo/colly/commits{/sha}","git_commits_url":"https://api.github.com/repos/asciimoo/colly/git/commits{/sha}","comments_url":"https://api.github.com/repos/asciimoo/colly/comments{/number}","issue_comment_url":"https://api.github.com/repos/asciimoo/colly/issues/comments{/number}","contents_url":"https://api.github.com/repos/asciimoo/colly/contents/{+path}","compare_url":"https://api.github.com/repos/asciimoo/colly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asciimoo/colly/merges","archive_url":"https://api.github.com/repos/asciimoo/colly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asciimoo/colly/downloads","issues_url":"https://api.github.com/repos/asciimoo/colly/issues{/number}","pulls_url":"https://api.github.com/repos/asciimoo/colly/pulls{/number}","milestones_url":"https://api.github.com/repos/asciimoo/colly/milestones{/number}","notifications_url":"https://api.github.com/repos/asciimoo/colly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asciimoo/colly/labels{/name}","releases_url":"https://api.github.com/repos/asciimoo/colly/releases{/id}","deployments_url":"https://api.github.com/repos/asciimoo/colly/deployments","created_at":"2017-09-29T14:08:49Z","updated_at":"2017-10-08T17:41:40Z","pushed_at":"2017-10-08T17:45:00Z","git_url":"git://github.com/asciimoo/colly.git","ssh_url":"git@github.com:asciimoo/colly.git","clone_url":"https://github.com/asciimoo/colly.git","svn_url":"https://github.com/asciimoo/colly","homepage":"https://godoc.org/github.com/asciimoo/colly","size":49,"stargazers_count":1353,"watchers_count":1353,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":53,"mirror_url":null,"open_issues_count":5,"forks":53,"open_issues":5,"watchers":1353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/asciimoo/colly/pulls/15"},"html":{"href":"https://github.com/asciimoo/colly/pull/15"},"issue":{"href":"https://api.github.com/repos/asciimoo/colly/issues/15"},"comments":{"href":"https://api.github.com/repos/asciimoo/colly/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/asciimoo/colly/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/asciimoo/colly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/asciimoo/colly/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/asciimoo/colly/statuses/45c7962457b956e7e3c1a2e33640f554a2ff6e1f"}},"author_association":"NONE"}}
{"actor":{"display_login":"asciimoo"}}