{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/comments/143116939","pull_request_review_id":67580958,"id":143116939,"diff_hunk":"@@ -30,10 +28,18 @@ public static IServiceCollection AddLegacyClusterConfigurationSupport(this IServ\n             return services;\n         }\n \n-        public static IServiceCollection AddLegacyClientConfigurationSupport(this IServiceCollection services)\n+        public static IServiceCollection AddLegacyNodeConfigurationSupport(this IServiceCollection services)\n         {\n-            // Global configuration\n+            services.Configure<NodeConfiguration, StatisticsOptions>((configuration, options) =>\n+            {\n+                CopyStatisticsOptions(configuration, options);\n+            });\n \n+            return services;\n+        }\n+\n+        public static IServiceCollection AddLegacyClientConfigurationSupport(this IServiceCollection services)","path":"src/Orleans/Configuration/Legacy/LegacyConfigurationExtensions.cs","position":25,"original_position":25,"commit_id":"4ee1f8f21b86fdcdac6eb78a3bc15e68c81e0954","original_commit_id":"4ee1f8f21b86fdcdac6eb78a3bc15e68c81e0954","user":{"login":"jdom","id":1361686,"avatar_url":"https://avatars3.githubusercontent.com/u/1361686?v=4","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false},"body":"the namespace for this class should be moved to `Orleans.Hosting`","created_at":"2017-10-06T06:29:19Z","updated_at":"2017-10-06T06:29:19Z","html_url":"https://github.com/dotnet/orleans/pull/3492#discussion_r143116939","pull_request_url":"https://api.github.com/repos/dotnet/orleans/pulls/3492","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments/143116939"},"html":{"href":"https://github.com/dotnet/orleans/pull/3492#discussion_r143116939"},"pull_request":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3492"}}},"pull_request":{"url":"https://api.github.com/repos/dotnet/orleans/pulls/3492","id":144592757,"html_url":"https://github.com/dotnet/orleans/pull/3492","diff_url":"https://github.com/dotnet/orleans/pull/3492.diff","patch_url":"https://github.com/dotnet/orleans/pull/3492.patch","issue_url":"https://api.github.com/repos/dotnet/orleans/issues/3492","number":3492,"state":"open","locked":false,"title":"Migrate StatisticsConfiguration to StatisticsOptions","user":{"login":"attilah","id":230432,"avatar_url":"https://avatars2.githubusercontent.com/u/230432?v=4","gravatar_id":"","url":"https://api.github.com/users/attilah","html_url":"https://github.com/attilah","followers_url":"https://api.github.com/users/attilah/followers","following_url":"https://api.github.com/users/attilah/following{/other_user}","gists_url":"https://api.github.com/users/attilah/gists{/gist_id}","starred_url":"https://api.github.com/users/attilah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attilah/subscriptions","organizations_url":"https://api.github.com/users/attilah/orgs","repos_url":"https://api.github.com/users/attilah/repos","events_url":"https://api.github.com/users/attilah/events{/privacy}","received_events_url":"https://api.github.com/users/attilah/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-10-04T06:44:59Z","updated_at":"2017-10-06T06:29:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30ea70838af8c206554dc0b3d86c0559990f3ec8","assignee":{"login":"jdom","id":1361686,"avatar_url":"https://avatars3.githubusercontent.com/u/1361686?v=4","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false},"assignees":[{"login":"jdom","id":1361686,"avatar_url":"https://avatars3.githubusercontent.com/u/1361686?v=4","gravatar_id":"","url":"https://api.github.com/users/jdom","html_url":"https://github.com/jdom","followers_url":"https://api.github.com/users/jdom/followers","following_url":"https://api.github.com/users/jdom/following{/other_user}","gists_url":"https://api.github.com/users/jdom/gists{/gist_id}","starred_url":"https://api.github.com/users/jdom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdom/subscriptions","organizations_url":"https://api.github.com/users/jdom/orgs","repos_url":"https://api.github.com/users/jdom/repos","events_url":"https://api.github.com/users/jdom/events{/privacy}","received_events_url":"https://api.github.com/users/jdom/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/dotnet/orleans/milestones/20","html_url":"https://github.com/dotnet/orleans/milestone/20","labels_url":"https://api.github.com/repos/dotnet/orleans/milestones/20/labels","id":2757603,"number":20,"title":"2.0.0-beta","description":"","creator":{"login":"sergeybykov","id":8248806,"avatar_url":"https://avatars1.githubusercontent.com/u/8248806?v=4","gravatar_id":"","url":"https://api.github.com/users/sergeybykov","html_url":"https://github.com/sergeybykov","followers_url":"https://api.github.com/users/sergeybykov/followers","following_url":"https://api.github.com/users/sergeybykov/following{/other_user}","gists_url":"https://api.github.com/users/sergeybykov/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeybykov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeybykov/subscriptions","organizations_url":"https://api.github.com/users/sergeybykov/orgs","repos_url":"https://api.github.com/users/sergeybykov/repos","events_url":"https://api.github.com/users/sergeybykov/events{/privacy}","received_events_url":"https://api.github.com/users/sergeybykov/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":18,"state":"open","created_at":"2017-09-11T15:32:03Z","updated_at":"2017-10-05T22:59:26Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/dotnet/orleans/pulls/3492/commits","review_comments_url":"https://api.github.com/repos/dotnet/orleans/pulls/3492/comments","review_comment_url":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/orleans/issues/3492/comments","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/4ee1f8f21b86fdcdac6eb78a3bc15e68c81e0954","head":{"label":"attilah:migrate-IStatisticsConfiguration","ref":"migrate-IStatisticsConfiguration","sha":"4ee1f8f21b86fdcdac6eb78a3bc15e68c81e0954","user":{"login":"attilah","id":230432,"avatar_url":"https://avatars2.githubusercontent.com/u/230432?v=4","gravatar_id":"","url":"https://api.github.com/users/attilah","html_url":"https://github.com/attilah","followers_url":"https://api.github.com/users/attilah/followers","following_url":"https://api.github.com/users/attilah/following{/other_user}","gists_url":"https://api.github.com/users/attilah/gists{/gist_id}","starred_url":"https://api.github.com/users/attilah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attilah/subscriptions","organizations_url":"https://api.github.com/users/attilah/orgs","repos_url":"https://api.github.com/users/attilah/repos","events_url":"https://api.github.com/users/attilah/events{/privacy}","received_events_url":"https://api.github.com/users/attilah/received_events","type":"User","site_admin":false},"repo":{"id":48026713,"name":"orleans","full_name":"attilah/orleans","owner":{"login":"attilah","id":230432,"avatar_url":"https://avatars2.githubusercontent.com/u/230432?v=4","gravatar_id":"","url":"https://api.github.com/users/attilah","html_url":"https://github.com/attilah","followers_url":"https://api.github.com/users/attilah/followers","following_url":"https://api.github.com/users/attilah/following{/other_user}","gists_url":"https://api.github.com/users/attilah/gists{/gist_id}","starred_url":"https://api.github.com/users/attilah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/attilah/subscriptions","organizations_url":"https://api.github.com/users/attilah/orgs","repos_url":"https://api.github.com/users/attilah/repos","events_url":"https://api.github.com/users/attilah/events{/privacy}","received_events_url":"https://api.github.com/users/attilah/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/attilah/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":true,"url":"https://api.github.com/repos/attilah/orleans","forks_url":"https://api.github.com/repos/attilah/orleans/forks","keys_url":"https://api.github.com/repos/attilah/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/attilah/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/attilah/orleans/teams","hooks_url":"https://api.github.com/repos/attilah/orleans/hooks","issue_events_url":"https://api.github.com/repos/attilah/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/attilah/orleans/events","assignees_url":"https://api.github.com/repos/attilah/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/attilah/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/attilah/orleans/tags","blobs_url":"https://api.github.com/repos/attilah/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/attilah/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/attilah/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/attilah/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/attilah/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/attilah/orleans/languages","stargazers_url":"https://api.github.com/repos/attilah/orleans/stargazers","contributors_url":"https://api.github.com/repos/attilah/orleans/contributors","subscribers_url":"https://api.github.com/repos/attilah/orleans/subscribers","subscription_url":"https://api.github.com/repos/attilah/orleans/subscription","commits_url":"https://api.github.com/repos/attilah/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/attilah/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/attilah/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/attilah/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/attilah/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/attilah/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/attilah/orleans/merges","archive_url":"https://api.github.com/repos/attilah/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/attilah/orleans/downloads","issues_url":"https://api.github.com/repos/attilah/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/attilah/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/attilah/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/attilah/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/attilah/orleans/labels{/name}","releases_url":"https://api.github.com/repos/attilah/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/attilah/orleans/deployments","created_at":"2015-12-15T07:26:37Z","updated_at":"2016-01-23T20:32:11Z","pushed_at":"2017-10-04T06:44:39Z","git_url":"git://github.com/attilah/orleans.git","ssh_url":"git@github.com:attilah/orleans.git","clone_url":"https://github.com/attilah/orleans.git","svn_url":"https://github.com/attilah/orleans","homepage":"http://dotnet.github.io/orleans","size":19941,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"01eada96369eff86f30fb521303ca6c2df572161","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":28232663,"name":"orleans","full_name":"dotnet/orleans","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/orleans","description":"Orleans - Distributed Virtual Actor Model","fork":false,"url":"https://api.github.com/repos/dotnet/orleans","forks_url":"https://api.github.com/repos/dotnet/orleans/forks","keys_url":"https://api.github.com/repos/dotnet/orleans/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/orleans/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/orleans/teams","hooks_url":"https://api.github.com/repos/dotnet/orleans/hooks","issue_events_url":"https://api.github.com/repos/dotnet/orleans/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/orleans/events","assignees_url":"https://api.github.com/repos/dotnet/orleans/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/orleans/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/orleans/tags","blobs_url":"https://api.github.com/repos/dotnet/orleans/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/orleans/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/orleans/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/orleans/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/orleans/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/orleans/languages","stargazers_url":"https://api.github.com/repos/dotnet/orleans/stargazers","contributors_url":"https://api.github.com/repos/dotnet/orleans/contributors","subscribers_url":"https://api.github.com/repos/dotnet/orleans/subscribers","subscription_url":"https://api.github.com/repos/dotnet/orleans/subscription","commits_url":"https://api.github.com/repos/dotnet/orleans/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/orleans/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/orleans/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/orleans/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/orleans/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/orleans/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/orleans/merges","archive_url":"https://api.github.com/repos/dotnet/orleans/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/orleans/downloads","issues_url":"https://api.github.com/repos/dotnet/orleans/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/orleans/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/orleans/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/orleans/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/orleans/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/orleans/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/orleans/deployments","created_at":"2014-12-19T14:32:50Z","updated_at":"2017-10-06T04:22:10Z","pushed_at":"2017-10-06T00:23:21Z","git_url":"git://github.com/dotnet/orleans.git","ssh_url":"git@github.com:dotnet/orleans.git","clone_url":"https://github.com/dotnet/orleans.git","svn_url":"https://github.com/dotnet/orleans","homepage":"http://dotnet.github.io/orleans","size":41198,"stargazers_count":3149,"watchers_count":3149,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":783,"mirror_url":null,"open_issues_count":315,"forks":783,"open_issues":315,"watchers":3149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3492"},"html":{"href":"https://github.com/dotnet/orleans/pull/3492"},"issue":{"href":"https://api.github.com/repos/dotnet/orleans/issues/3492"},"comments":{"href":"https://api.github.com/repos/dotnet/orleans/issues/3492/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3492/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/orleans/pulls/3492/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/orleans/statuses/4ee1f8f21b86fdcdac6eb78a3bc15e68c81e0954"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jdom"}}