{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/135705996","pull_request_review_id":59145033,"id":135705996,"diff_hunk":"@@ -2181,17 +2175,17 @@ static int handle_request(struct zoap_packet *request,\n \treturn r;\n }\n \n-int lwm2m_udp_sendto(struct net_pkt *pkt, const struct sockaddr *dst_addr)\n+int lwm2m_udp_sendto(struct net_app_ctx *app_ctx, struct net_pkt *pkt,\n+\t\t     const struct sockaddr *dst_addr)","path":"subsys/net/lib/lwm2m/lwm2m_engine.c","position":139,"original_position":133,"commit_id":"c57db4af7e924d6ccce608729610a66993ac0ad7","original_commit_id":"b8d676b063ec3da96ec78f7bfe98492f7aca66d2","user":{"login":"rbtchc","id":904087,"avatar_url":"https://avatars2.githubusercontent.com/u/904087?v=4","gravatar_id":"","url":"https://api.github.com/users/rbtchc","html_url":"https://github.com/rbtchc","followers_url":"https://api.github.com/users/rbtchc/followers","following_url":"https://api.github.com/users/rbtchc/following{/other_user}","gists_url":"https://api.github.com/users/rbtchc/gists{/gist_id}","starred_url":"https://api.github.com/users/rbtchc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbtchc/subscriptions","organizations_url":"https://api.github.com/users/rbtchc/orgs","repos_url":"https://api.github.com/users/rbtchc/repos","events_url":"https://api.github.com/users/rbtchc/events{/privacy}","received_events_url":"https://api.github.com/users/rbtchc/received_events","type":"User","site_admin":false},"body":"Agree. But I suppose it doesn't work when DTLS is enabled.","created_at":"2017-08-29T06:46:29Z","updated_at":"2017-08-29T06:46:30Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/1255#discussion_r135705996","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1255","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/135705996"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/1255#discussion_r135705996"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1255"}},"in_reply_to_id":135179105},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1255","id":137504563,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/1255","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/1255.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/1255.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/1255","number":1255,"state":"open","locked":false,"title":"LwM2M: Move library internals to net_app APIs","user":{"login":"mike-scott","id":9355527,"avatar_url":"https://avatars2.githubusercontent.com/u/9355527?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-scott","html_url":"https://github.com/mike-scott","followers_url":"https://api.github.com/users/mike-scott/followers","following_url":"https://api.github.com/users/mike-scott/following{/other_user}","gists_url":"https://api.github.com/users/mike-scott/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-scott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-scott/subscriptions","organizations_url":"https://api.github.com/users/mike-scott/orgs","repos_url":"https://api.github.com/users/mike-scott/repos","events_url":"https://api.github.com/users/mike-scott/events{/privacy}","received_events_url":"https://api.github.com/users/mike-scott/received_events","type":"User","site_admin":false},"body":"Currently, the LwM2M uses net_context structures and the LwM2M sample has code to establish network communications.\r\n\r\nThis should be changed to use the net_app APIs so that the sample can remove most of the network\r\nsetup code and the library itself can benefit from other net_app features such as DTLS, etc.","created_at":"2017-08-24T17:07:11Z","updated_at":"2017-08-29T06:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f033449abc455087a29be3af17ca115da2b853b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"tbursztyka","id":1608406,"avatar_url":"https://avatars2.githubusercontent.com/u/1608406?v=4","gravatar_id":"","url":"https://api.github.com/users/tbursztyka","html_url":"https://github.com/tbursztyka","followers_url":"https://api.github.com/users/tbursztyka/followers","following_url":"https://api.github.com/users/tbursztyka/following{/other_user}","gists_url":"https://api.github.com/users/tbursztyka/gists{/gist_id}","starred_url":"https://api.github.com/users/tbursztyka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tbursztyka/subscriptions","organizations_url":"https://api.github.com/users/tbursztyka/orgs","repos_url":"https://api.github.com/users/tbursztyka/repos","events_url":"https://api.github.com/users/tbursztyka/events{/privacy}","received_events_url":"https://api.github.com/users/tbursztyka/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones/6","html_url":"https://github.com/zephyrproject-rtos/zephyr/milestone/6","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones/6/labels","id":2607212,"number":6,"title":"v1.10","description":"","creator":{"login":"nashif","id":180017,"avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":0,"state":"open","created_at":"2017-06-27T13:34:13Z","updated_at":"2017-08-28T23:57:21Z","due_on":"2017-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1255/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1255/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/1255/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/c57db4af7e924d6ccce608729610a66993ac0ad7","head":{"label":"mike-scott:lwm2m-net-app","ref":"lwm2m-net-app","sha":"c57db4af7e924d6ccce608729610a66993ac0ad7","user":{"login":"mike-scott","id":9355527,"avatar_url":"https://avatars2.githubusercontent.com/u/9355527?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-scott","html_url":"https://github.com/mike-scott","followers_url":"https://api.github.com/users/mike-scott/followers","following_url":"https://api.github.com/users/mike-scott/following{/other_user}","gists_url":"https://api.github.com/users/mike-scott/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-scott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-scott/subscriptions","organizations_url":"https://api.github.com/users/mike-scott/orgs","repos_url":"https://api.github.com/users/mike-scott/repos","events_url":"https://api.github.com/users/mike-scott/events{/privacy}","received_events_url":"https://api.github.com/users/mike-scott/received_events","type":"User","site_admin":false},"repo":{"id":92333484,"name":"zephyr","full_name":"mike-scott/zephyr","owner":{"login":"mike-scott","id":9355527,"avatar_url":"https://avatars2.githubusercontent.com/u/9355527?v=4","gravatar_id":"","url":"https://api.github.com/users/mike-scott","html_url":"https://github.com/mike-scott","followers_url":"https://api.github.com/users/mike-scott/followers","following_url":"https://api.github.com/users/mike-scott/following{/other_user}","gists_url":"https://api.github.com/users/mike-scott/gists{/gist_id}","starred_url":"https://api.github.com/users/mike-scott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mike-scott/subscriptions","organizations_url":"https://api.github.com/users/mike-scott/orgs","repos_url":"https://api.github.com/users/mike-scott/repos","events_url":"https://api.github.com/users/mike-scott/events{/privacy}","received_events_url":"https://api.github.com/users/mike-scott/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mike-scott/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/mike-scott/zephyr","forks_url":"https://api.github.com/repos/mike-scott/zephyr/forks","keys_url":"https://api.github.com/repos/mike-scott/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mike-scott/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mike-scott/zephyr/teams","hooks_url":"https://api.github.com/repos/mike-scott/zephyr/hooks","issue_events_url":"https://api.github.com/repos/mike-scott/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/mike-scott/zephyr/events","assignees_url":"https://api.github.com/repos/mike-scott/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/mike-scott/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/mike-scott/zephyr/tags","blobs_url":"https://api.github.com/repos/mike-scott/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mike-scott/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mike-scott/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/mike-scott/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mike-scott/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/mike-scott/zephyr/languages","stargazers_url":"https://api.github.com/repos/mike-scott/zephyr/stargazers","contributors_url":"https://api.github.com/repos/mike-scott/zephyr/contributors","subscribers_url":"https://api.github.com/repos/mike-scott/zephyr/subscribers","subscription_url":"https://api.github.com/repos/mike-scott/zephyr/subscription","commits_url":"https://api.github.com/repos/mike-scott/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/mike-scott/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/mike-scott/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/mike-scott/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/mike-scott/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/mike-scott/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mike-scott/zephyr/merges","archive_url":"https://api.github.com/repos/mike-scott/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mike-scott/zephyr/downloads","issues_url":"https://api.github.com/repos/mike-scott/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/mike-scott/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/mike-scott/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/mike-scott/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mike-scott/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/mike-scott/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/mike-scott/zephyr/deployments","created_at":"2017-05-24T20:25:49Z","updated_at":"2017-05-24T20:26:45Z","pushed_at":"2017-08-28T23:45:04Z","git_url":"git://github.com/mike-scott/zephyr.git","ssh_url":"git@github.com:mike-scott/zephyr.git","clone_url":"https://github.com/mike-scott/zephyr.git","svn_url":"https://github.com/mike-scott/zephyr","homepage":"http://zephyrproject.org/doc","size":81596,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":2,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"54e01ac58f3593f6db6bc1bec9d5cbc7b8684a53","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2017-08-28T13:37:24Z","pushed_at":"2017-08-29T04:28:48Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"http://zephyrproject.org/doc","size":81754,"stargazers_count":310,"watchers_count":310,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":266,"mirror_url":null,"open_issues_count":88,"forks":266,"open_issues":88,"watchers":310,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1255"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/1255"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/1255"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/1255/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1255/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/1255/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/c57db4af7e924d6ccce608729610a66993ac0ad7"}}}}
{"actor":{"display_login":"rbtchc"}}