{"action":"opened","number":3,"pull_request":{"url":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls/3","id":104312558,"html_url":"https://github.com/hirschenberger/ex_modbus/pull/3","diff_url":"https://github.com/hirschenberger/ex_modbus/pull/3.diff","patch_url":"https://github.com/hirschenberger/ex_modbus/pull/3.patch","issue_url":"https://api.github.com/repos/hirschenberger/ex_modbus/issues/3","number":3,"state":"open","locked":false,"title":"Reduce duplication between TCP/RTU clients","user":{"login":"jeffdeville","id":131664,"avatar_url":"https://avatars.githubusercontent.com/u/131664?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdeville","html_url":"https://github.com/jeffdeville","followers_url":"https://api.github.com/users/jeffdeville/followers","following_url":"https://api.github.com/users/jeffdeville/following{/other_user}","gists_url":"https://api.github.com/users/jeffdeville/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdeville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdeville/subscriptions","organizations_url":"https://api.github.com/users/jeffdeville/orgs","repos_url":"https://api.github.com/users/jeffdeville/repos","events_url":"https://api.github.com/users/jeffdeville/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdeville/received_events","type":"User","site_admin":false},"body":"Sorry, because this is a fork, I can't create an issue here. So this was the only way I knew to start a conversation.\r\n\r\nI'm preparing to start updating the TCP client (handling connection disruptions), but wanted to reduce the duplication with some of the logic first, and check whether you prefer 1 big PR that would include the TCP changes, or break it into this, and a separate one to handle TCP connection issues.\r\n\r\n**Alert 1:** This would require a big version bump, because the RtuClient won't work on its own anymore. Everything would just be ExModbus.Client, and it infers your transport (TCP/RTU) based on the parameters you specify.\r\n\r\n**Alert 2:** Because there are no specs for any of this, I can't be sure it's all working!  I'll write specs for the TCP code that I upgrade though.","created_at":"2017-02-02T10:43:58Z","updated_at":"2017-02-02T10:43:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls/3/commits","review_comments_url":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls/3/comments","review_comment_url":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hirschenberger/ex_modbus/issues/3/comments","statuses_url":"https://api.github.com/repos/hirschenberger/ex_modbus/statuses/1c08d39c0e1e523f6b7f9f2410d3baf7974c453a","head":{"label":"jeffdeville:client_refactoring","ref":"client_refactoring","sha":"1c08d39c0e1e523f6b7f9f2410d3baf7974c453a","user":{"login":"jeffdeville","id":131664,"avatar_url":"https://avatars.githubusercontent.com/u/131664?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdeville","html_url":"https://github.com/jeffdeville","followers_url":"https://api.github.com/users/jeffdeville/followers","following_url":"https://api.github.com/users/jeffdeville/following{/other_user}","gists_url":"https://api.github.com/users/jeffdeville/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdeville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdeville/subscriptions","organizations_url":"https://api.github.com/users/jeffdeville/orgs","repos_url":"https://api.github.com/users/jeffdeville/repos","events_url":"https://api.github.com/users/jeffdeville/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdeville/received_events","type":"User","site_admin":false},"repo":{"id":80710187,"name":"ex_modbus","full_name":"jeffdeville/ex_modbus","owner":{"login":"jeffdeville","id":131664,"avatar_url":"https://avatars.githubusercontent.com/u/131664?v=3","gravatar_id":"","url":"https://api.github.com/users/jeffdeville","html_url":"https://github.com/jeffdeville","followers_url":"https://api.github.com/users/jeffdeville/followers","following_url":"https://api.github.com/users/jeffdeville/following{/other_user}","gists_url":"https://api.github.com/users/jeffdeville/gists{/gist_id}","starred_url":"https://api.github.com/users/jeffdeville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeffdeville/subscriptions","organizations_url":"https://api.github.com/users/jeffdeville/orgs","repos_url":"https://api.github.com/users/jeffdeville/repos","events_url":"https://api.github.com/users/jeffdeville/events{/privacy}","received_events_url":"https://api.github.com/users/jeffdeville/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeffdeville/ex_modbus","description":"Elixir ModbusTCP Client","fork":true,"url":"https://api.github.com/repos/jeffdeville/ex_modbus","forks_url":"https://api.github.com/repos/jeffdeville/ex_modbus/forks","keys_url":"https://api.github.com/repos/jeffdeville/ex_modbus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeffdeville/ex_modbus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeffdeville/ex_modbus/teams","hooks_url":"https://api.github.com/repos/jeffdeville/ex_modbus/hooks","issue_events_url":"https://api.github.com/repos/jeffdeville/ex_modbus/issues/events{/number}","events_url":"https://api.github.com/repos/jeffdeville/ex_modbus/events","assignees_url":"https://api.github.com/repos/jeffdeville/ex_modbus/assignees{/user}","branches_url":"https://api.github.com/repos/jeffdeville/ex_modbus/branches{/branch}","tags_url":"https://api.github.com/repos/jeffdeville/ex_modbus/tags","blobs_url":"https://api.github.com/repos/jeffdeville/ex_modbus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeffdeville/ex_modbus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeffdeville/ex_modbus/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeffdeville/ex_modbus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeffdeville/ex_modbus/statuses/{sha}","languages_url":"https://api.github.com/repos/jeffdeville/ex_modbus/languages","stargazers_url":"https://api.github.com/repos/jeffdeville/ex_modbus/stargazers","contributors_url":"https://api.github.com/repos/jeffdeville/ex_modbus/contributors","subscribers_url":"https://api.github.com/repos/jeffdeville/ex_modbus/subscribers","subscription_url":"https://api.github.com/repos/jeffdeville/ex_modbus/subscription","commits_url":"https://api.github.com/repos/jeffdeville/ex_modbus/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeffdeville/ex_modbus/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeffdeville/ex_modbus/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeffdeville/ex_modbus/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeffdeville/ex_modbus/contents/{+path}","compare_url":"https://api.github.com/repos/jeffdeville/ex_modbus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeffdeville/ex_modbus/merges","archive_url":"https://api.github.com/repos/jeffdeville/ex_modbus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeffdeville/ex_modbus/downloads","issues_url":"https://api.github.com/repos/jeffdeville/ex_modbus/issues{/number}","pulls_url":"https://api.github.com/repos/jeffdeville/ex_modbus/pulls{/number}","milestones_url":"https://api.github.com/repos/jeffdeville/ex_modbus/milestones{/number}","notifications_url":"https://api.github.com/repos/jeffdeville/ex_modbus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeffdeville/ex_modbus/labels{/name}","releases_url":"https://api.github.com/repos/jeffdeville/ex_modbus/releases{/id}","deployments_url":"https://api.github.com/repos/jeffdeville/ex_modbus/deployments","created_at":"2017-02-02T09:23:24Z","updated_at":"2017-02-02T09:23:26Z","pushed_at":"2017-02-02T10:21:15Z","git_url":"git://github.com/jeffdeville/ex_modbus.git","ssh_url":"git@github.com:jeffdeville/ex_modbus.git","clone_url":"https://github.com/jeffdeville/ex_modbus.git","svn_url":"https://github.com/jeffdeville/ex_modbus","homepage":null,"size":37,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hirschenberger:master","ref":"master","sha":"c3b6e3d369ef753eb837c960b4c203a2e4de9aaf","user":{"login":"hirschenberger","id":1053180,"avatar_url":"https://avatars.githubusercontent.com/u/1053180?v=3","gravatar_id":"","url":"https://api.github.com/users/hirschenberger","html_url":"https://github.com/hirschenberger","followers_url":"https://api.github.com/users/hirschenberger/followers","following_url":"https://api.github.com/users/hirschenberger/following{/other_user}","gists_url":"https://api.github.com/users/hirschenberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hirschenberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hirschenberger/subscriptions","organizations_url":"https://api.github.com/users/hirschenberger/orgs","repos_url":"https://api.github.com/users/hirschenberger/repos","events_url":"https://api.github.com/users/hirschenberger/events{/privacy}","received_events_url":"https://api.github.com/users/hirschenberger/received_events","type":"User","site_admin":false},"repo":{"id":42438604,"name":"ex_modbus","full_name":"hirschenberger/ex_modbus","owner":{"login":"hirschenberger","id":1053180,"avatar_url":"https://avatars.githubusercontent.com/u/1053180?v=3","gravatar_id":"","url":"https://api.github.com/users/hirschenberger","html_url":"https://github.com/hirschenberger","followers_url":"https://api.github.com/users/hirschenberger/followers","following_url":"https://api.github.com/users/hirschenberger/following{/other_user}","gists_url":"https://api.github.com/users/hirschenberger/gists{/gist_id}","starred_url":"https://api.github.com/users/hirschenberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hirschenberger/subscriptions","organizations_url":"https://api.github.com/users/hirschenberger/orgs","repos_url":"https://api.github.com/users/hirschenberger/repos","events_url":"https://api.github.com/users/hirschenberger/events{/privacy}","received_events_url":"https://api.github.com/users/hirschenberger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hirschenberger/ex_modbus","description":"Elixir ModbusTCP Client","fork":true,"url":"https://api.github.com/repos/hirschenberger/ex_modbus","forks_url":"https://api.github.com/repos/hirschenberger/ex_modbus/forks","keys_url":"https://api.github.com/repos/hirschenberger/ex_modbus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hirschenberger/ex_modbus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hirschenberger/ex_modbus/teams","hooks_url":"https://api.github.com/repos/hirschenberger/ex_modbus/hooks","issue_events_url":"https://api.github.com/repos/hirschenberger/ex_modbus/issues/events{/number}","events_url":"https://api.github.com/repos/hirschenberger/ex_modbus/events","assignees_url":"https://api.github.com/repos/hirschenberger/ex_modbus/assignees{/user}","branches_url":"https://api.github.com/repos/hirschenberger/ex_modbus/branches{/branch}","tags_url":"https://api.github.com/repos/hirschenberger/ex_modbus/tags","blobs_url":"https://api.github.com/repos/hirschenberger/ex_modbus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hirschenberger/ex_modbus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hirschenberger/ex_modbus/git/refs{/sha}","trees_url":"https://api.github.com/repos/hirschenberger/ex_modbus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hirschenberger/ex_modbus/statuses/{sha}","languages_url":"https://api.github.com/repos/hirschenberger/ex_modbus/languages","stargazers_url":"https://api.github.com/repos/hirschenberger/ex_modbus/stargazers","contributors_url":"https://api.github.com/repos/hirschenberger/ex_modbus/contributors","subscribers_url":"https://api.github.com/repos/hirschenberger/ex_modbus/subscribers","subscription_url":"https://api.github.com/repos/hirschenberger/ex_modbus/subscription","commits_url":"https://api.github.com/repos/hirschenberger/ex_modbus/commits{/sha}","git_commits_url":"https://api.github.com/repos/hirschenberger/ex_modbus/git/commits{/sha}","comments_url":"https://api.github.com/repos/hirschenberger/ex_modbus/comments{/number}","issue_comment_url":"https://api.github.com/repos/hirschenberger/ex_modbus/issues/comments{/number}","contents_url":"https://api.github.com/repos/hirschenberger/ex_modbus/contents/{+path}","compare_url":"https://api.github.com/repos/hirschenberger/ex_modbus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hirschenberger/ex_modbus/merges","archive_url":"https://api.github.com/repos/hirschenberger/ex_modbus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hirschenberger/ex_modbus/downloads","issues_url":"https://api.github.com/repos/hirschenberger/ex_modbus/issues{/number}","pulls_url":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls{/number}","milestones_url":"https://api.github.com/repos/hirschenberger/ex_modbus/milestones{/number}","notifications_url":"https://api.github.com/repos/hirschenberger/ex_modbus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hirschenberger/ex_modbus/labels{/name}","releases_url":"https://api.github.com/repos/hirschenberger/ex_modbus/releases{/id}","deployments_url":"https://api.github.com/repos/hirschenberger/ex_modbus/deployments","created_at":"2015-09-14T09:10:52Z","updated_at":"2017-01-20T00:40:37Z","pushed_at":"2017-02-02T09:56:49Z","git_url":"git://github.com/hirschenberger/ex_modbus.git","ssh_url":"git@github.com:hirschenberger/ex_modbus.git","clone_url":"https://github.com/hirschenberger/ex_modbus.git","svn_url":"https://github.com/hirschenberger/ex_modbus","homepage":null,"size":18,"stargazers_count":1,"watchers_count":1,"language":"Elixir","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":1,"forks":1,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls/3"},"html":{"href":"https://github.com/hirschenberger/ex_modbus/pull/3"},"issue":{"href":"https://api.github.com/repos/hirschenberger/ex_modbus/issues/3"},"comments":{"href":"https://api.github.com/repos/hirschenberger/ex_modbus/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hirschenberger/ex_modbus/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/hirschenberger/ex_modbus/statuses/1c08d39c0e1e523f6b7f9f2410d3baf7974c453a"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":60,"deletions":148,"changed_files":5}}
{"actor":{"display_login":"jeffdeville"}}