{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/132877993","pull_request_review_id":56000298,"id":132877993,"diff_hunk":"@@ -1378,6 +1379,18 @@\n    */\n   String NAME = \"name\";\n   /**\n+   * The authentication mode for the protobuf client-server protocol.\n+   *\n+   * </p>\n+   * <U>Description</U>: Specifies the authentication mode used by the geode-protobuf module.\n+   * </p>\n+   * <U>Default</U>: \"NOOP\"\n+   * </p>\n+   * <U>Allowed values</U>: \"NOOP\" \"SIMPLE\"\n+   */\n+  @Experimental\n+  String PROTOBUF_PROTOCOL_AUTHENTICATION_MODE = \"protobuf-protocol-authentication-mode\";","path":"geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java","position":22,"original_position":22,"commit_id":"daa140875c4f65838dde4ae0f627a9551bea7516","original_commit_id":"daa140875c4f65838dde4ae0f627a9551bea7516","user":{"login":"galen-pivotal","id":22917714,"avatar_url":"https://avatars1.githubusercontent.com/u/22917714?v=4","gravatar_id":"","url":"https://api.github.com/users/galen-pivotal","html_url":"https://github.com/galen-pivotal","followers_url":"https://api.github.com/users/galen-pivotal/followers","following_url":"https://api.github.com/users/galen-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/galen-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/galen-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galen-pivotal/subscriptions","organizations_url":"https://api.github.com/users/galen-pivotal/orgs","repos_url":"https://api.github.com/users/galen-pivotal/repos","events_url":"https://api.github.com/users/galen-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/galen-pivotal/received_events","type":"User","site_admin":false},"body":"The property is a String representing the authentication mode to be used by the protobuf protocol. It currently has two valid settings. The protobuf in the name refers to the new client protocol (which we're calling the protobuf protocol).\r\n\r\nI don't think we're quite ready to take the feature flag out yet, but we should consider it as this feature nears alpha. Or moving the feature flag to a better config mechanism (DistributionConfig), so that this property and that one are in approximately the same place.","created_at":"2017-08-14T05:57:51Z","updated_at":"2017-08-14T05:57:51Z","html_url":"https://github.com/apache/geode/pull/707#discussion_r132877993","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/707","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/132877993"},"html":{"href":"https://github.com/apache/geode/pull/707#discussion_r132877993"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/707"}}},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/707","id":135189794,"html_url":"https://github.com/apache/geode/pull/707","diff_url":"https://github.com/apache/geode/pull/707.diff","patch_url":"https://github.com/apache/geode/pull/707.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/707","number":707,"state":"open","locked":false,"title":"GEODE-3412: Add simple authentication flow to protobuf protocol.","user":{"login":"WireBaron","id":16887862,"avatar_url":"https://avatars3.githubusercontent.com/u/16887862?v=4","gravatar_id":"","url":"https://api.github.com/users/WireBaron","html_url":"https://github.com/WireBaron","followers_url":"https://api.github.com/users/WireBaron/followers","following_url":"https://api.github.com/users/WireBaron/following{/other_user}","gists_url":"https://api.github.com/users/WireBaron/gists{/gist_id}","starred_url":"https://api.github.com/users/WireBaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WireBaron/subscriptions","organizations_url":"https://api.github.com/users/WireBaron/orgs","repos_url":"https://api.github.com/users/WireBaron/repos","events_url":"https://api.github.com/users/WireBaron/events{/privacy}","received_events_url":"https://api.github.com/users/WireBaron/received_events","type":"User","site_admin":false},"body":"@pivotal-amurmann @galen-pivotal @kohlmu-pivotal @bschuchardt @hiteshk25 \r\n\r\nThis change adds a simple username/password validation to the protobuf protocol.\r\nIt also adds a new configuration parameter to specify the type of authentication required.\r\n\r\nSigned-off-by: Galen O'Sullivan <gosullivan@pivotal.io>\r\n\r\nThank you for submitting a contribution to Apache Geode.\r\n\r\nIn order to streamline the review of the contribution we ask you\r\nto ensure the following steps have been taken:\r\n\r\n### For all changes:\r\n- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?\r\n\r\n- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?\r\n\r\n- [x] Is your initial contribution a single, squashed commit?\r\n\r\n- [x] Does `gradlew build` run cleanly?\r\n\r\n- [x] Have you written or updated unit tests to verify your changes?\r\n\r\n- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?\r\n\r\n### Note:\r\nPlease ensure that once the PR is submitted, you check travis-ci for build issues and\r\nsubmit an update to your PR as soon as possible. If you need help, please send an\r\nemail to dev@geode.apache.org.\r\n","created_at":"2017-08-10T18:19:52Z","updated_at":"2017-08-14T05:57:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a663ab9eac7264abd3cf77231bda1bab234f7b0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/707/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/707/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/707/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/daa140875c4f65838dde4ae0f627a9551bea7516","head":{"label":"WireBaron:feature/GEODE-3412","ref":"feature/GEODE-3412","sha":"daa140875c4f65838dde4ae0f627a9551bea7516","user":{"login":"WireBaron","id":16887862,"avatar_url":"https://avatars3.githubusercontent.com/u/16887862?v=4","gravatar_id":"","url":"https://api.github.com/users/WireBaron","html_url":"https://github.com/WireBaron","followers_url":"https://api.github.com/users/WireBaron/followers","following_url":"https://api.github.com/users/WireBaron/following{/other_user}","gists_url":"https://api.github.com/users/WireBaron/gists{/gist_id}","starred_url":"https://api.github.com/users/WireBaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WireBaron/subscriptions","organizations_url":"https://api.github.com/users/WireBaron/orgs","repos_url":"https://api.github.com/users/WireBaron/repos","events_url":"https://api.github.com/users/WireBaron/events{/privacy}","received_events_url":"https://api.github.com/users/WireBaron/received_events","type":"User","site_admin":false},"repo":{"id":93657146,"name":"geode","full_name":"WireBaron/geode","owner":{"login":"WireBaron","id":16887862,"avatar_url":"https://avatars3.githubusercontent.com/u/16887862?v=4","gravatar_id":"","url":"https://api.github.com/users/WireBaron","html_url":"https://github.com/WireBaron","followers_url":"https://api.github.com/users/WireBaron/followers","following_url":"https://api.github.com/users/WireBaron/following{/other_user}","gists_url":"https://api.github.com/users/WireBaron/gists{/gist_id}","starred_url":"https://api.github.com/users/WireBaron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WireBaron/subscriptions","organizations_url":"https://api.github.com/users/WireBaron/orgs","repos_url":"https://api.github.com/users/WireBaron/repos","events_url":"https://api.github.com/users/WireBaron/events{/privacy}","received_events_url":"https://api.github.com/users/WireBaron/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/WireBaron/geode","description":"Mirror of Apache Geode","fork":true,"url":"https://api.github.com/repos/WireBaron/geode","forks_url":"https://api.github.com/repos/WireBaron/geode/forks","keys_url":"https://api.github.com/repos/WireBaron/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WireBaron/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WireBaron/geode/teams","hooks_url":"https://api.github.com/repos/WireBaron/geode/hooks","issue_events_url":"https://api.github.com/repos/WireBaron/geode/issues/events{/number}","events_url":"https://api.github.com/repos/WireBaron/geode/events","assignees_url":"https://api.github.com/repos/WireBaron/geode/assignees{/user}","branches_url":"https://api.github.com/repos/WireBaron/geode/branches{/branch}","tags_url":"https://api.github.com/repos/WireBaron/geode/tags","blobs_url":"https://api.github.com/repos/WireBaron/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WireBaron/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WireBaron/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/WireBaron/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WireBaron/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/WireBaron/geode/languages","stargazers_url":"https://api.github.com/repos/WireBaron/geode/stargazers","contributors_url":"https://api.github.com/repos/WireBaron/geode/contributors","subscribers_url":"https://api.github.com/repos/WireBaron/geode/subscribers","subscription_url":"https://api.github.com/repos/WireBaron/geode/subscription","commits_url":"https://api.github.com/repos/WireBaron/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/WireBaron/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/WireBaron/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/WireBaron/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/WireBaron/geode/contents/{+path}","compare_url":"https://api.github.com/repos/WireBaron/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WireBaron/geode/merges","archive_url":"https://api.github.com/repos/WireBaron/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WireBaron/geode/downloads","issues_url":"https://api.github.com/repos/WireBaron/geode/issues{/number}","pulls_url":"https://api.github.com/repos/WireBaron/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/WireBaron/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/WireBaron/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WireBaron/geode/labels{/name}","releases_url":"https://api.github.com/repos/WireBaron/geode/releases{/id}","deployments_url":"https://api.github.com/repos/WireBaron/geode/deployments","created_at":"2017-06-07T16:36:46Z","updated_at":"2017-06-07T16:37:02Z","pushed_at":"2017-08-10T18:18:23Z","git_url":"git://github.com/WireBaron/geode.git","ssh_url":"git@github.com:WireBaron/geode.git","clone_url":"https://github.com/WireBaron/geode.git","svn_url":"https://github.com/WireBaron/geode","homepage":"","size":134566,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"08154dd7731910803aa5eb2caf0e284b3a239755","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Mirror of Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2017-08-14T03:43:32Z","pushed_at":"2017-08-13T22:36:48Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":134413,"stargazers_count":1029,"watchers_count":1029,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":375,"mirror_url":"git://git.apache.org/geode.git","open_issues_count":23,"forks":375,"open_issues":23,"watchers":1029,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/707"},"html":{"href":"https://github.com/apache/geode/pull/707"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/707"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/707/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/707/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/707/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/daa140875c4f65838dde4ae0f627a9551bea7516"}}}}
{"actor":{"display_login":"galen-pivotal"}}