{"action":"created","comment":{"url":"https://api.github.com/repos/coala/coala/pulls/comments/100739761","pull_request_review_id":21452951,"id":100739761,"diff_hunk":"@@ -89,7 +89,35 @@ def end(self):\n         return self._end\n \n     def overlaps(self, other):\n-        return self.start <= other.end and self.end >= other.start\n+        first = False  # check for left boundary overlap\n+        # self.start <= other.end\n+\n+        second = False  # check for right boundary overlap\n+        # self.end >= other.start","path":"coalib/results/TextRange.py","position":9,"original_position":9,"commit_id":"449d5c218b2dbd0757803ecac5faa387cfd602f5","original_commit_id":"6dce30df4465d9dd2835bf6e2a4e54a1f293664a","user":{"login":"sils","id":5716520,"avatar_url":"https://avatars.githubusercontent.com/u/5716520?v=3","gravatar_id":"","url":"https://api.github.com/users/sils","html_url":"https://github.com/sils","followers_url":"https://api.github.com/users/sils/followers","following_url":"https://api.github.com/users/sils/following{/other_user}","gists_url":"https://api.github.com/users/sils/gists{/gist_id}","starred_url":"https://api.github.com/users/sils/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sils/subscriptions","organizations_url":"https://api.github.com/users/sils/orgs","repos_url":"https://api.github.com/users/sils/repos","events_url":"https://api.github.com/users/sils/events{/privacy}","received_events_url":"https://api.github.com/users/sils/received_events","type":"User","site_admin":false},"body":"@aptrishu usually the best thing in those cases is better variable names","created_at":"2017-02-13T08:02:51Z","updated_at":"2017-02-13T08:02:51Z","html_url":"https://github.com/coala/coala/pull/3675#discussion_r100739761","pull_request_url":"https://api.github.com/repos/coala/coala/pulls/3675","_links":{"self":{"href":"https://api.github.com/repos/coala/coala/pulls/comments/100739761"},"html":{"href":"https://github.com/coala/coala/pull/3675#discussion_r100739761"},"pull_request":{"href":"https://api.github.com/repos/coala/coala/pulls/3675"}}},"pull_request":{"url":"https://api.github.com/repos/coala/coala/pulls/3675","id":104239885,"html_url":"https://github.com/coala/coala/pull/3675","diff_url":"https://github.com/coala/coala/pull/3675.diff","patch_url":"https://github.com/coala/coala/pull/3675.patch","issue_url":"https://api.github.com/repos/coala/coala/issues/3675","number":3675,"state":"open","locked":false,"title":"TextRange.py: Modify overlaps()","user":{"login":"aptrishu","id":22702242,"avatar_url":"https://avatars.githubusercontent.com/u/22702242?v=3","gravatar_id":"","url":"https://api.github.com/users/aptrishu","html_url":"https://github.com/aptrishu","followers_url":"https://api.github.com/users/aptrishu/followers","following_url":"https://api.github.com/users/aptrishu/following{/other_user}","gists_url":"https://api.github.com/users/aptrishu/gists{/gist_id}","starred_url":"https://api.github.com/users/aptrishu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptrishu/subscriptions","organizations_url":"https://api.github.com/users/aptrishu/orgs","repos_url":"https://api.github.com/users/aptrishu/repos","events_url":"https://api.github.com/users/aptrishu/events{/privacy}","received_events_url":"https://api.github.com/users/aptrishu/received_events","type":"User","site_admin":false},"body":"It modifies overlaps() method in TextRange.py\r\nto explicitly check for None values.\r\nAlso, It adds overlaps method in SourceRange.py.\r\n\r\nFixes https://github.com/coala/coala/issues/3094\r\n\r\n<!--\r\nThanks for your contribution!\r\n\r\nReviewing pull requests takes a lot of time and we're all volunteers. Please make sure you go through the following checklist and all items before pinging someone for a review.\r\n-->\r\n\r\n### Checklist\r\n\r\n- [x] I have rebased properly. Please see [our tutorial on rebasing](http://coala.io/git#rebasing).\r\n- [x] I have gone through the [commit guidelines](http://coala.io/commit) and I've followed them.\r\n- [x] I have followed the [guidelines for the commit shortlog](http://coala.io/commit#shortlog).\r\n- [x] I have followed the [guidelines for the commit body](http://coala.io/commit#commit-body).\r\n- [x] I have included the issue URL with the 'Fixes' keyword if the commit fixes a *real bug* and the 'Closes' keyword if it adds a feature or enhancement. For details, check the [issue reference section in our commit guidelines](http://coala.io/commit#issue-reference).\r\n- [x] I have [run all the tests](http://api.coala.io/en/latest/Developers/Executing_Tests.html) and they all pass. If any CI (below) is not green, please fix them. If GitMate issues appear you will have to amend your commits, pushing new commits on top is not sufficient!\r\n\r\n**After you submit your pull request, DO NOT click the 'Update Branch' button**\r\n\r\n### Reviewers\r\n\r\n<!--\r\nPlease list the Github handles of people you think susceptible to review this PR. Feel free to leave this section blank if you don't know who to tag.\r\n-->\r\n\r\n<!--\r\nEnd note:\r\n\r\nAs you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well!\r\n-->\r\n","created_at":"2017-02-01T22:49:51Z","updated_at":"2017-02-13T08:02:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8fe69823f0fc4f51bb2dd502a276b877ae7a22e6","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/coala/coala/pulls/3675/commits","review_comments_url":"https://api.github.com/repos/coala/coala/pulls/3675/comments","review_comment_url":"https://api.github.com/repos/coala/coala/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coala/coala/issues/3675/comments","statuses_url":"https://api.github.com/repos/coala/coala/statuses/449d5c218b2dbd0757803ecac5faa387cfd602f5","head":{"label":"aptrishu:issue3094","ref":"issue3094","sha":"449d5c218b2dbd0757803ecac5faa387cfd602f5","user":{"login":"aptrishu","id":22702242,"avatar_url":"https://avatars.githubusercontent.com/u/22702242?v=3","gravatar_id":"","url":"https://api.github.com/users/aptrishu","html_url":"https://github.com/aptrishu","followers_url":"https://api.github.com/users/aptrishu/followers","following_url":"https://api.github.com/users/aptrishu/following{/other_user}","gists_url":"https://api.github.com/users/aptrishu/gists{/gist_id}","starred_url":"https://api.github.com/users/aptrishu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptrishu/subscriptions","organizations_url":"https://api.github.com/users/aptrishu/orgs","repos_url":"https://api.github.com/users/aptrishu/repos","events_url":"https://api.github.com/users/aptrishu/events{/privacy}","received_events_url":"https://api.github.com/users/aptrishu/received_events","type":"User","site_admin":false},"repo":{"id":70317856,"name":"coala","full_name":"aptrishu/coala","owner":{"login":"aptrishu","id":22702242,"avatar_url":"https://avatars.githubusercontent.com/u/22702242?v=3","gravatar_id":"","url":"https://api.github.com/users/aptrishu","html_url":"https://github.com/aptrishu","followers_url":"https://api.github.com/users/aptrishu/followers","following_url":"https://api.github.com/users/aptrishu/following{/other_user}","gists_url":"https://api.github.com/users/aptrishu/gists{/gist_id}","starred_url":"https://api.github.com/users/aptrishu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aptrishu/subscriptions","organizations_url":"https://api.github.com/users/aptrishu/orgs","repos_url":"https://api.github.com/users/aptrishu/repos","events_url":"https://api.github.com/users/aptrishu/events{/privacy}","received_events_url":"https://api.github.com/users/aptrishu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aptrishu/coala","description":"coala provides a unified command-line interface for linting and fixing all your code, regardless of the programming languages you use.","fork":true,"url":"https://api.github.com/repos/aptrishu/coala","forks_url":"https://api.github.com/repos/aptrishu/coala/forks","keys_url":"https://api.github.com/repos/aptrishu/coala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aptrishu/coala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aptrishu/coala/teams","hooks_url":"https://api.github.com/repos/aptrishu/coala/hooks","issue_events_url":"https://api.github.com/repos/aptrishu/coala/issues/events{/number}","events_url":"https://api.github.com/repos/aptrishu/coala/events","assignees_url":"https://api.github.com/repos/aptrishu/coala/assignees{/user}","branches_url":"https://api.github.com/repos/aptrishu/coala/branches{/branch}","tags_url":"https://api.github.com/repos/aptrishu/coala/tags","blobs_url":"https://api.github.com/repos/aptrishu/coala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aptrishu/coala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aptrishu/coala/git/refs{/sha}","trees_url":"https://api.github.com/repos/aptrishu/coala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aptrishu/coala/statuses/{sha}","languages_url":"https://api.github.com/repos/aptrishu/coala/languages","stargazers_url":"https://api.github.com/repos/aptrishu/coala/stargazers","contributors_url":"https://api.github.com/repos/aptrishu/coala/contributors","subscribers_url":"https://api.github.com/repos/aptrishu/coala/subscribers","subscription_url":"https://api.github.com/repos/aptrishu/coala/subscription","commits_url":"https://api.github.com/repos/aptrishu/coala/commits{/sha}","git_commits_url":"https://api.github.com/repos/aptrishu/coala/git/commits{/sha}","comments_url":"https://api.github.com/repos/aptrishu/coala/comments{/number}","issue_comment_url":"https://api.github.com/repos/aptrishu/coala/issues/comments{/number}","contents_url":"https://api.github.com/repos/aptrishu/coala/contents/{+path}","compare_url":"https://api.github.com/repos/aptrishu/coala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aptrishu/coala/merges","archive_url":"https://api.github.com/repos/aptrishu/coala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aptrishu/coala/downloads","issues_url":"https://api.github.com/repos/aptrishu/coala/issues{/number}","pulls_url":"https://api.github.com/repos/aptrishu/coala/pulls{/number}","milestones_url":"https://api.github.com/repos/aptrishu/coala/milestones{/number}","notifications_url":"https://api.github.com/repos/aptrishu/coala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aptrishu/coala/labels{/name}","releases_url":"https://api.github.com/repos/aptrishu/coala/releases{/id}","deployments_url":"https://api.github.com/repos/aptrishu/coala/deployments","created_at":"2016-10-08T08:47:48Z","updated_at":"2016-10-08T08:47:49Z","pushed_at":"2017-02-11T21:51:28Z","git_url":"git://github.com/aptrishu/coala.git","ssh_url":"git@github.com:aptrishu/coala.git","clone_url":"https://github.com/aptrishu/coala.git","svn_url":"https://github.com/aptrishu/coala","homepage":"https://coala.io/","size":11048,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coala:master","ref":"master","sha":"575250a418e0e8c6e7af8f6d8350314de5fe08bb","user":{"login":"coala","id":10620750,"avatar_url":"https://avatars.githubusercontent.com/u/10620750?v=3","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"repo":{"id":19816973,"name":"coala","full_name":"coala/coala","owner":{"login":"coala","id":10620750,"avatar_url":"https://avatars.githubusercontent.com/u/10620750?v=3","gravatar_id":"","url":"https://api.github.com/users/coala","html_url":"https://github.com/coala","followers_url":"https://api.github.com/users/coala/followers","following_url":"https://api.github.com/users/coala/following{/other_user}","gists_url":"https://api.github.com/users/coala/gists{/gist_id}","starred_url":"https://api.github.com/users/coala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coala/subscriptions","organizations_url":"https://api.github.com/users/coala/orgs","repos_url":"https://api.github.com/users/coala/repos","events_url":"https://api.github.com/users/coala/events{/privacy}","received_events_url":"https://api.github.com/users/coala/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coala/coala","description":"coala provides a unified command-line interface for linting and fixing all your code, regardless of the programming languages you use.","fork":false,"url":"https://api.github.com/repos/coala/coala","forks_url":"https://api.github.com/repos/coala/coala/forks","keys_url":"https://api.github.com/repos/coala/coala/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coala/coala/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coala/coala/teams","hooks_url":"https://api.github.com/repos/coala/coala/hooks","issue_events_url":"https://api.github.com/repos/coala/coala/issues/events{/number}","events_url":"https://api.github.com/repos/coala/coala/events","assignees_url":"https://api.github.com/repos/coala/coala/assignees{/user}","branches_url":"https://api.github.com/repos/coala/coala/branches{/branch}","tags_url":"https://api.github.com/repos/coala/coala/tags","blobs_url":"https://api.github.com/repos/coala/coala/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coala/coala/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coala/coala/git/refs{/sha}","trees_url":"https://api.github.com/repos/coala/coala/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coala/coala/statuses/{sha}","languages_url":"https://api.github.com/repos/coala/coala/languages","stargazers_url":"https://api.github.com/repos/coala/coala/stargazers","contributors_url":"https://api.github.com/repos/coala/coala/contributors","subscribers_url":"https://api.github.com/repos/coala/coala/subscribers","subscription_url":"https://api.github.com/repos/coala/coala/subscription","commits_url":"https://api.github.com/repos/coala/coala/commits{/sha}","git_commits_url":"https://api.github.com/repos/coala/coala/git/commits{/sha}","comments_url":"https://api.github.com/repos/coala/coala/comments{/number}","issue_comment_url":"https://api.github.com/repos/coala/coala/issues/comments{/number}","contents_url":"https://api.github.com/repos/coala/coala/contents/{+path}","compare_url":"https://api.github.com/repos/coala/coala/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coala/coala/merges","archive_url":"https://api.github.com/repos/coala/coala/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coala/coala/downloads","issues_url":"https://api.github.com/repos/coala/coala/issues{/number}","pulls_url":"https://api.github.com/repos/coala/coala/pulls{/number}","milestones_url":"https://api.github.com/repos/coala/coala/milestones{/number}","notifications_url":"https://api.github.com/repos/coala/coala/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coala/coala/labels{/name}","releases_url":"https://api.github.com/repos/coala/coala/releases{/id}","deployments_url":"https://api.github.com/repos/coala/coala/deployments","created_at":"2014-05-15T11:35:34Z","updated_at":"2017-02-13T06:26:06Z","pushed_at":"2017-02-13T05:10:19Z","git_url":"git://github.com/coala/coala.git","ssh_url":"git@github.com:coala/coala.git","clone_url":"https://github.com/coala/coala.git","svn_url":"https://github.com/coala/coala","homepage":"https://coala.io/","size":11232,"stargazers_count":1076,"watchers_count":1076,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":469,"mirror_url":null,"open_issues_count":432,"forks":469,"open_issues":432,"watchers":1076,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coala/coala/pulls/3675"},"html":{"href":"https://github.com/coala/coala/pull/3675"},"issue":{"href":"https://api.github.com/repos/coala/coala/issues/3675"},"comments":{"href":"https://api.github.com/repos/coala/coala/issues/3675/comments"},"review_comments":{"href":"https://api.github.com/repos/coala/coala/pulls/3675/comments"},"review_comment":{"href":"https://api.github.com/repos/coala/coala/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coala/coala/pulls/3675/commits"},"statuses":{"href":"https://api.github.com/repos/coala/coala/statuses/449d5c218b2dbd0757803ecac5faa387cfd602f5"}}}}
{"actor":{"display_login":"sils"}}