{"action":"created","comment":{"url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/comments/112360975","pull_request_review_id":33668789,"id":112360975,"diff_hunk":"@@ -14,36 +6,69 @@ protocol AccountSettingViewControllerDelegate {\n \n class AccountSettingViewController: UIViewController {\n     \n+    @IBOutlet weak var emailTextField: UITextField!\n+    @IBOutlet weak var passWordTextField: UITextField!\n+    @IBOutlet weak var doubleCheckPasswordTextField: UITextField!\n+    \n     var delegate: AccountSettingViewControllerDelegate?\n \n     override func viewDidLoad() {\n         super.viewDidLoad()\n-\n-        // Do any additional setup after loading the view.\n+        emailTextField.text = \"\"\n+        passWordTextField.text = \"\"\n+        doubleCheckPasswordTextField.text = \"\"\n     }\n \n     override func didReceiveMemoryWarning() {\n         super.didReceiveMemoryWarning()\n         // Dispose of any resources that can be recreated.\n     }\n     \n-    \n+    //閉じるボタンが押された時モーダルを閉じる\n     @IBAction func tappedCloseButton(_ sender: UIButton){\n         delegate?.closeAccountSettingView(self, didTapButton: sender)\n     }\n     \n+    //保存ボタンが押された時フォームバリデーションを実行\n     @IBAction func tappedSaveButton(_ sender: UIButton){\n-        delegate?.closeAccountSettingView(self, didTapButton: sender)\n+        if validateEmpty(), validateNotMatchPasswords(passWordTextField, doubleCheckPasswordTextField) {\n+            delegate?.closeAccountSettingView(self, didTapButton: sender)\n+        }\n     }\n \n-    /*\n-    // MARK: - Navigation\n-\n-    // In a storyboard-based application, you will often want to do a little preparation before navigation\n-    override func prepare(for segue: UIStoryboardSegue, sender: Any?) {\n-        // Get the new view controller using segue.destinationViewController.\n-        // Pass the selected object to the new view controller.\n+    //未入力のチェックを行う\n+    func validateEmpty() -> Bool{\n+        if (emailTextField.text?.isEmpty)! || (passWordTextField.text?.isEmpty)! {\n+            displayAlert(\"未入力項目があります\")\n+            return false\n+        }else{\n+            return true\n+        }","path":"book_manager_v1/AccountSettingViewController.swift","position":64,"original_position":64,"commit_id":"6fa37ace553c4758463b49a90ac504d2b2e0896d","original_commit_id":"6fa37ace553c4758463b49a90ac504d2b2e0896d","user":{"login":"miyoshi-cq","id":10803556,"avatar_url":"https://avatars3.githubusercontent.com/u/10803556?v=3","gravatar_id":"","url":"https://api.github.com/users/miyoshi-cq","html_url":"https://github.com/miyoshi-cq","followers_url":"https://api.github.com/users/miyoshi-cq/followers","following_url":"https://api.github.com/users/miyoshi-cq/following{/other_user}","gists_url":"https://api.github.com/users/miyoshi-cq/gists{/gist_id}","starred_url":"https://api.github.com/users/miyoshi-cq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miyoshi-cq/subscriptions","organizations_url":"https://api.github.com/users/miyoshi-cq/orgs","repos_url":"https://api.github.com/users/miyoshi-cq/repos","events_url":"https://api.github.com/users/miyoshi-cq/events{/privacy}","received_events_url":"https://api.github.com/users/miyoshi-cq/received_events","type":"User","site_admin":false},"body":"早期リターン","created_at":"2017-04-20T03:54:04Z","updated_at":"2017-04-20T04:03:00Z","html_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS/pull/1#discussion_r112360975","pull_request_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/1","_links":{"self":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/comments/112360975"},"html":{"href":"https://github.com/hkomatsushiro-cq/BookManagerIOS/pull/1#discussion_r112360975"},"pull_request":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/1","id":115884907,"html_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS/pull/1","diff_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS/pull/1.diff","patch_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS/pull/1.patch","issue_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues/1","number":1,"state":"open","locked":false,"title":"UI実装","user":{"login":"Komatsushiro","id":20163753,"avatar_url":"https://avatars2.githubusercontent.com/u/20163753?v=3","gravatar_id":"","url":"https://api.github.com/users/Komatsushiro","html_url":"https://github.com/Komatsushiro","followers_url":"https://api.github.com/users/Komatsushiro/followers","following_url":"https://api.github.com/users/Komatsushiro/following{/other_user}","gists_url":"https://api.github.com/users/Komatsushiro/gists{/gist_id}","starred_url":"https://api.github.com/users/Komatsushiro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Komatsushiro/subscriptions","organizations_url":"https://api.github.com/users/Komatsushiro/orgs","repos_url":"https://api.github.com/users/Komatsushiro/repos","events_url":"https://api.github.com/users/Komatsushiro/events{/privacy}","received_events_url":"https://api.github.com/users/Komatsushiro/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-04-14T05:08:58Z","updated_at":"2017-04-20T04:03:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"563ca6a3c8991f4ae0d6bda9be81860c4271e201","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/1/commits","review_comments_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/1/comments","review_comment_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues/1/comments","statuses_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/statuses/6fa37ace553c4758463b49a90ac504d2b2e0896d","head":{"label":"hkomatsushiro-cq:UI","ref":"UI","sha":"6fa37ace553c4758463b49a90ac504d2b2e0896d","user":{"login":"hkomatsushiro-cq","id":26862178,"avatar_url":"https://avatars1.githubusercontent.com/u/26862178?v=3","gravatar_id":"","url":"https://api.github.com/users/hkomatsushiro-cq","html_url":"https://github.com/hkomatsushiro-cq","followers_url":"https://api.github.com/users/hkomatsushiro-cq/followers","following_url":"https://api.github.com/users/hkomatsushiro-cq/following{/other_user}","gists_url":"https://api.github.com/users/hkomatsushiro-cq/gists{/gist_id}","starred_url":"https://api.github.com/users/hkomatsushiro-cq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkomatsushiro-cq/subscriptions","organizations_url":"https://api.github.com/users/hkomatsushiro-cq/orgs","repos_url":"https://api.github.com/users/hkomatsushiro-cq/repos","events_url":"https://api.github.com/users/hkomatsushiro-cq/events{/privacy}","received_events_url":"https://api.github.com/users/hkomatsushiro-cq/received_events","type":"User","site_admin":false},"repo":{"id":87420909,"name":"BookManagerIOS","full_name":"hkomatsushiro-cq/BookManagerIOS","owner":{"login":"hkomatsushiro-cq","id":26862178,"avatar_url":"https://avatars1.githubusercontent.com/u/26862178?v=3","gravatar_id":"","url":"https://api.github.com/users/hkomatsushiro-cq","html_url":"https://github.com/hkomatsushiro-cq","followers_url":"https://api.github.com/users/hkomatsushiro-cq/followers","following_url":"https://api.github.com/users/hkomatsushiro-cq/following{/other_user}","gists_url":"https://api.github.com/users/hkomatsushiro-cq/gists{/gist_id}","starred_url":"https://api.github.com/users/hkomatsushiro-cq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkomatsushiro-cq/subscriptions","organizations_url":"https://api.github.com/users/hkomatsushiro-cq/orgs","repos_url":"https://api.github.com/users/hkomatsushiro-cq/repos","events_url":"https://api.github.com/users/hkomatsushiro-cq/events{/privacy}","received_events_url":"https://api.github.com/users/hkomatsushiro-cq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS","description":null,"fork":false,"url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS","forks_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/forks","keys_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/teams","hooks_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/hooks","issue_events_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues/events{/number}","events_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/events","assignees_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/assignees{/user}","branches_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/branches{/branch}","tags_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/tags","blobs_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/statuses/{sha}","languages_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/languages","stargazers_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/stargazers","contributors_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/contributors","subscribers_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/subscribers","subscription_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/subscription","commits_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/contents/{+path}","compare_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/merges","archive_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/downloads","issues_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues{/number}","pulls_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls{/number}","milestones_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/milestones{/number}","notifications_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/labels{/name}","releases_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/releases{/id}","deployments_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/deployments","created_at":"2017-04-06T11:19:26Z","updated_at":"2017-04-06T11:39:32Z","pushed_at":"2017-04-20T01:08:17Z","git_url":"git://github.com/hkomatsushiro-cq/BookManagerIOS.git","ssh_url":"git@github.com:hkomatsushiro-cq/BookManagerIOS.git","clone_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS.git","svn_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS","homepage":null,"size":37324,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hkomatsushiro-cq:master","ref":"master","sha":"949bd29124057cb98a7008d8a7a52a9de5691c9a","user":{"login":"hkomatsushiro-cq","id":26862178,"avatar_url":"https://avatars1.githubusercontent.com/u/26862178?v=3","gravatar_id":"","url":"https://api.github.com/users/hkomatsushiro-cq","html_url":"https://github.com/hkomatsushiro-cq","followers_url":"https://api.github.com/users/hkomatsushiro-cq/followers","following_url":"https://api.github.com/users/hkomatsushiro-cq/following{/other_user}","gists_url":"https://api.github.com/users/hkomatsushiro-cq/gists{/gist_id}","starred_url":"https://api.github.com/users/hkomatsushiro-cq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkomatsushiro-cq/subscriptions","organizations_url":"https://api.github.com/users/hkomatsushiro-cq/orgs","repos_url":"https://api.github.com/users/hkomatsushiro-cq/repos","events_url":"https://api.github.com/users/hkomatsushiro-cq/events{/privacy}","received_events_url":"https://api.github.com/users/hkomatsushiro-cq/received_events","type":"User","site_admin":false},"repo":{"id":87420909,"name":"BookManagerIOS","full_name":"hkomatsushiro-cq/BookManagerIOS","owner":{"login":"hkomatsushiro-cq","id":26862178,"avatar_url":"https://avatars1.githubusercontent.com/u/26862178?v=3","gravatar_id":"","url":"https://api.github.com/users/hkomatsushiro-cq","html_url":"https://github.com/hkomatsushiro-cq","followers_url":"https://api.github.com/users/hkomatsushiro-cq/followers","following_url":"https://api.github.com/users/hkomatsushiro-cq/following{/other_user}","gists_url":"https://api.github.com/users/hkomatsushiro-cq/gists{/gist_id}","starred_url":"https://api.github.com/users/hkomatsushiro-cq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hkomatsushiro-cq/subscriptions","organizations_url":"https://api.github.com/users/hkomatsushiro-cq/orgs","repos_url":"https://api.github.com/users/hkomatsushiro-cq/repos","events_url":"https://api.github.com/users/hkomatsushiro-cq/events{/privacy}","received_events_url":"https://api.github.com/users/hkomatsushiro-cq/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS","description":null,"fork":false,"url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS","forks_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/forks","keys_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/teams","hooks_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/hooks","issue_events_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues/events{/number}","events_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/events","assignees_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/assignees{/user}","branches_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/branches{/branch}","tags_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/tags","blobs_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/statuses/{sha}","languages_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/languages","stargazers_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/stargazers","contributors_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/contributors","subscribers_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/subscribers","subscription_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/subscription","commits_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/contents/{+path}","compare_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/merges","archive_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/downloads","issues_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues{/number}","pulls_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls{/number}","milestones_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/milestones{/number}","notifications_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/labels{/name}","releases_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/releases{/id}","deployments_url":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/deployments","created_at":"2017-04-06T11:19:26Z","updated_at":"2017-04-06T11:39:32Z","pushed_at":"2017-04-20T01:08:17Z","git_url":"git://github.com/hkomatsushiro-cq/BookManagerIOS.git","ssh_url":"git@github.com:hkomatsushiro-cq/BookManagerIOS.git","clone_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS.git","svn_url":"https://github.com/hkomatsushiro-cq/BookManagerIOS","homepage":null,"size":37324,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/1"},"html":{"href":"https://github.com/hkomatsushiro-cq/BookManagerIOS/pull/1"},"issue":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues/1"},"comments":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/hkomatsushiro-cq/BookManagerIOS/statuses/6fa37ace553c4758463b49a90ac504d2b2e0896d"}}}}
{"actor":{"display_login":"miyoshi-cq"}}