{"action":"created","issue":{"url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/issues/4","repository_url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter","labels_url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/issues/4/comments","events_url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/issues/4/events","html_url":"https://github.com/phpbb-de/phpbb-ext-newsletter/pull/4","id":252062287,"number":4,"title":"Fixes typo in readme.md for travis-ci-build-status link","user":{"login":"Crizz0","id":1311778,"avatar_url":"https://avatars2.githubusercontent.com/u/1311778?v=4","gravatar_id":"","url":"https://api.github.com/users/Crizz0","html_url":"https://github.com/Crizz0","followers_url":"https://api.github.com/users/Crizz0/followers","following_url":"https://api.github.com/users/Crizz0/following{/other_user}","gists_url":"https://api.github.com/users/Crizz0/gists{/gist_id}","starred_url":"https://api.github.com/users/Crizz0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Crizz0/subscriptions","organizations_url":"https://api.github.com/users/Crizz0/orgs","repos_url":"https://api.github.com/users/Crizz0/repos","events_url":"https://api.github.com/users/Crizz0/events{/privacy}","received_events_url":"https://api.github.com/users/Crizz0/received_events","type":"User","site_admin":false},"labels":[{"id":557178224,"url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":674332059,"url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/labels/WIP","name":"WIP","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-08-22T19:21:48Z","updated_at":"2017-08-22T22:57:36Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/pulls/4","html_url":"https://github.com/phpbb-de/phpbb-ext-newsletter/pull/4","diff_url":"https://github.com/phpbb-de/phpbb-ext-newsletter/pull/4.diff","patch_url":"https://github.com/phpbb-de/phpbb-ext-newsletter/pull/4.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/issues/comments/324174346","html_url":"https://github.com/phpbb-de/phpbb-ext-newsletter/pull/4#issuecomment-324174346","issue_url":"https://api.github.com/repos/phpbb-de/phpbb-ext-newsletter/issues/4","id":324174346,"user":{"login":"gn36","id":607501,"avatar_url":"https://avatars2.githubusercontent.com/u/607501?v=4","gravatar_id":"","url":"https://api.github.com/users/gn36","html_url":"https://github.com/gn36","followers_url":"https://api.github.com/users/gn36/followers","following_url":"https://api.github.com/users/gn36/following{/other_user}","gists_url":"https://api.github.com/users/gn36/gists{/gist_id}","starred_url":"https://api.github.com/users/gn36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gn36/subscriptions","organizations_url":"https://api.github.com/users/gn36/orgs","repos_url":"https://api.github.com/users/gn36/repos","events_url":"https://api.github.com/users/gn36/events{/privacy}","received_events_url":"https://api.github.com/users/gn36/received_events","type":"User","site_admin":false},"created_at":"2017-08-22T22:57:36Z","updated_at":"2017-08-22T22:57:36Z","body":"The EPV problem is a result of this commit to phpbb/epv: https://github.com/phpbb/epv/commit/21f7608180175087acd2d37af100d56a41699ba5\r\n\r\nIt does not seem that the minimum version requirement is really true here, the commit simply removes older PHP Versions from the tests of the EPV (so the EPV is no longer guaranteed to work on older versions).\r\n\r\nIf we go back to a specific \"release\", this will result in a very old version of the epv (Oct. 2016 was 0.0.8).\r\n\r\nTwo solutions: \r\n1) We simply don't validate with EPV on older PHP Versions any longer, either. The EPV primarily validates the PHP Files for very basic errors and the structure of the extension. Structure does not change with PHP Version and the basic errors should also be caught with the newer versions.\r\n2) We use a version requirement of dev-master|0.0.8, optionally also allowing the older version of the EPV. This must be done in a way that if possible dev-master is installed and only the older PHP Versions use 0.0.8.\r\n\r\nI don't know if composer even allows combining branches and tags in constraints and how it behaves in this case, so I would actually prefer solution 1, even though this means we don't run the EPV with 5.4"}}
{"actor":{"display_login":"gn36"}}