{"action":"created","issue":{"url":"https://api.github.com/repos/svaarala/duktape/issues/1660","repository_url":"https://api.github.com/repos/svaarala/duktape","labels_url":"https://api.github.com/repos/svaarala/duktape/issues/1660/labels{/name}","comments_url":"https://api.github.com/repos/svaarala/duktape/issues/1660/comments","events_url":"https://api.github.com/repos/svaarala/duktape/issues/1660/events","html_url":"https://github.com/svaarala/duktape/pull/1660","id":247850737,"number":1660,"title":"Add performance.now() API and millisecond fraction support for duk_get_now()","user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars1.githubusercontent.com/u/6377415?v=4","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/svaarala/duktape/milestones/34","html_url":"https://github.com/svaarala/duktape/milestone/34","labels_url":"https://api.github.com/repos/svaarala/duktape/milestones/34/labels","id":2418161,"number":34,"title":"v2.2.0","description":"TBD","creator":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars1.githubusercontent.com/u/6377415?v=4","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":104,"state":"open","created_at":"2017-03-29T02:04:34Z","updated_at":"2017-08-03T23:08:27Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2017-08-03T22:14:09Z","updated_at":"2017-08-04T02:45:01Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/svaarala/duktape/pulls/1660","html_url":"https://github.com/svaarala/duktape/pull/1660","diff_url":"https://github.com/svaarala/duktape/pull/1660.diff","patch_url":"https://github.com/svaarala/duktape/pull/1660.patch"},"body":"- [x] Rebase\r\n- [x] Allow fractions in DUK_USE_DATE_GET_NOW() and expose them in duk_get_now() (but not for Date instances)\r\n- [x] Update DUK_USE_DATE_GET_NOW and DUK_USE_GET_MONOTONIC_TIME documentation\r\n- [x] Add fractions to POSIX/Windows DUK_USE_DATE_GET_NOW()\r\n- [x] Add performance.now()\r\n- [x] performance.timeOrigin intentionally missing for now, semantics to be decided and missing property matches earlier performance.now() spec\r\n- [x] Property attributes\r\n- [x] Maybe remove .timeOrigin altogether instead of returning 0?\r\n- [x] Website guide, custom built-ins\r\n- [x] Website guide, global binding removal note (unrelated to other changes)\r\n- [x] Website guide, clarify that other 'performance' bindings (like performance.timing) are not supported\r\n- [x] Wiki post-ES5 page, custom built-in - https://github.com/svaarala/duktape-wiki/pull/184\r\n- [x] Testcase: performance.now()\r\n- [x] Testcase: performance.timeOrigin absent\r\n- [x] Releases entry\r\n- [x] 2.2 migration note: fractions in duk_get_now()\r\n\r\nFixes #773."},"comment":{"url":"https://api.github.com/repos/svaarala/duktape/issues/comments/320141874","html_url":"https://github.com/svaarala/duktape/pull/1660#issuecomment-320141874","issue_url":"https://api.github.com/repos/svaarala/duktape/issues/1660","id":320141874,"user":{"login":"svaarala","id":6377415,"avatar_url":"https://avatars1.githubusercontent.com/u/6377415?v=4","gravatar_id":"","url":"https://api.github.com/users/svaarala","html_url":"https://github.com/svaarala","followers_url":"https://api.github.com/users/svaarala/followers","following_url":"https://api.github.com/users/svaarala/following{/other_user}","gists_url":"https://api.github.com/users/svaarala/gists{/gist_id}","starred_url":"https://api.github.com/users/svaarala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svaarala/subscriptions","organizations_url":"https://api.github.com/users/svaarala/orgs","repos_url":"https://api.github.com/users/svaarala/repos","events_url":"https://api.github.com/users/svaarala/events{/privacy}","received_events_url":"https://api.github.com/users/svaarala/received_events","type":"User","site_admin":false},"created_at":"2017-08-04T02:45:01Z","updated_at":"2017-08-04T02:45:01Z","body":"One difficult choice is whether performance.now() should be available at all if DUK_USE_GET_MONOTONIC_TIME() is not provided.\r\n\r\nTechnically the answer is clear: it shouldn't, because it won't then respect the requirements in High Resolution Time specification.\r\n\r\nBut in practice, it's probably more surprising not to have the binding, especially because DUK_USE_GET_MONOTONIC_TIME() is not provided by default (at least for now). Further, there's no other Ecmascript binding where one can get fractional milliseconds.\r\n\r\nIf all major platforms had a monotonic time provider, then it might make more sense for the binding to be absent without a monotonic time provider.\r\n\r\nSo in this pull the binding is always provided, but this can be changed later if necessary, also added to #1658 as a future work note."}}
{"actor":{"display_login":"svaarala"}}