{"action":"created","issue":{"url":"https://api.github.com/repos/p6spy/p6spy/issues/374","repository_url":"https://api.github.com/repos/p6spy/p6spy","labels_url":"https://api.github.com/repos/p6spy/p6spy/issues/374/labels{/name}","comments_url":"https://api.github.com/repos/p6spy/p6spy/issues/374/comments","events_url":"https://api.github.com/repos/p6spy/p6spy/issues/374/events","html_url":"https://github.com/p6spy/p6spy/issues/374","id":216926325,"number":374,"title":"Programmatic configuration","user":{"login":"gavlyukovskiy","id":15277543,"avatar_url":"https://avatars1.githubusercontent.com/u/15277543?v=4","gravatar_id":"","url":"https://api.github.com/users/gavlyukovskiy","html_url":"https://github.com/gavlyukovskiy","followers_url":"https://api.github.com/users/gavlyukovskiy/followers","following_url":"https://api.github.com/users/gavlyukovskiy/following{/other_user}","gists_url":"https://api.github.com/users/gavlyukovskiy/gists{/gist_id}","starred_url":"https://api.github.com/users/gavlyukovskiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gavlyukovskiy/subscriptions","organizations_url":"https://api.github.com/users/gavlyukovskiy/orgs","repos_url":"https://api.github.com/users/gavlyukovskiy/repos","events_url":"https://api.github.com/users/gavlyukovskiy/events{/privacy}","received_events_url":"https://api.github.com/users/gavlyukovskiy/received_events","type":"User","site_admin":false},"labels":[{"id":84794917,"url":"https://api.github.com/repos/p6spy/p6spy/labels/Enhancement","name":"Enhancement","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-03-24T23:13:07Z","updated_at":"2017-09-09T19:27:25Z","closed_at":"2017-09-09T19:27:25Z","author_association":"CONTRIBUTOR","body":"Are there any plans/views on the programmatic configuration?\r\n\r\nSome `JdbcEventListener` implementations may rely on the IoC container or just have dependencies that have to be created from outside a listener/factory e.g. https://github.com/openzipkin/brave/blob/master/brave-p6spy/src/main/java/com/github/kristofa/brave/p6spy/BraveP6SpyListener.java\r\nDoes it make sense to implement dynamic non-reflective registration of listeners (or make public method to register modules and maybe keep user registered modules on reload).\r\nAs I understtod `P6ModuleManager.getInstance().getFactories().add(...)` is not really correct approach.\r\n\r\nAlso it would be great to have ability to register own `P6OptionsSource` implementations."},"comment":{"url":"https://api.github.com/repos/p6spy/p6spy/issues/comments/328298534","html_url":"https://github.com/p6spy/p6spy/issues/374#issuecomment-328298534","issue_url":"https://api.github.com/repos/p6spy/p6spy/issues/374","id":328298534,"user":{"login":"typekpb","id":499820,"avatar_url":"https://avatars1.githubusercontent.com/u/499820?v=4","gravatar_id":"","url":"https://api.github.com/users/typekpb","html_url":"https://github.com/typekpb","followers_url":"https://api.github.com/users/typekpb/followers","following_url":"https://api.github.com/users/typekpb/following{/other_user}","gists_url":"https://api.github.com/users/typekpb/gists{/gist_id}","starred_url":"https://api.github.com/users/typekpb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/typekpb/subscriptions","organizations_url":"https://api.github.com/users/typekpb/orgs","repos_url":"https://api.github.com/users/typekpb/repos","events_url":"https://api.github.com/users/typekpb/events{/privacy}","received_events_url":"https://api.github.com/users/typekpb/received_events","type":"User","site_admin":false},"created_at":"2017-09-09T19:27:25Z","updated_at":"2017-09-09T19:27:25Z","author_association":"OWNER","body":"closed by #400 "}}
{"actor":{"display_login":"typekpb"}}