{"action":"created","comment":{"url":"https://api.github.com/repos/colszowka/simplecov/pulls/comments/103299939","pull_request_review_id":24082270,"id":103299939,"diff_hunk":"@@ -24,7 +24,6 @@ class Result\n     # Initialize a new SimpleCov::Result from given Coverage.result (a Hash of filenames each containing an array of\n     # coverage data)\n     def initialize(original_result)\n-      original_result = original_result.dup.extend(SimpleCov::HashMergeHelper) unless original_result.is_a? SimpleCov::HashMergeHelper\n       @original_result = original_result.freeze\n       @files = SimpleCov::FileList.new(original_result.map do |filename, coverage|","path":"lib/simplecov/result.rb","position":6,"original_position":6,"commit_id":"c7a9d82248c38a71416959ebfe4ae2e9c7842161","original_commit_id":"c7a9d82248c38a71416959ebfe4ae2e9c7842161","user":{"login":"bf4","id":142914,"avatar_url":"https://avatars.githubusercontent.com/u/142914?v=3","gravatar_id":"","url":"https://api.github.com/users/bf4","html_url":"https://github.com/bf4","followers_url":"https://api.github.com/users/bf4/followers","following_url":"https://api.github.com/users/bf4/following{/other_user}","gists_url":"https://api.github.com/users/bf4/gists{/gist_id}","starred_url":"https://api.github.com/users/bf4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bf4/subscriptions","organizations_url":"https://api.github.com/users/bf4/orgs","repos_url":"https://api.github.com/users/bf4/repos","events_url":"https://api.github.com/users/bf4/events{/privacy}","received_events_url":"https://api.github.com/users/bf4/received_events","type":"User","site_admin":false},"body":"@PragTob good to merge. The 'good for another pr', would be a way to merge files not represented on the current file system, since that's out of scope. This works fine when running on the same filesystem (or if you were to munge the paths).","created_at":"2017-02-27T20:09:40Z","updated_at":"2017-02-27T20:09:40Z","html_url":"https://github.com/colszowka/simplecov/pull/558#discussion_r103299939","pull_request_url":"https://api.github.com/repos/colszowka/simplecov/pulls/558","_links":{"self":{"href":"https://api.github.com/repos/colszowka/simplecov/pulls/comments/103299939"},"html":{"href":"https://github.com/colszowka/simplecov/pull/558#discussion_r103299939"},"pull_request":{"href":"https://api.github.com/repos/colszowka/simplecov/pulls/558"}}},"pull_request":{"url":"https://api.github.com/repos/colszowka/simplecov/pulls/558","id":106122612,"html_url":"https://github.com/colszowka/simplecov/pull/558","diff_url":"https://github.com/colszowka/simplecov/pull/558.diff","patch_url":"https://github.com/colszowka/simplecov/pull/558.patch","issue_url":"https://api.github.com/repos/colszowka/simplecov/issues/558","number":558,"state":"open","locked":false,"title":"Rewrite merge helpers to work with frozen objects","user":{"login":"aroben","id":917945,"avatar_url":"https://avatars.githubusercontent.com/u/917945?v=3","gravatar_id":"","url":"https://api.github.com/users/aroben","html_url":"https://github.com/aroben","followers_url":"https://api.github.com/users/aroben/followers","following_url":"https://api.github.com/users/aroben/following{/other_user}","gists_url":"https://api.github.com/users/aroben/gists{/gist_id}","starred_url":"https://api.github.com/users/aroben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aroben/subscriptions","organizations_url":"https://api.github.com/users/aroben/orgs","repos_url":"https://api.github.com/users/aroben/repos","events_url":"https://api.github.com/users/aroben/events{/privacy}","received_events_url":"https://api.github.com/users/aroben/received_events","type":"User","site_admin":true},"body":"`Coverage.result` returns a frozen Hash containing frozen Strings as keys and frozen Arrays as values. The existing merge helper did not work when passed a `Coverage.result` directly, because it would try to `extend` the frozen Arrays. This is not a problem in typical SimpleCov usage because usually Coverage.result has been roundtripped through `.resultset.json` resulting in an unfrozen copy. But when trying to do manual merging of `Coverage.result` hashes the use of `extend` gets in the way.\r\n\r\nThe merge helper has now been rewritten a method that takes two Hashes and doesn't modify them or their contents at all. While I was touching this code I tried to clean it up a little bit as well.","created_at":"2017-02-14T15:05:21Z","updated_at":"2017-02-27T20:09:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fd801cd22cfb35f30816126b66c7efa632aefd13","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/colszowka/simplecov/pulls/558/commits","review_comments_url":"https://api.github.com/repos/colszowka/simplecov/pulls/558/comments","review_comment_url":"https://api.github.com/repos/colszowka/simplecov/pulls/comments{/number}","comments_url":"https://api.github.com/repos/colszowka/simplecov/issues/558/comments","statuses_url":"https://api.github.com/repos/colszowka/simplecov/statuses/c7a9d82248c38a71416959ebfe4ae2e9c7842161","head":{"label":"aroben:merge-without-extend","ref":"merge-without-extend","sha":"c7a9d82248c38a71416959ebfe4ae2e9c7842161","user":{"login":"aroben","id":917945,"avatar_url":"https://avatars.githubusercontent.com/u/917945?v=3","gravatar_id":"","url":"https://api.github.com/users/aroben","html_url":"https://github.com/aroben","followers_url":"https://api.github.com/users/aroben/followers","following_url":"https://api.github.com/users/aroben/following{/other_user}","gists_url":"https://api.github.com/users/aroben/gists{/gist_id}","starred_url":"https://api.github.com/users/aroben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aroben/subscriptions","organizations_url":"https://api.github.com/users/aroben/orgs","repos_url":"https://api.github.com/users/aroben/repos","events_url":"https://api.github.com/users/aroben/events{/privacy}","received_events_url":"https://api.github.com/users/aroben/received_events","type":"User","site_admin":true},"repo":{"id":81956989,"name":"simplecov","full_name":"aroben/simplecov","owner":{"login":"aroben","id":917945,"avatar_url":"https://avatars.githubusercontent.com/u/917945?v=3","gravatar_id":"","url":"https://api.github.com/users/aroben","html_url":"https://github.com/aroben","followers_url":"https://api.github.com/users/aroben/followers","following_url":"https://api.github.com/users/aroben/following{/other_user}","gists_url":"https://api.github.com/users/aroben/gists{/gist_id}","starred_url":"https://api.github.com/users/aroben/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aroben/subscriptions","organizations_url":"https://api.github.com/users/aroben/orgs","repos_url":"https://api.github.com/users/aroben/repos","events_url":"https://api.github.com/users/aroben/events{/privacy}","received_events_url":"https://api.github.com/users/aroben/received_events","type":"User","site_admin":true},"private":false,"html_url":"https://github.com/aroben/simplecov","description":"Code coverage for Ruby 1.9+ with a powerful configuration library and automatic merging of coverage across test suites","fork":true,"url":"https://api.github.com/repos/aroben/simplecov","forks_url":"https://api.github.com/repos/aroben/simplecov/forks","keys_url":"https://api.github.com/repos/aroben/simplecov/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aroben/simplecov/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aroben/simplecov/teams","hooks_url":"https://api.github.com/repos/aroben/simplecov/hooks","issue_events_url":"https://api.github.com/repos/aroben/simplecov/issues/events{/number}","events_url":"https://api.github.com/repos/aroben/simplecov/events","assignees_url":"https://api.github.com/repos/aroben/simplecov/assignees{/user}","branches_url":"https://api.github.com/repos/aroben/simplecov/branches{/branch}","tags_url":"https://api.github.com/repos/aroben/simplecov/tags","blobs_url":"https://api.github.com/repos/aroben/simplecov/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aroben/simplecov/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aroben/simplecov/git/refs{/sha}","trees_url":"https://api.github.com/repos/aroben/simplecov/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aroben/simplecov/statuses/{sha}","languages_url":"https://api.github.com/repos/aroben/simplecov/languages","stargazers_url":"https://api.github.com/repos/aroben/simplecov/stargazers","contributors_url":"https://api.github.com/repos/aroben/simplecov/contributors","subscribers_url":"https://api.github.com/repos/aroben/simplecov/subscribers","subscription_url":"https://api.github.com/repos/aroben/simplecov/subscription","commits_url":"https://api.github.com/repos/aroben/simplecov/commits{/sha}","git_commits_url":"https://api.github.com/repos/aroben/simplecov/git/commits{/sha}","comments_url":"https://api.github.com/repos/aroben/simplecov/comments{/number}","issue_comment_url":"https://api.github.com/repos/aroben/simplecov/issues/comments{/number}","contents_url":"https://api.github.com/repos/aroben/simplecov/contents/{+path}","compare_url":"https://api.github.com/repos/aroben/simplecov/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aroben/simplecov/merges","archive_url":"https://api.github.com/repos/aroben/simplecov/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aroben/simplecov/downloads","issues_url":"https://api.github.com/repos/aroben/simplecov/issues{/number}","pulls_url":"https://api.github.com/repos/aroben/simplecov/pulls{/number}","milestones_url":"https://api.github.com/repos/aroben/simplecov/milestones{/number}","notifications_url":"https://api.github.com/repos/aroben/simplecov/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aroben/simplecov/labels{/name}","releases_url":"https://api.github.com/repos/aroben/simplecov/releases{/id}","deployments_url":"https://api.github.com/repos/aroben/simplecov/deployments","created_at":"2017-02-14T15:04:17Z","updated_at":"2017-02-14T15:04:20Z","pushed_at":"2017-02-21T16:23:04Z","git_url":"git://github.com/aroben/simplecov.git","ssh_url":"git@github.com:aroben/simplecov.git","clone_url":"https://github.com/aroben/simplecov.git","svn_url":"https://github.com/aroben/simplecov","homepage":"","size":1902,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"colszowka:master","ref":"master","sha":"3ca3141fcbb940382af607e3d43651c52da3d611","user":{"login":"colszowka","id":13972,"avatar_url":"https://avatars.githubusercontent.com/u/13972?v=3","gravatar_id":"","url":"https://api.github.com/users/colszowka","html_url":"https://github.com/colszowka","followers_url":"https://api.github.com/users/colszowka/followers","following_url":"https://api.github.com/users/colszowka/following{/other_user}","gists_url":"https://api.github.com/users/colszowka/gists{/gist_id}","starred_url":"https://api.github.com/users/colszowka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colszowka/subscriptions","organizations_url":"https://api.github.com/users/colszowka/orgs","repos_url":"https://api.github.com/users/colszowka/repos","events_url":"https://api.github.com/users/colszowka/events{/privacy}","received_events_url":"https://api.github.com/users/colszowka/received_events","type":"User","site_admin":false},"repo":{"id":839336,"name":"simplecov","full_name":"colszowka/simplecov","owner":{"login":"colszowka","id":13972,"avatar_url":"https://avatars.githubusercontent.com/u/13972?v=3","gravatar_id":"","url":"https://api.github.com/users/colszowka","html_url":"https://github.com/colszowka","followers_url":"https://api.github.com/users/colszowka/followers","following_url":"https://api.github.com/users/colszowka/following{/other_user}","gists_url":"https://api.github.com/users/colszowka/gists{/gist_id}","starred_url":"https://api.github.com/users/colszowka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colszowka/subscriptions","organizations_url":"https://api.github.com/users/colszowka/orgs","repos_url":"https://api.github.com/users/colszowka/repos","events_url":"https://api.github.com/users/colszowka/events{/privacy}","received_events_url":"https://api.github.com/users/colszowka/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/colszowka/simplecov","description":"Code coverage for Ruby 1.9+ with a powerful configuration library and automatic merging of coverage across test suites","fork":false,"url":"https://api.github.com/repos/colszowka/simplecov","forks_url":"https://api.github.com/repos/colszowka/simplecov/forks","keys_url":"https://api.github.com/repos/colszowka/simplecov/keys{/key_id}","collaborators_url":"https://api.github.com/repos/colszowka/simplecov/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/colszowka/simplecov/teams","hooks_url":"https://api.github.com/repos/colszowka/simplecov/hooks","issue_events_url":"https://api.github.com/repos/colszowka/simplecov/issues/events{/number}","events_url":"https://api.github.com/repos/colszowka/simplecov/events","assignees_url":"https://api.github.com/repos/colszowka/simplecov/assignees{/user}","branches_url":"https://api.github.com/repos/colszowka/simplecov/branches{/branch}","tags_url":"https://api.github.com/repos/colszowka/simplecov/tags","blobs_url":"https://api.github.com/repos/colszowka/simplecov/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/colszowka/simplecov/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/colszowka/simplecov/git/refs{/sha}","trees_url":"https://api.github.com/repos/colszowka/simplecov/git/trees{/sha}","statuses_url":"https://api.github.com/repos/colszowka/simplecov/statuses/{sha}","languages_url":"https://api.github.com/repos/colszowka/simplecov/languages","stargazers_url":"https://api.github.com/repos/colszowka/simplecov/stargazers","contributors_url":"https://api.github.com/repos/colszowka/simplecov/contributors","subscribers_url":"https://api.github.com/repos/colszowka/simplecov/subscribers","subscription_url":"https://api.github.com/repos/colszowka/simplecov/subscription","commits_url":"https://api.github.com/repos/colszowka/simplecov/commits{/sha}","git_commits_url":"https://api.github.com/repos/colszowka/simplecov/git/commits{/sha}","comments_url":"https://api.github.com/repos/colszowka/simplecov/comments{/number}","issue_comment_url":"https://api.github.com/repos/colszowka/simplecov/issues/comments{/number}","contents_url":"https://api.github.com/repos/colszowka/simplecov/contents/{+path}","compare_url":"https://api.github.com/repos/colszowka/simplecov/compare/{base}...{head}","merges_url":"https://api.github.com/repos/colszowka/simplecov/merges","archive_url":"https://api.github.com/repos/colszowka/simplecov/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/colszowka/simplecov/downloads","issues_url":"https://api.github.com/repos/colszowka/simplecov/issues{/number}","pulls_url":"https://api.github.com/repos/colszowka/simplecov/pulls{/number}","milestones_url":"https://api.github.com/repos/colszowka/simplecov/milestones{/number}","notifications_url":"https://api.github.com/repos/colszowka/simplecov/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/colszowka/simplecov/labels{/name}","releases_url":"https://api.github.com/repos/colszowka/simplecov/releases{/id}","deployments_url":"https://api.github.com/repos/colszowka/simplecov/deployments","created_at":"2010-08-15T15:28:56Z","updated_at":"2017-02-25T01:45:28Z","pushed_at":"2017-02-21T16:23:06Z","git_url":"git://github.com/colszowka/simplecov.git","ssh_url":"git@github.com:colszowka/simplecov.git","clone_url":"https://github.com/colszowka/simplecov.git","svn_url":"https://github.com/colszowka/simplecov","homepage":"","size":1887,"stargazers_count":2904,"watchers_count":2904,"language":"Ruby","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":301,"mirror_url":null,"open_issues_count":42,"forks":301,"open_issues":42,"watchers":2904,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/colszowka/simplecov/pulls/558"},"html":{"href":"https://github.com/colszowka/simplecov/pull/558"},"issue":{"href":"https://api.github.com/repos/colszowka/simplecov/issues/558"},"comments":{"href":"https://api.github.com/repos/colszowka/simplecov/issues/558/comments"},"review_comments":{"href":"https://api.github.com/repos/colszowka/simplecov/pulls/558/comments"},"review_comment":{"href":"https://api.github.com/repos/colszowka/simplecov/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/colszowka/simplecov/pulls/558/commits"},"statuses":{"href":"https://api.github.com/repos/colszowka/simplecov/statuses/c7a9d82248c38a71416959ebfe4ae2e9c7842161"}}}}
{"actor":{"display_login":"bf4"}}