{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/96590744","pull_request_review_id":17175783,"id":96590744,"diff_hunk":"@@ -125,108 +177,4 @@\n             </plugin>\n         </plugins>\n     </build>\n-    <profiles>\n-        <profile>\n-            <id>docbook</id>\n-            <build>\n-                <plugins>\n-                    <plugin>\n-                        <groupId>org.asciidoctor</groupId>\n-                        <artifactId>asciidoctor-maven-plugin</artifactId>\n-                        <executions>\n-                            <execution>\n-                                <id>output-docbook</id>\n-                                <phase>generate-resources</phase>\n-                                <goals>\n-                                    <goal>process-asciidoc</goal>\n-                                </goals>\n-                                <configuration>\n-                                    <backend>docbook</backend>\n-                                    <outputDirectory>target/asciidoc-docbook/en-US</outputDirectory>\n-                                    <attributes>\n-                                        <sourcedir>${basedir}/src/test/java</sourcedir>\n-                                        <engine-sourcedir>${basedir}/../engine/src/main/java</engine-sourcedir>\n-                                    </attributes>\n-                                </configuration>\n-                            </execution>\n-                        </executions>\n-                    </plugin>\n-                    <plugin>\n-                        <groupId>org.apache.maven.plugins</groupId>\n-                        <artifactId>maven-resources-plugin</artifactId>\n-                        <executions>\n-                            <execution>\n-                                <id>copy-docbook-images-to-staging</id>\n-                                <phase>generate-resources</phase>\n-                                <goals>\n-                                    <goal>copy-resources</goal>\n-                                </goals>\n-                                <configuration>\n-                                    <outputDirectory>${basedir}/target/docbook/staging/images/images</outputDirectory>\n-                                    <resources>\n-                                        <resource>\n-                                            <directory>${basedir}/src/main/asciidoc/images</directory>\n-                                        </resource>\n-                                    </resources>\n-                                </configuration>\n-                            </execution>\n-                        </executions>\n-                    </plugin>\n-                    <plugin>\n-                        <groupId>org.jboss.maven.plugins</groupId>\n-                        <artifactId>maven-jdocbook-plugin</artifactId>\n-                        <configuration>\n-                            <sourceDirectory>${basedir}/target/asciidoc-docbook</sourceDirectory>\n-                            <sourceDocumentName>index.xml</sourceDocumentName>\n-                            <masterTranslation>en-US</masterTranslation>\n-                            <formats>\n-                                <format>\n-                                    <formatName>html_single</formatName>\n-                                    <stylesheetResource>classpath:/xslt/org/hibernate/jdocbook/xslt/xhtml-single.xsl\n-                                    </stylesheetResource>\n-                                    <finalName>index.html</finalName>\n-                                </format>\n-                                <format>\n-                                    <formatName>html</formatName>\n-                                    <stylesheetResource>classpath:/xslt/org/hibernate/jdocbook/xslt/xhtml.xsl\n-                                    </stylesheetResource>\n-                                    <finalName>index.html</finalName>\n-                                </format>\n-                                <format>\n-                                    <formatName>pdf</formatName>\n-                                    <stylesheetResource>classpath:/xslt/org/hibernate/jdocbook/xslt/pdf.xsl\n-                                    </stylesheetResource>\n-                                    <finalName>hibernate_validator_reference.pdf</finalName>\n-                                </format>\n-                            </formats>\n-                            <options>\n-                                <xincludeSupported>true</xincludeSupported>\n-                                <xmlTransformerType>saxon</xmlTransformerType>\n-                                <!-- needed for uri-resolvers; can be ommitted if using 'current' uri scheme -->\n-                                <!-- could also locate the docbook dependency and inspect its version... -->\n-                                <!-- docbookVersion>1.72.0</docbookVersion -->\n-                                <localeSeparator>-</localeSeparator>\n-                                <injectionDateFormat>yyyy-MM-dd</injectionDateFormat>\n-                                <transformerParameters>","path":"documentation/pom.xml","position":152,"original_position":152,"commit_id":"46081cd11d58a6aeb6e1be13607096fd72b2fba4","original_commit_id":"46081cd11d58a6aeb6e1be13607096fd72b2fba4","user":{"login":"gunnarmorling","id":28612,"avatar_url":"https://avatars.githubusercontent.com/u/28612?v=3","gravatar_id":"","url":"https://api.github.com/users/gunnarmorling","html_url":"https://github.com/gunnarmorling","followers_url":"https://api.github.com/users/gunnarmorling/followers","following_url":"https://api.github.com/users/gunnarmorling/following{/other_user}","gists_url":"https://api.github.com/users/gunnarmorling/gists{/gist_id}","starred_url":"https://api.github.com/users/gunnarmorling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gunnarmorling/subscriptions","organizations_url":"https://api.github.com/users/gunnarmorling/orgs","repos_url":"https://api.github.com/users/gunnarmorling/repos","events_url":"https://api.github.com/users/gunnarmorling/events{/privacy}","received_events_url":"https://api.github.com/users/gunnarmorling/received_events","type":"User","site_admin":false},"body":"Cool; thanks, @ge0ffrey!","created_at":"2017-01-18T09:11:48Z","updated_at":"2017-01-18T09:11:48Z","html_url":"https://github.com/hibernate/hibernate-validator/pull/632#discussion_r96590744","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/632","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments/96590744"},"html":{"href":"https://github.com/hibernate/hibernate-validator/pull/632#discussion_r96590744"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/632"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/632","id":101929423,"html_url":"https://github.com/hibernate/hibernate-validator/pull/632","diff_url":"https://github.com/hibernate/hibernate-validator/pull/632.diff","patch_url":"https://github.com/hibernate/hibernate-validator/pull/632.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/632","number":632,"state":"open","locked":false,"title":"Switch to Asciidoctor for PDF and epub generation","user":{"login":"gsmet","id":1279749,"avatar_url":"https://avatars.githubusercontent.com/u/1279749?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"body":"If someone wants to play with it:\r\n```\r\ncd documentation\r\nmvn clean install\r\n```\r\n\r\nI also tuned the HTML output to be more practical (especially enabled section anchor and the side toc).","created_at":"2017-01-17T19:25:15Z","updated_at":"2017-01-18T09:11:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03d5eb778ac7dabfb80f4878db9e77e613d68470","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/632/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/632/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/632/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/46081cd11d58a6aeb6e1be13607096fd72b2fba4","head":{"label":"gsmet:asciidoctor-pdf-epub","ref":"asciidoctor-pdf-epub","sha":"46081cd11d58a6aeb6e1be13607096fd72b2fba4","user":{"login":"gsmet","id":1279749,"avatar_url":"https://avatars.githubusercontent.com/u/1279749?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"repo":{"id":56131797,"name":"hibernate-validator","full_name":"gsmet/hibernate-validator","owner":{"login":"gsmet","id":1279749,"avatar_url":"https://avatars.githubusercontent.com/u/1279749?v=3","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gsmet/hibernate-validator","description":"Hibernate Validator - Bean Validation 1.1 (JSR 349) Reference Implementation","fork":true,"url":"https://api.github.com/repos/gsmet/hibernate-validator","forks_url":"https://api.github.com/repos/gsmet/hibernate-validator/forks","keys_url":"https://api.github.com/repos/gsmet/hibernate-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gsmet/hibernate-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gsmet/hibernate-validator/teams","hooks_url":"https://api.github.com/repos/gsmet/hibernate-validator/hooks","issue_events_url":"https://api.github.com/repos/gsmet/hibernate-validator/issues/events{/number}","events_url":"https://api.github.com/repos/gsmet/hibernate-validator/events","assignees_url":"https://api.github.com/repos/gsmet/hibernate-validator/assignees{/user}","branches_url":"https://api.github.com/repos/gsmet/hibernate-validator/branches{/branch}","tags_url":"https://api.github.com/repos/gsmet/hibernate-validator/tags","blobs_url":"https://api.github.com/repos/gsmet/hibernate-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gsmet/hibernate-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gsmet/hibernate-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/gsmet/hibernate-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gsmet/hibernate-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/gsmet/hibernate-validator/languages","stargazers_url":"https://api.github.com/repos/gsmet/hibernate-validator/stargazers","contributors_url":"https://api.github.com/repos/gsmet/hibernate-validator/contributors","subscribers_url":"https://api.github.com/repos/gsmet/hibernate-validator/subscribers","subscription_url":"https://api.github.com/repos/gsmet/hibernate-validator/subscription","commits_url":"https://api.github.com/repos/gsmet/hibernate-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/gsmet/hibernate-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/gsmet/hibernate-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/gsmet/hibernate-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/gsmet/hibernate-validator/contents/{+path}","compare_url":"https://api.github.com/repos/gsmet/hibernate-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gsmet/hibernate-validator/merges","archive_url":"https://api.github.com/repos/gsmet/hibernate-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gsmet/hibernate-validator/downloads","issues_url":"https://api.github.com/repos/gsmet/hibernate-validator/issues{/number}","pulls_url":"https://api.github.com/repos/gsmet/hibernate-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/gsmet/hibernate-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/gsmet/hibernate-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gsmet/hibernate-validator/labels{/name}","releases_url":"https://api.github.com/repos/gsmet/hibernate-validator/releases{/id}","deployments_url":"https://api.github.com/repos/gsmet/hibernate-validator/deployments","created_at":"2016-04-13T07:48:18Z","updated_at":"2016-04-13T07:48:22Z","pushed_at":"2017-01-17T19:23:30Z","git_url":"git://github.com/gsmet/hibernate-validator.git","ssh_url":"git@github.com:gsmet/hibernate-validator.git","clone_url":"https://github.com/gsmet/hibernate-validator.git","svn_url":"https://github.com/gsmet/hibernate-validator","homepage":"http://validator.hibernate.org/","size":22542,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"eba840dfe83a4991bec805aa1829396b5112cbd2","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":972205,"name":"hibernate-validator","full_name":"hibernate/hibernate-validator","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars.githubusercontent.com/u/348262?v=3","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-validator","description":"Hibernate Validator - Bean Validation 2.0 (JSR 380) Reference Implementation","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-validator","forks_url":"https://api.github.com/repos/hibernate/hibernate-validator/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-validator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-validator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-validator/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-validator/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-validator/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-validator/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-validator/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-validator/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-validator/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-validator/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-validator/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-validator/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-validator/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-validator/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-validator/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-validator/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-validator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-validator/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-validator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-validator/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-validator/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-validator/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-validator/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-validator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-validator/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-validator/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-validator/deployments","created_at":"2010-10-08T13:25:07Z","updated_at":"2017-01-16T08:30:23Z","pushed_at":"2017-01-17T19:25:16Z","git_url":"git://github.com/hibernate/hibernate-validator.git","ssh_url":"git@github.com:hibernate/hibernate-validator.git","clone_url":"https://github.com/hibernate/hibernate-validator.git","svn_url":"https://github.com/hibernate/hibernate-validator","homepage":"http://hibernate.org/validator","size":22403,"stargazers_count":287,"watchers_count":287,"language":"Java","has_issues":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":200,"mirror_url":null,"open_issues_count":7,"forks":200,"open_issues":7,"watchers":287,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/632"},"html":{"href":"https://github.com/hibernate/hibernate-validator/pull/632"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/issues/632"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/issues/632/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/632/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/pulls/632/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-validator/statuses/46081cd11d58a6aeb6e1be13607096fd72b2fba4"}}}}
{"actor":{"display_login":"gunnarmorling"}}