{"action":"created","comment":{"url":"https://api.github.com/repos/solson/miri/pulls/comments/124470428","pull_request_review_id":46759887,"id":124470428,"diff_hunk":"@@ -1353,7 +1347,12 @@ impl<'a, 'tcx> EvalContext<'a, 'tcx> {\n                     I128 => 16,\n                     Is => self.memory.pointer_size(),\n                 };\n-                PrimVal::from_i128(self.memory.read_int(ptr, size)?)\n+                // if we cast a ptr to a usize reading it back into a primval shouldn't panic","path":"src/eval_context.rs","position":48,"original_position":48,"commit_id":"5dfaacf310bcec345ec38ee76d509e3e23810a95","original_commit_id":"5dfaacf310bcec345ec38ee76d509e3e23810a95","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars1.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"Whoops, copy paste.","created_at":"2017-06-28T07:35:07Z","updated_at":"2017-06-28T07:35:07Z","html_url":"https://github.com/solson/miri/pull/220#discussion_r124470428","pull_request_url":"https://api.github.com/repos/solson/miri/pulls/220","_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/comments/124470428"},"html":{"href":"https://github.com/solson/miri/pull/220#discussion_r124470428"},"pull_request":{"href":"https://api.github.com/repos/solson/miri/pulls/220"}}},"pull_request":{"url":"https://api.github.com/repos/solson/miri/pulls/220","id":127673699,"html_url":"https://github.com/solson/miri/pull/220","diff_url":"https://github.com/solson/miri/pull/220.diff","patch_url":"https://github.com/solson/miri/pull/220.patch","issue_url":"https://api.github.com/repos/solson/miri/issues/220","number":220,"state":"open","locked":false,"title":"Simplify all the code","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars1.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"body":"Undoes #146 and #139 because this was just a lot of overhead working with the field accesses. They also only \"helped\" when the lvalue that was produced was immediately read again.\r\n\r\nWe should move to doing an lvalue-read operation similar to https://github.com/solson/miri/pull/139/files#diff-3596aeeadedc2ed352f2c376852f8fb7L117 which optimizes through those cases where you don't want to have a pointer in the end, but only a primval. So basically primval rvalues?\r\n\r\nI did not reinstate the mentioned lvalue-read, since i want to get this PR through first and then write a more advanced version that supports more cases.","created_at":"2017-06-27T11:42:47Z","updated_at":"2017-06-28T07:35:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"995ff7ca5711e86842417f54b03617dc27f217ef","assignee":null,"assignees":[],"requested_reviewers":[{"login":"eddyb","id":77424,"avatar_url":"https://avatars1.githubusercontent.com/u/77424?v=3","gravatar_id":"","url":"https://api.github.com/users/eddyb","html_url":"https://github.com/eddyb","followers_url":"https://api.github.com/users/eddyb/followers","following_url":"https://api.github.com/users/eddyb/following{/other_user}","gists_url":"https://api.github.com/users/eddyb/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyb/subscriptions","organizations_url":"https://api.github.com/users/eddyb/orgs","repos_url":"https://api.github.com/users/eddyb/repos","events_url":"https://api.github.com/users/eddyb/events{/privacy}","received_events_url":"https://api.github.com/users/eddyb/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/solson/miri/pulls/220/commits","review_comments_url":"https://api.github.com/repos/solson/miri/pulls/220/comments","review_comment_url":"https://api.github.com/repos/solson/miri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/solson/miri/issues/220/comments","statuses_url":"https://api.github.com/repos/solson/miri/statuses/5dfaacf310bcec345ec38ee76d509e3e23810a95","head":{"label":"oli-obk:undo_single_field_opt","ref":"undo_single_field_opt","sha":"5dfaacf310bcec345ec38ee76d509e3e23810a95","user":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars1.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"repo":{"id":68608933,"name":"miri","full_name":"oli-obk/miri","owner":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars1.githubusercontent.com/u/332036?v=3","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/oli-obk/miri","description":"An interpreter for Rust's mid-level intermediate representation","fork":true,"url":"https://api.github.com/repos/oli-obk/miri","forks_url":"https://api.github.com/repos/oli-obk/miri/forks","keys_url":"https://api.github.com/repos/oli-obk/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/oli-obk/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/oli-obk/miri/teams","hooks_url":"https://api.github.com/repos/oli-obk/miri/hooks","issue_events_url":"https://api.github.com/repos/oli-obk/miri/issues/events{/number}","events_url":"https://api.github.com/repos/oli-obk/miri/events","assignees_url":"https://api.github.com/repos/oli-obk/miri/assignees{/user}","branches_url":"https://api.github.com/repos/oli-obk/miri/branches{/branch}","tags_url":"https://api.github.com/repos/oli-obk/miri/tags","blobs_url":"https://api.github.com/repos/oli-obk/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/oli-obk/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/oli-obk/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/oli-obk/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/oli-obk/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/oli-obk/miri/languages","stargazers_url":"https://api.github.com/repos/oli-obk/miri/stargazers","contributors_url":"https://api.github.com/repos/oli-obk/miri/contributors","subscribers_url":"https://api.github.com/repos/oli-obk/miri/subscribers","subscription_url":"https://api.github.com/repos/oli-obk/miri/subscription","commits_url":"https://api.github.com/repos/oli-obk/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/oli-obk/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/oli-obk/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/oli-obk/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/oli-obk/miri/contents/{+path}","compare_url":"https://api.github.com/repos/oli-obk/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/oli-obk/miri/merges","archive_url":"https://api.github.com/repos/oli-obk/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/oli-obk/miri/downloads","issues_url":"https://api.github.com/repos/oli-obk/miri/issues{/number}","pulls_url":"https://api.github.com/repos/oli-obk/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/oli-obk/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/oli-obk/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/oli-obk/miri/labels{/name}","releases_url":"https://api.github.com/repos/oli-obk/miri/releases{/id}","deployments_url":"https://api.github.com/repos/oli-obk/miri/deployments","created_at":"2016-09-19T13:32:46Z","updated_at":"2016-09-19T13:32:47Z","pushed_at":"2017-06-27T11:38:29Z","git_url":"git://github.com/oli-obk/miri.git","ssh_url":"git@github.com:oli-obk/miri.git","clone_url":"https://github.com/oli-obk/miri.git","svn_url":"https://github.com/oli-obk/miri","homepage":"","size":2219,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"solson:master","ref":"master","sha":"f3832c6476c1b9e74d255be5c64a8719a9cd5ab7","user":{"login":"solson","id":26806,"avatar_url":"https://avatars3.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"repo":{"id":46083140,"name":"miri","full_name":"solson/miri","owner":{"login":"solson","id":26806,"avatar_url":"https://avatars3.githubusercontent.com/u/26806?v=3","gravatar_id":"","url":"https://api.github.com/users/solson","html_url":"https://github.com/solson","followers_url":"https://api.github.com/users/solson/followers","following_url":"https://api.github.com/users/solson/following{/other_user}","gists_url":"https://api.github.com/users/solson/gists{/gist_id}","starred_url":"https://api.github.com/users/solson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solson/subscriptions","organizations_url":"https://api.github.com/users/solson/orgs","repos_url":"https://api.github.com/users/solson/repos","events_url":"https://api.github.com/users/solson/events{/privacy}","received_events_url":"https://api.github.com/users/solson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/solson/miri","description":"An interpreter for Rust's mid-level intermediate representation","fork":false,"url":"https://api.github.com/repos/solson/miri","forks_url":"https://api.github.com/repos/solson/miri/forks","keys_url":"https://api.github.com/repos/solson/miri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/solson/miri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/solson/miri/teams","hooks_url":"https://api.github.com/repos/solson/miri/hooks","issue_events_url":"https://api.github.com/repos/solson/miri/issues/events{/number}","events_url":"https://api.github.com/repos/solson/miri/events","assignees_url":"https://api.github.com/repos/solson/miri/assignees{/user}","branches_url":"https://api.github.com/repos/solson/miri/branches{/branch}","tags_url":"https://api.github.com/repos/solson/miri/tags","blobs_url":"https://api.github.com/repos/solson/miri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/solson/miri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/solson/miri/git/refs{/sha}","trees_url":"https://api.github.com/repos/solson/miri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/solson/miri/statuses/{sha}","languages_url":"https://api.github.com/repos/solson/miri/languages","stargazers_url":"https://api.github.com/repos/solson/miri/stargazers","contributors_url":"https://api.github.com/repos/solson/miri/contributors","subscribers_url":"https://api.github.com/repos/solson/miri/subscribers","subscription_url":"https://api.github.com/repos/solson/miri/subscription","commits_url":"https://api.github.com/repos/solson/miri/commits{/sha}","git_commits_url":"https://api.github.com/repos/solson/miri/git/commits{/sha}","comments_url":"https://api.github.com/repos/solson/miri/comments{/number}","issue_comment_url":"https://api.github.com/repos/solson/miri/issues/comments{/number}","contents_url":"https://api.github.com/repos/solson/miri/contents/{+path}","compare_url":"https://api.github.com/repos/solson/miri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/solson/miri/merges","archive_url":"https://api.github.com/repos/solson/miri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/solson/miri/downloads","issues_url":"https://api.github.com/repos/solson/miri/issues{/number}","pulls_url":"https://api.github.com/repos/solson/miri/pulls{/number}","milestones_url":"https://api.github.com/repos/solson/miri/milestones{/number}","notifications_url":"https://api.github.com/repos/solson/miri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/solson/miri/labels{/name}","releases_url":"https://api.github.com/repos/solson/miri/releases{/id}","deployments_url":"https://api.github.com/repos/solson/miri/deployments","created_at":"2015-11-12T21:51:25Z","updated_at":"2017-06-26T16:21:54Z","pushed_at":"2017-06-28T06:46:03Z","git_url":"git://github.com/solson/miri.git","ssh_url":"git@github.com:solson/miri.git","clone_url":"https://github.com/solson/miri.git","svn_url":"https://github.com/solson/miri","homepage":"","size":2008,"stargazers_count":265,"watchers_count":265,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":35,"mirror_url":null,"open_issues_count":19,"forks":35,"open_issues":19,"watchers":265,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/solson/miri/pulls/220"},"html":{"href":"https://github.com/solson/miri/pull/220"},"issue":{"href":"https://api.github.com/repos/solson/miri/issues/220"},"comments":{"href":"https://api.github.com/repos/solson/miri/issues/220/comments"},"review_comments":{"href":"https://api.github.com/repos/solson/miri/pulls/220/comments"},"review_comment":{"href":"https://api.github.com/repos/solson/miri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/solson/miri/pulls/220/commits"},"statuses":{"href":"https://api.github.com/repos/solson/miri/statuses/5dfaacf310bcec345ec38ee76d509e3e23810a95"}}}}
{"actor":{"display_login":"oli-obk"}}