{"action":"created","issue":{"url":"https://api.github.com/repos/phpbb/phpbb/issues/4896","repository_url":"https://api.github.com/repos/phpbb/phpbb","labels_url":"https://api.github.com/repos/phpbb/phpbb/issues/4896/labels{/name}","comments_url":"https://api.github.com/repos/phpbb/phpbb/issues/4896/comments","events_url":"https://api.github.com/repos/phpbb/phpbb/issues/4896/events","html_url":"https://github.com/phpbb/phpbb/pull/4896","id":248879473,"number":4896,"title":"[ticket/15310] Do not recognize numbers as template names","user":{"login":"javiexin","id":11807050,"avatar_url":"https://avatars1.githubusercontent.com/u/11807050?v=4","gravatar_id":"","url":"https://api.github.com/users/javiexin","html_url":"https://github.com/javiexin","followers_url":"https://api.github.com/users/javiexin/followers","following_url":"https://api.github.com/users/javiexin/following{/other_user}","gists_url":"https://api.github.com/users/javiexin/gists{/gist_id}","starred_url":"https://api.github.com/users/javiexin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javiexin/subscriptions","organizations_url":"https://api.github.com/users/javiexin/orgs","repos_url":"https://api.github.com/users/javiexin/repos","events_url":"https://api.github.com/users/javiexin/events{/privacy}","received_events_url":"https://api.github.com/users/javiexin/received_events","type":"User","site_admin":false},"labels":[{"id":118148851,"url":"https://api.github.com/repos/phpbb/phpbb/labels/3.2%20(Rhea)","name":"3.2 (Rhea)","color":"c7def8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/phpbb/phpbb/milestones/24","html_url":"https://github.com/phpbb/phpbb/milestone/24","labels_url":"https://api.github.com/repos/phpbb/phpbb/milestones/24/labels","id":2269685,"number":24,"title":"3.2.2","description":"","creator":{"login":"marc1706","id":394418,"avatar_url":"https://avatars2.githubusercontent.com/u/394418?v=4","gravatar_id":"","url":"https://api.github.com/users/marc1706","html_url":"https://github.com/marc1706","followers_url":"https://api.github.com/users/marc1706/followers","following_url":"https://api.github.com/users/marc1706/following{/other_user}","gists_url":"https://api.github.com/users/marc1706/gists{/gist_id}","starred_url":"https://api.github.com/users/marc1706/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marc1706/subscriptions","organizations_url":"https://api.github.com/users/marc1706/orgs","repos_url":"https://api.github.com/users/marc1706/repos","events_url":"https://api.github.com/users/marc1706/events{/privacy}","received_events_url":"https://api.github.com/users/marc1706/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":34,"state":"open","created_at":"2017-01-22T16:24:15Z","updated_at":"2017-09-09T17:07:47Z","due_on":null,"closed_at":null},"comments":9,"created_at":"2017-08-08T23:53:30Z","updated_at":"2017-09-10T06:25:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/phpbb/phpbb/pulls/4896","html_url":"https://github.com/phpbb/phpbb/pull/4896","diff_url":"https://github.com/phpbb/phpbb/pull/4896.diff","patch_url":"https://github.com/phpbb/phpbb/pull/4896.patch"},"body":"Currently, something like {923} in a template file is recognized as a potential template name, and replaced by {{ 923 }} for Twig processing.  This also happens with things like {9abc._} or {.a_b.}.\r\nAt the very least, things that do not start with a letter should be excluded, and that would rule out most of the \"false positives\" that it is currently identifying.\r\n\r\nPHPBB3-15310\r\n\r\nChecklist:\r\n\r\n- [x] Correct branch: master for new features; 3.2.x, 3.1.x for fixes\r\n- [x] Tests pass\r\n- [x] Code follows coding guidelines: [master / 3.2.x](https://area51.phpbb.com/docs/master/coding-guidelines.html), [3.1.x](https://area51.phpbb.com/docs/31x/coding-guidelines.html)\r\n- [x] Commit follows commit message [format](https://wiki.phpbb.com/Git#Commit_Messages)\r\n\r\nTracker ticket:\r\n\r\nhttps://tracker.phpbb.com/browse/PHPBB3-15310\r\n"},"comment":{"url":"https://api.github.com/repos/phpbb/phpbb/issues/comments/328322987","html_url":"https://github.com/phpbb/phpbb/pull/4896#issuecomment-328322987","issue_url":"https://api.github.com/repos/phpbb/phpbb/issues/4896","id":328322987,"user":{"login":"3D-I","id":480857,"avatar_url":"https://avatars1.githubusercontent.com/u/480857?v=4","gravatar_id":"","url":"https://api.github.com/users/3D-I","html_url":"https://github.com/3D-I","followers_url":"https://api.github.com/users/3D-I/followers","following_url":"https://api.github.com/users/3D-I/following{/other_user}","gists_url":"https://api.github.com/users/3D-I/gists{/gist_id}","starred_url":"https://api.github.com/users/3D-I/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/3D-I/subscriptions","organizations_url":"https://api.github.com/users/3D-I/orgs","repos_url":"https://api.github.com/users/3D-I/repos","events_url":"https://api.github.com/users/3D-I/events{/privacy}","received_events_url":"https://api.github.com/users/3D-I/received_events","type":"User","site_admin":false},"created_at":"2017-09-10T06:25:25Z","updated_at":"2017-09-10T06:25:25Z","author_association":"CONTRIBUTOR","body":"The last two comments don't apply IMHO.\r\n@Crizz0\r\nThe issue arised during the development of our extension (fully twigged), I will try to resume the commits from a set of more of 500 in order to give you the exact example.\r\n@Elsensee\r\nThere are no conflicts of any sort. Try it and see.\r\n"}}
{"actor":{"display_login":"3D-I"}}