{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/122347262","pull_request_review_id":44456432,"id":122347262,"diff_hunk":"@@ -523,7 +527,13 @@ func TestInsufficientCapacityNodeDaemonDoesNotLaunchPod(t *testing.T) {\n \t\t\tSpec: podSpec,\n \t\t})\n \t\tmanager.dsStore.Add(ds)\n-\t\tsyncAndValidateDaemonSets(t, manager, ds, podControl, 0, 0)\n+\t\tif apiequality.Semantic.DeepEqual(strategy, newOnDeleteStrategy()) {","path":"pkg/controller/daemon/daemoncontroller_test.go","position":134,"original_position":134,"commit_id":"20ae15e51992aaef776957d836a6d9f958af7012","original_commit_id":"20ae15e51992aaef776957d836a6d9f958af7012","user":{"login":"janetkuo","id":4876867,"avatar_url":"https://avatars2.githubusercontent.com/u/4876867?v=3","gravatar_id":"","url":"https://api.github.com/users/janetkuo","html_url":"https://github.com/janetkuo","followers_url":"https://api.github.com/users/janetkuo/followers","following_url":"https://api.github.com/users/janetkuo/following{/other_user}","gists_url":"https://api.github.com/users/janetkuo/gists{/gist_id}","starred_url":"https://api.github.com/users/janetkuo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janetkuo/subscriptions","organizations_url":"https://api.github.com/users/janetkuo/orgs","repos_url":"https://api.github.com/users/janetkuo/repos","events_url":"https://api.github.com/users/janetkuo/events{/privacy}","received_events_url":"https://api.github.com/users/janetkuo/received_events","type":"User","site_admin":false},"body":"```go \r\nswitch strategy.Type {\r\ncase extensions.OnDeleteDaemonSetStrategyType:\r\n...\r\n}\r\n```","created_at":"2017-06-16T01:19:20Z","updated_at":"2017-06-16T01:19:20Z","html_url":"https://github.com/kubernetes/kubernetes/pull/47042#discussion_r122347262","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47042","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/122347262"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47042#discussion_r122347262"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47042"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47042","id":124181403,"html_url":"https://github.com/kubernetes/kubernetes/pull/47042","diff_url":"https://github.com/kubernetes/kubernetes/pull/47042.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/47042.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47042","number":47042,"state":"open","locked":false,"title":"Validated expected event numbers for damoncontroller test.","user":{"login":"gyliu513","id":4461983,"avatar_url":"https://avatars2.githubusercontent.com/u/4461983?v=3","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://github.com/kubernetes/community/blob/master/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #46629\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\nnone\r\n```\r\n","created_at":"2017-06-06T12:44:10Z","updated_at":"2017-06-16T01:19:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fa49d7eb0bb5de4fa18ee1f07ba8c4578960f36","assignee":{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars0.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false},"assignees":[{"login":"lukaszo","id":97335,"avatar_url":"https://avatars0.githubusercontent.com/u/97335?v=3","gravatar_id":"","url":"https://api.github.com/users/lukaszo","html_url":"https://github.com/lukaszo","followers_url":"https://api.github.com/users/lukaszo/followers","following_url":"https://api.github.com/users/lukaszo/following{/other_user}","gists_url":"https://api.github.com/users/lukaszo/gists{/gist_id}","starred_url":"https://api.github.com/users/lukaszo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukaszo/subscriptions","organizations_url":"https://api.github.com/users/lukaszo/orgs","repos_url":"https://api.github.com/users/lukaszo/repos","events_url":"https://api.github.com/users/lukaszo/events{/privacy}","received_events_url":"https://api.github.com/users/lukaszo/received_events","type":"User","site_admin":false},{"login":"mikedanese","id":1787169,"avatar_url":"https://avatars0.githubusercontent.com/u/1787169?v=3","gravatar_id":"","url":"https://api.github.com/users/mikedanese","html_url":"https://github.com/mikedanese","followers_url":"https://api.github.com/users/mikedanese/followers","following_url":"https://api.github.com/users/mikedanese/following{/other_user}","gists_url":"https://api.github.com/users/mikedanese/gists{/gist_id}","starred_url":"https://api.github.com/users/mikedanese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikedanese/subscriptions","organizations_url":"https://api.github.com/users/mikedanese/orgs","repos_url":"https://api.github.com/users/mikedanese/repos","events_url":"https://api.github.com/users/mikedanese/events{/privacy}","received_events_url":"https://api.github.com/users/mikedanese/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36","html_url":"https://github.com/kubernetes/kubernetes/milestone/36","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36/labels","id":2545392,"number":36,"title":"v1.8","description":"Kubernetes 1.8 release milestone, date is TBD.","creator":{"login":"timothysc","id":169553,"avatar_url":"https://avatars3.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"open_issues":160,"closed_issues":7,"state":"open","created_at":"2017-05-26T17:18:43Z","updated_at":"2017-06-16T01:11:40Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47042/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47042/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47042/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/20ae15e51992aaef776957d836a6d9f958af7012","head":{"label":"gyliu513:event-count","ref":"event-count","sha":"20ae15e51992aaef776957d836a6d9f958af7012","user":{"login":"gyliu513","id":4461983,"avatar_url":"https://avatars2.githubusercontent.com/u/4461983?v=3","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},"repo":{"id":80884954,"name":"kubernetes","full_name":"gyliu513/kubernetes","owner":{"login":"gyliu513","id":4461983,"avatar_url":"https://avatars2.githubusercontent.com/u/4461983?v=3","gravatar_id":"","url":"https://api.github.com/users/gyliu513","html_url":"https://github.com/gyliu513","followers_url":"https://api.github.com/users/gyliu513/followers","following_url":"https://api.github.com/users/gyliu513/following{/other_user}","gists_url":"https://api.github.com/users/gyliu513/gists{/gist_id}","starred_url":"https://api.github.com/users/gyliu513/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gyliu513/subscriptions","organizations_url":"https://api.github.com/users/gyliu513/orgs","repos_url":"https://api.github.com/users/gyliu513/repos","events_url":"https://api.github.com/users/gyliu513/events{/privacy}","received_events_url":"https://api.github.com/users/gyliu513/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gyliu513/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/gyliu513/kubernetes","forks_url":"https://api.github.com/repos/gyliu513/kubernetes/forks","keys_url":"https://api.github.com/repos/gyliu513/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gyliu513/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gyliu513/kubernetes/teams","hooks_url":"https://api.github.com/repos/gyliu513/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/gyliu513/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/gyliu513/kubernetes/events","assignees_url":"https://api.github.com/repos/gyliu513/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/gyliu513/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/gyliu513/kubernetes/tags","blobs_url":"https://api.github.com/repos/gyliu513/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gyliu513/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gyliu513/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/gyliu513/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gyliu513/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/gyliu513/kubernetes/languages","stargazers_url":"https://api.github.com/repos/gyliu513/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/gyliu513/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/gyliu513/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/gyliu513/kubernetes/subscription","commits_url":"https://api.github.com/repos/gyliu513/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/gyliu513/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/gyliu513/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/gyliu513/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/gyliu513/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/gyliu513/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gyliu513/kubernetes/merges","archive_url":"https://api.github.com/repos/gyliu513/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gyliu513/kubernetes/downloads","issues_url":"https://api.github.com/repos/gyliu513/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/gyliu513/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/gyliu513/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/gyliu513/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gyliu513/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/gyliu513/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/gyliu513/kubernetes/deployments","created_at":"2017-02-04T01:48:21Z","updated_at":"2017-02-04T01:48:49Z","pushed_at":"2017-06-13T00:28:21Z","git_url":"git://github.com/gyliu513/kubernetes.git","ssh_url":"git@github.com:gyliu513/kubernetes.git","clone_url":"https://github.com/gyliu513/kubernetes.git","svn_url":"https://github.com/gyliu513/kubernetes","homepage":"http://kubernetes.io","size":445614,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"1dc2056599e1e9452d1649cbdd417eee0835a1bd","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-06-16T01:18:38Z","pushed_at":"2017-06-16T01:04:43Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":665141,"stargazers_count":24045,"watchers_count":24045,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8517,"mirror_url":null,"open_issues_count":5090,"forks":8517,"open_issues":5090,"watchers":24045,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47042"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47042"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47042"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47042/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47042/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47042/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/20ae15e51992aaef776957d836a6d9f958af7012"}}}}
{"actor":{"display_login":"janetkuo"}}