{"action":"closed","number":47058,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47058","id":124235597,"html_url":"https://github.com/kubernetes/kubernetes/pull/47058","diff_url":"https://github.com/kubernetes/kubernetes/pull/47058.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/47058.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47058","number":47058,"state":"closed","locked":false,"title":"kubelet: remove unused bandwidth shaping teardown code","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars1.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"body":"Since v1.5 and the removal of --configure-cbr0:\r\n\r\n0800df74abab11ba43ac53b345653e4b814ed77b \"Remove the legacy networking mode --configure-cbr0\"\r\n\r\nkubelet hasn't done any shaping operations internally.  They\r\nhave all been delegated to network plugins like kubenet or\r\nexternal CNI plugins.  But some shaping code was still left\r\nin kubelet, so remove it now that it's unused.\r\n\r\n@freehan @thockin @bprashanth ","created_at":"2017-06-06T16:36:57Z","updated_at":"2017-06-30T23:28:51Z","closed_at":"2017-06-30T23:28:51Z","merged_at":"2017-06-30T23:28:51Z","merge_commit_sha":"4b354d487727521b74b843aacaf722535d521ee7","assignee":{"login":"freehan","id":1332699,"avatar_url":"https://avatars0.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},"assignees":[{"login":"freehan","id":1332699,"avatar_url":"https://avatars0.githubusercontent.com/u/1332699?v=3","gravatar_id":"","url":"https://api.github.com/users/freehan","html_url":"https://github.com/freehan","followers_url":"https://api.github.com/users/freehan/followers","following_url":"https://api.github.com/users/freehan/following{/other_user}","gists_url":"https://api.github.com/users/freehan/gists{/gist_id}","starred_url":"https://api.github.com/users/freehan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freehan/subscriptions","organizations_url":"https://api.github.com/users/freehan/orgs","repos_url":"https://api.github.com/users/freehan/repos","events_url":"https://api.github.com/users/freehan/events{/privacy}","received_events_url":"https://api.github.com/users/freehan/received_events","type":"User","site_admin":false},{"login":"resouer","id":1701782,"avatar_url":"https://avatars0.githubusercontent.com/u/1701782?v=3","gravatar_id":"","url":"https://api.github.com/users/resouer","html_url":"https://github.com/resouer","followers_url":"https://api.github.com/users/resouer/followers","following_url":"https://api.github.com/users/resouer/following{/other_user}","gists_url":"https://api.github.com/users/resouer/gists{/gist_id}","starred_url":"https://api.github.com/users/resouer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/resouer/subscriptions","organizations_url":"https://api.github.com/users/resouer/orgs","repos_url":"https://api.github.com/users/resouer/repos","events_url":"https://api.github.com/users/resouer/events{/privacy}","received_events_url":"https://api.github.com/users/resouer/received_events","type":"User","site_admin":false},{"login":"pmichali","id":2787783,"avatar_url":"https://avatars2.githubusercontent.com/u/2787783?v=3","gravatar_id":"","url":"https://api.github.com/users/pmichali","html_url":"https://github.com/pmichali","followers_url":"https://api.github.com/users/pmichali/followers","following_url":"https://api.github.com/users/pmichali/following{/other_user}","gists_url":"https://api.github.com/users/pmichali/gists{/gist_id}","starred_url":"https://api.github.com/users/pmichali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmichali/subscriptions","organizations_url":"https://api.github.com/users/pmichali/orgs","repos_url":"https://api.github.com/users/pmichali/repos","events_url":"https://api.github.com/users/pmichali/events{/privacy}","received_events_url":"https://api.github.com/users/pmichali/received_events","type":"User","site_admin":false},{"login":"vishh","id":7063592,"avatar_url":"https://avatars1.githubusercontent.com/u/7063592?v=3","gravatar_id":"","url":"https://api.github.com/users/vishh","html_url":"https://github.com/vishh","followers_url":"https://api.github.com/users/vishh/followers","following_url":"https://api.github.com/users/vishh/following{/other_user}","gists_url":"https://api.github.com/users/vishh/gists{/gist_id}","starred_url":"https://api.github.com/users/vishh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishh/subscriptions","organizations_url":"https://api.github.com/users/vishh/orgs","repos_url":"https://api.github.com/users/vishh/repos","events_url":"https://api.github.com/users/vishh/events{/privacy}","received_events_url":"https://api.github.com/users/vishh/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36","html_url":"https://github.com/kubernetes/kubernetes/milestone/36","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/36/labels","id":2545392,"number":36,"title":"v1.8","description":"Kubernetes 1.8 release milestone, date is TBD.","creator":{"login":"timothysc","id":169553,"avatar_url":"https://avatars3.githubusercontent.com/u/169553?v=3","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"open_issues":200,"closed_issues":47,"state":"open","created_at":"2017-05-26T17:18:43Z","updated_at":"2017-06-30T23:28:51Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47058/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47058/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/47058/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/36a54bd5a41edcee515d4629b285b4080201d023","head":{"label":"dcbw:remove-dead-kubelet-shaping","ref":"remove-dead-kubelet-shaping","sha":"36a54bd5a41edcee515d4629b285b4080201d023","user":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars1.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"repo":{"id":43094783,"name":"kubernetes","full_name":"dcbw/kubernetes","owner":{"login":"dcbw","id":10926354,"avatar_url":"https://avatars1.githubusercontent.com/u/10926354?v=3","gravatar_id":"","url":"https://api.github.com/users/dcbw","html_url":"https://github.com/dcbw","followers_url":"https://api.github.com/users/dcbw/followers","following_url":"https://api.github.com/users/dcbw/following{/other_user}","gists_url":"https://api.github.com/users/dcbw/gists{/gist_id}","starred_url":"https://api.github.com/users/dcbw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcbw/subscriptions","organizations_url":"https://api.github.com/users/dcbw/orgs","repos_url":"https://api.github.com/users/dcbw/repos","events_url":"https://api.github.com/users/dcbw/events{/privacy}","received_events_url":"https://api.github.com/users/dcbw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dcbw/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/dcbw/kubernetes","forks_url":"https://api.github.com/repos/dcbw/kubernetes/forks","keys_url":"https://api.github.com/repos/dcbw/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcbw/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcbw/kubernetes/teams","hooks_url":"https://api.github.com/repos/dcbw/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/dcbw/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/dcbw/kubernetes/events","assignees_url":"https://api.github.com/repos/dcbw/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/dcbw/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/dcbw/kubernetes/tags","blobs_url":"https://api.github.com/repos/dcbw/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcbw/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcbw/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcbw/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcbw/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/dcbw/kubernetes/languages","stargazers_url":"https://api.github.com/repos/dcbw/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/dcbw/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/dcbw/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/dcbw/kubernetes/subscription","commits_url":"https://api.github.com/repos/dcbw/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcbw/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcbw/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcbw/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcbw/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/dcbw/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcbw/kubernetes/merges","archive_url":"https://api.github.com/repos/dcbw/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcbw/kubernetes/downloads","issues_url":"https://api.github.com/repos/dcbw/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/dcbw/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/dcbw/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/dcbw/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcbw/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/dcbw/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/dcbw/kubernetes/deployments","created_at":"2015-09-24T21:46:52Z","updated_at":"2016-02-04T14:52:56Z","pushed_at":"2017-06-30T16:52:28Z","git_url":"git://github.com/dcbw/kubernetes.git","ssh_url":"git@github.com:dcbw/kubernetes.git","clone_url":"https://github.com/dcbw/kubernetes.git","svn_url":"https://github.com/dcbw/kubernetes","homepage":"http://kubernetes.io","size":442725,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"17e19dfce619a10c1eef1a47894fd623e523e662","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars1.githubusercontent.com/u/13629408?v=3","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2017-06-30T22:27:14Z","pushed_at":"2017-06-30T23:28:51Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":671846,"stargazers_count":24483,"watchers_count":24483,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8692,"mirror_url":null,"open_issues_count":4930,"forks":8692,"open_issues":4930,"watchers":24483,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47058"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/47058"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47058"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/47058/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47058/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/47058/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/36a54bd5a41edcee515d4629b285b4080201d023"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"k8s-merge-robot","id":13653959,"avatar_url":"https://avatars3.githubusercontent.com/u/13653959?v=3","gravatar_id":"","url":"https://api.github.com/users/k8s-merge-robot","html_url":"https://github.com/k8s-merge-robot","followers_url":"https://api.github.com/users/k8s-merge-robot/followers","following_url":"https://api.github.com/users/k8s-merge-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-merge-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-merge-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-merge-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-merge-robot/orgs","repos_url":"https://api.github.com/users/k8s-merge-robot/repos","events_url":"https://api.github.com/users/k8s-merge-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-merge-robot/received_events","type":"User","site_admin":false},"comments":10,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":2,"deletions":189,"changed_files":8}}
{"actor":{"display_login":"k8s-merge-robot"}}