{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/157216370","pull_request_review_id":83827192,"id":157216370,"diff_hunk":"@@ -4827,11 +4827,19 @@ extern (C++) abstract class BinExp : Expression\n         TOK thisOp = (op == TOKquestion) ? TOKcolon : op;\n         if (e1.op == TOKtype || e2.op == TOKtype)\n         {\n-            error(\"incompatible types for ((%s) %s (%s)): cannot use '%s' with types\", e1.toChars(), Token.toChars(thisOp), e2.toChars(), Token.toChars(op));\n+            error(\"incompatible types for ((%s) %s (%s)): cannot use '%s' with types\",","path":"src/dmd/expression.d","position":5,"original_position":5,"commit_id":"cf01f6829411208a57613d6cbd5feae7c3cc3771","original_commit_id":"cf01f6829411208a57613d6cbd5feae7c3cc3771","user":{"login":"JinShil","id":6023641,"avatar_url":"https://avatars1.githubusercontent.com/u/6023641?v=4","gravatar_id":"","url":"https://api.github.com/users/JinShil","html_url":"https://github.com/JinShil","followers_url":"https://api.github.com/users/JinShil/followers","following_url":"https://api.github.com/users/JinShil/following{/other_user}","gists_url":"https://api.github.com/users/JinShil/gists{/gist_id}","starred_url":"https://api.github.com/users/JinShil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JinShil/subscriptions","organizations_url":"https://api.github.com/users/JinShil/orgs","repos_url":"https://api.github.com/users/JinShil/repos","events_url":"https://api.github.com/users/JinShil/events{/privacy}","received_events_url":"https://api.github.com/users/JinShil/received_events","type":"User","site_admin":false},"body":"Also, those single quotes should be backticks.","created_at":"2017-12-15T14:44:44Z","updated_at":"2017-12-15T14:44:44Z","html_url":"https://github.com/dlang/dmd/pull/7441#discussion_r157216370","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/7441","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/157216370"},"html":{"href":"https://github.com/dlang/dmd/pull/7441#discussion_r157216370"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7441"}},"in_reply_to_id":157216088},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/7441","id":158591979,"html_url":"https://github.com/dlang/dmd/pull/7441","diff_url":"https://github.com/dlang/dmd/pull/7441.diff","patch_url":"https://github.com/dlang/dmd/pull/7441.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/7441","number":7441,"state":"open","locked":false,"title":"Issue 9631 - Error message not using fully qualified name (part 2)","user":{"login":"ntrel","id":1107820,"avatar_url":"https://avatars0.githubusercontent.com/u/1107820?v=4","gravatar_id":"","url":"https://api.github.com/users/ntrel","html_url":"https://github.com/ntrel","followers_url":"https://api.github.com/users/ntrel/followers","following_url":"https://api.github.com/users/ntrel/following{/other_user}","gists_url":"https://api.github.com/users/ntrel/gists{/gist_id}","starred_url":"https://api.github.com/users/ntrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntrel/subscriptions","organizations_url":"https://api.github.com/users/ntrel/orgs","repos_url":"https://api.github.com/users/ntrel/repos","events_url":"https://api.github.com/users/ntrel/events{/privacy}","received_events_url":"https://api.github.com/users/ntrel/received_events","type":"User","site_admin":false},"body":"@JinShil Following on from #7405.\r\n\r\n* Disambiguate incompatible type errors.\r\n* Add \"both operands are of type '%s'\" error message case.\r\n\r\nThe latter saves the programmer time reading the error when there are two types with long qualification.","created_at":"2017-12-15T12:25:49Z","updated_at":"2017-12-15T14:44:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96ec5b71dea488d80119ccd21b206baeb984f6b6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"WalterBright","id":568298,"avatar_url":"https://avatars0.githubusercontent.com/u/568298?v=4","gravatar_id":"","url":"https://api.github.com/users/WalterBright","html_url":"https://github.com/WalterBright","followers_url":"https://api.github.com/users/WalterBright/followers","following_url":"https://api.github.com/users/WalterBright/following{/other_user}","gists_url":"https://api.github.com/users/WalterBright/gists{/gist_id}","starred_url":"https://api.github.com/users/WalterBright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WalterBright/subscriptions","organizations_url":"https://api.github.com/users/WalterBright/orgs","repos_url":"https://api.github.com/users/WalterBright/repos","events_url":"https://api.github.com/users/WalterBright/events{/privacy}","received_events_url":"https://api.github.com/users/WalterBright/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/7441/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/7441/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/7441/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/cf01f6829411208a57613d6cbd5feae7c3cc3771","head":{"label":"ntrel:qual-incompatible","ref":"qual-incompatible","sha":"cf01f6829411208a57613d6cbd5feae7c3cc3771","user":{"login":"ntrel","id":1107820,"avatar_url":"https://avatars0.githubusercontent.com/u/1107820?v=4","gravatar_id":"","url":"https://api.github.com/users/ntrel","html_url":"https://github.com/ntrel","followers_url":"https://api.github.com/users/ntrel/followers","following_url":"https://api.github.com/users/ntrel/following{/other_user}","gists_url":"https://api.github.com/users/ntrel/gists{/gist_id}","starred_url":"https://api.github.com/users/ntrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntrel/subscriptions","organizations_url":"https://api.github.com/users/ntrel/orgs","repos_url":"https://api.github.com/users/ntrel/repos","events_url":"https://api.github.com/users/ntrel/events{/privacy}","received_events_url":"https://api.github.com/users/ntrel/received_events","type":"User","site_admin":false},"repo":{"id":6145198,"name":"dmd","full_name":"ntrel/dmd","owner":{"login":"ntrel","id":1107820,"avatar_url":"https://avatars0.githubusercontent.com/u/1107820?v=4","gravatar_id":"","url":"https://api.github.com/users/ntrel","html_url":"https://github.com/ntrel","followers_url":"https://api.github.com/users/ntrel/followers","following_url":"https://api.github.com/users/ntrel/following{/other_user}","gists_url":"https://api.github.com/users/ntrel/gists{/gist_id}","starred_url":"https://api.github.com/users/ntrel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ntrel/subscriptions","organizations_url":"https://api.github.com/users/ntrel/orgs","repos_url":"https://api.github.com/users/ntrel/repos","events_url":"https://api.github.com/users/ntrel/events{/privacy}","received_events_url":"https://api.github.com/users/ntrel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ntrel/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/ntrel/dmd","forks_url":"https://api.github.com/repos/ntrel/dmd/forks","keys_url":"https://api.github.com/repos/ntrel/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ntrel/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ntrel/dmd/teams","hooks_url":"https://api.github.com/repos/ntrel/dmd/hooks","issue_events_url":"https://api.github.com/repos/ntrel/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/ntrel/dmd/events","assignees_url":"https://api.github.com/repos/ntrel/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/ntrel/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/ntrel/dmd/tags","blobs_url":"https://api.github.com/repos/ntrel/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ntrel/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ntrel/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ntrel/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ntrel/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/ntrel/dmd/languages","stargazers_url":"https://api.github.com/repos/ntrel/dmd/stargazers","contributors_url":"https://api.github.com/repos/ntrel/dmd/contributors","subscribers_url":"https://api.github.com/repos/ntrel/dmd/subscribers","subscription_url":"https://api.github.com/repos/ntrel/dmd/subscription","commits_url":"https://api.github.com/repos/ntrel/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ntrel/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ntrel/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ntrel/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ntrel/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/ntrel/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ntrel/dmd/merges","archive_url":"https://api.github.com/repos/ntrel/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ntrel/dmd/downloads","issues_url":"https://api.github.com/repos/ntrel/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/ntrel/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/ntrel/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/ntrel/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ntrel/dmd/labels{/name}","releases_url":"https://api.github.com/repos/ntrel/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/ntrel/dmd/deployments","created_at":"2012-10-09T18:05:57Z","updated_at":"2013-03-08T14:37:48Z","pushed_at":"2017-12-15T14:19:54Z","git_url":"git://github.com/ntrel/dmd.git","ssh_url":"git@github.com:ntrel/dmd.git","clone_url":"https://github.com/ntrel/dmd.git","svn_url":"https://github.com/ntrel/dmd","homepage":"d-programming-language.org","size":76595,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"64424027452125693483b36022827e6c401e2307","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2017-12-14T10:02:07Z","pushed_at":"2017-12-15T14:27:33Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":80605,"stargazers_count":1712,"watchers_count":1712,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":432,"mirror_url":null,"archived":false,"open_issues_count":145,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":432,"open_issues":145,"watchers":1712,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7441"},"html":{"href":"https://github.com/dlang/dmd/pull/7441"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/7441"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/7441/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7441/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7441/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/cf01f6829411208a57613d6cbd5feae7c3cc3771"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"JinShil"}}