{"comment":{"url":"https://api.github.com/repos/gozora/rear/comments/23133068","html_url":"https://github.com/gozora/rear/commit/3a2eefdd6ec0826946d49e9de14416eea2649f96#commitcomment-23133068","id":23133068,"user":{"login":"jsmeix","id":1788608,"avatar_url":"https://avatars4.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"position":null,"line":null,"path":null,"commit_id":"3a2eefdd6ec0826946d49e9de14416eea2649f96","created_at":"2017-07-17T10:21:00Z","updated_at":"2017-07-17T10:21:00Z","body":"Because the current retry_command runs the command\r\nat least two times (a succesful trial plus a succesful verification)\r\nthe current name 'retry_command' could be misleading\r\nthat users may assume it runs command only once if that succeeds\r\nwhich may result unexpected outcome:\r\n<pre>\r\n# value=Hello\r\n\r\n# file=/tmp/testy\r\n\r\n# retry_command \"echo $value >>$file\"\r\n\r\n# cat /tmp/testy\r\nHello\r\nHello\r\n</pre>\r\n\r\nPerhaps the function name should be more explicit,\r\ne.g. something like 'try_and_verify'?\r\n\r\nOr we may have two functions\r\n'retry_command' that runs only once if successfu\r\nplus\r\n'try_and_verify' that just runs 'retry_command' two times?\r\n"}}
{"actor":{"display_login":"jsmeix"}}