{"action":"created","issue":{"url":"https://api.github.com/repos/patrik-piskay/react-tabs-redux/issues/26","repository_url":"https://api.github.com/repos/patrik-piskay/react-tabs-redux","labels_url":"https://api.github.com/repos/patrik-piskay/react-tabs-redux/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/patrik-piskay/react-tabs-redux/issues/26/comments","events_url":"https://api.github.com/repos/patrik-piskay/react-tabs-redux/issues/26/events","html_url":"https://github.com/patrik-piskay/react-tabs-redux/pull/26","id":244252678,"number":26,"title":"Navigating between tabs with TAB button","user":{"login":"w35l3y","id":963510,"avatar_url":"https://avatars2.githubusercontent.com/u/963510?v=4","gravatar_id":"","url":"https://api.github.com/users/w35l3y","html_url":"https://github.com/w35l3y","followers_url":"https://api.github.com/users/w35l3y/followers","following_url":"https://api.github.com/users/w35l3y/following{/other_user}","gists_url":"https://api.github.com/users/w35l3y/gists{/gist_id}","starred_url":"https://api.github.com/users/w35l3y/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w35l3y/subscriptions","organizations_url":"https://api.github.com/users/w35l3y/orgs","repos_url":"https://api.github.com/users/w35l3y/repos","events_url":"https://api.github.com/users/w35l3y/events{/privacy}","received_events_url":"https://api.github.com/users/w35l3y/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-07-20T05:54:22Z","updated_at":"2017-07-20T22:06:02Z","closed_at":"2017-07-20T22:06:02Z","pull_request":{"url":"https://api.github.com/repos/patrik-piskay/react-tabs-redux/pulls/26","html_url":"https://github.com/patrik-piskay/react-tabs-redux/pull/26","diff_url":"https://github.com/patrik-piskay/react-tabs-redux/pull/26.diff","patch_url":"https://github.com/patrik-piskay/react-tabs-redux/pull/26.patch"},"body":"We now should be able to navigate between tabs when pressing TAB button.\r\n\r\nIt WON'T work whenever `renderActiveTabContentOnly` is enabled.\r\n\r\nShould fix #24 "},"comment":{"url":"https://api.github.com/repos/patrik-piskay/react-tabs-redux/issues/comments/316843518","html_url":"https://github.com/patrik-piskay/react-tabs-redux/pull/26#issuecomment-316843518","issue_url":"https://api.github.com/repos/patrik-piskay/react-tabs-redux/issues/26","id":316843518,"user":{"login":"patrik-piskay","id":966953,"avatar_url":"https://avatars0.githubusercontent.com/u/966953?v=4","gravatar_id":"","url":"https://api.github.com/users/patrik-piskay","html_url":"https://github.com/patrik-piskay","followers_url":"https://api.github.com/users/patrik-piskay/followers","following_url":"https://api.github.com/users/patrik-piskay/following{/other_user}","gists_url":"https://api.github.com/users/patrik-piskay/gists{/gist_id}","starred_url":"https://api.github.com/users/patrik-piskay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/patrik-piskay/subscriptions","organizations_url":"https://api.github.com/users/patrik-piskay/orgs","repos_url":"https://api.github.com/users/patrik-piskay/repos","events_url":"https://api.github.com/users/patrik-piskay/events{/privacy}","received_events_url":"https://api.github.com/users/patrik-piskay/received_events","type":"User","site_admin":false},"created_at":"2017-07-20T22:06:02Z","updated_at":"2017-07-20T22:06:02Z","body":"Oh, looks like I misunderstood what you were trying to achieve. I thought it was a fix for following scenario: \r\n- you have 2 tabs with few inputs each\r\n- you navigate through the inputs on the active tab using `tab` key\r\n- after pressing `tab` key while the last input on the active tab is focused, the first input on the hidden tab is focused\r\n\r\nAnd I thought the desired behaviour is to not focus the input in hidden tab but continue focusing elements outside Tabs (rest of the page) instead.\r\n\r\nWhat this PR implements is the ability to change active tabs just by changing focus of elements (pressing tab key) which I think is not the expected behaviour in common cases (or in other words, users do not expect it to work that way) and that's why I wouldn't make it a default for this library.\r\n\r\nI'll close this one but I'm definitely open to the one addressing the other issue (continue focusing visible elements and don't focus elements that are part of the hidden tabs) "}}
{"actor":{"display_login":"patrik-piskay"}}