{"action":"created","comment":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/118568678","pull_request_review_id":40373967,"id":118568678,"diff_hunk":"@@ -498,8 +498,15 @@ func (b *Builder) AddRPMList(rpms []os.FileInfo) {\n \t\t\tfmt.Println(\"ERROR: RPM is not valid! Please make sure it was built correctly.\")\n \t\t\tos.Exit(1)\n \t\t} else {\n-\t\t\tfmt.Printf(\"Copying %s\\n\", rpm.Name())\n-\t\t\thelpers.CopyFile(b.Repodir+\"/\"+rpm.Name(), b.Rpmdir+\"/\"+rpm.Name())\n+\t\t\tif _, err = os.Stat(b.Repodir + \"/\" + rpm.Name()); err == nil {\n+\t\t\t\tcontinue\n+\t\t\t}\n+\t\t\tfmt.Printf(\"Hardlinking %s to repodir\\n\", rpm.Name())\n+\t\t\terr := os.Link(b.Rpmdir+\"/\"+rpm.Name(), b.Repodir+\"/\"+rpm.Name())\n+\t\t\tif err != nil {\n+\t\t\t\thelpers.PrintError(err)\n+\t\t\t\tos.Exit(1)","path":"src/builder/builder.go","position":13,"original_position":13,"commit_id":"2ecd9903461250df861af8c1c08d98cf3d594868","original_commit_id":"2ecd9903461250df861af8c1c08d98cf3d594868","user":{"login":"bryteise","id":15709,"avatar_url":"https://avatars1.githubusercontent.com/u/15709?v=3","gravatar_id":"","url":"https://api.github.com/users/bryteise","html_url":"https://github.com/bryteise","followers_url":"https://api.github.com/users/bryteise/followers","following_url":"https://api.github.com/users/bryteise/following{/other_user}","gists_url":"https://api.github.com/users/bryteise/gists{/gist_id}","starred_url":"https://api.github.com/users/bryteise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryteise/subscriptions","organizations_url":"https://api.github.com/users/bryteise/orgs","repos_url":"https://api.github.com/users/bryteise/repos","events_url":"https://api.github.com/users/bryteise/events{/privacy}","received_events_url":"https://api.github.com/users/bryteise/received_events","type":"User","site_admin":false},"body":"Seems harsh to fail and not just fall back to copyfile in case folks have these on different filesystem partitions.","created_at":"2017-05-25T19:46:32Z","updated_at":"2017-05-25T19:46:32Z","html_url":"https://github.com/clearlinux/mixer-tools/pull/21#discussion_r118568678","pull_request_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/21","_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments/118568678"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/21#discussion_r118568678"},"pull_request":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/21","id":122506391,"html_url":"https://github.com/clearlinux/mixer-tools/pull/21","diff_url":"https://github.com/clearlinux/mixer-tools/pull/21.diff","patch_url":"https://github.com/clearlinux/mixer-tools/pull/21.patch","issue_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/21","number":21,"state":"open","locked":false,"title":"Hardlink rpms when calling add-rpms","user":{"login":"tmarcu","id":574028,"avatar_url":"https://avatars1.githubusercontent.com/u/574028?v=3","gravatar_id":"","url":"https://api.github.com/users/tmarcu","html_url":"https://github.com/tmarcu","followers_url":"https://api.github.com/users/tmarcu/followers","following_url":"https://api.github.com/users/tmarcu/following{/other_user}","gists_url":"https://api.github.com/users/tmarcu/gists{/gist_id}","starred_url":"https://api.github.com/users/tmarcu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmarcu/subscriptions","organizations_url":"https://api.github.com/users/tmarcu/orgs","repos_url":"https://api.github.com/users/tmarcu/repos","events_url":"https://api.github.com/users/tmarcu/events{/privacy}","received_events_url":"https://api.github.com/users/tmarcu/received_events","type":"User","site_admin":false},"body":"To save time on copying fullfiles, just make a hardlink from the files in\r\nRPMDIR to the REPODIR.\r\n\r\nSigned-off-by: Tudor Marcu <tudor.marcu@intel.com>","created_at":"2017-05-25T19:18:14Z","updated_at":"2017-05-25T19:46:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9afd7d4bb652b8ae899c4c92280cc5c2df6ced37","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/21/commits","review_comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/21/comments","review_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/21/comments","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/2ecd9903461250df861af8c1c08d98cf3d594868","head":{"label":"clearlinux:hardlink","ref":"hardlink","sha":"2ecd9903461250df861af8c1c08d98cf3d594868","user":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars1.githubusercontent.com/u/12545216?v=3","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"name":"mixer-tools","full_name":"clearlinux/mixer-tools","owner":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars1.githubusercontent.com/u/12545216?v=3","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2017-03-01T10:45:55Z","pushed_at":"2017-05-25T19:18:14Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":75,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"clearlinux:master","ref":"master","sha":"8c76142781320967b51fc19bd4f2fa73a348baf5","user":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars1.githubusercontent.com/u/12545216?v=3","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"repo":{"id":54439474,"name":"mixer-tools","full_name":"clearlinux/mixer-tools","owner":{"login":"clearlinux","id":12545216,"avatar_url":"https://avatars1.githubusercontent.com/u/12545216?v=3","gravatar_id":"","url":"https://api.github.com/users/clearlinux","html_url":"https://github.com/clearlinux","followers_url":"https://api.github.com/users/clearlinux/followers","following_url":"https://api.github.com/users/clearlinux/following{/other_user}","gists_url":"https://api.github.com/users/clearlinux/gists{/gist_id}","starred_url":"https://api.github.com/users/clearlinux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clearlinux/subscriptions","organizations_url":"https://api.github.com/users/clearlinux/orgs","repos_url":"https://api.github.com/users/clearlinux/repos","events_url":"https://api.github.com/users/clearlinux/events{/privacy}","received_events_url":"https://api.github.com/users/clearlinux/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/clearlinux/mixer-tools","description":null,"fork":false,"url":"https://api.github.com/repos/clearlinux/mixer-tools","forks_url":"https://api.github.com/repos/clearlinux/mixer-tools/forks","keys_url":"https://api.github.com/repos/clearlinux/mixer-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/clearlinux/mixer-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/clearlinux/mixer-tools/teams","hooks_url":"https://api.github.com/repos/clearlinux/mixer-tools/hooks","issue_events_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/events{/number}","events_url":"https://api.github.com/repos/clearlinux/mixer-tools/events","assignees_url":"https://api.github.com/repos/clearlinux/mixer-tools/assignees{/user}","branches_url":"https://api.github.com/repos/clearlinux/mixer-tools/branches{/branch}","tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/tags","blobs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/clearlinux/mixer-tools/languages","stargazers_url":"https://api.github.com/repos/clearlinux/mixer-tools/stargazers","contributors_url":"https://api.github.com/repos/clearlinux/mixer-tools/contributors","subscribers_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscribers","subscription_url":"https://api.github.com/repos/clearlinux/mixer-tools/subscription","commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/clearlinux/mixer-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/clearlinux/mixer-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/clearlinux/mixer-tools/contents/{+path}","compare_url":"https://api.github.com/repos/clearlinux/mixer-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/clearlinux/mixer-tools/merges","archive_url":"https://api.github.com/repos/clearlinux/mixer-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/clearlinux/mixer-tools/downloads","issues_url":"https://api.github.com/repos/clearlinux/mixer-tools/issues{/number}","pulls_url":"https://api.github.com/repos/clearlinux/mixer-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/clearlinux/mixer-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/clearlinux/mixer-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/clearlinux/mixer-tools/labels{/name}","releases_url":"https://api.github.com/repos/clearlinux/mixer-tools/releases{/id}","deployments_url":"https://api.github.com/repos/clearlinux/mixer-tools/deployments","created_at":"2016-03-22T02:38:26Z","updated_at":"2017-03-01T10:45:55Z","pushed_at":"2017-05-25T19:18:14Z","git_url":"git://github.com/clearlinux/mixer-tools.git","ssh_url":"git@github.com:clearlinux/mixer-tools.git","clone_url":"https://github.com/clearlinux/mixer-tools.git","svn_url":"https://github.com/clearlinux/mixer-tools","homepage":null,"size":75,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/21"},"html":{"href":"https://github.com/clearlinux/mixer-tools/pull/21"},"issue":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/21"},"comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/clearlinux/mixer-tools/statuses/2ecd9903461250df861af8c1c08d98cf3d594868"}}}}
{"actor":{"display_login":"bryteise"}}