{"action":"created","issue":{"url":"https://api.github.com/repos/apollographql/apollo-engine-js/issues/24","repository_url":"https://api.github.com/repos/apollographql/apollo-engine-js","labels_url":"https://api.github.com/repos/apollographql/apollo-engine-js/issues/24/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-engine-js/issues/24/comments","events_url":"https://api.github.com/repos/apollographql/apollo-engine-js/issues/24/events","html_url":"https://github.com/apollographql/apollo-engine-js/issues/24","id":268903828,"number":24,"title":"Conflict with timber-node package","user":{"login":"owensbla","id":929281,"avatar_url":"https://avatars0.githubusercontent.com/u/929281?v=4","gravatar_id":"","url":"https://api.github.com/users/owensbla","html_url":"https://github.com/owensbla","followers_url":"https://api.github.com/users/owensbla/followers","following_url":"https://api.github.com/users/owensbla/following{/other_user}","gists_url":"https://api.github.com/users/owensbla/gists{/gist_id}","starred_url":"https://api.github.com/users/owensbla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owensbla/subscriptions","organizations_url":"https://api.github.com/users/owensbla/orgs","repos_url":"https://api.github.com/users/owensbla/repos","events_url":"https://api.github.com/users/owensbla/events{/privacy}","received_events_url":"https://api.github.com/users/owensbla/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-26T20:40:28Z","updated_at":"2017-11-30T22:05:13Z","closed_at":null,"author_association":"NONE","body":"Error when running sidecar package alongside [timber-node](https://github.com/timberio/timber-node):\r\n\r\n```js\r\nTypeError: log.split is not a function\r\n    at stripMetadata (/Development/api/node_modules/timber/dist/utils/metadata.js:7:14)\r\n    at WriteStream.toStream.write (/Development/api/node_modules/timber/dist/utils/attach.js:76:159)\r\n    at LineWrapper.ondata (_stream_readable.js:642:20)\r\n    at emitOne (events.js:115:13)\r\n    at LineWrapper.emit (events.js:210:7)\r\n    at addChunk (_stream_readable.js:266:12)\r\n    at readableAddChunk (_stream_readable.js:253:11)\r\n    at LineWrapper.Readable.push (_stream_readable.js:211:10)\r\n    at LineWrapper.Transform.push (_stream_transform.js:147:32)\r\n    at LineWrapper.<anonymous> (/Development/api/node_modules/stream-line-wrapper/lib/line-wrapper.js:75:10)\r\n    at Array.forEach (<anonymous>)\r\n    at LineWrapper._transform (/Development/api/node_modules/stream-line-wrapper/lib/line-wrapper.js:74:9)\r\n    at LineWrapper.Transform._read (_stream_transform.js:186:10)\r\n    at LineWrapper.Transform._write (_stream_transform.js:174:12)\r\n    at doWrite (_stream_writable.js:385:12)\r\n    at writeOrBuffer (_stream_writable.js:371:5)\r\n    at LineWrapper.Writable.write (_stream_writable.js:288:11)\r\n    at Socket.ondata (_stream_readable.js:642:20)\r\n    at emitOne (events.js:115:13)\r\n    at Socket.emit (events.js:210:7)\r\n    at addChunk (_stream_readable.js:266:12)\r\n    at readableAddChunk (_stream_readable.js:253:11)\r\n    at Socket.Readable.push (_stream_readable.js:211:10)\r\n    at Pipe.onread (net.js:585:20)\r\n```\r\n\r\nAssuming it has to do with timber hijacking `console.log` methods."},"comment":{"url":"https://api.github.com/repos/apollographql/apollo-engine-js/issues/comments/348335866","html_url":"https://github.com/apollographql/apollo-engine-js/issues/24#issuecomment-348335866","issue_url":"https://api.github.com/repos/apollographql/apollo-engine-js/issues/24","id":348335866,"user":{"login":"zionts","id":6365997,"avatar_url":"https://avatars2.githubusercontent.com/u/6365997?v=4","gravatar_id":"","url":"https://api.github.com/users/zionts","html_url":"https://github.com/zionts","followers_url":"https://api.github.com/users/zionts/followers","following_url":"https://api.github.com/users/zionts/following{/other_user}","gists_url":"https://api.github.com/users/zionts/gists{/gist_id}","starred_url":"https://api.github.com/users/zionts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zionts/subscriptions","organizations_url":"https://api.github.com/users/zionts/orgs","repos_url":"https://api.github.com/users/zionts/repos","events_url":"https://api.github.com/users/zionts/events{/privacy}","received_events_url":"https://api.github.com/users/zionts/received_events","type":"User","site_admin":false},"created_at":"2017-11-30T22:05:13Z","updated_at":"2017-11-30T22:05:13Z","author_association":"NONE","body":"Thanks for writing this in and pointing this out! It looks like this is likely an incompatibility issue, and we'd love to try to support timber-node. It would be really useful if you could provide a reproduction of this issue in the form of a PR that adds timber-node logging as a test case in /test/ and maybe even pinpointing where in the code you thing the bug might lie.\r\n\r\nWe'd love to support all third party packages – to prioritize, we rely on community feedback to choose where we spend our time. Please 👍 this issue if adding support for timber-node is important to you."}}
{"actor":{"display_login":"zionts"}}