{"action":"created","comment":{"url":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/comments/101748454","pull_request_review_id":22486914,"id":101748454,"diff_hunk":"@@ -29,24 +38,33 @@ public void shouldApplyUnchecked() throws Exception {\n         // then no exception thrown\n     }\n \n-    @Test(expected = WrappedException.class)\n+    @Test\n     public void shouldApplyUncheckedAndThrow() throws Exception {\n+        final IOException cause = new IOException(\"some message\");\n+        \n+        thrown.expect(WrappedException.class);\n+        thrown.expectMessage(\"some message\");\n+        thrown.expectCause(is(cause));\n+\n         // given\n-        ThrowingUnaryOperator<Integer, IOException> op = i -> { throw new IOException(); };\n+        ThrowingUnaryOperator<Integer, IOException> op = i -> { throw cause; };","path":"src/test/java/pl/touk/throwing/ThrowingUnaryOperatorTest.java","position":37,"original_position":37,"commit_id":"603d2e8c4df98b23c3ed51ade7471658be55205f","original_commit_id":"603d2e8c4df98b23c3ed51ade7471658be55205f","user":{"login":"sputnikci","id":15047461,"avatar_url":"https://avatars.githubusercontent.com/u/15047461?v=3","gravatar_id":"","url":"https://api.github.com/users/sputnikci","html_url":"https://github.com/sputnikci","followers_url":"https://api.github.com/users/sputnikci/followers","following_url":"https://api.github.com/users/sputnikci/following{/other_user}","gists_url":"https://api.github.com/users/sputnikci/gists{/gist_id}","starred_url":"https://api.github.com/users/sputnikci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sputnikci/subscriptions","organizations_url":"https://api.github.com/users/sputnikci/orgs","repos_url":"https://api.github.com/users/sputnikci/repos","events_url":"https://api.github.com/users/sputnikci/events{/privacy}","received_events_url":"https://api.github.com/users/sputnikci/received_events","type":"User","site_admin":false},"body":"\\[Checkstyle\\] ERROR: Only one statement per line allowed\\.","created_at":"2017-02-17T12:41:05Z","updated_at":"2017-02-17T12:41:05Z","html_url":"https://github.com/TouK/ThrowingFunction/pull/20#discussion_r101748454","pull_request_url":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/20","_links":{"self":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/comments/101748454"},"html":{"href":"https://github.com/TouK/ThrowingFunction/pull/20#discussion_r101748454"},"pull_request":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/20"}}},"pull_request":{"url":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/20","id":106725513,"html_url":"https://github.com/TouK/ThrowingFunction/pull/20","diff_url":"https://github.com/TouK/ThrowingFunction/pull/20.diff","patch_url":"https://github.com/TouK/ThrowingFunction/pull/20.patch","issue_url":"https://api.github.com/repos/TouK/ThrowingFunction/issues/20","number":20,"state":"open","locked":false,"title":"update existing tests to use `ExpectedException` instead of `@Test(expected = SomeException.class)`","user":{"login":"albertlr","id":856574,"avatar_url":"https://avatars.githubusercontent.com/u/856574?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlr","html_url":"https://github.com/albertlr","followers_url":"https://api.github.com/users/albertlr/followers","following_url":"https://api.github.com/users/albertlr/following{/other_user}","gists_url":"https://api.github.com/users/albertlr/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlr/subscriptions","organizations_url":"https://api.github.com/users/albertlr/orgs","repos_url":"https://api.github.com/users/albertlr/repos","events_url":"https://api.github.com/users/albertlr/events{/privacy}","received_events_url":"https://api.github.com/users/albertlr/received_events","type":"User","site_admin":false},"body":"As for issue #19, I did the following changes:\r\n\r\n* update existing tests to use `ExpectedException` instead of `@Test(expected = SomeException.class)` and \r\n* fix `ThrowingBinaryOperatorTest` to use `ThrowingBinaryOperator::unchecked` instead of `ThrowingBiFunction::unchecked`\r\n\r\n@pivovarit could you take a look?\r\n\r\n","created_at":"2017-02-17T12:39:14Z","updated_at":"2017-02-17T12:41:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e53d01a3a5e20500ef194695b54947dd3549b399","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/20/commits","review_comments_url":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/20/comments","review_comment_url":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TouK/ThrowingFunction/issues/20/comments","statuses_url":"https://api.github.com/repos/TouK/ThrowingFunction/statuses/603d2e8c4df98b23c3ed51ade7471658be55205f","head":{"label":"albertlr:tests-with-expectedexception","ref":"tests-with-expectedexception","sha":"603d2e8c4df98b23c3ed51ade7471658be55205f","user":{"login":"albertlr","id":856574,"avatar_url":"https://avatars.githubusercontent.com/u/856574?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlr","html_url":"https://github.com/albertlr","followers_url":"https://api.github.com/users/albertlr/followers","following_url":"https://api.github.com/users/albertlr/following{/other_user}","gists_url":"https://api.github.com/users/albertlr/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlr/subscriptions","organizations_url":"https://api.github.com/users/albertlr/orgs","repos_url":"https://api.github.com/users/albertlr/repos","events_url":"https://api.github.com/users/albertlr/events{/privacy}","received_events_url":"https://api.github.com/users/albertlr/received_events","type":"User","site_admin":false},"repo":{"id":82286642,"name":"ThrowingFunction","full_name":"albertlr/ThrowingFunction","owner":{"login":"albertlr","id":856574,"avatar_url":"https://avatars.githubusercontent.com/u/856574?v=3","gravatar_id":"","url":"https://api.github.com/users/albertlr","html_url":"https://github.com/albertlr","followers_url":"https://api.github.com/users/albertlr/followers","following_url":"https://api.github.com/users/albertlr/following{/other_user}","gists_url":"https://api.github.com/users/albertlr/gists{/gist_id}","starred_url":"https://api.github.com/users/albertlr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albertlr/subscriptions","organizations_url":"https://api.github.com/users/albertlr/orgs","repos_url":"https://api.github.com/users/albertlr/repos","events_url":"https://api.github.com/users/albertlr/events{/privacy}","received_events_url":"https://api.github.com/users/albertlr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/albertlr/ThrowingFunction","description":"Java 8 functional types supporting checked exceptions","fork":true,"url":"https://api.github.com/repos/albertlr/ThrowingFunction","forks_url":"https://api.github.com/repos/albertlr/ThrowingFunction/forks","keys_url":"https://api.github.com/repos/albertlr/ThrowingFunction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/albertlr/ThrowingFunction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/albertlr/ThrowingFunction/teams","hooks_url":"https://api.github.com/repos/albertlr/ThrowingFunction/hooks","issue_events_url":"https://api.github.com/repos/albertlr/ThrowingFunction/issues/events{/number}","events_url":"https://api.github.com/repos/albertlr/ThrowingFunction/events","assignees_url":"https://api.github.com/repos/albertlr/ThrowingFunction/assignees{/user}","branches_url":"https://api.github.com/repos/albertlr/ThrowingFunction/branches{/branch}","tags_url":"https://api.github.com/repos/albertlr/ThrowingFunction/tags","blobs_url":"https://api.github.com/repos/albertlr/ThrowingFunction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/albertlr/ThrowingFunction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/albertlr/ThrowingFunction/git/refs{/sha}","trees_url":"https://api.github.com/repos/albertlr/ThrowingFunction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/albertlr/ThrowingFunction/statuses/{sha}","languages_url":"https://api.github.com/repos/albertlr/ThrowingFunction/languages","stargazers_url":"https://api.github.com/repos/albertlr/ThrowingFunction/stargazers","contributors_url":"https://api.github.com/repos/albertlr/ThrowingFunction/contributors","subscribers_url":"https://api.github.com/repos/albertlr/ThrowingFunction/subscribers","subscription_url":"https://api.github.com/repos/albertlr/ThrowingFunction/subscription","commits_url":"https://api.github.com/repos/albertlr/ThrowingFunction/commits{/sha}","git_commits_url":"https://api.github.com/repos/albertlr/ThrowingFunction/git/commits{/sha}","comments_url":"https://api.github.com/repos/albertlr/ThrowingFunction/comments{/number}","issue_comment_url":"https://api.github.com/repos/albertlr/ThrowingFunction/issues/comments{/number}","contents_url":"https://api.github.com/repos/albertlr/ThrowingFunction/contents/{+path}","compare_url":"https://api.github.com/repos/albertlr/ThrowingFunction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/albertlr/ThrowingFunction/merges","archive_url":"https://api.github.com/repos/albertlr/ThrowingFunction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/albertlr/ThrowingFunction/downloads","issues_url":"https://api.github.com/repos/albertlr/ThrowingFunction/issues{/number}","pulls_url":"https://api.github.com/repos/albertlr/ThrowingFunction/pulls{/number}","milestones_url":"https://api.github.com/repos/albertlr/ThrowingFunction/milestones{/number}","notifications_url":"https://api.github.com/repos/albertlr/ThrowingFunction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/albertlr/ThrowingFunction/labels{/name}","releases_url":"https://api.github.com/repos/albertlr/ThrowingFunction/releases{/id}","deployments_url":"https://api.github.com/repos/albertlr/ThrowingFunction/deployments","created_at":"2017-02-17T10:37:06Z","updated_at":"2017-02-17T10:37:08Z","pushed_at":"2017-02-17T12:29:17Z","git_url":"git://github.com/albertlr/ThrowingFunction.git","ssh_url":"git@github.com:albertlr/ThrowingFunction.git","clone_url":"https://github.com/albertlr/ThrowingFunction.git","svn_url":"https://github.com/albertlr/ThrowingFunction","homepage":null,"size":112,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TouK:master","ref":"master","sha":"bcaff343dc81376400a867338ba83a3dba1b0b3d","user":{"login":"TouK","id":136506,"avatar_url":"https://avatars.githubusercontent.com/u/136506?v=3","gravatar_id":"","url":"https://api.github.com/users/TouK","html_url":"https://github.com/TouK","followers_url":"https://api.github.com/users/TouK/followers","following_url":"https://api.github.com/users/TouK/following{/other_user}","gists_url":"https://api.github.com/users/TouK/gists{/gist_id}","starred_url":"https://api.github.com/users/TouK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TouK/subscriptions","organizations_url":"https://api.github.com/users/TouK/orgs","repos_url":"https://api.github.com/users/TouK/repos","events_url":"https://api.github.com/users/TouK/events{/privacy}","received_events_url":"https://api.github.com/users/TouK/received_events","type":"Organization","site_admin":false},"repo":{"id":46967967,"name":"ThrowingFunction","full_name":"TouK/ThrowingFunction","owner":{"login":"TouK","id":136506,"avatar_url":"https://avatars.githubusercontent.com/u/136506?v=3","gravatar_id":"","url":"https://api.github.com/users/TouK","html_url":"https://github.com/TouK","followers_url":"https://api.github.com/users/TouK/followers","following_url":"https://api.github.com/users/TouK/following{/other_user}","gists_url":"https://api.github.com/users/TouK/gists{/gist_id}","starred_url":"https://api.github.com/users/TouK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TouK/subscriptions","organizations_url":"https://api.github.com/users/TouK/orgs","repos_url":"https://api.github.com/users/TouK/repos","events_url":"https://api.github.com/users/TouK/events{/privacy}","received_events_url":"https://api.github.com/users/TouK/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TouK/ThrowingFunction","description":"Java 8 functional types supporting checked exceptions","fork":false,"url":"https://api.github.com/repos/TouK/ThrowingFunction","forks_url":"https://api.github.com/repos/TouK/ThrowingFunction/forks","keys_url":"https://api.github.com/repos/TouK/ThrowingFunction/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TouK/ThrowingFunction/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TouK/ThrowingFunction/teams","hooks_url":"https://api.github.com/repos/TouK/ThrowingFunction/hooks","issue_events_url":"https://api.github.com/repos/TouK/ThrowingFunction/issues/events{/number}","events_url":"https://api.github.com/repos/TouK/ThrowingFunction/events","assignees_url":"https://api.github.com/repos/TouK/ThrowingFunction/assignees{/user}","branches_url":"https://api.github.com/repos/TouK/ThrowingFunction/branches{/branch}","tags_url":"https://api.github.com/repos/TouK/ThrowingFunction/tags","blobs_url":"https://api.github.com/repos/TouK/ThrowingFunction/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TouK/ThrowingFunction/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TouK/ThrowingFunction/git/refs{/sha}","trees_url":"https://api.github.com/repos/TouK/ThrowingFunction/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TouK/ThrowingFunction/statuses/{sha}","languages_url":"https://api.github.com/repos/TouK/ThrowingFunction/languages","stargazers_url":"https://api.github.com/repos/TouK/ThrowingFunction/stargazers","contributors_url":"https://api.github.com/repos/TouK/ThrowingFunction/contributors","subscribers_url":"https://api.github.com/repos/TouK/ThrowingFunction/subscribers","subscription_url":"https://api.github.com/repos/TouK/ThrowingFunction/subscription","commits_url":"https://api.github.com/repos/TouK/ThrowingFunction/commits{/sha}","git_commits_url":"https://api.github.com/repos/TouK/ThrowingFunction/git/commits{/sha}","comments_url":"https://api.github.com/repos/TouK/ThrowingFunction/comments{/number}","issue_comment_url":"https://api.github.com/repos/TouK/ThrowingFunction/issues/comments{/number}","contents_url":"https://api.github.com/repos/TouK/ThrowingFunction/contents/{+path}","compare_url":"https://api.github.com/repos/TouK/ThrowingFunction/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TouK/ThrowingFunction/merges","archive_url":"https://api.github.com/repos/TouK/ThrowingFunction/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TouK/ThrowingFunction/downloads","issues_url":"https://api.github.com/repos/TouK/ThrowingFunction/issues{/number}","pulls_url":"https://api.github.com/repos/TouK/ThrowingFunction/pulls{/number}","milestones_url":"https://api.github.com/repos/TouK/ThrowingFunction/milestones{/number}","notifications_url":"https://api.github.com/repos/TouK/ThrowingFunction/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TouK/ThrowingFunction/labels{/name}","releases_url":"https://api.github.com/repos/TouK/ThrowingFunction/releases{/id}","deployments_url":"https://api.github.com/repos/TouK/ThrowingFunction/deployments","created_at":"2015-11-27T08:16:59Z","updated_at":"2017-01-18T10:26:12Z","pushed_at":"2017-02-17T12:39:15Z","git_url":"git://github.com/TouK/ThrowingFunction.git","ssh_url":"git@github.com:TouK/ThrowingFunction.git","clone_url":"https://github.com/TouK/ThrowingFunction.git","svn_url":"https://github.com/TouK/ThrowingFunction","homepage":null,"size":112,"stargazers_count":44,"watchers_count":44,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"open_issues_count":4,"forks":5,"open_issues":4,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/20"},"html":{"href":"https://github.com/TouK/ThrowingFunction/pull/20"},"issue":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/issues/20"},"comments":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/issues/20/comments"},"review_comments":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/20/comments"},"review_comment":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/pulls/20/commits"},"statuses":{"href":"https://api.github.com/repos/TouK/ThrowingFunction/statuses/603d2e8c4df98b23c3ed51ade7471658be55205f"}}}}
{"actor":{"display_login":"sputnikci"}}