{"action":"opened","number":21,"pull_request":{"url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls/21","id":153892843,"html_url":"https://github.com/ONSdigital/dp-dimension-importer/pull/21","diff_url":"https://github.com/ONSdigital/dp-dimension-importer/pull/21.diff","patch_url":"https://github.com/ONSdigital/dp-dimension-importer/pull/21.patch","issue_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues/21","number":21,"state":"open","locked":false,"title":"Feature/observation constraint","user":{"login":"CarlHembrough","id":1786012,"avatar_url":"https://avatars0.githubusercontent.com/u/1786012?v=4","gravatar_id":"","url":"https://api.github.com/users/CarlHembrough","html_url":"https://github.com/CarlHembrough","followers_url":"https://api.github.com/users/CarlHembrough/followers","following_url":"https://api.github.com/users/CarlHembrough/following{/other_user}","gists_url":"https://api.github.com/users/CarlHembrough/gists{/gist_id}","starred_url":"https://api.github.com/users/CarlHembrough/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CarlHembrough/subscriptions","organizations_url":"https://api.github.com/users/CarlHembrough/orgs","repos_url":"https://api.github.com/users/CarlHembrough/repos","events_url":"https://api.github.com/users/CarlHembrough/events{/privacy}","received_events_url":"https://api.github.com/users/CarlHembrough/received_events","type":"User","site_admin":false},"body":"### What\r\n\r\n* Added an additional call to create a constraint for observation nodes when processing a new instance.\r\n* Extracted some methods out of the handler.handle method\r\n* changed the existing `dimensions_extracted_generated_mocks.go` file name to `incoming_instance_generated_mocks.go` to match the updated handler name.\r\n\r\n### How to review\r\n\r\nStandard code review + testing\r\n\r\n### Who can review\r\n\r\nAnyone\r\n","created_at":"2017-11-21T13:40:36Z","updated_at":"2017-11-21T13:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls/21/commits","review_comments_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls/21/comments","review_comment_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues/21/comments","statuses_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/statuses/2371c512a823ba3ee081e4e2cbbb51ad453d96a8","head":{"label":"ONSdigital:feature/observation-constraint","ref":"feature/observation-constraint","sha":"2371c512a823ba3ee081e4e2cbbb51ad453d96a8","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":95766826,"name":"dp-dimension-importer","full_name":"ONSdigital/dp-dimension-importer","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/dp-dimension-importer","description":"Component that takes unique dimensions and writes them to the database.","fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer","forks_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/deployments","created_at":"2017-06-29T10:30:45Z","updated_at":"2017-11-10T02:19:36Z","pushed_at":"2017-11-20T16:58:15Z","git_url":"git://github.com/ONSdigital/dp-dimension-importer.git","ssh_url":"git@github.com:ONSdigital/dp-dimension-importer.git","clone_url":"https://github.com/ONSdigital/dp-dimension-importer.git","svn_url":"https://github.com/ONSdigital/dp-dimension-importer","homepage":null,"size":673,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"cmd-develop"}},"base":{"label":"ONSdigital:cmd-develop","ref":"cmd-develop","sha":"fd1b04e1c8036d64346a0fe9026f466af0961091","user":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"repo":{"id":95766826,"name":"dp-dimension-importer","full_name":"ONSdigital/dp-dimension-importer","owner":{"login":"ONSdigital","id":6865137,"avatar_url":"https://avatars0.githubusercontent.com/u/6865137?v=4","gravatar_id":"","url":"https://api.github.com/users/ONSdigital","html_url":"https://github.com/ONSdigital","followers_url":"https://api.github.com/users/ONSdigital/followers","following_url":"https://api.github.com/users/ONSdigital/following{/other_user}","gists_url":"https://api.github.com/users/ONSdigital/gists{/gist_id}","starred_url":"https://api.github.com/users/ONSdigital/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ONSdigital/subscriptions","organizations_url":"https://api.github.com/users/ONSdigital/orgs","repos_url":"https://api.github.com/users/ONSdigital/repos","events_url":"https://api.github.com/users/ONSdigital/events{/privacy}","received_events_url":"https://api.github.com/users/ONSdigital/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ONSdigital/dp-dimension-importer","description":"Component that takes unique dimensions and writes them to the database.","fork":false,"url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer","forks_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/forks","keys_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/teams","hooks_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/hooks","issue_events_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues/events{/number}","events_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/events","assignees_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/assignees{/user}","branches_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/branches{/branch}","tags_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/tags","blobs_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/statuses/{sha}","languages_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/languages","stargazers_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/stargazers","contributors_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/contributors","subscribers_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/subscribers","subscription_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/subscription","commits_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/contents/{+path}","compare_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/merges","archive_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/downloads","issues_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues{/number}","pulls_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls{/number}","milestones_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/milestones{/number}","notifications_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/labels{/name}","releases_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/releases{/id}","deployments_url":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/deployments","created_at":"2017-06-29T10:30:45Z","updated_at":"2017-11-10T02:19:36Z","pushed_at":"2017-11-20T16:58:15Z","git_url":"git://github.com/ONSdigital/dp-dimension-importer.git","ssh_url":"git@github.com:ONSdigital/dp-dimension-importer.git","clone_url":"https://github.com/ONSdigital/dp-dimension-importer.git","svn_url":"https://github.com/ONSdigital/dp-dimension-importer","homepage":null,"size":673,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"forks":0,"open_issues":1,"watchers":1,"default_branch":"cmd-develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls/21"},"html":{"href":"https://github.com/ONSdigital/dp-dimension-importer/pull/21"},"issue":{"href":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues/21"},"comments":{"href":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/ONSdigital/dp-dimension-importer/statuses/2371c512a823ba3ee081e4e2cbbb51ad453d96a8"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":546,"deletions":47,"changed_files":6}}
{"actor":{"display_login":"CarlHembrough"}}