{"action":"created","comment":{"url":"https://api.github.com/repos/vberger/smithay/pulls/comments/112143125","pull_request_review_id":33434019,"id":112143125,"diff_hunk":"@@ -216,6 +231,9 @@ pub trait InputBackend: Sized {\n     /// Get current `InputConfig`\n     fn input_config(&mut self) -> &mut Self::InputConfig;\n \n+    /// Called to inform the Input backend about a new focused Output for a `Seat`\n+    fn set_output_metadata(&mut self, seat: &Seat, output: &Output);","path":"src/backend/input.rs","position":103,"original_position":34,"commit_id":"9b6273f2971c4faaa77719c4193e649c42530262","original_commit_id":"9b6273f2971c4faaa77719c4193e649c42530262","user":{"login":"Drakulix","id":4404502,"avatar_url":"https://avatars1.githubusercontent.com/u/4404502?v=3","gravatar_id":"","url":"https://api.github.com/users/Drakulix","html_url":"https://github.com/Drakulix","followers_url":"https://api.github.com/users/Drakulix/followers","following_url":"https://api.github.com/users/Drakulix/following{/other_user}","gists_url":"https://api.github.com/users/Drakulix/gists{/gist_id}","starred_url":"https://api.github.com/users/Drakulix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drakulix/subscriptions","organizations_url":"https://api.github.com/users/Drakulix/orgs","repos_url":"https://api.github.com/users/Drakulix/repos","events_url":"https://api.github.com/users/Drakulix/events{/privacy}","received_events_url":"https://api.github.com/users/Drakulix/received_events","type":"User","site_admin":false},"body":"Generics would make `InputHandler` not object-safe, which is problematic for the `InputBackend` (just try it, this was the only solution I did found).\r\n\r\nI though this would be more extensible and gives a nice API for the backends (you could just implement `Input::Output` for the `GraphicsBackend`s specific output type). I also think we have an API hole here, currently it looks like every `GraphicsBackend` is meant to be exactly one output, which will not work with DRM. I have some idea for that, but that belongs into a seperate design issue.\r\n\r\n> Also, the question of device giving absolute positions (such as touchscreens) and locked to one output, independently of pointer focus remains.\r\n\r\nI would say this is something a concrete implementation should handle. Just don't call set_output_metadata more then once for that output in that case.","created_at":"2017-04-19T08:30:45Z","updated_at":"2017-04-19T08:30:45Z","html_url":"https://github.com/vberger/smithay/pull/15#discussion_r112143125","pull_request_url":"https://api.github.com/repos/vberger/smithay/pulls/15","_links":{"self":{"href":"https://api.github.com/repos/vberger/smithay/pulls/comments/112143125"},"html":{"href":"https://github.com/vberger/smithay/pull/15#discussion_r112143125"},"pull_request":{"href":"https://api.github.com/repos/vberger/smithay/pulls/15"}}},"pull_request":{"url":"https://api.github.com/repos/vberger/smithay/pulls/15","id":115998646,"html_url":"https://github.com/vberger/smithay/pull/15","diff_url":"https://github.com/vberger/smithay/pull/15.diff","patch_url":"https://github.com/vberger/smithay/pull/15.patch","issue_url":"https://api.github.com/repos/vberger/smithay/issues/15","number":15,"state":"open","locked":false,"title":"WIP: libinput backend","user":{"login":"Drakulix","id":4404502,"avatar_url":"https://avatars1.githubusercontent.com/u/4404502?v=3","gravatar_id":"","url":"https://api.github.com/users/Drakulix","html_url":"https://github.com/Drakulix","followers_url":"https://api.github.com/users/Drakulix/followers","following_url":"https://api.github.com/users/Drakulix/following{/other_user}","gists_url":"https://api.github.com/users/Drakulix/gists{/gist_id}","starred_url":"https://api.github.com/users/Drakulix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drakulix/subscriptions","organizations_url":"https://api.github.com/users/Drakulix/orgs","repos_url":"https://api.github.com/users/Drakulix/repos","events_url":"https://api.github.com/users/Drakulix/events{/privacy}","received_events_url":"https://api.github.com/users/Drakulix/received_events","type":"User","site_admin":false},"body":"A first version of [Drakulix/input.rs](https://github.com/Drakulix/input.rs) is finally done and on crates.io.\r\n\r\nSo I started building the backend in smithay. It's not done yet, but feedback is already welcome and this should make tracking progress easier.","created_at":"2017-04-14T22:31:24Z","updated_at":"2017-04-19T08:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"380d964d35555a386562f87f4cb9a869894c243a","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/vberger/smithay/pulls/15/commits","review_comments_url":"https://api.github.com/repos/vberger/smithay/pulls/15/comments","review_comment_url":"https://api.github.com/repos/vberger/smithay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vberger/smithay/issues/15/comments","statuses_url":"https://api.github.com/repos/vberger/smithay/statuses/9b6273f2971c4faaa77719c4193e649c42530262","head":{"label":"Drakulix:feature/libinput","ref":"feature/libinput","sha":"9b6273f2971c4faaa77719c4193e649c42530262","user":{"login":"Drakulix","id":4404502,"avatar_url":"https://avatars1.githubusercontent.com/u/4404502?v=3","gravatar_id":"","url":"https://api.github.com/users/Drakulix","html_url":"https://github.com/Drakulix","followers_url":"https://api.github.com/users/Drakulix/followers","following_url":"https://api.github.com/users/Drakulix/following{/other_user}","gists_url":"https://api.github.com/users/Drakulix/gists{/gist_id}","starred_url":"https://api.github.com/users/Drakulix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drakulix/subscriptions","organizations_url":"https://api.github.com/users/Drakulix/orgs","repos_url":"https://api.github.com/users/Drakulix/repos","events_url":"https://api.github.com/users/Drakulix/events{/privacy}","received_events_url":"https://api.github.com/users/Drakulix/received_events","type":"User","site_admin":false},"repo":{"id":83716870,"name":"smithay","full_name":"Drakulix/smithay","owner":{"login":"Drakulix","id":4404502,"avatar_url":"https://avatars1.githubusercontent.com/u/4404502?v=3","gravatar_id":"","url":"https://api.github.com/users/Drakulix","html_url":"https://github.com/Drakulix","followers_url":"https://api.github.com/users/Drakulix/followers","following_url":"https://api.github.com/users/Drakulix/following{/other_user}","gists_url":"https://api.github.com/users/Drakulix/gists{/gist_id}","starred_url":"https://api.github.com/users/Drakulix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Drakulix/subscriptions","organizations_url":"https://api.github.com/users/Drakulix/orgs","repos_url":"https://api.github.com/users/Drakulix/repos","events_url":"https://api.github.com/users/Drakulix/events{/privacy}","received_events_url":"https://api.github.com/users/Drakulix/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Drakulix/smithay","description":"A smithy for rusty wayland compositors","fork":true,"url":"https://api.github.com/repos/Drakulix/smithay","forks_url":"https://api.github.com/repos/Drakulix/smithay/forks","keys_url":"https://api.github.com/repos/Drakulix/smithay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Drakulix/smithay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Drakulix/smithay/teams","hooks_url":"https://api.github.com/repos/Drakulix/smithay/hooks","issue_events_url":"https://api.github.com/repos/Drakulix/smithay/issues/events{/number}","events_url":"https://api.github.com/repos/Drakulix/smithay/events","assignees_url":"https://api.github.com/repos/Drakulix/smithay/assignees{/user}","branches_url":"https://api.github.com/repos/Drakulix/smithay/branches{/branch}","tags_url":"https://api.github.com/repos/Drakulix/smithay/tags","blobs_url":"https://api.github.com/repos/Drakulix/smithay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Drakulix/smithay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Drakulix/smithay/git/refs{/sha}","trees_url":"https://api.github.com/repos/Drakulix/smithay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Drakulix/smithay/statuses/{sha}","languages_url":"https://api.github.com/repos/Drakulix/smithay/languages","stargazers_url":"https://api.github.com/repos/Drakulix/smithay/stargazers","contributors_url":"https://api.github.com/repos/Drakulix/smithay/contributors","subscribers_url":"https://api.github.com/repos/Drakulix/smithay/subscribers","subscription_url":"https://api.github.com/repos/Drakulix/smithay/subscription","commits_url":"https://api.github.com/repos/Drakulix/smithay/commits{/sha}","git_commits_url":"https://api.github.com/repos/Drakulix/smithay/git/commits{/sha}","comments_url":"https://api.github.com/repos/Drakulix/smithay/comments{/number}","issue_comment_url":"https://api.github.com/repos/Drakulix/smithay/issues/comments{/number}","contents_url":"https://api.github.com/repos/Drakulix/smithay/contents/{+path}","compare_url":"https://api.github.com/repos/Drakulix/smithay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Drakulix/smithay/merges","archive_url":"https://api.github.com/repos/Drakulix/smithay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Drakulix/smithay/downloads","issues_url":"https://api.github.com/repos/Drakulix/smithay/issues{/number}","pulls_url":"https://api.github.com/repos/Drakulix/smithay/pulls{/number}","milestones_url":"https://api.github.com/repos/Drakulix/smithay/milestones{/number}","notifications_url":"https://api.github.com/repos/Drakulix/smithay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Drakulix/smithay/labels{/name}","releases_url":"https://api.github.com/repos/Drakulix/smithay/releases{/id}","deployments_url":"https://api.github.com/repos/Drakulix/smithay/deployments","created_at":"2017-03-02T19:34:04Z","updated_at":"2017-03-02T19:34:06Z","pushed_at":"2017-04-18T19:58:04Z","git_url":"git://github.com/Drakulix/smithay.git","ssh_url":"git@github.com:Drakulix/smithay.git","clone_url":"https://github.com/Drakulix/smithay.git","svn_url":"https://github.com/Drakulix/smithay","homepage":null,"size":617,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vberger:master","ref":"master","sha":"c83792c5704d87a755ff0b8387dba71be6960596","user":{"login":"vberger","id":3009227,"avatar_url":"https://avatars0.githubusercontent.com/u/3009227?v=3","gravatar_id":"","url":"https://api.github.com/users/vberger","html_url":"https://github.com/vberger","followers_url":"https://api.github.com/users/vberger/followers","following_url":"https://api.github.com/users/vberger/following{/other_user}","gists_url":"https://api.github.com/users/vberger/gists{/gist_id}","starred_url":"https://api.github.com/users/vberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vberger/subscriptions","organizations_url":"https://api.github.com/users/vberger/orgs","repos_url":"https://api.github.com/users/vberger/repos","events_url":"https://api.github.com/users/vberger/events{/privacy}","received_events_url":"https://api.github.com/users/vberger/received_events","type":"User","site_admin":false},"repo":{"id":79542705,"name":"smithay","full_name":"vberger/smithay","owner":{"login":"vberger","id":3009227,"avatar_url":"https://avatars0.githubusercontent.com/u/3009227?v=3","gravatar_id":"","url":"https://api.github.com/users/vberger","html_url":"https://github.com/vberger","followers_url":"https://api.github.com/users/vberger/followers","following_url":"https://api.github.com/users/vberger/following{/other_user}","gists_url":"https://api.github.com/users/vberger/gists{/gist_id}","starred_url":"https://api.github.com/users/vberger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vberger/subscriptions","organizations_url":"https://api.github.com/users/vberger/orgs","repos_url":"https://api.github.com/users/vberger/repos","events_url":"https://api.github.com/users/vberger/events{/privacy}","received_events_url":"https://api.github.com/users/vberger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vberger/smithay","description":"A smithy for rusty wayland compositors","fork":false,"url":"https://api.github.com/repos/vberger/smithay","forks_url":"https://api.github.com/repos/vberger/smithay/forks","keys_url":"https://api.github.com/repos/vberger/smithay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vberger/smithay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vberger/smithay/teams","hooks_url":"https://api.github.com/repos/vberger/smithay/hooks","issue_events_url":"https://api.github.com/repos/vberger/smithay/issues/events{/number}","events_url":"https://api.github.com/repos/vberger/smithay/events","assignees_url":"https://api.github.com/repos/vberger/smithay/assignees{/user}","branches_url":"https://api.github.com/repos/vberger/smithay/branches{/branch}","tags_url":"https://api.github.com/repos/vberger/smithay/tags","blobs_url":"https://api.github.com/repos/vberger/smithay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vberger/smithay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vberger/smithay/git/refs{/sha}","trees_url":"https://api.github.com/repos/vberger/smithay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vberger/smithay/statuses/{sha}","languages_url":"https://api.github.com/repos/vberger/smithay/languages","stargazers_url":"https://api.github.com/repos/vberger/smithay/stargazers","contributors_url":"https://api.github.com/repos/vberger/smithay/contributors","subscribers_url":"https://api.github.com/repos/vberger/smithay/subscribers","subscription_url":"https://api.github.com/repos/vberger/smithay/subscription","commits_url":"https://api.github.com/repos/vberger/smithay/commits{/sha}","git_commits_url":"https://api.github.com/repos/vberger/smithay/git/commits{/sha}","comments_url":"https://api.github.com/repos/vberger/smithay/comments{/number}","issue_comment_url":"https://api.github.com/repos/vberger/smithay/issues/comments{/number}","contents_url":"https://api.github.com/repos/vberger/smithay/contents/{+path}","compare_url":"https://api.github.com/repos/vberger/smithay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vberger/smithay/merges","archive_url":"https://api.github.com/repos/vberger/smithay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vberger/smithay/downloads","issues_url":"https://api.github.com/repos/vberger/smithay/issues{/number}","pulls_url":"https://api.github.com/repos/vberger/smithay/pulls{/number}","milestones_url":"https://api.github.com/repos/vberger/smithay/milestones{/number}","notifications_url":"https://api.github.com/repos/vberger/smithay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vberger/smithay/labels{/name}","releases_url":"https://api.github.com/repos/vberger/smithay/releases{/id}","deployments_url":"https://api.github.com/repos/vberger/smithay/deployments","created_at":"2017-01-20T08:53:24Z","updated_at":"2017-04-12T17:03:08Z","pushed_at":"2017-04-18T19:58:06Z","git_url":"git://github.com/vberger/smithay.git","ssh_url":"git@github.com:vberger/smithay.git","clone_url":"https://github.com/vberger/smithay.git","svn_url":"https://github.com/vberger/smithay","homepage":null,"size":4914,"stargazers_count":10,"watchers_count":10,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"open_issues_count":7,"forks":3,"open_issues":7,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vberger/smithay/pulls/15"},"html":{"href":"https://github.com/vberger/smithay/pull/15"},"issue":{"href":"https://api.github.com/repos/vberger/smithay/issues/15"},"comments":{"href":"https://api.github.com/repos/vberger/smithay/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/vberger/smithay/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/vberger/smithay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vberger/smithay/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/vberger/smithay/statuses/9b6273f2971c4faaa77719c4193e649c42530262"}}}}
{"actor":{"display_login":"Drakulix"}}