{"action":"created","issue":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/5701","repository_url":"https://api.github.com/repos/RobotLocomotion/drake","labels_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/5701/labels{/name}","comments_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/5701/comments","events_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/5701/events","html_url":"https://github.com/RobotLocomotion/drake/pull/5701","id":218815972,"number":5701,"title":"Add MobilPlanner as a benchmark for lane switching","user":{"login":"jadecastro","id":1655653,"avatar_url":"https://avatars1.githubusercontent.com/u/1655653?v=3","gravatar_id":"","url":"https://api.github.com/users/jadecastro","html_url":"https://github.com/jadecastro","followers_url":"https://api.github.com/users/jadecastro/followers","following_url":"https://api.github.com/users/jadecastro/following{/other_user}","gists_url":"https://api.github.com/users/jadecastro/gists{/gist_id}","starred_url":"https://api.github.com/users/jadecastro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jadecastro/subscriptions","organizations_url":"https://api.github.com/users/jadecastro/orgs","repos_url":"https://api.github.com/users/jadecastro/repos","events_url":"https://api.github.com/users/jadecastro/events{/privacy}","received_events_url":"https://api.github.com/users/jadecastro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars3.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"assignees":[{"login":"liangfok","id":1388098,"avatar_url":"https://avatars3.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2017-04-03T02:27:32Z","updated_at":"2017-04-03T14:21:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/RobotLocomotion/drake/pulls/5701","html_url":"https://github.com/RobotLocomotion/drake/pull/5701","diff_url":"https://github.com/RobotLocomotion/drake/pull/5701.diff","patch_url":"https://github.com/RobotLocomotion/drake/pull/5701.patch"},"body":"Also reconfigures `IdmControllerTest` to share some of the test functionality with `MobilPlannerTest`.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/robotlocomotion/drake/5701)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RobotLocomotion/drake/issues/comments/291158031","html_url":"https://github.com/RobotLocomotion/drake/pull/5701#issuecomment-291158031","issue_url":"https://api.github.com/repos/RobotLocomotion/drake/issues/5701","id":291158031,"user":{"login":"liangfok","id":1388098,"avatar_url":"https://avatars3.githubusercontent.com/u/1388098?v=3","gravatar_id":"","url":"https://api.github.com/users/liangfok","html_url":"https://github.com/liangfok","followers_url":"https://api.github.com/users/liangfok/followers","following_url":"https://api.github.com/users/liangfok/following{/other_user}","gists_url":"https://api.github.com/users/liangfok/gists{/gist_id}","starred_url":"https://api.github.com/users/liangfok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liangfok/subscriptions","organizations_url":"https://api.github.com/users/liangfok/orgs","repos_url":"https://api.github.com/users/liangfok/repos","events_url":"https://api.github.com/users/liangfok/events{/privacy}","received_events_url":"https://api.github.com/users/liangfok/received_events","type":"User","site_admin":false},"created_at":"2017-04-03T14:21:40Z","updated_at":"2017-04-03T14:21:40Z","body":"Checkpoint.\n\n---\n\nReviewed 2 of 14 files at r1.\nReview status: 12 of 14 files reviewed at latest revision, 21 unresolved discussions.\n\n---\n\n*[drake/automotive/idm_controller.cc, line 18 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/5701#-KgoAwZ-KNoiIXbq5KiH:-KgoAwZ-KNoiIXbq5KiI:b-m0houe) ([raw file](https://github.com/robotlocomotion/drake/blob/64e14d56949d9bad7d419d4204419f4cc56217e3/drake/automotive/idm_controller.cc#L18)):*\n> ```cpp\n> using maliput::api::Rotation;\n> using math::saturate;\n> using automotive::pose_selector::RoadOdometry;\n> ```\n\nBTW, alpha sort.\n\n---\n\n*[drake/automotive/pose_selector.cc, line 87 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/5701#-KgoAklhFEGJ5Myk-V-5:-KgoAklhFEGJ5Myk-V-6:bboa4x4) ([raw file](https://github.com/robotlocomotion/drake/blob/64e14d56949d9bad7d419d4204419f4cc56217e3/drake/automotive/pose_selector.cc#L87)):*\n> ```cpp\n>   const double vy = road_odom.vel.get_velocity().translational().y();\n> \n>   return vx * std::cos(rot.yaw) + vy * std::sin(rot.yaw);\n> ```\n\nBTW, focused unit test coverage? (I know this code was extracted from `idm_controller.cc`, but now that it's separate, maybe it needs its own unit test coverage.)\n\n---\n\n*[drake/automotive/pose_selector.h, line 83 at r1](https://reviewable.io:443/reviews/robotlocomotion/drake/5701#-KgoA_YTu6k-NjYKao2a:-KgoA_YUPE2L8ESnCWYv:b-j8ac2x) ([raw file](https://github.com/robotlocomotion/drake/blob/64e14d56949d9bad7d419d4204419f4cc56217e3/drake/automotive/pose_selector.h#L83)):*\n> ```objc\n> \n> // Extracts the vehicle's `s`-direction velocity based on its RoadPosition @p\n> // pos and FrameVelocity @p vel.  Assumes the road has zero elevation.\n> ```\n\nI believe this method also assumes zero super-elevation, right?\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/robotlocomotion/drake/5701#-:-KgoBGgk3ofRxZwIb10M:by96gdd)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"liangfok"}}