{"action":"created","issue":{"url":"https://api.github.com/repos/hprose/hprose-python/issues/3","repository_url":"https://api.github.com/repos/hprose/hprose-python","labels_url":"https://api.github.com/repos/hprose/hprose-python/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/hprose/hprose-python/issues/3/comments","events_url":"https://api.github.com/repos/hprose/hprose-python/issues/3/events","html_url":"https://github.com/hprose/hprose-python/pull/3","id":225932120,"number":3,"title":"Tornado AsyncHTTPClient Support","user":{"login":"rsj217","id":1689622,"avatar_url":"https://avatars1.githubusercontent.com/u/1689622?v=3","gravatar_id":"","url":"https://api.github.com/users/rsj217","html_url":"https://github.com/rsj217","followers_url":"https://api.github.com/users/rsj217/followers","following_url":"https://api.github.com/users/rsj217/following{/other_user}","gists_url":"https://api.github.com/users/rsj217/gists{/gist_id}","starred_url":"https://api.github.com/users/rsj217/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsj217/subscriptions","organizations_url":"https://api.github.com/users/rsj217/orgs","repos_url":"https://api.github.com/users/rsj217/repos","events_url":"https://api.github.com/users/rsj217/events{/privacy}","received_events_url":"https://api.github.com/users/rsj217/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-05-03T09:44:43Z","updated_at":"2017-05-06T01:19:25Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/hprose/hprose-python/pulls/3","html_url":"https://github.com/hprose/hprose-python/pull/3","diff_url":"https://github.com/hprose/hprose-python/pull/3.diff","patch_url":"https://github.com/hprose/hprose-python/pull/3.patch"},"body":"Hi `hprose`，考察了一些`rpc`，发现这个项目挺不错。由于我常用`Tornado`，而`hprose`的`python`客户端使用的是`HTTPSConnection`，在`tornado`的`handler`请求会block进程，因此fork了一个版本，添加了对 AsyncHTTPClient的支持。\r\n\r\n只是在发起http请求的时候做了替换，由基类`HproseClient`部分方法是私有，继承的`HTTPTornadoClient`无法调用，也同步修改了`httpclient.py`文件的一些方法类型。\r\n\r\n至于二进制协议的编码和解码，依然沿用之前的方法。提交`merge request`前在example中添加了一些demo并做了测试。\r\n\r\nPS： 为了使用进行了简单的hack，有些改动则是编辑器PEP给格式化了，自己的代码写得不是很好，希望多多指教哈~"},"comment":{"url":"https://api.github.com/repos/hprose/hprose-python/issues/comments/299606604","html_url":"https://github.com/hprose/hprose-python/pull/3#issuecomment-299606604","issue_url":"https://api.github.com/repos/hprose/hprose-python/issues/3","id":299606604,"user":{"login":"andot","id":232161,"avatar_url":"https://avatars0.githubusercontent.com/u/232161?v=3","gravatar_id":"","url":"https://api.github.com/users/andot","html_url":"https://github.com/andot","followers_url":"https://api.github.com/users/andot/followers","following_url":"https://api.github.com/users/andot/following{/other_user}","gists_url":"https://api.github.com/users/andot/gists{/gist_id}","starred_url":"https://api.github.com/users/andot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andot/subscriptions","organizations_url":"https://api.github.com/users/andot/orgs","repos_url":"https://api.github.com/users/andot/repos","events_url":"https://api.github.com/users/andot/events{/privacy}","received_events_url":"https://api.github.com/users/andot/received_events","type":"User","site_admin":false},"created_at":"2017-05-06T01:19:25Z","updated_at":"2017-05-06T01:19:25Z","body":"你修改的代码是 python3 下面的，这个下面的是针对 python 3.0+的代码。python2下面是针对 python 2.3+的代码。即使你修改的是 python2 下面的代码，即使兼容 python 2.7，但是否能够兼容到 2.3 也不好说。另外，你加入了对 tornado 的依赖，而 hprose 中是不依赖这种库的，所以，这个你只能开个分支自己来用了。"}}
{"actor":{"display_login":"andot"}}