{"action":"closed","number":276,"pull_request":{"url":"https://api.github.com/repos/grommet/grommet-docs/pulls/276","id":129266021,"html_url":"https://github.com/grommet/grommet-docs/pull/276","diff_url":"https://github.com/grommet/grommet-docs/pull/276.diff","patch_url":"https://github.com/grommet/grommet-docs/pull/276.patch","issue_url":"https://api.github.com/repos/grommet/grommet-docs/issues/276","number":276,"state":"closed","locked":false,"title":"Fixes #1395 - some FormField props aren't documented.","user":{"login":"cherih","id":25066338,"avatar_url":"https://avatars1.githubusercontent.com/u/25066338?v=3","gravatar_id":"","url":"https://api.github.com/users/cherih","html_url":"https://github.com/cherih","followers_url":"https://api.github.com/users/cherih/followers","following_url":"https://api.github.com/users/cherih/following{/other_user}","gists_url":"https://api.github.com/users/cherih/gists{/gist_id}","starred_url":"https://api.github.com/users/cherih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherih/subscriptions","organizations_url":"https://api.github.com/users/cherih/orgs","repos_url":"https://api.github.com/users/cherih/repos","events_url":"https://api.github.com/users/cherih/events{/privacy}","received_events_url":"https://api.github.com/users/cherih/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of the PR in the Title above -->\r\n\r\n#### What does this PR do?\r\nAdds documentation for the hidden, size and strong properties of the FormField component.\r\n\r\n#### Where should the reviewer start?\r\nLine 49 of FormFieldDoc.js.\r\n\r\n#### What testing has been done on this PR?\r\nManual testing of the changes in my sandbox.\r\n\r\n#### How should this be manually tested?\r\nPull the change into your sandbox and build grommet.io. Browse to the FormField component page and find the properties that were added.\r\n\r\n#### Any background context you want to provide?\r\nThis documents the properties as they are currently used (i.e. for input text in a FormField). \r\n\r\n#### What are the relevant issues?\r\nSupport for these properties will most likely be removed in Grommet 2.0.\r\n\r\n#### Screenshots (if appropriate)\r\n","created_at":"2017-07-06T19:45:55Z","updated_at":"2017-07-06T20:24:08Z","closed_at":"2017-07-06T20:24:08Z","merged_at":"2017-07-06T20:24:08Z","merge_commit_sha":"2e0fbb3db855aeda655cc7581a0859a2c3db2253","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/grommet/grommet-docs/pulls/276/commits","review_comments_url":"https://api.github.com/repos/grommet/grommet-docs/pulls/276/comments","review_comment_url":"https://api.github.com/repos/grommet/grommet-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grommet/grommet-docs/issues/276/comments","statuses_url":"https://api.github.com/repos/grommet/grommet-docs/statuses/c5a844c837298e5d0b6570f9ed6109f99af3083d","head":{"label":"cherih:master","ref":"master","sha":"c5a844c837298e5d0b6570f9ed6109f99af3083d","user":{"login":"cherih","id":25066338,"avatar_url":"https://avatars1.githubusercontent.com/u/25066338?v=3","gravatar_id":"","url":"https://api.github.com/users/cherih","html_url":"https://github.com/cherih","followers_url":"https://api.github.com/users/cherih/followers","following_url":"https://api.github.com/users/cherih/following{/other_user}","gists_url":"https://api.github.com/users/cherih/gists{/gist_id}","starred_url":"https://api.github.com/users/cherih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherih/subscriptions","organizations_url":"https://api.github.com/users/cherih/orgs","repos_url":"https://api.github.com/users/cherih/repos","events_url":"https://api.github.com/users/cherih/events{/privacy}","received_events_url":"https://api.github.com/users/cherih/received_events","type":"User","site_admin":false},"repo":{"id":95264659,"name":"grommet-docs","full_name":"cherih/grommet-docs","owner":{"login":"cherih","id":25066338,"avatar_url":"https://avatars1.githubusercontent.com/u/25066338?v=3","gravatar_id":"","url":"https://api.github.com/users/cherih","html_url":"https://github.com/cherih","followers_url":"https://api.github.com/users/cherih/followers","following_url":"https://api.github.com/users/cherih/following{/other_user}","gists_url":"https://api.github.com/users/cherih/gists{/gist_id}","starred_url":"https://api.github.com/users/cherih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cherih/subscriptions","organizations_url":"https://api.github.com/users/cherih/orgs","repos_url":"https://api.github.com/users/cherih/repos","events_url":"https://api.github.com/users/cherih/events{/privacy}","received_events_url":"https://api.github.com/users/cherih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cherih/grommet-docs","description":"Website project for Grommet framework (http://grommet.io)","fork":true,"url":"https://api.github.com/repos/cherih/grommet-docs","forks_url":"https://api.github.com/repos/cherih/grommet-docs/forks","keys_url":"https://api.github.com/repos/cherih/grommet-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cherih/grommet-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cherih/grommet-docs/teams","hooks_url":"https://api.github.com/repos/cherih/grommet-docs/hooks","issue_events_url":"https://api.github.com/repos/cherih/grommet-docs/issues/events{/number}","events_url":"https://api.github.com/repos/cherih/grommet-docs/events","assignees_url":"https://api.github.com/repos/cherih/grommet-docs/assignees{/user}","branches_url":"https://api.github.com/repos/cherih/grommet-docs/branches{/branch}","tags_url":"https://api.github.com/repos/cherih/grommet-docs/tags","blobs_url":"https://api.github.com/repos/cherih/grommet-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cherih/grommet-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cherih/grommet-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cherih/grommet-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cherih/grommet-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/cherih/grommet-docs/languages","stargazers_url":"https://api.github.com/repos/cherih/grommet-docs/stargazers","contributors_url":"https://api.github.com/repos/cherih/grommet-docs/contributors","subscribers_url":"https://api.github.com/repos/cherih/grommet-docs/subscribers","subscription_url":"https://api.github.com/repos/cherih/grommet-docs/subscription","commits_url":"https://api.github.com/repos/cherih/grommet-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cherih/grommet-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cherih/grommet-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cherih/grommet-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cherih/grommet-docs/contents/{+path}","compare_url":"https://api.github.com/repos/cherih/grommet-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cherih/grommet-docs/merges","archive_url":"https://api.github.com/repos/cherih/grommet-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cherih/grommet-docs/downloads","issues_url":"https://api.github.com/repos/cherih/grommet-docs/issues{/number}","pulls_url":"https://api.github.com/repos/cherih/grommet-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/cherih/grommet-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/cherih/grommet-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cherih/grommet-docs/labels{/name}","releases_url":"https://api.github.com/repos/cherih/grommet-docs/releases{/id}","deployments_url":"https://api.github.com/repos/cherih/grommet-docs/deployments","created_at":"2017-06-24T00:00:34Z","updated_at":"2017-06-24T00:00:36Z","pushed_at":"2017-07-06T20:01:55Z","git_url":"git://github.com/cherih/grommet-docs.git","ssh_url":"git@github.com:cherih/grommet-docs.git","clone_url":"https://github.com/cherih/grommet-docs.git","svn_url":"https://github.com/cherih/grommet-docs","homepage":null,"size":45081,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"grommet:master","ref":"master","sha":"7ecff575f44d78c746b71612ae510fc8ba85020f","user":{"login":"grommet","id":14203820,"avatar_url":"https://avatars0.githubusercontent.com/u/14203820?v=3","gravatar_id":"","url":"https://api.github.com/users/grommet","html_url":"https://github.com/grommet","followers_url":"https://api.github.com/users/grommet/followers","following_url":"https://api.github.com/users/grommet/following{/other_user}","gists_url":"https://api.github.com/users/grommet/gists{/gist_id}","starred_url":"https://api.github.com/users/grommet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grommet/subscriptions","organizations_url":"https://api.github.com/users/grommet/orgs","repos_url":"https://api.github.com/users/grommet/repos","events_url":"https://api.github.com/users/grommet/events{/privacy}","received_events_url":"https://api.github.com/users/grommet/received_events","type":"Organization","site_admin":false},"repo":{"id":44203721,"name":"grommet-docs","full_name":"grommet/grommet-docs","owner":{"login":"grommet","id":14203820,"avatar_url":"https://avatars0.githubusercontent.com/u/14203820?v=3","gravatar_id":"","url":"https://api.github.com/users/grommet","html_url":"https://github.com/grommet","followers_url":"https://api.github.com/users/grommet/followers","following_url":"https://api.github.com/users/grommet/following{/other_user}","gists_url":"https://api.github.com/users/grommet/gists{/gist_id}","starred_url":"https://api.github.com/users/grommet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grommet/subscriptions","organizations_url":"https://api.github.com/users/grommet/orgs","repos_url":"https://api.github.com/users/grommet/repos","events_url":"https://api.github.com/users/grommet/events{/privacy}","received_events_url":"https://api.github.com/users/grommet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/grommet/grommet-docs","description":"Website project for Grommet framework (http://grommet.io)","fork":false,"url":"https://api.github.com/repos/grommet/grommet-docs","forks_url":"https://api.github.com/repos/grommet/grommet-docs/forks","keys_url":"https://api.github.com/repos/grommet/grommet-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grommet/grommet-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grommet/grommet-docs/teams","hooks_url":"https://api.github.com/repos/grommet/grommet-docs/hooks","issue_events_url":"https://api.github.com/repos/grommet/grommet-docs/issues/events{/number}","events_url":"https://api.github.com/repos/grommet/grommet-docs/events","assignees_url":"https://api.github.com/repos/grommet/grommet-docs/assignees{/user}","branches_url":"https://api.github.com/repos/grommet/grommet-docs/branches{/branch}","tags_url":"https://api.github.com/repos/grommet/grommet-docs/tags","blobs_url":"https://api.github.com/repos/grommet/grommet-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grommet/grommet-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grommet/grommet-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/grommet/grommet-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grommet/grommet-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/grommet/grommet-docs/languages","stargazers_url":"https://api.github.com/repos/grommet/grommet-docs/stargazers","contributors_url":"https://api.github.com/repos/grommet/grommet-docs/contributors","subscribers_url":"https://api.github.com/repos/grommet/grommet-docs/subscribers","subscription_url":"https://api.github.com/repos/grommet/grommet-docs/subscription","commits_url":"https://api.github.com/repos/grommet/grommet-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/grommet/grommet-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/grommet/grommet-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/grommet/grommet-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/grommet/grommet-docs/contents/{+path}","compare_url":"https://api.github.com/repos/grommet/grommet-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grommet/grommet-docs/merges","archive_url":"https://api.github.com/repos/grommet/grommet-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grommet/grommet-docs/downloads","issues_url":"https://api.github.com/repos/grommet/grommet-docs/issues{/number}","pulls_url":"https://api.github.com/repos/grommet/grommet-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/grommet/grommet-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/grommet/grommet-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grommet/grommet-docs/labels{/name}","releases_url":"https://api.github.com/repos/grommet/grommet-docs/releases{/id}","deployments_url":"https://api.github.com/repos/grommet/grommet-docs/deployments","created_at":"2015-10-13T20:44:52Z","updated_at":"2017-06-14T20:42:14Z","pushed_at":"2017-07-06T20:24:08Z","git_url":"git://github.com/grommet/grommet-docs.git","ssh_url":"git@github.com:grommet/grommet-docs.git","clone_url":"https://github.com/grommet/grommet-docs.git","svn_url":"https://github.com/grommet/grommet-docs","homepage":null,"size":45082,"stargazers_count":18,"watchers_count":18,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"open_issues_count":9,"forks":49,"open_issues":9,"watchers":18,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grommet/grommet-docs/pulls/276"},"html":{"href":"https://github.com/grommet/grommet-docs/pull/276"},"issue":{"href":"https://api.github.com/repos/grommet/grommet-docs/issues/276"},"comments":{"href":"https://api.github.com/repos/grommet/grommet-docs/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/grommet/grommet-docs/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/grommet/grommet-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grommet/grommet-docs/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/grommet/grommet-docs/statuses/c5a844c837298e5d0b6570f9ed6109f99af3083d"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"alansouzati","id":1207250,"avatar_url":"https://avatars2.githubusercontent.com/u/1207250?v=3","gravatar_id":"","url":"https://api.github.com/users/alansouzati","html_url":"https://github.com/alansouzati","followers_url":"https://api.github.com/users/alansouzati/followers","following_url":"https://api.github.com/users/alansouzati/following{/other_user}","gists_url":"https://api.github.com/users/alansouzati/gists{/gist_id}","starred_url":"https://api.github.com/users/alansouzati/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alansouzati/subscriptions","organizations_url":"https://api.github.com/users/alansouzati/orgs","repos_url":"https://api.github.com/users/alansouzati/repos","events_url":"https://api.github.com/users/alansouzati/events{/privacy}","received_events_url":"https://api.github.com/users/alansouzati/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":12,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"alansouzati"}}