{"action":"created","comment":{"url":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/comments/98224518","pull_request_review_id":18861456,"id":98224518,"diff_hunk":"@@ -662,7 +663,18 @@ fn start_gluster_volume(volume_name: &str) -> Result<(), String> {\n                       Some(LogLevel::Info));\n             status_set!(Active \"Starting volume succeeded.\");\n             mount_cluster(&volume_name)?;\n-            // Update the juju status\n+            let mut settings: Vec<GlusterOption> = Vec::new();\n+            // Starting in gluster 3.8 NFS is disabled in favor of ganesha.  I'd like to stick\n+            // with the legacy version a bit longer.\n+            settings.push(GlusterOption::NfsDisable(Toggle::Off));\n+            // Set the split brain policy if requested\n+            if let Ok(splitbrain_policy) = juju::config_get(\"splitbrain_policy\") {\n+                let policy =\n+                    SplitBrainPolicy::from_str(&splitbrain_policy).map_err(|e| e.to_string())?;","path":"src/main.rs","position":20,"original_position":20,"commit_id":"eda5b0ad06c87dcdc530a9b9b1a01b1aab8d0dfa","original_commit_id":"eda5b0ad06c87dcdc530a9b9b1a01b1aab8d0dfa","user":{"login":"ChrisMacNaughton","id":429739,"avatar_url":"https://avatars.githubusercontent.com/u/429739?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisMacNaughton","html_url":"https://github.com/ChrisMacNaughton","followers_url":"https://api.github.com/users/ChrisMacNaughton/followers","following_url":"https://api.github.com/users/ChrisMacNaughton/following{/other_user}","gists_url":"https://api.github.com/users/ChrisMacNaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisMacNaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisMacNaughton/subscriptions","organizations_url":"https://api.github.com/users/ChrisMacNaughton/orgs","repos_url":"https://api.github.com/users/ChrisMacNaughton/repos","events_url":"https://api.github.com/users/ChrisMacNaughton/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisMacNaughton/received_events","type":"User","site_admin":false},"body":"You may want to match on the from_str instead so that an Err is ignored / logged rather than failing the whole hook?","created_at":"2017-01-27T15:28:23Z","updated_at":"2017-01-27T15:28:23Z","html_url":"https://github.com/cholcombe973/gluster-charm/pull/13#discussion_r98224518","pull_request_url":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/13","_links":{"self":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/comments/98224518"},"html":{"href":"https://github.com/cholcombe973/gluster-charm/pull/13#discussion_r98224518"},"pull_request":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/13","id":103415046,"html_url":"https://github.com/cholcombe973/gluster-charm/pull/13","diff_url":"https://github.com/cholcombe973/gluster-charm/pull/13.diff","patch_url":"https://github.com/cholcombe973/gluster-charm/pull/13.patch","issue_url":"https://api.github.com/repos/cholcombe973/gluster-charm/issues/13","number":13,"state":"open","locked":false,"title":"Favorite child policy","user":{"login":"cholcombe973","id":3058195,"avatar_url":"https://avatars.githubusercontent.com/u/3058195?v=3","gravatar_id":"","url":"https://api.github.com/users/cholcombe973","html_url":"https://github.com/cholcombe973","followers_url":"https://api.github.com/users/cholcombe973/followers","following_url":"https://api.github.com/users/cholcombe973/following{/other_user}","gists_url":"https://api.github.com/users/cholcombe973/gists{/gist_id}","starred_url":"https://api.github.com/users/cholcombe973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cholcombe973/subscriptions","organizations_url":"https://api.github.com/users/cholcombe973/orgs","repos_url":"https://api.github.com/users/cholcombe973/repos","events_url":"https://api.github.com/users/cholcombe973/events{/privacy}","received_events_url":"https://api.github.com/users/cholcombe973/received_events","type":"User","site_admin":false},"body":"This PR adds support to allow charm users to pick a policy so that split brain files can be automatically fixed.  ","created_at":"2017-01-26T23:53:43Z","updated_at":"2017-01-27T15:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"317d03306a44d6479f2c02b5380dfcf330a8fcd4","assignee":{"login":"ChrisMacNaughton","id":429739,"avatar_url":"https://avatars.githubusercontent.com/u/429739?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisMacNaughton","html_url":"https://github.com/ChrisMacNaughton","followers_url":"https://api.github.com/users/ChrisMacNaughton/followers","following_url":"https://api.github.com/users/ChrisMacNaughton/following{/other_user}","gists_url":"https://api.github.com/users/ChrisMacNaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisMacNaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisMacNaughton/subscriptions","organizations_url":"https://api.github.com/users/ChrisMacNaughton/orgs","repos_url":"https://api.github.com/users/ChrisMacNaughton/repos","events_url":"https://api.github.com/users/ChrisMacNaughton/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisMacNaughton/received_events","type":"User","site_admin":false},"assignees":[{"login":"ChrisMacNaughton","id":429739,"avatar_url":"https://avatars.githubusercontent.com/u/429739?v=3","gravatar_id":"","url":"https://api.github.com/users/ChrisMacNaughton","html_url":"https://github.com/ChrisMacNaughton","followers_url":"https://api.github.com/users/ChrisMacNaughton/followers","following_url":"https://api.github.com/users/ChrisMacNaughton/following{/other_user}","gists_url":"https://api.github.com/users/ChrisMacNaughton/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisMacNaughton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisMacNaughton/subscriptions","organizations_url":"https://api.github.com/users/ChrisMacNaughton/orgs","repos_url":"https://api.github.com/users/ChrisMacNaughton/repos","events_url":"https://api.github.com/users/ChrisMacNaughton/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisMacNaughton/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/13/commits","review_comments_url":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/13/comments","review_comment_url":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cholcombe973/gluster-charm/issues/13/comments","statuses_url":"https://api.github.com/repos/cholcombe973/gluster-charm/statuses/eda5b0ad06c87dcdc530a9b9b1a01b1aab8d0dfa","head":{"label":"cholcombe973:favorite-child-policy","ref":"favorite-child-policy","sha":"eda5b0ad06c87dcdc530a9b9b1a01b1aab8d0dfa","user":{"login":"cholcombe973","id":3058195,"avatar_url":"https://avatars.githubusercontent.com/u/3058195?v=3","gravatar_id":"","url":"https://api.github.com/users/cholcombe973","html_url":"https://github.com/cholcombe973","followers_url":"https://api.github.com/users/cholcombe973/followers","following_url":"https://api.github.com/users/cholcombe973/following{/other_user}","gists_url":"https://api.github.com/users/cholcombe973/gists{/gist_id}","starred_url":"https://api.github.com/users/cholcombe973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cholcombe973/subscriptions","organizations_url":"https://api.github.com/users/cholcombe973/orgs","repos_url":"https://api.github.com/users/cholcombe973/repos","events_url":"https://api.github.com/users/cholcombe973/events{/privacy}","received_events_url":"https://api.github.com/users/cholcombe973/received_events","type":"User","site_admin":false},"repo":{"id":38644285,"name":"gluster-charm","full_name":"cholcombe973/gluster-charm","owner":{"login":"cholcombe973","id":3058195,"avatar_url":"https://avatars.githubusercontent.com/u/3058195?v=3","gravatar_id":"","url":"https://api.github.com/users/cholcombe973","html_url":"https://github.com/cholcombe973","followers_url":"https://api.github.com/users/cholcombe973/followers","following_url":"https://api.github.com/users/cholcombe973/following{/other_user}","gists_url":"https://api.github.com/users/cholcombe973/gists{/gist_id}","starred_url":"https://api.github.com/users/cholcombe973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cholcombe973/subscriptions","organizations_url":"https://api.github.com/users/cholcombe973/orgs","repos_url":"https://api.github.com/users/cholcombe973/repos","events_url":"https://api.github.com/users/cholcombe973/events{/privacy}","received_events_url":"https://api.github.com/users/cholcombe973/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cholcombe973/gluster-charm","description":"Juju Gluster Charm","fork":false,"url":"https://api.github.com/repos/cholcombe973/gluster-charm","forks_url":"https://api.github.com/repos/cholcombe973/gluster-charm/forks","keys_url":"https://api.github.com/repos/cholcombe973/gluster-charm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cholcombe973/gluster-charm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cholcombe973/gluster-charm/teams","hooks_url":"https://api.github.com/repos/cholcombe973/gluster-charm/hooks","issue_events_url":"https://api.github.com/repos/cholcombe973/gluster-charm/issues/events{/number}","events_url":"https://api.github.com/repos/cholcombe973/gluster-charm/events","assignees_url":"https://api.github.com/repos/cholcombe973/gluster-charm/assignees{/user}","branches_url":"https://api.github.com/repos/cholcombe973/gluster-charm/branches{/branch}","tags_url":"https://api.github.com/repos/cholcombe973/gluster-charm/tags","blobs_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cholcombe973/gluster-charm/statuses/{sha}","languages_url":"https://api.github.com/repos/cholcombe973/gluster-charm/languages","stargazers_url":"https://api.github.com/repos/cholcombe973/gluster-charm/stargazers","contributors_url":"https://api.github.com/repos/cholcombe973/gluster-charm/contributors","subscribers_url":"https://api.github.com/repos/cholcombe973/gluster-charm/subscribers","subscription_url":"https://api.github.com/repos/cholcombe973/gluster-charm/subscription","commits_url":"https://api.github.com/repos/cholcombe973/gluster-charm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cholcombe973/gluster-charm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cholcombe973/gluster-charm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cholcombe973/gluster-charm/contents/{+path}","compare_url":"https://api.github.com/repos/cholcombe973/gluster-charm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cholcombe973/gluster-charm/merges","archive_url":"https://api.github.com/repos/cholcombe973/gluster-charm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cholcombe973/gluster-charm/downloads","issues_url":"https://api.github.com/repos/cholcombe973/gluster-charm/issues{/number}","pulls_url":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls{/number}","milestones_url":"https://api.github.com/repos/cholcombe973/gluster-charm/milestones{/number}","notifications_url":"https://api.github.com/repos/cholcombe973/gluster-charm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cholcombe973/gluster-charm/labels{/name}","releases_url":"https://api.github.com/repos/cholcombe973/gluster-charm/releases{/id}","deployments_url":"https://api.github.com/repos/cholcombe973/gluster-charm/deployments","created_at":"2015-07-06T20:31:10Z","updated_at":"2017-01-26T20:31:39Z","pushed_at":"2017-01-27T00:07:40Z","git_url":"git://github.com/cholcombe973/gluster-charm.git","ssh_url":"git@github.com:cholcombe973/gluster-charm.git","clone_url":"https://github.com/cholcombe973/gluster-charm.git","svn_url":"https://github.com/cholcombe973/gluster-charm","homepage":"","size":23441,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":5,"default_branch":"master"}},"base":{"label":"cholcombe973:master","ref":"master","sha":"9f512654b2911d57e89847fbd77d6943695945d1","user":{"login":"cholcombe973","id":3058195,"avatar_url":"https://avatars.githubusercontent.com/u/3058195?v=3","gravatar_id":"","url":"https://api.github.com/users/cholcombe973","html_url":"https://github.com/cholcombe973","followers_url":"https://api.github.com/users/cholcombe973/followers","following_url":"https://api.github.com/users/cholcombe973/following{/other_user}","gists_url":"https://api.github.com/users/cholcombe973/gists{/gist_id}","starred_url":"https://api.github.com/users/cholcombe973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cholcombe973/subscriptions","organizations_url":"https://api.github.com/users/cholcombe973/orgs","repos_url":"https://api.github.com/users/cholcombe973/repos","events_url":"https://api.github.com/users/cholcombe973/events{/privacy}","received_events_url":"https://api.github.com/users/cholcombe973/received_events","type":"User","site_admin":false},"repo":{"id":38644285,"name":"gluster-charm","full_name":"cholcombe973/gluster-charm","owner":{"login":"cholcombe973","id":3058195,"avatar_url":"https://avatars.githubusercontent.com/u/3058195?v=3","gravatar_id":"","url":"https://api.github.com/users/cholcombe973","html_url":"https://github.com/cholcombe973","followers_url":"https://api.github.com/users/cholcombe973/followers","following_url":"https://api.github.com/users/cholcombe973/following{/other_user}","gists_url":"https://api.github.com/users/cholcombe973/gists{/gist_id}","starred_url":"https://api.github.com/users/cholcombe973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cholcombe973/subscriptions","organizations_url":"https://api.github.com/users/cholcombe973/orgs","repos_url":"https://api.github.com/users/cholcombe973/repos","events_url":"https://api.github.com/users/cholcombe973/events{/privacy}","received_events_url":"https://api.github.com/users/cholcombe973/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cholcombe973/gluster-charm","description":"Juju Gluster Charm","fork":false,"url":"https://api.github.com/repos/cholcombe973/gluster-charm","forks_url":"https://api.github.com/repos/cholcombe973/gluster-charm/forks","keys_url":"https://api.github.com/repos/cholcombe973/gluster-charm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cholcombe973/gluster-charm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cholcombe973/gluster-charm/teams","hooks_url":"https://api.github.com/repos/cholcombe973/gluster-charm/hooks","issue_events_url":"https://api.github.com/repos/cholcombe973/gluster-charm/issues/events{/number}","events_url":"https://api.github.com/repos/cholcombe973/gluster-charm/events","assignees_url":"https://api.github.com/repos/cholcombe973/gluster-charm/assignees{/user}","branches_url":"https://api.github.com/repos/cholcombe973/gluster-charm/branches{/branch}","tags_url":"https://api.github.com/repos/cholcombe973/gluster-charm/tags","blobs_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/refs{/sha}","trees_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cholcombe973/gluster-charm/statuses/{sha}","languages_url":"https://api.github.com/repos/cholcombe973/gluster-charm/languages","stargazers_url":"https://api.github.com/repos/cholcombe973/gluster-charm/stargazers","contributors_url":"https://api.github.com/repos/cholcombe973/gluster-charm/contributors","subscribers_url":"https://api.github.com/repos/cholcombe973/gluster-charm/subscribers","subscription_url":"https://api.github.com/repos/cholcombe973/gluster-charm/subscription","commits_url":"https://api.github.com/repos/cholcombe973/gluster-charm/commits{/sha}","git_commits_url":"https://api.github.com/repos/cholcombe973/gluster-charm/git/commits{/sha}","comments_url":"https://api.github.com/repos/cholcombe973/gluster-charm/comments{/number}","issue_comment_url":"https://api.github.com/repos/cholcombe973/gluster-charm/issues/comments{/number}","contents_url":"https://api.github.com/repos/cholcombe973/gluster-charm/contents/{+path}","compare_url":"https://api.github.com/repos/cholcombe973/gluster-charm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cholcombe973/gluster-charm/merges","archive_url":"https://api.github.com/repos/cholcombe973/gluster-charm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cholcombe973/gluster-charm/downloads","issues_url":"https://api.github.com/repos/cholcombe973/gluster-charm/issues{/number}","pulls_url":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls{/number}","milestones_url":"https://api.github.com/repos/cholcombe973/gluster-charm/milestones{/number}","notifications_url":"https://api.github.com/repos/cholcombe973/gluster-charm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cholcombe973/gluster-charm/labels{/name}","releases_url":"https://api.github.com/repos/cholcombe973/gluster-charm/releases{/id}","deployments_url":"https://api.github.com/repos/cholcombe973/gluster-charm/deployments","created_at":"2015-07-06T20:31:10Z","updated_at":"2017-01-26T20:31:39Z","pushed_at":"2017-01-27T00:07:40Z","git_url":"git://github.com/cholcombe973/gluster-charm.git","ssh_url":"git@github.com:cholcombe973/gluster-charm.git","clone_url":"https://github.com/cholcombe973/gluster-charm.git","svn_url":"https://github.com/cholcombe973/gluster-charm","homepage":"","size":23441,"stargazers_count":5,"watchers_count":5,"language":"Python","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":7,"forks":0,"open_issues":7,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/13"},"html":{"href":"https://github.com/cholcombe973/gluster-charm/pull/13"},"issue":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/issues/13"},"comments":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/cholcombe973/gluster-charm/statuses/eda5b0ad06c87dcdc530a9b9b1a01b1aab8d0dfa"}}}}
{"actor":{"display_login":"ChrisMacNaughton"}}