{"action":"created","issue":{"url":"https://api.github.com/repos/ni/VireoSDK/issues/228","repository_url":"https://api.github.com/repos/ni/VireoSDK","labels_url":"https://api.github.com/repos/ni/VireoSDK/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/ni/VireoSDK/issues/228/comments","events_url":"https://api.github.com/repos/ni/VireoSDK/issues/228/events","html_url":"https://github.com/ni/VireoSDK/pull/228","id":216189552,"number":228,"title":"Resize arrays eggshell","user":{"login":"gleonoliva","id":18090460,"avatar_url":"https://avatars0.githubusercontent.com/u/18090460?v=3","gravatar_id":"","url":"https://api.github.com/users/gleonoliva","html_url":"https://github.com/gleonoliva","followers_url":"https://api.github.com/users/gleonoliva/followers","following_url":"https://api.github.com/users/gleonoliva/following{/other_user}","gists_url":"https://api.github.com/users/gleonoliva/gists{/gist_id}","starred_url":"https://api.github.com/users/gleonoliva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gleonoliva/subscriptions","organizations_url":"https://api.github.com/users/gleonoliva/orgs","repos_url":"https://api.github.com/users/gleonoliva/repos","events_url":"https://api.github.com/users/gleonoliva/events{/privacy}","received_events_url":"https://api.github.com/users/gleonoliva/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-03-22T19:58:00Z","updated_at":"2017-03-22T21:34:38Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ni/VireoSDK/pulls/228","html_url":"https://github.com/ni/VireoSDK/pull/228","diff_url":"https://github.com/ni/VireoSDK/pull/228.diff","patch_url":"https://github.com/ni/VireoSDK/pull/228.patch"},"body":"Here are my changes for exposing ResizeArray to eggshell.\r\n\r\nI have a couple of questions about conventions for this repo. \r\n\r\n1. Do you think more validation is required for the rank and newLengths is required in `CEntryPoints.cpp`? Iwas just assuming that the actual call for resizing on line 229 would handle this.\r\n2. I tried to differentiate the reason resizing failed with different error codes. Don't know if is ok or just use one.\r\n3. Do you think more tests are needed?\r\n4. Should I modify `CEntryPoints.h` with the function signature for this and `EggShell_GetArrayDimLength`, there might be more missing there. Is this relevant?"},"comment":{"url":"https://api.github.com/repos/ni/VireoSDK/issues/comments/288547068","html_url":"https://github.com/ni/VireoSDK/pull/228#issuecomment-288547068","issue_url":"https://api.github.com/repos/ni/VireoSDK/issues/228","id":288547068,"user":{"login":"cglzaguilar","id":8452083,"avatar_url":"https://avatars0.githubusercontent.com/u/8452083?v=3","gravatar_id":"","url":"https://api.github.com/users/cglzaguilar","html_url":"https://github.com/cglzaguilar","followers_url":"https://api.github.com/users/cglzaguilar/followers","following_url":"https://api.github.com/users/cglzaguilar/following{/other_user}","gists_url":"https://api.github.com/users/cglzaguilar/gists{/gist_id}","starred_url":"https://api.github.com/users/cglzaguilar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cglzaguilar/subscriptions","organizations_url":"https://api.github.com/users/cglzaguilar/orgs","repos_url":"https://api.github.com/users/cglzaguilar/repos","events_url":"https://api.github.com/users/cglzaguilar/events{/privacy}","received_events_url":"https://api.github.com/users/cglzaguilar/received_events","type":"User","site_admin":false},"created_at":"2017-03-22T21:34:38Z","updated_at":"2017-03-22T21:34:38Z","body":"Answer to your questions\r\n\r\n1) Yes, ResizeDimensions should take care of this, if it doesn't we should fixed. Do you have test cases in mind?\r\n\r\n2) More codes is better, let's give the user feedback as specific as we can.\r\n\r\n3) Yes, once for error code -1, and probably we might need more tests for ResizeDimensions to handle incorrect parameters, like a Rank of -1 or stuff like that.\r\n\r\n4) I didn't understand your question. Can you elaborate more?\r\n"}}
{"actor":{"display_login":"cglzaguilar"}}