{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/18186","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/18186/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/18186/comments","events_url":"https://api.github.com/repos/golang/go/issues/18186/events","html_url":"https://github.com/golang/go/issues/18186","id":193301357,"number":18186,"title":"unicode: FoldCategory and FoldScript incorrectly defined","user":{"login":"IsaacDunlap","id":13685963,"avatar_url":"https://avatars0.githubusercontent.com/u/13685963?v=3","gravatar_id":"","url":"https://api.github.com/users/IsaacDunlap","html_url":"https://github.com/IsaacDunlap","followers_url":"https://api.github.com/users/IsaacDunlap/followers","following_url":"https://api.github.com/users/IsaacDunlap/following{/other_user}","gists_url":"https://api.github.com/users/IsaacDunlap/gists{/gist_id}","starred_url":"https://api.github.com/users/IsaacDunlap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IsaacDunlap/subscriptions","organizations_url":"https://api.github.com/users/IsaacDunlap/orgs","repos_url":"https://api.github.com/users/IsaacDunlap/repos","events_url":"https://api.github.com/users/IsaacDunlap/events{/privacy}","received_events_url":"https://api.github.com/users/IsaacDunlap/received_events","type":"User","site_admin":false},"labels":[{"id":373399998,"url":"https://api.github.com/repos/golang/go/labels/NeedsFix","name":"NeedsFix","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"rsc","id":104030,"avatar_url":"https://avatars2.githubusercontent.com/u/104030?v=3","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"assignees":[{"login":"rsc","id":104030,"avatar_url":"https://avatars2.githubusercontent.com/u/104030?v=3","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/49","html_url":"https://github.com/golang/go/milestone/49","labels_url":"https://api.github.com/repos/golang/go/milestones/49/labels","id":2053058,"number":49,"title":"Go1.9","description":"","creator":{"login":"rsc","id":104030,"avatar_url":"https://avatars2.githubusercontent.com/u/104030?v=3","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":162,"closed_issues":534,"state":"open","created_at":"2016-10-06T18:17:55Z","updated_at":"2017-06-14T21:58:27Z","due_on":"2017-07-31T07:00:00Z","closed_at":null},"comments":7,"created_at":"2016-12-03T17:09:28Z","updated_at":"2017-06-15T00:32:00Z","closed_at":null,"body":"In Go version 1.7.3, the unicode package provides 2 maps: FoldCategory and FoldScript. FoldCategory is only supposed to map category names to tables of code points, but includes script names (\"Common\", \"Greek\", \"Inherited\"). By contrast, although FoldScript is supposed to map script names to tables of code points, the 3 script names (\"Common\", \"Greek\", \"Inherited\") are missing and FoldScript is an empty map.\r\n\r\nThis bug could be fixed by instead defining Fold Category and FoldScript thus:\r\n\r\n`var FoldCategory = map[string]*RangeTable{\r\n\t\"L\":  foldL,\r\n\t\"Ll\": foldLl,\r\n\t\"Lt\": foldLt,\r\n\t\"Lu\": foldLu,\r\n\t\"M\":  foldM,\r\n\t\"Mn\": foldMn,\r\n}`\r\n\r\n`var FoldScript = map[string]*RangeTable{\r\n\t\"Common\":    foldCommon,\r\n\t\"Greek\":     foldGreek,\r\n\t\"Inherited\": foldInherited,\r\n}`\r\n\r\nThis much better fits what the user of unicode expects when reading the descriptions of FoldCategory and FoldScript (as well as better matching what the names of the variables imply)."},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/308595297","html_url":"https://github.com/golang/go/issues/18186#issuecomment-308595297","issue_url":"https://api.github.com/repos/golang/go/issues/18186","id":308595297,"user":{"login":"rsc","id":104030,"avatar_url":"https://avatars2.githubusercontent.com/u/104030?v=3","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"created_at":"2017-06-15T00:32:00Z","updated_at":"2017-06-15T00:32:00Z","body":"Seems like @mpvl is away (not sure). I'll take care of this. I thought the tables were now generated from something in x/text, but unicode/maketables.go is still in the main distribution and editing and rerunning it has the desired effect, so good enough for me.\r\n"}}
{"actor":{"display_login":"rsc"}}