{"action":"created","issue":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16656","repository_url":"https://api.github.com/repos/Automattic/wp-calypso","labels_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16656/labels{/name}","comments_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16656/comments","events_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16656/events","html_url":"https://github.com/Automattic/wp-calypso/pull/16656","id":246180495,"number":16656,"title":"Store Orders: Display all taxes on orders, and add correct tax during refunds","user":{"login":"ryelle","id":541093,"avatar_url":"https://avatars1.githubusercontent.com/u/541093?v=4","gravatar_id":"","url":"https://api.github.com/users/ryelle","html_url":"https://github.com/ryelle","followers_url":"https://api.github.com/users/ryelle/followers","following_url":"https://api.github.com/users/ryelle/following{/other_user}","gists_url":"https://api.github.com/users/ryelle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryelle/subscriptions","organizations_url":"https://api.github.com/users/ryelle/orgs","repos_url":"https://api.github.com/users/ryelle/repos","events_url":"https://api.github.com/users/ryelle/events{/privacy}","received_events_url":"https://api.github.com/users/ryelle/received_events","type":"User","site_admin":false},"labels":[{"id":545515130,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/Store","name":"Store","color":"96588a","default":false},{"id":542883719,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Size]%20XL","name":"[Size] XL","color":"390036","default":false},{"id":285010018,"url":"https://api.github.com/repos/Automattic/wp-calypso/labels/[Status]%20Needs%20Review","name":"[Status] Needs Review","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":{"login":"ryelle","id":541093,"avatar_url":"https://avatars1.githubusercontent.com/u/541093?v=4","gravatar_id":"","url":"https://api.github.com/users/ryelle","html_url":"https://github.com/ryelle","followers_url":"https://api.github.com/users/ryelle/followers","following_url":"https://api.github.com/users/ryelle/following{/other_user}","gists_url":"https://api.github.com/users/ryelle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryelle/subscriptions","organizations_url":"https://api.github.com/users/ryelle/orgs","repos_url":"https://api.github.com/users/ryelle/repos","events_url":"https://api.github.com/users/ryelle/events{/privacy}","received_events_url":"https://api.github.com/users/ryelle/received_events","type":"User","site_admin":false},"assignees":[{"login":"ryelle","id":541093,"avatar_url":"https://avatars1.githubusercontent.com/u/541093?v=4","gravatar_id":"","url":"https://api.github.com/users/ryelle","html_url":"https://github.com/ryelle","followers_url":"https://api.github.com/users/ryelle/followers","following_url":"https://api.github.com/users/ryelle/following{/other_user}","gists_url":"https://api.github.com/users/ryelle/gists{/gist_id}","starred_url":"https://api.github.com/users/ryelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryelle/subscriptions","organizations_url":"https://api.github.com/users/ryelle/orgs","repos_url":"https://api.github.com/users/ryelle/repos","events_url":"https://api.github.com/users/ryelle/events{/privacy}","received_events_url":"https://api.github.com/users/ryelle/received_events","type":"User","site_admin":false}],"milestone":null,"comments":18,"created_at":"2017-07-27T21:53:39Z","updated_at":"2017-08-09T21:02:04Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Automattic/wp-calypso/pulls/16656","html_url":"https://github.com/Automattic/wp-calypso/pull/16656","diff_url":"https://github.com/Automattic/wp-calypso/pull/16656.diff","patch_url":"https://github.com/Automattic/wp-calypso/pull/16656.patch"},"body":"Fixes #16645, fixes #16634\r\n\r\nThis PR has been pretty drastically updated. It used to be:\r\n\r\n> This PR updates the price computed by changing the quantity in the refund modal to include tax on the item. It does check first that tax is not already included on the item (based on the API response, I couldn't actually get my test site into a state where it included tax on the products).\r\n\r\nNow it's a refactor of the order details page, specifically the discount/shipping/total rows. It also includes these refund-with-tax fixes. The two big changes are:\r\n\r\n- Now the discount, shipping, and total rows also have a Tax column, which line up with the product list table's tax and total columns.\r\n- The refund modal, which also uses this table component, has a separate row for the refund input, so that users can see the shipping total and tax values.\r\n\r\nDetails table:\r\n![screen shot 2017-08-04 at 6 56 02 pm](https://user-images.githubusercontent.com/541093/28990301-18032630-794a-11e7-832d-fc6d84304f9f.png)\r\n\r\nRefund modal:\r\n![screen shot 2017-08-04 at 6 55 29 pm](https://user-images.githubusercontent.com/541093/28990302-1807ea76-794a-11e7-8634-faa53d0dcccf.png)\r\n\r\nTo test:\r\n\r\n- With a site that has taxes enabled, create an order or view an existing taxed order\r\n- On the details view, make sure the discount, shipping, total, and refunds display as expected\r\n- Try to give a refund on the order by changing the quantity in the refunds modal\r\n- The price refunded should include the tax per-item\r\n- You can see the shipping total and tax, and can enter that into the shipping refund input\r\n- Refunding now, you can refund the entire order cost."},"comment":{"url":"https://api.github.com/repos/Automattic/wp-calypso/issues/comments/321380429","html_url":"https://github.com/Automattic/wp-calypso/pull/16656#issuecomment-321380429","issue_url":"https://api.github.com/repos/Automattic/wp-calypso/issues/16656","id":321380429,"user":{"login":"allendav","id":1595739,"avatar_url":"https://avatars1.githubusercontent.com/u/1595739?v=4","gravatar_id":"","url":"https://api.github.com/users/allendav","html_url":"https://github.com/allendav","followers_url":"https://api.github.com/users/allendav/followers","following_url":"https://api.github.com/users/allendav/following{/other_user}","gists_url":"https://api.github.com/users/allendav/gists{/gist_id}","starred_url":"https://api.github.com/users/allendav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allendav/subscriptions","organizations_url":"https://api.github.com/users/allendav/orgs","repos_url":"https://api.github.com/users/allendav/repos","events_url":"https://api.github.com/users/allendav/events{/privacy}","received_events_url":"https://api.github.com/users/allendav/received_events","type":"User","site_admin":false},"created_at":"2017-08-09T21:02:04Z","updated_at":"2017-08-09T21:02:04Z","body":"@jameskoster wrote\r\n\r\n> I agree the shipping refund input is confusing as it exists in this PR. How about we keep it inline like it is on live but pre-populate it with the total shipping cost?\r\n\r\nOooh - I like this idea"}}
{"actor":{"display_login":"allendav"}}