{"action":"closed","number":2632,"pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/2632","id":108934673,"html_url":"https://github.com/apache/kafka/pull/2632","diff_url":"https://github.com/apache/kafka/pull/2632.diff","patch_url":"https://github.com/apache/kafka/pull/2632.patch","issue_url":"https://api.github.com/repos/apache/kafka/issues/2632","number":2632,"state":"closed","locked":false,"title":"KAFKA-3182: Fix Transient Test Failure (kafka.network.SocketServerTest.testSocketsCloseOnShutdown)","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars3.githubusercontent.com/u/6490959?v=3","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"body":"Fixes https://issues.apache.org/jira/browse/KAFKA-3182 by:\r\n* Turning off Nagle on the sending sockets to force the socket to physically acknowledge after the first write in `sendRequest`\r\n* (Still had to do this on Linux though not on Mac) Adding a `200ms` delay between write attempts (my guess would be [Slow Start](https://en.wikipedia.org/wiki/TCP_congestion_control#Slow_start) is to blame for this, but with Nagle off 200ms should more than suffice here imo)\r\n\r\n### Before:\r\n![before](https://cloud.githubusercontent.com/assets/6490959/23545356/5015f6a6-fffb-11e6-88f2-418e286a920d.png)\r\n\r\n### After:\r\n![after](https://cloud.githubusercontent.com/assets/6490959/23545331/32265096-fffb-11e6-8843-017580dacfc5.png)\r\n\r\n","created_at":"2017-03-03T09:22:56Z","updated_at":"2017-03-04T15:29:24Z","closed_at":"2017-03-04T15:29:24Z","merged_at":null,"merge_commit_sha":"1d67862338cc0602e25e78c632d1ad8a9d86dfce","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/kafka/pulls/2632/commits","review_comments_url":"https://api.github.com/repos/apache/kafka/pulls/2632/comments","review_comment_url":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/kafka/issues/2632/comments","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/a9be43fc77ceea5fc40f2256f7f0f6e982990b09","head":{"label":"original-brownbear:KAFKA-3182","ref":"KAFKA-3182","sha":"a9be43fc77ceea5fc40f2256f7f0f6e982990b09","user":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars3.githubusercontent.com/u/6490959?v=3","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"repo":{"id":82090417,"name":"kafka","full_name":"original-brownbear/kafka","owner":{"login":"original-brownbear","id":6490959,"avatar_url":"https://avatars3.githubusercontent.com/u/6490959?v=3","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/original-brownbear/kafka","description":"Mirror of Apache Kafka","fork":true,"url":"https://api.github.com/repos/original-brownbear/kafka","forks_url":"https://api.github.com/repos/original-brownbear/kafka/forks","keys_url":"https://api.github.com/repos/original-brownbear/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/original-brownbear/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/original-brownbear/kafka/teams","hooks_url":"https://api.github.com/repos/original-brownbear/kafka/hooks","issue_events_url":"https://api.github.com/repos/original-brownbear/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/original-brownbear/kafka/events","assignees_url":"https://api.github.com/repos/original-brownbear/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/original-brownbear/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/original-brownbear/kafka/tags","blobs_url":"https://api.github.com/repos/original-brownbear/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/original-brownbear/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/original-brownbear/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/original-brownbear/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/original-brownbear/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/original-brownbear/kafka/languages","stargazers_url":"https://api.github.com/repos/original-brownbear/kafka/stargazers","contributors_url":"https://api.github.com/repos/original-brownbear/kafka/contributors","subscribers_url":"https://api.github.com/repos/original-brownbear/kafka/subscribers","subscription_url":"https://api.github.com/repos/original-brownbear/kafka/subscription","commits_url":"https://api.github.com/repos/original-brownbear/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/original-brownbear/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/original-brownbear/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/original-brownbear/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/original-brownbear/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/original-brownbear/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/original-brownbear/kafka/merges","archive_url":"https://api.github.com/repos/original-brownbear/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/original-brownbear/kafka/downloads","issues_url":"https://api.github.com/repos/original-brownbear/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/original-brownbear/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/original-brownbear/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/original-brownbear/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/original-brownbear/kafka/labels{/name}","releases_url":"https://api.github.com/repos/original-brownbear/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/original-brownbear/kafka/deployments","created_at":"2017-02-15T18:06:11Z","updated_at":"2017-02-15T18:06:19Z","pushed_at":"2017-03-03T21:55:13Z","git_url":"git://github.com/original-brownbear/kafka.git","ssh_url":"git@github.com:original-brownbear/kafka.git","clone_url":"https://github.com/original-brownbear/kafka.git","svn_url":"https://github.com/original-brownbear/kafka","homepage":null,"size":44544,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"trunk"}},"base":{"label":"apache:trunk","ref":"trunk","sha":"a3c45b0c9263ca4481b1af7af3f7d8ae8cb5d5cd","user":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":2211243,"name":"kafka","full_name":"apache/kafka","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars3.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/kafka","description":"Mirror of Apache Kafka","fork":false,"url":"https://api.github.com/repos/apache/kafka","forks_url":"https://api.github.com/repos/apache/kafka/forks","keys_url":"https://api.github.com/repos/apache/kafka/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/kafka/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/kafka/teams","hooks_url":"https://api.github.com/repos/apache/kafka/hooks","issue_events_url":"https://api.github.com/repos/apache/kafka/issues/events{/number}","events_url":"https://api.github.com/repos/apache/kafka/events","assignees_url":"https://api.github.com/repos/apache/kafka/assignees{/user}","branches_url":"https://api.github.com/repos/apache/kafka/branches{/branch}","tags_url":"https://api.github.com/repos/apache/kafka/tags","blobs_url":"https://api.github.com/repos/apache/kafka/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/kafka/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/kafka/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/kafka/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/kafka/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/kafka/languages","stargazers_url":"https://api.github.com/repos/apache/kafka/stargazers","contributors_url":"https://api.github.com/repos/apache/kafka/contributors","subscribers_url":"https://api.github.com/repos/apache/kafka/subscribers","subscription_url":"https://api.github.com/repos/apache/kafka/subscription","commits_url":"https://api.github.com/repos/apache/kafka/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/kafka/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/kafka/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/kafka/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/kafka/contents/{+path}","compare_url":"https://api.github.com/repos/apache/kafka/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/kafka/merges","archive_url":"https://api.github.com/repos/apache/kafka/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/kafka/downloads","issues_url":"https://api.github.com/repos/apache/kafka/issues{/number}","pulls_url":"https://api.github.com/repos/apache/kafka/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/kafka/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/kafka/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/kafka/labels{/name}","releases_url":"https://api.github.com/repos/apache/kafka/releases{/id}","deployments_url":"https://api.github.com/repos/apache/kafka/deployments","created_at":"2011-08-15T18:06:16Z","updated_at":"2017-03-04T06:54:05Z","pushed_at":"2017-03-04T15:28:56Z","git_url":"git://github.com/apache/kafka.git","ssh_url":"git@github.com:apache/kafka.git","clone_url":"https://github.com/apache/kafka.git","svn_url":"https://github.com/apache/kafka","homepage":null,"size":44567,"stargazers_count":4690,"watchers_count":4690,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2932,"mirror_url":"git://git.apache.org/kafka.git","open_issues_count":286,"forks":2932,"open_issues":286,"watchers":4690,"default_branch":"trunk"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/kafka/pulls/2632"},"html":{"href":"https://github.com/apache/kafka/pull/2632"},"issue":{"href":"https://api.github.com/repos/apache/kafka/issues/2632"},"comments":{"href":"https://api.github.com/repos/apache/kafka/issues/2632/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/kafka/pulls/2632/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/kafka/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/kafka/pulls/2632/commits"},"statuses":{"href":"https://api.github.com/repos/apache/kafka/statuses/a9be43fc77ceea5fc40f2256f7f0f6e982990b09"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":9,"review_comments":11,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"asfgit"}}