{"action":"created","comment":{"url":"https://api.github.com/repos/Lightricks/Tweaks/pulls/comments/158913932","pull_request_review_id":85779117,"id":158913932,"diff_hunk":"@@ -7,31 +7,45 @@\n  of patent rights can be found in the PATENTS file in the same directory.\n  */\n \n+#import \"FBKVOController.h\"\n #import \"FBTweakCollection.h\"\n #import \"FBTweakCategory.h\"\n #import \"FBTweak.h\"\n+#import \"_FBKeyboardManager.h\"\n+#import \"_FBTweakArrayViewController.h\"\n #import \"_FBTweakCollectionViewController.h\"\n-#import \"_FBTweakTableViewCell.h\"\n #import \"_FBTweakColorViewController.h\"\n #import \"_FBTweakDictionaryViewController.h\"\n-#import \"_FBTweakArrayViewController.h\"\n-#import \"_FBKeyboardManager.h\"\n-\n-@interface _FBTweakCollectionViewController () <UITableViewDelegate, UITableViewDataSource>\n-@end\n+#import \"_FBTweakTableViewCell.h\"\n \n @implementation _FBTweakCollectionViewController {\n-  UITableView *_tableView;\n-  NSArray *_sortedCollections;\n+   NSArray<FBTweakCollection *> *_sortedCollections;\n   _FBKeyboardManager *_keyboardManager;\n+  FBKVOController *_kvoController;\n }\n \n-- (instancetype)initWithTweakCategory:(FBTweakCategory *)category\n+- (instancetype)initWithTweakCategory:(id<FBTweakCategory>)category\n {\n   if ((self = [super init])) {\n     _tweakCategory = category;\n+    self.clearsSelectionOnViewWillAppear = YES;\n     self.title = _tweakCategory.name;\n-    [self _reloadData];\n+\n+    _kvoController = [FBKVOController controllerWithObserver:self];\n+    [_kvoController observe:_tweakCategory keyPath:@\"tweakCollections\"","path":"FBTweak/_FBTweakCollectionViewController.m","position":39,"original_position":39,"commit_id":"442a9fdec65770718a1db88c0cfd88a514735937","original_commit_id":"442a9fdec65770718a1db88c0cfd88a514735937","user":{"login":"mkimi-lightricks","id":20626100,"avatar_url":"https://avatars1.githubusercontent.com/u/20626100?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimi-lightricks","html_url":"https://github.com/mkimi-lightricks","followers_url":"https://api.github.com/users/mkimi-lightricks/followers","following_url":"https://api.github.com/users/mkimi-lightricks/following{/other_user}","gists_url":"https://api.github.com/users/mkimi-lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimi-lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimi-lightricks/subscriptions","organizations_url":"https://api.github.com/users/mkimi-lightricks/orgs","repos_url":"https://api.github.com/users/mkimi-lightricks/repos","events_url":"https://api.github.com/users/mkimi-lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/mkimi-lightricks/received_events","type":"User","site_admin":false},"body":"Do you have to remove this observation when done?","created_at":"2017-12-28T08:48:38Z","updated_at":"2017-12-28T08:56:29Z","html_url":"https://github.com/Lightricks/Tweaks/pull/3#discussion_r158913932","pull_request_url":"https://api.github.com/repos/Lightricks/Tweaks/pulls/3","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Lightricks/Tweaks/pulls/comments/158913932"},"html":{"href":"https://github.com/Lightricks/Tweaks/pull/3#discussion_r158913932"},"pull_request":{"href":"https://api.github.com/repos/Lightricks/Tweaks/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/Lightricks/Tweaks/pulls/3","id":160000739,"html_url":"https://github.com/Lightricks/Tweaks/pull/3","diff_url":"https://github.com/Lightricks/Tweaks/pull/3.diff","patch_url":"https://github.com/Lightricks/Tweaks/pull/3.patch","issue_url":"https://api.github.com/repos/Lightricks/Tweaks/issues/3","number":3,"state":"open","locked":false,"title":"Tweaks: Add support for updating tweak collections.","user":{"login":"barakwei","id":5232161,"avatar_url":"https://avatars1.githubusercontent.com/u/5232161?v=4","gravatar_id":"","url":"https://api.github.com/users/barakwei","html_url":"https://github.com/barakwei","followers_url":"https://api.github.com/users/barakwei/followers","following_url":"https://api.github.com/users/barakwei/following{/other_user}","gists_url":"https://api.github.com/users/barakwei/gists{/gist_id}","starred_url":"https://api.github.com/users/barakwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barakwei/subscriptions","organizations_url":"https://api.github.com/users/barakwei/orgs","repos_url":"https://api.github.com/users/barakwei/repos","events_url":"https://api.github.com/users/barakwei/events{/privacy}","received_events_url":"https://api.github.com/users/barakwei/received_events","type":"User","site_admin":false},"body":"@mkimi-lightricks\r\n1. The style is weird, and I adhered to the style in this repo (use of ivars, long lines etc.)\r\n2. I mixed mutable and immutable stuff there IMO, but I didn't want to change too much.\r\n3. KVO files are from https://github.com/facebook/kvocontroller, didn't add submodule.\r\n\r\nThis is not the last PR, other will probably follow as new features will be needed.\r\n\r\n@StatusReport general design review will be nice\r\n","created_at":"2017-12-24T14:06:13Z","updated_at":"2017-12-28T08:56:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb5569eff9ab58135cfc05d1d79745853be2cc13","assignee":{"login":"mkimi-lightricks","id":20626100,"avatar_url":"https://avatars1.githubusercontent.com/u/20626100?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimi-lightricks","html_url":"https://github.com/mkimi-lightricks","followers_url":"https://api.github.com/users/mkimi-lightricks/followers","following_url":"https://api.github.com/users/mkimi-lightricks/following{/other_user}","gists_url":"https://api.github.com/users/mkimi-lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimi-lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimi-lightricks/subscriptions","organizations_url":"https://api.github.com/users/mkimi-lightricks/orgs","repos_url":"https://api.github.com/users/mkimi-lightricks/repos","events_url":"https://api.github.com/users/mkimi-lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/mkimi-lightricks/received_events","type":"User","site_admin":false},"assignees":[{"login":"mkimi-lightricks","id":20626100,"avatar_url":"https://avatars1.githubusercontent.com/u/20626100?v=4","gravatar_id":"","url":"https://api.github.com/users/mkimi-lightricks","html_url":"https://github.com/mkimi-lightricks","followers_url":"https://api.github.com/users/mkimi-lightricks/followers","following_url":"https://api.github.com/users/mkimi-lightricks/following{/other_user}","gists_url":"https://api.github.com/users/mkimi-lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/mkimi-lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkimi-lightricks/subscriptions","organizations_url":"https://api.github.com/users/mkimi-lightricks/orgs","repos_url":"https://api.github.com/users/mkimi-lightricks/repos","events_url":"https://api.github.com/users/mkimi-lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/mkimi-lightricks/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Lightricks/Tweaks/pulls/3/commits","review_comments_url":"https://api.github.com/repos/Lightricks/Tweaks/pulls/3/comments","review_comment_url":"https://api.github.com/repos/Lightricks/Tweaks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Lightricks/Tweaks/issues/3/comments","statuses_url":"https://api.github.com/repos/Lightricks/Tweaks/statuses/442a9fdec65770718a1db88c0cfd88a514735937","head":{"label":"barakwei:feature/reactive-tweak-collection-vc","ref":"feature/reactive-tweak-collection-vc","sha":"442a9fdec65770718a1db88c0cfd88a514735937","user":{"login":"barakwei","id":5232161,"avatar_url":"https://avatars1.githubusercontent.com/u/5232161?v=4","gravatar_id":"","url":"https://api.github.com/users/barakwei","html_url":"https://github.com/barakwei","followers_url":"https://api.github.com/users/barakwei/followers","following_url":"https://api.github.com/users/barakwei/following{/other_user}","gists_url":"https://api.github.com/users/barakwei/gists{/gist_id}","starred_url":"https://api.github.com/users/barakwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barakwei/subscriptions","organizations_url":"https://api.github.com/users/barakwei/orgs","repos_url":"https://api.github.com/users/barakwei/repos","events_url":"https://api.github.com/users/barakwei/events{/privacy}","received_events_url":"https://api.github.com/users/barakwei/received_events","type":"User","site_admin":false},"repo":{"id":115131047,"name":"Tweaks","full_name":"barakwei/Tweaks","owner":{"login":"barakwei","id":5232161,"avatar_url":"https://avatars1.githubusercontent.com/u/5232161?v=4","gravatar_id":"","url":"https://api.github.com/users/barakwei","html_url":"https://github.com/barakwei","followers_url":"https://api.github.com/users/barakwei/followers","following_url":"https://api.github.com/users/barakwei/following{/other_user}","gists_url":"https://api.github.com/users/barakwei/gists{/gist_id}","starred_url":"https://api.github.com/users/barakwei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barakwei/subscriptions","organizations_url":"https://api.github.com/users/barakwei/orgs","repos_url":"https://api.github.com/users/barakwei/repos","events_url":"https://api.github.com/users/barakwei/events{/privacy}","received_events_url":"https://api.github.com/users/barakwei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/barakwei/Tweaks","description":"An easy way to fine-tune, and adjust parameters for iOS apps in development.","fork":true,"url":"https://api.github.com/repos/barakwei/Tweaks","forks_url":"https://api.github.com/repos/barakwei/Tweaks/forks","keys_url":"https://api.github.com/repos/barakwei/Tweaks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/barakwei/Tweaks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/barakwei/Tweaks/teams","hooks_url":"https://api.github.com/repos/barakwei/Tweaks/hooks","issue_events_url":"https://api.github.com/repos/barakwei/Tweaks/issues/events{/number}","events_url":"https://api.github.com/repos/barakwei/Tweaks/events","assignees_url":"https://api.github.com/repos/barakwei/Tweaks/assignees{/user}","branches_url":"https://api.github.com/repos/barakwei/Tweaks/branches{/branch}","tags_url":"https://api.github.com/repos/barakwei/Tweaks/tags","blobs_url":"https://api.github.com/repos/barakwei/Tweaks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/barakwei/Tweaks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/barakwei/Tweaks/git/refs{/sha}","trees_url":"https://api.github.com/repos/barakwei/Tweaks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/barakwei/Tweaks/statuses/{sha}","languages_url":"https://api.github.com/repos/barakwei/Tweaks/languages","stargazers_url":"https://api.github.com/repos/barakwei/Tweaks/stargazers","contributors_url":"https://api.github.com/repos/barakwei/Tweaks/contributors","subscribers_url":"https://api.github.com/repos/barakwei/Tweaks/subscribers","subscription_url":"https://api.github.com/repos/barakwei/Tweaks/subscription","commits_url":"https://api.github.com/repos/barakwei/Tweaks/commits{/sha}","git_commits_url":"https://api.github.com/repos/barakwei/Tweaks/git/commits{/sha}","comments_url":"https://api.github.com/repos/barakwei/Tweaks/comments{/number}","issue_comment_url":"https://api.github.com/repos/barakwei/Tweaks/issues/comments{/number}","contents_url":"https://api.github.com/repos/barakwei/Tweaks/contents/{+path}","compare_url":"https://api.github.com/repos/barakwei/Tweaks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/barakwei/Tweaks/merges","archive_url":"https://api.github.com/repos/barakwei/Tweaks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/barakwei/Tweaks/downloads","issues_url":"https://api.github.com/repos/barakwei/Tweaks/issues{/number}","pulls_url":"https://api.github.com/repos/barakwei/Tweaks/pulls{/number}","milestones_url":"https://api.github.com/repos/barakwei/Tweaks/milestones{/number}","notifications_url":"https://api.github.com/repos/barakwei/Tweaks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/barakwei/Tweaks/labels{/name}","releases_url":"https://api.github.com/repos/barakwei/Tweaks/releases{/id}","deployments_url":"https://api.github.com/repos/barakwei/Tweaks/deployments","created_at":"2017-12-22T16:12:59Z","updated_at":"2017-12-22T16:13:01Z","pushed_at":"2017-12-27T10:53:55Z","git_url":"git://github.com/barakwei/Tweaks.git","ssh_url":"git@github.com:barakwei/Tweaks.git","clone_url":"https://github.com/barakwei/Tweaks.git","svn_url":"https://github.com/barakwei/Tweaks","homepage":"","size":587,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Lightricks:master","ref":"master","sha":"93e062ab429a8cfa7d3aeb79c707b86cfbaed4ef","user":{"login":"Lightricks","id":3170348,"avatar_url":"https://avatars3.githubusercontent.com/u/3170348?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightricks","html_url":"https://github.com/Lightricks","followers_url":"https://api.github.com/users/Lightricks/followers","following_url":"https://api.github.com/users/Lightricks/following{/other_user}","gists_url":"https://api.github.com/users/Lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightricks/subscriptions","organizations_url":"https://api.github.com/users/Lightricks/orgs","repos_url":"https://api.github.com/users/Lightricks/repos","events_url":"https://api.github.com/users/Lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/Lightricks/received_events","type":"Organization","site_admin":false},"repo":{"id":95461604,"name":"Tweaks","full_name":"Lightricks/Tweaks","owner":{"login":"Lightricks","id":3170348,"avatar_url":"https://avatars3.githubusercontent.com/u/3170348?v=4","gravatar_id":"","url":"https://api.github.com/users/Lightricks","html_url":"https://github.com/Lightricks","followers_url":"https://api.github.com/users/Lightricks/followers","following_url":"https://api.github.com/users/Lightricks/following{/other_user}","gists_url":"https://api.github.com/users/Lightricks/gists{/gist_id}","starred_url":"https://api.github.com/users/Lightricks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lightricks/subscriptions","organizations_url":"https://api.github.com/users/Lightricks/orgs","repos_url":"https://api.github.com/users/Lightricks/repos","events_url":"https://api.github.com/users/Lightricks/events{/privacy}","received_events_url":"https://api.github.com/users/Lightricks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Lightricks/Tweaks","description":"An easy way to fine-tune, and adjust parameters for iOS apps in development.","fork":true,"url":"https://api.github.com/repos/Lightricks/Tweaks","forks_url":"https://api.github.com/repos/Lightricks/Tweaks/forks","keys_url":"https://api.github.com/repos/Lightricks/Tweaks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Lightricks/Tweaks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Lightricks/Tweaks/teams","hooks_url":"https://api.github.com/repos/Lightricks/Tweaks/hooks","issue_events_url":"https://api.github.com/repos/Lightricks/Tweaks/issues/events{/number}","events_url":"https://api.github.com/repos/Lightricks/Tweaks/events","assignees_url":"https://api.github.com/repos/Lightricks/Tweaks/assignees{/user}","branches_url":"https://api.github.com/repos/Lightricks/Tweaks/branches{/branch}","tags_url":"https://api.github.com/repos/Lightricks/Tweaks/tags","blobs_url":"https://api.github.com/repos/Lightricks/Tweaks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Lightricks/Tweaks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Lightricks/Tweaks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Lightricks/Tweaks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Lightricks/Tweaks/statuses/{sha}","languages_url":"https://api.github.com/repos/Lightricks/Tweaks/languages","stargazers_url":"https://api.github.com/repos/Lightricks/Tweaks/stargazers","contributors_url":"https://api.github.com/repos/Lightricks/Tweaks/contributors","subscribers_url":"https://api.github.com/repos/Lightricks/Tweaks/subscribers","subscription_url":"https://api.github.com/repos/Lightricks/Tweaks/subscription","commits_url":"https://api.github.com/repos/Lightricks/Tweaks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Lightricks/Tweaks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Lightricks/Tweaks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Lightricks/Tweaks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Lightricks/Tweaks/contents/{+path}","compare_url":"https://api.github.com/repos/Lightricks/Tweaks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Lightricks/Tweaks/merges","archive_url":"https://api.github.com/repos/Lightricks/Tweaks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Lightricks/Tweaks/downloads","issues_url":"https://api.github.com/repos/Lightricks/Tweaks/issues{/number}","pulls_url":"https://api.github.com/repos/Lightricks/Tweaks/pulls{/number}","milestones_url":"https://api.github.com/repos/Lightricks/Tweaks/milestones{/number}","notifications_url":"https://api.github.com/repos/Lightricks/Tweaks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Lightricks/Tweaks/labels{/name}","releases_url":"https://api.github.com/repos/Lightricks/Tweaks/releases{/id}","deployments_url":"https://api.github.com/repos/Lightricks/Tweaks/deployments","created_at":"2017-06-26T15:31:31Z","updated_at":"2017-06-26T15:31:34Z","pushed_at":"2017-12-27T10:53:58Z","git_url":"git://github.com/Lightricks/Tweaks.git","ssh_url":"git@github.com:Lightricks/Tweaks.git","clone_url":"https://github.com/Lightricks/Tweaks.git","svn_url":"https://github.com/Lightricks/Tweaks","homepage":"","size":562,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Lightricks/Tweaks/pulls/3"},"html":{"href":"https://github.com/Lightricks/Tweaks/pull/3"},"issue":{"href":"https://api.github.com/repos/Lightricks/Tweaks/issues/3"},"comments":{"href":"https://api.github.com/repos/Lightricks/Tweaks/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/Lightricks/Tweaks/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/Lightricks/Tweaks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Lightricks/Tweaks/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/Lightricks/Tweaks/statuses/442a9fdec65770718a1db88c0cfd88a514735937"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mkimi-lightricks"}}