{"action":"opened","number":3790,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kops/pulls/3790","id":151192353,"html_url":"https://github.com/kubernetes/kops/pull/3790","diff_url":"https://github.com/kubernetes/kops/pull/3790.diff","patch_url":"https://github.com/kubernetes/kops/pull/3790.patch","issue_url":"https://api.github.com/repos/kubernetes/kops/issues/3790","number":3790,"state":"open","locked":false,"title":"Bugfix kops update always detecting changes when using ExecContainerAction.","user":{"login":"KashifSaadat","id":6972966,"avatar_url":"https://avatars0.githubusercontent.com/u/6972966?v=4","gravatar_id":"","url":"https://api.github.com/users/KashifSaadat","html_url":"https://github.com/KashifSaadat","followers_url":"https://api.github.com/users/KashifSaadat/followers","following_url":"https://api.github.com/users/KashifSaadat/following{/other_user}","gists_url":"https://api.github.com/users/KashifSaadat/gists{/gist_id}","starred_url":"https://api.github.com/users/KashifSaadat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KashifSaadat/subscriptions","organizations_url":"https://api.github.com/users/KashifSaadat/orgs","repos_url":"https://api.github.com/users/KashifSaadat/repos","events_url":"https://api.github.com/users/KashifSaadat/events{/privacy}","received_events_url":"https://api.github.com/users/KashifSaadat/received_events","type":"User","site_admin":false},"body":"`ExecContainerAction` is referenced as a pointer in the `HookSpec`. When the bootstrapscript is run, it fingerprints the content here and stores it on-top of the existing `ExecContainerAction` within the Hook being parsed. The bootstrapscript is called for every Instance Group, and so the fingerprinted content gets passed and re-parsed.\r\n\r\nThis PR fixes the issue by creating a new `ExecContainerAction` object and assigning it to the hook being processed. Tests should now cover this case by running the `ResourceNodeUp` fn multiple times.\r\n\r\nFixes #3516","created_at":"2017-11-07T18:31:48Z","updated_at":"2017-11-07T18:31:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kops/pulls/3790/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kops/pulls/3790/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kops/issues/3790/comments","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/43f193e6ea0e44155cafcce4f3ed119db4ff7f6f","head":{"label":"KashifSaadat:bootstrapscript-hooks-bugfix","ref":"bootstrapscript-hooks-bugfix","sha":"43f193e6ea0e44155cafcce4f3ed119db4ff7f6f","user":{"login":"KashifSaadat","id":6972966,"avatar_url":"https://avatars0.githubusercontent.com/u/6972966?v=4","gravatar_id":"","url":"https://api.github.com/users/KashifSaadat","html_url":"https://github.com/KashifSaadat","followers_url":"https://api.github.com/users/KashifSaadat/followers","following_url":"https://api.github.com/users/KashifSaadat/following{/other_user}","gists_url":"https://api.github.com/users/KashifSaadat/gists{/gist_id}","starred_url":"https://api.github.com/users/KashifSaadat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KashifSaadat/subscriptions","organizations_url":"https://api.github.com/users/KashifSaadat/orgs","repos_url":"https://api.github.com/users/KashifSaadat/repos","events_url":"https://api.github.com/users/KashifSaadat/events{/privacy}","received_events_url":"https://api.github.com/users/KashifSaadat/received_events","type":"User","site_admin":false},"repo":{"id":98550798,"name":"kops","full_name":"KashifSaadat/kops","owner":{"login":"KashifSaadat","id":6972966,"avatar_url":"https://avatars0.githubusercontent.com/u/6972966?v=4","gravatar_id":"","url":"https://api.github.com/users/KashifSaadat","html_url":"https://github.com/KashifSaadat","followers_url":"https://api.github.com/users/KashifSaadat/followers","following_url":"https://api.github.com/users/KashifSaadat/following{/other_user}","gists_url":"https://api.github.com/users/KashifSaadat/gists{/gist_id}","starred_url":"https://api.github.com/users/KashifSaadat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KashifSaadat/subscriptions","organizations_url":"https://api.github.com/users/KashifSaadat/orgs","repos_url":"https://api.github.com/users/KashifSaadat/repos","events_url":"https://api.github.com/users/KashifSaadat/events{/privacy}","received_events_url":"https://api.github.com/users/KashifSaadat/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/KashifSaadat/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":true,"url":"https://api.github.com/repos/KashifSaadat/kops","forks_url":"https://api.github.com/repos/KashifSaadat/kops/forks","keys_url":"https://api.github.com/repos/KashifSaadat/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KashifSaadat/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KashifSaadat/kops/teams","hooks_url":"https://api.github.com/repos/KashifSaadat/kops/hooks","issue_events_url":"https://api.github.com/repos/KashifSaadat/kops/issues/events{/number}","events_url":"https://api.github.com/repos/KashifSaadat/kops/events","assignees_url":"https://api.github.com/repos/KashifSaadat/kops/assignees{/user}","branches_url":"https://api.github.com/repos/KashifSaadat/kops/branches{/branch}","tags_url":"https://api.github.com/repos/KashifSaadat/kops/tags","blobs_url":"https://api.github.com/repos/KashifSaadat/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KashifSaadat/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KashifSaadat/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/KashifSaadat/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KashifSaadat/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/KashifSaadat/kops/languages","stargazers_url":"https://api.github.com/repos/KashifSaadat/kops/stargazers","contributors_url":"https://api.github.com/repos/KashifSaadat/kops/contributors","subscribers_url":"https://api.github.com/repos/KashifSaadat/kops/subscribers","subscription_url":"https://api.github.com/repos/KashifSaadat/kops/subscription","commits_url":"https://api.github.com/repos/KashifSaadat/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/KashifSaadat/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/KashifSaadat/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/KashifSaadat/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/KashifSaadat/kops/contents/{+path}","compare_url":"https://api.github.com/repos/KashifSaadat/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KashifSaadat/kops/merges","archive_url":"https://api.github.com/repos/KashifSaadat/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KashifSaadat/kops/downloads","issues_url":"https://api.github.com/repos/KashifSaadat/kops/issues{/number}","pulls_url":"https://api.github.com/repos/KashifSaadat/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/KashifSaadat/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/KashifSaadat/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KashifSaadat/kops/labels{/name}","releases_url":"https://api.github.com/repos/KashifSaadat/kops/releases{/id}","deployments_url":"https://api.github.com/repos/KashifSaadat/kops/deployments","created_at":"2017-07-27T15:12:31Z","updated_at":"2017-07-27T15:12:36Z","pushed_at":"2017-11-07T18:17:46Z","git_url":"git://github.com/KashifSaadat/kops.git","ssh_url":"git@github.com:KashifSaadat/kops.git","clone_url":"https://github.com/KashifSaadat/kops.git","svn_url":"https://github.com/KashifSaadat/kops","homepage":"","size":158025,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"dac6813ab1e9132e087e0aa48202d3cde727e94d","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":62091339,"name":"kops","full_name":"kubernetes/kops","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kops","description":"Kubernetes Operations (kops) - Production Grade K8s Installation, Upgrades, and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kops","forks_url":"https://api.github.com/repos/kubernetes/kops/forks","keys_url":"https://api.github.com/repos/kubernetes/kops/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kops/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kops/teams","hooks_url":"https://api.github.com/repos/kubernetes/kops/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kops/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kops/events","assignees_url":"https://api.github.com/repos/kubernetes/kops/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kops/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kops/tags","blobs_url":"https://api.github.com/repos/kubernetes/kops/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kops/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kops/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kops/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kops/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kops/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kops/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kops/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kops/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kops/subscription","commits_url":"https://api.github.com/repos/kubernetes/kops/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kops/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kops/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kops/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kops/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kops/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kops/merges","archive_url":"https://api.github.com/repos/kubernetes/kops/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kops/downloads","issues_url":"https://api.github.com/repos/kubernetes/kops/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kops/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kops/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kops/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kops/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kops/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kops/deployments","created_at":"2016-06-27T22:01:15Z","updated_at":"2017-11-07T18:18:48Z","pushed_at":"2017-11-07T13:32:25Z","git_url":"git://github.com/kubernetes/kops.git","ssh_url":"git@github.com:kubernetes/kops.git","clone_url":"https://github.com/kubernetes/kops.git","svn_url":"https://github.com/kubernetes/kops","homepage":"","size":170215,"stargazers_count":3321,"watchers_count":3321,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":862,"mirror_url":null,"archived":false,"open_issues_count":749,"forks":862,"open_issues":749,"watchers":3321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3790"},"html":{"href":"https://github.com/kubernetes/kops/pull/3790"},"issue":{"href":"https://api.github.com/repos/kubernetes/kops/issues/3790"},"comments":{"href":"https://api.github.com/repos/kubernetes/kops/issues/3790/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3790/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kops/pulls/3790/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kops/statuses/43f193e6ea0e44155cafcce4f3ed119db4ff7f6f"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":46,"deletions":39,"changed_files":8}}
{"actor":{"display_login":"KashifSaadat"}}