{"action":"created","issue":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/3935","repository_url":"https://api.github.com/repos/mne-tools/mne-python","labels_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3935/labels{/name}","comments_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3935/comments","events_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3935/events","html_url":"https://github.com/mne-tools/mne-python/pull/3935","id":203404801,"number":3935,"title":"MRG: Minor enhancements to coreg","user":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/mne-tools/mne-python/milestones/11","html_url":"https://github.com/mne-tools/mne-python/milestone/11","labels_url":"https://api.github.com/repos/mne-tools/mne-python/milestones/11/labels","id":2233512,"number":11,"title":"0.15","description":"Release by early June in advance of HBM (end of June).","creator":{"login":"Eric89GXL","id":2365790,"avatar_url":"https://avatars.githubusercontent.com/u/2365790?v=3","gravatar_id":"","url":"https://api.github.com/users/Eric89GXL","html_url":"https://github.com/Eric89GXL","followers_url":"https://api.github.com/users/Eric89GXL/followers","following_url":"https://api.github.com/users/Eric89GXL/following{/other_user}","gists_url":"https://api.github.com/users/Eric89GXL/gists{/gist_id}","starred_url":"https://api.github.com/users/Eric89GXL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Eric89GXL/subscriptions","organizations_url":"https://api.github.com/users/Eric89GXL/orgs","repos_url":"https://api.github.com/users/Eric89GXL/repos","events_url":"https://api.github.com/users/Eric89GXL/events{/privacy}","received_events_url":"https://api.github.com/users/Eric89GXL/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2017-01-06T17:12:14Z","updated_at":"2017-01-26T16:17:22Z","due_on":"2017-06-02T07:00:00Z","closed_at":null},"comments":2,"created_at":"2017-01-26T15:44:41Z","updated_at":"2017-01-26T16:19:56Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/mne-tools/mne-python/pulls/3935","html_url":"https://github.com/mne-tools/mne-python/pull/3935","diff_url":"https://github.com/mne-tools/mne-python/pull/3935.diff","patch_url":"https://github.com/mne-tools/mne-python/pull/3935.patch"},"body":"This PR:\r\n\r\n1. Adds `verbose` option to the Coreg GUI.\r\n2. Sets surface normals for the head surface for better rendering.\r\n3. Turns on backface culling, which fixes a problem where rotating the head 180 degrees with alpha <1 previously made the head look very strange.\r\n4. Renames scaling params to None/Uniform/3-axis since it's a bit more descriptive.\r\n5. Reorders loading of parameters in `CoregGUI.__init__` to avoid a bug where `mne coreg -s whomever -f inst.fif` wouldn't use `whomever` but rather the name guessed by `inst.fif`. Although you could pass `--no-guess-mri` to work around this bug, this shouldn't be necessary (if MRI is specified, it should be used)\r\n6. Reformats some of the `Property` calls to make it easier to visually track dependencies (should help refactoring)\r\n\r\nReady for review/merge @christianbrodbeck "},"comment":{"url":"https://api.github.com/repos/mne-tools/mne-python/issues/comments/275432564","html_url":"https://github.com/mne-tools/mne-python/pull/3935#issuecomment-275432564","issue_url":"https://api.github.com/repos/mne-tools/mne-python/issues/3935","id":275432564,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars.githubusercontent.com/u/8655789?v=3","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2017-01-26T16:19:56Z","updated_at":"2017-01-26T16:19:56Z","body":"## [Current coverage](https://codecov.io/gh/mne-tools/mne-python/pull/3935?src=pr) is 53.14% (diff: 5.00%)\n> Merging [#3935](https://codecov.io/gh/mne-tools/mne-python/pull/3935?src=pr) into [master](https://codecov.io/gh/mne-tools/mne-python/branch/master?src=pr) will decrease coverage by **32.52%**\n\n```diff\n@@             master      #3935   diff @@\n==========================================\n  Files           349        349            \n  Lines         62113      62121       +8   \n  Methods           0          0            \n  Messages          0          0            \n  Branches       9511       9510       -1   \n==========================================\n- Hits          53211      33013   -20198   \n- Misses         6233      27136   +20903   \n+ Partials       2669       1972     -697   \n```\n\n![Sunburst](https://codecov.io/gh/mne-tools/mne-python/pull/3935/graphs/sunburst.svg?src=pr&size=150)\n\n\n> Powered by [Codecov](https://codecov.io?src=pr). Last update [83b9ced...e9d0ebc](https://codecov.io/gh/mne-tools/mne-python/compare/83b9cedc1d460a20dc20ca9e84f29da01e26c762...e9d0ebc0d35a91ed30974e7b3133980d26fe3094?src=pr)"}}
{"actor":{"display_login":"codecov-io"}}