{"action":"created","comment":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/comments/113204345","pull_request_review_id":34573455,"id":113204345,"diff_hunk":"@@ -1,30 +1,68 @@\n #include \"Scene_surface_mesh_item.h\"\n \n+#include \"Color_map.h\"\n #include <queue>\n #include <boost/graph/properties.hpp>\n #include <boost/graph/graph_traits.hpp>\n #include <QOpenGLShaderProgram>\n #include <QOpenGLBuffer>\n #include <QApplication>\n+#include <QVariant>\n \n-#include <CGAL/boost/graph/properties_Surface_mesh.h>\n-#include <CGAL/Surface_mesh/Surface_mesh.h>\n+//#include <CGAL/boost/graph/properties_Surface_mesh.h>\n+#include <CGAL/Surface_mesh.h>\n+#include <CGAL/intersections.h>\n+#include <CGAL/AABB_tree.h>\n+#include <CGAL/AABB_traits.h>\n \n #include <CGAL/Polygon_mesh_processing/compute_normal.h>\n #include \"triangulate_primitive.h\"\n \n typedef boost::graph_traits<Scene_surface_mesh_item::SMesh>::face_descriptor face_descriptor;\n typedef boost::graph_traits<Scene_surface_mesh_item::SMesh>::halfedge_descriptor halfedge_descriptor;\n typedef boost::graph_traits<Scene_surface_mesh_item::SMesh>::vertex_descriptor vertex_descriptor;\n+//Used to triangulate the AABB_Tree\n+class Primitive\n+{\n+public:\n+  // types\n+  typedef face_descriptor Id; // Id type\n+  typedef Scene_surface_mesh_item::Point Point; // point type\n+  typedef Scene_surface_mesh_item::Kernel::Triangle_3 Datum; // datum type\n+\n+private:\n+  // member data\n+  Id m_it; // iterator\n+  Datum m_datum; // 3D triangle\n+\n+  // constructor\n+public:\n+  Primitive() {}\n+  Primitive(Datum triangle, Id it)\n+    : m_it(it), m_datum(triangle)\n+  {\n+  }\n+public:\n+  Id& id() { return m_it; }\n+  const Id& id() const { return m_it; }\n+  Datum& datum() { return m_datum; }\n+  const Datum& datum() const { return m_datum; }\n+\n+  /// Returns a point on the primitive\n+  Point reference_point() const { return m_datum.vertex(0); }\n+};","path":"Polyhedron/demo/Polyhedron/Scene_surface_mesh_item.cpp","position":56,"original_position":55,"commit_id":"dc883ebd0d47aba0d734029b05189df65384fbce","original_commit_id":"bf1c552a6bbb8b0be1624c9af2f5ac913853828e","user":{"login":"sloriot","id":1224632,"avatar_url":"https://avatars1.githubusercontent.com/u/1224632?v=3","gravatar_id":"","url":"https://api.github.com/users/sloriot","html_url":"https://github.com/sloriot","followers_url":"https://api.github.com/users/sloriot/followers","following_url":"https://api.github.com/users/sloriot/following{/other_user}","gists_url":"https://api.github.com/users/sloriot/gists{/gist_id}","starred_url":"https://api.github.com/users/sloriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloriot/subscriptions","organizations_url":"https://api.github.com/users/sloriot/orgs","repos_url":"https://api.github.com/users/sloriot/repos","events_url":"https://api.github.com/users/sloriot/events{/privacy}","received_events_url":"https://api.github.com/users/sloriot/received_events","type":"User","site_admin":false},"body":"Indeed.","created_at":"2017-04-25T14:07:03Z","updated_at":"2017-04-25T14:07:03Z","html_url":"https://github.com/CGAL/cgal/pull/1983#discussion_r113204345","pull_request_url":"https://api.github.com/repos/CGAL/cgal/pulls/1983","_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments/113204345"},"html":{"href":"https://github.com/CGAL/cgal/pull/1983#discussion_r113204345"},"pull_request":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1983"}}},"pull_request":{"url":"https://api.github.com/repos/CGAL/cgal/pulls/1983","id":111975610,"html_url":"https://github.com/CGAL/cgal/pull/1983","diff_url":"https://github.com/CGAL/cgal/pull/1983.diff","patch_url":"https://github.com/CGAL/cgal/pull/1983.patch","issue_url":"https://api.github.com/repos/CGAL/cgal/issues/1983","number":1983,"state":"open","locked":false,"title":"Use surface_mesh in selection_plugin and edit_polyhedron_plugin","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars3.githubusercontent.com/u/11310805?v=3","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"body":"## Summary of Changes\r\nThe selection_plugin and edit_polyhedron_plugin are able to use a surface_mesh_item as well as a polyhedron_item.\r\n\r\n\r\n## Release Management\r\n* Many PR depend on this one.\r\n* Based on PR #1954.\r\n* Affected package(s):Polyhedron_demo, Mesh_3, Polygon_mesh_processing\r\n* Issue(s) solved (if any): fix #1931\r\n\r\n\r\n","created_at":"2017-03-22T10:30:44Z","updated_at":"2017-04-25T14:07:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"439208235ccb3a49600420d3578865d47b7bed93","assignee":{"login":"lrineau","id":5746675,"avatar_url":"https://avatars2.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false},"assignees":[{"login":"lrineau","id":5746675,"avatar_url":"https://avatars2.githubusercontent.com/u/5746675?v=3","gravatar_id":"","url":"https://api.github.com/users/lrineau","html_url":"https://github.com/lrineau","followers_url":"https://api.github.com/users/lrineau/followers","following_url":"https://api.github.com/users/lrineau/following{/other_user}","gists_url":"https://api.github.com/users/lrineau/gists{/gist_id}","starred_url":"https://api.github.com/users/lrineau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lrineau/subscriptions","organizations_url":"https://api.github.com/users/lrineau/orgs","repos_url":"https://api.github.com/users/lrineau/repos","events_url":"https://api.github.com/users/lrineau/events{/privacy}","received_events_url":"https://api.github.com/users/lrineau/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/CGAL/cgal/milestones/21","html_url":"https://github.com/CGAL/cgal/milestone/21","labels_url":"https://api.github.com/repos/CGAL/cgal/milestones/21/labels","id":2225084,"number":21,"title":"4.11-beta","description":"","creator":{"login":"sloriot","id":1224632,"avatar_url":"https://avatars1.githubusercontent.com/u/1224632?v=3","gravatar_id":"","url":"https://api.github.com/users/sloriot","html_url":"https://github.com/sloriot","followers_url":"https://api.github.com/users/sloriot/followers","following_url":"https://api.github.com/users/sloriot/following{/other_user}","gists_url":"https://api.github.com/users/sloriot/gists{/gist_id}","starred_url":"https://api.github.com/users/sloriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloriot/subscriptions","organizations_url":"https://api.github.com/users/sloriot/orgs","repos_url":"https://api.github.com/users/sloriot/repos","events_url":"https://api.github.com/users/sloriot/events{/privacy}","received_events_url":"https://api.github.com/users/sloriot/received_events","type":"User","site_admin":false},"open_issues":90,"closed_issues":1,"state":"open","created_at":"2017-01-03T13:46:26Z","updated_at":"2017-04-14T13:35:43Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/CGAL/cgal/pulls/1983/commits","review_comments_url":"https://api.github.com/repos/CGAL/cgal/pulls/1983/comments","review_comment_url":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CGAL/cgal/issues/1983/comments","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/dc883ebd0d47aba0d734029b05189df65384fbce","head":{"label":"maxGimeno:Polyhedron_demo-Use_sm_in_Deformation-GF","ref":"Polyhedron_demo-Use_sm_in_Deformation-GF","sha":"dc883ebd0d47aba0d734029b05189df65384fbce","user":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars3.githubusercontent.com/u/11310805?v=3","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"repo":{"id":38375573,"name":"cgal","full_name":"maxGimeno/cgal","owner":{"login":"maxGimeno","id":11310805,"avatar_url":"https://avatars3.githubusercontent.com/u/11310805?v=3","gravatar_id":"","url":"https://api.github.com/users/maxGimeno","html_url":"https://github.com/maxGimeno","followers_url":"https://api.github.com/users/maxGimeno/followers","following_url":"https://api.github.com/users/maxGimeno/following{/other_user}","gists_url":"https://api.github.com/users/maxGimeno/gists{/gist_id}","starred_url":"https://api.github.com/users/maxGimeno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxGimeno/subscriptions","organizations_url":"https://api.github.com/users/maxGimeno/orgs","repos_url":"https://api.github.com/users/maxGimeno/repos","events_url":"https://api.github.com/users/maxGimeno/events{/privacy}","received_events_url":"https://api.github.com/users/maxGimeno/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maxGimeno/cgal","description":"The public CGAL repository","fork":true,"url":"https://api.github.com/repos/maxGimeno/cgal","forks_url":"https://api.github.com/repos/maxGimeno/cgal/forks","keys_url":"https://api.github.com/repos/maxGimeno/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maxGimeno/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maxGimeno/cgal/teams","hooks_url":"https://api.github.com/repos/maxGimeno/cgal/hooks","issue_events_url":"https://api.github.com/repos/maxGimeno/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/maxGimeno/cgal/events","assignees_url":"https://api.github.com/repos/maxGimeno/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/maxGimeno/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/maxGimeno/cgal/tags","blobs_url":"https://api.github.com/repos/maxGimeno/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maxGimeno/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maxGimeno/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/maxGimeno/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maxGimeno/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/maxGimeno/cgal/languages","stargazers_url":"https://api.github.com/repos/maxGimeno/cgal/stargazers","contributors_url":"https://api.github.com/repos/maxGimeno/cgal/contributors","subscribers_url":"https://api.github.com/repos/maxGimeno/cgal/subscribers","subscription_url":"https://api.github.com/repos/maxGimeno/cgal/subscription","commits_url":"https://api.github.com/repos/maxGimeno/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/maxGimeno/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/maxGimeno/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/maxGimeno/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/maxGimeno/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/maxGimeno/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maxGimeno/cgal/merges","archive_url":"https://api.github.com/repos/maxGimeno/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maxGimeno/cgal/downloads","issues_url":"https://api.github.com/repos/maxGimeno/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/maxGimeno/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/maxGimeno/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/maxGimeno/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maxGimeno/cgal/labels{/name}","releases_url":"https://api.github.com/repos/maxGimeno/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/maxGimeno/cgal/deployments","created_at":"2015-07-01T14:25:52Z","updated_at":"2017-01-20T17:02:24Z","pushed_at":"2017-04-25T13:23:49Z","git_url":"git://github.com/maxGimeno/cgal.git","ssh_url":"git@github.com:maxGimeno/cgal.git","clone_url":"https://github.com/maxGimeno/cgal.git","svn_url":"https://github.com/maxGimeno/cgal","homepage":"http://www.cgal.org","size":535411,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"CGAL:master","ref":"master","sha":"fc29bc3a6af4833887afe228b526627b13c452f1","user":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars3.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"repo":{"id":24677392,"name":"cgal","full_name":"CGAL/cgal","owner":{"login":"CGAL","id":5746664,"avatar_url":"https://avatars3.githubusercontent.com/u/5746664?v=3","gravatar_id":"","url":"https://api.github.com/users/CGAL","html_url":"https://github.com/CGAL","followers_url":"https://api.github.com/users/CGAL/followers","following_url":"https://api.github.com/users/CGAL/following{/other_user}","gists_url":"https://api.github.com/users/CGAL/gists{/gist_id}","starred_url":"https://api.github.com/users/CGAL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CGAL/subscriptions","organizations_url":"https://api.github.com/users/CGAL/orgs","repos_url":"https://api.github.com/users/CGAL/repos","events_url":"https://api.github.com/users/CGAL/events{/privacy}","received_events_url":"https://api.github.com/users/CGAL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CGAL/cgal","description":"The public CGAL repository, see the README below","fork":false,"url":"https://api.github.com/repos/CGAL/cgal","forks_url":"https://api.github.com/repos/CGAL/cgal/forks","keys_url":"https://api.github.com/repos/CGAL/cgal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CGAL/cgal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CGAL/cgal/teams","hooks_url":"https://api.github.com/repos/CGAL/cgal/hooks","issue_events_url":"https://api.github.com/repos/CGAL/cgal/issues/events{/number}","events_url":"https://api.github.com/repos/CGAL/cgal/events","assignees_url":"https://api.github.com/repos/CGAL/cgal/assignees{/user}","branches_url":"https://api.github.com/repos/CGAL/cgal/branches{/branch}","tags_url":"https://api.github.com/repos/CGAL/cgal/tags","blobs_url":"https://api.github.com/repos/CGAL/cgal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CGAL/cgal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CGAL/cgal/git/refs{/sha}","trees_url":"https://api.github.com/repos/CGAL/cgal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CGAL/cgal/statuses/{sha}","languages_url":"https://api.github.com/repos/CGAL/cgal/languages","stargazers_url":"https://api.github.com/repos/CGAL/cgal/stargazers","contributors_url":"https://api.github.com/repos/CGAL/cgal/contributors","subscribers_url":"https://api.github.com/repos/CGAL/cgal/subscribers","subscription_url":"https://api.github.com/repos/CGAL/cgal/subscription","commits_url":"https://api.github.com/repos/CGAL/cgal/commits{/sha}","git_commits_url":"https://api.github.com/repos/CGAL/cgal/git/commits{/sha}","comments_url":"https://api.github.com/repos/CGAL/cgal/comments{/number}","issue_comment_url":"https://api.github.com/repos/CGAL/cgal/issues/comments{/number}","contents_url":"https://api.github.com/repos/CGAL/cgal/contents/{+path}","compare_url":"https://api.github.com/repos/CGAL/cgal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CGAL/cgal/merges","archive_url":"https://api.github.com/repos/CGAL/cgal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CGAL/cgal/downloads","issues_url":"https://api.github.com/repos/CGAL/cgal/issues{/number}","pulls_url":"https://api.github.com/repos/CGAL/cgal/pulls{/number}","milestones_url":"https://api.github.com/repos/CGAL/cgal/milestones{/number}","notifications_url":"https://api.github.com/repos/CGAL/cgal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CGAL/cgal/labels{/name}","releases_url":"https://api.github.com/repos/CGAL/cgal/releases{/id}","deployments_url":"https://api.github.com/repos/CGAL/cgal/deployments","created_at":"2014-10-01T12:22:47Z","updated_at":"2017-04-24T10:10:09Z","pushed_at":"2017-04-25T13:30:32Z","git_url":"git://github.com/CGAL/cgal.git","ssh_url":"git@github.com:CGAL/cgal.git","clone_url":"https://github.com/CGAL/cgal.git","svn_url":"https://github.com/CGAL/cgal","homepage":"https://github.com/CGAL/cgal#readme","size":534214,"stargazers_count":510,"watchers_count":510,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":239,"mirror_url":null,"open_issues_count":241,"forks":239,"open_issues":241,"watchers":510,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1983"},"html":{"href":"https://github.com/CGAL/cgal/pull/1983"},"issue":{"href":"https://api.github.com/repos/CGAL/cgal/issues/1983"},"comments":{"href":"https://api.github.com/repos/CGAL/cgal/issues/1983/comments"},"review_comments":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1983/comments"},"review_comment":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CGAL/cgal/pulls/1983/commits"},"statuses":{"href":"https://api.github.com/repos/CGAL/cgal/statuses/dc883ebd0d47aba0d734029b05189df65384fbce"}}}}
{"actor":{"display_login":"sloriot"}}