{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/94688911","pull_request_review_id":15222547,"id":94688911,"diff_hunk":"@@ -70,11 +70,20 @@ const (\n \tReasonMessageInvalidArtifactsMapping api.StepFailureMessage = \"Invalid artifacts mapping specified.\"\n \n \t// ReasonArtifactsFetchFailed is the reason associated with a failure to\n-\t// download specified scripts in the application image.\n-\tReasonArtifactsFetchFailed api.StepFailureReason = \"FetchScriptsFailed\"\n+\t// download specified artifacts in the application image.\n+\tReasonArtifactsFetchFailed api.StepFailureReason = \"FetchArtifactsFailed\"\n \t// ReasonMessageArtifactsFetchFailed is the message associated with a failure to\n-\t// download specified scripts in the application image.\n-\tReasonMessageArtifactsFetchFailed api.StepFailureMessage = \"Failed to fetch scripts specified scripts.\"\n+\t// download specified artifacts in the application image.\n+\tReasonMessageArtifactsFetchFailed api.StepFailureMessage = \"Failed to fetch specified artifacts.\"","path":"pkg/util/status/build_status.go","position":null,"original_position":12,"commit_id":"153002804c92b9def389eff410f4a3aa113d1eae","original_commit_id":"c4a4b9d8d7417efcc2488cff7979b515cb331519","user":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"body":"scripts it is, then.","created_at":"2017-01-04T23:38:50Z","updated_at":"2017-01-04T23:38:51Z","html_url":"https://github.com/openshift/source-to-image/pull/673#discussion_r94688911","pull_request_url":"https://api.github.com/repos/openshift/source-to-image/pulls/673","_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments/94688911"},"html":{"href":"https://github.com/openshift/source-to-image/pull/673#discussion_r94688911"},"pull_request":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/673"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/source-to-image/pulls/673","id":100130799,"html_url":"https://github.com/openshift/source-to-image/pull/673","diff_url":"https://github.com/openshift/source-to-image/pull/673.diff","patch_url":"https://github.com/openshift/source-to-image/pull/673.patch","issue_url":"https://api.github.com/repos/openshift/source-to-image/issues/673","number":673,"state":"open","locked":false,"title":"[DO_NOT_MERGE] minor improvements","user":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"body":"* removes reason and status failure for onbuild strat - since it's not supported in openshift, then it's not needed here.\r\n* add runtime artifacts reason and message for failing to fetch them. should fix https://bugzilla.redhat.com/show_bug.cgi?id=1403712 still need to test it out\r\n* rename s2i specific errors package to `s2ierr` to avoid collision with core `errors` package.\r\n* make error messages consistent through out the app.\r\n\r\n\r\n[test]","created_at":"2017-01-04T15:11:42Z","updated_at":"2017-01-04T23:38:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a0697f8c7536650ed22ecc420b7458fcf09677b9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/source-to-image/pulls/673/commits","review_comments_url":"https://api.github.com/repos/openshift/source-to-image/pulls/673/comments","review_comment_url":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/source-to-image/issues/673/comments","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/153002804c92b9def389eff410f4a3aa113d1eae","head":{"label":"PI-Victor:fix_artifacts","ref":"fix_artifacts","sha":"153002804c92b9def389eff410f4a3aa113d1eae","user":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"repo":{"id":63790091,"name":"source-to-image","full_name":"PI-Victor/source-to-image","owner":{"login":"PI-Victor","id":6294120,"avatar_url":"https://avatars.githubusercontent.com/u/6294120?v=3","gravatar_id":"","url":"https://api.github.com/users/PI-Victor","html_url":"https://github.com/PI-Victor","followers_url":"https://api.github.com/users/PI-Victor/followers","following_url":"https://api.github.com/users/PI-Victor/following{/other_user}","gists_url":"https://api.github.com/users/PI-Victor/gists{/gist_id}","starred_url":"https://api.github.com/users/PI-Victor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PI-Victor/subscriptions","organizations_url":"https://api.github.com/users/PI-Victor/orgs","repos_url":"https://api.github.com/users/PI-Victor/repos","events_url":"https://api.github.com/users/PI-Victor/events{/privacy}","received_events_url":"https://api.github.com/users/PI-Victor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PI-Victor/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":true,"url":"https://api.github.com/repos/PI-Victor/source-to-image","forks_url":"https://api.github.com/repos/PI-Victor/source-to-image/forks","keys_url":"https://api.github.com/repos/PI-Victor/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PI-Victor/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PI-Victor/source-to-image/teams","hooks_url":"https://api.github.com/repos/PI-Victor/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/PI-Victor/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/PI-Victor/source-to-image/events","assignees_url":"https://api.github.com/repos/PI-Victor/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/PI-Victor/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/PI-Victor/source-to-image/tags","blobs_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PI-Victor/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/PI-Victor/source-to-image/languages","stargazers_url":"https://api.github.com/repos/PI-Victor/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/PI-Victor/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/PI-Victor/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/PI-Victor/source-to-image/subscription","commits_url":"https://api.github.com/repos/PI-Victor/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/PI-Victor/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/PI-Victor/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/PI-Victor/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/PI-Victor/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/PI-Victor/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PI-Victor/source-to-image/merges","archive_url":"https://api.github.com/repos/PI-Victor/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PI-Victor/source-to-image/downloads","issues_url":"https://api.github.com/repos/PI-Victor/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/PI-Victor/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/PI-Victor/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/PI-Victor/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PI-Victor/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/PI-Victor/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/PI-Victor/source-to-image/deployments","created_at":"2016-07-20T14:54:06Z","updated_at":"2016-07-20T14:54:07Z","pushed_at":"2017-01-04T23:38:42Z","git_url":"git://github.com/PI-Victor/source-to-image.git","ssh_url":"git@github.com:PI-Victor/source-to-image.git","clone_url":"https://github.com/PI-Victor/source-to-image.git","svn_url":"https://github.com/PI-Victor/source-to-image","homepage":"","size":15716,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"6d638c6ab64d0b214baebb0bdf6660a97c8ec22b","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":16323162,"name":"source-to-image","full_name":"openshift/source-to-image","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars.githubusercontent.com/u/792337?v=3","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/source-to-image","description":"A tool for building/building artifacts from source and injecting into docker images","fork":false,"url":"https://api.github.com/repos/openshift/source-to-image","forks_url":"https://api.github.com/repos/openshift/source-to-image/forks","keys_url":"https://api.github.com/repos/openshift/source-to-image/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/source-to-image/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/source-to-image/teams","hooks_url":"https://api.github.com/repos/openshift/source-to-image/hooks","issue_events_url":"https://api.github.com/repos/openshift/source-to-image/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/source-to-image/events","assignees_url":"https://api.github.com/repos/openshift/source-to-image/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/source-to-image/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/source-to-image/tags","blobs_url":"https://api.github.com/repos/openshift/source-to-image/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/source-to-image/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/source-to-image/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/source-to-image/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/source-to-image/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/source-to-image/languages","stargazers_url":"https://api.github.com/repos/openshift/source-to-image/stargazers","contributors_url":"https://api.github.com/repos/openshift/source-to-image/contributors","subscribers_url":"https://api.github.com/repos/openshift/source-to-image/subscribers","subscription_url":"https://api.github.com/repos/openshift/source-to-image/subscription","commits_url":"https://api.github.com/repos/openshift/source-to-image/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/source-to-image/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/source-to-image/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/source-to-image/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/source-to-image/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/source-to-image/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/source-to-image/merges","archive_url":"https://api.github.com/repos/openshift/source-to-image/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/source-to-image/downloads","issues_url":"https://api.github.com/repos/openshift/source-to-image/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/source-to-image/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/source-to-image/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/source-to-image/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/source-to-image/labels{/name}","releases_url":"https://api.github.com/repos/openshift/source-to-image/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/source-to-image/deployments","created_at":"2014-01-28T19:32:40Z","updated_at":"2017-01-04T16:09:53Z","pushed_at":"2017-01-04T23:38:44Z","git_url":"git://github.com/openshift/source-to-image.git","ssh_url":"git@github.com:openshift/source-to-image.git","clone_url":"https://github.com/openshift/source-to-image.git","svn_url":"https://github.com/openshift/source-to-image","homepage":"","size":15690,"stargazers_count":349,"watchers_count":349,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":165,"mirror_url":null,"open_issues_count":28,"forks":165,"open_issues":28,"watchers":349,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/673"},"html":{"href":"https://github.com/openshift/source-to-image/pull/673"},"issue":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/673"},"comments":{"href":"https://api.github.com/repos/openshift/source-to-image/issues/673/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/673/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/source-to-image/pulls/673/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/source-to-image/statuses/153002804c92b9def389eff410f4a3aa113d1eae"}}}}
{"actor":{"display_login":"PI-Victor"}}