{"action":"created","comment":{"url":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/comments/123900114","pull_request_review_id":46146710,"id":123900114,"diff_hunk":"@@ -49,6 +84,8 @@ class JoomlaBrowser extends WebDriver\n \tpublic function doAdministratorLogin($user = null, $password = null)\n \t{\n \t\t$I = $this;\n+\t\t$locator = $this->instantiateLocator();","path":"src/JoomlaBrowser.php","position":56,"original_position":56,"commit_id":"350bb6aee81d70683c2b4a9822d74a6307f81557","original_commit_id":"350bb6aee81d70683c2b4a9822d74a6307f81557","user":{"login":"yvesh","id":897638,"avatar_url":"https://avatars3.githubusercontent.com/u/897638?v=3","gravatar_id":"","url":"https://api.github.com/users/yvesh","html_url":"https://github.com/yvesh","followers_url":"https://api.github.com/users/yvesh/followers","following_url":"https://api.github.com/users/yvesh/following{/other_user}","gists_url":"https://api.github.com/users/yvesh/gists{/gist_id}","starred_url":"https://api.github.com/users/yvesh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yvesh/subscriptions","organizations_url":"https://api.github.com/users/yvesh/orgs","repos_url":"https://api.github.com/users/yvesh/repos","events_url":"https://api.github.com/users/yvesh/events{/privacy}","received_events_url":"https://api.github.com/users/yvesh/received_events","type":"User","site_admin":false},"body":"Just do that once in the __constructor :-)","created_at":"2017-06-25T14:30:24Z","updated_at":"2017-06-25T14:30:24Z","html_url":"https://github.com/joomla-projects/joomla-browser/pull/131#discussion_r123900114","pull_request_url":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/131","_links":{"self":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/comments/123900114"},"html":{"href":"https://github.com/joomla-projects/joomla-browser/pull/131#discussion_r123900114"},"pull_request":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/131","id":120669672,"html_url":"https://github.com/joomla-projects/joomla-browser/pull/131","diff_url":"https://github.com/joomla-projects/joomla-browser/pull/131.diff","patch_url":"https://github.com/joomla-projects/joomla-browser/pull/131.patch","issue_url":"https://api.github.com/repos/joomla-projects/joomla-browser/issues/131","number":131,"state":"open","locked":false,"title":"Adding Support of Custom Template Locators","user":{"login":"puneet0191","id":3048593,"avatar_url":"https://avatars3.githubusercontent.com/u/3048593?v=3","gravatar_id":"","url":"https://api.github.com/users/puneet0191","html_url":"https://github.com/puneet0191","followers_url":"https://api.github.com/users/puneet0191/followers","following_url":"https://api.github.com/users/puneet0191/following{/other_user}","gists_url":"https://api.github.com/users/puneet0191/gists{/gist_id}","starred_url":"https://api.github.com/users/puneet0191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneet0191/subscriptions","organizations_url":"https://api.github.com/users/puneet0191/orgs","repos_url":"https://api.github.com/users/puneet0191/repos","events_url":"https://api.github.com/users/puneet0191/events{/privacy}","received_events_url":"https://api.github.com/users/puneet0191/received_events","type":"User","site_admin":false},"body":"currently Joomla Browser only supports locators for Protostar template, but when testing against extensions which has custom Template, all the methods fail because of wrong locators, with this PR, I am trying to establish an option in which Extension developers can pass their custom Locators class, It works like Page Object class. The new function ``instantiateLocator`` checks if any custom Template locator has been provided in the acceptance.suite.yml file and then instantiates the locator object with custom Template locator. \r\n\r\nJust by adding this in Acceptance Suite file \r\n![image](https://cloud.githubusercontent.com/assets/3048593/26073874/b05c986a-39cd-11e7-93e1-22c38020e638.png)\r\nThis PR makes sure, no changes are required in the existing system and no failures occur because of this change, extension developers who are using Joomla Browser will have an option to use this feature if they want to. ","created_at":"2017-05-15T18:54:38Z","updated_at":"2017-06-25T14:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d35bd462f1e1ef4376a0d8c2c8801be5e3599ce","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/131/commits","review_comments_url":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/131/comments","review_comment_url":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joomla-projects/joomla-browser/issues/131/comments","statuses_url":"https://api.github.com/repos/joomla-projects/joomla-browser/statuses/350bb6aee81d70683c2b4a9822d74a6307f81557","head":{"label":"puneet0191:Template-Management","ref":"Template-Management","sha":"350bb6aee81d70683c2b4a9822d74a6307f81557","user":{"login":"puneet0191","id":3048593,"avatar_url":"https://avatars3.githubusercontent.com/u/3048593?v=3","gravatar_id":"","url":"https://api.github.com/users/puneet0191","html_url":"https://github.com/puneet0191","followers_url":"https://api.github.com/users/puneet0191/followers","following_url":"https://api.github.com/users/puneet0191/following{/other_user}","gists_url":"https://api.github.com/users/puneet0191/gists{/gist_id}","starred_url":"https://api.github.com/users/puneet0191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneet0191/subscriptions","organizations_url":"https://api.github.com/users/puneet0191/orgs","repos_url":"https://api.github.com/users/puneet0191/repos","events_url":"https://api.github.com/users/puneet0191/events{/privacy}","received_events_url":"https://api.github.com/users/puneet0191/received_events","type":"User","site_admin":false},"repo":{"id":34470383,"name":"joomla-browser","full_name":"puneet0191/joomla-browser","owner":{"login":"puneet0191","id":3048593,"avatar_url":"https://avatars3.githubusercontent.com/u/3048593?v=3","gravatar_id":"","url":"https://api.github.com/users/puneet0191","html_url":"https://github.com/puneet0191","followers_url":"https://api.github.com/users/puneet0191/followers","following_url":"https://api.github.com/users/puneet0191/following{/other_user}","gists_url":"https://api.github.com/users/puneet0191/gists{/gist_id}","starred_url":"https://api.github.com/users/puneet0191/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puneet0191/subscriptions","organizations_url":"https://api.github.com/users/puneet0191/orgs","repos_url":"https://api.github.com/users/puneet0191/repos","events_url":"https://api.github.com/users/puneet0191/events{/privacy}","received_events_url":"https://api.github.com/users/puneet0191/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/puneet0191/joomla-browser","description":"An extended Webdriver Browser to navigate through Joomla sites with Codeception","fork":true,"url":"https://api.github.com/repos/puneet0191/joomla-browser","forks_url":"https://api.github.com/repos/puneet0191/joomla-browser/forks","keys_url":"https://api.github.com/repos/puneet0191/joomla-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puneet0191/joomla-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puneet0191/joomla-browser/teams","hooks_url":"https://api.github.com/repos/puneet0191/joomla-browser/hooks","issue_events_url":"https://api.github.com/repos/puneet0191/joomla-browser/issues/events{/number}","events_url":"https://api.github.com/repos/puneet0191/joomla-browser/events","assignees_url":"https://api.github.com/repos/puneet0191/joomla-browser/assignees{/user}","branches_url":"https://api.github.com/repos/puneet0191/joomla-browser/branches{/branch}","tags_url":"https://api.github.com/repos/puneet0191/joomla-browser/tags","blobs_url":"https://api.github.com/repos/puneet0191/joomla-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puneet0191/joomla-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puneet0191/joomla-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/puneet0191/joomla-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puneet0191/joomla-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/puneet0191/joomla-browser/languages","stargazers_url":"https://api.github.com/repos/puneet0191/joomla-browser/stargazers","contributors_url":"https://api.github.com/repos/puneet0191/joomla-browser/contributors","subscribers_url":"https://api.github.com/repos/puneet0191/joomla-browser/subscribers","subscription_url":"https://api.github.com/repos/puneet0191/joomla-browser/subscription","commits_url":"https://api.github.com/repos/puneet0191/joomla-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/puneet0191/joomla-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/puneet0191/joomla-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/puneet0191/joomla-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/puneet0191/joomla-browser/contents/{+path}","compare_url":"https://api.github.com/repos/puneet0191/joomla-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puneet0191/joomla-browser/merges","archive_url":"https://api.github.com/repos/puneet0191/joomla-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puneet0191/joomla-browser/downloads","issues_url":"https://api.github.com/repos/puneet0191/joomla-browser/issues{/number}","pulls_url":"https://api.github.com/repos/puneet0191/joomla-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/puneet0191/joomla-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/puneet0191/joomla-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puneet0191/joomla-browser/labels{/name}","releases_url":"https://api.github.com/repos/puneet0191/joomla-browser/releases{/id}","deployments_url":"https://api.github.com/repos/puneet0191/joomla-browser/deployments","created_at":"2015-04-23T17:13:36Z","updated_at":"2016-02-08T18:10:50Z","pushed_at":"2017-06-22T19:29:03Z","git_url":"git://github.com/puneet0191/joomla-browser.git","ssh_url":"git@github.com:puneet0191/joomla-browser.git","clone_url":"https://github.com/puneet0191/joomla-browser.git","svn_url":"https://github.com/puneet0191/joomla-browser","homepage":null,"size":289,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"joomla-projects:develop","ref":"develop","sha":"f766edb90b92a0616b0817dc134d5428cb7bde8c","user":{"login":"joomla-projects","id":4417437,"avatar_url":"https://avatars3.githubusercontent.com/u/4417437?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla-projects","html_url":"https://github.com/joomla-projects","followers_url":"https://api.github.com/users/joomla-projects/followers","following_url":"https://api.github.com/users/joomla-projects/following{/other_user}","gists_url":"https://api.github.com/users/joomla-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-projects/subscriptions","organizations_url":"https://api.github.com/users/joomla-projects/orgs","repos_url":"https://api.github.com/users/joomla-projects/repos","events_url":"https://api.github.com/users/joomla-projects/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-projects/received_events","type":"Organization","site_admin":false},"repo":{"id":34443186,"name":"joomla-browser","full_name":"joomla-projects/joomla-browser","owner":{"login":"joomla-projects","id":4417437,"avatar_url":"https://avatars3.githubusercontent.com/u/4417437?v=3","gravatar_id":"","url":"https://api.github.com/users/joomla-projects","html_url":"https://github.com/joomla-projects","followers_url":"https://api.github.com/users/joomla-projects/followers","following_url":"https://api.github.com/users/joomla-projects/following{/other_user}","gists_url":"https://api.github.com/users/joomla-projects/gists{/gist_id}","starred_url":"https://api.github.com/users/joomla-projects/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joomla-projects/subscriptions","organizations_url":"https://api.github.com/users/joomla-projects/orgs","repos_url":"https://api.github.com/users/joomla-projects/repos","events_url":"https://api.github.com/users/joomla-projects/events{/privacy}","received_events_url":"https://api.github.com/users/joomla-projects/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/joomla-projects/joomla-browser","description":"An extended Webdriver Browser to navigate through Joomla sites with Codeception","fork":false,"url":"https://api.github.com/repos/joomla-projects/joomla-browser","forks_url":"https://api.github.com/repos/joomla-projects/joomla-browser/forks","keys_url":"https://api.github.com/repos/joomla-projects/joomla-browser/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joomla-projects/joomla-browser/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joomla-projects/joomla-browser/teams","hooks_url":"https://api.github.com/repos/joomla-projects/joomla-browser/hooks","issue_events_url":"https://api.github.com/repos/joomla-projects/joomla-browser/issues/events{/number}","events_url":"https://api.github.com/repos/joomla-projects/joomla-browser/events","assignees_url":"https://api.github.com/repos/joomla-projects/joomla-browser/assignees{/user}","branches_url":"https://api.github.com/repos/joomla-projects/joomla-browser/branches{/branch}","tags_url":"https://api.github.com/repos/joomla-projects/joomla-browser/tags","blobs_url":"https://api.github.com/repos/joomla-projects/joomla-browser/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joomla-projects/joomla-browser/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joomla-projects/joomla-browser/git/refs{/sha}","trees_url":"https://api.github.com/repos/joomla-projects/joomla-browser/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joomla-projects/joomla-browser/statuses/{sha}","languages_url":"https://api.github.com/repos/joomla-projects/joomla-browser/languages","stargazers_url":"https://api.github.com/repos/joomla-projects/joomla-browser/stargazers","contributors_url":"https://api.github.com/repos/joomla-projects/joomla-browser/contributors","subscribers_url":"https://api.github.com/repos/joomla-projects/joomla-browser/subscribers","subscription_url":"https://api.github.com/repos/joomla-projects/joomla-browser/subscription","commits_url":"https://api.github.com/repos/joomla-projects/joomla-browser/commits{/sha}","git_commits_url":"https://api.github.com/repos/joomla-projects/joomla-browser/git/commits{/sha}","comments_url":"https://api.github.com/repos/joomla-projects/joomla-browser/comments{/number}","issue_comment_url":"https://api.github.com/repos/joomla-projects/joomla-browser/issues/comments{/number}","contents_url":"https://api.github.com/repos/joomla-projects/joomla-browser/contents/{+path}","compare_url":"https://api.github.com/repos/joomla-projects/joomla-browser/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joomla-projects/joomla-browser/merges","archive_url":"https://api.github.com/repos/joomla-projects/joomla-browser/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joomla-projects/joomla-browser/downloads","issues_url":"https://api.github.com/repos/joomla-projects/joomla-browser/issues{/number}","pulls_url":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls{/number}","milestones_url":"https://api.github.com/repos/joomla-projects/joomla-browser/milestones{/number}","notifications_url":"https://api.github.com/repos/joomla-projects/joomla-browser/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joomla-projects/joomla-browser/labels{/name}","releases_url":"https://api.github.com/repos/joomla-projects/joomla-browser/releases{/id}","deployments_url":"https://api.github.com/repos/joomla-projects/joomla-browser/deployments","created_at":"2015-04-23T08:13:58Z","updated_at":"2017-05-15T10:53:58Z","pushed_at":"2017-06-22T19:29:04Z","git_url":"git://github.com/joomla-projects/joomla-browser.git","ssh_url":"git@github.com:joomla-projects/joomla-browser.git","clone_url":"https://github.com/joomla-projects/joomla-browser.git","svn_url":"https://github.com/joomla-projects/joomla-browser","homepage":null,"size":213,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":27,"mirror_url":null,"open_issues_count":23,"forks":27,"open_issues":23,"watchers":13,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/131"},"html":{"href":"https://github.com/joomla-projects/joomla-browser/pull/131"},"issue":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/issues/131"},"comments":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/joomla-projects/joomla-browser/statuses/350bb6aee81d70683c2b4a9822d74a6307f81557"}}}}
{"actor":{"display_login":"yvesh"}}