{"action":"created","comment":{"url":"https://api.github.com/repos/release-engineering/kobo/pulls/comments/136879395","pull_request_review_id":60477513,"id":136879395,"diff_hunk":"@@ -62,10 +62,10 @@ def new_func(*args, **kwargs):\n             import datetime\n             import kobo.shortcuts\n             import kobo.tback\n-            date = datetime.datetime.strftime(datetime.datetime.now(), \"%F %R:%S\")\n-            data =  \"--- TRACEBACK BEGIN: %s ---\\n\" % date\n+            date = datetime.datetime.strftime(datetime.datetime.now(), \"%F %R:%S\").encode()","path":"kobo/decorators.py","position":6,"original_position":6,"commit_id":"4dbc4babb3e7030f043e1eeb839569e2ed333853","original_commit_id":"9f32084dc12444d8d5daf9b5d90addd9c6cc8a6c","user":{"login":"tkdchen","id":919706,"avatar_url":"https://avatars3.githubusercontent.com/u/919706?v=4","gravatar_id":"","url":"https://api.github.com/users/tkdchen","html_url":"https://github.com/tkdchen","followers_url":"https://api.github.com/users/tkdchen/followers","following_url":"https://api.github.com/users/tkdchen/following{/other_user}","gists_url":"https://api.github.com/users/tkdchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tkdchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkdchen/subscriptions","organizations_url":"https://api.github.com/users/tkdchen/orgs","repos_url":"https://api.github.com/users/tkdchen/repos","events_url":"https://api.github.com/users/tkdchen/events{/privacy}","received_events_url":"https://api.github.com/users/tkdchen/received_events","type":"User","site_admin":false},"body":"Isn't an explicit encoding necessary here? For example, ``utf-8``.","created_at":"2017-09-05T00:47:05Z","updated_at":"2017-09-05T00:47:05Z","html_url":"https://github.com/release-engineering/kobo/pull/48#discussion_r136879395","pull_request_url":"https://api.github.com/repos/release-engineering/kobo/pulls/48","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/comments/136879395"},"html":{"href":"https://github.com/release-engineering/kobo/pull/48#discussion_r136879395"},"pull_request":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/release-engineering/kobo/pulls/48","id":139182363,"html_url":"https://github.com/release-engineering/kobo/pull/48","diff_url":"https://github.com/release-engineering/kobo/pull/48.diff","patch_url":"https://github.com/release-engineering/kobo/pull/48.patch","issue_url":"https://api.github.com/repos/release-engineering/kobo/issues/48","number":48,"state":"open","locked":false,"title":"[WIP] Python3 compatible Kobo","user":{"login":"frenzymadness","id":5688939,"avatar_url":"https://avatars3.githubusercontent.com/u/5688939?v=4","gravatar_id":"","url":"https://api.github.com/users/frenzymadness","html_url":"https://github.com/frenzymadness","followers_url":"https://api.github.com/users/frenzymadness/followers","following_url":"https://api.github.com/users/frenzymadness/following{/other_user}","gists_url":"https://api.github.com/users/frenzymadness/gists{/gist_id}","starred_url":"https://api.github.com/users/frenzymadness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenzymadness/subscriptions","organizations_url":"https://api.github.com/users/frenzymadness/orgs","repos_url":"https://api.github.com/users/frenzymadness/repos","events_url":"https://api.github.com/users/frenzymadness/events{/privacy}","received_events_url":"https://api.github.com/users/frenzymadness/received_events","type":"User","site_admin":false},"body":"Hello.\r\n\r\nI've done some work and the part of codebase covered by tests is Python 3 compatible!\r\n\r\nThis PR is still in WIP state because I want to do my own code review after a day or two of rest. In the meantime, feel free to do a review. I am not planning to change something heavily.\r\n\r\nThe most changes are related to Kobo core which has also the best test coverage but some simple changes like absolute imports, renamed modules and attributes etc. are fixed in all places.\r\n\r\nIf you find a bug, the best solution is to send a patch with a new test which tests that it won't happen again. But I know that it is not possible very time. Also, if you find something weird, let me know and please add some example of usage, because I am not a Kobo user and I've met it for the first time so maybe I misunderstood something during porting.\r\n\r\nThank you. Hopefully, we can make Kobo Python 3 compatible together.","created_at":"2017-09-04T15:42:58Z","updated_at":"2017-09-05T00:47:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1aadc0c8363e175ec43a0329193a46a4e6e45a22","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/release-engineering/kobo/pulls/48/commits","review_comments_url":"https://api.github.com/repos/release-engineering/kobo/pulls/48/comments","review_comment_url":"https://api.github.com/repos/release-engineering/kobo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/release-engineering/kobo/issues/48/comments","statuses_url":"https://api.github.com/repos/release-engineering/kobo/statuses/4dbc4babb3e7030f043e1eeb839569e2ed333853","head":{"label":"frenzymadness:python3-dev","ref":"python3-dev","sha":"4dbc4babb3e7030f043e1eeb839569e2ed333853","user":{"login":"frenzymadness","id":5688939,"avatar_url":"https://avatars3.githubusercontent.com/u/5688939?v=4","gravatar_id":"","url":"https://api.github.com/users/frenzymadness","html_url":"https://github.com/frenzymadness","followers_url":"https://api.github.com/users/frenzymadness/followers","following_url":"https://api.github.com/users/frenzymadness/following{/other_user}","gists_url":"https://api.github.com/users/frenzymadness/gists{/gist_id}","starred_url":"https://api.github.com/users/frenzymadness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenzymadness/subscriptions","organizations_url":"https://api.github.com/users/frenzymadness/orgs","repos_url":"https://api.github.com/users/frenzymadness/repos","events_url":"https://api.github.com/users/frenzymadness/events{/privacy}","received_events_url":"https://api.github.com/users/frenzymadness/received_events","type":"User","site_admin":false},"repo":{"id":99113792,"name":"kobo","full_name":"frenzymadness/kobo","owner":{"login":"frenzymadness","id":5688939,"avatar_url":"https://avatars3.githubusercontent.com/u/5688939?v=4","gravatar_id":"","url":"https://api.github.com/users/frenzymadness","html_url":"https://github.com/frenzymadness","followers_url":"https://api.github.com/users/frenzymadness/followers","following_url":"https://api.github.com/users/frenzymadness/following{/other_user}","gists_url":"https://api.github.com/users/frenzymadness/gists{/gist_id}","starred_url":"https://api.github.com/users/frenzymadness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frenzymadness/subscriptions","organizations_url":"https://api.github.com/users/frenzymadness/orgs","repos_url":"https://api.github.com/users/frenzymadness/repos","events_url":"https://api.github.com/users/frenzymadness/events{/privacy}","received_events_url":"https://api.github.com/users/frenzymadness/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/frenzymadness/kobo","description":"A pile of python modules used by Red Hat release engineering to build their tools.","fork":true,"url":"https://api.github.com/repos/frenzymadness/kobo","forks_url":"https://api.github.com/repos/frenzymadness/kobo/forks","keys_url":"https://api.github.com/repos/frenzymadness/kobo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/frenzymadness/kobo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/frenzymadness/kobo/teams","hooks_url":"https://api.github.com/repos/frenzymadness/kobo/hooks","issue_events_url":"https://api.github.com/repos/frenzymadness/kobo/issues/events{/number}","events_url":"https://api.github.com/repos/frenzymadness/kobo/events","assignees_url":"https://api.github.com/repos/frenzymadness/kobo/assignees{/user}","branches_url":"https://api.github.com/repos/frenzymadness/kobo/branches{/branch}","tags_url":"https://api.github.com/repos/frenzymadness/kobo/tags","blobs_url":"https://api.github.com/repos/frenzymadness/kobo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/frenzymadness/kobo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/frenzymadness/kobo/git/refs{/sha}","trees_url":"https://api.github.com/repos/frenzymadness/kobo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/frenzymadness/kobo/statuses/{sha}","languages_url":"https://api.github.com/repos/frenzymadness/kobo/languages","stargazers_url":"https://api.github.com/repos/frenzymadness/kobo/stargazers","contributors_url":"https://api.github.com/repos/frenzymadness/kobo/contributors","subscribers_url":"https://api.github.com/repos/frenzymadness/kobo/subscribers","subscription_url":"https://api.github.com/repos/frenzymadness/kobo/subscription","commits_url":"https://api.github.com/repos/frenzymadness/kobo/commits{/sha}","git_commits_url":"https://api.github.com/repos/frenzymadness/kobo/git/commits{/sha}","comments_url":"https://api.github.com/repos/frenzymadness/kobo/comments{/number}","issue_comment_url":"https://api.github.com/repos/frenzymadness/kobo/issues/comments{/number}","contents_url":"https://api.github.com/repos/frenzymadness/kobo/contents/{+path}","compare_url":"https://api.github.com/repos/frenzymadness/kobo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/frenzymadness/kobo/merges","archive_url":"https://api.github.com/repos/frenzymadness/kobo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/frenzymadness/kobo/downloads","issues_url":"https://api.github.com/repos/frenzymadness/kobo/issues{/number}","pulls_url":"https://api.github.com/repos/frenzymadness/kobo/pulls{/number}","milestones_url":"https://api.github.com/repos/frenzymadness/kobo/milestones{/number}","notifications_url":"https://api.github.com/repos/frenzymadness/kobo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/frenzymadness/kobo/labels{/name}","releases_url":"https://api.github.com/repos/frenzymadness/kobo/releases{/id}","deployments_url":"https://api.github.com/repos/frenzymadness/kobo/deployments","created_at":"2017-08-02T12:25:07Z","updated_at":"2017-08-02T12:25:09Z","pushed_at":"2017-09-04T15:31:39Z","git_url":"git://github.com/frenzymadness/kobo.git","ssh_url":"git@github.com:frenzymadness/kobo.git","clone_url":"https://github.com/frenzymadness/kobo.git","svn_url":"https://github.com/frenzymadness/kobo","homepage":null,"size":487,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"release-engineering:master","ref":"master","sha":"966808a2af7d65dd65347b5336d1d174fff34d5b","user":{"login":"release-engineering","id":9591189,"avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":52263225,"name":"kobo","full_name":"release-engineering/kobo","owner":{"login":"release-engineering","id":9591189,"avatar_url":"https://avatars3.githubusercontent.com/u/9591189?v=4","gravatar_id":"","url":"https://api.github.com/users/release-engineering","html_url":"https://github.com/release-engineering","followers_url":"https://api.github.com/users/release-engineering/followers","following_url":"https://api.github.com/users/release-engineering/following{/other_user}","gists_url":"https://api.github.com/users/release-engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/release-engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/release-engineering/subscriptions","organizations_url":"https://api.github.com/users/release-engineering/orgs","repos_url":"https://api.github.com/users/release-engineering/repos","events_url":"https://api.github.com/users/release-engineering/events{/privacy}","received_events_url":"https://api.github.com/users/release-engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/release-engineering/kobo","description":"A pile of python modules used by Red Hat release engineering to build their tools.","fork":false,"url":"https://api.github.com/repos/release-engineering/kobo","forks_url":"https://api.github.com/repos/release-engineering/kobo/forks","keys_url":"https://api.github.com/repos/release-engineering/kobo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/release-engineering/kobo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/release-engineering/kobo/teams","hooks_url":"https://api.github.com/repos/release-engineering/kobo/hooks","issue_events_url":"https://api.github.com/repos/release-engineering/kobo/issues/events{/number}","events_url":"https://api.github.com/repos/release-engineering/kobo/events","assignees_url":"https://api.github.com/repos/release-engineering/kobo/assignees{/user}","branches_url":"https://api.github.com/repos/release-engineering/kobo/branches{/branch}","tags_url":"https://api.github.com/repos/release-engineering/kobo/tags","blobs_url":"https://api.github.com/repos/release-engineering/kobo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/release-engineering/kobo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/release-engineering/kobo/git/refs{/sha}","trees_url":"https://api.github.com/repos/release-engineering/kobo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/release-engineering/kobo/statuses/{sha}","languages_url":"https://api.github.com/repos/release-engineering/kobo/languages","stargazers_url":"https://api.github.com/repos/release-engineering/kobo/stargazers","contributors_url":"https://api.github.com/repos/release-engineering/kobo/contributors","subscribers_url":"https://api.github.com/repos/release-engineering/kobo/subscribers","subscription_url":"https://api.github.com/repos/release-engineering/kobo/subscription","commits_url":"https://api.github.com/repos/release-engineering/kobo/commits{/sha}","git_commits_url":"https://api.github.com/repos/release-engineering/kobo/git/commits{/sha}","comments_url":"https://api.github.com/repos/release-engineering/kobo/comments{/number}","issue_comment_url":"https://api.github.com/repos/release-engineering/kobo/issues/comments{/number}","contents_url":"https://api.github.com/repos/release-engineering/kobo/contents/{+path}","compare_url":"https://api.github.com/repos/release-engineering/kobo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/release-engineering/kobo/merges","archive_url":"https://api.github.com/repos/release-engineering/kobo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/release-engineering/kobo/downloads","issues_url":"https://api.github.com/repos/release-engineering/kobo/issues{/number}","pulls_url":"https://api.github.com/repos/release-engineering/kobo/pulls{/number}","milestones_url":"https://api.github.com/repos/release-engineering/kobo/milestones{/number}","notifications_url":"https://api.github.com/repos/release-engineering/kobo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/release-engineering/kobo/labels{/name}","releases_url":"https://api.github.com/repos/release-engineering/kobo/releases{/id}","deployments_url":"https://api.github.com/repos/release-engineering/kobo/deployments","created_at":"2016-02-22T09:45:26Z","updated_at":"2016-10-27T07:58:54Z","pushed_at":"2017-09-05T00:45:10Z","git_url":"git://github.com/release-engineering/kobo.git","ssh_url":"git@github.com:release-engineering/kobo.git","clone_url":"https://github.com/release-engineering/kobo.git","svn_url":"https://github.com/release-engineering/kobo","homepage":null,"size":443,"stargazers_count":3,"watchers_count":3,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"open_issues_count":11,"forks":11,"open_issues":11,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/48"},"html":{"href":"https://github.com/release-engineering/kobo/pull/48"},"issue":{"href":"https://api.github.com/repos/release-engineering/kobo/issues/48"},"comments":{"href":"https://api.github.com/repos/release-engineering/kobo/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/release-engineering/kobo/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/release-engineering/kobo/statuses/4dbc4babb3e7030f043e1eeb839569e2ed333853"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tkdchen"}}