{"action":"created","issue":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6517","repository_url":"https://api.github.com/repos/ArduPilot/ardupilot","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6517/labels{/name}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6517/comments","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6517/events","html_url":"https://github.com/ArduPilot/ardupilot/pull/6517","id":239592236,"number":6517,"title":"Revert \"waf: ensure that we can link to a package before using it\"","user":{"login":"lucasdemarchi","id":31864,"avatar_url":"https://avatars3.githubusercontent.com/u/31864?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasdemarchi","html_url":"https://github.com/lucasdemarchi","followers_url":"https://api.github.com/users/lucasdemarchi/followers","following_url":"https://api.github.com/users/lucasdemarchi/following{/other_user}","gists_url":"https://api.github.com/users/lucasdemarchi/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasdemarchi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasdemarchi/subscriptions","organizations_url":"https://api.github.com/users/lucasdemarchi/orgs","repos_url":"https://api.github.com/users/lucasdemarchi/repos","events_url":"https://api.github.com/users/lucasdemarchi/events{/privacy}","received_events_url":"https://api.github.com/users/lucasdemarchi/received_events","type":"User","site_admin":false},"labels":[{"id":305298438,"url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/BuildSystem","name":"BuildSystem","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2017-06-29T19:51:14Z","updated_at":"2017-07-27T10:57:40Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/6517","html_url":"https://github.com/ArduPilot/ardupilot/pull/6517","diff_url":"https://github.com/ArduPilot/ardupilot/pull/6517.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/6517.patch"},"body":"This reverts commit 6747f42986f4110a2e279fe72dd3126a4e278634.\r\n\r\nThis broke the link to external libraries since it won't define the\r\nHAVE_* variable anymore. When we call the check method from pkg-config\r\nit defines this variable for us, but it's reverted by the call to\r\ncfg.env.revert().  We could define it again, but the whole check\r\ndefeats the purpose of relying on the pkg-config module from waf. If the\r\nmodule is not sufficient, it should be fixed in the proper place.\r\n\r\nThis however points a deficiency on our infra: we don't have support for\r\nthe user to point to a sysroot. This would make it much easier to\r\ncross-compile the packages and not have issues regarding wrong\r\nlibraries.  For now only the revert is done.\r\n\r\nThanks to Miguel Arroyo for help debugging it."},"comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments/318329642","html_url":"https://github.com/ArduPilot/ardupilot/pull/6517#issuecomment-318329642","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/6517","id":318329642,"user":{"login":"OXINARF","id":1778527,"avatar_url":"https://avatars2.githubusercontent.com/u/1778527?v=4","gravatar_id":"","url":"https://api.github.com/users/OXINARF","html_url":"https://github.com/OXINARF","followers_url":"https://api.github.com/users/OXINARF/followers","following_url":"https://api.github.com/users/OXINARF/following{/other_user}","gists_url":"https://api.github.com/users/OXINARF/gists{/gist_id}","starred_url":"https://api.github.com/users/OXINARF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OXINARF/subscriptions","organizations_url":"https://api.github.com/users/OXINARF/orgs","repos_url":"https://api.github.com/users/OXINARF/repos","events_url":"https://api.github.com/users/OXINARF/events{/privacy}","received_events_url":"https://api.github.com/users/OXINARF/received_events","type":"User","site_admin":false},"created_at":"2017-07-27T10:57:40Z","updated_at":"2017-07-27T10:57:40Z","body":"> On our repository I see it being set only on build_autotest.sh, but this is after actually building it so it has no effect.\r\n\r\nWhat do you mean it is _after actually building_? Export happens in line 137, build at line 142..."}}
{"actor":{"display_login":"OXINARF"}}