{"action":"created","comment":{"url":"https://api.github.com/repos/istio/mixer/pulls/comments/104814584","pull_request_review_id":25666764,"id":104814584,"diff_hunk":"@@ -30,7 +30,17 @@ rules:\n   - kind: access-logs\n     params:\n       logName: \"access_log\"\n-      logFormat: 0 # Common Log Format\n+      log:\n+        log_format: 1 # apache common log format\n+        template_expressions:","path":"testdata/serviceconfig.yml","position":7,"original_position":7,"commit_id":"30279e1a7a032c9d60437225afd7f7d4a7a53142","original_commit_id":"7fd7ae2882f792ac783e91173ba82a2e2d342ec2","user":{"login":"douglas-reid","id":21148125,"avatar_url":"https://avatars0.githubusercontent.com/u/21148125?v=3","gravatar_id":"","url":"https://api.github.com/users/douglas-reid","html_url":"https://github.com/douglas-reid","followers_url":"https://api.github.com/users/douglas-reid/followers","following_url":"https://api.github.com/users/douglas-reid/following{/other_user}","gists_url":"https://api.github.com/users/douglas-reid/gists{/gist_id}","starred_url":"https://api.github.com/users/douglas-reid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/douglas-reid/subscriptions","organizations_url":"https://api.github.com/users/douglas-reid/orgs","repos_url":"https://api.github.com/users/douglas-reid/repos","events_url":"https://api.github.com/users/douglas-reid/events{/privacy}","received_events_url":"https://api.github.com/users/douglas-reid/received_events","type":"User","site_admin":false},"body":"Can we add a (duplicate) set of labels here to match the template_exprs (for completeness sake)?","created_at":"2017-03-08T00:12:36Z","updated_at":"2017-03-08T00:12:52Z","html_url":"https://github.com/istio/mixer/pull/294#discussion_r104814584","pull_request_url":"https://api.github.com/repos/istio/mixer/pulls/294","_links":{"self":{"href":"https://api.github.com/repos/istio/mixer/pulls/comments/104814584"},"html":{"href":"https://github.com/istio/mixer/pull/294#discussion_r104814584"},"pull_request":{"href":"https://api.github.com/repos/istio/mixer/pulls/294"}}},"pull_request":{"url":"https://api.github.com/repos/istio/mixer/pulls/294","id":108424889,"html_url":"https://github.com/istio/mixer/pull/294","diff_url":"https://github.com/istio/mixer/pull/294.diff","patch_url":"https://github.com/istio/mixer/pull/294.patch","issue_url":"https://api.github.com/repos/istio/mixer/issues/294","number":294,"state":"open","locked":false,"title":"Update the AccessLogManager","user":{"login":"ZackButcher","id":1923135,"avatar_url":"https://avatars1.githubusercontent.com/u/1923135?v=3","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},"body":"Update the access log manager to look more like the metric and quota managers. Unlink log templates from attribute names, deferring to a mapping instead. A follow-on PR will introduce using descriptors for both application and access logs at the same time.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/istio/mixer/294)\n<!-- Reviewable:end -->\n","created_at":"2017-02-28T22:22:48Z","updated_at":"2017-03-08T00:12:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55a8aa722628cb992934e13be2aea1fc41e75c43","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/istio/mixer/pulls/294/commits","review_comments_url":"https://api.github.com/repos/istio/mixer/pulls/294/comments","review_comment_url":"https://api.github.com/repos/istio/mixer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/mixer/issues/294/comments","statuses_url":"https://api.github.com/repos/istio/mixer/statuses/30279e1a7a032c9d60437225afd7f7d4a7a53142","head":{"label":"ZackButcher:applogs","ref":"applogs","sha":"30279e1a7a032c9d60437225afd7f7d4a7a53142","user":{"login":"ZackButcher","id":1923135,"avatar_url":"https://avatars1.githubusercontent.com/u/1923135?v=3","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},"repo":{"id":75560156,"name":"mixer","full_name":"ZackButcher/mixer","owner":{"login":"ZackButcher","id":1923135,"avatar_url":"https://avatars1.githubusercontent.com/u/1923135?v=3","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZackButcher/mixer","description":"The Istio mixer and its adapters.","fork":true,"url":"https://api.github.com/repos/ZackButcher/mixer","forks_url":"https://api.github.com/repos/ZackButcher/mixer/forks","keys_url":"https://api.github.com/repos/ZackButcher/mixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZackButcher/mixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZackButcher/mixer/teams","hooks_url":"https://api.github.com/repos/ZackButcher/mixer/hooks","issue_events_url":"https://api.github.com/repos/ZackButcher/mixer/issues/events{/number}","events_url":"https://api.github.com/repos/ZackButcher/mixer/events","assignees_url":"https://api.github.com/repos/ZackButcher/mixer/assignees{/user}","branches_url":"https://api.github.com/repos/ZackButcher/mixer/branches{/branch}","tags_url":"https://api.github.com/repos/ZackButcher/mixer/tags","blobs_url":"https://api.github.com/repos/ZackButcher/mixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZackButcher/mixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZackButcher/mixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZackButcher/mixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZackButcher/mixer/statuses/{sha}","languages_url":"https://api.github.com/repos/ZackButcher/mixer/languages","stargazers_url":"https://api.github.com/repos/ZackButcher/mixer/stargazers","contributors_url":"https://api.github.com/repos/ZackButcher/mixer/contributors","subscribers_url":"https://api.github.com/repos/ZackButcher/mixer/subscribers","subscription_url":"https://api.github.com/repos/ZackButcher/mixer/subscription","commits_url":"https://api.github.com/repos/ZackButcher/mixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZackButcher/mixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZackButcher/mixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZackButcher/mixer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZackButcher/mixer/contents/{+path}","compare_url":"https://api.github.com/repos/ZackButcher/mixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZackButcher/mixer/merges","archive_url":"https://api.github.com/repos/ZackButcher/mixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZackButcher/mixer/downloads","issues_url":"https://api.github.com/repos/ZackButcher/mixer/issues{/number}","pulls_url":"https://api.github.com/repos/ZackButcher/mixer/pulls{/number}","milestones_url":"https://api.github.com/repos/ZackButcher/mixer/milestones{/number}","notifications_url":"https://api.github.com/repos/ZackButcher/mixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZackButcher/mixer/labels{/name}","releases_url":"https://api.github.com/repos/ZackButcher/mixer/releases{/id}","deployments_url":"https://api.github.com/repos/ZackButcher/mixer/deployments","created_at":"2016-12-04T19:47:02Z","updated_at":"2016-12-04T19:47:03Z","pushed_at":"2017-03-07T23:05:00Z","git_url":"git://github.com/ZackButcher/mixer.git","ssh_url":"git@github.com:ZackButcher/mixer.git","clone_url":"https://github.com/ZackButcher/mixer.git","svn_url":"https://github.com/ZackButcher/mixer","homepage":null,"size":12792,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"b486c5db085aac367f627e63187fe90938bbb9e7","user":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74177509,"name":"mixer","full_name":"istio/mixer","owner":{"login":"istio","id":23534644,"avatar_url":"https://avatars2.githubusercontent.com/u/23534644?v=3","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/mixer","description":"The Istio mixer and its adapters","fork":false,"url":"https://api.github.com/repos/istio/mixer","forks_url":"https://api.github.com/repos/istio/mixer/forks","keys_url":"https://api.github.com/repos/istio/mixer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/mixer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/mixer/teams","hooks_url":"https://api.github.com/repos/istio/mixer/hooks","issue_events_url":"https://api.github.com/repos/istio/mixer/issues/events{/number}","events_url":"https://api.github.com/repos/istio/mixer/events","assignees_url":"https://api.github.com/repos/istio/mixer/assignees{/user}","branches_url":"https://api.github.com/repos/istio/mixer/branches{/branch}","tags_url":"https://api.github.com/repos/istio/mixer/tags","blobs_url":"https://api.github.com/repos/istio/mixer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/mixer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/mixer/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/mixer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/mixer/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/mixer/languages","stargazers_url":"https://api.github.com/repos/istio/mixer/stargazers","contributors_url":"https://api.github.com/repos/istio/mixer/contributors","subscribers_url":"https://api.github.com/repos/istio/mixer/subscribers","subscription_url":"https://api.github.com/repos/istio/mixer/subscription","commits_url":"https://api.github.com/repos/istio/mixer/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/mixer/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/mixer/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/mixer/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/mixer/contents/{+path}","compare_url":"https://api.github.com/repos/istio/mixer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/mixer/merges","archive_url":"https://api.github.com/repos/istio/mixer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/mixer/downloads","issues_url":"https://api.github.com/repos/istio/mixer/issues{/number}","pulls_url":"https://api.github.com/repos/istio/mixer/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/mixer/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/mixer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/mixer/labels{/name}","releases_url":"https://api.github.com/repos/istio/mixer/releases{/id}","deployments_url":"https://api.github.com/repos/istio/mixer/deployments","created_at":"2016-11-19T00:40:17Z","updated_at":"2017-03-01T19:20:56Z","pushed_at":"2017-03-07T23:11:50Z","git_url":"git://github.com/istio/mixer.git","ssh_url":"git@github.com:istio/mixer.git","clone_url":"https://github.com/istio/mixer.git","svn_url":"https://github.com/istio/mixer","homepage":"","size":13257,"stargazers_count":14,"watchers_count":14,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"open_issues_count":46,"forks":18,"open_issues":46,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/mixer/pulls/294"},"html":{"href":"https://github.com/istio/mixer/pull/294"},"issue":{"href":"https://api.github.com/repos/istio/mixer/issues/294"},"comments":{"href":"https://api.github.com/repos/istio/mixer/issues/294/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/mixer/pulls/294/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/mixer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/mixer/pulls/294/commits"},"statuses":{"href":"https://api.github.com/repos/istio/mixer/statuses/30279e1a7a032c9d60437225afd7f7d4a7a53142"}}}}
{"actor":{"display_login":"douglas-reid"}}