{"action":"created","comment":{"url":"https://api.github.com/repos/slide-rs/specs/pulls/comments/121772958","pull_request_review_id":43828334,"id":121772958,"diff_hunk":"@@ -451,3 +451,25 @@ fn par_join_many_entities_and_systems() {\n                n);\n     }\n }\n+\n+fn par_join_check_storage() {\n+    use rayon::iter::ParallelIterator;\n+\n+    struct Sys;\n+\n+    let mut world = create_world();\n+\n+    impl<'a> System<'a> for Sys {\n+        type SystemData = (WriteStorage<'a, CompInt>);\n+\n+        fn run(&mut self, data: Self::SystemData) {\n+            let mut ints = data;\n+            (ints.check())\n+                .par_join()\n+                .for_each(|c_i| ints.get_mut_unchecked(&mut c_i).0 += 1);","path":"tests/tests.rs","position":19,"original_position":19,"commit_id":"2e546df4fece15e9f11b5b1b5299b234200db51d","original_commit_id":"2e546df4fece15e9f11b5b1b5299b234200db51d","user":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars2.githubusercontent.com/u/23152057?v=3","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"body":"There seems to be some lifetime issue going on here, I'll try to track it down later.","created_at":"2017-06-13T19:21:33Z","updated_at":"2017-06-13T19:21:33Z","html_url":"https://github.com/slide-rs/specs/pull/191#discussion_r121772958","pull_request_url":"https://api.github.com/repos/slide-rs/specs/pulls/191","_links":{"self":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/comments/121772958"},"html":{"href":"https://github.com/slide-rs/specs/pull/191#discussion_r121772958"},"pull_request":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/191"}}},"pull_request":{"url":"https://api.github.com/repos/slide-rs/specs/pulls/191","id":125110823,"html_url":"https://github.com/slide-rs/specs/pull/191","diff_url":"https://github.com/slide-rs/specs/pull/191.diff","patch_url":"https://github.com/slide-rs/specs/pull/191.patch","issue_url":"https://api.github.com/repos/slide-rs/specs/issues/191","number":191,"state":"open","locked":false,"title":"Missing Send / Sync and ParJoin for CheckStorage","user":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars2.githubusercontent.com/u/23152057?v=3","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"body":"@WaDelma Sorry for the inconvenience!\r\n\r\nFixes #190 ","created_at":"2017-06-12T11:04:29Z","updated_at":"2017-06-13T19:21:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1308748ec6d7d9aa70fb3d3d1210ba54791734a4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/slide-rs/specs/pulls/191/commits","review_comments_url":"https://api.github.com/repos/slide-rs/specs/pulls/191/comments","review_comment_url":"https://api.github.com/repos/slide-rs/specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/slide-rs/specs/issues/191/comments","statuses_url":"https://api.github.com/repos/slide-rs/specs/statuses/2e546df4fece15e9f11b5b1b5299b234200db51d","head":{"label":"torkleyy:sendsync","ref":"sendsync","sha":"2e546df4fece15e9f11b5b1b5299b234200db51d","user":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars2.githubusercontent.com/u/23152057?v=3","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"repo":{"id":84238344,"name":"specs","full_name":"torkleyy/specs","owner":{"login":"torkleyy","id":23152057,"avatar_url":"https://avatars2.githubusercontent.com/u/23152057?v=3","gravatar_id":"","url":"https://api.github.com/users/torkleyy","html_url":"https://github.com/torkleyy","followers_url":"https://api.github.com/users/torkleyy/followers","following_url":"https://api.github.com/users/torkleyy/following{/other_user}","gists_url":"https://api.github.com/users/torkleyy/gists{/gist_id}","starred_url":"https://api.github.com/users/torkleyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkleyy/subscriptions","organizations_url":"https://api.github.com/users/torkleyy/orgs","repos_url":"https://api.github.com/users/torkleyy/repos","events_url":"https://api.github.com/users/torkleyy/events{/privacy}","received_events_url":"https://api.github.com/users/torkleyy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/torkleyy/specs","description":"Specs - Parallel ECS","fork":true,"url":"https://api.github.com/repos/torkleyy/specs","forks_url":"https://api.github.com/repos/torkleyy/specs/forks","keys_url":"https://api.github.com/repos/torkleyy/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/torkleyy/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/torkleyy/specs/teams","hooks_url":"https://api.github.com/repos/torkleyy/specs/hooks","issue_events_url":"https://api.github.com/repos/torkleyy/specs/issues/events{/number}","events_url":"https://api.github.com/repos/torkleyy/specs/events","assignees_url":"https://api.github.com/repos/torkleyy/specs/assignees{/user}","branches_url":"https://api.github.com/repos/torkleyy/specs/branches{/branch}","tags_url":"https://api.github.com/repos/torkleyy/specs/tags","blobs_url":"https://api.github.com/repos/torkleyy/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/torkleyy/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/torkleyy/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/torkleyy/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/torkleyy/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/torkleyy/specs/languages","stargazers_url":"https://api.github.com/repos/torkleyy/specs/stargazers","contributors_url":"https://api.github.com/repos/torkleyy/specs/contributors","subscribers_url":"https://api.github.com/repos/torkleyy/specs/subscribers","subscription_url":"https://api.github.com/repos/torkleyy/specs/subscription","commits_url":"https://api.github.com/repos/torkleyy/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/torkleyy/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/torkleyy/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/torkleyy/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/torkleyy/specs/contents/{+path}","compare_url":"https://api.github.com/repos/torkleyy/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/torkleyy/specs/merges","archive_url":"https://api.github.com/repos/torkleyy/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/torkleyy/specs/downloads","issues_url":"https://api.github.com/repos/torkleyy/specs/issues{/number}","pulls_url":"https://api.github.com/repos/torkleyy/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/torkleyy/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/torkleyy/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/torkleyy/specs/labels{/name}","releases_url":"https://api.github.com/repos/torkleyy/specs/releases{/id}","deployments_url":"https://api.github.com/repos/torkleyy/specs/deployments","created_at":"2017-03-07T19:35:07Z","updated_at":"2017-03-07T19:35:08Z","pushed_at":"2017-06-13T19:20:44Z","git_url":"git://github.com/torkleyy/specs.git","ssh_url":"git@github.com:torkleyy/specs.git","clone_url":"https://github.com/torkleyy/specs.git","svn_url":"https://github.com/torkleyy/specs","homepage":"https://slide-rs.github.io/specs/","size":3857,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"slide-rs:master","ref":"master","sha":"ca14bd028ba7205af7c4670674e8df56d62f5745","user":{"login":"slide-rs","id":12649318,"avatar_url":"https://avatars0.githubusercontent.com/u/12649318?v=3","gravatar_id":"","url":"https://api.github.com/users/slide-rs","html_url":"https://github.com/slide-rs","followers_url":"https://api.github.com/users/slide-rs/followers","following_url":"https://api.github.com/users/slide-rs/following{/other_user}","gists_url":"https://api.github.com/users/slide-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/slide-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slide-rs/subscriptions","organizations_url":"https://api.github.com/users/slide-rs/orgs","repos_url":"https://api.github.com/users/slide-rs/repos","events_url":"https://api.github.com/users/slide-rs/events{/privacy}","received_events_url":"https://api.github.com/users/slide-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":55565443,"name":"specs","full_name":"slide-rs/specs","owner":{"login":"slide-rs","id":12649318,"avatar_url":"https://avatars0.githubusercontent.com/u/12649318?v=3","gravatar_id":"","url":"https://api.github.com/users/slide-rs","html_url":"https://github.com/slide-rs","followers_url":"https://api.github.com/users/slide-rs/followers","following_url":"https://api.github.com/users/slide-rs/following{/other_user}","gists_url":"https://api.github.com/users/slide-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/slide-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slide-rs/subscriptions","organizations_url":"https://api.github.com/users/slide-rs/orgs","repos_url":"https://api.github.com/users/slide-rs/repos","events_url":"https://api.github.com/users/slide-rs/events{/privacy}","received_events_url":"https://api.github.com/users/slide-rs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/slide-rs/specs","description":"Specs - Parallel ECS","fork":false,"url":"https://api.github.com/repos/slide-rs/specs","forks_url":"https://api.github.com/repos/slide-rs/specs/forks","keys_url":"https://api.github.com/repos/slide-rs/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/slide-rs/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/slide-rs/specs/teams","hooks_url":"https://api.github.com/repos/slide-rs/specs/hooks","issue_events_url":"https://api.github.com/repos/slide-rs/specs/issues/events{/number}","events_url":"https://api.github.com/repos/slide-rs/specs/events","assignees_url":"https://api.github.com/repos/slide-rs/specs/assignees{/user}","branches_url":"https://api.github.com/repos/slide-rs/specs/branches{/branch}","tags_url":"https://api.github.com/repos/slide-rs/specs/tags","blobs_url":"https://api.github.com/repos/slide-rs/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/slide-rs/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/slide-rs/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/slide-rs/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/slide-rs/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/slide-rs/specs/languages","stargazers_url":"https://api.github.com/repos/slide-rs/specs/stargazers","contributors_url":"https://api.github.com/repos/slide-rs/specs/contributors","subscribers_url":"https://api.github.com/repos/slide-rs/specs/subscribers","subscription_url":"https://api.github.com/repos/slide-rs/specs/subscription","commits_url":"https://api.github.com/repos/slide-rs/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/slide-rs/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/slide-rs/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/slide-rs/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/slide-rs/specs/contents/{+path}","compare_url":"https://api.github.com/repos/slide-rs/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/slide-rs/specs/merges","archive_url":"https://api.github.com/repos/slide-rs/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/slide-rs/specs/downloads","issues_url":"https://api.github.com/repos/slide-rs/specs/issues{/number}","pulls_url":"https://api.github.com/repos/slide-rs/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/slide-rs/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/slide-rs/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/slide-rs/specs/labels{/name}","releases_url":"https://api.github.com/repos/slide-rs/specs/releases{/id}","deployments_url":"https://api.github.com/repos/slide-rs/specs/deployments","created_at":"2016-04-06T01:06:31Z","updated_at":"2017-06-13T10:38:09Z","pushed_at":"2017-06-13T19:20:45Z","git_url":"git://github.com/slide-rs/specs.git","ssh_url":"git@github.com:slide-rs/specs.git","clone_url":"https://github.com/slide-rs/specs.git","svn_url":"https://github.com/slide-rs/specs","homepage":"https://slide-rs.github.io/specs-website/","size":6519,"stargazers_count":308,"watchers_count":308,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"open_issues_count":14,"forks":30,"open_issues":14,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/191"},"html":{"href":"https://github.com/slide-rs/specs/pull/191"},"issue":{"href":"https://api.github.com/repos/slide-rs/specs/issues/191"},"comments":{"href":"https://api.github.com/repos/slide-rs/specs/issues/191/comments"},"review_comments":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/191/comments"},"review_comment":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/slide-rs/specs/pulls/191/commits"},"statuses":{"href":"https://api.github.com/repos/slide-rs/specs/statuses/2e546df4fece15e9f11b5b1b5299b234200db51d"}}}}
{"actor":{"display_login":"torkleyy"}}