{"action":"opened","number":4928,"pull_request":{"url":"https://api.github.com/repos/mpv-player/mpv/pulls/4928","id":143404657,"html_url":"https://github.com/mpv-player/mpv/pull/4928","diff_url":"https://github.com/mpv-player/mpv/pull/4928.diff","patch_url":"https://github.com/mpv-player/mpv/pull/4928.patch","issue_url":"https://api.github.com/repos/mpv-player/mpv/issues/4928","number":4928,"state":"open","locked":false,"title":"Add support for Vulkan on Windows","user":{"login":"rossy","id":162837,"avatar_url":"https://avatars3.githubusercontent.com/u/162837?v=4","gravatar_id":"","url":"https://api.github.com/users/rossy","html_url":"https://github.com/rossy","followers_url":"https://api.github.com/users/rossy/followers","following_url":"https://api.github.com/users/rossy/following{/other_user}","gists_url":"https://api.github.com/users/rossy/gists{/gist_id}","starred_url":"https://api.github.com/users/rossy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossy/subscriptions","organizations_url":"https://api.github.com/users/rossy/orgs","repos_url":"https://api.github.com/users/rossy/repos","events_url":"https://api.github.com/users/rossy/events{/privacy}","received_events_url":"https://api.github.com/users/rossy/received_events","type":"User","site_admin":false},"body":"This has been tested and seems to work.\r\n\r\nOne problem is that mpv spams messages like this on resize:\r\n```\r\n[vo/gpu/vulkan] Requested width 1392 does not match current width 1395\r\n[vo/gpu/vulkan] Requested height 783 does not match current height 784\r\n[vo/gpu/vulkan] Requested width 1419 does not match current width 1423\r\n[vo/gpu/vulkan] Requested height 798 does not match current height 800\r\n```\r\n\r\nI think this is because resizing on Windows happens asynchronously from the perspective of the vo thread. Resizing still works though.","created_at":"2017-09-27T14:15:09Z","updated_at":"2017-09-27T14:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d04037aa7cf9d85999712b925f04b90177f2c6f9","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/mpv-player/mpv/pulls/4928/commits","review_comments_url":"https://api.github.com/repos/mpv-player/mpv/pulls/4928/comments","review_comment_url":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mpv-player/mpv/issues/4928/comments","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/833a4c5ebd3f1322157353361a36fb467fe0bc08","head":{"label":"rossy:vulkan-win","ref":"vulkan-win","sha":"833a4c5ebd3f1322157353361a36fb467fe0bc08","user":{"login":"rossy","id":162837,"avatar_url":"https://avatars3.githubusercontent.com/u/162837?v=4","gravatar_id":"","url":"https://api.github.com/users/rossy","html_url":"https://github.com/rossy","followers_url":"https://api.github.com/users/rossy/followers","following_url":"https://api.github.com/users/rossy/following{/other_user}","gists_url":"https://api.github.com/users/rossy/gists{/gist_id}","starred_url":"https://api.github.com/users/rossy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossy/subscriptions","organizations_url":"https://api.github.com/users/rossy/orgs","repos_url":"https://api.github.com/users/rossy/repos","events_url":"https://api.github.com/users/rossy/events{/privacy}","received_events_url":"https://api.github.com/users/rossy/received_events","type":"User","site_admin":false},"repo":{"id":10967623,"name":"mpv","full_name":"rossy/mpv","owner":{"login":"rossy","id":162837,"avatar_url":"https://avatars3.githubusercontent.com/u/162837?v=4","gravatar_id":"","url":"https://api.github.com/users/rossy","html_url":"https://github.com/rossy","followers_url":"https://api.github.com/users/rossy/followers","following_url":"https://api.github.com/users/rossy/following{/other_user}","gists_url":"https://api.github.com/users/rossy/gists{/gist_id}","starred_url":"https://api.github.com/users/rossy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rossy/subscriptions","organizations_url":"https://api.github.com/users/rossy/orgs","repos_url":"https://api.github.com/users/rossy/repos","events_url":"https://api.github.com/users/rossy/events{/privacy}","received_events_url":"https://api.github.com/users/rossy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rossy/mpv","description":"Video player based on MPlayer/mplayer2","fork":true,"url":"https://api.github.com/repos/rossy/mpv","forks_url":"https://api.github.com/repos/rossy/mpv/forks","keys_url":"https://api.github.com/repos/rossy/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rossy/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rossy/mpv/teams","hooks_url":"https://api.github.com/repos/rossy/mpv/hooks","issue_events_url":"https://api.github.com/repos/rossy/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/rossy/mpv/events","assignees_url":"https://api.github.com/repos/rossy/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/rossy/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/rossy/mpv/tags","blobs_url":"https://api.github.com/repos/rossy/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rossy/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rossy/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/rossy/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rossy/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/rossy/mpv/languages","stargazers_url":"https://api.github.com/repos/rossy/mpv/stargazers","contributors_url":"https://api.github.com/repos/rossy/mpv/contributors","subscribers_url":"https://api.github.com/repos/rossy/mpv/subscribers","subscription_url":"https://api.github.com/repos/rossy/mpv/subscription","commits_url":"https://api.github.com/repos/rossy/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/rossy/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/rossy/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/rossy/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/rossy/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/rossy/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rossy/mpv/merges","archive_url":"https://api.github.com/repos/rossy/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rossy/mpv/downloads","issues_url":"https://api.github.com/repos/rossy/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/rossy/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/rossy/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/rossy/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rossy/mpv/labels{/name}","releases_url":"https://api.github.com/repos/rossy/mpv/releases{/id}","deployments_url":"https://api.github.com/repos/rossy/mpv/deployments","created_at":"2013-06-26T12:46:06Z","updated_at":"2015-04-24T16:15:38Z","pushed_at":"2017-09-27T14:10:35Z","git_url":"git://github.com/rossy/mpv.git","ssh_url":"git@github.com:rossy/mpv.git","clone_url":"https://github.com/rossy/mpv.git","svn_url":"https://github.com/rossy/mpv","homepage":"http://mpv.io","size":83299,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mpv-player:master","ref":"master","sha":"868bf4da7dd841611fb87455194f80e963a1573e","user":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars0.githubusercontent.com/u/2550273?v=4","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"repo":{"id":6201092,"name":"mpv","full_name":"mpv-player/mpv","owner":{"login":"mpv-player","id":2550273,"avatar_url":"https://avatars0.githubusercontent.com/u/2550273?v=4","gravatar_id":"","url":"https://api.github.com/users/mpv-player","html_url":"https://github.com/mpv-player","followers_url":"https://api.github.com/users/mpv-player/followers","following_url":"https://api.github.com/users/mpv-player/following{/other_user}","gists_url":"https://api.github.com/users/mpv-player/gists{/gist_id}","starred_url":"https://api.github.com/users/mpv-player/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpv-player/subscriptions","organizations_url":"https://api.github.com/users/mpv-player/orgs","repos_url":"https://api.github.com/users/mpv-player/repos","events_url":"https://api.github.com/users/mpv-player/events{/privacy}","received_events_url":"https://api.github.com/users/mpv-player/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mpv-player/mpv","description":"🎥 Video player based on MPlayer/mplayer2","fork":false,"url":"https://api.github.com/repos/mpv-player/mpv","forks_url":"https://api.github.com/repos/mpv-player/mpv/forks","keys_url":"https://api.github.com/repos/mpv-player/mpv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mpv-player/mpv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mpv-player/mpv/teams","hooks_url":"https://api.github.com/repos/mpv-player/mpv/hooks","issue_events_url":"https://api.github.com/repos/mpv-player/mpv/issues/events{/number}","events_url":"https://api.github.com/repos/mpv-player/mpv/events","assignees_url":"https://api.github.com/repos/mpv-player/mpv/assignees{/user}","branches_url":"https://api.github.com/repos/mpv-player/mpv/branches{/branch}","tags_url":"https://api.github.com/repos/mpv-player/mpv/tags","blobs_url":"https://api.github.com/repos/mpv-player/mpv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mpv-player/mpv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mpv-player/mpv/git/refs{/sha}","trees_url":"https://api.github.com/repos/mpv-player/mpv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mpv-player/mpv/statuses/{sha}","languages_url":"https://api.github.com/repos/mpv-player/mpv/languages","stargazers_url":"https://api.github.com/repos/mpv-player/mpv/stargazers","contributors_url":"https://api.github.com/repos/mpv-player/mpv/contributors","subscribers_url":"https://api.github.com/repos/mpv-player/mpv/subscribers","subscription_url":"https://api.github.com/repos/mpv-player/mpv/subscription","commits_url":"https://api.github.com/repos/mpv-player/mpv/commits{/sha}","git_commits_url":"https://api.github.com/repos/mpv-player/mpv/git/commits{/sha}","comments_url":"https://api.github.com/repos/mpv-player/mpv/comments{/number}","issue_comment_url":"https://api.github.com/repos/mpv-player/mpv/issues/comments{/number}","contents_url":"https://api.github.com/repos/mpv-player/mpv/contents/{+path}","compare_url":"https://api.github.com/repos/mpv-player/mpv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mpv-player/mpv/merges","archive_url":"https://api.github.com/repos/mpv-player/mpv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mpv-player/mpv/downloads","issues_url":"https://api.github.com/repos/mpv-player/mpv/issues{/number}","pulls_url":"https://api.github.com/repos/mpv-player/mpv/pulls{/number}","milestones_url":"https://api.github.com/repos/mpv-player/mpv/milestones{/number}","notifications_url":"https://api.github.com/repos/mpv-player/mpv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mpv-player/mpv/labels{/name}","releases_url":"https://api.github.com/repos/mpv-player/mpv/releases{/id}","deployments_url":"https://api.github.com/repos/mpv-player/mpv/deployments","created_at":"2012-10-13T08:08:44Z","updated_at":"2017-09-27T09:37:50Z","pushed_at":"2017-09-27T14:15:10Z","git_url":"git://github.com/mpv-player/mpv.git","ssh_url":"git@github.com:mpv-player/mpv.git","clone_url":"https://github.com/mpv-player/mpv.git","svn_url":"https://github.com/mpv-player/mpv","homepage":"https://mpv.io","size":85275,"stargazers_count":6321,"watchers_count":6321,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":824,"mirror_url":null,"open_issues_count":392,"forks":824,"open_issues":392,"watchers":6321,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/4928"},"html":{"href":"https://github.com/mpv-player/mpv/pull/4928"},"issue":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/4928"},"comments":{"href":"https://api.github.com/repos/mpv-player/mpv/issues/4928/comments"},"review_comments":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/4928/comments"},"review_comment":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mpv-player/mpv/pulls/4928/commits"},"statuses":{"href":"https://api.github.com/repos/mpv-player/mpv/statuses/833a4c5ebd3f1322157353361a36fb467fe0bc08"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":113,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"rossy"}}