{"action":"created","issue":{"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/110","repository_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs","labels_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/110/labels{/name}","comments_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/110/comments","events_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/110/events","html_url":"https://github.com/stratis-storage/devicemapper-rs/pull/110","id":245760895,"number":110,"title":"Refine new() and setup() methods","user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"labels":[{"id":570452650,"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/labels/review-final","name":"review-final","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2017-07-26T15:26:36Z","updated_at":"2017-08-16T18:01:05Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/pulls/110","html_url":"https://github.com/stratis-storage/devicemapper-rs/pull/110","diff_url":"https://github.com/stratis-storage/devicemapper-rs/pull/110.diff","patch_url":"https://github.com/stratis-storage/devicemapper-rs/pull/110.patch"},"body":"This PR includes a bunch of changes.\r\n\r\n* When making a new device still known to the kernel, it verifies that the given information matches the information known to the kernel.\r\n* It removes the redundant size parameter from ```ThinPoolDev::new()``` and ```setup()```\r\n* It makes running ```thin_check``` in ```ThinPoolDev::setup()``` conditional on the device being unknown to the kernel.\r\n* It changes the return type of ```DM::parse_table_status()``` since the method prefers to panic in all cases where it might otherwise return an error.\r\n* It trims trailing white space off the last entry in each line of the table returned by ```DM::parse_table_status()```.\r\n* It add several tests to thinpooldev.rs.\r\n* It does other small adjustements and fixes.\r\n\r\nIt addresses #120 but can not be certainly said to fix it, due to the uncertainty of what it means to be \"in use\".\r\n"},"comment":{"url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/comments/322851588","html_url":"https://github.com/stratis-storage/devicemapper-rs/pull/110#issuecomment-322851588","issue_url":"https://api.github.com/repos/stratis-storage/devicemapper-rs/issues/110","id":322851588,"user":{"login":"mulkieran","id":1218366,"avatar_url":"https://avatars0.githubusercontent.com/u/1218366?v=4","gravatar_id":"","url":"https://api.github.com/users/mulkieran","html_url":"https://github.com/mulkieran","followers_url":"https://api.github.com/users/mulkieran/followers","following_url":"https://api.github.com/users/mulkieran/following{/other_user}","gists_url":"https://api.github.com/users/mulkieran/gists{/gist_id}","starred_url":"https://api.github.com/users/mulkieran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulkieran/subscriptions","organizations_url":"https://api.github.com/users/mulkieran/orgs","repos_url":"https://api.github.com/users/mulkieran/repos","events_url":"https://api.github.com/users/mulkieran/events{/privacy}","received_events_url":"https://api.github.com/users/mulkieran/received_events","type":"User","site_admin":false},"created_at":"2017-08-16T18:01:05Z","updated_at":"2017-08-16T18:01:05Z","body":"@agrover review?"}}
{"actor":{"display_login":"mulkieran"}}