{"action":"opened","number":8597,"pull_request":{"url":"https://api.github.com/repos/elastic/logstash/pulls/8597","id":150939217,"html_url":"https://github.com/elastic/logstash/pull/8597","diff_url":"https://github.com/elastic/logstash/pull/8597.diff","patch_url":"https://github.com/elastic/logstash/pull/8597.patch","issue_url":"https://api.github.com/repos/elastic/logstash/issues/8597","number":8597,"state":"open","locked":false,"title":"LIR: merge hash attributes of same name to support legacy configurations","user":{"login":"yaauie","id":210924,"avatar_url":"https://avatars1.githubusercontent.com/u/210924?v=4","gravatar_id":"","url":"https://api.github.com/users/yaauie","html_url":"https://github.com/yaauie","followers_url":"https://api.github.com/users/yaauie/followers","following_url":"https://api.github.com/users/yaauie/following{/other_user}","gists_url":"https://api.github.com/users/yaauie/gists{/gist_id}","starred_url":"https://api.github.com/users/yaauie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaauie/subscriptions","organizations_url":"https://api.github.com/users/yaauie/orgs","repos_url":"https://api.github.com/users/yaauie/repos","events_url":"https://api.github.com/users/yaauie/events{/privacy}","received_events_url":"https://api.github.com/users/yaauie/received_events","type":"User","site_admin":false},"body":"A [build failure][] of the grok plugin when run through LIR/lscl indicates that\r\nthere is an expectation for multiple Attributes of the same name to be merged\r\ntogether.\r\n\r\nThis commit ports the failing spec in the plugin to an abstraction that can be\r\ntested within logstash-core, and adds a caveat to the LSCL LIR-builder to\r\nensure that we merge the hashes in a way that is compatible with legacy\r\nbehaviour.\r\n\r\nNOTE: when multiple Attributes of the same name are used in a single config,\r\nit's possible to create configurations that circumvent `AST::Hash`'s ability to\r\nreport duplicate keys.\r\n\r\n[build failure]: https://travis-ci.org/logstash-plugins/logstash-filter-grok/builds/293778268\r\n\r\nDiscovered while working on logstash-plugins/logstash-filter-grok#124","created_at":"2017-11-06T19:33:11Z","updated_at":"2017-11-06T19:33:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/logstash/pulls/8597/commits","review_comments_url":"https://api.github.com/repos/elastic/logstash/pulls/8597/comments","review_comment_url":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/logstash/issues/8597/comments","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/429b3e05bace87eb376df9e1656a742c6ea3b6a9","head":{"label":"yaauie:fix/lir-legacy-merge-hashes","ref":"fix/lir-legacy-merge-hashes","sha":"429b3e05bace87eb376df9e1656a742c6ea3b6a9","user":{"login":"yaauie","id":210924,"avatar_url":"https://avatars1.githubusercontent.com/u/210924?v=4","gravatar_id":"","url":"https://api.github.com/users/yaauie","html_url":"https://github.com/yaauie","followers_url":"https://api.github.com/users/yaauie/followers","following_url":"https://api.github.com/users/yaauie/following{/other_user}","gists_url":"https://api.github.com/users/yaauie/gists{/gist_id}","starred_url":"https://api.github.com/users/yaauie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaauie/subscriptions","organizations_url":"https://api.github.com/users/yaauie/orgs","repos_url":"https://api.github.com/users/yaauie/repos","events_url":"https://api.github.com/users/yaauie/events{/privacy}","received_events_url":"https://api.github.com/users/yaauie/received_events","type":"User","site_admin":false},"repo":{"id":108014349,"name":"logstash","full_name":"yaauie/logstash","owner":{"login":"yaauie","id":210924,"avatar_url":"https://avatars1.githubusercontent.com/u/210924?v=4","gravatar_id":"","url":"https://api.github.com/users/yaauie","html_url":"https://github.com/yaauie","followers_url":"https://api.github.com/users/yaauie/followers","following_url":"https://api.github.com/users/yaauie/following{/other_user}","gists_url":"https://api.github.com/users/yaauie/gists{/gist_id}","starred_url":"https://api.github.com/users/yaauie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaauie/subscriptions","organizations_url":"https://api.github.com/users/yaauie/orgs","repos_url":"https://api.github.com/users/yaauie/repos","events_url":"https://api.github.com/users/yaauie/events{/privacy}","received_events_url":"https://api.github.com/users/yaauie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yaauie/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":true,"url":"https://api.github.com/repos/yaauie/logstash","forks_url":"https://api.github.com/repos/yaauie/logstash/forks","keys_url":"https://api.github.com/repos/yaauie/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yaauie/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yaauie/logstash/teams","hooks_url":"https://api.github.com/repos/yaauie/logstash/hooks","issue_events_url":"https://api.github.com/repos/yaauie/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/yaauie/logstash/events","assignees_url":"https://api.github.com/repos/yaauie/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/yaauie/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/yaauie/logstash/tags","blobs_url":"https://api.github.com/repos/yaauie/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yaauie/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yaauie/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/yaauie/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yaauie/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/yaauie/logstash/languages","stargazers_url":"https://api.github.com/repos/yaauie/logstash/stargazers","contributors_url":"https://api.github.com/repos/yaauie/logstash/contributors","subscribers_url":"https://api.github.com/repos/yaauie/logstash/subscribers","subscription_url":"https://api.github.com/repos/yaauie/logstash/subscription","commits_url":"https://api.github.com/repos/yaauie/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/yaauie/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/yaauie/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/yaauie/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/yaauie/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/yaauie/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yaauie/logstash/merges","archive_url":"https://api.github.com/repos/yaauie/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yaauie/logstash/downloads","issues_url":"https://api.github.com/repos/yaauie/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/yaauie/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/yaauie/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/yaauie/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yaauie/logstash/labels{/name}","releases_url":"https://api.github.com/repos/yaauie/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/yaauie/logstash/deployments","created_at":"2017-10-23T17:18:21Z","updated_at":"2017-10-23T18:28:38Z","pushed_at":"2017-11-06T19:31:27Z","git_url":"git://github.com/yaauie/logstash.git","ssh_url":"git@github.com:yaauie/logstash.git","clone_url":"https://github.com/yaauie/logstash.git","svn_url":"https://github.com/yaauie/logstash","homepage":"https://www.elastic.co/products/logstash","size":97270,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"8cbc3982828e0411f2f87608bce7508bf5a997cc","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":1090311,"name":"logstash","full_name":"elastic/logstash","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/logstash","description":"Logstash - transport and process your logs, events, or other data","fork":false,"url":"https://api.github.com/repos/elastic/logstash","forks_url":"https://api.github.com/repos/elastic/logstash/forks","keys_url":"https://api.github.com/repos/elastic/logstash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/logstash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/logstash/teams","hooks_url":"https://api.github.com/repos/elastic/logstash/hooks","issue_events_url":"https://api.github.com/repos/elastic/logstash/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/logstash/events","assignees_url":"https://api.github.com/repos/elastic/logstash/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/logstash/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/logstash/tags","blobs_url":"https://api.github.com/repos/elastic/logstash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/logstash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/logstash/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/logstash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/logstash/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/logstash/languages","stargazers_url":"https://api.github.com/repos/elastic/logstash/stargazers","contributors_url":"https://api.github.com/repos/elastic/logstash/contributors","subscribers_url":"https://api.github.com/repos/elastic/logstash/subscribers","subscription_url":"https://api.github.com/repos/elastic/logstash/subscription","commits_url":"https://api.github.com/repos/elastic/logstash/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/logstash/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/logstash/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/logstash/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/logstash/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/logstash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/logstash/merges","archive_url":"https://api.github.com/repos/elastic/logstash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/logstash/downloads","issues_url":"https://api.github.com/repos/elastic/logstash/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/logstash/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/logstash/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/logstash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/logstash/labels{/name}","releases_url":"https://api.github.com/repos/elastic/logstash/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/logstash/deployments","created_at":"2010-11-18T01:31:50Z","updated_at":"2017-11-06T17:00:33Z","pushed_at":"2017-11-06T18:43:17Z","git_url":"git://github.com/elastic/logstash.git","ssh_url":"git@github.com:elastic/logstash.git","clone_url":"https://github.com/elastic/logstash.git","svn_url":"https://github.com/elastic/logstash","homepage":"https://www.elastic.co/products/logstash","size":97506,"stargazers_count":8168,"watchers_count":8168,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2288,"mirror_url":null,"archived":false,"open_issues_count":1022,"forks":2288,"open_issues":1022,"watchers":8168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8597"},"html":{"href":"https://github.com/elastic/logstash/pull/8597"},"issue":{"href":"https://api.github.com/repos/elastic/logstash/issues/8597"},"comments":{"href":"https://api.github.com/repos/elastic/logstash/issues/8597/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8597/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/logstash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/logstash/pulls/8597/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/logstash/statuses/429b3e05bace87eb376df9e1656a742c6ea3b6a9"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":37,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"yaauie"}}