{"action":"created","comment":{"url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/comments/124055932","pull_request_review_id":46313108,"id":124055932,"diff_hunk":"@@ -403,6 +406,20 @@ void *flexdll_dlopen(const char *file, int mode) {\n   return unit;\n }\n \n+void *flexdll_dlopen(const char *file, int mode)\n+{\n+  int exec = mode & FLEXDLL_RTLD_NOEXEC ? 0 : 1;\n+  if (!file) return &main_unit;\n+  return flexdll_dlopen_aux(ll_dlopen(file, exec), mode);","path":"flexdll.c","position":82,"original_position":82,"commit_id":"9fd0a3f0ed14796350c29a5763caff4a7f220e9e","original_commit_id":"9fd0a3f0ed14796350c29a5763caff4a7f220e9e","user":{"login":"alainfrisch","id":3305274,"avatar_url":"https://avatars3.githubusercontent.com/u/3305274?v=3","gravatar_id":"","url":"https://api.github.com/users/alainfrisch","html_url":"https://github.com/alainfrisch","followers_url":"https://api.github.com/users/alainfrisch/followers","following_url":"https://api.github.com/users/alainfrisch/following{/other_user}","gists_url":"https://api.github.com/users/alainfrisch/gists{/gist_id}","starred_url":"https://api.github.com/users/alainfrisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainfrisch/subscriptions","organizations_url":"https://api.github.com/users/alainfrisch/orgs","repos_url":"https://api.github.com/users/alainfrisch/repos","events_url":"https://api.github.com/users/alainfrisch/events{/privacy}","received_events_url":"https://api.github.com/users/alainfrisch/received_events","type":"User","site_admin":false},"body":"I think this is wrong: ll_dlopen would now be called before setting FLEXDLL_RELOCATE, which can be read by the DLL's entry point.","created_at":"2017-06-26T16:25:19Z","updated_at":"2017-06-26T16:25:19Z","html_url":"https://github.com/alainfrisch/flexdll/pull/34#discussion_r124055932","pull_request_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/34","_links":{"self":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/comments/124055932"},"html":{"href":"https://github.com/alainfrisch/flexdll/pull/34#discussion_r124055932"},"pull_request":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/34"}}},"pull_request":{"url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/34","id":127451148,"html_url":"https://github.com/alainfrisch/flexdll/pull/34","diff_url":"https://github.com/alainfrisch/flexdll/pull/34.diff","patch_url":"https://github.com/alainfrisch/flexdll/pull/34.patch","issue_url":"https://api.github.com/repos/alainfrisch/flexdll/issues/34","number":34,"state":"open","locked":false,"title":"Add wide-character version of flexdll_dlopen","user":{"login":"nojb","id":113560,"avatar_url":"https://avatars0.githubusercontent.com/u/113560?v=3","gravatar_id":"","url":"https://api.github.com/users/nojb","html_url":"https://github.com/nojb","followers_url":"https://api.github.com/users/nojb/followers","following_url":"https://api.github.com/users/nojb/following{/other_user}","gists_url":"https://api.github.com/users/nojb/gists{/gist_id}","starred_url":"https://api.github.com/users/nojb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojb/subscriptions","organizations_url":"https://api.github.com/users/nojb/orgs","repos_url":"https://api.github.com/users/nojb/repos","events_url":"https://api.github.com/users/nojb/events{/privacy}","received_events_url":"https://api.github.com/users/nojb/received_events","type":"User","site_admin":false},"body":"See #33, ocaml/ocaml#1200.","created_at":"2017-06-26T11:35:49Z","updated_at":"2017-06-26T16:25:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a84d9e37cf2d6f4bdaa29874136c2d11e52949f0","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/34/commits","review_comments_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/34/comments","review_comment_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls/comments{/number}","comments_url":"https://api.github.com/repos/alainfrisch/flexdll/issues/34/comments","statuses_url":"https://api.github.com/repos/alainfrisch/flexdll/statuses/9fd0a3f0ed14796350c29a5763caff4a7f220e9e","head":{"label":"nojb:master","ref":"master","sha":"9fd0a3f0ed14796350c29a5763caff4a7f220e9e","user":{"login":"nojb","id":113560,"avatar_url":"https://avatars0.githubusercontent.com/u/113560?v=3","gravatar_id":"","url":"https://api.github.com/users/nojb","html_url":"https://github.com/nojb","followers_url":"https://api.github.com/users/nojb/followers","following_url":"https://api.github.com/users/nojb/following{/other_user}","gists_url":"https://api.github.com/users/nojb/gists{/gist_id}","starred_url":"https://api.github.com/users/nojb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojb/subscriptions","organizations_url":"https://api.github.com/users/nojb/orgs","repos_url":"https://api.github.com/users/nojb/repos","events_url":"https://api.github.com/users/nojb/events{/privacy}","received_events_url":"https://api.github.com/users/nojb/received_events","type":"User","site_admin":false},"repo":{"id":95436104,"name":"flexdll","full_name":"nojb/flexdll","owner":{"login":"nojb","id":113560,"avatar_url":"https://avatars0.githubusercontent.com/u/113560?v=3","gravatar_id":"","url":"https://api.github.com/users/nojb","html_url":"https://github.com/nojb","followers_url":"https://api.github.com/users/nojb/followers","following_url":"https://api.github.com/users/nojb/following{/other_user}","gists_url":"https://api.github.com/users/nojb/gists{/gist_id}","starred_url":"https://api.github.com/users/nojb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nojb/subscriptions","organizations_url":"https://api.github.com/users/nojb/orgs","repos_url":"https://api.github.com/users/nojb/repos","events_url":"https://api.github.com/users/nojb/events{/privacy}","received_events_url":"https://api.github.com/users/nojb/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nojb/flexdll","description":"a dlopen-like API for Windows","fork":true,"url":"https://api.github.com/repos/nojb/flexdll","forks_url":"https://api.github.com/repos/nojb/flexdll/forks","keys_url":"https://api.github.com/repos/nojb/flexdll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nojb/flexdll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nojb/flexdll/teams","hooks_url":"https://api.github.com/repos/nojb/flexdll/hooks","issue_events_url":"https://api.github.com/repos/nojb/flexdll/issues/events{/number}","events_url":"https://api.github.com/repos/nojb/flexdll/events","assignees_url":"https://api.github.com/repos/nojb/flexdll/assignees{/user}","branches_url":"https://api.github.com/repos/nojb/flexdll/branches{/branch}","tags_url":"https://api.github.com/repos/nojb/flexdll/tags","blobs_url":"https://api.github.com/repos/nojb/flexdll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nojb/flexdll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nojb/flexdll/git/refs{/sha}","trees_url":"https://api.github.com/repos/nojb/flexdll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nojb/flexdll/statuses/{sha}","languages_url":"https://api.github.com/repos/nojb/flexdll/languages","stargazers_url":"https://api.github.com/repos/nojb/flexdll/stargazers","contributors_url":"https://api.github.com/repos/nojb/flexdll/contributors","subscribers_url":"https://api.github.com/repos/nojb/flexdll/subscribers","subscription_url":"https://api.github.com/repos/nojb/flexdll/subscription","commits_url":"https://api.github.com/repos/nojb/flexdll/commits{/sha}","git_commits_url":"https://api.github.com/repos/nojb/flexdll/git/commits{/sha}","comments_url":"https://api.github.com/repos/nojb/flexdll/comments{/number}","issue_comment_url":"https://api.github.com/repos/nojb/flexdll/issues/comments{/number}","contents_url":"https://api.github.com/repos/nojb/flexdll/contents/{+path}","compare_url":"https://api.github.com/repos/nojb/flexdll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nojb/flexdll/merges","archive_url":"https://api.github.com/repos/nojb/flexdll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nojb/flexdll/downloads","issues_url":"https://api.github.com/repos/nojb/flexdll/issues{/number}","pulls_url":"https://api.github.com/repos/nojb/flexdll/pulls{/number}","milestones_url":"https://api.github.com/repos/nojb/flexdll/milestones{/number}","notifications_url":"https://api.github.com/repos/nojb/flexdll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nojb/flexdll/labels{/name}","releases_url":"https://api.github.com/repos/nojb/flexdll/releases{/id}","deployments_url":"https://api.github.com/repos/nojb/flexdll/deployments","created_at":"2017-06-26T10:36:03Z","updated_at":"2017-06-26T10:36:04Z","pushed_at":"2017-06-26T11:34:02Z","git_url":"git://github.com/nojb/flexdll.git","ssh_url":"git@github.com:nojb/flexdll.git","clone_url":"https://github.com/nojb/flexdll.git","svn_url":"https://github.com/nojb/flexdll","homepage":"","size":315,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"alainfrisch:master","ref":"master","sha":"a18ae9d1f5bdfd5232ba03f26943ff1ed507a4dd","user":{"login":"alainfrisch","id":3305274,"avatar_url":"https://avatars3.githubusercontent.com/u/3305274?v=3","gravatar_id":"","url":"https://api.github.com/users/alainfrisch","html_url":"https://github.com/alainfrisch","followers_url":"https://api.github.com/users/alainfrisch/followers","following_url":"https://api.github.com/users/alainfrisch/following{/other_user}","gists_url":"https://api.github.com/users/alainfrisch/gists{/gist_id}","starred_url":"https://api.github.com/users/alainfrisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainfrisch/subscriptions","organizations_url":"https://api.github.com/users/alainfrisch/orgs","repos_url":"https://api.github.com/users/alainfrisch/repos","events_url":"https://api.github.com/users/alainfrisch/events{/privacy}","received_events_url":"https://api.github.com/users/alainfrisch/received_events","type":"User","site_admin":false},"repo":{"id":15137466,"name":"flexdll","full_name":"alainfrisch/flexdll","owner":{"login":"alainfrisch","id":3305274,"avatar_url":"https://avatars3.githubusercontent.com/u/3305274?v=3","gravatar_id":"","url":"https://api.github.com/users/alainfrisch","html_url":"https://github.com/alainfrisch","followers_url":"https://api.github.com/users/alainfrisch/followers","following_url":"https://api.github.com/users/alainfrisch/following{/other_user}","gists_url":"https://api.github.com/users/alainfrisch/gists{/gist_id}","starred_url":"https://api.github.com/users/alainfrisch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alainfrisch/subscriptions","organizations_url":"https://api.github.com/users/alainfrisch/orgs","repos_url":"https://api.github.com/users/alainfrisch/repos","events_url":"https://api.github.com/users/alainfrisch/events{/privacy}","received_events_url":"https://api.github.com/users/alainfrisch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alainfrisch/flexdll","description":"a dlopen-like API for Windows","fork":false,"url":"https://api.github.com/repos/alainfrisch/flexdll","forks_url":"https://api.github.com/repos/alainfrisch/flexdll/forks","keys_url":"https://api.github.com/repos/alainfrisch/flexdll/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alainfrisch/flexdll/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alainfrisch/flexdll/teams","hooks_url":"https://api.github.com/repos/alainfrisch/flexdll/hooks","issue_events_url":"https://api.github.com/repos/alainfrisch/flexdll/issues/events{/number}","events_url":"https://api.github.com/repos/alainfrisch/flexdll/events","assignees_url":"https://api.github.com/repos/alainfrisch/flexdll/assignees{/user}","branches_url":"https://api.github.com/repos/alainfrisch/flexdll/branches{/branch}","tags_url":"https://api.github.com/repos/alainfrisch/flexdll/tags","blobs_url":"https://api.github.com/repos/alainfrisch/flexdll/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alainfrisch/flexdll/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alainfrisch/flexdll/git/refs{/sha}","trees_url":"https://api.github.com/repos/alainfrisch/flexdll/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alainfrisch/flexdll/statuses/{sha}","languages_url":"https://api.github.com/repos/alainfrisch/flexdll/languages","stargazers_url":"https://api.github.com/repos/alainfrisch/flexdll/stargazers","contributors_url":"https://api.github.com/repos/alainfrisch/flexdll/contributors","subscribers_url":"https://api.github.com/repos/alainfrisch/flexdll/subscribers","subscription_url":"https://api.github.com/repos/alainfrisch/flexdll/subscription","commits_url":"https://api.github.com/repos/alainfrisch/flexdll/commits{/sha}","git_commits_url":"https://api.github.com/repos/alainfrisch/flexdll/git/commits{/sha}","comments_url":"https://api.github.com/repos/alainfrisch/flexdll/comments{/number}","issue_comment_url":"https://api.github.com/repos/alainfrisch/flexdll/issues/comments{/number}","contents_url":"https://api.github.com/repos/alainfrisch/flexdll/contents/{+path}","compare_url":"https://api.github.com/repos/alainfrisch/flexdll/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alainfrisch/flexdll/merges","archive_url":"https://api.github.com/repos/alainfrisch/flexdll/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alainfrisch/flexdll/downloads","issues_url":"https://api.github.com/repos/alainfrisch/flexdll/issues{/number}","pulls_url":"https://api.github.com/repos/alainfrisch/flexdll/pulls{/number}","milestones_url":"https://api.github.com/repos/alainfrisch/flexdll/milestones{/number}","notifications_url":"https://api.github.com/repos/alainfrisch/flexdll/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alainfrisch/flexdll/labels{/name}","releases_url":"https://api.github.com/repos/alainfrisch/flexdll/releases{/id}","deployments_url":"https://api.github.com/repos/alainfrisch/flexdll/deployments","created_at":"2013-12-12T14:04:07Z","updated_at":"2017-06-25T03:50:43Z","pushed_at":"2017-06-26T11:35:50Z","git_url":"git://github.com/alainfrisch/flexdll.git","ssh_url":"git@github.com:alainfrisch/flexdll.git","clone_url":"https://github.com/alainfrisch/flexdll.git","svn_url":"https://github.com/alainfrisch/flexdll","homepage":"","size":373,"stargazers_count":21,"watchers_count":21,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"open_issues_count":13,"forks":13,"open_issues":13,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/34"},"html":{"href":"https://github.com/alainfrisch/flexdll/pull/34"},"issue":{"href":"https://api.github.com/repos/alainfrisch/flexdll/issues/34"},"comments":{"href":"https://api.github.com/repos/alainfrisch/flexdll/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/alainfrisch/flexdll/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/alainfrisch/flexdll/statuses/9fd0a3f0ed14796350c29a5763caff4a7f220e9e"}}}}
{"actor":{"display_login":"alainfrisch"}}