{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/110687099","pull_request_review_id":31876385,"id":110687099,"diff_hunk":"@@ -12,5 +12,12 @@\n       cms.InputTag(\"inclusiveCandidateSecondaryVertices\"),\n       cms.InputTag(\"inclusiveCandidateSecondaryVerticesCvsL\"),\n       ),      \n-    minPtForTrackProperties = cms.double(0.95)\n+    minPtForTrackProperties = cms.double(0.95),\n+    covarianceVersion = cms.int32(0), #so far: 0 is Phase0, 1 is Phase1   \n+#    covariancePackingSchemas = cms.vint32(1,257,513,769,0)  # a cheaper schema in kb/ev \n+    covariancePackingSchemas = cms.vint32(8,264,520,776,0)   # more accurate schema +0.6kb/ev   ","path":"PhysicsTools/PatAlgos/python/slimming/packedPFCandidates_cfi.py","position":8,"original_position":8,"commit_id":"657091351c285b18941e839ca899d4802b805aca","original_commit_id":"657091351c285b18941e839ca899d4802b805aca","user":{"login":"slava77","id":4676718,"avatar_url":"https://avatars1.githubusercontent.com/u/4676718?v=3","gravatar_id":"","url":"https://api.github.com/users/slava77","html_url":"https://github.com/slava77","followers_url":"https://api.github.com/users/slava77/followers","following_url":"https://api.github.com/users/slava77/following{/other_user}","gists_url":"https://api.github.com/users/slava77/gists{/gist_id}","starred_url":"https://api.github.com/users/slava77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slava77/subscriptions","organizations_url":"https://api.github.com/users/slava77/orgs","repos_url":"https://api.github.com/users/slava77/repos","events_url":"https://api.github.com/users/slava77/events{/privacy}","received_events_url":"https://api.github.com/users/slava77/received_events","type":"User","site_admin":false},"body":"please add some notes what these values mean here.\r\n[it looks like currently, the only solution is to run some script, read the code, and then match the numbers]","created_at":"2017-04-10T15:28:45Z","updated_at":"2017-04-10T15:28:45Z","html_url":"https://github.com/cms-sw/cmssw/pull/18092#discussion_r110687099","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18092","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/110687099"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/18092#discussion_r110687099"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18092"}}},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18092","id":112742720,"html_url":"https://github.com/cms-sw/cmssw/pull/18092","diff_url":"https://github.com/cms-sw/cmssw/pull/18092.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/18092.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18092","number":18092,"state":"open","locked":false,"title":"MiniAOD new track covariance parameterization","user":{"login":"arizzi","id":5022358,"avatar_url":"https://avatars2.githubusercontent.com/u/5022358?v=3","gravatar_id":"","url":"https://api.github.com/users/arizzi","html_url":"https://github.com/arizzi","followers_url":"https://api.github.com/users/arizzi/followers","following_url":"https://api.github.com/users/arizzi/following{/other_user}","gists_url":"https://api.github.com/users/arizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/arizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arizzi/subscriptions","organizations_url":"https://api.github.com/users/arizzi/orgs","repos_url":"https://api.github.com/users/arizzi/repos","events_url":"https://api.github.com/users/arizzi/events{/privacy}","received_events_url":"https://api.github.com/users/arizzi/received_events","type":"User","site_admin":false},"body":"New version of  track covariance for MiniAOD based on meanvalues, compression ranges and compression methods specified in versionable root file from DataFormats/PatCandidates/data while event by event only the id of the method. (developments from @gmandorl)\r\n\r\nThe expected size change depends on PU. It should zero or slightly negative on noPU and the increase should be below 1Kb/ev on relval ttbar w/ PU. \r\n\r\n*Update:* the working point has been changed to a slightly more expensive one, increase on ttbar w/PU ~600bytes/ev compared to previous version.\r\n\r\n*Update:* the code should be backward compatible, reading old MiniAOD should produce meaningful result. \r\n\r\n@gpetruc \r\n\r\nNB: the PR is being tested with recent IB for final size increase and validation of output (all validation tests where made with 80X and several changes have been introduced to merge in 91X)","created_at":"2017-03-27T13:18:34Z","updated_at":"2017-04-10T15:28:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ad75d7def753960ac42c80d60e21bb9fa2354ceb","assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/65","html_url":"https://github.com/cms-sw/cmssw/milestone/65","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/65/labels","id":2358370,"number":65,"title":"Next CMSSW_9_1_X","description":"","creator":{"login":"smuzaffar","id":4115138,"avatar_url":"https://avatars0.githubusercontent.com/u/4115138?v=3","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":86,"closed_issues":321,"state":"open","created_at":"2017-03-02T09:15:47Z","updated_at":"2017-04-10T14:56:54Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18092/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/18092/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/18092/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/657091351c285b18941e839ca899d4802b805aca","head":{"label":"arizzi:cov91X","ref":"cov91X","sha":"657091351c285b18941e839ca899d4802b805aca","user":{"login":"arizzi","id":5022358,"avatar_url":"https://avatars2.githubusercontent.com/u/5022358?v=3","gravatar_id":"","url":"https://api.github.com/users/arizzi","html_url":"https://github.com/arizzi","followers_url":"https://api.github.com/users/arizzi/followers","following_url":"https://api.github.com/users/arizzi/following{/other_user}","gists_url":"https://api.github.com/users/arizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/arizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arizzi/subscriptions","organizations_url":"https://api.github.com/users/arizzi/orgs","repos_url":"https://api.github.com/users/arizzi/repos","events_url":"https://api.github.com/users/arizzi/events{/privacy}","received_events_url":"https://api.github.com/users/arizzi/received_events","type":"User","site_admin":false},"repo":{"id":11454967,"name":"cmssw","full_name":"arizzi/cmssw","owner":{"login":"arizzi","id":5022358,"avatar_url":"https://avatars2.githubusercontent.com/u/5022358?v=3","gravatar_id":"","url":"https://api.github.com/users/arizzi","html_url":"https://github.com/arizzi","followers_url":"https://api.github.com/users/arizzi/followers","following_url":"https://api.github.com/users/arizzi/following{/other_user}","gists_url":"https://api.github.com/users/arizzi/gists{/gist_id}","starred_url":"https://api.github.com/users/arizzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arizzi/subscriptions","organizations_url":"https://api.github.com/users/arizzi/orgs","repos_url":"https://api.github.com/users/arizzi/repos","events_url":"https://api.github.com/users/arizzi/events{/privacy}","received_events_url":"https://api.github.com/users/arizzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arizzi/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/arizzi/cmssw","forks_url":"https://api.github.com/repos/arizzi/cmssw/forks","keys_url":"https://api.github.com/repos/arizzi/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arizzi/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arizzi/cmssw/teams","hooks_url":"https://api.github.com/repos/arizzi/cmssw/hooks","issue_events_url":"https://api.github.com/repos/arizzi/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/arizzi/cmssw/events","assignees_url":"https://api.github.com/repos/arizzi/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/arizzi/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/arizzi/cmssw/tags","blobs_url":"https://api.github.com/repos/arizzi/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arizzi/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arizzi/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/arizzi/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arizzi/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/arizzi/cmssw/languages","stargazers_url":"https://api.github.com/repos/arizzi/cmssw/stargazers","contributors_url":"https://api.github.com/repos/arizzi/cmssw/contributors","subscribers_url":"https://api.github.com/repos/arizzi/cmssw/subscribers","subscription_url":"https://api.github.com/repos/arizzi/cmssw/subscription","commits_url":"https://api.github.com/repos/arizzi/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/arizzi/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/arizzi/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/arizzi/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/arizzi/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/arizzi/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arizzi/cmssw/merges","archive_url":"https://api.github.com/repos/arizzi/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arizzi/cmssw/downloads","issues_url":"https://api.github.com/repos/arizzi/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/arizzi/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/arizzi/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/arizzi/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arizzi/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/arizzi/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/arizzi/cmssw/deployments","created_at":"2013-07-16T16:56:57Z","updated_at":"2014-06-20T13:25:48Z","pushed_at":"2017-04-10T12:55:47Z","git_url":"git://github.com/arizzi/cmssw.git","ssh_url":"git@github.com:arizzi/cmssw.git","clone_url":"https://github.com/arizzi/cmssw.git","svn_url":"https://github.com/arizzi/cmssw","homepage":"cms-sw.github.io/cmssw","size":1118144,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":0,"default_branch":"CMSSW_7_0_X"}},"base":{"label":"cms-sw:master","ref":"master","sha":"b70be61968f57bca9c0bbca1437220af264aa592","user":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars3.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"avatar_url":"https://avatars3.githubusercontent.com/u/3863500?v=3","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2017-04-10T08:39:06Z","pushed_at":"2017-04-10T15:04:20Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":936306,"stargazers_count":407,"watchers_count":407,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2148,"mirror_url":null,"open_issues_count":378,"forks":2148,"open_issues":378,"watchers":407,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18092"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/18092"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/18092"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/18092/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18092/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/18092/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/657091351c285b18941e839ca899d4802b805aca"}}}}
{"actor":{"display_login":"slava77"}}