{"action":"created","issue":{"url":"https://api.github.com/repos/cljsjs/packages/issues/1129","repository_url":"https://api.github.com/repos/cljsjs/packages","labels_url":"https://api.github.com/repos/cljsjs/packages/issues/1129/labels{/name}","comments_url":"https://api.github.com/repos/cljsjs/packages/issues/1129/comments","events_url":"https://api.github.com/repos/cljsjs/packages/issues/1129/events","html_url":"https://github.com/cljsjs/packages/issues/1129","id":225334406,"number":1129,"title":"Bad react externs","user":{"login":"thheller","id":144930,"avatar_url":"https://avatars2.githubusercontent.com/u/144930?v=4","gravatar_id":"","url":"https://api.github.com/users/thheller","html_url":"https://github.com/thheller","followers_url":"https://api.github.com/users/thheller/followers","following_url":"https://api.github.com/users/thheller/following{/other_user}","gists_url":"https://api.github.com/users/thheller/gists{/gist_id}","starred_url":"https://api.github.com/users/thheller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thheller/subscriptions","organizations_url":"https://api.github.com/users/thheller/orgs","repos_url":"https://api.github.com/users/thheller/repos","events_url":"https://api.github.com/users/thheller/events{/privacy}","received_events_url":"https://api.github.com/users/thheller/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-04-30T15:34:44Z","updated_at":"2017-10-10T03:09:42Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I'm currently working on enabling the Closure `:check-types` compiler option again. While doing so it uncovered some bad annotations in the `react` package externs.\r\n\r\n\r\n```\r\nCLOSURE-WARNING: EXTERNS:/Users/zilence/.m2/repository/cljsjs/react-dom/15.4.2-2/react-dom-15.4.2-2.jar!/cljsjs/react-dom/common/react-dom.ext.js[27:11]\r\n\tBad type annotation. Unknown type React.ReactComponent\r\n\r\n\r\nCLOSURE-WARNING: EXTERNS:/Users/zilence/.m2/repository/cljsjs/react-dom/15.4.2-2/react-dom-15.4.2-2.jar!/cljsjs/react-dom/common/react-dom.ext.js[30:12]\r\n\tBad type annotation. Unknown type React.ReactComponent\r\n\r\n\r\nCLOSURE-WARNING: EXTERNS:/Users/zilence/.m2/repository/cljsjs/react-dom/15.4.2-2/react-dom-15.4.2-2.jar!/cljsjs/react-dom/common/react-dom.ext.js[43:11]\r\n\tBad type annotation. Unknown type React.ReactComponent\r\n\r\n\r\nCLOSURE-WARNING: EXTERNS:/Users/zilence/.m2/repository/cljsjs/react-dom/15.4.2-2/react-dom-15.4.2-2.jar!/cljsjs/react-dom/common/react-dom.ext.js[70:11]\r\n\tBad type annotation. Unknown type React.ReactComponent\r\n\r\n\r\nCLOSURE-WARNING: EXTERNS:/Users/zilence/.m2/repository/cljsjs/react-dom/15.4.2-2/react-dom-15.4.2-2.jar!/cljsjs/react-dom/common/react-dom.ext.js[71:11]\r\n\tBad type annotation. Unknown type React.ReactElement\r\n\r\n\r\nCLOSURE-WARNING: EXTERNS:/Users/zilence/.m2/repository/cljsjs/react-dom/15.4.2-2/react-dom-15.4.2-2.jar!/cljsjs/react-dom/common/react-dom.ext.js[74:12]\r\n\tBad type annotation. Unknown type React.ReactComponent\r\n\r\n\r\nCLOSURE-WARNING: EXTERNS:/Users/zilence/.m2/repository/cljsjs/react/15.4.2-2/react-15.4.2-2.jar!/cljsjs/react/common/react.ext.js[212:22]\r\n\t@extends used without @constructor or @interface for React.PureComponent\r\n```\r\n\r\nThey work but that should probably be fixed at some point.\r\n\r\nI'll create a PR when I find the time."},"comment":{"url":"https://api.github.com/repos/cljsjs/packages/issues/comments/335347068","html_url":"https://github.com/cljsjs/packages/issues/1129#issuecomment-335347068","issue_url":"https://api.github.com/repos/cljsjs/packages/issues/1129","id":335347068,"user":{"login":"tiagob","id":1031522,"avatar_url":"https://avatars0.githubusercontent.com/u/1031522?v=4","gravatar_id":"","url":"https://api.github.com/users/tiagob","html_url":"https://github.com/tiagob","followers_url":"https://api.github.com/users/tiagob/followers","following_url":"https://api.github.com/users/tiagob/following{/other_user}","gists_url":"https://api.github.com/users/tiagob/gists{/gist_id}","starred_url":"https://api.github.com/users/tiagob/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiagob/subscriptions","organizations_url":"https://api.github.com/users/tiagob/orgs","repos_url":"https://api.github.com/users/tiagob/repos","events_url":"https://api.github.com/users/tiagob/events{/privacy}","received_events_url":"https://api.github.com/users/tiagob/received_events","type":"User","site_admin":false},"created_at":"2017-10-10T03:09:42Z","updated_at":"2017-10-10T03:09:42Z","author_association":"NONE","body":"+1"}}
{"actor":{"display_login":"tiagob"}}