{"action":"opened","number":71,"pull_request":{"url":"https://api.github.com/repos/robotology/robot-testing/pulls/71","id":143572506,"html_url":"https://github.com/robotology/robot-testing/pull/71","diff_url":"https://github.com/robotology/robot-testing/pull/71.diff","patch_url":"https://github.com/robotology/robot-testing/pull/71.patch","issue_url":"https://api.github.com/repos/robotology/robot-testing/issues/71","number":71,"state":"open","locked":false,"title":"Fix suit -> suite","user":{"login":"drdanz","id":1100056,"avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},"body":"### Warning: breaking change\r\n\r\nI don't think it is worth supporting both the **suit** and **suite** syntax in the xml parsing and in the arguments, it would require a lot of effort just to support a typo. I suggest we just break compatibility now instead.\r\n\r\nin master we can ensure that the RTF version is ok by changing:\r\n\r\n```diff\r\n-find_package(RTF 1.2)\r\n+find_package(RTF 1.2 EXACT)\r\n```\r\n\r\nin devel we can change it to\r\n```diff\r\n-find_package(RTF 1.2)\r\n+find_package(RTF 1.3)\r\n```\r\n","created_at":"2017-09-28T07:20:52Z","updated_at":"2017-09-28T07:20:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/robotology/robot-testing/pulls/71/commits","review_comments_url":"https://api.github.com/repos/robotology/robot-testing/pulls/71/comments","review_comment_url":"https://api.github.com/repos/robotology/robot-testing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robotology/robot-testing/issues/71/comments","statuses_url":"https://api.github.com/repos/robotology/robot-testing/statuses/1fbd3fe16c6b4d5d691c9c1bd14e6a54bd9b31ef","head":{"label":"drdanz:fix/suit","ref":"fix/suit","sha":"1fbd3fe16c6b4d5d691c9c1bd14e6a54bd9b31ef","user":{"login":"drdanz","id":1100056,"avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},"repo":{"id":94340569,"name":"robot-testing","full_name":"drdanz/robot-testing","owner":{"login":"drdanz","id":1100056,"avatar_url":"https://avatars2.githubusercontent.com/u/1100056?v=4","gravatar_id":"","url":"https://api.github.com/users/drdanz","html_url":"https://github.com/drdanz","followers_url":"https://api.github.com/users/drdanz/followers","following_url":"https://api.github.com/users/drdanz/following{/other_user}","gists_url":"https://api.github.com/users/drdanz/gists{/gist_id}","starred_url":"https://api.github.com/users/drdanz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drdanz/subscriptions","organizations_url":"https://api.github.com/users/drdanz/orgs","repos_url":"https://api.github.com/users/drdanz/repos","events_url":"https://api.github.com/users/drdanz/events{/privacy}","received_events_url":"https://api.github.com/users/drdanz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/drdanz/robot-testing","description":"Robot Testing Framework (RTF)","fork":true,"url":"https://api.github.com/repos/drdanz/robot-testing","forks_url":"https://api.github.com/repos/drdanz/robot-testing/forks","keys_url":"https://api.github.com/repos/drdanz/robot-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drdanz/robot-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drdanz/robot-testing/teams","hooks_url":"https://api.github.com/repos/drdanz/robot-testing/hooks","issue_events_url":"https://api.github.com/repos/drdanz/robot-testing/issues/events{/number}","events_url":"https://api.github.com/repos/drdanz/robot-testing/events","assignees_url":"https://api.github.com/repos/drdanz/robot-testing/assignees{/user}","branches_url":"https://api.github.com/repos/drdanz/robot-testing/branches{/branch}","tags_url":"https://api.github.com/repos/drdanz/robot-testing/tags","blobs_url":"https://api.github.com/repos/drdanz/robot-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drdanz/robot-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drdanz/robot-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/drdanz/robot-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drdanz/robot-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/drdanz/robot-testing/languages","stargazers_url":"https://api.github.com/repos/drdanz/robot-testing/stargazers","contributors_url":"https://api.github.com/repos/drdanz/robot-testing/contributors","subscribers_url":"https://api.github.com/repos/drdanz/robot-testing/subscribers","subscription_url":"https://api.github.com/repos/drdanz/robot-testing/subscription","commits_url":"https://api.github.com/repos/drdanz/robot-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/drdanz/robot-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/drdanz/robot-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/drdanz/robot-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/drdanz/robot-testing/contents/{+path}","compare_url":"https://api.github.com/repos/drdanz/robot-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drdanz/robot-testing/merges","archive_url":"https://api.github.com/repos/drdanz/robot-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drdanz/robot-testing/downloads","issues_url":"https://api.github.com/repos/drdanz/robot-testing/issues{/number}","pulls_url":"https://api.github.com/repos/drdanz/robot-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/drdanz/robot-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/drdanz/robot-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drdanz/robot-testing/labels{/name}","releases_url":"https://api.github.com/repos/drdanz/robot-testing/releases{/id}","deployments_url":"https://api.github.com/repos/drdanz/robot-testing/deployments","created_at":"2017-06-14T14:34:44Z","updated_at":"2017-06-14T14:59:11Z","pushed_at":"2017-09-28T07:12:07Z","git_url":"git://github.com/drdanz/robot-testing.git","ssh_url":"git@github.com:drdanz/robot-testing.git","clone_url":"https://github.com/drdanz/robot-testing.git","svn_url":"https://github.com/drdanz/robot-testing","homepage":"http://robotology.github.io/robot-testing/index.html","size":710,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"robotology:devel","ref":"devel","sha":"2a920ffb47b378dce7e9e8d82d4766625fb4784f","user":{"login":"robotology","id":1587191,"avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"repo":{"id":28056717,"name":"robot-testing","full_name":"robotology/robot-testing","owner":{"login":"robotology","id":1587191,"avatar_url":"https://avatars2.githubusercontent.com/u/1587191?v=4","gravatar_id":"","url":"https://api.github.com/users/robotology","html_url":"https://github.com/robotology","followers_url":"https://api.github.com/users/robotology/followers","following_url":"https://api.github.com/users/robotology/following{/other_user}","gists_url":"https://api.github.com/users/robotology/gists{/gist_id}","starred_url":"https://api.github.com/users/robotology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robotology/subscriptions","organizations_url":"https://api.github.com/users/robotology/orgs","repos_url":"https://api.github.com/users/robotology/repos","events_url":"https://api.github.com/users/robotology/events{/privacy}","received_events_url":"https://api.github.com/users/robotology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/robotology/robot-testing","description":"Robot Testing Framework (RTF)","fork":false,"url":"https://api.github.com/repos/robotology/robot-testing","forks_url":"https://api.github.com/repos/robotology/robot-testing/forks","keys_url":"https://api.github.com/repos/robotology/robot-testing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robotology/robot-testing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robotology/robot-testing/teams","hooks_url":"https://api.github.com/repos/robotology/robot-testing/hooks","issue_events_url":"https://api.github.com/repos/robotology/robot-testing/issues/events{/number}","events_url":"https://api.github.com/repos/robotology/robot-testing/events","assignees_url":"https://api.github.com/repos/robotology/robot-testing/assignees{/user}","branches_url":"https://api.github.com/repos/robotology/robot-testing/branches{/branch}","tags_url":"https://api.github.com/repos/robotology/robot-testing/tags","blobs_url":"https://api.github.com/repos/robotology/robot-testing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robotology/robot-testing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robotology/robot-testing/git/refs{/sha}","trees_url":"https://api.github.com/repos/robotology/robot-testing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robotology/robot-testing/statuses/{sha}","languages_url":"https://api.github.com/repos/robotology/robot-testing/languages","stargazers_url":"https://api.github.com/repos/robotology/robot-testing/stargazers","contributors_url":"https://api.github.com/repos/robotology/robot-testing/contributors","subscribers_url":"https://api.github.com/repos/robotology/robot-testing/subscribers","subscription_url":"https://api.github.com/repos/robotology/robot-testing/subscription","commits_url":"https://api.github.com/repos/robotology/robot-testing/commits{/sha}","git_commits_url":"https://api.github.com/repos/robotology/robot-testing/git/commits{/sha}","comments_url":"https://api.github.com/repos/robotology/robot-testing/comments{/number}","issue_comment_url":"https://api.github.com/repos/robotology/robot-testing/issues/comments{/number}","contents_url":"https://api.github.com/repos/robotology/robot-testing/contents/{+path}","compare_url":"https://api.github.com/repos/robotology/robot-testing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robotology/robot-testing/merges","archive_url":"https://api.github.com/repos/robotology/robot-testing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robotology/robot-testing/downloads","issues_url":"https://api.github.com/repos/robotology/robot-testing/issues{/number}","pulls_url":"https://api.github.com/repos/robotology/robot-testing/pulls{/number}","milestones_url":"https://api.github.com/repos/robotology/robot-testing/milestones{/number}","notifications_url":"https://api.github.com/repos/robotology/robot-testing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robotology/robot-testing/labels{/name}","releases_url":"https://api.github.com/repos/robotology/robot-testing/releases{/id}","deployments_url":"https://api.github.com/repos/robotology/robot-testing/deployments","created_at":"2014-12-15T21:18:32Z","updated_at":"2017-04-07T12:26:05Z","pushed_at":"2017-09-28T07:11:12Z","git_url":"git://github.com/robotology/robot-testing.git","ssh_url":"git@github.com:robotology/robot-testing.git","clone_url":"https://github.com/robotology/robot-testing.git","svn_url":"https://github.com/robotology/robot-testing","homepage":"http://robotology.github.io/robot-testing/index.html","size":16368,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"open_issues_count":16,"forks":9,"open_issues":16,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robotology/robot-testing/pulls/71"},"html":{"href":"https://github.com/robotology/robot-testing/pull/71"},"issue":{"href":"https://api.github.com/repos/robotology/robot-testing/issues/71"},"comments":{"href":"https://api.github.com/repos/robotology/robot-testing/issues/71/comments"},"review_comments":{"href":"https://api.github.com/repos/robotology/robot-testing/pulls/71/comments"},"review_comment":{"href":"https://api.github.com/repos/robotology/robot-testing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robotology/robot-testing/pulls/71/commits"},"statuses":{"href":"https://api.github.com/repos/robotology/robot-testing/statuses/1fbd3fe16c6b4d5d691c9c1bd14e6a54bd9b31ef"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":503,"deletions":503,"changed_files":50}}
{"actor":{"display_login":"drdanz"}}