{"action":"created","issue":{"url":"https://api.github.com/repos/jviereck/regjsparser/issues/83","repository_url":"https://api.github.com/repos/jviereck/regjsparser","labels_url":"https://api.github.com/repos/jviereck/regjsparser/issues/83/labels{/name}","comments_url":"https://api.github.com/repos/jviereck/regjsparser/issues/83/comments","events_url":"https://api.github.com/repos/jviereck/regjsparser/issues/83/events","html_url":"https://github.com/jviereck/regjsparser/pull/83","id":284472337,"number":83,"title":"Add support for named capturing groups","user":{"login":"nicolo-ribaudo","id":7000710,"avatar_url":"https://avatars3.githubusercontent.com/u/7000710?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolo-ribaudo","html_url":"https://github.com/nicolo-ribaudo","followers_url":"https://api.github.com/users/nicolo-ribaudo/followers","following_url":"https://api.github.com/users/nicolo-ribaudo/following{/other_user}","gists_url":"https://api.github.com/users/nicolo-ribaudo/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolo-ribaudo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolo-ribaudo/subscriptions","organizations_url":"https://api.github.com/users/nicolo-ribaudo/orgs","repos_url":"https://api.github.com/users/nicolo-ribaudo/repos","events_url":"https://api.github.com/users/nicolo-ribaudo/events{/privacy}","received_events_url":"https://api.github.com/users/nicolo-ribaudo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-12-25T22:48:12Z","updated_at":"2017-12-26T22:41:06Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/jviereck/regjsparser/pulls/83","html_url":"https://github.com/jviereck/regjsparser/pull/83","diff_url":"https://github.com/jviereck/regjsparser/pull/83.diff","patch_url":"https://github.com/jviereck/regjsparser/pull/83.patch"},"body":"https://github.com/tc39/proposal-regexp-named-groups\r\n\r\nI started working on this feature because I needed it for implementing a babel plugin. I then decided to use another package which already transformsnamed groups in regexps (regexp-tree), but I finished this PR anyway since it will probably be useful to someone else."},"comment":{"url":"https://api.github.com/repos/jviereck/regjsparser/issues/comments/354021066","html_url":"https://github.com/jviereck/regjsparser/pull/83#issuecomment-354021066","issue_url":"https://api.github.com/repos/jviereck/regjsparser/issues/83","id":354021066,"user":{"login":"jviereck","id":191719,"avatar_url":"https://avatars2.githubusercontent.com/u/191719?v=4","gravatar_id":"","url":"https://api.github.com/users/jviereck","html_url":"https://github.com/jviereck","followers_url":"https://api.github.com/users/jviereck/followers","following_url":"https://api.github.com/users/jviereck/following{/other_user}","gists_url":"https://api.github.com/users/jviereck/gists{/gist_id}","starred_url":"https://api.github.com/users/jviereck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jviereck/subscriptions","organizations_url":"https://api.github.com/users/jviereck/orgs","repos_url":"https://api.github.com/users/jviereck/repos","events_url":"https://api.github.com/users/jviereck/events{/privacy}","received_events_url":"https://api.github.com/users/jviereck/received_events","type":"User","site_admin":false},"created_at":"2017-12-26T22:41:06Z","updated_at":"2017-12-26T22:41:06Z","author_association":"OWNER","body":"Hi @nicolo-ribaudo,\r\n\r\nthanks a lot for implementing this and proving the PR - especially as you went with using a different parser in the end :)\r\n\r\nDoing a quick look over the code, is the named-group feature enabled by default? When adding unicode parsing before (see [1]), we've added a `features` flag to the `parse(...)` function. I think having a feature flag for this feature would be great as well. What do you think?\r\n\r\nIf you have any questions, let me know.\r\n\r\nThanks! \\jv\r\n \r\n[1]: https://github.com/jviereck/regjsparser/pull/78#issuecomment-220850082\r\n\r\n"}}
{"actor":{"display_login":"jviereck"}}