{"action":"opened","issue":{"url":"https://api.github.com/repos/bandre-ucar/junk-issues/issues/46","repository_url":"https://api.github.com/repos/bandre-ucar/junk-issues","labels_url":"https://api.github.com/repos/bandre-ucar/junk-issues/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/bandre-ucar/junk-issues/issues/46/comments","events_url":"https://api.github.com/repos/bandre-ucar/junk-issues/issues/46/events","html_url":"https://github.com/bandre-ucar/junk-issues/issues/46","id":271984867,"number":46,"title":"Possible changes for having create_crop_landunit always true","user":{"login":"bandre-ucar","id":9341547,"avatar_url":"https://avatars2.githubusercontent.com/u/9341547?v=4","gravatar_id":"","url":"https://api.github.com/users/bandre-ucar","html_url":"https://github.com/bandre-ucar","followers_url":"https://api.github.com/users/bandre-ucar/followers","following_url":"https://api.github.com/users/bandre-ucar/following{/other_user}","gists_url":"https://api.github.com/users/bandre-ucar/gists{/gist_id}","starred_url":"https://api.github.com/users/bandre-ucar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bandre-ucar/subscriptions","organizations_url":"https://api.github.com/users/bandre-ucar/orgs","repos_url":"https://api.github.com/users/bandre-ucar/repos","events_url":"https://api.github.com/users/bandre-ucar/events{/privacy}","received_events_url":"https://api.github.com/users/bandre-ucar/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/bandre-ucar/junk-issues/milestones/1","html_url":"https://github.com/bandre-ucar/junk-issues/milestone/1","labels_url":"https://api.github.com/repos/bandre-ucar/junk-issues/milestones/1/labels","id":2895337,"number":1,"title":"clm5","description":null,"creator":{"login":"bandre-ucar","id":9341547,"avatar_url":"https://avatars2.githubusercontent.com/u/9341547?v=4","gravatar_id":"","url":"https://api.github.com/users/bandre-ucar","html_url":"https://github.com/bandre-ucar","followers_url":"https://api.github.com/users/bandre-ucar/followers","following_url":"https://api.github.com/users/bandre-ucar/following{/other_user}","gists_url":"https://api.github.com/users/bandre-ucar/gists{/gist_id}","starred_url":"https://api.github.com/users/bandre-ucar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bandre-ucar/subscriptions","organizations_url":"https://api.github.com/users/bandre-ucar/orgs","repos_url":"https://api.github.com/users/bandre-ucar/repos","events_url":"https://api.github.com/users/bandre-ucar/events{/privacy}","received_events_url":"https://api.github.com/users/bandre-ucar/received_events","type":"User","site_admin":false},"open_issues":45,"closed_issues":0,"state":"open","created_at":"2017-11-07T21:00:12Z","updated_at":"2017-11-07T21:11:44Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2017-11-07T21:11:44Z","updated_at":"2017-11-07T21:11:44Z","closed_at":null,"author_association":"OWNER","body":"**Bill Sacks < sacks > - 2016-12-05 15:07:27 -0700**\n**Bugzilla Id:** 2385\n**Bugzilla Blocks:**  None, \n**Bugzilla Depends:**  None, \n**Bugzilla CC:**  andre,  rfisher, \n**Bugzilla Attachment:**  None\n\nHere are some notes from March 28, 2013, about what I thought would need to change once we were ready to set create_crop_landunit to true always. I'm not sure how much here is still correct, relevant, or necessary. I can dig up my other notes that are referenced here if they would be helpful:\n\n\nOnce dynamic landunits are in place, we can always use create_crop_landunit=true. So far this hasn't been possible, because we need to maintain create_crop_landunit=false when doing transient landcover change (because otherwise changing crop area would imply changing landunit areas, which so far hasn't been allowed).\n\nHere are some things that will need to be done to accomplish this:\n\n• In mkpftMod: mkpftInit: Change setting of num_natpft & num_cft in the case numpft == numstdpft\n\t- we will now ALWAYS have num_natpft = numstdpft - numstdcft, and num_cft = numpft - num_natpft. \n\t- so we can get rid of the conditional that sets num_natpft and num_cft\n\t- see May 14, 2013 notes in Changing weights specification in surface dataset for diffs needed for this (mkpftMod.F90 changes under \"Making surface datasets for running with my new code\")\n\n\n\tI'm not sure if we're still allowing the use of raw datasets with just the 16 standard PFTs. I know we're allowing that for the transient pft dataset, but I'm not sure about the static-in-time dataset. But it might be irrelevant... with the above change, we might be handling things the same in the code regardless of the number of PFTs on the dataset, at least with respect to the static-in-time datasets (see below for notes on the transient dataset)\n\n• Need PCT_CROP to be time-varying on the pftdyn dataset. \n\nWhen transient pft info comes from a file with just the 17 pfts (as it currently does), this would be interpreted as: PFTs 0-14 treated as before. Assuming that PFT #16 is always 0%, then PCT_CFT can stay fixed in time (for surface datasets with generic crop: always 100% PFT #15; for surface datasets with specific crops: whatever is determined from the raw data file); PFT #15 will determine PCT_CROP through time.\n\nTo summarize: We'll have the following on the pftdyn dataset:\n- PCT_NATVEG: no time dimension (essentially ignored for transient runs -- that's the whole point of my refactoring)\n- PCT_CROP: varies in time\n- PCT_PFT: varies in time\n- PCT_CFT: no time dimension, at least for now\n\n• Making sure transient pfts are handled right with respect to crops\n\n- Make sure that the new formulation creates transient datasets correctly. \n\t- In particular: it sounds like the transient raw dataset format won't change. So, I think we can interpret the % crop in the transient raw dataset to be the crop landunit area -- and then have the individual crop areas (as % of landunit) stay fixed (see also Surface dataset meeting 6-15-12)\n\nNOTE: there may be conflicts between this bullet and notes in the previous bullet... need to figure out how exactly we should handle transient pfts now:\n\t- can we have the case where the static dataset has 24 pfts but transient has 16?\n\t- If so, confirm how this should be handled"}}
{"actor":{"display_login":"bandre-ucar"}}