{"action":"closed","number":2429,"pull_request":{"url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/2429","id":149374874,"html_url":"https://github.com/aio-libs/aiohttp/pull/2429","diff_url":"https://github.com/aio-libs/aiohttp/pull/2429.diff","patch_url":"https://github.com/aio-libs/aiohttp/pull/2429.patch","issue_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/2429","number":2429,"state":"closed","locked":false,"title":"Client signals #2313","user":{"login":"pfreixes","id":1226121,"avatar_url":"https://avatars0.githubusercontent.com/u/1226121?v=4","gravatar_id":"","url":"https://api.github.com/users/pfreixes","html_url":"https://github.com/pfreixes","followers_url":"https://api.github.com/users/pfreixes/followers","following_url":"https://api.github.com/users/pfreixes/following{/other_user}","gists_url":"https://api.github.com/users/pfreixes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfreixes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfreixes/subscriptions","organizations_url":"https://api.github.com/users/pfreixes/orgs","repos_url":"https://api.github.com/users/pfreixes/repos","events_url":"https://api.github.com/users/pfreixes/events{/privacy}","received_events_url":"https://api.github.com/users/pfreixes/received_events","type":"User","site_admin":false},"body":"\r\n## What do these changes do?\r\n\r\nImplementation of the client signals exposed by the `ClientSession`\r\nclass, to get a list of the all signals implementation please visit\r\nthe documentation.\r\n\r\n## Are there changes in behavior for the user?\r\n\r\nYes\r\n\r\n## Related issue number\r\n\r\n#2313 \r\n\r\n## Checklist\r\n\r\n- [x] I think the code is well written\r\n- [x] Unit tests for the changes exist\r\n- [x] Documentation reflects the changes\r\n- [ ] If you provide code modification, please add yourself to `CONTRIBUTORS.txt`\r\n  * The format is &lt;Name&gt; &lt;Surname&gt;.\r\n  * Please keep alphabetical order, the file is sorted by names. \r\n- [ ] Add a new news fragment into the `changes` folder\r\n  * name it `<issue_id>.<type>` for example (588.bug)\r\n  * if you don't have an `issue_id` change it to the pr id after creating the pr\r\n  * ensure type is one of the following:\r\n    * `.feature`: Signifying a new feature.\r\n    * `.bugfix`: Signifying a bug fix.\r\n    * `.doc`: Signifying a documentation improvement.\r\n    * `.removal`: Signifying a deprecation or removal of public API.\r\n    * `.misc`: A ticket has been closed, but it is not of interest to users.\r\n  * Make sure to use full sentences with correct case and punctuation, for example: \"Fix issue with non-ascii contents in doctest text files.\"\r\n","created_at":"2017-10-29T08:58:14Z","updated_at":"2017-11-18T16:59:41Z","closed_at":"2017-11-18T16:59:41Z","merged_at":"2017-11-18T16:59:41Z","merge_commit_sha":"ca8878a53df18250dd12c770e47c4ea4b41d353f","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/2429/commits","review_comments_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/2429/comments","review_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/2429/comments","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/031bb3b50fade18630093a31d8b91fd913a2faee","head":{"label":"pfreixes:clientsession_signals","ref":"clientsession_signals","sha":"031bb3b50fade18630093a31d8b91fd913a2faee","user":{"login":"pfreixes","id":1226121,"avatar_url":"https://avatars0.githubusercontent.com/u/1226121?v=4","gravatar_id":"","url":"https://api.github.com/users/pfreixes","html_url":"https://github.com/pfreixes","followers_url":"https://api.github.com/users/pfreixes/followers","following_url":"https://api.github.com/users/pfreixes/following{/other_user}","gists_url":"https://api.github.com/users/pfreixes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfreixes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfreixes/subscriptions","organizations_url":"https://api.github.com/users/pfreixes/orgs","repos_url":"https://api.github.com/users/pfreixes/repos","events_url":"https://api.github.com/users/pfreixes/events{/privacy}","received_events_url":"https://api.github.com/users/pfreixes/received_events","type":"User","site_admin":false},"repo":{"id":63355624,"name":"aiohttp","full_name":"pfreixes/aiohttp","owner":{"login":"pfreixes","id":1226121,"avatar_url":"https://avatars0.githubusercontent.com/u/1226121?v=4","gravatar_id":"","url":"https://api.github.com/users/pfreixes","html_url":"https://github.com/pfreixes","followers_url":"https://api.github.com/users/pfreixes/followers","following_url":"https://api.github.com/users/pfreixes/following{/other_user}","gists_url":"https://api.github.com/users/pfreixes/gists{/gist_id}","starred_url":"https://api.github.com/users/pfreixes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfreixes/subscriptions","organizations_url":"https://api.github.com/users/pfreixes/orgs","repos_url":"https://api.github.com/users/pfreixes/repos","events_url":"https://api.github.com/users/pfreixes/events{/privacy}","received_events_url":"https://api.github.com/users/pfreixes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pfreixes/aiohttp","description":"http client/server for asyncio (PEP-3156)","fork":true,"url":"https://api.github.com/repos/pfreixes/aiohttp","forks_url":"https://api.github.com/repos/pfreixes/aiohttp/forks","keys_url":"https://api.github.com/repos/pfreixes/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pfreixes/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pfreixes/aiohttp/teams","hooks_url":"https://api.github.com/repos/pfreixes/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/pfreixes/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/pfreixes/aiohttp/events","assignees_url":"https://api.github.com/repos/pfreixes/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/pfreixes/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/pfreixes/aiohttp/tags","blobs_url":"https://api.github.com/repos/pfreixes/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pfreixes/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pfreixes/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/pfreixes/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pfreixes/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/pfreixes/aiohttp/languages","stargazers_url":"https://api.github.com/repos/pfreixes/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/pfreixes/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/pfreixes/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/pfreixes/aiohttp/subscription","commits_url":"https://api.github.com/repos/pfreixes/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/pfreixes/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/pfreixes/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/pfreixes/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/pfreixes/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/pfreixes/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pfreixes/aiohttp/merges","archive_url":"https://api.github.com/repos/pfreixes/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pfreixes/aiohttp/downloads","issues_url":"https://api.github.com/repos/pfreixes/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/pfreixes/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/pfreixes/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/pfreixes/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pfreixes/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/pfreixes/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/pfreixes/aiohttp/deployments","created_at":"2016-07-14T17:19:52Z","updated_at":"2016-07-14T17:19:54Z","pushed_at":"2017-11-18T14:54:03Z","git_url":"git://github.com/pfreixes/aiohttp.git","ssh_url":"git@github.com:pfreixes/aiohttp.git","clone_url":"https://github.com/pfreixes/aiohttp.git","svn_url":"https://github.com/pfreixes/aiohttp","homepage":"http://aiohttp.readthedocs.io","size":11283,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aio-libs:master","ref":"master","sha":"992499d38b0dde841eee63393c461cdc1e1b5453","user":{"login":"aio-libs","id":7049303,"avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"repo":{"id":13258039,"name":"aiohttp","full_name":"aio-libs/aiohttp","owner":{"login":"aio-libs","id":7049303,"avatar_url":"https://avatars2.githubusercontent.com/u/7049303?v=4","gravatar_id":"","url":"https://api.github.com/users/aio-libs","html_url":"https://github.com/aio-libs","followers_url":"https://api.github.com/users/aio-libs/followers","following_url":"https://api.github.com/users/aio-libs/following{/other_user}","gists_url":"https://api.github.com/users/aio-libs/gists{/gist_id}","starred_url":"https://api.github.com/users/aio-libs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aio-libs/subscriptions","organizations_url":"https://api.github.com/users/aio-libs/orgs","repos_url":"https://api.github.com/users/aio-libs/repos","events_url":"https://api.github.com/users/aio-libs/events{/privacy}","received_events_url":"https://api.github.com/users/aio-libs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aio-libs/aiohttp","description":"Async http client/server framework (asyncio) ","fork":false,"url":"https://api.github.com/repos/aio-libs/aiohttp","forks_url":"https://api.github.com/repos/aio-libs/aiohttp/forks","keys_url":"https://api.github.com/repos/aio-libs/aiohttp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aio-libs/aiohttp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aio-libs/aiohttp/teams","hooks_url":"https://api.github.com/repos/aio-libs/aiohttp/hooks","issue_events_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/events{/number}","events_url":"https://api.github.com/repos/aio-libs/aiohttp/events","assignees_url":"https://api.github.com/repos/aio-libs/aiohttp/assignees{/user}","branches_url":"https://api.github.com/repos/aio-libs/aiohttp/branches{/branch}","tags_url":"https://api.github.com/repos/aio-libs/aiohttp/tags","blobs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aio-libs/aiohttp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aio-libs/aiohttp/git/refs{/sha}","trees_url":"https://api.github.com/repos/aio-libs/aiohttp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aio-libs/aiohttp/statuses/{sha}","languages_url":"https://api.github.com/repos/aio-libs/aiohttp/languages","stargazers_url":"https://api.github.com/repos/aio-libs/aiohttp/stargazers","contributors_url":"https://api.github.com/repos/aio-libs/aiohttp/contributors","subscribers_url":"https://api.github.com/repos/aio-libs/aiohttp/subscribers","subscription_url":"https://api.github.com/repos/aio-libs/aiohttp/subscription","commits_url":"https://api.github.com/repos/aio-libs/aiohttp/commits{/sha}","git_commits_url":"https://api.github.com/repos/aio-libs/aiohttp/git/commits{/sha}","comments_url":"https://api.github.com/repos/aio-libs/aiohttp/comments{/number}","issue_comment_url":"https://api.github.com/repos/aio-libs/aiohttp/issues/comments{/number}","contents_url":"https://api.github.com/repos/aio-libs/aiohttp/contents/{+path}","compare_url":"https://api.github.com/repos/aio-libs/aiohttp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aio-libs/aiohttp/merges","archive_url":"https://api.github.com/repos/aio-libs/aiohttp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aio-libs/aiohttp/downloads","issues_url":"https://api.github.com/repos/aio-libs/aiohttp/issues{/number}","pulls_url":"https://api.github.com/repos/aio-libs/aiohttp/pulls{/number}","milestones_url":"https://api.github.com/repos/aio-libs/aiohttp/milestones{/number}","notifications_url":"https://api.github.com/repos/aio-libs/aiohttp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aio-libs/aiohttp/labels{/name}","releases_url":"https://api.github.com/repos/aio-libs/aiohttp/releases{/id}","deployments_url":"https://api.github.com/repos/aio-libs/aiohttp/deployments","created_at":"2013-10-01T23:04:01Z","updated_at":"2017-11-18T13:36:16Z","pushed_at":"2017-11-18T16:59:41Z","git_url":"git://github.com/aio-libs/aiohttp.git","ssh_url":"git@github.com:aio-libs/aiohttp.git","clone_url":"https://github.com/aio-libs/aiohttp.git","svn_url":"https://github.com/aio-libs/aiohttp","homepage":"http://docs.aiohttp.org","size":11053,"stargazers_count":4043,"watchers_count":4043,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":713,"mirror_url":null,"archived":false,"open_issues_count":130,"forks":713,"open_issues":130,"watchers":4043,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/2429"},"html":{"href":"https://github.com/aio-libs/aiohttp/pull/2429"},"issue":{"href":"https://api.github.com/repos/aio-libs/aiohttp/issues/2429"},"comments":{"href":"https://api.github.com/repos/aio-libs/aiohttp/issues/2429/comments"},"review_comments":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/2429/comments"},"review_comment":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aio-libs/aiohttp/pulls/2429/commits"},"statuses":{"href":"https://api.github.com/repos/aio-libs/aiohttp/statuses/031bb3b50fade18630093a31d8b91fd913a2faee"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"asvetlov","id":356399,"avatar_url":"https://avatars0.githubusercontent.com/u/356399?v=4","gravatar_id":"","url":"https://api.github.com/users/asvetlov","html_url":"https://github.com/asvetlov","followers_url":"https://api.github.com/users/asvetlov/followers","following_url":"https://api.github.com/users/asvetlov/following{/other_user}","gists_url":"https://api.github.com/users/asvetlov/gists{/gist_id}","starred_url":"https://api.github.com/users/asvetlov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asvetlov/subscriptions","organizations_url":"https://api.github.com/users/asvetlov/orgs","repos_url":"https://api.github.com/users/asvetlov/repos","events_url":"https://api.github.com/users/asvetlov/events{/privacy}","received_events_url":"https://api.github.com/users/asvetlov/received_events","type":"User","site_admin":false},"comments":24,"review_comments":35,"maintainer_can_modify":false,"commits":27,"additions":1199,"deletions":32,"changed_files":16}}
{"actor":{"display_login":"asvetlov"}}