{"action":"opened","number":238,"pull_request":{"url":"https://api.github.com/repos/shader-slang/slang/pulls/238","id":149593244,"html_url":"https://github.com/shader-slang/slang/pull/238","diff_url":"https://github.com/shader-slang/slang/pull/238.diff","patch_url":"https://github.com/shader-slang/slang/pull/238.patch","issue_url":"https://api.github.com/repos/shader-slang/slang/issues/238","number":238,"state":"open","locked":false,"title":"Fix output for type cast when checking fails","user":{"login":"tfoleyNV","id":10618364,"avatar_url":"https://avatars2.githubusercontent.com/u/10618364?v=4","gravatar_id":"","url":"https://api.github.com/users/tfoleyNV","html_url":"https://github.com/tfoleyNV","followers_url":"https://api.github.com/users/tfoleyNV/followers","following_url":"https://api.github.com/users/tfoleyNV/following{/other_user}","gists_url":"https://api.github.com/users/tfoleyNV/gists{/gist_id}","starred_url":"https://api.github.com/users/tfoleyNV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfoleyNV/subscriptions","organizations_url":"https://api.github.com/users/tfoleyNV/orgs","repos_url":"https://api.github.com/users/tfoleyNV/repos","events_url":"https://api.github.com/users/tfoleyNV/events{/privacy}","received_events_url":"https://api.github.com/users/tfoleyNV/received_events","type":"User","site_admin":false},"body":"Fixes #237\r\n\r\nThere were some cases where we would try to emit an `ErrorType` to the output HLSL, which obviously isn't allowed. This change tries to avoid emitting error types, and instead use the original expression when it is available.\r\n\r\nI tried adding a test case for the change, but I can't convince Slang to output matching line numbers for the error message; it seems like more work is needed on that front.","created_at":"2017-10-30T17:53:01Z","updated_at":"2017-10-30T17:53:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/shader-slang/slang/pulls/238/commits","review_comments_url":"https://api.github.com/repos/shader-slang/slang/pulls/238/comments","review_comment_url":"https://api.github.com/repos/shader-slang/slang/pulls/comments{/number}","comments_url":"https://api.github.com/repos/shader-slang/slang/issues/238/comments","statuses_url":"https://api.github.com/repos/shader-slang/slang/statuses/bb00f190c384188d980a60a0ce1c39b5f27c4161","head":{"label":"tfoleyNV:gh-237","ref":"gh-237","sha":"bb00f190c384188d980a60a0ce1c39b5f27c4161","user":{"login":"tfoleyNV","id":10618364,"avatar_url":"https://avatars2.githubusercontent.com/u/10618364?v=4","gravatar_id":"","url":"https://api.github.com/users/tfoleyNV","html_url":"https://github.com/tfoleyNV","followers_url":"https://api.github.com/users/tfoleyNV/followers","following_url":"https://api.github.com/users/tfoleyNV/following{/other_user}","gists_url":"https://api.github.com/users/tfoleyNV/gists{/gist_id}","starred_url":"https://api.github.com/users/tfoleyNV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfoleyNV/subscriptions","organizations_url":"https://api.github.com/users/tfoleyNV/orgs","repos_url":"https://api.github.com/users/tfoleyNV/repos","events_url":"https://api.github.com/users/tfoleyNV/events{/privacy}","received_events_url":"https://api.github.com/users/tfoleyNV/received_events","type":"User","site_admin":false},"repo":{"id":94112578,"name":"slang","full_name":"tfoleyNV/slang","owner":{"login":"tfoleyNV","id":10618364,"avatar_url":"https://avatars2.githubusercontent.com/u/10618364?v=4","gravatar_id":"","url":"https://api.github.com/users/tfoleyNV","html_url":"https://github.com/tfoleyNV","followers_url":"https://api.github.com/users/tfoleyNV/followers","following_url":"https://api.github.com/users/tfoleyNV/following{/other_user}","gists_url":"https://api.github.com/users/tfoleyNV/gists{/gist_id}","starred_url":"https://api.github.com/users/tfoleyNV/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tfoleyNV/subscriptions","organizations_url":"https://api.github.com/users/tfoleyNV/orgs","repos_url":"https://api.github.com/users/tfoleyNV/repos","events_url":"https://api.github.com/users/tfoleyNV/events{/privacy}","received_events_url":"https://api.github.com/users/tfoleyNV/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tfoleyNV/slang","description":"Making it easier to work with shaders","fork":true,"url":"https://api.github.com/repos/tfoleyNV/slang","forks_url":"https://api.github.com/repos/tfoleyNV/slang/forks","keys_url":"https://api.github.com/repos/tfoleyNV/slang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tfoleyNV/slang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tfoleyNV/slang/teams","hooks_url":"https://api.github.com/repos/tfoleyNV/slang/hooks","issue_events_url":"https://api.github.com/repos/tfoleyNV/slang/issues/events{/number}","events_url":"https://api.github.com/repos/tfoleyNV/slang/events","assignees_url":"https://api.github.com/repos/tfoleyNV/slang/assignees{/user}","branches_url":"https://api.github.com/repos/tfoleyNV/slang/branches{/branch}","tags_url":"https://api.github.com/repos/tfoleyNV/slang/tags","blobs_url":"https://api.github.com/repos/tfoleyNV/slang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tfoleyNV/slang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tfoleyNV/slang/git/refs{/sha}","trees_url":"https://api.github.com/repos/tfoleyNV/slang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tfoleyNV/slang/statuses/{sha}","languages_url":"https://api.github.com/repos/tfoleyNV/slang/languages","stargazers_url":"https://api.github.com/repos/tfoleyNV/slang/stargazers","contributors_url":"https://api.github.com/repos/tfoleyNV/slang/contributors","subscribers_url":"https://api.github.com/repos/tfoleyNV/slang/subscribers","subscription_url":"https://api.github.com/repos/tfoleyNV/slang/subscription","commits_url":"https://api.github.com/repos/tfoleyNV/slang/commits{/sha}","git_commits_url":"https://api.github.com/repos/tfoleyNV/slang/git/commits{/sha}","comments_url":"https://api.github.com/repos/tfoleyNV/slang/comments{/number}","issue_comment_url":"https://api.github.com/repos/tfoleyNV/slang/issues/comments{/number}","contents_url":"https://api.github.com/repos/tfoleyNV/slang/contents/{+path}","compare_url":"https://api.github.com/repos/tfoleyNV/slang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tfoleyNV/slang/merges","archive_url":"https://api.github.com/repos/tfoleyNV/slang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tfoleyNV/slang/downloads","issues_url":"https://api.github.com/repos/tfoleyNV/slang/issues{/number}","pulls_url":"https://api.github.com/repos/tfoleyNV/slang/pulls{/number}","milestones_url":"https://api.github.com/repos/tfoleyNV/slang/milestones{/number}","notifications_url":"https://api.github.com/repos/tfoleyNV/slang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tfoleyNV/slang/labels{/name}","releases_url":"https://api.github.com/repos/tfoleyNV/slang/releases{/id}","deployments_url":"https://api.github.com/repos/tfoleyNV/slang/deployments","created_at":"2017-06-12T15:36:58Z","updated_at":"2017-06-12T15:37:01Z","pushed_at":"2017-10-30T17:51:25Z","git_url":"git://github.com/tfoleyNV/slang.git","ssh_url":"git@github.com:tfoleyNV/slang.git","clone_url":"https://github.com/tfoleyNV/slang.git","svn_url":"https://github.com/tfoleyNV/slang","homepage":null,"size":2685,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"shader-slang:master","ref":"master","sha":"4ab545bcd0716cc3f2da432a921c1f53fdce7925","user":{"login":"shader-slang","id":29205606,"avatar_url":"https://avatars1.githubusercontent.com/u/29205606?v=4","gravatar_id":"","url":"https://api.github.com/users/shader-slang","html_url":"https://github.com/shader-slang","followers_url":"https://api.github.com/users/shader-slang/followers","following_url":"https://api.github.com/users/shader-slang/following{/other_user}","gists_url":"https://api.github.com/users/shader-slang/gists{/gist_id}","starred_url":"https://api.github.com/users/shader-slang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shader-slang/subscriptions","organizations_url":"https://api.github.com/users/shader-slang/orgs","repos_url":"https://api.github.com/users/shader-slang/repos","events_url":"https://api.github.com/users/shader-slang/events{/privacy}","received_events_url":"https://api.github.com/users/shader-slang/received_events","type":"Organization","site_admin":false},"repo":{"id":93882897,"name":"slang","full_name":"shader-slang/slang","owner":{"login":"shader-slang","id":29205606,"avatar_url":"https://avatars1.githubusercontent.com/u/29205606?v=4","gravatar_id":"","url":"https://api.github.com/users/shader-slang","html_url":"https://github.com/shader-slang","followers_url":"https://api.github.com/users/shader-slang/followers","following_url":"https://api.github.com/users/shader-slang/following{/other_user}","gists_url":"https://api.github.com/users/shader-slang/gists{/gist_id}","starred_url":"https://api.github.com/users/shader-slang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shader-slang/subscriptions","organizations_url":"https://api.github.com/users/shader-slang/orgs","repos_url":"https://api.github.com/users/shader-slang/repos","events_url":"https://api.github.com/users/shader-slang/events{/privacy}","received_events_url":"https://api.github.com/users/shader-slang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/shader-slang/slang","description":"Making it easier to work with shaders","fork":false,"url":"https://api.github.com/repos/shader-slang/slang","forks_url":"https://api.github.com/repos/shader-slang/slang/forks","keys_url":"https://api.github.com/repos/shader-slang/slang/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shader-slang/slang/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shader-slang/slang/teams","hooks_url":"https://api.github.com/repos/shader-slang/slang/hooks","issue_events_url":"https://api.github.com/repos/shader-slang/slang/issues/events{/number}","events_url":"https://api.github.com/repos/shader-slang/slang/events","assignees_url":"https://api.github.com/repos/shader-slang/slang/assignees{/user}","branches_url":"https://api.github.com/repos/shader-slang/slang/branches{/branch}","tags_url":"https://api.github.com/repos/shader-slang/slang/tags","blobs_url":"https://api.github.com/repos/shader-slang/slang/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shader-slang/slang/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shader-slang/slang/git/refs{/sha}","trees_url":"https://api.github.com/repos/shader-slang/slang/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shader-slang/slang/statuses/{sha}","languages_url":"https://api.github.com/repos/shader-slang/slang/languages","stargazers_url":"https://api.github.com/repos/shader-slang/slang/stargazers","contributors_url":"https://api.github.com/repos/shader-slang/slang/contributors","subscribers_url":"https://api.github.com/repos/shader-slang/slang/subscribers","subscription_url":"https://api.github.com/repos/shader-slang/slang/subscription","commits_url":"https://api.github.com/repos/shader-slang/slang/commits{/sha}","git_commits_url":"https://api.github.com/repos/shader-slang/slang/git/commits{/sha}","comments_url":"https://api.github.com/repos/shader-slang/slang/comments{/number}","issue_comment_url":"https://api.github.com/repos/shader-slang/slang/issues/comments{/number}","contents_url":"https://api.github.com/repos/shader-slang/slang/contents/{+path}","compare_url":"https://api.github.com/repos/shader-slang/slang/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shader-slang/slang/merges","archive_url":"https://api.github.com/repos/shader-slang/slang/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shader-slang/slang/downloads","issues_url":"https://api.github.com/repos/shader-slang/slang/issues{/number}","pulls_url":"https://api.github.com/repos/shader-slang/slang/pulls{/number}","milestones_url":"https://api.github.com/repos/shader-slang/slang/milestones{/number}","notifications_url":"https://api.github.com/repos/shader-slang/slang/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shader-slang/slang/labels{/name}","releases_url":"https://api.github.com/repos/shader-slang/slang/releases{/id}","deployments_url":"https://api.github.com/repos/shader-slang/slang/deployments","created_at":"2017-06-09T17:42:49Z","updated_at":"2017-10-30T16:13:15Z","pushed_at":"2017-10-30T17:27:42Z","git_url":"git://github.com/shader-slang/slang.git","ssh_url":"git@github.com:shader-slang/slang.git","clone_url":"https://github.com/shader-slang/slang.git","svn_url":"https://github.com/shader-slang/slang","homepage":null,"size":2628,"stargazers_count":49,"watchers_count":49,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":44,"forks":3,"open_issues":44,"watchers":49,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/shader-slang/slang/pulls/238"},"html":{"href":"https://github.com/shader-slang/slang/pull/238"},"issue":{"href":"https://api.github.com/repos/shader-slang/slang/issues/238"},"comments":{"href":"https://api.github.com/repos/shader-slang/slang/issues/238/comments"},"review_comments":{"href":"https://api.github.com/repos/shader-slang/slang/pulls/238/comments"},"review_comment":{"href":"https://api.github.com/repos/shader-slang/slang/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/shader-slang/slang/pulls/238/commits"},"statuses":{"href":"https://api.github.com/repos/shader-slang/slang/statuses/bb00f190c384188d980a60a0ce1c39b5f27c4161"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":16,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"tfoleyNV"}}