{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/95073252","pull_request_review_id":15619016,"id":95073252,"diff_hunk":"@@ -0,0 +1,149 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *    http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.spark.sql.execution.datasources\n+\n+import java.util.concurrent.ConcurrentHashMap\n+import java.util.concurrent.atomic.AtomicBoolean\n+\n+import scala.collection.JavaConverters._\n+\n+import com.google.common.cache._\n+import org.apache.hadoop.fs.{FileStatus, Path}\n+\n+import org.apache.spark.internal.Logging\n+import org.apache.spark.metrics.source.HiveCatalogMetrics\n+import org.apache.spark.sql.SparkSession\n+import org.apache.spark.util.{SerializableConfiguration, SizeEstimator}\n+\n+/**\n+ * A cache of the leaf files of partition directories. We cache these files in order to speed\n+ * up iterated queries over the same set of partitions. Otherwise, each query would have to\n+ * hit remote storage in order to gather file statistics for physical planning.\n+ *\n+ * Each resolved catalog table has its own FileStatusCache. When the backing relation for the\n+ * table is refreshed via refreshTable() or refreshByPath(), this cache will be invalidated.\n+ */\n+abstract class FileStatusCache {\n+  /**\n+   * @return the leaf files for the specified path from this cache, or None if not cached.\n+   */\n+  def getLeafFiles(path: Path): Option[Array[FileStatus]] = None\n+\n+  /**\n+   * Saves the given set of leaf files for a path in this cache.\n+   */\n+  def putLeafFiles(path: Path, leafFiles: Array[FileStatus]): Unit\n+\n+  /**\n+   * Invalidates all data held by this cache.\n+   */\n+  def invalidateAll(): Unit\n+}\n+\n+object FileStatusCache {\n+  private var sharedCache: SharedInMemoryCache = null\n+\n+  /**\n+   * @return a new FileStatusCache based on session configuration. Cache memory quota is\n+   *         shared across all clients.\n+   */\n+  def newCache(session: SparkSession): FileStatusCache = {\n+    synchronized {\n+      if (session.sqlContext.conf.filesourcePartitionPruning &&\n+          session.sqlContext.conf.filesourcePartitionFileCacheSize > 0) {","path":"sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileStatusCache.scala","position":68,"original_position":68,"commit_id":"2a965377258d4d77db5a3f00d4257bbacc4a0adb","original_commit_id":"2a965377258d4d77db5a3f00d4257bbacc4a0adb","user":{"login":"gatorsmile","id":11567269,"avatar_url":"https://avatars.githubusercontent.com/u/11567269?v=3","gravatar_id":"","url":"https://api.github.com/users/gatorsmile","html_url":"https://github.com/gatorsmile","followers_url":"https://api.github.com/users/gatorsmile/followers","following_url":"https://api.github.com/users/gatorsmile/following{/other_user}","gists_url":"https://api.github.com/users/gatorsmile/gists{/gist_id}","starred_url":"https://api.github.com/users/gatorsmile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gatorsmile/subscriptions","organizations_url":"https://api.github.com/users/gatorsmile/orgs","repos_url":"https://api.github.com/users/gatorsmile/repos","events_url":"https://api.github.com/users/gatorsmile/events{/privacy}","received_events_url":"https://api.github.com/users/gatorsmile/received_events","type":"User","site_admin":false},"body":"These two conf have to be global and static; otherwise, we might face weird behaviors when different sessions are using/changing different values. Let me submit a PR to improve it.","created_at":"2017-01-08T07:19:41Z","updated_at":"2017-01-08T07:19:41Z","html_url":"https://github.com/apache/spark/pull/15539#discussion_r95073252","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/15539","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/95073252"},"html":{"href":"https://github.com/apache/spark/pull/15539#discussion_r95073252"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/15539"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/15539","id":89920883,"html_url":"https://github.com/apache/spark/pull/15539","diff_url":"https://github.com/apache/spark/pull/15539.diff","patch_url":"https://github.com/apache/spark/pull/15539.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/15539","number":15539,"state":"closed","locked":false,"title":"[SPARK-17994] [SQL] Add back a file status cache for catalog tables","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\n\nIn SPARK-16980, we removed the full in-memory cache of table partitions in favor of loading only needed partitions from the metastore. This greatly improves the initial latency of queries that only read a small fraction of table partitions.\n\nHowever, since the metastore does not store file statistics, we need to discover those from remote storage. With the loss of the in-memory file status cache this has to happen on each query, increasing the latency of repeated queries over the same partitions.\n\nThe proposal is to add back a per-table cache of partition contents, i.e. Map[Path, Array[FileStatus]]. This cache would be retained per-table, and can be invalidated through refreshTable() and refreshByPath(). Unlike the prior cache, it can be incrementally updated as new partitions are read.\n## How was this patch tested?\n\nExisting tests and new tests in `HiveTablePerfStatsSuite`.\n\ncc @mallman \n","created_at":"2016-10-19T00:04:57Z","updated_at":"2017-01-08T07:19:41Z","closed_at":"2016-10-22T14:10:39Z","merged_at":null,"merge_commit_sha":"b02cd025c9da20418f2ca2b58fc53d18768b4dd9","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/15539/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/15539/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/15539/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/2a965377258d4d77db5a3f00d4257bbacc4a0adb","head":{"label":"ericl:meta-cache","ref":"meta-cache","sha":"2a965377258d4d77db5a3f00d4257bbacc4a0adb","user":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"repo":{"id":23644625,"name":"spark","full_name":"ericl/spark","owner":{"login":"ericl","id":14922,"avatar_url":"https://avatars.githubusercontent.com/u/14922?v=3","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ericl/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/ericl/spark","forks_url":"https://api.github.com/repos/ericl/spark/forks","keys_url":"https://api.github.com/repos/ericl/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ericl/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ericl/spark/teams","hooks_url":"https://api.github.com/repos/ericl/spark/hooks","issue_events_url":"https://api.github.com/repos/ericl/spark/issues/events{/number}","events_url":"https://api.github.com/repos/ericl/spark/events","assignees_url":"https://api.github.com/repos/ericl/spark/assignees{/user}","branches_url":"https://api.github.com/repos/ericl/spark/branches{/branch}","tags_url":"https://api.github.com/repos/ericl/spark/tags","blobs_url":"https://api.github.com/repos/ericl/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ericl/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ericl/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/ericl/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ericl/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/ericl/spark/languages","stargazers_url":"https://api.github.com/repos/ericl/spark/stargazers","contributors_url":"https://api.github.com/repos/ericl/spark/contributors","subscribers_url":"https://api.github.com/repos/ericl/spark/subscribers","subscription_url":"https://api.github.com/repos/ericl/spark/subscription","commits_url":"https://api.github.com/repos/ericl/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/ericl/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/ericl/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/ericl/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/ericl/spark/contents/{+path}","compare_url":"https://api.github.com/repos/ericl/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ericl/spark/merges","archive_url":"https://api.github.com/repos/ericl/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ericl/spark/downloads","issues_url":"https://api.github.com/repos/ericl/spark/issues{/number}","pulls_url":"https://api.github.com/repos/ericl/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/ericl/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/ericl/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ericl/spark/labels{/name}","releases_url":"https://api.github.com/repos/ericl/spark/releases{/id}","deployments_url":"https://api.github.com/repos/ericl/spark/deployments","created_at":"2014-09-04T01:48:06Z","updated_at":"2016-07-30T22:03:00Z","pushed_at":"2017-01-06T10:12:20Z","git_url":"git://github.com/ericl/spark.git","ssh_url":"git@github.com:ericl/spark.git","clone_url":"https://github.com/ericl/spark.git","svn_url":"https://github.com/ericl/spark","homepage":null,"size":252052,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"b3b4b9542223de3495a7a7e0dd27634ddb9f929d","user":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars.githubusercontent.com/u/47359?v=3","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2017-01-08T06:29:49Z","pushed_at":"2017-01-08T04:53:25Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":260854,"stargazers_count":11341,"watchers_count":11341,"language":"Scala","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10617,"mirror_url":"git://git.apache.org/spark.git","open_issues_count":442,"forks":10617,"open_issues":442,"watchers":11341,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/15539"},"html":{"href":"https://github.com/apache/spark/pull/15539"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/15539"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/15539/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/15539/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/15539/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/2a965377258d4d77db5a3f00d4257bbacc4a0adb"}}}}
{"actor":{"display_login":"gatorsmile"}}