{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/156127721","pull_request_review_id":82555585,"id":156127721,"diff_hunk":"@@ -153,6 +160,12 @@ def deep_copy(new_attributes = {})\n \n   private\n \n+  def create_association_list(associations_on_dialog_fields, dialog_field_list)\n+    associations_on_dialog_fields.each_with_object({}) do |a, associations|\n+      associations[dialog_field_list.find { |df| df.id == a.trigger_id }.name] = dialog_field_list.select { |df| df.id == a.respond_id }.pluck(:name)","path":"app/models/dialog.rb","position":26,"original_position":26,"commit_id":"a3d02977c255245075cb642d7561c40645406c53","original_commit_id":"a3d02977c255245075cb642d7561c40645406c53","user":{"login":"bdunne","id":651659,"avatar_url":"https://avatars1.githubusercontent.com/u/651659?v=4","gravatar_id":"","url":"https://api.github.com/users/bdunne","html_url":"https://github.com/bdunne","followers_url":"https://api.github.com/users/bdunne/followers","following_url":"https://api.github.com/users/bdunne/following{/other_user}","gists_url":"https://api.github.com/users/bdunne/gists{/gist_id}","starred_url":"https://api.github.com/users/bdunne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdunne/subscriptions","organizations_url":"https://api.github.com/users/bdunne/orgs","repos_url":"https://api.github.com/users/bdunne/repos","events_url":"https://api.github.com/users/bdunne/events{/privacy}","received_events_url":"https://api.github.com/users/bdunne/received_events","type":"User","site_admin":false},"body":"Is this being done in a large transaction or something?","created_at":"2017-12-11T16:39:34Z","updated_at":"2017-12-11T16:39:34Z","html_url":"https://github.com/ManageIQ/manageiq/pull/16606#discussion_r156127721","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16606","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments/156127721"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/16606#discussion_r156127721"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16606"}},"in_reply_to_id":155878413},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16606","id":156754282,"html_url":"https://github.com/ManageIQ/manageiq/pull/16606","diff_url":"https://github.com/ManageIQ/manageiq/pull/16606.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/16606.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16606","number":16606,"state":"open","locked":false,"title":"Adds field associations circular reference check to backend validations","user":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"body":"Dialog field associations are checked for circular references on dialog import but this check needs to also be included in the main dialog validation on save for association creation via the classic ui.","created_at":"2017-12-06T15:09:47Z","updated_at":"2017-12-11T16:39:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d980d054cac9f0169404d2ae9396743455fcee03","assignee":{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars0.githubusercontent.com/u/2591569?v=4","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmcculloug","id":2591569,"avatar_url":"https://avatars0.githubusercontent.com/u/2591569?v=4","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16606/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16606/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/16606/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/a3d02977c255245075cb642d7561c40645406c53","head":{"label":"d-m-u:circular_ref_checker_dialog_field_associations_for_ui","ref":"circular_ref_checker_dialog_field_associations_for_ui","sha":"a3d02977c255245075cb642d7561c40645406c53","user":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"repo":{"id":97605552,"name":"manageiq","full_name":"d-m-u/manageiq","owner":{"login":"d-m-u","id":16326669,"avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/d-m-u/manageiq","description":"ManageIQ Open-Source Management Platform","fork":true,"url":"https://api.github.com/repos/d-m-u/manageiq","forks_url":"https://api.github.com/repos/d-m-u/manageiq/forks","keys_url":"https://api.github.com/repos/d-m-u/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d-m-u/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d-m-u/manageiq/teams","hooks_url":"https://api.github.com/repos/d-m-u/manageiq/hooks","issue_events_url":"https://api.github.com/repos/d-m-u/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/d-m-u/manageiq/events","assignees_url":"https://api.github.com/repos/d-m-u/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/d-m-u/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/d-m-u/manageiq/tags","blobs_url":"https://api.github.com/repos/d-m-u/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d-m-u/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d-m-u/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/d-m-u/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d-m-u/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/d-m-u/manageiq/languages","stargazers_url":"https://api.github.com/repos/d-m-u/manageiq/stargazers","contributors_url":"https://api.github.com/repos/d-m-u/manageiq/contributors","subscribers_url":"https://api.github.com/repos/d-m-u/manageiq/subscribers","subscription_url":"https://api.github.com/repos/d-m-u/manageiq/subscription","commits_url":"https://api.github.com/repos/d-m-u/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/d-m-u/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/d-m-u/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/d-m-u/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/d-m-u/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/d-m-u/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d-m-u/manageiq/merges","archive_url":"https://api.github.com/repos/d-m-u/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d-m-u/manageiq/downloads","issues_url":"https://api.github.com/repos/d-m-u/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/d-m-u/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/d-m-u/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/d-m-u/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d-m-u/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/d-m-u/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/d-m-u/manageiq/deployments","created_at":"2017-07-18T14:05:43Z","updated_at":"2017-07-18T14:05:52Z","pushed_at":"2017-12-08T21:06:22Z","git_url":"git://github.com/d-m-u/manageiq.git","ssh_url":"git@github.com:d-m-u/manageiq.git","clone_url":"https://github.com/d-m-u/manageiq.git","svn_url":"https://github.com/d-m-u/manageiq","homepage":"manageiq.org","size":208182,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"00a2fdc1a7e160fe396fcf8e79b6be860a791e72","user":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":20789757,"name":"manageiq","full_name":"ManageIQ/manageiq","owner":{"login":"ManageIQ","id":1125575,"avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq","description":"ManageIQ Open-Source Management Platform","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq","forks_url":"https://api.github.com/repos/ManageIQ/manageiq/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq/deployments","created_at":"2014-06-13T02:31:26Z","updated_at":"2017-12-10T04:42:42Z","pushed_at":"2017-12-11T16:00:05Z","git_url":"git://github.com/ManageIQ/manageiq.git","ssh_url":"git@github.com:ManageIQ/manageiq.git","clone_url":"https://github.com/ManageIQ/manageiq.git","svn_url":"https://github.com/ManageIQ/manageiq","homepage":"manageiq.org","size":215553,"stargazers_count":567,"watchers_count":567,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":555,"mirror_url":null,"archived":false,"open_issues_count":635,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":555,"open_issues":635,"watchers":567,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16606"},"html":{"href":"https://github.com/ManageIQ/manageiq/pull/16606"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/16606"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/issues/16606/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16606/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq/pulls/16606/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq/statuses/a3d02977c255245075cb642d7561c40645406c53"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bdunne"}}