{"action":"opened","number":1389,"pull_request":{"url":"https://api.github.com/repos/Nukkit/Nukkit/pulls/1389","id":102345257,"html_url":"https://github.com/Nukkit/Nukkit/pull/1389","diff_url":"https://github.com/Nukkit/Nukkit/pull/1389.diff","patch_url":"https://github.com/Nukkit/Nukkit/pull/1389.patch","issue_url":"https://api.github.com/repos/Nukkit/Nukkit/issues/1389","number":1389,"state":"open","locked":false,"title":"Timings refactor","user":{"login":"MrPowerGamerBR","id":9496359,"avatar_url":"https://avatars.githubusercontent.com/u/9496359?v=3","gravatar_id":"","url":"https://api.github.com/users/MrPowerGamerBR","html_url":"https://github.com/MrPowerGamerBR","followers_url":"https://api.github.com/users/MrPowerGamerBR/followers","following_url":"https://api.github.com/users/MrPowerGamerBR/following{/other_user}","gists_url":"https://api.github.com/users/MrPowerGamerBR/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPowerGamerBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPowerGamerBR/subscriptions","organizations_url":"https://api.github.com/users/MrPowerGamerBR/orgs","repos_url":"https://api.github.com/users/MrPowerGamerBR/repos","events_url":"https://api.github.com/users/MrPowerGamerBR/events{/privacy}","received_events_url":"https://api.github.com/users/MrPowerGamerBR/received_events","type":"User","site_admin":false},"body":"Okay, this isn't really a fix, it is actually a refactoring in the Timings v2 related packages.\r\n\r\nTimings was refactored from ```cn.nukkit.timings``` to ```co.aikar.timings```, this WILL break plugins that uses the Timings v2 API, but as far as I know there isn't any public plugins using those APIs, and, even if it does break, the fix is just a package rename, so it is **that** breaking.\r\n\r\nChanged the user agent to Nukkit instead of Sponge because Nukkit is now allowed in @aikar's Timings v2 website.\r\n\r\nAdded the original @aikar's file headers and removed the @author headers for classes from @aikar.\r\n\r\nI think that's it, at least now Nukkit uses the correct Timings v2 user agent instead of borrowing the user agent from Sponge 👍 ","created_at":"2017-01-19T20:46:29Z","updated_at":"2017-01-19T20:46:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Nukkit/Nukkit/pulls/1389/commits","review_comments_url":"https://api.github.com/repos/Nukkit/Nukkit/pulls/1389/comments","review_comment_url":"https://api.github.com/repos/Nukkit/Nukkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Nukkit/Nukkit/issues/1389/comments","statuses_url":"https://api.github.com/repos/Nukkit/Nukkit/statuses/22af4b27d20b4a75744d1bd40802696be62fa9ec","head":{"label":"MrPowerGamerBR:timings-refactor","ref":"timings-refactor","sha":"22af4b27d20b4a75744d1bd40802696be62fa9ec","user":{"login":"MrPowerGamerBR","id":9496359,"avatar_url":"https://avatars.githubusercontent.com/u/9496359?v=3","gravatar_id":"","url":"https://api.github.com/users/MrPowerGamerBR","html_url":"https://github.com/MrPowerGamerBR","followers_url":"https://api.github.com/users/MrPowerGamerBR/followers","following_url":"https://api.github.com/users/MrPowerGamerBR/following{/other_user}","gists_url":"https://api.github.com/users/MrPowerGamerBR/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPowerGamerBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPowerGamerBR/subscriptions","organizations_url":"https://api.github.com/users/MrPowerGamerBR/orgs","repos_url":"https://api.github.com/users/MrPowerGamerBR/repos","events_url":"https://api.github.com/users/MrPowerGamerBR/events{/privacy}","received_events_url":"https://api.github.com/users/MrPowerGamerBR/received_events","type":"User","site_admin":false},"repo":{"id":79492119,"name":"Nukkit","full_name":"MrPowerGamerBR/Nukkit","owner":{"login":"MrPowerGamerBR","id":9496359,"avatar_url":"https://avatars.githubusercontent.com/u/9496359?v=3","gravatar_id":"","url":"https://api.github.com/users/MrPowerGamerBR","html_url":"https://github.com/MrPowerGamerBR","followers_url":"https://api.github.com/users/MrPowerGamerBR/followers","following_url":"https://api.github.com/users/MrPowerGamerBR/following{/other_user}","gists_url":"https://api.github.com/users/MrPowerGamerBR/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPowerGamerBR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPowerGamerBR/subscriptions","organizations_url":"https://api.github.com/users/MrPowerGamerBR/orgs","repos_url":"https://api.github.com/users/MrPowerGamerBR/repos","events_url":"https://api.github.com/users/MrPowerGamerBR/events{/privacy}","received_events_url":"https://api.github.com/users/MrPowerGamerBR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/MrPowerGamerBR/Nukkit","description":"Nukkit is a Nuclear-Powered Server Software For Minecraft: Pocket Edition","fork":true,"url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit","forks_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/forks","keys_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/teams","hooks_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/hooks","issue_events_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/issues/events{/number}","events_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/events","assignees_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/assignees{/user}","branches_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/branches{/branch}","tags_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/tags","blobs_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/statuses/{sha}","languages_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/languages","stargazers_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/stargazers","contributors_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/contributors","subscribers_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/subscribers","subscription_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/subscription","commits_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/contents/{+path}","compare_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/merges","archive_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/downloads","issues_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/issues{/number}","pulls_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/pulls{/number}","milestones_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/milestones{/number}","notifications_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/labels{/name}","releases_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/releases{/id}","deployments_url":"https://api.github.com/repos/MrPowerGamerBR/Nukkit/deployments","created_at":"2017-01-19T20:28:43Z","updated_at":"2017-01-19T20:28:47Z","pushed_at":"2017-01-19T20:45:11Z","git_url":"git://github.com/MrPowerGamerBR/Nukkit.git","ssh_url":"git@github.com:MrPowerGamerBR/Nukkit.git","clone_url":"https://github.com/MrPowerGamerBR/Nukkit.git","svn_url":"https://github.com/MrPowerGamerBR/Nukkit","homepage":"https://nukkit.io","size":9762,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Nukkit:master","ref":"master","sha":"37be4ba52eb3ce9d8b23e237be4c325103b84ead","user":{"login":"Nukkit","id":12780190,"avatar_url":"https://avatars.githubusercontent.com/u/12780190?v=3","gravatar_id":"","url":"https://api.github.com/users/Nukkit","html_url":"https://github.com/Nukkit","followers_url":"https://api.github.com/users/Nukkit/followers","following_url":"https://api.github.com/users/Nukkit/following{/other_user}","gists_url":"https://api.github.com/users/Nukkit/gists{/gist_id}","starred_url":"https://api.github.com/users/Nukkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nukkit/subscriptions","organizations_url":"https://api.github.com/users/Nukkit/orgs","repos_url":"https://api.github.com/users/Nukkit/repos","events_url":"https://api.github.com/users/Nukkit/events{/privacy}","received_events_url":"https://api.github.com/users/Nukkit/received_events","type":"Organization","site_admin":false},"repo":{"id":36117051,"name":"Nukkit","full_name":"Nukkit/Nukkit","owner":{"login":"Nukkit","id":12780190,"avatar_url":"https://avatars.githubusercontent.com/u/12780190?v=3","gravatar_id":"","url":"https://api.github.com/users/Nukkit","html_url":"https://github.com/Nukkit","followers_url":"https://api.github.com/users/Nukkit/followers","following_url":"https://api.github.com/users/Nukkit/following{/other_user}","gists_url":"https://api.github.com/users/Nukkit/gists{/gist_id}","starred_url":"https://api.github.com/users/Nukkit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nukkit/subscriptions","organizations_url":"https://api.github.com/users/Nukkit/orgs","repos_url":"https://api.github.com/users/Nukkit/repos","events_url":"https://api.github.com/users/Nukkit/events{/privacy}","received_events_url":"https://api.github.com/users/Nukkit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Nukkit/Nukkit","description":"Nukkit is a Nuclear-Powered Server Software For Minecraft: Pocket Edition","fork":false,"url":"https://api.github.com/repos/Nukkit/Nukkit","forks_url":"https://api.github.com/repos/Nukkit/Nukkit/forks","keys_url":"https://api.github.com/repos/Nukkit/Nukkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Nukkit/Nukkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Nukkit/Nukkit/teams","hooks_url":"https://api.github.com/repos/Nukkit/Nukkit/hooks","issue_events_url":"https://api.github.com/repos/Nukkit/Nukkit/issues/events{/number}","events_url":"https://api.github.com/repos/Nukkit/Nukkit/events","assignees_url":"https://api.github.com/repos/Nukkit/Nukkit/assignees{/user}","branches_url":"https://api.github.com/repos/Nukkit/Nukkit/branches{/branch}","tags_url":"https://api.github.com/repos/Nukkit/Nukkit/tags","blobs_url":"https://api.github.com/repos/Nukkit/Nukkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Nukkit/Nukkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Nukkit/Nukkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Nukkit/Nukkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Nukkit/Nukkit/statuses/{sha}","languages_url":"https://api.github.com/repos/Nukkit/Nukkit/languages","stargazers_url":"https://api.github.com/repos/Nukkit/Nukkit/stargazers","contributors_url":"https://api.github.com/repos/Nukkit/Nukkit/contributors","subscribers_url":"https://api.github.com/repos/Nukkit/Nukkit/subscribers","subscription_url":"https://api.github.com/repos/Nukkit/Nukkit/subscription","commits_url":"https://api.github.com/repos/Nukkit/Nukkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Nukkit/Nukkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Nukkit/Nukkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Nukkit/Nukkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Nukkit/Nukkit/contents/{+path}","compare_url":"https://api.github.com/repos/Nukkit/Nukkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Nukkit/Nukkit/merges","archive_url":"https://api.github.com/repos/Nukkit/Nukkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Nukkit/Nukkit/downloads","issues_url":"https://api.github.com/repos/Nukkit/Nukkit/issues{/number}","pulls_url":"https://api.github.com/repos/Nukkit/Nukkit/pulls{/number}","milestones_url":"https://api.github.com/repos/Nukkit/Nukkit/milestones{/number}","notifications_url":"https://api.github.com/repos/Nukkit/Nukkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Nukkit/Nukkit/labels{/name}","releases_url":"https://api.github.com/repos/Nukkit/Nukkit/releases{/id}","deployments_url":"https://api.github.com/repos/Nukkit/Nukkit/deployments","created_at":"2015-05-23T09:51:41Z","updated_at":"2017-01-18T09:30:43Z","pushed_at":"2017-01-18T03:52:40Z","git_url":"git://github.com/Nukkit/Nukkit.git","ssh_url":"git@github.com:Nukkit/Nukkit.git","clone_url":"https://github.com/Nukkit/Nukkit.git","svn_url":"https://github.com/Nukkit/Nukkit","homepage":"https://nukkit.io","size":9762,"stargazers_count":372,"watchers_count":372,"language":"Java","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":230,"mirror_url":null,"open_issues_count":91,"forks":230,"open_issues":91,"watchers":372,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Nukkit/Nukkit/pulls/1389"},"html":{"href":"https://github.com/Nukkit/Nukkit/pull/1389"},"issue":{"href":"https://api.github.com/repos/Nukkit/Nukkit/issues/1389"},"comments":{"href":"https://api.github.com/repos/Nukkit/Nukkit/issues/1389/comments"},"review_comments":{"href":"https://api.github.com/repos/Nukkit/Nukkit/pulls/1389/comments"},"review_comment":{"href":"https://api.github.com/repos/Nukkit/Nukkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Nukkit/Nukkit/pulls/1389/commits"},"statuses":{"href":"https://api.github.com/repos/Nukkit/Nukkit/statuses/22af4b27d20b4a75744d1bd40802696be62fa9ec"}},"merged":false,"mergeable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":14746,"deletions":14565,"changed_files":26}}
{"actor":{"display_login":"MrPowerGamerBR"}}