{"action":"created","issue":{"url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/188","repository_url":"https://api.github.com/repos/ipfs/interface-ipfs-core","labels_url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/188/labels{/name}","comments_url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/188/comments","events_url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/188/events","html_url":"https://github.com/ipfs/interface-ipfs-core/pull/188","id":285224678,"number":188,"title":"pubsub makes no guarantee ","user":{"login":"richardschneider","id":631061,"avatar_url":"https://avatars2.githubusercontent.com/u/631061?v=4","gravatar_id":"","url":"https://api.github.com/users/richardschneider","html_url":"https://github.com/richardschneider","followers_url":"https://api.github.com/users/richardschneider/followers","following_url":"https://api.github.com/users/richardschneider/following{/other_user}","gists_url":"https://api.github.com/users/richardschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/richardschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardschneider/subscriptions","organizations_url":"https://api.github.com/users/richardschneider/orgs","repos_url":"https://api.github.com/users/richardschneider/repos","events_url":"https://api.github.com/users/richardschneider/events{/privacy}","received_events_url":"https://api.github.com/users/richardschneider/received_events","type":"User","site_admin":false},"labels":[{"id":428049503,"url":"https://api.github.com/repos/ipfs/interface-ipfs-core/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"richardschneider","id":631061,"avatar_url":"https://avatars2.githubusercontent.com/u/631061?v=4","gravatar_id":"","url":"https://api.github.com/users/richardschneider","html_url":"https://github.com/richardschneider","followers_url":"https://api.github.com/users/richardschneider/followers","following_url":"https://api.github.com/users/richardschneider/following{/other_user}","gists_url":"https://api.github.com/users/richardschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/richardschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardschneider/subscriptions","organizations_url":"https://api.github.com/users/richardschneider/orgs","repos_url":"https://api.github.com/users/richardschneider/repos","events_url":"https://api.github.com/users/richardschneider/events{/privacy}","received_events_url":"https://api.github.com/users/richardschneider/received_events","type":"User","site_admin":false},"assignees":[{"login":"richardschneider","id":631061,"avatar_url":"https://avatars2.githubusercontent.com/u/631061?v=4","gravatar_id":"","url":"https://api.github.com/users/richardschneider","html_url":"https://github.com/richardschneider","followers_url":"https://api.github.com/users/richardschneider/followers","following_url":"https://api.github.com/users/richardschneider/following{/other_user}","gists_url":"https://api.github.com/users/richardschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/richardschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardschneider/subscriptions","organizations_url":"https://api.github.com/users/richardschneider/orgs","repos_url":"https://api.github.com/users/richardschneider/repos","events_url":"https://api.github.com/users/richardschneider/events{/privacy}","received_events_url":"https://api.github.com/users/richardschneider/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-12-30T21:25:26Z","updated_at":"2018-01-01T20:44:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ipfs/interface-ipfs-core/pulls/188","html_url":"https://github.com/ipfs/interface-ipfs-core/pull/188","diff_url":"https://github.com/ipfs/interface-ipfs-core/pull/188.diff","patch_url":"https://github.com/ipfs/interface-ipfs-core/pull/188.patch"},"body":"Skip some tests because pubsub, `go floodsub`, does not make any guarantee on message delivery.\r\n\r\nFirst reported in https://github.com/ipfs/js-ipfs-api/pull/648\r\n```\r\n1) .pubsub multiple nodes connected multiple nodes receive multiple messages:\r\n     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\n\r\n2) .pubsub multiple nodes connected load tests send/receive 10k messages:\r\n     Error: Timeout of 80000ms exceeded. For async tests and hooks, ensure \"done()\" is called; if returning a Promise, ensure it resolves.\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/comments/354675297","html_url":"https://github.com/ipfs/interface-ipfs-core/pull/188#issuecomment-354675297","issue_url":"https://api.github.com/repos/ipfs/interface-ipfs-core/issues/188","id":354675297,"user":{"login":"richardschneider","id":631061,"avatar_url":"https://avatars2.githubusercontent.com/u/631061?v=4","gravatar_id":"","url":"https://api.github.com/users/richardschneider","html_url":"https://github.com/richardschneider","followers_url":"https://api.github.com/users/richardschneider/followers","following_url":"https://api.github.com/users/richardschneider/following{/other_user}","gists_url":"https://api.github.com/users/richardschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/richardschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardschneider/subscriptions","organizations_url":"https://api.github.com/users/richardschneider/orgs","repos_url":"https://api.github.com/users/richardschneider/repos","events_url":"https://api.github.com/users/richardschneider/events{/privacy}","received_events_url":"https://api.github.com/users/richardschneider/received_events","type":"User","site_admin":false},"created_at":"2018-01-01T20:44:18Z","updated_at":"2018-01-01T20:44:18Z","author_association":"CONTRIBUTOR","body":"Took a look at `go-floodsub` and [this code](https://github.com/libp2p/go-floodsub/blob/master/floodsub.go#L418) looks suspicious\r\n\r\n> binary.BigEndian.PutUint64(seqno, uint64(time.Now().UnixNano())) \r\n\r\nDuplicate sequence number can be produced \r\n- if the resolution of the clock is not nanoseconds, or\r\n- mutliple publish events are received within the resolution of the clock\r\n"}}
{"actor":{"display_login":"richardschneider"}}