{"action":"created","comment":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/comments/118956790","pull_request_review_id":40793088,"id":118956790,"diff_hunk":"@@ -137,3 +140,49 @@ fn concurrent_merge() {\n     }\n     assert_eq!(prefixes.len(), 2);\n }\n+\n+#[test]\n+fn merge_exclude_reconnecting_peers() {\n+    let min_section_size = 3;\n+    let network = Network::new(min_section_size, None);\n+    let mut rng = network.new_rng();\n+    let mut nodes = create_connected_nodes_until_split(&network, vec![1, 1], false);\n+    verify_invariant_for_all_nodes(&mut nodes);\n+    rng.shuffle(&mut nodes);\n+\n+    // Choose one sections to drop nodes from.\n+    let prefix_to_drop_from = Prefix::new(1, XorName([0; XOR_NAME_LEN]));\n+\n+    let mut nodes_count = nodes\n+        .iter()\n+        .filter(|node| node.routing_table().our_prefix() == &prefix_to_drop_from)\n+        .count();\n+\n+    // Drop enough nodes (without polling) from the two section to take them just below","path":"tests/mock_crust/merge.rs","position":37,"original_position":37,"commit_id":"0649612394727459fef79ebbec6f71d59ad62598","original_commit_id":"0649612394727459fef79ebbec6f71d59ad62598","user":{"login":"afck","id":7894725,"avatar_url":"https://avatars3.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"body":"`from the two` → `from that`?","created_at":"2017-05-29T15:33:14Z","updated_at":"2017-05-29T15:34:32Z","html_url":"https://github.com/maidsafe/routing/pull/1456#discussion_r118956790","pull_request_url":"https://api.github.com/repos/maidsafe/routing/pulls/1456","_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments/118956790"},"html":{"href":"https://github.com/maidsafe/routing/pull/1456#discussion_r118956790"},"pull_request":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1456"}}},"pull_request":{"url":"https://api.github.com/repos/maidsafe/routing/pulls/1456","id":122909190,"html_url":"https://github.com/maidsafe/routing/pull/1456","diff_url":"https://github.com/maidsafe/routing/pull/1456.diff","patch_url":"https://github.com/maidsafe/routing/pull/1456.patch","issue_url":"https://api.github.com/repos/maidsafe/routing/issues/1456","number":1456,"state":"open","locked":false,"title":"Fixes","user":{"login":"maqi","id":568777,"avatar_url":"https://avatars1.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-05-29T14:53:03Z","updated_at":"2017-05-29T15:34:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b16d42b16242246b3d52e89517f4f36445c85c4","assignee":{"login":"afck","id":7894725,"avatar_url":"https://avatars3.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false},"assignees":[{"login":"afck","id":7894725,"avatar_url":"https://avatars3.githubusercontent.com/u/7894725?v=3","gravatar_id":"","url":"https://api.github.com/users/afck","html_url":"https://github.com/afck","followers_url":"https://api.github.com/users/afck/followers","following_url":"https://api.github.com/users/afck/following{/other_user}","gists_url":"https://api.github.com/users/afck/gists{/gist_id}","starred_url":"https://api.github.com/users/afck/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afck/subscriptions","organizations_url":"https://api.github.com/users/afck/orgs","repos_url":"https://api.github.com/users/afck/repos","events_url":"https://api.github.com/users/afck/events{/privacy}","received_events_url":"https://api.github.com/users/afck/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/maidsafe/routing/pulls/1456/commits","review_comments_url":"https://api.github.com/repos/maidsafe/routing/pulls/1456/comments","review_comment_url":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/maidsafe/routing/issues/1456/comments","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/0649612394727459fef79ebbec6f71d59ad62598","head":{"label":"maqi:fixes","ref":"fixes","sha":"0649612394727459fef79ebbec6f71d59ad62598","user":{"login":"maqi","id":568777,"avatar_url":"https://avatars1.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"repo":{"id":32407025,"name":"routing","full_name":"maqi/routing","owner":{"login":"maqi","id":568777,"avatar_url":"https://avatars1.githubusercontent.com/u/568777?v=3","gravatar_id":"","url":"https://api.github.com/users/maqi","html_url":"https://github.com/maqi","followers_url":"https://api.github.com/users/maqi/followers","following_url":"https://api.github.com/users/maqi/following{/other_user}","gists_url":"https://api.github.com/users/maqi/gists{/gist_id}","starred_url":"https://api.github.com/users/maqi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maqi/subscriptions","organizations_url":"https://api.github.com/users/maqi/orgs","repos_url":"https://api.github.com/users/maqi/repos","events_url":"https://api.github.com/users/maqi/events{/privacy}","received_events_url":"https://api.github.com/users/maqi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/maqi/routing","description":"Routing - specialised storage DHT","fork":true,"url":"https://api.github.com/repos/maqi/routing","forks_url":"https://api.github.com/repos/maqi/routing/forks","keys_url":"https://api.github.com/repos/maqi/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maqi/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maqi/routing/teams","hooks_url":"https://api.github.com/repos/maqi/routing/hooks","issue_events_url":"https://api.github.com/repos/maqi/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maqi/routing/events","assignees_url":"https://api.github.com/repos/maqi/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maqi/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maqi/routing/tags","blobs_url":"https://api.github.com/repos/maqi/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maqi/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maqi/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maqi/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maqi/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maqi/routing/languages","stargazers_url":"https://api.github.com/repos/maqi/routing/stargazers","contributors_url":"https://api.github.com/repos/maqi/routing/contributors","subscribers_url":"https://api.github.com/repos/maqi/routing/subscribers","subscription_url":"https://api.github.com/repos/maqi/routing/subscription","commits_url":"https://api.github.com/repos/maqi/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maqi/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maqi/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maqi/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maqi/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maqi/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maqi/routing/merges","archive_url":"https://api.github.com/repos/maqi/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maqi/routing/downloads","issues_url":"https://api.github.com/repos/maqi/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maqi/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maqi/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maqi/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maqi/routing/labels{/name}","releases_url":"https://api.github.com/repos/maqi/routing/releases{/id}","deployments_url":"https://api.github.com/repos/maqi/routing/deployments","created_at":"2015-03-17T16:51:50Z","updated_at":"2015-03-28T00:22:40Z","pushed_at":"2017-05-29T15:17:56Z","git_url":"git://github.com/maqi/routing.git","ssh_url":"git@github.com:maqi/routing.git","clone_url":"https://github.com/maqi/routing.git","svn_url":"https://github.com/maqi/routing","homepage":null,"size":10986,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"OSX_executable_test"}},"base":{"label":"maidsafe:master","ref":"master","sha":"9d4a6670eb9388f9c4e5a7515093fa3f11625701","user":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars2.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"repo":{"id":31270514,"name":"routing","full_name":"maidsafe/routing","owner":{"login":"maidsafe","id":536423,"avatar_url":"https://avatars2.githubusercontent.com/u/536423?v=3","gravatar_id":"","url":"https://api.github.com/users/maidsafe","html_url":"https://github.com/maidsafe","followers_url":"https://api.github.com/users/maidsafe/followers","following_url":"https://api.github.com/users/maidsafe/following{/other_user}","gists_url":"https://api.github.com/users/maidsafe/gists{/gist_id}","starred_url":"https://api.github.com/users/maidsafe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maidsafe/subscriptions","organizations_url":"https://api.github.com/users/maidsafe/orgs","repos_url":"https://api.github.com/users/maidsafe/repos","events_url":"https://api.github.com/users/maidsafe/events{/privacy}","received_events_url":"https://api.github.com/users/maidsafe/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/maidsafe/routing","description":"Routing - specialised storage DHT","fork":false,"url":"https://api.github.com/repos/maidsafe/routing","forks_url":"https://api.github.com/repos/maidsafe/routing/forks","keys_url":"https://api.github.com/repos/maidsafe/routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/maidsafe/routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/maidsafe/routing/teams","hooks_url":"https://api.github.com/repos/maidsafe/routing/hooks","issue_events_url":"https://api.github.com/repos/maidsafe/routing/issues/events{/number}","events_url":"https://api.github.com/repos/maidsafe/routing/events","assignees_url":"https://api.github.com/repos/maidsafe/routing/assignees{/user}","branches_url":"https://api.github.com/repos/maidsafe/routing/branches{/branch}","tags_url":"https://api.github.com/repos/maidsafe/routing/tags","blobs_url":"https://api.github.com/repos/maidsafe/routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/maidsafe/routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/maidsafe/routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/maidsafe/routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/maidsafe/routing/statuses/{sha}","languages_url":"https://api.github.com/repos/maidsafe/routing/languages","stargazers_url":"https://api.github.com/repos/maidsafe/routing/stargazers","contributors_url":"https://api.github.com/repos/maidsafe/routing/contributors","subscribers_url":"https://api.github.com/repos/maidsafe/routing/subscribers","subscription_url":"https://api.github.com/repos/maidsafe/routing/subscription","commits_url":"https://api.github.com/repos/maidsafe/routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/maidsafe/routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/maidsafe/routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/maidsafe/routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/maidsafe/routing/contents/{+path}","compare_url":"https://api.github.com/repos/maidsafe/routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/maidsafe/routing/merges","archive_url":"https://api.github.com/repos/maidsafe/routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/maidsafe/routing/downloads","issues_url":"https://api.github.com/repos/maidsafe/routing/issues{/number}","pulls_url":"https://api.github.com/repos/maidsafe/routing/pulls{/number}","milestones_url":"https://api.github.com/repos/maidsafe/routing/milestones{/number}","notifications_url":"https://api.github.com/repos/maidsafe/routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/maidsafe/routing/labels{/name}","releases_url":"https://api.github.com/repos/maidsafe/routing/releases{/id}","deployments_url":"https://api.github.com/repos/maidsafe/routing/deployments","created_at":"2015-02-24T16:52:53Z","updated_at":"2017-05-29T14:50:37Z","pushed_at":"2017-05-29T15:17:58Z","git_url":"git://github.com/maidsafe/routing.git","ssh_url":"git@github.com:maidsafe/routing.git","clone_url":"https://github.com/maidsafe/routing.git","svn_url":"https://github.com/maidsafe/routing","homepage":null,"size":111197,"stargazers_count":147,"watchers_count":147,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":43,"mirror_url":null,"open_issues_count":7,"forks":43,"open_issues":7,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1456"},"html":{"href":"https://github.com/maidsafe/routing/pull/1456"},"issue":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1456"},"comments":{"href":"https://api.github.com/repos/maidsafe/routing/issues/1456/comments"},"review_comments":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1456/comments"},"review_comment":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/maidsafe/routing/pulls/1456/commits"},"statuses":{"href":"https://api.github.com/repos/maidsafe/routing/statuses/0649612394727459fef79ebbec6f71d59ad62598"}}}}
{"actor":{"display_login":"afck"}}