{"action":"created","comment":{"url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/comments/118038823","pull_request_review_id":39794812,"id":118038823,"diff_hunk":"@@ -1236,7 +1236,7 @@ component \tpersistent=\"true\"\n \t* Build content cache keys according to sent content object\n \t*/\n \tstring function buildContentCacheKey(){\n-\t\treturn \"cb-content-#cgi.http_host#-#getContentType()#-#getContentID()#-#i18n.getfwLocale()#\";\n+\t\treturn \"cb-content-#cgi.http_host#-#cgi.query_string#-#getContentType()#-#getContentID()#-#i18n.getfwLocale()#\";","path":"modules/contentbox/models/content/BaseContent.cfc","position":5,"original_position":5,"commit_id":"323d1f842acb6b985b5f4460af93a93b9efb3a3c","original_commit_id":"323d1f842acb6b985b5f4460af93a93b9efb3a3c","user":{"login":"lmajano","id":137111,"avatar_url":"https://avatars3.githubusercontent.com/u/137111?v=3","gravatar_id":"","url":"https://api.github.com/users/lmajano","html_url":"https://github.com/lmajano","followers_url":"https://api.github.com/users/lmajano/followers","following_url":"https://api.github.com/users/lmajano/following{/other_user}","gists_url":"https://api.github.com/users/lmajano/gists{/gist_id}","starred_url":"https://api.github.com/users/lmajano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lmajano/subscriptions","organizations_url":"https://api.github.com/users/lmajano/orgs","repos_url":"https://api.github.com/users/lmajano/repos","events_url":"https://api.github.com/users/lmajano/events{/privacy}","received_events_url":"https://api.github.com/users/lmajano/received_events","type":"User","site_admin":false},"body":"Hmm, I am not sure how I feel about this one, since potentially any query string can alter the translation cache.  What is your reasoning behind this?","created_at":"2017-05-23T16:21:01Z","updated_at":"2017-05-23T16:21:08Z","html_url":"https://github.com/Ortus-Solutions/ContentBox/pull/337#discussion_r118038823","pull_request_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/337","_links":{"self":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/comments/118038823"},"html":{"href":"https://github.com/Ortus-Solutions/ContentBox/pull/337#discussion_r118038823"},"pull_request":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/337"}}},"pull_request":{"url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/337","id":121060188,"html_url":"https://github.com/Ortus-Solutions/ContentBox/pull/337","diff_url":"https://github.com/Ortus-Solutions/ContentBox/pull/337.diff","patch_url":"https://github.com/Ortus-Solutions/ContentBox/pull/337.patch","issue_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/issues/337","number":337,"state":"open","locked":false,"title":"Added query string to content cache key","user":{"login":"skeltonm","id":21675653,"avatar_url":"https://avatars3.githubusercontent.com/u/21675653?v=3","gravatar_id":"","url":"https://api.github.com/users/skeltonm","html_url":"https://github.com/skeltonm","followers_url":"https://api.github.com/users/skeltonm/followers","following_url":"https://api.github.com/users/skeltonm/following{/other_user}","gists_url":"https://api.github.com/users/skeltonm/gists{/gist_id}","starred_url":"https://api.github.com/users/skeltonm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeltonm/subscriptions","organizations_url":"https://api.github.com/users/skeltonm/orgs","repos_url":"https://api.github.com/users/skeltonm/repos","events_url":"https://api.github.com/users/skeltonm/events{/privacy}","received_events_url":"https://api.github.com/users/skeltonm/received_events","type":"User","site_admin":false},"body":"Allows for content to be created based on URL parameters, i.e. paging","created_at":"2017-05-17T13:40:44Z","updated_at":"2017-05-23T16:21:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2dcdaae4a4a6ae50d3ba2c3cf56b1ed924ed609a","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/337/commits","review_comments_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/337/comments","review_comment_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/issues/337/comments","statuses_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/statuses/323d1f842acb6b985b5f4460af93a93b9efb3a3c","head":{"label":"skeltonm:development","ref":"development","sha":"323d1f842acb6b985b5f4460af93a93b9efb3a3c","user":{"login":"skeltonm","id":21675653,"avatar_url":"https://avatars3.githubusercontent.com/u/21675653?v=3","gravatar_id":"","url":"https://api.github.com/users/skeltonm","html_url":"https://github.com/skeltonm","followers_url":"https://api.github.com/users/skeltonm/followers","following_url":"https://api.github.com/users/skeltonm/following{/other_user}","gists_url":"https://api.github.com/users/skeltonm/gists{/gist_id}","starred_url":"https://api.github.com/users/skeltonm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeltonm/subscriptions","organizations_url":"https://api.github.com/users/skeltonm/orgs","repos_url":"https://api.github.com/users/skeltonm/repos","events_url":"https://api.github.com/users/skeltonm/events{/privacy}","received_events_url":"https://api.github.com/users/skeltonm/received_events","type":"User","site_admin":false},"repo":{"id":91474889,"name":"ContentBox","full_name":"skeltonm/ContentBox","owner":{"login":"skeltonm","id":21675653,"avatar_url":"https://avatars3.githubusercontent.com/u/21675653?v=3","gravatar_id":"","url":"https://api.github.com/users/skeltonm","html_url":"https://github.com/skeltonm","followers_url":"https://api.github.com/users/skeltonm/followers","following_url":"https://api.github.com/users/skeltonm/following{/other_user}","gists_url":"https://api.github.com/users/skeltonm/gists{/gist_id}","starred_url":"https://api.github.com/users/skeltonm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skeltonm/subscriptions","organizations_url":"https://api.github.com/users/skeltonm/orgs","repos_url":"https://api.github.com/users/skeltonm/repos","events_url":"https://api.github.com/users/skeltonm/events{/privacy}","received_events_url":"https://api.github.com/users/skeltonm/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/skeltonm/ContentBox","description":"Enterprise ColdFusion (CFML) Modular CMS","fork":true,"url":"https://api.github.com/repos/skeltonm/ContentBox","forks_url":"https://api.github.com/repos/skeltonm/ContentBox/forks","keys_url":"https://api.github.com/repos/skeltonm/ContentBox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/skeltonm/ContentBox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/skeltonm/ContentBox/teams","hooks_url":"https://api.github.com/repos/skeltonm/ContentBox/hooks","issue_events_url":"https://api.github.com/repos/skeltonm/ContentBox/issues/events{/number}","events_url":"https://api.github.com/repos/skeltonm/ContentBox/events","assignees_url":"https://api.github.com/repos/skeltonm/ContentBox/assignees{/user}","branches_url":"https://api.github.com/repos/skeltonm/ContentBox/branches{/branch}","tags_url":"https://api.github.com/repos/skeltonm/ContentBox/tags","blobs_url":"https://api.github.com/repos/skeltonm/ContentBox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/skeltonm/ContentBox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/skeltonm/ContentBox/git/refs{/sha}","trees_url":"https://api.github.com/repos/skeltonm/ContentBox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/skeltonm/ContentBox/statuses/{sha}","languages_url":"https://api.github.com/repos/skeltonm/ContentBox/languages","stargazers_url":"https://api.github.com/repos/skeltonm/ContentBox/stargazers","contributors_url":"https://api.github.com/repos/skeltonm/ContentBox/contributors","subscribers_url":"https://api.github.com/repos/skeltonm/ContentBox/subscribers","subscription_url":"https://api.github.com/repos/skeltonm/ContentBox/subscription","commits_url":"https://api.github.com/repos/skeltonm/ContentBox/commits{/sha}","git_commits_url":"https://api.github.com/repos/skeltonm/ContentBox/git/commits{/sha}","comments_url":"https://api.github.com/repos/skeltonm/ContentBox/comments{/number}","issue_comment_url":"https://api.github.com/repos/skeltonm/ContentBox/issues/comments{/number}","contents_url":"https://api.github.com/repos/skeltonm/ContentBox/contents/{+path}","compare_url":"https://api.github.com/repos/skeltonm/ContentBox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/skeltonm/ContentBox/merges","archive_url":"https://api.github.com/repos/skeltonm/ContentBox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/skeltonm/ContentBox/downloads","issues_url":"https://api.github.com/repos/skeltonm/ContentBox/issues{/number}","pulls_url":"https://api.github.com/repos/skeltonm/ContentBox/pulls{/number}","milestones_url":"https://api.github.com/repos/skeltonm/ContentBox/milestones{/number}","notifications_url":"https://api.github.com/repos/skeltonm/ContentBox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/skeltonm/ContentBox/labels{/name}","releases_url":"https://api.github.com/repos/skeltonm/ContentBox/releases{/id}","deployments_url":"https://api.github.com/repos/skeltonm/ContentBox/deployments","created_at":"2017-05-16T15:34:08Z","updated_at":"2017-05-16T15:34:14Z","pushed_at":"2017-05-23T16:08:47Z","git_url":"git://github.com/skeltonm/ContentBox.git","ssh_url":"git@github.com:skeltonm/ContentBox.git","clone_url":"https://github.com/skeltonm/ContentBox.git","svn_url":"https://github.com/skeltonm/ContentBox","homepage":"http://www.ortussolutions.com/products/contentbox","size":186323,"stargazers_count":0,"watchers_count":0,"language":"ColdFusion","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"Ortus-Solutions:development","ref":"development","sha":"3e5a4bf198bb72c4ad179fdaa72f3825c5654e04","user":{"login":"Ortus-Solutions","id":838105,"avatar_url":"https://avatars0.githubusercontent.com/u/838105?v=3","gravatar_id":"","url":"https://api.github.com/users/Ortus-Solutions","html_url":"https://github.com/Ortus-Solutions","followers_url":"https://api.github.com/users/Ortus-Solutions/followers","following_url":"https://api.github.com/users/Ortus-Solutions/following{/other_user}","gists_url":"https://api.github.com/users/Ortus-Solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/Ortus-Solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ortus-Solutions/subscriptions","organizations_url":"https://api.github.com/users/Ortus-Solutions/orgs","repos_url":"https://api.github.com/users/Ortus-Solutions/repos","events_url":"https://api.github.com/users/Ortus-Solutions/events{/privacy}","received_events_url":"https://api.github.com/users/Ortus-Solutions/received_events","type":"Organization","site_admin":false},"repo":{"id":2075343,"name":"ContentBox","full_name":"Ortus-Solutions/ContentBox","owner":{"login":"Ortus-Solutions","id":838105,"avatar_url":"https://avatars0.githubusercontent.com/u/838105?v=3","gravatar_id":"","url":"https://api.github.com/users/Ortus-Solutions","html_url":"https://github.com/Ortus-Solutions","followers_url":"https://api.github.com/users/Ortus-Solutions/followers","following_url":"https://api.github.com/users/Ortus-Solutions/following{/other_user}","gists_url":"https://api.github.com/users/Ortus-Solutions/gists{/gist_id}","starred_url":"https://api.github.com/users/Ortus-Solutions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ortus-Solutions/subscriptions","organizations_url":"https://api.github.com/users/Ortus-Solutions/orgs","repos_url":"https://api.github.com/users/Ortus-Solutions/repos","events_url":"https://api.github.com/users/Ortus-Solutions/events{/privacy}","received_events_url":"https://api.github.com/users/Ortus-Solutions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Ortus-Solutions/ContentBox","description":"Enterprise ColdFusion (CFML) Modular CMS","fork":false,"url":"https://api.github.com/repos/Ortus-Solutions/ContentBox","forks_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/forks","keys_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/teams","hooks_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/hooks","issue_events_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/issues/events{/number}","events_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/events","assignees_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/assignees{/user}","branches_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/branches{/branch}","tags_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/tags","blobs_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/statuses/{sha}","languages_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/languages","stargazers_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/stargazers","contributors_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/contributors","subscribers_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/subscribers","subscription_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/subscription","commits_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/contents/{+path}","compare_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/merges","archive_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/downloads","issues_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/issues{/number}","pulls_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls{/number}","milestones_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/milestones{/number}","notifications_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/labels{/name}","releases_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/releases{/id}","deployments_url":"https://api.github.com/repos/Ortus-Solutions/ContentBox/deployments","created_at":"2011-07-20T00:11:03Z","updated_at":"2017-03-11T13:55:47Z","pushed_at":"2017-05-23T16:08:19Z","git_url":"git://github.com/Ortus-Solutions/ContentBox.git","ssh_url":"git@github.com:Ortus-Solutions/ContentBox.git","clone_url":"https://github.com/Ortus-Solutions/ContentBox.git","svn_url":"https://github.com/Ortus-Solutions/ContentBox","homepage":"http://www.ortussolutions.com/products/contentbox","size":186310,"stargazers_count":63,"watchers_count":63,"language":"ColdFusion","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":58,"mirror_url":null,"open_issues_count":4,"forks":58,"open_issues":4,"watchers":63,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/337"},"html":{"href":"https://github.com/Ortus-Solutions/ContentBox/pull/337"},"issue":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/issues/337"},"comments":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/issues/337/comments"},"review_comments":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/337/comments"},"review_comment":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/pulls/337/commits"},"statuses":{"href":"https://api.github.com/repos/Ortus-Solutions/ContentBox/statuses/323d1f842acb6b985b5f4460af93a93b9efb3a3c"}}}}
{"actor":{"display_login":"lmajano"}}