{"action":"created","comment":{"url":"https://api.github.com/repos/gigya/microdot/pulls/comments/136709092","pull_request_review_id":60288875,"id":136709092,"diff_hunk":"@@ -109,11 +115,11 @@ public MethodSchema(MethodInfo info)\n                 Response = new TypeSchema(info.ReturnType, info.ReturnType.GetCustomAttributes());\n             }\n \n-            ResponseType = Response.TypeName;\n+            ResponseType = Response?.TypeName;\n             Parameters = info.GetParameters().Select(p => new ParameterSchema(p)).ToArray();\n             Attributes = info\n                 .GetCustomAttributes()\n-                .Where(a => a.GetType().Namespace?.StartsWith(\"System.Diagnostics\") == false)\n+                .Where(a => a.GetType().Namespace?.StartsWith(\"System.Diagnostics\") == false && a.GetType().Namespace?.StartsWith(\"System.Security\") == false)","path":"Gigya.ServiceContract/HttpService/ServiceSchema.cs","position":52,"original_position":52,"commit_id":"4c7e22ba15917c16d13a56758cc55080933ee4e4","original_commit_id":"4c7e22ba15917c16d13a56758cc55080933ee4e4","user":{"login":"bronsh","id":20515114,"avatar_url":"https://avatars1.githubusercontent.com/u/20515114?v=4","gravatar_id":"","url":"https://api.github.com/users/bronsh","html_url":"https://github.com/bronsh","followers_url":"https://api.github.com/users/bronsh/followers","following_url":"https://api.github.com/users/bronsh/following{/other_user}","gists_url":"https://api.github.com/users/bronsh/gists{/gist_id}","starred_url":"https://api.github.com/users/bronsh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bronsh/subscriptions","organizations_url":"https://api.github.com/users/bronsh/orgs","repos_url":"https://api.github.com/users/bronsh/repos","events_url":"https://api.github.com/users/bronsh/events{/privacy}","received_events_url":"https://api.github.com/users/bronsh/received_events","type":"User","site_admin":false},"body":"The namespace validating is being re-used in the code.\r\nConsider putting it on a common function","created_at":"2017-09-03T06:13:33Z","updated_at":"2017-09-03T06:13:34Z","html_url":"https://github.com/gigya/microdot/pull/79#discussion_r136709092","pull_request_url":"https://api.github.com/repos/gigya/microdot/pulls/79","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gigya/microdot/pulls/comments/136709092"},"html":{"href":"https://github.com/gigya/microdot/pull/79#discussion_r136709092"},"pull_request":{"href":"https://api.github.com/repos/gigya/microdot/pulls/79"}}},"pull_request":{"url":"https://api.github.com/repos/gigya/microdot/pulls/79","id":138692347,"html_url":"https://github.com/gigya/microdot/pull/79","diff_url":"https://github.com/gigya/microdot/pull/79.diff","patch_url":"https://github.com/gigya/microdot/pull/79.patch","issue_url":"https://api.github.com/repos/gigya/microdot/issues/79","number":79,"state":"open","locked":false,"title":"fix ServiceSchema ","user":{"login":"EranOfer","id":13414515,"avatar_url":"https://avatars3.githubusercontent.com/u/13414515?v=4","gravatar_id":"","url":"https://api.github.com/users/EranOfer","html_url":"https://github.com/EranOfer","followers_url":"https://api.github.com/users/EranOfer/followers","following_url":"https://api.github.com/users/EranOfer/following{/other_user}","gists_url":"https://api.github.com/users/EranOfer/gists{/gist_id}","starred_url":"https://api.github.com/users/EranOfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EranOfer/subscriptions","organizations_url":"https://api.github.com/users/EranOfer/orgs","repos_url":"https://api.github.com/users/EranOfer/repos","events_url":"https://api.github.com/users/EranOfer/events{/privacy}","received_events_url":"https://api.github.com/users/EranOfer/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-08-31T15:09:03Z","updated_at":"2017-09-03T06:13:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2671493e9480f05882ec3cbc01bd6065c473ed87","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/gigya/microdot/pulls/79/commits","review_comments_url":"https://api.github.com/repos/gigya/microdot/pulls/79/comments","review_comment_url":"https://api.github.com/repos/gigya/microdot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gigya/microdot/issues/79/comments","statuses_url":"https://api.github.com/repos/gigya/microdot/statuses/4c7e22ba15917c16d13a56758cc55080933ee4e4","head":{"label":"gigya:feature/fix_Service_Schema_Response","ref":"feature/fix_Service_Schema_Response","sha":"4c7e22ba15917c16d13a56758cc55080933ee4e4","user":{"login":"gigya","id":3179803,"avatar_url":"https://avatars1.githubusercontent.com/u/3179803?v=4","gravatar_id":"","url":"https://api.github.com/users/gigya","html_url":"https://github.com/gigya","followers_url":"https://api.github.com/users/gigya/followers","following_url":"https://api.github.com/users/gigya/following{/other_user}","gists_url":"https://api.github.com/users/gigya/gists{/gist_id}","starred_url":"https://api.github.com/users/gigya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigya/subscriptions","organizations_url":"https://api.github.com/users/gigya/orgs","repos_url":"https://api.github.com/users/gigya/repos","events_url":"https://api.github.com/users/gigya/events{/privacy}","received_events_url":"https://api.github.com/users/gigya/received_events","type":"Organization","site_admin":false},"repo":{"id":89123929,"name":"microdot","full_name":"gigya/microdot","owner":{"login":"gigya","id":3179803,"avatar_url":"https://avatars1.githubusercontent.com/u/3179803?v=4","gravatar_id":"","url":"https://api.github.com/users/gigya","html_url":"https://github.com/gigya","followers_url":"https://api.github.com/users/gigya/followers","following_url":"https://api.github.com/users/gigya/following{/other_user}","gists_url":"https://api.github.com/users/gigya/gists{/gist_id}","starred_url":"https://api.github.com/users/gigya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigya/subscriptions","organizations_url":"https://api.github.com/users/gigya/orgs","repos_url":"https://api.github.com/users/gigya/repos","events_url":"https://api.github.com/users/gigya/events{/privacy}","received_events_url":"https://api.github.com/users/gigya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gigya/microdot","description":"Microdot: An open source .NET microservices framework","fork":false,"url":"https://api.github.com/repos/gigya/microdot","forks_url":"https://api.github.com/repos/gigya/microdot/forks","keys_url":"https://api.github.com/repos/gigya/microdot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigya/microdot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigya/microdot/teams","hooks_url":"https://api.github.com/repos/gigya/microdot/hooks","issue_events_url":"https://api.github.com/repos/gigya/microdot/issues/events{/number}","events_url":"https://api.github.com/repos/gigya/microdot/events","assignees_url":"https://api.github.com/repos/gigya/microdot/assignees{/user}","branches_url":"https://api.github.com/repos/gigya/microdot/branches{/branch}","tags_url":"https://api.github.com/repos/gigya/microdot/tags","blobs_url":"https://api.github.com/repos/gigya/microdot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigya/microdot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigya/microdot/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigya/microdot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigya/microdot/statuses/{sha}","languages_url":"https://api.github.com/repos/gigya/microdot/languages","stargazers_url":"https://api.github.com/repos/gigya/microdot/stargazers","contributors_url":"https://api.github.com/repos/gigya/microdot/contributors","subscribers_url":"https://api.github.com/repos/gigya/microdot/subscribers","subscription_url":"https://api.github.com/repos/gigya/microdot/subscription","commits_url":"https://api.github.com/repos/gigya/microdot/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigya/microdot/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigya/microdot/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigya/microdot/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigya/microdot/contents/{+path}","compare_url":"https://api.github.com/repos/gigya/microdot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigya/microdot/merges","archive_url":"https://api.github.com/repos/gigya/microdot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigya/microdot/downloads","issues_url":"https://api.github.com/repos/gigya/microdot/issues{/number}","pulls_url":"https://api.github.com/repos/gigya/microdot/pulls{/number}","milestones_url":"https://api.github.com/repos/gigya/microdot/milestones{/number}","notifications_url":"https://api.github.com/repos/gigya/microdot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigya/microdot/labels{/name}","releases_url":"https://api.github.com/repos/gigya/microdot/releases{/id}","deployments_url":"https://api.github.com/repos/gigya/microdot/deployments","created_at":"2017-04-23T07:10:26Z","updated_at":"2017-09-01T03:47:57Z","pushed_at":"2017-09-03T04:52:01Z","git_url":"git://github.com/gigya/microdot.git","ssh_url":"git@github.com:gigya/microdot.git","clone_url":"https://github.com/gigya/microdot.git","svn_url":"https://github.com/gigya/microdot","homepage":"","size":706,"stargazers_count":332,"watchers_count":332,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":4,"forks":36,"open_issues":4,"watchers":332,"default_branch":"develop"}},"base":{"label":"gigya:develop","ref":"develop","sha":"c39495dfc66a9928bf4bdea3a9fa4a922aac3dc8","user":{"login":"gigya","id":3179803,"avatar_url":"https://avatars1.githubusercontent.com/u/3179803?v=4","gravatar_id":"","url":"https://api.github.com/users/gigya","html_url":"https://github.com/gigya","followers_url":"https://api.github.com/users/gigya/followers","following_url":"https://api.github.com/users/gigya/following{/other_user}","gists_url":"https://api.github.com/users/gigya/gists{/gist_id}","starred_url":"https://api.github.com/users/gigya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigya/subscriptions","organizations_url":"https://api.github.com/users/gigya/orgs","repos_url":"https://api.github.com/users/gigya/repos","events_url":"https://api.github.com/users/gigya/events{/privacy}","received_events_url":"https://api.github.com/users/gigya/received_events","type":"Organization","site_admin":false},"repo":{"id":89123929,"name":"microdot","full_name":"gigya/microdot","owner":{"login":"gigya","id":3179803,"avatar_url":"https://avatars1.githubusercontent.com/u/3179803?v=4","gravatar_id":"","url":"https://api.github.com/users/gigya","html_url":"https://github.com/gigya","followers_url":"https://api.github.com/users/gigya/followers","following_url":"https://api.github.com/users/gigya/following{/other_user}","gists_url":"https://api.github.com/users/gigya/gists{/gist_id}","starred_url":"https://api.github.com/users/gigya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gigya/subscriptions","organizations_url":"https://api.github.com/users/gigya/orgs","repos_url":"https://api.github.com/users/gigya/repos","events_url":"https://api.github.com/users/gigya/events{/privacy}","received_events_url":"https://api.github.com/users/gigya/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gigya/microdot","description":"Microdot: An open source .NET microservices framework","fork":false,"url":"https://api.github.com/repos/gigya/microdot","forks_url":"https://api.github.com/repos/gigya/microdot/forks","keys_url":"https://api.github.com/repos/gigya/microdot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gigya/microdot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gigya/microdot/teams","hooks_url":"https://api.github.com/repos/gigya/microdot/hooks","issue_events_url":"https://api.github.com/repos/gigya/microdot/issues/events{/number}","events_url":"https://api.github.com/repos/gigya/microdot/events","assignees_url":"https://api.github.com/repos/gigya/microdot/assignees{/user}","branches_url":"https://api.github.com/repos/gigya/microdot/branches{/branch}","tags_url":"https://api.github.com/repos/gigya/microdot/tags","blobs_url":"https://api.github.com/repos/gigya/microdot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gigya/microdot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gigya/microdot/git/refs{/sha}","trees_url":"https://api.github.com/repos/gigya/microdot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gigya/microdot/statuses/{sha}","languages_url":"https://api.github.com/repos/gigya/microdot/languages","stargazers_url":"https://api.github.com/repos/gigya/microdot/stargazers","contributors_url":"https://api.github.com/repos/gigya/microdot/contributors","subscribers_url":"https://api.github.com/repos/gigya/microdot/subscribers","subscription_url":"https://api.github.com/repos/gigya/microdot/subscription","commits_url":"https://api.github.com/repos/gigya/microdot/commits{/sha}","git_commits_url":"https://api.github.com/repos/gigya/microdot/git/commits{/sha}","comments_url":"https://api.github.com/repos/gigya/microdot/comments{/number}","issue_comment_url":"https://api.github.com/repos/gigya/microdot/issues/comments{/number}","contents_url":"https://api.github.com/repos/gigya/microdot/contents/{+path}","compare_url":"https://api.github.com/repos/gigya/microdot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gigya/microdot/merges","archive_url":"https://api.github.com/repos/gigya/microdot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gigya/microdot/downloads","issues_url":"https://api.github.com/repos/gigya/microdot/issues{/number}","pulls_url":"https://api.github.com/repos/gigya/microdot/pulls{/number}","milestones_url":"https://api.github.com/repos/gigya/microdot/milestones{/number}","notifications_url":"https://api.github.com/repos/gigya/microdot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gigya/microdot/labels{/name}","releases_url":"https://api.github.com/repos/gigya/microdot/releases{/id}","deployments_url":"https://api.github.com/repos/gigya/microdot/deployments","created_at":"2017-04-23T07:10:26Z","updated_at":"2017-09-01T03:47:57Z","pushed_at":"2017-09-03T04:52:01Z","git_url":"git://github.com/gigya/microdot.git","ssh_url":"git@github.com:gigya/microdot.git","clone_url":"https://github.com/gigya/microdot.git","svn_url":"https://github.com/gigya/microdot","homepage":"","size":706,"stargazers_count":332,"watchers_count":332,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"open_issues_count":4,"forks":36,"open_issues":4,"watchers":332,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/gigya/microdot/pulls/79"},"html":{"href":"https://github.com/gigya/microdot/pull/79"},"issue":{"href":"https://api.github.com/repos/gigya/microdot/issues/79"},"comments":{"href":"https://api.github.com/repos/gigya/microdot/issues/79/comments"},"review_comments":{"href":"https://api.github.com/repos/gigya/microdot/pulls/79/comments"},"review_comment":{"href":"https://api.github.com/repos/gigya/microdot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gigya/microdot/pulls/79/commits"},"statuses":{"href":"https://api.github.com/repos/gigya/microdot/statuses/4c7e22ba15917c16d13a56758cc55080933ee4e4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bronsh"}}