{"action":"created","comment":{"url":"https://api.github.com/repos/minishift/minishift/pulls/comments/106932025","pull_request_review_id":27876619,"id":106932025,"diff_hunk":"@@ -39,26 +39,31 @@ provisioning VMs, and [OpenShift Origin](https://github.com/openshift/origin) fo\n <a name=\"prerequisites\"></a>\n ### Prerequisites\n \n-Minishift requires a hypervisor to run the virtual machine containing OpenShift. Depending on your\n-host OS, you have the choice of the following hypervisors:\n+Minishift requires a hypervisor to start the virtual machine containing the single-node OpenShift cluster.\n+Make sure that the hypervisor of your choice is installed and enabled on your system before you\n+install Minishift.\n \n-* OS X\n-    * [xhyve](https://github.com/mist64/xhyve) (default), [VirtualBox](https://www.virtualbox.org/wiki/Downloads) or [VMware Fusion](https://www.vmware.com/products/fusion)\n-* GNU/Linux\n-    * [KVM](https://minishift.io/docs/docker-machine-drivers.html#kvm-driver) (default) or [VirtualBox](https://www.virtualbox.org/wiki/Downloads)\n-* Windows\n-    * [Hyper-V](https://technet.microsoft.com/en-us/library/mt169373.aspx) (default) or [VirtualBox](https://www.virtualbox.org/wiki/Downloads)\n+Depending on your host OS, you have the choice of the following hypervisors:\n \n-Make sure that the hypervisor is installed and enabled on your system before you install Minishift.\n+* **OS X:** [xhyve](https://github.com/mist64/xhyve) (default), [VirtualBox](https://www.virtualbox.org/wiki/Downloads) or [VMware Fusion](https://www.vmware.com/products/fusion)\n \n-**Important:**\n+    **Note:** xhyve requires specific installation and configuration steps as mentioned in the [docker machine drivers installation](https://minishift.io/docs/docker-machine-drivers.html#xhyve-driver) section.\n \n-- KVM and xhyve require specific installation and configuration steps.\n-For more information, see [docker machine drivers installation](https://minishift.io/docs/docker-machine-drivers.html).\n-- It is recommended to use `Virtualbox 5.1.12` or later on Windows to avoid the issue\n-[Error: getting state for host: machine does not exist](https://minishift.io/docs/troubleshooting.html#error-getting-state-for-host-machine-does-not-exist)\n+* **GNU/Linux:** [KVM](https://minishift.io/docs/docker-machine-drivers.html#kvm-driver) (default) or [VirtualBox](https://www.virtualbox.org/wiki/Downloads)\n \n-If you encounter driver issues, see the [Troubleshooting](https://minishift.io/docs/troubleshooting.html) guide.\n+    **Note:** KVM requires specific installation and configuration steps as mentioned in the [docker machine drivers installation](https://minishift.io/docs/docker-machine-drivers.html#kvm-driver) section.\n+\n+* **Windows:** [Hyper-V](https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/quick-start/enable-hyper-v) (default) or [VirtualBox](https://www.virtualbox.org/wiki/Downloads)\n+\n+    **Note:**\n+    - To enable Hyper-V ensure that, after you [install Hyper-V](https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/quick-start/enable-hyper-v), you also [add a Virtual\n+Switch](https://msdn.microsoft.com/en-us/virtualization/hyperv_on_windows/quick_start/walkthrough_virtual_switch) using the Hyper-V Manager.\n+Also, ensure that you pair the virtual switch with\n+a _physical network card which has Internet access_.","path":"README.md","position":39,"original_position":39,"commit_id":"7d47d885b8884cdc29e8214e7702b9947ba76572","original_commit_id":"7d47d885b8884cdc29e8214e7702b9947ba76572","user":{"login":"gbraad","id":1894,"avatar_url":"https://avatars3.githubusercontent.com/u/1894?v=3","gravatar_id":"","url":"https://api.github.com/users/gbraad","html_url":"https://github.com/gbraad","followers_url":"https://api.github.com/users/gbraad/followers","following_url":"https://api.github.com/users/gbraad/following{/other_user}","gists_url":"https://api.github.com/users/gbraad/gists{/gist_id}","starred_url":"https://api.github.com/users/gbraad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbraad/subscriptions","organizations_url":"https://api.github.com/users/gbraad/orgs","repos_url":"https://api.github.com/users/gbraad/repos","events_url":"https://api.github.com/users/gbraad/events{/privacy}","received_events_url":"https://api.github.com/users/gbraad/received_events","type":"User","site_admin":false},"body":"not sure if physical should be mentioned here; both _wireless_ or _wired_ are possible. is _wireless_ physical?","created_at":"2017-03-20T15:30:25Z","updated_at":"2017-03-20T15:30:25Z","html_url":"https://github.com/minishift/minishift/pull/573#discussion_r106932025","pull_request_url":"https://api.github.com/repos/minishift/minishift/pulls/573","_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments/106932025"},"html":{"href":"https://github.com/minishift/minishift/pull/573#discussion_r106932025"},"pull_request":{"href":"https://api.github.com/repos/minishift/minishift/pulls/573"}}},"pull_request":{"url":"https://api.github.com/repos/minishift/minishift/pulls/573","id":111500426,"html_url":"https://github.com/minishift/minishift/pull/573","diff_url":"https://github.com/minishift/minishift/pull/573.diff","patch_url":"https://github.com/minishift/minishift/pull/573.patch","issue_url":"https://api.github.com/repos/minishift/minishift/issues/573","number":573,"state":"open","locked":false,"title":"Issue #265 Adding note for virtual switch creation for Hyper-V.","user":{"login":"Preeticp","id":16647625,"avatar_url":"https://avatars0.githubusercontent.com/u/16647625?v=3","gravatar_id":"","url":"https://api.github.com/users/Preeticp","html_url":"https://github.com/Preeticp","followers_url":"https://api.github.com/users/Preeticp/followers","following_url":"https://api.github.com/users/Preeticp/following{/other_user}","gists_url":"https://api.github.com/users/Preeticp/gists{/gist_id}","starred_url":"https://api.github.com/users/Preeticp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Preeticp/subscriptions","organizations_url":"https://api.github.com/users/Preeticp/orgs","repos_url":"https://api.github.com/users/Preeticp/repos","events_url":"https://api.github.com/users/Preeticp/events{/privacy}","received_events_url":"https://api.github.com/users/Preeticp/received_events","type":"User","site_admin":false},"body":"Also, updated link for Hyper-V in the 'Prerequisites section' to point to - installation of Hyper-V on windows 10 and moved the sentence above the 'Important section' to the first paragraph in the Prerequisites section, to ensure better visibility to the points listed under Important.","created_at":"2017-03-20T07:35:23Z","updated_at":"2017-03-20T15:30:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a1872302c61950ada797c9c4d1d26ed6c2accab","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/minishift/minishift/pulls/573/commits","review_comments_url":"https://api.github.com/repos/minishift/minishift/pulls/573/comments","review_comment_url":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minishift/minishift/issues/573/comments","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/7d47d885b8884cdc29e8214e7702b9947ba76572","head":{"label":"Preeticp:Hyperv_virtualswitch","ref":"Hyperv_virtualswitch","sha":"7d47d885b8884cdc29e8214e7702b9947ba76572","user":{"login":"Preeticp","id":16647625,"avatar_url":"https://avatars0.githubusercontent.com/u/16647625?v=3","gravatar_id":"","url":"https://api.github.com/users/Preeticp","html_url":"https://github.com/Preeticp","followers_url":"https://api.github.com/users/Preeticp/followers","following_url":"https://api.github.com/users/Preeticp/following{/other_user}","gists_url":"https://api.github.com/users/Preeticp/gists{/gist_id}","starred_url":"https://api.github.com/users/Preeticp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Preeticp/subscriptions","organizations_url":"https://api.github.com/users/Preeticp/orgs","repos_url":"https://api.github.com/users/Preeticp/repos","events_url":"https://api.github.com/users/Preeticp/events{/privacy}","received_events_url":"https://api.github.com/users/Preeticp/received_events","type":"User","site_admin":false},"repo":{"id":77666048,"name":"minishift","full_name":"Preeticp/minishift","owner":{"login":"Preeticp","id":16647625,"avatar_url":"https://avatars0.githubusercontent.com/u/16647625?v=3","gravatar_id":"","url":"https://api.github.com/users/Preeticp","html_url":"https://github.com/Preeticp","followers_url":"https://api.github.com/users/Preeticp/followers","following_url":"https://api.github.com/users/Preeticp/following{/other_user}","gists_url":"https://api.github.com/users/Preeticp/gists{/gist_id}","starred_url":"https://api.github.com/users/Preeticp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Preeticp/subscriptions","organizations_url":"https://api.github.com/users/Preeticp/orgs","repos_url":"https://api.github.com/users/Preeticp/repos","events_url":"https://api.github.com/users/Preeticp/events{/privacy}","received_events_url":"https://api.github.com/users/Preeticp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Preeticp/minishift","description":"Run OpenShift locally","fork":true,"url":"https://api.github.com/repos/Preeticp/minishift","forks_url":"https://api.github.com/repos/Preeticp/minishift/forks","keys_url":"https://api.github.com/repos/Preeticp/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Preeticp/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Preeticp/minishift/teams","hooks_url":"https://api.github.com/repos/Preeticp/minishift/hooks","issue_events_url":"https://api.github.com/repos/Preeticp/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/Preeticp/minishift/events","assignees_url":"https://api.github.com/repos/Preeticp/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/Preeticp/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/Preeticp/minishift/tags","blobs_url":"https://api.github.com/repos/Preeticp/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Preeticp/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Preeticp/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/Preeticp/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Preeticp/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/Preeticp/minishift/languages","stargazers_url":"https://api.github.com/repos/Preeticp/minishift/stargazers","contributors_url":"https://api.github.com/repos/Preeticp/minishift/contributors","subscribers_url":"https://api.github.com/repos/Preeticp/minishift/subscribers","subscription_url":"https://api.github.com/repos/Preeticp/minishift/subscription","commits_url":"https://api.github.com/repos/Preeticp/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/Preeticp/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/Preeticp/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/Preeticp/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/Preeticp/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/Preeticp/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Preeticp/minishift/merges","archive_url":"https://api.github.com/repos/Preeticp/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Preeticp/minishift/downloads","issues_url":"https://api.github.com/repos/Preeticp/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/Preeticp/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/Preeticp/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/Preeticp/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Preeticp/minishift/labels{/name}","releases_url":"https://api.github.com/repos/Preeticp/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/Preeticp/minishift/deployments","created_at":"2016-12-30T06:30:31Z","updated_at":"2016-12-30T06:30:35Z","pushed_at":"2017-03-20T13:01:02Z","git_url":"git://github.com/Preeticp/minishift.git","ssh_url":"git@github.com:Preeticp/minishift.git","clone_url":"https://github.com/Preeticp/minishift.git","svn_url":"https://github.com/Preeticp/minishift","homepage":"","size":155125,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minishift:master","ref":"master","sha":"1471e3559dab16f3435009b0d25301ec33425248","user":{"login":"minishift","id":23212309,"avatar_url":"https://avatars2.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"repo":{"id":62728051,"name":"minishift","full_name":"minishift/minishift","owner":{"login":"minishift","id":23212309,"avatar_url":"https://avatars2.githubusercontent.com/u/23212309?v=3","gravatar_id":"","url":"https://api.github.com/users/minishift","html_url":"https://github.com/minishift","followers_url":"https://api.github.com/users/minishift/followers","following_url":"https://api.github.com/users/minishift/following{/other_user}","gists_url":"https://api.github.com/users/minishift/gists{/gist_id}","starred_url":"https://api.github.com/users/minishift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minishift/subscriptions","organizations_url":"https://api.github.com/users/minishift/orgs","repos_url":"https://api.github.com/users/minishift/repos","events_url":"https://api.github.com/users/minishift/events{/privacy}","received_events_url":"https://api.github.com/users/minishift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/minishift/minishift","description":"Run OpenShift locally","fork":false,"url":"https://api.github.com/repos/minishift/minishift","forks_url":"https://api.github.com/repos/minishift/minishift/forks","keys_url":"https://api.github.com/repos/minishift/minishift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minishift/minishift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minishift/minishift/teams","hooks_url":"https://api.github.com/repos/minishift/minishift/hooks","issue_events_url":"https://api.github.com/repos/minishift/minishift/issues/events{/number}","events_url":"https://api.github.com/repos/minishift/minishift/events","assignees_url":"https://api.github.com/repos/minishift/minishift/assignees{/user}","branches_url":"https://api.github.com/repos/minishift/minishift/branches{/branch}","tags_url":"https://api.github.com/repos/minishift/minishift/tags","blobs_url":"https://api.github.com/repos/minishift/minishift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minishift/minishift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minishift/minishift/git/refs{/sha}","trees_url":"https://api.github.com/repos/minishift/minishift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minishift/minishift/statuses/{sha}","languages_url":"https://api.github.com/repos/minishift/minishift/languages","stargazers_url":"https://api.github.com/repos/minishift/minishift/stargazers","contributors_url":"https://api.github.com/repos/minishift/minishift/contributors","subscribers_url":"https://api.github.com/repos/minishift/minishift/subscribers","subscription_url":"https://api.github.com/repos/minishift/minishift/subscription","commits_url":"https://api.github.com/repos/minishift/minishift/commits{/sha}","git_commits_url":"https://api.github.com/repos/minishift/minishift/git/commits{/sha}","comments_url":"https://api.github.com/repos/minishift/minishift/comments{/number}","issue_comment_url":"https://api.github.com/repos/minishift/minishift/issues/comments{/number}","contents_url":"https://api.github.com/repos/minishift/minishift/contents/{+path}","compare_url":"https://api.github.com/repos/minishift/minishift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minishift/minishift/merges","archive_url":"https://api.github.com/repos/minishift/minishift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minishift/minishift/downloads","issues_url":"https://api.github.com/repos/minishift/minishift/issues{/number}","pulls_url":"https://api.github.com/repos/minishift/minishift/pulls{/number}","milestones_url":"https://api.github.com/repos/minishift/minishift/milestones{/number}","notifications_url":"https://api.github.com/repos/minishift/minishift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minishift/minishift/labels{/name}","releases_url":"https://api.github.com/repos/minishift/minishift/releases{/id}","deployments_url":"https://api.github.com/repos/minishift/minishift/deployments","created_at":"2016-07-06T14:37:20Z","updated_at":"2017-03-20T06:20:52Z","pushed_at":"2017-03-20T15:01:13Z","git_url":"git://github.com/minishift/minishift.git","ssh_url":"git@github.com:minishift/minishift.git","clone_url":"https://github.com/minishift/minishift.git","svn_url":"https://github.com/minishift/minishift","homepage":"","size":155124,"stargazers_count":308,"watchers_count":308,"language":"Go","has_issues":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":71,"mirror_url":null,"open_issues_count":132,"forks":71,"open_issues":132,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minishift/minishift/pulls/573"},"html":{"href":"https://github.com/minishift/minishift/pull/573"},"issue":{"href":"https://api.github.com/repos/minishift/minishift/issues/573"},"comments":{"href":"https://api.github.com/repos/minishift/minishift/issues/573/comments"},"review_comments":{"href":"https://api.github.com/repos/minishift/minishift/pulls/573/comments"},"review_comment":{"href":"https://api.github.com/repos/minishift/minishift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minishift/minishift/pulls/573/commits"},"statuses":{"href":"https://api.github.com/repos/minishift/minishift/statuses/7d47d885b8884cdc29e8214e7702b9947ba76572"}}}}
{"actor":{"display_login":"gbraad"}}