{"action":"created","comment":{"url":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/comments/122922250","pull_request_review_id":45077150,"id":122922250,"diff_hunk":"@@ -10,12 +10,13 @@ const loadConfig = require('./lib/config')\n const RoutingTables = require('./lib/routing-tables')\n const RouteBuilder = require('./lib/route-builder')\n const RouteBroadcaster = require('./lib/route-broadcaster')\n+const CurveCache = require('./lib/curve-cache')","path":"src/app.js","position":4,"original_position":4,"commit_id":"e8edce3897732f2db273b6985dc57261cf547ca6","original_commit_id":"34082781feb048441a373384314bffa4a0a35e45","user":{"login":"michielbdejong","id":408412,"avatar_url":"https://avatars1.githubusercontent.com/u/408412?v=3","gravatar_id":"","url":"https://api.github.com/users/michielbdejong","html_url":"https://github.com/michielbdejong","followers_url":"https://api.github.com/users/michielbdejong/followers","following_url":"https://api.github.com/users/michielbdejong/following{/other_user}","gists_url":"https://api.github.com/users/michielbdejong/gists{/gist_id}","starred_url":"https://api.github.com/users/michielbdejong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michielbdejong/subscriptions","organizations_url":"https://api.github.com/users/michielbdejong/orgs","repos_url":"https://api.github.com/users/michielbdejong/repos","events_url":"https://api.github.com/users/michielbdejong/events{/privacy}","received_events_url":"https://api.github.com/users/michielbdejong/received_events","type":"User","site_admin":false},"body":"My gut feeling is that c) would lead to overly complex code.","created_at":"2017-06-20T09:19:04Z","updated_at":"2017-06-20T09:19:04Z","html_url":"https://github.com/interledgerjs/ilp-connector/pull/355#discussion_r122922250","pull_request_url":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/355","_links":{"self":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/comments/122922250"},"html":{"href":"https://github.com/interledgerjs/ilp-connector/pull/355#discussion_r122922250"},"pull_request":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/355"}}},"pull_request":{"url":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/355","id":125693656,"html_url":"https://github.com/interledgerjs/ilp-connector/pull/355","diff_url":"https://github.com/interledgerjs/ilp-connector/pull/355.diff","patch_url":"https://github.com/interledgerjs/ilp-connector/pull/355.patch","issue_url":"https://api.github.com/repos/interledgerjs/ilp-connector/issues/355","number":355,"state":"open","locked":false,"title":"feat: BREAKING handle liquidity quote requests","user":{"login":"sentientwaffle","id":461112,"avatar_url":"https://avatars3.githubusercontent.com/u/461112?v=3","gravatar_id":"","url":"https://api.github.com/users/sentientwaffle","html_url":"https://github.com/sentientwaffle","followers_url":"https://api.github.com/users/sentientwaffle/followers","following_url":"https://api.github.com/users/sentientwaffle/following{/other_user}","gists_url":"https://api.github.com/users/sentientwaffle/gists{/gist_id}","starred_url":"https://api.github.com/users/sentientwaffle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sentientwaffle/subscriptions","organizations_url":"https://api.github.com/users/sentientwaffle/orgs","repos_url":"https://api.github.com/users/sentientwaffle/repos","events_url":"https://api.github.com/users/sentientwaffle/events{/privacy}","received_events_url":"https://api.github.com/users/sentientwaffle/received_events","type":"User","site_admin":false},"body":"* Quote-by-source/destination uses liquidity quoting internally; payment is handled by cached quotes if available.\r\n* Depends on #350 and interledgerjs/ilp-routing#46 and https://github.com/interledgerjs/five-bells-integration-test/pull/82 and https://github.com/interledgerjs/five-bells-shared/pull/191","created_at":"2017-06-14T21:09:25Z","updated_at":"2017-06-20T09:19:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9fbed70ddeed0ff77cc00a153bd561a23870510","assignee":null,"assignees":[],"requested_reviewers":[{"login":"justmoon","id":53233,"avatar_url":"https://avatars2.githubusercontent.com/u/53233?v=3","gravatar_id":"","url":"https://api.github.com/users/justmoon","html_url":"https://github.com/justmoon","followers_url":"https://api.github.com/users/justmoon/followers","following_url":"https://api.github.com/users/justmoon/following{/other_user}","gists_url":"https://api.github.com/users/justmoon/gists{/gist_id}","starred_url":"https://api.github.com/users/justmoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justmoon/subscriptions","organizations_url":"https://api.github.com/users/justmoon/orgs","repos_url":"https://api.github.com/users/justmoon/repos","events_url":"https://api.github.com/users/justmoon/events{/privacy}","received_events_url":"https://api.github.com/users/justmoon/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/355/commits","review_comments_url":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/355/comments","review_comment_url":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/comments{/number}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-connector/issues/355/comments","statuses_url":"https://api.github.com/repos/interledgerjs/ilp-connector/statuses/e8edce3897732f2db273b6985dc57261cf547ca6","head":{"label":"interledgerjs:dj-ilqp-quote-liquidity","ref":"dj-ilqp-quote-liquidity","sha":"e8edce3897732f2db273b6985dc57261cf547ca6","user":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars2.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":30608872,"name":"ilp-connector","full_name":"interledgerjs/ilp-connector","owner":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars2.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledgerjs/ilp-connector","description":"Reference implementation of an Interledger connector.","fork":false,"url":"https://api.github.com/repos/interledgerjs/ilp-connector","forks_url":"https://api.github.com/repos/interledgerjs/ilp-connector/forks","keys_url":"https://api.github.com/repos/interledgerjs/ilp-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledgerjs/ilp-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledgerjs/ilp-connector/teams","hooks_url":"https://api.github.com/repos/interledgerjs/ilp-connector/hooks","issue_events_url":"https://api.github.com/repos/interledgerjs/ilp-connector/issues/events{/number}","events_url":"https://api.github.com/repos/interledgerjs/ilp-connector/events","assignees_url":"https://api.github.com/repos/interledgerjs/ilp-connector/assignees{/user}","branches_url":"https://api.github.com/repos/interledgerjs/ilp-connector/branches{/branch}","tags_url":"https://api.github.com/repos/interledgerjs/ilp-connector/tags","blobs_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledgerjs/ilp-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/interledgerjs/ilp-connector/languages","stargazers_url":"https://api.github.com/repos/interledgerjs/ilp-connector/stargazers","contributors_url":"https://api.github.com/repos/interledgerjs/ilp-connector/contributors","subscribers_url":"https://api.github.com/repos/interledgerjs/ilp-connector/subscribers","subscription_url":"https://api.github.com/repos/interledgerjs/ilp-connector/subscription","commits_url":"https://api.github.com/repos/interledgerjs/ilp-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledgerjs/ilp-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledgerjs/ilp-connector/contents/{+path}","compare_url":"https://api.github.com/repos/interledgerjs/ilp-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledgerjs/ilp-connector/merges","archive_url":"https://api.github.com/repos/interledgerjs/ilp-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledgerjs/ilp-connector/downloads","issues_url":"https://api.github.com/repos/interledgerjs/ilp-connector/issues{/number}","pulls_url":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/interledgerjs/ilp-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/interledgerjs/ilp-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledgerjs/ilp-connector/labels{/name}","releases_url":"https://api.github.com/repos/interledgerjs/ilp-connector/releases{/id}","deployments_url":"https://api.github.com/repos/interledgerjs/ilp-connector/deployments","created_at":"2015-02-10T19:01:26Z","updated_at":"2017-06-05T22:07:09Z","pushed_at":"2017-06-20T08:28:00Z","git_url":"git://github.com/interledgerjs/ilp-connector.git","ssh_url":"git@github.com:interledgerjs/ilp-connector.git","clone_url":"https://github.com/interledgerjs/ilp-connector.git","svn_url":"https://github.com/interledgerjs/ilp-connector","homepage":"","size":2098,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":34,"forks":15,"open_issues":34,"watchers":7,"default_branch":"master"}},"base":{"label":"interledgerjs:master","ref":"master","sha":"a4086a7b0651845c3c479b679e5738423c50709a","user":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars2.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"repo":{"id":30608872,"name":"ilp-connector","full_name":"interledgerjs/ilp-connector","owner":{"login":"interledgerjs","id":22465593,"avatar_url":"https://avatars2.githubusercontent.com/u/22465593?v=3","gravatar_id":"","url":"https://api.github.com/users/interledgerjs","html_url":"https://github.com/interledgerjs","followers_url":"https://api.github.com/users/interledgerjs/followers","following_url":"https://api.github.com/users/interledgerjs/following{/other_user}","gists_url":"https://api.github.com/users/interledgerjs/gists{/gist_id}","starred_url":"https://api.github.com/users/interledgerjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/interledgerjs/subscriptions","organizations_url":"https://api.github.com/users/interledgerjs/orgs","repos_url":"https://api.github.com/users/interledgerjs/repos","events_url":"https://api.github.com/users/interledgerjs/events{/privacy}","received_events_url":"https://api.github.com/users/interledgerjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/interledgerjs/ilp-connector","description":"Reference implementation of an Interledger connector.","fork":false,"url":"https://api.github.com/repos/interledgerjs/ilp-connector","forks_url":"https://api.github.com/repos/interledgerjs/ilp-connector/forks","keys_url":"https://api.github.com/repos/interledgerjs/ilp-connector/keys{/key_id}","collaborators_url":"https://api.github.com/repos/interledgerjs/ilp-connector/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/interledgerjs/ilp-connector/teams","hooks_url":"https://api.github.com/repos/interledgerjs/ilp-connector/hooks","issue_events_url":"https://api.github.com/repos/interledgerjs/ilp-connector/issues/events{/number}","events_url":"https://api.github.com/repos/interledgerjs/ilp-connector/events","assignees_url":"https://api.github.com/repos/interledgerjs/ilp-connector/assignees{/user}","branches_url":"https://api.github.com/repos/interledgerjs/ilp-connector/branches{/branch}","tags_url":"https://api.github.com/repos/interledgerjs/ilp-connector/tags","blobs_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/refs{/sha}","trees_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/trees{/sha}","statuses_url":"https://api.github.com/repos/interledgerjs/ilp-connector/statuses/{sha}","languages_url":"https://api.github.com/repos/interledgerjs/ilp-connector/languages","stargazers_url":"https://api.github.com/repos/interledgerjs/ilp-connector/stargazers","contributors_url":"https://api.github.com/repos/interledgerjs/ilp-connector/contributors","subscribers_url":"https://api.github.com/repos/interledgerjs/ilp-connector/subscribers","subscription_url":"https://api.github.com/repos/interledgerjs/ilp-connector/subscription","commits_url":"https://api.github.com/repos/interledgerjs/ilp-connector/commits{/sha}","git_commits_url":"https://api.github.com/repos/interledgerjs/ilp-connector/git/commits{/sha}","comments_url":"https://api.github.com/repos/interledgerjs/ilp-connector/comments{/number}","issue_comment_url":"https://api.github.com/repos/interledgerjs/ilp-connector/issues/comments{/number}","contents_url":"https://api.github.com/repos/interledgerjs/ilp-connector/contents/{+path}","compare_url":"https://api.github.com/repos/interledgerjs/ilp-connector/compare/{base}...{head}","merges_url":"https://api.github.com/repos/interledgerjs/ilp-connector/merges","archive_url":"https://api.github.com/repos/interledgerjs/ilp-connector/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/interledgerjs/ilp-connector/downloads","issues_url":"https://api.github.com/repos/interledgerjs/ilp-connector/issues{/number}","pulls_url":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls{/number}","milestones_url":"https://api.github.com/repos/interledgerjs/ilp-connector/milestones{/number}","notifications_url":"https://api.github.com/repos/interledgerjs/ilp-connector/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/interledgerjs/ilp-connector/labels{/name}","releases_url":"https://api.github.com/repos/interledgerjs/ilp-connector/releases{/id}","deployments_url":"https://api.github.com/repos/interledgerjs/ilp-connector/deployments","created_at":"2015-02-10T19:01:26Z","updated_at":"2017-06-05T22:07:09Z","pushed_at":"2017-06-20T08:28:00Z","git_url":"git://github.com/interledgerjs/ilp-connector.git","ssh_url":"git@github.com:interledgerjs/ilp-connector.git","clone_url":"https://github.com/interledgerjs/ilp-connector.git","svn_url":"https://github.com/interledgerjs/ilp-connector","homepage":"","size":2098,"stargazers_count":7,"watchers_count":7,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15,"mirror_url":null,"open_issues_count":34,"forks":15,"open_issues":34,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/355"},"html":{"href":"https://github.com/interledgerjs/ilp-connector/pull/355"},"issue":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/issues/355"},"comments":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/issues/355/comments"},"review_comments":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/355/comments"},"review_comment":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/pulls/355/commits"},"statuses":{"href":"https://api.github.com/repos/interledgerjs/ilp-connector/statuses/e8edce3897732f2db273b6985dc57261cf547ca6"}}}}
{"actor":{"display_login":"michielbdejong"}}