{"action":"created","comment":{"url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/comments/144069996","pull_request_review_id":68671870,"id":144069996,"diff_hunk":"@@ -110,8 +110,27 @@ func typeLabel(units string, pcpType string, name string) string {\n \t} else {\n \t\tname += unit\n \t}\n+\treturn name\n+}\n+\n+func fixNaming(name string) string {\n \tname = strings.Replace(name, \"count / sec\", \"count_per_second\", -1)\n-\treturn strings.Replace(name, \".\", \"_\", -1)\n+\tname = strings.Replace(name, \"Kbyte\", \"kilobyte\", -1)","path":"sources/pmwebapi.go","position":10,"original_position":10,"commit_id":"f1930a428db5c6f3f0789510785900a938a8893a","original_commit_id":"f1930a428db5c6f3f0789510785900a938a8893a","user":{"login":"roclark","id":12703406,"avatar_url":"https://avatars3.githubusercontent.com/u/12703406?v=4","gravatar_id":"","url":"https://api.github.com/users/roclark","html_url":"https://github.com/roclark","followers_url":"https://api.github.com/users/roclark/followers","following_url":"https://api.github.com/users/roclark/following{/other_user}","gists_url":"https://api.github.com/users/roclark/gists{/gist_id}","starred_url":"https://api.github.com/users/roclark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roclark/subscriptions","organizations_url":"https://api.github.com/users/roclark/orgs","repos_url":"https://api.github.com/users/roclark/repos","events_url":"https://api.github.com/users/roclark/events{/privacy}","received_events_url":"https://api.github.com/users/roclark/received_events","type":"User","site_admin":false},"body":"Note that when you convert these to switchcases, you will no longer require every single one of these items. Some of the later ones are a result of these earlier actions. I will let you figure out which ones you need to keep.","created_at":"2017-10-11T16:49:57Z","updated_at":"2017-10-11T16:50:44Z","html_url":"https://github.com/HewlettPackard/pcp_exporter/pull/21#discussion_r144069996","pull_request_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/21","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/comments/144069996"},"html":{"href":"https://github.com/HewlettPackard/pcp_exporter/pull/21#discussion_r144069996"},"pull_request":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/21","id":144472527,"html_url":"https://github.com/HewlettPackard/pcp_exporter/pull/21","diff_url":"https://github.com/HewlettPackard/pcp_exporter/pull/21.diff","patch_url":"https://github.com/HewlettPackard/pcp_exporter/pull/21.patch","issue_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues/21","number":21,"state":"open","locked":false,"title":"Fix Weird Metrics","user":{"login":"kmada97","id":8628036,"avatar_url":"https://avatars0.githubusercontent.com/u/8628036?v=4","gravatar_id":"","url":"https://api.github.com/users/kmada97","html_url":"https://github.com/kmada97","followers_url":"https://api.github.com/users/kmada97/followers","following_url":"https://api.github.com/users/kmada97/following{/other_user}","gists_url":"https://api.github.com/users/kmada97/gists{/gist_id}","starred_url":"https://api.github.com/users/kmada97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kmada97/subscriptions","organizations_url":"https://api.github.com/users/kmada97/orgs","repos_url":"https://api.github.com/users/kmada97/repos","events_url":"https://api.github.com/users/kmada97/events{/privacy}","received_events_url":"https://api.github.com/users/kmada97/received_events","type":"User","site_admin":false},"body":"Initial fixes to metrics that were not matching prometheus standards.","created_at":"2017-10-03T16:45:25Z","updated_at":"2017-10-11T16:50:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"590de4a146abfca14a3bc4c7d9bfef72f0ecd9e3","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/21/commits","review_comments_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/21/comments","review_comment_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues/21/comments","statuses_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/statuses/f1930a428db5c6f3f0789510785900a938a8893a","head":{"label":"HewlettPackard:weirdmetrics","ref":"weirdmetrics","sha":"f1930a428db5c6f3f0789510785900a938a8893a","user":{"login":"HewlettPackard","id":6004705,"avatar_url":"https://avatars0.githubusercontent.com/u/6004705?v=4","gravatar_id":"","url":"https://api.github.com/users/HewlettPackard","html_url":"https://github.com/HewlettPackard","followers_url":"https://api.github.com/users/HewlettPackard/followers","following_url":"https://api.github.com/users/HewlettPackard/following{/other_user}","gists_url":"https://api.github.com/users/HewlettPackard/gists{/gist_id}","starred_url":"https://api.github.com/users/HewlettPackard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HewlettPackard/subscriptions","organizations_url":"https://api.github.com/users/HewlettPackard/orgs","repos_url":"https://api.github.com/users/HewlettPackard/repos","events_url":"https://api.github.com/users/HewlettPackard/events{/privacy}","received_events_url":"https://api.github.com/users/HewlettPackard/received_events","type":"Organization","site_admin":false},"repo":{"id":93640905,"name":"pcp_exporter","full_name":"HewlettPackard/pcp_exporter","owner":{"login":"HewlettPackard","id":6004705,"avatar_url":"https://avatars0.githubusercontent.com/u/6004705?v=4","gravatar_id":"","url":"https://api.github.com/users/HewlettPackard","html_url":"https://github.com/HewlettPackard","followers_url":"https://api.github.com/users/HewlettPackard/followers","following_url":"https://api.github.com/users/HewlettPackard/following{/other_user}","gists_url":"https://api.github.com/users/HewlettPackard/gists{/gist_id}","starred_url":"https://api.github.com/users/HewlettPackard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HewlettPackard/subscriptions","organizations_url":"https://api.github.com/users/HewlettPackard/orgs","repos_url":"https://api.github.com/users/HewlettPackard/repos","events_url":"https://api.github.com/users/HewlettPackard/events{/privacy}","received_events_url":"https://api.github.com/users/HewlettPackard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HewlettPackard/pcp_exporter","description":"Exporter for Performance CoPilot Metrics","fork":false,"url":"https://api.github.com/repos/HewlettPackard/pcp_exporter","forks_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/forks","keys_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/teams","hooks_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/hooks","issue_events_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/events","assignees_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/tags","blobs_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/languages","stargazers_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/stargazers","contributors_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/contributors","subscribers_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/subscribers","subscription_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/subscription","commits_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/merges","archive_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/downloads","issues_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/labels{/name}","releases_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/deployments","created_at":"2017-06-07T13:54:12Z","updated_at":"2017-09-26T15:16:17Z","pushed_at":"2017-10-11T15:53:39Z","git_url":"git://github.com/HewlettPackard/pcp_exporter.git","ssh_url":"git@github.com:HewlettPackard/pcp_exporter.git","clone_url":"https://github.com/HewlettPackard/pcp_exporter.git","svn_url":"https://github.com/HewlettPackard/pcp_exporter","homepage":null,"size":20,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":4,"default_branch":"master"}},"base":{"label":"HewlettPackard:master","ref":"master","sha":"c43280f6270acb60e2099907e6bbdc45b510ec13","user":{"login":"HewlettPackard","id":6004705,"avatar_url":"https://avatars0.githubusercontent.com/u/6004705?v=4","gravatar_id":"","url":"https://api.github.com/users/HewlettPackard","html_url":"https://github.com/HewlettPackard","followers_url":"https://api.github.com/users/HewlettPackard/followers","following_url":"https://api.github.com/users/HewlettPackard/following{/other_user}","gists_url":"https://api.github.com/users/HewlettPackard/gists{/gist_id}","starred_url":"https://api.github.com/users/HewlettPackard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HewlettPackard/subscriptions","organizations_url":"https://api.github.com/users/HewlettPackard/orgs","repos_url":"https://api.github.com/users/HewlettPackard/repos","events_url":"https://api.github.com/users/HewlettPackard/events{/privacy}","received_events_url":"https://api.github.com/users/HewlettPackard/received_events","type":"Organization","site_admin":false},"repo":{"id":93640905,"name":"pcp_exporter","full_name":"HewlettPackard/pcp_exporter","owner":{"login":"HewlettPackard","id":6004705,"avatar_url":"https://avatars0.githubusercontent.com/u/6004705?v=4","gravatar_id":"","url":"https://api.github.com/users/HewlettPackard","html_url":"https://github.com/HewlettPackard","followers_url":"https://api.github.com/users/HewlettPackard/followers","following_url":"https://api.github.com/users/HewlettPackard/following{/other_user}","gists_url":"https://api.github.com/users/HewlettPackard/gists{/gist_id}","starred_url":"https://api.github.com/users/HewlettPackard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HewlettPackard/subscriptions","organizations_url":"https://api.github.com/users/HewlettPackard/orgs","repos_url":"https://api.github.com/users/HewlettPackard/repos","events_url":"https://api.github.com/users/HewlettPackard/events{/privacy}","received_events_url":"https://api.github.com/users/HewlettPackard/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HewlettPackard/pcp_exporter","description":"Exporter for Performance CoPilot Metrics","fork":false,"url":"https://api.github.com/repos/HewlettPackard/pcp_exporter","forks_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/forks","keys_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/teams","hooks_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/hooks","issue_events_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues/events{/number}","events_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/events","assignees_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/assignees{/user}","branches_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/branches{/branch}","tags_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/tags","blobs_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/refs{/sha}","trees_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/statuses/{sha}","languages_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/languages","stargazers_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/stargazers","contributors_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/contributors","subscribers_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/subscribers","subscription_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/subscription","commits_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/commits{/sha}","git_commits_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/git/commits{/sha}","comments_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/comments{/number}","issue_comment_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues/comments{/number}","contents_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/contents/{+path}","compare_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/merges","archive_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/downloads","issues_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues{/number}","pulls_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls{/number}","milestones_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/milestones{/number}","notifications_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/labels{/name}","releases_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/releases{/id}","deployments_url":"https://api.github.com/repos/HewlettPackard/pcp_exporter/deployments","created_at":"2017-06-07T13:54:12Z","updated_at":"2017-09-26T15:16:17Z","pushed_at":"2017-10-11T15:53:39Z","git_url":"git://github.com/HewlettPackard/pcp_exporter.git","ssh_url":"git@github.com:HewlettPackard/pcp_exporter.git","clone_url":"https://github.com/HewlettPackard/pcp_exporter.git","svn_url":"https://github.com/HewlettPackard/pcp_exporter","homepage":null,"size":20,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":5,"forks":0,"open_issues":5,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/21"},"html":{"href":"https://github.com/HewlettPackard/pcp_exporter/pull/21"},"issue":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues/21"},"comments":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/HewlettPackard/pcp_exporter/statuses/f1930a428db5c6f3f0789510785900a938a8893a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"roclark"}}