{"action":"closed","number":24,"pull_request":{"url":"https://api.github.com/repos/hajimehoshi/oto/pulls/24","id":133642734,"html_url":"https://github.com/hajimehoshi/oto/pull/24","diff_url":"https://github.com/hajimehoshi/oto/pull/24.diff","patch_url":"https://github.com/hajimehoshi/oto/pull/24.patch","issue_url":"https://api.github.com/repos/hajimehoshi/oto/issues/24","number":24,"state":"closed","locked":false,"title":"openal: avoid possibility of panic by index out of bounds at player.Close","user":{"login":"pankona","id":6533008,"avatar_url":"https://avatars3.githubusercontent.com/u/6533008?v=4","gravatar_id":"","url":"https://api.github.com/users/pankona","html_url":"https://github.com/pankona","followers_url":"https://api.github.com/users/pankona/followers","following_url":"https://api.github.com/users/pankona/following{/other_user}","gists_url":"https://api.github.com/users/pankona/gists{/gist_id}","starred_url":"https://api.github.com/users/pankona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pankona/subscriptions","organizations_url":"https://api.github.com/users/pankona/orgs","repos_url":"https://api.github.com/users/pankona/repos","events_url":"https://api.github.com/users/pankona/events{/privacy}","received_events_url":"https://api.github.com/users/pankona/received_events","type":"User","site_admin":false},"body":"Hi, @hajimehoshi !\r\n\r\nI sometimes faced panic by index out of bounds in player.Close function.\r\nI don't see this problem in Linux, but only in OSX so far.\r\n\r\nfor the time being, I inserted checking length of p.bufs before its use.\r\nIt seems to help not to cause panic, but since I'm not sure the reason of index out of bounds occurs, i'm not sure this is applicable correction.\r\n\r\nI'm very happy if you give some comment!","created_at":"2017-08-02T07:46:25Z","updated_at":"2017-08-02T08:34:06Z","closed_at":"2017-08-02T08:34:06Z","merged_at":"2017-08-02T08:34:06Z","merge_commit_sha":"aa3e5edb663c133528796e77a28ef597d9dfd5d4","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/hajimehoshi/oto/pulls/24/commits","review_comments_url":"https://api.github.com/repos/hajimehoshi/oto/pulls/24/comments","review_comment_url":"https://api.github.com/repos/hajimehoshi/oto/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hajimehoshi/oto/issues/24/comments","statuses_url":"https://api.github.com/repos/hajimehoshi/oto/statuses/8908ca082e98da9bce2f0369a9324c8879f642de","head":{"label":"pankona:guard_openal_crash","ref":"guard_openal_crash","sha":"8908ca082e98da9bce2f0369a9324c8879f642de","user":{"login":"pankona","id":6533008,"avatar_url":"https://avatars3.githubusercontent.com/u/6533008?v=4","gravatar_id":"","url":"https://api.github.com/users/pankona","html_url":"https://github.com/pankona","followers_url":"https://api.github.com/users/pankona/followers","following_url":"https://api.github.com/users/pankona/following{/other_user}","gists_url":"https://api.github.com/users/pankona/gists{/gist_id}","starred_url":"https://api.github.com/users/pankona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pankona/subscriptions","organizations_url":"https://api.github.com/users/pankona/orgs","repos_url":"https://api.github.com/users/pankona/repos","events_url":"https://api.github.com/users/pankona/events{/privacy}","received_events_url":"https://api.github.com/users/pankona/received_events","type":"User","site_admin":false},"repo":{"id":99001785,"name":"oto","full_name":"pankona/oto","owner":{"login":"pankona","id":6533008,"avatar_url":"https://avatars3.githubusercontent.com/u/6533008?v=4","gravatar_id":"","url":"https://api.github.com/users/pankona","html_url":"https://github.com/pankona","followers_url":"https://api.github.com/users/pankona/followers","following_url":"https://api.github.com/users/pankona/following{/other_user}","gists_url":"https://api.github.com/users/pankona/gists{/gist_id}","starred_url":"https://api.github.com/users/pankona/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pankona/subscriptions","organizations_url":"https://api.github.com/users/pankona/orgs","repos_url":"https://api.github.com/users/pankona/repos","events_url":"https://api.github.com/users/pankona/events{/privacy}","received_events_url":"https://api.github.com/users/pankona/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/pankona/oto","description":"♪ A low-level library to play sound on multiple platforms ♪","fork":true,"url":"https://api.github.com/repos/pankona/oto","forks_url":"https://api.github.com/repos/pankona/oto/forks","keys_url":"https://api.github.com/repos/pankona/oto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pankona/oto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pankona/oto/teams","hooks_url":"https://api.github.com/repos/pankona/oto/hooks","issue_events_url":"https://api.github.com/repos/pankona/oto/issues/events{/number}","events_url":"https://api.github.com/repos/pankona/oto/events","assignees_url":"https://api.github.com/repos/pankona/oto/assignees{/user}","branches_url":"https://api.github.com/repos/pankona/oto/branches{/branch}","tags_url":"https://api.github.com/repos/pankona/oto/tags","blobs_url":"https://api.github.com/repos/pankona/oto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pankona/oto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pankona/oto/git/refs{/sha}","trees_url":"https://api.github.com/repos/pankona/oto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pankona/oto/statuses/{sha}","languages_url":"https://api.github.com/repos/pankona/oto/languages","stargazers_url":"https://api.github.com/repos/pankona/oto/stargazers","contributors_url":"https://api.github.com/repos/pankona/oto/contributors","subscribers_url":"https://api.github.com/repos/pankona/oto/subscribers","subscription_url":"https://api.github.com/repos/pankona/oto/subscription","commits_url":"https://api.github.com/repos/pankona/oto/commits{/sha}","git_commits_url":"https://api.github.com/repos/pankona/oto/git/commits{/sha}","comments_url":"https://api.github.com/repos/pankona/oto/comments{/number}","issue_comment_url":"https://api.github.com/repos/pankona/oto/issues/comments{/number}","contents_url":"https://api.github.com/repos/pankona/oto/contents/{+path}","compare_url":"https://api.github.com/repos/pankona/oto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pankona/oto/merges","archive_url":"https://api.github.com/repos/pankona/oto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pankona/oto/downloads","issues_url":"https://api.github.com/repos/pankona/oto/issues{/number}","pulls_url":"https://api.github.com/repos/pankona/oto/pulls{/number}","milestones_url":"https://api.github.com/repos/pankona/oto/milestones{/number}","notifications_url":"https://api.github.com/repos/pankona/oto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pankona/oto/labels{/name}","releases_url":"https://api.github.com/repos/pankona/oto/releases{/id}","deployments_url":"https://api.github.com/repos/pankona/oto/deployments","created_at":"2017-08-01T13:00:49Z","updated_at":"2017-08-01T13:00:51Z","pushed_at":"2017-08-02T05:48:36Z","git_url":"git://github.com/pankona/oto.git","ssh_url":"git@github.com:pankona/oto.git","clone_url":"https://github.com/pankona/oto.git","svn_url":"https://github.com/pankona/oto","homepage":"","size":57,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hajimehoshi:master","ref":"master","sha":"3f34faeeb68e18a9a7ae39056db4d4e117b805df","user":{"login":"hajimehoshi","id":16950,"avatar_url":"https://avatars2.githubusercontent.com/u/16950?v=4","gravatar_id":"","url":"https://api.github.com/users/hajimehoshi","html_url":"https://github.com/hajimehoshi","followers_url":"https://api.github.com/users/hajimehoshi/followers","following_url":"https://api.github.com/users/hajimehoshi/following{/other_user}","gists_url":"https://api.github.com/users/hajimehoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/hajimehoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hajimehoshi/subscriptions","organizations_url":"https://api.github.com/users/hajimehoshi/orgs","repos_url":"https://api.github.com/users/hajimehoshi/repos","events_url":"https://api.github.com/users/hajimehoshi/events{/privacy}","received_events_url":"https://api.github.com/users/hajimehoshi/received_events","type":"User","site_admin":false},"repo":{"id":90259571,"name":"oto","full_name":"hajimehoshi/oto","owner":{"login":"hajimehoshi","id":16950,"avatar_url":"https://avatars2.githubusercontent.com/u/16950?v=4","gravatar_id":"","url":"https://api.github.com/users/hajimehoshi","html_url":"https://github.com/hajimehoshi","followers_url":"https://api.github.com/users/hajimehoshi/followers","following_url":"https://api.github.com/users/hajimehoshi/following{/other_user}","gists_url":"https://api.github.com/users/hajimehoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/hajimehoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hajimehoshi/subscriptions","organizations_url":"https://api.github.com/users/hajimehoshi/orgs","repos_url":"https://api.github.com/users/hajimehoshi/repos","events_url":"https://api.github.com/users/hajimehoshi/events{/privacy}","received_events_url":"https://api.github.com/users/hajimehoshi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hajimehoshi/oto","description":"♪ A low-level library to play sound on multiple platforms ♪","fork":false,"url":"https://api.github.com/repos/hajimehoshi/oto","forks_url":"https://api.github.com/repos/hajimehoshi/oto/forks","keys_url":"https://api.github.com/repos/hajimehoshi/oto/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hajimehoshi/oto/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hajimehoshi/oto/teams","hooks_url":"https://api.github.com/repos/hajimehoshi/oto/hooks","issue_events_url":"https://api.github.com/repos/hajimehoshi/oto/issues/events{/number}","events_url":"https://api.github.com/repos/hajimehoshi/oto/events","assignees_url":"https://api.github.com/repos/hajimehoshi/oto/assignees{/user}","branches_url":"https://api.github.com/repos/hajimehoshi/oto/branches{/branch}","tags_url":"https://api.github.com/repos/hajimehoshi/oto/tags","blobs_url":"https://api.github.com/repos/hajimehoshi/oto/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hajimehoshi/oto/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hajimehoshi/oto/git/refs{/sha}","trees_url":"https://api.github.com/repos/hajimehoshi/oto/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hajimehoshi/oto/statuses/{sha}","languages_url":"https://api.github.com/repos/hajimehoshi/oto/languages","stargazers_url":"https://api.github.com/repos/hajimehoshi/oto/stargazers","contributors_url":"https://api.github.com/repos/hajimehoshi/oto/contributors","subscribers_url":"https://api.github.com/repos/hajimehoshi/oto/subscribers","subscription_url":"https://api.github.com/repos/hajimehoshi/oto/subscription","commits_url":"https://api.github.com/repos/hajimehoshi/oto/commits{/sha}","git_commits_url":"https://api.github.com/repos/hajimehoshi/oto/git/commits{/sha}","comments_url":"https://api.github.com/repos/hajimehoshi/oto/comments{/number}","issue_comment_url":"https://api.github.com/repos/hajimehoshi/oto/issues/comments{/number}","contents_url":"https://api.github.com/repos/hajimehoshi/oto/contents/{+path}","compare_url":"https://api.github.com/repos/hajimehoshi/oto/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hajimehoshi/oto/merges","archive_url":"https://api.github.com/repos/hajimehoshi/oto/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hajimehoshi/oto/downloads","issues_url":"https://api.github.com/repos/hajimehoshi/oto/issues{/number}","pulls_url":"https://api.github.com/repos/hajimehoshi/oto/pulls{/number}","milestones_url":"https://api.github.com/repos/hajimehoshi/oto/milestones{/number}","notifications_url":"https://api.github.com/repos/hajimehoshi/oto/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hajimehoshi/oto/labels{/name}","releases_url":"https://api.github.com/repos/hajimehoshi/oto/releases{/id}","deployments_url":"https://api.github.com/repos/hajimehoshi/oto/deployments","created_at":"2017-05-04T12:16:30Z","updated_at":"2017-08-01T23:30:19Z","pushed_at":"2017-08-02T08:34:06Z","git_url":"git://github.com/hajimehoshi/oto.git","ssh_url":"git@github.com:hajimehoshi/oto.git","clone_url":"https://github.com/hajimehoshi/oto.git","svn_url":"https://github.com/hajimehoshi/oto","homepage":"","size":68,"stargazers_count":72,"watchers_count":72,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"open_issues_count":7,"forks":10,"open_issues":7,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hajimehoshi/oto/pulls/24"},"html":{"href":"https://github.com/hajimehoshi/oto/pull/24"},"issue":{"href":"https://api.github.com/repos/hajimehoshi/oto/issues/24"},"comments":{"href":"https://api.github.com/repos/hajimehoshi/oto/issues/24/comments"},"review_comments":{"href":"https://api.github.com/repos/hajimehoshi/oto/pulls/24/comments"},"review_comment":{"href":"https://api.github.com/repos/hajimehoshi/oto/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hajimehoshi/oto/pulls/24/commits"},"statuses":{"href":"https://api.github.com/repos/hajimehoshi/oto/statuses/8908ca082e98da9bce2f0369a9324c8879f642de"}},"merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hajimehoshi","id":16950,"avatar_url":"https://avatars2.githubusercontent.com/u/16950?v=4","gravatar_id":"","url":"https://api.github.com/users/hajimehoshi","html_url":"https://github.com/hajimehoshi","followers_url":"https://api.github.com/users/hajimehoshi/followers","following_url":"https://api.github.com/users/hajimehoshi/following{/other_user}","gists_url":"https://api.github.com/users/hajimehoshi/gists{/gist_id}","starred_url":"https://api.github.com/users/hajimehoshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hajimehoshi/subscriptions","organizations_url":"https://api.github.com/users/hajimehoshi/orgs","repos_url":"https://api.github.com/users/hajimehoshi/repos","events_url":"https://api.github.com/users/hajimehoshi/events{/privacy}","received_events_url":"https://api.github.com/users/hajimehoshi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"hajimehoshi"}}