{"action":"opened","number":9721,"pull_request":{"url":"https://api.github.com/repos/numpy/numpy/pulls/9721","id":142154591,"html_url":"https://github.com/numpy/numpy/pull/9721","diff_url":"https://github.com/numpy/numpy/pull/9721.diff","patch_url":"https://github.com/numpy/numpy/pull/9721.patch","issue_url":"https://api.github.com/repos/numpy/numpy/issues/9721","number":9721,"state":"open","locked":false,"title":"MAINT: Fix compilation if HAVE_CEXPx is defined","user":{"login":"abrodkin","id":1618098,"avatar_url":"https://avatars3.githubusercontent.com/u/1618098?v=4","gravatar_id":"","url":"https://api.github.com/users/abrodkin","html_url":"https://github.com/abrodkin","followers_url":"https://api.github.com/users/abrodkin/followers","following_url":"https://api.github.com/users/abrodkin/following{/other_user}","gists_url":"https://api.github.com/users/abrodkin/gists{/gist_id}","starred_url":"https://api.github.com/users/abrodkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrodkin/subscriptions","organizations_url":"https://api.github.com/users/abrodkin/orgs","repos_url":"https://api.github.com/users/abrodkin/repos","events_url":"https://api.github.com/users/abrodkin/events{/privacy}","received_events_url":"https://api.github.com/users/abrodkin/received_events","type":"User","site_admin":false},"body":"Commit c15f7747c78e (\"MAINT: remove a bunch of compiler warnings\")\r\nbroke compilation if HAVE_CEXPx is defined with no good reason.\r\n\r\nThe problem is with defined HAVE_CEXPx _npy_scaled_cexp() is never\r\ndefined and compiler:\r\n 1) Reports implicitly declared function\r\n 2) Uses default return type \"int\" in equations like:\r\n      z = _npy_scaled_cexp@c@(absx, y, -1);\r\n    where z is \"@ctype@\" which might very well differ from int...\r\n 3) ... and finally throws an error, see:\r\n--------------------------->8------------------------\r\nnumpy/core/src/npymath/npy_math_complex.c.src: In function 'npy_ccoshl':\r\nnumpy/core/src/npymath/npy_math_complex.c.src:643:17: warning: implicit declaration of function '_npy_scaled_cexpl' [-Wimplicit-function-declaration]\r\n             z = _npy_scaled_cexp@c@(absx, y, -1);\r\n                 ^~~~~~~~~~~~~~~~~\r\nnumpy/core/src/npymath/npy_math_complex.c.src:643:15: error: incompatible types when assigning to type 'npy_clongdouble {aka struct <anonymous>}' from type 'int'\r\n             z = _npy_scaled_cexp@c@(absx, y, -1);\r\n--------------------------->8------------------------\r\n               ^","created_at":"2017-09-20T17:12:48Z","updated_at":"2017-09-20T17:12:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/numpy/numpy/pulls/9721/commits","review_comments_url":"https://api.github.com/repos/numpy/numpy/pulls/9721/comments","review_comment_url":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/numpy/numpy/issues/9721/comments","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/587e3f4239807131c963fe2294988b12ed7fdc6d","head":{"label":"abrodkin:topic-fix-compilation-with-have-cexp","ref":"topic-fix-compilation-with-have-cexp","sha":"587e3f4239807131c963fe2294988b12ed7fdc6d","user":{"login":"abrodkin","id":1618098,"avatar_url":"https://avatars3.githubusercontent.com/u/1618098?v=4","gravatar_id":"","url":"https://api.github.com/users/abrodkin","html_url":"https://github.com/abrodkin","followers_url":"https://api.github.com/users/abrodkin/followers","following_url":"https://api.github.com/users/abrodkin/following{/other_user}","gists_url":"https://api.github.com/users/abrodkin/gists{/gist_id}","starred_url":"https://api.github.com/users/abrodkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrodkin/subscriptions","organizations_url":"https://api.github.com/users/abrodkin/orgs","repos_url":"https://api.github.com/users/abrodkin/repos","events_url":"https://api.github.com/users/abrodkin/events{/privacy}","received_events_url":"https://api.github.com/users/abrodkin/received_events","type":"User","site_admin":false},"repo":{"id":103646626,"name":"numpy","full_name":"abrodkin/numpy","owner":{"login":"abrodkin","id":1618098,"avatar_url":"https://avatars3.githubusercontent.com/u/1618098?v=4","gravatar_id":"","url":"https://api.github.com/users/abrodkin","html_url":"https://github.com/abrodkin","followers_url":"https://api.github.com/users/abrodkin/followers","following_url":"https://api.github.com/users/abrodkin/following{/other_user}","gists_url":"https://api.github.com/users/abrodkin/gists{/gist_id}","starred_url":"https://api.github.com/users/abrodkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abrodkin/subscriptions","organizations_url":"https://api.github.com/users/abrodkin/orgs","repos_url":"https://api.github.com/users/abrodkin/repos","events_url":"https://api.github.com/users/abrodkin/events{/privacy}","received_events_url":"https://api.github.com/users/abrodkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abrodkin/numpy","description":"Numpy main repository","fork":true,"url":"https://api.github.com/repos/abrodkin/numpy","forks_url":"https://api.github.com/repos/abrodkin/numpy/forks","keys_url":"https://api.github.com/repos/abrodkin/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abrodkin/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abrodkin/numpy/teams","hooks_url":"https://api.github.com/repos/abrodkin/numpy/hooks","issue_events_url":"https://api.github.com/repos/abrodkin/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/abrodkin/numpy/events","assignees_url":"https://api.github.com/repos/abrodkin/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/abrodkin/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/abrodkin/numpy/tags","blobs_url":"https://api.github.com/repos/abrodkin/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abrodkin/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abrodkin/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/abrodkin/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abrodkin/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/abrodkin/numpy/languages","stargazers_url":"https://api.github.com/repos/abrodkin/numpy/stargazers","contributors_url":"https://api.github.com/repos/abrodkin/numpy/contributors","subscribers_url":"https://api.github.com/repos/abrodkin/numpy/subscribers","subscription_url":"https://api.github.com/repos/abrodkin/numpy/subscription","commits_url":"https://api.github.com/repos/abrodkin/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/abrodkin/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/abrodkin/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/abrodkin/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/abrodkin/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/abrodkin/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abrodkin/numpy/merges","archive_url":"https://api.github.com/repos/abrodkin/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abrodkin/numpy/downloads","issues_url":"https://api.github.com/repos/abrodkin/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/abrodkin/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/abrodkin/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/abrodkin/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abrodkin/numpy/labels{/name}","releases_url":"https://api.github.com/repos/abrodkin/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/abrodkin/numpy/deployments","created_at":"2017-09-15T10:48:19Z","updated_at":"2017-09-15T10:48:26Z","pushed_at":"2017-09-20T16:15:48Z","git_url":"git://github.com/abrodkin/numpy.git","ssh_url":"git@github.com:abrodkin/numpy.git","clone_url":"https://github.com/abrodkin/numpy.git","svn_url":"https://github.com/abrodkin/numpy","homepage":"http://www.numpy.org/","size":51020,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"numpy:master","ref":"master","sha":"76cabbbf3b985631212cba6b164c4bac3d2d42c2","user":{"login":"numpy","id":288276,"avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"repo":{"id":908607,"name":"numpy","full_name":"numpy/numpy","owner":{"login":"numpy","id":288276,"avatar_url":"https://avatars2.githubusercontent.com/u/288276?v=4","gravatar_id":"","url":"https://api.github.com/users/numpy","html_url":"https://github.com/numpy","followers_url":"https://api.github.com/users/numpy/followers","following_url":"https://api.github.com/users/numpy/following{/other_user}","gists_url":"https://api.github.com/users/numpy/gists{/gist_id}","starred_url":"https://api.github.com/users/numpy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/numpy/subscriptions","organizations_url":"https://api.github.com/users/numpy/orgs","repos_url":"https://api.github.com/users/numpy/repos","events_url":"https://api.github.com/users/numpy/events{/privacy}","received_events_url":"https://api.github.com/users/numpy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/numpy/numpy","description":"Numpy main repository","fork":false,"url":"https://api.github.com/repos/numpy/numpy","forks_url":"https://api.github.com/repos/numpy/numpy/forks","keys_url":"https://api.github.com/repos/numpy/numpy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/numpy/numpy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/numpy/numpy/teams","hooks_url":"https://api.github.com/repos/numpy/numpy/hooks","issue_events_url":"https://api.github.com/repos/numpy/numpy/issues/events{/number}","events_url":"https://api.github.com/repos/numpy/numpy/events","assignees_url":"https://api.github.com/repos/numpy/numpy/assignees{/user}","branches_url":"https://api.github.com/repos/numpy/numpy/branches{/branch}","tags_url":"https://api.github.com/repos/numpy/numpy/tags","blobs_url":"https://api.github.com/repos/numpy/numpy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/numpy/numpy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/numpy/numpy/git/refs{/sha}","trees_url":"https://api.github.com/repos/numpy/numpy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/numpy/numpy/statuses/{sha}","languages_url":"https://api.github.com/repos/numpy/numpy/languages","stargazers_url":"https://api.github.com/repos/numpy/numpy/stargazers","contributors_url":"https://api.github.com/repos/numpy/numpy/contributors","subscribers_url":"https://api.github.com/repos/numpy/numpy/subscribers","subscription_url":"https://api.github.com/repos/numpy/numpy/subscription","commits_url":"https://api.github.com/repos/numpy/numpy/commits{/sha}","git_commits_url":"https://api.github.com/repos/numpy/numpy/git/commits{/sha}","comments_url":"https://api.github.com/repos/numpy/numpy/comments{/number}","issue_comment_url":"https://api.github.com/repos/numpy/numpy/issues/comments{/number}","contents_url":"https://api.github.com/repos/numpy/numpy/contents/{+path}","compare_url":"https://api.github.com/repos/numpy/numpy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/numpy/numpy/merges","archive_url":"https://api.github.com/repos/numpy/numpy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/numpy/numpy/downloads","issues_url":"https://api.github.com/repos/numpy/numpy/issues{/number}","pulls_url":"https://api.github.com/repos/numpy/numpy/pulls{/number}","milestones_url":"https://api.github.com/repos/numpy/numpy/milestones{/number}","notifications_url":"https://api.github.com/repos/numpy/numpy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/numpy/numpy/labels{/name}","releases_url":"https://api.github.com/repos/numpy/numpy/releases{/id}","deployments_url":"https://api.github.com/repos/numpy/numpy/deployments","created_at":"2010-09-13T23:02:39Z","updated_at":"2017-09-20T13:34:31Z","pushed_at":"2017-09-20T16:59:46Z","git_url":"git://github.com/numpy/numpy.git","ssh_url":"git@github.com:numpy/numpy.git","clone_url":"https://github.com/numpy/numpy.git","svn_url":"https://github.com/numpy/numpy","homepage":"http://www.numpy.org/","size":52334,"stargazers_count":5046,"watchers_count":5046,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2245,"mirror_url":null,"open_issues_count":1695,"forks":2245,"open_issues":1695,"watchers":5046,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/numpy/numpy/pulls/9721"},"html":{"href":"https://github.com/numpy/numpy/pull/9721"},"issue":{"href":"https://api.github.com/repos/numpy/numpy/issues/9721"},"comments":{"href":"https://api.github.com/repos/numpy/numpy/issues/9721/comments"},"review_comments":{"href":"https://api.github.com/repos/numpy/numpy/pulls/9721/comments"},"review_comment":{"href":"https://api.github.com/repos/numpy/numpy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/numpy/numpy/pulls/9721/commits"},"statuses":{"href":"https://api.github.com/repos/numpy/numpy/statuses/587e3f4239807131c963fe2294988b12ed7fdc6d"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"abrodkin"}}