{"action":"created","comment":{"url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/comments/107109267","pull_request_review_id":28059969,"id":107109267,"diff_hunk":"@@ -59,13 +59,17 @@ Ext.define('Modera.backend.googleanalytics.profiling.GABackend', {\n         }\n \n         if (target instanceof MF.activation.activities.AbstractActivity) {\n-            ga('send', {\n-                hitType: 'timing',\n-                timingCategory: 'MJR',\n-                timingVar: this.trackingPlugin.createToken(),\n-                timingLabel: 'View activation',\n-                timingValue: ms\n-            });\n+            if (typeof ga !== 'undefined') {","path":"Resources/public/js/profiling/GABackend.js","position":11,"original_position":11,"commit_id":"dec8ce39b81119533f1941872c12a875fac0476e","original_commit_id":"dec8ce39b81119533f1941872c12a875fac0476e","user":{"login":"sergeil","id":425579,"avatar_url":"https://avatars2.githubusercontent.com/u/425579?v=3","gravatar_id":"","url":"https://api.github.com/users/sergeil","html_url":"https://github.com/sergeil","followers_url":"https://api.github.com/users/sergeil/followers","following_url":"https://api.github.com/users/sergeil/following{/other_user}","gists_url":"https://api.github.com/users/sergeil/gists{/gist_id}","starred_url":"https://api.github.com/users/sergeil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergeil/subscriptions","organizations_url":"https://api.github.com/users/sergeil/orgs","repos_url":"https://api.github.com/users/sergeil/repos","events_url":"https://api.github.com/users/sergeil/events{/privacy}","received_events_url":"https://api.github.com/users/sergeil/received_events","type":"User","site_admin":false},"body":"This won't cut it. If you look below in the method, you will see a second invocation of ga() method. Create a delegate method in this class that would check in a single place if ga() is globally defined and invoke it, otherwise just, say, ignore.","created_at":"2017-03-21T09:37:40Z","updated_at":"2017-03-21T09:38:05Z","html_url":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle/pull/2#discussion_r107109267","pull_request_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/2","_links":{"self":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/comments/107109267"},"html":{"href":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle/pull/2#discussion_r107109267"},"pull_request":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/2","id":111734941,"html_url":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle/pull/2","diff_url":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle/pull/2.diff","patch_url":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle/pull/2.patch","issue_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/issues/2","number":2,"state":"open","locked":false,"title":"Fix to GA time reporting when no token is provided","user":{"login":"NecessaryEvil90","id":15425112,"avatar_url":"https://avatars3.githubusercontent.com/u/15425112?v=3","gravatar_id":"","url":"https://api.github.com/users/NecessaryEvil90","html_url":"https://github.com/NecessaryEvil90","followers_url":"https://api.github.com/users/NecessaryEvil90/followers","following_url":"https://api.github.com/users/NecessaryEvil90/following{/other_user}","gists_url":"https://api.github.com/users/NecessaryEvil90/gists{/gist_id}","starred_url":"https://api.github.com/users/NecessaryEvil90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NecessaryEvil90/subscriptions","organizations_url":"https://api.github.com/users/NecessaryEvil90/orgs","repos_url":"https://api.github.com/users/NecessaryEvil90/repos","events_url":"https://api.github.com/users/NecessaryEvil90/events{/privacy}","received_events_url":"https://api.github.com/users/NecessaryEvil90/received_events","type":"User","site_admin":false},"body":"","created_at":"2017-03-21T09:33:27Z","updated_at":"2017-03-21T09:38:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bb81495a5672e29760045bfd337f3193ccc449c","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/2/commits","review_comments_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/2/comments","review_comment_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/issues/2/comments","statuses_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/statuses/dec8ce39b81119533f1941872c12a875fac0476e","head":{"label":"NecessaryEvil90:FiXToUndefinedGa","ref":"FiXToUndefinedGa","sha":"dec8ce39b81119533f1941872c12a875fac0476e","user":{"login":"NecessaryEvil90","id":15425112,"avatar_url":"https://avatars3.githubusercontent.com/u/15425112?v=3","gravatar_id":"","url":"https://api.github.com/users/NecessaryEvil90","html_url":"https://github.com/NecessaryEvil90","followers_url":"https://api.github.com/users/NecessaryEvil90/followers","following_url":"https://api.github.com/users/NecessaryEvil90/following{/other_user}","gists_url":"https://api.github.com/users/NecessaryEvil90/gists{/gist_id}","starred_url":"https://api.github.com/users/NecessaryEvil90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NecessaryEvil90/subscriptions","organizations_url":"https://api.github.com/users/NecessaryEvil90/orgs","repos_url":"https://api.github.com/users/NecessaryEvil90/repos","events_url":"https://api.github.com/users/NecessaryEvil90/events{/privacy}","received_events_url":"https://api.github.com/users/NecessaryEvil90/received_events","type":"User","site_admin":false},"repo":{"id":85682177,"name":"ModeraBackendGoogleAnalyticsBundle","full_name":"NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle","owner":{"login":"NecessaryEvil90","id":15425112,"avatar_url":"https://avatars3.githubusercontent.com/u/15425112?v=3","gravatar_id":"","url":"https://api.github.com/users/NecessaryEvil90","html_url":"https://github.com/NecessaryEvil90","followers_url":"https://api.github.com/users/NecessaryEvil90/followers","following_url":"https://api.github.com/users/NecessaryEvil90/following{/other_user}","gists_url":"https://api.github.com/users/NecessaryEvil90/gists{/gist_id}","starred_url":"https://api.github.com/users/NecessaryEvil90/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NecessaryEvil90/subscriptions","organizations_url":"https://api.github.com/users/NecessaryEvil90/orgs","repos_url":"https://api.github.com/users/NecessaryEvil90/repos","events_url":"https://api.github.com/users/NecessaryEvil90/events{/privacy}","received_events_url":"https://api.github.com/users/NecessaryEvil90/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle","description":"Provides support for gathering 'pageview' analytics in backend using Google Analytics.","fork":true,"url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle","forks_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/forks","keys_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/teams","hooks_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/hooks","issue_events_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/issues/events{/number}","events_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/events","assignees_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/assignees{/user}","branches_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/branches{/branch}","tags_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/tags","blobs_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/languages","stargazers_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/stargazers","contributors_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/contributors","subscribers_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/subscribers","subscription_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/subscription","commits_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/contents/{+path}","compare_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/merges","archive_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/downloads","issues_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/issues{/number}","pulls_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/labels{/name}","releases_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/releases{/id}","deployments_url":"https://api.github.com/repos/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle/deployments","created_at":"2017-03-21T09:21:10Z","updated_at":"2017-03-21T09:21:12Z","pushed_at":"2017-03-21T09:32:45Z","git_url":"git://github.com/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle.git","ssh_url":"git@github.com:NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle.git","clone_url":"https://github.com/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle.git","svn_url":"https://github.com/NecessaryEvil90/ModeraBackendGoogleAnalyticsBundle","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"modera:master","ref":"master","sha":"526b30d8016c4b2c126fc07162a387e41541218e","user":{"login":"modera","id":6311198,"avatar_url":"https://avatars0.githubusercontent.com/u/6311198?v=3","gravatar_id":"","url":"https://api.github.com/users/modera","html_url":"https://github.com/modera","followers_url":"https://api.github.com/users/modera/followers","following_url":"https://api.github.com/users/modera/following{/other_user}","gists_url":"https://api.github.com/users/modera/gists{/gist_id}","starred_url":"https://api.github.com/users/modera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modera/subscriptions","organizations_url":"https://api.github.com/users/modera/orgs","repos_url":"https://api.github.com/users/modera/repos","events_url":"https://api.github.com/users/modera/events{/privacy}","received_events_url":"https://api.github.com/users/modera/received_events","type":"Organization","site_admin":false},"repo":{"id":49496662,"name":"ModeraBackendGoogleAnalyticsBundle","full_name":"modera/ModeraBackendGoogleAnalyticsBundle","owner":{"login":"modera","id":6311198,"avatar_url":"https://avatars0.githubusercontent.com/u/6311198?v=3","gravatar_id":"","url":"https://api.github.com/users/modera","html_url":"https://github.com/modera","followers_url":"https://api.github.com/users/modera/followers","following_url":"https://api.github.com/users/modera/following{/other_user}","gists_url":"https://api.github.com/users/modera/gists{/gist_id}","starred_url":"https://api.github.com/users/modera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modera/subscriptions","organizations_url":"https://api.github.com/users/modera/orgs","repos_url":"https://api.github.com/users/modera/repos","events_url":"https://api.github.com/users/modera/events{/privacy}","received_events_url":"https://api.github.com/users/modera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle","description":"Provides support for gathering 'pageview' analytics in backend using Google Analytics.","fork":false,"url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle","forks_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/forks","keys_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/teams","hooks_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/hooks","issue_events_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/issues/events{/number}","events_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/events","assignees_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/assignees{/user}","branches_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/branches{/branch}","tags_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/tags","blobs_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/statuses/{sha}","languages_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/languages","stargazers_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/stargazers","contributors_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/contributors","subscribers_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/subscribers","subscription_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/subscription","commits_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/contents/{+path}","compare_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/merges","archive_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/downloads","issues_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/issues{/number}","pulls_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls{/number}","milestones_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/milestones{/number}","notifications_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/labels{/name}","releases_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/releases{/id}","deployments_url":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/deployments","created_at":"2016-01-12T11:45:24Z","updated_at":"2016-01-12T15:00:24Z","pushed_at":"2017-03-21T09:33:28Z","git_url":"git://github.com/modera/ModeraBackendGoogleAnalyticsBundle.git","ssh_url":"git@github.com:modera/ModeraBackendGoogleAnalyticsBundle.git","clone_url":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle.git","svn_url":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle","homepage":null,"size":41,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"open_issues_count":1,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/2"},"html":{"href":"https://github.com/modera/ModeraBackendGoogleAnalyticsBundle/pull/2"},"issue":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/issues/2"},"comments":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/modera/ModeraBackendGoogleAnalyticsBundle/statuses/dec8ce39b81119533f1941872c12a875fac0476e"}}}}
{"actor":{"display_login":"sergeil"}}