{"action":"opened","number":56,"pull_request":{"url":"https://api.github.com/repos/legislated/legislated-web/pulls/56","id":153405717,"html_url":"https://github.com/legislated/legislated-web/pull/56","diff_url":"https://github.com/legislated/legislated-web/pull/56.diff","patch_url":"https://github.com/legislated/legislated-web/pull/56.patch","issue_url":"https://api.github.com/repos/legislated/legislated-web/issues/56","number":56,"state":"open","locked":false,"title":"New header","user":{"login":"davemcorwin","id":6662371,"avatar_url":"https://avatars1.githubusercontent.com/u/6662371?v=4","gravatar_id":"","url":"https://api.github.com/users/davemcorwin","html_url":"https://github.com/davemcorwin","followers_url":"https://api.github.com/users/davemcorwin/followers","following_url":"https://api.github.com/users/davemcorwin/following{/other_user}","gists_url":"https://api.github.com/users/davemcorwin/gists{/gist_id}","starred_url":"https://api.github.com/users/davemcorwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davemcorwin/subscriptions","organizations_url":"https://api.github.com/users/davemcorwin/orgs","repos_url":"https://api.github.com/users/davemcorwin/repos","events_url":"https://api.github.com/users/davemcorwin/events{/privacy}","received_events_url":"https://api.github.com/users/davemcorwin/received_events","type":"User","site_admin":false},"body":"@wzrad This is ready to be evaluated. A couple notes:\r\n\r\n1. The behavior is a little different when the desktop header 'sticks'. I moved the nav items to the right and removed the fading in. This is to better handle a variable number of nav links and screen sizes. The fading is removed because I would have to do a lot of magic to do it with the nav links as well since they are moving and I thought it might be a little weird if only part fades in.\r\n\r\n2. This is using `emotion` for the styles. I'll save my general thoughts for a different thread, but it is possible to port everything over the emotion using the object based styles that currently exist by using the `css` function if we want to.\r\n\r\n3. Navigating when the header is 'sticky' feels a little wonky because it scrolls to the top of the page, we may want to see i we can maintain a min scroll on navigation that keeps the header in the 'sticky' position.\r\n\r\n4. Fonts are waiting on https://trello.com/c/BF31twil/3-add-custom-fonts\r\n\r\n5. The code from React Sticky is now in the app explicitly, but currently depends on `prop-types` and is in need of flow types.\r\n\r\n6. Could probably use a bit of refactoring, ex. moving `DesktopHeader`, `MobileHeader`, etc into their own files. When everything else looks good, I will do this.\r\n","created_at":"2017-11-17T22:12:50Z","updated_at":"2017-11-17T22:12:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/legislated/legislated-web/pulls/56/commits","review_comments_url":"https://api.github.com/repos/legislated/legislated-web/pulls/56/comments","review_comment_url":"https://api.github.com/repos/legislated/legislated-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/legislated/legislated-web/issues/56/comments","statuses_url":"https://api.github.com/repos/legislated/legislated-web/statuses/bb60511236797fbaf6b680c08d09ce4d109128c5","head":{"label":"legislated:new-header","ref":"new-header","sha":"bb60511236797fbaf6b680c08d09ce4d109128c5","user":{"login":"legislated","id":26589469,"avatar_url":"https://avatars0.githubusercontent.com/u/26589469?v=4","gravatar_id":"","url":"https://api.github.com/users/legislated","html_url":"https://github.com/legislated","followers_url":"https://api.github.com/users/legislated/followers","following_url":"https://api.github.com/users/legislated/following{/other_user}","gists_url":"https://api.github.com/users/legislated/gists{/gist_id}","starred_url":"https://api.github.com/users/legislated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legislated/subscriptions","organizations_url":"https://api.github.com/users/legislated/orgs","repos_url":"https://api.github.com/users/legislated/repos","events_url":"https://api.github.com/users/legislated/events{/privacy}","received_events_url":"https://api.github.com/users/legislated/received_events","type":"Organization","site_admin":false},"repo":{"id":85785289,"name":"legislated-web","full_name":"legislated/legislated-web","owner":{"login":"legislated","id":26589469,"avatar_url":"https://avatars0.githubusercontent.com/u/26589469?v=4","gravatar_id":"","url":"https://api.github.com/users/legislated","html_url":"https://github.com/legislated","followers_url":"https://api.github.com/users/legislated/followers","following_url":"https://api.github.com/users/legislated/following{/other_user}","gists_url":"https://api.github.com/users/legislated/gists{/gist_id}","starred_url":"https://api.github.com/users/legislated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legislated/subscriptions","organizations_url":"https://api.github.com/users/legislated/orgs","repos_url":"https://api.github.com/users/legislated/repos","events_url":"https://api.github.com/users/legislated/events{/privacy}","received_events_url":"https://api.github.com/users/legislated/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/legislated/legislated-web","description":"legislated api & website","fork":false,"url":"https://api.github.com/repos/legislated/legislated-web","forks_url":"https://api.github.com/repos/legislated/legislated-web/forks","keys_url":"https://api.github.com/repos/legislated/legislated-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legislated/legislated-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legislated/legislated-web/teams","hooks_url":"https://api.github.com/repos/legislated/legislated-web/hooks","issue_events_url":"https://api.github.com/repos/legislated/legislated-web/issues/events{/number}","events_url":"https://api.github.com/repos/legislated/legislated-web/events","assignees_url":"https://api.github.com/repos/legislated/legislated-web/assignees{/user}","branches_url":"https://api.github.com/repos/legislated/legislated-web/branches{/branch}","tags_url":"https://api.github.com/repos/legislated/legislated-web/tags","blobs_url":"https://api.github.com/repos/legislated/legislated-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legislated/legislated-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legislated/legislated-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/legislated/legislated-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legislated/legislated-web/statuses/{sha}","languages_url":"https://api.github.com/repos/legislated/legislated-web/languages","stargazers_url":"https://api.github.com/repos/legislated/legislated-web/stargazers","contributors_url":"https://api.github.com/repos/legislated/legislated-web/contributors","subscribers_url":"https://api.github.com/repos/legislated/legislated-web/subscribers","subscription_url":"https://api.github.com/repos/legislated/legislated-web/subscription","commits_url":"https://api.github.com/repos/legislated/legislated-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/legislated/legislated-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/legislated/legislated-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/legislated/legislated-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/legislated/legislated-web/contents/{+path}","compare_url":"https://api.github.com/repos/legislated/legislated-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legislated/legislated-web/merges","archive_url":"https://api.github.com/repos/legislated/legislated-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legislated/legislated-web/downloads","issues_url":"https://api.github.com/repos/legislated/legislated-web/issues{/number}","pulls_url":"https://api.github.com/repos/legislated/legislated-web/pulls{/number}","milestones_url":"https://api.github.com/repos/legislated/legislated-web/milestones{/number}","notifications_url":"https://api.github.com/repos/legislated/legislated-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legislated/legislated-web/labels{/name}","releases_url":"https://api.github.com/repos/legislated/legislated-web/releases{/id}","deployments_url":"https://api.github.com/repos/legislated/legislated-web/deployments","created_at":"2017-03-22T04:34:18Z","updated_at":"2017-11-11T17:00:34Z","pushed_at":"2017-11-17T22:11:48Z","git_url":"git://github.com/legislated/legislated-web.git","ssh_url":"git@github.com:legislated/legislated-web.git","clone_url":"https://github.com/legislated/legislated-web.git","svn_url":"https://github.com/legislated/legislated-web","homepage":"https://legislated.org","size":1190,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"legislated:master","ref":"master","sha":"34e4ec2f015d5e59588703b3ba5cf8b17a71ea53","user":{"login":"legislated","id":26589469,"avatar_url":"https://avatars0.githubusercontent.com/u/26589469?v=4","gravatar_id":"","url":"https://api.github.com/users/legislated","html_url":"https://github.com/legislated","followers_url":"https://api.github.com/users/legislated/followers","following_url":"https://api.github.com/users/legislated/following{/other_user}","gists_url":"https://api.github.com/users/legislated/gists{/gist_id}","starred_url":"https://api.github.com/users/legislated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legislated/subscriptions","organizations_url":"https://api.github.com/users/legislated/orgs","repos_url":"https://api.github.com/users/legislated/repos","events_url":"https://api.github.com/users/legislated/events{/privacy}","received_events_url":"https://api.github.com/users/legislated/received_events","type":"Organization","site_admin":false},"repo":{"id":85785289,"name":"legislated-web","full_name":"legislated/legislated-web","owner":{"login":"legislated","id":26589469,"avatar_url":"https://avatars0.githubusercontent.com/u/26589469?v=4","gravatar_id":"","url":"https://api.github.com/users/legislated","html_url":"https://github.com/legislated","followers_url":"https://api.github.com/users/legislated/followers","following_url":"https://api.github.com/users/legislated/following{/other_user}","gists_url":"https://api.github.com/users/legislated/gists{/gist_id}","starred_url":"https://api.github.com/users/legislated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/legislated/subscriptions","organizations_url":"https://api.github.com/users/legislated/orgs","repos_url":"https://api.github.com/users/legislated/repos","events_url":"https://api.github.com/users/legislated/events{/privacy}","received_events_url":"https://api.github.com/users/legislated/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/legislated/legislated-web","description":"legislated api & website","fork":false,"url":"https://api.github.com/repos/legislated/legislated-web","forks_url":"https://api.github.com/repos/legislated/legislated-web/forks","keys_url":"https://api.github.com/repos/legislated/legislated-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/legislated/legislated-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/legislated/legislated-web/teams","hooks_url":"https://api.github.com/repos/legislated/legislated-web/hooks","issue_events_url":"https://api.github.com/repos/legislated/legislated-web/issues/events{/number}","events_url":"https://api.github.com/repos/legislated/legislated-web/events","assignees_url":"https://api.github.com/repos/legislated/legislated-web/assignees{/user}","branches_url":"https://api.github.com/repos/legislated/legislated-web/branches{/branch}","tags_url":"https://api.github.com/repos/legislated/legislated-web/tags","blobs_url":"https://api.github.com/repos/legislated/legislated-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/legislated/legislated-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/legislated/legislated-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/legislated/legislated-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/legislated/legislated-web/statuses/{sha}","languages_url":"https://api.github.com/repos/legislated/legislated-web/languages","stargazers_url":"https://api.github.com/repos/legislated/legislated-web/stargazers","contributors_url":"https://api.github.com/repos/legislated/legislated-web/contributors","subscribers_url":"https://api.github.com/repos/legislated/legislated-web/subscribers","subscription_url":"https://api.github.com/repos/legislated/legislated-web/subscription","commits_url":"https://api.github.com/repos/legislated/legislated-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/legislated/legislated-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/legislated/legislated-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/legislated/legislated-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/legislated/legislated-web/contents/{+path}","compare_url":"https://api.github.com/repos/legislated/legislated-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/legislated/legislated-web/merges","archive_url":"https://api.github.com/repos/legislated/legislated-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/legislated/legislated-web/downloads","issues_url":"https://api.github.com/repos/legislated/legislated-web/issues{/number}","pulls_url":"https://api.github.com/repos/legislated/legislated-web/pulls{/number}","milestones_url":"https://api.github.com/repos/legislated/legislated-web/milestones{/number}","notifications_url":"https://api.github.com/repos/legislated/legislated-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/legislated/legislated-web/labels{/name}","releases_url":"https://api.github.com/repos/legislated/legislated-web/releases{/id}","deployments_url":"https://api.github.com/repos/legislated/legislated-web/deployments","created_at":"2017-03-22T04:34:18Z","updated_at":"2017-11-11T17:00:34Z","pushed_at":"2017-11-17T22:11:48Z","git_url":"git://github.com/legislated/legislated-web.git","ssh_url":"git@github.com:legislated/legislated-web.git","clone_url":"https://github.com/legislated/legislated-web.git","svn_url":"https://github.com/legislated/legislated-web","homepage":"https://legislated.org","size":1190,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"forks":5,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/legislated/legislated-web/pulls/56"},"html":{"href":"https://github.com/legislated/legislated-web/pull/56"},"issue":{"href":"https://api.github.com/repos/legislated/legislated-web/issues/56"},"comments":{"href":"https://api.github.com/repos/legislated/legislated-web/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/legislated/legislated-web/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/legislated/legislated-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/legislated/legislated-web/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/legislated/legislated-web/statuses/bb60511236797fbaf6b680c08d09ce4d109128c5"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":510,"deletions":88,"changed_files":12}}
{"actor":{"display_login":"davemcorwin"}}