{"action":"closed","issue":{"url":"https://api.github.com/repos/apankrat/dnswhisperer/issues/1","repository_url":"https://api.github.com/repos/apankrat/dnswhisperer","labels_url":"https://api.github.com/repos/apankrat/dnswhisperer/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/apankrat/dnswhisperer/issues/1/comments","events_url":"https://api.github.com/repos/apankrat/dnswhisperer/issues/1/events","html_url":"https://github.com/apankrat/dnswhisperer/issues/1","id":185648195,"number":1,"title":"Questions","user":{"login":"a7ypically","id":22150757,"avatar_url":"https://avatars1.githubusercontent.com/u/22150757?v=3","gravatar_id":"","url":"https://api.github.com/users/a7ypically","html_url":"https://github.com/a7ypically","followers_url":"https://api.github.com/users/a7ypically/followers","following_url":"https://api.github.com/users/a7ypically/following{/other_user}","gists_url":"https://api.github.com/users/a7ypically/gists{/gist_id}","starred_url":"https://api.github.com/users/a7ypically/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a7ypically/subscriptions","organizations_url":"https://api.github.com/users/a7ypically/orgs","repos_url":"https://api.github.com/users/a7ypically/repos","events_url":"https://api.github.com/users/a7ypically/events{/privacy}","received_events_url":"https://api.github.com/users/a7ypically/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2016-10-27T11:58:20Z","updated_at":"2017-06-26T08:49:54Z","closed_at":"2017-06-26T08:49:54Z","body":"Hi,\n\nThanks for this code. I plan to use it to filter AAAA queries as I don't have ipv6 and it's just a waste as all clients do ask for ipv6 addresses.\n\nLooking at the code I think I see a few issues:\n- When iterating requests, if one request has multiple queries in it, you do iterate all of them but as soon as one matches a filter you set nope_it to true and then all the rest of the queries in that request will be filtered though I assume they may have other names in them.\n- When you do filter a request, why do you send the request to the real server instead of immediately sending a response to the client that it is not found?\n- There is no overflow handling in the pending requests array. So if the server gets more requests than the size of the array it will overrun the first requests and the clients will not get a response. I think it's better to track the current number of pending requests and if there's an overflow print a warning and drop the new request.\n\nAnyway, this is very useful for me so thanks a lot for sharing your code!\n"}}
{"actor":{"display_login":"apankrat"}}