{"action":"created","comment":{"url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/comments/106405076","pull_request_review_id":27323931,"id":106405076,"diff_hunk":"@@ -18,7 +18,8 @@ @interface BCDownloadManager ()\n /// The dictionary containing the currently active tasks. Tasks are removed when they have completed.\n @property (nonatomic, strong) NSMutableDictionary <NSString *, NSURLSessionDownloadTask *> *downloadingTasks;\n \n-@property (nonatomic, strong) id <BCDownloadManagerDelegate> delegate;\n+/// The download manager delegate.\n+@property (nonatomic, weak) id <BCDownloadManagerDelegate> delegate;","path":"Source/BCDownloadManager.m","position":6,"original_position":6,"commit_id":"97fa388872cedff918259cf106e9ff259b7a4655","original_commit_id":"97fa388872cedff918259cf106e9ff259b7a4655","user":{"login":"mikeabdullah","id":165011,"avatar_url":"https://avatars1.githubusercontent.com/u/165011?v=3","gravatar_id":"","url":"https://api.github.com/users/mikeabdullah","html_url":"https://github.com/mikeabdullah","followers_url":"https://api.github.com/users/mikeabdullah/followers","following_url":"https://api.github.com/users/mikeabdullah/following{/other_user}","gists_url":"https://api.github.com/users/mikeabdullah/gists{/gist_id}","starred_url":"https://api.github.com/users/mikeabdullah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikeabdullah/subscriptions","organizations_url":"https://api.github.com/users/mikeabdullah/orgs","repos_url":"https://api.github.com/users/mikeabdullah/repos","events_url":"https://api.github.com/users/mikeabdullah/events{/privacy}","received_events_url":"https://api.github.com/users/mikeabdullah/received_events","type":"User","site_admin":false},"body":"Are you sure we want to do this? The API of `BCDownloadManager` looks to me like it's closely modelled on `NSURLSession`. `NSURLSession` has a strong delegate because of the asynchronous way it operates. There's no need to think about what happens if the delegate goes away or changes during the operation. Instead it's fixed for the lifetime of the op.\r\n\r\nOnce all ops are over and the session/manager invalidated, then the delegate is dropped, breaking any retain cycle.","created_at":"2017-03-16T12:32:40Z","updated_at":"2017-03-16T12:33:24Z","html_url":"https://github.com/BohemianCoding/BCFoundation/pull/110#discussion_r106405076","pull_request_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/110","_links":{"self":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/comments/106405076"},"html":{"href":"https://github.com/BohemianCoding/BCFoundation/pull/110#discussion_r106405076"},"pull_request":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/110"}}},"pull_request":{"url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/110","id":110156975,"html_url":"https://github.com/BohemianCoding/BCFoundation/pull/110","diff_url":"https://github.com/BohemianCoding/BCFoundation/pull/110.diff","patch_url":"https://github.com/BohemianCoding/BCFoundation/pull/110.patch","issue_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/110","number":110,"state":"open","locked":false,"title":"Code Review: Implement plugin manager API - Installing Updates (#12067)","user":{"login":"SheffieldKevin","id":1265218,"avatar_url":"https://avatars2.githubusercontent.com/u/1265218?v=3","gravatar_id":"","url":"https://api.github.com/users/SheffieldKevin","html_url":"https://github.com/SheffieldKevin","followers_url":"https://api.github.com/users/SheffieldKevin/followers","following_url":"https://api.github.com/users/SheffieldKevin/following{/other_user}","gists_url":"https://api.github.com/users/SheffieldKevin/gists{/gist_id}","starred_url":"https://api.github.com/users/SheffieldKevin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SheffieldKevin/subscriptions","organizations_url":"https://api.github.com/users/SheffieldKevin/orgs","repos_url":"https://api.github.com/users/SheffieldKevin/repos","events_url":"https://api.github.com/users/SheffieldKevin/events{/privacy}","received_events_url":"https://api.github.com/users/SheffieldKevin/received_events","type":"User","site_admin":false},"body":"Code review for Implement plugin manager API - Installing Updates (#12067):\n\nConnect to BohemianCoding/Sketch#12067.","created_at":"2017-03-10T16:03:12Z","updated_at":"2017-03-16T12:33:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96457fb287a2e9d53c98a8c4e844d0c89d7189d3","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/110/commits","review_comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/110/comments","review_comment_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/110/comments","statuses_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/statuses/97fa388872cedff918259cf106e9ff259b7a4655","head":{"label":"BohemianCoding:feature/12067-implement-plugin-manager-api","ref":"feature/12067-implement-plugin-manager-api","sha":"97fa388872cedff918259cf106e9ff259b7a4655","user":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars2.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"repo":{"id":13962123,"name":"BCFoundation","full_name":"BohemianCoding/BCFoundation","owner":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars2.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BohemianCoding/BCFoundation","description":"Shared prefixes, configurations etc for a number of other projects","fork":false,"url":"https://api.github.com/repos/BohemianCoding/BCFoundation","forks_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/forks","keys_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/teams","hooks_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/hooks","issue_events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/events{/number}","events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/events","assignees_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/assignees{/user}","branches_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/branches{/branch}","tags_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/tags","blobs_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/statuses/{sha}","languages_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/languages","stargazers_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/stargazers","contributors_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/contributors","subscribers_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/subscribers","subscription_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/subscription","commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/contents/{+path}","compare_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/merges","archive_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/downloads","issues_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues{/number}","pulls_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls{/number}","milestones_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/milestones{/number}","notifications_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/labels{/name}","releases_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/releases{/id}","deployments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/deployments","created_at":"2013-10-29T16:48:27Z","updated_at":"2016-01-25T15:08:14Z","pushed_at":"2017-03-15T11:48:49Z","git_url":"git://github.com/BohemianCoding/BCFoundation.git","ssh_url":"git@github.com:BohemianCoding/BCFoundation.git","clone_url":"https://github.com/BohemianCoding/BCFoundation.git","svn_url":"https://github.com/BohemianCoding/BCFoundation","homepage":"","size":2053,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"BohemianCoding:develop","ref":"develop","sha":"87992fc7e7f91f0a6f42e5dae8084ee2b6fc5c32","user":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars2.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"repo":{"id":13962123,"name":"BCFoundation","full_name":"BohemianCoding/BCFoundation","owner":{"login":"BohemianCoding","id":4498264,"avatar_url":"https://avatars2.githubusercontent.com/u/4498264?v=3","gravatar_id":"","url":"https://api.github.com/users/BohemianCoding","html_url":"https://github.com/BohemianCoding","followers_url":"https://api.github.com/users/BohemianCoding/followers","following_url":"https://api.github.com/users/BohemianCoding/following{/other_user}","gists_url":"https://api.github.com/users/BohemianCoding/gists{/gist_id}","starred_url":"https://api.github.com/users/BohemianCoding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BohemianCoding/subscriptions","organizations_url":"https://api.github.com/users/BohemianCoding/orgs","repos_url":"https://api.github.com/users/BohemianCoding/repos","events_url":"https://api.github.com/users/BohemianCoding/events{/privacy}","received_events_url":"https://api.github.com/users/BohemianCoding/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BohemianCoding/BCFoundation","description":"Shared prefixes, configurations etc for a number of other projects","fork":false,"url":"https://api.github.com/repos/BohemianCoding/BCFoundation","forks_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/forks","keys_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/teams","hooks_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/hooks","issue_events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/events{/number}","events_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/events","assignees_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/assignees{/user}","branches_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/branches{/branch}","tags_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/tags","blobs_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/refs{/sha}","trees_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/statuses/{sha}","languages_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/languages","stargazers_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/stargazers","contributors_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/contributors","subscribers_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/subscribers","subscription_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/subscription","commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/commits{/sha}","git_commits_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/git/commits{/sha}","comments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/comments{/number}","issue_comment_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/comments{/number}","contents_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/contents/{+path}","compare_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/merges","archive_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/downloads","issues_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues{/number}","pulls_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls{/number}","milestones_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/milestones{/number}","notifications_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/labels{/name}","releases_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/releases{/id}","deployments_url":"https://api.github.com/repos/BohemianCoding/BCFoundation/deployments","created_at":"2013-10-29T16:48:27Z","updated_at":"2016-01-25T15:08:14Z","pushed_at":"2017-03-15T11:48:49Z","git_url":"git://github.com/BohemianCoding/BCFoundation.git","ssh_url":"git@github.com:BohemianCoding/BCFoundation.git","clone_url":"https://github.com/BohemianCoding/BCFoundation.git","svn_url":"https://github.com/BohemianCoding/BCFoundation","homepage":"","size":2053,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"open_issues_count":3,"forks":1,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/110"},"html":{"href":"https://github.com/BohemianCoding/BCFoundation/pull/110"},"issue":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/110"},"comments":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/BohemianCoding/BCFoundation/statuses/97fa388872cedff918259cf106e9ff259b7a4655"}}}}
{"actor":{"display_login":"mikeabdullah"}}