{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/130959070","pull_request_review_id":53891338,"id":130959070,"diff_hunk":"@@ -0,0 +1,17 @@\n+// Type definitions for nodemailer-mailgun-transport 1.3\n+// Project: https://github.com/orliesaurus/nodemailer-mailgun-transport\n+// Definitions by: Oto Ciulis <https://github.com/otociulis/>\n+// Definitions: https://github.com/DefinitelyTyped/DefinitelyTyped\n+\n+import * as nodemailer from 'nodemailer';\n+\n+declare namespace mailgunTransport {\n+    interface AuthOptions {\n+        api_key: string;\n+        domain?: string;\n+    }\n+}\n+\n+declare function mailgunTransport(options: mailgunTransport.AuthOptions): nodemailer.Transport;","path":"types/nodemailer-mailgun-transport/index.d.ts","position":15,"original_position":15,"commit_id":"2e1057ff7f8307c090e09ea1c24114c3b69504d7","original_commit_id":"2e1057ff7f8307c090e09ea1c24114c3b69504d7","user":{"login":"sheetalkamat","id":8052792,"avatar_url":"https://avatars2.githubusercontent.com/u/8052792?v=4","gravatar_id":"","url":"https://api.github.com/users/sheetalkamat","html_url":"https://github.com/sheetalkamat","followers_url":"https://api.github.com/users/sheetalkamat/followers","following_url":"https://api.github.com/users/sheetalkamat/following{/other_user}","gists_url":"https://api.github.com/users/sheetalkamat/gists{/gist_id}","starred_url":"https://api.github.com/users/sheetalkamat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheetalkamat/subscriptions","organizations_url":"https://api.github.com/users/sheetalkamat/orgs","repos_url":"https://api.github.com/users/sheetalkamat/repos","events_url":"https://api.github.com/users/sheetalkamat/events{/privacy}","received_events_url":"https://api.github.com/users/sheetalkamat/received_events","type":"User","site_admin":false},"body":"Is the return type correct as nodemailer.Transport? It seems like in your implementation(https://github.com/orliesaurus/nodemailer-mailgun-transport/blob/master/src/mailgun-transport.js), I dont see close method thats required in nodemailer.Transport (https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/nodemailer/index.d.ts#L210) ","created_at":"2017-08-02T18:33:11Z","updated_at":"2017-08-02T18:33:33Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18584#discussion_r130959070","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18584","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/130959070"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18584#discussion_r130959070"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18584"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18584","id":133736840,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18584","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18584.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18584.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18584","number":18584,"state":"open","locked":false,"title":"Adding nodemailer-mailgun-transport definitions","user":{"login":"otociulis","id":7397234,"avatar_url":"https://avatars2.githubusercontent.com/u/7397234?v=4","gravatar_id":"","url":"https://api.github.com/users/otociulis","html_url":"https://github.com/otociulis","followers_url":"https://api.github.com/users/otociulis/followers","following_url":"https://api.github.com/users/otociulis/following{/other_user}","gists_url":"https://api.github.com/users/otociulis/gists{/gist_id}","starred_url":"https://api.github.com/users/otociulis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otociulis/subscriptions","organizations_url":"https://api.github.com/users/otociulis/orgs","repos_url":"https://api.github.com/users/otociulis/repos","events_url":"https://api.github.com/users/otociulis/events{/privacy}","received_events_url":"https://api.github.com/users/otociulis/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [x] The package does not provide its own types, and you can not add them.\r\n- [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [x] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [x] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, and `strictNullChecks` set to `true`.\r\n","created_at":"2017-08-02T15:20:08Z","updated_at":"2017-08-02T18:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7fe5cb68c14c2b333db969e93ec25370578e6974","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18584/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18584/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18584/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/2e1057ff7f8307c090e09ea1c24114c3b69504d7","head":{"label":"otociulis:master","ref":"master","sha":"2e1057ff7f8307c090e09ea1c24114c3b69504d7","user":{"login":"otociulis","id":7397234,"avatar_url":"https://avatars2.githubusercontent.com/u/7397234?v=4","gravatar_id":"","url":"https://api.github.com/users/otociulis","html_url":"https://github.com/otociulis","followers_url":"https://api.github.com/users/otociulis/followers","following_url":"https://api.github.com/users/otociulis/following{/other_user}","gists_url":"https://api.github.com/users/otociulis/gists{/gist_id}","starred_url":"https://api.github.com/users/otociulis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otociulis/subscriptions","organizations_url":"https://api.github.com/users/otociulis/orgs","repos_url":"https://api.github.com/users/otociulis/repos","events_url":"https://api.github.com/users/otociulis/events{/privacy}","received_events_url":"https://api.github.com/users/otociulis/received_events","type":"User","site_admin":false},"repo":{"id":98759855,"name":"DefinitelyTyped","full_name":"otociulis/DefinitelyTyped","owner":{"login":"otociulis","id":7397234,"avatar_url":"https://avatars2.githubusercontent.com/u/7397234?v=4","gravatar_id":"","url":"https://api.github.com/users/otociulis","html_url":"https://github.com/otociulis","followers_url":"https://api.github.com/users/otociulis/followers","following_url":"https://api.github.com/users/otociulis/following{/other_user}","gists_url":"https://api.github.com/users/otociulis/gists{/gist_id}","starred_url":"https://api.github.com/users/otociulis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/otociulis/subscriptions","organizations_url":"https://api.github.com/users/otociulis/orgs","repos_url":"https://api.github.com/users/otociulis/repos","events_url":"https://api.github.com/users/otociulis/events{/privacy}","received_events_url":"https://api.github.com/users/otociulis/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/otociulis/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/otociulis/DefinitelyTyped","forks_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/otociulis/DefinitelyTyped/deployments","created_at":"2017-07-29T21:34:08Z","updated_at":"2017-07-29T21:34:24Z","pushed_at":"2017-08-02T15:13:54Z","git_url":"git://github.com/otociulis/DefinitelyTyped.git","ssh_url":"git@github.com:otociulis/DefinitelyTyped.git","clone_url":"https://github.com/otociulis/DefinitelyTyped.git","svn_url":"https://github.com/otociulis/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":223836,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"02ff752907efc578064bdcdc5139d88601129bcd","user":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2017-08-02T14:39:12Z","pushed_at":"2017-08-02T18:28:12Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":223740,"stargazers_count":11688,"watchers_count":11688,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9680,"mirror_url":null,"open_issues_count":1640,"forks":9680,"open_issues":1640,"watchers":11688,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18584"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/18584"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18584"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/18584/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18584/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/18584/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/2e1057ff7f8307c090e09ea1c24114c3b69504d7"}}}}
{"actor":{"display_login":"sheetalkamat"}}