{"action":"created","issue":{"url":"https://api.github.com/repos/Solo5/solo5/issues/198","repository_url":"https://api.github.com/repos/Solo5/solo5","labels_url":"https://api.github.com/repos/Solo5/solo5/issues/198/labels{/name}","comments_url":"https://api.github.com/repos/Solo5/solo5/issues/198/comments","events_url":"https://api.github.com/repos/Solo5/solo5/issues/198/events","html_url":"https://github.com/Solo5/solo5/pull/198","id":233704144,"number":198,"title":"Cleanup of the GDB server code in ukvm","user":{"login":"ricarkol","id":11448949,"avatar_url":"https://avatars3.githubusercontent.com/u/11448949?v=3","gravatar_id":"","url":"https://api.github.com/users/ricarkol","html_url":"https://github.com/ricarkol","followers_url":"https://api.github.com/users/ricarkol/followers","following_url":"https://api.github.com/users/ricarkol/following{/other_user}","gists_url":"https://api.github.com/users/ricarkol/gists{/gist_id}","starred_url":"https://api.github.com/users/ricarkol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ricarkol/subscriptions","organizations_url":"https://api.github.com/users/ricarkol/orgs","repos_url":"https://api.github.com/users/ricarkol/repos","events_url":"https://api.github.com/users/ricarkol/events{/privacy}","received_events_url":"https://api.github.com/users/ricarkol/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-06-05T20:40:29Z","updated_at":"2017-06-08T14:13:08Z","closed_at":null,"pull_request":{"url":"https://api.github.com/repos/Solo5/solo5/pulls/198","html_url":"https://github.com/Solo5/solo5/pull/198","diff_url":"https://github.com/Solo5/solo5/pull/198.diff","patch_url":"https://github.com/Solo5/solo5/pull/198.patch"},"body":"Changes:\r\n1. Removed all arch and backend dependent code from ukvm/ukvm_module_gdb.c\r\n2. Cleaned up ukvm/ukvm_module_gdb.c, fixed issue #25.\r\n3. Implemented some new GDB commands like: writing memory and registers.\r\n4. Added an empty stub for freebsd (just so freebsd builds successfully).\r\n5. Breakpoints without relying on stepping: hardware and software breakpoints #16.\r\n\r\nThis PR fixes: #176  #16  #25 \r\n\r\nTests:\r\n- tested without mirage with this:\r\n    https://gist.github.com/ricarkol/3e9768639c1e52b86c195d579d818279#file-gdb-test-sh\r\n- tested breakpointing and stepping over some mirage apps. Used this pin:\r\n    `opam pin add mirage git://github.com/ricarkol/mirage#gdb-ukvm`\r\n- built on freebsd (didn't run ukvm)"},"comment":{"url":"https://api.github.com/repos/Solo5/solo5/issues/comments/307116107","html_url":"https://github.com/Solo5/solo5/pull/198#issuecomment-307116107","issue_url":"https://api.github.com/repos/Solo5/solo5/issues/198","id":307116107,"user":{"login":"mato","id":190797,"avatar_url":"https://avatars3.githubusercontent.com/u/190797?v=3","gravatar_id":"","url":"https://api.github.com/users/mato","html_url":"https://github.com/mato","followers_url":"https://api.github.com/users/mato/followers","following_url":"https://api.github.com/users/mato/following{/other_user}","gists_url":"https://api.github.com/users/mato/gists{/gist_id}","starred_url":"https://api.github.com/users/mato/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mato/subscriptions","organizations_url":"https://api.github.com/users/mato/orgs","repos_url":"https://api.github.com/users/mato/repos","events_url":"https://api.github.com/users/mato/events{/privacy}","received_events_url":"https://api.github.com/users/mato/received_events","type":"User","site_admin":false},"created_at":"2017-06-08T14:13:08Z","updated_at":"2017-06-08T14:13:08Z","body":"(approved but don't merge yet, more comments forthcoming)"}}
{"actor":{"display_login":"mato"}}