{"action":"created","comment":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/155944386","pull_request_review_id":82347179,"id":155944386,"diff_hunk":"@@ -946,12 +945,25 @@ void BitcoinGUI::changeEvent(QEvent *e)\n             QWindowStateChangeEvent *wsevt = static_cast<QWindowStateChangeEvent*>(e);\n             if(!(wsevt->oldState() & Qt::WindowMinimized) && isMinimized())\n             {\n+                if (wsevt->oldState() & Qt::WindowMaximized)\n+                {\n+                    QTimer::singleShot(0, this, SLOT(showMaximized()));\n+                }\n+                else if (wsevt->oldState() & Qt::WindowFullScreen)\n+                {\n+                    QTimer::singleShot(0, this, SLOT(showFullScreen()));\n+                }\n+                else\n+                {\n+                    QTimer::singleShot(0, this, SLOT(showNormal()));\n+                }\n                 QTimer::singleShot(0, this, SLOT(hide()));\n                 e->ignore();\n             }\n         }\n     }\n #endif\n+    QMainWindow::changeEvent(e);","path":"src/qt/bitcoingui.cpp","position":null,"original_position":30,"commit_id":"7856bb412df9de69c3451f0a85223247f77c0181","original_commit_id":"eb217dfc0e570501f362152836d844901ee30cea","user":{"login":"promag","id":3534524,"avatar_url":"https://avatars1.githubusercontent.com/u/3534524?v=4","gravatar_id":"","url":"https://api.github.com/users/promag","html_url":"https://github.com/promag","followers_url":"https://api.github.com/users/promag/followers","following_url":"https://api.github.com/users/promag/following{/other_user}","gists_url":"https://api.github.com/users/promag/gists{/gist_id}","starred_url":"https://api.github.com/users/promag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/promag/subscriptions","organizations_url":"https://api.github.com/users/promag/orgs","repos_url":"https://api.github.com/users/promag/repos","events_url":"https://api.github.com/users/promag/events{/privacy}","received_events_url":"https://api.github.com/users/promag/received_events","type":"User","site_admin":false},"body":"You could have some reason, otherwise it's unrelated to your goal.","created_at":"2017-12-10T11:07:45Z","updated_at":"2017-12-10T11:07:45Z","html_url":"https://github.com/bitcoin/bitcoin/pull/11859#discussion_r155944386","pull_request_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11859","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments/155944386"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/11859#discussion_r155944386"},"pull_request":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11859"}},"in_reply_to_id":155936443},"pull_request":{"url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11859","id":157411189,"html_url":"https://github.com/bitcoin/bitcoin/pull/11859","diff_url":"https://github.com/bitcoin/bitcoin/pull/11859.diff","patch_url":"https://github.com/bitcoin/bitcoin/pull/11859.patch","issue_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11859","number":11859,"state":"open","locked":false,"title":"Qt: Fixing restore from system tray behaviour of main window","user":{"login":"vajdaz","id":8015558,"avatar_url":"https://avatars0.githubusercontent.com/u/8015558?v=4","gravatar_id":"","url":"https://api.github.com/users/vajdaz","html_url":"https://github.com/vajdaz","followers_url":"https://api.github.com/users/vajdaz/followers","following_url":"https://api.github.com/users/vajdaz/following{/other_user}","gists_url":"https://api.github.com/users/vajdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vajdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vajdaz/subscriptions","organizations_url":"https://api.github.com/users/vajdaz/orgs","repos_url":"https://api.github.com/users/vajdaz/repos","events_url":"https://api.github.com/users/vajdaz/events{/privacy}","received_events_url":"https://api.github.com/users/vajdaz/received_events","type":"User","site_admin":false},"body":"When restoring the main window from the system tray, it always was in minimized state (at least on Windows). This patch should fix this. The window should restore to the same state as it was  at the moment of minimizing it into the tray.\r\n\r\nMay be related to issue #8225 \r\n\r\nTo reproduce the bug do following under Windows:\r\n* In Options->Window enable \"Minimize to the tray instead of the taskbar\"\r\n* Optionally enable \"Minimize on close\", too\r\n* Minimize the main window\r\n* Klick on the tray icon (or right click on the tray icon and select Show/Hide)\r\n\r\nThe main window's taskbar icon appears, but the window itself is not restored to its original size.\r\n\r\nExpected behaviour: the window should appear.","created_at":"2017-12-10T00:31:16Z","updated_at":"2017-12-10T11:07:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72295af44f0087a4b74ac2c2f4d520bf8060305d","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11859/commits","review_comments_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11859/comments","review_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/11859/comments","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/7856bb412df9de69c3451f0a85223247f77c0181","head":{"label":"vajdaz:minimize-to-tray","ref":"minimize-to-tray","sha":"7856bb412df9de69c3451f0a85223247f77c0181","user":{"login":"vajdaz","id":8015558,"avatar_url":"https://avatars0.githubusercontent.com/u/8015558?v=4","gravatar_id":"","url":"https://api.github.com/users/vajdaz","html_url":"https://github.com/vajdaz","followers_url":"https://api.github.com/users/vajdaz/followers","following_url":"https://api.github.com/users/vajdaz/following{/other_user}","gists_url":"https://api.github.com/users/vajdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vajdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vajdaz/subscriptions","organizations_url":"https://api.github.com/users/vajdaz/orgs","repos_url":"https://api.github.com/users/vajdaz/repos","events_url":"https://api.github.com/users/vajdaz/events{/privacy}","received_events_url":"https://api.github.com/users/vajdaz/received_events","type":"User","site_admin":false},"repo":{"id":113512263,"name":"bitcoin","full_name":"vajdaz/bitcoin","owner":{"login":"vajdaz","id":8015558,"avatar_url":"https://avatars0.githubusercontent.com/u/8015558?v=4","gravatar_id":"","url":"https://api.github.com/users/vajdaz","html_url":"https://github.com/vajdaz","followers_url":"https://api.github.com/users/vajdaz/followers","following_url":"https://api.github.com/users/vajdaz/following{/other_user}","gists_url":"https://api.github.com/users/vajdaz/gists{/gist_id}","starred_url":"https://api.github.com/users/vajdaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vajdaz/subscriptions","organizations_url":"https://api.github.com/users/vajdaz/orgs","repos_url":"https://api.github.com/users/vajdaz/repos","events_url":"https://api.github.com/users/vajdaz/events{/privacy}","received_events_url":"https://api.github.com/users/vajdaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vajdaz/bitcoin","description":"Bitcoin Core integration/staging tree","fork":true,"url":"https://api.github.com/repos/vajdaz/bitcoin","forks_url":"https://api.github.com/repos/vajdaz/bitcoin/forks","keys_url":"https://api.github.com/repos/vajdaz/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vajdaz/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vajdaz/bitcoin/teams","hooks_url":"https://api.github.com/repos/vajdaz/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/vajdaz/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/vajdaz/bitcoin/events","assignees_url":"https://api.github.com/repos/vajdaz/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/vajdaz/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/vajdaz/bitcoin/tags","blobs_url":"https://api.github.com/repos/vajdaz/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vajdaz/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vajdaz/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/vajdaz/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vajdaz/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/vajdaz/bitcoin/languages","stargazers_url":"https://api.github.com/repos/vajdaz/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/vajdaz/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/vajdaz/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/vajdaz/bitcoin/subscription","commits_url":"https://api.github.com/repos/vajdaz/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/vajdaz/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/vajdaz/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/vajdaz/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/vajdaz/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/vajdaz/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vajdaz/bitcoin/merges","archive_url":"https://api.github.com/repos/vajdaz/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vajdaz/bitcoin/downloads","issues_url":"https://api.github.com/repos/vajdaz/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/vajdaz/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/vajdaz/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/vajdaz/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vajdaz/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/vajdaz/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/vajdaz/bitcoin/deployments","created_at":"2017-12-08T00:24:28Z","updated_at":"2017-12-08T00:24:42Z","pushed_at":"2017-12-10T10:57:31Z","git_url":"git://github.com/vajdaz/bitcoin.git","ssh_url":"git@github.com:vajdaz/bitcoin.git","clone_url":"https://github.com/vajdaz/bitcoin.git","svn_url":"https://github.com/vajdaz/bitcoin","homepage":"https://bitcoin.org/en/download","size":90528,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bitcoin:master","ref":"master","sha":"59d3dc85b698430f71f6e242a01a25a70c9ef397","user":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"repo":{"id":1181927,"name":"bitcoin","full_name":"bitcoin/bitcoin","owner":{"login":"bitcoin","id":528860,"avatar_url":"https://avatars2.githubusercontent.com/u/528860?v=4","gravatar_id":"","url":"https://api.github.com/users/bitcoin","html_url":"https://github.com/bitcoin","followers_url":"https://api.github.com/users/bitcoin/followers","following_url":"https://api.github.com/users/bitcoin/following{/other_user}","gists_url":"https://api.github.com/users/bitcoin/gists{/gist_id}","starred_url":"https://api.github.com/users/bitcoin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bitcoin/subscriptions","organizations_url":"https://api.github.com/users/bitcoin/orgs","repos_url":"https://api.github.com/users/bitcoin/repos","events_url":"https://api.github.com/users/bitcoin/events{/privacy}","received_events_url":"https://api.github.com/users/bitcoin/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bitcoin/bitcoin","description":"Bitcoin Core integration/staging tree","fork":false,"url":"https://api.github.com/repos/bitcoin/bitcoin","forks_url":"https://api.github.com/repos/bitcoin/bitcoin/forks","keys_url":"https://api.github.com/repos/bitcoin/bitcoin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bitcoin/bitcoin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bitcoin/bitcoin/teams","hooks_url":"https://api.github.com/repos/bitcoin/bitcoin/hooks","issue_events_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/events{/number}","events_url":"https://api.github.com/repos/bitcoin/bitcoin/events","assignees_url":"https://api.github.com/repos/bitcoin/bitcoin/assignees{/user}","branches_url":"https://api.github.com/repos/bitcoin/bitcoin/branches{/branch}","tags_url":"https://api.github.com/repos/bitcoin/bitcoin/tags","blobs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bitcoin/bitcoin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bitcoin/bitcoin/git/refs{/sha}","trees_url":"https://api.github.com/repos/bitcoin/bitcoin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bitcoin/bitcoin/statuses/{sha}","languages_url":"https://api.github.com/repos/bitcoin/bitcoin/languages","stargazers_url":"https://api.github.com/repos/bitcoin/bitcoin/stargazers","contributors_url":"https://api.github.com/repos/bitcoin/bitcoin/contributors","subscribers_url":"https://api.github.com/repos/bitcoin/bitcoin/subscribers","subscription_url":"https://api.github.com/repos/bitcoin/bitcoin/subscription","commits_url":"https://api.github.com/repos/bitcoin/bitcoin/commits{/sha}","git_commits_url":"https://api.github.com/repos/bitcoin/bitcoin/git/commits{/sha}","comments_url":"https://api.github.com/repos/bitcoin/bitcoin/comments{/number}","issue_comment_url":"https://api.github.com/repos/bitcoin/bitcoin/issues/comments{/number}","contents_url":"https://api.github.com/repos/bitcoin/bitcoin/contents/{+path}","compare_url":"https://api.github.com/repos/bitcoin/bitcoin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bitcoin/bitcoin/merges","archive_url":"https://api.github.com/repos/bitcoin/bitcoin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bitcoin/bitcoin/downloads","issues_url":"https://api.github.com/repos/bitcoin/bitcoin/issues{/number}","pulls_url":"https://api.github.com/repos/bitcoin/bitcoin/pulls{/number}","milestones_url":"https://api.github.com/repos/bitcoin/bitcoin/milestones{/number}","notifications_url":"https://api.github.com/repos/bitcoin/bitcoin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bitcoin/bitcoin/labels{/name}","releases_url":"https://api.github.com/repos/bitcoin/bitcoin/releases{/id}","deployments_url":"https://api.github.com/repos/bitcoin/bitcoin/deployments","created_at":"2010-12-19T15:16:43Z","updated_at":"2017-12-10T10:54:08Z","pushed_at":"2017-12-10T10:57:37Z","git_url":"git://github.com/bitcoin/bitcoin.git","ssh_url":"git@github.com:bitcoin/bitcoin.git","clone_url":"https://github.com/bitcoin/bitcoin.git","svn_url":"https://github.com/bitcoin/bitcoin","homepage":"https://bitcoin.org/en/download","size":90558,"stargazers_count":21196,"watchers_count":21196,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":12298,"mirror_url":null,"archived":false,"open_issues_count":778,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":12298,"open_issues":778,"watchers":21196,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11859"},"html":{"href":"https://github.com/bitcoin/bitcoin/pull/11859"},"issue":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/11859"},"comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/issues/11859/comments"},"review_comments":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11859/comments"},"review_comment":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bitcoin/bitcoin/pulls/11859/commits"},"statuses":{"href":"https://api.github.com/repos/bitcoin/bitcoin/statuses/7856bb412df9de69c3451f0a85223247f77c0181"}},"author_association":"NONE"}}
{"actor":{"display_login":"promag"}}