{"action":"closed","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/40241","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/40241/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/40241/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/40241/events","html_url":"https://github.com/Microsoft/vscode/issues/40241","id":282301399,"number":40241,"title":"When adding a condition to the default key binding, it will not be overwritten.","user":{"login":"pakutoma","id":31642509,"avatar_url":"https://avatars0.githubusercontent.com/u/31642509?v=4","gravatar_id":"","url":"https://api.github.com/users/pakutoma","html_url":"https://github.com/pakutoma","followers_url":"https://api.github.com/users/pakutoma/followers","following_url":"https://api.github.com/users/pakutoma/following{/other_user}","gists_url":"https://api.github.com/users/pakutoma/gists{/gist_id}","starred_url":"https://api.github.com/users/pakutoma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pakutoma/subscriptions","organizations_url":"https://api.github.com/users/pakutoma/orgs","repos_url":"https://api.github.com/users/pakutoma/repos","events_url":"https://api.github.com/users/pakutoma/events{/privacy}","received_events_url":"https://api.github.com/users/pakutoma/received_events","type":"User","site_admin":false},"labels":[{"id":362694632,"url":"https://api.github.com/repos/Microsoft/vscode/labels/integrated-terminal","name":"integrated-terminal","color":"1d76db","default":false},{"id":297959291,"url":"https://api.github.com/repos/Microsoft/vscode/labels/keybindings","name":"keybindings","color":"1d76db","default":false}],"state":"closed","locked":false,"assignee":{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"assignees":[{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2017-12-15T02:28:01Z","updated_at":"2017-12-15T14:58:13Z","closed_at":"2017-12-15T14:58:13Z","author_association":"NONE","body":"<!-- Do you have a question? Please ask it on http://stackoverflow.com/questions/tagged/vscode. -->\r\n\r\n<!-- Use Help > Report Issues to prefill these. -->\r\n- VSCode Version: 1.18.1\r\n- OS Version: Windows 10 Home Version 1709 (Fall Creators Update)\r\n\r\nSteps to Reproduce:\r\n\r\n1.\r\nIn keybinding.json :\r\n```\r\n{\r\n    \"key\": \"ctrl+oem_3\",\r\n    \"command\": \"workbench.action.terminal.toggleTerminal\",\r\n    \"when\": \"terminalFocus\"\r\n},\r\n{\r\n    \"key\": \"ctrl+oem_3\",\r\n    \"command\": \"-workbench.action.terminal.toggleTerminal\"\r\n}\r\n```\r\n\r\nIn this setting I was expecting that Ctrl+oem_3 will open / close the terminal (ie close) only when the terminal has the focus.\r\nHowever, in reality, opening and closing of the terminal is done regardless of where the focus is.\r\n\r\n\r\n<!-- Launch with `code --disable-extensions` to check. -->\r\nReproduces without extensions: Yes"}}
{"actor":{"display_login":"Tyriar"}}