{"action":"created","comment":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/comments/143720841","pull_request_review_id":68263554,"id":143720841,"diff_hunk":"@@ -12,12 +12,23 @@ export const workspacePath = '/services/workspace';\n  */\n export const WorkspaceServer = Symbol('WorkspaceServer');\n export interface WorkspaceServer {\n+\n+    /**\n+     * Returns with a promise that resolves to the workspace root URI as a string. Resolves to `undefined` if the workspace root is not yet set.\n+     */\n+    getRoot(): Promise<string | undefined>;\n+\n     /**\n-     * Return the current workspace root.\n+     * Returns a promise that resolves the default workspace root. This could be used, when the desired workspace root is not yet set.\n+     *\n+     * The default workspace location depends on the actual implementation. Could be the user home, the current working directory of the\n+     * underlying process or any other arbitrary logic.\n      */\n-    getRoot(): Promise<string>;\n+    getDefaultRoot(): Promise<string>;","path":"packages/workspace/src/common/workspace-protocol.ts","position":18,"original_position":18,"commit_id":"ea820a2ee943d3b9b33b508777bc52f51e2dd9a9","original_commit_id":"ea820a2ee943d3b9b33b508777bc52f51e2dd9a9","user":{"login":"hexa00","id":698076,"avatar_url":"https://avatars2.githubusercontent.com/u/698076?v=4","gravatar_id":"","url":"https://api.github.com/users/hexa00","html_url":"https://github.com/hexa00","followers_url":"https://api.github.com/users/hexa00/followers","following_url":"https://api.github.com/users/hexa00/following{/other_user}","gists_url":"https://api.github.com/users/hexa00/gists{/gist_id}","starred_url":"https://api.github.com/users/hexa00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hexa00/subscriptions","organizations_url":"https://api.github.com/users/hexa00/orgs","repos_url":"https://api.github.com/users/hexa00/repos","events_url":"https://api.github.com/users/hexa00/events{/privacy}","received_events_url":"https://api.github.com/users/hexa00/received_events","type":"User","site_admin":false},"body":"Ditto URI","created_at":"2017-10-10T13:07:39Z","updated_at":"2017-10-10T13:09:00Z","html_url":"https://github.com/theia-ide/theia/pull/615#discussion_r143720841","pull_request_url":"https://api.github.com/repos/theia-ide/theia/pulls/615","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments/143720841"},"html":{"href":"https://github.com/theia-ide/theia/pull/615#discussion_r143720841"},"pull_request":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/615"}}},"pull_request":{"url":"https://api.github.com/repos/theia-ide/theia/pulls/615","id":145480658,"html_url":"https://github.com/theia-ide/theia/pull/615","diff_url":"https://github.com/theia-ide/theia/pull/615.diff","patch_url":"https://github.com/theia-ide/theia/pull/615.patch","issue_url":"https://api.github.com/repos/theia-ide/theia/issues/615","number":615,"state":"open","locked":false,"title":"[WIP] GH-603: Initial workspace API changes to support unset root case.","user":{"login":"kittaakos","id":1405703,"avatar_url":"https://avatars3.githubusercontent.com/u/1405703?v=4","gravatar_id":"","url":"https://api.github.com/users/kittaakos","html_url":"https://github.com/kittaakos","followers_url":"https://api.github.com/users/kittaakos/followers","following_url":"https://api.github.com/users/kittaakos/following{/other_user}","gists_url":"https://api.github.com/users/kittaakos/gists{/gist_id}","starred_url":"https://api.github.com/users/kittaakos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kittaakos/subscriptions","organizations_url":"https://api.github.com/users/kittaakos/orgs","repos_url":"https://api.github.com/users/kittaakos/repos","events_url":"https://api.github.com/users/kittaakos/events{/privacy}","received_events_url":"https://api.github.com/users/kittaakos/received_events","type":"User","site_admin":false},"body":"Workspace root could be unset (`undefined`) so downstream services\r\nshould handle it gracefully. Workspace root will not be resolved\r\nunless it is explicitly set either manually, through the UI, or\r\nfrom the program arguments.\r\n\r\nThis PR does not yet contain the `Open...` button from the navigator.\r\n\r\nTask: #603.\r\nCloses: #603.\r\n\r\nSigned-off-by: Akos Kitta <kittaakos@gmail.com>","created_at":"2017-10-09T15:18:58Z","updated_at":"2017-10-10T13:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1a658ef4122b14d5fae68b9a94aad630c95244a1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"svenefftinge","id":372735,"avatar_url":"https://avatars0.githubusercontent.com/u/372735?v=4","gravatar_id":"","url":"https://api.github.com/users/svenefftinge","html_url":"https://github.com/svenefftinge","followers_url":"https://api.github.com/users/svenefftinge/followers","following_url":"https://api.github.com/users/svenefftinge/following{/other_user}","gists_url":"https://api.github.com/users/svenefftinge/gists{/gist_id}","starred_url":"https://api.github.com/users/svenefftinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svenefftinge/subscriptions","organizations_url":"https://api.github.com/users/svenefftinge/orgs","repos_url":"https://api.github.com/users/svenefftinge/repos","events_url":"https://api.github.com/users/svenefftinge/events{/privacy}","received_events_url":"https://api.github.com/users/svenefftinge/received_events","type":"User","site_admin":false}],"milestone":null,"commits_url":"https://api.github.com/repos/theia-ide/theia/pulls/615/commits","review_comments_url":"https://api.github.com/repos/theia-ide/theia/pulls/615/comments","review_comment_url":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/theia-ide/theia/issues/615/comments","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/ea820a2ee943d3b9b33b508777bc52f51e2dd9a9","head":{"label":"theia-ide:GH-603","ref":"GH-603","sha":"ea820a2ee943d3b9b33b508777bc52f51e2dd9a9","user":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2017-10-10T04:17:48Z","pushed_at":"2017-10-10T12:11:18Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"","size":33756,"stargazers_count":260,"watchers_count":260,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":154,"forks":48,"open_issues":154,"watchers":260,"default_branch":"master"}},"base":{"label":"theia-ide:master","ref":"master","sha":"3b61f339735c68ed2bbbe1344f87ec98b7b74445","user":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"repo":{"id":83050680,"name":"theia","full_name":"theia-ide/theia","owner":{"login":"theia-ide","id":28530323,"avatar_url":"https://avatars1.githubusercontent.com/u/28530323?v=4","gravatar_id":"","url":"https://api.github.com/users/theia-ide","html_url":"https://github.com/theia-ide","followers_url":"https://api.github.com/users/theia-ide/followers","following_url":"https://api.github.com/users/theia-ide/following{/other_user}","gists_url":"https://api.github.com/users/theia-ide/gists{/gist_id}","starred_url":"https://api.github.com/users/theia-ide/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/theia-ide/subscriptions","organizations_url":"https://api.github.com/users/theia-ide/orgs","repos_url":"https://api.github.com/users/theia-ide/repos","events_url":"https://api.github.com/users/theia-ide/events{/privacy}","received_events_url":"https://api.github.com/users/theia-ide/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/theia-ide/theia","description":"Theia is a cloud & desktop IDE framework implemented in TypeScript.","fork":false,"url":"https://api.github.com/repos/theia-ide/theia","forks_url":"https://api.github.com/repos/theia-ide/theia/forks","keys_url":"https://api.github.com/repos/theia-ide/theia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/theia-ide/theia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/theia-ide/theia/teams","hooks_url":"https://api.github.com/repos/theia-ide/theia/hooks","issue_events_url":"https://api.github.com/repos/theia-ide/theia/issues/events{/number}","events_url":"https://api.github.com/repos/theia-ide/theia/events","assignees_url":"https://api.github.com/repos/theia-ide/theia/assignees{/user}","branches_url":"https://api.github.com/repos/theia-ide/theia/branches{/branch}","tags_url":"https://api.github.com/repos/theia-ide/theia/tags","blobs_url":"https://api.github.com/repos/theia-ide/theia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/theia-ide/theia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/theia-ide/theia/git/refs{/sha}","trees_url":"https://api.github.com/repos/theia-ide/theia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/theia-ide/theia/statuses/{sha}","languages_url":"https://api.github.com/repos/theia-ide/theia/languages","stargazers_url":"https://api.github.com/repos/theia-ide/theia/stargazers","contributors_url":"https://api.github.com/repos/theia-ide/theia/contributors","subscribers_url":"https://api.github.com/repos/theia-ide/theia/subscribers","subscription_url":"https://api.github.com/repos/theia-ide/theia/subscription","commits_url":"https://api.github.com/repos/theia-ide/theia/commits{/sha}","git_commits_url":"https://api.github.com/repos/theia-ide/theia/git/commits{/sha}","comments_url":"https://api.github.com/repos/theia-ide/theia/comments{/number}","issue_comment_url":"https://api.github.com/repos/theia-ide/theia/issues/comments{/number}","contents_url":"https://api.github.com/repos/theia-ide/theia/contents/{+path}","compare_url":"https://api.github.com/repos/theia-ide/theia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/theia-ide/theia/merges","archive_url":"https://api.github.com/repos/theia-ide/theia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/theia-ide/theia/downloads","issues_url":"https://api.github.com/repos/theia-ide/theia/issues{/number}","pulls_url":"https://api.github.com/repos/theia-ide/theia/pulls{/number}","milestones_url":"https://api.github.com/repos/theia-ide/theia/milestones{/number}","notifications_url":"https://api.github.com/repos/theia-ide/theia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/theia-ide/theia/labels{/name}","releases_url":"https://api.github.com/repos/theia-ide/theia/releases{/id}","deployments_url":"https://api.github.com/repos/theia-ide/theia/deployments","created_at":"2017-02-24T14:42:05Z","updated_at":"2017-10-10T04:17:48Z","pushed_at":"2017-10-10T12:11:18Z","git_url":"git://github.com/theia-ide/theia.git","ssh_url":"git@github.com:theia-ide/theia.git","clone_url":"https://github.com/theia-ide/theia.git","svn_url":"https://github.com/theia-ide/theia","homepage":"","size":33756,"stargazers_count":260,"watchers_count":260,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"open_issues_count":154,"forks":48,"open_issues":154,"watchers":260,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/615"},"html":{"href":"https://github.com/theia-ide/theia/pull/615"},"issue":{"href":"https://api.github.com/repos/theia-ide/theia/issues/615"},"comments":{"href":"https://api.github.com/repos/theia-ide/theia/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/theia-ide/theia/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/theia-ide/theia/statuses/ea820a2ee943d3b9b33b508777bc52f51e2dd9a9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"hexa00"}}