{"action":"created","issue":{"url":"https://api.github.com/repos/the-control-group/voyager/issues/1546","repository_url":"https://api.github.com/repos/the-control-group/voyager","labels_url":"https://api.github.com/repos/the-control-group/voyager/issues/1546/labels{/name}","comments_url":"https://api.github.com/repos/the-control-group/voyager/issues/1546/comments","events_url":"https://api.github.com/repos/the-control-group/voyager/issues/1546/events","html_url":"https://github.com/the-control-group/voyager/pull/1546","id":249436723,"number":1546,"title":"Fixing the primary key issue that was introduced after PR 1452","user":{"login":"tnylea","id":601261,"avatar_url":"https://avatars2.githubusercontent.com/u/601261?v=4","gravatar_id":"","url":"https://api.github.com/users/tnylea","html_url":"https://github.com/tnylea","followers_url":"https://api.github.com/users/tnylea/followers","following_url":"https://api.github.com/users/tnylea/following{/other_user}","gists_url":"https://api.github.com/users/tnylea/gists{/gist_id}","starred_url":"https://api.github.com/users/tnylea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tnylea/subscriptions","organizations_url":"https://api.github.com/users/tnylea/orgs","repos_url":"https://api.github.com/users/tnylea/repos","events_url":"https://api.github.com/users/tnylea/events{/privacy}","received_events_url":"https://api.github.com/users/tnylea/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-08-10T18:31:31Z","updated_at":"2017-08-13T13:38:58Z","closed_at":"2017-08-10T18:35:12Z","pull_request":{"url":"https://api.github.com/repos/the-control-group/voyager/pulls/1546","html_url":"https://github.com/the-control-group/voyager/pull/1546","diff_url":"https://github.com/the-control-group/voyager/pull/1546.diff","patch_url":"https://github.com/the-control-group/voyager/pull/1546.patch"},"body":"In this PR https://github.com/the-control-group/voyager/pull/1452\r\n\r\nA new feature was added that allowed users to specify their own `primaryKey`, this will cause it to break if there is not a `primaryKey` specified.\r\n\r\nThis PR will default to the `id` if primaryKey is not specified in the model."},"comment":{"url":"https://api.github.com/repos/the-control-group/voyager/issues/comments/322042775","html_url":"https://github.com/the-control-group/voyager/pull/1546#issuecomment-322042775","issue_url":"https://api.github.com/repos/the-control-group/voyager/issues/1546","id":322042775,"user":{"login":"fletch3555","id":1387843,"avatar_url":"https://avatars0.githubusercontent.com/u/1387843?v=4","gravatar_id":"","url":"https://api.github.com/users/fletch3555","html_url":"https://github.com/fletch3555","followers_url":"https://api.github.com/users/fletch3555/followers","following_url":"https://api.github.com/users/fletch3555/following{/other_user}","gists_url":"https://api.github.com/users/fletch3555/gists{/gist_id}","starred_url":"https://api.github.com/users/fletch3555/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fletch3555/subscriptions","organizations_url":"https://api.github.com/users/fletch3555/orgs","repos_url":"https://api.github.com/users/fletch3555/repos","events_url":"https://api.github.com/users/fletch3555/events{/privacy}","received_events_url":"https://api.github.com/users/fletch3555/received_events","type":"User","site_admin":false},"created_at":"2017-08-13T13:38:58Z","updated_at":"2017-08-13T13:38:58Z","body":"@tnylea, @victorlap is correct, this should be `->getPrimaryKey()`, which does that check for you since it's just an overridden property on the model.\n\nAlso, please don't merge your own PRs."}}
{"actor":{"display_login":"fletch3555"}}