{"action":"created","issue":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/247","repository_url":"https://api.github.com/repos/HEP-FCC/FCCSW","labels_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/247/labels{/name}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/247/comments","events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/247/events","html_url":"https://github.com/HEP-FCC/FCCSW/issues/247","id":270735662,"number":247,"title":"Inconsistent readout","user":{"login":"jhrdinka","id":8693249,"avatar_url":"https://avatars3.githubusercontent.com/u/8693249?v=4","gravatar_id":"","url":"https://api.github.com/users/jhrdinka","html_url":"https://github.com/jhrdinka","followers_url":"https://api.github.com/users/jhrdinka/followers","following_url":"https://api.github.com/users/jhrdinka/following{/other_user}","gists_url":"https://api.github.com/users/jhrdinka/gists{/gist_id}","starred_url":"https://api.github.com/users/jhrdinka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhrdinka/subscriptions","organizations_url":"https://api.github.com/users/jhrdinka/orgs","repos_url":"https://api.github.com/users/jhrdinka/repos","events_url":"https://api.github.com/users/jhrdinka/events{/privacy}","received_events_url":"https://api.github.com/users/jhrdinka/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2017-11-02T17:14:11Z","updated_at":"2017-11-03T19:52:06Z","closed_at":null,"author_association":"NONE","body":"The readout is inconsistent within the current detector. E.g. the lengths of our system IDs differ in the Calorimeters and the Tracker (for example see: https://github.com/HEP-FCC/FCCSW/blob/master/Detector/DetFCChhHCalTile/compact/FCChh_HCalBarrel_TileCal.xml#L56, https://github.com/HEP-FCC/FCCSW/blob/master/Detector/DetFCChhTrackerTkLayout/compact/Tracker.xml#L9). This leads to inconsistencies in the volumeIDs. \r\nIn order to avoid these problems in the future we should agree on the lengths of the subsystems and define them in the master, similar to how it is done here: https://github.com/iLCSoft/lcgeo/blob/master/CLIC/compact/CLIC_o3_v13/CLIC_o3_v13.xml#L188 .\r\n"},"comment":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/comments/341809256","html_url":"https://github.com/HEP-FCC/FCCSW/issues/247#issuecomment-341809256","issue_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/247","id":341809256,"user":{"login":"MarkusFrankATcernch","id":8831087,"avatar_url":"https://avatars0.githubusercontent.com/u/8831087?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkusFrankATcernch","html_url":"https://github.com/MarkusFrankATcernch","followers_url":"https://api.github.com/users/MarkusFrankATcernch/followers","following_url":"https://api.github.com/users/MarkusFrankATcernch/following{/other_user}","gists_url":"https://api.github.com/users/MarkusFrankATcernch/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkusFrankATcernch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkusFrankATcernch/subscriptions","organizations_url":"https://api.github.com/users/MarkusFrankATcernch/orgs","repos_url":"https://api.github.com/users/MarkusFrankATcernch/repos","events_url":"https://api.github.com/users/MarkusFrankATcernch/events{/privacy}","received_events_url":"https://api.github.com/users/MarkusFrankATcernch/received_events","type":"User","site_admin":false},"created_at":"2017-11-03T19:52:06Z","updated_at":"2017-11-03T19:52:06Z","author_association":"NONE","body":"@vvolkl, @zaborowska : \r\nTheoretically the argument is correct. \r\nHowever, there are numerous computations in particular when it comes to the handling of volume ids, where the bitfield values are accessed using the IDDDescriptor object. At the end of the day the bitfield computations are done using integers for values and masks and here things could go unex[ectedly wrong.\r\nI for sure would not bet my life, that e.g. the VolumeManager still works correctly using these assumptions.\r\n\r\nIn order to stay consistent, it is highly advisable to have a common length of the system ID and then add a second field (ie. barrel, endcap-A, endcap-B, etc) if a subdivision of a given subdetector is necessary.\r\nThis also would lead to a clean solution without having to rely on hacks with assumptions, which later have a potential of becoming a bomb."}}
{"actor":{"display_login":"MarkusFrankATcernch"}}