{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/106305727","pull_request_review_id":27222198,"id":106305727,"diff_hunk":"@@ -0,0 +1,28 @@\n+﻿// Copyright (c) Microsoft. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+//-----------------------------------------------------------------------\n+\n+\n+using System.Collections.Generic;\n+\n+namespace Microsoft.Build.Globbing.Extensions\n+{\n+    /// <summary>\n+    /// Extensions for <see cref=\"IMsBuildGlob\"/>\n+    /// </summary>\n+    public static class IMsBuildGlobExtensions","path":"src/Build/Globbing/Extensions/IMSBuildGlobExtensions.cs","position":13,"original_position":13,"commit_id":"24e54f78d0e0b333d3e51ffd6229cece95cb7ef5","original_commit_id":"24e54f78d0e0b333d3e51ffd6229cece95cb7ef5","user":{"login":"AndyGerlicher","id":9847849,"avatar_url":"https://avatars0.githubusercontent.com/u/9847849?v=3","gravatar_id":"","url":"https://api.github.com/users/AndyGerlicher","html_url":"https://github.com/AndyGerlicher","followers_url":"https://api.github.com/users/AndyGerlicher/followers","following_url":"https://api.github.com/users/AndyGerlicher/following{/other_user}","gists_url":"https://api.github.com/users/AndyGerlicher/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyGerlicher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyGerlicher/subscriptions","organizations_url":"https://api.github.com/users/AndyGerlicher/orgs","repos_url":"https://api.github.com/users/AndyGerlicher/repos","events_url":"https://api.github.com/users/AndyGerlicher/events{/privacy}","received_events_url":"https://api.github.com/users/AndyGerlicher/received_events","type":"User","site_admin":false},"body":"Not an interface so remove the I from the name/file. Also for more consistency, use `MSBuildGlobExtensions` (uppercase `S`) even though resharper doesn't like it.","created_at":"2017-03-15T23:12:08Z","updated_at":"2017-03-15T23:12:08Z","html_url":"https://github.com/Microsoft/msbuild/pull/1859#discussion_r106305727","pull_request_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1859","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments/106305727"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/1859#discussion_r106305727"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1859"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1859","id":110544210,"html_url":"https://github.com/Microsoft/msbuild/pull/1859","diff_url":"https://github.com/Microsoft/msbuild/pull/1859.diff","patch_url":"https://github.com/Microsoft/msbuild/pull/1859.patch","issue_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1859","number":1859,"state":"open","locked":false,"title":"Globing APIs","user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars3.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"body":"Addresses #1794.\r\n\r\nThis PR has the subset of the APIs that CPS will need. Left for future work:\r\n- Add Expand method.\r\n- Don't use regexes when the glob does not contain any wildcards\r\n- Composites combine regexes for perf","created_at":"2017-03-14T04:01:42Z","updated_at":"2017-03-15T23:12:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9307a283c1dcd6b9534238dc5608c202eb09dec","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1859/commits","review_comments_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/1859/comments","review_comment_url":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/issues/1859/comments","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/24e54f78d0e0b333d3e51ffd6229cece95cb7ef5","head":{"label":"cdmihai:globAPI","ref":"globAPI","sha":"24e54f78d0e0b333d3e51ffd6229cece95cb7ef5","user":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars3.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"repo":{"id":43783196,"name":"msbuild","full_name":"cdmihai/msbuild","owner":{"login":"cdmihai","id":2255729,"avatar_url":"https://avatars3.githubusercontent.com/u/2255729?v=3","gravatar_id":"","url":"https://api.github.com/users/cdmihai","html_url":"https://github.com/cdmihai","followers_url":"https://api.github.com/users/cdmihai/followers","following_url":"https://api.github.com/users/cdmihai/following{/other_user}","gists_url":"https://api.github.com/users/cdmihai/gists{/gist_id}","starred_url":"https://api.github.com/users/cdmihai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cdmihai/subscriptions","organizations_url":"https://api.github.com/users/cdmihai/orgs","repos_url":"https://api.github.com/users/cdmihai/repos","events_url":"https://api.github.com/users/cdmihai/events{/privacy}","received_events_url":"https://api.github.com/users/cdmihai/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cdmihai/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":true,"url":"https://api.github.com/repos/cdmihai/msbuild","forks_url":"https://api.github.com/repos/cdmihai/msbuild/forks","keys_url":"https://api.github.com/repos/cdmihai/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cdmihai/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cdmihai/msbuild/teams","hooks_url":"https://api.github.com/repos/cdmihai/msbuild/hooks","issue_events_url":"https://api.github.com/repos/cdmihai/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/cdmihai/msbuild/events","assignees_url":"https://api.github.com/repos/cdmihai/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/cdmihai/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/cdmihai/msbuild/tags","blobs_url":"https://api.github.com/repos/cdmihai/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cdmihai/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cdmihai/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/cdmihai/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cdmihai/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/cdmihai/msbuild/languages","stargazers_url":"https://api.github.com/repos/cdmihai/msbuild/stargazers","contributors_url":"https://api.github.com/repos/cdmihai/msbuild/contributors","subscribers_url":"https://api.github.com/repos/cdmihai/msbuild/subscribers","subscription_url":"https://api.github.com/repos/cdmihai/msbuild/subscription","commits_url":"https://api.github.com/repos/cdmihai/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/cdmihai/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/cdmihai/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/cdmihai/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/cdmihai/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/cdmihai/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cdmihai/msbuild/merges","archive_url":"https://api.github.com/repos/cdmihai/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cdmihai/msbuild/downloads","issues_url":"https://api.github.com/repos/cdmihai/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/cdmihai/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/cdmihai/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/cdmihai/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cdmihai/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/cdmihai/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/cdmihai/msbuild/deployments","created_at":"2015-10-06T22:47:50Z","updated_at":"2016-01-27T00:00:17Z","pushed_at":"2017-03-15T17:35:09Z","git_url":"git://github.com/cdmihai/msbuild.git","ssh_url":"git@github.com:cdmihai/msbuild.git","clone_url":"https://github.com/cdmihai/msbuild.git","svn_url":"https://github.com/cdmihai/msbuild","homepage":null,"size":17338,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"7c51e86c33270152e5fb912a7722ad9b3eda5ad5","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":32051890,"name":"msbuild","full_name":"Microsoft/msbuild","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars1.githubusercontent.com/u/6154722?v=3","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/msbuild","description":"The Microsoft Build Engine (MSBuild) is the build platform for .NET and Visual Studio.","fork":false,"url":"https://api.github.com/repos/Microsoft/msbuild","forks_url":"https://api.github.com/repos/Microsoft/msbuild/forks","keys_url":"https://api.github.com/repos/Microsoft/msbuild/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/msbuild/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/msbuild/teams","hooks_url":"https://api.github.com/repos/Microsoft/msbuild/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/msbuild/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/msbuild/events","assignees_url":"https://api.github.com/repos/Microsoft/msbuild/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/msbuild/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/msbuild/tags","blobs_url":"https://api.github.com/repos/Microsoft/msbuild/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/msbuild/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/msbuild/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/msbuild/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/msbuild/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/msbuild/languages","stargazers_url":"https://api.github.com/repos/Microsoft/msbuild/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/msbuild/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/msbuild/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/msbuild/subscription","commits_url":"https://api.github.com/repos/Microsoft/msbuild/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/msbuild/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/msbuild/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/msbuild/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/msbuild/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/msbuild/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/msbuild/merges","archive_url":"https://api.github.com/repos/Microsoft/msbuild/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/msbuild/downloads","issues_url":"https://api.github.com/repos/Microsoft/msbuild/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/msbuild/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/msbuild/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/msbuild/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/msbuild/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/msbuild/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/msbuild/deployments","created_at":"2015-03-12T02:04:46Z","updated_at":"2017-03-15T20:16:06Z","pushed_at":"2017-03-15T23:04:59Z","git_url":"git://github.com/Microsoft/msbuild.git","ssh_url":"git@github.com:Microsoft/msbuild.git","clone_url":"https://github.com/Microsoft/msbuild.git","svn_url":"https://github.com/Microsoft/msbuild","homepage":null,"size":17281,"stargazers_count":2914,"watchers_count":2914,"language":"C#","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":628,"mirror_url":null,"open_issues_count":455,"forks":628,"open_issues":455,"watchers":2914,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1859"},"html":{"href":"https://github.com/Microsoft/msbuild/pull/1859"},"issue":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/1859"},"comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/issues/1859/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1859/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/msbuild/pulls/1859/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/msbuild/statuses/24e54f78d0e0b333d3e51ffd6229cece95cb7ef5"}}}}
{"actor":{"display_login":"AndyGerlicher"}}