{"action":"created","issue":{"url":"https://api.github.com/repos/phetsims/john-travoltage/issues/239","repository_url":"https://api.github.com/repos/phetsims/john-travoltage","labels_url":"https://api.github.com/repos/phetsims/john-travoltage/issues/239/labels{/name}","comments_url":"https://api.github.com/repos/phetsims/john-travoltage/issues/239/comments","events_url":"https://api.github.com/repos/phetsims/john-travoltage/issues/239/events","html_url":"https://github.com/phetsims/john-travoltage/issues/239","id":226110472,"number":239,"title":"[VO + Safari] Should we increment sliders with VO + Space?","user":{"login":"phet-steele","id":5863899,"avatar_url":"https://avatars1.githubusercontent.com/u/5863899?v=3","gravatar_id":"","url":"https://api.github.com/users/phet-steele","html_url":"https://github.com/phet-steele","followers_url":"https://api.github.com/users/phet-steele/followers","following_url":"https://api.github.com/users/phet-steele/following{/other_user}","gists_url":"https://api.github.com/users/phet-steele/gists{/gist_id}","starred_url":"https://api.github.com/users/phet-steele/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phet-steele/subscriptions","organizations_url":"https://api.github.com/users/phet-steele/orgs","repos_url":"https://api.github.com/users/phet-steele/repos","events_url":"https://api.github.com/users/phet-steele/events{/privacy}","received_events_url":"https://api.github.com/users/phet-steele/received_events","type":"User","site_admin":false},"labels":[{"id":322181766,"url":"https://api.github.com/repos/phetsims/john-travoltage/labels/dev:a11y","name":"dev:a11y","color":"008080","default":false},{"id":38998493,"url":"https://api.github.com/repos/phetsims/john-travoltage/labels/type:bug","name":"type:bug","color":"FF00AA","default":false},{"id":38998497,"url":"https://api.github.com/repos/phetsims/john-travoltage/labels/type:question","name":"type:question","color":"EDCB62","default":false}],"state":"open","locked":false,"assignee":{"login":"emily-phet","id":5109055,"avatar_url":"https://avatars0.githubusercontent.com/u/5109055?v=3","gravatar_id":"","url":"https://api.github.com/users/emily-phet","html_url":"https://github.com/emily-phet","followers_url":"https://api.github.com/users/emily-phet/followers","following_url":"https://api.github.com/users/emily-phet/following{/other_user}","gists_url":"https://api.github.com/users/emily-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/emily-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emily-phet/subscriptions","organizations_url":"https://api.github.com/users/emily-phet/orgs","repos_url":"https://api.github.com/users/emily-phet/repos","events_url":"https://api.github.com/users/emily-phet/events{/privacy}","received_events_url":"https://api.github.com/users/emily-phet/received_events","type":"User","site_admin":false},"assignees":[{"login":"emily-phet","id":5109055,"avatar_url":"https://avatars0.githubusercontent.com/u/5109055?v=3","gravatar_id":"","url":"https://api.github.com/users/emily-phet","html_url":"https://github.com/emily-phet","followers_url":"https://api.github.com/users/emily-phet/followers","following_url":"https://api.github.com/users/emily-phet/following{/other_user}","gists_url":"https://api.github.com/users/emily-phet/gists{/gist_id}","starred_url":"https://api.github.com/users/emily-phet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emily-phet/subscriptions","organizations_url":"https://api.github.com/users/emily-phet/orgs","repos_url":"https://api.github.com/users/emily-phet/repos","events_url":"https://api.github.com/users/emily-phet/events{/privacy}","received_events_url":"https://api.github.com/users/emily-phet/received_events","type":"User","site_admin":false},{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars3.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2017-05-03T20:49:42Z","updated_at":"2017-05-05T17:35:25Z","closed_at":null,"body":"The command \"VO + Space\" can be used on the leg or arm to perform their default action (as VO documentation puts it). In the case of the leg and arm, which are sliders, the default action is to increment the slider by 1.\r\n\r\nFor a basic idea of how this works, try the slider here: https://jsfiddle.net/1j1y3s8p/\r\n\r\nUsing VO + Space will increment the slider by one (no known way to decrement). Using the arrow keys of course move the slider in either direction. Using any combination of VO + Space and arrow keys behaves as expected...then there is our sim:\r\n\r\nHow the leg currently works with \"VO + Space\":\r\n\r\n1. From sim start up, focus on the leg. You will be read its position.\r\n2. Using VO + Space will work fine to increment the leg here....until,\r\n3. Use an arrow key to move the leg.\r\n4. Pressing VO + Space will no longer work. @jessegreenberg I believe step 3 leading to step 4 is the crux of the problem. If you press VO + Space, you will hear the current position with the word \"increment\" preceding the message BUT the leg no longer moves. Notice that more presses of VO + Space will repeat the same message with the same position value.\r\n5. After you've had your fun with VO + Space, use an arrow key to move the leg. The leg will jump to a position that is based on how many times you pressed VO + Space. For example, if you started at position -3 and pressed VO + Space 4 times, pressing the right arrow key will jump the leg to position 2 (-3 + 4 + 1[right arrow key] = 2). The problem with this is that you've moved through a large amount of positions without picking up any electrons.\r\n\r\nBonus bug: after using VO + Space on the leg/arm any number of times, then tabbing to the arm/leg, will cease messages coming from the latter appendage after the first couple (or few?) messages.\r\n\r\nBonus bonus bug: Similar to the first bonus bug, the appendage you are currently incrementing can also have its messages cease. I do not know how or why, but it might be tied to pressing VO + Space multiple times at an appendages max position.\r\n\r\nI'm inclined to say we make it so an appendage can be moved with VO + Space. However @emily-phet, it may not be necessary. It seems easy for users to learn that arrow keys are the better way to move an appendage. Even after running into these weird issues with VO + Space, the sim will quickly recover after a few tabs/arrow presses here and there. I'm also willing to bet that this is not a widely used key command. I would imagine this key command would have been brought up much earlier in interviews/design if it were widely used. @emily-phet up to you to have @jessegreenberg investigate why this is happening. My vote is to go ahead and support this feature. Why deny usability?\r\n\r\nSeen on macOS 10.12.4. For phetsims/tasks/issues/831."},"comment":{"url":"https://api.github.com/repos/phetsims/john-travoltage/issues/comments/299527789","html_url":"https://github.com/phetsims/john-travoltage/issues/239#issuecomment-299527789","issue_url":"https://api.github.com/repos/phetsims/john-travoltage/issues/239","id":299527789,"user":{"login":"jessegreenberg","id":6396244,"avatar_url":"https://avatars3.githubusercontent.com/u/6396244?v=3","gravatar_id":"","url":"https://api.github.com/users/jessegreenberg","html_url":"https://github.com/jessegreenberg","followers_url":"https://api.github.com/users/jessegreenberg/followers","following_url":"https://api.github.com/users/jessegreenberg/following{/other_user}","gists_url":"https://api.github.com/users/jessegreenberg/gists{/gist_id}","starred_url":"https://api.github.com/users/jessegreenberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessegreenberg/subscriptions","organizations_url":"https://api.github.com/users/jessegreenberg/orgs","repos_url":"https://api.github.com/users/jessegreenberg/repos","events_url":"https://api.github.com/users/jessegreenberg/events{/privacy}","received_events_url":"https://api.github.com/users/jessegreenberg/received_events","type":"User","site_admin":false},"created_at":"2017-05-05T17:35:25Z","updated_at":"2017-05-05T17:35:25Z","body":"Here is an updated JSFiddle example which lets us see the aria-valuetext:\r\n\r\nhttps://jsfiddle.net/1j1y3s8p/2/\r\n\r\nUsing the increment feature, the value is correct, but it also stops reading any aria-valuetext after incrementing.  That much seems like a VoiceOver problem."}}
{"actor":{"display_login":"jessegreenberg"}}