{"action":"created","comment":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/107021244","pull_request_review_id":27970972,"id":107021244,"diff_hunk":"@@ -2499,7 +2595,7 @@ compute_scalar_stats(VacAttrStatsP stats,\n \t\t\t * avoid repeated detoastings and resultant excess memory usage\n \t\t\t * during the comparisons.\tAlso, check to see if the value is\n \t\t\t * excessively wide, and if so don't detoast at all --- just\n-\t\t\t * ignore the value.\n+\t\t\t * ignore the column.","path":"src/backend/commands/analyze.c","position":246,"original_position":246,"commit_id":"142c278f4d2f395656c2036255db778dee6aab26","original_commit_id":"142c278f4d2f395656c2036255db778dee6aab26","user":{"login":"hlinnaka","id":191602,"avatar_url":"https://avatars1.githubusercontent.com/u/191602?v=3","gravatar_id":"","url":"https://api.github.com/users/hlinnaka","html_url":"https://github.com/hlinnaka","followers_url":"https://api.github.com/users/hlinnaka/followers","following_url":"https://api.github.com/users/hlinnaka/following{/other_user}","gists_url":"https://api.github.com/users/hlinnaka/gists{/gist_id}","starred_url":"https://api.github.com/users/hlinnaka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlinnaka/subscriptions","organizations_url":"https://api.github.com/users/hlinnaka/orgs","repos_url":"https://api.github.com/users/hlinnaka/repos","events_url":"https://api.github.com/users/hlinnaka/events{/privacy}","received_events_url":"https://api.github.com/users/hlinnaka/received_events","type":"User","site_admin":false},"body":"This change seems wrong. We only ignore the value here, not the whole column.","created_at":"2017-03-20T21:26:43Z","updated_at":"2017-03-20T21:26:43Z","html_url":"https://github.com/greenplum-db/gpdb/pull/2073#discussion_r107021244","pull_request_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2073","_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments/107021244"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/2073#discussion_r107021244"},"pull_request":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2073"}}},"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2073","id":111614543,"html_url":"https://github.com/greenplum-db/gpdb/pull/2073","diff_url":"https://github.com/greenplum-db/gpdb/pull/2073.diff","patch_url":"https://github.com/greenplum-db/gpdb/pull/2073.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2073","number":2073,"state":"open","locked":false,"title":"Analyze large strings","user":{"login":"bhuvnesh2703","id":10293569,"avatar_url":"https://avatars2.githubusercontent.com/u/10293569?v=3","gravatar_id":"","url":"https://api.github.com/users/bhuvnesh2703","html_url":"https://github.com/bhuvnesh2703","followers_url":"https://api.github.com/users/bhuvnesh2703/followers","following_url":"https://api.github.com/users/bhuvnesh2703/following{/other_user}","gists_url":"https://api.github.com/users/bhuvnesh2703/gists{/gist_id}","starred_url":"https://api.github.com/users/bhuvnesh2703/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhuvnesh2703/subscriptions","organizations_url":"https://api.github.com/users/bhuvnesh2703/orgs","repos_url":"https://api.github.com/users/bhuvnesh2703/repos","events_url":"https://api.github.com/users/bhuvnesh2703/events{/privacy}","received_events_url":"https://api.github.com/users/bhuvnesh2703/received_events","type":"User","site_admin":false},"body":"Mask columns exceeding threshold in analyze sample, and do not collect stats on them.\r\n\r\nAnalyze collects a sample from the table, in case the sample contains columns with huge length, the columns may result memory usage to go high cancelling the query.\r\n\r\nThis commit masks the lengthy columns to avoid high memory usage while collecting sample. If a column has exceeded a threshold no stats will be collected for this column and existing stale stats will be deleted\r\n\r\nApproach to address this issue :\r\n\r\n 1. Numeric types or Fixed length user defined types:\r\n      Always include the column in the sample.\r\n\r\n 2. Built in Variable length type :\r\n      Use octet_length() to get the detoasted size and exclude the column if the size exceeds column_threshhold (uncompressed)\r\n\r\n 3. User defined variable length type :\r\n      Check the toasted/compressed size and exclude the column if size exceeds column_threshhold (compressed)","created_at":"2017-03-20T18:00:41Z","updated_at":"2017-03-20T21:26:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13d8c022ad7ad506dc2eb15ca56ce2186aa3bab1","assignee":null,"assignees":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2073/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2073/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/2073/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/142c278f4d2f395656c2036255db778dee6aab26","head":{"label":"bhuvnesh2703:analyze-large-strings","ref":"analyze-large-strings","sha":"142c278f4d2f395656c2036255db778dee6aab26","user":{"login":"bhuvnesh2703","id":10293569,"avatar_url":"https://avatars2.githubusercontent.com/u/10293569?v=3","gravatar_id":"","url":"https://api.github.com/users/bhuvnesh2703","html_url":"https://github.com/bhuvnesh2703","followers_url":"https://api.github.com/users/bhuvnesh2703/followers","following_url":"https://api.github.com/users/bhuvnesh2703/following{/other_user}","gists_url":"https://api.github.com/users/bhuvnesh2703/gists{/gist_id}","starred_url":"https://api.github.com/users/bhuvnesh2703/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhuvnesh2703/subscriptions","organizations_url":"https://api.github.com/users/bhuvnesh2703/orgs","repos_url":"https://api.github.com/users/bhuvnesh2703/repos","events_url":"https://api.github.com/users/bhuvnesh2703/events{/privacy}","received_events_url":"https://api.github.com/users/bhuvnesh2703/received_events","type":"User","site_admin":false},"repo":{"id":67822977,"name":"gpdb","full_name":"bhuvnesh2703/gpdb","owner":{"login":"bhuvnesh2703","id":10293569,"avatar_url":"https://avatars2.githubusercontent.com/u/10293569?v=3","gravatar_id":"","url":"https://api.github.com/users/bhuvnesh2703","html_url":"https://github.com/bhuvnesh2703","followers_url":"https://api.github.com/users/bhuvnesh2703/followers","following_url":"https://api.github.com/users/bhuvnesh2703/following{/other_user}","gists_url":"https://api.github.com/users/bhuvnesh2703/gists{/gist_id}","starred_url":"https://api.github.com/users/bhuvnesh2703/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bhuvnesh2703/subscriptions","organizations_url":"https://api.github.com/users/bhuvnesh2703/orgs","repos_url":"https://api.github.com/users/bhuvnesh2703/repos","events_url":"https://api.github.com/users/bhuvnesh2703/events{/privacy}","received_events_url":"https://api.github.com/users/bhuvnesh2703/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bhuvnesh2703/gpdb","description":"Greenplum Database","fork":true,"url":"https://api.github.com/repos/bhuvnesh2703/gpdb","forks_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/forks","keys_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/teams","hooks_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/hooks","issue_events_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/events","assignees_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/tags","blobs_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/languages","stargazers_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/stargazers","contributors_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/contributors","subscribers_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/subscribers","subscription_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/subscription","commits_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/merges","archive_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/downloads","issues_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/bhuvnesh2703/gpdb/deployments","created_at":"2016-09-09T18:33:06Z","updated_at":"2016-09-09T18:34:31Z","pushed_at":"2017-03-20T17:58:08Z","git_url":"git://github.com/bhuvnesh2703/gpdb.git","ssh_url":"git@github.com:bhuvnesh2703/gpdb.git","clone_url":"https://github.com/bhuvnesh2703/gpdb.git","svn_url":"https://github.com/bhuvnesh2703/gpdb","homepage":"http://greenplum.org","size":208523,"stargazers_count":0,"watchers_count":0,"language":"PLpgSQL","has_issues":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:master","ref":"master","sha":"e8dd6b61db858dde66eb229de9bfbd3b6cf50918","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars1.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":44781140,"name":"gpdb","full_name":"greenplum-db/gpdb","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars1.githubusercontent.com/u/14097842?v=3","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb","description":"Greenplum Database","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb","forks_url":"https://api.github.com/repos/greenplum-db/gpdb/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb/deployments","created_at":"2015-10-23T00:25:17Z","updated_at":"2017-03-20T08:33:00Z","pushed_at":"2017-03-20T21:21:03Z","git_url":"git://github.com/greenplum-db/gpdb.git","ssh_url":"git@github.com:greenplum-db/gpdb.git","clone_url":"https://github.com/greenplum-db/gpdb.git","svn_url":"https://github.com/greenplum-db/gpdb","homepage":"http://greenplum.org","size":208604,"stargazers_count":1853,"watchers_count":1853,"language":"C","has_issues":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":568,"mirror_url":null,"open_issues_count":137,"forks":568,"open_issues":137,"watchers":1853,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2073"},"html":{"href":"https://github.com/greenplum-db/gpdb/pull/2073"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/2073"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/issues/2073/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2073/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb/pulls/2073/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb/statuses/142c278f4d2f395656c2036255db778dee6aab26"}}}}
{"actor":{"display_login":"hlinnaka"}}