{"action":"closed","issue":{"url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/519","repository_url":"https://api.github.com/repos/bhauman/lein-figwheel","labels_url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/519/labels{/name}","comments_url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/519/comments","events_url":"https://api.github.com/repos/bhauman/lein-figwheel/issues/519/events","html_url":"https://github.com/bhauman/lein-figwheel/issues/519","id":205244626,"number":519,"title":"Consider relaxing :closure-defines spec","user":{"login":"christianromney","id":5679,"avatar_url":"https://avatars.githubusercontent.com/u/5679?v=3","gravatar_id":"","url":"https://api.github.com/users/christianromney","html_url":"https://github.com/christianromney","followers_url":"https://api.github.com/users/christianromney/followers","following_url":"https://api.github.com/users/christianromney/following{/other_user}","gists_url":"https://api.github.com/users/christianromney/gists{/gist_id}","starred_url":"https://api.github.com/users/christianromney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christianromney/subscriptions","organizations_url":"https://api.github.com/users/christianromney/orgs","repos_url":"https://api.github.com/users/christianromney/repos","events_url":"https://api.github.com/users/christianromney/events{/privacy}","received_events_url":"https://api.github.com/users/christianromney/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-02-03T19:16:16Z","updated_at":"2017-02-04T02:09:56Z","closed_at":"2017-02-04T02:09:56Z","body":"I use `:closure-defines` to define some variables for my app. In some contexts, a blank string is a perfectly legitimate application value to use for some of these variables. However, upon starting Figwheel an exception is thrown from an internal spec saying that:\r\n\r\n```\r\nIt should satisfy one of: Number | NonBlankString | boolean?\r\n```\r\n\r\nWould you consider changing the spec to use`string?` rather than `NonBlankString` for this value? \r\n\r\nThanks for your work on Figwheel."}}
{"actor":{"display_login":"bhauman"}}