{"action":"created","issue":{"url":"https://api.github.com/repos/sympy/sympy/issues/11924","repository_url":"https://api.github.com/repos/sympy/sympy","labels_url":"https://api.github.com/repos/sympy/sympy/issues/11924/labels{/name}","comments_url":"https://api.github.com/repos/sympy/sympy/issues/11924/comments","events_url":"https://api.github.com/repos/sympy/sympy/issues/11924/events","html_url":"https://github.com/sympy/sympy/pull/11924","id":194510013,"number":11924,"title":"Modified is_positive for cosh function","user":{"login":"rohitrango","id":15312514,"avatar_url":"https://avatars2.githubusercontent.com/u/15312514?v=4","gravatar_id":"","url":"https://api.github.com/users/rohitrango","html_url":"https://github.com/rohitrango","followers_url":"https://api.github.com/users/rohitrango/followers","following_url":"https://api.github.com/users/rohitrango/following{/other_user}","gists_url":"https://api.github.com/users/rohitrango/gists{/gist_id}","starred_url":"https://api.github.com/users/rohitrango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohitrango/subscriptions","organizations_url":"https://api.github.com/users/rohitrango/orgs","repos_url":"https://api.github.com/users/rohitrango/repos","events_url":"https://api.github.com/users/rohitrango/events{/privacy}","received_events_url":"https://api.github.com/users/rohitrango/received_events","type":"User","site_admin":false},"labels":[{"id":222449974,"url":"https://api.github.com/repos/sympy/sympy/labels/PR:%20author's%20turn","name":"PR: author's turn","color":"eb6420","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2016-12-09T04:15:48Z","updated_at":"2017-10-02T14:22:12Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sympy/sympy/pulls/11924","html_url":"https://github.com/sympy/sympy/pull/11924","diff_url":"https://github.com/sympy/sympy/pull/11924.diff","patch_url":"https://github.com/sympy/sympy/pull/11924.patch"},"body":"Fixes #11721.\r\n\r\n`cosh(x).is_positive` returns `True` if x is real.\r\nAlso modified the `Abs` function to return the function itself or its negative if the function is positive or negative.\r\n\r\nExample:\r\n```\r\nIn [1]: r=symbols('r',real=True)\r\n\r\nIn [2]: abs(cosh(x))\r\nOut[2]: │cosh(x)│\r\n\r\nIn [3]: abs(cosh(r))\r\nOut[3]: cosh(r)\r\n\r\nIn [4]: abs(cosh(r)) == cosh(r)\r\nOut[4]: True\r\n\r\nIn [5]: abs(cosh(x)) == cosh(x)\r\nOut[5]: False\r\n\r\nIn [6]: cosh(r).is_positive\r\nOut[6]: True\r\n\r\nIn [7]: cosh(x).is_positive\r\n\r\nIn [8]:      \r\n```"},"comment":{"url":"https://api.github.com/repos/sympy/sympy/issues/comments/333549319","html_url":"https://github.com/sympy/sympy/pull/11924#issuecomment-333549319","issue_url":"https://api.github.com/repos/sympy/sympy/issues/11924","id":333549319,"user":{"login":"gxyd","id":7712241,"avatar_url":"https://avatars0.githubusercontent.com/u/7712241?v=4","gravatar_id":"","url":"https://api.github.com/users/gxyd","html_url":"https://github.com/gxyd","followers_url":"https://api.github.com/users/gxyd/followers","following_url":"https://api.github.com/users/gxyd/following{/other_user}","gists_url":"https://api.github.com/users/gxyd/gists{/gist_id}","starred_url":"https://api.github.com/users/gxyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gxyd/subscriptions","organizations_url":"https://api.github.com/users/gxyd/orgs","repos_url":"https://api.github.com/users/gxyd/repos","events_url":"https://api.github.com/users/gxyd/events{/privacy}","received_events_url":"https://api.github.com/users/gxyd/received_events","type":"User","site_admin":false},"created_at":"2017-10-02T14:22:12Z","updated_at":"2017-10-02T14:22:12Z","author_association":"MEMBER","body":"I was having an impression from the conversation (from comments by @jksuom ) that it could be possible to refactor your changes to return compound boolean expression. \r\n\r\n@jksuom do you think changes can (or should) be made?\r\n\r\nBTW, thanks for responding quickly :)"}}
{"actor":{"display_login":"gxyd"}}