{"action":"created","comment":{"url":"https://api.github.com/repos/apereo/cas/pulls/comments/122644263","pull_request_review_id":44776234,"id":122644263,"diff_hunk":"@@ -164,19 +163,20 @@ public MergingStrategy getMergingStrategy() {\n      * @return person attributes\n      */\n     private static Map<String, List<Object>> convertPrincipalAttributesToPersonAttributes(final Principal p) {\n-        final Map<String, List<Object>> convertedAttributes = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);\n         final Map<String, Object> principalAttributes = p.getAttributes();\n \n-        principalAttributes.entrySet().stream().forEach(entry -> {\n-            final Object values = entry.getValue();\n-            final String key = entry.getKey();\n-            if (values instanceof List) {\n-                convertedAttributes.put(key, (List) values);\n-            } else {\n-                convertedAttributes.put(key, Collections.singletonList(values));\n-            }\n-        });\n-        return convertedAttributes;\n+        return principalAttributes.entrySet().stream().collect(Collectors.toMap(\n+                Map.Entry::getKey,\n+                entry -> {\n+                    final Object values = entry.getValue();\n+                    if (values instanceof List) {\n+                        return (List) values;\n+                    } else {\n+                        return Collections.singletonList(values);\n+                    }\n+                },\n+                (e1, e2) -> e1,\n+                () -> new TreeMap<>(String.CASE_INSENSITIVE_ORDER)));","path":"core/cas-server-core-authentication/src/main/java/org/apereo/cas/authentication/principal/cache/AbstractPrincipalAttributesRepository.java","position":38,"original_position":38,"commit_id":"cb8fdee8bc3ef095a49e1ea0f6918fca890eb2a0","original_commit_id":"cb8fdee8bc3ef095a49e1ea0f6918fca890eb2a0","user":{"login":"codacy-bot","id":19940114,"avatar_url":"https://avatars2.githubusercontent.com/u/19940114?v=3","gravatar_id":"","url":"https://api.github.com/users/codacy-bot","html_url":"https://github.com/codacy-bot","followers_url":"https://api.github.com/users/codacy-bot/followers","following_url":"https://api.github.com/users/codacy-bot/following{/other_user}","gists_url":"https://api.github.com/users/codacy-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/codacy-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codacy-bot/subscriptions","organizations_url":"https://api.github.com/users/codacy-bot/orgs","repos_url":"https://api.github.com/users/codacy-bot/repos","events_url":"https://api.github.com/users/codacy-bot/events{/privacy}","received_events_url":"https://api.github.com/users/codacy-bot/received_events","type":"User","site_admin":false},"body":"![Codacy](https://www.codacy.com/assets/images/favicon.png) Issue found: ['lambda arguments' have incorrect indentation level 16, expected level should be 12.](https://www.codacy.com/app/mmoayyed/cas/pullRequest?prid=718684)","created_at":"2017-06-19T08:14:07Z","updated_at":"2017-06-19T08:14:07Z","html_url":"https://github.com/apereo/cas/pull/2693#discussion_r122644263","pull_request_url":"https://api.github.com/repos/apereo/cas/pulls/2693","_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments/122644263"},"html":{"href":"https://github.com/apereo/cas/pull/2693#discussion_r122644263"},"pull_request":{"href":"https://api.github.com/repos/apereo/cas/pulls/2693"}}},"pull_request":{"url":"https://api.github.com/repos/apereo/cas/pulls/2693","id":126244128,"html_url":"https://github.com/apereo/cas/pull/2693","diff_url":"https://github.com/apereo/cas/pull/2693.diff","patch_url":"https://github.com/apereo/cas/pull/2693.patch","issue_url":"https://api.github.com/repos/apereo/cas/issues/2693","number":2693,"state":"open","locked":false,"title":"improving streams","user":{"login":"DavidRG13","id":5788241,"avatar_url":"https://avatars1.githubusercontent.com/u/5788241?v=3","gravatar_id":"","url":"https://api.github.com/users/DavidRG13","html_url":"https://github.com/DavidRG13","followers_url":"https://api.github.com/users/DavidRG13/followers","following_url":"https://api.github.com/users/DavidRG13/following{/other_user}","gists_url":"https://api.github.com/users/DavidRG13/gists{/gist_id}","starred_url":"https://api.github.com/users/DavidRG13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavidRG13/subscriptions","organizations_url":"https://api.github.com/users/DavidRG13/orgs","repos_url":"https://api.github.com/users/DavidRG13/repos","events_url":"https://api.github.com/users/DavidRG13/events{/privacy}","received_events_url":"https://api.github.com/users/DavidRG13/received_events","type":"User","site_admin":false},"body":"Closes no issue.\r\n\r\nChanges:\r\n- Do not create intermediate collections\r\n- Do not process things twice","created_at":"2017-06-19T08:03:31Z","updated_at":"2017-06-19T08:14:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f6fa8ffedf3c10cfee14151f217ab7eba429919","assignee":null,"assignees":[],"requested_reviewers":[],"milestone":null,"commits_url":"https://api.github.com/repos/apereo/cas/pulls/2693/commits","review_comments_url":"https://api.github.com/repos/apereo/cas/pulls/2693/comments","review_comment_url":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apereo/cas/issues/2693/comments","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/cb8fdee8bc3ef095a49e1ea0f6918fca890eb2a0","head":{"label":"William-Hill-Online:streams","ref":"streams","sha":"cb8fdee8bc3ef095a49e1ea0f6918fca890eb2a0","user":{"login":"William-Hill-Online","id":16120005,"avatar_url":"https://avatars3.githubusercontent.com/u/16120005?v=3","gravatar_id":"","url":"https://api.github.com/users/William-Hill-Online","html_url":"https://github.com/William-Hill-Online","followers_url":"https://api.github.com/users/William-Hill-Online/followers","following_url":"https://api.github.com/users/William-Hill-Online/following{/other_user}","gists_url":"https://api.github.com/users/William-Hill-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/William-Hill-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/William-Hill-Online/subscriptions","organizations_url":"https://api.github.com/users/William-Hill-Online/orgs","repos_url":"https://api.github.com/users/William-Hill-Online/repos","events_url":"https://api.github.com/users/William-Hill-Online/events{/privacy}","received_events_url":"https://api.github.com/users/William-Hill-Online/received_events","type":"Organization","site_admin":false},"repo":{"id":71229990,"name":"cas","full_name":"William-Hill-Online/cas","owner":{"login":"William-Hill-Online","id":16120005,"avatar_url":"https://avatars3.githubusercontent.com/u/16120005?v=3","gravatar_id":"","url":"https://api.github.com/users/William-Hill-Online","html_url":"https://github.com/William-Hill-Online","followers_url":"https://api.github.com/users/William-Hill-Online/followers","following_url":"https://api.github.com/users/William-Hill-Online/following{/other_user}","gists_url":"https://api.github.com/users/William-Hill-Online/gists{/gist_id}","starred_url":"https://api.github.com/users/William-Hill-Online/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/William-Hill-Online/subscriptions","organizations_url":"https://api.github.com/users/William-Hill-Online/orgs","repos_url":"https://api.github.com/users/William-Hill-Online/repos","events_url":"https://api.github.com/users/William-Hill-Online/events{/privacy}","received_events_url":"https://api.github.com/users/William-Hill-Online/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/William-Hill-Online/cas","description":"Apereo CAS - Enterprise Single Sign On for all","fork":true,"url":"https://api.github.com/repos/William-Hill-Online/cas","forks_url":"https://api.github.com/repos/William-Hill-Online/cas/forks","keys_url":"https://api.github.com/repos/William-Hill-Online/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/William-Hill-Online/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/William-Hill-Online/cas/teams","hooks_url":"https://api.github.com/repos/William-Hill-Online/cas/hooks","issue_events_url":"https://api.github.com/repos/William-Hill-Online/cas/issues/events{/number}","events_url":"https://api.github.com/repos/William-Hill-Online/cas/events","assignees_url":"https://api.github.com/repos/William-Hill-Online/cas/assignees{/user}","branches_url":"https://api.github.com/repos/William-Hill-Online/cas/branches{/branch}","tags_url":"https://api.github.com/repos/William-Hill-Online/cas/tags","blobs_url":"https://api.github.com/repos/William-Hill-Online/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/William-Hill-Online/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/William-Hill-Online/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/William-Hill-Online/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/William-Hill-Online/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/William-Hill-Online/cas/languages","stargazers_url":"https://api.github.com/repos/William-Hill-Online/cas/stargazers","contributors_url":"https://api.github.com/repos/William-Hill-Online/cas/contributors","subscribers_url":"https://api.github.com/repos/William-Hill-Online/cas/subscribers","subscription_url":"https://api.github.com/repos/William-Hill-Online/cas/subscription","commits_url":"https://api.github.com/repos/William-Hill-Online/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/William-Hill-Online/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/William-Hill-Online/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/William-Hill-Online/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/William-Hill-Online/cas/contents/{+path}","compare_url":"https://api.github.com/repos/William-Hill-Online/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/William-Hill-Online/cas/merges","archive_url":"https://api.github.com/repos/William-Hill-Online/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/William-Hill-Online/cas/downloads","issues_url":"https://api.github.com/repos/William-Hill-Online/cas/issues{/number}","pulls_url":"https://api.github.com/repos/William-Hill-Online/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/William-Hill-Online/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/William-Hill-Online/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/William-Hill-Online/cas/labels{/name}","releases_url":"https://api.github.com/repos/William-Hill-Online/cas/releases{/id}","deployments_url":"https://api.github.com/repos/William-Hill-Online/cas/deployments","created_at":"2016-10-18T09:10:14Z","updated_at":"2016-11-22T16:29:51Z","pushed_at":"2017-06-19T08:01:28Z","git_url":"git://github.com/William-Hill-Online/cas.git","ssh_url":"git@github.com:William-Hill-Online/cas.git","clone_url":"https://github.com/William-Hill-Online/cas.git","svn_url":"https://github.com/William-Hill-Online/cas","homepage":"https://apereo.github.io/cas/","size":1273511,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"open_issues_count":0,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apereo:master","ref":"master","sha":"53cc1687efddbb5e2e178b4e28fec6b55c630de4","user":{"login":"apereo","id":4679233,"avatar_url":"https://avatars0.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"repo":{"id":2352744,"name":"cas","full_name":"apereo/cas","owner":{"login":"apereo","id":4679233,"avatar_url":"https://avatars0.githubusercontent.com/u/4679233?v=3","gravatar_id":"","url":"https://api.github.com/users/apereo","html_url":"https://github.com/apereo","followers_url":"https://api.github.com/users/apereo/followers","following_url":"https://api.github.com/users/apereo/following{/other_user}","gists_url":"https://api.github.com/users/apereo/gists{/gist_id}","starred_url":"https://api.github.com/users/apereo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apereo/subscriptions","organizations_url":"https://api.github.com/users/apereo/orgs","repos_url":"https://api.github.com/users/apereo/repos","events_url":"https://api.github.com/users/apereo/events{/privacy}","received_events_url":"https://api.github.com/users/apereo/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apereo/cas","description":"Apereo CAS - Enterprise Single Sign On for all earthlings and beyond.","fork":false,"url":"https://api.github.com/repos/apereo/cas","forks_url":"https://api.github.com/repos/apereo/cas/forks","keys_url":"https://api.github.com/repos/apereo/cas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apereo/cas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apereo/cas/teams","hooks_url":"https://api.github.com/repos/apereo/cas/hooks","issue_events_url":"https://api.github.com/repos/apereo/cas/issues/events{/number}","events_url":"https://api.github.com/repos/apereo/cas/events","assignees_url":"https://api.github.com/repos/apereo/cas/assignees{/user}","branches_url":"https://api.github.com/repos/apereo/cas/branches{/branch}","tags_url":"https://api.github.com/repos/apereo/cas/tags","blobs_url":"https://api.github.com/repos/apereo/cas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apereo/cas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apereo/cas/git/refs{/sha}","trees_url":"https://api.github.com/repos/apereo/cas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apereo/cas/statuses/{sha}","languages_url":"https://api.github.com/repos/apereo/cas/languages","stargazers_url":"https://api.github.com/repos/apereo/cas/stargazers","contributors_url":"https://api.github.com/repos/apereo/cas/contributors","subscribers_url":"https://api.github.com/repos/apereo/cas/subscribers","subscription_url":"https://api.github.com/repos/apereo/cas/subscription","commits_url":"https://api.github.com/repos/apereo/cas/commits{/sha}","git_commits_url":"https://api.github.com/repos/apereo/cas/git/commits{/sha}","comments_url":"https://api.github.com/repos/apereo/cas/comments{/number}","issue_comment_url":"https://api.github.com/repos/apereo/cas/issues/comments{/number}","contents_url":"https://api.github.com/repos/apereo/cas/contents/{+path}","compare_url":"https://api.github.com/repos/apereo/cas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apereo/cas/merges","archive_url":"https://api.github.com/repos/apereo/cas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apereo/cas/downloads","issues_url":"https://api.github.com/repos/apereo/cas/issues{/number}","pulls_url":"https://api.github.com/repos/apereo/cas/pulls{/number}","milestones_url":"https://api.github.com/repos/apereo/cas/milestones{/number}","notifications_url":"https://api.github.com/repos/apereo/cas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apereo/cas/labels{/name}","releases_url":"https://api.github.com/repos/apereo/cas/releases{/id}","deployments_url":"https://api.github.com/repos/apereo/cas/deployments","created_at":"2011-09-09T01:36:42Z","updated_at":"2017-06-19T02:42:02Z","pushed_at":"2017-06-19T08:03:32Z","git_url":"git://github.com/apereo/cas.git","ssh_url":"git@github.com:apereo/cas.git","clone_url":"https://github.com/apereo/cas.git","svn_url":"https://github.com/apereo/cas","homepage":"https://apereo.github.io/cas/","size":1309947,"stargazers_count":2723,"watchers_count":2723,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1578,"mirror_url":null,"open_issues_count":19,"forks":1578,"open_issues":19,"watchers":2723,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apereo/cas/pulls/2693"},"html":{"href":"https://github.com/apereo/cas/pull/2693"},"issue":{"href":"https://api.github.com/repos/apereo/cas/issues/2693"},"comments":{"href":"https://api.github.com/repos/apereo/cas/issues/2693/comments"},"review_comments":{"href":"https://api.github.com/repos/apereo/cas/pulls/2693/comments"},"review_comment":{"href":"https://api.github.com/repos/apereo/cas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apereo/cas/pulls/2693/commits"},"statuses":{"href":"https://api.github.com/repos/apereo/cas/statuses/cb8fdee8bc3ef095a49e1ea0f6918fca890eb2a0"}}}}
{"actor":{"display_login":"codacy-bot"}}