/*
 * #%L
 * ImageJ software for multidimensional image processing and analysis.
 * %%
 * Copyright (C) 2014 - 2016 Board of Regents of the University of
 * Wisconsin-Madison, University of Konstanz and Brian Northan.
 * %%
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are met:
 * 
 * 1. Redistributions of source code must retain the above copyright notice,
 *    this list of conditions and the following disclaimer.
 * 2. Redistributions in binary form must reproduce the above copyright notice,
 *    this list of conditions and the following disclaimer in the documentation
 *    and/or other materials provided with the distribution.
 * 
 * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
 * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
 * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
 * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDERS OR CONTRIBUTORS BE
 * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
 * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
 * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
 * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
 * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
 * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
 * POSSIBILITY OF SUCH DAMAGE.
 * #L%
 */

package net.imagej.ops.geom.geom2d;

import net.imagej.ops.Ops;
import net.imagej.ops.special.chain.RTs;
import net.imagej.ops.special.function.UnaryFunctionOp;
import net.imagej.ops.special.hybrid.AbstractUnaryHybridCF;
import net.imglib2.roi.geometric.Polygon;
import net.imglib2.type.numeric.real.DoubleType;

import org.scijava.plugin.Plugin;

/**
 * Generic implementation of {@code geom.eccentricity}.
 * 
 * @author Daniel Seebacher (University of Konstanz)
 */
@Plugin(type = Ops.Geometric.Eccentricity.class,
	label = "Geometric (2D): Eccentricity")
public class DefaultEccentricity extends AbstractUnaryHybridCF<Polygon, DoubleType>
	implements Ops.Geometric.Eccentricity
{

	private UnaryFunctionOp<Polygon, DoubleType> minorAxisFunc;
	private UnaryFunctionOp<Polygon, DoubleType> majorAxisFunc;

	@Override
	public void initialize() {
		minorAxisFunc = RTs.function(ops(), Ops.Geometric.MinorAxis.class, in());
		majorAxisFunc = RTs.function(ops(), Ops.Geometric.MajorAxis.class, in());
	}

	@Override
	public void compute1(final Polygon input, final DoubleType output) {
		output.set(majorAxisFunc.compute1(input).getRealDouble() /
			minorAxisFunc.compute1(input).getRealDouble());
	}
	
	@Override
	public DoubleType createOutput(Polygon input) {
		return new DoubleType();
	}

}

@@ -1953,34 +1953,141 @@
 %0A * 
-@author Daniel Seebacher (
+The eccentricity formula is based on %22The Eccentricity of a Conic Section%22 by%0A * Ayoub B. Ayoub.%0A * %0A * @author Tim-Oliver Buchholz, 
 Univ
@@ -2104,17 +2104,16 @@
 Konstanz
-)
 %0A */%0A@Pl
@@ -2157,18 +2157,17 @@
 y.class,
-%0A%09
+ 
 label = 
@@ -2282,16 +2282,17 @@
 leType%3E%0A
+%09
 %09impleme
@@ -2321,17 +2321,17 @@
 ntricity
-%0A
+ 
 %7B%0A%0A%09priv
@@ -2728,21 +2728,28 @@
 ) %7B%0A
+%0A
 %09%09
-output.set(
+final double a = 
 majo
@@ -2781,26 +2781,37 @@
 .get
-RealDouble() /%0A%09%09%09
+() / 2.0;%0A%09%09final double b = 
 mino
@@ -2843,27 +2843,71 @@
 .get
-RealDouble(
+() / 2.0;%0A%0A%09%09output.set(Math.sqrt(1 - Math.pow(b / a, 2)
 ));%0A%09%7D%0A
-%09
 %0A%09@O

Fix eccentricity implementation.