Datasets:

---

labofsahil

/

github-event-dataset-2018

like 0

Follow

Sahil 2

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/comments/236987880","pull_request_review_id":179178004,"id":236987880,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjk4Nzg4MA==","diff_hunk":"@@ -526,6 +530,134 @@ def execute(self, context):\n self.database)\n \n \n+class CloudSqlInstanceExportOperator(CloudSqlBaseOperator):\n+ \"\"\"\n+ Exports data from a Cloud SQL instance to a Cloud Storage bucket as a SQL dump\n+ or CSV file.\n+\n+ Note: This operator is idempotent. If executed multiple times with the same\n+ export file URI, the export file in GCS will simply be overridden.\n+\n+ :param project_id: Project ID of the project that contains the instance to be\n+ exported.\n+ :type project_id: str\n+ :param instance: Cloud SQL instance ID. This does not include the project ID.\n+ :type instance: str\n+ :param body: The request body, as described in\n+ https://cloud.google.com/sql/docs/mysql/admin-api/v1beta4/instances/export#request-body\n+ :type body: dict\n+ :param gcp_conn_id: The connection ID used to connect to Google Cloud Platform.\n+ :type gcp_conn_id: str\n+ :param api_version: API version used (e.g. v1beta4).\n+ :type api_version: str\n+ :param validate_body: Whether the body should be validated. Defaults to True.\n+ :type validate_body: bool\n+ \"\"\"\n+ # [START gcp_sql_export_template_fields]\n+ template_fields = ('project_id', 'instance', 'gcp_conn_id', 'api_version')\n+ # [END gcp_sql_export_template_fields]\n+\n+ @apply_defaults\n+ def __init__(self,\n+ project_id,\n+ instance,\n+ body,\n+ gcp_conn_id='google_cloud_default',\n+ api_version='v1beta4',\n+ validate_body=True,\n+ *args, **kwargs):\n+ self.body = body\n+ self.validate_body = validate_body\n+ super(CloudSqlInstanceExportOperator, self).__init__(\n+ project_id=project_id, instance=instance, gcp_conn_id=gcp_conn_id,\n+ api_version=api_version, *args, **kwargs)\n+\n+ def _validate_inputs(self):\n+ super(CloudSqlInstanceExportOperator, self)._validate_inputs()\n+ if not self.body:\n+ raise AirflowException(\"The required parameter 'body' is empty\")\n+\n+ def _validate_body_fields(self):\n+ if self.validate_body:\n+ GcpBodyFieldValidator(CLOUD_SQL_EXPORT_VALIDATION,\n+ api_version=self.api_version).validate(self.body)\n+\n+ def execute(self, context):\n+ self._validate_body_fields()\n+ return self._hook.export_instance(self.project_id, self.instance, self.body)\n+\n+\n+class CloudSqlInstanceImportOperator(CloudSqlBaseOperator):\n+ \"\"\"\n+ Imports data into a Cloud SQL instance from a SQL dump or CSV file in Cloud Storage.\n+\n+ CSV IMPORT:\n+\n+ This operator is NOT idempotent for a CSV import. If the same file is imported\n+ multiple times, the imported data will be duplicated in the database.\n+ Moreover, if there are any unique constraints the duplicate import may result in an\n+ error.\n+\n+ To ensure idempotence you can use the CloudSqlQueryOperator in your DAG before\n+ the import to delete the table(s) which may be imported again.","path":"airflow/contrib/operators/gcp_sql_operator.py","position":null,"original_position":148,"commit_id":"842973846b3d03ed94ba63a72b39e3744ce8bce8","original_commit_id":"0ee852c5e325807ce91d706acecb85120ec869f6","user":{"login":"sprzedwojski","id":4280682,"node_id":"MDQ6VXNlcjQyODA2ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/4280682?v=4","gravatar_id":"","url":"https://api.github.com/users/sprzedwojski","html_url":"https://github.com/sprzedwojski","followers_url":"https://api.github.com/users/sprzedwojski/followers","following_url":"https://api.github.com/users/sprzedwojski/following{/other_user}","gists_url":"https://api.github.com/users/sprzedwojski/gists{/gist_id}","starred_url":"https://api.github.com/users/sprzedwojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprzedwojski/subscriptions","organizations_url":"https://api.github.com/users/sprzedwojski/orgs","repos_url":"https://api.github.com/users/sprzedwojski/repos","events_url":"https://api.github.com/users/sprzedwojski/events{/privacy}","received_events_url":"https://api.github.com/users/sprzedwojski/received_events","type":"User","site_admin":false},"body":"You're right, haven't thought of that. I removed that line and am just saying it's not idempotent.","created_at":"2018-11-28T08:52:13Z","updated_at":"2018-11-28T08:52:14Z","html_url":"https://github.com/PolideaInternal/incubator-airflow/pull/15#discussion_r236987880","pull_request_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/15","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/comments/236987880"},"html":{"href":"https://github.com/PolideaInternal/incubator-airflow/pull/15#discussion_r236987880"},"pull_request":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/15"}},"in_reply_to_id":236798475},"pull_request":{"url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/15","id":232633423,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjMzNDIz","html_url":"https://github.com/PolideaInternal/incubator-airflow/pull/15","diff_url":"https://github.com/PolideaInternal/incubator-airflow/pull/15.diff","patch_url":"https://github.com/PolideaInternal/incubator-airflow/pull/15.patch","issue_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues/15","number":15,"state":"open","locked":false,"title":"Cloud SQL: export and import","user":{"login":"sprzedwojski","id":4280682,"node_id":"MDQ6VXNlcjQyODA2ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/4280682?v=4","gravatar_id":"","url":"https://api.github.com/users/sprzedwojski","html_url":"https://github.com/sprzedwojski","followers_url":"https://api.github.com/users/sprzedwojski/followers","following_url":"https://api.github.com/users/sprzedwojski/following{/other_user}","gists_url":"https://api.github.com/users/sprzedwojski/gists{/gist_id}","starred_url":"https://api.github.com/users/sprzedwojski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sprzedwojski/subscriptions","organizations_url":"https://api.github.com/users/sprzedwojski/orgs","repos_url":"https://api.github.com/users/sprzedwojski/repos","events_url":"https://api.github.com/users/sprzedwojski/events{/privacy}","received_events_url":"https://api.github.com/users/sprzedwojski/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-21T11:42:42Z","updated_at":"2018-11-28T08:52:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f39cedada38fd1b90531606f37e3a91be20d8a63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/15/commits","review_comments_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/15/comments","review_comment_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues/15/comments","statuses_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/statuses/842973846b3d03ed94ba63a72b39e3744ce8bce8","head":{"label":"PolideaInternal:cloud-sql-exp-imp__new","ref":"cloud-sql-exp-imp__new","sha":"842973846b3d03ed94ba63a72b39e3744ce8bce8","user":{"login":"PolideaInternal","id":31278126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc4MTI2","avatar_url":"https://avatars2.githubusercontent.com/u/31278126?v=4","gravatar_id":"","url":"https://api.github.com/users/PolideaInternal","html_url":"https://github.com/PolideaInternal","followers_url":"https://api.github.com/users/PolideaInternal/followers","following_url":"https://api.github.com/users/PolideaInternal/following{/other_user}","gists_url":"https://api.github.com/users/PolideaInternal/gists{/gist_id}","starred_url":"https://api.github.com/users/PolideaInternal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolideaInternal/subscriptions","organizations_url":"https://api.github.com/users/PolideaInternal/orgs","repos_url":"https://api.github.com/users/PolideaInternal/repos","events_url":"https://api.github.com/users/PolideaInternal/events{/privacy}","received_events_url":"https://api.github.com/users/PolideaInternal/received_events","type":"Organization","site_admin":false},"repo":{"id":147329695,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczMjk2OTU=","name":"incubator-airflow","full_name":"PolideaInternal/incubator-airflow","private":false,"owner":{"login":"PolideaInternal","id":31278126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc4MTI2","avatar_url":"https://avatars2.githubusercontent.com/u/31278126?v=4","gravatar_id":"","url":"https://api.github.com/users/PolideaInternal","html_url":"https://github.com/PolideaInternal","followers_url":"https://api.github.com/users/PolideaInternal/followers","following_url":"https://api.github.com/users/PolideaInternal/following{/other_user}","gists_url":"https://api.github.com/users/PolideaInternal/gists{/gist_id}","starred_url":"https://api.github.com/users/PolideaInternal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolideaInternal/subscriptions","organizations_url":"https://api.github.com/users/PolideaInternal/orgs","repos_url":"https://api.github.com/users/PolideaInternal/repos","events_url":"https://api.github.com/users/PolideaInternal/events{/privacy}","received_events_url":"https://api.github.com/users/PolideaInternal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolideaInternal/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/PolideaInternal/incubator-airflow","forks_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/forks","keys_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/events","assignees_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/merges","archive_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/deployments","created_at":"2018-09-04T10:35:22Z","updated_at":"2018-11-26T12:04:34Z","pushed_at":"2018-11-28T08:47:59Z","git_url":"git://github.com/PolideaInternal/incubator-airflow.git","ssh_url":"[email protected]:PolideaInternal/incubator-airflow.git","clone_url":"https://github.com/PolideaInternal/incubator-airflow.git","svn_url":"https://github.com/PolideaInternal/incubator-airflow","homepage":"https://airflow.apache.org","size":27888,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"base":{"label":"PolideaInternal:master","ref":"master","sha":"e56e625152da98c20b453b67b1333fb2b8597194","user":{"login":"PolideaInternal","id":31278126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc4MTI2","avatar_url":"https://avatars2.githubusercontent.com/u/31278126?v=4","gravatar_id":"","url":"https://api.github.com/users/PolideaInternal","html_url":"https://github.com/PolideaInternal","followers_url":"https://api.github.com/users/PolideaInternal/followers","following_url":"https://api.github.com/users/PolideaInternal/following{/other_user}","gists_url":"https://api.github.com/users/PolideaInternal/gists{/gist_id}","starred_url":"https://api.github.com/users/PolideaInternal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolideaInternal/subscriptions","organizations_url":"https://api.github.com/users/PolideaInternal/orgs","repos_url":"https://api.github.com/users/PolideaInternal/repos","events_url":"https://api.github.com/users/PolideaInternal/events{/privacy}","received_events_url":"https://api.github.com/users/PolideaInternal/received_events","type":"Organization","site_admin":false},"repo":{"id":147329695,"node_id":"MDEwOlJlcG9zaXRvcnkxNDczMjk2OTU=","name":"incubator-airflow","full_name":"PolideaInternal/incubator-airflow","private":false,"owner":{"login":"PolideaInternal","id":31278126,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMjc4MTI2","avatar_url":"https://avatars2.githubusercontent.com/u/31278126?v=4","gravatar_id":"","url":"https://api.github.com/users/PolideaInternal","html_url":"https://github.com/PolideaInternal","followers_url":"https://api.github.com/users/PolideaInternal/followers","following_url":"https://api.github.com/users/PolideaInternal/following{/other_user}","gists_url":"https://api.github.com/users/PolideaInternal/gists{/gist_id}","starred_url":"https://api.github.com/users/PolideaInternal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolideaInternal/subscriptions","organizations_url":"https://api.github.com/users/PolideaInternal/orgs","repos_url":"https://api.github.com/users/PolideaInternal/repos","events_url":"https://api.github.com/users/PolideaInternal/events{/privacy}","received_events_url":"https://api.github.com/users/PolideaInternal/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolideaInternal/incubator-airflow","description":"Apache Airflow (Incubating)","fork":true,"url":"https://api.github.com/repos/PolideaInternal/incubator-airflow","forks_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/forks","keys_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/teams","hooks_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/hooks","issue_events_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues/events{/number}","events_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/events","assignees_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/assignees{/user}","branches_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/branches{/branch}","tags_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/tags","blobs_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/statuses/{sha}","languages_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/languages","stargazers_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/stargazers","contributors_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/contributors","subscribers_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/subscribers","subscription_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/subscription","commits_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/contents/{+path}","compare_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/merges","archive_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/downloads","issues_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues{/number}","pulls_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls{/number}","milestones_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/milestones{/number}","notifications_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/labels{/name}","releases_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/releases{/id}","deployments_url":"https://api.github.com/repos/PolideaInternal/incubator-airflow/deployments","created_at":"2018-09-04T10:35:22Z","updated_at":"2018-11-26T12:04:34Z","pushed_at":"2018-11-28T08:47:59Z","git_url":"git://github.com/PolideaInternal/incubator-airflow.git","ssh_url":"[email protected]:PolideaInternal/incubator-airflow.git","clone_url":"https://github.com/PolideaInternal/incubator-airflow.git","svn_url":"https://github.com/PolideaInternal/incubator-airflow","homepage":"https://airflow.apache.org","size":27888,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":6,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/15"},"html":{"href":"https://github.com/PolideaInternal/incubator-airflow/pull/15"},"issue":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues/15"},"comments":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/PolideaInternal/incubator-airflow/statuses/842973846b3d03ed94ba63a72b39e3744ce8bce8"}},"author_association":"NONE"}}

8660154523

{"actor":{"display_login":"sprzedwojski"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/d3ledger/back-office/pulls/comments/212658764","pull_request_review_id":149341482,"id":212658764,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY1ODc2NA==","diff_hunk":"@@ -19,8 +19,7 @@ const set = {\n { pattern: /^([a-z0-9\\-.]*)\\.(([a-z]{2,4})|([0-9]{1,3}\\.([0-9]{1,3})\\.([0-9]{1,3})))|(:[0-9]{1,5})$/, message: 'Invalid IP', trigger: 'change' }\n ],\n walletAddress: [\n- { required: true, message: 'Please input wallet address', trigger: 'change' },\n- { pattern: /^0x[a-fA-F0-9]{40}$/, message: 'Invalid wallet address', trigger: 'change' }","path":"src/components/mixins/inputValidation.js","position":5,"original_position":5,"commit_id":"0ab3aae4d90720473eb887fea1fb8075439394ea","original_commit_id":"0ab3aae4d90720473eb887fea1fb8075439394ea","user":{"login":"Pobepto","id":16295803,"node_id":"MDQ6VXNlcjE2Mjk1ODAz","avatar_url":"https://avatars1.githubusercontent.com/u/16295803?v=4","gravatar_id":"","url":"https://api.github.com/users/Pobepto","html_url":"https://github.com/Pobepto","followers_url":"https://api.github.com/users/Pobepto/followers","following_url":"https://api.github.com/users/Pobepto/following{/other_user}","gists_url":"https://api.github.com/users/Pobepto/gists{/gist_id}","starred_url":"https://api.github.com/users/Pobepto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pobepto/subscriptions","organizations_url":"https://api.github.com/users/Pobepto/orgs","repos_url":"https://api.github.com/users/Pobepto/repos","events_url":"https://api.github.com/users/Pobepto/events{/privacy}","received_events_url":"https://api.github.com/users/Pobepto/received_events","type":"User","site_admin":false},"body":"I'm trying to do something like this:\r\n``` javascript\r\n walletAddress: [\r\n { required: true, message: 'Please input wallet address', trigger: 'change' },\r\n { pattern: /^[13][a-km-zA-HJ-NP-Z1-9]{25,34}$/, message: 'Invalid wallet address', trigger: 'change' },\r\n { pattern: /^0x[a-fA-F0-9]{40}$/, message: 'Invalid wallet address', trigger: 'change' }\r\n ]\r\n```\r\nbut this don't work. It always says that wallet address is invalid.","created_at":"2018-08-24T15:04:13Z","updated_at":"2018-08-24T15:04:13Z","html_url":"https://github.com/d3ledger/back-office/pull/37#discussion_r212658764","pull_request_url":"https://api.github.com/repos/d3ledger/back-office/pulls/37","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/d3ledger/back-office/pulls/comments/212658764"},"html":{"href":"https://github.com/d3ledger/back-office/pull/37#discussion_r212658764"},"pull_request":{"href":"https://api.github.com/repos/d3ledger/back-office/pulls/37"}},"in_reply_to_id":212563806},"pull_request":{"url":"https://api.github.com/repos/d3ledger/back-office/pulls/37","id":209138473,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTM4NDcz","html_url":"https://github.com/d3ledger/back-office/pull/37","diff_url":"https://github.com/d3ledger/back-office/pull/37.diff","patch_url":"https://github.com/d3ledger/back-office/pull/37.patch","issue_url":"https://api.github.com/repos/d3ledger/back-office/issues/37","number":37,"state":"open","locked":false,"title":"D3-265 | Feature white list","user":{"login":"Pobepto","id":16295803,"node_id":"MDQ6VXNlcjE2Mjk1ODAz","avatar_url":"https://avatars1.githubusercontent.com/u/16295803?v=4","gravatar_id":"","url":"https://api.github.com/users/Pobepto","html_url":"https://github.com/Pobepto","followers_url":"https://api.github.com/users/Pobepto/followers","following_url":"https://api.github.com/users/Pobepto/following{/other_user}","gists_url":"https://api.github.com/users/Pobepto/gists{/gist_id}","starred_url":"https://api.github.com/users/Pobepto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pobepto/subscriptions","organizations_url":"https://api.github.com/users/Pobepto/orgs","repos_url":"https://api.github.com/users/Pobepto/repos","events_url":"https://api.github.com/users/Pobepto/events{/privacy}","received_events_url":"https://api.github.com/users/Pobepto/received_events","type":"User","site_admin":false},"body":"# Description\r\nAdd white list for the front end part. When user try to withdraw money it should select address from list of available addresses.\r\n# Screenshots\r\n**Wallets page -> Withdraw modal**\r\n\r\n**Settings page**\r\n\r\n\r\n\r\n#### Works done\r\n- [x] Added getter for white list\r\n- [x] Changed input field to select field\r\n- [x] Added privacy list to settings page\r\n- [x] Changed script to send key 'eth_whitelist' to account via `setAccountDetail`\r\n\r\n# How to check\r\n1. `yarn` to install new packages.\r\n2. `yarn serve` to run dev server.","created_at":"2018-08-17T12:51:23Z","updated_at":"2018-08-24T15:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bbc5dac4c8b99731c9db1d322513eb710952458","assignee":{"login":"Pobepto","id":16295803,"node_id":"MDQ6VXNlcjE2Mjk1ODAz","avatar_url":"https://avatars1.githubusercontent.com/u/16295803?v=4","gravatar_id":"","url":"https://api.github.com/users/Pobepto","html_url":"https://github.com/Pobepto","followers_url":"https://api.github.com/users/Pobepto/followers","following_url":"https://api.github.com/users/Pobepto/following{/other_user}","gists_url":"https://api.github.com/users/Pobepto/gists{/gist_id}","starred_url":"https://api.github.com/users/Pobepto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pobepto/subscriptions","organizations_url":"https://api.github.com/users/Pobepto/orgs","repos_url":"https://api.github.com/users/Pobepto/repos","events_url":"https://api.github.com/users/Pobepto/events{/privacy}","received_events_url":"https://api.github.com/users/Pobepto/received_events","type":"User","site_admin":false},"assignees":[{"login":"Pobepto","id":16295803,"node_id":"MDQ6VXNlcjE2Mjk1ODAz","avatar_url":"https://avatars1.githubusercontent.com/u/16295803?v=4","gravatar_id":"","url":"https://api.github.com/users/Pobepto","html_url":"https://github.com/Pobepto","followers_url":"https://api.github.com/users/Pobepto/followers","following_url":"https://api.github.com/users/Pobepto/following{/other_user}","gists_url":"https://api.github.com/users/Pobepto/gists{/gist_id}","starred_url":"https://api.github.com/users/Pobepto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pobepto/subscriptions","organizations_url":"https://api.github.com/users/Pobepto/orgs","repos_url":"https://api.github.com/users/Pobepto/repos","events_url":"https://api.github.com/users/Pobepto/events{/privacy}","received_events_url":"https://api.github.com/users/Pobepto/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/d3ledger/back-office/pulls/37/commits","review_comments_url":"https://api.github.com/repos/d3ledger/back-office/pulls/37/comments","review_comment_url":"https://api.github.com/repos/d3ledger/back-office/pulls/comments{/number}","comments_url":"https://api.github.com/repos/d3ledger/back-office/issues/37/comments","statuses_url":"https://api.github.com/repos/d3ledger/back-office/statuses/0ab3aae4d90720473eb887fea1fb8075439394ea","head":{"label":"d3ledger:feature/D3-256-whitelist","ref":"feature/D3-256-whitelist","sha":"0ab3aae4d90720473eb887fea1fb8075439394ea","user":{"login":"d3ledger","id":31348469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ4NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/31348469?v=4","gravatar_id":"","url":"https://api.github.com/users/d3ledger","html_url":"https://github.com/d3ledger","followers_url":"https://api.github.com/users/d3ledger/followers","following_url":"https://api.github.com/users/d3ledger/following{/other_user}","gists_url":"https://api.github.com/users/d3ledger/gists{/gist_id}","starred_url":"https://api.github.com/users/d3ledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3ledger/subscriptions","organizations_url":"https://api.github.com/users/d3ledger/orgs","repos_url":"https://api.github.com/users/d3ledger/repos","events_url":"https://api.github.com/users/d3ledger/events{/privacy}","received_events_url":"https://api.github.com/users/d3ledger/received_events","type":"Organization","site_admin":false},"repo":{"id":129922092,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5MjIwOTI=","name":"back-office","full_name":"d3ledger/back-office","owner":{"login":"d3ledger","id":31348469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ4NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/31348469?v=4","gravatar_id":"","url":"https://api.github.com/users/d3ledger","html_url":"https://github.com/d3ledger","followers_url":"https://api.github.com/users/d3ledger/followers","following_url":"https://api.github.com/users/d3ledger/following{/other_user}","gists_url":"https://api.github.com/users/d3ledger/gists{/gist_id}","starred_url":"https://api.github.com/users/d3ledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3ledger/subscriptions","organizations_url":"https://api.github.com/users/d3ledger/orgs","repos_url":"https://api.github.com/users/d3ledger/repos","events_url":"https://api.github.com/users/d3ledger/events{/privacy}","received_events_url":"https://api.github.com/users/d3ledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d3ledger/back-office","description":"Web application for an operator of D3 notary","fork":false,"url":"https://api.github.com/repos/d3ledger/back-office","forks_url":"https://api.github.com/repos/d3ledger/back-office/forks","keys_url":"https://api.github.com/repos/d3ledger/back-office/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3ledger/back-office/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3ledger/back-office/teams","hooks_url":"https://api.github.com/repos/d3ledger/back-office/hooks","issue_events_url":"https://api.github.com/repos/d3ledger/back-office/issues/events{/number}","events_url":"https://api.github.com/repos/d3ledger/back-office/events","assignees_url":"https://api.github.com/repos/d3ledger/back-office/assignees{/user}","branches_url":"https://api.github.com/repos/d3ledger/back-office/branches{/branch}","tags_url":"https://api.github.com/repos/d3ledger/back-office/tags","blobs_url":"https://api.github.com/repos/d3ledger/back-office/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3ledger/back-office/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3ledger/back-office/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3ledger/back-office/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3ledger/back-office/statuses/{sha}","languages_url":"https://api.github.com/repos/d3ledger/back-office/languages","stargazers_url":"https://api.github.com/repos/d3ledger/back-office/stargazers","contributors_url":"https://api.github.com/repos/d3ledger/back-office/contributors","subscribers_url":"https://api.github.com/repos/d3ledger/back-office/subscribers","subscription_url":"https://api.github.com/repos/d3ledger/back-office/subscription","commits_url":"https://api.github.com/repos/d3ledger/back-office/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3ledger/back-office/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3ledger/back-office/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3ledger/back-office/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3ledger/back-office/contents/{+path}","compare_url":"https://api.github.com/repos/d3ledger/back-office/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3ledger/back-office/merges","archive_url":"https://api.github.com/repos/d3ledger/back-office/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3ledger/back-office/downloads","issues_url":"https://api.github.com/repos/d3ledger/back-office/issues{/number}","pulls_url":"https://api.github.com/repos/d3ledger/back-office/pulls{/number}","milestones_url":"https://api.github.com/repos/d3ledger/back-office/milestones{/number}","notifications_url":"https://api.github.com/repos/d3ledger/back-office/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3ledger/back-office/labels{/name}","releases_url":"https://api.github.com/repos/d3ledger/back-office/releases{/id}","deployments_url":"https://api.github.com/repos/d3ledger/back-office/deployments","created_at":"2018-04-17T15:02:39Z","updated_at":"2018-06-15T07:55:06Z","pushed_at":"2018-08-24T14:59:23Z","git_url":"git://github.com/d3ledger/back-office.git","ssh_url":"[email protected]:d3ledger/back-office.git","clone_url":"https://github.com/d3ledger/back-office.git","svn_url":"https://github.com/d3ledger/back-office","homepage":"","size":2137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"d3ledger:develop","ref":"develop","sha":"7e475dfb1b3c2e16d95874446bfa0818c154d8a4","user":{"login":"d3ledger","id":31348469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ4NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/31348469?v=4","gravatar_id":"","url":"https://api.github.com/users/d3ledger","html_url":"https://github.com/d3ledger","followers_url":"https://api.github.com/users/d3ledger/followers","following_url":"https://api.github.com/users/d3ledger/following{/other_user}","gists_url":"https://api.github.com/users/d3ledger/gists{/gist_id}","starred_url":"https://api.github.com/users/d3ledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3ledger/subscriptions","organizations_url":"https://api.github.com/users/d3ledger/orgs","repos_url":"https://api.github.com/users/d3ledger/repos","events_url":"https://api.github.com/users/d3ledger/events{/privacy}","received_events_url":"https://api.github.com/users/d3ledger/received_events","type":"Organization","site_admin":false},"repo":{"id":129922092,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk5MjIwOTI=","name":"back-office","full_name":"d3ledger/back-office","owner":{"login":"d3ledger","id":31348469,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxMzQ4NDY5","avatar_url":"https://avatars1.githubusercontent.com/u/31348469?v=4","gravatar_id":"","url":"https://api.github.com/users/d3ledger","html_url":"https://github.com/d3ledger","followers_url":"https://api.github.com/users/d3ledger/followers","following_url":"https://api.github.com/users/d3ledger/following{/other_user}","gists_url":"https://api.github.com/users/d3ledger/gists{/gist_id}","starred_url":"https://api.github.com/users/d3ledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d3ledger/subscriptions","organizations_url":"https://api.github.com/users/d3ledger/orgs","repos_url":"https://api.github.com/users/d3ledger/repos","events_url":"https://api.github.com/users/d3ledger/events{/privacy}","received_events_url":"https://api.github.com/users/d3ledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/d3ledger/back-office","description":"Web application for an operator of D3 notary","fork":false,"url":"https://api.github.com/repos/d3ledger/back-office","forks_url":"https://api.github.com/repos/d3ledger/back-office/forks","keys_url":"https://api.github.com/repos/d3ledger/back-office/keys{/key_id}","collaborators_url":"https://api.github.com/repos/d3ledger/back-office/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/d3ledger/back-office/teams","hooks_url":"https://api.github.com/repos/d3ledger/back-office/hooks","issue_events_url":"https://api.github.com/repos/d3ledger/back-office/issues/events{/number}","events_url":"https://api.github.com/repos/d3ledger/back-office/events","assignees_url":"https://api.github.com/repos/d3ledger/back-office/assignees{/user}","branches_url":"https://api.github.com/repos/d3ledger/back-office/branches{/branch}","tags_url":"https://api.github.com/repos/d3ledger/back-office/tags","blobs_url":"https://api.github.com/repos/d3ledger/back-office/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/d3ledger/back-office/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/d3ledger/back-office/git/refs{/sha}","trees_url":"https://api.github.com/repos/d3ledger/back-office/git/trees{/sha}","statuses_url":"https://api.github.com/repos/d3ledger/back-office/statuses/{sha}","languages_url":"https://api.github.com/repos/d3ledger/back-office/languages","stargazers_url":"https://api.github.com/repos/d3ledger/back-office/stargazers","contributors_url":"https://api.github.com/repos/d3ledger/back-office/contributors","subscribers_url":"https://api.github.com/repos/d3ledger/back-office/subscribers","subscription_url":"https://api.github.com/repos/d3ledger/back-office/subscription","commits_url":"https://api.github.com/repos/d3ledger/back-office/commits{/sha}","git_commits_url":"https://api.github.com/repos/d3ledger/back-office/git/commits{/sha}","comments_url":"https://api.github.com/repos/d3ledger/back-office/comments{/number}","issue_comment_url":"https://api.github.com/repos/d3ledger/back-office/issues/comments{/number}","contents_url":"https://api.github.com/repos/d3ledger/back-office/contents/{+path}","compare_url":"https://api.github.com/repos/d3ledger/back-office/compare/{base}...{head}","merges_url":"https://api.github.com/repos/d3ledger/back-office/merges","archive_url":"https://api.github.com/repos/d3ledger/back-office/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/d3ledger/back-office/downloads","issues_url":"https://api.github.com/repos/d3ledger/back-office/issues{/number}","pulls_url":"https://api.github.com/repos/d3ledger/back-office/pulls{/number}","milestones_url":"https://api.github.com/repos/d3ledger/back-office/milestones{/number}","notifications_url":"https://api.github.com/repos/d3ledger/back-office/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/d3ledger/back-office/labels{/name}","releases_url":"https://api.github.com/repos/d3ledger/back-office/releases{/id}","deployments_url":"https://api.github.com/repos/d3ledger/back-office/deployments","created_at":"2018-04-17T15:02:39Z","updated_at":"2018-06-15T07:55:06Z","pushed_at":"2018-08-24T14:59:23Z","git_url":"git://github.com/d3ledger/back-office.git","ssh_url":"[email protected]:d3ledger/back-office.git","clone_url":"https://github.com/d3ledger/back-office.git","svn_url":"https://github.com/d3ledger/back-office","homepage":"","size":2137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/d3ledger/back-office/pulls/37"},"html":{"href":"https://github.com/d3ledger/back-office/pull/37"},"issue":{"href":"https://api.github.com/repos/d3ledger/back-office/issues/37"},"comments":{"href":"https://api.github.com/repos/d3ledger/back-office/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/d3ledger/back-office/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/d3ledger/back-office/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/d3ledger/back-office/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/d3ledger/back-office/statuses/0ab3aae4d90720473eb887fea1fb8075439394ea"}},"author_association":"COLLABORATOR"}}

8163587770

{"actor":{"display_login":"Pobepto"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/comments/221826928","pull_request_review_id":160568573,"id":221826928,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTgyNjkyOA==","diff_hunk":"@@ -6,6 +6,7 @@ locals {\n cluster_security_group_id = \"${coalesce(join(\"\", aws_security_group.cluster.*.id), var.cluster_security_group_id)}\"\n \n worker_security_group_id = \"${coalesce(join(\"\", aws_security_group.workers.*.id), var.worker_security_group_id)}\"\n+ default_iam_role_id = \"${element(concat(aws_iam_role.workers.*.id, list(\"\")), 0)}\"","path":"local.tf","position":4,"original_position":4,"commit_id":"7540677fe4d63a958c50cfe079c2c0a2d9c6049d","original_commit_id":"7540677fe4d63a958c50cfe079c2c0a2d9c6049d","user":{"login":"laverya","id":2318911,"node_id":"MDQ6VXNlcjIzMTg5MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/2318911?v=4","gravatar_id":"","url":"https://api.github.com/users/laverya","html_url":"https://github.com/laverya","followers_url":"https://api.github.com/users/laverya/followers","following_url":"https://api.github.com/users/laverya/following{/other_user}","gists_url":"https://api.github.com/users/laverya/gists{/gist_id}","starred_url":"https://api.github.com/users/laverya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laverya/subscriptions","organizations_url":"https://api.github.com/users/laverya/orgs","repos_url":"https://api.github.com/users/laverya/repos","events_url":"https://api.github.com/users/laverya/events{/privacy}","received_events_url":"https://api.github.com/users/laverya/received_events","type":"User","site_admin":false},"body":"Oh, it's for destroy operations 🤦‍♂️ \r\nI don't recall ever hitting that race condition during a teardown, but then I've only torn this version down a handful of times. Still surprised the splat operator works, but this makes a lot more sense to me now!","created_at":"2018-10-02T05:13:24Z","updated_at":"2018-10-02T05:13:24Z","html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/147#discussion_r221826928","pull_request_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/147","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/comments/221826928"},"html":{"href":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/147#discussion_r221826928"},"pull_request":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/147"}},"in_reply_to_id":221728517},"pull_request":{"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/147","id":219444996,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDQ0OTk2","html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/147","diff_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/147.diff","patch_url":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/147.patch","issue_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/147","number":147,"state":"open","locked":false,"title":"Fixed issue with 'workers_group_defaults_defaults.iam_role_id' and added explicit depends_on for 'update_config_map_aws_auth'","user":{"login":"mmcaya","id":493911,"node_id":"MDQ6VXNlcjQ5MzkxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/493911?v=4","gravatar_id":"","url":"https://api.github.com/users/mmcaya","html_url":"https://github.com/mmcaya","followers_url":"https://api.github.com/users/mmcaya/followers","following_url":"https://api.github.com/users/mmcaya/following{/other_user}","gists_url":"https://api.github.com/users/mmcaya/gists{/gist_id}","starred_url":"https://api.github.com/users/mmcaya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmcaya/subscriptions","organizations_url":"https://api.github.com/users/mmcaya/orgs","repos_url":"https://api.github.com/users/mmcaya/repos","events_url":"https://api.github.com/users/mmcaya/events{/privacy}","received_events_url":"https://api.github.com/users/mmcaya/received_events","type":"User","site_admin":false},"body":"\r\nFixed issue with workers_group_defaults_defaults.iam_role_id and added explicit depends_on for 'update_config_map_aws_auth'\r\n\r\n# PR o'clock\r\n\r\n## Description\r\n\r\nMinimal fixes for this issue:\r\nhttps://github.com/terraform-aws-modules/terraform-aws-eks/issues/146\r\n\r\nThis PR only attempts to fix the minimal requirements of the issue.\r\n- `update_config_map_aws_auth` null resource now depends on `aws_eks_cluster.this` \r\n- `iam_role_id` uses the element/concat work around for its default value\r\n\r\nAdditional comments in line.\r\n\r\n### Checklist\r\n\r\n- [X] `terraform fmt` and `terraform validate` both work from the root and `examples/eks_test_fixture` directories (look in CI for an example)\r\n- both updated files passed checks\r\n- [ ] Tests for the changes have been added and passing (for bug fixes/features)\r\n- [X] Test results are pasted in this PR (in lieu of CI)\r\n- [ ] Docs have been updated using `terraform-docs` per `README.md` instructions\r\n- [ ] I've added my change to CHANGELOG.md\r\n- [ ] Any breaking changes are highlighted above\r\n\r\nI have internal test kitchen / rspec test scenarios that exercise and tear down complete clusters, with sample output provided in lieu of ability to open source the tests at this time.\r\n\r\n```\r\n#Custom matcher as awspec does not have eks resources at this time\r\neks cluster exists\r\n should eql \"tf-platform-test-kitchen\"\r\n... TRUCATED ...\r\nFinished in 1.78 seconds (files took 2.25 seconds to load)\r\n25 examples, 0 failures\r\n```\r\n\r\n```\r\nScenario 1: \r\n worker_group_count = 0\r\n write_kubeconfig = false\r\n manage_aws_auth = false\r\n\r\nScenario 2:\r\n worker_group_count = 0\r\n write_kubeconfig = true\r\n manage_aws_auth = true\r\n\r\nScenario 3:\r\n worker_group_count = 1\r\n write_kubeconfig = true\r\n manage_aws_auth = true\r\n\r\nScenario 4:\r\n worker_group_count = 2\r\n worker_groups = [\r\n {\r\n \"name\" = \"green\"\r\n \"instance_type\" = \"t2.small\"\r\n \"asg_desired_capacity\" = \"0\"\r\n \"asg_max_size\" = \"0\"\r\n \"asg_min_size\" = \"0\"\r\n },\r\n {\r\n \"name\" = \"blue\"\r\n \"instance_type\" = \"t2.small\"\r\n \"asg_desired_capacity\" = \"0\"\r\n \"asg_max_size\" = \"0\"\r\n \"asg_min_size\" = \"0\"\r\n },\r\n ]\r\n write_kubeconfig = true\r\n manage_aws_auth = true\r\n```","created_at":"2018-10-01T16:54:18Z","updated_at":"2018-10-02T05:13:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"41cf3b1b575cbfb49b2648e1e26e70f9b8acc613","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/147/commits","review_comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/147/comments","review_comment_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/147/comments","statuses_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/statuses/7540677fe4d63a958c50cfe079c2c0a2d9c6049d","head":{"label":"Hobsons:feature/worker-group-iam-role-id-fix","ref":"feature/worker-group-iam-role-id-fix","sha":"7540677fe4d63a958c50cfe079c2c0a2d9c6049d","user":{"login":"Hobsons","id":413675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzY3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/413675?v=4","gravatar_id":"","url":"https://api.github.com/users/Hobsons","html_url":"https://github.com/Hobsons","followers_url":"https://api.github.com/users/Hobsons/followers","following_url":"https://api.github.com/users/Hobsons/following{/other_user}","gists_url":"https://api.github.com/users/Hobsons/gists{/gist_id}","starred_url":"https://api.github.com/users/Hobsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hobsons/subscriptions","organizations_url":"https://api.github.com/users/Hobsons/orgs","repos_url":"https://api.github.com/users/Hobsons/repos","events_url":"https://api.github.com/users/Hobsons/events{/privacy}","received_events_url":"https://api.github.com/users/Hobsons/received_events","type":"Organization","site_admin":false},"repo":{"id":150451156,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0NTExNTY=","name":"terraform-aws-eks","full_name":"Hobsons/terraform-aws-eks","private":false,"owner":{"login":"Hobsons","id":413675,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzY3NQ==","avatar_url":"https://avatars3.githubusercontent.com/u/413675?v=4","gravatar_id":"","url":"https://api.github.com/users/Hobsons","html_url":"https://github.com/Hobsons","followers_url":"https://api.github.com/users/Hobsons/followers","following_url":"https://api.github.com/users/Hobsons/following{/other_user}","gists_url":"https://api.github.com/users/Hobsons/gists{/gist_id}","starred_url":"https://api.github.com/users/Hobsons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hobsons/subscriptions","organizations_url":"https://api.github.com/users/Hobsons/orgs","repos_url":"https://api.github.com/users/Hobsons/repos","events_url":"https://api.github.com/users/Hobsons/events{/privacy}","received_events_url":"https://api.github.com/users/Hobsons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Hobsons/terraform-aws-eks","description":"A Terraform module to create an Elastic Kubernetes (EKS) cluster and associated worker instances on AWS.","fork":true,"url":"https://api.github.com/repos/Hobsons/terraform-aws-eks","forks_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/forks","keys_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/teams","hooks_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/hooks","issue_events_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/issues/events{/number}","events_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/events","assignees_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/assignees{/user}","branches_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/branches{/branch}","tags_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/tags","blobs_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/git/refs{/sha}","trees_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/statuses/{sha}","languages_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/languages","stargazers_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/stargazers","contributors_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/contributors","subscribers_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/subscribers","subscription_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/subscription","commits_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/commits{/sha}","git_commits_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/git/commits{/sha}","comments_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/comments{/number}","issue_comment_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/issues/comments{/number}","contents_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/contents/{+path}","compare_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/merges","archive_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/downloads","issues_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/issues{/number}","pulls_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/pulls{/number}","milestones_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/milestones{/number}","notifications_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/labels{/name}","releases_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/releases{/id}","deployments_url":"https://api.github.com/repos/Hobsons/terraform-aws-eks/deployments","created_at":"2018-09-26T15:45:54Z","updated_at":"2018-09-26T15:45:56Z","pushed_at":"2018-10-01T17:03:02Z","git_url":"git://github.com/Hobsons/terraform-aws-eks.git","ssh_url":"[email protected]:Hobsons/terraform-aws-eks.git","clone_url":"https://github.com/Hobsons/terraform-aws-eks.git","svn_url":"https://github.com/Hobsons/terraform-aws-eks","homepage":"https://registry.terraform.io/modules/terraform-aws-modules/eks/aws","size":206,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-aws-modules:master","ref":"master","sha":"3b546a9c1bc9fab24b3bd0ca5ec30b5defed5e50","user":{"login":"terraform-aws-modules","id":31414033,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDE0MDMz","avatar_url":"https://avatars1.githubusercontent.com/u/31414033?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-aws-modules","html_url":"https://github.com/terraform-aws-modules","followers_url":"https://api.github.com/users/terraform-aws-modules/followers","following_url":"https://api.github.com/users/terraform-aws-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-aws-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-aws-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-aws-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-aws-modules/orgs","repos_url":"https://api.github.com/users/terraform-aws-modules/repos","events_url":"https://api.github.com/users/terraform-aws-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-aws-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":136401408,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY0MDE0MDg=","name":"terraform-aws-eks","full_name":"terraform-aws-modules/terraform-aws-eks","private":false,"owner":{"login":"terraform-aws-modules","id":31414033,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNDE0MDMz","avatar_url":"https://avatars1.githubusercontent.com/u/31414033?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-aws-modules","html_url":"https://github.com/terraform-aws-modules","followers_url":"https://api.github.com/users/terraform-aws-modules/followers","following_url":"https://api.github.com/users/terraform-aws-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-aws-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-aws-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-aws-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-aws-modules/orgs","repos_url":"https://api.github.com/users/terraform-aws-modules/repos","events_url":"https://api.github.com/users/terraform-aws-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-aws-modules/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/terraform-aws-modules/terraform-aws-eks","description":"A Terraform module to create an Elastic Kubernetes (EKS) cluster and associated worker instances on AWS.","fork":false,"url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks","forks_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/forks","keys_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/teams","hooks_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/hooks","issue_events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/events","assignees_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/tags","blobs_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/languages","stargazers_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/stargazers","contributors_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/contributors","subscribers_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/subscribers","subscription_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/subscription","commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/merges","archive_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/downloads","issues_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/labels{/name}","releases_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/deployments","created_at":"2018-06-07T00:43:18Z","updated_at":"2018-10-01T10:23:15Z","pushed_at":"2018-10-01T17:03:03Z","git_url":"git://github.com/terraform-aws-modules/terraform-aws-eks.git","ssh_url":"[email protected]:terraform-aws-modules/terraform-aws-eks.git","clone_url":"https://github.com/terraform-aws-modules/terraform-aws-eks.git","svn_url":"https://github.com/terraform-aws-modules/terraform-aws-eks","homepage":"https://registry.terraform.io/modules/terraform-aws-modules/eks/aws","size":207,"stargazers_count":133,"watchers_count":133,"language":"HCL","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":79,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":79,"open_issues":17,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/147"},"html":{"href":"https://github.com/terraform-aws-modules/terraform-aws-eks/pull/147"},"issue":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/147"},"comments":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-aws-modules/terraform-aws-eks/statuses/7540677fe4d63a958c50cfe079c2c0a2d9c6049d"}},"author_association":"NONE"}}

8352227442

{"actor":{"display_login":"laverya"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/go-spatial/tegola/pulls/comments/176887399","pull_request_review_id":106672734,"id":176887399,"diff_hunk":"@@ -279,35 +167,234 @@ var cacheCmd = &cobra.Command{\n \n type MapTile struct {\n \tMapName string\n-\tTile *tegola.Tile\n+\tTile *slippy.Tile\n }\n \n-//parseTileString converts a Z/X/Y formatted string into a tegola tile\n-func parseTileString(str string) (*tegola.Tile, error) {\n-\tvar tile *tegola.Tile\n+// parseTileString converts a Z/X/Y formatted string into a tegola tile\n+// format string \"{delim}{order}\" (ex. \"/zxy\", \" zxy\", \",zxy\"\n+func parseTileString(format, str string) (*slippy.Tile, error) {\n+\tvar tile *slippy.Tile\n+\n+\tix := 1\n+\tiy := strings.Index(format, \"y\") - 1\n+\tiz := strings.Index(format, \"z\") - 1\n \n-\tparts := strings.Split(str, \"/\")\n+\tparts := strings.Split(str, format[:1])\n+\t//parts := strings.Split(str, \"/\")\n \tif len(parts) != 3 {\n \t\treturn tile, fmt.Errorf(\"invalid zxy value (%v). expecting the format z/x/y\", str)\n \t}\n \n-\tz, err := strconv.ParseUint(parts[0], 10, 64)\n+\tz, err := strconv.ParseUint(parts[iz], 10, 64)\n \tif err != nil || z > tegola.MaxZ {\n \t\treturn tile, fmt.Errorf(\"invalid Z value (%v)\", z)\n \t}\n \n \tmaxXYatZ := maths.Exp2(z) - 1\n \n-\tx, err := strconv.ParseUint(parts[1], 10, 64)\n+\tx, err := strconv.ParseUint(parts[ix], 10, 64)\n \tif err != nil || x > maxXYatZ {\n \t\treturn tile, fmt.Errorf(\"invalid X value (%v)\", x)\n \t}\n \n-\ty, err := strconv.ParseUint(parts[2], 10, 64)\n+\ty, err := strconv.ParseUint(parts[iy], 10, 64)\n \tif err != nil || y > maxXYatZ {\n \t\treturn tile, fmt.Errorf(\"invalid Y value (%v)\", y)\n \t}\n-\ttile = tegola.NewTile(uint(z), uint(x), uint(y))\n+\n+\ttile = slippy.NewTile(uint(z), uint(x), uint(y), 0, tegola.WebMercator)\n \n \treturn tile, nil\n }\n+\n+func seedWorker(ctx context.Context, mt MapTile) {\n+\t//\ttrack how long the tile generation is taking\n+\tt := time.Now()\n+\n+\t//\tlookup the Map\n+\tm, err := atlas.GetMap(mt.MapName)\n+\tif err != nil {\n+\t\tlog.Fatalf(\"error seeding tile (%+v): %v\", mt.Tile, err)\n+\t}\n+\n+\tz, x, y := mt.Tile.ZXY()\n+\n+\t//\tfilter down the layers we need for this zoom\n+\tm = m.FilterLayersByZoom(x)\n+\n+\t//\tcheck if overwriting the cache is not ok\n+\tif !cacheOverwrite {\n+\t\t//\tlookup our cache\n+\t\tc := atlas.GetCache()\n+\t\tif c == nil {\n+\t\t\tlog.Fatalf(\"error fetching cache: %v\", err)\n+\t\t}\n+\n+\t\t//\tcache key\n+\t\tkey := cache.Key{\n+\t\t\tMapName: mt.MapName,\n+\t\t\tZ: z,\n+\t\t\tX: x,\n+\t\t\tY: y,\n+\t\t}\n+\n+\t\t//\tread the tile from the cache\n+\t\t_, hit, err := c.Get(&key)\n+\t\tif err != nil {\n+\t\t\tlog.Fatal(\"error reading from cache: %v\", err)\n+\t\t}\n+\t\t//\tif we have a cache hit, then skip processing this tile\n+\t\tif hit {\n+\t\t\tlog.Infof(\"cache seed set to not overwrite existing tiles. skipping map (%v) tile (%v/%v/%v)\", mt.MapName, z, x, y)\n+\t\t\treturn\n+\t\t}\n+\t}\n+\n+\t//\tset tile buffer if it was configured by the user\n+\tif conf.TileBuffer > 0 {\n+\t\tmt.Tile.Buffer = float64(conf.TileBuffer)\n+\t}\n+\n+\t//\tseed the tile\n+\tif err = atlas.SeedMapTile(ctx, m, z, x, y); err != nil {\n+\t\tlog.Errorf(\"error seeding tile (%+v): %v\", mt.Tile, err)\n+\t\treturn\n+\t}\n+\n+\t//\tTODO: this is a hack to get around large arrays not being garbage collected\n+\t//\thttps://github.com/golang/go/issues/14045 - should be addressed in Go 1.11\n+\truntime.GC()\n+\n+\tlog.Infof(\"seeding map (%v) tile (%v/%v/%v) took: %v\", mt.MapName, z, x, y, time.Now().Sub(t))\n+}\n+\n+func purgeWorker(mt MapTile) {\n+\n+\tz, x, y := mt.Tile.ZXY()\n+\n+\tlog.Infof(\"purging map (%v) tile (%v/%v/%v)\", mt.MapName, z, x, y)\n+\n+\t//\tlookup the Map\n+\tm, err := atlas.GetMap(mt.MapName)\n+\tif err != nil {\n+\t\tlog.Fatalf(\"error seeding tile (%+v): %v\", mt.Tile, err)\n+\t}\n+\n+\t//\tpurge the tile\n+\tttile := tegola.NewTile(mt.Tile.ZXY())\n+\tif err = atlas.PurgeMapTile(m, ttile); err != nil {\n+\t\tlog.Errorf(\"error purging tile (%+v): %v\", mt.Tile, err)\n+\t}\n+}\n+\n+func sendTiles(zooms []uint, c chan *slippy.Tile) {\n+\tif cacheZXY != \"\" {\n+\t\t// single xyz\n+\t\t//\tconvert the input into a tile\n+\t\ttile, err := parseTileString(cacheFormat, cacheZXY)\n+\t\tif err != nil {\n+\t\t\tlog.Fatal(err)\n+\t\t}\n+\n+\tZoomLoop:\n+\t\tfor _, zoom := range zooms {\n+\t\t\terr := tile.RangeFamilyAt(zoom, func(t *slippy.Tile) error {\n+\t\t\t\tif gdcmd.IsCancelled() {\n+\t\t\t\t\treturn fmt.Errorf(\"stop iteration\")\n+\t\t\t\t}\n+\n+\t\t\t\tc <- t\n+\t\t\t\treturn nil\n+\t\t\t})\n+\n+\t\t\tif err != nil {\n+\t\t\t\tbreak ZoomLoop\n+\t\t\t}\n+\t\t}\n+\n+\t\tclose(c)\n+\t} else if cacheFile != \"\" {\n+\t\t// read xyz from a file\n+\t\tf, err := os.Open(cacheFile)\n+\t\tif err != nil {\n+\t\t\tlog.Fatal(\"could not open file\")\n+\t\t}\n+\n+\t\tscanner := bufio.NewScanner(f)\n+\tScanLoop:\n+\t\tfor scanner.Scan() {\n+\t\t\ttile, err := parseTileString(cacheFormat, scanner.Text())\n+\t\t\tif err != nil {\n+\t\t\t\tlog.Fatal(err)\n+\t\t\t}\n+\n+\t\t\t// range\n+\t\t\tfor _, zoom := range zooms {\n+\t\t\t\terr := tile.RangeFamilyAt(zoom, func(t *slippy.Tile) error {\n+\t\t\t\t\tif gdcmd.IsCancelled() {\n+\t\t\t\t\t\treturn fmt.Errorf(\"stop iteration\")\n+\t\t\t\t\t}\n+\n+\t\t\t\t\tc <- t\n+\t\t\t\t\treturn nil\n+\t\t\t\t})\n+\n+\t\t\t\tif err != nil {\n+\t\t\t\t\tbreak ScanLoop\n+\t\t\t\t}\n+\t\t\t}\n+\t\t}\n+\n+\t\tclose(c)\n+\t} else {\n+\t\t// bounding box caching\n+\t\tboundsParts := strings.Split(cacheBounds, \",\")\n+\t\tif len(boundsParts) != 4 {\n+\t\t\tlog.Fatal(\"invalid value for bounds. expecting minx, miny, maxx, maxy\")","path":"cmd/tegola/cmd/cache.go","position":432,"original_position":432,"commit_id":"15623b0c731e44e289cfa37c6265dc38a718fe3d","original_commit_id":"15623b0c731e44e289cfa37c6265dc38a718fe3d","user":{"login":"ARolek","id":667850,"avatar_url":"https://avatars3.githubusercontent.com/u/667850?v=4","gravatar_id":"","url":"https://api.github.com/users/ARolek","html_url":"https://github.com/ARolek","followers_url":"https://api.github.com/users/ARolek/followers","following_url":"https://api.github.com/users/ARolek/following{/other_user}","gists_url":"https://api.github.com/users/ARolek/gists{/gist_id}","starred_url":"https://api.github.com/users/ARolek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARolek/subscriptions","organizations_url":"https://api.github.com/users/ARolek/orgs","repos_url":"https://api.github.com/users/ARolek/repos","events_url":"https://api.github.com/users/ARolek/events{/privacy}","received_events_url":"https://api.github.com/users/ARolek/received_events","type":"User","site_admin":false},"body":"return error instead of kill the program","created_at":"2018-03-23T23:31:13Z","updated_at":"2018-03-23T23:32:23Z","html_url":"https://github.com/go-spatial/tegola/pull/372#discussion_r176887399","pull_request_url":"https://api.github.com/repos/go-spatial/tegola/pulls/372","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/go-spatial/tegola/pulls/comments/176887399"},"html":{"href":"https://github.com/go-spatial/tegola/pull/372#discussion_r176887399"},"pull_request":{"href":"https://api.github.com/repos/go-spatial/tegola/pulls/372"}}},"pull_request":{"url":"https://api.github.com/repos/go-spatial/tegola/pulls/372","id":177153196,"html_url":"https://github.com/go-spatial/tegola/pull/372","diff_url":"https://github.com/go-spatial/tegola/pull/372.diff","patch_url":"https://github.com/go-spatial/tegola/pull/372.patch","issue_url":"https://api.github.com/repos/go-spatial/tegola/issues/372","number":372,"state":"open","locked":false,"title":"Cache seeding/purging command improvements","user":{"login":"ear7h","id":23175084,"avatar_url":"https://avatars0.githubusercontent.com/u/23175084?v=4","gravatar_id":"","url":"https://api.github.com/users/ear7h","html_url":"https://github.com/ear7h","followers_url":"https://api.github.com/users/ear7h/followers","following_url":"https://api.github.com/users/ear7h/following{/other_user}","gists_url":"https://api.github.com/users/ear7h/gists{/gist_id}","starred_url":"https://api.github.com/users/ear7h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ear7h/subscriptions","organizations_url":"https://api.github.com/users/ear7h/orgs","repos_url":"https://api.github.com/users/ear7h/repos","events_url":"https://api.github.com/users/ear7h/events{/privacy}","received_events_url":"https://api.github.com/users/ear7h/received_events","type":"User","site_admin":false},"body":"*cleaned up version of #371\r\n\r\nThere are several improvements made to the cache purge/seed command\r\n* reading from a file via `--file={filename}` flag\r\n* support for varying formats via `--format={format}` flag. \r\n * The format is a 4 character string where the first character is the delimiter and the last charcaters are xyz in the file's order.\r\n * Ex. to parse `X Y Z` use `--format=\" xyz\"`\r\n* code structure improvements\r\n* using a zoom range for single tile updating\r\n\r\nAlso a new member function on `slippy.Tile`\r\n* `RangeFamilyAt` - in order to access descendants and ancestors of a tile","created_at":"2018-03-23T18:37:06Z","updated_at":"2018-03-23T23:32:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"67e6a183f4b638d2a58c2557063a95515b406efc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-spatial/tegola/pulls/372/commits","review_comments_url":"https://api.github.com/repos/go-spatial/tegola/pulls/372/comments","review_comment_url":"https://api.github.com/repos/go-spatial/tegola/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-spatial/tegola/issues/372/comments","statuses_url":"https://api.github.com/repos/go-spatial/tegola/statuses/15623b0c731e44e289cfa37c6265dc38a718fe3d","head":{"label":"ear7h:issue-214","ref":"issue-214","sha":"15623b0c731e44e289cfa37c6265dc38a718fe3d","user":{"login":"ear7h","id":23175084,"avatar_url":"https://avatars0.githubusercontent.com/u/23175084?v=4","gravatar_id":"","url":"https://api.github.com/users/ear7h","html_url":"https://github.com/ear7h","followers_url":"https://api.github.com/users/ear7h/followers","following_url":"https://api.github.com/users/ear7h/following{/other_user}","gists_url":"https://api.github.com/users/ear7h/gists{/gist_id}","starred_url":"https://api.github.com/users/ear7h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ear7h/subscriptions","organizations_url":"https://api.github.com/users/ear7h/orgs","repos_url":"https://api.github.com/users/ear7h/repos","events_url":"https://api.github.com/users/ear7h/events{/privacy}","received_events_url":"https://api.github.com/users/ear7h/received_events","type":"User","site_admin":false},"repo":{"id":121827458,"name":"tegola","full_name":"ear7h/tegola","owner":{"login":"ear7h","id":23175084,"avatar_url":"https://avatars0.githubusercontent.com/u/23175084?v=4","gravatar_id":"","url":"https://api.github.com/users/ear7h","html_url":"https://github.com/ear7h","followers_url":"https://api.github.com/users/ear7h/followers","following_url":"https://api.github.com/users/ear7h/following{/other_user}","gists_url":"https://api.github.com/users/ear7h/gists{/gist_id}","starred_url":"https://api.github.com/users/ear7h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ear7h/subscriptions","organizations_url":"https://api.github.com/users/ear7h/orgs","repos_url":"https://api.github.com/users/ear7h/repos","events_url":"https://api.github.com/users/ear7h/events{/privacy}","received_events_url":"https://api.github.com/users/ear7h/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ear7h/tegola","description":"Tegola is a Mapbox Vector Tile server written in Go","fork":true,"url":"https://api.github.com/repos/ear7h/tegola","forks_url":"https://api.github.com/repos/ear7h/tegola/forks","keys_url":"https://api.github.com/repos/ear7h/tegola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ear7h/tegola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ear7h/tegola/teams","hooks_url":"https://api.github.com/repos/ear7h/tegola/hooks","issue_events_url":"https://api.github.com/repos/ear7h/tegola/issues/events{/number}","events_url":"https://api.github.com/repos/ear7h/tegola/events","assignees_url":"https://api.github.com/repos/ear7h/tegola/assignees{/user}","branches_url":"https://api.github.com/repos/ear7h/tegola/branches{/branch}","tags_url":"https://api.github.com/repos/ear7h/tegola/tags","blobs_url":"https://api.github.com/repos/ear7h/tegola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ear7h/tegola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ear7h/tegola/git/refs{/sha}","trees_url":"https://api.github.com/repos/ear7h/tegola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ear7h/tegola/statuses/{sha}","languages_url":"https://api.github.com/repos/ear7h/tegola/languages","stargazers_url":"https://api.github.com/repos/ear7h/tegola/stargazers","contributors_url":"https://api.github.com/repos/ear7h/tegola/contributors","subscribers_url":"https://api.github.com/repos/ear7h/tegola/subscribers","subscription_url":"https://api.github.com/repos/ear7h/tegola/subscription","commits_url":"https://api.github.com/repos/ear7h/tegola/commits{/sha}","git_commits_url":"https://api.github.com/repos/ear7h/tegola/git/commits{/sha}","comments_url":"https://api.github.com/repos/ear7h/tegola/comments{/number}","issue_comment_url":"https://api.github.com/repos/ear7h/tegola/issues/comments{/number}","contents_url":"https://api.github.com/repos/ear7h/tegola/contents/{+path}","compare_url":"https://api.github.com/repos/ear7h/tegola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ear7h/tegola/merges","archive_url":"https://api.github.com/repos/ear7h/tegola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ear7h/tegola/downloads","issues_url":"https://api.github.com/repos/ear7h/tegola/issues{/number}","pulls_url":"https://api.github.com/repos/ear7h/tegola/pulls{/number}","milestones_url":"https://api.github.com/repos/ear7h/tegola/milestones{/number}","notifications_url":"https://api.github.com/repos/ear7h/tegola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ear7h/tegola/labels{/name}","releases_url":"https://api.github.com/repos/ear7h/tegola/releases{/id}","deployments_url":"https://api.github.com/repos/ear7h/tegola/deployments","created_at":"2018-02-17T04:32:51Z","updated_at":"2018-03-23T19:04:11Z","pushed_at":"2018-03-23T23:30:13Z","git_url":"git://github.com/ear7h/tegola.git","ssh_url":"[email protected]:ear7h/tegola.git","clone_url":"https://github.com/ear7h/tegola.git","svn_url":"https://github.com/ear7h/tegola","homepage":"http://tegola.io/","size":37018,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-spatial:v0.7.0","ref":"v0.7.0","sha":"4ec01f604a6bfec3a38e02057140e2095ec53900","user":{"login":"go-spatial","id":31428490,"avatar_url":"https://avatars2.githubusercontent.com/u/31428490?v=4","gravatar_id":"","url":"https://api.github.com/users/go-spatial","html_url":"https://github.com/go-spatial","followers_url":"https://api.github.com/users/go-spatial/followers","following_url":"https://api.github.com/users/go-spatial/following{/other_user}","gists_url":"https://api.github.com/users/go-spatial/gists{/gist_id}","starred_url":"https://api.github.com/users/go-spatial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-spatial/subscriptions","organizations_url":"https://api.github.com/users/go-spatial/orgs","repos_url":"https://api.github.com/users/go-spatial/repos","events_url":"https://api.github.com/users/go-spatial/events{/privacy}","received_events_url":"https://api.github.com/users/go-spatial/received_events","type":"Organization","site_admin":false},"repo":{"id":59313726,"name":"tegola","full_name":"go-spatial/tegola","owner":{"login":"go-spatial","id":31428490,"avatar_url":"https://avatars2.githubusercontent.com/u/31428490?v=4","gravatar_id":"","url":"https://api.github.com/users/go-spatial","html_url":"https://github.com/go-spatial","followers_url":"https://api.github.com/users/go-spatial/followers","following_url":"https://api.github.com/users/go-spatial/following{/other_user}","gists_url":"https://api.github.com/users/go-spatial/gists{/gist_id}","starred_url":"https://api.github.com/users/go-spatial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-spatial/subscriptions","organizations_url":"https://api.github.com/users/go-spatial/orgs","repos_url":"https://api.github.com/users/go-spatial/repos","events_url":"https://api.github.com/users/go-spatial/events{/privacy}","received_events_url":"https://api.github.com/users/go-spatial/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/go-spatial/tegola","description":"Tegola is a Mapbox Vector Tile server written in Go","fork":false,"url":"https://api.github.com/repos/go-spatial/tegola","forks_url":"https://api.github.com/repos/go-spatial/tegola/forks","keys_url":"https://api.github.com/repos/go-spatial/tegola/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-spatial/tegola/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-spatial/tegola/teams","hooks_url":"https://api.github.com/repos/go-spatial/tegola/hooks","issue_events_url":"https://api.github.com/repos/go-spatial/tegola/issues/events{/number}","events_url":"https://api.github.com/repos/go-spatial/tegola/events","assignees_url":"https://api.github.com/repos/go-spatial/tegola/assignees{/user}","branches_url":"https://api.github.com/repos/go-spatial/tegola/branches{/branch}","tags_url":"https://api.github.com/repos/go-spatial/tegola/tags","blobs_url":"https://api.github.com/repos/go-spatial/tegola/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-spatial/tegola/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-spatial/tegola/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-spatial/tegola/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-spatial/tegola/statuses/{sha}","languages_url":"https://api.github.com/repos/go-spatial/tegola/languages","stargazers_url":"https://api.github.com/repos/go-spatial/tegola/stargazers","contributors_url":"https://api.github.com/repos/go-spatial/tegola/contributors","subscribers_url":"https://api.github.com/repos/go-spatial/tegola/subscribers","subscription_url":"https://api.github.com/repos/go-spatial/tegola/subscription","commits_url":"https://api.github.com/repos/go-spatial/tegola/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-spatial/tegola/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-spatial/tegola/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-spatial/tegola/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-spatial/tegola/contents/{+path}","compare_url":"https://api.github.com/repos/go-spatial/tegola/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-spatial/tegola/merges","archive_url":"https://api.github.com/repos/go-spatial/tegola/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-spatial/tegola/downloads","issues_url":"https://api.github.com/repos/go-spatial/tegola/issues{/number}","pulls_url":"https://api.github.com/repos/go-spatial/tegola/pulls{/number}","milestones_url":"https://api.github.com/repos/go-spatial/tegola/milestones{/number}","notifications_url":"https://api.github.com/repos/go-spatial/tegola/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-spatial/tegola/labels{/name}","releases_url":"https://api.github.com/repos/go-spatial/tegola/releases{/id}","deployments_url":"https://api.github.com/repos/go-spatial/tegola/deployments","created_at":"2016-05-20T17:34:24Z","updated_at":"2018-03-23T23:25:28Z","pushed_at":"2018-03-23T23:30:14Z","git_url":"git://github.com/go-spatial/tegola.git","ssh_url":"[email protected]:go-spatial/tegola.git","clone_url":"https://github.com/go-spatial/tegola.git","svn_url":"https://github.com/go-spatial/tegola","homepage":"http://tegola.io/","size":37040,"stargazers_count":208,"watchers_count":208,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":47,"open_issues":88,"watchers":208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-spatial/tegola/pulls/372"},"html":{"href":"https://github.com/go-spatial/tegola/pull/372"},"issue":{"href":"https://api.github.com/repos/go-spatial/tegola/issues/372"},"comments":{"href":"https://api.github.com/repos/go-spatial/tegola/issues/372/comments"},"review_comments":{"href":"https://api.github.com/repos/go-spatial/tegola/pulls/372/comments"},"review_comment":{"href":"https://api.github.com/repos/go-spatial/tegola/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-spatial/tegola/pulls/372/commits"},"statuses":{"href":"https://api.github.com/repos/go-spatial/tegola/statuses/15623b0c731e44e289cfa37c6265dc38a718fe3d"}},"author_association":"COLLABORATOR"}}

7428208614

{"actor":{"display_login":"ARolek"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/omisego/ewallet/pulls/comments/201211750","pull_request_review_id":135667087,"id":201211750,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTIxMTc1MA==","diff_hunk":"@@ -665,106 +649,525 @@ defmodule AdminAPI.V1.ProviderAuth.TransactionControllerTest do\n }\n end\n \n- test \"returns user:same_address when `from` and `to` and exchange wallet are the same address\" do\n- exchange_account = Account.get_master_account()\n- wallet = Account.get_primary_wallet(exchange_account)\n-\n- token_1 = insert(:token)\n- token_2 = insert(:token)\n-\n- mint!(token_1)\n- mint!(token_2)\n-\n- _pair = insert(:exchange_pair, from_token: token_1, to_token: token_2, rate: 2)\n+ test \"returns token:token_not_found when token_id does not exist\" do\n+ wallet_1 = insert(:wallet)\n+ wallet_2 = insert(:wallet)\n \n response =\n provider_request(\"/transaction.create\", %{\n \"idempotency_token\" => \"123\",\n- \"from_address\" => wallet.address,\n- \"from_amount\" => 1_000_000,\n- \"from_token_id\" => token_1.id,\n- \"to_address\" => wallet.address,\n- \"to_amount\" => 2_000_000,\n- \"to_token_id\" => token_2.id,\n- \"exchange_account_id\" => exchange_account.id\n+ \"from_address\" => wallet_1.address,\n+ \"to_address\" => wallet_2.address,\n+ \"token_id\" => \"fake\",\n+ \"amount\" => 1_000_000\n })\n \n assert response[\"success\"] == false\n \n assert response[\"data\"] == %{\n- \"code\" => \"transaction:same_address\",\n- \"description\" =>\n- \"Found identical addresses in senders and receivers: #{wallet.address}.\",\n+ \"code\" => \"token:token_not_found\",\n+ \"description\" => \"There is no token matching the provided token_id.\",\n \"messages\" => nil,\n \"object\" => \"error\"\n }\n end\n \n- test \"returns user:from_address_not_found when from_address does not exist\" do\n+ test \"returns :invalid_parameter when amount is invalid\" do\n token = insert(:token)\n+ wallet_1 = insert(:wallet)\n wallet_2 = insert(:wallet)\n \n response =\n provider_request(\"/transaction.create\", %{\n \"idempotency_token\" => \"123\",\n- \"from_address\" => \"fake-0000-0000-0000\",\n+ \"from_address\" => wallet_1.address,\n \"to_address\" => wallet_2.address,\n \"token_id\" => token.id,\n- \"amount\" => 1_000_000\n+ \"amount\" => \"fake\"\n })\n \n assert response[\"success\"] == false\n \n assert response[\"data\"] == %{\n- \"code\" => \"unauthorized\",\n- \"description\" => \"You are not allowed to perform the requested operation\",\n+ \"code\" => \"client:invalid_parameter\",\n+ \"description\" => \"String number is not a valid number: 'fake'.\",\n \"messages\" => nil,\n \"object\" => \"error\"\n }\n end\n \n- test \"returns token:token_not_found when token_id does not exist\" do\n- wallet_1 = insert(:wallet)\n+ test \"returns user:from_address_not_found when from_address does not exist\" do","path":"apps/admin_api/test/admin_api/v1/controllers/provider_auth/transaction_controller_test.exs","position":432,"original_position":432,"commit_id":"d62c68b6a54b5a6b37e2c088b462a44432c13cf1","original_commit_id":"d62c68b6a54b5a6b37e2c088b462a44432c13cf1","user":{"login":"T-Dnzt","id":2647689,"node_id":"MDQ6VXNlcjI2NDc2ODk=","avatar_url":"https://avatars2.githubusercontent.com/u/2647689?v=4","gravatar_id":"","url":"https://api.github.com/users/T-Dnzt","html_url":"https://github.com/T-Dnzt","followers_url":"https://api.github.com/users/T-Dnzt/followers","following_url":"https://api.github.com/users/T-Dnzt/following{/other_user}","gists_url":"https://api.github.com/users/T-Dnzt/gists{/gist_id}","starred_url":"https://api.github.com/users/T-Dnzt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/T-Dnzt/subscriptions","organizations_url":"https://api.github.com/users/T-Dnzt/orgs","repos_url":"https://api.github.com/users/T-Dnzt/repos","events_url":"https://api.github.com/users/T-Dnzt/events{/privacy}","received_events_url":"https://api.github.com/users/T-Dnzt/received_events","type":"User","site_admin":false},"body":"unauthorized?","created_at":"2018-07-10T04:01:22Z","updated_at":"2018-07-10T04:02:47Z","html_url":"https://github.com/omisego/ewallet/pull/317#discussion_r201211750","pull_request_url":"https://api.github.com/repos/omisego/ewallet/pulls/317","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/comments/201211750"},"html":{"href":"https://github.com/omisego/ewallet/pull/317#discussion_r201211750"},"pull_request":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/317"}}},"pull_request":{"url":"https://api.github.com/repos/omisego/ewallet/pulls/317","id":200067959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMDY3OTU5","html_url":"https://github.com/omisego/ewallet/pull/317","diff_url":"https://github.com/omisego/ewallet/pull/317.diff","patch_url":"https://github.com/omisego/ewallet/pull/317.patch","issue_url":"https://api.github.com/repos/omisego/ewallet/issues/317","number":317,"state":"open","locked":false,"title":"Fix error 500 when from_amount and to_amount are equal on /transaction.create","user":{"login":"unnawut","id":921194,"node_id":"MDQ6VXNlcjkyMTE5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/921194?v=4","gravatar_id":"","url":"https://api.github.com/users/unnawut","html_url":"https://github.com/unnawut","followers_url":"https://api.github.com/users/unnawut/followers","following_url":"https://api.github.com/users/unnawut/following{/other_user}","gists_url":"https://api.github.com/users/unnawut/gists{/gist_id}","starred_url":"https://api.github.com/users/unnawut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unnawut/subscriptions","organizations_url":"https://api.github.com/users/unnawut/orgs","repos_url":"https://api.github.com/users/unnawut/repos","events_url":"https://api.github.com/users/unnawut/events{/privacy}","received_events_url":"https://api.github.com/users/unnawut/received_events","type":"User","site_admin":false},"body":"Issue/Task Number: T504\r\n\r\n# Overview\r\n\r\nThis PR fixes the internal server error on `/transaction.create` when `from_amount` and `to_amount` are equal in integer value.\r\n\r\n# Changes\r\n\r\n- Fixed the conditions in `EWallet.AmountFetcher`\r\n- Updated `AdminAuth.TransactionControllerTest` and `ProviderAuth.TransactionControllerTest`\r\n- Removed `TransactionSerializer` defaulting `exchange.rate` to 1\r\n\r\n# Implementation Details\r\n\r\n- There were more changes than expected in the controller tests as I needed to regroup some tests\r\n\r\n- Defaulting `exchange.rate || 1` is removed as it causes some confusion whether the transaction was done as cross-token or single-token.\r\n\r\n- For references, this PR fixes the error found by @jarindr:\r\n\r\n```ex\r\nException:\r\n\r\n ** (FunctionClauseError) no function clause matching in AdminAPI.V1.TransactionController.respond_single/2\r\n \r\n The following arguments were given to AdminAPI.V1.TransactionController.respond_single/2:\r\n \r\n # 1\r\n [ok: 1000000000000000000, ok: 1000000000000000000]\r\n \r\n # 2\r\n %Plug.Conn{...}\r\n \r\n Attempted function clauses (showing 7 out of 7):\r\n \r\n defp respond_single(-%EWalletDB.Transaction{} = transaction-, conn)\r\n defp respond_single(-{:ok, transaction}-, conn)\r\n defp respond_single(-{:error, _transaction, code, description}-, conn)\r\n defp respond_single(-{:error, code, description}-, conn)\r\n defp respond_single(-{:error, %Ecto.Changeset{} = changeset}-, conn)\r\n defp respond_single(-{:error, code}-, conn)\r\n defp respond_single(-nil-, conn)\r\n \r\n (admin_api) lib/admin_api/v1/controllers/transaction_controller.ex:143: AdminAPI.V1.TransactionController.respond_single/2\r\n (admin_api) lib/admin_api/v1/controllers/transaction_controller.ex:1: AdminAPI.V1.TransactionController.action/2\r\n (admin_api) lib/admin_api/v1/controllers/transaction_controller.ex:1: AdminAPI.V1.TransactionController.phoenix_controller_pipeline/2\r\n (admin_api) lib/admin_api/endpoint.ex:1: AdminAPI.Endpoint.instrument/4\r\n (phoenix) lib/phoenix/router.ex:278: Phoenix.Router.__call__/1\r\n (phoenix) lib/phoenix/router/route.ex:163: Phoenix.Router.Route.forward/4\r\n (phoenix) lib/phoenix/router.ex:278: Phoenix.Router.__call__/1\r\n (admin_api) lib/admin_api/endpoint.ex:1: AdminAPI.Endpoint.plug_builder_call/2\r\n (admin_api) lib/plug/debugger.ex:102: AdminAPI.Endpoint.\"call (overridable 3)\"/2\r\n (admin_api) lib/admin_api/endpoint.ex:1: AdminAPI.Endpoint.call/2\r\n (plug) lib/plug/adapters/cowboy/handler.ex:16: Plug.Adapters.Cowboy.Handler.upgrade/4\r\n (cowboy) /Users/jarindr/ewallet/deps/cowboy/src/cowboy_protocol.erl:442: :cowboy_protocol.execute/4\r\n\r\n## Connection details\r\n\r\n### Params\r\n\r\n %{\"exchange_wallet_address\" => \"rspi519893043122\", \"from_address\" => \"rspi519893043122\", \"from_amount\" => \"1000000000000000000\", \"from_token_id\" => \"tok_ETH_01chqpp72rhr39mxjg70m5pn52\", \"idempotency_token\" => \"43a0d817-93c1-4911-9cb1-c0ae88c71d76\", \"to_address\" => \"dain840330673096\", \"to_amount\" => \"1000000000000000000\", \"to_token_id\" => \"tok_BTC_01chq27sx0vyewppmvyh5yqz5t\"}\r\n\r\n### Request info\r\n\r\n * URI: http://localhost:4000/api/admin/transaction.create\r\n * Query string: \r\n * Peer: 127.0.0.1:55589\r\n```\r\n\r\n# Usage\r\n\r\nTry `/api/admin/transaction.create` with the following request data (note the same values of `from_amount` and `to_amount`):\r\n\r\n```json\r\n{\r\n \"idempotency_token\": \"some_unique_value\",\r\n \"exchange_wallet_address\": \"exhg123456789012\",\r\n \"from_address\": \"wllt111111111111\",\r\n \"from_amount\": \"100\",\r\n \"from_token_id\": \"tok_ETH_01234567890123456\",\r\n \"to_address\": \"wllt222222222222\",\r\n \"to_amount\": \"100\",\r\n \"to_token_id\": \"tok_BTC_01234567890123456\"\r\n}\r\n```\r\n\r\n# Impact\r\n\r\nNo DB changes. No API format changes.\r\n","created_at":"2018-07-09T11:18:49Z","updated_at":"2018-07-10T04:02:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a62fc87cb48f1ab3ab10657aa0ebd5b356e3419c","assignee":{"login":"unnawut","id":921194,"node_id":"MDQ6VXNlcjkyMTE5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/921194?v=4","gravatar_id":"","url":"https://api.github.com/users/unnawut","html_url":"https://github.com/unnawut","followers_url":"https://api.github.com/users/unnawut/followers","following_url":"https://api.github.com/users/unnawut/following{/other_user}","gists_url":"https://api.github.com/users/unnawut/gists{/gist_id}","starred_url":"https://api.github.com/users/unnawut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unnawut/subscriptions","organizations_url":"https://api.github.com/users/unnawut/orgs","repos_url":"https://api.github.com/users/unnawut/repos","events_url":"https://api.github.com/users/unnawut/events{/privacy}","received_events_url":"https://api.github.com/users/unnawut/received_events","type":"User","site_admin":false},"assignees":[{"login":"unnawut","id":921194,"node_id":"MDQ6VXNlcjkyMTE5NA==","avatar_url":"https://avatars1.githubusercontent.com/u/921194?v=4","gravatar_id":"","url":"https://api.github.com/users/unnawut","html_url":"https://github.com/unnawut","followers_url":"https://api.github.com/users/unnawut/followers","following_url":"https://api.github.com/users/unnawut/following{/other_user}","gists_url":"https://api.github.com/users/unnawut/gists{/gist_id}","starred_url":"https://api.github.com/users/unnawut/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unnawut/subscriptions","organizations_url":"https://api.github.com/users/unnawut/orgs","repos_url":"https://api.github.com/users/unnawut/repos","events_url":"https://api.github.com/users/unnawut/events{/privacy}","received_events_url":"https://api.github.com/users/unnawut/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":799476942,"node_id":"MDU6TGFiZWw3OTk0NzY5NDI=","url":"https://api.github.com/repos/omisego/ewallet/labels/bug%20:warning:","name":"bug :warning:","color":"ee0701","default":false},{"id":829698714,"node_id":"MDU6TGFiZWw4Mjk2OTg3MTQ=","url":"https://api.github.com/repos/omisego/ewallet/labels/work%20in%20progress%20:construction:","name":"work in progress :construction:","color":"d93f0b","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/omisego/ewallet/pulls/317/commits","review_comments_url":"https://api.github.com/repos/omisego/ewallet/pulls/317/comments","review_comment_url":"https://api.github.com/repos/omisego/ewallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omisego/ewallet/issues/317/comments","statuses_url":"https://api.github.com/repos/omisego/ewallet/statuses/d62c68b6a54b5a6b37e2c088b462a44432c13cf1","head":{"label":"omisego:t504-transaction-calculate-both-amounts","ref":"t504-transaction-calculate-both-amounts","sha":"d62c68b6a54b5a6b37e2c088b462a44432c13cf1","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":116826798,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MjY3OTg=","name":"ewallet","full_name":"omisego/ewallet","owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/omisego/ewallet","description":"eWallet Backend for the OmiseGO SDKs.","fork":false,"url":"https://api.github.com/repos/omisego/ewallet","forks_url":"https://api.github.com/repos/omisego/ewallet/forks","keys_url":"https://api.github.com/repos/omisego/ewallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/ewallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/ewallet/teams","hooks_url":"https://api.github.com/repos/omisego/ewallet/hooks","issue_events_url":"https://api.github.com/repos/omisego/ewallet/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/ewallet/events","assignees_url":"https://api.github.com/repos/omisego/ewallet/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/ewallet/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/ewallet/tags","blobs_url":"https://api.github.com/repos/omisego/ewallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/ewallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/ewallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/ewallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/ewallet/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/ewallet/languages","stargazers_url":"https://api.github.com/repos/omisego/ewallet/stargazers","contributors_url":"https://api.github.com/repos/omisego/ewallet/contributors","subscribers_url":"https://api.github.com/repos/omisego/ewallet/subscribers","subscription_url":"https://api.github.com/repos/omisego/ewallet/subscription","commits_url":"https://api.github.com/repos/omisego/ewallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/ewallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/ewallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/ewallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/ewallet/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/ewallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/ewallet/merges","archive_url":"https://api.github.com/repos/omisego/ewallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/ewallet/downloads","issues_url":"https://api.github.com/repos/omisego/ewallet/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/ewallet/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/ewallet/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/ewallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/ewallet/labels{/name}","releases_url":"https://api.github.com/repos/omisego/ewallet/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/ewallet/deployments","created_at":"2018-01-09T14:31:13Z","updated_at":"2018-07-09T07:33:10Z","pushed_at":"2018-07-10T03:48:52Z","git_url":"git://github.com/omisego/ewallet.git","ssh_url":"[email protected]:omisego/ewallet.git","clone_url":"https://github.com/omisego/ewallet.git","svn_url":"https://github.com/omisego/ewallet","homepage":"https://omisego.network/","size":23806,"stargazers_count":192,"watchers_count":192,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":12,"watchers":192,"default_branch":"master"}},"base":{"label":"omisego:master","ref":"master","sha":"51eb5bf17842bd906ca1d0bae441b3d4fd98122b","user":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"repo":{"id":116826798,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY4MjY3OTg=","name":"ewallet","full_name":"omisego/ewallet","owner":{"login":"omisego","id":31544276,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNTQ0Mjc2","avatar_url":"https://avatars3.githubusercontent.com/u/31544276?v=4","gravatar_id":"","url":"https://api.github.com/users/omisego","html_url":"https://github.com/omisego","followers_url":"https://api.github.com/users/omisego/followers","following_url":"https://api.github.com/users/omisego/following{/other_user}","gists_url":"https://api.github.com/users/omisego/gists{/gist_id}","starred_url":"https://api.github.com/users/omisego/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omisego/subscriptions","organizations_url":"https://api.github.com/users/omisego/orgs","repos_url":"https://api.github.com/users/omisego/repos","events_url":"https://api.github.com/users/omisego/events{/privacy}","received_events_url":"https://api.github.com/users/omisego/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/omisego/ewallet","description":"eWallet Backend for the OmiseGO SDKs.","fork":false,"url":"https://api.github.com/repos/omisego/ewallet","forks_url":"https://api.github.com/repos/omisego/ewallet/forks","keys_url":"https://api.github.com/repos/omisego/ewallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omisego/ewallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omisego/ewallet/teams","hooks_url":"https://api.github.com/repos/omisego/ewallet/hooks","issue_events_url":"https://api.github.com/repos/omisego/ewallet/issues/events{/number}","events_url":"https://api.github.com/repos/omisego/ewallet/events","assignees_url":"https://api.github.com/repos/omisego/ewallet/assignees{/user}","branches_url":"https://api.github.com/repos/omisego/ewallet/branches{/branch}","tags_url":"https://api.github.com/repos/omisego/ewallet/tags","blobs_url":"https://api.github.com/repos/omisego/ewallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omisego/ewallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omisego/ewallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/omisego/ewallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omisego/ewallet/statuses/{sha}","languages_url":"https://api.github.com/repos/omisego/ewallet/languages","stargazers_url":"https://api.github.com/repos/omisego/ewallet/stargazers","contributors_url":"https://api.github.com/repos/omisego/ewallet/contributors","subscribers_url":"https://api.github.com/repos/omisego/ewallet/subscribers","subscription_url":"https://api.github.com/repos/omisego/ewallet/subscription","commits_url":"https://api.github.com/repos/omisego/ewallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/omisego/ewallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/omisego/ewallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/omisego/ewallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/omisego/ewallet/contents/{+path}","compare_url":"https://api.github.com/repos/omisego/ewallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omisego/ewallet/merges","archive_url":"https://api.github.com/repos/omisego/ewallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omisego/ewallet/downloads","issues_url":"https://api.github.com/repos/omisego/ewallet/issues{/number}","pulls_url":"https://api.github.com/repos/omisego/ewallet/pulls{/number}","milestones_url":"https://api.github.com/repos/omisego/ewallet/milestones{/number}","notifications_url":"https://api.github.com/repos/omisego/ewallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omisego/ewallet/labels{/name}","releases_url":"https://api.github.com/repos/omisego/ewallet/releases{/id}","deployments_url":"https://api.github.com/repos/omisego/ewallet/deployments","created_at":"2018-01-09T14:31:13Z","updated_at":"2018-07-09T07:33:10Z","pushed_at":"2018-07-10T03:48:52Z","git_url":"git://github.com/omisego/ewallet.git","ssh_url":"[email protected]:omisego/ewallet.git","clone_url":"https://github.com/omisego/ewallet.git","svn_url":"https://github.com/omisego/ewallet","homepage":"https://omisego.network/","size":23806,"stargazers_count":192,"watchers_count":192,"language":"Elixir","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":22,"open_issues":12,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/317"},"html":{"href":"https://github.com/omisego/ewallet/pull/317"},"issue":{"href":"https://api.github.com/repos/omisego/ewallet/issues/317"},"comments":{"href":"https://api.github.com/repos/omisego/ewallet/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omisego/ewallet/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/omisego/ewallet/statuses/d62c68b6a54b5a6b37e2c088b462a44432c13cf1"}},"author_association":"COLLABORATOR"}}

7941350046

{"actor":{"display_login":"T-Dnzt"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/onnx/onnx/pulls/comments/216099030","pull_request_review_id":153517743,"id":216099030,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA5OTAzMA==","diff_hunk":"@@ -0,0 +1,249 @@\n+#include \"gtest_utils.h\"\n+\n+#include \"onnx/checker.h\"\n+#include \"onnx/onnxifi.h\"\n+#include \"onnx/onnxifi_loader.h\"\n+#include \"onnx/string_utils.h\"\n+\n+#ifndef ONNXIFI_DUMMY_BACKEND\n+#define ONNXIFI_DUMMY_BACKEND false\n+#endif\n+\n+const float ONNXIFI_TESTDATA_EPS = 1e-5;\n+\n+template <typename T>\n+class CompareOnnxifiData {\n+ public:\n+ bool IsEqual(void* P, void* Q) {\n+ T x = *((T*)P), y = *((T*)Q);\n+ return ((x - y) > -ONNXIFI_TESTDATA_EPS) &&\n+ ((x - y) < ONNXIFI_TESTDATA_EPS);\n+ }\n+};\n+class ONNXCppDriverTest\n+ : public testing::TestWithParam<ONNX_NAMESPACE::testing::ProtoTestCase> {\n+ protected:\n+ std::vector<ONNX_NAMESPACE::testing::ProtoTestData> protos_;\n+ ONNX_NAMESPACE::ModelProto model_;\n+ void SetUp() override {\n+ ONNX_NAMESPACE::testing::ProtoTestCase t = GetParam();\n+ protos_ = t.proto_test_data_;\n+ model_ = t.model_;\n+ }\n+ uint64_t GetDescriptorSize(const onnxTensorDescriptorV1* t) {\n+ uint64_t d_size = 1;\n+ for (int i = 0; i < t->dimensions; i++) {\n+ d_size *= t->shape[i];\n+ }\n+ return d_size;\n+ }\n+ bool IsDescriptorEqual(\n+ const onnxTensorDescriptorV1& x,\n+ const onnxTensorDescriptorV1& y) {\n+ if (x.dataType != y.dataType || x.dimensions != y.dimensions) {\n+ return false;\n+ }\n+ const int dims = x.dimensions;\n+ for (int i = 0; i < dims; i++) {\n+ if (x.shape[i] != y.shape[i]) {\n+ return false;\n+ }\n+ }\n+ const uint64_t d_size = GetDescriptorSize(&x);\n+ void* p1 = (void*)x.buffer;\n+ void* p2 = (void*)y.buffer;\n+ bool is_equal = true;\n+ for (uint64_t i = 0; i < d_size; i++) {\n+ int offset = 1;\n+ switch (x.dataType) {\n+ case ONNXIFI_DATATYPE_UNDEFINED:\n+ case ONNXIFI_DATATYPE_INT8:\n+ CompareOnnxifiData<char> compare_int8;\n+ is_equal &= compare_int8.IsEqual(p1, p2);\n+ offset = sizeof(char);\n+ break;\n+ case ONNXIFI_DATATYPE_UINT8:\n+ CompareOnnxifiData<unsigned char> compare_uint8;\n+ is_equal &= compare_uint8.IsEqual(p1, p2);\n+ offset = sizeof(unsigned char);\n+ break;\n+ case ONNXIFI_DATATYPE_FLOAT16:\n+ // no support now\n+ break;\n+ case ONNXIFI_DATATYPE_INT16:\n+ CompareOnnxifiData<short> compare_int16;\n+ is_equal &= compare_int16.IsEqual(p1, p2);\n+ offset = sizeof(short);\n+ break;\n+ case ONNXIFI_DATATYPE_UINT16:\n+ CompareOnnxifiData<unsigned short> compare_uint16;\n+ is_equal &= compare_uint16.IsEqual(p1, p2);\n+ offset = sizeof(unsigned short);\n+ break;\n+ case ONNXIFI_DATATYPE_FLOAT32:\n+ CompareOnnxifiData<float> compare_float32;\n+ is_equal &= compare_float32.IsEqual(p1, p2);\n+ offset = sizeof(float);\n+ break;\n+ case ONNXIFI_DATATYPE_INT32:\n+ CompareOnnxifiData<int> compare_int32;\n+ is_equal &= compare_int32.IsEqual(p1, p2);\n+ offset = sizeof(int);\n+ break;\n+ case ONNXIFI_DATATYPE_UINT32:\n+ CompareOnnxifiData<unsigned int> compare_uint32;\n+ is_equal &= compare_uint32.IsEqual(p1, p2);\n+ offset = sizeof(unsigned int);\n+ break;\n+ case ONNXIFI_DATATYPE_FLOAT64:\n+ CompareOnnxifiData<long double> compare_float64;\n+ is_equal &= compare_float64.IsEqual(p1, p2);\n+ offset = sizeof(long double);\n+ break;\n+ case ONNXIFI_DATATYPE_INT64:\n+ CompareOnnxifiData<long long> compare_int64;\n+ is_equal &= compare_int64.IsEqual(p1, p2);\n+ offset = sizeof(long long);\n+ break;\n+ case ONNXIFI_DATATYPE_UINT64:\n+ CompareOnnxifiData<unsigned long long> compare_uint64;\n+ is_equal &= compare_uint64.IsEqual(p1, p2);\n+ offset = sizeof(unsigned long long);\n+ break;\n+ case ONNXIFI_DATATYPE_COMPLEX64:\n+ case ONNXIFI_DATATYPE_COMPLEX128:\n+ // no support now\n+ break;\n+ }\n+ p1 = (char*)p1 + offset;\n+ p2 = (char*)p2 + offset;\n+ if (!is_equal) {\n+ return false;\n+ }\n+ }\n+ return true;\n+ }\n+ void RunAndVerify(onnxifi_library& lib, onnxBackend& backend) {\n+ // Check Model\n+ ONNX_NAMESPACE::checker::check_model(model_);\n+ // Check Input&Output Tensors\n+ ONNX_NAMESPACE::checker::CheckerContext ctx;\n+ for (auto proto_test_data : protos_) {\n+ for (auto input : proto_test_data.inputs_) {\n+ ONNX_NAMESPACE::checker::check_tensor(input, ctx);\n+ }\n+ for (auto output : proto_test_data.outputs_) {\n+ ONNX_NAMESPACE::checker::check_tensor(output, ctx);\n+ }\n+ }\n+ /* TO DO:\n+ * This chunk of code is to test the correctness of onnxifi backend.\n+ * Since we are not using a real backend, we should wait and not\n+ * enable these tests. */\n+#if !ONNXIFI_DUMMY_BACKEND\n+ onnxGraph graph;\n+ uint32_t weightCount = model_.graph().initializer_size();\n+ onnxTensorDescriptorV1 weightDescriptors =\n+ ONNX_NAMESPACE::testing::ProtoToOnnxTensorDescriptor(\n+ model_.graph().initializer(0));\n+\n+ EXPECT_EQ(\n+ lib.onnxInitGraph(\n+ backend,\n+ NULL,\n+ sizeof(model_),\n+ &model_,\n+ weightCount,\n+ &weightDescriptors,\n+ &graph),\n+ ONNXIFI_STATUS_SUCCESS);\n+\n+ for (const auto& proto_test_data : protos_) {\n+ std::vector<onnxTensorDescriptorV1> input_descriptor, output_descriptor,\n+ result_descriptor;\n+ for (const auto& input : proto_test_data.inputs_) {\n+ input_descriptor.push_back(\n+ ONNX_NAMESPACE::testing::ProtoToOnnxTensorDescriptor(input));\n+ }\n+ int output_count = 0;\n+ for (auto& output : proto_test_data.outputs_) {\n+ output_count++;\n+ output_descriptor.push_back(\n+ ONNX_NAMESPACE::testing::ProtoToOnnxTensorDescriptor(output));\n+ onnxTensorDescriptorV1 result;\n+ result.tag = ONNXIFI_TAG_TENSOR_DESCRIPTOR_V1;\n+ std::string name_string =\n+ \"output_\" + ONNX_NAMESPACE::to_string(output_count);\n+ result.name = name_string.c_str();\n+ result.dataType = output.data_type();\n+ result.memoryType = ONNXIFI_MEMORY_TYPE_CPU;\n+ std::vector<uint64_t> shape_values(\n+ output.dims().begin(), output.dims().end());\n+ result.dimensions = shape_values.size();\n+ result.shape = shape_values.data();\n+ std::vector<uint8_t> raw_data(output.raw_data().size(), 0);\n+ result.buffer = (onnxPointer)raw_data.data();\n+ result_descriptor.emplace_back(std::move(result));\n+ }\n+ EXPECT_EQ(\n+ lib.onnxSetGraphIO(\n+ graph,\n+ input_descriptor.size(),\n+ input_descriptor.data(),\n+ result_descriptor.size(),\n+ result_descriptor.data()),\n+ ONNXIFI_STATUS_SUCCESS);\n+\n+ onnxMemoryFenceV1 inputFence, outputFence;\n+ inputFence.tag = ONNXIFI_TAG_MEMORY_FENCE_V1;\n+ outputFence.tag = ONNXIFI_TAG_MEMORY_FENCE_V1;\n+ inputFence.type = ONNXIFI_SYNCHRONIZATION_EVENT;\n+ outputFence.type = ONNXIFI_SYNCHRONIZATION_EVENT;\n+\n+ EXPECT_EQ(\n+ lib.onnxRunGraph(graph, &inputFence, &outputFence),\n+ ONNXIFI_STATUS_SUCCESS);\n+ EXPECT_EQ(lib.onnxWaitEvent(outputFence.event), ONNXIFI_STATUS_SUCCESS);\n+ for (int i = 0; i < output_descriptor.size(); i++) {\n+ auto output_size = GetDescriptorSize(&output_descriptor[i]);\n+ for (int j = 0; j < output_size; j++) {\n+ EXPECT_EQ(\n+ IsDescriptorEqual(output_descriptor[i], result_descriptor[i]),\n+ true);\n+ ;\n+ }\n+ }\n+ }\n+ EXPECT_EQ(lib.onnxReleaseGraph(graph), ONNXIFI_STATUS_SUCCESS);\n+#endif\n+ }\n+};\n+\n+/**\n+ *\tWhen testing backend, we do not specify target backend here,\n+ *\tbut always use the by-default backend of onnxifi_loader.\n+ *\tCheck onnxifi_loader.h for more detail of how to indicate specific\n+ *backend.","path":"onnx/backend/test/cpp/driver_test.cc","position":226,"original_position":226,"commit_id":"4e96d1d5a3d220f66a542e5dd2ee453586c69f0f","original_commit_id":"4e96d1d5a3d220f66a542e5dd2ee453586c69f0f","user":{"login":"houseroad","id":30275821,"node_id":"MDQ6VXNlcjMwMjc1ODIx","avatar_url":"https://avatars0.githubusercontent.com/u/30275821?v=4","gravatar_id":"","url":"https://api.github.com/users/houseroad","html_url":"https://github.com/houseroad","followers_url":"https://api.github.com/users/houseroad/followers","following_url":"https://api.github.com/users/houseroad/following{/other_user}","gists_url":"https://api.github.com/users/houseroad/gists{/gist_id}","starred_url":"https://api.github.com/users/houseroad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houseroad/subscriptions","organizations_url":"https://api.github.com/users/houseroad/orgs","repos_url":"https://api.github.com/users/houseroad/repos","events_url":"https://api.github.com/users/houseroad/events{/privacy}","received_events_url":"https://api.github.com/users/houseroad/received_events","type":"User","site_admin":false},"body":"Nit: indent","created_at":"2018-09-07T22:09:03Z","updated_at":"2018-09-07T22:09:03Z","html_url":"https://github.com/onnx/onnx/pull/1290#discussion_r216099030","pull_request_url":"https://api.github.com/repos/onnx/onnx/pulls/1290","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/onnx/onnx/pulls/comments/216099030"},"html":{"href":"https://github.com/onnx/onnx/pull/1290#discussion_r216099030"},"pull_request":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1290"}}},"pull_request":{"url":"https://api.github.com/repos/onnx/onnx/pulls/1290","id":208358614,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzU4NjE0","html_url":"https://github.com/onnx/onnx/pull/1290","diff_url":"https://github.com/onnx/onnx/pull/1290.diff","patch_url":"https://github.com/onnx/onnx/pull/1290.patch","issue_url":"https://api.github.com/repos/onnx/onnx/issues/1290","number":1290,"state":"open","locked":false,"title":"ONNXIFI cpp test driver","user":{"login":"zrphercule","id":22670479,"node_id":"MDQ6VXNlcjIyNjcwNDc5","avatar_url":"https://avatars2.githubusercontent.com/u/22670479?v=4","gravatar_id":"","url":"https://api.github.com/users/zrphercule","html_url":"https://github.com/zrphercule","followers_url":"https://api.github.com/users/zrphercule/followers","following_url":"https://api.github.com/users/zrphercule/following{/other_user}","gists_url":"https://api.github.com/users/zrphercule/gists{/gist_id}","starred_url":"https://api.github.com/users/zrphercule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrphercule/subscriptions","organizations_url":"https://api.github.com/users/zrphercule/orgs","repos_url":"https://api.github.com/users/zrphercule/repos","events_url":"https://api.github.com/users/zrphercule/events{/privacy}","received_events_url":"https://api.github.com/users/zrphercule/received_events","type":"User","site_admin":false},"body":"the onnxifi cpp test driver.\r\nusing gtest to test all protobuf data in <model, <input, output>> structured dir.\r\nneed to specify the target dir.\r\n\r\nExample of testing:\r\npip install -e .\r\n./.setuptools-cmake-build/onnxifi_test_driver_gtests onnx/backend/test/data/node \r\n\r\nthe second argument is the target dir.\r\n","created_at":"2018-08-14T17:42:27Z","updated_at":"2018-09-07T22:09:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2109d85973b13407871def2782dd3d3195e58e85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/onnx/onnx/pulls/1290/commits","review_comments_url":"https://api.github.com/repos/onnx/onnx/pulls/1290/comments","review_comment_url":"https://api.github.com/repos/onnx/onnx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/onnx/onnx/issues/1290/comments","statuses_url":"https://api.github.com/repos/onnx/onnx/statuses/4e96d1d5a3d220f66a542e5dd2ee453586c69f0f","head":{"label":"zrphercule:cpp_test_driver","ref":"cpp_test_driver","sha":"4e96d1d5a3d220f66a542e5dd2ee453586c69f0f","user":{"login":"zrphercule","id":22670479,"node_id":"MDQ6VXNlcjIyNjcwNDc5","avatar_url":"https://avatars2.githubusercontent.com/u/22670479?v=4","gravatar_id":"","url":"https://api.github.com/users/zrphercule","html_url":"https://github.com/zrphercule","followers_url":"https://api.github.com/users/zrphercule/followers","following_url":"https://api.github.com/users/zrphercule/following{/other_user}","gists_url":"https://api.github.com/users/zrphercule/gists{/gist_id}","starred_url":"https://api.github.com/users/zrphercule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrphercule/subscriptions","organizations_url":"https://api.github.com/users/zrphercule/orgs","repos_url":"https://api.github.com/users/zrphercule/repos","events_url":"https://api.github.com/users/zrphercule/events{/privacy}","received_events_url":"https://api.github.com/users/zrphercule/received_events","type":"User","site_admin":false},"repo":{"id":136089592,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwODk1OTI=","name":"onnx","full_name":"zrphercule/onnx","owner":{"login":"zrphercule","id":22670479,"node_id":"MDQ6VXNlcjIyNjcwNDc5","avatar_url":"https://avatars2.githubusercontent.com/u/22670479?v=4","gravatar_id":"","url":"https://api.github.com/users/zrphercule","html_url":"https://github.com/zrphercule","followers_url":"https://api.github.com/users/zrphercule/followers","following_url":"https://api.github.com/users/zrphercule/following{/other_user}","gists_url":"https://api.github.com/users/zrphercule/gists{/gist_id}","starred_url":"https://api.github.com/users/zrphercule/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zrphercule/subscriptions","organizations_url":"https://api.github.com/users/zrphercule/orgs","repos_url":"https://api.github.com/users/zrphercule/repos","events_url":"https://api.github.com/users/zrphercule/events{/privacy}","received_events_url":"https://api.github.com/users/zrphercule/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zrphercule/onnx","description":"Open Neural Network Exchange","fork":true,"url":"https://api.github.com/repos/zrphercule/onnx","forks_url":"https://api.github.com/repos/zrphercule/onnx/forks","keys_url":"https://api.github.com/repos/zrphercule/onnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zrphercule/onnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zrphercule/onnx/teams","hooks_url":"https://api.github.com/repos/zrphercule/onnx/hooks","issue_events_url":"https://api.github.com/repos/zrphercule/onnx/issues/events{/number}","events_url":"https://api.github.com/repos/zrphercule/onnx/events","assignees_url":"https://api.github.com/repos/zrphercule/onnx/assignees{/user}","branches_url":"https://api.github.com/repos/zrphercule/onnx/branches{/branch}","tags_url":"https://api.github.com/repos/zrphercule/onnx/tags","blobs_url":"https://api.github.com/repos/zrphercule/onnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zrphercule/onnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zrphercule/onnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/zrphercule/onnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zrphercule/onnx/statuses/{sha}","languages_url":"https://api.github.com/repos/zrphercule/onnx/languages","stargazers_url":"https://api.github.com/repos/zrphercule/onnx/stargazers","contributors_url":"https://api.github.com/repos/zrphercule/onnx/contributors","subscribers_url":"https://api.github.com/repos/zrphercule/onnx/subscribers","subscription_url":"https://api.github.com/repos/zrphercule/onnx/subscription","commits_url":"https://api.github.com/repos/zrphercule/onnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/zrphercule/onnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/zrphercule/onnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/zrphercule/onnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/zrphercule/onnx/contents/{+path}","compare_url":"https://api.github.com/repos/zrphercule/onnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zrphercule/onnx/merges","archive_url":"https://api.github.com/repos/zrphercule/onnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zrphercule/onnx/downloads","issues_url":"https://api.github.com/repos/zrphercule/onnx/issues{/number}","pulls_url":"https://api.github.com/repos/zrphercule/onnx/pulls{/number}","milestones_url":"https://api.github.com/repos/zrphercule/onnx/milestones{/number}","notifications_url":"https://api.github.com/repos/zrphercule/onnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zrphercule/onnx/labels{/name}","releases_url":"https://api.github.com/repos/zrphercule/onnx/releases{/id}","deployments_url":"https://api.github.com/repos/zrphercule/onnx/deployments","created_at":"2018-06-04T22:26:37Z","updated_at":"2018-09-07T21:55:59Z","pushed_at":"2018-09-07T22:00:33Z","git_url":"git://github.com/zrphercule/onnx.git","ssh_url":"[email protected]:zrphercule/onnx.git","clone_url":"https://github.com/zrphercule/onnx.git","svn_url":"https://github.com/zrphercule/onnx","homepage":"https://onnx.ai/","size":6915,"stargazers_count":0,"watchers_count":0,"language":"PureBasic","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"onnx:master","ref":"master","sha":"31fd87ffff1f5b0c9886c94ca219982e1a5ee32e","user":{"login":"onnx","id":31675368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjc1MzY4","avatar_url":"https://avatars3.githubusercontent.com/u/31675368?v=4","gravatar_id":"","url":"https://api.github.com/users/onnx","html_url":"https://github.com/onnx","followers_url":"https://api.github.com/users/onnx/followers","following_url":"https://api.github.com/users/onnx/following{/other_user}","gists_url":"https://api.github.com/users/onnx/gists{/gist_id}","starred_url":"https://api.github.com/users/onnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onnx/subscriptions","organizations_url":"https://api.github.com/users/onnx/orgs","repos_url":"https://api.github.com/users/onnx/repos","events_url":"https://api.github.com/users/onnx/events{/privacy}","received_events_url":"https://api.github.com/users/onnx/received_events","type":"Organization","site_admin":false},"repo":{"id":102692863,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI2OTI4NjM=","name":"onnx","full_name":"onnx/onnx","owner":{"login":"onnx","id":31675368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNjc1MzY4","avatar_url":"https://avatars3.githubusercontent.com/u/31675368?v=4","gravatar_id":"","url":"https://api.github.com/users/onnx","html_url":"https://github.com/onnx","followers_url":"https://api.github.com/users/onnx/followers","following_url":"https://api.github.com/users/onnx/following{/other_user}","gists_url":"https://api.github.com/users/onnx/gists{/gist_id}","starred_url":"https://api.github.com/users/onnx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onnx/subscriptions","organizations_url":"https://api.github.com/users/onnx/orgs","repos_url":"https://api.github.com/users/onnx/repos","events_url":"https://api.github.com/users/onnx/events{/privacy}","received_events_url":"https://api.github.com/users/onnx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/onnx/onnx","description":"Open Neural Network Exchange","fork":false,"url":"https://api.github.com/repos/onnx/onnx","forks_url":"https://api.github.com/repos/onnx/onnx/forks","keys_url":"https://api.github.com/repos/onnx/onnx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/onnx/onnx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/onnx/onnx/teams","hooks_url":"https://api.github.com/repos/onnx/onnx/hooks","issue_events_url":"https://api.github.com/repos/onnx/onnx/issues/events{/number}","events_url":"https://api.github.com/repos/onnx/onnx/events","assignees_url":"https://api.github.com/repos/onnx/onnx/assignees{/user}","branches_url":"https://api.github.com/repos/onnx/onnx/branches{/branch}","tags_url":"https://api.github.com/repos/onnx/onnx/tags","blobs_url":"https://api.github.com/repos/onnx/onnx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/onnx/onnx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/onnx/onnx/git/refs{/sha}","trees_url":"https://api.github.com/repos/onnx/onnx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/onnx/onnx/statuses/{sha}","languages_url":"https://api.github.com/repos/onnx/onnx/languages","stargazers_url":"https://api.github.com/repos/onnx/onnx/stargazers","contributors_url":"https://api.github.com/repos/onnx/onnx/contributors","subscribers_url":"https://api.github.com/repos/onnx/onnx/subscribers","subscription_url":"https://api.github.com/repos/onnx/onnx/subscription","commits_url":"https://api.github.com/repos/onnx/onnx/commits{/sha}","git_commits_url":"https://api.github.com/repos/onnx/onnx/git/commits{/sha}","comments_url":"https://api.github.com/repos/onnx/onnx/comments{/number}","issue_comment_url":"https://api.github.com/repos/onnx/onnx/issues/comments{/number}","contents_url":"https://api.github.com/repos/onnx/onnx/contents/{+path}","compare_url":"https://api.github.com/repos/onnx/onnx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/onnx/onnx/merges","archive_url":"https://api.github.com/repos/onnx/onnx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/onnx/onnx/downloads","issues_url":"https://api.github.com/repos/onnx/onnx/issues{/number}","pulls_url":"https://api.github.com/repos/onnx/onnx/pulls{/number}","milestones_url":"https://api.github.com/repos/onnx/onnx/milestones{/number}","notifications_url":"https://api.github.com/repos/onnx/onnx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/onnx/onnx/labels{/name}","releases_url":"https://api.github.com/repos/onnx/onnx/releases{/id}","deployments_url":"https://api.github.com/repos/onnx/onnx/deployments","created_at":"2017-09-07T04:53:45Z","updated_at":"2018-09-07T21:42:08Z","pushed_at":"2018-09-07T22:03:36Z","git_url":"git://github.com/onnx/onnx.git","ssh_url":"[email protected]:onnx/onnx.git","clone_url":"https://github.com/onnx/onnx.git","svn_url":"https://github.com/onnx/onnx","homepage":"https://onnx.ai/","size":6911,"stargazers_count":4177,"watchers_count":4177,"language":"PureBasic","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":579,"mirror_url":null,"archived":false,"open_issues_count":220,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":579,"open_issues":220,"watchers":4177,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1290"},"html":{"href":"https://github.com/onnx/onnx/pull/1290"},"issue":{"href":"https://api.github.com/repos/onnx/onnx/issues/1290"},"comments":{"href":"https://api.github.com/repos/onnx/onnx/issues/1290/comments"},"review_comments":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1290/comments"},"review_comment":{"href":"https://api.github.com/repos/onnx/onnx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/onnx/onnx/pulls/1290/commits"},"statuses":{"href":"https://api.github.com/repos/onnx/onnx/statuses/4e96d1d5a3d220f66a542e5dd2ee453586c69f0f"}},"author_association":"COLLABORATOR"}}

8233058144

{"actor":{"display_login":"houseroad"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/comments/227285980","pull_request_review_id":167283585,"id":227285980,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzI4NTk4MA==","diff_hunk":"@@ -40,10 +121,70 @@ library MetaBlock {\n bytes20 coreIdentifier;\n }\n \n- /** To hash structs according to EIP-712, a type hash is required. */\n- bytes32 constant ORIGINTRANSITION_TYPEHASH = keccak256(\n- \"OriginTransition(uint256 dynasty,bytes32 blockHash,bytes20 coreIdentifier)\"\n- );\n+ /**\n+ * @notice Takes the parameters of an transition object and returns the\n+ * typed hash of it.\n+ *\n+ * @param _coreIdentifier A unique identifier that identifies what chain\n+ * this vote is about.\n+ * @param _kernelHash The hash of the current kernel.\n+ * @param _auxiliaryDynasty The dynasty number where the meta-block closes\n+ * on the auxiliary chain.\n+ * @param _auxiliaryBlockHash The block hash where the meta-block closes\n+ * on the auxiliary chain.\n+ * @param _gas The total consumed gas on auxiliary within this meta-block.\n+ * @param _originDynasty Dynasty of origin block within latest meta-block\n+ * reported at auxiliary chain.\n+ * @param _originBlockHash Block hash of origin block within latest\n+ * meta-block reported at auxiliary chain.\n+ * @param _transactionRoot The transaction root of the meta-block. A trie\n+ * created by the auxiliary block store from the\n+ * transaction roots of all blocks.\n+ * @return The hash of this transition object.\n+ */\n+ function hashAuxiliaryTransition(\n+ bytes32 _coreIdentifier,\n+ bytes32 _kernelHash,\n+ uint256 _auxiliaryDynasty,\n+ bytes32 _auxiliaryBlockHash,\n+ uint256 _gas,\n+ uint256 _originDynasty,\n+ bytes32 _originBlockHash,\n+ bytes32 _transactionRoot\n+ )\n+ internal\n+ pure\n+ returns (bytes32)\n+ {\n+ //todo implement this in separate ticket\n+ return keccak256(abi.encode(_gas));\n+ }\n+\n+ /**\n+ * @notice Takes the parameters of a kernel object and returns the\n+ * typed hash of it.\n+ *\n+ * @param _height The height of meta-block.\n+ * @param _parent The hash of this block's parent.\n+ * @param _updatedValidators The array of addresses of the updated validators.\n+ * @param _updatedWeights The array of weights that corresponds to\n+ * the updated validators.\n+ *\n+ * @return The hash of kernel.\n+ */\n+ function hashKernel(\n+ uint256 _height,\n+ bytes32 _parent,\n+ address[] _updatedValidators,\n+ uint256[] _updatedWeights\n+ )\n+ internal\n+ pure\n+ returns (bytes32)\n+ {\n+ //todo implement this in separate ticket","path":"contracts/lib/MetaBlock.sol","position":157,"original_position":157,"commit_id":"4ce7cae4b8d31f13e3131503029657d818be65d1","original_commit_id":"4ce7cae4b8d31f13e3131503029657d818be65d1","user":{"login":"schemar","id":1196244,"node_id":"MDQ6VXNlcjExOTYyNDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1196244?v=4","gravatar_id":"","url":"https://api.github.com/users/schemar","html_url":"https://github.com/schemar","followers_url":"https://api.github.com/users/schemar/followers","following_url":"https://api.github.com/users/schemar/following{/other_user}","gists_url":"https://api.github.com/users/schemar/gists{/gist_id}","starred_url":"https://api.github.com/users/schemar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schemar/subscriptions","organizations_url":"https://api.github.com/users/schemar/orgs","repos_url":"https://api.github.com/users/schemar/repos","events_url":"https://api.github.com/users/schemar/events{/privacy}","received_events_url":"https://api.github.com/users/schemar/received_events","type":"User","site_admin":false},"body":"Please remove the two TODOs and create a ticket instead.","created_at":"2018-10-23T08:44:02Z","updated_at":"2018-10-23T08:50:58Z","html_url":"https://github.com/OpenSTFoundation/mosaic-contracts/pull/402#discussion_r227285980","pull_request_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/402","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/comments/227285980"},"html":{"href":"https://github.com/OpenSTFoundation/mosaic-contracts/pull/402#discussion_r227285980"},"pull_request":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/402"}}},"pull_request":{"url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/402","id":224923804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0OTIzODA0","html_url":"https://github.com/OpenSTFoundation/mosaic-contracts/pull/402","diff_url":"https://github.com/OpenSTFoundation/mosaic-contracts/pull/402.diff","patch_url":"https://github.com/OpenSTFoundation/mosaic-contracts/pull/402.patch","issue_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/issues/402","number":402,"state":"open","locked":false,"title":"Anyone should be able to propose meta block","user":{"login":"sarvesh-ost","id":39081115,"node_id":"MDQ6VXNlcjM5MDgxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/39081115?v=4","gravatar_id":"","url":"https://api.github.com/users/sarvesh-ost","html_url":"https://github.com/sarvesh-ost","followers_url":"https://api.github.com/users/sarvesh-ost/followers","following_url":"https://api.github.com/users/sarvesh-ost/following{/other_user}","gists_url":"https://api.github.com/users/sarvesh-ost/gists{/gist_id}","starred_url":"https://api.github.com/users/sarvesh-ost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarvesh-ost/subscriptions","organizations_url":"https://api.github.com/users/sarvesh-ost/orgs","repos_url":"https://api.github.com/users/sarvesh-ost/repos","events_url":"https://api.github.com/users/sarvesh-ost/events{/privacy}","received_events_url":"https://api.github.com/users/sarvesh-ost/received_events","type":"User","site_admin":false},"body":"Following features are implemented \r\n\r\n1. Propose Meta-block with transition object\r\n2. Report genesis block on origin core deployment. \r\n3. Deploy Stake contract on origin-core deployment. \r\n4. Unit test cases for propose meta-block","created_at":"2018-10-23T07:24:07Z","updated_at":"2018-10-23T08:50:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a420f27bc423edf31207035faaaecdab7817617","assignee":{"login":"sarvesh-ost","id":39081115,"node_id":"MDQ6VXNlcjM5MDgxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/39081115?v=4","gravatar_id":"","url":"https://api.github.com/users/sarvesh-ost","html_url":"https://github.com/sarvesh-ost","followers_url":"https://api.github.com/users/sarvesh-ost/followers","following_url":"https://api.github.com/users/sarvesh-ost/following{/other_user}","gists_url":"https://api.github.com/users/sarvesh-ost/gists{/gist_id}","starred_url":"https://api.github.com/users/sarvesh-ost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarvesh-ost/subscriptions","organizations_url":"https://api.github.com/users/sarvesh-ost/orgs","repos_url":"https://api.github.com/users/sarvesh-ost/repos","events_url":"https://api.github.com/users/sarvesh-ost/events{/privacy}","received_events_url":"https://api.github.com/users/sarvesh-ost/received_events","type":"User","site_admin":false},"assignees":[{"login":"sarvesh-ost","id":39081115,"node_id":"MDQ6VXNlcjM5MDgxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/39081115?v=4","gravatar_id":"","url":"https://api.github.com/users/sarvesh-ost","html_url":"https://github.com/sarvesh-ost","followers_url":"https://api.github.com/users/sarvesh-ost/followers","following_url":"https://api.github.com/users/sarvesh-ost/following{/other_user}","gists_url":"https://api.github.com/users/sarvesh-ost/gists{/gist_id}","starred_url":"https://api.github.com/users/sarvesh-ost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarvesh-ost/subscriptions","organizations_url":"https://api.github.com/users/sarvesh-ost/orgs","repos_url":"https://api.github.com/users/sarvesh-ost/repos","events_url":"https://api.github.com/users/sarvesh-ost/events{/privacy}","received_events_url":"https://api.github.com/users/sarvesh-ost/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"deepesh-kn","id":17645038,"node_id":"MDQ6VXNlcjE3NjQ1MDM4","avatar_url":"https://avatars0.githubusercontent.com/u/17645038?v=4","gravatar_id":"","url":"https://api.github.com/users/deepesh-kn","html_url":"https://github.com/deepesh-kn","followers_url":"https://api.github.com/users/deepesh-kn/followers","following_url":"https://api.github.com/users/deepesh-kn/following{/other_user}","gists_url":"https://api.github.com/users/deepesh-kn/gists{/gist_id}","starred_url":"https://api.github.com/users/deepesh-kn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deepesh-kn/subscriptions","organizations_url":"https://api.github.com/users/deepesh-kn/orgs","repos_url":"https://api.github.com/users/deepesh-kn/repos","events_url":"https://api.github.com/users/deepesh-kn/events{/privacy}","received_events_url":"https://api.github.com/users/deepesh-kn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/402/commits","review_comments_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/402/comments","review_comment_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/issues/402/comments","statuses_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/statuses/4ce7cae4b8d31f13e3131503029657d818be65d1","head":{"label":"sarvesh-ost:gh_372/should_be_able_to_propose_meta_block","ref":"gh_372/should_be_able_to_propose_meta_block","sha":"4ce7cae4b8d31f13e3131503029657d818be65d1","user":{"login":"sarvesh-ost","id":39081115,"node_id":"MDQ6VXNlcjM5MDgxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/39081115?v=4","gravatar_id":"","url":"https://api.github.com/users/sarvesh-ost","html_url":"https://github.com/sarvesh-ost","followers_url":"https://api.github.com/users/sarvesh-ost/followers","following_url":"https://api.github.com/users/sarvesh-ost/following{/other_user}","gists_url":"https://api.github.com/users/sarvesh-ost/gists{/gist_id}","starred_url":"https://api.github.com/users/sarvesh-ost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarvesh-ost/subscriptions","organizations_url":"https://api.github.com/users/sarvesh-ost/orgs","repos_url":"https://api.github.com/users/sarvesh-ost/repos","events_url":"https://api.github.com/users/sarvesh-ost/events{/privacy}","received_events_url":"https://api.github.com/users/sarvesh-ost/received_events","type":"User","site_admin":false},"repo":{"id":145391386,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUzOTEzODY=","name":"mosaic-contracts","full_name":"sarvesh-ost/mosaic-contracts","private":false,"owner":{"login":"sarvesh-ost","id":39081115,"node_id":"MDQ6VXNlcjM5MDgxMTE1","avatar_url":"https://avatars2.githubusercontent.com/u/39081115?v=4","gravatar_id":"","url":"https://api.github.com/users/sarvesh-ost","html_url":"https://github.com/sarvesh-ost","followers_url":"https://api.github.com/users/sarvesh-ost/followers","following_url":"https://api.github.com/users/sarvesh-ost/following{/other_user}","gists_url":"https://api.github.com/users/sarvesh-ost/gists{/gist_id}","starred_url":"https://api.github.com/users/sarvesh-ost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarvesh-ost/subscriptions","organizations_url":"https://api.github.com/users/sarvesh-ost/orgs","repos_url":"https://api.github.com/users/sarvesh-ost/repos","events_url":"https://api.github.com/users/sarvesh-ost/events{/privacy}","received_events_url":"https://api.github.com/users/sarvesh-ost/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sarvesh-ost/mosaic-contracts","description":"OpenST Protocol allows to stake Simple Token on Ethereum to mint branded utility tokens","fork":true,"url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts","forks_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/forks","keys_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/teams","hooks_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/hooks","issue_events_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/events","assignees_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/tags","blobs_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/languages","stargazers_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/stargazers","contributors_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/contributors","subscribers_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/subscribers","subscription_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/subscription","commits_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/merges","archive_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/downloads","issues_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/labels{/name}","releases_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/sarvesh-ost/mosaic-contracts/deployments","created_at":"2018-08-20T08:50:00Z","updated_at":"2018-10-22T10:20:58Z","pushed_at":"2018-10-23T08:22:18Z","git_url":"git://github.com/sarvesh-ost/mosaic-contracts.git","ssh_url":"[email protected]:sarvesh-ost/mosaic-contracts.git","clone_url":"https://github.com/sarvesh-ost/mosaic-contracts.git","svn_url":"https://github.com/sarvesh-ost/mosaic-contracts","homepage":"https://simpletoken.org","size":6366,"stargazers_count":0,"watchers_count":0,"language":"Solidity","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"OpenSTFoundation:develop","ref":"develop","sha":"dc56035d87adfa9b3f7a1aa57a944f71dfe44000","user":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":108171643,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNzE2NDM=","name":"mosaic-contracts","full_name":"OpenSTFoundation/mosaic-contracts","private":false,"owner":{"login":"OpenSTFoundation","id":31754790,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxNzU0Nzkw","avatar_url":"https://avatars2.githubusercontent.com/u/31754790?v=4","gravatar_id":"","url":"https://api.github.com/users/OpenSTFoundation","html_url":"https://github.com/OpenSTFoundation","followers_url":"https://api.github.com/users/OpenSTFoundation/followers","following_url":"https://api.github.com/users/OpenSTFoundation/following{/other_user}","gists_url":"https://api.github.com/users/OpenSTFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/OpenSTFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OpenSTFoundation/subscriptions","organizations_url":"https://api.github.com/users/OpenSTFoundation/orgs","repos_url":"https://api.github.com/users/OpenSTFoundation/repos","events_url":"https://api.github.com/users/OpenSTFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/OpenSTFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OpenSTFoundation/mosaic-contracts","description":"Mosaic is a set of meta-blockchains on top of Ethereum to scale DApps","fork":false,"url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts","forks_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/forks","keys_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/teams","hooks_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/hooks","issue_events_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/events","assignees_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/tags","blobs_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/languages","stargazers_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/stargazers","contributors_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/contributors","subscribers_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/subscribers","subscription_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/subscription","commits_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/merges","archive_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/downloads","issues_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/labels{/name}","releases_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/deployments","created_at":"2017-10-24T19:09:30Z","updated_at":"2018-10-22T14:19:46Z","pushed_at":"2018-10-23T08:25:07Z","git_url":"git://github.com/OpenSTFoundation/mosaic-contracts.git","ssh_url":"[email protected]:OpenSTFoundation/mosaic-contracts.git","clone_url":"https://github.com/OpenSTFoundation/mosaic-contracts.git","svn_url":"https://github.com/OpenSTFoundation/mosaic-contracts","homepage":"https://simpletoken.org","size":6201,"stargazers_count":80,"watchers_count":80,"language":"Solidity","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":52,"watchers":80,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/402"},"html":{"href":"https://github.com/OpenSTFoundation/mosaic-contracts/pull/402"},"issue":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/issues/402"},"comments":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/issues/402/comments"},"review_comments":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/402/comments"},"review_comment":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/pulls/402/commits"},"statuses":{"href":"https://api.github.com/repos/OpenSTFoundation/mosaic-contracts/statuses/4ce7cae4b8d31f13e3131503029657d818be65d1"}},"author_association":"MEMBER"}}

8464120424

{"actor":{"display_login":"schemar"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/comments/174396189","pull_request_review_id":103735591,"id":174396189,"diff_hunk":"@@ -0,0 +1,26 @@\n+<!DOCTYPE html>\n+<html lang=\"en\">","path":"app/views/main.hbs","position":2,"original_position":2,"commit_id":"51e6ebfa353372fa809b1d4e50bb118e9ba2e026","original_commit_id":"51e6ebfa353372fa809b1d4e50bb118e9ba2e026","user":{"login":"noveogroup-amorgunov","id":21186268,"avatar_url":"https://avatars3.githubusercontent.com/u/21186268?v=4","gravatar_id":"","url":"https://api.github.com/users/noveogroup-amorgunov","html_url":"https://github.com/noveogroup-amorgunov","followers_url":"https://api.github.com/users/noveogroup-amorgunov/followers","following_url":"https://api.github.com/users/noveogroup-amorgunov/following{/other_user}","gists_url":"https://api.github.com/users/noveogroup-amorgunov/gists{/gist_id}","starred_url":"https://api.github.com/users/noveogroup-amorgunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noveogroup-amorgunov/subscriptions","organizations_url":"https://api.github.com/users/noveogroup-amorgunov/orgs","repos_url":"https://api.github.com/users/noveogroup-amorgunov/repos","events_url":"https://api.github.com/users/noveogroup-amorgunov/events{/privacy}","received_events_url":"https://api.github.com/users/noveogroup-amorgunov/received_events","type":"User","site_admin":false},"body":"И я писал, что нужно вынести общую часть у main.hbs и news.hbs в общий layout. ","created_at":"2018-03-14T09:27:55Z","updated_at":"2018-03-14T09:31:51Z","html_url":"https://github.com/urfu-2017/webdev-task-1/pull/8#discussion_r174396189","pull_request_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/comments/174396189"},"html":{"href":"https://github.com/urfu-2017/webdev-task-1/pull/8#discussion_r174396189"},"pull_request":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/8"}},"in_reply_to_id":174395768},"pull_request":{"url":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/8","id":172896987,"html_url":"https://github.com/urfu-2017/webdev-task-1/pull/8","diff_url":"https://github.com/urfu-2017/webdev-task-1/pull/8.diff","patch_url":"https://github.com/urfu-2017/webdev-task-1/pull/8.patch","issue_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/issues/8","number":8,"state":"open","locked":false,"title":"Хомич Павел","user":{"login":"paulkhomich","id":14900963,"avatar_url":"https://avatars1.githubusercontent.com/u/14900963?v=4","gravatar_id":"","url":"https://api.github.com/users/paulkhomich","html_url":"https://github.com/paulkhomich","followers_url":"https://api.github.com/users/paulkhomich/followers","following_url":"https://api.github.com/users/paulkhomich/following{/other_user}","gists_url":"https://api.github.com/users/paulkhomich/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkhomich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkhomich/subscriptions","organizations_url":"https://api.github.com/users/paulkhomich/orgs","repos_url":"https://api.github.com/users/paulkhomich/repos","events_url":"https://api.github.com/users/paulkhomich/events{/privacy}","received_events_url":"https://api.github.com/users/paulkhomich/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-05T15:21:26Z","updated_at":"2018-03-14T09:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02319dd7e2afde4b9176c86068d3b6d1bfe87866","assignee":{"login":"noveogroup-amorgunov","id":21186268,"avatar_url":"https://avatars3.githubusercontent.com/u/21186268?v=4","gravatar_id":"","url":"https://api.github.com/users/noveogroup-amorgunov","html_url":"https://github.com/noveogroup-amorgunov","followers_url":"https://api.github.com/users/noveogroup-amorgunov/followers","following_url":"https://api.github.com/users/noveogroup-amorgunov/following{/other_user}","gists_url":"https://api.github.com/users/noveogroup-amorgunov/gists{/gist_id}","starred_url":"https://api.github.com/users/noveogroup-amorgunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noveogroup-amorgunov/subscriptions","organizations_url":"https://api.github.com/users/noveogroup-amorgunov/orgs","repos_url":"https://api.github.com/users/noveogroup-amorgunov/repos","events_url":"https://api.github.com/users/noveogroup-amorgunov/events{/privacy}","received_events_url":"https://api.github.com/users/noveogroup-amorgunov/received_events","type":"User","site_admin":false},"assignees":[{"login":"noveogroup-amorgunov","id":21186268,"avatar_url":"https://avatars3.githubusercontent.com/u/21186268?v=4","gravatar_id":"","url":"https://api.github.com/users/noveogroup-amorgunov","html_url":"https://github.com/noveogroup-amorgunov","followers_url":"https://api.github.com/users/noveogroup-amorgunov/followers","following_url":"https://api.github.com/users/noveogroup-amorgunov/following{/other_user}","gists_url":"https://api.github.com/users/noveogroup-amorgunov/gists{/gist_id}","starred_url":"https://api.github.com/users/noveogroup-amorgunov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noveogroup-amorgunov/subscriptions","organizations_url":"https://api.github.com/users/noveogroup-amorgunov/orgs","repos_url":"https://api.github.com/users/noveogroup-amorgunov/repos","events_url":"https://api.github.com/users/noveogroup-amorgunov/events{/privacy}","received_events_url":"https://api.github.com/users/noveogroup-amorgunov/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/8/commits","review_comments_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/8/comments","review_comment_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/issues/8/comments","statuses_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/statuses/51e6ebfa353372fa809b1d4e50bb118e9ba2e026","head":{"label":"paulkhomich:master","ref":"master","sha":"51e6ebfa353372fa809b1d4e50bb118e9ba2e026","user":{"login":"paulkhomich","id":14900963,"avatar_url":"https://avatars1.githubusercontent.com/u/14900963?v=4","gravatar_id":"","url":"https://api.github.com/users/paulkhomich","html_url":"https://github.com/paulkhomich","followers_url":"https://api.github.com/users/paulkhomich/followers","following_url":"https://api.github.com/users/paulkhomich/following{/other_user}","gists_url":"https://api.github.com/users/paulkhomich/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkhomich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkhomich/subscriptions","organizations_url":"https://api.github.com/users/paulkhomich/orgs","repos_url":"https://api.github.com/users/paulkhomich/repos","events_url":"https://api.github.com/users/paulkhomich/events{/privacy}","received_events_url":"https://api.github.com/users/paulkhomich/received_events","type":"User","site_admin":false},"repo":{"id":123767165,"name":"webdev-task-1","full_name":"paulkhomich/webdev-task-1","owner":{"login":"paulkhomich","id":14900963,"avatar_url":"https://avatars1.githubusercontent.com/u/14900963?v=4","gravatar_id":"","url":"https://api.github.com/users/paulkhomich","html_url":"https://github.com/paulkhomich","followers_url":"https://api.github.com/users/paulkhomich/followers","following_url":"https://api.github.com/users/paulkhomich/following{/other_user}","gists_url":"https://api.github.com/users/paulkhomich/gists{/gist_id}","starred_url":"https://api.github.com/users/paulkhomich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulkhomich/subscriptions","organizations_url":"https://api.github.com/users/paulkhomich/orgs","repos_url":"https://api.github.com/users/paulkhomich/repos","events_url":"https://api.github.com/users/paulkhomich/events{/privacy}","received_events_url":"https://api.github.com/users/paulkhomich/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/paulkhomich/webdev-task-1","description":"Задача «Илон слишком занят»","fork":true,"url":"https://api.github.com/repos/paulkhomich/webdev-task-1","forks_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/forks","keys_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/teams","hooks_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/hooks","issue_events_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/issues/events{/number}","events_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/events","assignees_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/assignees{/user}","branches_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/branches{/branch}","tags_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/tags","blobs_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/statuses/{sha}","languages_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/languages","stargazers_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/stargazers","contributors_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/contributors","subscribers_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/subscribers","subscription_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/subscription","commits_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/contents/{+path}","compare_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/merges","archive_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/downloads","issues_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/issues{/number}","pulls_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/pulls{/number}","milestones_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/milestones{/number}","notifications_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/labels{/name}","releases_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/releases{/id}","deployments_url":"https://api.github.com/repos/paulkhomich/webdev-task-1/deployments","created_at":"2018-03-04T07:35:26Z","updated_at":"2018-03-14T07:18:39Z","pushed_at":"2018-03-14T07:18:38Z","git_url":"git://github.com/paulkhomich/webdev-task-1.git","ssh_url":"[email protected]:paulkhomich/webdev-task-1.git","clone_url":"https://github.com/paulkhomich/webdev-task-1.git","svn_url":"https://github.com/paulkhomich/webdev-task-1","homepage":null,"size":169,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urfu-2017:master","ref":"master","sha":"bf85b0023730ecd410cb060700ad38d578aa1f48","user":{"login":"urfu-2017","id":31925391,"avatar_url":"https://avatars1.githubusercontent.com/u/31925391?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2017","html_url":"https://github.com/urfu-2017","followers_url":"https://api.github.com/users/urfu-2017/followers","following_url":"https://api.github.com/users/urfu-2017/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2017/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2017/subscriptions","organizations_url":"https://api.github.com/users/urfu-2017/orgs","repos_url":"https://api.github.com/users/urfu-2017/repos","events_url":"https://api.github.com/users/urfu-2017/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2017/received_events","type":"Organization","site_admin":false},"repo":{"id":123447876,"name":"webdev-task-1","full_name":"urfu-2017/webdev-task-1","owner":{"login":"urfu-2017","id":31925391,"avatar_url":"https://avatars1.githubusercontent.com/u/31925391?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2017","html_url":"https://github.com/urfu-2017","followers_url":"https://api.github.com/users/urfu-2017/followers","following_url":"https://api.github.com/users/urfu-2017/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2017/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2017/subscriptions","organizations_url":"https://api.github.com/users/urfu-2017/orgs","repos_url":"https://api.github.com/users/urfu-2017/repos","events_url":"https://api.github.com/users/urfu-2017/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2017/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urfu-2017/webdev-task-1","description":"Задача «Илон слишком занят»","fork":false,"url":"https://api.github.com/repos/urfu-2017/webdev-task-1","forks_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/forks","keys_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/teams","hooks_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/hooks","issue_events_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/issues/events{/number}","events_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/events","assignees_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/assignees{/user}","branches_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/branches{/branch}","tags_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/tags","blobs_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/statuses/{sha}","languages_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/languages","stargazers_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/stargazers","contributors_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/contributors","subscribers_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/subscribers","subscription_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/subscription","commits_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/contents/{+path}","compare_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/merges","archive_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/downloads","issues_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/issues{/number}","pulls_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls{/number}","milestones_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/milestones{/number}","notifications_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/labels{/name}","releases_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/releases{/id}","deployments_url":"https://api.github.com/repos/urfu-2017/webdev-task-1/deployments","created_at":"2018-03-01T14:44:31Z","updated_at":"2018-03-12T14:40:50Z","pushed_at":"2018-03-14T08:40:51Z","git_url":"git://github.com/urfu-2017/webdev-task-1.git","ssh_url":"[email protected]:urfu-2017/webdev-task-1.git","clone_url":"https://github.com/urfu-2017/webdev-task-1.git","svn_url":"https://github.com/urfu-2017/webdev-task-1","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":33,"license":null,"forks":49,"open_issues":33,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/8"},"html":{"href":"https://github.com/urfu-2017/webdev-task-1/pull/8"},"issue":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/issues/8"},"comments":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-1/statuses/51e6ebfa353372fa809b1d4e50bb118e9ba2e026"}},"author_association":"NONE"}}

7377111984

{"actor":{"display_login":"noveogroup-amorgunov"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/comments/188833779","pull_request_review_id":120889377,"id":188833779,"diff_hunk":"@@ -0,0 +1,332 @@\n+'use strict';\n+\n+const API_URL = 'https://webdev-task-2-xdmhfckqxs.now.sh/places';\n+\n+let visitedFilterState = 'all';\n+\n+class ElementWrapper {\n+ _find(selector) {\n+ return this.element.querySelector(selector);\n+ }\n+\n+ _forAll(selector, action) {\n+ return this.element.querySelectorAll(selector).forEach(action);\n+ }\n+}\n+\n+class EditableField extends ElementWrapper {\n+ constructor(sourceElement) {\n+ super();\n+ this._sourceElement = sourceElement;\n+ this._createElement();\n+ this._findComponents();\n+ }\n+\n+ get value() {\n+ return this._field.value;\n+ }\n+\n+ set value(value) {\n+ this._field.value = value;\n+ }\n+\n+ get sourceText() {\n+ return this._sourceElement.textContent;\n+ }\n+\n+ set sourceText(value) {\n+ this._sourceElement.textContent = value;\n+ }\n+\n+ edit(onSave) {\n+ this._btnCancel.onclick = () => this._endEdit();\n+ this._btnSave.onclick = async () => {\n+ try {\n+ if (this.value === this.sourceText) {\n+ return;\n+ }\n+ await onSave(this.value);\n+ this.sourceText = this.value;\n+ } finally {\n+ this._endEdit();\n+ }\n+ };\n+ this._beginEdit();\n+ }\n+\n+ _beginEdit() {\n+ this.value = this.sourceText;\n+ this._sourceElement.hidden = true;\n+ this.element.hidden = false;\n+ }\n+\n+ _endEdit() {\n+ this._sourceElement.hidden = false;\n+ this.element.hidden = true;\n+ }\n+\n+ _createElement() {\n+ this.element = document.createElement('div');\n+ this.element.classList.add('edit-field');\n+ this.element.innerHTML = '' +\n+ '<input class=\"edit-field__field\">\\n' +\n+ '<div class=\"edit-field__buttons\">\\n' +\n+ ' <button class=\"edit-field__btn-cancel btn-float\">' +\n+ ' <i class=\"fas fa-times\"></i>\\n' +\n+ ' </button>\\n' +\n+ ' <button class=\"edit-field__btn-save btn-float\">' +\n+ ' <i class=\"fas fa-check\"></i>\\n' +\n+ ' </button>\\n' +\n+ '</div>\\n';\n+ this.element.hidden = true;\n+ this._sourceElement.parentNode.insertBefore(\n+ this.element, this._sourceElement.nextSibling);\n+ }\n+\n+ _findComponents() {\n+ this._field = this._find('.edit-field__field');\n+ this._btnCancel = this._find('.edit-field__btn-cancel');\n+ this._btnSave = this._find('.edit-field__btn-save');\n+ }\n+}\n+\n+\n+class Place extends ElementWrapper {\n+ constructor(id, name, visited) {\n+ super();\n+ this._createElement();\n+ this._findComponents();\n+ this.id = id;\n+ this.name = name;\n+ this.visited = visited;\n+ }\n+\n+ get name() {\n+ return this.nameElement.textContent;\n+ }\n+\n+ set name(value) {\n+ this.nameElement.textContent = value;\n+ }\n+\n+ get visited() {\n+ return this.visitedElement.checked;\n+ }\n+\n+ set visited(value) {\n+ this.visitedElement.checked = value;\n+ }\n+\n+ _createElement() {\n+ this.element = document.createElement('div');\n+ this.element.classList.add('places__place');\n+ this.element.innerHTML = '' +\n+ '<div class=\"places__edit-buttons\">\\n' +\n+ ' <button class=\"places__btn-edit btn-float\">' +\n+ ' <i class=\"fas fa-pencil-alt\"></i>' +\n+ ' </button>\\n' +\n+ ' <button class=\"places__btn-delete btn-float\">' +\n+ ' <i class=\"fas fa-trash-alt\"></i>' +\n+ ' </button>\\n' +\n+ '</div>\\n' +\n+ '<div class=\"places__place-name\"></div>\\n' +\n+ '<div class=\"places__move-buttons\">\\n' +\n+ ' <button class=\"places__btn-move-up btn-float\">' +\n+ ' <i class=\"fas fa-arrow-up\"></i>' +\n+ ' </button>\\n' +\n+ ' <button class=\"places__btn-move-down btn-float\">' +\n+ ' <i class=\"fas fa-arrow-down\"></i>' +\n+ ' </button>\\n' +\n+ '</div>\\n' +\n+ '<input class=\"places__is-visited\" type=\"checkbox\">';\n+ }\n+\n+ _findComponents() {\n+ this.nameElement = this._find('.places__place-name');\n+ this.visitedElement = this._find('.places__is-visited');\n+ this.editableField = new EditableField(this.nameElement);\n+ this.btnEdit = this._find('.places__btn-edit');\n+ this.btnDelete = this._find('.places__btn-delete');\n+ this.btnCancel = this._find('.edit-field__btn-cancel');\n+ this.btnSave = this._find('.edit-field__btn-save');\n+ this.btnMoveUp = this._find('.places__btn-move-up');\n+ this.btnMoveDown = this._find('.places__btn-move-down');\n+ }\n+}\n+\n+\n+class PlacesList extends ElementWrapper {\n+ constructor() {\n+ super();\n+ this.element = document.querySelector('.places__list');\n+ this.places = [];\n+ }\n+\n+ async reloadPlacesFromServer() {\n+ let response = await fetch(API_URL);\n+ let places = await response.json();\n+ this.places = [];\n+ for (const place of places) {\n+ this.createPlace(place.id, place.description, place.visited);\n+ }\n+ }\n+\n+ createPlace(id, name, visited = false) {\n+ const place = new Place(id, name, visited);\n+ this.places.push(place);\n+ place.btnEdit.onclick = (e) => this._onEditPlaceName(e);\n+ place.btnDelete.onclick = (e) => this._onDeletePlace(e);\n+ place.btnMoveUp.onclick = (e) => this._onChangeIndex(e, -1);\n+ place.btnMoveDown.onclick = (e) => this._onChangeIndex(e, 1);\n+ place.visitedElement.onchange = (e) => this._onChangePlaceVisited(e);\n+ this.reloadListView();\n+ }\n+\n+ reloadListView() {\n+ const searchQuery = document.querySelector('.search__field').value;\n+ this.element.innerHTML = '';\n+ for (const place of this.places) {\n+ if (place.name.includes(searchQuery) && matchesVisitedFilter(place)) {\n+ this.element.appendChild(place.element);\n+ }\n+ }\n+ const moveAllowed = !searchQuery && visitedFilterState === 'all';\n+ this._forAll('.places__btn-move-up, .places__btn-move-down', btn => {\n+ btn.hidden = !moveAllowed;\n+ });\n+ }\n+\n+ async _onEditPlaceName(event) {\n+ const place = this._getPlace(event);\n+ place.editableField.edit(async (editedValue) => {\n+ const response = await fetch(`${API_URL}/${place.id}`, {\n+ method: 'PATCH',\n+ headers: {\n+ 'Content-Type': 'application/json'\n+ },\n+ body: JSON.stringify({ description: editedValue })\n+ });\n+ if (response.status !== 204) {\n+ throw new Error('Cannot update place.');\n+ }\n+ });\n+ }\n+\n+ async _onChangePlaceVisited(event) {\n+ const place = this._getPlace(event);\n+ const response = await fetch(`${API_URL}/${place.id}`, {\n+ method: 'PATCH',\n+ headers: {\n+ 'Content-Type': 'application/json'\n+ },\n+ body: JSON.stringify({ visited: place.visited })\n+ });\n+ if (response.status !== 204) {\n+ throw new Error('Cannot update place.');\n+ }\n+ this.reloadListView();\n+ }\n+\n+ async _onChangeIndex(event, delta) {\n+ const place = this._getPlace(event);\n+ const placeIndex = this.places.indexOf(place);\n+ const response = await fetch(`${API_URL}/${place.id}/index`, {\n+ method: 'PUT',\n+ headers: {\n+ 'Content-Type': 'application/json'\n+ },\n+ body: JSON.stringify(placeIndex + delta)\n+ });\n+ if (response.status !== 204) {\n+ throw new Error('Cannot change place index.');\n+ }\n+ this.places.splice(placeIndex, 1);\n+ this.places.splice(placeIndex + delta, 0, place);\n+ this.reloadListView();\n+ }\n+\n+ async _onDeletePlace(event) {\n+ const place = this._getPlace(event);\n+ const response = await fetch(`${API_URL}/${place.id}`, {\n+ method: 'DELETE'\n+ });\n+ if (response.status !== 204) {\n+ throw new Error('Cannot delete place.');\n+ }\n+ this.places = this.places.filter(item => item !== place);\n+ this.reloadListView();\n+ }\n+\n+ async deleteAllPlaces() {\n+ const response = await fetch(API_URL, {\n+ method: 'DELETE'\n+ });\n+ if (response.status !== 204) {\n+ throw new Error('Cannot delete all places.');\n+ }\n+ this.places = [];\n+ this.reloadListView();\n+ }\n+\n+ _getPlace(event) {\n+ return this.places.find(place =>\n+ place.element === event.target.closest('.places__place'));\n+ }\n+}\n+\n+let placesList;\n+\n+window.onload = async function () {\n+ placesList = new PlacesList();\n+ await placesList.reloadPlacesFromServer();\n+\n+ document.querySelector('.search__field')\n+ .oninput = () => placesList.reloadListView();\n+\n+ document.querySelectorAll('.places__filter button')\n+ .forEach(btn => {\n+ btn.onclick = (e) => {\n+ visitedFilterState = e.target.dataset.filterState;\n+ document.querySelectorAll('.places__filter button')\n+ .forEach(b => b.classList.remove('btn-filter-selected'));\n+ e.target.classList.add('btn-filter-selected');\n+ placesList.reloadListView();\n+ };\n+ });\n+\n+ document.querySelector('.create-place__btn-create')\n+ .onclick = createPlace;\n+\n+ document.querySelector('.create-place__name')\n+ .onkeydown = e => {\n+ if (e.keyCode === 13) {\n+ createPlace();\n+ }\n+ };\n+\n+ document.querySelector('.places__btn-delete-all')\n+ .onclick = () => placesList.deleteAllPlaces();\n+};\n+\n+async function createPlace() {\n+ const placeName = document.querySelector('.create-place__name').value;\n+ const response = await fetch(API_URL, {\n+ method: 'POST',\n+ headers: {\n+ 'Content-Type': 'application/json'\n+ },\n+ body: JSON.stringify({ description: placeName })\n+ });\n+ if (response.status !== 200) {\n+ throw new Error('Cannot create place.');\n+ }\n+\n+ const placeId = response.url.split('/').slice(-1)[0];\n+ placesList.createPlace(placeId, placeName);\n+}\n+\n+function matchesVisitedFilter(place) {\n+ return visitedFilterState === 'all' ||","path":"public/index.js","position":329,"original_position":329,"commit_id":"50c650f36faf826d58d8c3e4b6ae153f9b03d5ab","original_commit_id":"50c650f36faf826d58d8c3e4b6ae153f9b03d5ab","user":{"login":"Superilya","id":6960308,"avatar_url":"https://avatars0.githubusercontent.com/u/6960308?v=4","gravatar_id":"","url":"https://api.github.com/users/Superilya","html_url":"https://github.com/Superilya","followers_url":"https://api.github.com/users/Superilya/followers","following_url":"https://api.github.com/users/Superilya/following{/other_user}","gists_url":"https://api.github.com/users/Superilya/gists{/gist_id}","starred_url":"https://api.github.com/users/Superilya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Superilya/subscriptions","organizations_url":"https://api.github.com/users/Superilya/orgs","repos_url":"https://api.github.com/users/Superilya/repos","events_url":"https://api.github.com/users/Superilya/events{/privacy}","received_events_url":"https://api.github.com/users/Superilya/received_events","type":"User","site_admin":false},"body":"давай названия стейтотв в константы","created_at":"2018-05-17T04:03:58Z","updated_at":"2018-05-17T04:04:03Z","html_url":"https://github.com/urfu-2017/webdev-task-3/pull/5#discussion_r188833779","pull_request_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/comments/188833779"},"html":{"href":"https://github.com/urfu-2017/webdev-task-3/pull/5#discussion_r188833779"},"pull_request":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/5","id":176200537,"html_url":"https://github.com/urfu-2017/webdev-task-3/pull/5","diff_url":"https://github.com/urfu-2017/webdev-task-3/pull/5.diff","patch_url":"https://github.com/urfu-2017/webdev-task-3/pull/5.patch","issue_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/issues/5","number":5,"state":"open","locked":false,"title":"Захаров Алексей","user":{"login":"Az404","id":17743197,"avatar_url":"https://avatars2.githubusercontent.com/u/17743197?v=4","gravatar_id":"","url":"https://api.github.com/users/Az404","html_url":"https://github.com/Az404","followers_url":"https://api.github.com/users/Az404/followers","following_url":"https://api.github.com/users/Az404/following{/other_user}","gists_url":"https://api.github.com/users/Az404/gists{/gist_id}","starred_url":"https://api.github.com/users/Az404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Az404/subscriptions","organizations_url":"https://api.github.com/users/Az404/orgs","repos_url":"https://api.github.com/users/Az404/repos","events_url":"https://api.github.com/users/Az404/events{/privacy}","received_events_url":"https://api.github.com/users/Az404/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-20T14:03:20Z","updated_at":"2018-05-17T04:04:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5492923d60ff5bafe8917fa2c8a7ac92e649787d","assignee":{"login":"Savichev-Igor","id":7279995,"avatar_url":"https://avatars0.githubusercontent.com/u/7279995?v=4","gravatar_id":"","url":"https://api.github.com/users/Savichev-Igor","html_url":"https://github.com/Savichev-Igor","followers_url":"https://api.github.com/users/Savichev-Igor/followers","following_url":"https://api.github.com/users/Savichev-Igor/following{/other_user}","gists_url":"https://api.github.com/users/Savichev-Igor/gists{/gist_id}","starred_url":"https://api.github.com/users/Savichev-Igor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Savichev-Igor/subscriptions","organizations_url":"https://api.github.com/users/Savichev-Igor/orgs","repos_url":"https://api.github.com/users/Savichev-Igor/repos","events_url":"https://api.github.com/users/Savichev-Igor/events{/privacy}","received_events_url":"https://api.github.com/users/Savichev-Igor/received_events","type":"User","site_admin":false},"assignees":[{"login":"Savichev-Igor","id":7279995,"avatar_url":"https://avatars0.githubusercontent.com/u/7279995?v=4","gravatar_id":"","url":"https://api.github.com/users/Savichev-Igor","html_url":"https://github.com/Savichev-Igor","followers_url":"https://api.github.com/users/Savichev-Igor/followers","following_url":"https://api.github.com/users/Savichev-Igor/following{/other_user}","gists_url":"https://api.github.com/users/Savichev-Igor/gists{/gist_id}","starred_url":"https://api.github.com/users/Savichev-Igor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Savichev-Igor/subscriptions","organizations_url":"https://api.github.com/users/Savichev-Igor/orgs","repos_url":"https://api.github.com/users/Savichev-Igor/repos","events_url":"https://api.github.com/users/Savichev-Igor/events{/privacy}","received_events_url":"https://api.github.com/users/Savichev-Igor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/5/commits","review_comments_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/5/comments","review_comment_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/issues/5/comments","statuses_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/statuses/50c650f36faf826d58d8c3e4b6ae153f9b03d5ab","head":{"label":"Az404:master","ref":"master","sha":"50c650f36faf826d58d8c3e4b6ae153f9b03d5ab","user":{"login":"Az404","id":17743197,"avatar_url":"https://avatars2.githubusercontent.com/u/17743197?v=4","gravatar_id":"","url":"https://api.github.com/users/Az404","html_url":"https://github.com/Az404","followers_url":"https://api.github.com/users/Az404/followers","following_url":"https://api.github.com/users/Az404/following{/other_user}","gists_url":"https://api.github.com/users/Az404/gists{/gist_id}","starred_url":"https://api.github.com/users/Az404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Az404/subscriptions","organizations_url":"https://api.github.com/users/Az404/orgs","repos_url":"https://api.github.com/users/Az404/repos","events_url":"https://api.github.com/users/Az404/events{/privacy}","received_events_url":"https://api.github.com/users/Az404/received_events","type":"User","site_admin":false},"repo":{"id":125612972,"name":"webdev-task-3","full_name":"Az404/webdev-task-3","owner":{"login":"Az404","id":17743197,"avatar_url":"https://avatars2.githubusercontent.com/u/17743197?v=4","gravatar_id":"","url":"https://api.github.com/users/Az404","html_url":"https://github.com/Az404","followers_url":"https://api.github.com/users/Az404/followers","following_url":"https://api.github.com/users/Az404/following{/other_user}","gists_url":"https://api.github.com/users/Az404/gists{/gist_id}","starred_url":"https://api.github.com/users/Az404/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Az404/subscriptions","organizations_url":"https://api.github.com/users/Az404/orgs","repos_url":"https://api.github.com/users/Az404/repos","events_url":"https://api.github.com/users/Az404/events{/privacy}","received_events_url":"https://api.github.com/users/Az404/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Az404/webdev-task-3","description":"Задача «Павел слишком занят»","fork":true,"url":"https://api.github.com/repos/Az404/webdev-task-3","forks_url":"https://api.github.com/repos/Az404/webdev-task-3/forks","keys_url":"https://api.github.com/repos/Az404/webdev-task-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Az404/webdev-task-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Az404/webdev-task-3/teams","hooks_url":"https://api.github.com/repos/Az404/webdev-task-3/hooks","issue_events_url":"https://api.github.com/repos/Az404/webdev-task-3/issues/events{/number}","events_url":"https://api.github.com/repos/Az404/webdev-task-3/events","assignees_url":"https://api.github.com/repos/Az404/webdev-task-3/assignees{/user}","branches_url":"https://api.github.com/repos/Az404/webdev-task-3/branches{/branch}","tags_url":"https://api.github.com/repos/Az404/webdev-task-3/tags","blobs_url":"https://api.github.com/repos/Az404/webdev-task-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Az404/webdev-task-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Az404/webdev-task-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/Az404/webdev-task-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Az404/webdev-task-3/statuses/{sha}","languages_url":"https://api.github.com/repos/Az404/webdev-task-3/languages","stargazers_url":"https://api.github.com/repos/Az404/webdev-task-3/stargazers","contributors_url":"https://api.github.com/repos/Az404/webdev-task-3/contributors","subscribers_url":"https://api.github.com/repos/Az404/webdev-task-3/subscribers","subscription_url":"https://api.github.com/repos/Az404/webdev-task-3/subscription","commits_url":"https://api.github.com/repos/Az404/webdev-task-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/Az404/webdev-task-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/Az404/webdev-task-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/Az404/webdev-task-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/Az404/webdev-task-3/contents/{+path}","compare_url":"https://api.github.com/repos/Az404/webdev-task-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Az404/webdev-task-3/merges","archive_url":"https://api.github.com/repos/Az404/webdev-task-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Az404/webdev-task-3/downloads","issues_url":"https://api.github.com/repos/Az404/webdev-task-3/issues{/number}","pulls_url":"https://api.github.com/repos/Az404/webdev-task-3/pulls{/number}","milestones_url":"https://api.github.com/repos/Az404/webdev-task-3/milestones{/number}","notifications_url":"https://api.github.com/repos/Az404/webdev-task-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Az404/webdev-task-3/labels{/name}","releases_url":"https://api.github.com/repos/Az404/webdev-task-3/releases{/id}","deployments_url":"https://api.github.com/repos/Az404/webdev-task-3/deployments","created_at":"2018-03-17T09:06:52Z","updated_at":"2018-03-20T13:14:10Z","pushed_at":"2018-03-20T13:14:09Z","git_url":"git://github.com/Az404/webdev-task-3.git","ssh_url":"[email protected]:Az404/webdev-task-3.git","clone_url":"https://github.com/Az404/webdev-task-3.git","svn_url":"https://github.com/Az404/webdev-task-3","homepage":null,"size":22,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urfu-2017:master","ref":"master","sha":"64c81d7a61977a615ed2d2e70fa2887ac553d7c1","user":{"login":"urfu-2017","id":31925391,"avatar_url":"https://avatars1.githubusercontent.com/u/31925391?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2017","html_url":"https://github.com/urfu-2017","followers_url":"https://api.github.com/users/urfu-2017/followers","following_url":"https://api.github.com/users/urfu-2017/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2017/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2017/subscriptions","organizations_url":"https://api.github.com/users/urfu-2017/orgs","repos_url":"https://api.github.com/users/urfu-2017/repos","events_url":"https://api.github.com/users/urfu-2017/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2017/received_events","type":"Organization","site_admin":false},"repo":{"id":125380477,"name":"webdev-task-3","full_name":"urfu-2017/webdev-task-3","owner":{"login":"urfu-2017","id":31925391,"avatar_url":"https://avatars1.githubusercontent.com/u/31925391?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2017","html_url":"https://github.com/urfu-2017","followers_url":"https://api.github.com/users/urfu-2017/followers","following_url":"https://api.github.com/users/urfu-2017/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2017/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2017/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2017/subscriptions","organizations_url":"https://api.github.com/users/urfu-2017/orgs","repos_url":"https://api.github.com/users/urfu-2017/repos","events_url":"https://api.github.com/users/urfu-2017/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2017/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/urfu-2017/webdev-task-3","description":"Задача «Павел слишком занят»","fork":false,"url":"https://api.github.com/repos/urfu-2017/webdev-task-3","forks_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/forks","keys_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/teams","hooks_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/hooks","issue_events_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/issues/events{/number}","events_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/events","assignees_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/assignees{/user}","branches_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/branches{/branch}","tags_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/tags","blobs_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/git/refs{/sha}","trees_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/statuses/{sha}","languages_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/languages","stargazers_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/stargazers","contributors_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/contributors","subscribers_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/subscribers","subscription_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/subscription","commits_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/commits{/sha}","git_commits_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/git/commits{/sha}","comments_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/comments{/number}","issue_comment_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/issues/comments{/number}","contents_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/contents/{+path}","compare_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/merges","archive_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/downloads","issues_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/issues{/number}","pulls_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls{/number}","milestones_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/milestones{/number}","notifications_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/labels{/name}","releases_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/releases{/id}","deployments_url":"https://api.github.com/repos/urfu-2017/webdev-task-3/deployments","created_at":"2018-03-15T14:34:50Z","updated_at":"2018-03-15T18:34:06Z","pushed_at":"2018-05-15T15:51:49Z","git_url":"git://github.com/urfu-2017/webdev-task-3.git","ssh_url":"[email protected]:urfu-2017/webdev-task-3.git","clone_url":"https://github.com/urfu-2017/webdev-task-3.git","svn_url":"https://github.com/urfu-2017/webdev-task-3","homepage":null,"size":12,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":45,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":45,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/5"},"html":{"href":"https://github.com/urfu-2017/webdev-task-3/pull/5"},"issue":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/issues/5"},"comments":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/urfu-2017/webdev-task-3/statuses/50c650f36faf826d58d8c3e4b6ae153f9b03d5ab"}},"author_association":"NONE"}}

7687214331

{"actor":{"display_login":"Superilya"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/comments/201850600","pull_request_review_id":136435237,"id":201850600,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTg1MDYwMA==","diff_hunk":"@@ -0,0 +1,11 @@\n+multi-panel > .panel-heading {","path":"src/components/output/custom-els/MultiPanel/styles.css","position":1,"original_position":1,"commit_id":"b5d7882c8c49fbee09698081fe600a54a9a13d04","original_commit_id":"b5d7882c8c49fbee09698081fe600a54a9a13d04","user":{"login":"kosamari","id":4581495,"node_id":"MDQ6VXNlcjQ1ODE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4581495?v=4","gravatar_id":"","url":"https://api.github.com/users/kosamari","html_url":"https://github.com/kosamari","followers_url":"https://api.github.com/users/kosamari/followers","following_url":"https://api.github.com/users/kosamari/following{/other_user}","gists_url":"https://api.github.com/users/kosamari/gists{/gist_id}","starred_url":"https://api.github.com/users/kosamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kosamari/subscriptions","organizations_url":"https://api.github.com/users/kosamari/orgs","repos_url":"https://api.github.com/users/kosamari/repos","events_url":"https://api.github.com/users/kosamari/events{/privacy}","received_events_url":"https://api.github.com/users/kosamari/received_events","type":"User","site_admin":false},"body":"hmmm, I simply followed PinchZoom and TwoUp which are css.","created_at":"2018-07-11T21:48:22Z","updated_at":"2018-07-11T21:48:22Z","html_url":"https://github.com/GoogleChromeLabs/squoosh/pull/95#discussion_r201850600","pull_request_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/95","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/comments/201850600"},"html":{"href":"https://github.com/GoogleChromeLabs/squoosh/pull/95#discussion_r201850600"},"pull_request":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/95"}},"in_reply_to_id":200842439},"pull_request":{"url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/95","id":199311389,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MzExMzg5","html_url":"https://github.com/GoogleChromeLabs/squoosh/pull/95","diff_url":"https://github.com/GoogleChromeLabs/squoosh/pull/95.diff","patch_url":"https://github.com/GoogleChromeLabs/squoosh/pull/95.patch","issue_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues/95","number":95,"state":"open","locked":false,"title":"Add multi-panel component","user":{"login":"kosamari","id":4581495,"node_id":"MDQ6VXNlcjQ1ODE0OTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4581495?v=4","gravatar_id":"","url":"https://api.github.com/users/kosamari","html_url":"https://github.com/kosamari","followers_url":"https://api.github.com/users/kosamari/followers","following_url":"https://api.github.com/users/kosamari/following{/other_user}","gists_url":"https://api.github.com/users/kosamari/gists{/gist_id}","starred_url":"https://api.github.com/users/kosamari/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kosamari/subscriptions","organizations_url":"https://api.github.com/users/kosamari/orgs","repos_url":"https://api.github.com/users/kosamari/repos","events_url":"https://api.github.com/users/kosamari/events{/privacy}","received_events_url":"https://api.github.com/users/kosamari/received_events","type":"User","site_admin":false},"body":"This PR is the same thing for #24 but against master.\r\n\r\nAll of code review feedback from #24 should have been addressed, and typescript errors resolved.","created_at":"2018-07-04T19:04:13Z","updated_at":"2018-07-11T21:48:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"33a4bb3122764546f8dd2219456674c31ee88484","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/95/commits","review_comments_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/95/comments","review_comment_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues/95/comments","statuses_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/statuses/b5d7882c8c49fbee09698081fe600a54a9a13d04","head":{"label":"GoogleChromeLabs:multi-panel","ref":"multi-panel","sha":"b5d7882c8c49fbee09698081fe600a54a9a13d04","user":{"login":"GoogleChromeLabs","id":31970254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTcwMjU0","avatar_url":"https://avatars1.githubusercontent.com/u/31970254?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChromeLabs","html_url":"https://github.com/GoogleChromeLabs","followers_url":"https://api.github.com/users/GoogleChromeLabs/followers","following_url":"https://api.github.com/users/GoogleChromeLabs/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChromeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChromeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChromeLabs/subscriptions","organizations_url":"https://api.github.com/users/GoogleChromeLabs/orgs","repos_url":"https://api.github.com/users/GoogleChromeLabs/repos","events_url":"https://api.github.com/users/GoogleChromeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChromeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":124303364,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzMDMzNjQ=","name":"squoosh","full_name":"GoogleChromeLabs/squoosh","owner":{"login":"GoogleChromeLabs","id":31970254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTcwMjU0","avatar_url":"https://avatars1.githubusercontent.com/u/31970254?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChromeLabs","html_url":"https://github.com/GoogleChromeLabs","followers_url":"https://api.github.com/users/GoogleChromeLabs/followers","following_url":"https://api.github.com/users/GoogleChromeLabs/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChromeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChromeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChromeLabs/subscriptions","organizations_url":"https://api.github.com/users/GoogleChromeLabs/orgs","repos_url":"https://api.github.com/users/GoogleChromeLabs/repos","events_url":"https://api.github.com/users/GoogleChromeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChromeLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChromeLabs/squoosh","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleChromeLabs/squoosh","forks_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/forks","keys_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/teams","hooks_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/hooks","issue_events_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/events","assignees_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/tags","blobs_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/languages","stargazers_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/stargazers","contributors_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/contributors","subscribers_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/subscribers","subscription_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/subscription","commits_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/merges","archive_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/downloads","issues_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/deployments","created_at":"2018-03-07T22:42:03Z","updated_at":"2018-07-10T14:59:09Z","pushed_at":"2018-07-11T21:23:34Z","git_url":"git://github.com/GoogleChromeLabs/squoosh.git","ssh_url":"[email protected]:GoogleChromeLabs/squoosh.git","clone_url":"https://github.com/GoogleChromeLabs/squoosh.git","svn_url":"https://github.com/GoogleChromeLabs/squoosh","homepage":null,"size":4906,"stargazers_count":15,"watchers_count":15,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":39,"watchers":15,"default_branch":"master"}},"base":{"label":"GoogleChromeLabs:master","ref":"master","sha":"491280935a365f23ae3a617687f3ba7206465fe8","user":{"login":"GoogleChromeLabs","id":31970254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTcwMjU0","avatar_url":"https://avatars1.githubusercontent.com/u/31970254?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChromeLabs","html_url":"https://github.com/GoogleChromeLabs","followers_url":"https://api.github.com/users/GoogleChromeLabs/followers","following_url":"https://api.github.com/users/GoogleChromeLabs/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChromeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChromeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChromeLabs/subscriptions","organizations_url":"https://api.github.com/users/GoogleChromeLabs/orgs","repos_url":"https://api.github.com/users/GoogleChromeLabs/repos","events_url":"https://api.github.com/users/GoogleChromeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChromeLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":124303364,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzMDMzNjQ=","name":"squoosh","full_name":"GoogleChromeLabs/squoosh","owner":{"login":"GoogleChromeLabs","id":31970254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTcwMjU0","avatar_url":"https://avatars1.githubusercontent.com/u/31970254?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleChromeLabs","html_url":"https://github.com/GoogleChromeLabs","followers_url":"https://api.github.com/users/GoogleChromeLabs/followers","following_url":"https://api.github.com/users/GoogleChromeLabs/following{/other_user}","gists_url":"https://api.github.com/users/GoogleChromeLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleChromeLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleChromeLabs/subscriptions","organizations_url":"https://api.github.com/users/GoogleChromeLabs/orgs","repos_url":"https://api.github.com/users/GoogleChromeLabs/repos","events_url":"https://api.github.com/users/GoogleChromeLabs/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleChromeLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleChromeLabs/squoosh","description":null,"fork":false,"url":"https://api.github.com/repos/GoogleChromeLabs/squoosh","forks_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/forks","keys_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/teams","hooks_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/hooks","issue_events_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/events","assignees_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/tags","blobs_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/languages","stargazers_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/stargazers","contributors_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/contributors","subscribers_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/subscribers","subscription_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/subscription","commits_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/merges","archive_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/downloads","issues_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/labels{/name}","releases_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleChromeLabs/squoosh/deployments","created_at":"2018-03-07T22:42:03Z","updated_at":"2018-07-10T14:59:09Z","pushed_at":"2018-07-11T21:23:34Z","git_url":"git://github.com/GoogleChromeLabs/squoosh.git","ssh_url":"[email protected]:GoogleChromeLabs/squoosh.git","clone_url":"https://github.com/GoogleChromeLabs/squoosh.git","svn_url":"https://github.com/GoogleChromeLabs/squoosh","homepage":null,"size":4906,"stargazers_count":15,"watchers_count":15,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":39,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4,"open_issues":39,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/95"},"html":{"href":"https://github.com/GoogleChromeLabs/squoosh/pull/95"},"issue":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues/95"},"comments":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleChromeLabs/squoosh/statuses/b5d7882c8c49fbee09698081fe600a54a9a13d04"}},"author_association":"COLLABORATOR"}}

7952775494

{"actor":{"display_login":"kosamari"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/cloudevents/spec/pulls/comments/200503611","pull_request_review_id":134834427,"id":200503611,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDUwMzYxMQ==","diff_hunk":"@@ -300,6 +300,14 @@ attributes and the event data will be materialized. For example, in the case\n of a JSON serialization, the context attributes and the event data might\n both appear within the same JSON object.\n \n+CloudEvent producers MAY include additional extension attributes within the\n+event. Each specification that defines how to serialize a CloudEvent will\n+define how extension attributes will appear. When defining a new extension","path":"spec.md","position":6,"original_position":6,"commit_id":"08f376a97a95f59470b7f75c9e31dfa03fe445e5","original_commit_id":"08f376a97a95f59470b7f75c9e31dfa03fe445e5","user":{"login":"cathyhongzhang","id":9042908,"node_id":"MDQ6VXNlcjkwNDI5MDg=","avatar_url":"https://avatars1.githubusercontent.com/u/9042908?v=4","gravatar_id":"","url":"https://api.github.com/users/cathyhongzhang","html_url":"https://github.com/cathyhongzhang","followers_url":"https://api.github.com/users/cathyhongzhang/followers","following_url":"https://api.github.com/users/cathyhongzhang/following{/other_user}","gists_url":"https://api.github.com/users/cathyhongzhang/gists{/gist_id}","starred_url":"https://api.github.com/users/cathyhongzhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cathyhongzhang/subscriptions","organizations_url":"https://api.github.com/users/cathyhongzhang/orgs","repos_url":"https://api.github.com/users/cathyhongzhang/repos","events_url":"https://api.github.com/users/cathyhongzhang/events{/privacy}","received_events_url":"https://api.github.com/users/cathyhongzhang/received_events","type":"User","site_admin":false},"body":"Need to clarify what is meant by \"include additional extension attributes within the event\"? Do you mean Event producer can include any random attributes (and give it a name the producer likes) within the top level event attributes? If so, how could the event consumers know the semantics of those attributes? How could the event consumers know how to decode the random attributes (are they strings or ints ?) and properly use them? ","created_at":"2018-07-05T22:09:57Z","updated_at":"2018-07-05T22:09:57Z","html_url":"https://github.com/cloudevents/spec/pull/225#discussion_r200503611","pull_request_url":"https://api.github.com/repos/cloudevents/spec/pulls/225","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cloudevents/spec/pulls/comments/200503611"},"html":{"href":"https://github.com/cloudevents/spec/pull/225#discussion_r200503611"},"pull_request":{"href":"https://api.github.com/repos/cloudevents/spec/pulls/225"}}},"pull_request":{"url":"https://api.github.com/repos/cloudevents/spec/pulls/225","id":191785671,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzg1Njcx","html_url":"https://github.com/cloudevents/spec/pull/225","diff_url":"https://github.com/cloudevents/spec/pull/225.diff","patch_url":"https://github.com/cloudevents/spec/pull/225.patch","issue_url":"https://api.github.com/repos/cloudevents/spec/issues/225","number":225,"state":"open","locked":false,"title":"Make extension attributes siblings to our attributes","user":{"login":"duglin","id":1944671,"node_id":"MDQ6VXNlcjE5NDQ2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1944671?v=4","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"body":"A top-level `extensions` bag doesn't scope the extensions to anything other than to the event itself, which means in:\r\n``` JSON\r\n{\r\n \"cloudEventsVersion\" : \"0.1\",\r\n \"eventType\" : \"com.example.someevent\",\r\n \"eventTypeVersion\" : \"1.0\",\r\n \"source\" : \"/mycontext\",\r\n \"eventID\" : \"A234-1234-1234\",\r\n \"eventTime\" : \"2018-04-05T17:31:00Z\",\r\n \"contentType\" : \"text/xml\",\r\n \"data\" : \"<much wow=\\\"xml\\\"/>\",\r\n \"extensions\" : {\r\n \"foo\" : \"value\"\r\n },\r\n \"bar\" : \"value\"\r\n}\r\n```\r\n`foo` and `bar` would have the same scoping. This would serve no purpose other than to confuse people as to when to use one extension point verses the other. And what does it mean when one is used vs the other? What if both are used? What if the same name is used in both spots - which one wins? These types of questions, while solvable, add unnecessary complexity. I think its much cleaner if we just used the natural extensibility of whatever encoding/transport being used.\r\n\r\nSigned-off-by: Doug Davis <[email protected]>","created_at":"2018-05-31T15:10:51Z","updated_at":"2018-07-05T22:09:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1be450f97ffc16cfcadb8c5cad5089d914879f76","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":927948896,"node_id":"MDU6TGFiZWw5Mjc5NDg4OTY=","url":"https://api.github.com/repos/cloudevents/spec/labels/v1.0","name":"v1.0","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cloudevents/spec/pulls/225/commits","review_comments_url":"https://api.github.com/repos/cloudevents/spec/pulls/225/comments","review_comment_url":"https://api.github.com/repos/cloudevents/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudevents/spec/issues/225/comments","statuses_url":"https://api.github.com/repos/cloudevents/spec/statuses/08f376a97a95f59470b7f75c9e31dfa03fe445e5","head":{"label":"duglin:extensions","ref":"extensions","sha":"08f376a97a95f59470b7f75c9e31dfa03fe445e5","user":{"login":"duglin","id":1944671,"node_id":"MDQ6VXNlcjE5NDQ2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1944671?v=4","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"repo":{"id":113702066,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM3MDIwNjY=","name":"spec","full_name":"duglin/spec","owner":{"login":"duglin","id":1944671,"node_id":"MDQ6VXNlcjE5NDQ2NzE=","avatar_url":"https://avatars1.githubusercontent.com/u/1944671?v=4","gravatar_id":"","url":"https://api.github.com/users/duglin","html_url":"https://github.com/duglin","followers_url":"https://api.github.com/users/duglin/followers","following_url":"https://api.github.com/users/duglin/following{/other_user}","gists_url":"https://api.github.com/users/duglin/gists{/gist_id}","starred_url":"https://api.github.com/users/duglin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/duglin/subscriptions","organizations_url":"https://api.github.com/users/duglin/orgs","repos_url":"https://api.github.com/users/duglin/repos","events_url":"https://api.github.com/users/duglin/events{/privacy}","received_events_url":"https://api.github.com/users/duglin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/duglin/spec","description":"OpenEventing Specification","fork":true,"url":"https://api.github.com/repos/duglin/spec","forks_url":"https://api.github.com/repos/duglin/spec/forks","keys_url":"https://api.github.com/repos/duglin/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/duglin/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/duglin/spec/teams","hooks_url":"https://api.github.com/repos/duglin/spec/hooks","issue_events_url":"https://api.github.com/repos/duglin/spec/issues/events{/number}","events_url":"https://api.github.com/repos/duglin/spec/events","assignees_url":"https://api.github.com/repos/duglin/spec/assignees{/user}","branches_url":"https://api.github.com/repos/duglin/spec/branches{/branch}","tags_url":"https://api.github.com/repos/duglin/spec/tags","blobs_url":"https://api.github.com/repos/duglin/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/duglin/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/duglin/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/duglin/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/duglin/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/duglin/spec/languages","stargazers_url":"https://api.github.com/repos/duglin/spec/stargazers","contributors_url":"https://api.github.com/repos/duglin/spec/contributors","subscribers_url":"https://api.github.com/repos/duglin/spec/subscribers","subscription_url":"https://api.github.com/repos/duglin/spec/subscription","commits_url":"https://api.github.com/repos/duglin/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/duglin/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/duglin/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/duglin/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/duglin/spec/contents/{+path}","compare_url":"https://api.github.com/repos/duglin/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/duglin/spec/merges","archive_url":"https://api.github.com/repos/duglin/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/duglin/spec/downloads","issues_url":"https://api.github.com/repos/duglin/spec/issues{/number}","pulls_url":"https://api.github.com/repos/duglin/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/duglin/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/duglin/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/duglin/spec/labels{/name}","releases_url":"https://api.github.com/repos/duglin/spec/releases{/id}","deployments_url":"https://api.github.com/repos/duglin/spec/deployments","created_at":"2017-12-09T21:20:39Z","updated_at":"2017-12-09T21:18:13Z","pushed_at":"2018-07-05T17:47:24Z","git_url":"git://github.com/duglin/spec.git","ssh_url":"[email protected]:duglin/spec.git","clone_url":"https://github.com/duglin/spec.git","svn_url":"https://github.com/duglin/spec","homepage":null,"size":26485,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudevents:master","ref":"master","sha":"42d7635ca06f43c8c0099ee84c11ced5e4fa3e6b","user":{"login":"cloudevents","id":32076828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDc2ODI4","avatar_url":"https://avatars2.githubusercontent.com/u/32076828?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudevents","html_url":"https://github.com/cloudevents","followers_url":"https://api.github.com/users/cloudevents/followers","following_url":"https://api.github.com/users/cloudevents/following{/other_user}","gists_url":"https://api.github.com/users/cloudevents/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudevents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudevents/subscriptions","organizations_url":"https://api.github.com/users/cloudevents/orgs","repos_url":"https://api.github.com/users/cloudevents/repos","events_url":"https://api.github.com/users/cloudevents/events{/privacy}","received_events_url":"https://api.github.com/users/cloudevents/received_events","type":"Organization","site_admin":false},"repo":{"id":113701924,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM3MDE5MjQ=","name":"spec","full_name":"cloudevents/spec","owner":{"login":"cloudevents","id":32076828,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDc2ODI4","avatar_url":"https://avatars2.githubusercontent.com/u/32076828?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudevents","html_url":"https://github.com/cloudevents","followers_url":"https://api.github.com/users/cloudevents/followers","following_url":"https://api.github.com/users/cloudevents/following{/other_user}","gists_url":"https://api.github.com/users/cloudevents/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudevents/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudevents/subscriptions","organizations_url":"https://api.github.com/users/cloudevents/orgs","repos_url":"https://api.github.com/users/cloudevents/repos","events_url":"https://api.github.com/users/cloudevents/events{/privacy}","received_events_url":"https://api.github.com/users/cloudevents/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudevents/spec","description":"CloudEvents Specification","fork":false,"url":"https://api.github.com/repos/cloudevents/spec","forks_url":"https://api.github.com/repos/cloudevents/spec/forks","keys_url":"https://api.github.com/repos/cloudevents/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudevents/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudevents/spec/teams","hooks_url":"https://api.github.com/repos/cloudevents/spec/hooks","issue_events_url":"https://api.github.com/repos/cloudevents/spec/issues/events{/number}","events_url":"https://api.github.com/repos/cloudevents/spec/events","assignees_url":"https://api.github.com/repos/cloudevents/spec/assignees{/user}","branches_url":"https://api.github.com/repos/cloudevents/spec/branches{/branch}","tags_url":"https://api.github.com/repos/cloudevents/spec/tags","blobs_url":"https://api.github.com/repos/cloudevents/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudevents/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudevents/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudevents/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudevents/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudevents/spec/languages","stargazers_url":"https://api.github.com/repos/cloudevents/spec/stargazers","contributors_url":"https://api.github.com/repos/cloudevents/spec/contributors","subscribers_url":"https://api.github.com/repos/cloudevents/spec/subscribers","subscription_url":"https://api.github.com/repos/cloudevents/spec/subscription","commits_url":"https://api.github.com/repos/cloudevents/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudevents/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudevents/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudevents/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudevents/spec/contents/{+path}","compare_url":"https://api.github.com/repos/cloudevents/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudevents/spec/merges","archive_url":"https://api.github.com/repos/cloudevents/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudevents/spec/downloads","issues_url":"https://api.github.com/repos/cloudevents/spec/issues{/number}","pulls_url":"https://api.github.com/repos/cloudevents/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudevents/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudevents/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudevents/spec/labels{/name}","releases_url":"https://api.github.com/repos/cloudevents/spec/releases{/id}","deployments_url":"https://api.github.com/repos/cloudevents/spec/deployments","created_at":"2017-12-09T21:18:13Z","updated_at":"2018-07-05T17:46:21Z","pushed_at":"2018-07-05T17:46:18Z","git_url":"git://github.com/cloudevents/spec.git","ssh_url":"[email protected]:cloudevents/spec.git","clone_url":"https://github.com/cloudevents/spec.git","svn_url":"https://github.com/cloudevents/spec","homepage":"https://cloudevents.io","size":26521,"stargazers_count":479,"watchers_count":479,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":83,"open_issues":48,"watchers":479,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudevents/spec/pulls/225"},"html":{"href":"https://github.com/cloudevents/spec/pull/225"},"issue":{"href":"https://api.github.com/repos/cloudevents/spec/issues/225"},"comments":{"href":"https://api.github.com/repos/cloudevents/spec/issues/225/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudevents/spec/pulls/225/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudevents/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudevents/spec/pulls/225/commits"},"statuses":{"href":"https://api.github.com/repos/cloudevents/spec/statuses/08f376a97a95f59470b7f75c9e31dfa03fe445e5"}},"author_association":"COLLABORATOR"}}

7925815179

{"actor":{"display_login":"cathyhongzhang"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/process-engine/documentation/pulls/comments/224708114","pull_request_review_id":164142784,"id":224708114,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDcwODExNA==","diff_hunk":"@@ -1,271 +1,80 @@\n # Erhalten von Prozessbenachrichtigungen\n \n-* [Arten von Prozessbenachrichtigungen](#arten-von-prozessbenachrichtigungen)\n-* [Erhalten von BPMN-Events](#erhalten-von-bpmn-events)\n-* [Erhalten von Infos zu start und ende von Aktivitäten](#erhalten-von-infos-zu-start-und-ende-von-aktivitäten)\n-* [Erhalten von System-Events](#erhalten-von-system-events)\n-* [Erhalten von BPMN-Signalen](#erhalten-von-bpmn-signalen)\n+* [Beendigung eines Prozesses](#beendigung-eines-prozesses)\n+* [Abbruch eines Prozesses](#abbruch-eines-prozesses)\n+* [Erreichen eines UserTasks](#erreichen-eines-usertasks)\n+* [Abschluss eines UserTasks](#abschluss-eines-usertasks)\n \n-Der Consumer Client benutzt einen Messagebus, um zur Laufzeit\n-von der Process Engine über bestimmte `Events` benachrichtigt zu werden.\n+Der ConsumerAPI Client wird zur Laufzeit von der Process Engine über bestimmte\n+`Events` benachrichtigt zu werden.","path":"api/consumer_api/tasks/receive-process-notifiations.md","position":16,"original_position":16,"commit_id":"dd55828198b1445d56d17e73c0d50a0308b31389","original_commit_id":"dd55828198b1445d56d17e73c0d50a0308b31389","user":{"login":"ElRaptorus","id":15343316,"node_id":"MDQ6VXNlcjE1MzQzMzE2","avatar_url":"https://avatars1.githubusercontent.com/u/15343316?v=4","gravatar_id":"","url":"https://api.github.com/users/ElRaptorus","html_url":"https://github.com/ElRaptorus","followers_url":"https://api.github.com/users/ElRaptorus/followers","following_url":"https://api.github.com/users/ElRaptorus/following{/other_user}","gists_url":"https://api.github.com/users/ElRaptorus/gists{/gist_id}","starred_url":"https://api.github.com/users/ElRaptorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElRaptorus/subscriptions","organizations_url":"https://api.github.com/users/ElRaptorus/orgs","repos_url":"https://api.github.com/users/ElRaptorus/repos","events_url":"https://api.github.com/users/ElRaptorus/events{/privacy}","received_events_url":"https://api.github.com/users/ElRaptorus/received_events","type":"User","site_admin":false},"body":"`... zu werden.` am Ende ist zu viel.","created_at":"2018-10-12T08:27:32Z","updated_at":"2018-10-12T08:44:02Z","html_url":"https://github.com/process-engine/documentation/pull/147#discussion_r224708114","pull_request_url":"https://api.github.com/repos/process-engine/documentation/pulls/147","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/process-engine/documentation/pulls/comments/224708114"},"html":{"href":"https://github.com/process-engine/documentation/pull/147#discussion_r224708114"},"pull_request":{"href":"https://api.github.com/repos/process-engine/documentation/pulls/147"}}},"pull_request":{"url":"https://api.github.com/repos/process-engine/documentation/pulls/147","id":216975817,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2OTc1ODE3","html_url":"https://github.com/process-engine/documentation/pull/147","diff_url":"https://github.com/process-engine/documentation/pull/147.diff","patch_url":"https://github.com/process-engine/documentation/pull/147.patch","issue_url":"https://api.github.com/repos/process-engine/documentation/issues/147","number":147,"state":"open","locked":false,"title":"✨ Async notifications","user":{"login":"5ebastianMeier","id":16539774,"node_id":"MDQ6VXNlcjE2NTM5Nzc0","avatar_url":"https://avatars0.githubusercontent.com/u/16539774?v=4","gravatar_id":"","url":"https://api.github.com/users/5ebastianMeier","html_url":"https://github.com/5ebastianMeier","followers_url":"https://api.github.com/users/5ebastianMeier/followers","following_url":"https://api.github.com/users/5ebastianMeier/following{/other_user}","gists_url":"https://api.github.com/users/5ebastianMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/5ebastianMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5ebastianMeier/subscriptions","organizations_url":"https://api.github.com/users/5ebastianMeier/orgs","repos_url":"https://api.github.com/users/5ebastianMeier/repos","events_url":"https://api.github.com/users/5ebastianMeier/events{/privacy}","received_events_url":"https://api.github.com/users/5ebastianMeier/received_events","type":"User","site_admin":false},"body":"**Changes:**\r\n\r\n1. Move current `Erhalten von Prozessbenachrichtigungen` into legacy folder for further conceptual reference.\r\n2. Refactored section and sub-sections of `Erhalten von Prozessbenachrichtigungen`.\r\n3. Added `Socket` section to technical specifications of `ConsumerAPI`.\r\n4. Updated architecture diagram of `ConsumerAPI`.\r\n\r\n**Issues:**\r\n\r\nhttps://github.com/process-engine/process_engine_runtime/issues/71\r\n\r\nPR: #147 \r\n\r\n---\r\n\r\n## PR-Checklist\r\n\r\nPlease check the boxes in this list after submitting your PR:\r\n\r\n- [x] You can merge this PR **right now** (if not, please prefix the title with \"WIP: \")\r\n- [x] I've tested **all** changes included in this PR.\r\n- [x] I've also reviewed this PR myself before submitting (e.g. for scrambled letters, typos, etc.).\r\n- [x] I've rebased the `develop` branch with my branch before finishing this PR.\r\n- [x] I've **summarized all changes** in a list above.\r\n- [x] I've mentioned all **PRs, which relate to this one**.\r\n- [x] I've prefixed my Pull Request title is according to [gitmoji guide](https://gitmoji.carloscuesta.me/).\r\n\r\n## Example\r\n\r\n<details>\r\n<summary>\r\n:warning: Before merging please click here to expand and follow the guide.\r\n</summary>\r\n<br>\r\n\r\nPlease use `:twisted_rightwards_arrows:` at the beginning of your merge commit title.\r\n\r\nExample 1:\r\n\r\n<pre>\r\n<code>\r\n:twisted_rightwards_arrows: :bug: Fix Wrong Text Decoration at ...\r\n</code>\r\n</pre>\r\n\r\nTo get your commit message, just copy the first part of this pull request.\r\n\r\nExample 2:\r\n<pre>\r\n<code>\r\n**Changes:**\r\n\r\n- Fixes Wrong Text Decoration at ...\r\n- Fixes some typos\r\n- ...\r\n\r\n**Issues:**\r\n\r\nCloses #NumberOfFixedIssue\r\n\r\nPR: #NumberOfThisPR\r\n</code>\r\n</pre>\r\n</details>\r\n\r\n## Emojis\r\n\r\n<details>\r\n<summary>\r\nExpand for a list of most used Emojis.\r\n</summary>\r\n<br>\r\n\r\nPlease prefix your commit messages with an Emoji.\r\n\r\nRef: https://gitmoji.carloscuesta.me/\r\n\r\n| Description | Glyphe | Emoji |\r\n|--------------------------|----------------------|--------|\r\n| Bugfix | `:bug:` | 🐛 |\r\n| Configuration releated | `:wrench:` | 🔧 |\r\n| Cosmetic | `:lipstick:` | 💄 |\r\n| Dependencies Downgrade | `:arrow_down:` | ⬇️ |\r\n| Dependencies Upgrade | `:arrow_up:` | ⬆️ |\r\n| Formatting | `:art:` | 🎨 |\r\n| Improving Performance | `:zap:` | ⚡️ |\r\n| Initial commit | `:tada:` | 🎉 |\r\n| Linter | `:rotating_light:` | 🚨 |\r\n| Miscellaneous | `:package:` | 📦 |\r\n| New Feature | `:sparkles:` | ✨ |\r\n| Refactoring Code | `:recycle:` | ♻️ |\r\n| Releasing / Version tags | `:bookmark:` | 🔖 |\r\n| Removing Stuff | `:fire:` | 🔥 |\r\n| Tests | `:white_check_mark:` | ✅ |\r\n| Work In Progress (WIP) | `:construction:` | 🚧 |\r\n\r\n</details>\r\n","created_at":"2018-09-20T13:39:54Z","updated_at":"2018-10-12T08:44:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6841b37630d11766d68671e60d1fc0aec6f14254","assignee":{"login":"5ebastianMeier","id":16539774,"node_id":"MDQ6VXNlcjE2NTM5Nzc0","avatar_url":"https://avatars0.githubusercontent.com/u/16539774?v=4","gravatar_id":"","url":"https://api.github.com/users/5ebastianMeier","html_url":"https://github.com/5ebastianMeier","followers_url":"https://api.github.com/users/5ebastianMeier/followers","following_url":"https://api.github.com/users/5ebastianMeier/following{/other_user}","gists_url":"https://api.github.com/users/5ebastianMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/5ebastianMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5ebastianMeier/subscriptions","organizations_url":"https://api.github.com/users/5ebastianMeier/orgs","repos_url":"https://api.github.com/users/5ebastianMeier/repos","events_url":"https://api.github.com/users/5ebastianMeier/events{/privacy}","received_events_url":"https://api.github.com/users/5ebastianMeier/received_events","type":"User","site_admin":false},"assignees":[{"login":"5ebastianMeier","id":16539774,"node_id":"MDQ6VXNlcjE2NTM5Nzc0","avatar_url":"https://avatars0.githubusercontent.com/u/16539774?v=4","gravatar_id":"","url":"https://api.github.com/users/5ebastianMeier","html_url":"https://github.com/5ebastianMeier","followers_url":"https://api.github.com/users/5ebastianMeier/followers","following_url":"https://api.github.com/users/5ebastianMeier/following{/other_user}","gists_url":"https://api.github.com/users/5ebastianMeier/gists{/gist_id}","starred_url":"https://api.github.com/users/5ebastianMeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/5ebastianMeier/subscriptions","organizations_url":"https://api.github.com/users/5ebastianMeier/orgs","repos_url":"https://api.github.com/users/5ebastianMeier/repos","events_url":"https://api.github.com/users/5ebastianMeier/events{/privacy}","received_events_url":"https://api.github.com/users/5ebastianMeier/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"cmg-dev","id":4034128,"node_id":"MDQ6VXNlcjQwMzQxMjg=","avatar_url":"https://avatars0.githubusercontent.com/u/4034128?v=4","gravatar_id":"","url":"https://api.github.com/users/cmg-dev","html_url":"https://github.com/cmg-dev","followers_url":"https://api.github.com/users/cmg-dev/followers","following_url":"https://api.github.com/users/cmg-dev/following{/other_user}","gists_url":"https://api.github.com/users/cmg-dev/gists{/gist_id}","starred_url":"https://api.github.com/users/cmg-dev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmg-dev/subscriptions","organizations_url":"https://api.github.com/users/cmg-dev/orgs","repos_url":"https://api.github.com/users/cmg-dev/repos","events_url":"https://api.github.com/users/cmg-dev/events{/privacy}","received_events_url":"https://api.github.com/users/cmg-dev/received_events","type":"User","site_admin":false},{"login":"roblen45","id":36449148,"node_id":"MDQ6VXNlcjM2NDQ5MTQ4","avatar_url":"https://avatars1.githubusercontent.com/u/36449148?v=4","gravatar_id":"","url":"https://api.github.com/users/roblen45","html_url":"https://github.com/roblen45","followers_url":"https://api.github.com/users/roblen45/followers","following_url":"https://api.github.com/users/roblen45/following{/other_user}","gists_url":"https://api.github.com/users/roblen45/gists{/gist_id}","starred_url":"https://api.github.com/users/roblen45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roblen45/subscriptions","organizations_url":"https://api.github.com/users/roblen45/orgs","repos_url":"https://api.github.com/users/roblen45/repos","events_url":"https://api.github.com/users/roblen45/events{/privacy}","received_events_url":"https://api.github.com/users/roblen45/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":714833690,"node_id":"MDU6TGFiZWw3MTQ4MzM2OTA=","url":"https://api.github.com/repos/process-engine/documentation/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/process-engine/documentation/pulls/147/commits","review_comments_url":"https://api.github.com/repos/process-engine/documentation/pulls/147/comments","review_comment_url":"https://api.github.com/repos/process-engine/documentation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/process-engine/documentation/issues/147/comments","statuses_url":"https://api.github.com/repos/process-engine/documentation/statuses/dd55828198b1445d56d17e73c0d50a0308b31389","head":{"label":"process-engine:feature/async_notification","ref":"feature/async_notification","sha":"dd55828198b1445d56d17e73c0d50a0308b31389","user":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106316372,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMTYzNzI=","name":"documentation","full_name":"process-engine/documentation","private":false,"owner":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/process-engine/documentation","description":"The ProcessEngine and BPMN-Studio Documentation","fork":false,"url":"https://api.github.com/repos/process-engine/documentation","forks_url":"https://api.github.com/repos/process-engine/documentation/forks","keys_url":"https://api.github.com/repos/process-engine/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/documentation/teams","hooks_url":"https://api.github.com/repos/process-engine/documentation/hooks","issue_events_url":"https://api.github.com/repos/process-engine/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/documentation/events","assignees_url":"https://api.github.com/repos/process-engine/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/documentation/tags","blobs_url":"https://api.github.com/repos/process-engine/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/documentation/languages","stargazers_url":"https://api.github.com/repos/process-engine/documentation/stargazers","contributors_url":"https://api.github.com/repos/process-engine/documentation/contributors","subscribers_url":"https://api.github.com/repos/process-engine/documentation/subscribers","subscription_url":"https://api.github.com/repos/process-engine/documentation/subscription","commits_url":"https://api.github.com/repos/process-engine/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/documentation/merges","archive_url":"https://api.github.com/repos/process-engine/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/documentation/downloads","issues_url":"https://api.github.com/repos/process-engine/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/documentation/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/documentation/deployments","created_at":"2017-10-09T17:51:36Z","updated_at":"2018-10-11T07:33:49Z","pushed_at":"2018-10-12T08:20:44Z","git_url":"git://github.com/process-engine/documentation.git","ssh_url":"[email protected]:process-engine/documentation.git","clone_url":"https://github.com/process-engine/documentation.git","svn_url":"https://github.com/process-engine/documentation","homepage":"http://www.process-engine.io/documentation","size":297641,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":19,"watchers":1,"default_branch":"develop"}},"base":{"label":"process-engine:develop","ref":"develop","sha":"2e88f9ce9a86017281994c17a82ddfcea5d724a7","user":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"repo":{"id":106316372,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYzMTYzNzI=","name":"documentation","full_name":"process-engine/documentation","private":false,"owner":{"login":"process-engine","id":32196207,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMTk2MjA3","avatar_url":"https://avatars2.githubusercontent.com/u/32196207?v=4","gravatar_id":"","url":"https://api.github.com/users/process-engine","html_url":"https://github.com/process-engine","followers_url":"https://api.github.com/users/process-engine/followers","following_url":"https://api.github.com/users/process-engine/following{/other_user}","gists_url":"https://api.github.com/users/process-engine/gists{/gist_id}","starred_url":"https://api.github.com/users/process-engine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/process-engine/subscriptions","organizations_url":"https://api.github.com/users/process-engine/orgs","repos_url":"https://api.github.com/users/process-engine/repos","events_url":"https://api.github.com/users/process-engine/events{/privacy}","received_events_url":"https://api.github.com/users/process-engine/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/process-engine/documentation","description":"The ProcessEngine and BPMN-Studio Documentation","fork":false,"url":"https://api.github.com/repos/process-engine/documentation","forks_url":"https://api.github.com/repos/process-engine/documentation/forks","keys_url":"https://api.github.com/repos/process-engine/documentation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/process-engine/documentation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/process-engine/documentation/teams","hooks_url":"https://api.github.com/repos/process-engine/documentation/hooks","issue_events_url":"https://api.github.com/repos/process-engine/documentation/issues/events{/number}","events_url":"https://api.github.com/repos/process-engine/documentation/events","assignees_url":"https://api.github.com/repos/process-engine/documentation/assignees{/user}","branches_url":"https://api.github.com/repos/process-engine/documentation/branches{/branch}","tags_url":"https://api.github.com/repos/process-engine/documentation/tags","blobs_url":"https://api.github.com/repos/process-engine/documentation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/process-engine/documentation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/process-engine/documentation/git/refs{/sha}","trees_url":"https://api.github.com/repos/process-engine/documentation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/process-engine/documentation/statuses/{sha}","languages_url":"https://api.github.com/repos/process-engine/documentation/languages","stargazers_url":"https://api.github.com/repos/process-engine/documentation/stargazers","contributors_url":"https://api.github.com/repos/process-engine/documentation/contributors","subscribers_url":"https://api.github.com/repos/process-engine/documentation/subscribers","subscription_url":"https://api.github.com/repos/process-engine/documentation/subscription","commits_url":"https://api.github.com/repos/process-engine/documentation/commits{/sha}","git_commits_url":"https://api.github.com/repos/process-engine/documentation/git/commits{/sha}","comments_url":"https://api.github.com/repos/process-engine/documentation/comments{/number}","issue_comment_url":"https://api.github.com/repos/process-engine/documentation/issues/comments{/number}","contents_url":"https://api.github.com/repos/process-engine/documentation/contents/{+path}","compare_url":"https://api.github.com/repos/process-engine/documentation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/process-engine/documentation/merges","archive_url":"https://api.github.com/repos/process-engine/documentation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/process-engine/documentation/downloads","issues_url":"https://api.github.com/repos/process-engine/documentation/issues{/number}","pulls_url":"https://api.github.com/repos/process-engine/documentation/pulls{/number}","milestones_url":"https://api.github.com/repos/process-engine/documentation/milestones{/number}","notifications_url":"https://api.github.com/repos/process-engine/documentation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/process-engine/documentation/labels{/name}","releases_url":"https://api.github.com/repos/process-engine/documentation/releases{/id}","deployments_url":"https://api.github.com/repos/process-engine/documentation/deployments","created_at":"2017-10-09T17:51:36Z","updated_at":"2018-10-11T07:33:49Z","pushed_at":"2018-10-12T08:20:44Z","git_url":"git://github.com/process-engine/documentation.git","ssh_url":"[email protected]:process-engine/documentation.git","clone_url":"https://github.com/process-engine/documentation.git","svn_url":"https://github.com/process-engine/documentation","homepage":"http://www.process-engine.io/documentation","size":297641,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":19,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/process-engine/documentation/pulls/147"},"html":{"href":"https://github.com/process-engine/documentation/pull/147"},"issue":{"href":"https://api.github.com/repos/process-engine/documentation/issues/147"},"comments":{"href":"https://api.github.com/repos/process-engine/documentation/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/process-engine/documentation/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/process-engine/documentation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/process-engine/documentation/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/process-engine/documentation/statuses/dd55828198b1445d56d17e73c0d50a0308b31389"}},"author_association":"CONTRIBUTOR"}}

8409841164

{"actor":{"display_login":"ElRaptorus"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/comments/208851944","pull_request_review_id":144745336,"id":208851944,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODg1MTk0NA==","diff_hunk":"@@ -1,43 +1,132 @@\n const pull = require('pull-stream')\n-const { h, Array: MutantArray, map, throttle, Value } = require('mutant')\n+pull.paramap = require('pull-paramap')\n+const { h, Array: MutantArray, computed, Value, when } = require('mutant')\n+const getContent = require('ssb-msg-content')\n+const isRequest = require('scuttle-dark-crystal/isRequest')\n+const isReply = require('scuttle-dark-crystal/isReply')\n+const sort = require('ssb-sort')\n \n // const DarkCrystalShowShard = require('./show')\n \n+const RECEIVED = 'received'\n+const REQUESTED = 'requested'\n+const REPLIED = 'replied'\n+\n function DarkCrystalFriendsIndex (opts) {\n const {\n avatar = identity,\n name = identity,\n scuttle\n } = opts\n \n- const shards = getShards()\n+ const store = {\n+ records: MutantArray([])\n+ }\n+ getRecords()\n+ watchForUpdates()\n+\n return h('DarkCrystalFriendsIndex', [\n- map(shards, Shard, { comparer })\n+ computed(store.records, records => {\n+ return records.map(Record)\n+ })\n ])\n \n- function Shard (msg) {\n- const show = Value(false)\n-\n- return h('div.shard', { 'ev-click': () => show.set(!show()) }, [\n- h('div.overview', [\n- h('div.avatar', avatar(msg.value.author)),\n- h('div.name', name(msg.value.author)),\n- h('div.received', new Date(msg.value.timestamp).toLocaleDateString())\n- ])\n- // when(show,\n- // DarkCrystalShowShard({ root: msg, scuttle })\n- // )\n- ])\n+ function Record ({ shard, requests, replies }) {\n+ const { author, timestamp } = shard.value\n+\n+ var state = RECEIVED\n+ if (requests.length) state = REQUESTED\n+ if (replies.length) state = REPLIED\n+\n+ // NOTE - it's possible to have replied without having received a request\n+ // I think being able to return a shard because you're about to lose your computer is important\n+ // At the moment this is hard to do because scuttle assumes an invite to be replying to ):\n+\n+ switch (state) {\n+ case RECEIVED:\n+ return h('div.shard -received', [\n+ h('div.avatar', avatar(author)),\n+ h('div.name', name(author)),\n+ h('button', { disabled: true }, 'Return Shard'), // TODO\n+ h('div.rts', new Date(timestamp).toLocaleDateString())\n+ ])\n+\n+ case REQUESTED:\n+ const returning = Value(false)\n+ const returnShard = () => {\n+ scuttle.recover.async.reply(requests[0], (err, data) => {\n+ if (err) throw err\n+\n+ console.log('shard returned', data)\n+ getRecords() // refresh the view\n+ })\n+ }\n+\n+ return h('div.shard -requested', [\n+ h('div.avatar', avatar(author)),\n+ h('div.name', name(author)),\n+ when(returning,\n+ h('div.info'),\n+ h('div.info', [\n+ h('i.fa.fa-warning'), ' - shard requested'\n+ ])\n+ ),\n+ when(returning,\n+ h('i.fa.fa-spinner.fa-pulse'),\n+ h('button -primary', { 'ev-click': returnShard }, 'Return Shard')\n+ ),\n+ h('div.rts', new Date(timestamp).toLocaleDateString())\n+ ])\n+\n+ case REPLIED:\n+ return h('div.shard -replied', [\n+ h('div.avatar', avatar(author)),\n+ h('div.name', name(author)),\n+ h('div.info', '(returned)'),\n+ h('div.rts', new Date(timestamp).toLocaleDateString())\n+ ])\n+ }\n }\n \n- function getShards () {\n- const store = MutantArray([])\n+ function getRecords () {\n pull(\n- scuttle.shard.pull.friends({ live: true }),\n+ scuttle.shard.pull.fromOthers({ reverse: true, live: false }),\n+ pull.paramap((shard, cb) => {","path":"views/others-shards/index.js","position":113,"original_position":113,"commit_id":"46009453818baccb5d130041e70b1bfc30f335f0","original_commit_id":"46009453818baccb5d130041e70b1bfc30f335f0","user":{"login":"KGibb8","id":17786217,"node_id":"MDQ6VXNlcjE3Nzg2MjE3","avatar_url":"https://avatars2.githubusercontent.com/u/17786217?v=4","gravatar_id":"","url":"https://api.github.com/users/KGibb8","html_url":"https://github.com/KGibb8","followers_url":"https://api.github.com/users/KGibb8/followers","following_url":"https://api.github.com/users/KGibb8/following{/other_user}","gists_url":"https://api.github.com/users/KGibb8/gists{/gist_id}","starred_url":"https://api.github.com/users/KGibb8/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KGibb8/subscriptions","organizations_url":"https://api.github.com/users/KGibb8/orgs","repos_url":"https://api.github.com/users/KGibb8/repos","events_url":"https://api.github.com/users/KGibb8/events{/privacy}","received_events_url":"https://api.github.com/users/KGibb8/received_events","type":"User","site_admin":false},"body":"I'm sure you've probably had to explain this before to me, but can you remind me what the difference is between `pull.paramap` and `pull.asyncMap`? I wouldn't know when to apply one and not the other. Noticing the comment `// width 3`, what does this mean too?","created_at":"2018-08-09T08:49:46Z","updated_at":"2018-08-09T08:49:46Z","html_url":"https://github.com/blockades/patchbay-dark-crystal/pull/8#discussion_r208851944","pull_request_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/comments/208851944"},"html":{"href":"https://github.com/blockades/patchbay-dark-crystal/pull/8#discussion_r208851944"},"pull_request":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/8","id":207191385,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MTkxMzg1","html_url":"https://github.com/blockades/patchbay-dark-crystal/pull/8","diff_url":"https://github.com/blockades/patchbay-dark-crystal/pull/8.diff","patch_url":"https://github.com/blockades/patchbay-dark-crystal/pull/8.patch","issue_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/8","number":8,"state":"open","locked":false,"title":"reply to requests!","user":{"login":"mixmix","id":2665886,"node_id":"MDQ6VXNlcjI2NjU4ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/2665886?v=4","gravatar_id":"","url":"https://api.github.com/users/mixmix","html_url":"https://github.com/mixmix","followers_url":"https://api.github.com/users/mixmix/followers","following_url":"https://api.github.com/users/mixmix/following{/other_user}","gists_url":"https://api.github.com/users/mixmix/gists{/gist_id}","starred_url":"https://api.github.com/users/mixmix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixmix/subscriptions","organizations_url":"https://api.github.com/users/mixmix/orgs","repos_url":"https://api.github.com/users/mixmix/repos","events_url":"https://api.github.com/users/mixmix/events{/privacy}","received_events_url":"https://api.github.com/users/mixmix/received_events","type":"User","site_admin":false},"body":null,"created_at":"2018-08-09T03:32:18Z","updated_at":"2018-08-09T08:49:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b827abcac261ba394fd01395702e5e2028386686","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/8/commits","review_comments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/8/comments","review_comment_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/8/comments","statuses_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/statuses/46009453818baccb5d130041e70b1bfc30f335f0","head":{"label":"blockades:reply_to_requests","ref":"reply_to_requests","sha":"46009453818baccb5d130041e70b1bfc30f335f0","user":{"login":"blockades","id":32723195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIzMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32723195?v=4","gravatar_id":"","url":"https://api.github.com/users/blockades","html_url":"https://github.com/blockades","followers_url":"https://api.github.com/users/blockades/followers","following_url":"https://api.github.com/users/blockades/following{/other_user}","gists_url":"https://api.github.com/users/blockades/gists{/gist_id}","starred_url":"https://api.github.com/users/blockades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockades/subscriptions","organizations_url":"https://api.github.com/users/blockades/orgs","repos_url":"https://api.github.com/users/blockades/repos","events_url":"https://api.github.com/users/blockades/events{/privacy}","received_events_url":"https://api.github.com/users/blockades/received_events","type":"Organization","site_admin":false},"repo":{"id":141201965,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMDE5NjU=","name":"patchbay-dark-crystal","full_name":"blockades/patchbay-dark-crystal","owner":{"login":"blockades","id":32723195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIzMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32723195?v=4","gravatar_id":"","url":"https://api.github.com/users/blockades","html_url":"https://github.com/blockades","followers_url":"https://api.github.com/users/blockades/followers","following_url":"https://api.github.com/users/blockades/following{/other_user}","gists_url":"https://api.github.com/users/blockades/gists{/gist_id}","starred_url":"https://api.github.com/users/blockades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockades/subscriptions","organizations_url":"https://api.github.com/users/blockades/orgs","repos_url":"https://api.github.com/users/blockades/repos","events_url":"https://api.github.com/users/blockades/events{/privacy}","received_events_url":"https://api.github.com/users/blockades/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockades/patchbay-dark-crystal","description":"a patchbay interface for dark-crystal (a scuttlebutt based secret sharing tool) ","fork":false,"url":"https://api.github.com/repos/blockades/patchbay-dark-crystal","forks_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/forks","keys_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/teams","hooks_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/hooks","issue_events_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/events{/number}","events_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/events","assignees_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/assignees{/user}","branches_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/branches{/branch}","tags_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/tags","blobs_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/languages","stargazers_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/stargazers","contributors_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/contributors","subscribers_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/subscribers","subscription_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/subscription","commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/contents/{+path}","compare_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/merges","archive_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/downloads","issues_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues{/number}","pulls_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/labels{/name}","releases_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/releases{/id}","deployments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/deployments","created_at":"2018-07-16T22:36:52Z","updated_at":"2018-08-08T09:10:02Z","pushed_at":"2018-08-09T06:43:41Z","git_url":"git://github.com/blockades/patchbay-dark-crystal.git","ssh_url":"[email protected]:blockades/patchbay-dark-crystal.git","clone_url":"https://github.com/blockades/patchbay-dark-crystal.git","svn_url":"https://github.com/blockades/patchbay-dark-crystal","homepage":"http://darkcrystal.pw","size":208,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"blockades:master","ref":"master","sha":"d6b9ff06dfaa3735c3573df7388b053b53d00f67","user":{"login":"blockades","id":32723195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIzMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32723195?v=4","gravatar_id":"","url":"https://api.github.com/users/blockades","html_url":"https://github.com/blockades","followers_url":"https://api.github.com/users/blockades/followers","following_url":"https://api.github.com/users/blockades/following{/other_user}","gists_url":"https://api.github.com/users/blockades/gists{/gist_id}","starred_url":"https://api.github.com/users/blockades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockades/subscriptions","organizations_url":"https://api.github.com/users/blockades/orgs","repos_url":"https://api.github.com/users/blockades/repos","events_url":"https://api.github.com/users/blockades/events{/privacy}","received_events_url":"https://api.github.com/users/blockades/received_events","type":"Organization","site_admin":false},"repo":{"id":141201965,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyMDE5NjU=","name":"patchbay-dark-crystal","full_name":"blockades/patchbay-dark-crystal","owner":{"login":"blockades","id":32723195,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyNzIzMTk1","avatar_url":"https://avatars1.githubusercontent.com/u/32723195?v=4","gravatar_id":"","url":"https://api.github.com/users/blockades","html_url":"https://github.com/blockades","followers_url":"https://api.github.com/users/blockades/followers","following_url":"https://api.github.com/users/blockades/following{/other_user}","gists_url":"https://api.github.com/users/blockades/gists{/gist_id}","starred_url":"https://api.github.com/users/blockades/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockades/subscriptions","organizations_url":"https://api.github.com/users/blockades/orgs","repos_url":"https://api.github.com/users/blockades/repos","events_url":"https://api.github.com/users/blockades/events{/privacy}","received_events_url":"https://api.github.com/users/blockades/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockades/patchbay-dark-crystal","description":"a patchbay interface for dark-crystal (a scuttlebutt based secret sharing tool) ","fork":false,"url":"https://api.github.com/repos/blockades/patchbay-dark-crystal","forks_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/forks","keys_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/teams","hooks_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/hooks","issue_events_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/events{/number}","events_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/events","assignees_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/assignees{/user}","branches_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/branches{/branch}","tags_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/tags","blobs_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/statuses/{sha}","languages_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/languages","stargazers_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/stargazers","contributors_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/contributors","subscribers_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/subscribers","subscription_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/subscription","commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/contents/{+path}","compare_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/merges","archive_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/downloads","issues_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues{/number}","pulls_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls{/number}","milestones_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/milestones{/number}","notifications_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/labels{/name}","releases_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/releases{/id}","deployments_url":"https://api.github.com/repos/blockades/patchbay-dark-crystal/deployments","created_at":"2018-07-16T22:36:52Z","updated_at":"2018-08-08T09:10:02Z","pushed_at":"2018-08-09T06:43:41Z","git_url":"git://github.com/blockades/patchbay-dark-crystal.git","ssh_url":"[email protected]:blockades/patchbay-dark-crystal.git","clone_url":"https://github.com/blockades/patchbay-dark-crystal.git","svn_url":"https://github.com/blockades/patchbay-dark-crystal","homepage":"http://darkcrystal.pw","size":208,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/8"},"html":{"href":"https://github.com/blockades/patchbay-dark-crystal/pull/8"},"issue":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/8"},"comments":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/blockades/patchbay-dark-crystal/statuses/46009453818baccb5d130041e70b1bfc30f335f0"}},"author_association":"MEMBER"}}

8088795299

{"actor":{"display_login":"KGibb8"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/singnet/snet-cli/pulls/comments/200800907","pull_request_review_id":135191966,"id":200800907,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgwMDkwNw==","diff_hunk":"@@ -123,6 +124,18 @@ def walk_imports(entry_path):\n return seen_paths\n \n \n+def get_contract_json(interface_path, implementation_path=None):","path":"snet_cli/utils.py","position":null,"original_position":10,"commit_id":"91a376da6e6f67170421c7dd45da4ec5a51a0860","original_commit_id":"0fb157b8a3830c266cb1081aac37aeff3122ee38","user":{"login":"vforvalerio87","id":10940962,"node_id":"MDQ6VXNlcjEwOTQwOTYy","avatar_url":"https://avatars3.githubusercontent.com/u/10940962?v=4","gravatar_id":"","url":"https://api.github.com/users/vforvalerio87","html_url":"https://github.com/vforvalerio87","followers_url":"https://api.github.com/users/vforvalerio87/followers","following_url":"https://api.github.com/users/vforvalerio87/following{/other_user}","gists_url":"https://api.github.com/users/vforvalerio87/gists{/gist_id}","starred_url":"https://api.github.com/users/vforvalerio87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vforvalerio87/subscriptions","organizations_url":"https://api.github.com/users/vforvalerio87/orgs","repos_url":"https://api.github.com/users/vforvalerio87/repos","events_url":"https://api.github.com/users/vforvalerio87/events{/privacy}","received_events_url":"https://api.github.com/users/vforvalerio87/received_events","type":"User","site_admin":false},"body":"Killed: this function was unnecessary","created_at":"2018-07-07T03:14:01Z","updated_at":"2018-07-07T03:14:01Z","html_url":"https://github.com/singnet/snet-cli/pull/19#discussion_r200800907","pull_request_url":"https://api.github.com/repos/singnet/snet-cli/pulls/19","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/singnet/snet-cli/pulls/comments/200800907"},"html":{"href":"https://github.com/singnet/snet-cli/pull/19#discussion_r200800907"},"pull_request":{"href":"https://api.github.com/repos/singnet/snet-cli/pulls/19"}},"in_reply_to_id":200766978},"pull_request":{"url":"https://api.github.com/repos/singnet/snet-cli/pulls/19","id":199832078,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODMyMDc4","html_url":"https://github.com/singnet/snet-cli/pull/19","diff_url":"https://github.com/singnet/snet-cli/pull/19.diff","patch_url":"https://github.com/singnet/snet-cli/pull/19.patch","issue_url":"https://api.github.com/repos/singnet/snet-cli/issues/19","number":19,"state":"open","locked":false,"title":"Modified service commands to work with new Registry","user":{"login":"vforvalerio87","id":10940962,"node_id":"MDQ6VXNlcjEwOTQwOTYy","avatar_url":"https://avatars3.githubusercontent.com/u/10940962?v=4","gravatar_id":"","url":"https://api.github.com/users/vforvalerio87","html_url":"https://github.com/vforvalerio87","followers_url":"https://api.github.com/users/vforvalerio87/followers","following_url":"https://api.github.com/users/vforvalerio87/following{/other_user}","gists_url":"https://api.github.com/users/vforvalerio87/gists{/gist_id}","starred_url":"https://api.github.com/users/vforvalerio87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vforvalerio87/subscriptions","organizations_url":"https://api.github.com/users/vforvalerio87/orgs","repos_url":"https://api.github.com/users/vforvalerio87/repos","events_url":"https://api.github.com/users/vforvalerio87/events{/privacy}","received_events_url":"https://api.github.com/users/vforvalerio87/received_events","type":"User","site_admin":false},"body":"modified init, publish and update arguments and commands to use the new Registry contract.\r\n\r\nNote: this PR assumes only one contract is provided; in case a contract has an interface and an implementation, only the json for the implementation contract has to be provided.","created_at":"2018-07-06T19:42:32Z","updated_at":"2018-07-07T03:14:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d275cfc868d356ac8af8bb6c12679dfa0f02280","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/singnet/snet-cli/pulls/19/commits","review_comments_url":"https://api.github.com/repos/singnet/snet-cli/pulls/19/comments","review_comment_url":"https://api.github.com/repos/singnet/snet-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/singnet/snet-cli/issues/19/comments","statuses_url":"https://api.github.com/repos/singnet/snet-cli/statuses/91a376da6e6f67170421c7dd45da4ec5a51a0860","head":{"label":"vforvalerio87:master","ref":"master","sha":"91a376da6e6f67170421c7dd45da4ec5a51a0860","user":{"login":"vforvalerio87","id":10940962,"node_id":"MDQ6VXNlcjEwOTQwOTYy","avatar_url":"https://avatars3.githubusercontent.com/u/10940962?v=4","gravatar_id":"","url":"https://api.github.com/users/vforvalerio87","html_url":"https://github.com/vforvalerio87","followers_url":"https://api.github.com/users/vforvalerio87/followers","following_url":"https://api.github.com/users/vforvalerio87/following{/other_user}","gists_url":"https://api.github.com/users/vforvalerio87/gists{/gist_id}","starred_url":"https://api.github.com/users/vforvalerio87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vforvalerio87/subscriptions","organizations_url":"https://api.github.com/users/vforvalerio87/orgs","repos_url":"https://api.github.com/users/vforvalerio87/repos","events_url":"https://api.github.com/users/vforvalerio87/events{/privacy}","received_events_url":"https://api.github.com/users/vforvalerio87/received_events","type":"User","site_admin":false},"repo":{"id":134476775,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ0NzY3NzU=","name":"snet-cli","full_name":"vforvalerio87/snet-cli","owner":{"login":"vforvalerio87","id":10940962,"node_id":"MDQ6VXNlcjEwOTQwOTYy","avatar_url":"https://avatars3.githubusercontent.com/u/10940962?v=4","gravatar_id":"","url":"https://api.github.com/users/vforvalerio87","html_url":"https://github.com/vforvalerio87","followers_url":"https://api.github.com/users/vforvalerio87/followers","following_url":"https://api.github.com/users/vforvalerio87/following{/other_user}","gists_url":"https://api.github.com/users/vforvalerio87/gists{/gist_id}","starred_url":"https://api.github.com/users/vforvalerio87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vforvalerio87/subscriptions","organizations_url":"https://api.github.com/users/vforvalerio87/orgs","repos_url":"https://api.github.com/users/vforvalerio87/repos","events_url":"https://api.github.com/users/vforvalerio87/events{/privacy}","received_events_url":"https://api.github.com/users/vforvalerio87/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vforvalerio87/snet-cli","description":"SingularityNET CLI for interacting with SNET blockchain contracts and deployed services.","fork":true,"url":"https://api.github.com/repos/vforvalerio87/snet-cli","forks_url":"https://api.github.com/repos/vforvalerio87/snet-cli/forks","keys_url":"https://api.github.com/repos/vforvalerio87/snet-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vforvalerio87/snet-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vforvalerio87/snet-cli/teams","hooks_url":"https://api.github.com/repos/vforvalerio87/snet-cli/hooks","issue_events_url":"https://api.github.com/repos/vforvalerio87/snet-cli/issues/events{/number}","events_url":"https://api.github.com/repos/vforvalerio87/snet-cli/events","assignees_url":"https://api.github.com/repos/vforvalerio87/snet-cli/assignees{/user}","branches_url":"https://api.github.com/repos/vforvalerio87/snet-cli/branches{/branch}","tags_url":"https://api.github.com/repos/vforvalerio87/snet-cli/tags","blobs_url":"https://api.github.com/repos/vforvalerio87/snet-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vforvalerio87/snet-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vforvalerio87/snet-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/vforvalerio87/snet-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vforvalerio87/snet-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/vforvalerio87/snet-cli/languages","stargazers_url":"https://api.github.com/repos/vforvalerio87/snet-cli/stargazers","contributors_url":"https://api.github.com/repos/vforvalerio87/snet-cli/contributors","subscribers_url":"https://api.github.com/repos/vforvalerio87/snet-cli/subscribers","subscription_url":"https://api.github.com/repos/vforvalerio87/snet-cli/subscription","commits_url":"https://api.github.com/repos/vforvalerio87/snet-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/vforvalerio87/snet-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/vforvalerio87/snet-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/vforvalerio87/snet-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/vforvalerio87/snet-cli/contents/{+path}","compare_url":"https://api.github.com/repos/vforvalerio87/snet-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vforvalerio87/snet-cli/merges","archive_url":"https://api.github.com/repos/vforvalerio87/snet-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vforvalerio87/snet-cli/downloads","issues_url":"https://api.github.com/repos/vforvalerio87/snet-cli/issues{/number}","pulls_url":"https://api.github.com/repos/vforvalerio87/snet-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/vforvalerio87/snet-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/vforvalerio87/snet-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vforvalerio87/snet-cli/labels{/name}","releases_url":"https://api.github.com/repos/vforvalerio87/snet-cli/releases{/id}","deployments_url":"https://api.github.com/repos/vforvalerio87/snet-cli/deployments","created_at":"2018-05-22T21:15:28Z","updated_at":"2018-07-07T03:05:44Z","pushed_at":"2018-07-07T03:05:42Z","git_url":"git://github.com/vforvalerio87/snet-cli.git","ssh_url":"[email protected]:vforvalerio87/snet-cli.git","clone_url":"https://github.com/vforvalerio87/snet-cli.git","svn_url":"https://github.com/vforvalerio87/snet-cli","homepage":"","size":89,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"singnet:master","ref":"master","sha":"d9e0bf168d62228858a5ca8a3fe238cdec2a23b4","user":{"login":"singnet","id":32847093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODQ3MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/32847093?v=4","gravatar_id":"","url":"https://api.github.com/users/singnet","html_url":"https://github.com/singnet","followers_url":"https://api.github.com/users/singnet/followers","following_url":"https://api.github.com/users/singnet/following{/other_user}","gists_url":"https://api.github.com/users/singnet/gists{/gist_id}","starred_url":"https://api.github.com/users/singnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singnet/subscriptions","organizations_url":"https://api.github.com/users/singnet/orgs","repos_url":"https://api.github.com/users/singnet/repos","events_url":"https://api.github.com/users/singnet/events{/privacy}","received_events_url":"https://api.github.com/users/singnet/received_events","type":"Organization","site_admin":false},"repo":{"id":131075650,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEwNzU2NTA=","name":"snet-cli","full_name":"singnet/snet-cli","owner":{"login":"singnet","id":32847093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyODQ3MDkz","avatar_url":"https://avatars0.githubusercontent.com/u/32847093?v=4","gravatar_id":"","url":"https://api.github.com/users/singnet","html_url":"https://github.com/singnet","followers_url":"https://api.github.com/users/singnet/followers","following_url":"https://api.github.com/users/singnet/following{/other_user}","gists_url":"https://api.github.com/users/singnet/gists{/gist_id}","starred_url":"https://api.github.com/users/singnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/singnet/subscriptions","organizations_url":"https://api.github.com/users/singnet/orgs","repos_url":"https://api.github.com/users/singnet/repos","events_url":"https://api.github.com/users/singnet/events{/privacy}","received_events_url":"https://api.github.com/users/singnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/singnet/snet-cli","description":"SingularityNET CLI for interacting with SNET blockchain contracts and deployed services.","fork":false,"url":"https://api.github.com/repos/singnet/snet-cli","forks_url":"https://api.github.com/repos/singnet/snet-cli/forks","keys_url":"https://api.github.com/repos/singnet/snet-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/singnet/snet-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/singnet/snet-cli/teams","hooks_url":"https://api.github.com/repos/singnet/snet-cli/hooks","issue_events_url":"https://api.github.com/repos/singnet/snet-cli/issues/events{/number}","events_url":"https://api.github.com/repos/singnet/snet-cli/events","assignees_url":"https://api.github.com/repos/singnet/snet-cli/assignees{/user}","branches_url":"https://api.github.com/repos/singnet/snet-cli/branches{/branch}","tags_url":"https://api.github.com/repos/singnet/snet-cli/tags","blobs_url":"https://api.github.com/repos/singnet/snet-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/singnet/snet-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/singnet/snet-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/singnet/snet-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/singnet/snet-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/singnet/snet-cli/languages","stargazers_url":"https://api.github.com/repos/singnet/snet-cli/stargazers","contributors_url":"https://api.github.com/repos/singnet/snet-cli/contributors","subscribers_url":"https://api.github.com/repos/singnet/snet-cli/subscribers","subscription_url":"https://api.github.com/repos/singnet/snet-cli/subscription","commits_url":"https://api.github.com/repos/singnet/snet-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/singnet/snet-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/singnet/snet-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/singnet/snet-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/singnet/snet-cli/contents/{+path}","compare_url":"https://api.github.com/repos/singnet/snet-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/singnet/snet-cli/merges","archive_url":"https://api.github.com/repos/singnet/snet-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/singnet/snet-cli/downloads","issues_url":"https://api.github.com/repos/singnet/snet-cli/issues{/number}","pulls_url":"https://api.github.com/repos/singnet/snet-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/singnet/snet-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/singnet/snet-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/singnet/snet-cli/labels{/name}","releases_url":"https://api.github.com/repos/singnet/snet-cli/releases{/id}","deployments_url":"https://api.github.com/repos/singnet/snet-cli/deployments","created_at":"2018-04-25T23:45:42Z","updated_at":"2018-07-06T21:28:26Z","pushed_at":"2018-07-07T03:05:43Z","git_url":"git://github.com/singnet/snet-cli.git","ssh_url":"[email protected]:singnet/snet-cli.git","clone_url":"https://github.com/singnet/snet-cli.git","svn_url":"https://github.com/singnet/snet-cli","homepage":"","size":84,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":5,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/singnet/snet-cli/pulls/19"},"html":{"href":"https://github.com/singnet/snet-cli/pull/19"},"issue":{"href":"https://api.github.com/repos/singnet/snet-cli/issues/19"},"comments":{"href":"https://api.github.com/repos/singnet/snet-cli/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/singnet/snet-cli/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/singnet/snet-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/singnet/snet-cli/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/singnet/snet-cli/statuses/91a376da6e6f67170421c7dd45da4ec5a51a0860"}},"author_association":"CONTRIBUTOR"}}

7931664161

{"actor":{"display_login":"vforvalerio87"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/comments/174671587","pull_request_review_id":104065151,"id":174671587,"diff_hunk":"@@ -9,57 +9,141 @@\n import json\r\n \r\n poi1 = {\r\n- '_id' = 1\r\n 'name': 'Himalayan Chimney',\r\n- 'date': 'Date(2018, 2, 27)',\r\n+ 'date': '2018-02-02',\r\n 'description': 'Yum',\r\n 'map_year': 2018,\r\n 'x_coord': 12,\r\n 'y_coord': 43\r\n }\r\n \r\n poi2 = {\r\n- '_id' = 2\r\n 'name': 'Mount Everest',\r\n- 'date': 'Date(2018, 5, 15)',\r\n+ 'date': '2018-05-15',\r\n 'description': 'Snow',\r\n 'map_year': 2018,\r\n 'x_coord': 15,\r\n 'y_coord': 30\r\n }\r\n \r\n poi3 = {\r\n- '_id' = 3\r\n 'name': 'Tampa Bay',\r\n- 'date': 'Date(2018, 8, 3)',\r\n+ 'date': '2018-08-03',\r\n 'description': 'Hot',\r\n 'map_year': 2018,\r\n 'x_coord': 50,\r\n 'y_coord': 82\r\n }\r\n \r\n-stories = [\r\n- {\r\n- '_id': 21,\r\n- 'story_name': 'Angad Goes to Wisconsin',\r\n- },\r\n- {\r\n- '_id': 22,\r\n- 'story_name': 'Amanda Takes her Medicine',\r\n- },\r\n- {\r\n- '_id': 23,\r\n- 'story_name': 'Jeffy Goes to Fashion Show',\r\n- },\r\n- {\r\n- '_id': 24,\r\n- 'story_name': 'Time for Hack4Impact',\r\n- }\r\n-]\r\n- \r\n- \r\n- story = {\r\n- '_id': 25\r\n+story_with_no_pois = {\r\n 'story_name' : 'Jeffy Discovers the Dark side of the Moon'\r\n }\r\n \r\n+story_with_pois = {\r\n+ 'story_name' : 'Angad Goes to Wisconsin',\r\n+ 'poi_ids' : []\r\n+}\r\n+\r\n+story_edit = {\r\n+ 'story_name': 'Time for Hugs4Infants'\r\n+}\r\n+\r\n+story_empty = {\r\n+\r\n+}\r\n+\r\n+\r\n+os.environ['STORY_ID_1'] = '1' # this one doesn't have pois\r\n+os.environ['STORY_ID_2'] = '2' # this one has the pois\r\n+os.environ['POI_ID_1'] = '1'\r\n+os.environ['POI_ID_2'] = '2'\r\n+\r\n+class POITests(unittest.TestCase):\r\n+\r\n+ def test1_post_story(self):\r\n+ r = requests.post('http://127.0.0.1:5000/stories', json=story_with_no_pois)\r\n+ response = r.json()\r\n+ self.assertEqual(response['code'], 201)\r\n+ self.assertEqual(response['result']['story']['story_name'], story_with_no_pois['story_name'])\r\n+ os.environ['STORY_ID_1'] = str(response['result']['story']['_id'])\r\n+\r\n+ def test2_post_story_with_pois(self):\r\n+ r = requests.post('http://127.0.0.1:5000/pois', json=poi1)\r\n+ response = r.json()\r\n+ story_with_pois['poi_ids'].append(response['result']['poi']['_id'])\r\n+ os.environ['POI_ID_1'] = str(response['result']['poi']['_id'])\r\n+ r = requests.post('http://127.0.0.1:5000/pois', json=poi2)\r\n+ response = r.json()\r\n+ story_with_pois['poi_ids'].append(response['result']['poi']['_id'])\r\n+ os.environ['POI_ID_2'] = str(response['result']['poi']['_id'])\r\n+ r = requests.post('http://127.0.0.1:5000/stories', json=story_with_pois)\r\n+ response = r.json()\r\n+ self.assertEqual(response['code'], 201)\r\n+ self.assertEqual(response['result']['story']['story_name'], story_with_pois['story_name'])\r\n+ os.environ['STORY_ID_2'] = str(response['result']['story']['_id'])\r\n+\r\n+ def test3_get_stories(self):\r\n+ # GET with no parameters\r\n+ story_id_1 = int(os.environ.get('STORY_ID_1'))\r\n+ story_id_2 = int(os.environ.get('STORY_ID_2'))\r\n+ r = requests.get('http://127.0.0.1:5000/stories')\r\n+ response = r.json()\r\n+ self.assertEqual(response['code'], 200)\r\n+ story = next((s for s in response['result']['stories'] if s['_id'] == story_id_1), None)\r\n+ self.assertEqual(story['story_name'], story_with_no_pois['story_name'])\r\n+ story = next((s for s in response['result']['stories'] if s['_id'] == story_id_2), None)\r\n+ self.assertEqual(story['story_name'], story_with_pois['story_name'])\r\n+\r\n+ def test4_get_stories(self):\r\n+ # GET with poi_id parameter\r\n+ story_id_2 = int(os.environ.get('STORY_ID_2'))\r\n+ poi_id_1 = int(os.environ.get('POI_ID_1'))\r\n+ poi_id_2 = int(os.environ.get('POI_ID_2'))\r\n+ r = requests.get('http://127.0.0.1:5000/stories?poi_id={}'.format(poi_id_1))\r\n+ response = r.json()\r\n+ self.assertEqual(response['code'], 200)\r\n+ story = next((s for s in response['result']['stories'] if s['_id'] == story_id_2), None)\r\n+ self.assertEqual(story['story_name'], story_with_pois['story_name'])\r\n+ r = requests.get('http://127.0.0.1:5000/stories?poi_id={}'.format(poi_id_2))\r\n+ response = r.json()\r\n+ self.assertEqual(response['code'], 200)\r\n+ story = next((s for s in response['result']['stories'] if s['_id'] == story_id_2), None)\r\n+ self.assertEqual(story['story_name'], story_with_pois['story_name'])\r\n+\r\n+ def test5_put_stories(self):\r\n+ # PUT with new story name\r\n+ story_id_1 = int(os.environ.get('STORY_ID_1'))\r\n+ r = requests.put('http://127.0.0.1:5000/stories/{}'.format(story_id_1), json=story_edit)\r\n+ response_put = r.json()\r\n+ self.assertEqual(response_put['code'], 200)\r\n+ r = requests.get('http://127.0.0.1:5000/stories')\r\n+ response_get = r.json()\r\n+ story = next((s for s in response_get['result']['stories'] if s['_id'] == story_id_1), None)\r\n+ self.assertEqual(story['story_name'], story_edit['story_name'])\r\n+\r\n+ def test6_put_stories(self):\r\n+ # PUT with blank payload\r\n+ story_id_1 = int(os.environ.get('STORY_ID_1'))\r\n+ r = requests.put('http://127.0.0.1:5000/stories/{}'.format(story_id_1), json=story_empty)\r\n+ response_put = r.json()\r\n+ self.assertEqual(response_put['code'], 200)\r\n+ r = requests.get('http://127.0.0.1:5000/stories')\r\n+ response_get = r.json()\r\n+ story = next((s for s in response_get['result']['stories'] if s['_id'] == story_id_1), None)\r\n+ self.assertEqual(story['story_name'], story_edit['story_name'])\r\n+\r\n+ def test7_delete_stories(self):\r\n+ story_id_1 = int(os.environ.get('STORY_ID_1'))\r\n+ story_id_2 = int(os.environ.get('STORY_ID_2'))\r\n+ r = requests.delete('http://127.0.0.1:5000/stories/{}'.format(story_id_1))\r\n+ response_put = r.json()\r\n+ self.assertEqual(response_put['code'], 200)\r\n+ r = requests.delete('http://127.0.0.1:5000/stories/{}'.format(story_id_2))\r\n+ response_put = r.json()\r\n+ self.assertEqual(response_put['code'], 200)\r\n+ r = requests.get('http://127.0.0.1:5000/stories')\r\n+ response = r.json()\r\n+ story = next((s for s in response['result']['stories'] if s['_id'] == story_id_1), None)\r\n+ self.assertEqual(story, None)\r\n+ story = next((s for s in response['result']['stories'] if s['_id'] == story_id_2), None)\r\n+ self.assertEqual(story, None)\r","path":"tests/test_stories.py","position":169,"original_position":169,"commit_id":"673bccea6c4a8abda97f2abf33bfa088f99d8be5","original_commit_id":"673bccea6c4a8abda97f2abf33bfa088f99d8be5","user":{"login":"vrunjeti","id":6979696,"avatar_url":"https://avatars2.githubusercontent.com/u/6979696?v=4","gravatar_id":"","url":"https://api.github.com/users/vrunjeti","html_url":"https://github.com/vrunjeti","followers_url":"https://api.github.com/users/vrunjeti/followers","following_url":"https://api.github.com/users/vrunjeti/following{/other_user}","gists_url":"https://api.github.com/users/vrunjeti/gists{/gist_id}","starred_url":"https://api.github.com/users/vrunjeti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vrunjeti/subscriptions","organizations_url":"https://api.github.com/users/vrunjeti/orgs","repos_url":"https://api.github.com/users/vrunjeti/repos","events_url":"https://api.github.com/users/vrunjeti/events{/privacy}","received_events_url":"https://api.github.com/users/vrunjeti/received_events","type":"User","site_admin":false},"body":"might also be good to have a test that tries to delete a nonexistent story, which checks if it returns a 404","created_at":"2018-03-15T03:58:41Z","updated_at":"2018-03-15T04:00:25Z","html_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2/pull/31#discussion_r174671587","pull_request_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/31","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/comments/174671587"},"html":{"href":"https://github.com/hack4impact-uiuc/nnb-backend-v2/pull/31#discussion_r174671587"},"pull_request":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/31","id":174272305,"html_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2/pull/31","diff_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2/pull/31.diff","patch_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2/pull/31.patch","issue_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues/31","number":31,"state":"open","locked":false,"title":"Stories Tests","user":{"login":"wangworks","id":13527969,"avatar_url":"https://avatars2.githubusercontent.com/u/13527969?v=4","gravatar_id":"","url":"https://api.github.com/users/wangworks","html_url":"https://github.com/wangworks","followers_url":"https://api.github.com/users/wangworks/followers","following_url":"https://api.github.com/users/wangworks/following{/other_user}","gists_url":"https://api.github.com/users/wangworks/gists{/gist_id}","starred_url":"https://api.github.com/users/wangworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangworks/subscriptions","organizations_url":"https://api.github.com/users/wangworks/orgs","repos_url":"https://api.github.com/users/wangworks/repos","events_url":"https://api.github.com/users/wangworks/events{/privacy}","received_events_url":"https://api.github.com/users/wangworks/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-12T04:52:46Z","updated_at":"2018-03-15T04:00:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0f694b721361f25644db06b952c775f22ccd1b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/31/commits","review_comments_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/31/comments","review_comment_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues/31/comments","statuses_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/statuses/673bccea6c4a8abda97f2abf33bfa088f99d8be5","head":{"label":"hack4impact-uiuc:stories-endpoints","ref":"stories-endpoints","sha":"673bccea6c4a8abda97f2abf33bfa088f99d8be5","user":{"login":"hack4impact-uiuc","id":32913348,"avatar_url":"https://avatars1.githubusercontent.com/u/32913348?v=4","gravatar_id":"","url":"https://api.github.com/users/hack4impact-uiuc","html_url":"https://github.com/hack4impact-uiuc","followers_url":"https://api.github.com/users/hack4impact-uiuc/followers","following_url":"https://api.github.com/users/hack4impact-uiuc/following{/other_user}","gists_url":"https://api.github.com/users/hack4impact-uiuc/gists{/gist_id}","starred_url":"https://api.github.com/users/hack4impact-uiuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hack4impact-uiuc/subscriptions","organizations_url":"https://api.github.com/users/hack4impact-uiuc/orgs","repos_url":"https://api.github.com/users/hack4impact-uiuc/repos","events_url":"https://api.github.com/users/hack4impact-uiuc/events{/privacy}","received_events_url":"https://api.github.com/users/hack4impact-uiuc/received_events","type":"Organization","site_admin":false},"repo":{"id":122602807,"name":"nnb-backend-v2","full_name":"hack4impact-uiuc/nnb-backend-v2","owner":{"login":"hack4impact-uiuc","id":32913348,"avatar_url":"https://avatars1.githubusercontent.com/u/32913348?v=4","gravatar_id":"","url":"https://api.github.com/users/hack4impact-uiuc","html_url":"https://github.com/hack4impact-uiuc","followers_url":"https://api.github.com/users/hack4impact-uiuc/followers","following_url":"https://api.github.com/users/hack4impact-uiuc/following{/other_user}","gists_url":"https://api.github.com/users/hack4impact-uiuc/gists{/gist_id}","starred_url":"https://api.github.com/users/hack4impact-uiuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hack4impact-uiuc/subscriptions","organizations_url":"https://api.github.com/users/hack4impact-uiuc/orgs","repos_url":"https://api.github.com/users/hack4impact-uiuc/repos","events_url":"https://api.github.com/users/hack4impact-uiuc/events{/privacy}","received_events_url":"https://api.github.com/users/hack4impact-uiuc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2","description":null,"fork":false,"url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2","forks_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/forks","keys_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/teams","hooks_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/hooks","issue_events_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues/events{/number}","events_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/events","assignees_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/assignees{/user}","branches_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/branches{/branch}","tags_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/tags","blobs_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/languages","stargazers_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/stargazers","contributors_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/contributors","subscribers_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/subscribers","subscription_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/subscription","commits_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/contents/{+path}","compare_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/merges","archive_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/downloads","issues_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues{/number}","pulls_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/labels{/name}","releases_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/releases{/id}","deployments_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/deployments","created_at":"2018-02-23T09:48:42Z","updated_at":"2018-03-12T22:33:37Z","pushed_at":"2018-03-15T03:47:57Z","git_url":"git://github.com/hack4impact-uiuc/nnb-backend-v2.git","ssh_url":"[email protected]:hack4impact-uiuc/nnb-backend-v2.git","clone_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2.git","svn_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2","homepage":null,"size":101,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"base":{"label":"hack4impact-uiuc:master","ref":"master","sha":"6a0a6a79a9a068c7fcdebc9d7301bf513995dd8c","user":{"login":"hack4impact-uiuc","id":32913348,"avatar_url":"https://avatars1.githubusercontent.com/u/32913348?v=4","gravatar_id":"","url":"https://api.github.com/users/hack4impact-uiuc","html_url":"https://github.com/hack4impact-uiuc","followers_url":"https://api.github.com/users/hack4impact-uiuc/followers","following_url":"https://api.github.com/users/hack4impact-uiuc/following{/other_user}","gists_url":"https://api.github.com/users/hack4impact-uiuc/gists{/gist_id}","starred_url":"https://api.github.com/users/hack4impact-uiuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hack4impact-uiuc/subscriptions","organizations_url":"https://api.github.com/users/hack4impact-uiuc/orgs","repos_url":"https://api.github.com/users/hack4impact-uiuc/repos","events_url":"https://api.github.com/users/hack4impact-uiuc/events{/privacy}","received_events_url":"https://api.github.com/users/hack4impact-uiuc/received_events","type":"Organization","site_admin":false},"repo":{"id":122602807,"name":"nnb-backend-v2","full_name":"hack4impact-uiuc/nnb-backend-v2","owner":{"login":"hack4impact-uiuc","id":32913348,"avatar_url":"https://avatars1.githubusercontent.com/u/32913348?v=4","gravatar_id":"","url":"https://api.github.com/users/hack4impact-uiuc","html_url":"https://github.com/hack4impact-uiuc","followers_url":"https://api.github.com/users/hack4impact-uiuc/followers","following_url":"https://api.github.com/users/hack4impact-uiuc/following{/other_user}","gists_url":"https://api.github.com/users/hack4impact-uiuc/gists{/gist_id}","starred_url":"https://api.github.com/users/hack4impact-uiuc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hack4impact-uiuc/subscriptions","organizations_url":"https://api.github.com/users/hack4impact-uiuc/orgs","repos_url":"https://api.github.com/users/hack4impact-uiuc/repos","events_url":"https://api.github.com/users/hack4impact-uiuc/events{/privacy}","received_events_url":"https://api.github.com/users/hack4impact-uiuc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2","description":null,"fork":false,"url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2","forks_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/forks","keys_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/teams","hooks_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/hooks","issue_events_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues/events{/number}","events_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/events","assignees_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/assignees{/user}","branches_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/branches{/branch}","tags_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/tags","blobs_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/refs{/sha}","trees_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/statuses/{sha}","languages_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/languages","stargazers_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/stargazers","contributors_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/contributors","subscribers_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/subscribers","subscription_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/subscription","commits_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/commits{/sha}","git_commits_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/git/commits{/sha}","comments_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/comments{/number}","issue_comment_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues/comments{/number}","contents_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/contents/{+path}","compare_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/merges","archive_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/downloads","issues_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues{/number}","pulls_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls{/number}","milestones_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/milestones{/number}","notifications_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/labels{/name}","releases_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/releases{/id}","deployments_url":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/deployments","created_at":"2018-02-23T09:48:42Z","updated_at":"2018-03-12T22:33:37Z","pushed_at":"2018-03-15T03:47:57Z","git_url":"git://github.com/hack4impact-uiuc/nnb-backend-v2.git","ssh_url":"[email protected]:hack4impact-uiuc/nnb-backend-v2.git","clone_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2.git","svn_url":"https://github.com/hack4impact-uiuc/nnb-backend-v2","homepage":null,"size":101,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":9,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/31"},"html":{"href":"https://github.com/hack4impact-uiuc/nnb-backend-v2/pull/31"},"issue":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues/31"},"comments":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/hack4impact-uiuc/nnb-backend-v2/statuses/673bccea6c4a8abda97f2abf33bfa088f99d8be5"}},"author_association":"CONTRIBUTOR"}}

7382315763

{"actor":{"display_login":"vrunjeti"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/comments/173229248","pull_request_review_id":102384508,"id":173229248,"diff_hunk":"@@ -0,0 +1,49 @@\n+package com.danielfireman.gci;\n+\n+import java.util.concurrent.atomic.AtomicInteger;\n+\n+public class Sampler {\n+\t// Default sample rate should be fairly small, so big requests get checked up quickly.\n+\tprivate final int DEFAULT_SAMPLE_RATE = 10; // TODO(David) Update this value, if needed","path":"gci/src/main/java/com/danielfireman/gci/Sampler.java","position":7,"original_position":7,"commit_id":"1251d5d69773cd8ffb85a7188389497335eabcf0","original_commit_id":"1251d5d69773cd8ffb85a7188389497335eabcf0","user":{"login":"dfquaresma","id":26947413,"avatar_url":"https://avatars1.githubusercontent.com/u/26947413?v=4","gravatar_id":"","url":"https://api.github.com/users/dfquaresma","html_url":"https://github.com/dfquaresma","followers_url":"https://api.github.com/users/dfquaresma/followers","following_url":"https://api.github.com/users/dfquaresma/following{/other_user}","gists_url":"https://api.github.com/users/dfquaresma/gists{/gist_id}","starred_url":"https://api.github.com/users/dfquaresma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfquaresma/subscriptions","organizations_url":"https://api.github.com/users/dfquaresma/orgs","repos_url":"https://api.github.com/users/dfquaresma/repos","events_url":"https://api.github.com/users/dfquaresma/events{/privacy}","received_events_url":"https://api.github.com/users/dfquaresma/received_events","type":"User","site_admin":false},"body":"What is different? The value?","created_at":"2018-03-08T17:22:22Z","updated_at":"2018-03-08T17:22:22Z","html_url":"https://github.com/gcinterceptor/gci-java/pull/1#discussion_r173229248","pull_request_url":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/comments/173229248"},"html":{"href":"https://github.com/gcinterceptor/gci-java/pull/1#discussion_r173229248"},"pull_request":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/1"}},"in_reply_to_id":173224778},"pull_request":{"url":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/1","id":173793722,"html_url":"https://github.com/gcinterceptor/gci-java/pull/1","diff_url":"https://github.com/gcinterceptor/gci-java/pull/1.diff","patch_url":"https://github.com/gcinterceptor/gci-java/pull/1.patch","issue_url":"https://api.github.com/repos/gcinterceptor/gci-java/issues/1","number":1,"state":"open","locked":false,"title":"Encapsulate sampler logic in a class","user":{"login":"dfquaresma","id":26947413,"avatar_url":"https://avatars1.githubusercontent.com/u/26947413?v=4","gravatar_id":"","url":"https://api.github.com/users/dfquaresma","html_url":"https://github.com/dfquaresma","followers_url":"https://api.github.com/users/dfquaresma/followers","following_url":"https://api.github.com/users/dfquaresma/following{/other_user}","gists_url":"https://api.github.com/users/dfquaresma/gists{/gist_id}","starred_url":"https://api.github.com/users/dfquaresma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfquaresma/subscriptions","organizations_url":"https://api.github.com/users/dfquaresma/orgs","repos_url":"https://api.github.com/users/dfquaresma/repos","events_url":"https://api.github.com/users/dfquaresma/events{/privacy}","received_events_url":"https://api.github.com/users/dfquaresma/received_events","type":"User","site_admin":false},"body":"This PR ports sampler logic from [gci-go sampler](https://github.com/gcinterceptor/gci-go/blob/master/gccontrol/sampler.go) to gci-java. ","created_at":"2018-03-08T17:04:54Z","updated_at":"2018-03-08T17:22:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d36344a515252182b5f705e4dde39b8582f26ae8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/1/commits","review_comments_url":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/1/comments","review_comment_url":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gcinterceptor/gci-java/issues/1/comments","statuses_url":"https://api.github.com/repos/gcinterceptor/gci-java/statuses/1251d5d69773cd8ffb85a7188389497335eabcf0","head":{"label":"dfquaresma:sampler","ref":"sampler","sha":"1251d5d69773cd8ffb85a7188389497335eabcf0","user":{"login":"dfquaresma","id":26947413,"avatar_url":"https://avatars1.githubusercontent.com/u/26947413?v=4","gravatar_id":"","url":"https://api.github.com/users/dfquaresma","html_url":"https://github.com/dfquaresma","followers_url":"https://api.github.com/users/dfquaresma/followers","following_url":"https://api.github.com/users/dfquaresma/following{/other_user}","gists_url":"https://api.github.com/users/dfquaresma/gists{/gist_id}","starred_url":"https://api.github.com/users/dfquaresma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfquaresma/subscriptions","organizations_url":"https://api.github.com/users/dfquaresma/orgs","repos_url":"https://api.github.com/users/dfquaresma/repos","events_url":"https://api.github.com/users/dfquaresma/events{/privacy}","received_events_url":"https://api.github.com/users/dfquaresma/received_events","type":"User","site_admin":false},"repo":{"id":124396454,"name":"gci-java","full_name":"dfquaresma/gci-java","owner":{"login":"dfquaresma","id":26947413,"avatar_url":"https://avatars1.githubusercontent.com/u/26947413?v=4","gravatar_id":"","url":"https://api.github.com/users/dfquaresma","html_url":"https://github.com/dfquaresma","followers_url":"https://api.github.com/users/dfquaresma/followers","following_url":"https://api.github.com/users/dfquaresma/following{/other_user}","gists_url":"https://api.github.com/users/dfquaresma/gists{/gist_id}","starred_url":"https://api.github.com/users/dfquaresma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dfquaresma/subscriptions","organizations_url":"https://api.github.com/users/dfquaresma/orgs","repos_url":"https://api.github.com/users/dfquaresma/repos","events_url":"https://api.github.com/users/dfquaresma/events{/privacy}","received_events_url":"https://api.github.com/users/dfquaresma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dfquaresma/gci-java","description":null,"fork":true,"url":"https://api.github.com/repos/dfquaresma/gci-java","forks_url":"https://api.github.com/repos/dfquaresma/gci-java/forks","keys_url":"https://api.github.com/repos/dfquaresma/gci-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dfquaresma/gci-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dfquaresma/gci-java/teams","hooks_url":"https://api.github.com/repos/dfquaresma/gci-java/hooks","issue_events_url":"https://api.github.com/repos/dfquaresma/gci-java/issues/events{/number}","events_url":"https://api.github.com/repos/dfquaresma/gci-java/events","assignees_url":"https://api.github.com/repos/dfquaresma/gci-java/assignees{/user}","branches_url":"https://api.github.com/repos/dfquaresma/gci-java/branches{/branch}","tags_url":"https://api.github.com/repos/dfquaresma/gci-java/tags","blobs_url":"https://api.github.com/repos/dfquaresma/gci-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dfquaresma/gci-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dfquaresma/gci-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/dfquaresma/gci-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dfquaresma/gci-java/statuses/{sha}","languages_url":"https://api.github.com/repos/dfquaresma/gci-java/languages","stargazers_url":"https://api.github.com/repos/dfquaresma/gci-java/stargazers","contributors_url":"https://api.github.com/repos/dfquaresma/gci-java/contributors","subscribers_url":"https://api.github.com/repos/dfquaresma/gci-java/subscribers","subscription_url":"https://api.github.com/repos/dfquaresma/gci-java/subscription","commits_url":"https://api.github.com/repos/dfquaresma/gci-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/dfquaresma/gci-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/dfquaresma/gci-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/dfquaresma/gci-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/dfquaresma/gci-java/contents/{+path}","compare_url":"https://api.github.com/repos/dfquaresma/gci-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dfquaresma/gci-java/merges","archive_url":"https://api.github.com/repos/dfquaresma/gci-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dfquaresma/gci-java/downloads","issues_url":"https://api.github.com/repos/dfquaresma/gci-java/issues{/number}","pulls_url":"https://api.github.com/repos/dfquaresma/gci-java/pulls{/number}","milestones_url":"https://api.github.com/repos/dfquaresma/gci-java/milestones{/number}","notifications_url":"https://api.github.com/repos/dfquaresma/gci-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dfquaresma/gci-java/labels{/name}","releases_url":"https://api.github.com/repos/dfquaresma/gci-java/releases{/id}","deployments_url":"https://api.github.com/repos/dfquaresma/gci-java/deployments","created_at":"2018-03-08T13:36:07Z","updated_at":"2017-10-30T14:23:23Z","pushed_at":"2018-03-08T17:01:51Z","git_url":"git://github.com/dfquaresma/gci-java.git","ssh_url":"[email protected]:dfquaresma/gci-java.git","clone_url":"https://github.com/dfquaresma/gci-java.git","svn_url":"https://github.com/dfquaresma/gci-java","homepage":null,"size":1,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gcinterceptor:master","ref":"master","sha":"8455d63ab2bc522b3fe67bc46094c4d45f4efdbc","user":{"login":"gcinterceptor","id":33000313,"avatar_url":"https://avatars1.githubusercontent.com/u/33000313?v=4","gravatar_id":"","url":"https://api.github.com/users/gcinterceptor","html_url":"https://github.com/gcinterceptor","followers_url":"https://api.github.com/users/gcinterceptor/followers","following_url":"https://api.github.com/users/gcinterceptor/following{/other_user}","gists_url":"https://api.github.com/users/gcinterceptor/gists{/gist_id}","starred_url":"https://api.github.com/users/gcinterceptor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcinterceptor/subscriptions","organizations_url":"https://api.github.com/users/gcinterceptor/orgs","repos_url":"https://api.github.com/users/gcinterceptor/repos","events_url":"https://api.github.com/users/gcinterceptor/events{/privacy}","received_events_url":"https://api.github.com/users/gcinterceptor/received_events","type":"Organization","site_admin":false},"repo":{"id":108861500,"name":"gci-java","full_name":"gcinterceptor/gci-java","owner":{"login":"gcinterceptor","id":33000313,"avatar_url":"https://avatars1.githubusercontent.com/u/33000313?v=4","gravatar_id":"","url":"https://api.github.com/users/gcinterceptor","html_url":"https://github.com/gcinterceptor","followers_url":"https://api.github.com/users/gcinterceptor/followers","following_url":"https://api.github.com/users/gcinterceptor/following{/other_user}","gists_url":"https://api.github.com/users/gcinterceptor/gists{/gist_id}","starred_url":"https://api.github.com/users/gcinterceptor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcinterceptor/subscriptions","organizations_url":"https://api.github.com/users/gcinterceptor/orgs","repos_url":"https://api.github.com/users/gcinterceptor/repos","events_url":"https://api.github.com/users/gcinterceptor/events{/privacy}","received_events_url":"https://api.github.com/users/gcinterceptor/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gcinterceptor/gci-java","description":null,"fork":false,"url":"https://api.github.com/repos/gcinterceptor/gci-java","forks_url":"https://api.github.com/repos/gcinterceptor/gci-java/forks","keys_url":"https://api.github.com/repos/gcinterceptor/gci-java/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcinterceptor/gci-java/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcinterceptor/gci-java/teams","hooks_url":"https://api.github.com/repos/gcinterceptor/gci-java/hooks","issue_events_url":"https://api.github.com/repos/gcinterceptor/gci-java/issues/events{/number}","events_url":"https://api.github.com/repos/gcinterceptor/gci-java/events","assignees_url":"https://api.github.com/repos/gcinterceptor/gci-java/assignees{/user}","branches_url":"https://api.github.com/repos/gcinterceptor/gci-java/branches{/branch}","tags_url":"https://api.github.com/repos/gcinterceptor/gci-java/tags","blobs_url":"https://api.github.com/repos/gcinterceptor/gci-java/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcinterceptor/gci-java/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcinterceptor/gci-java/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcinterceptor/gci-java/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcinterceptor/gci-java/statuses/{sha}","languages_url":"https://api.github.com/repos/gcinterceptor/gci-java/languages","stargazers_url":"https://api.github.com/repos/gcinterceptor/gci-java/stargazers","contributors_url":"https://api.github.com/repos/gcinterceptor/gci-java/contributors","subscribers_url":"https://api.github.com/repos/gcinterceptor/gci-java/subscribers","subscription_url":"https://api.github.com/repos/gcinterceptor/gci-java/subscription","commits_url":"https://api.github.com/repos/gcinterceptor/gci-java/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcinterceptor/gci-java/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcinterceptor/gci-java/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcinterceptor/gci-java/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcinterceptor/gci-java/contents/{+path}","compare_url":"https://api.github.com/repos/gcinterceptor/gci-java/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcinterceptor/gci-java/merges","archive_url":"https://api.github.com/repos/gcinterceptor/gci-java/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcinterceptor/gci-java/downloads","issues_url":"https://api.github.com/repos/gcinterceptor/gci-java/issues{/number}","pulls_url":"https://api.github.com/repos/gcinterceptor/gci-java/pulls{/number}","milestones_url":"https://api.github.com/repos/gcinterceptor/gci-java/milestones{/number}","notifications_url":"https://api.github.com/repos/gcinterceptor/gci-java/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcinterceptor/gci-java/labels{/name}","releases_url":"https://api.github.com/repos/gcinterceptor/gci-java/releases{/id}","deployments_url":"https://api.github.com/repos/gcinterceptor/gci-java/deployments","created_at":"2017-10-30T14:23:23Z","updated_at":"2017-10-30T14:23:23Z","pushed_at":"2018-03-08T17:04:54Z","git_url":"git://github.com/gcinterceptor/gci-java.git","ssh_url":"[email protected]:gcinterceptor/gci-java.git","clone_url":"https://github.com/gcinterceptor/gci-java.git","svn_url":"https://github.com/gcinterceptor/gci-java","homepage":null,"size":1,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/1"},"html":{"href":"https://github.com/gcinterceptor/gci-java/pull/1"},"issue":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/issues/1"},"comments":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/gcinterceptor/gci-java/statuses/1251d5d69773cd8ffb85a7188389497335eabcf0"}},"author_association":"NONE"}}

7351485729

{"actor":{"display_login":"dfquaresma"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/akaj-team/selenium-test/pulls/comments/216176999","pull_request_review_id":153600304,"id":216176999,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjE3Njk5OQ==","diff_hunk":"@@ -0,0 +1,115 @@\n+package stepdefs;\n+\n+import cucumber.api.java8.En;\n+import org.openqa.selenium.JavascriptExecutor;\n+import org.openqa.selenium.support.ui.WebDriverWait;\n+import org.testng.Assert;\n+import vn.asiantech.base.Constant;\n+import vn.asiantech.base.DriverBase;\n+import vn.asiantech.page.HomePage;\n+import vn.asiantech.page.LoginPage;\n+import vn.asiantech.page.NotificationMenuElement;\n+\n+public class NotificationElementDefinitions extends DriverBase implements En {\n+ private NotificationMenuElement notificationMenuElement;\n+ private HomePage homePage;\n+ private LoginPage loginPage;\n+\n+ public NotificationElementDefinitions() {","path":"src/test/java/stepdefs/NotificationElementDefinitions.java","position":18,"original_position":18,"commit_id":"9cc8a1f4317e7d0acd8fd47e0d455c8fdc3bceab","original_commit_id":"9cc8a1f4317e7d0acd8fd47e0d455c8fdc3bceab","user":{"login":"at-vinhhuynh","id":11311731,"node_id":"MDQ6VXNlcjExMzExNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/11311731?v=4","gravatar_id":"","url":"https://api.github.com/users/at-vinhhuynh","html_url":"https://github.com/at-vinhhuynh","followers_url":"https://api.github.com/users/at-vinhhuynh/followers","following_url":"https://api.github.com/users/at-vinhhuynh/following{/other_user}","gists_url":"https://api.github.com/users/at-vinhhuynh/gists{/gist_id}","starred_url":"https://api.github.com/users/at-vinhhuynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-vinhhuynh/subscriptions","organizations_url":"https://api.github.com/users/at-vinhhuynh/orgs","repos_url":"https://api.github.com/users/at-vinhhuynh/repos","events_url":"https://api.github.com/users/at-vinhhuynh/events{/privacy}","received_events_url":"https://api.github.com/users/at-vinhhuynh/received_events","type":"User","site_admin":false},"body":"<table data-meta=\"generated_by_danger\">\n <tbody>\n <tr>\n <td>:warning:</td>\n <td width=\"100%\" data-sticky=\"false\"><span data-href=\"https://github.com/akaj-team/selenium-test/blob/9cc8a1f4317e7d0acd8fd47e0d455c8fdc3bceab/src/test/java/stepdefs/NotificationElementDefinitions.java#L18\"></span>Missing a Javadoc comment.</td>\n </tr>\n </tbody>\n</table>\n\n\n\n","created_at":"2018-09-10T00:34:01Z","updated_at":"2018-09-10T00:34:01Z","html_url":"https://github.com/akaj-team/selenium-test/pull/6#discussion_r216176999","pull_request_url":"https://api.github.com/repos/akaj-team/selenium-test/pulls/6","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/akaj-team/selenium-test/pulls/comments/216176999"},"html":{"href":"https://github.com/akaj-team/selenium-test/pull/6#discussion_r216176999"},"pull_request":{"href":"https://api.github.com/repos/akaj-team/selenium-test/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/akaj-team/selenium-test/pulls/6","id":213477226,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNDc3MjI2","html_url":"https://github.com/akaj-team/selenium-test/pull/6","diff_url":"https://github.com/akaj-team/selenium-test/pull/6.diff","patch_url":"https://github.com/akaj-team/selenium-test/pull/6.patch","issue_url":"https://api.github.com/repos/akaj-team/selenium-test/issues/6","number":6,"state":"open","locked":false,"title":"Feature - Create Test For Notification Element","user":{"login":"at-vinhhuynh","id":11311731,"node_id":"MDQ6VXNlcjExMzExNzMx","avatar_url":"https://avatars1.githubusercontent.com/u/11311731?v=4","gravatar_id":"","url":"https://api.github.com/users/at-vinhhuynh","html_url":"https://github.com/at-vinhhuynh","followers_url":"https://api.github.com/users/at-vinhhuynh/followers","following_url":"https://api.github.com/users/at-vinhhuynh/following{/other_user}","gists_url":"https://api.github.com/users/at-vinhhuynh/gists{/gist_id}","starred_url":"https://api.github.com/users/at-vinhhuynh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-vinhhuynh/subscriptions","organizations_url":"https://api.github.com/users/at-vinhhuynh/orgs","repos_url":"https://api.github.com/users/at-vinhhuynh/repos","events_url":"https://api.github.com/users/at-vinhhuynh/events{/privacy}","received_events_url":"https://api.github.com/users/at-vinhhuynh/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-06T02:19:55Z","updated_at":"2018-09-10T00:34:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"07fd1ef1506bc73f2c23df67e251050f26641098","assignee":{"login":"at-tienhoang","id":16132900,"node_id":"MDQ6VXNlcjE2MTMyOTAw","avatar_url":"https://avatars1.githubusercontent.com/u/16132900?v=4","gravatar_id":"","url":"https://api.github.com/users/at-tienhoang","html_url":"https://github.com/at-tienhoang","followers_url":"https://api.github.com/users/at-tienhoang/followers","following_url":"https://api.github.com/users/at-tienhoang/following{/other_user}","gists_url":"https://api.github.com/users/at-tienhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/at-tienhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-tienhoang/subscriptions","organizations_url":"https://api.github.com/users/at-tienhoang/orgs","repos_url":"https://api.github.com/users/at-tienhoang/repos","events_url":"https://api.github.com/users/at-tienhoang/events{/privacy}","received_events_url":"https://api.github.com/users/at-tienhoang/received_events","type":"User","site_admin":false},"assignees":[{"login":"at-tienhoang","id":16132900,"node_id":"MDQ6VXNlcjE2MTMyOTAw","avatar_url":"https://avatars1.githubusercontent.com/u/16132900?v=4","gravatar_id":"","url":"https://api.github.com/users/at-tienhoang","html_url":"https://github.com/at-tienhoang","followers_url":"https://api.github.com/users/at-tienhoang/followers","following_url":"https://api.github.com/users/at-tienhoang/following{/other_user}","gists_url":"https://api.github.com/users/at-tienhoang/gists{/gist_id}","starred_url":"https://api.github.com/users/at-tienhoang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/at-tienhoang/subscriptions","organizations_url":"https://api.github.com/users/at-tienhoang/orgs","repos_url":"https://api.github.com/users/at-tienhoang/repos","events_url":"https://api.github.com/users/at-tienhoang/events{/privacy}","received_events_url":"https://api.github.com/users/at-tienhoang/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1034126466,"node_id":"MDU6TGFiZWwxMDM0MTI2NDY2","url":"https://api.github.com/repos/akaj-team/selenium-test/labels/[status]%20Review%20Needed","name":"[status] Review Needed","color":"f9d0c4","default":false},{"id":1034126467,"node_id":"MDU6TGFiZWwxMDM0MTI2NDY3","url":"https://api.github.com/repos/akaj-team/selenium-test/labels/[type]%20Task","name":"[type] Task","color":"96dfea","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/akaj-team/selenium-test/pulls/6/commits","review_comments_url":"https://api.github.com/repos/akaj-team/selenium-test/pulls/6/comments","review_comment_url":"https://api.github.com/repos/akaj-team/selenium-test/pulls/comments{/number}","comments_url":"https://api.github.com/repos/akaj-team/selenium-test/issues/6/comments","statuses_url":"https://api.github.com/repos/akaj-team/selenium-test/statuses/9cc8a1f4317e7d0acd8fd47e0d455c8fdc3bceab","head":{"label":"akaj-team:feature/create_test_notification","ref":"feature/create_test_notification","sha":"9cc8a1f4317e7d0acd8fd47e0d455c8fdc3bceab","user":{"login":"akaj-team","id":33055357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDU1MzU3","avatar_url":"https://avatars0.githubusercontent.com/u/33055357?v=4","gravatar_id":"","url":"https://api.github.com/users/akaj-team","html_url":"https://github.com/akaj-team","followers_url":"https://api.github.com/users/akaj-team/followers","following_url":"https://api.github.com/users/akaj-team/following{/other_user}","gists_url":"https://api.github.com/users/akaj-team/gists{/gist_id}","starred_url":"https://api.github.com/users/akaj-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akaj-team/subscriptions","organizations_url":"https://api.github.com/users/akaj-team/orgs","repos_url":"https://api.github.com/users/akaj-team/repos","events_url":"https://api.github.com/users/akaj-team/events{/privacy}","received_events_url":"https://api.github.com/users/akaj-team/received_events","type":"Organization","site_admin":false},"repo":{"id":145970870,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5NzA4NzA=","name":"selenium-test","full_name":"akaj-team/selenium-test","owner":{"login":"akaj-team","id":33055357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDU1MzU3","avatar_url":"https://avatars0.githubusercontent.com/u/33055357?v=4","gravatar_id":"","url":"https://api.github.com/users/akaj-team","html_url":"https://github.com/akaj-team","followers_url":"https://api.github.com/users/akaj-team/followers","following_url":"https://api.github.com/users/akaj-team/following{/other_user}","gists_url":"https://api.github.com/users/akaj-team/gists{/gist_id}","starred_url":"https://api.github.com/users/akaj-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akaj-team/subscriptions","organizations_url":"https://api.github.com/users/akaj-team/orgs","repos_url":"https://api.github.com/users/akaj-team/repos","events_url":"https://api.github.com/users/akaj-team/events{/privacy}","received_events_url":"https://api.github.com/users/akaj-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akaj-team/selenium-test","description":null,"fork":false,"url":"https://api.github.com/repos/akaj-team/selenium-test","forks_url":"https://api.github.com/repos/akaj-team/selenium-test/forks","keys_url":"https://api.github.com/repos/akaj-team/selenium-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akaj-team/selenium-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akaj-team/selenium-test/teams","hooks_url":"https://api.github.com/repos/akaj-team/selenium-test/hooks","issue_events_url":"https://api.github.com/repos/akaj-team/selenium-test/issues/events{/number}","events_url":"https://api.github.com/repos/akaj-team/selenium-test/events","assignees_url":"https://api.github.com/repos/akaj-team/selenium-test/assignees{/user}","branches_url":"https://api.github.com/repos/akaj-team/selenium-test/branches{/branch}","tags_url":"https://api.github.com/repos/akaj-team/selenium-test/tags","blobs_url":"https://api.github.com/repos/akaj-team/selenium-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akaj-team/selenium-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akaj-team/selenium-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/akaj-team/selenium-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akaj-team/selenium-test/statuses/{sha}","languages_url":"https://api.github.com/repos/akaj-team/selenium-test/languages","stargazers_url":"https://api.github.com/repos/akaj-team/selenium-test/stargazers","contributors_url":"https://api.github.com/repos/akaj-team/selenium-test/contributors","subscribers_url":"https://api.github.com/repos/akaj-team/selenium-test/subscribers","subscription_url":"https://api.github.com/repos/akaj-team/selenium-test/subscription","commits_url":"https://api.github.com/repos/akaj-team/selenium-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/akaj-team/selenium-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/akaj-team/selenium-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/akaj-team/selenium-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/akaj-team/selenium-test/contents/{+path}","compare_url":"https://api.github.com/repos/akaj-team/selenium-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akaj-team/selenium-test/merges","archive_url":"https://api.github.com/repos/akaj-team/selenium-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akaj-team/selenium-test/downloads","issues_url":"https://api.github.com/repos/akaj-team/selenium-test/issues{/number}","pulls_url":"https://api.github.com/repos/akaj-team/selenium-test/pulls{/number}","milestones_url":"https://api.github.com/repos/akaj-team/selenium-test/milestones{/number}","notifications_url":"https://api.github.com/repos/akaj-team/selenium-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akaj-team/selenium-test/labels{/name}","releases_url":"https://api.github.com/repos/akaj-team/selenium-test/releases{/id}","deployments_url":"https://api.github.com/repos/akaj-team/selenium-test/deployments","created_at":"2018-08-24T09:20:58Z","updated_at":"2018-09-07T12:08:14Z","pushed_at":"2018-09-10T00:32:02Z","git_url":"git://github.com/akaj-team/selenium-test.git","ssh_url":"[email protected]:akaj-team/selenium-test.git","clone_url":"https://github.com/akaj-team/selenium-test.git","svn_url":"https://github.com/akaj-team/selenium-test","homepage":null,"size":84,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"akaj-team:master","ref":"master","sha":"6b31029cb7c1585e21384c4396e42083ed33c6b5","user":{"login":"akaj-team","id":33055357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDU1MzU3","avatar_url":"https://avatars0.githubusercontent.com/u/33055357?v=4","gravatar_id":"","url":"https://api.github.com/users/akaj-team","html_url":"https://github.com/akaj-team","followers_url":"https://api.github.com/users/akaj-team/followers","following_url":"https://api.github.com/users/akaj-team/following{/other_user}","gists_url":"https://api.github.com/users/akaj-team/gists{/gist_id}","starred_url":"https://api.github.com/users/akaj-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akaj-team/subscriptions","organizations_url":"https://api.github.com/users/akaj-team/orgs","repos_url":"https://api.github.com/users/akaj-team/repos","events_url":"https://api.github.com/users/akaj-team/events{/privacy}","received_events_url":"https://api.github.com/users/akaj-team/received_events","type":"Organization","site_admin":false},"repo":{"id":145970870,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5NzA4NzA=","name":"selenium-test","full_name":"akaj-team/selenium-test","owner":{"login":"akaj-team","id":33055357,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMDU1MzU3","avatar_url":"https://avatars0.githubusercontent.com/u/33055357?v=4","gravatar_id":"","url":"https://api.github.com/users/akaj-team","html_url":"https://github.com/akaj-team","followers_url":"https://api.github.com/users/akaj-team/followers","following_url":"https://api.github.com/users/akaj-team/following{/other_user}","gists_url":"https://api.github.com/users/akaj-team/gists{/gist_id}","starred_url":"https://api.github.com/users/akaj-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akaj-team/subscriptions","organizations_url":"https://api.github.com/users/akaj-team/orgs","repos_url":"https://api.github.com/users/akaj-team/repos","events_url":"https://api.github.com/users/akaj-team/events{/privacy}","received_events_url":"https://api.github.com/users/akaj-team/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/akaj-team/selenium-test","description":null,"fork":false,"url":"https://api.github.com/repos/akaj-team/selenium-test","forks_url":"https://api.github.com/repos/akaj-team/selenium-test/forks","keys_url":"https://api.github.com/repos/akaj-team/selenium-test/keys{/key_id}","collaborators_url":"https://api.github.com/repos/akaj-team/selenium-test/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/akaj-team/selenium-test/teams","hooks_url":"https://api.github.com/repos/akaj-team/selenium-test/hooks","issue_events_url":"https://api.github.com/repos/akaj-team/selenium-test/issues/events{/number}","events_url":"https://api.github.com/repos/akaj-team/selenium-test/events","assignees_url":"https://api.github.com/repos/akaj-team/selenium-test/assignees{/user}","branches_url":"https://api.github.com/repos/akaj-team/selenium-test/branches{/branch}","tags_url":"https://api.github.com/repos/akaj-team/selenium-test/tags","blobs_url":"https://api.github.com/repos/akaj-team/selenium-test/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/akaj-team/selenium-test/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/akaj-team/selenium-test/git/refs{/sha}","trees_url":"https://api.github.com/repos/akaj-team/selenium-test/git/trees{/sha}","statuses_url":"https://api.github.com/repos/akaj-team/selenium-test/statuses/{sha}","languages_url":"https://api.github.com/repos/akaj-team/selenium-test/languages","stargazers_url":"https://api.github.com/repos/akaj-team/selenium-test/stargazers","contributors_url":"https://api.github.com/repos/akaj-team/selenium-test/contributors","subscribers_url":"https://api.github.com/repos/akaj-team/selenium-test/subscribers","subscription_url":"https://api.github.com/repos/akaj-team/selenium-test/subscription","commits_url":"https://api.github.com/repos/akaj-team/selenium-test/commits{/sha}","git_commits_url":"https://api.github.com/repos/akaj-team/selenium-test/git/commits{/sha}","comments_url":"https://api.github.com/repos/akaj-team/selenium-test/comments{/number}","issue_comment_url":"https://api.github.com/repos/akaj-team/selenium-test/issues/comments{/number}","contents_url":"https://api.github.com/repos/akaj-team/selenium-test/contents/{+path}","compare_url":"https://api.github.com/repos/akaj-team/selenium-test/compare/{base}...{head}","merges_url":"https://api.github.com/repos/akaj-team/selenium-test/merges","archive_url":"https://api.github.com/repos/akaj-team/selenium-test/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/akaj-team/selenium-test/downloads","issues_url":"https://api.github.com/repos/akaj-team/selenium-test/issues{/number}","pulls_url":"https://api.github.com/repos/akaj-team/selenium-test/pulls{/number}","milestones_url":"https://api.github.com/repos/akaj-team/selenium-test/milestones{/number}","notifications_url":"https://api.github.com/repos/akaj-team/selenium-test/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/akaj-team/selenium-test/labels{/name}","releases_url":"https://api.github.com/repos/akaj-team/selenium-test/releases{/id}","deployments_url":"https://api.github.com/repos/akaj-team/selenium-test/deployments","created_at":"2018-08-24T09:20:58Z","updated_at":"2018-09-07T12:08:14Z","pushed_at":"2018-09-10T00:32:02Z","git_url":"git://github.com/akaj-team/selenium-test.git","ssh_url":"[email protected]:akaj-team/selenium-test.git","clone_url":"https://github.com/akaj-team/selenium-test.git","svn_url":"https://github.com/akaj-team/selenium-test","homepage":null,"size":84,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/akaj-team/selenium-test/pulls/6"},"html":{"href":"https://github.com/akaj-team/selenium-test/pull/6"},"issue":{"href":"https://api.github.com/repos/akaj-team/selenium-test/issues/6"},"comments":{"href":"https://api.github.com/repos/akaj-team/selenium-test/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/akaj-team/selenium-test/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/akaj-team/selenium-test/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/akaj-team/selenium-test/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/akaj-team/selenium-test/statuses/9cc8a1f4317e7d0acd8fd47e0d455c8fdc3bceab"}},"author_association":"CONTRIBUTOR"}}

8237116835

{"actor":{"display_login":"at-vinhhuynh"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/MARKETProtocol/website/pulls/comments/214374552","pull_request_review_id":151422475,"id":214374552,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDM3NDU1Mg==","diff_hunk":"@@ -35,6 +35,13 @@ export default {\n path: '/',\n component: 'src/containers/Home',\n },\n+ {\n+ path: '/video',\n+ component: 'src/containers/HomeRouteWrapper',\n+ getData: async () => ({","path":"static.config.js","position":null,"original_position":7,"commit_id":"075fb839f3881b8e6272169408f14a9e84534389","original_commit_id":"377cf77dfdb71020c513fc1be275059d574f71a0","user":{"login":"darshannbs57","id":42678276,"node_id":"MDQ6VXNlcjQyNjc4Mjc2","avatar_url":"https://avatars0.githubusercontent.com/u/42678276?v=4","gravatar_id":"","url":"https://api.github.com/users/darshannbs57","html_url":"https://github.com/darshannbs57","followers_url":"https://api.github.com/users/darshannbs57/followers","following_url":"https://api.github.com/users/darshannbs57/following{/other_user}","gists_url":"https://api.github.com/users/darshannbs57/gists{/gist_id}","starred_url":"https://api.github.com/users/darshannbs57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darshannbs57/subscriptions","organizations_url":"https://api.github.com/users/darshannbs57/orgs","repos_url":"https://api.github.com/users/darshannbs57/repos","events_url":"https://api.github.com/users/darshannbs57/events{/privacy}","received_events_url":"https://api.github.com/users/darshannbs57/received_events","type":"User","site_admin":false},"body":"Learnt the actual scenario why its async now.","created_at":"2018-08-31T14:36:25Z","updated_at":"2018-08-31T14:36:26Z","html_url":"https://github.com/MARKETProtocol/website/pull/246#discussion_r214374552","pull_request_url":"https://api.github.com/repos/MARKETProtocol/website/pulls/246","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/MARKETProtocol/website/pulls/comments/214374552"},"html":{"href":"https://github.com/MARKETProtocol/website/pull/246#discussion_r214374552"},"pull_request":{"href":"https://api.github.com/repos/MARKETProtocol/website/pulls/246"}},"in_reply_to_id":214365560},"pull_request":{"url":"https://api.github.com/repos/MARKETProtocol/website/pulls/246","id":212382985,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMzgyOTg1","html_url":"https://github.com/MARKETProtocol/website/pull/246","diff_url":"https://github.com/MARKETProtocol/website/pull/246.diff","patch_url":"https://github.com/MARKETProtocol/website/pull/246.patch","issue_url":"https://api.github.com/repos/MARKETProtocol/website/issues/246","number":246,"state":"open","locked":false,"title":"Adding Route to Video Section","user":{"login":"darshannbs57","id":42678276,"node_id":"MDQ6VXNlcjQyNjc4Mjc2","avatar_url":"https://avatars0.githubusercontent.com/u/42678276?v=4","gravatar_id":"","url":"https://api.github.com/users/darshannbs57","html_url":"https://github.com/darshannbs57","followers_url":"https://api.github.com/users/darshannbs57/followers","following_url":"https://api.github.com/users/darshannbs57/following{/other_user}","gists_url":"https://api.github.com/users/darshannbs57/gists{/gist_id}","starred_url":"https://api.github.com/users/darshannbs57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darshannbs57/subscriptions","organizations_url":"https://api.github.com/users/darshannbs57/orgs","repos_url":"https://api.github.com/users/darshannbs57/repos","events_url":"https://api.github.com/users/darshannbs57/events{/privacy}","received_events_url":"https://api.github.com/users/darshannbs57/received_events","type":"User","site_admin":false},"body":"##### Description\r\n1. Added new route to `static.config.js`\r\n2. Created a route wrapper passing the routeData to HomeComponent\r\n3. Added test case for video expansion on \"./video\" route navigation\r\n\r\n##### Checklist\r\n- [x] Linter status: 100% pass\r\n- [x] Changes don't break existing behavior\r\n- [x] Tests coverage hasn't decreased\r\n\r\n##### Affected core subsystem(s)\r\nUI/UX\r\n\r\n##### Screenshots (Optional) \r\nVideo Section on \"./video\" route\r\n\r\n\r\n\r\n##### Testing\r\n1. Navigate to Home Page and modify the url to \"./video\" and see that video is expanded and played.\r\n2. Navigate to other sections to enforce it doesn't after other views.\r\n3. Run test cases\r\n\r\n##### Refers/Fixes\r\nFixes: #242 \r\n","created_at":"2018-08-31T13:26:44Z","updated_at":"2018-08-31T14:36:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f92390524e80a995ee8a0043b57d9fb51743307e","assignee":{"login":"nitinrgupta","id":4952395,"node_id":"MDQ6VXNlcjQ5NTIzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4952395?v=4","gravatar_id":"","url":"https://api.github.com/users/nitinrgupta","html_url":"https://github.com/nitinrgupta","followers_url":"https://api.github.com/users/nitinrgupta/followers","following_url":"https://api.github.com/users/nitinrgupta/following{/other_user}","gists_url":"https://api.github.com/users/nitinrgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/nitinrgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitinrgupta/subscriptions","organizations_url":"https://api.github.com/users/nitinrgupta/orgs","repos_url":"https://api.github.com/users/nitinrgupta/repos","events_url":"https://api.github.com/users/nitinrgupta/events{/privacy}","received_events_url":"https://api.github.com/users/nitinrgupta/received_events","type":"User","site_admin":false},"assignees":[{"login":"nitinrgupta","id":4952395,"node_id":"MDQ6VXNlcjQ5NTIzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4952395?v=4","gravatar_id":"","url":"https://api.github.com/users/nitinrgupta","html_url":"https://github.com/nitinrgupta","followers_url":"https://api.github.com/users/nitinrgupta/followers","following_url":"https://api.github.com/users/nitinrgupta/following{/other_user}","gists_url":"https://api.github.com/users/nitinrgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/nitinrgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitinrgupta/subscriptions","organizations_url":"https://api.github.com/users/nitinrgupta/orgs","repos_url":"https://api.github.com/users/nitinrgupta/repos","events_url":"https://api.github.com/users/nitinrgupta/events{/privacy}","received_events_url":"https://api.github.com/users/nitinrgupta/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"nitinrgupta","id":4952395,"node_id":"MDQ6VXNlcjQ5NTIzOTU=","avatar_url":"https://avatars0.githubusercontent.com/u/4952395?v=4","gravatar_id":"","url":"https://api.github.com/users/nitinrgupta","html_url":"https://github.com/nitinrgupta","followers_url":"https://api.github.com/users/nitinrgupta/followers","following_url":"https://api.github.com/users/nitinrgupta/following{/other_user}","gists_url":"https://api.github.com/users/nitinrgupta/gists{/gist_id}","starred_url":"https://api.github.com/users/nitinrgupta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nitinrgupta/subscriptions","organizations_url":"https://api.github.com/users/nitinrgupta/orgs","repos_url":"https://api.github.com/users/nitinrgupta/repos","events_url":"https://api.github.com/users/nitinrgupta/events{/privacy}","received_events_url":"https://api.github.com/users/nitinrgupta/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MARKETProtocol/website/pulls/246/commits","review_comments_url":"https://api.github.com/repos/MARKETProtocol/website/pulls/246/comments","review_comment_url":"https://api.github.com/repos/MARKETProtocol/website/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MARKETProtocol/website/issues/246/comments","statuses_url":"https://api.github.com/repos/MARKETProtocol/website/statuses/075fb839f3881b8e6272169408f14a9e84534389","head":{"label":"darshannbs57:video-section","ref":"video-section","sha":"075fb839f3881b8e6272169408f14a9e84534389","user":{"login":"darshannbs57","id":42678276,"node_id":"MDQ6VXNlcjQyNjc4Mjc2","avatar_url":"https://avatars0.githubusercontent.com/u/42678276?v=4","gravatar_id":"","url":"https://api.github.com/users/darshannbs57","html_url":"https://github.com/darshannbs57","followers_url":"https://api.github.com/users/darshannbs57/followers","following_url":"https://api.github.com/users/darshannbs57/following{/other_user}","gists_url":"https://api.github.com/users/darshannbs57/gists{/gist_id}","starred_url":"https://api.github.com/users/darshannbs57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darshannbs57/subscriptions","organizations_url":"https://api.github.com/users/darshannbs57/orgs","repos_url":"https://api.github.com/users/darshannbs57/repos","events_url":"https://api.github.com/users/darshannbs57/events{/privacy}","received_events_url":"https://api.github.com/users/darshannbs57/received_events","type":"User","site_admin":false},"repo":{"id":146840466,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4NDA0NjY=","name":"website","full_name":"darshannbs57/website","owner":{"login":"darshannbs57","id":42678276,"node_id":"MDQ6VXNlcjQyNjc4Mjc2","avatar_url":"https://avatars0.githubusercontent.com/u/42678276?v=4","gravatar_id":"","url":"https://api.github.com/users/darshannbs57","html_url":"https://github.com/darshannbs57","followers_url":"https://api.github.com/users/darshannbs57/followers","following_url":"https://api.github.com/users/darshannbs57/following{/other_user}","gists_url":"https://api.github.com/users/darshannbs57/gists{/gist_id}","starred_url":"https://api.github.com/users/darshannbs57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/darshannbs57/subscriptions","organizations_url":"https://api.github.com/users/darshannbs57/orgs","repos_url":"https://api.github.com/users/darshannbs57/repos","events_url":"https://api.github.com/users/darshannbs57/events{/privacy}","received_events_url":"https://api.github.com/users/darshannbs57/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/darshannbs57/website","description":"MARKET Protocol website","fork":true,"url":"https://api.github.com/repos/darshannbs57/website","forks_url":"https://api.github.com/repos/darshannbs57/website/forks","keys_url":"https://api.github.com/repos/darshannbs57/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/darshannbs57/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/darshannbs57/website/teams","hooks_url":"https://api.github.com/repos/darshannbs57/website/hooks","issue_events_url":"https://api.github.com/repos/darshannbs57/website/issues/events{/number}","events_url":"https://api.github.com/repos/darshannbs57/website/events","assignees_url":"https://api.github.com/repos/darshannbs57/website/assignees{/user}","branches_url":"https://api.github.com/repos/darshannbs57/website/branches{/branch}","tags_url":"https://api.github.com/repos/darshannbs57/website/tags","blobs_url":"https://api.github.com/repos/darshannbs57/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/darshannbs57/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/darshannbs57/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/darshannbs57/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/darshannbs57/website/statuses/{sha}","languages_url":"https://api.github.com/repos/darshannbs57/website/languages","stargazers_url":"https://api.github.com/repos/darshannbs57/website/stargazers","contributors_url":"https://api.github.com/repos/darshannbs57/website/contributors","subscribers_url":"https://api.github.com/repos/darshannbs57/website/subscribers","subscription_url":"https://api.github.com/repos/darshannbs57/website/subscription","commits_url":"https://api.github.com/repos/darshannbs57/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/darshannbs57/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/darshannbs57/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/darshannbs57/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/darshannbs57/website/contents/{+path}","compare_url":"https://api.github.com/repos/darshannbs57/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/darshannbs57/website/merges","archive_url":"https://api.github.com/repos/darshannbs57/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/darshannbs57/website/downloads","issues_url":"https://api.github.com/repos/darshannbs57/website/issues{/number}","pulls_url":"https://api.github.com/repos/darshannbs57/website/pulls{/number}","milestones_url":"https://api.github.com/repos/darshannbs57/website/milestones{/number}","notifications_url":"https://api.github.com/repos/darshannbs57/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/darshannbs57/website/labels{/name}","releases_url":"https://api.github.com/repos/darshannbs57/website/releases{/id}","deployments_url":"https://api.github.com/repos/darshannbs57/website/deployments","created_at":"2018-08-31T04:08:36Z","updated_at":"2018-08-31T04:08:39Z","pushed_at":"2018-08-31T14:34:13Z","git_url":"git://github.com/darshannbs57/website.git","ssh_url":"[email protected]:darshannbs57/website.git","clone_url":"https://github.com/darshannbs57/website.git","svn_url":"https://github.com/darshannbs57/website","homepage":"https://marketprotocol.io/","size":21243,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"MARKETProtocol:develop","ref":"develop","sha":"737bad088195b6b86280cb95b7c20918e9abe9d1","user":{"login":"MARKETProtocol","id":33100368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTAwMzY4","avatar_url":"https://avatars2.githubusercontent.com/u/33100368?v=4","gravatar_id":"","url":"https://api.github.com/users/MARKETProtocol","html_url":"https://github.com/MARKETProtocol","followers_url":"https://api.github.com/users/MARKETProtocol/followers","following_url":"https://api.github.com/users/MARKETProtocol/following{/other_user}","gists_url":"https://api.github.com/users/MARKETProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/MARKETProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MARKETProtocol/subscriptions","organizations_url":"https://api.github.com/users/MARKETProtocol/orgs","repos_url":"https://api.github.com/users/MARKETProtocol/repos","events_url":"https://api.github.com/users/MARKETProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/MARKETProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":129016888,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkwMTY4ODg=","name":"website","full_name":"MARKETProtocol/website","owner":{"login":"MARKETProtocol","id":33100368,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTAwMzY4","avatar_url":"https://avatars2.githubusercontent.com/u/33100368?v=4","gravatar_id":"","url":"https://api.github.com/users/MARKETProtocol","html_url":"https://github.com/MARKETProtocol","followers_url":"https://api.github.com/users/MARKETProtocol/followers","following_url":"https://api.github.com/users/MARKETProtocol/following{/other_user}","gists_url":"https://api.github.com/users/MARKETProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/MARKETProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MARKETProtocol/subscriptions","organizations_url":"https://api.github.com/users/MARKETProtocol/orgs","repos_url":"https://api.github.com/users/MARKETProtocol/repos","events_url":"https://api.github.com/users/MARKETProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/MARKETProtocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/MARKETProtocol/website","description":"MARKET Protocol website","fork":false,"url":"https://api.github.com/repos/MARKETProtocol/website","forks_url":"https://api.github.com/repos/MARKETProtocol/website/forks","keys_url":"https://api.github.com/repos/MARKETProtocol/website/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MARKETProtocol/website/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MARKETProtocol/website/teams","hooks_url":"https://api.github.com/repos/MARKETProtocol/website/hooks","issue_events_url":"https://api.github.com/repos/MARKETProtocol/website/issues/events{/number}","events_url":"https://api.github.com/repos/MARKETProtocol/website/events","assignees_url":"https://api.github.com/repos/MARKETProtocol/website/assignees{/user}","branches_url":"https://api.github.com/repos/MARKETProtocol/website/branches{/branch}","tags_url":"https://api.github.com/repos/MARKETProtocol/website/tags","blobs_url":"https://api.github.com/repos/MARKETProtocol/website/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MARKETProtocol/website/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MARKETProtocol/website/git/refs{/sha}","trees_url":"https://api.github.com/repos/MARKETProtocol/website/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MARKETProtocol/website/statuses/{sha}","languages_url":"https://api.github.com/repos/MARKETProtocol/website/languages","stargazers_url":"https://api.github.com/repos/MARKETProtocol/website/stargazers","contributors_url":"https://api.github.com/repos/MARKETProtocol/website/contributors","subscribers_url":"https://api.github.com/repos/MARKETProtocol/website/subscribers","subscription_url":"https://api.github.com/repos/MARKETProtocol/website/subscription","commits_url":"https://api.github.com/repos/MARKETProtocol/website/commits{/sha}","git_commits_url":"https://api.github.com/repos/MARKETProtocol/website/git/commits{/sha}","comments_url":"https://api.github.com/repos/MARKETProtocol/website/comments{/number}","issue_comment_url":"https://api.github.com/repos/MARKETProtocol/website/issues/comments{/number}","contents_url":"https://api.github.com/repos/MARKETProtocol/website/contents/{+path}","compare_url":"https://api.github.com/repos/MARKETProtocol/website/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MARKETProtocol/website/merges","archive_url":"https://api.github.com/repos/MARKETProtocol/website/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MARKETProtocol/website/downloads","issues_url":"https://api.github.com/repos/MARKETProtocol/website/issues{/number}","pulls_url":"https://api.github.com/repos/MARKETProtocol/website/pulls{/number}","milestones_url":"https://api.github.com/repos/MARKETProtocol/website/milestones{/number}","notifications_url":"https://api.github.com/repos/MARKETProtocol/website/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MARKETProtocol/website/labels{/name}","releases_url":"https://api.github.com/repos/MARKETProtocol/website/releases{/id}","deployments_url":"https://api.github.com/repos/MARKETProtocol/website/deployments","created_at":"2018-04-11T01:36:52Z","updated_at":"2018-08-31T08:15:21Z","pushed_at":"2018-08-31T14:34:15Z","git_url":"git://github.com/MARKETProtocol/website.git","ssh_url":"[email protected]:MARKETProtocol/website.git","clone_url":"https://github.com/MARKETProtocol/website.git","svn_url":"https://github.com/MARKETProtocol/website","homepage":"https://marketprotocol.io/","size":21246,"stargazers_count":27,"watchers_count":27,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":44,"open_issues":9,"watchers":27,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/MARKETProtocol/website/pulls/246"},"html":{"href":"https://github.com/MARKETProtocol/website/pull/246"},"issue":{"href":"https://api.github.com/repos/MARKETProtocol/website/issues/246"},"comments":{"href":"https://api.github.com/repos/MARKETProtocol/website/issues/246/comments"},"review_comments":{"href":"https://api.github.com/repos/MARKETProtocol/website/pulls/246/comments"},"review_comment":{"href":"https://api.github.com/repos/MARKETProtocol/website/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MARKETProtocol/website/pulls/246/commits"},"statuses":{"href":"https://api.github.com/repos/MARKETProtocol/website/statuses/075fb839f3881b8e6272169408f14a9e84534389"}},"author_association":"NONE"}}

8197843201

{"actor":{"display_login":"darshannbs57"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/comments/204313271","pull_request_review_id":139368873,"id":204313271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDMxMzI3MQ==","diff_hunk":"@@ -115,11 +115,162 @@ def analyze(self, event):\n wgt = self._worker.getWeight(l.pt,l.eta)\n sf.append(wgt if wgt>0 else 1.)\n else:\n- sf.append(self._worker.getWeight(getattr(l,sef.var)))\n+ sf.append(self._worker.getWeight(getattr(l,self.var)))\n self.out.fillBranch(\"LepGood_trgSF\", sf)\n return True\n \n+####################################################################\n+####################################################################\n+\n+class scaleFactorManager:\n+ def __init__(self,filename,path,hname):\n+ self.hname = hname\n+ self.fname = path + (\"\" if path.endswith(\"/\") else \"/\") + filename\n+ self.hist = 0\n+ self.epsilon = 0.0001 # used to get correct bin number given value on axis (just in case we are picking a value on a bin edge)\n+ self.hasLoadedHisto = False\n+\n+ def printFile():\n+ tf = ROOT.TFile.Open(self.fname)\n+ print \"-\"*20\n+ tf.Print()\n+ tf.Close()\n+ print \"-\"*20\n+\n+ def loadHist(self,newfname=None,newhname=None):\n+ # can also change file and/or histogram name with this method\n+ if newfname:\n+ self.fname = newfname\n+ if newhname:\n+ self.hname = newhname\n+ tf = ROOT.TFile.Open(self.fname)\n+ self.hist = tf.Get(self.hname)\n+ self.hist.SetDirectory(0)\n+ tf.Close()\n+ if not self.hist:\n+ print \"*\"*20\n+ print \"WARNING: could not load histogram {n} from file {f}. Will return 1\".format(n=self.hname,f=self.fname)\n+ print \"*\"*20\n+ self.printFile()\n+ else:\n+ print \"Histogram {n} successfully loaded from file {f} ;-)\".format(n=self.hname,f=self.fname)\n+ self.hasLoadedHisto = True\n+\n+ def getSF(self,pt,eta):\n+ if not self.hist:\n+ #print \"Warning in scaleFactorManager.getSF(): histogram not found, I will try to load it now. If not successfull, I will return 1.\"\n+ # just in case it was not loaded explicitly\n+ if not self.hasLoadedHisto:\n+ self.loadHist()\n+ return self.getSF(pt,eta)\n+ else: \n+ return 1.\n+ else:\n+ ieta = self.hist.GetXaxis().FindFixBin(eta+self.epsilon)\n+ ipt = self.hist.GetYaxis().FindFixBin(pt +self.epsilon)\n+ # protect against underflow and overflow\n+ return self.hist.GetBinContent(min(max(1,ieta),self.hist.GetNbinsX()),min(max(1,ipt),self.hist.GetNbinsY()))\n+\n+ def getSF_err(self,pt,eta):\n+ if not self.hist:\n+ #print \"Warning in scaleFactorManager.getSF_err(): histogram not found, I will try to load it now. If not successfull, I will return 1.\"\n+ # just in case it was not loaded explicitly\n+ if not self.hasLoadedHisto:\n+ self.loadHist()\n+ return self.getSF(pt,eta)\n+ else: \n+ return 1.\n+ else:\n+ ieta = self.hist.GetXaxis().FindFixBin(eta+self.epsilon)\n+ ipt = self.hist.GetYaxis().FindFixBin(pt +self.epsilon)\n+ return self.hist.GetBinError(min(max(1,ieta),self.hist.GetNbinsX()),min(max(1,ipt),self.hist.GetNbinsY()))\n+ \n+#-----------------------------------------\n+\n+class lep2016SFProducer(Module):\n+ def __init__(self):\n+\n+ self.mu_f = {\"trigger\" :\"smoothEfficiency_muons_trigger.root\", \n+ \"identification\":\"smoothEfficiency_muons_full2016_ID.root\", \n+ \"isolation\" :\"smoothEfficiency_muons_full2016_ISO.root\"\n+ }\n+ self.el_f = {\"trigger\" :\"smoothEfficiency_electrons_trigger.root\"\n+ }\n+ self.filePath = \"%s/src/CMGTools/WMass/python/postprocessing/data/leptonSF/new2016_madeSummer2018/\" % os.environ['CMSSW_BASE']\n+\n+ def beginJob(self):\n+ # create muon scale factor manager: pass file name and location, and then the name of histogram to read\n+ # for muon ID, might also want to use \"scaleFactorOriginal\" which has the unsmoothed version of the scale factors\n+ self.trgSF_manager_mu = scaleFactorManager(self.mu_f[\"trigger\"], self.filePath,\"scaleFactor\")\n+ self.idSF_manager_mu = scaleFactorManager(self.mu_f[\"identification\"],self.filePath,\"scaleFactor\") \n+ self.isoSF_manager_mu = scaleFactorManager(self.mu_f[\"isolation\"], self.filePath,\"scaleFactor\")\n+\n+ # create electron scale factor manager \n+ self.trgSF_manager_el = scaleFactorManager(self.el_f[\"trigger\"], self.filePath,\"scaleFactor\")\n+\n+ # load histograms\n+ self.trgSF_manager_mu.loadHist()\n+ self.idSF_manager_mu.loadHist()\n+ self.isoSF_manager_mu.loadHist()\n+ self.trgSF_manager_el.loadHist()\n+\n+ def endJob(self):\n+ pass\n+ def beginFile(self, inputFile, outputFile, inputTree, wrappedOutputTree):\n+ self.out = wrappedOutputTree\n+ self.out.branch(\"LepGood_IDeffSF\", \"F\", lenVar=\"nLepGood\")\n+ self.out.branch(\"LepGood_ISOeffSF\", \"F\", lenVar=\"nLepGood\")\n+ self.out.branch(\"LepGood_trgSF\", \"F\", lenVar=\"nLepGood\")\n+ self.out.branch(\"LepGood_IDeffSF_err\", \"F\", lenVar=\"nLepGood\")\n+ self.out.branch(\"LepGood_ISOeffSF_err\", \"F\", lenVar=\"nLepGood\")\n+ self.out.branch(\"LepGood_trgSF_err\", \"F\", lenVar=\"nLepGood\")\n+ def endFile(self, inputFile, outputFile, inputTree, wrappedOutputTree):\n+ pass\n+ def analyze(self, event):\n+ \"\"\"process event, return True (go to next module) or False (fail, go to next event)\"\"\"\n+ leps = Collection(event, \"LepGood\")\n+ sf_id = []\n+ sf_iso = []\n+ sf_trg = []\n+ sf_id_err = []\n+ sf_iso_err = []\n+ sf_trg_err = []\n+ for l in leps:\n+ if event.isData:\n+ sf_trg.append(1.)\n+ sf_id.append(1.)\n+ sf_iso.append(1.)\n+ sf_trg_err.append(0.)\n+ sf_id_err.append(0.)\n+ sf_iso_err.append(0.)\n+ else:\n+ if abs(l.pdgId)==11:\n+ sf_trg.append(float(self.trgSF_manager_el.getSF(l.pt,l.eta))) \n+ sf_id.append(1.)\n+ sf_iso.append(1.)\n+ sf_trg_err.append(float(self.trgSF_manager_el.getSF_err(l.pt,l.eta))) \n+ sf_id_err.append(1.)\n+ sf_iso_err.append(1.)\n+ else:\n+ sf_trg.append( float(self.trgSF_manager_mu.getSF(l.pt,l.eta)))\n+ sf_id.append( float(self.idSF_manager_mu.getSF(l.pt,l.eta)))\n+ sf_iso.append( float(self.isoSF_manager_mu.getSF(l.pt,l.eta)))\n+ sf_trg_err.append(float(self.trgSF_manager_mu.getSF_err(l.pt,l.eta)))\n+ sf_id_err.append( float(self.idSF_manager_mu.getSF_err(l.pt,l.eta)))\n+ sf_iso_err.append(float(self.isoSF_manager_mu.getSF_err(l.pt,l.eta)))\n+ self.out.fillBranch(\"LepGood_IDeffSF\", sf_id)\n+ self.out.fillBranch(\"LepGood_ISOeffSF\", sf_iso)\n+ self.out.fillBranch(\"LepGood_trgSF\", sf_trg)\n+ self.out.fillBranch(\"LepGood_IDeffSF_err\", sf_id_err)\n+ self.out.fillBranch(\"LepGood_ISOeffSF_err\", sf_iso_err)\n+ self.out.fillBranch(\"LepGood_trgSF_err\", sf_trg_err)\n+ return True\n+\n+#########################################################\n+\n+\n # define modules using the syntax 'name = lambda : constructor' to avoid having them loaded when not needed\n \n lepSF = lambda : lepSFProducer( \"TightWP_2016\", \"CutBasedTight_2016\")\n trgSF = lambda : lepTrgSFProducer()\n+lep2016SF = lambda : lep2016SFProducer()","path":"WMass/python/postprocessing/examples/lepSFProducer.py","position":163,"original_position":163,"commit_id":"9d04f69e6ddbd2c74ffc101bbc74325718ffbfe8","original_commit_id":"9d04f69e6ddbd2c74ffc101bbc74325718ffbfe8","user":{"login":"emanueledimarco","id":4517974,"node_id":"MDQ6VXNlcjQ1MTc5NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/4517974?v=4","gravatar_id":"","url":"https://api.github.com/users/emanueledimarco","html_url":"https://github.com/emanueledimarco","followers_url":"https://api.github.com/users/emanueledimarco/followers","following_url":"https://api.github.com/users/emanueledimarco/following{/other_user}","gists_url":"https://api.github.com/users/emanueledimarco/gists{/gist_id}","starred_url":"https://api.github.com/users/emanueledimarco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/emanueledimarco/subscriptions","organizations_url":"https://api.github.com/users/emanueledimarco/orgs","repos_url":"https://api.github.com/users/emanueledimarco/repos","events_url":"https://api.github.com/users/emanueledimarco/events{/privacy}","received_events_url":"https://api.github.com/users/emanueledimarco/received_events","type":"User","site_admin":false},"body":"so summarizing the answer: YES","created_at":"2018-07-23T08:07:59Z","updated_at":"2018-07-23T08:07:59Z","html_url":"https://github.com/WMass/cmgtools-lite/pull/257#discussion_r204313271","pull_request_url":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/257","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/comments/204313271"},"html":{"href":"https://github.com/WMass/cmgtools-lite/pull/257#discussion_r204313271"},"pull_request":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/257"}},"in_reply_to_id":204295966},"pull_request":{"url":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/257","id":203009636,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDA5NjM2","html_url":"https://github.com/WMass/cmgtools-lite/pull/257","diff_url":"https://github.com/WMass/cmgtools-lite/pull/257.diff","patch_url":"https://github.com/WMass/cmgtools-lite/pull/257.patch","issue_url":"https://api.github.com/repos/WMass/cmgtools-lite/issues/257","number":257,"state":"open","locked":false,"title":"New lepton scale factors implementend in the friend trees","user":{"login":"cippy","id":11335859,"node_id":"MDQ6VXNlcjExMzM1ODU5","avatar_url":"https://avatars0.githubusercontent.com/u/11335859?v=4","gravatar_id":"","url":"https://api.github.com/users/cippy","html_url":"https://github.com/cippy","followers_url":"https://api.github.com/users/cippy/followers","following_url":"https://api.github.com/users/cippy/following{/other_user}","gists_url":"https://api.github.com/users/cippy/gists{/gist_id}","starred_url":"https://api.github.com/users/cippy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cippy/subscriptions","organizations_url":"https://api.github.com/users/cippy/orgs","repos_url":"https://api.github.com/users/cippy/repos","events_url":"https://api.github.com/users/cippy/events{/privacy}","received_events_url":"https://api.github.com/users/cippy/received_events","type":"User","site_admin":false},"body":"Some scripts to produce and plot lepton scale factors.\r\n There is an utility script, **WMass/python/plotter/makeScaleFactors2016.sh**, which just calls all the commands\r\n\r\nAt the moment there are 3 different scale factors: trigger, ID and iso (for electrons, at the moment only tigger SF are available)\r\nAdded a new module named lep2016SFProducer in **WMass/python/postprocessing/examples/lepSFProducer.py**. Friends are created successfully.\r\nThis module create 6 branches (3 sf and their uncertainty) with the results of the scale factor smoothing (might want to add a new branch with original unsmoothed ID scale factor).\r\nTested with following command on W and Z samples):\r\npython postproc_batch.py ../plotter/TREE_PATH_EOS/TREES_1LEP_80X_V3_WENUSKIM_V5/ ../plotter/test_postproc --friend --log friends_log -d WJetsToLNu_NLO_part1 -c 0 -N 5000\r\n\r\n@emanuele: I tried to squash some commits with git rebase, but when pushing to my remote repo I got an error saying that I had to git pull from my remote repo, which seemed related to the rebase. So I did it and apparently this step has splitted the commits again. I will try again next time, for now let's keep the commits as they are","created_at":"2018-07-21T13:23:21Z","updated_at":"2018-07-23T08:07:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78d9d8608046534404a619861fbb73f9f7826ea5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/257/commits","review_comments_url":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/257/comments","review_comment_url":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/WMass/cmgtools-lite/issues/257/comments","statuses_url":"https://api.github.com/repos/WMass/cmgtools-lite/statuses/9d04f69e6ddbd2c74ffc101bbc74325718ffbfe8","head":{"label":"cippy:8025_wmass_mciprian","ref":"8025_wmass_mciprian","sha":"9d04f69e6ddbd2c74ffc101bbc74325718ffbfe8","user":{"login":"cippy","id":11335859,"node_id":"MDQ6VXNlcjExMzM1ODU5","avatar_url":"https://avatars0.githubusercontent.com/u/11335859?v=4","gravatar_id":"","url":"https://api.github.com/users/cippy","html_url":"https://github.com/cippy","followers_url":"https://api.github.com/users/cippy/followers","following_url":"https://api.github.com/users/cippy/following{/other_user}","gists_url":"https://api.github.com/users/cippy/gists{/gist_id}","starred_url":"https://api.github.com/users/cippy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cippy/subscriptions","organizations_url":"https://api.github.com/users/cippy/orgs","repos_url":"https://api.github.com/users/cippy/repos","events_url":"https://api.github.com/users/cippy/events{/privacy}","received_events_url":"https://api.github.com/users/cippy/received_events","type":"User","site_admin":false},"repo":{"id":53125743,"node_id":"MDEwOlJlcG9zaXRvcnk1MzEyNTc0Mw==","name":"cmgtools-lite","full_name":"cippy/cmgtools-lite","owner":{"login":"cippy","id":11335859,"node_id":"MDQ6VXNlcjExMzM1ODU5","avatar_url":"https://avatars0.githubusercontent.com/u/11335859?v=4","gravatar_id":"","url":"https://api.github.com/users/cippy","html_url":"https://github.com/cippy","followers_url":"https://api.github.com/users/cippy/followers","following_url":"https://api.github.com/users/cippy/following{/other_user}","gists_url":"https://api.github.com/users/cippy/gists{/gist_id}","starred_url":"https://api.github.com/users/cippy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cippy/subscriptions","organizations_url":"https://api.github.com/users/cippy/orgs","repos_url":"https://api.github.com/users/cippy/repos","events_url":"https://api.github.com/users/cippy/events{/privacy}","received_events_url":"https://api.github.com/users/cippy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cippy/cmgtools-lite","description":"CMGTools as a subsystem, not as a CMSSW overlay","fork":true,"url":"https://api.github.com/repos/cippy/cmgtools-lite","forks_url":"https://api.github.com/repos/cippy/cmgtools-lite/forks","keys_url":"https://api.github.com/repos/cippy/cmgtools-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cippy/cmgtools-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cippy/cmgtools-lite/teams","hooks_url":"https://api.github.com/repos/cippy/cmgtools-lite/hooks","issue_events_url":"https://api.github.com/repos/cippy/cmgtools-lite/issues/events{/number}","events_url":"https://api.github.com/repos/cippy/cmgtools-lite/events","assignees_url":"https://api.github.com/repos/cippy/cmgtools-lite/assignees{/user}","branches_url":"https://api.github.com/repos/cippy/cmgtools-lite/branches{/branch}","tags_url":"https://api.github.com/repos/cippy/cmgtools-lite/tags","blobs_url":"https://api.github.com/repos/cippy/cmgtools-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cippy/cmgtools-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cippy/cmgtools-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/cippy/cmgtools-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cippy/cmgtools-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/cippy/cmgtools-lite/languages","stargazers_url":"https://api.github.com/repos/cippy/cmgtools-lite/stargazers","contributors_url":"https://api.github.com/repos/cippy/cmgtools-lite/contributors","subscribers_url":"https://api.github.com/repos/cippy/cmgtools-lite/subscribers","subscription_url":"https://api.github.com/repos/cippy/cmgtools-lite/subscription","commits_url":"https://api.github.com/repos/cippy/cmgtools-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/cippy/cmgtools-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/cippy/cmgtools-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/cippy/cmgtools-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/cippy/cmgtools-lite/contents/{+path}","compare_url":"https://api.github.com/repos/cippy/cmgtools-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cippy/cmgtools-lite/merges","archive_url":"https://api.github.com/repos/cippy/cmgtools-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cippy/cmgtools-lite/downloads","issues_url":"https://api.github.com/repos/cippy/cmgtools-lite/issues{/number}","pulls_url":"https://api.github.com/repos/cippy/cmgtools-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/cippy/cmgtools-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/cippy/cmgtools-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cippy/cmgtools-lite/labels{/name}","releases_url":"https://api.github.com/repos/cippy/cmgtools-lite/releases{/id}","deployments_url":"https://api.github.com/repos/cippy/cmgtools-lite/deployments","created_at":"2016-03-04T09:57:52Z","updated_at":"2016-03-04T09:57:57Z","pushed_at":"2018-07-21T14:36:06Z","git_url":"git://github.com/cippy/cmgtools-lite.git","ssh_url":"[email protected]:cippy/cmgtools-lite.git","clone_url":"https://github.com/cippy/cmgtools-lite.git","svn_url":"https://github.com/cippy/cmgtools-lite","homepage":null,"size":65564,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"76X"}},"base":{"label":"WMass:80X","ref":"80X","sha":"be913a4f44a3e078c592d5e42b4fd8369d4946a1","user":{"login":"WMass","id":33157985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTU3OTg1","avatar_url":"https://avatars3.githubusercontent.com/u/33157985?v=4","gravatar_id":"","url":"https://api.github.com/users/WMass","html_url":"https://github.com/WMass","followers_url":"https://api.github.com/users/WMass/followers","following_url":"https://api.github.com/users/WMass/following{/other_user}","gists_url":"https://api.github.com/users/WMass/gists{/gist_id}","starred_url":"https://api.github.com/users/WMass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WMass/subscriptions","organizations_url":"https://api.github.com/users/WMass/orgs","repos_url":"https://api.github.com/users/WMass/repos","events_url":"https://api.github.com/users/WMass/events{/privacy}","received_events_url":"https://api.github.com/users/WMass/received_events","type":"Organization","site_admin":false},"repo":{"id":108602987,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2MDI5ODc=","name":"cmgtools-lite","full_name":"WMass/cmgtools-lite","owner":{"login":"WMass","id":33157985,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTU3OTg1","avatar_url":"https://avatars3.githubusercontent.com/u/33157985?v=4","gravatar_id":"","url":"https://api.github.com/users/WMass","html_url":"https://github.com/WMass","followers_url":"https://api.github.com/users/WMass/followers","following_url":"https://api.github.com/users/WMass/following{/other_user}","gists_url":"https://api.github.com/users/WMass/gists{/gist_id}","starred_url":"https://api.github.com/users/WMass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WMass/subscriptions","organizations_url":"https://api.github.com/users/WMass/orgs","repos_url":"https://api.github.com/users/WMass/repos","events_url":"https://api.github.com/users/WMass/events{/privacy}","received_events_url":"https://api.github.com/users/WMass/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/WMass/cmgtools-lite","description":"CMGTools as a subsystem, not as a CMSSW overlay","fork":true,"url":"https://api.github.com/repos/WMass/cmgtools-lite","forks_url":"https://api.github.com/repos/WMass/cmgtools-lite/forks","keys_url":"https://api.github.com/repos/WMass/cmgtools-lite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/WMass/cmgtools-lite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/WMass/cmgtools-lite/teams","hooks_url":"https://api.github.com/repos/WMass/cmgtools-lite/hooks","issue_events_url":"https://api.github.com/repos/WMass/cmgtools-lite/issues/events{/number}","events_url":"https://api.github.com/repos/WMass/cmgtools-lite/events","assignees_url":"https://api.github.com/repos/WMass/cmgtools-lite/assignees{/user}","branches_url":"https://api.github.com/repos/WMass/cmgtools-lite/branches{/branch}","tags_url":"https://api.github.com/repos/WMass/cmgtools-lite/tags","blobs_url":"https://api.github.com/repos/WMass/cmgtools-lite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/WMass/cmgtools-lite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/WMass/cmgtools-lite/git/refs{/sha}","trees_url":"https://api.github.com/repos/WMass/cmgtools-lite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/WMass/cmgtools-lite/statuses/{sha}","languages_url":"https://api.github.com/repos/WMass/cmgtools-lite/languages","stargazers_url":"https://api.github.com/repos/WMass/cmgtools-lite/stargazers","contributors_url":"https://api.github.com/repos/WMass/cmgtools-lite/contributors","subscribers_url":"https://api.github.com/repos/WMass/cmgtools-lite/subscribers","subscription_url":"https://api.github.com/repos/WMass/cmgtools-lite/subscription","commits_url":"https://api.github.com/repos/WMass/cmgtools-lite/commits{/sha}","git_commits_url":"https://api.github.com/repos/WMass/cmgtools-lite/git/commits{/sha}","comments_url":"https://api.github.com/repos/WMass/cmgtools-lite/comments{/number}","issue_comment_url":"https://api.github.com/repos/WMass/cmgtools-lite/issues/comments{/number}","contents_url":"https://api.github.com/repos/WMass/cmgtools-lite/contents/{+path}","compare_url":"https://api.github.com/repos/WMass/cmgtools-lite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/WMass/cmgtools-lite/merges","archive_url":"https://api.github.com/repos/WMass/cmgtools-lite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/WMass/cmgtools-lite/downloads","issues_url":"https://api.github.com/repos/WMass/cmgtools-lite/issues{/number}","pulls_url":"https://api.github.com/repos/WMass/cmgtools-lite/pulls{/number}","milestones_url":"https://api.github.com/repos/WMass/cmgtools-lite/milestones{/number}","notifications_url":"https://api.github.com/repos/WMass/cmgtools-lite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/WMass/cmgtools-lite/labels{/name}","releases_url":"https://api.github.com/repos/WMass/cmgtools-lite/releases{/id}","deployments_url":"https://api.github.com/repos/WMass/cmgtools-lite/deployments","created_at":"2017-10-27T22:56:41Z","updated_at":"2018-07-20T15:18:05Z","pushed_at":"2018-07-21T14:36:07Z","git_url":"git://github.com/WMass/cmgtools-lite.git","ssh_url":"[email protected]:WMass/cmgtools-lite.git","clone_url":"https://github.com/WMass/cmgtools-lite.git","svn_url":"https://github.com/WMass/cmgtools-lite","homepage":null,"size":64678,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":2,"open_issues":3,"watchers":0,"default_branch":"80X"}},"_links":{"self":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/257"},"html":{"href":"https://github.com/WMass/cmgtools-lite/pull/257"},"issue":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/issues/257"},"comments":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/issues/257/comments"},"review_comments":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/257/comments"},"review_comment":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/pulls/257/commits"},"statuses":{"href":"https://api.github.com/repos/WMass/cmgtools-lite/statuses/9d04f69e6ddbd2c74ffc101bbc74325718ffbfe8"}},"author_association":"NONE"}}

8002333078

{"actor":{"display_login":"emanueledimarco"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/191538460","pull_request_review_id":124130054,"id":191538460,"diff_hunk":"@@ -108,7 +108,12 @@ resources:\n nodeMetadata: SECURE\n {% endif %}\n oauthScopes:\n- - gke-default\n+ - https://www.googleapis.com/auth/devstorage.read_only\n+ - https://www.googleapis.com/auth/logging.write\n+ - https://www.googleapis.com/auth/monitoring\n+ - https://www.googleapis.com/auth/service.management.readonly\n+ - https://www.googleapis.com/auth/servicecontrol","path":"docs/gke/configs/cluster.jinja","position":107,"original_position":9,"commit_id":"74bf7d7817aebf0193ca32beecee1d7855409876","original_commit_id":"74bf7d7817aebf0193ca32beecee1d7855409876","user":{"login":"jlewi","id":777219,"avatar_url":"https://avatars3.githubusercontent.com/u/777219?v=4","gravatar_id":"","url":"https://api.github.com/users/jlewi","html_url":"https://github.com/jlewi","followers_url":"https://api.github.com/users/jlewi/followers","following_url":"https://api.github.com/users/jlewi/following{/other_user}","gists_url":"https://api.github.com/users/jlewi/gists{/gist_id}","starred_url":"https://api.github.com/users/jlewi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlewi/subscriptions","organizations_url":"https://api.github.com/users/jlewi/orgs","repos_url":"https://api.github.com/users/jlewi/repos","events_url":"https://api.github.com/users/jlewi/events{/privacy}","received_events_url":"https://api.github.com/users/jlewi/received_events","type":"User","site_admin":false},"body":"logging and monitoring make sense for the logging and monitoring agents but what about the others?\r\n\r\nI assume devstorage is for GCR?\r\n\r\nWhy do we need service.management, servicecontrol, and trace?\r\n\r\n","created_at":"2018-05-29T19:04:46Z","updated_at":"2018-05-29T19:04:46Z","html_url":"https://github.com/kubeflow/kubeflow/pull/879#discussion_r191538460","pull_request_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/879","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments/191538460"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/879#discussion_r191538460"},"pull_request":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/879"}}},"pull_request":{"url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/879","id":190680770,"html_url":"https://github.com/kubeflow/kubeflow/pull/879","diff_url":"https://github.com/kubeflow/kubeflow/pull/879.diff","patch_url":"https://github.com/kubeflow/kubeflow/pull/879.patch","issue_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/879","number":879,"state":"open","locked":false,"title":"Add GKE Security Features to Deployment Manager config","user":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"body":"Add option for\r\n* Private Clusters\r\n* Separate Service Account\r\n* masterIpv4CidrBlock\r\n* Pod Security Policy\r\n* Secure Node Metadata\r\n* Authorized Networks for k8s Master\r\n* Reduce oauth scopes for worker nodes and replace it with gke-default\r\n\r\n/cc @jlewi @kunmingg\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/kubeflow/kubeflow/879)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-05-25T19:53:51Z","updated_at":"2018-05-29T19:04:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1dc41a3d97caf22e73bdb01ed0a84208563efbd2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":796399084,"url":"https://api.github.com/repos/kubeflow/kubeflow/labels/size/L","name":"size/L","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/879/commits","review_comments_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/879/comments","review_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/879/comments","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/74bf7d7817aebf0193ca32beecee1d7855409876","head":{"label":"ankushagarwal:securestuff","ref":"securestuff","sha":"74bf7d7817aebf0193ca32beecee1d7855409876","user":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"repo":{"id":121576093,"name":"kubeflow","full_name":"ankushagarwal/kubeflow","owner":{"login":"ankushagarwal","id":796949,"avatar_url":"https://avatars2.githubusercontent.com/u/796949?v=4","gravatar_id":"","url":"https://api.github.com/users/ankushagarwal","html_url":"https://github.com/ankushagarwal","followers_url":"https://api.github.com/users/ankushagarwal/followers","following_url":"https://api.github.com/users/ankushagarwal/following{/other_user}","gists_url":"https://api.github.com/users/ankushagarwal/gists{/gist_id}","starred_url":"https://api.github.com/users/ankushagarwal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankushagarwal/subscriptions","organizations_url":"https://api.github.com/users/ankushagarwal/orgs","repos_url":"https://api.github.com/users/ankushagarwal/repos","events_url":"https://api.github.com/users/ankushagarwal/events{/privacy}","received_events_url":"https://api.github.com/users/ankushagarwal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ankushagarwal/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":true,"url":"https://api.github.com/repos/ankushagarwal/kubeflow","forks_url":"https://api.github.com/repos/ankushagarwal/kubeflow/forks","keys_url":"https://api.github.com/repos/ankushagarwal/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ankushagarwal/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ankushagarwal/kubeflow/teams","hooks_url":"https://api.github.com/repos/ankushagarwal/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/ankushagarwal/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/ankushagarwal/kubeflow/events","assignees_url":"https://api.github.com/repos/ankushagarwal/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/ankushagarwal/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/ankushagarwal/kubeflow/tags","blobs_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ankushagarwal/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/ankushagarwal/kubeflow/languages","stargazers_url":"https://api.github.com/repos/ankushagarwal/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/ankushagarwal/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/ankushagarwal/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/ankushagarwal/kubeflow/subscription","commits_url":"https://api.github.com/repos/ankushagarwal/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/ankushagarwal/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/ankushagarwal/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/ankushagarwal/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/ankushagarwal/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/ankushagarwal/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ankushagarwal/kubeflow/merges","archive_url":"https://api.github.com/repos/ankushagarwal/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ankushagarwal/kubeflow/downloads","issues_url":"https://api.github.com/repos/ankushagarwal/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/ankushagarwal/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/ankushagarwal/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/ankushagarwal/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ankushagarwal/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/ankushagarwal/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/ankushagarwal/kubeflow/deployments","created_at":"2018-02-15T00:09:47Z","updated_at":"2018-05-29T17:41:25Z","pushed_at":"2018-05-29T18:56:39Z","git_url":"git://github.com/ankushagarwal/kubeflow.git","ssh_url":"[email protected]:ankushagarwal/kubeflow.git","clone_url":"https://github.com/ankushagarwal/kubeflow.git","svn_url":"https://github.com/ankushagarwal/kubeflow","homepage":"","size":121007,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubeflow:master","ref":"master","sha":"43dd4de9407ac0314625fa3470841f8e32874fd9","user":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"repo":{"id":112647343,"name":"kubeflow","full_name":"kubeflow/kubeflow","owner":{"login":"kubeflow","id":33164907,"avatar_url":"https://avatars0.githubusercontent.com/u/33164907?v=4","gravatar_id":"","url":"https://api.github.com/users/kubeflow","html_url":"https://github.com/kubeflow","followers_url":"https://api.github.com/users/kubeflow/followers","following_url":"https://api.github.com/users/kubeflow/following{/other_user}","gists_url":"https://api.github.com/users/kubeflow/gists{/gist_id}","starred_url":"https://api.github.com/users/kubeflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubeflow/subscriptions","organizations_url":"https://api.github.com/users/kubeflow/orgs","repos_url":"https://api.github.com/users/kubeflow/repos","events_url":"https://api.github.com/users/kubeflow/events{/privacy}","received_events_url":"https://api.github.com/users/kubeflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubeflow/kubeflow","description":"Machine Learning Toolkit for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubeflow/kubeflow","forks_url":"https://api.github.com/repos/kubeflow/kubeflow/forks","keys_url":"https://api.github.com/repos/kubeflow/kubeflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubeflow/kubeflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubeflow/kubeflow/teams","hooks_url":"https://api.github.com/repos/kubeflow/kubeflow/hooks","issue_events_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/events{/number}","events_url":"https://api.github.com/repos/kubeflow/kubeflow/events","assignees_url":"https://api.github.com/repos/kubeflow/kubeflow/assignees{/user}","branches_url":"https://api.github.com/repos/kubeflow/kubeflow/branches{/branch}","tags_url":"https://api.github.com/repos/kubeflow/kubeflow/tags","blobs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubeflow/kubeflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubeflow/kubeflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubeflow/kubeflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubeflow/kubeflow/statuses/{sha}","languages_url":"https://api.github.com/repos/kubeflow/kubeflow/languages","stargazers_url":"https://api.github.com/repos/kubeflow/kubeflow/stargazers","contributors_url":"https://api.github.com/repos/kubeflow/kubeflow/contributors","subscribers_url":"https://api.github.com/repos/kubeflow/kubeflow/subscribers","subscription_url":"https://api.github.com/repos/kubeflow/kubeflow/subscription","commits_url":"https://api.github.com/repos/kubeflow/kubeflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubeflow/kubeflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubeflow/kubeflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubeflow/kubeflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubeflow/kubeflow/contents/{+path}","compare_url":"https://api.github.com/repos/kubeflow/kubeflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubeflow/kubeflow/merges","archive_url":"https://api.github.com/repos/kubeflow/kubeflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubeflow/kubeflow/downloads","issues_url":"https://api.github.com/repos/kubeflow/kubeflow/issues{/number}","pulls_url":"https://api.github.com/repos/kubeflow/kubeflow/pulls{/number}","milestones_url":"https://api.github.com/repos/kubeflow/kubeflow/milestones{/number}","notifications_url":"https://api.github.com/repos/kubeflow/kubeflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubeflow/kubeflow/labels{/name}","releases_url":"https://api.github.com/repos/kubeflow/kubeflow/releases{/id}","deployments_url":"https://api.github.com/repos/kubeflow/kubeflow/deployments","created_at":"2017-11-30T18:44:19Z","updated_at":"2018-05-29T18:11:39Z","pushed_at":"2018-05-29T19:02:39Z","git_url":"git://github.com/kubeflow/kubeflow.git","ssh_url":"[email protected]:kubeflow/kubeflow.git","clone_url":"https://github.com/kubeflow/kubeflow.git","svn_url":"https://github.com/kubeflow/kubeflow","homepage":"","size":122012,"stargazers_count":3684,"watchers_count":3684,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":444,"mirror_url":null,"archived":false,"open_issues_count":209,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":444,"open_issues":209,"watchers":3684,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/879"},"html":{"href":"https://github.com/kubeflow/kubeflow/pull/879"},"issue":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/879"},"comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/issues/879/comments"},"review_comments":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/879/comments"},"review_comment":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubeflow/kubeflow/pulls/879/commits"},"statuses":{"href":"https://api.github.com/repos/kubeflow/kubeflow/statuses/74bf7d7817aebf0193ca32beecee1d7855409876"}},"author_association":"MEMBER"}}

7745667194

{"actor":{"display_login":"jlewi"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/comments/205749716","pull_request_review_id":141083227,"id":205749716,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTc0OTcxNg==","diff_hunk":"@@ -241,6 +241,163 @@ definitions:\n - version\n - db_timestamp\n \n+ deleted_user:\n+ type: object\n+ properties:\n+ id:\n+ type: string\n+ format: uuid\n+ username:\n+ type: string\n+ email:\n+ type: string\n+ msisdn:\n+ type: string\n+ reason:\n+ type: string\n+ created_at:\n+ type: string\n+ format: date-time\n+ readOnly: true\n+ updated_at:\n+ type: string\n+ format: date-time\n+ readOnly: true\n+ deleted_at:\n+ type: string\n+ format: date-time\n+ deleter_id:\n+ type: string\n+ format: uuid\n+ required:\n+ - id\n+ - username","path":"swagger/user_data_store.yml","position":34,"original_position":34,"commit_id":"676f37488bea4075b56c9150d45b4f0498605d34","original_commit_id":"676f37488bea4075b56c9150d45b4f0498605d34","user":{"login":"cobusc","id":574390,"node_id":"MDQ6VXNlcjU3NDM5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/574390?v=4","gravatar_id":"","url":"https://api.github.com/users/cobusc","html_url":"https://github.com/cobusc","followers_url":"https://api.github.com/users/cobusc/followers","following_url":"https://api.github.com/users/cobusc/following{/other_user}","gists_url":"https://api.github.com/users/cobusc/gists{/gist_id}","starred_url":"https://api.github.com/users/cobusc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cobusc/subscriptions","organizations_url":"https://api.github.com/users/cobusc/orgs","repos_url":"https://api.github.com/users/cobusc/repos","events_url":"https://api.github.com/users/cobusc/events{/privacy}","received_events_url":"https://api.github.com/users/cobusc/received_events","type":"User","site_admin":false},"body":"Reason is also required","created_at":"2018-07-27T11:56:06Z","updated_at":"2018-07-27T11:56:06Z","html_url":"https://github.com/girleffect/core-user-data-store/pull/33#discussion_r205749716","pull_request_url":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/33","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/comments/205749716"},"html":{"href":"https://github.com/girleffect/core-user-data-store/pull/33#discussion_r205749716"},"pull_request":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/33"}}},"pull_request":{"url":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/33","id":204410410,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NDEwNDEw","html_url":"https://github.com/girleffect/core-user-data-store/pull/33","diff_url":"https://github.com/girleffect/core-user-data-store/pull/33.diff","patch_url":"https://github.com/girleffect/core-user-data-store/pull/33.patch","issue_url":"https://api.github.com/repos/girleffect/core-user-data-store/issues/33","number":33,"state":"open","locked":false,"title":"Feature/geinfra 122","user":{"login":"AltusBarry","id":10414305,"node_id":"MDQ6VXNlcjEwNDE0MzA1","avatar_url":"https://avatars1.githubusercontent.com/u/10414305?v=4","gravatar_id":"","url":"https://api.github.com/users/AltusBarry","html_url":"https://github.com/AltusBarry","followers_url":"https://api.github.com/users/AltusBarry/followers","following_url":"https://api.github.com/users/AltusBarry/following{/other_user}","gists_url":"https://api.github.com/users/AltusBarry/gists{/gist_id}","starred_url":"https://api.github.com/users/AltusBarry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AltusBarry/subscriptions","organizations_url":"https://api.github.com/users/AltusBarry/orgs","repos_url":"https://api.github.com/users/AltusBarry/repos","events_url":"https://api.github.com/users/AltusBarry/events{/privacy}","received_events_url":"https://api.github.com/users/AltusBarry/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-27T11:54:36Z","updated_at":"2018-07-27T11:56:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b584d9ce730fd807298082356ae5bc98cfe92430","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/33/commits","review_comments_url":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/33/comments","review_comment_url":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/comments{/number}","comments_url":"https://api.github.com/repos/girleffect/core-user-data-store/issues/33/comments","statuses_url":"https://api.github.com/repos/girleffect/core-user-data-store/statuses/676f37488bea4075b56c9150d45b4f0498605d34","head":{"label":"girleffect:feature/GEINFRA-122","ref":"feature/GEINFRA-122","sha":"676f37488bea4075b56c9150d45b4f0498605d34","user":{"login":"girleffect","id":33266906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjY2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/33266906?v=4","gravatar_id":"","url":"https://api.github.com/users/girleffect","html_url":"https://github.com/girleffect","followers_url":"https://api.github.com/users/girleffect/followers","following_url":"https://api.github.com/users/girleffect/following{/other_user}","gists_url":"https://api.github.com/users/girleffect/gists{/gist_id}","starred_url":"https://api.github.com/users/girleffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girleffect/subscriptions","organizations_url":"https://api.github.com/users/girleffect/orgs","repos_url":"https://api.github.com/users/girleffect/repos","events_url":"https://api.github.com/users/girleffect/events{/privacy}","received_events_url":"https://api.github.com/users/girleffect/received_events","type":"Organization","site_admin":false},"repo":{"id":112724678,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3MjQ2Nzg=","name":"core-user-data-store","full_name":"girleffect/core-user-data-store","owner":{"login":"girleffect","id":33266906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjY2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/33266906?v=4","gravatar_id":"","url":"https://api.github.com/users/girleffect","html_url":"https://github.com/girleffect","followers_url":"https://api.github.com/users/girleffect/followers","following_url":"https://api.github.com/users/girleffect/following{/other_user}","gists_url":"https://api.github.com/users/girleffect/gists{/gist_id}","starred_url":"https://api.github.com/users/girleffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girleffect/subscriptions","organizations_url":"https://api.github.com/users/girleffect/orgs","repos_url":"https://api.github.com/users/girleffect/repos","events_url":"https://api.github.com/users/girleffect/events{/privacy}","received_events_url":"https://api.github.com/users/girleffect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/girleffect/core-user-data-store","description":null,"fork":false,"url":"https://api.github.com/repos/girleffect/core-user-data-store","forks_url":"https://api.github.com/repos/girleffect/core-user-data-store/forks","keys_url":"https://api.github.com/repos/girleffect/core-user-data-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girleffect/core-user-data-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girleffect/core-user-data-store/teams","hooks_url":"https://api.github.com/repos/girleffect/core-user-data-store/hooks","issue_events_url":"https://api.github.com/repos/girleffect/core-user-data-store/issues/events{/number}","events_url":"https://api.github.com/repos/girleffect/core-user-data-store/events","assignees_url":"https://api.github.com/repos/girleffect/core-user-data-store/assignees{/user}","branches_url":"https://api.github.com/repos/girleffect/core-user-data-store/branches{/branch}","tags_url":"https://api.github.com/repos/girleffect/core-user-data-store/tags","blobs_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girleffect/core-user-data-store/statuses/{sha}","languages_url":"https://api.github.com/repos/girleffect/core-user-data-store/languages","stargazers_url":"https://api.github.com/repos/girleffect/core-user-data-store/stargazers","contributors_url":"https://api.github.com/repos/girleffect/core-user-data-store/contributors","subscribers_url":"https://api.github.com/repos/girleffect/core-user-data-store/subscribers","subscription_url":"https://api.github.com/repos/girleffect/core-user-data-store/subscription","commits_url":"https://api.github.com/repos/girleffect/core-user-data-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/girleffect/core-user-data-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/girleffect/core-user-data-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/girleffect/core-user-data-store/contents/{+path}","compare_url":"https://api.github.com/repos/girleffect/core-user-data-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girleffect/core-user-data-store/merges","archive_url":"https://api.github.com/repos/girleffect/core-user-data-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girleffect/core-user-data-store/downloads","issues_url":"https://api.github.com/repos/girleffect/core-user-data-store/issues{/number}","pulls_url":"https://api.github.com/repos/girleffect/core-user-data-store/pulls{/number}","milestones_url":"https://api.github.com/repos/girleffect/core-user-data-store/milestones{/number}","notifications_url":"https://api.github.com/repos/girleffect/core-user-data-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girleffect/core-user-data-store/labels{/name}","releases_url":"https://api.github.com/repos/girleffect/core-user-data-store/releases{/id}","deployments_url":"https://api.github.com/repos/girleffect/core-user-data-store/deployments","created_at":"2017-12-01T10:02:31Z","updated_at":"2018-07-25T11:48:55Z","pushed_at":"2018-07-27T11:54:36Z","git_url":"git://github.com/girleffect/core-user-data-store.git","ssh_url":"[email protected]:girleffect/core-user-data-store.git","clone_url":"https://github.com/girleffect/core-user-data-store.git","svn_url":"https://github.com/girleffect/core-user-data-store","homepage":null,"size":507,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"girleffect:develop","ref":"develop","sha":"ccfbd249912c2a8d64bc12d610caebb7e13efc24","user":{"login":"girleffect","id":33266906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjY2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/33266906?v=4","gravatar_id":"","url":"https://api.github.com/users/girleffect","html_url":"https://github.com/girleffect","followers_url":"https://api.github.com/users/girleffect/followers","following_url":"https://api.github.com/users/girleffect/following{/other_user}","gists_url":"https://api.github.com/users/girleffect/gists{/gist_id}","starred_url":"https://api.github.com/users/girleffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girleffect/subscriptions","organizations_url":"https://api.github.com/users/girleffect/orgs","repos_url":"https://api.github.com/users/girleffect/repos","events_url":"https://api.github.com/users/girleffect/events{/privacy}","received_events_url":"https://api.github.com/users/girleffect/received_events","type":"Organization","site_admin":false},"repo":{"id":112724678,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI3MjQ2Nzg=","name":"core-user-data-store","full_name":"girleffect/core-user-data-store","owner":{"login":"girleffect","id":33266906,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjY2OTA2","avatar_url":"https://avatars2.githubusercontent.com/u/33266906?v=4","gravatar_id":"","url":"https://api.github.com/users/girleffect","html_url":"https://github.com/girleffect","followers_url":"https://api.github.com/users/girleffect/followers","following_url":"https://api.github.com/users/girleffect/following{/other_user}","gists_url":"https://api.github.com/users/girleffect/gists{/gist_id}","starred_url":"https://api.github.com/users/girleffect/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/girleffect/subscriptions","organizations_url":"https://api.github.com/users/girleffect/orgs","repos_url":"https://api.github.com/users/girleffect/repos","events_url":"https://api.github.com/users/girleffect/events{/privacy}","received_events_url":"https://api.github.com/users/girleffect/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/girleffect/core-user-data-store","description":null,"fork":false,"url":"https://api.github.com/repos/girleffect/core-user-data-store","forks_url":"https://api.github.com/repos/girleffect/core-user-data-store/forks","keys_url":"https://api.github.com/repos/girleffect/core-user-data-store/keys{/key_id}","collaborators_url":"https://api.github.com/repos/girleffect/core-user-data-store/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/girleffect/core-user-data-store/teams","hooks_url":"https://api.github.com/repos/girleffect/core-user-data-store/hooks","issue_events_url":"https://api.github.com/repos/girleffect/core-user-data-store/issues/events{/number}","events_url":"https://api.github.com/repos/girleffect/core-user-data-store/events","assignees_url":"https://api.github.com/repos/girleffect/core-user-data-store/assignees{/user}","branches_url":"https://api.github.com/repos/girleffect/core-user-data-store/branches{/branch}","tags_url":"https://api.github.com/repos/girleffect/core-user-data-store/tags","blobs_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/refs{/sha}","trees_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/trees{/sha}","statuses_url":"https://api.github.com/repos/girleffect/core-user-data-store/statuses/{sha}","languages_url":"https://api.github.com/repos/girleffect/core-user-data-store/languages","stargazers_url":"https://api.github.com/repos/girleffect/core-user-data-store/stargazers","contributors_url":"https://api.github.com/repos/girleffect/core-user-data-store/contributors","subscribers_url":"https://api.github.com/repos/girleffect/core-user-data-store/subscribers","subscription_url":"https://api.github.com/repos/girleffect/core-user-data-store/subscription","commits_url":"https://api.github.com/repos/girleffect/core-user-data-store/commits{/sha}","git_commits_url":"https://api.github.com/repos/girleffect/core-user-data-store/git/commits{/sha}","comments_url":"https://api.github.com/repos/girleffect/core-user-data-store/comments{/number}","issue_comment_url":"https://api.github.com/repos/girleffect/core-user-data-store/issues/comments{/number}","contents_url":"https://api.github.com/repos/girleffect/core-user-data-store/contents/{+path}","compare_url":"https://api.github.com/repos/girleffect/core-user-data-store/compare/{base}...{head}","merges_url":"https://api.github.com/repos/girleffect/core-user-data-store/merges","archive_url":"https://api.github.com/repos/girleffect/core-user-data-store/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/girleffect/core-user-data-store/downloads","issues_url":"https://api.github.com/repos/girleffect/core-user-data-store/issues{/number}","pulls_url":"https://api.github.com/repos/girleffect/core-user-data-store/pulls{/number}","milestones_url":"https://api.github.com/repos/girleffect/core-user-data-store/milestones{/number}","notifications_url":"https://api.github.com/repos/girleffect/core-user-data-store/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/girleffect/core-user-data-store/labels{/name}","releases_url":"https://api.github.com/repos/girleffect/core-user-data-store/releases{/id}","deployments_url":"https://api.github.com/repos/girleffect/core-user-data-store/deployments","created_at":"2017-12-01T10:02:31Z","updated_at":"2018-07-25T11:48:55Z","pushed_at":"2018-07-27T11:54:36Z","git_url":"git://github.com/girleffect/core-user-data-store.git","ssh_url":"[email protected]:girleffect/core-user-data-store.git","clone_url":"https://github.com/girleffect/core-user-data-store.git","svn_url":"https://github.com/girleffect/core-user-data-store","homepage":null,"size":507,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/33"},"html":{"href":"https://github.com/girleffect/core-user-data-store/pull/33"},"issue":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/issues/33"},"comments":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/issues/33/comments"},"review_comments":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/33/comments"},"review_comment":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/pulls/33/commits"},"statuses":{"href":"https://api.github.com/repos/girleffect/core-user-data-store/statuses/676f37488bea4075b56c9150d45b4f0498605d34"}},"author_association":"CONTRIBUTOR"}}

8028182569

{"actor":{"display_login":"cobusc"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/182305859","pull_request_review_id":113073760,"id":182305859,"diff_hunk":"@@ -144,6 +144,9 @@ type agent interface {\n \t// supported by the agent.\n \tcapabilities() capabilities\n \n+\t// disconnect will disconnect the connection to the agent\n+\tdisconnect()","path":"virtcontainers/agent.go","position":5,"original_position":5,"commit_id":"ef479309824641a0a2bf1e0f8160859a0186e61c","original_commit_id":"ef479309824641a0a2bf1e0f8160859a0186e61c","user":{"login":"amshinde","id":7132811,"avatar_url":"https://avatars0.githubusercontent.com/u/7132811?v=4","gravatar_id":"","url":"https://api.github.com/users/amshinde","html_url":"https://github.com/amshinde","followers_url":"https://api.github.com/users/amshinde/followers","following_url":"https://api.github.com/users/amshinde/following{/other_user}","gists_url":"https://api.github.com/users/amshinde/gists{/gist_id}","starred_url":"https://api.github.com/users/amshinde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amshinde/subscriptions","organizations_url":"https://api.github.com/users/amshinde/orgs","repos_url":"https://api.github.com/users/amshinde/repos","events_url":"https://api.github.com/users/amshinde/events{/privacy}","received_events_url":"https://api.github.com/users/amshinde/received_events","type":"User","site_admin":false},"body":"@bergwolf Will be useful to return the error to atleast log it even if it we cannot recover.","created_at":"2018-04-18T04:30:41Z","updated_at":"2018-04-18T04:30:41Z","html_url":"https://github.com/kata-containers/runtime/pull/218#discussion_r182305859","pull_request_url":"https://api.github.com/repos/kata-containers/runtime/pulls/218","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/182305859"},"html":{"href":"https://github.com/kata-containers/runtime/pull/218#discussion_r182305859"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/218"}},"in_reply_to_id":182096328},"pull_request":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/218","id":181853453,"html_url":"https://github.com/kata-containers/runtime/pull/218","diff_url":"https://github.com/kata-containers/runtime/pull/218.diff","patch_url":"https://github.com/kata-containers/runtime/pull/218.patch","issue_url":"https://api.github.com/repos/kata-containers/runtime/issues/218","number":218,"state":"open","locked":false,"title":"api: add fetchsandbox and release sandbox","user":{"login":"bergwolf","id":88972,"avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"body":"`FetchSandbox()` allows a caller to retrieve sandbox with its ID. `sandbox.Release()` allows a caller to actively drop the runtime-agent connection. A new config option `LongLiveConn` is added to kata agent's config. When set, the connection to agent is kept across multiple calls to the agent and caller is expected to call `sandbox.Release()` to explicitly close the connection.","created_at":"2018-04-16T13:03:15Z","updated_at":"2018-04-18T04:30:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b131b6019e7b94e49d91f2daffc370f20ffcccfc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":837054292,"url":"https://api.github.com/repos/kata-containers/runtime/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/runtime/pulls/218/commits","review_comments_url":"https://api.github.com/repos/kata-containers/runtime/pulls/218/comments","review_comment_url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/runtime/issues/218/comments","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/ef479309824641a0a2bf1e0f8160859a0186e61c","head":{"label":"bergwolf:sandbox_api","ref":"sandbox_api","sha":"ef479309824641a0a2bf1e0f8160859a0186e61c","user":{"login":"bergwolf","id":88972,"avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"repo":{"id":119074038,"name":"kata-runtime","full_name":"bergwolf/kata-runtime","owner":{"login":"bergwolf","id":88972,"avatar_url":"https://avatars0.githubusercontent.com/u/88972?v=4","gravatar_id":"","url":"https://api.github.com/users/bergwolf","html_url":"https://github.com/bergwolf","followers_url":"https://api.github.com/users/bergwolf/followers","following_url":"https://api.github.com/users/bergwolf/following{/other_user}","gists_url":"https://api.github.com/users/bergwolf/gists{/gist_id}","starred_url":"https://api.github.com/users/bergwolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bergwolf/subscriptions","organizations_url":"https://api.github.com/users/bergwolf/orgs","repos_url":"https://api.github.com/users/bergwolf/repos","events_url":"https://api.github.com/users/bergwolf/events{/privacy}","received_events_url":"https://api.github.com/users/bergwolf/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bergwolf/kata-runtime","description":"Kata Containers runtimes","fork":true,"url":"https://api.github.com/repos/bergwolf/kata-runtime","forks_url":"https://api.github.com/repos/bergwolf/kata-runtime/forks","keys_url":"https://api.github.com/repos/bergwolf/kata-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bergwolf/kata-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bergwolf/kata-runtime/teams","hooks_url":"https://api.github.com/repos/bergwolf/kata-runtime/hooks","issue_events_url":"https://api.github.com/repos/bergwolf/kata-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/bergwolf/kata-runtime/events","assignees_url":"https://api.github.com/repos/bergwolf/kata-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/bergwolf/kata-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/bergwolf/kata-runtime/tags","blobs_url":"https://api.github.com/repos/bergwolf/kata-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bergwolf/kata-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bergwolf/kata-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/bergwolf/kata-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bergwolf/kata-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/bergwolf/kata-runtime/languages","stargazers_url":"https://api.github.com/repos/bergwolf/kata-runtime/stargazers","contributors_url":"https://api.github.com/repos/bergwolf/kata-runtime/contributors","subscribers_url":"https://api.github.com/repos/bergwolf/kata-runtime/subscribers","subscription_url":"https://api.github.com/repos/bergwolf/kata-runtime/subscription","commits_url":"https://api.github.com/repos/bergwolf/kata-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/bergwolf/kata-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/bergwolf/kata-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/bergwolf/kata-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/bergwolf/kata-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/bergwolf/kata-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bergwolf/kata-runtime/merges","archive_url":"https://api.github.com/repos/bergwolf/kata-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bergwolf/kata-runtime/downloads","issues_url":"https://api.github.com/repos/bergwolf/kata-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/bergwolf/kata-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/bergwolf/kata-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/bergwolf/kata-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bergwolf/kata-runtime/labels{/name}","releases_url":"https://api.github.com/repos/bergwolf/kata-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/bergwolf/kata-runtime/deployments","created_at":"2018-01-26T16:17:13Z","updated_at":"2018-04-02T07:41:16Z","pushed_at":"2018-04-16T14:30:49Z","git_url":"git://github.com/bergwolf/kata-runtime.git","ssh_url":"[email protected]:bergwolf/kata-runtime.git","clone_url":"https://github.com/bergwolf/kata-runtime.git","svn_url":"https://github.com/bergwolf/kata-runtime","homepage":"","size":3767,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"8088a62805ce264ddb81a0cedad18c529fec85a4","user":{"login":"kata-containers","id":33289952,"avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539997,"name":"runtime","full_name":"kata-containers/runtime","owner":{"login":"kata-containers","id":33289952,"avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kata-containers/runtime","description":"Kata Containers runtimes","fork":false,"url":"https://api.github.com/repos/kata-containers/runtime","forks_url":"https://api.github.com/repos/kata-containers/runtime/forks","keys_url":"https://api.github.com/repos/kata-containers/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/runtime/teams","hooks_url":"https://api.github.com/repos/kata-containers/runtime/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/runtime/events","assignees_url":"https://api.github.com/repos/kata-containers/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/runtime/tags","blobs_url":"https://api.github.com/repos/kata-containers/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/runtime/languages","stargazers_url":"https://api.github.com/repos/kata-containers/runtime/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/runtime/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/runtime/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/runtime/subscription","commits_url":"https://api.github.com/repos/kata-containers/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/runtime/merges","archive_url":"https://api.github.com/repos/kata-containers/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/runtime/downloads","issues_url":"https://api.github.com/repos/kata-containers/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/runtime/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/runtime/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/runtime/deployments","created_at":"2017-11-13T11:29:03Z","updated_at":"2018-04-18T03:36:56Z","pushed_at":"2018-04-17T19:15:43Z","git_url":"git://github.com/kata-containers/runtime.git","ssh_url":"[email protected]:kata-containers/runtime.git","clone_url":"https://github.com/kata-containers/runtime.git","svn_url":"https://github.com/kata-containers/runtime","homepage":"","size":3795,"stargazers_count":132,"watchers_count":132,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":37,"open_issues":83,"watchers":132,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/218"},"html":{"href":"https://github.com/kata-containers/runtime/pull/218"},"issue":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/218"},"comments":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/runtime/statuses/ef479309824641a0a2bf1e0f8160859a0186e61c"}},"author_association":"OWNER"}}

7546698295

{"actor":{"display_login":"amshinde"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/tests/pulls/comments/222398397","pull_request_review_id":161276290,"id":222398397,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjM5ODM5Nw==","diff_hunk":"@@ -1,5 +1,31 @@\n # Kata Containers metrics\n \n+* [Kata Containers metrics](#kata-containers-metrics)\n+ * [Goals](#goals)\n+ * [PR regression checks](#pr-regression-checks)\n+ * [master branch trending](#master-branch-trending)\n+ * [Developer pre-checking](#developer-pre-checking)\n+ * [Stability or Performance?](#stability-or-performance)\n+ * [Requirements](#requirements)\n+ * [For PR checks](#for-pr-checks)\n+ * [For master tracking](#for-master-tracking)\n+ * [Categories](#categories)\n+ * [Time (Speed)](#time-speed)\n+ * [Density](#density)\n+ * [Networking](#networking)\n+ * [Storage](#storage)\n+ * [Saving Results](#saving-results)\n+ * [JSON API](#json-api)\n+ * [metrics_json_init()](#metrics_json_init)\n+ * [metrics_json_save()](#metrics_json_save)\n+ * [metrics_json_add_fragment(json)](#metrics_json_add_fragmentjson)\n+ * [metrics_json_start_array()](#metrics_json_start_array)\n+ * [metrics_json_add_array_element(json)](#metrics_json_add_array_elementjson)\n+ * [metrics_json_add_array_fragment(json)](#metrics_json_add_array_fragmentjson)\n+ * [metrics_json_close_array_element()](#metrics_json_close_array_element)\n+ * [metrics_json_end_array(name)](#metrics_json_end_arrayname)\n+ * [Preserving results Results](#preserving-results)","path":"metrics/README.md","position":null,"original_position":27,"commit_id":"968fe09ba8363b486ff36b11a4af553b23ab1c71","original_commit_id":"0667b0e5110f2f574677a4edf587ab1be89b8d5f","user":{"login":"grahamwhaley","id":4761717,"node_id":"MDQ6VXNlcjQ3NjE3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"body":"Indeed. fixed.","created_at":"2018-10-03T17:30:19Z","updated_at":"2018-10-03T17:30:19Z","html_url":"https://github.com/kata-containers/tests/pull/791#discussion_r222398397","pull_request_url":"https://api.github.com/repos/kata-containers/tests/pulls/791","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/comments/222398397"},"html":{"href":"https://github.com/kata-containers/tests/pull/791#discussion_r222398397"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/791"}},"in_reply_to_id":222072772},"pull_request":{"url":"https://api.github.com/repos/kata-containers/tests/pulls/791","id":219766907,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzY2OTA3","html_url":"https://github.com/kata-containers/tests/pull/791","diff_url":"https://github.com/kata-containers/tests/pull/791.diff","patch_url":"https://github.com/kata-containers/tests/pull/791.patch","issue_url":"https://api.github.com/repos/kata-containers/tests/issues/791","number":791,"state":"open","locked":false,"title":"metrics: json: enable socat and single line transmit for json","user":{"login":"grahamwhaley","id":4761717,"node_id":"MDQ6VXNlcjQ3NjE3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"body":"For some storage endpoints (such as the filebeat TCP), it is\r\nmuch easier to use `socat` to send the data, rather than trying\r\nto figure out how to get `curl` to do it.\r\n\r\nAlso, ideally we should send the results as a single line, so\r\nadd that capability as well.\r\n\r\nAnd finally, document the hooks, and add a ToC to the README.\r\n\r\nFixes: #790\r\n\r\nSigned-off-by: Graham Whaley <[email protected]>","created_at":"2018-10-02T16:27:36Z","updated_at":"2018-10-03T17:30:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9dfc6f9c1c56080956eccee8816bad6f2b855e4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chavafg","id":11828666,"node_id":"MDQ6VXNlcjExODI4NjY2","avatar_url":"https://avatars3.githubusercontent.com/u/11828666?v=4","gravatar_id":"","url":"https://api.github.com/users/chavafg","html_url":"https://github.com/chavafg","followers_url":"https://api.github.com/users/chavafg/followers","following_url":"https://api.github.com/users/chavafg/following{/other_user}","gists_url":"https://api.github.com/users/chavafg/gists{/gist_id}","starred_url":"https://api.github.com/users/chavafg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chavafg/subscriptions","organizations_url":"https://api.github.com/users/chavafg/orgs","repos_url":"https://api.github.com/users/chavafg/repos","events_url":"https://api.github.com/users/chavafg/events{/privacy}","received_events_url":"https://api.github.com/users/chavafg/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/tests/pulls/791/commits","review_comments_url":"https://api.github.com/repos/kata-containers/tests/pulls/791/comments","review_comment_url":"https://api.github.com/repos/kata-containers/tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/tests/issues/791/comments","statuses_url":"https://api.github.com/repos/kata-containers/tests/statuses/968fe09ba8363b486ff36b11a4af553b23ab1c71","head":{"label":"grahamwhaley:20181001_nc_json","ref":"20181001_nc_json","sha":"968fe09ba8363b486ff36b11a4af553b23ab1c71","user":{"login":"grahamwhaley","id":4761717,"node_id":"MDQ6VXNlcjQ3NjE3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"repo":{"id":125889433,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU4ODk0MzM=","name":"kata-containers-tests","full_name":"grahamwhaley/kata-containers-tests","private":false,"owner":{"login":"grahamwhaley","id":4761717,"node_id":"MDQ6VXNlcjQ3NjE3MTc=","avatar_url":"https://avatars3.githubusercontent.com/u/4761717?v=4","gravatar_id":"","url":"https://api.github.com/users/grahamwhaley","html_url":"https://github.com/grahamwhaley","followers_url":"https://api.github.com/users/grahamwhaley/followers","following_url":"https://api.github.com/users/grahamwhaley/following{/other_user}","gists_url":"https://api.github.com/users/grahamwhaley/gists{/gist_id}","starred_url":"https://api.github.com/users/grahamwhaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grahamwhaley/subscriptions","organizations_url":"https://api.github.com/users/grahamwhaley/orgs","repos_url":"https://api.github.com/users/grahamwhaley/repos","events_url":"https://api.github.com/users/grahamwhaley/events{/privacy}","received_events_url":"https://api.github.com/users/grahamwhaley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/grahamwhaley/kata-containers-tests","description":"Kata Containers tests, CI, and metrics","fork":true,"url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests","forks_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/forks","keys_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/teams","hooks_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/hooks","issue_events_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/issues/events{/number}","events_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/events","assignees_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/assignees{/user}","branches_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/branches{/branch}","tags_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/tags","blobs_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/languages","stargazers_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/stargazers","contributors_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/contributors","subscribers_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/subscribers","subscription_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/subscription","commits_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/contents/{+path}","compare_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/merges","archive_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/downloads","issues_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/issues{/number}","pulls_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/labels{/name}","releases_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/releases{/id}","deployments_url":"https://api.github.com/repos/grahamwhaley/kata-containers-tests/deployments","created_at":"2018-03-19T16:38:59Z","updated_at":"2018-03-19T16:39:36Z","pushed_at":"2018-10-03T17:30:03Z","git_url":"git://github.com/grahamwhaley/kata-containers-tests.git","ssh_url":"[email protected]:grahamwhaley/kata-containers-tests.git","clone_url":"https://github.com/grahamwhaley/kata-containers-tests.git","svn_url":"https://github.com/grahamwhaley/kata-containers-tests","homepage":"","size":2364,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"6aa20b11f31d3aa3ea01bb56b4ded04652452168","user":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539912,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Mzk5MTI=","name":"tests","full_name":"kata-containers/tests","private":false,"owner":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kata-containers/tests","description":"Kata Containers tests, CI, and metrics","fork":false,"url":"https://api.github.com/repos/kata-containers/tests","forks_url":"https://api.github.com/repos/kata-containers/tests/forks","keys_url":"https://api.github.com/repos/kata-containers/tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/tests/teams","hooks_url":"https://api.github.com/repos/kata-containers/tests/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/tests/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/tests/events","assignees_url":"https://api.github.com/repos/kata-containers/tests/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/tests/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/tests/tags","blobs_url":"https://api.github.com/repos/kata-containers/tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/tests/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/tests/languages","stargazers_url":"https://api.github.com/repos/kata-containers/tests/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/tests/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/tests/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/tests/subscription","commits_url":"https://api.github.com/repos/kata-containers/tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/tests/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/tests/merges","archive_url":"https://api.github.com/repos/kata-containers/tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/tests/downloads","issues_url":"https://api.github.com/repos/kata-containers/tests/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/tests/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/tests/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/tests/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/tests/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/tests/deployments","created_at":"2017-11-13T11:28:08Z","updated_at":"2018-10-03T17:01:23Z","pushed_at":"2018-10-03T17:30:05Z","git_url":"git://github.com/kata-containers/tests.git","ssh_url":"[email protected]:kata-containers/tests.git","clone_url":"https://github.com/kata-containers/tests.git","svn_url":"https://github.com/kata-containers/tests","homepage":"","size":2346,"stargazers_count":69,"watchers_count":69,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":75,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":33,"open_issues":75,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/791"},"html":{"href":"https://github.com/kata-containers/tests/pull/791"},"issue":{"href":"https://api.github.com/repos/kata-containers/tests/issues/791"},"comments":{"href":"https://api.github.com/repos/kata-containers/tests/issues/791/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/791/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/tests/pulls/791/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/tests/statuses/968fe09ba8363b486ff36b11a4af553b23ab1c71"}},"author_association":"MEMBER"}}

8362669660

{"actor":{"display_login":"grahamwhaley"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/regro/regolith/pulls/comments/191036276","pull_request_review_id":123543581,"id":191036276,"diff_hunk":"@@ -0,0 +1,37 @@\n+\\documentclass[prl,tighten,amsmath,amssymb,floatfix]{revtex4-1}\n+\n+\n+% Packages\n+\\usepackage{graphicx}\n+\\usepackage{times}\n+\\usepackage{booktabs,dcolumn}\n+\\usepackage{siunitx}\n+\n+\\setlength{\\parindent}{0pt}\n+\n+% Document\n+\\begin{document}\n+\\textbf{Presentations}\n+\n+\\textbf{ {{-latex_safe(pi['name']).upper() }}}\n+\\vskip 14pt\n+\n+\\begin{enumerate}\n+{% for pres in presentations %}\n+\\item {{ latex_safe(pres['authors']) }}, {\\bf {{ latex_safe(pres['title']) }} },","path":"regolith/templates/preslist.tex","position":21,"original_position":21,"commit_id":"c53ee5b85b7f38857f6b6facb76a89f299973c54","original_commit_id":"c53ee5b85b7f38857f6b6facb76a89f299973c54","user":{"login":"CJ-Wright","id":6740689,"avatar_url":"https://avatars3.githubusercontent.com/u/6740689?v=4","gravatar_id":"","url":"https://api.github.com/users/CJ-Wright","html_url":"https://github.com/CJ-Wright","followers_url":"https://api.github.com/users/CJ-Wright/followers","following_url":"https://api.github.com/users/CJ-Wright/following{/other_user}","gists_url":"https://api.github.com/users/CJ-Wright/gists{/gist_id}","starred_url":"https://api.github.com/users/CJ-Wright/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CJ-Wright/subscriptions","organizations_url":"https://api.github.com/users/CJ-Wright/orgs","repos_url":"https://api.github.com/users/CJ-Wright/repos","events_url":"https://api.github.com/users/CJ-Wright/events{/privacy}","received_events_url":"https://api.github.com/users/CJ-Wright/received_events","type":"User","site_admin":false},"body":"Actually one could do this in less code. You could do\r\n```python\r\npres['authors'] = ', '.join(pres['authors'])\r\n```\r\nThis will turn the authors into a string which `latex_safe` will properly operate upon.","created_at":"2018-05-26T01:40:14Z","updated_at":"2018-05-26T01:40:14Z","html_url":"https://github.com/regro/regolith/pull/143#discussion_r191036276","pull_request_url":"https://api.github.com/repos/regro/regolith/pulls/143","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/regro/regolith/pulls/comments/191036276"},"html":{"href":"https://github.com/regro/regolith/pull/143#discussion_r191036276"},"pull_request":{"href":"https://api.github.com/repos/regro/regolith/pulls/143"}},"in_reply_to_id":191035013},"pull_request":{"url":"https://api.github.com/repos/regro/regolith/pulls/143","id":190321234,"html_url":"https://github.com/regro/regolith/pull/143","diff_url":"https://github.com/regro/regolith/pull/143.diff","patch_url":"https://github.com/regro/regolith/pull/143.patch","issue_url":"https://api.github.com/repos/regro/regolith/issues/143","number":143,"state":"open","locked":false,"title":"Presentations builder","user":{"login":"sbillinge","id":4254545,"avatar_url":"https://avatars0.githubusercontent.com/u/4254545?v=4","gravatar_id":"","url":"https://api.github.com/users/sbillinge","html_url":"https://github.com/sbillinge","followers_url":"https://api.github.com/users/sbillinge/followers","following_url":"https://api.github.com/users/sbillinge/following{/other_user}","gists_url":"https://api.github.com/users/sbillinge/gists{/gist_id}","starred_url":"https://api.github.com/users/sbillinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbillinge/subscriptions","organizations_url":"https://api.github.com/users/sbillinge/orgs","repos_url":"https://api.github.com/users/sbillinge/repos","events_url":"https://api.github.com/users/sbillinge/events{/privacy}","received_events_url":"https://api.github.com/users/sbillinge/received_events","type":"User","site_admin":false},"body":"not ready for review yet. I still need to do the institutions schema, but I wanted to get this PR in. It will close #141 and #142 ","created_at":"2018-05-24T15:00:21Z","updated_at":"2018-05-26T01:40:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be07580b796e85b340a15aa65e9ec691ffc93b33","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/regro/regolith/pulls/143/commits","review_comments_url":"https://api.github.com/repos/regro/regolith/pulls/143/comments","review_comment_url":"https://api.github.com/repos/regro/regolith/pulls/comments{/number}","comments_url":"https://api.github.com/repos/regro/regolith/issues/143/comments","statuses_url":"https://api.github.com/repos/regro/regolith/statuses/c53ee5b85b7f38857f6b6facb76a89f299973c54","head":{"label":"sbillinge:presentations_builder","ref":"presentations_builder","sha":"c53ee5b85b7f38857f6b6facb76a89f299973c54","user":{"login":"sbillinge","id":4254545,"avatar_url":"https://avatars0.githubusercontent.com/u/4254545?v=4","gravatar_id":"","url":"https://api.github.com/users/sbillinge","html_url":"https://github.com/sbillinge","followers_url":"https://api.github.com/users/sbillinge/followers","following_url":"https://api.github.com/users/sbillinge/following{/other_user}","gists_url":"https://api.github.com/users/sbillinge/gists{/gist_id}","starred_url":"https://api.github.com/users/sbillinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbillinge/subscriptions","organizations_url":"https://api.github.com/users/sbillinge/orgs","repos_url":"https://api.github.com/users/sbillinge/repos","events_url":"https://api.github.com/users/sbillinge/events{/privacy}","received_events_url":"https://api.github.com/users/sbillinge/received_events","type":"User","site_admin":false},"repo":{"id":116424498,"name":"regolith","full_name":"sbillinge/regolith","owner":{"login":"sbillinge","id":4254545,"avatar_url":"https://avatars0.githubusercontent.com/u/4254545?v=4","gravatar_id":"","url":"https://api.github.com/users/sbillinge","html_url":"https://github.com/sbillinge","followers_url":"https://api.github.com/users/sbillinge/followers","following_url":"https://api.github.com/users/sbillinge/following{/other_user}","gists_url":"https://api.github.com/users/sbillinge/gists{/gist_id}","starred_url":"https://api.github.com/users/sbillinge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbillinge/subscriptions","organizations_url":"https://api.github.com/users/sbillinge/orgs","repos_url":"https://api.github.com/users/sbillinge/repos","events_url":"https://api.github.com/users/sbillinge/events{/privacy}","received_events_url":"https://api.github.com/users/sbillinge/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sbillinge/regolith","description":"Research Group Content Managment System","fork":true,"url":"https://api.github.com/repos/sbillinge/regolith","forks_url":"https://api.github.com/repos/sbillinge/regolith/forks","keys_url":"https://api.github.com/repos/sbillinge/regolith/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sbillinge/regolith/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sbillinge/regolith/teams","hooks_url":"https://api.github.com/repos/sbillinge/regolith/hooks","issue_events_url":"https://api.github.com/repos/sbillinge/regolith/issues/events{/number}","events_url":"https://api.github.com/repos/sbillinge/regolith/events","assignees_url":"https://api.github.com/repos/sbillinge/regolith/assignees{/user}","branches_url":"https://api.github.com/repos/sbillinge/regolith/branches{/branch}","tags_url":"https://api.github.com/repos/sbillinge/regolith/tags","blobs_url":"https://api.github.com/repos/sbillinge/regolith/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sbillinge/regolith/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sbillinge/regolith/git/refs{/sha}","trees_url":"https://api.github.com/repos/sbillinge/regolith/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sbillinge/regolith/statuses/{sha}","languages_url":"https://api.github.com/repos/sbillinge/regolith/languages","stargazers_url":"https://api.github.com/repos/sbillinge/regolith/stargazers","contributors_url":"https://api.github.com/repos/sbillinge/regolith/contributors","subscribers_url":"https://api.github.com/repos/sbillinge/regolith/subscribers","subscription_url":"https://api.github.com/repos/sbillinge/regolith/subscription","commits_url":"https://api.github.com/repos/sbillinge/regolith/commits{/sha}","git_commits_url":"https://api.github.com/repos/sbillinge/regolith/git/commits{/sha}","comments_url":"https://api.github.com/repos/sbillinge/regolith/comments{/number}","issue_comment_url":"https://api.github.com/repos/sbillinge/regolith/issues/comments{/number}","contents_url":"https://api.github.com/repos/sbillinge/regolith/contents/{+path}","compare_url":"https://api.github.com/repos/sbillinge/regolith/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sbillinge/regolith/merges","archive_url":"https://api.github.com/repos/sbillinge/regolith/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sbillinge/regolith/downloads","issues_url":"https://api.github.com/repos/sbillinge/regolith/issues{/number}","pulls_url":"https://api.github.com/repos/sbillinge/regolith/pulls{/number}","milestones_url":"https://api.github.com/repos/sbillinge/regolith/milestones{/number}","notifications_url":"https://api.github.com/repos/sbillinge/regolith/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sbillinge/regolith/labels{/name}","releases_url":"https://api.github.com/repos/sbillinge/regolith/releases{/id}","deployments_url":"https://api.github.com/repos/sbillinge/regolith/deployments","created_at":"2018-01-05T20:35:21Z","updated_at":"2018-01-05T20:35:23Z","pushed_at":"2018-05-26T00:03:06Z","git_url":"git://github.com/sbillinge/regolith.git","ssh_url":"[email protected]:sbillinge/regolith.git","clone_url":"https://github.com/sbillinge/regolith.git","svn_url":"https://github.com/sbillinge/regolith","homepage":"http://regro.github.io/regolith-docs/","size":1012,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"regro:master","ref":"master","sha":"3a223fabe9fbec5eddafc32811fae7457f564f6a","user":{"login":"regro","id":33434656,"avatar_url":"https://avatars1.githubusercontent.com/u/33434656?v=4","gravatar_id":"","url":"https://api.github.com/users/regro","html_url":"https://github.com/regro","followers_url":"https://api.github.com/users/regro/followers","following_url":"https://api.github.com/users/regro/following{/other_user}","gists_url":"https://api.github.com/users/regro/gists{/gist_id}","starred_url":"https://api.github.com/users/regro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regro/subscriptions","organizations_url":"https://api.github.com/users/regro/orgs","repos_url":"https://api.github.com/users/regro/repos","events_url":"https://api.github.com/users/regro/events{/privacy}","received_events_url":"https://api.github.com/users/regro/received_events","type":"Organization","site_admin":false},"repo":{"id":41056896,"name":"regolith","full_name":"regro/regolith","owner":{"login":"regro","id":33434656,"avatar_url":"https://avatars1.githubusercontent.com/u/33434656?v=4","gravatar_id":"","url":"https://api.github.com/users/regro","html_url":"https://github.com/regro","followers_url":"https://api.github.com/users/regro/followers","following_url":"https://api.github.com/users/regro/following{/other_user}","gists_url":"https://api.github.com/users/regro/gists{/gist_id}","starred_url":"https://api.github.com/users/regro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/regro/subscriptions","organizations_url":"https://api.github.com/users/regro/orgs","repos_url":"https://api.github.com/users/regro/repos","events_url":"https://api.github.com/users/regro/events{/privacy}","received_events_url":"https://api.github.com/users/regro/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/regro/regolith","description":"Research Group Content Managment System","fork":false,"url":"https://api.github.com/repos/regro/regolith","forks_url":"https://api.github.com/repos/regro/regolith/forks","keys_url":"https://api.github.com/repos/regro/regolith/keys{/key_id}","collaborators_url":"https://api.github.com/repos/regro/regolith/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/regro/regolith/teams","hooks_url":"https://api.github.com/repos/regro/regolith/hooks","issue_events_url":"https://api.github.com/repos/regro/regolith/issues/events{/number}","events_url":"https://api.github.com/repos/regro/regolith/events","assignees_url":"https://api.github.com/repos/regro/regolith/assignees{/user}","branches_url":"https://api.github.com/repos/regro/regolith/branches{/branch}","tags_url":"https://api.github.com/repos/regro/regolith/tags","blobs_url":"https://api.github.com/repos/regro/regolith/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/regro/regolith/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/regro/regolith/git/refs{/sha}","trees_url":"https://api.github.com/repos/regro/regolith/git/trees{/sha}","statuses_url":"https://api.github.com/repos/regro/regolith/statuses/{sha}","languages_url":"https://api.github.com/repos/regro/regolith/languages","stargazers_url":"https://api.github.com/repos/regro/regolith/stargazers","contributors_url":"https://api.github.com/repos/regro/regolith/contributors","subscribers_url":"https://api.github.com/repos/regro/regolith/subscribers","subscription_url":"https://api.github.com/repos/regro/regolith/subscription","commits_url":"https://api.github.com/repos/regro/regolith/commits{/sha}","git_commits_url":"https://api.github.com/repos/regro/regolith/git/commits{/sha}","comments_url":"https://api.github.com/repos/regro/regolith/comments{/number}","issue_comment_url":"https://api.github.com/repos/regro/regolith/issues/comments{/number}","contents_url":"https://api.github.com/repos/regro/regolith/contents/{+path}","compare_url":"https://api.github.com/repos/regro/regolith/compare/{base}...{head}","merges_url":"https://api.github.com/repos/regro/regolith/merges","archive_url":"https://api.github.com/repos/regro/regolith/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/regro/regolith/downloads","issues_url":"https://api.github.com/repos/regro/regolith/issues{/number}","pulls_url":"https://api.github.com/repos/regro/regolith/pulls{/number}","milestones_url":"https://api.github.com/repos/regro/regolith/milestones{/number}","notifications_url":"https://api.github.com/repos/regro/regolith/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/regro/regolith/labels{/name}","releases_url":"https://api.github.com/repos/regro/regolith/releases{/id}","deployments_url":"https://api.github.com/repos/regro/regolith/deployments","created_at":"2015-08-19T19:58:10Z","updated_at":"2018-05-25T14:39:23Z","pushed_at":"2018-05-26T00:03:08Z","git_url":"git://github.com/regro/regolith.git","ssh_url":"[email protected]:regro/regolith.git","clone_url":"https://github.com/regro/regolith.git","svn_url":"https://github.com/regro/regolith","homepage":"http://regro.github.io/regolith-docs/","size":1001,"stargazers_count":7,"watchers_count":7,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"cc0-1.0","name":"Creative Commons Zero v1.0 Universal","spdx_id":"CC0-1.0","url":"https://api.github.com/licenses/cc0-1.0"},"forks":6,"open_issues":50,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/regro/regolith/pulls/143"},"html":{"href":"https://github.com/regro/regolith/pull/143"},"issue":{"href":"https://api.github.com/repos/regro/regolith/issues/143"},"comments":{"href":"https://api.github.com/repos/regro/regolith/issues/143/comments"},"review_comments":{"href":"https://api.github.com/repos/regro/regolith/pulls/143/comments"},"review_comment":{"href":"https://api.github.com/repos/regro/regolith/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/regro/regolith/pulls/143/commits"},"statuses":{"href":"https://api.github.com/repos/regro/regolith/statuses/c53ee5b85b7f38857f6b6facb76a89f299973c54"}},"author_association":"CONTRIBUTOR"}}

7732738270

{"actor":{"display_login":"CJ-Wright"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/graycoreio/daffodil/pulls/comments/216466102","pull_request_review_id":153954766,"id":216466102,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjQ2NjEwMg==","diff_hunk":"@@ -0,0 +1,8 @@\n+import { Component } from '@angular/core';\n+\n+@Component({\n+ selector: '[daff-sidebar-item]',\n+ host: {'class': 'daff-sidebar__item'},","path":"apps/foundation-demo/src/app/design/molecules/sidebar/sidebar-item/sidebar-item.component.ts","position":5,"original_position":5,"commit_id":"941a310c0fc731e69a8c1c06a5f21f93e0d40007","original_commit_id":"941a310c0fc731e69a8c1c06a5f21f93e0d40007","user":{"login":"lderrickable","id":7902778,"node_id":"MDQ6VXNlcjc5MDI3Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7902778?v=4","gravatar_id":"","url":"https://api.github.com/users/lderrickable","html_url":"https://github.com/lderrickable","followers_url":"https://api.github.com/users/lderrickable/followers","following_url":"https://api.github.com/users/lderrickable/following{/other_user}","gists_url":"https://api.github.com/users/lderrickable/gists{/gist_id}","starred_url":"https://api.github.com/users/lderrickable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lderrickable/subscriptions","organizations_url":"https://api.github.com/users/lderrickable/orgs","repos_url":"https://api.github.com/users/lderrickable/repos","events_url":"https://api.github.com/users/lderrickable/events{/privacy}","received_events_url":"https://api.github.com/users/lderrickable/received_events","type":"User","site_admin":false},"body":"Actually I changed my mind. I actually like just sticking with the BEM syntax anyway","created_at":"2018-09-10T20:44:16Z","updated_at":"2018-09-10T20:44:16Z","html_url":"https://github.com/graycoreio/daffodil/pull/53#discussion_r216466102","pull_request_url":"https://api.github.com/repos/graycoreio/daffodil/pulls/53","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/graycoreio/daffodil/pulls/comments/216466102"},"html":{"href":"https://github.com/graycoreio/daffodil/pull/53#discussion_r216466102"},"pull_request":{"href":"https://api.github.com/repos/graycoreio/daffodil/pulls/53"}},"in_reply_to_id":216446382},"pull_request":{"url":"https://api.github.com/repos/graycoreio/daffodil/pulls/53","id":210486654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDg2NjU0","html_url":"https://github.com/graycoreio/daffodil/pull/53","diff_url":"https://github.com/graycoreio/daffodil/pull/53.diff","patch_url":"https://github.com/graycoreio/daffodil/pull/53.patch","issue_url":"https://api.github.com/repos/graycoreio/daffodil/issues/53","number":53,"state":"open","locked":false,"title":"Header","user":{"login":"lderrickable","id":7902778,"node_id":"MDQ6VXNlcjc5MDI3Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7902778?v=4","gravatar_id":"","url":"https://api.github.com/users/lderrickable","html_url":"https://github.com/lderrickable","followers_url":"https://api.github.com/users/lderrickable/followers","following_url":"https://api.github.com/users/lderrickable/following{/other_user}","gists_url":"https://api.github.com/users/lderrickable/gists{/gist_id}","starred_url":"https://api.github.com/users/lderrickable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lderrickable/subscriptions","organizations_url":"https://api.github.com/users/lderrickable/orgs","repos_url":"https://api.github.com/users/lderrickable/repos","events_url":"https://api.github.com/users/lderrickable/events{/privacy}","received_events_url":"https://api.github.com/users/lderrickable/received_events","type":"User","site_admin":false},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [X] The commit message follows our guidelines: https://github.com/graycoreio/daffodil/blob/master/CONTRIBUTING.md#commit\r\n- [X] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n```\r\n[ ] Bugfix\r\n[X] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[X] No\r\n```","created_at":"2018-08-23T15:23:35Z","updated_at":"2018-09-10T20:44:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9fb233e693aee6aa3a12aa556144436f28dffd79","assignee":{"login":"lderrickable","id":7902778,"node_id":"MDQ6VXNlcjc5MDI3Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7902778?v=4","gravatar_id":"","url":"https://api.github.com/users/lderrickable","html_url":"https://github.com/lderrickable","followers_url":"https://api.github.com/users/lderrickable/followers","following_url":"https://api.github.com/users/lderrickable/following{/other_user}","gists_url":"https://api.github.com/users/lderrickable/gists{/gist_id}","starred_url":"https://api.github.com/users/lderrickable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lderrickable/subscriptions","organizations_url":"https://api.github.com/users/lderrickable/orgs","repos_url":"https://api.github.com/users/lderrickable/repos","events_url":"https://api.github.com/users/lderrickable/events{/privacy}","received_events_url":"https://api.github.com/users/lderrickable/received_events","type":"User","site_admin":false},"assignees":[{"login":"lderrickable","id":7902778,"node_id":"MDQ6VXNlcjc5MDI3Nzg=","avatar_url":"https://avatars0.githubusercontent.com/u/7902778?v=4","gravatar_id":"","url":"https://api.github.com/users/lderrickable","html_url":"https://github.com/lderrickable","followers_url":"https://api.github.com/users/lderrickable/followers","following_url":"https://api.github.com/users/lderrickable/following{/other_user}","gists_url":"https://api.github.com/users/lderrickable/gists{/gist_id}","starred_url":"https://api.github.com/users/lderrickable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lderrickable/subscriptions","organizations_url":"https://api.github.com/users/lderrickable/orgs","repos_url":"https://api.github.com/users/lderrickable/repos","events_url":"https://api.github.com/users/lderrickable/events{/privacy}","received_events_url":"https://api.github.com/users/lderrickable/received_events","type":"User","site_admin":false},{"login":"damienwebdev","id":9029654,"node_id":"MDQ6VXNlcjkwMjk2NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9029654?v=4","gravatar_id":"","url":"https://api.github.com/users/damienwebdev","html_url":"https://github.com/damienwebdev","followers_url":"https://api.github.com/users/damienwebdev/followers","following_url":"https://api.github.com/users/damienwebdev/following{/other_user}","gists_url":"https://api.github.com/users/damienwebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/damienwebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienwebdev/subscriptions","organizations_url":"https://api.github.com/users/damienwebdev/orgs","repos_url":"https://api.github.com/users/damienwebdev/repos","events_url":"https://api.github.com/users/damienwebdev/events{/privacy}","received_events_url":"https://api.github.com/users/damienwebdev/received_events","type":"User","site_admin":false},{"login":"xelaint","id":15809918,"node_id":"MDQ6VXNlcjE1ODA5OTE4","avatar_url":"https://avatars1.githubusercontent.com/u/15809918?v=4","gravatar_id":"","url":"https://api.github.com/users/xelaint","html_url":"https://github.com/xelaint","followers_url":"https://api.github.com/users/xelaint/followers","following_url":"https://api.github.com/users/xelaint/following{/other_user}","gists_url":"https://api.github.com/users/xelaint/gists{/gist_id}","starred_url":"https://api.github.com/users/xelaint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xelaint/subscriptions","organizations_url":"https://api.github.com/users/xelaint/orgs","repos_url":"https://api.github.com/users/xelaint/repos","events_url":"https://api.github.com/users/xelaint/events{/privacy}","received_events_url":"https://api.github.com/users/xelaint/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"xelaint","id":15809918,"node_id":"MDQ6VXNlcjE1ODA5OTE4","avatar_url":"https://avatars1.githubusercontent.com/u/15809918?v=4","gravatar_id":"","url":"https://api.github.com/users/xelaint","html_url":"https://github.com/xelaint","followers_url":"https://api.github.com/users/xelaint/followers","following_url":"https://api.github.com/users/xelaint/following{/other_user}","gists_url":"https://api.github.com/users/xelaint/gists{/gist_id}","starred_url":"https://api.github.com/users/xelaint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xelaint/subscriptions","organizations_url":"https://api.github.com/users/xelaint/orgs","repos_url":"https://api.github.com/users/xelaint/repos","events_url":"https://api.github.com/users/xelaint/events{/privacy}","received_events_url":"https://api.github.com/users/xelaint/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":896097400,"node_id":"MDU6TGFiZWw4OTYwOTc0MDA=","url":"https://api.github.com/repos/graycoreio/daffodil/labels/feat","name":"feat","color":"a2eeef","default":false}],"milestone":{"url":"https://api.github.com/repos/graycoreio/daffodil/milestones/1","html_url":"https://github.com/graycoreio/daffodil/milestone/1","labels_url":"https://api.github.com/repos/graycoreio/daffodil/milestones/1/labels","id":3328175,"node_id":"MDk6TWlsZXN0b25lMzMyODE3NQ==","number":1,"title":"v1.0.0","description":"","creator":{"login":"damienwebdev","id":9029654,"node_id":"MDQ6VXNlcjkwMjk2NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9029654?v=4","gravatar_id":"","url":"https://api.github.com/users/damienwebdev","html_url":"https://github.com/damienwebdev","followers_url":"https://api.github.com/users/damienwebdev/followers","following_url":"https://api.github.com/users/damienwebdev/following{/other_user}","gists_url":"https://api.github.com/users/damienwebdev/gists{/gist_id}","starred_url":"https://api.github.com/users/damienwebdev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/damienwebdev/subscriptions","organizations_url":"https://api.github.com/users/damienwebdev/orgs","repos_url":"https://api.github.com/users/damienwebdev/repos","events_url":"https://api.github.com/users/damienwebdev/events{/privacy}","received_events_url":"https://api.github.com/users/damienwebdev/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":10,"state":"open","created_at":"2018-05-08T01:40:38Z","updated_at":"2018-09-10T17:33:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/graycoreio/daffodil/pulls/53/commits","review_comments_url":"https://api.github.com/repos/graycoreio/daffodil/pulls/53/comments","review_comment_url":"https://api.github.com/repos/graycoreio/daffodil/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graycoreio/daffodil/issues/53/comments","statuses_url":"https://api.github.com/repos/graycoreio/daffodil/statuses/941a310c0fc731e69a8c1c06a5f21f93e0d40007","head":{"label":"graycoreio:header","ref":"header","sha":"941a310c0fc731e69a8c1c06a5f21f93e0d40007","user":{"login":"graycoreio","id":33813698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODEzNjk4","avatar_url":"https://avatars2.githubusercontent.com/u/33813698?v=4","gravatar_id":"","url":"https://api.github.com/users/graycoreio","html_url":"https://github.com/graycoreio","followers_url":"https://api.github.com/users/graycoreio/followers","following_url":"https://api.github.com/users/graycoreio/following{/other_user}","gists_url":"https://api.github.com/users/graycoreio/gists{/gist_id}","starred_url":"https://api.github.com/users/graycoreio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graycoreio/subscriptions","organizations_url":"https://api.github.com/users/graycoreio/orgs","repos_url":"https://api.github.com/users/graycoreio/repos","events_url":"https://api.github.com/users/graycoreio/events{/privacy}","received_events_url":"https://api.github.com/users/graycoreio/received_events","type":"Organization","site_admin":false},"repo":{"id":128830675,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4MzA2NzU=","name":"daffodil","full_name":"graycoreio/daffodil","owner":{"login":"graycoreio","id":33813698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODEzNjk4","avatar_url":"https://avatars2.githubusercontent.com/u/33813698?v=4","gravatar_id":"","url":"https://api.github.com/users/graycoreio","html_url":"https://github.com/graycoreio","followers_url":"https://api.github.com/users/graycoreio/followers","following_url":"https://api.github.com/users/graycoreio/following{/other_user}","gists_url":"https://api.github.com/users/graycoreio/gists{/gist_id}","starred_url":"https://api.github.com/users/graycoreio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graycoreio/subscriptions","organizations_url":"https://api.github.com/users/graycoreio/orgs","repos_url":"https://api.github.com/users/graycoreio/repos","events_url":"https://api.github.com/users/graycoreio/events{/privacy}","received_events_url":"https://api.github.com/users/graycoreio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graycoreio/daffodil","description":"A frontend development toolkit for Ecommerce - built with Angular","fork":false,"url":"https://api.github.com/repos/graycoreio/daffodil","forks_url":"https://api.github.com/repos/graycoreio/daffodil/forks","keys_url":"https://api.github.com/repos/graycoreio/daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graycoreio/daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graycoreio/daffodil/teams","hooks_url":"https://api.github.com/repos/graycoreio/daffodil/hooks","issue_events_url":"https://api.github.com/repos/graycoreio/daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/graycoreio/daffodil/events","assignees_url":"https://api.github.com/repos/graycoreio/daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/graycoreio/daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/graycoreio/daffodil/tags","blobs_url":"https://api.github.com/repos/graycoreio/daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graycoreio/daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graycoreio/daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/graycoreio/daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graycoreio/daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/graycoreio/daffodil/languages","stargazers_url":"https://api.github.com/repos/graycoreio/daffodil/stargazers","contributors_url":"https://api.github.com/repos/graycoreio/daffodil/contributors","subscribers_url":"https://api.github.com/repos/graycoreio/daffodil/subscribers","subscription_url":"https://api.github.com/repos/graycoreio/daffodil/subscription","commits_url":"https://api.github.com/repos/graycoreio/daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/graycoreio/daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/graycoreio/daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/graycoreio/daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/graycoreio/daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/graycoreio/daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graycoreio/daffodil/merges","archive_url":"https://api.github.com/repos/graycoreio/daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graycoreio/daffodil/downloads","issues_url":"https://api.github.com/repos/graycoreio/daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/graycoreio/daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/graycoreio/daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/graycoreio/daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graycoreio/daffodil/labels{/name}","releases_url":"https://api.github.com/repos/graycoreio/daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/graycoreio/daffodil/deployments","created_at":"2018-04-09T20:36:05Z","updated_at":"2018-08-29T11:32:41Z","pushed_at":"2018-09-10T19:27:57Z","git_url":"git://github.com/graycoreio/daffodil.git","ssh_url":"[email protected]:graycoreio/daffodil.git","clone_url":"https://github.com/graycoreio/daffodil.git","svn_url":"https://github.com/graycoreio/daffodil","homepage":"","size":4429,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":19,"watchers":6,"default_branch":"develop"}},"base":{"label":"graycoreio:develop","ref":"develop","sha":"fd78fd57dcb7edeb049fc86f43db50c7d6fbf66f","user":{"login":"graycoreio","id":33813698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODEzNjk4","avatar_url":"https://avatars2.githubusercontent.com/u/33813698?v=4","gravatar_id":"","url":"https://api.github.com/users/graycoreio","html_url":"https://github.com/graycoreio","followers_url":"https://api.github.com/users/graycoreio/followers","following_url":"https://api.github.com/users/graycoreio/following{/other_user}","gists_url":"https://api.github.com/users/graycoreio/gists{/gist_id}","starred_url":"https://api.github.com/users/graycoreio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graycoreio/subscriptions","organizations_url":"https://api.github.com/users/graycoreio/orgs","repos_url":"https://api.github.com/users/graycoreio/repos","events_url":"https://api.github.com/users/graycoreio/events{/privacy}","received_events_url":"https://api.github.com/users/graycoreio/received_events","type":"Organization","site_admin":false},"repo":{"id":128830675,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4MzA2NzU=","name":"daffodil","full_name":"graycoreio/daffodil","owner":{"login":"graycoreio","id":33813698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODEzNjk4","avatar_url":"https://avatars2.githubusercontent.com/u/33813698?v=4","gravatar_id":"","url":"https://api.github.com/users/graycoreio","html_url":"https://github.com/graycoreio","followers_url":"https://api.github.com/users/graycoreio/followers","following_url":"https://api.github.com/users/graycoreio/following{/other_user}","gists_url":"https://api.github.com/users/graycoreio/gists{/gist_id}","starred_url":"https://api.github.com/users/graycoreio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graycoreio/subscriptions","organizations_url":"https://api.github.com/users/graycoreio/orgs","repos_url":"https://api.github.com/users/graycoreio/repos","events_url":"https://api.github.com/users/graycoreio/events{/privacy}","received_events_url":"https://api.github.com/users/graycoreio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graycoreio/daffodil","description":"A frontend development toolkit for Ecommerce - built with Angular","fork":false,"url":"https://api.github.com/repos/graycoreio/daffodil","forks_url":"https://api.github.com/repos/graycoreio/daffodil/forks","keys_url":"https://api.github.com/repos/graycoreio/daffodil/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graycoreio/daffodil/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graycoreio/daffodil/teams","hooks_url":"https://api.github.com/repos/graycoreio/daffodil/hooks","issue_events_url":"https://api.github.com/repos/graycoreio/daffodil/issues/events{/number}","events_url":"https://api.github.com/repos/graycoreio/daffodil/events","assignees_url":"https://api.github.com/repos/graycoreio/daffodil/assignees{/user}","branches_url":"https://api.github.com/repos/graycoreio/daffodil/branches{/branch}","tags_url":"https://api.github.com/repos/graycoreio/daffodil/tags","blobs_url":"https://api.github.com/repos/graycoreio/daffodil/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graycoreio/daffodil/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graycoreio/daffodil/git/refs{/sha}","trees_url":"https://api.github.com/repos/graycoreio/daffodil/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graycoreio/daffodil/statuses/{sha}","languages_url":"https://api.github.com/repos/graycoreio/daffodil/languages","stargazers_url":"https://api.github.com/repos/graycoreio/daffodil/stargazers","contributors_url":"https://api.github.com/repos/graycoreio/daffodil/contributors","subscribers_url":"https://api.github.com/repos/graycoreio/daffodil/subscribers","subscription_url":"https://api.github.com/repos/graycoreio/daffodil/subscription","commits_url":"https://api.github.com/repos/graycoreio/daffodil/commits{/sha}","git_commits_url":"https://api.github.com/repos/graycoreio/daffodil/git/commits{/sha}","comments_url":"https://api.github.com/repos/graycoreio/daffodil/comments{/number}","issue_comment_url":"https://api.github.com/repos/graycoreio/daffodil/issues/comments{/number}","contents_url":"https://api.github.com/repos/graycoreio/daffodil/contents/{+path}","compare_url":"https://api.github.com/repos/graycoreio/daffodil/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graycoreio/daffodil/merges","archive_url":"https://api.github.com/repos/graycoreio/daffodil/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graycoreio/daffodil/downloads","issues_url":"https://api.github.com/repos/graycoreio/daffodil/issues{/number}","pulls_url":"https://api.github.com/repos/graycoreio/daffodil/pulls{/number}","milestones_url":"https://api.github.com/repos/graycoreio/daffodil/milestones{/number}","notifications_url":"https://api.github.com/repos/graycoreio/daffodil/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graycoreio/daffodil/labels{/name}","releases_url":"https://api.github.com/repos/graycoreio/daffodil/releases{/id}","deployments_url":"https://api.github.com/repos/graycoreio/daffodil/deployments","created_at":"2018-04-09T20:36:05Z","updated_at":"2018-08-29T11:32:41Z","pushed_at":"2018-09-10T19:27:57Z","git_url":"git://github.com/graycoreio/daffodil.git","ssh_url":"[email protected]:graycoreio/daffodil.git","clone_url":"https://github.com/graycoreio/daffodil.git","svn_url":"https://github.com/graycoreio/daffodil","homepage":"","size":4429,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":19,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/graycoreio/daffodil/pulls/53"},"html":{"href":"https://github.com/graycoreio/daffodil/pull/53"},"issue":{"href":"https://api.github.com/repos/graycoreio/daffodil/issues/53"},"comments":{"href":"https://api.github.com/repos/graycoreio/daffodil/issues/53/comments"},"review_comments":{"href":"https://api.github.com/repos/graycoreio/daffodil/pulls/53/comments"},"review_comment":{"href":"https://api.github.com/repos/graycoreio/daffodil/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graycoreio/daffodil/pulls/53/commits"},"statuses":{"href":"https://api.github.com/repos/graycoreio/daffodil/statuses/941a310c0fc731e69a8c1c06a5f21f93e0d40007"}},"author_association":"COLLABORATOR"}}

8242595743

{"actor":{"display_login":"lderrickable"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/comments/237468238","pull_request_review_id":179769784,"id":237468238,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzQ2ODIzOA==","diff_hunk":"@@ -31,3 +31,14 @@\n \n en:\n hello: \"Hello world\"\n+ activerecord:\n+ models:\n+ category: loai giay","path":"config/locales/en.yml","position":6,"original_position":6,"commit_id":"53d9994f20d54f440c63486c09519f33fe7bb865","original_commit_id":"53d9994f20d54f440c63486c09519f33fe7bb865","user":{"login":"dogiadat","id":11146493,"node_id":"MDQ6VXNlcjExMTQ2NDkz","avatar_url":"https://avatars1.githubusercontent.com/u/11146493?v=4","gravatar_id":"","url":"https://api.github.com/users/dogiadat","html_url":"https://github.com/dogiadat","followers_url":"https://api.github.com/users/dogiadat/followers","following_url":"https://api.github.com/users/dogiadat/following{/other_user}","gists_url":"https://api.github.com/users/dogiadat/gists{/gist_id}","starred_url":"https://api.github.com/users/dogiadat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dogiadat/subscriptions","organizations_url":"https://api.github.com/users/dogiadat/orgs","repos_url":"https://api.github.com/users/dogiadat/repos","events_url":"https://api.github.com/users/dogiadat/events{/privacy}","received_events_url":"https://api.github.com/users/dogiadat/received_events","type":"User","site_admin":false},"body":"chỉnh sửa lại đi chứ em, tiếng việt có dấu","created_at":"2018-11-29T12:32:54Z","updated_at":"2018-11-29T12:33:33Z","html_url":"https://github.com/awesome-academy/pr1-1803-shoes-shop/pull/12#discussion_r237468238","pull_request_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/12","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/comments/237468238"},"html":{"href":"https://github.com/awesome-academy/pr1-1803-shoes-shop/pull/12#discussion_r237468238"},"pull_request":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/12","id":234618901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NjE4OTAx","html_url":"https://github.com/awesome-academy/pr1-1803-shoes-shop/pull/12","diff_url":"https://github.com/awesome-academy/pr1-1803-shoes-shop/pull/12.diff","patch_url":"https://github.com/awesome-academy/pr1-1803-shoes-shop/pull/12.patch","issue_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/issues/12","number":12,"state":"open","locked":false,"title":"category","user":{"login":"quangnguyen1","id":37622132,"node_id":"MDQ6VXNlcjM3NjIyMTMy","avatar_url":"https://avatars1.githubusercontent.com/u/37622132?v=4","gravatar_id":"","url":"https://api.github.com/users/quangnguyen1","html_url":"https://github.com/quangnguyen1","followers_url":"https://api.github.com/users/quangnguyen1/followers","following_url":"https://api.github.com/users/quangnguyen1/following{/other_user}","gists_url":"https://api.github.com/users/quangnguyen1/gists{/gist_id}","starred_url":"https://api.github.com/users/quangnguyen1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quangnguyen1/subscriptions","organizations_url":"https://api.github.com/users/quangnguyen1/orgs","repos_url":"https://api.github.com/users/quangnguyen1/repos","events_url":"https://api.github.com/users/quangnguyen1/events{/privacy}","received_events_url":"https://api.github.com/users/quangnguyen1/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-29T12:26:06Z","updated_at":"2018-11-29T12:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08a7599a905bafcf846d58f114fd0894391e8817","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/12/commits","review_comments_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/12/comments","review_comment_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/issues/12/comments","statuses_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/statuses/53d9994f20d54f440c63486c09519f33fe7bb865","head":{"label":"quangnguyen1:product","ref":"product","sha":"53d9994f20d54f440c63486c09519f33fe7bb865","user":{"login":"quangnguyen1","id":37622132,"node_id":"MDQ6VXNlcjM3NjIyMTMy","avatar_url":"https://avatars1.githubusercontent.com/u/37622132?v=4","gravatar_id":"","url":"https://api.github.com/users/quangnguyen1","html_url":"https://github.com/quangnguyen1","followers_url":"https://api.github.com/users/quangnguyen1/followers","following_url":"https://api.github.com/users/quangnguyen1/following{/other_user}","gists_url":"https://api.github.com/users/quangnguyen1/gists{/gist_id}","starred_url":"https://api.github.com/users/quangnguyen1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quangnguyen1/subscriptions","organizations_url":"https://api.github.com/users/quangnguyen1/orgs","repos_url":"https://api.github.com/users/quangnguyen1/repos","events_url":"https://api.github.com/users/quangnguyen1/events{/privacy}","received_events_url":"https://api.github.com/users/quangnguyen1/received_events","type":"User","site_admin":false},"repo":{"id":153286571,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMyODY1NzE=","name":"pr1-1803-shoes-shop","full_name":"quangnguyen1/pr1-1803-shoes-shop","private":false,"owner":{"login":"quangnguyen1","id":37622132,"node_id":"MDQ6VXNlcjM3NjIyMTMy","avatar_url":"https://avatars1.githubusercontent.com/u/37622132?v=4","gravatar_id":"","url":"https://api.github.com/users/quangnguyen1","html_url":"https://github.com/quangnguyen1","followers_url":"https://api.github.com/users/quangnguyen1/followers","following_url":"https://api.github.com/users/quangnguyen1/following{/other_user}","gists_url":"https://api.github.com/users/quangnguyen1/gists{/gist_id}","starred_url":"https://api.github.com/users/quangnguyen1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quangnguyen1/subscriptions","organizations_url":"https://api.github.com/users/quangnguyen1/orgs","repos_url":"https://api.github.com/users/quangnguyen1/repos","events_url":"https://api.github.com/users/quangnguyen1/events{/privacy}","received_events_url":"https://api.github.com/users/quangnguyen1/received_events","type":"User","site_admin":false},"html_url":"https://github.com/quangnguyen1/pr1-1803-shoes-shop","description":"Team 1: Sáng, Tuyền, Quang","fork":true,"url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop","forks_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/forks","keys_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/teams","hooks_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/hooks","issue_events_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/issues/events{/number}","events_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/events","assignees_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/assignees{/user}","branches_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/branches{/branch}","tags_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/tags","blobs_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/git/refs{/sha}","trees_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/statuses/{sha}","languages_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/languages","stargazers_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/stargazers","contributors_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/contributors","subscribers_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/subscribers","subscription_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/subscription","commits_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/commits{/sha}","git_commits_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/git/commits{/sha}","comments_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/comments{/number}","issue_comment_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/issues/comments{/number}","contents_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/contents/{+path}","compare_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/merges","archive_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/downloads","issues_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/issues{/number}","pulls_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/pulls{/number}","milestones_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/milestones{/number}","notifications_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/labels{/name}","releases_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/releases{/id}","deployments_url":"https://api.github.com/repos/quangnguyen1/pr1-1803-shoes-shop/deployments","created_at":"2018-10-16T13:04:29Z","updated_at":"2018-11-06T13:25:58Z","pushed_at":"2018-11-29T12:24:51Z","git_url":"git://github.com/quangnguyen1/pr1-1803-shoes-shop.git","ssh_url":"[email protected]:quangnguyen1/pr1-1803-shoes-shop.git","clone_url":"https://github.com/quangnguyen1/pr1-1803-shoes-shop.git","svn_url":"https://github.com/quangnguyen1/pr1-1803-shoes-shop","homepage":null,"size":2232,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"awesome-academy:master","ref":"master","sha":"725684ca283e8870e5926e4d6deef7e267a6b76f","user":{"login":"awesome-academy","id":33895223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/33895223?v=4","gravatar_id":"","url":"https://api.github.com/users/awesome-academy","html_url":"https://github.com/awesome-academy","followers_url":"https://api.github.com/users/awesome-academy/followers","following_url":"https://api.github.com/users/awesome-academy/following{/other_user}","gists_url":"https://api.github.com/users/awesome-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/awesome-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesome-academy/subscriptions","organizations_url":"https://api.github.com/users/awesome-academy/orgs","repos_url":"https://api.github.com/users/awesome-academy/repos","events_url":"https://api.github.com/users/awesome-academy/events{/privacy}","received_events_url":"https://api.github.com/users/awesome-academy/received_events","type":"Organization","site_admin":false},"repo":{"id":152856066,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4NTYwNjY=","name":"pr1-1803-shoes-shop","full_name":"awesome-academy/pr1-1803-shoes-shop","private":false,"owner":{"login":"awesome-academy","id":33895223,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzODk1MjIz","avatar_url":"https://avatars0.githubusercontent.com/u/33895223?v=4","gravatar_id":"","url":"https://api.github.com/users/awesome-academy","html_url":"https://github.com/awesome-academy","followers_url":"https://api.github.com/users/awesome-academy/followers","following_url":"https://api.github.com/users/awesome-academy/following{/other_user}","gists_url":"https://api.github.com/users/awesome-academy/gists{/gist_id}","starred_url":"https://api.github.com/users/awesome-academy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awesome-academy/subscriptions","organizations_url":"https://api.github.com/users/awesome-academy/orgs","repos_url":"https://api.github.com/users/awesome-academy/repos","events_url":"https://api.github.com/users/awesome-academy/events{/privacy}","received_events_url":"https://api.github.com/users/awesome-academy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/awesome-academy/pr1-1803-shoes-shop","description":"Team 1: Sáng, Tuyền, Quang","fork":false,"url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop","forks_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/forks","keys_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/teams","hooks_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/hooks","issue_events_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/issues/events{/number}","events_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/events","assignees_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/assignees{/user}","branches_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/branches{/branch}","tags_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/tags","blobs_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/git/refs{/sha}","trees_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/statuses/{sha}","languages_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/languages","stargazers_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/stargazers","contributors_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/contributors","subscribers_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/subscribers","subscription_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/subscription","commits_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/commits{/sha}","git_commits_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/git/commits{/sha}","comments_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/comments{/number}","issue_comment_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/issues/comments{/number}","contents_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/contents/{+path}","compare_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/merges","archive_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/downloads","issues_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/issues{/number}","pulls_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls{/number}","milestones_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/milestones{/number}","notifications_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/labels{/name}","releases_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/releases{/id}","deployments_url":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/deployments","created_at":"2018-10-13T09:26:54Z","updated_at":"2018-11-13T13:26:21Z","pushed_at":"2018-11-29T12:26:06Z","git_url":"git://github.com/awesome-academy/pr1-1803-shoes-shop.git","ssh_url":"[email protected]:awesome-academy/pr1-1803-shoes-shop.git","clone_url":"https://github.com/awesome-academy/pr1-1803-shoes-shop.git","svn_url":"https://github.com/awesome-academy/pr1-1803-shoes-shop","homepage":null,"size":2232,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":3,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/12"},"html":{"href":"https://github.com/awesome-academy/pr1-1803-shoes-shop/pull/12"},"issue":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/issues/12"},"comments":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/awesome-academy/pr1-1803-shoes-shop/statuses/53d9994f20d54f440c63486c09519f33fe7bb865"}},"author_association":"CONTRIBUTOR"}}

8668811877

{"actor":{"display_login":"dogiadat"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/Informo/specs/pulls/comments/237222163","pull_request_review_id":179468822,"id":237222163,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzIyMjE2Mw==","diff_hunk":"@@ -23,12 +58,221 @@ one key vs all of the keys vs the source's entire Matrix account), and take the\n actions it deems necessary.\n \n In such an event, client implementations **should** consider articles posted\n-prior to the key being compromised as possibly, but not surely trustworthy.\n+prior to the key being declared as compromised as possibly, but not surely\n+trustworthy.\n+\n+## Localisation\n+\n+An information website might want to publish articles in more than one language.\n+In such case, it **can** create sub-sources, each of which handling the\n+publication of its articles in one language. A source, regardless of whether it\n+is a sub-source or not, **must not** publish articles in more than one language.\n+\n+A sub-source is an entity similar to a source, with the exception that it\n+**must** be related to a source. Each sub-source **must** be a registered Matrix\n+user, and **must** register itself on the Matrix room through the publication of\n+a state event of the `network.informo.subsource` type, with the Matrix user's ID\n+as the event's state key. The event's content **must** be embedded in a [signed\n+Matrix event](/information-distribution/signature/#signed-matrix-event), signed\n+by one of the parent source's public keys, with its `signed` object using the\n+following model:\n+\n+| Parameter | Type | Req. | Description |\n+| ------------------- | ---------- | :--: | ------------------------------------------------------------------------------ |\n+| `sig_algo` | `string` | x | Algorithm the sub-source will use to cryptographically sign its articles. 🔧 |\n+| `sig_keys` | `[string]` | x | Public keys the sub-source will use to cryptographically sign its articles. 🔧 |\n+| `website` | `string` | | URL of the source's website in this language, if there's one. |\n+| `description` | `string` | | Short localised description of the source and its publications. |\n+| `custom` | `object` | | Additional information for custom client implementations. |\n+\n+The parent source **must** then reference the sub-source in its own registration\n+event, as a `lang` object. A `lang` object **can** reference the source that\n+emitted the `network.informo.source` event, but a Matrix user ID **must not** be\n+referenced more than once in a source registration's whole array of `lang`\n+objects.\n+\n+{{% notice info %}}\n+If a source decides to register itself as one if its own sub-sources, it doesn't\n+need to emit any `network.informo.subsource` event for this specific sub-source.\n+The articles published by the source acting as one of its sub-sources **must**\n+then be signed using the one of the source's public keys.\n+{{% /notice %}}\n+\n+### Example\n+\n+Considering the example of an example website publishing news\n+only in English, and registering itself as a source with the Matrix user id\n+`@acmenews:example.com`, and not registering any sub-source, the array of `lang`\n+objects would look like this:\n+\n+```\n+[\n+ {\n+ \"locale\": \"en\",\n+ \"mxid\": \"@acmenews:example.com\"\n+ }\n+]\n+```\n+\n+## Full example\n+\n+Let's consider a news website, named \"ACME News\", publishing news in both\n+English and French, each on a localised website. We'll also consider\n+`@acmenews:example.com` its main Informo source, and `@acmenewsen:example.com`\n+and `@acmenewsfr:example.com` its sub-sources, handling the publications of\n+articles, respectively in English and in French.\n+\n+Here are the state events it needs to emit to properly register all of its\n+sources.\n \n {{% notice note %}}\n-In the event of an organism or individual publishing information in several\n-languages, this organism or individual **must** register a source for each\n-publication language, with each registration containing the relevant data.\n+Please keep in mind that, although this can look like a troublesome thing to do,\n+it can easily be automated using one of the existing [SDKs for\n+Matrix](https://matrix.org/docs/projects/try-matrix-now.html#client-sdks).\n {{% /notice %}}\n \n-2️⃣: rest of the page\n+#### `network.informo.source`\n+\n+| Emitter | State key |\n+| ----------------------- | ----------------------- |\n+| `@acmenews:example.com` | `@acmenews:example.com` |\n+\n+```\n+{\n+ \"name\": \"ACME News\",\n+ \"origin\": \"ACME News Group\",\n+ \"website\": \"https://www.example.com\",\n+ \"description\": \"Lorem ipsum dolor sit amet, consectetur adipiscing elit.\",\n+ \"logo\": \"mxc://weu.informo.network/AtEuTuVSeIlZQgjEzjGyMDtG\",\n+ \"sig_algo\": \"ed25519\",\n+ \"sig_keys\": [\n+ \"IlRMeOPX2e0MurIyfWEucYBRVOEEUMrOHqn/8mLqMjA\"\n+ ],\n+ \"lang\": [\n+ {\n+ \"locale\": \"en\",\n+ \"mxid\": \"@acmenewsen:example.com\"\n+ },\n+ {\n+ \"locale\": \"fr\",\n+ \"mxid\": \"@acmenewsfr:example.com\"\n+ }\n+ ]\n+}\n+```\n+\n+#### `network.informo.subsource`\n+\n+| Emitter | State key |\n+| ------------------------- | ------------------------- |\n+| `@acmenewsen:example.com` | `@acmenewsen:example.com` |\n+\n+```\n+{\n+ \"algorithm\": \"ed25519\",\n+ \"sender_key\": \"IlRMeOPX2e0MurIyfWEucYBRVOEEUMrOHqn/8mLqMjA\",\n+ \"signature\": \"54ab6f6f18d63ef1\",\n+ \"signed\": {\n+ \"website\": \"https://www.example.com/en\",\n+ \"description\": \"This is the English source for ACME News.\",\n+ \"sig_algo\": \"ed25519\",\n+ \"sig_keys\": [\n+ \"Noh0oot2chahTheixeuviX6seidiweewahK/8mLeMjA\"\n+ ]\n+ }\n+}\n+```\n+\n+#### `network.informo.subsource`\n+\n+| Emitter | State key |\n+| ------------------------- | ------------------------- |\n+| `@acmenewsfr:example.com` | `@acmenewsfr:example.com` |\n+\n+```\n+{\n+ \"algorithm\": \"ed25519\",\n+ \"sender_key\": \"IlRMeOPX2e0MurIyfWEucYBRVOEEUMrOHqn/8mLqMjA\",\n+ \"signature\": \"0a1df56f18d63ef1\",\n+ \"signed\": {\n+ \"website\": \"https://www.example.com/fr\",\n+ \"description\": \"Ceci est la source française d'ACME News.\",\n+ \"sig_algo\": \"ed25519\",\n+ \"sig_keys\": [\n+ \"xee1PahM1jutohz2jiec1keeshoW0GooVei/8mLeMjA\"\n+ ]\n+ }\n+}\n+```\n+\n+Once all of these events have been published, `@acmenewsen:example.com` can\n+start publishing articles in English, and `@acmenewsfr:example.com` can start\n+publishing articles in French.\n+\n+## Alternate example\n+\n+Let's consider a news website, named \"ACME News\", publishing news in both\n+English and French, each on a localised website. We'll also consider\n+`@acmenews:example.com` its main Informo source, and `@acmenewsfr:example.com`\n+its sub-sources, handling the publications of articles in French. The","path":"content/information-distribution/source.md","position":221,"original_position":221,"commit_id":"3a91241ee81b703cbe850ef27d5a98dcee8f5695","original_commit_id":"3a91241ee81b703cbe850ef27d5a98dcee8f5695","user":{"login":"vabd","id":34184120,"node_id":"MDQ6VXNlcjM0MTg0MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/34184120?v=4","gravatar_id":"","url":"https://api.github.com/users/vabd","html_url":"https://github.com/vabd","followers_url":"https://api.github.com/users/vabd/followers","following_url":"https://api.github.com/users/vabd/following{/other_user}","gists_url":"https://api.github.com/users/vabd/gists{/gist_id}","starred_url":"https://api.github.com/users/vabd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vabd/subscriptions","organizations_url":"https://api.github.com/users/vabd/orgs","repos_url":"https://api.github.com/users/vabd/repos","events_url":"https://api.github.com/users/vabd/events{/privacy}","received_events_url":"https://api.github.com/users/vabd/received_events","type":"User","site_admin":false},"body":"Good catch. Copy-pasted too hastily.","created_at":"2018-11-28T19:11:30Z","updated_at":"2018-11-28T19:11:30Z","html_url":"https://github.com/Informo/specs/pull/11#discussion_r237222163","pull_request_url":"https://api.github.com/repos/Informo/specs/pulls/11","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Informo/specs/pulls/comments/237222163"},"html":{"href":"https://github.com/Informo/specs/pull/11#discussion_r237222163"},"pull_request":{"href":"https://api.github.com/repos/Informo/specs/pulls/11"}},"in_reply_to_id":236077051},"pull_request":{"url":"https://api.github.com/repos/Informo/specs/pulls/11","id":232465103,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDY1MTAz","html_url":"https://github.com/Informo/specs/pull/11","diff_url":"https://github.com/Informo/specs/pull/11.diff","patch_url":"https://github.com/Informo/specs/pull/11.patch","issue_url":"https://api.github.com/repos/Informo/specs/issues/11","number":11,"state":"open","locked":false,"title":"Sources data model","user":{"login":"vabd","id":34184120,"node_id":"MDQ6VXNlcjM0MTg0MTIw","avatar_url":"https://avatars1.githubusercontent.com/u/34184120?v=4","gravatar_id":"","url":"https://api.github.com/users/vabd","html_url":"https://github.com/vabd","followers_url":"https://api.github.com/users/vabd/followers","following_url":"https://api.github.com/users/vabd/following{/other_user}","gists_url":"https://api.github.com/users/vabd/gists{/gist_id}","starred_url":"https://api.github.com/users/vabd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vabd/subscriptions","organizations_url":"https://api.github.com/users/vabd/orgs","repos_url":"https://api.github.com/users/vabd/repos","events_url":"https://api.github.com/users/vabd/events{/privacy}","received_events_url":"https://api.github.com/users/vabd/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-20T21:29:49Z","updated_at":"2018-11-28T19:11:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b7aa1156d3d5b666762c476fe70e07bb41ed6a9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1088923856,"node_id":"MDU6TGFiZWwxMDg4OTIzODU2","url":"https://api.github.com/repos/Informo/specs/labels/scsp:review","name":"scsp:review","color":"f5f8ae","default":false},{"id":1088922816,"node_id":"MDU6TGFiZWwxMDg4OTIyODE2","url":"https://api.github.com/repos/Informo/specs/labels/type:behaviour","name":"type:behaviour","color":"cfcfcf","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Informo/specs/pulls/11/commits","review_comments_url":"https://api.github.com/repos/Informo/specs/pulls/11/comments","review_comment_url":"https://api.github.com/repos/Informo/specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Informo/specs/issues/11/comments","statuses_url":"https://api.github.com/repos/Informo/specs/statuses/3a91241ee81b703cbe850ef27d5a98dcee8f5695","head":{"label":"Informo:vabd/sources-p2","ref":"vabd/sources-p2","sha":"3a91241ee81b703cbe850ef27d5a98dcee8f5695","user":{"login":"Informo","id":34184183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTg0MTgz","avatar_url":"https://avatars3.githubusercontent.com/u/34184183?v=4","gravatar_id":"","url":"https://api.github.com/users/Informo","html_url":"https://github.com/Informo","followers_url":"https://api.github.com/users/Informo/followers","following_url":"https://api.github.com/users/Informo/following{/other_user}","gists_url":"https://api.github.com/users/Informo/gists{/gist_id}","starred_url":"https://api.github.com/users/Informo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Informo/subscriptions","organizations_url":"https://api.github.com/users/Informo/orgs","repos_url":"https://api.github.com/users/Informo/repos","events_url":"https://api.github.com/users/Informo/events{/privacy}","received_events_url":"https://api.github.com/users/Informo/received_events","type":"Organization","site_admin":false},"repo":{"id":150414149,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0MTQxNDk=","name":"specs","full_name":"Informo/specs","private":false,"owner":{"login":"Informo","id":34184183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTg0MTgz","avatar_url":"https://avatars3.githubusercontent.com/u/34184183?v=4","gravatar_id":"","url":"https://api.github.com/users/Informo","html_url":"https://github.com/Informo","followers_url":"https://api.github.com/users/Informo/followers","following_url":"https://api.github.com/users/Informo/following{/other_user}","gists_url":"https://api.github.com/users/Informo/gists{/gist_id}","starred_url":"https://api.github.com/users/Informo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Informo/subscriptions","organizations_url":"https://api.github.com/users/Informo/orgs","repos_url":"https://api.github.com/users/Informo/repos","events_url":"https://api.github.com/users/Informo/events{/privacy}","received_events_url":"https://api.github.com/users/Informo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Informo/specs","description":"Informo specifications","fork":false,"url":"https://api.github.com/repos/Informo/specs","forks_url":"https://api.github.com/repos/Informo/specs/forks","keys_url":"https://api.github.com/repos/Informo/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Informo/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Informo/specs/teams","hooks_url":"https://api.github.com/repos/Informo/specs/hooks","issue_events_url":"https://api.github.com/repos/Informo/specs/issues/events{/number}","events_url":"https://api.github.com/repos/Informo/specs/events","assignees_url":"https://api.github.com/repos/Informo/specs/assignees{/user}","branches_url":"https://api.github.com/repos/Informo/specs/branches{/branch}","tags_url":"https://api.github.com/repos/Informo/specs/tags","blobs_url":"https://api.github.com/repos/Informo/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Informo/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Informo/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Informo/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Informo/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Informo/specs/languages","stargazers_url":"https://api.github.com/repos/Informo/specs/stargazers","contributors_url":"https://api.github.com/repos/Informo/specs/contributors","subscribers_url":"https://api.github.com/repos/Informo/specs/subscribers","subscription_url":"https://api.github.com/repos/Informo/specs/subscription","commits_url":"https://api.github.com/repos/Informo/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Informo/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Informo/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Informo/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Informo/specs/contents/{+path}","compare_url":"https://api.github.com/repos/Informo/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Informo/specs/merges","archive_url":"https://api.github.com/repos/Informo/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Informo/specs/downloads","issues_url":"https://api.github.com/repos/Informo/specs/issues{/number}","pulls_url":"https://api.github.com/repos/Informo/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Informo/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Informo/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Informo/specs/labels{/name}","releases_url":"https://api.github.com/repos/Informo/specs/releases{/id}","deployments_url":"https://api.github.com/repos/Informo/specs/deployments","created_at":"2018-09-26T11:13:04Z","updated_at":"2018-11-21T12:08:07Z","pushed_at":"2018-11-22T12:11:25Z","git_url":"git://github.com/Informo/specs.git","ssh_url":"[email protected]:Informo/specs.git","clone_url":"https://github.com/Informo/specs.git","svn_url":"https://github.com/Informo/specs","homepage":"https://specs.informo.network","size":219,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"Informo:master","ref":"master","sha":"614177fe4b37d95a7cf55c11fd51c5499ac50cb8","user":{"login":"Informo","id":34184183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTg0MTgz","avatar_url":"https://avatars3.githubusercontent.com/u/34184183?v=4","gravatar_id":"","url":"https://api.github.com/users/Informo","html_url":"https://github.com/Informo","followers_url":"https://api.github.com/users/Informo/followers","following_url":"https://api.github.com/users/Informo/following{/other_user}","gists_url":"https://api.github.com/users/Informo/gists{/gist_id}","starred_url":"https://api.github.com/users/Informo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Informo/subscriptions","organizations_url":"https://api.github.com/users/Informo/orgs","repos_url":"https://api.github.com/users/Informo/repos","events_url":"https://api.github.com/users/Informo/events{/privacy}","received_events_url":"https://api.github.com/users/Informo/received_events","type":"Organization","site_admin":false},"repo":{"id":150414149,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA0MTQxNDk=","name":"specs","full_name":"Informo/specs","private":false,"owner":{"login":"Informo","id":34184183,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MTg0MTgz","avatar_url":"https://avatars3.githubusercontent.com/u/34184183?v=4","gravatar_id":"","url":"https://api.github.com/users/Informo","html_url":"https://github.com/Informo","followers_url":"https://api.github.com/users/Informo/followers","following_url":"https://api.github.com/users/Informo/following{/other_user}","gists_url":"https://api.github.com/users/Informo/gists{/gist_id}","starred_url":"https://api.github.com/users/Informo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Informo/subscriptions","organizations_url":"https://api.github.com/users/Informo/orgs","repos_url":"https://api.github.com/users/Informo/repos","events_url":"https://api.github.com/users/Informo/events{/privacy}","received_events_url":"https://api.github.com/users/Informo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Informo/specs","description":"Informo specifications","fork":false,"url":"https://api.github.com/repos/Informo/specs","forks_url":"https://api.github.com/repos/Informo/specs/forks","keys_url":"https://api.github.com/repos/Informo/specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Informo/specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Informo/specs/teams","hooks_url":"https://api.github.com/repos/Informo/specs/hooks","issue_events_url":"https://api.github.com/repos/Informo/specs/issues/events{/number}","events_url":"https://api.github.com/repos/Informo/specs/events","assignees_url":"https://api.github.com/repos/Informo/specs/assignees{/user}","branches_url":"https://api.github.com/repos/Informo/specs/branches{/branch}","tags_url":"https://api.github.com/repos/Informo/specs/tags","blobs_url":"https://api.github.com/repos/Informo/specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Informo/specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Informo/specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Informo/specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Informo/specs/statuses/{sha}","languages_url":"https://api.github.com/repos/Informo/specs/languages","stargazers_url":"https://api.github.com/repos/Informo/specs/stargazers","contributors_url":"https://api.github.com/repos/Informo/specs/contributors","subscribers_url":"https://api.github.com/repos/Informo/specs/subscribers","subscription_url":"https://api.github.com/repos/Informo/specs/subscription","commits_url":"https://api.github.com/repos/Informo/specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Informo/specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Informo/specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Informo/specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Informo/specs/contents/{+path}","compare_url":"https://api.github.com/repos/Informo/specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Informo/specs/merges","archive_url":"https://api.github.com/repos/Informo/specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Informo/specs/downloads","issues_url":"https://api.github.com/repos/Informo/specs/issues{/number}","pulls_url":"https://api.github.com/repos/Informo/specs/pulls{/number}","milestones_url":"https://api.github.com/repos/Informo/specs/milestones{/number}","notifications_url":"https://api.github.com/repos/Informo/specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Informo/specs/labels{/name}","releases_url":"https://api.github.com/repos/Informo/specs/releases{/id}","deployments_url":"https://api.github.com/repos/Informo/specs/deployments","created_at":"2018-09-26T11:13:04Z","updated_at":"2018-11-21T12:08:07Z","pushed_at":"2018-11-22T12:11:25Z","git_url":"git://github.com/Informo/specs.git","ssh_url":"[email protected]:Informo/specs.git","clone_url":"https://github.com/Informo/specs.git","svn_url":"https://github.com/Informo/specs","homepage":"https://specs.informo.network","size":219,"stargazers_count":3,"watchers_count":3,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Informo/specs/pulls/11"},"html":{"href":"https://github.com/Informo/specs/pull/11"},"issue":{"href":"https://api.github.com/repos/Informo/specs/issues/11"},"comments":{"href":"https://api.github.com/repos/Informo/specs/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/Informo/specs/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/Informo/specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Informo/specs/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/Informo/specs/statuses/3a91241ee81b703cbe850ef27d5a98dcee8f5695"}},"author_association":"MEMBER"}}

8664099298

{"actor":{"display_login":"vabd"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments/232470169","pull_request_review_id":173679677,"id":232470169,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQ3MDE2OQ==","diff_hunk":"@@ -31,7 +31,7 @@ import (\n \t\"github.com/iotexproject/iotex-core/trie\"\n )\n \n-var cfg = &config.Default\n+var cfg = config.Default","path":"state/factory_test.go","position":5,"original_position":5,"commit_id":"1459b3f0a0a7042233f2fd407cf23c765d9d9f76","original_commit_id":"1459b3f0a0a7042233f2fd407cf23c765d9d9f76","user":{"login":"golangcibot","id":42910462,"node_id":"MDQ6VXNlcjQyOTEwNDYy","avatar_url":"https://avatars1.githubusercontent.com/u/42910462?v=4","gravatar_id":"","url":"https://api.github.com/users/golangcibot","html_url":"https://github.com/golangcibot","followers_url":"https://api.github.com/users/golangcibot/followers","following_url":"https://api.github.com/users/golangcibot/following{/other_user}","gists_url":"https://api.github.com/users/golangcibot/gists{/gist_id}","starred_url":"https://api.github.com/users/golangcibot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/golangcibot/subscriptions","organizations_url":"https://api.github.com/users/golangcibot/orgs","repos_url":"https://api.github.com/users/golangcibot/repos","events_url":"https://api.github.com/users/golangcibot/events{/privacy}","received_events_url":"https://api.github.com/users/golangcibot/received_events","type":"User","site_admin":false},"body":"`cfg` is a global variable","created_at":"2018-11-11T00:05:39Z","updated_at":"2018-11-11T00:05:40Z","html_url":"https://github.com/iotexproject/iotex-core/pull/309#discussion_r232470169","pull_request_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/309","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments/232470169"},"html":{"href":"https://github.com/iotexproject/iotex-core/pull/309#discussion_r232470169"},"pull_request":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/309"}}},"pull_request":{"url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/309","id":229921639,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTIxNjM5","html_url":"https://github.com/iotexproject/iotex-core/pull/309","diff_url":"https://github.com/iotexproject/iotex-core/pull/309.diff","patch_url":"https://github.com/iotexproject/iotex-core/pull/309.patch","issue_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/309","number":309,"state":"open","locked":false,"title":"Pass config struct instead of pointer","user":{"login":"zjshen14","id":35021395,"node_id":"MDQ6VXNlcjM1MDIxMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/35021395?v=4","gravatar_id":"","url":"https://api.github.com/users/zjshen14","html_url":"https://github.com/zjshen14","followers_url":"https://api.github.com/users/zjshen14/followers","following_url":"https://api.github.com/users/zjshen14/following{/other_user}","gists_url":"https://api.github.com/users/zjshen14/gists{/gist_id}","starred_url":"https://api.github.com/users/zjshen14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjshen14/subscriptions","organizations_url":"https://api.github.com/users/zjshen14/orgs","repos_url":"https://api.github.com/users/zjshen14/repos","events_url":"https://api.github.com/users/zjshen14/events{/privacy}","received_events_url":"https://api.github.com/users/zjshen14/received_events","type":"User","site_admin":false},"body":"Now the whole system almost share the same copy of a config struct by using the pointer. This PR changes to copying config struct instead of pointer to make every components have an immutable config copy.\r\n\r\nBTW, I realize there's another thing need to fix. Most components take the root config as the param. Instead, they should be able to only get the relevant section","created_at":"2018-11-11T00:04:36Z","updated_at":"2018-11-11T00:05:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"af62e05e7b05cbf28191d43d4e89bd752cd8eae7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"protocol-team","id":2774529,"node_id":"MDQ6VGVhbTI3NzQ1Mjk=","slug":"protocol-team","description":"protocol dev team","privacy":"closed","url":"https://api.github.com/teams/2774529","members_url":"https://api.github.com/teams/2774529/members{/member}","repositories_url":"https://api.github.com/teams/2774529/repos","permission":"pull"}],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/309/commits","review_comments_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/309/comments","review_comment_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/309/comments","statuses_url":"https://api.github.com/repos/iotexproject/iotex-core/statuses/1459b3f0a0a7042233f2fd407cf23c765d9d9f76","head":{"label":"zjshen14:master","ref":"master","sha":"1459b3f0a0a7042233f2fd407cf23c765d9d9f76","user":{"login":"zjshen14","id":35021395,"node_id":"MDQ6VXNlcjM1MDIxMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/35021395?v=4","gravatar_id":"","url":"https://api.github.com/users/zjshen14","html_url":"https://github.com/zjshen14","followers_url":"https://api.github.com/users/zjshen14/followers","following_url":"https://api.github.com/users/zjshen14/following{/other_user}","gists_url":"https://api.github.com/users/zjshen14/gists{/gist_id}","starred_url":"https://api.github.com/users/zjshen14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjshen14/subscriptions","organizations_url":"https://api.github.com/users/zjshen14/orgs","repos_url":"https://api.github.com/users/zjshen14/repos","events_url":"https://api.github.com/users/zjshen14/events{/privacy}","received_events_url":"https://api.github.com/users/zjshen14/received_events","type":"User","site_admin":false},"repo":{"id":147471673,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc0NzE2NzM=","name":"iotex-core","full_name":"zjshen14/iotex-core","private":false,"owner":{"login":"zjshen14","id":35021395,"node_id":"MDQ6VXNlcjM1MDIxMzk1","avatar_url":"https://avatars3.githubusercontent.com/u/35021395?v=4","gravatar_id":"","url":"https://api.github.com/users/zjshen14","html_url":"https://github.com/zjshen14","followers_url":"https://api.github.com/users/zjshen14/followers","following_url":"https://api.github.com/users/zjshen14/following{/other_user}","gists_url":"https://api.github.com/users/zjshen14/gists{/gist_id}","starred_url":"https://api.github.com/users/zjshen14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zjshen14/subscriptions","organizations_url":"https://api.github.com/users/zjshen14/orgs","repos_url":"https://api.github.com/users/zjshen14/repos","events_url":"https://api.github.com/users/zjshen14/events{/privacy}","received_events_url":"https://api.github.com/users/zjshen14/received_events","type":"User","site_admin":false},"html_url":"https://github.com/zjshen14/iotex-core","description":"Connecting the physical world, block by block.","fork":true,"url":"https://api.github.com/repos/zjshen14/iotex-core","forks_url":"https://api.github.com/repos/zjshen14/iotex-core/forks","keys_url":"https://api.github.com/repos/zjshen14/iotex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zjshen14/iotex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zjshen14/iotex-core/teams","hooks_url":"https://api.github.com/repos/zjshen14/iotex-core/hooks","issue_events_url":"https://api.github.com/repos/zjshen14/iotex-core/issues/events{/number}","events_url":"https://api.github.com/repos/zjshen14/iotex-core/events","assignees_url":"https://api.github.com/repos/zjshen14/iotex-core/assignees{/user}","branches_url":"https://api.github.com/repos/zjshen14/iotex-core/branches{/branch}","tags_url":"https://api.github.com/repos/zjshen14/iotex-core/tags","blobs_url":"https://api.github.com/repos/zjshen14/iotex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zjshen14/iotex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zjshen14/iotex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/zjshen14/iotex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zjshen14/iotex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/zjshen14/iotex-core/languages","stargazers_url":"https://api.github.com/repos/zjshen14/iotex-core/stargazers","contributors_url":"https://api.github.com/repos/zjshen14/iotex-core/contributors","subscribers_url":"https://api.github.com/repos/zjshen14/iotex-core/subscribers","subscription_url":"https://api.github.com/repos/zjshen14/iotex-core/subscription","commits_url":"https://api.github.com/repos/zjshen14/iotex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/zjshen14/iotex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/zjshen14/iotex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/zjshen14/iotex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/zjshen14/iotex-core/contents/{+path}","compare_url":"https://api.github.com/repos/zjshen14/iotex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zjshen14/iotex-core/merges","archive_url":"https://api.github.com/repos/zjshen14/iotex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zjshen14/iotex-core/downloads","issues_url":"https://api.github.com/repos/zjshen14/iotex-core/issues{/number}","pulls_url":"https://api.github.com/repos/zjshen14/iotex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/zjshen14/iotex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/zjshen14/iotex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zjshen14/iotex-core/labels{/name}","releases_url":"https://api.github.com/repos/zjshen14/iotex-core/releases{/id}","deployments_url":"https://api.github.com/repos/zjshen14/iotex-core/deployments","created_at":"2018-09-05T06:38:20Z","updated_at":"2018-11-11T00:00:10Z","pushed_at":"2018-11-11T00:00:08Z","git_url":"git://github.com/zjshen14/iotex-core.git","ssh_url":"[email protected]:zjshen14/iotex-core.git","clone_url":"https://github.com/zjshen14/iotex-core.git","svn_url":"https://github.com/zjshen14/iotex-core","homepage":"https://iotex.io","size":7545,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"iotexproject:master","ref":"master","sha":"c6b8317616da01ecbf3d5a0547671ae90dc1b3f6","user":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"repo":{"id":130281002,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAyODEwMDI=","name":"iotex-core","full_name":"iotexproject/iotex-core","private":false,"owner":{"login":"iotexproject","id":34317526,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzE3NTI2","avatar_url":"https://avatars3.githubusercontent.com/u/34317526?v=4","gravatar_id":"","url":"https://api.github.com/users/iotexproject","html_url":"https://github.com/iotexproject","followers_url":"https://api.github.com/users/iotexproject/followers","following_url":"https://api.github.com/users/iotexproject/following{/other_user}","gists_url":"https://api.github.com/users/iotexproject/gists{/gist_id}","starred_url":"https://api.github.com/users/iotexproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotexproject/subscriptions","organizations_url":"https://api.github.com/users/iotexproject/orgs","repos_url":"https://api.github.com/users/iotexproject/repos","events_url":"https://api.github.com/users/iotexproject/events{/privacy}","received_events_url":"https://api.github.com/users/iotexproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/iotexproject/iotex-core","description":"Official Go implementation of the IoTeX protocol","fork":false,"url":"https://api.github.com/repos/iotexproject/iotex-core","forks_url":"https://api.github.com/repos/iotexproject/iotex-core/forks","keys_url":"https://api.github.com/repos/iotexproject/iotex-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotexproject/iotex-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotexproject/iotex-core/teams","hooks_url":"https://api.github.com/repos/iotexproject/iotex-core/hooks","issue_events_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/events{/number}","events_url":"https://api.github.com/repos/iotexproject/iotex-core/events","assignees_url":"https://api.github.com/repos/iotexproject/iotex-core/assignees{/user}","branches_url":"https://api.github.com/repos/iotexproject/iotex-core/branches{/branch}","tags_url":"https://api.github.com/repos/iotexproject/iotex-core/tags","blobs_url":"https://api.github.com/repos/iotexproject/iotex-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotexproject/iotex-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotexproject/iotex-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotexproject/iotex-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotexproject/iotex-core/statuses/{sha}","languages_url":"https://api.github.com/repos/iotexproject/iotex-core/languages","stargazers_url":"https://api.github.com/repos/iotexproject/iotex-core/stargazers","contributors_url":"https://api.github.com/repos/iotexproject/iotex-core/contributors","subscribers_url":"https://api.github.com/repos/iotexproject/iotex-core/subscribers","subscription_url":"https://api.github.com/repos/iotexproject/iotex-core/subscription","commits_url":"https://api.github.com/repos/iotexproject/iotex-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotexproject/iotex-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotexproject/iotex-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotexproject/iotex-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotexproject/iotex-core/contents/{+path}","compare_url":"https://api.github.com/repos/iotexproject/iotex-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotexproject/iotex-core/merges","archive_url":"https://api.github.com/repos/iotexproject/iotex-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotexproject/iotex-core/downloads","issues_url":"https://api.github.com/repos/iotexproject/iotex-core/issues{/number}","pulls_url":"https://api.github.com/repos/iotexproject/iotex-core/pulls{/number}","milestones_url":"https://api.github.com/repos/iotexproject/iotex-core/milestones{/number}","notifications_url":"https://api.github.com/repos/iotexproject/iotex-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotexproject/iotex-core/labels{/name}","releases_url":"https://api.github.com/repos/iotexproject/iotex-core/releases{/id}","deployments_url":"https://api.github.com/repos/iotexproject/iotex-core/deployments","created_at":"2018-04-19T22:56:20Z","updated_at":"2018-11-09T18:03:40Z","pushed_at":"2018-11-11T00:04:37Z","git_url":"git://github.com/iotexproject/iotex-core.git","ssh_url":"[email protected]:iotexproject/iotex-core.git","clone_url":"https://github.com/iotexproject/iotex-core.git","svn_url":"https://github.com/iotexproject/iotex-core","homepage":"https://iotex.io","size":7535,"stargazers_count":796,"watchers_count":796,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":94,"open_issues":22,"watchers":796,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/309"},"html":{"href":"https://github.com/iotexproject/iotex-core/pull/309"},"issue":{"href":"https://api.github.com/repos/iotexproject/iotex-core/issues/309"},"comments":{"href":"https://api.github.com/repos/iotexproject/iotex-core/issues/309/comments"},"review_comments":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/309/comments"},"review_comment":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotexproject/iotex-core/pulls/309/commits"},"statuses":{"href":"https://api.github.com/repos/iotexproject/iotex-core/statuses/1459b3f0a0a7042233f2fd407cf23c765d9d9f76"}},"author_association":"CONTRIBUTOR"}}

8568665669

{"actor":{"display_login":"golangcibot"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/transcom/mymove/pulls/comments/241215533","pull_request_review_id":184430497,"id":241215533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTIxNTUzMw==","diff_hunk":"@@ -28,12 +29,32 @@ func RandomSCAC() string {\n \treturn string(b)\n }\n \n+// DefaultSupplierID generates a default SupplierID for a given SCAC\n+func DefaultSupplierID(scac string) *string {\n+\tvar supplierID = scac + defaultPayeeCode\n+\treturn &supplierID\n+}\n+\n // MakeTSP makes a single transportation service provider record.\n func MakeTSP(db *pop.Connection, assertions Assertions) models.TransportationServiceProvider {\n \n+\t// Check to see if TSP has already been created\n+\texistingTsp := models.TransportationServiceProvider{}\n+\tif !isZeroUUID(assertions.TransportationServiceProvider.ID) {\n+\t\tif err := db.Find(&existingTsp, assertions.TransportationServiceProvider.ID); err == nil {\n+\t\t\t// Found existing TSP for this ID\n+\t\t\treturn existingTsp\n+\t\t}\n+\t}\n+\n \tscac := assertions.TransportationServiceProvider.StandardCarrierAlphaCode\n \tif scac == \"\" {\n-\t\tscac = RandomSCAC()\n+\t\tscac = \"ABCD\" //RandomSCAC()","path":"pkg/testdatagen/make_tsp_records.go","position":33,"original_position":33,"commit_id":"713d9754bca9234f94564943b0ca1adcfc8cc649","original_commit_id":"713d9754bca9234f94564943b0ca1adcfc8cc649","user":{"login":"akostibas","id":859429,"node_id":"MDQ6VXNlcjg1OTQyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/859429?v=4","gravatar_id":"","url":"https://api.github.com/users/akostibas","html_url":"https://github.com/akostibas","followers_url":"https://api.github.com/users/akostibas/followers","following_url":"https://api.github.com/users/akostibas/following{/other_user}","gists_url":"https://api.github.com/users/akostibas/gists{/gist_id}","starred_url":"https://api.github.com/users/akostibas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akostibas/subscriptions","organizations_url":"https://api.github.com/users/akostibas/orgs","repos_url":"https://api.github.com/users/akostibas/repos","events_url":"https://api.github.com/users/akostibas/events{/privacy}","received_events_url":"https://api.github.com/users/akostibas/received_events","type":"User","site_admin":false},"body":"Why did you remove `RandomSCAC()`? If there's a good reason to remove it, I don't think it's worth keeping the comment of the old function name.","created_at":"2018-12-12T22:53:31Z","updated_at":"2018-12-12T22:55:27Z","html_url":"https://github.com/transcom/mymove/pull/1452#discussion_r241215533","pull_request_url":"https://api.github.com/repos/transcom/mymove/pulls/1452","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments/241215533"},"html":{"href":"https://github.com/transcom/mymove/pull/1452#discussion_r241215533"},"pull_request":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1452"}}},"pull_request":{"url":"https://api.github.com/repos/transcom/mymove/pulls/1452","id":238095901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MDk1OTAx","html_url":"https://github.com/transcom/mymove/pull/1452","diff_url":"https://github.com/transcom/mymove/pull/1452.diff","patch_url":"https://github.com/transcom/mymove/pull/1452.patch","issue_url":"https://api.github.com/repos/transcom/mymove/issues/1452","number":1452,"state":"open","locked":false,"title":"Jm 160744363 add supplier id invoice generator","user":{"login":"jacquelineIO","id":1359520,"node_id":"MDQ6VXNlcjEzNTk1MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1359520?v=4","gravatar_id":"","url":"https://api.github.com/users/jacquelineIO","html_url":"https://github.com/jacquelineIO","followers_url":"https://api.github.com/users/jacquelineIO/followers","following_url":"https://api.github.com/users/jacquelineIO/following{/other_user}","gists_url":"https://api.github.com/users/jacquelineIO/gists{/gist_id}","starred_url":"https://api.github.com/users/jacquelineIO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacquelineIO/subscriptions","organizations_url":"https://api.github.com/users/jacquelineIO/orgs","repos_url":"https://api.github.com/users/jacquelineIO/repos","events_url":"https://api.github.com/users/jacquelineIO/events{/privacy}","received_events_url":"https://api.github.com/users/jacquelineIO/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nThis PR adds the `SupplierID` for the Accepted TransportationServiceProvider to the EDI generator. The TransportationServerProvider is accessed via `Shipment > ShipmentOffer > TransportationServiceProviderPerformance > TransportationServiceProvider`. `SupplierID` is a required field for the generation of EDIs before sending to GEX/Syncada.\r\n\r\n## Reviewer Notes\r\n\r\n`\"ShipmentOffers.TransportationServiceProvider\"` was removed from the Eager fetch for shipment. It had been recently added and since it has been added I have learned that we want to use `\"ShipmentOffers.TransportationServiceProviderPerformance.TransportationServiceProvider\"` instead. More [changes](https://www.pivotaltracker.com/story/show/160303967) down the pipeline are planned to remove the use of `\"ShipmentOffers.TransportationServiceProvider\"`.\r\n\r\n## Setup\r\n\r\n### Option 1\r\n\r\n`make db_populate_e2e`\r\nGo to tsp-local, login as tsp.\r\nGo to In Transit shipments, click on shipment with locator ENTDEL.\r\nChoose an actual pickup date, and then click on Delivered.\r\n`go run cmd/generate_shipment_edi/main.go --moveID 135af727-f570-4c7e-bf5b-878d717ef83c`\r\n\r\n### Option 2\r\n\r\nYou will have to follow the setup to create a HHG SM move and progress through until the shipment is delivered in order to view the invoice.\r\n\r\n### Some specific test to run\r\n\r\nThe specific `server_test` for this change is:\r\n```shell\r\ngo test ./pkg/edi/invoice -testify.m TestEDIString\r\ngo test ./pkg/edi/invoice -testify.m TestInvoiceSuite\r\n```\r\n## Code Review Verification Steps\r\n\r\n* [ ] Code follows the guidelines for [Logging](./docs/backend.md#logging)\r\n* [ ] The requirements listed in\r\n [Querying the Database Safely](./docs/backend.md#querying-the-database-safely)\r\n have been satisfied.\r\n* Any new migrations/schema changes:\r\n * [ ] Follow our guidelines for zero-downtime deploys (see [Zero-Downtime Deploys](./docs/database.md#zero-downtime-migrations))\r\n * [ ] Have been communicated to #dp3-engineering\r\n* [ ] There are no aXe warnings for UI.\r\n* [ ] This works in IE.\r\n* Any new client dependencies (Google Analytics, hosted libraries, CDNs, etc) have been:\r\n * [ ] Communicated to @willowbl00\r\n * [ ] Added to the list of [network dependencies](https://github.com/transcom/mymove#client-network-dependencies)\r\n* [ ] Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)\r\n* [ ] Request review from a member of a different team.\r\n* [ ] Have the Pivotal acceptance criteria been met for this change?\r\n\r\n## References\r\n\r\n* [Pivotal story](https://www.pivotaltracker.com/story/show/160744363) for this change\r\n\r\n## Screenshots\r\n\r\nNone.\r\n","created_at":"2018-12-12T16:16:04Z","updated_at":"2018-12-12T22:55:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf5302c757e287693671206b46eabd8083eff2ac","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Ryan-Koch","id":4325613,"node_id":"MDQ6VXNlcjQzMjU2MTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4325613?v=4","gravatar_id":"","url":"https://api.github.com/users/Ryan-Koch","html_url":"https://github.com/Ryan-Koch","followers_url":"https://api.github.com/users/Ryan-Koch/followers","following_url":"https://api.github.com/users/Ryan-Koch/following{/other_user}","gists_url":"https://api.github.com/users/Ryan-Koch/gists{/gist_id}","starred_url":"https://api.github.com/users/Ryan-Koch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ryan-Koch/subscriptions","organizations_url":"https://api.github.com/users/Ryan-Koch/orgs","repos_url":"https://api.github.com/users/Ryan-Koch/repos","events_url":"https://api.github.com/users/Ryan-Koch/events{/privacy}","received_events_url":"https://api.github.com/users/Ryan-Koch/received_events","type":"User","site_admin":false},{"login":"reggieriser","id":4960757,"node_id":"MDQ6VXNlcjQ5NjA3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/4960757?v=4","gravatar_id":"","url":"https://api.github.com/users/reggieriser","html_url":"https://github.com/reggieriser","followers_url":"https://api.github.com/users/reggieriser/followers","following_url":"https://api.github.com/users/reggieriser/following{/other_user}","gists_url":"https://api.github.com/users/reggieriser/gists{/gist_id}","starred_url":"https://api.github.com/users/reggieriser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reggieriser/subscriptions","organizations_url":"https://api.github.com/users/reggieriser/orgs","repos_url":"https://api.github.com/users/reggieriser/repos","events_url":"https://api.github.com/users/reggieriser/events{/privacy}","received_events_url":"https://api.github.com/users/reggieriser/received_events","type":"User","site_admin":false},{"login":"stangah","id":5151804,"node_id":"MDQ6VXNlcjUxNTE4MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5151804?v=4","gravatar_id":"","url":"https://api.github.com/users/stangah","html_url":"https://github.com/stangah","followers_url":"https://api.github.com/users/stangah/followers","following_url":"https://api.github.com/users/stangah/following{/other_user}","gists_url":"https://api.github.com/users/stangah/gists{/gist_id}","starred_url":"https://api.github.com/users/stangah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stangah/subscriptions","organizations_url":"https://api.github.com/users/stangah/orgs","repos_url":"https://api.github.com/users/stangah/repos","events_url":"https://api.github.com/users/stangah/events{/privacy}","received_events_url":"https://api.github.com/users/stangah/received_events","type":"User","site_admin":false},{"login":"mikena-truss","id":44583912,"node_id":"MDQ6VXNlcjQ0NTgzOTEy","avatar_url":"https://avatars0.githubusercontent.com/u/44583912?v=4","gravatar_id":"","url":"https://api.github.com/users/mikena-truss","html_url":"https://github.com/mikena-truss","followers_url":"https://api.github.com/users/mikena-truss/followers","following_url":"https://api.github.com/users/mikena-truss/following{/other_user}","gists_url":"https://api.github.com/users/mikena-truss/gists{/gist_id}","starred_url":"https://api.github.com/users/mikena-truss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikena-truss/subscriptions","organizations_url":"https://api.github.com/users/mikena-truss/orgs","repos_url":"https://api.github.com/users/mikena-truss/repos","events_url":"https://api.github.com/users/mikena-truss/events{/privacy}","received_events_url":"https://api.github.com/users/mikena-truss/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/transcom/mymove/pulls/1452/commits","review_comments_url":"https://api.github.com/repos/transcom/mymove/pulls/1452/comments","review_comment_url":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}","comments_url":"https://api.github.com/repos/transcom/mymove/issues/1452/comments","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/713d9754bca9234f94564943b0ca1adcfc8cc649","head":{"label":"transcom:jm-160744363-add-supplier-id-invoice-generator","ref":"jm-160744363-add-supplier-id-invoice-generator","sha":"713d9754bca9234f94564943b0ca1adcfc8cc649","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"MyMove Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-12-12T19:18:34Z","pushed_at":"2018-12-12T22:54:55Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"[email protected]:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":"https://move.mil","size":32063,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":21,"watchers":16,"default_branch":"master"}},"base":{"label":"transcom:master","ref":"master","sha":"3833f6ff0f386f5ca07fa04113a3c9509de29458","user":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"repo":{"id":114694829,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ2OTQ4Mjk=","name":"mymove","full_name":"transcom/mymove","private":false,"owner":{"login":"transcom","id":34352343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MzUyMzQz","avatar_url":"https://avatars0.githubusercontent.com/u/34352343?v=4","gravatar_id":"","url":"https://api.github.com/users/transcom","html_url":"https://github.com/transcom","followers_url":"https://api.github.com/users/transcom/followers","following_url":"https://api.github.com/users/transcom/following{/other_user}","gists_url":"https://api.github.com/users/transcom/gists{/gist_id}","starred_url":"https://api.github.com/users/transcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/transcom/subscriptions","organizations_url":"https://api.github.com/users/transcom/orgs","repos_url":"https://api.github.com/users/transcom/repos","events_url":"https://api.github.com/users/transcom/events{/privacy}","received_events_url":"https://api.github.com/users/transcom/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/transcom/mymove","description":"MyMove Personal Property Prototype","fork":false,"url":"https://api.github.com/repos/transcom/mymove","forks_url":"https://api.github.com/repos/transcom/mymove/forks","keys_url":"https://api.github.com/repos/transcom/mymove/keys{/key_id}","collaborators_url":"https://api.github.com/repos/transcom/mymove/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/transcom/mymove/teams","hooks_url":"https://api.github.com/repos/transcom/mymove/hooks","issue_events_url":"https://api.github.com/repos/transcom/mymove/issues/events{/number}","events_url":"https://api.github.com/repos/transcom/mymove/events","assignees_url":"https://api.github.com/repos/transcom/mymove/assignees{/user}","branches_url":"https://api.github.com/repos/transcom/mymove/branches{/branch}","tags_url":"https://api.github.com/repos/transcom/mymove/tags","blobs_url":"https://api.github.com/repos/transcom/mymove/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/transcom/mymove/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/transcom/mymove/git/refs{/sha}","trees_url":"https://api.github.com/repos/transcom/mymove/git/trees{/sha}","statuses_url":"https://api.github.com/repos/transcom/mymove/statuses/{sha}","languages_url":"https://api.github.com/repos/transcom/mymove/languages","stargazers_url":"https://api.github.com/repos/transcom/mymove/stargazers","contributors_url":"https://api.github.com/repos/transcom/mymove/contributors","subscribers_url":"https://api.github.com/repos/transcom/mymove/subscribers","subscription_url":"https://api.github.com/repos/transcom/mymove/subscription","commits_url":"https://api.github.com/repos/transcom/mymove/commits{/sha}","git_commits_url":"https://api.github.com/repos/transcom/mymove/git/commits{/sha}","comments_url":"https://api.github.com/repos/transcom/mymove/comments{/number}","issue_comment_url":"https://api.github.com/repos/transcom/mymove/issues/comments{/number}","contents_url":"https://api.github.com/repos/transcom/mymove/contents/{+path}","compare_url":"https://api.github.com/repos/transcom/mymove/compare/{base}...{head}","merges_url":"https://api.github.com/repos/transcom/mymove/merges","archive_url":"https://api.github.com/repos/transcom/mymove/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/transcom/mymove/downloads","issues_url":"https://api.github.com/repos/transcom/mymove/issues{/number}","pulls_url":"https://api.github.com/repos/transcom/mymove/pulls{/number}","milestones_url":"https://api.github.com/repos/transcom/mymove/milestones{/number}","notifications_url":"https://api.github.com/repos/transcom/mymove/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/transcom/mymove/labels{/name}","releases_url":"https://api.github.com/repos/transcom/mymove/releases{/id}","deployments_url":"https://api.github.com/repos/transcom/mymove/deployments","created_at":"2017-12-18T22:41:12Z","updated_at":"2018-12-12T19:18:34Z","pushed_at":"2018-12-12T22:54:55Z","git_url":"git://github.com/transcom/mymove.git","ssh_url":"[email protected]:transcom/mymove.git","clone_url":"https://github.com/transcom/mymove.git","svn_url":"https://github.com/transcom/mymove","homepage":"https://move.mil","size":32063,"stargazers_count":16,"watchers_count":16,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":13,"open_issues":21,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1452"},"html":{"href":"https://github.com/transcom/mymove/pull/1452"},"issue":{"href":"https://api.github.com/repos/transcom/mymove/issues/1452"},"comments":{"href":"https://api.github.com/repos/transcom/mymove/issues/1452/comments"},"review_comments":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1452/comments"},"review_comment":{"href":"https://api.github.com/repos/transcom/mymove/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/transcom/mymove/pulls/1452/commits"},"statuses":{"href":"https://api.github.com/repos/transcom/mymove/statuses/713d9754bca9234f94564943b0ca1adcfc8cc649"}},"author_association":"CONTRIBUTOR"}}

8744627184

{"actor":{"display_login":"akostibas"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/167398714","pull_request_review_id":95622068,"id":167398714,"diff_hunk":"@@ -0,0 +1,12 @@\n+package seedu.addressbook.data.person;\n+\n+public class Block {","path":"src/seedu/addressbook/data/person/Block.java","position":3,"original_position":3,"commit_id":"c9ee947b8612a5c4abe581d62a54eeb38213ca6f","original_commit_id":"c9ee947b8612a5c4abe581d62a54eeb38213ca6f","user":{"login":"trafalgarandre","id":21093598,"avatar_url":"https://avatars1.githubusercontent.com/u/21093598?v=4","gravatar_id":"","url":"https://api.github.com/users/trafalgarandre","html_url":"https://github.com/trafalgarandre","followers_url":"https://api.github.com/users/trafalgarandre/followers","following_url":"https://api.github.com/users/trafalgarandre/following{/other_user}","gists_url":"https://api.github.com/users/trafalgarandre/gists{/gist_id}","starred_url":"https://api.github.com/users/trafalgarandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trafalgarandre/subscriptions","organizations_url":"https://api.github.com/users/trafalgarandre/orgs","repos_url":"https://api.github.com/users/trafalgarandre/repos","events_url":"https://api.github.com/users/trafalgarandre/events{/privacy}","received_events_url":"https://api.github.com/users/trafalgarandre/received_events","type":"User","site_admin":false},"body":"Totally forgot. Thanks for the comment!","created_at":"2018-02-10T13:12:37Z","updated_at":"2018-02-10T13:12:38Z","html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/78#discussion_r167398714","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/78","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/167398714"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/78#discussion_r167398714"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/78"}},"in_reply_to_id":166515401},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/78","id":167454079,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/78","diff_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/78.diff","patch_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/78.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/78","number":78,"state":"open","locked":false,"title":"[W4.4b][W09-A3]Do Andre Khoi Nguyen","user":{"login":"trafalgarandre","id":21093598,"avatar_url":"https://avatars1.githubusercontent.com/u/21093598?v=4","gravatar_id":"","url":"https://api.github.com/users/trafalgarandre","html_url":"https://github.com/trafalgarandre","followers_url":"https://api.github.com/users/trafalgarandre/followers","following_url":"https://api.github.com/users/trafalgarandre/following{/other_user}","gists_url":"https://api.github.com/users/trafalgarandre/gists{/gist_id}","starred_url":"https://api.github.com/users/trafalgarandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trafalgarandre/subscriptions","organizations_url":"https://api.github.com/users/trafalgarandre/orgs","repos_url":"https://api.github.com/users/trafalgarandre/repos","events_url":"https://api.github.com/users/trafalgarandre/events{/privacy}","received_events_url":"https://api.github.com/users/trafalgarandre/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-06T15:58:06Z","updated_at":"2018-02-10T13:12:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8f8cbcd2a68796d4bd45eb729c1360b195eb40f5","assignee":{"login":"hwkchia","id":16570616,"avatar_url":"https://avatars2.githubusercontent.com/u/16570616?v=4","gravatar_id":"","url":"https://api.github.com/users/hwkchia","html_url":"https://github.com/hwkchia","followers_url":"https://api.github.com/users/hwkchia/followers","following_url":"https://api.github.com/users/hwkchia/following{/other_user}","gists_url":"https://api.github.com/users/hwkchia/gists{/gist_id}","starred_url":"https://api.github.com/users/hwkchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwkchia/subscriptions","organizations_url":"https://api.github.com/users/hwkchia/orgs","repos_url":"https://api.github.com/users/hwkchia/repos","events_url":"https://api.github.com/users/hwkchia/events{/privacy}","received_events_url":"https://api.github.com/users/hwkchia/received_events","type":"User","site_admin":false},"assignees":[{"login":"goweiwen","id":1926229,"avatar_url":"https://avatars3.githubusercontent.com/u/1926229?v=4","gravatar_id":"","url":"https://api.github.com/users/goweiwen","html_url":"https://github.com/goweiwen","followers_url":"https://api.github.com/users/goweiwen/followers","following_url":"https://api.github.com/users/goweiwen/following{/other_user}","gists_url":"https://api.github.com/users/goweiwen/gists{/gist_id}","starred_url":"https://api.github.com/users/goweiwen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goweiwen/subscriptions","organizations_url":"https://api.github.com/users/goweiwen/orgs","repos_url":"https://api.github.com/users/goweiwen/repos","events_url":"https://api.github.com/users/goweiwen/events{/privacy}","received_events_url":"https://api.github.com/users/goweiwen/received_events","type":"User","site_admin":false},{"login":"hwkchia","id":16570616,"avatar_url":"https://avatars2.githubusercontent.com/u/16570616?v=4","gravatar_id":"","url":"https://api.github.com/users/hwkchia","html_url":"https://github.com/hwkchia","followers_url":"https://api.github.com/users/hwkchia/followers","following_url":"https://api.github.com/users/hwkchia/following{/other_user}","gists_url":"https://api.github.com/users/hwkchia/gists{/gist_id}","starred_url":"https://api.github.com/users/hwkchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hwkchia/subscriptions","organizations_url":"https://api.github.com/users/hwkchia/orgs","repos_url":"https://api.github.com/users/hwkchia/repos","events_url":"https://api.github.com/users/hwkchia/events{/privacy}","received_events_url":"https://api.github.com/users/hwkchia/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":784873012,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/Reviewed","name":"Reviewed","color":"128A0C","default":false},{"id":784873039,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/team.A3","name":"team.A3","color":"ededed","default":false},{"id":784873267,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/tutorial.W09","name":"tutorial.W09","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/78/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/78/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/78/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/c9ee947b8612a5c4abe581d62a54eeb38213ca6f","head":{"label":"trafalgarandre:LO-ImplementClass","ref":"LO-ImplementClass","sha":"c9ee947b8612a5c4abe581d62a54eeb38213ca6f","user":{"login":"trafalgarandre","id":21093598,"avatar_url":"https://avatars1.githubusercontent.com/u/21093598?v=4","gravatar_id":"","url":"https://api.github.com/users/trafalgarandre","html_url":"https://github.com/trafalgarandre","followers_url":"https://api.github.com/users/trafalgarandre/followers","following_url":"https://api.github.com/users/trafalgarandre/following{/other_user}","gists_url":"https://api.github.com/users/trafalgarandre/gists{/gist_id}","starred_url":"https://api.github.com/users/trafalgarandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trafalgarandre/subscriptions","organizations_url":"https://api.github.com/users/trafalgarandre/orgs","repos_url":"https://api.github.com/users/trafalgarandre/repos","events_url":"https://api.github.com/users/trafalgarandre/events{/privacy}","received_events_url":"https://api.github.com/users/trafalgarandre/received_events","type":"User","site_admin":false},"repo":{"id":120391830,"name":"addressbook-level2","full_name":"trafalgarandre/addressbook-level2","owner":{"login":"trafalgarandre","id":21093598,"avatar_url":"https://avatars1.githubusercontent.com/u/21093598?v=4","gravatar_id":"","url":"https://api.github.com/users/trafalgarandre","html_url":"https://github.com/trafalgarandre","followers_url":"https://api.github.com/users/trafalgarandre/followers","following_url":"https://api.github.com/users/trafalgarandre/following{/other_user}","gists_url":"https://api.github.com/users/trafalgarandre/gists{/gist_id}","starred_url":"https://api.github.com/users/trafalgarandre/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trafalgarandre/subscriptions","organizations_url":"https://api.github.com/users/trafalgarandre/orgs","repos_url":"https://api.github.com/users/trafalgarandre/repos","events_url":"https://api.github.com/users/trafalgarandre/events{/privacy}","received_events_url":"https://api.github.com/users/trafalgarandre/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trafalgarandre/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/trafalgarandre/addressbook-level2","forks_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/forks","keys_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/events","assignees_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/merges","archive_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/trafalgarandre/addressbook-level2/deployments","created_at":"2018-02-06T02:41:07Z","updated_at":"2018-02-06T02:41:09Z","pushed_at":"2018-02-09T16:58:42Z","git_url":"git://github.com/trafalgarandre/addressbook-level2.git","ssh_url":"[email protected]:trafalgarandre/addressbook-level2.git","clone_url":"https://github.com/trafalgarandre/addressbook-level2.git","svn_url":"https://github.com/trafalgarandre/addressbook-level2","homepage":null,"size":3309,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1718S2:master","ref":"master","sha":"23644b1848abac9a973179ad015e20b7292394f5","user":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"repo":{"id":115011334,"name":"addressbook-level2","full_name":"nus-cs2103-AY1718S2/addressbook-level2","owner":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/deployments","created_at":"2017-12-21T13:56:37Z","updated_at":"2018-02-10T03:00:19Z","pushed_at":"2018-02-10T13:06:30Z","git_url":"git://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","ssh_url":"[email protected]:nus-cs2103-AY1718S2/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","homepage":null,"size":3419,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":214,"license":null,"forks":156,"open_issues":214,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/78"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/78"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/78"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/c9ee947b8612a5c4abe581d62a54eeb38213ca6f"}},"author_association":"NONE"}}

7226722347

{"actor":{"display_login":"trafalgarandre"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/168916980","pull_request_review_id":97369459,"id":168916980,"diff_hunk":"@@ -53,6 +53,10 @@ Examples:\n Shows a list of all persons in the address book.<br>\n Format: `list`\n \n+### Sorting all persons : `sort`\n+Shows a list of persons sorted lexicographically in the address book.<br>","path":"doc/UserGuide.md","position":5,"original_position":5,"commit_id":"68519e6a2cb15e24d7436c4c6b2ea00ee4a67cc3","original_commit_id":"68519e6a2cb15e24d7436c4c6b2ea00ee4a67cc3","user":{"login":"karrui","id":22133008,"avatar_url":"https://avatars3.githubusercontent.com/u/22133008?v=4","gravatar_id":"","url":"https://api.github.com/users/karrui","html_url":"https://github.com/karrui","followers_url":"https://api.github.com/users/karrui/followers","following_url":"https://api.github.com/users/karrui/following{/other_user}","gists_url":"https://api.github.com/users/karrui/gists{/gist_id}","starred_url":"https://api.github.com/users/karrui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karrui/subscriptions","organizations_url":"https://api.github.com/users/karrui/orgs","repos_url":"https://api.github.com/users/karrui/repos","events_url":"https://api.github.com/users/karrui/events{/privacy}","received_events_url":"https://api.github.com/users/karrui/received_events","type":"User","site_admin":false},"body":"Your sort command seems to save the sorted order (i.e. persistent sorting). Might be a good idea to tell the user that this command irreversibly sorts the list.","created_at":"2018-02-17T09:03:44Z","updated_at":"2018-02-17T09:05:22Z","html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/728#discussion_r168916980","pull_request_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/728","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments/168916980"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/728#discussion_r168916980"},"pull_request":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/728"}}},"pull_request":{"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/728","id":169578995,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/728","diff_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/728.diff","patch_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/728.patch","issue_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/728","number":728,"state":"open","locked":false,"title":"[W5.11][F11-A2] Zhang Yijiong","user":{"login":"ZhangYijiong","id":35628620,"avatar_url":"https://avatars3.githubusercontent.com/u/35628620?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYijiong","html_url":"https://github.com/ZhangYijiong","followers_url":"https://api.github.com/users/ZhangYijiong/followers","following_url":"https://api.github.com/users/ZhangYijiong/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYijiong/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYijiong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYijiong/subscriptions","organizations_url":"https://api.github.com/users/ZhangYijiong/orgs","repos_url":"https://api.github.com/users/ZhangYijiong/repos","events_url":"https://api.github.com/users/ZhangYijiong/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYijiong/received_events","type":"User","site_admin":false},"body":"Second enhancement, add sort command to display persons in lexicographic order ","created_at":"2018-02-16T09:31:37Z","updated_at":"2018-02-17T09:05:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78e2ef46fc2a1c3d444ac329b7f1bebb87458190","assignee":{"login":"karrui","id":22133008,"avatar_url":"https://avatars3.githubusercontent.com/u/22133008?v=4","gravatar_id":"","url":"https://api.github.com/users/karrui","html_url":"https://github.com/karrui","followers_url":"https://api.github.com/users/karrui/followers","following_url":"https://api.github.com/users/karrui/following{/other_user}","gists_url":"https://api.github.com/users/karrui/gists{/gist_id}","starred_url":"https://api.github.com/users/karrui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karrui/subscriptions","organizations_url":"https://api.github.com/users/karrui/orgs","repos_url":"https://api.github.com/users/karrui/repos","events_url":"https://api.github.com/users/karrui/events{/privacy}","received_events_url":"https://api.github.com/users/karrui/received_events","type":"User","site_admin":false},"assignees":[{"login":"okkhoy","id":1023494,"avatar_url":"https://avatars1.githubusercontent.com/u/1023494?v=4","gravatar_id":"","url":"https://api.github.com/users/okkhoy","html_url":"https://github.com/okkhoy","followers_url":"https://api.github.com/users/okkhoy/followers","following_url":"https://api.github.com/users/okkhoy/following{/other_user}","gists_url":"https://api.github.com/users/okkhoy/gists{/gist_id}","starred_url":"https://api.github.com/users/okkhoy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okkhoy/subscriptions","organizations_url":"https://api.github.com/users/okkhoy/orgs","repos_url":"https://api.github.com/users/okkhoy/repos","events_url":"https://api.github.com/users/okkhoy/events{/privacy}","received_events_url":"https://api.github.com/users/okkhoy/received_events","type":"User","site_admin":false},{"login":"karrui","id":22133008,"avatar_url":"https://avatars3.githubusercontent.com/u/22133008?v=4","gravatar_id":"","url":"https://api.github.com/users/karrui","html_url":"https://github.com/karrui","followers_url":"https://api.github.com/users/karrui/followers","following_url":"https://api.github.com/users/karrui/following{/other_user}","gists_url":"https://api.github.com/users/karrui/gists{/gist_id}","starred_url":"https://api.github.com/users/karrui/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karrui/subscriptions","organizations_url":"https://api.github.com/users/karrui/orgs","repos_url":"https://api.github.com/users/karrui/repos","events_url":"https://api.github.com/users/karrui/events{/privacy}","received_events_url":"https://api.github.com/users/karrui/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":784873038,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/team.A2","name":"team.A2","color":"ededed","default":false},{"id":784873128,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels/tutorial.F11","name":"tutorial.F11","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/728/commits","review_comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/728/comments","review_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/728/comments","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/68519e6a2cb15e24d7436c4c6b2ea00ee4a67cc3","head":{"label":"ZhangYijiong:W5.11b","ref":"W5.11b","sha":"68519e6a2cb15e24d7436c4c6b2ea00ee4a67cc3","user":{"login":"ZhangYijiong","id":35628620,"avatar_url":"https://avatars3.githubusercontent.com/u/35628620?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYijiong","html_url":"https://github.com/ZhangYijiong","followers_url":"https://api.github.com/users/ZhangYijiong/followers","following_url":"https://api.github.com/users/ZhangYijiong/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYijiong/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYijiong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYijiong/subscriptions","organizations_url":"https://api.github.com/users/ZhangYijiong/orgs","repos_url":"https://api.github.com/users/ZhangYijiong/repos","events_url":"https://api.github.com/users/ZhangYijiong/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYijiong/received_events","type":"User","site_admin":false},"repo":{"id":120610452,"name":"addressbook-level2","full_name":"ZhangYijiong/addressbook-level2","owner":{"login":"ZhangYijiong","id":35628620,"avatar_url":"https://avatars3.githubusercontent.com/u/35628620?v=4","gravatar_id":"","url":"https://api.github.com/users/ZhangYijiong","html_url":"https://github.com/ZhangYijiong","followers_url":"https://api.github.com/users/ZhangYijiong/followers","following_url":"https://api.github.com/users/ZhangYijiong/following{/other_user}","gists_url":"https://api.github.com/users/ZhangYijiong/gists{/gist_id}","starred_url":"https://api.github.com/users/ZhangYijiong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZhangYijiong/subscriptions","organizations_url":"https://api.github.com/users/ZhangYijiong/orgs","repos_url":"https://api.github.com/users/ZhangYijiong/repos","events_url":"https://api.github.com/users/ZhangYijiong/events{/privacy}","received_events_url":"https://api.github.com/users/ZhangYijiong/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ZhangYijiong/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2","forks_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/forks","keys_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/events","assignees_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/merges","archive_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/ZhangYijiong/addressbook-level2/deployments","created_at":"2018-02-07T12:09:53Z","updated_at":"2018-02-07T12:09:55Z","pushed_at":"2018-02-16T09:28:10Z","git_url":"git://github.com/ZhangYijiong/addressbook-level2.git","ssh_url":"[email protected]:ZhangYijiong/addressbook-level2.git","clone_url":"https://github.com/ZhangYijiong/addressbook-level2.git","svn_url":"https://github.com/ZhangYijiong/addressbook-level2","homepage":null,"size":3306,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nus-cs2103-AY1718S2:master","ref":"master","sha":"23644b1848abac9a973179ad015e20b7292394f5","user":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"repo":{"id":115011334,"name":"addressbook-level2","full_name":"nus-cs2103-AY1718S2/addressbook-level2","owner":{"login":"nus-cs2103-AY1718S2","id":34544003,"avatar_url":"https://avatars0.githubusercontent.com/u/34544003?v=4","gravatar_id":"","url":"https://api.github.com/users/nus-cs2103-AY1718S2","html_url":"https://github.com/nus-cs2103-AY1718S2","followers_url":"https://api.github.com/users/nus-cs2103-AY1718S2/followers","following_url":"https://api.github.com/users/nus-cs2103-AY1718S2/following{/other_user}","gists_url":"https://api.github.com/users/nus-cs2103-AY1718S2/gists{/gist_id}","starred_url":"https://api.github.com/users/nus-cs2103-AY1718S2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nus-cs2103-AY1718S2/subscriptions","organizations_url":"https://api.github.com/users/nus-cs2103-AY1718S2/orgs","repos_url":"https://api.github.com/users/nus-cs2103-AY1718S2/repos","events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/events{/privacy}","received_events_url":"https://api.github.com/users/nus-cs2103-AY1718S2/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","description":"A Java sample application for students. An AddressBook application that uses OOP basics.","fork":true,"url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2","forks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/forks","keys_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/teams","hooks_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/hooks","issue_events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/events{/number}","events_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/events","assignees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/assignees{/user}","branches_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/branches{/branch}","tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/tags","blobs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/refs{/sha}","trees_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/{sha}","languages_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/languages","stargazers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/stargazers","contributors_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contributors","subscribers_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscribers","subscription_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/subscription","commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/commits{/sha}","git_commits_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/git/commits{/sha}","comments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/comments{/number}","issue_comment_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/comments{/number}","contents_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/contents/{+path}","compare_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/merges","archive_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/downloads","issues_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues{/number}","pulls_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls{/number}","milestones_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/milestones{/number}","notifications_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/labels{/name}","releases_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/releases{/id}","deployments_url":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/deployments","created_at":"2017-12-21T13:56:37Z","updated_at":"2018-02-10T03:00:19Z","pushed_at":"2018-02-17T08:55:14Z","git_url":"git://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","ssh_url":"[email protected]:nus-cs2103-AY1718S2/addressbook-level2.git","clone_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2.git","svn_url":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2","homepage":null,"size":3419,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":187,"mirror_url":null,"archived":false,"open_issues_count":551,"license":null,"forks":187,"open_issues":551,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/728"},"html":{"href":"https://github.com/nus-cs2103-AY1718S2/addressbook-level2/pull/728"},"issue":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/728"},"comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/issues/728/comments"},"review_comments":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/728/comments"},"review_comment":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/pulls/728/commits"},"statuses":{"href":"https://api.github.com/repos/nus-cs2103-AY1718S2/addressbook-level2/statuses/68519e6a2cb15e24d7436c4c6b2ea00ee4a67cc3"}},"author_association":"NONE"}}

7258544884

{"actor":{"display_login":"karrui"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/jenkins-x/jx/pulls/comments/234703314","pull_request_review_id":176401549,"id":234703314,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDcwMzMxNA==","diff_hunk":"@@ -0,0 +1,254 @@\n+package cmd\n+\n+import (\n+\t\"fmt\"\n+\t\"io\"\n+\t\"strings\"\n+\n+\t\"github.com/jenkins-x/jx/pkg/gits\"\n+\t\"github.com/jenkins-x/jx/pkg/helm\"\n+\t\"github.com/jenkins-x/jx/pkg/util\"\n+\n+\t\"github.com/jenkins-x/jx/pkg/apis/jenkins.io/v1\"\n+\n+\t\"github.com/jenkins-x/jx/pkg/log\"\n+\n+\t\"github.com/jenkins-x/jx/pkg/kube\"\n+\t\"github.com/pkg/errors\"\n+\t\"github.com/spf13/cobra\"\n+\t\"gopkg.in/AlecAivazis/survey.v1/terminal\"\n+\tmeta_v1 \"k8s.io/apimachinery/pkg/apis/meta/v1\"\n+)\n+\n+// AddAppOptions the options for the create spring command\n+type AddAppOptions struct {\n+\tAddOptions\n+\n+\tGitOps bool\n+\tDevEnv *v1.Environment\n+\n+\tRepo string\n+\tUsername string\n+\tPassword string\n+\tAlias string\n+\n+\t// for testing\n+\tFakePullRequests CreateEnvPullRequestFn\n+\n+\t// allow git to be configured externally before a PR is created\n+\tConfigureGitCallback ConfigureGitFolderFn\n+\n+\t// TODO Remove OLD\n+\tNamespace string\n+\tVersion string\n+\tReleaseName string\n+\tSetValues string\n+\tValueFiles []string\n+\tHelmUpdate bool\n+}\n+\n+// NewCmdAddApp creates a command object for the \"create\" command\n+func NewCmdAddApp(f Factory, in terminal.FileReader, out terminal.FileWriter, errOut io.Writer) *cobra.Command {\n+\toptions := &AddAppOptions{\n+\t\tAddOptions: AddOptions{\n+\t\t\tCommonOptions: CommonOptions{\n+\t\t\t\tFactory: f,\n+\t\t\t\tIn: in,\n+\t\t\t\tOut: out,\n+\t\t\t\tErr: errOut,\n+\t\t\t},\n+\t\t},\n+\t}\n+\n+\tcmd := &cobra.Command{\n+\t\tUse: \"app\",\n+\t\tShort: \"Adds an app\",\n+\t\tRun: func(cmd *cobra.Command, args []string) {\n+\t\t\toptions.Cmd = cmd\n+\t\t\toptions.Args = args\n+\t\t\terr := options.Run()\n+\t\t\tCheckErr(err)\n+\t\t},\n+\t}\n+\n+\toptions.addFlags(cmd, kube.DefaultNamespace, \"\", \"\")\n+\treturn cmd\n+}\n+\n+func (options *AddAppOptions) addFlags(cmd *cobra.Command, defaultNamespace string, defaultOptionRelease string, defaultVersion string) {\n+\n+\t// We're going to need to know whether the team is using GitOps for the dev env or not,\n+\t// and also access the team settings, so load those\n+\tjxClient, ns, err := options.JXClientAndDevNamespace()\n+\tif err != nil {\n+\t\tif options.Verbose {\n+\t\t\tlog.Errorf(\"Error loading team settings. %v\\n\", err)\n+\t\t}\n+\t\toptions.GitOps = false\n+\t\toptions.DevEnv = &v1.Environment{}\n+\t} else {\n+\t\tdevEnv, err := kube.GetDevEnvironment(jxClient, ns)\n+\t\tif err != nil {\n+\t\t\tlog.Errorf(\"Error loading team settings. %v\\n\", err)\n+\t\t\toptions.GitOps = false\n+\t\t\toptions.DevEnv = &v1.Environment{}\n+\t\t} else {\n+\t\t\toptions.DevEnv = devEnv\n+\t\t\tif options.DevEnv.Spec.Source.URL != \"\" {\n+\t\t\t\toptions.GitOps = true\n+\t\t\t}\n+\t\t}\n+\t}\n+\n+\t// Common flags\n+\tcmd.Flags().StringVarP(&options.SetValues, \"set\", \"s\", \"\",\n+\t\t\"The chart set values (can specify multiple or separate values with commas: key1=val1,key2=val2)\")\n+\tcmd.Flags().StringVarP(&options.Version, \"version\", \"v\", defaultVersion,\n+\t\t\"The chart version to install\")\n+\tcmd.Flags().StringVarP(&options.Repo, \"repository\", \"\", options.DevEnv.Spec.TeamSettings.AppsRepository,\n+\t\t\"The repository from which the chart should be installed\")\n+\tcmd.Flags().StringVarP(&options.Version, \"username\", \"\", \"\",\n+\t\t\"The username for the chart repository\")\n+\tcmd.Flags().StringVarP(&options.Version, \"password\", \"\", \"\",\n+\t\t\"The password for the chart repository\")\n+\tcmd.Flags().BoolVarP(&options.BatchMode, optionBatchMode, \"b\", false, \"In batch mode the command never prompts for user input\")\n+\tcmd.Flags().BoolVarP(&options.Verbose, optionVerbose, \"\", false, \"Enable verbose logging\")\n+\tif options.GitOps {\n+\t\t// GitOps specific flags go here\n+\t\tcmd.Flags().StringVarP(&options.Alias, \"alias\", \"\", \"\", \"An alias to use for the app\")\n+\t} else {\n+\t\t// Non GitOps specific flags go here\n+\t\tcmd.Flags().StringVarP(&options.ReleaseName, optionRelease, \"r\", defaultOptionRelease, \"The chart release name\")\n+\t\tcmd.Flags().BoolVarP(&options.HelmUpdate, \"helm-update\", \"\", true, \"Should we run helm update first to ensure we use the latest version\")\n+\t\tcmd.Flags().StringVarP(&options.Namespace, \"namespace\", \"n\", defaultNamespace, \"The Namespace to install into\")\n+\t\tcmd.Flags().StringArrayVarP(&options.ValueFiles, \"values\", \"f\", []string{}, \"List of locations for values files, can be local files or URLs\")\n+\t}\n+\n+}\n+\n+// Run implements this command\n+func (o *AddAppOptions) Run() error {\n+\targs := o.Args\n+\tif len(args) == 0 {\n+\t\treturn o.Cmd.Help()\n+\t}\n+\tif len(args) > 1 {\n+\t\treturn o.Cmd.Help()\n+\t}\n+\tfor _, arg := range args {\n+\t\tif o.GitOps {\n+\t\t\terr := o.CreatePR(arg)\n+\t\t\tif err != nil {\n+\t\t\t\treturn err\n+\t\t\t}\n+\t\t} else {\n+\t\t\terr := o.InstallApp(arg)\n+\t\t\tif err != nil {\n+\t\t\t\treturn err\n+\t\t\t}\n+\t\t}\n+\n+\t}\n+\treturn nil\n+}\n+\n+func (o *AddAppOptions) CreatePR(app string) error {\n+\tversion := o.Version\n+\tif version == \"\" {\n+\t\tvar err error\n+\t\tversion, err = helm.GetLatestVersion(app, o.Repo, o.Helm())\n+\t\tif err != nil {\n+\t\t\treturn err\n+\t\t}\n+\t\tif o.Verbose {\n+\t\t\tlog.Infof(\"No version specified so using latest version which is %s\\n\", util.ColorInfo(version))\n+\t\t}\n+\t}\n+\tmodifyRequirementsFn := func(requirements *helm.Requirements) error {\n+\t\t// See if the app already exists in requirements\n+\t\tfound := false\n+\t\tfor _, d := range requirements.Dependencies {\n+\t\t\tif d.Name == app && d.Repository == o.Repo && d.Alias == o.Alias {\n+\t\t\t\t// App found\n+\t\t\t\tlog.Infof(\"App %s already installed.\\n\", util.ColorWarning(app))\n+\t\t\t\tif version != d.Version {\n+\t\t\t\t\tlog.Infof(\"To upgrade the app use %s or %s\\n\",\n+\t\t\t\t\t\tutil.ColorInfo(\"jx upgrade app <app>\"),\n+\t\t\t\t\t\tutil.ColorInfo(\"jx upgrade apps --all\"))\n+\t\t\t\t}\n+\t\t\t\tfound = true\n+\t\t\t\tbreak\n+\t\t\t}\n+\t\t}\n+\t\t// If app not found, add it\n+\t\tif !found {\n+\t\t\trequirements.Dependencies = append(requirements.Dependencies, &helm.Dependency{\n+\t\t\t\tAlias: o.Alias,\n+\t\t\t\tRepository: o.Repo,\n+\t\t\t\tName: app,\n+\t\t\t\tVersion: version,\n+\t\t\t})\n+\t\t}\n+\t\treturn nil\n+\t}\n+\tbranchNameText := \"add-app-\" + app + \"-\" + version\n+\ttitle := fmt.Sprintf(\"Add %s %s\", app, version)\n+\tmessage := fmt.Sprintf(\"Add app %s %s\", app, version)\n+\tvar pullRequestInfo *gits.PullRequestInfo\n+\tif o.FakePullRequests != nil {\n+\t\tvar err error\n+\t\tpullRequestInfo, err = o.FakePullRequests(o.DevEnv, modifyRequirementsFn, branchNameText, title, message,\n+\t\t\tnil)\n+\t\treturn err\n+\t} else {\n+\t\tvar err error\n+\t\tpullRequestInfo, err = o.createEnvironmentPullRequest(o.DevEnv, modifyRequirementsFn, branchNameText, title,\n+\t\t\tmessage,\n+\t\t\tnil, o.ConfigureGitCallback)\n+\t\treturn err\n+\t}\n+\tlog.Infof(\"Added app via Pull Request %s\\n\", pullRequestInfo.PullRequest.URL)\n+\treturn nil\n+}\n+\n+func (o *AddAppOptions) InstallApp(app string) error {\n+\terr := o.ensureHelm()\n+\tif err != nil {\n+\t\treturn errors.Wrap(err, \"failed to ensure that helm is present\")\n+\t}\n+\tsetValues := strings.Split(o.SetValues, \",\")\n+\n+\terr = o.installChart(app, app, o.Version, o.Namespace, o.HelmUpdate, setValues, o.ValueFiles, o.Repo)\n+\tif err != nil {\n+\t\treturn fmt.Errorf(\"failed to install app %s: %v\", app, err)\n+\t}\n+\treturn o.ExposeApp(app)\n+}\n+\n+// TODO Patch this up to use app CRD","path":"pkg/jx/cmd/add_app.go","position":228,"original_position":228,"commit_id":"663e6b13a01414c743cef1ad588dcc5a1d74e6b8","original_commit_id":"663e6b13a01414c743cef1ad588dcc5a1d74e6b8","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"comment on exported method AddAppOptions.ExposeApp should be of the form \"ExposeApp ...\"","created_at":"2018-11-19T17:05:13Z","updated_at":"2018-11-19T17:05:15Z","html_url":"https://github.com/jenkins-x/jx/pull/2283#discussion_r234703314","pull_request_url":"https://api.github.com/repos/jenkins-x/jx/pulls/2283","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/comments/234703314"},"html":{"href":"https://github.com/jenkins-x/jx/pull/2283#discussion_r234703314"},"pull_request":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/2283"}}},"pull_request":{"url":"https://api.github.com/repos/jenkins-x/jx/pulls/2283","id":232047503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMDQ3NTAz","html_url":"https://github.com/jenkins-x/jx/pull/2283","diff_url":"https://github.com/jenkins-x/jx/pull/2283.diff","patch_url":"https://github.com/jenkins-x/jx/pull/2283.patch","issue_url":"https://api.github.com/repos/jenkins-x/jx/issues/2283","number":2283,"state":"open","locked":false,"title":"feat: `jx add app`","user":{"login":"pmuir","id":157761,"node_id":"MDQ6VXNlcjE1Nzc2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/157761?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuir","html_url":"https://github.com/pmuir","followers_url":"https://api.github.com/users/pmuir/followers","following_url":"https://api.github.com/users/pmuir/following{/other_user}","gists_url":"https://api.github.com/users/pmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuir/subscriptions","organizations_url":"https://api.github.com/users/pmuir/orgs","repos_url":"https://api.github.com/users/pmuir/repos","events_url":"https://api.github.com/users/pmuir/events{/privacy}","received_events_url":"https://api.github.com/users/pmuir/received_events","type":"User","site_admin":false},"body":"\r\n\r\n<!-- Thanks for sending a pull request! Here are some tips for you:\r\n1. If this is your first PR, read our contributor guidelines https://jenkins-x.io/contribute/\r\n2. Follow these instructions to write commit messages http://karma-runner.github.io/3.0/dev/git-commit-msg.html\r\n3. Follow these instructions to write tests https://jenkins-x.io/contribute/development/#testing\r\n4. You can trigger the tests for your PR with /test bdd\r\n5. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n6. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n#### Submitter checklist\r\n\r\n- [X] Change is code complete and matches issue description.\r\n- [X] Change is covered by existing or new tests.\r\n\r\n#### Description\r\n* Provides both traditional and gitops modes\r\n* Backwards compatible with `jx create add-on`\r\n\r\n#### Special notes for the reviewer(s)\r\n\r\n\r\n#### Which issue this PR fixes\r\n\r\nfixes #\r\n\r\n<!--\r\noptional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged\r\n-->\r\n","created_at":"2018-11-19T17:04:40Z","updated_at":"2018-11-19T17:05:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"wbrefvem","id":5361033,"node_id":"MDQ6VXNlcjUzNjEwMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/5361033?v=4","gravatar_id":"","url":"https://api.github.com/users/wbrefvem","html_url":"https://github.com/wbrefvem","followers_url":"https://api.github.com/users/wbrefvem/followers","following_url":"https://api.github.com/users/wbrefvem/following{/other_user}","gists_url":"https://api.github.com/users/wbrefvem/gists{/gist_id}","starred_url":"https://api.github.com/users/wbrefvem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wbrefvem/subscriptions","organizations_url":"https://api.github.com/users/wbrefvem/orgs","repos_url":"https://api.github.com/users/wbrefvem/repos","events_url":"https://api.github.com/users/wbrefvem/events{/privacy}","received_events_url":"https://api.github.com/users/wbrefvem/received_events","type":"User","site_admin":false},{"login":"markawm","id":42846990,"node_id":"MDQ6VXNlcjQyODQ2OTkw","avatar_url":"https://avatars2.githubusercontent.com/u/42846990?v=4","gravatar_id":"","url":"https://api.github.com/users/markawm","html_url":"https://github.com/markawm","followers_url":"https://api.github.com/users/markawm/followers","following_url":"https://api.github.com/users/markawm/following{/other_user}","gists_url":"https://api.github.com/users/markawm/gists{/gist_id}","starred_url":"https://api.github.com/users/markawm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markawm/subscriptions","organizations_url":"https://api.github.com/users/markawm/orgs","repos_url":"https://api.github.com/users/markawm/repos","events_url":"https://api.github.com/users/markawm/events{/privacy}","received_events_url":"https://api.github.com/users/markawm/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1012655166,"node_id":"MDU6TGFiZWwxMDEyNjU1MTY2","url":"https://api.github.com/repos/jenkins-x/jx/labels/size/XXL","name":"size/XXL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jenkins-x/jx/pulls/2283/commits","review_comments_url":"https://api.github.com/repos/jenkins-x/jx/pulls/2283/comments","review_comment_url":"https://api.github.com/repos/jenkins-x/jx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jenkins-x/jx/issues/2283/comments","statuses_url":"https://api.github.com/repos/jenkins-x/jx/statuses/663e6b13a01414c743cef1ad588dcc5a1d74e6b8","head":{"label":"pmuir:gitsops4apps","ref":"gitsops4apps","sha":"663e6b13a01414c743cef1ad588dcc5a1d74e6b8","user":{"login":"pmuir","id":157761,"node_id":"MDQ6VXNlcjE1Nzc2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/157761?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuir","html_url":"https://github.com/pmuir","followers_url":"https://api.github.com/users/pmuir/followers","following_url":"https://api.github.com/users/pmuir/following{/other_user}","gists_url":"https://api.github.com/users/pmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuir/subscriptions","organizations_url":"https://api.github.com/users/pmuir/orgs","repos_url":"https://api.github.com/users/pmuir/repos","events_url":"https://api.github.com/users/pmuir/events{/privacy}","received_events_url":"https://api.github.com/users/pmuir/received_events","type":"User","site_admin":false},"repo":{"id":148289125,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyODkxMjU=","name":"jx","full_name":"pmuir/jx","private":false,"owner":{"login":"pmuir","id":157761,"node_id":"MDQ6VXNlcjE1Nzc2MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/157761?v=4","gravatar_id":"","url":"https://api.github.com/users/pmuir","html_url":"https://github.com/pmuir","followers_url":"https://api.github.com/users/pmuir/followers","following_url":"https://api.github.com/users/pmuir/following{/other_user}","gists_url":"https://api.github.com/users/pmuir/gists{/gist_id}","starred_url":"https://api.github.com/users/pmuir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmuir/subscriptions","organizations_url":"https://api.github.com/users/pmuir/orgs","repos_url":"https://api.github.com/users/pmuir/repos","events_url":"https://api.github.com/users/pmuir/events{/privacy}","received_events_url":"https://api.github.com/users/pmuir/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pmuir/jx","description":"jx is a command line tool for working with Jenkins X: automated CI/CD for Kubernetes","fork":true,"url":"https://api.github.com/repos/pmuir/jx","forks_url":"https://api.github.com/repos/pmuir/jx/forks","keys_url":"https://api.github.com/repos/pmuir/jx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmuir/jx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmuir/jx/teams","hooks_url":"https://api.github.com/repos/pmuir/jx/hooks","issue_events_url":"https://api.github.com/repos/pmuir/jx/issues/events{/number}","events_url":"https://api.github.com/repos/pmuir/jx/events","assignees_url":"https://api.github.com/repos/pmuir/jx/assignees{/user}","branches_url":"https://api.github.com/repos/pmuir/jx/branches{/branch}","tags_url":"https://api.github.com/repos/pmuir/jx/tags","blobs_url":"https://api.github.com/repos/pmuir/jx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmuir/jx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmuir/jx/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmuir/jx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmuir/jx/statuses/{sha}","languages_url":"https://api.github.com/repos/pmuir/jx/languages","stargazers_url":"https://api.github.com/repos/pmuir/jx/stargazers","contributors_url":"https://api.github.com/repos/pmuir/jx/contributors","subscribers_url":"https://api.github.com/repos/pmuir/jx/subscribers","subscription_url":"https://api.github.com/repos/pmuir/jx/subscription","commits_url":"https://api.github.com/repos/pmuir/jx/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmuir/jx/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmuir/jx/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmuir/jx/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmuir/jx/contents/{+path}","compare_url":"https://api.github.com/repos/pmuir/jx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmuir/jx/merges","archive_url":"https://api.github.com/repos/pmuir/jx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmuir/jx/downloads","issues_url":"https://api.github.com/repos/pmuir/jx/issues{/number}","pulls_url":"https://api.github.com/repos/pmuir/jx/pulls{/number}","milestones_url":"https://api.github.com/repos/pmuir/jx/milestones{/number}","notifications_url":"https://api.github.com/repos/pmuir/jx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmuir/jx/labels{/name}","releases_url":"https://api.github.com/repos/pmuir/jx/releases{/id}","deployments_url":"https://api.github.com/repos/pmuir/jx/deployments","created_at":"2018-09-11T08:57:37Z","updated_at":"2018-09-11T08:57:41Z","pushed_at":"2018-11-19T17:04:20Z","git_url":"git://github.com/pmuir/jx.git","ssh_url":"[email protected]:pmuir/jx.git","clone_url":"https://github.com/pmuir/jx.git","svn_url":"https://github.com/pmuir/jx","homepage":"https://jenkins-x.io/","size":41151,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jenkins-x:master","ref":"master","sha":"530ff60087824fcdf1f9e551a926437d7e87699c","user":{"login":"jenkins-x","id":34566050,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTY2MDUw","avatar_url":"https://avatars0.githubusercontent.com/u/34566050?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-x","html_url":"https://github.com/jenkins-x","followers_url":"https://api.github.com/users/jenkins-x/followers","following_url":"https://api.github.com/users/jenkins-x/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-x/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-x/subscriptions","organizations_url":"https://api.github.com/users/jenkins-x/orgs","repos_url":"https://api.github.com/users/jenkins-x/repos","events_url":"https://api.github.com/users/jenkins-x/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-x/received_events","type":"Organization","site_admin":false},"repo":{"id":116400734,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY0MDA3MzQ=","name":"jx","full_name":"jenkins-x/jx","private":false,"owner":{"login":"jenkins-x","id":34566050,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NTY2MDUw","avatar_url":"https://avatars0.githubusercontent.com/u/34566050?v=4","gravatar_id":"","url":"https://api.github.com/users/jenkins-x","html_url":"https://github.com/jenkins-x","followers_url":"https://api.github.com/users/jenkins-x/followers","following_url":"https://api.github.com/users/jenkins-x/following{/other_user}","gists_url":"https://api.github.com/users/jenkins-x/gists{/gist_id}","starred_url":"https://api.github.com/users/jenkins-x/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jenkins-x/subscriptions","organizations_url":"https://api.github.com/users/jenkins-x/orgs","repos_url":"https://api.github.com/users/jenkins-x/repos","events_url":"https://api.github.com/users/jenkins-x/events{/privacy}","received_events_url":"https://api.github.com/users/jenkins-x/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jenkins-x/jx","description":"Jenkins X provides automated CI+CD for Kubernetes with Preview Environments on Pull Requests using Jenkins, Knative Build, Prow, Skaffold and Helm","fork":false,"url":"https://api.github.com/repos/jenkins-x/jx","forks_url":"https://api.github.com/repos/jenkins-x/jx/forks","keys_url":"https://api.github.com/repos/jenkins-x/jx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jenkins-x/jx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jenkins-x/jx/teams","hooks_url":"https://api.github.com/repos/jenkins-x/jx/hooks","issue_events_url":"https://api.github.com/repos/jenkins-x/jx/issues/events{/number}","events_url":"https://api.github.com/repos/jenkins-x/jx/events","assignees_url":"https://api.github.com/repos/jenkins-x/jx/assignees{/user}","branches_url":"https://api.github.com/repos/jenkins-x/jx/branches{/branch}","tags_url":"https://api.github.com/repos/jenkins-x/jx/tags","blobs_url":"https://api.github.com/repos/jenkins-x/jx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jenkins-x/jx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jenkins-x/jx/git/refs{/sha}","trees_url":"https://api.github.com/repos/jenkins-x/jx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jenkins-x/jx/statuses/{sha}","languages_url":"https://api.github.com/repos/jenkins-x/jx/languages","stargazers_url":"https://api.github.com/repos/jenkins-x/jx/stargazers","contributors_url":"https://api.github.com/repos/jenkins-x/jx/contributors","subscribers_url":"https://api.github.com/repos/jenkins-x/jx/subscribers","subscription_url":"https://api.github.com/repos/jenkins-x/jx/subscription","commits_url":"https://api.github.com/repos/jenkins-x/jx/commits{/sha}","git_commits_url":"https://api.github.com/repos/jenkins-x/jx/git/commits{/sha}","comments_url":"https://api.github.com/repos/jenkins-x/jx/comments{/number}","issue_comment_url":"https://api.github.com/repos/jenkins-x/jx/issues/comments{/number}","contents_url":"https://api.github.com/repos/jenkins-x/jx/contents/{+path}","compare_url":"https://api.github.com/repos/jenkins-x/jx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jenkins-x/jx/merges","archive_url":"https://api.github.com/repos/jenkins-x/jx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jenkins-x/jx/downloads","issues_url":"https://api.github.com/repos/jenkins-x/jx/issues{/number}","pulls_url":"https://api.github.com/repos/jenkins-x/jx/pulls{/number}","milestones_url":"https://api.github.com/repos/jenkins-x/jx/milestones{/number}","notifications_url":"https://api.github.com/repos/jenkins-x/jx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jenkins-x/jx/labels{/name}","releases_url":"https://api.github.com/repos/jenkins-x/jx/releases{/id}","deployments_url":"https://api.github.com/repos/jenkins-x/jx/deployments","created_at":"2018-01-05T15:46:09Z","updated_at":"2018-11-19T15:28:52Z","pushed_at":"2018-11-19T17:04:41Z","git_url":"git://github.com/jenkins-x/jx.git","ssh_url":"[email protected]:jenkins-x/jx.git","clone_url":"https://github.com/jenkins-x/jx.git","svn_url":"https://github.com/jenkins-x/jx","homepage":"https://jenkins-x.io/","size":41240,"stargazers_count":1732,"watchers_count":1732,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":289,"mirror_url":null,"archived":false,"open_issues_count":465,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":289,"open_issues":465,"watchers":1732,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/2283"},"html":{"href":"https://github.com/jenkins-x/jx/pull/2283"},"issue":{"href":"https://api.github.com/repos/jenkins-x/jx/issues/2283"},"comments":{"href":"https://api.github.com/repos/jenkins-x/jx/issues/2283/comments"},"review_comments":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/2283/comments"},"review_comment":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jenkins-x/jx/pulls/2283/commits"},"statuses":{"href":"https://api.github.com/repos/jenkins-x/jx/statuses/663e6b13a01414c743cef1ad588dcc5a1d74e6b8"}},"author_association":"MEMBER"}}

8614293960

{"actor":{"display_login":"houndci-bot"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/comments/171765890","pull_request_review_id":100677312,"id":171765890,"diff_hunk":"@@ -60,18 +76,63 @@ public boolean isTransactional() {\n return false;\n }\n \n- @Override public void onClose() {\n-\n+ @Override\n+ public void onClose() {\n }\n \n @Override\n- public void start(Xid xid, boolean join, boolean resume) {\n-\n+ public void start(Xid xid, int sessionId, boolean join, boolean resume) throws ValidationException {\n+ if (join && resume) {\n+ throw new ValidationException(\"Cannot start a branch with both join and resume set \" + xid);\n+ }\n+\n+ Branch branch = transactionRegistry.getBranch(xid);","path":"modules/broker-core/src/main/java/io/ballerina/messaging/broker/core/transaction/DistributedTransaction.java","position":58,"original_position":48,"commit_id":"bfaee19d980b46b1f25740a0deb64e8075ea0aa3","original_commit_id":"0c15f81ce128b933fee1044853f10f5764b5cf7f","user":{"login":"erandacr","id":4003109,"avatar_url":"https://avatars3.githubusercontent.com/u/4003109?v=4","gravatar_id":"","url":"https://api.github.com/users/erandacr","html_url":"https://github.com/erandacr","followers_url":"https://api.github.com/users/erandacr/followers","following_url":"https://api.github.com/users/erandacr/following{/other_user}","gists_url":"https://api.github.com/users/erandacr/gists{/gist_id}","starred_url":"https://api.github.com/users/erandacr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erandacr/subscriptions","organizations_url":"https://api.github.com/users/erandacr/orgs","repos_url":"https://api.github.com/users/erandacr/repos","events_url":"https://api.github.com/users/erandacr/events{/privacy}","received_events_url":"https://api.github.com/users/erandacr/received_events","type":"User","site_admin":false},"body":"+1","created_at":"2018-03-02T05:07:40Z","updated_at":"2018-03-02T05:07:40Z","html_url":"https://github.com/ballerina-platform/ballerina-message-broker/pull/321#discussion_r171765890","pull_request_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/321","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/comments/171765890"},"html":{"href":"https://github.com/ballerina-platform/ballerina-message-broker/pull/321#discussion_r171765890"},"pull_request":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/321"}},"in_reply_to_id":171585972},"pull_request":{"url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/321","id":171861790,"html_url":"https://github.com/ballerina-platform/ballerina-message-broker/pull/321","diff_url":"https://github.com/ballerina-platform/ballerina-message-broker/pull/321.diff","patch_url":"https://github.com/ballerina-platform/ballerina-message-broker/pull/321.patch","issue_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/issues/321","number":321,"state":"open","locked":false,"title":"Implement Dtx start and end functionality in broker core","user":{"login":"Asitha","id":919462,"avatar_url":"https://avatars3.githubusercontent.com/u/919462?v=4","gravatar_id":"","url":"https://api.github.com/users/Asitha","html_url":"https://github.com/Asitha","followers_url":"https://api.github.com/users/Asitha/followers","following_url":"https://api.github.com/users/Asitha/following{/other_user}","gists_url":"https://api.github.com/users/Asitha/gists{/gist_id}","starred_url":"https://api.github.com/users/Asitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asitha/subscriptions","organizations_url":"https://api.github.com/users/Asitha/orgs","repos_url":"https://api.github.com/users/Asitha/repos","events_url":"https://api.github.com/users/Asitha/events{/privacy}","received_events_url":"https://api.github.com/users/Asitha/received_events","type":"User","site_admin":false},"body":"## Purpose\r\n> Describe the problems, issues, or needs driving this feature/fix and include links to related issues in the following format: Resolves issue1, issue2, etc.\r\n\r\nHandle dtx start and end frames from broker core.\r\n\r\n## Goals\r\n> Describe the solutions that this feature/fix will introduce to resolve the problems described above\r\n\r\nThis will enable a user to start and end a XAResource\r\n## Approach\r\n> Describe how you are implementing the solutions. Include an animated GIF or screenshot if the change affects the UI (email [email protected] to review all UI text). Include a link to a Markdown file or Google doc if the feature write-up is too long to paste here.\r\n\r\nHandle the distributed transaction events through a DistributedTransaction object retrieved from the broker core. This objects internally handles working with transaction Branch and the transaction Registry \r\n\r\n## User stories\r\n> Summary of user stories addressed by this change>\r\n\r\n## Release note\r\n> Brief description of the new feature or bug fix as it will appear in the release notes\r\n\r\n## Documentation\r\n> Link(s) to product documentation that addresses the changes of this PR. If no doc impact, enter “N/A” plus brief explanation of why there’s no doc impact\r\n\r\n## Training\r\n> Link to the PR for changes to the training content in https://github.com/wso2/WSO2-Training, if applicable\r\n\r\n## Certification\r\n> Type “Sent” when you have provided new/updated certification questions, plus four answers for each question (correct answer highlighted in bold), based on this change. Certification questions/answers should be sent to [email protected] and NOT pasted in this PR. If there is no impact on certification exams, type “N/A” and explain why.\r\n\r\n## Marketing\r\n> Link to drafts of marketing content that will describe and promote this feature, including product page changes, technical articles, blog posts, videos, etc., if applicable\r\n\r\n## Automation tests\r\n - Unit tests \r\n > Code coverage information\r\n - Integration tests\r\n > Details about the test cases and coverage\r\n\r\nunit test added\r\n## Security checks\r\n - Followed secure coding standards in http://wso2.com/technical-reports/wso2-secure-engineering-guidelines? yes/no\r\n - Ran FindSecurityBugs plugin and verified report? yes/no\r\n - Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets? yes/no\r\n\r\n## Samples\r\n> Provide high-level details about the samples related to this feature\r\n\r\n## Related PRs\r\n> List any other related PRs\r\n\r\n## Migrations (if applicable)\r\n> Describe migration steps and platforms on which migration has been tested\r\n\r\n## Test environment\r\n> List all JDK versions, operating systems, databases, and browser/versions on which this feature/fix was tested\r\n \r\n## Learning\r\n> Describe the research phase and any blog posts, patterns, libraries, or add-ons you used to solve the problem.","created_at":"2018-02-28T05:47:44Z","updated_at":"2018-03-02T05:07:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1c5f60a73ef155e599ff226ddf196e787780bcd","assignee":{"login":"Asitha","id":919462,"avatar_url":"https://avatars3.githubusercontent.com/u/919462?v=4","gravatar_id":"","url":"https://api.github.com/users/Asitha","html_url":"https://github.com/Asitha","followers_url":"https://api.github.com/users/Asitha/followers","following_url":"https://api.github.com/users/Asitha/following{/other_user}","gists_url":"https://api.github.com/users/Asitha/gists{/gist_id}","starred_url":"https://api.github.com/users/Asitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asitha/subscriptions","organizations_url":"https://api.github.com/users/Asitha/orgs","repos_url":"https://api.github.com/users/Asitha/repos","events_url":"https://api.github.com/users/Asitha/events{/privacy}","received_events_url":"https://api.github.com/users/Asitha/received_events","type":"User","site_admin":false},"assignees":[{"login":"Asitha","id":919462,"avatar_url":"https://avatars3.githubusercontent.com/u/919462?v=4","gravatar_id":"","url":"https://api.github.com/users/Asitha","html_url":"https://github.com/Asitha","followers_url":"https://api.github.com/users/Asitha/followers","following_url":"https://api.github.com/users/Asitha/following{/other_user}","gists_url":"https://api.github.com/users/Asitha/gists{/gist_id}","starred_url":"https://api.github.com/users/Asitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asitha/subscriptions","organizations_url":"https://api.github.com/users/Asitha/orgs","repos_url":"https://api.github.com/users/Asitha/repos","events_url":"https://api.github.com/users/Asitha/events{/privacy}","received_events_url":"https://api.github.com/users/Asitha/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"a5anka","id":1148405,"avatar_url":"https://avatars3.githubusercontent.com/u/1148405?v=4","gravatar_id":"","url":"https://api.github.com/users/a5anka","html_url":"https://github.com/a5anka","followers_url":"https://api.github.com/users/a5anka/followers","following_url":"https://api.github.com/users/a5anka/following{/other_user}","gists_url":"https://api.github.com/users/a5anka/gists{/gist_id}","starred_url":"https://api.github.com/users/a5anka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a5anka/subscriptions","organizations_url":"https://api.github.com/users/a5anka/orgs","repos_url":"https://api.github.com/users/a5anka/repos","events_url":"https://api.github.com/users/a5anka/events{/privacy}","received_events_url":"https://api.github.com/users/a5anka/received_events","type":"User","site_admin":false},{"login":"indikasampath2000","id":3735291,"avatar_url":"https://avatars3.githubusercontent.com/u/3735291?v=4","gravatar_id":"","url":"https://api.github.com/users/indikasampath2000","html_url":"https://github.com/indikasampath2000","followers_url":"https://api.github.com/users/indikasampath2000/followers","following_url":"https://api.github.com/users/indikasampath2000/following{/other_user}","gists_url":"https://api.github.com/users/indikasampath2000/gists{/gist_id}","starred_url":"https://api.github.com/users/indikasampath2000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indikasampath2000/subscriptions","organizations_url":"https://api.github.com/users/indikasampath2000/orgs","repos_url":"https://api.github.com/users/indikasampath2000/repos","events_url":"https://api.github.com/users/indikasampath2000/events{/privacy}","received_events_url":"https://api.github.com/users/indikasampath2000/received_events","type":"User","site_admin":false},{"login":"MaryamZi","id":8376983,"avatar_url":"https://avatars1.githubusercontent.com/u/8376983?v=4","gravatar_id":"","url":"https://api.github.com/users/MaryamZi","html_url":"https://github.com/MaryamZi","followers_url":"https://api.github.com/users/MaryamZi/followers","following_url":"https://api.github.com/users/MaryamZi/following{/other_user}","gists_url":"https://api.github.com/users/MaryamZi/gists{/gist_id}","starred_url":"https://api.github.com/users/MaryamZi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MaryamZi/subscriptions","organizations_url":"https://api.github.com/users/MaryamZi/orgs","repos_url":"https://api.github.com/users/MaryamZi/repos","events_url":"https://api.github.com/users/MaryamZi/events{/privacy}","received_events_url":"https://api.github.com/users/MaryamZi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":783489412,"url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/labels/Module/broker-amqp","name":"Module/broker-amqp","color":"c6993d","default":false},{"id":783483737,"url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/labels/Module/broker-core","name":"Module/broker-core","color":"c6993d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/321/commits","review_comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/321/comments","review_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/issues/321/comments","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/statuses/bfaee19d980b46b1f25740a0deb64e8075ea0aa3","head":{"label":"Asitha:dtx-impl","ref":"dtx-impl","sha":"bfaee19d980b46b1f25740a0deb64e8075ea0aa3","user":{"login":"Asitha","id":919462,"avatar_url":"https://avatars3.githubusercontent.com/u/919462?v=4","gravatar_id":"","url":"https://api.github.com/users/Asitha","html_url":"https://github.com/Asitha","followers_url":"https://api.github.com/users/Asitha/followers","following_url":"https://api.github.com/users/Asitha/following{/other_user}","gists_url":"https://api.github.com/users/Asitha/gists{/gist_id}","starred_url":"https://api.github.com/users/Asitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asitha/subscriptions","organizations_url":"https://api.github.com/users/Asitha/orgs","repos_url":"https://api.github.com/users/Asitha/repos","events_url":"https://api.github.com/users/Asitha/events{/privacy}","received_events_url":"https://api.github.com/users/Asitha/received_events","type":"User","site_admin":false},"repo":{"id":111645485,"name":"message-broker","full_name":"Asitha/message-broker","owner":{"login":"Asitha","id":919462,"avatar_url":"https://avatars3.githubusercontent.com/u/919462?v=4","gravatar_id":"","url":"https://api.github.com/users/Asitha","html_url":"https://github.com/Asitha","followers_url":"https://api.github.com/users/Asitha/followers","following_url":"https://api.github.com/users/Asitha/following{/other_user}","gists_url":"https://api.github.com/users/Asitha/gists{/gist_id}","starred_url":"https://api.github.com/users/Asitha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Asitha/subscriptions","organizations_url":"https://api.github.com/users/Asitha/orgs","repos_url":"https://api.github.com/users/Asitha/repos","events_url":"https://api.github.com/users/Asitha/events{/privacy}","received_events_url":"https://api.github.com/users/Asitha/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Asitha/message-broker","description":null,"fork":true,"url":"https://api.github.com/repos/Asitha/message-broker","forks_url":"https://api.github.com/repos/Asitha/message-broker/forks","keys_url":"https://api.github.com/repos/Asitha/message-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Asitha/message-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Asitha/message-broker/teams","hooks_url":"https://api.github.com/repos/Asitha/message-broker/hooks","issue_events_url":"https://api.github.com/repos/Asitha/message-broker/issues/events{/number}","events_url":"https://api.github.com/repos/Asitha/message-broker/events","assignees_url":"https://api.github.com/repos/Asitha/message-broker/assignees{/user}","branches_url":"https://api.github.com/repos/Asitha/message-broker/branches{/branch}","tags_url":"https://api.github.com/repos/Asitha/message-broker/tags","blobs_url":"https://api.github.com/repos/Asitha/message-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Asitha/message-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Asitha/message-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/Asitha/message-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Asitha/message-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/Asitha/message-broker/languages","stargazers_url":"https://api.github.com/repos/Asitha/message-broker/stargazers","contributors_url":"https://api.github.com/repos/Asitha/message-broker/contributors","subscribers_url":"https://api.github.com/repos/Asitha/message-broker/subscribers","subscription_url":"https://api.github.com/repos/Asitha/message-broker/subscription","commits_url":"https://api.github.com/repos/Asitha/message-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/Asitha/message-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/Asitha/message-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/Asitha/message-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/Asitha/message-broker/contents/{+path}","compare_url":"https://api.github.com/repos/Asitha/message-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Asitha/message-broker/merges","archive_url":"https://api.github.com/repos/Asitha/message-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Asitha/message-broker/downloads","issues_url":"https://api.github.com/repos/Asitha/message-broker/issues{/number}","pulls_url":"https://api.github.com/repos/Asitha/message-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/Asitha/message-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/Asitha/message-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Asitha/message-broker/labels{/name}","releases_url":"https://api.github.com/repos/Asitha/message-broker/releases{/id}","deployments_url":"https://api.github.com/repos/Asitha/message-broker/deployments","created_at":"2017-11-22T06:33:03Z","updated_at":"2017-11-28T09:45:09Z","pushed_at":"2018-03-02T03:36:35Z","git_url":"git://github.com/Asitha/message-broker.git","ssh_url":"[email protected]:Asitha/message-broker.git","clone_url":"https://github.com/Asitha/message-broker.git","svn_url":"https://github.com/Asitha/message-broker","homepage":null,"size":2272,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ballerina-platform:transactions","ref":"transactions","sha":"5d64bd00f0ef86f63b1f85651338e18cf5156adb","user":{"login":"ballerina-platform","id":34733518,"avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":111517878,"name":"ballerina-message-broker","full_name":"ballerina-platform/ballerina-message-broker","owner":{"login":"ballerina-platform","id":34733518,"avatar_url":"https://avatars2.githubusercontent.com/u/34733518?v=4","gravatar_id":"","url":"https://api.github.com/users/ballerina-platform","html_url":"https://github.com/ballerina-platform","followers_url":"https://api.github.com/users/ballerina-platform/followers","following_url":"https://api.github.com/users/ballerina-platform/following{/other_user}","gists_url":"https://api.github.com/users/ballerina-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/ballerina-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ballerina-platform/subscriptions","organizations_url":"https://api.github.com/users/ballerina-platform/orgs","repos_url":"https://api.github.com/users/ballerina-platform/repos","events_url":"https://api.github.com/users/ballerina-platform/events{/privacy}","received_events_url":"https://api.github.com/users/ballerina-platform/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ballerina-platform/ballerina-message-broker","description":null,"fork":false,"url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker","forks_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/forks","keys_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/teams","hooks_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/hooks","issue_events_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/issues/events{/number}","events_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/events","assignees_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/assignees{/user}","branches_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/branches{/branch}","tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/tags","blobs_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/git/refs{/sha}","trees_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/statuses/{sha}","languages_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/languages","stargazers_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/stargazers","contributors_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/contributors","subscribers_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/subscribers","subscription_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/subscription","commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/commits{/sha}","git_commits_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/git/commits{/sha}","comments_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/comments{/number}","issue_comment_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/issues/comments{/number}","contents_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/contents/{+path}","compare_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/merges","archive_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/downloads","issues_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/issues{/number}","pulls_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls{/number}","milestones_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/milestones{/number}","notifications_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/labels{/name}","releases_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/releases{/id}","deployments_url":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/deployments","created_at":"2017-11-21T08:02:59Z","updated_at":"2018-02-16T10:46:30Z","pushed_at":"2018-03-02T04:58:31Z","git_url":"git://github.com/ballerina-platform/ballerina-message-broker.git","ssh_url":"[email protected]:ballerina-platform/ballerina-message-broker.git","clone_url":"https://github.com/ballerina-platform/ballerina-message-broker.git","svn_url":"https://github.com/ballerina-platform/ballerina-message-broker","homepage":null,"size":2273,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":62,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":10,"open_issues":62,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/321"},"html":{"href":"https://github.com/ballerina-platform/ballerina-message-broker/pull/321"},"issue":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/issues/321"},"comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/issues/321/comments"},"review_comments":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/321/comments"},"review_comment":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/pulls/321/commits"},"statuses":{"href":"https://api.github.com/repos/ballerina-platform/ballerina-message-broker/statuses/bfaee19d980b46b1f25740a0deb64e8075ea0aa3"}},"author_association":"MEMBER"}}

7320117342

{"actor":{"display_login":"erandacr"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/194623492","pull_request_review_id":127828442,"id":194623492,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDYyMzQ5Mg==","diff_hunk":"@@ -0,0 +1,83 @@\n+/*\n+ * Copyright 2018, Strimzi authors.\n+ * License: Apache License 2.0 (see the file LICENSE or http://apache.org/licenses/LICENSE-2.0.html).\n+ */\n+package io.strimzi.systemtest;\n+\n+import io.strimzi.test.JUnitGroup;\n+import io.strimzi.test.Namespace;\n+import io.strimzi.test.OpenShiftOnly;\n+import io.strimzi.test.StrimziRunner;\n+import io.strimzi.test.k8s.KubeClient;\n+import io.strimzi.test.k8s.Oc;\n+import org.apache.logging.log4j.LogManager;\n+import org.apache.logging.log4j.Logger;\n+import org.junit.Test;\n+import org.junit.runner.RunWith;\n+\n+\n+import static io.strimzi.systemtest.NamespaceIT.NAMESPACE1;\n+import static io.strimzi.systemtest.NamespaceIT.NAMESPACE2;\n+import static io.strimzi.test.TestUtils.map;\n+import static org.junit.Assert.assertEquals;\n+\n+@RunWith(StrimziRunner.class)\n+@Namespace(NAMESPACE1)\n+@Namespace(NAMESPACE2)\n+public class NamespaceIT extends AbstractClusterIT {\n+\n+ private static final Logger LOGGER = LogManager.getLogger(NamespaceIT.class);\n+\n+ public static final String NAMESPACE1 = \"kafka-cluster-test\";\n+ public static final String NAMESPACE2 = \"kafka-cluster-test2\";\n+\n+ @Test\n+ @JUnitGroup(name = \"regression\")\n+ @OpenShiftOnly\n+ public void testForWorkWithMultipleNamespaces() {\n+ String clusterName = \"openshift-my-cluster\";\n+\n+ //Deploying cluster in first namespace\n+ KubeClient client1 = kubeClient.inNamespace(NAMESPACE1);\n+ client1.deployCOFromCommandLine(NAMESPACE1, \"../examples/install/cluster-operator\");\n+ client1.waitForDeployment(\"strimzi-cluster-operator\");\n+ client1.installTemplates(NAMESPACE1, \"../examples/templates/cluster-operator\");\n+ Oc oc1 = (Oc) client1;\n+ oc1.newApp(\"strimzi-ephemeral\", map(\"CLUSTER_NAME\", clusterName));\n+ client1.waitForStatefulSet(zookeeperClusterName(clusterName), 3);\n+ client1.waitForStatefulSet(kafkaClusterName(clusterName), 3);\n+\n+ //Deploying cluster in second namespace\n+ KubeClient client2 = kubeClient.inNamespace(NAMESPACE2);\n+ client2.deployCOFromCommandLine(NAMESPACE2, \"../examples/install/cluster-operator\");","path":"systemtest/src/test/java/io/strimzi/systemtest/NamespaceIT.java","position":52,"original_position":52,"commit_id":"b0c3c58070cbdd2d7a4920ef2bb6ed4401c13f99","original_commit_id":"b0c3c58070cbdd2d7a4920ef2bb6ed4401c13f99","user":{"login":"ppatierno","id":5842311,"node_id":"MDQ6VXNlcjU4NDIzMTE=","avatar_url":"https://avatars0.githubusercontent.com/u/5842311?v=4","gravatar_id":"","url":"https://api.github.com/users/ppatierno","html_url":"https://github.com/ppatierno","followers_url":"https://api.github.com/users/ppatierno/followers","following_url":"https://api.github.com/users/ppatierno/following{/other_user}","gists_url":"https://api.github.com/users/ppatierno/gists{/gist_id}","starred_url":"https://api.github.com/users/ppatierno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ppatierno/subscriptions","organizations_url":"https://api.github.com/users/ppatierno/orgs","repos_url":"https://api.github.com/users/ppatierno/repos","events_url":"https://api.github.com/users/ppatierno/events{/privacy}","received_events_url":"https://api.github.com/users/ppatierno/received_events","type":"User","site_admin":false},"body":"Working with multi-namespaces means that the CO can live in just one namespace and then watching cluster ConfigMap created in different namespaces and deploying the clusters there. In this test you are deploying the CO twice in both the namespaces where you want to deploy the clusters. Is it something that you really wanted ?","created_at":"2018-06-12T06:08:38Z","updated_at":"2018-06-12T06:08:41Z","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/489#discussion_r194623492","pull_request_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/489","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/194623492"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/489#discussion_r194623492"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/489"}}},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/489","id":194012902,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MDEyOTAy","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/489","diff_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/489.diff","patch_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/489.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/489","number":489,"state":"open","locked":false,"title":"Added ST for multiple namespaces","user":{"login":"asorokhtey","id":7902749,"node_id":"MDQ6VXNlcjc5MDI3NDk=","avatar_url":"https://avatars2.githubusercontent.com/u/7902749?v=4","gravatar_id":"","url":"https://api.github.com/users/asorokhtey","html_url":"https://github.com/asorokhtey","followers_url":"https://api.github.com/users/asorokhtey/followers","following_url":"https://api.github.com/users/asorokhtey/following{/other_user}","gists_url":"https://api.github.com/users/asorokhtey/gists{/gist_id}","starred_url":"https://api.github.com/users/asorokhtey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asorokhtey/subscriptions","organizations_url":"https://api.github.com/users/asorokhtey/orgs","repos_url":"https://api.github.com/users/asorokhtey/repos","events_url":"https://api.github.com/users/asorokhtey/events{/privacy}","received_events_url":"https://api.github.com/users/asorokhtey/received_events","type":"User","site_admin":false},"body":"### Type of change\r\n\r\n- New system test\r\n\r\n### Description\r\n\r\nAdded ST for multiple namespaces. The test creates 2 namespaces and does scaling of each cluster. After scaling verifying that another cluster is not affected. \r\n\r\n### Checklist\r\n\r\n- [x] Write tests\r\n- [x] Make sure all tests pass\r\n- [ ] Update documentation\r\n- [ ] Check RBAC rights for Kubernetes / OpenShift roles\r\n- [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally\r\n- [ ] Reference relevant issue(s) and close them after merging\r\n\r\n","created_at":"2018-06-11T15:09:23Z","updated_at":"2018-06-12T06:08:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0b030e993a70697cafcc2fcbdfb933823443e01","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":872722607,"node_id":"MDU6TGFiZWw4NzI3MjI2MDc=","url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels/System%20tests","name":"System tests","color":"047a6a","default":false}],"milestone":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones/4","html_url":"https://github.com/strimzi/strimzi-kafka-operator/milestone/4","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones/4/labels","id":3333700,"node_id":"MDk6TWlsZXN0b25lMzMzMzcwMA==","number":4,"title":"0.5.0","description":"","creator":{"login":"scholzj","id":5658439,"node_id":"MDQ6VXNlcjU2NTg0Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/5658439?v=4","gravatar_id":"","url":"https://api.github.com/users/scholzj","html_url":"https://github.com/scholzj","followers_url":"https://api.github.com/users/scholzj/followers","following_url":"https://api.github.com/users/scholzj/following{/other_user}","gists_url":"https://api.github.com/users/scholzj/gists{/gist_id}","starred_url":"https://api.github.com/users/scholzj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scholzj/subscriptions","organizations_url":"https://api.github.com/users/scholzj/orgs","repos_url":"https://api.github.com/users/scholzj/repos","events_url":"https://api.github.com/users/scholzj/events{/privacy}","received_events_url":"https://api.github.com/users/scholzj/received_events","type":"User","site_admin":false},"open_issues":1,"closed_issues":41,"state":"open","created_at":"2018-05-09T16:31:12Z","updated_at":"2018-06-11T15:09:23Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/489/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/489/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/489/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/b0c3c58070cbdd2d7a4920ef2bb6ed4401c13f99","head":{"label":"strimzi:namespace-test","ref":"namespace-test","sha":"b0c3c58070cbdd2d7a4920ef2bb6ed4401c13f99","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE5NDE4MA==","name":"strimzi-kafka-operator","full_name":"strimzi/strimzi-kafka-operator","owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi-kafka-operator","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-06-11T06:36:29Z","pushed_at":"2018-06-12T02:34:49Z","git_url":"git://github.com/strimzi/strimzi-kafka-operator.git","ssh_url":"[email protected]:strimzi/strimzi-kafka-operator.git","clone_url":"https://github.com/strimzi/strimzi-kafka-operator.git","svn_url":"https://github.com/strimzi/strimzi-kafka-operator","homepage":"http://strimzi.io/","size":10895,"stargazers_count":289,"watchers_count":289,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":59,"open_issues":73,"watchers":289,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"62b489371135f4f590e6bbae0e30d947b58e7a70","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE5NDE4MA==","name":"strimzi-kafka-operator","full_name":"strimzi/strimzi-kafka-operator","owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi-kafka-operator","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-06-11T06:36:29Z","pushed_at":"2018-06-12T02:34:49Z","git_url":"git://github.com/strimzi/strimzi-kafka-operator.git","ssh_url":"[email protected]:strimzi/strimzi-kafka-operator.git","clone_url":"https://github.com/strimzi/strimzi-kafka-operator.git","svn_url":"https://github.com/strimzi/strimzi-kafka-operator","homepage":"http://strimzi.io/","size":10895,"stargazers_count":289,"watchers_count":289,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":59,"mirror_url":null,"archived":false,"open_issues_count":73,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":59,"open_issues":73,"watchers":289,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/489"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/489"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/489"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/489/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/489/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/489/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/b0c3c58070cbdd2d7a4920ef2bb6ed4401c13f99"}},"author_association":"MEMBER"}}

7810307232

{"actor":{"display_login":"ppatierno"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/201766607","pull_request_review_id":136331586,"id":201766607,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTc2NjYwNw==","diff_hunk":"@@ -13,6 +13,12 @@ services:\n # - asciidoctor\n before_install:\n - gem install asciidoctor\n+# Installing Helm\n+- HELM_TGZ=helm-v2.9.1-linux-amd64.tar.gz\n+- wget -q https://storage.googleapis.com/kubernetes-helm/${HELM_TGZ}\n+- tar xzfv ${HELM_TGZ}\n+- PATH=`pwd`/linux-amd64/:$PATH\n+- helm init --client-only","path":".travis.yml","position":9,"original_position":9,"commit_id":"dd3c3d90b438d4f2b5bbe6134ff540d2518ede6e","original_commit_id":"dd3c3d90b438d4f2b5bbe6134ff540d2518ede6e","user":{"login":"seglo","id":1148412,"node_id":"MDQ6VXNlcjExNDg0MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1148412?v=4","gravatar_id":"","url":"https://api.github.com/users/seglo","html_url":"https://github.com/seglo","followers_url":"https://api.github.com/users/seglo/followers","following_url":"https://api.github.com/users/seglo/following{/other_user}","gists_url":"https://api.github.com/users/seglo/gists{/gist_id}","starred_url":"https://api.github.com/users/seglo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seglo/subscriptions","organizations_url":"https://api.github.com/users/seglo/orgs","repos_url":"https://api.github.com/users/seglo/repos","events_url":"https://api.github.com/users/seglo/events{/privacy}","received_events_url":"https://api.github.com/users/seglo/received_events","type":"User","site_admin":false},"body":"Ok, I'll add a system test.","created_at":"2018-07-11T16:52:53Z","updated_at":"2018-07-11T16:52:53Z","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/565#discussion_r201766607","pull_request_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/565","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments/201766607"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/565#discussion_r201766607"},"pull_request":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/565"}},"in_reply_to_id":201723689},"pull_request":{"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/565","id":200458833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNDU4ODMz","html_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/565","diff_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/565.diff","patch_url":"https://github.com/strimzi/strimzi-kafka-operator/pull/565.patch","issue_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/565","number":565,"state":"open","locked":false,"title":"Add a Strimzi Helm Chart -WIP","user":{"login":"seglo","id":1148412,"node_id":"MDQ6VXNlcjExNDg0MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1148412?v=4","gravatar_id":"","url":"https://api.github.com/users/seglo","html_url":"https://github.com/seglo","followers_url":"https://api.github.com/users/seglo/followers","following_url":"https://api.github.com/users/seglo/following{/other_user}","gists_url":"https://api.github.com/users/seglo/gists{/gist_id}","starred_url":"https://api.github.com/users/seglo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seglo/subscriptions","organizations_url":"https://api.github.com/users/seglo/orgs","repos_url":"https://api.github.com/users/seglo/repos","events_url":"https://api.github.com/users/seglo/events{/privacy}","received_events_url":"https://api.github.com/users/seglo/received_events","type":"User","site_admin":false},"body":"### Type of change\r\n\r\nEnhancement / new feature\r\n\r\n### Description\r\n\r\nSupport Helm Charts as a means to install Strimzi into a Kubernetes cluster. #539 \r\n\r\n### Checklist\r\n\r\n_Please go through this checklist and make sure all applicable tasks have been done_\r\n\r\n- [ ] Write tests\r\n- [ ] Make sure all tests pass\r\n- [ ] Update documentation\r\n- [ ] Check RBAC rights for Kubernetes / OpenShift roles\r\n- [ ] Try your changes from Pod inside your Kubernetes and OpenShift cluster, not just locally\r\n- [x] Reference relevant issue(s) and close them after merging\r\n\r\n","created_at":"2018-07-10T16:44:26Z","updated_at":"2018-07-11T16:52:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4041759f7b4c5625fb3c270c9b78e6ab416059f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/565/commits","review_comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/565/comments","review_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/565/comments","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/dd3c3d90b438d4f2b5bbe6134ff540d2518ede6e","head":{"label":"seglo:helm-chart","ref":"helm-chart","sha":"dd3c3d90b438d4f2b5bbe6134ff540d2518ede6e","user":{"login":"seglo","id":1148412,"node_id":"MDQ6VXNlcjExNDg0MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1148412?v=4","gravatar_id":"","url":"https://api.github.com/users/seglo","html_url":"https://github.com/seglo","followers_url":"https://api.github.com/users/seglo/followers","following_url":"https://api.github.com/users/seglo/following{/other_user}","gists_url":"https://api.github.com/users/seglo/gists{/gist_id}","starred_url":"https://api.github.com/users/seglo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seglo/subscriptions","organizations_url":"https://api.github.com/users/seglo/orgs","repos_url":"https://api.github.com/users/seglo/repos","events_url":"https://api.github.com/users/seglo/events{/privacy}","received_events_url":"https://api.github.com/users/seglo/received_events","type":"User","site_admin":false},"repo":{"id":139985583,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5ODU1ODM=","name":"strimzi-kafka-operator","full_name":"seglo/strimzi-kafka-operator","owner":{"login":"seglo","id":1148412,"node_id":"MDQ6VXNlcjExNDg0MTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1148412?v=4","gravatar_id":"","url":"https://api.github.com/users/seglo","html_url":"https://github.com/seglo","followers_url":"https://api.github.com/users/seglo/followers","following_url":"https://api.github.com/users/seglo/following{/other_user}","gists_url":"https://api.github.com/users/seglo/gists{/gist_id}","starred_url":"https://api.github.com/users/seglo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seglo/subscriptions","organizations_url":"https://api.github.com/users/seglo/orgs","repos_url":"https://api.github.com/users/seglo/repos","events_url":"https://api.github.com/users/seglo/events{/privacy}","received_events_url":"https://api.github.com/users/seglo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/seglo/strimzi-kafka-operator","description":"Apache Kafka running on Kubernetes and OpenShift","fork":true,"url":"https://api.github.com/repos/seglo/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/seglo/strimzi-kafka-operator/deployments","created_at":"2018-07-06T13:01:47Z","updated_at":"2018-07-10T16:41:35Z","pushed_at":"2018-07-11T13:11:01Z","git_url":"git://github.com/seglo/strimzi-kafka-operator.git","ssh_url":"[email protected]:seglo/strimzi-kafka-operator.git","clone_url":"https://github.com/seglo/strimzi-kafka-operator.git","svn_url":"https://github.com/seglo/strimzi-kafka-operator","homepage":"http://strimzi.io/","size":11582,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strimzi:master","ref":"master","sha":"fb533b9b4ecb4033290c74b7507000c56dec416d","user":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"repo":{"id":58194180,"node_id":"MDEwOlJlcG9zaXRvcnk1ODE5NDE4MA==","name":"strimzi-kafka-operator","full_name":"strimzi/strimzi-kafka-operator","owner":{"login":"strimzi","id":34767428,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0NzY3NDI4","avatar_url":"https://avatars1.githubusercontent.com/u/34767428?v=4","gravatar_id":"","url":"https://api.github.com/users/strimzi","html_url":"https://github.com/strimzi","followers_url":"https://api.github.com/users/strimzi/followers","following_url":"https://api.github.com/users/strimzi/following{/other_user}","gists_url":"https://api.github.com/users/strimzi/gists{/gist_id}","starred_url":"https://api.github.com/users/strimzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strimzi/subscriptions","organizations_url":"https://api.github.com/users/strimzi/orgs","repos_url":"https://api.github.com/users/strimzi/repos","events_url":"https://api.github.com/users/strimzi/events{/privacy}","received_events_url":"https://api.github.com/users/strimzi/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/strimzi/strimzi-kafka-operator","description":"Apache Kafka running on Kubernetes and OpenShift","fork":false,"url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator","forks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/forks","keys_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/teams","hooks_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/hooks","issue_events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/events{/number}","events_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/events","assignees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/assignees{/user}","branches_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/branches{/branch}","tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/tags","blobs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/languages","stargazers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/stargazers","contributors_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contributors","subscribers_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscribers","subscription_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/subscription","commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/contents/{+path}","compare_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/merges","archive_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/downloads","issues_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues{/number}","pulls_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/labels{/name}","releases_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/releases{/id}","deployments_url":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/deployments","created_at":"2016-05-06T08:52:33Z","updated_at":"2018-07-11T10:11:12Z","pushed_at":"2018-07-11T16:30:15Z","git_url":"git://github.com/strimzi/strimzi-kafka-operator.git","ssh_url":"[email protected]:strimzi/strimzi-kafka-operator.git","clone_url":"https://github.com/strimzi/strimzi-kafka-operator.git","svn_url":"https://github.com/strimzi/strimzi-kafka-operator","homepage":"http://strimzi.io/","size":11417,"stargazers_count":313,"watchers_count":313,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":63,"open_issues":88,"watchers":313,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/565"},"html":{"href":"https://github.com/strimzi/strimzi-kafka-operator/pull/565"},"issue":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/565"},"comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/issues/565/comments"},"review_comments":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/565/comments"},"review_comment":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/pulls/565/commits"},"statuses":{"href":"https://api.github.com/repos/strimzi/strimzi-kafka-operator/statuses/dd3c3d90b438d4f2b5bbe6134ff540d2518ede6e"}},"author_association":"NONE"}}

7951353820

{"actor":{"display_login":"seglo"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/comments/229271981","pull_request_review_id":169728469,"id":229271981,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTI3MTk4MQ==","diff_hunk":"@@ -7,7 +7,7 @@ DEPENDS_append = \" af-main-native\"\n # for bindings af-binder is required.\n DEPENDS_append = \" af-binder\"\n \n-SRC_URI = \"git://github.com/webosose/${PN}.git;[email protected];protocol=https\"\n+SRC_URI = \"git://github.com/Igalia/${PN}.git;branch=flounder;protocol=https\"","path":"recipes-wam/chromium/chromium53.inc","position":5,"original_position":5,"commit_id":"434ffe828595195e2d84557bd42a85f1c3013533","original_commit_id":"434ffe828595195e2d84557bd42a85f1c3013533","user":{"login":"jdapena","id":1110395,"node_id":"MDQ6VXNlcjExMTAzOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1110395?v=4","gravatar_id":"","url":"https://api.github.com/users/jdapena","html_url":"https://github.com/jdapena","followers_url":"https://api.github.com/users/jdapena/followers","following_url":"https://api.github.com/users/jdapena/following{/other_user}","gists_url":"https://api.github.com/users/jdapena/gists{/gist_id}","starred_url":"https://api.github.com/users/jdapena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdapena/subscriptions","organizations_url":"https://api.github.com/users/jdapena/orgs","repos_url":"https://api.github.com/users/jdapena/repos","events_url":"https://api.github.com/users/jdapena/events{/privacy}","received_events_url":"https://api.github.com/users/jdapena/received_events","type":"User","site_admin":false},"body":"This needs to be fixed so it uses again the webosose repositories. Also, the branch is @1.agl.flounder.","created_at":"2018-10-30T11:39:15Z","updated_at":"2018-10-30T11:40:58Z","html_url":"https://github.com/webosose/meta-agl-lge/pull/9#discussion_r229271981","pull_request_url":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/9","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/comments/229271981"},"html":{"href":"https://github.com/webosose/meta-agl-lge/pull/9#discussion_r229271981"},"pull_request":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/9","id":226887127,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2ODg3MTI3","html_url":"https://github.com/webosose/meta-agl-lge/pull/9","diff_url":"https://github.com/webosose/meta-agl-lge/pull/9.diff","patch_url":"https://github.com/webosose/meta-agl-lge/pull/9.patch","issue_url":"https://api.github.com/repos/webosose/meta-agl-lge/issues/9","number":9,"state":"open","locked":false,"title":"Work from Igalia for WAM integration in Flounder + tinyproxy","user":{"login":"jdapena","id":1110395,"node_id":"MDQ6VXNlcjExMTAzOTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1110395?v=4","gravatar_id":"","url":"https://api.github.com/users/jdapena","html_url":"https://github.com/jdapena","followers_url":"https://api.github.com/users/jdapena/followers","following_url":"https://api.github.com/users/jdapena/following{/other_user}","gists_url":"https://api.github.com/users/jdapena/gists{/gist_id}","starred_url":"https://api.github.com/users/jdapena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdapena/subscriptions","organizations_url":"https://api.github.com/users/jdapena/orgs","repos_url":"https://api.github.com/users/jdapena/repos","events_url":"https://api.github.com/users/jdapena/events{/privacy}","received_events_url":"https://api.github.com/users/jdapena/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-30T11:37:50Z","updated_at":"2018-10-30T11:40:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[{"login":"andre-rosa","id":5388335,"node_id":"MDQ6VXNlcjUzODgzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/5388335?v=4","gravatar_id":"","url":"https://api.github.com/users/andre-rosa","html_url":"https://github.com/andre-rosa","followers_url":"https://api.github.com/users/andre-rosa/followers","following_url":"https://api.github.com/users/andre-rosa/following{/other_user}","gists_url":"https://api.github.com/users/andre-rosa/gists{/gist_id}","starred_url":"https://api.github.com/users/andre-rosa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andre-rosa/subscriptions","organizations_url":"https://api.github.com/users/andre-rosa/orgs","repos_url":"https://api.github.com/users/andre-rosa/repos","events_url":"https://api.github.com/users/andre-rosa/events{/privacy}","received_events_url":"https://api.github.com/users/andre-rosa/received_events","type":"User","site_admin":false},{"login":"zhani","id":32860233,"node_id":"MDQ6VXNlcjMyODYwMjMz","avatar_url":"https://avatars0.githubusercontent.com/u/32860233?v=4","gravatar_id":"","url":"https://api.github.com/users/zhani","html_url":"https://github.com/zhani","followers_url":"https://api.github.com/users/zhani/followers","following_url":"https://api.github.com/users/zhani/following{/other_user}","gists_url":"https://api.github.com/users/zhani/gists{/gist_id}","starred_url":"https://api.github.com/users/zhani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhani/subscriptions","organizations_url":"https://api.github.com/users/zhani/orgs","repos_url":"https://api.github.com/users/zhani/repos","events_url":"https://api.github.com/users/zhani/events{/privacy}","received_events_url":"https://api.github.com/users/zhani/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/9/commits","review_comments_url":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/9/comments","review_comment_url":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webosose/meta-agl-lge/issues/9/comments","statuses_url":"https://api.github.com/repos/webosose/meta-agl-lge/statuses/434ffe828595195e2d84557bd42a85f1c3013533","head":{"label":"Igalia:flounder","ref":"flounder","sha":"434ffe828595195e2d84557bd42a85f1c3013533","user":{"login":"Igalia","id":1576566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzY1NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1576566?v=4","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"repo":{"id":149272303,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkyNzIzMDM=","name":"meta-agl-lge","full_name":"Igalia/meta-agl-lge","private":false,"owner":{"login":"Igalia","id":1576566,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NzY1NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/1576566?v=4","gravatar_id":"","url":"https://api.github.com/users/Igalia","html_url":"https://github.com/Igalia","followers_url":"https://api.github.com/users/Igalia/followers","following_url":"https://api.github.com/users/Igalia/following{/other_user}","gists_url":"https://api.github.com/users/Igalia/gists{/gist_id}","starred_url":"https://api.github.com/users/Igalia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Igalia/subscriptions","organizations_url":"https://api.github.com/users/Igalia/orgs","repos_url":"https://api.github.com/users/Igalia/repos","events_url":"https://api.github.com/users/Igalia/events{/privacy}","received_events_url":"https://api.github.com/users/Igalia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Igalia/meta-agl-lge","description":null,"fork":true,"url":"https://api.github.com/repos/Igalia/meta-agl-lge","forks_url":"https://api.github.com/repos/Igalia/meta-agl-lge/forks","keys_url":"https://api.github.com/repos/Igalia/meta-agl-lge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Igalia/meta-agl-lge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Igalia/meta-agl-lge/teams","hooks_url":"https://api.github.com/repos/Igalia/meta-agl-lge/hooks","issue_events_url":"https://api.github.com/repos/Igalia/meta-agl-lge/issues/events{/number}","events_url":"https://api.github.com/repos/Igalia/meta-agl-lge/events","assignees_url":"https://api.github.com/repos/Igalia/meta-agl-lge/assignees{/user}","branches_url":"https://api.github.com/repos/Igalia/meta-agl-lge/branches{/branch}","tags_url":"https://api.github.com/repos/Igalia/meta-agl-lge/tags","blobs_url":"https://api.github.com/repos/Igalia/meta-agl-lge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Igalia/meta-agl-lge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Igalia/meta-agl-lge/git/refs{/sha}","trees_url":"https://api.github.com/repos/Igalia/meta-agl-lge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Igalia/meta-agl-lge/statuses/{sha}","languages_url":"https://api.github.com/repos/Igalia/meta-agl-lge/languages","stargazers_url":"https://api.github.com/repos/Igalia/meta-agl-lge/stargazers","contributors_url":"https://api.github.com/repos/Igalia/meta-agl-lge/contributors","subscribers_url":"https://api.github.com/repos/Igalia/meta-agl-lge/subscribers","subscription_url":"https://api.github.com/repos/Igalia/meta-agl-lge/subscription","commits_url":"https://api.github.com/repos/Igalia/meta-agl-lge/commits{/sha}","git_commits_url":"https://api.github.com/repos/Igalia/meta-agl-lge/git/commits{/sha}","comments_url":"https://api.github.com/repos/Igalia/meta-agl-lge/comments{/number}","issue_comment_url":"https://api.github.com/repos/Igalia/meta-agl-lge/issues/comments{/number}","contents_url":"https://api.github.com/repos/Igalia/meta-agl-lge/contents/{+path}","compare_url":"https://api.github.com/repos/Igalia/meta-agl-lge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Igalia/meta-agl-lge/merges","archive_url":"https://api.github.com/repos/Igalia/meta-agl-lge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Igalia/meta-agl-lge/downloads","issues_url":"https://api.github.com/repos/Igalia/meta-agl-lge/issues{/number}","pulls_url":"https://api.github.com/repos/Igalia/meta-agl-lge/pulls{/number}","milestones_url":"https://api.github.com/repos/Igalia/meta-agl-lge/milestones{/number}","notifications_url":"https://api.github.com/repos/Igalia/meta-agl-lge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Igalia/meta-agl-lge/labels{/name}","releases_url":"https://api.github.com/repos/Igalia/meta-agl-lge/releases{/id}","deployments_url":"https://api.github.com/repos/Igalia/meta-agl-lge/deployments","created_at":"2018-09-18T10:46:06Z","updated_at":"2018-10-30T11:23:35Z","pushed_at":"2018-10-30T11:23:33Z","git_url":"git://github.com/Igalia/meta-agl-lge.git","ssh_url":"[email protected]:Igalia/meta-agl-lge.git","clone_url":"https://github.com/Igalia/meta-agl-lge.git","svn_url":"https://github.com/Igalia/meta-agl-lge","homepage":null,"size":7305,"stargazers_count":0,"watchers_count":0,"language":"BitBake","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"flounder"}},"base":{"label":"webosose:flounder","ref":"flounder","sha":"236cad2c4fc211e429d64deccaba81e2c9eef1dc","user":{"login":"webosose","id":35021023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDIxMDIz","avatar_url":"https://avatars1.githubusercontent.com/u/35021023?v=4","gravatar_id":"","url":"https://api.github.com/users/webosose","html_url":"https://github.com/webosose","followers_url":"https://api.github.com/users/webosose/followers","following_url":"https://api.github.com/users/webosose/following{/other_user}","gists_url":"https://api.github.com/users/webosose/gists{/gist_id}","starred_url":"https://api.github.com/users/webosose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webosose/subscriptions","organizations_url":"https://api.github.com/users/webosose/orgs","repos_url":"https://api.github.com/users/webosose/repos","events_url":"https://api.github.com/users/webosose/events{/privacy}","received_events_url":"https://api.github.com/users/webosose/received_events","type":"Organization","site_admin":false},"repo":{"id":132146511,"node_id":"MDEwOlJlcG9zaXRvcnkxMzIxNDY1MTE=","name":"meta-agl-lge","full_name":"webosose/meta-agl-lge","private":false,"owner":{"login":"webosose","id":35021023,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDIxMDIz","avatar_url":"https://avatars1.githubusercontent.com/u/35021023?v=4","gravatar_id":"","url":"https://api.github.com/users/webosose","html_url":"https://github.com/webosose","followers_url":"https://api.github.com/users/webosose/followers","following_url":"https://api.github.com/users/webosose/following{/other_user}","gists_url":"https://api.github.com/users/webosose/gists{/gist_id}","starred_url":"https://api.github.com/users/webosose/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webosose/subscriptions","organizations_url":"https://api.github.com/users/webosose/orgs","repos_url":"https://api.github.com/users/webosose/repos","events_url":"https://api.github.com/users/webosose/events{/privacy}","received_events_url":"https://api.github.com/users/webosose/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/webosose/meta-agl-lge","description":null,"fork":false,"url":"https://api.github.com/repos/webosose/meta-agl-lge","forks_url":"https://api.github.com/repos/webosose/meta-agl-lge/forks","keys_url":"https://api.github.com/repos/webosose/meta-agl-lge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webosose/meta-agl-lge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webosose/meta-agl-lge/teams","hooks_url":"https://api.github.com/repos/webosose/meta-agl-lge/hooks","issue_events_url":"https://api.github.com/repos/webosose/meta-agl-lge/issues/events{/number}","events_url":"https://api.github.com/repos/webosose/meta-agl-lge/events","assignees_url":"https://api.github.com/repos/webosose/meta-agl-lge/assignees{/user}","branches_url":"https://api.github.com/repos/webosose/meta-agl-lge/branches{/branch}","tags_url":"https://api.github.com/repos/webosose/meta-agl-lge/tags","blobs_url":"https://api.github.com/repos/webosose/meta-agl-lge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webosose/meta-agl-lge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webosose/meta-agl-lge/git/refs{/sha}","trees_url":"https://api.github.com/repos/webosose/meta-agl-lge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webosose/meta-agl-lge/statuses/{sha}","languages_url":"https://api.github.com/repos/webosose/meta-agl-lge/languages","stargazers_url":"https://api.github.com/repos/webosose/meta-agl-lge/stargazers","contributors_url":"https://api.github.com/repos/webosose/meta-agl-lge/contributors","subscribers_url":"https://api.github.com/repos/webosose/meta-agl-lge/subscribers","subscription_url":"https://api.github.com/repos/webosose/meta-agl-lge/subscription","commits_url":"https://api.github.com/repos/webosose/meta-agl-lge/commits{/sha}","git_commits_url":"https://api.github.com/repos/webosose/meta-agl-lge/git/commits{/sha}","comments_url":"https://api.github.com/repos/webosose/meta-agl-lge/comments{/number}","issue_comment_url":"https://api.github.com/repos/webosose/meta-agl-lge/issues/comments{/number}","contents_url":"https://api.github.com/repos/webosose/meta-agl-lge/contents/{+path}","compare_url":"https://api.github.com/repos/webosose/meta-agl-lge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webosose/meta-agl-lge/merges","archive_url":"https://api.github.com/repos/webosose/meta-agl-lge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webosose/meta-agl-lge/downloads","issues_url":"https://api.github.com/repos/webosose/meta-agl-lge/issues{/number}","pulls_url":"https://api.github.com/repos/webosose/meta-agl-lge/pulls{/number}","milestones_url":"https://api.github.com/repos/webosose/meta-agl-lge/milestones{/number}","notifications_url":"https://api.github.com/repos/webosose/meta-agl-lge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webosose/meta-agl-lge/labels{/name}","releases_url":"https://api.github.com/repos/webosose/meta-agl-lge/releases{/id}","deployments_url":"https://api.github.com/repos/webosose/meta-agl-lge/deployments","created_at":"2018-05-04T13:53:34Z","updated_at":"2018-10-30T09:39:01Z","pushed_at":"2018-10-30T11:37:51Z","git_url":"git://github.com/webosose/meta-agl-lge.git","ssh_url":"[email protected]:webosose/meta-agl-lge.git","clone_url":"https://github.com/webosose/meta-agl-lge.git","svn_url":"https://github.com/webosose/meta-agl-lge","homepage":null,"size":7294,"stargazers_count":0,"watchers_count":0,"language":"BitBake","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/9"},"html":{"href":"https://github.com/webosose/meta-agl-lge/pull/9"},"issue":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/issues/9"},"comments":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/webosose/meta-agl-lge/statuses/434ffe828595195e2d84557bd42a85f1c3013533"}},"author_association":"CONTRIBUTOR"}}

8504409193

{"actor":{"display_login":"jdapena"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/nknorg/nkn/pulls/comments/216623981","pull_request_review_id":154145820,"id":216623981,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjYyMzk4MQ==","diff_hunk":"@@ -0,0 +1,78 @@\n+package payload\n+\n+import (\n+\t\"encoding/json\"\n+\t\"io\"\n+\n+\t\"github.com/nknorg/nkn/common/serialization\"\n+\t\"github.com/nknorg/nkn/crypto\"\n+\t. \"github.com/nknorg/nkn/errors\"\n+)\n+\n+type RegisterName struct {\n+\tRegistrant *crypto.PubKey","path":"core/transaction/payload/RegisterName.go","position":13,"original_position":13,"commit_id":"073957ca89427c748ec10b38ef84e0d8c810eb40","original_commit_id":"073957ca89427c748ec10b38ef84e0d8c810eb40","user":{"login":"doraemon0","id":34739393,"node_id":"MDQ6VXNlcjM0NzM5Mzkz","avatar_url":"https://avatars0.githubusercontent.com/u/34739393?v=4","gravatar_id":"","url":"https://api.github.com/users/doraemon0","html_url":"https://github.com/doraemon0","followers_url":"https://api.github.com/users/doraemon0/followers","following_url":"https://api.github.com/users/doraemon0/following{/other_user}","gists_url":"https://api.github.com/users/doraemon0/gists{/gist_id}","starred_url":"https://api.github.com/users/doraemon0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doraemon0/subscriptions","organizations_url":"https://api.github.com/users/doraemon0/orgs","repos_url":"https://api.github.com/users/doraemon0/repos","events_url":"https://api.github.com/users/doraemon0/events{/privacy}","received_events_url":"https://api.github.com/users/doraemon0/received_events","type":"User","site_admin":false},"body":"How about encoded public key?","created_at":"2018-09-11T10:44:28Z","updated_at":"2018-09-11T10:44:28Z","html_url":"https://github.com/nknorg/nkn/pull/272#discussion_r216623981","pull_request_url":"https://api.github.com/repos/nknorg/nkn/pulls/272","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nknorg/nkn/pulls/comments/216623981"},"html":{"href":"https://github.com/nknorg/nkn/pull/272#discussion_r216623981"},"pull_request":{"href":"https://api.github.com/repos/nknorg/nkn/pulls/272"}},"in_reply_to_id":216531562},"pull_request":{"url":"https://api.github.com/repos/nknorg/nkn/pulls/272","id":214063726,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MDYzNzI2","html_url":"https://github.com/nknorg/nkn/pull/272","diff_url":"https://github.com/nknorg/nkn/pull/272.diff","patch_url":"https://github.com/nknorg/nkn/pull/272.patch","issue_url":"https://api.github.com/repos/nknorg/nkn/issues/272","number":272,"state":"open","locked":false,"title":"WIP: Name Service","user":{"login":"trueinsider","id":662644,"node_id":"MDQ6VXNlcjY2MjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/662644?v=4","gravatar_id":"","url":"https://api.github.com/users/trueinsider","html_url":"https://github.com/trueinsider","followers_url":"https://api.github.com/users/trueinsider/followers","following_url":"https://api.github.com/users/trueinsider/following{/other_user}","gists_url":"https://api.github.com/users/trueinsider/gists{/gist_id}","starred_url":"https://api.github.com/users/trueinsider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueinsider/subscriptions","organizations_url":"https://api.github.com/users/trueinsider/orgs","repos_url":"https://api.github.com/users/trueinsider/repos","events_url":"https://api.github.com/users/trueinsider/events{/privacy}","received_events_url":"https://api.github.com/users/trueinsider/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Nikolai Perevozchikov <[email protected]>\r\n\r\n### Proposed changes in this pull request\r\nTo be able to use easy-to-remeber addresses instead of public keys when sending messages I propose name service where anyone can register simple name for their public key.\r\n\r\n### Type\r\n- [ ] Bug fix: Link to the issue\r\n- [x] Feature (Non-breaking change)\r\n- [ ] Feature (Breaking change)\r\n- [ ] Documentation Improvement\r\n\r\n### Checklist\r\n- [x] Read the [CONTRIBUTION guidelines](https://github.com/nknorg/nkn#contributing).\r\n- [ ] All the tests are passing after the introduction of new changes.\r\n- [ ] Added tests respective to the part of code I have written.\r\n- [ ] Added proper documentation where ever applicable (in code and README.md).\r\n- [ ] Code has been written according to [NKN-Golang-Style-Guide](https://github.com/nknorg/nkn/wiki/NKN-Golang-Style-Guide)\r\n\r\n### Extra information\r\n**TODO:**\r\n- [ ] Test\r\n- [ ] Name Restrictions (symbols that can be used, length)\r\n- [x] Only one name per public key\r\n- [x] Name should be unique (exist for only one public key at a time)\r\n- [ ] Transfer Name\r\n- [x] Delete Name\r\n- [ ] Owner Verification (only owner should be able to transfer or delete)","created_at":"2018-09-07T23:55:33Z","updated_at":"2018-09-11T10:44:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f37f2e3f739aba06bd4bfcaac20dbe85bb86424e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nknorg/nkn/pulls/272/commits","review_comments_url":"https://api.github.com/repos/nknorg/nkn/pulls/272/comments","review_comment_url":"https://api.github.com/repos/nknorg/nkn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nknorg/nkn/issues/272/comments","statuses_url":"https://api.github.com/repos/nknorg/nkn/statuses/073957ca89427c748ec10b38ef84e0d8c810eb40","head":{"label":"trueinsider:nameservice","ref":"nameservice","sha":"073957ca89427c748ec10b38ef84e0d8c810eb40","user":{"login":"trueinsider","id":662644,"node_id":"MDQ6VXNlcjY2MjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/662644?v=4","gravatar_id":"","url":"https://api.github.com/users/trueinsider","html_url":"https://github.com/trueinsider","followers_url":"https://api.github.com/users/trueinsider/followers","following_url":"https://api.github.com/users/trueinsider/following{/other_user}","gists_url":"https://api.github.com/users/trueinsider/gists{/gist_id}","starred_url":"https://api.github.com/users/trueinsider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueinsider/subscriptions","organizations_url":"https://api.github.com/users/trueinsider/orgs","repos_url":"https://api.github.com/users/trueinsider/repos","events_url":"https://api.github.com/users/trueinsider/events{/privacy}","received_events_url":"https://api.github.com/users/trueinsider/received_events","type":"User","site_admin":false},"repo":{"id":142361742,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzNjE3NDI=","name":"nkn","full_name":"trueinsider/nkn","owner":{"login":"trueinsider","id":662644,"node_id":"MDQ6VXNlcjY2MjY0NA==","avatar_url":"https://avatars3.githubusercontent.com/u/662644?v=4","gravatar_id":"","url":"https://api.github.com/users/trueinsider","html_url":"https://github.com/trueinsider","followers_url":"https://api.github.com/users/trueinsider/followers","following_url":"https://api.github.com/users/trueinsider/following{/other_user}","gists_url":"https://api.github.com/users/trueinsider/gists{/gist_id}","starred_url":"https://api.github.com/users/trueinsider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trueinsider/subscriptions","organizations_url":"https://api.github.com/users/trueinsider/orgs","repos_url":"https://api.github.com/users/trueinsider/repos","events_url":"https://api.github.com/users/trueinsider/events{/privacy}","received_events_url":"https://api.github.com/users/trueinsider/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trueinsider/nkn","description":"NKN blockchain system in Golang","fork":true,"url":"https://api.github.com/repos/trueinsider/nkn","forks_url":"https://api.github.com/repos/trueinsider/nkn/forks","keys_url":"https://api.github.com/repos/trueinsider/nkn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trueinsider/nkn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trueinsider/nkn/teams","hooks_url":"https://api.github.com/repos/trueinsider/nkn/hooks","issue_events_url":"https://api.github.com/repos/trueinsider/nkn/issues/events{/number}","events_url":"https://api.github.com/repos/trueinsider/nkn/events","assignees_url":"https://api.github.com/repos/trueinsider/nkn/assignees{/user}","branches_url":"https://api.github.com/repos/trueinsider/nkn/branches{/branch}","tags_url":"https://api.github.com/repos/trueinsider/nkn/tags","blobs_url":"https://api.github.com/repos/trueinsider/nkn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trueinsider/nkn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trueinsider/nkn/git/refs{/sha}","trees_url":"https://api.github.com/repos/trueinsider/nkn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trueinsider/nkn/statuses/{sha}","languages_url":"https://api.github.com/repos/trueinsider/nkn/languages","stargazers_url":"https://api.github.com/repos/trueinsider/nkn/stargazers","contributors_url":"https://api.github.com/repos/trueinsider/nkn/contributors","subscribers_url":"https://api.github.com/repos/trueinsider/nkn/subscribers","subscription_url":"https://api.github.com/repos/trueinsider/nkn/subscription","commits_url":"https://api.github.com/repos/trueinsider/nkn/commits{/sha}","git_commits_url":"https://api.github.com/repos/trueinsider/nkn/git/commits{/sha}","comments_url":"https://api.github.com/repos/trueinsider/nkn/comments{/number}","issue_comment_url":"https://api.github.com/repos/trueinsider/nkn/issues/comments{/number}","contents_url":"https://api.github.com/repos/trueinsider/nkn/contents/{+path}","compare_url":"https://api.github.com/repos/trueinsider/nkn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trueinsider/nkn/merges","archive_url":"https://api.github.com/repos/trueinsider/nkn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trueinsider/nkn/downloads","issues_url":"https://api.github.com/repos/trueinsider/nkn/issues{/number}","pulls_url":"https://api.github.com/repos/trueinsider/nkn/pulls{/number}","milestones_url":"https://api.github.com/repos/trueinsider/nkn/milestones{/number}","notifications_url":"https://api.github.com/repos/trueinsider/nkn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trueinsider/nkn/labels{/name}","releases_url":"https://api.github.com/repos/trueinsider/nkn/releases{/id}","deployments_url":"https://api.github.com/repos/trueinsider/nkn/deployments","created_at":"2018-07-25T22:55:05Z","updated_at":"2018-09-10T07:08:33Z","pushed_at":"2018-09-10T21:36:30Z","git_url":"git://github.com/trueinsider/nkn.git","ssh_url":"[email protected]:trueinsider/nkn.git","clone_url":"https://github.com/trueinsider/nkn.git","svn_url":"https://github.com/trueinsider/nkn","homepage":"https://www.nkn.org","size":2970,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nknorg:master","ref":"master","sha":"5074ff8cae3f48c525f85e10eb4a0d65b16b73b7","user":{"login":"nknorg","id":35023685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDIzNjg1","avatar_url":"https://avatars0.githubusercontent.com/u/35023685?v=4","gravatar_id":"","url":"https://api.github.com/users/nknorg","html_url":"https://github.com/nknorg","followers_url":"https://api.github.com/users/nknorg/followers","following_url":"https://api.github.com/users/nknorg/following{/other_user}","gists_url":"https://api.github.com/users/nknorg/gists{/gist_id}","starred_url":"https://api.github.com/users/nknorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknorg/subscriptions","organizations_url":"https://api.github.com/users/nknorg/orgs","repos_url":"https://api.github.com/users/nknorg/repos","events_url":"https://api.github.com/users/nknorg/events{/privacy}","received_events_url":"https://api.github.com/users/nknorg/received_events","type":"Organization","site_admin":false},"repo":{"id":119047243,"node_id":"MDEwOlJlcG9zaXRvcnkxMTkwNDcyNDM=","name":"nkn","full_name":"nknorg/nkn","owner":{"login":"nknorg","id":35023685,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MDIzNjg1","avatar_url":"https://avatars0.githubusercontent.com/u/35023685?v=4","gravatar_id":"","url":"https://api.github.com/users/nknorg","html_url":"https://github.com/nknorg","followers_url":"https://api.github.com/users/nknorg/followers","following_url":"https://api.github.com/users/nknorg/following{/other_user}","gists_url":"https://api.github.com/users/nknorg/gists{/gist_id}","starred_url":"https://api.github.com/users/nknorg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nknorg/subscriptions","organizations_url":"https://api.github.com/users/nknorg/orgs","repos_url":"https://api.github.com/users/nknorg/repos","events_url":"https://api.github.com/users/nknorg/events{/privacy}","received_events_url":"https://api.github.com/users/nknorg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nknorg/nkn","description":"NKN blockchain system in Golang","fork":false,"url":"https://api.github.com/repos/nknorg/nkn","forks_url":"https://api.github.com/repos/nknorg/nkn/forks","keys_url":"https://api.github.com/repos/nknorg/nkn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nknorg/nkn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nknorg/nkn/teams","hooks_url":"https://api.github.com/repos/nknorg/nkn/hooks","issue_events_url":"https://api.github.com/repos/nknorg/nkn/issues/events{/number}","events_url":"https://api.github.com/repos/nknorg/nkn/events","assignees_url":"https://api.github.com/repos/nknorg/nkn/assignees{/user}","branches_url":"https://api.github.com/repos/nknorg/nkn/branches{/branch}","tags_url":"https://api.github.com/repos/nknorg/nkn/tags","blobs_url":"https://api.github.com/repos/nknorg/nkn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nknorg/nkn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nknorg/nkn/git/refs{/sha}","trees_url":"https://api.github.com/repos/nknorg/nkn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nknorg/nkn/statuses/{sha}","languages_url":"https://api.github.com/repos/nknorg/nkn/languages","stargazers_url":"https://api.github.com/repos/nknorg/nkn/stargazers","contributors_url":"https://api.github.com/repos/nknorg/nkn/contributors","subscribers_url":"https://api.github.com/repos/nknorg/nkn/subscribers","subscription_url":"https://api.github.com/repos/nknorg/nkn/subscription","commits_url":"https://api.github.com/repos/nknorg/nkn/commits{/sha}","git_commits_url":"https://api.github.com/repos/nknorg/nkn/git/commits{/sha}","comments_url":"https://api.github.com/repos/nknorg/nkn/comments{/number}","issue_comment_url":"https://api.github.com/repos/nknorg/nkn/issues/comments{/number}","contents_url":"https://api.github.com/repos/nknorg/nkn/contents/{+path}","compare_url":"https://api.github.com/repos/nknorg/nkn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nknorg/nkn/merges","archive_url":"https://api.github.com/repos/nknorg/nkn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nknorg/nkn/downloads","issues_url":"https://api.github.com/repos/nknorg/nkn/issues{/number}","pulls_url":"https://api.github.com/repos/nknorg/nkn/pulls{/number}","milestones_url":"https://api.github.com/repos/nknorg/nkn/milestones{/number}","notifications_url":"https://api.github.com/repos/nknorg/nkn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nknorg/nkn/labels{/name}","releases_url":"https://api.github.com/repos/nknorg/nkn/releases{/id}","deployments_url":"https://api.github.com/repos/nknorg/nkn/deployments","created_at":"2018-01-26T12:07:15Z","updated_at":"2018-09-10T12:48:30Z","pushed_at":"2018-09-11T06:52:39Z","git_url":"git://github.com/nknorg/nkn.git","ssh_url":"[email protected]:nknorg/nkn.git","clone_url":"https://github.com/nknorg/nkn.git","svn_url":"https://github.com/nknorg/nkn","homepage":"https://www.nkn.org","size":2900,"stargazers_count":121,"watchers_count":121,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":61,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":61,"open_issues":21,"watchers":121,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nknorg/nkn/pulls/272"},"html":{"href":"https://github.com/nknorg/nkn/pull/272"},"issue":{"href":"https://api.github.com/repos/nknorg/nkn/issues/272"},"comments":{"href":"https://api.github.com/repos/nknorg/nkn/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/nknorg/nkn/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/nknorg/nkn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nknorg/nkn/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/nknorg/nkn/statuses/073957ca89427c748ec10b38ef84e0d8c810eb40"}},"author_association":"CONTRIBUTOR"}}

8245775376

{"actor":{"display_login":"doraemon0"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/comments/217631373","pull_request_review_id":155386099,"id":217631373,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzYzMTM3Mw==","diff_hunk":"@@ -33,19 +34,25 @@ describe('User service', () => {\n });\n \n it('should make correct request', async () => {\n+ expect.assertions(3);\n+\n mock.onPost(url).reply(config => {","path":"test/unit/specs/services/user.spec.js","position":16,"original_position":16,"commit_id":"499455bf5f38a06df002fc49a48471a9a5af3aaa","original_commit_id":"499455bf5f38a06df002fc49a48471a9a5af3aaa","user":{"login":"m-russkikh","id":28510049,"node_id":"MDQ6VXNlcjI4NTEwMDQ5","avatar_url":"https://avatars2.githubusercontent.com/u/28510049?v=4","gravatar_id":"","url":"https://api.github.com/users/m-russkikh","html_url":"https://github.com/m-russkikh","followers_url":"https://api.github.com/users/m-russkikh/followers","following_url":"https://api.github.com/users/m-russkikh/following{/other_user}","gists_url":"https://api.github.com/users/m-russkikh/gists{/gist_id}","starred_url":"https://api.github.com/users/m-russkikh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m-russkikh/subscriptions","organizations_url":"https://api.github.com/users/m-russkikh/orgs","repos_url":"https://api.github.com/users/m-russkikh/repos","events_url":"https://api.github.com/users/m-russkikh/events{/privacy}","received_events_url":"https://api.github.com/users/m-russkikh/received_events","type":"User","site_admin":false},"body":"тут возможно лучше поменять на mock.onAny. А то коллбек сработает только на Post запрос. Или проверка`expect(config.method).toBe('post');` в принципе лишняя. ","created_at":"2018-09-14T08:06:58Z","updated_at":"2018-09-14T08:15:52Z","html_url":"https://github.com/endpass/endpass-wallet/pull/227#discussion_r217631373","pull_request_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/227","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/comments/217631373"},"html":{"href":"https://github.com/endpass/endpass-wallet/pull/227#discussion_r217631373"},"pull_request":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/227"}}},"pull_request":{"url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/227","id":214682838,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NjgyODM4","html_url":"https://github.com/endpass/endpass-wallet/pull/227","diff_url":"https://github.com/endpass/endpass-wallet/pull/227.diff","patch_url":"https://github.com/endpass/endpass-wallet/pull/227.patch","issue_url":"https://api.github.com/repos/endpass/endpass-wallet/issues/227","number":227,"state":"open","locked":false,"title":"Add the redirect_uri parameter for user login","user":{"login":"kazurus","id":32077191,"node_id":"MDQ6VXNlcjMyMDc3MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/32077191?v=4","gravatar_id":"","url":"https://api.github.com/users/kazurus","html_url":"https://github.com/kazurus","followers_url":"https://api.github.com/users/kazurus/followers","following_url":"https://api.github.com/users/kazurus/following{/other_user}","gists_url":"https://api.github.com/users/kazurus/gists{/gist_id}","starred_url":"https://api.github.com/users/kazurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazurus/subscriptions","organizations_url":"https://api.github.com/users/kazurus/orgs","repos_url":"https://api.github.com/users/kazurus/repos","events_url":"https://api.github.com/users/kazurus/events{/privacy}","received_events_url":"https://api.github.com/users/kazurus/received_events","type":"User","site_admin":false},"body":"Add the redirect_uri parameter for user login","created_at":"2018-09-11T15:57:50Z","updated_at":"2018-09-14T08:15:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"32e270c895a075bf45aaf1ce11f45336af67d5ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/227/commits","review_comments_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/227/comments","review_comment_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/endpass/endpass-wallet/issues/227/comments","statuses_url":"https://api.github.com/repos/endpass/endpass-wallet/statuses/499455bf5f38a06df002fc49a48471a9a5af3aaa","head":{"label":"kazurus:improve/redirect-url","ref":"improve/redirect-url","sha":"499455bf5f38a06df002fc49a48471a9a5af3aaa","user":{"login":"kazurus","id":32077191,"node_id":"MDQ6VXNlcjMyMDc3MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/32077191?v=4","gravatar_id":"","url":"https://api.github.com/users/kazurus","html_url":"https://github.com/kazurus","followers_url":"https://api.github.com/users/kazurus/followers","following_url":"https://api.github.com/users/kazurus/following{/other_user}","gists_url":"https://api.github.com/users/kazurus/gists{/gist_id}","starred_url":"https://api.github.com/users/kazurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazurus/subscriptions","organizations_url":"https://api.github.com/users/kazurus/orgs","repos_url":"https://api.github.com/users/kazurus/repos","events_url":"https://api.github.com/users/kazurus/events{/privacy}","received_events_url":"https://api.github.com/users/kazurus/received_events","type":"User","site_admin":false},"repo":{"id":134812101,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ4MTIxMDE=","name":"endpass-wallet","full_name":"kazurus/endpass-wallet","owner":{"login":"kazurus","id":32077191,"node_id":"MDQ6VXNlcjMyMDc3MTkx","avatar_url":"https://avatars1.githubusercontent.com/u/32077191?v=4","gravatar_id":"","url":"https://api.github.com/users/kazurus","html_url":"https://github.com/kazurus","followers_url":"https://api.github.com/users/kazurus/followers","following_url":"https://api.github.com/users/kazurus/following{/other_user}","gists_url":"https://api.github.com/users/kazurus/gists{/gist_id}","starred_url":"https://api.github.com/users/kazurus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kazurus/subscriptions","organizations_url":"https://api.github.com/users/kazurus/orgs","repos_url":"https://api.github.com/users/kazurus/repos","events_url":"https://api.github.com/users/kazurus/events{/privacy}","received_events_url":"https://api.github.com/users/kazurus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kazurus/endpass-wallet","description":"Lightweight, easy to use Ethereum wallet","fork":true,"url":"https://api.github.com/repos/kazurus/endpass-wallet","forks_url":"https://api.github.com/repos/kazurus/endpass-wallet/forks","keys_url":"https://api.github.com/repos/kazurus/endpass-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kazurus/endpass-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kazurus/endpass-wallet/teams","hooks_url":"https://api.github.com/repos/kazurus/endpass-wallet/hooks","issue_events_url":"https://api.github.com/repos/kazurus/endpass-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/kazurus/endpass-wallet/events","assignees_url":"https://api.github.com/repos/kazurus/endpass-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/kazurus/endpass-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/kazurus/endpass-wallet/tags","blobs_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kazurus/endpass-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/kazurus/endpass-wallet/languages","stargazers_url":"https://api.github.com/repos/kazurus/endpass-wallet/stargazers","contributors_url":"https://api.github.com/repos/kazurus/endpass-wallet/contributors","subscribers_url":"https://api.github.com/repos/kazurus/endpass-wallet/subscribers","subscription_url":"https://api.github.com/repos/kazurus/endpass-wallet/subscription","commits_url":"https://api.github.com/repos/kazurus/endpass-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/kazurus/endpass-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/kazurus/endpass-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/kazurus/endpass-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/kazurus/endpass-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/kazurus/endpass-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kazurus/endpass-wallet/merges","archive_url":"https://api.github.com/repos/kazurus/endpass-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kazurus/endpass-wallet/downloads","issues_url":"https://api.github.com/repos/kazurus/endpass-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/kazurus/endpass-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/kazurus/endpass-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/kazurus/endpass-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kazurus/endpass-wallet/labels{/name}","releases_url":"https://api.github.com/repos/kazurus/endpass-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/kazurus/endpass-wallet/deployments","created_at":"2018-05-25T06:18:48Z","updated_at":"2018-09-13T12:41:35Z","pushed_at":"2018-09-13T20:16:10Z","git_url":"git://github.com/kazurus/endpass-wallet.git","ssh_url":"[email protected]:kazurus/endpass-wallet.git","clone_url":"https://github.com/kazurus/endpass-wallet.git","svn_url":"https://github.com/kazurus/endpass-wallet","homepage":null,"size":6920,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"endpass:master","ref":"master","sha":"273af3131f4dfa77f8123a2f5bf899328d91c4e2","user":{"login":"endpass","id":35308615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzA4NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/35308615?v=4","gravatar_id":"","url":"https://api.github.com/users/endpass","html_url":"https://github.com/endpass","followers_url":"https://api.github.com/users/endpass/followers","following_url":"https://api.github.com/users/endpass/following{/other_user}","gists_url":"https://api.github.com/users/endpass/gists{/gist_id}","starred_url":"https://api.github.com/users/endpass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endpass/subscriptions","organizations_url":"https://api.github.com/users/endpass/orgs","repos_url":"https://api.github.com/users/endpass/repos","events_url":"https://api.github.com/users/endpass/events{/privacy}","received_events_url":"https://api.github.com/users/endpass/received_events","type":"Organization","site_admin":false},"repo":{"id":128846976,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4NDY5NzY=","name":"endpass-wallet","full_name":"endpass/endpass-wallet","owner":{"login":"endpass","id":35308615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzA4NjE1","avatar_url":"https://avatars3.githubusercontent.com/u/35308615?v=4","gravatar_id":"","url":"https://api.github.com/users/endpass","html_url":"https://github.com/endpass","followers_url":"https://api.github.com/users/endpass/followers","following_url":"https://api.github.com/users/endpass/following{/other_user}","gists_url":"https://api.github.com/users/endpass/gists{/gist_id}","starred_url":"https://api.github.com/users/endpass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/endpass/subscriptions","organizations_url":"https://api.github.com/users/endpass/orgs","repos_url":"https://api.github.com/users/endpass/repos","events_url":"https://api.github.com/users/endpass/events{/privacy}","received_events_url":"https://api.github.com/users/endpass/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/endpass/endpass-wallet","description":"Lightweight, easy to use Ethereum wallet","fork":false,"url":"https://api.github.com/repos/endpass/endpass-wallet","forks_url":"https://api.github.com/repos/endpass/endpass-wallet/forks","keys_url":"https://api.github.com/repos/endpass/endpass-wallet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/endpass/endpass-wallet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/endpass/endpass-wallet/teams","hooks_url":"https://api.github.com/repos/endpass/endpass-wallet/hooks","issue_events_url":"https://api.github.com/repos/endpass/endpass-wallet/issues/events{/number}","events_url":"https://api.github.com/repos/endpass/endpass-wallet/events","assignees_url":"https://api.github.com/repos/endpass/endpass-wallet/assignees{/user}","branches_url":"https://api.github.com/repos/endpass/endpass-wallet/branches{/branch}","tags_url":"https://api.github.com/repos/endpass/endpass-wallet/tags","blobs_url":"https://api.github.com/repos/endpass/endpass-wallet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/endpass/endpass-wallet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/endpass/endpass-wallet/git/refs{/sha}","trees_url":"https://api.github.com/repos/endpass/endpass-wallet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/endpass/endpass-wallet/statuses/{sha}","languages_url":"https://api.github.com/repos/endpass/endpass-wallet/languages","stargazers_url":"https://api.github.com/repos/endpass/endpass-wallet/stargazers","contributors_url":"https://api.github.com/repos/endpass/endpass-wallet/contributors","subscribers_url":"https://api.github.com/repos/endpass/endpass-wallet/subscribers","subscription_url":"https://api.github.com/repos/endpass/endpass-wallet/subscription","commits_url":"https://api.github.com/repos/endpass/endpass-wallet/commits{/sha}","git_commits_url":"https://api.github.com/repos/endpass/endpass-wallet/git/commits{/sha}","comments_url":"https://api.github.com/repos/endpass/endpass-wallet/comments{/number}","issue_comment_url":"https://api.github.com/repos/endpass/endpass-wallet/issues/comments{/number}","contents_url":"https://api.github.com/repos/endpass/endpass-wallet/contents/{+path}","compare_url":"https://api.github.com/repos/endpass/endpass-wallet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/endpass/endpass-wallet/merges","archive_url":"https://api.github.com/repos/endpass/endpass-wallet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/endpass/endpass-wallet/downloads","issues_url":"https://api.github.com/repos/endpass/endpass-wallet/issues{/number}","pulls_url":"https://api.github.com/repos/endpass/endpass-wallet/pulls{/number}","milestones_url":"https://api.github.com/repos/endpass/endpass-wallet/milestones{/number}","notifications_url":"https://api.github.com/repos/endpass/endpass-wallet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/endpass/endpass-wallet/labels{/name}","releases_url":"https://api.github.com/repos/endpass/endpass-wallet/releases{/id}","deployments_url":"https://api.github.com/repos/endpass/endpass-wallet/deployments","created_at":"2018-04-09T23:50:15Z","updated_at":"2018-09-13T12:40:50Z","pushed_at":"2018-09-14T07:41:49Z","git_url":"git://github.com/endpass/endpass-wallet.git","ssh_url":"[email protected]:endpass/endpass-wallet.git","clone_url":"https://github.com/endpass/endpass-wallet.git","svn_url":"https://github.com/endpass/endpass-wallet","homepage":"https://wallet.endpass.com","size":6837,"stargazers_count":4,"watchers_count":4,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":6,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/227"},"html":{"href":"https://github.com/endpass/endpass-wallet/pull/227"},"issue":{"href":"https://api.github.com/repos/endpass/endpass-wallet/issues/227"},"comments":{"href":"https://api.github.com/repos/endpass/endpass-wallet/issues/227/comments"},"review_comments":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/227/comments"},"review_comment":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/endpass/endpass-wallet/pulls/227/commits"},"statuses":{"href":"https://api.github.com/repos/endpass/endpass-wallet/statuses/499455bf5f38a06df002fc49a48471a9a5af3aaa"}},"author_association":"COLLABORATOR"}}

8264566889

{"actor":{"display_login":"m-russkikh"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/comments/208635871","pull_request_review_id":144486303,"id":208635871,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODYzNTg3MQ==","diff_hunk":"@@ -129,12 +129,13 @@ class ByInteraction : public EnablePolymorphicObject<ByInteraction, Criterion> {\n void run_solver(volatile bool *stop_iteration_process,\n std::shared_ptr<gko::Executor> exec)\n {\n+ // Some shortcuts\n using mtx = gko::matrix::Csr<>;\n using vec = gko::matrix::Dense<>;\n using bicg = gko::solver::Bicgstab<>;\n \n // Read Data\n- auto A = gko::share(gko::read<mtx>(std::ifstream(\"data/A.mtx\"), exec));\n+ auto A = share(gko::read<mtx>(std::ifstream(\"data/A.mtx\"), exec));","path":"examples/asynchronous_stopping_criterion/asynchronous_stopping_criterion.cpp","position":11,"original_position":11,"commit_id":"992b0f3f3ca22aaed17152013d16e4480e6326e5","original_commit_id":"992b0f3f3ca22aaed17152013d16e4480e6326e5","user":{"login":"tcojean","id":35342290,"node_id":"MDQ6VXNlcjM1MzQyMjkw","avatar_url":"https://avatars1.githubusercontent.com/u/35342290?v=4","gravatar_id":"","url":"https://api.github.com/users/tcojean","html_url":"https://github.com/tcojean","followers_url":"https://api.github.com/users/tcojean/followers","following_url":"https://api.github.com/users/tcojean/following{/other_user}","gists_url":"https://api.github.com/users/tcojean/gists{/gist_id}","starred_url":"https://api.github.com/users/tcojean/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tcojean/subscriptions","organizations_url":"https://api.github.com/users/tcojean/orgs","repos_url":"https://api.github.com/users/tcojean/repos","events_url":"https://api.github.com/users/tcojean/events{/privacy}","received_events_url":"https://api.github.com/users/tcojean/received_events","type":"User","site_admin":false},"body":"Ah I see. Though that means that unlike before, we may have multiple choice for those functions. Is it a good idea to show users that? What if they have their own `share` laying somewhere in their code?","created_at":"2018-08-08T15:50:52Z","updated_at":"2018-08-08T15:50:53Z","html_url":"https://github.com/ginkgo-project/ginkgo/pull/98#discussion_r208635871","pull_request_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/98","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/comments/208635871"},"html":{"href":"https://github.com/ginkgo-project/ginkgo/pull/98#discussion_r208635871"},"pull_request":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/98"}},"in_reply_to_id":208629642},"pull_request":{"url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/98","id":206056071,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDU2MDcx","html_url":"https://github.com/ginkgo-project/ginkgo/pull/98","diff_url":"https://github.com/ginkgo-project/ginkgo/pull/98.diff","patch_url":"https://github.com/ginkgo-project/ginkgo/pull/98.patch","issue_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/98","number":98,"state":"open","locked":false,"title":"Matrix market writer","user":{"login":"gflegar","id":1261711,"node_id":"MDQ6VXNlcjEyNjE3MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1261711?v=4","gravatar_id":"","url":"https://api.github.com/users/gflegar","html_url":"https://github.com/gflegar","followers_url":"https://api.github.com/users/gflegar/followers","following_url":"https://api.github.com/users/gflegar/following{/other_user}","gists_url":"https://api.github.com/users/gflegar/gists{/gist_id}","starred_url":"https://api.github.com/users/gflegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gflegar/subscriptions","organizations_url":"https://api.github.com/users/gflegar/orgs","repos_url":"https://api.github.com/users/gflegar/repos","events_url":"https://api.github.com/users/gflegar/events{/privacy}","received_events_url":"https://api.github.com/users/gflegar/received_events","type":"User","site_admin":false},"body":"This PR adds functions for writing matrices to streams in matrix market format.\r\nThe current implementation supports both `array` and `coordinate` layouts, but does not support modifiers (symmetric, hermitian, etc.), and only the `real` and `complex` value types (`integer` and `pattern` are not supported).\r\n\r\nThe examples have also been modified to use these functions instead of writing out the vectors by hand.\r\n\r\nSince the name `mtx_reader` doesn't make much sense if it can also write data the header has been renamed to `mtx_io`.","created_at":"2018-08-03T14:57:31Z","updated_at":"2018-08-08T15:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f69aaa1c4252aa9378e1a1cf6cc277aa1a5a3dd2","assignee":{"login":"gflegar","id":1261711,"node_id":"MDQ6VXNlcjEyNjE3MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1261711?v=4","gravatar_id":"","url":"https://api.github.com/users/gflegar","html_url":"https://github.com/gflegar","followers_url":"https://api.github.com/users/gflegar/followers","following_url":"https://api.github.com/users/gflegar/following{/other_user}","gists_url":"https://api.github.com/users/gflegar/gists{/gist_id}","starred_url":"https://api.github.com/users/gflegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gflegar/subscriptions","organizations_url":"https://api.github.com/users/gflegar/orgs","repos_url":"https://api.github.com/users/gflegar/repos","events_url":"https://api.github.com/users/gflegar/events{/privacy}","received_events_url":"https://api.github.com/users/gflegar/received_events","type":"User","site_admin":false},"assignees":[{"login":"gflegar","id":1261711,"node_id":"MDQ6VXNlcjEyNjE3MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1261711?v=4","gravatar_id":"","url":"https://api.github.com/users/gflegar","html_url":"https://github.com/gflegar","followers_url":"https://api.github.com/users/gflegar/followers","following_url":"https://api.github.com/users/gflegar/following{/other_user}","gists_url":"https://api.github.com/users/gflegar/gists{/gist_id}","starred_url":"https://api.github.com/users/gflegar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gflegar/subscriptions","organizations_url":"https://api.github.com/users/gflegar/orgs","repos_url":"https://api.github.com/users/gflegar/repos","events_url":"https://api.github.com/users/gflegar/events{/privacy}","received_events_url":"https://api.github.com/users/gflegar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":978495766,"node_id":"MDU6TGFiZWw5Nzg0OTU3NjY=","url":"https://api.github.com/repos/ginkgo-project/ginkgo/labels/Core","name":"Core","color":"ECC832","default":false},{"id":830146004,"node_id":"MDU6TGFiZWw4MzAxNDYwMDQ=","url":"https://api.github.com/repos/ginkgo-project/ginkgo/labels/Task","name":"Task","color":"0033CC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/98/commits","review_comments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/98/comments","review_comment_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/98/comments","statuses_url":"https://api.github.com/repos/ginkgo-project/ginkgo/statuses/992b0f3f3ca22aaed17152013d16e4480e6326e5","head":{"label":"ginkgo-project:mtx_writer","ref":"mtx_writer","sha":"992b0f3f3ca22aaed17152013d16e4480e6326e5","user":{"login":"ginkgo-project","id":35341738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQxNzM4","avatar_url":"https://avatars2.githubusercontent.com/u/35341738?v=4","gravatar_id":"","url":"https://api.github.com/users/ginkgo-project","html_url":"https://github.com/ginkgo-project","followers_url":"https://api.github.com/users/ginkgo-project/followers","following_url":"https://api.github.com/users/ginkgo-project/following{/other_user}","gists_url":"https://api.github.com/users/ginkgo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ginkgo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginkgo-project/subscriptions","organizations_url":"https://api.github.com/users/ginkgo-project/orgs","repos_url":"https://api.github.com/users/ginkgo-project/repos","events_url":"https://api.github.com/users/ginkgo-project/events{/privacy}","received_events_url":"https://api.github.com/users/ginkgo-project/received_events","type":"Organization","site_admin":false},"repo":{"id":117122510,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMjI1MTA=","name":"ginkgo","full_name":"ginkgo-project/ginkgo","owner":{"login":"ginkgo-project","id":35341738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQxNzM4","avatar_url":"https://avatars2.githubusercontent.com/u/35341738?v=4","gravatar_id":"","url":"https://api.github.com/users/ginkgo-project","html_url":"https://github.com/ginkgo-project","followers_url":"https://api.github.com/users/ginkgo-project/followers","following_url":"https://api.github.com/users/ginkgo-project/following{/other_user}","gists_url":"https://api.github.com/users/ginkgo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ginkgo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginkgo-project/subscriptions","organizations_url":"https://api.github.com/users/ginkgo-project/orgs","repos_url":"https://api.github.com/users/ginkgo-project/repos","events_url":"https://api.github.com/users/ginkgo-project/events{/privacy}","received_events_url":"https://api.github.com/users/ginkgo-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ginkgo-project/ginkgo","description":"Numerical linear algebra software package","fork":false,"url":"https://api.github.com/repos/ginkgo-project/ginkgo","forks_url":"https://api.github.com/repos/ginkgo-project/ginkgo/forks","keys_url":"https://api.github.com/repos/ginkgo-project/ginkgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ginkgo-project/ginkgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ginkgo-project/ginkgo/teams","hooks_url":"https://api.github.com/repos/ginkgo-project/ginkgo/hooks","issue_events_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/events{/number}","events_url":"https://api.github.com/repos/ginkgo-project/ginkgo/events","assignees_url":"https://api.github.com/repos/ginkgo-project/ginkgo/assignees{/user}","branches_url":"https://api.github.com/repos/ginkgo-project/ginkgo/branches{/branch}","tags_url":"https://api.github.com/repos/ginkgo-project/ginkgo/tags","blobs_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ginkgo-project/ginkgo/statuses/{sha}","languages_url":"https://api.github.com/repos/ginkgo-project/ginkgo/languages","stargazers_url":"https://api.github.com/repos/ginkgo-project/ginkgo/stargazers","contributors_url":"https://api.github.com/repos/ginkgo-project/ginkgo/contributors","subscribers_url":"https://api.github.com/repos/ginkgo-project/ginkgo/subscribers","subscription_url":"https://api.github.com/repos/ginkgo-project/ginkgo/subscription","commits_url":"https://api.github.com/repos/ginkgo-project/ginkgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ginkgo-project/ginkgo/contents/{+path}","compare_url":"https://api.github.com/repos/ginkgo-project/ginkgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ginkgo-project/ginkgo/merges","archive_url":"https://api.github.com/repos/ginkgo-project/ginkgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ginkgo-project/ginkgo/downloads","issues_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues{/number}","pulls_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls{/number}","milestones_url":"https://api.github.com/repos/ginkgo-project/ginkgo/milestones{/number}","notifications_url":"https://api.github.com/repos/ginkgo-project/ginkgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ginkgo-project/ginkgo/labels{/name}","releases_url":"https://api.github.com/repos/ginkgo-project/ginkgo/releases{/id}","deployments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/deployments","created_at":"2018-01-11T16:14:21Z","updated_at":"2018-08-06T16:35:01Z","pushed_at":"2018-08-07T08:41:45Z","git_url":"git://github.com/ginkgo-project/ginkgo.git","ssh_url":"[email protected]:ginkgo-project/ginkgo.git","clone_url":"https://github.com/ginkgo-project/ginkgo.git","svn_url":"https://github.com/ginkgo-project/ginkgo","homepage":null,"size":3258,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":27,"watchers":7,"default_branch":"develop"}},"base":{"label":"ginkgo-project:develop","ref":"develop","sha":"9e6da9f054abce20bf338eab4c8145d2bbbae36a","user":{"login":"ginkgo-project","id":35341738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQxNzM4","avatar_url":"https://avatars2.githubusercontent.com/u/35341738?v=4","gravatar_id":"","url":"https://api.github.com/users/ginkgo-project","html_url":"https://github.com/ginkgo-project","followers_url":"https://api.github.com/users/ginkgo-project/followers","following_url":"https://api.github.com/users/ginkgo-project/following{/other_user}","gists_url":"https://api.github.com/users/ginkgo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ginkgo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginkgo-project/subscriptions","organizations_url":"https://api.github.com/users/ginkgo-project/orgs","repos_url":"https://api.github.com/users/ginkgo-project/repos","events_url":"https://api.github.com/users/ginkgo-project/events{/privacy}","received_events_url":"https://api.github.com/users/ginkgo-project/received_events","type":"Organization","site_admin":false},"repo":{"id":117122510,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxMjI1MTA=","name":"ginkgo","full_name":"ginkgo-project/ginkgo","owner":{"login":"ginkgo-project","id":35341738,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQxNzM4","avatar_url":"https://avatars2.githubusercontent.com/u/35341738?v=4","gravatar_id":"","url":"https://api.github.com/users/ginkgo-project","html_url":"https://github.com/ginkgo-project","followers_url":"https://api.github.com/users/ginkgo-project/followers","following_url":"https://api.github.com/users/ginkgo-project/following{/other_user}","gists_url":"https://api.github.com/users/ginkgo-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ginkgo-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ginkgo-project/subscriptions","organizations_url":"https://api.github.com/users/ginkgo-project/orgs","repos_url":"https://api.github.com/users/ginkgo-project/repos","events_url":"https://api.github.com/users/ginkgo-project/events{/privacy}","received_events_url":"https://api.github.com/users/ginkgo-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ginkgo-project/ginkgo","description":"Numerical linear algebra software package","fork":false,"url":"https://api.github.com/repos/ginkgo-project/ginkgo","forks_url":"https://api.github.com/repos/ginkgo-project/ginkgo/forks","keys_url":"https://api.github.com/repos/ginkgo-project/ginkgo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ginkgo-project/ginkgo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ginkgo-project/ginkgo/teams","hooks_url":"https://api.github.com/repos/ginkgo-project/ginkgo/hooks","issue_events_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/events{/number}","events_url":"https://api.github.com/repos/ginkgo-project/ginkgo/events","assignees_url":"https://api.github.com/repos/ginkgo-project/ginkgo/assignees{/user}","branches_url":"https://api.github.com/repos/ginkgo-project/ginkgo/branches{/branch}","tags_url":"https://api.github.com/repos/ginkgo-project/ginkgo/tags","blobs_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/refs{/sha}","trees_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ginkgo-project/ginkgo/statuses/{sha}","languages_url":"https://api.github.com/repos/ginkgo-project/ginkgo/languages","stargazers_url":"https://api.github.com/repos/ginkgo-project/ginkgo/stargazers","contributors_url":"https://api.github.com/repos/ginkgo-project/ginkgo/contributors","subscribers_url":"https://api.github.com/repos/ginkgo-project/ginkgo/subscribers","subscription_url":"https://api.github.com/repos/ginkgo-project/ginkgo/subscription","commits_url":"https://api.github.com/repos/ginkgo-project/ginkgo/commits{/sha}","git_commits_url":"https://api.github.com/repos/ginkgo-project/ginkgo/git/commits{/sha}","comments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/comments{/number}","issue_comment_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/comments{/number}","contents_url":"https://api.github.com/repos/ginkgo-project/ginkgo/contents/{+path}","compare_url":"https://api.github.com/repos/ginkgo-project/ginkgo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ginkgo-project/ginkgo/merges","archive_url":"https://api.github.com/repos/ginkgo-project/ginkgo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ginkgo-project/ginkgo/downloads","issues_url":"https://api.github.com/repos/ginkgo-project/ginkgo/issues{/number}","pulls_url":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls{/number}","milestones_url":"https://api.github.com/repos/ginkgo-project/ginkgo/milestones{/number}","notifications_url":"https://api.github.com/repos/ginkgo-project/ginkgo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ginkgo-project/ginkgo/labels{/name}","releases_url":"https://api.github.com/repos/ginkgo-project/ginkgo/releases{/id}","deployments_url":"https://api.github.com/repos/ginkgo-project/ginkgo/deployments","created_at":"2018-01-11T16:14:21Z","updated_at":"2018-08-06T16:35:01Z","pushed_at":"2018-08-07T08:41:45Z","git_url":"git://github.com/ginkgo-project/ginkgo.git","ssh_url":"[email protected]:ginkgo-project/ginkgo.git","clone_url":"https://github.com/ginkgo-project/ginkgo.git","svn_url":"https://github.com/ginkgo-project/ginkgo","homepage":null,"size":3258,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":27,"watchers":7,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/98"},"html":{"href":"https://github.com/ginkgo-project/ginkgo/pull/98"},"issue":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/98"},"comments":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/ginkgo-project/ginkgo/statuses/992b0f3f3ca22aaed17152013d16e4480e6326e5"}},"author_association":"MEMBER"}}

8084877944

{"actor":{"display_login":"tcojean"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/XDagger/xdag/pulls/comments/200833320","pull_request_review_id":135225920,"id":200833320,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDgzMzMyMA==","diff_hunk":"@@ -95,13 +105,21 @@ static pthread_mutex_t block_mutex;\n //TODO: this variable duplicates existing global variable g_is_pool. Probably should be removed\n static int g_light_mode = 0;\n static uint32_t cache_bounded_counter = 0;\n+static struct orphan_block **orphan_hashtable = NULL;","path":"client/block.c","position":32,"original_position":32,"commit_id":"cb5539b02552b245e11f870f461693d1cc58f98d","original_commit_id":"cb5539b02552b245e11f870f461693d1cc58f98d","user":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"body":"Every block related variable in block.c isn't named as global","created_at":"2018-07-08T08:32:38Z","updated_at":"2018-07-08T08:32:38Z","html_url":"https://github.com/XDagger/xdag/pull/247#discussion_r200833320","pull_request_url":"https://api.github.com/repos/XDagger/xdag/pulls/247","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/comments/200833320"},"html":{"href":"https://github.com/XDagger/xdag/pull/247#discussion_r200833320"},"pull_request":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/247"}},"in_reply_to_id":200832562},"pull_request":{"url":"https://api.github.com/repos/XDagger/xdag/pulls/247","id":199554398,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NTU0Mzk4","html_url":"https://github.com/XDagger/xdag/pull/247","diff_url":"https://github.com/XDagger/xdag/pull/247.diff","patch_url":"https://github.com/XDagger/xdag/pull/247.patch","issue_url":"https://api.github.com/repos/XDagger/xdag/issues/247","number":247,"state":"open","locked":false,"title":"Handle orphans with hashtable instead of list","user":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"body":"Loading from disk speedup should be around 300/400%\r\n","created_at":"2018-07-05T18:38:14Z","updated_at":"2018-07-08T08:32:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1996da70e129d14a4073b9e2f032719b295a8d5a","assignee":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"assignees":[{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":975124383,"node_id":"MDU6TGFiZWw5NzUxMjQzODM=","url":"https://api.github.com/repos/XDagger/xdag/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/XDagger/xdag/pulls/247/commits","review_comments_url":"https://api.github.com/repos/XDagger/xdag/pulls/247/comments","review_comment_url":"https://api.github.com/repos/XDagger/xdag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/XDagger/xdag/issues/247/comments","statuses_url":"https://api.github.com/repos/XDagger/xdag/statuses/cb5539b02552b245e11f870f461693d1cc58f98d","head":{"label":"sgaragagghu:orphanHT","ref":"orphanHT","sha":"cb5539b02552b245e11f870f461693d1cc58f98d","user":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"repo":{"id":128134063,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgxMzQwNjM=","name":"xdag-commented","full_name":"sgaragagghu/xdag-commented","owner":{"login":"sgaragagghu","id":14251422,"node_id":"MDQ6VXNlcjE0MjUxNDIy","avatar_url":"https://avatars1.githubusercontent.com/u/14251422?v=4","gravatar_id":"","url":"https://api.github.com/users/sgaragagghu","html_url":"https://github.com/sgaragagghu","followers_url":"https://api.github.com/users/sgaragagghu/followers","following_url":"https://api.github.com/users/sgaragagghu/following{/other_user}","gists_url":"https://api.github.com/users/sgaragagghu/gists{/gist_id}","starred_url":"https://api.github.com/users/sgaragagghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgaragagghu/subscriptions","organizations_url":"https://api.github.com/users/sgaragagghu/orgs","repos_url":"https://api.github.com/users/sgaragagghu/repos","events_url":"https://api.github.com/users/sgaragagghu/events{/privacy}","received_events_url":"https://api.github.com/users/sgaragagghu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sgaragagghu/xdag-commented","description":"XDAG Cryptocurrency COMMENTED REPOSITORY","fork":true,"url":"https://api.github.com/repos/sgaragagghu/xdag-commented","forks_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/forks","keys_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/teams","hooks_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/hooks","issue_events_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/issues/events{/number}","events_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/events","assignees_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/assignees{/user}","branches_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/branches{/branch}","tags_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/tags","blobs_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/refs{/sha}","trees_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/statuses/{sha}","languages_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/languages","stargazers_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/stargazers","contributors_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/contributors","subscribers_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/subscribers","subscription_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/subscription","commits_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/commits{/sha}","git_commits_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/git/commits{/sha}","comments_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/comments{/number}","issue_comment_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/issues/comments{/number}","contents_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/contents/{+path}","compare_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/merges","archive_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/downloads","issues_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/issues{/number}","pulls_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/pulls{/number}","milestones_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/milestones{/number}","notifications_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/labels{/name}","releases_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/releases{/id}","deployments_url":"https://api.github.com/repos/sgaragagghu/xdag-commented/deployments","created_at":"2018-04-04T23:21:48Z","updated_at":"2018-06-25T17:16:24Z","pushed_at":"2018-07-07T19:31:58Z","git_url":"git://github.com/sgaragagghu/xdag-commented.git","ssh_url":"[email protected]:sgaragagghu/xdag-commented.git","clone_url":"https://github.com/sgaragagghu/xdag-commented.git","svn_url":"https://github.com/sgaragagghu/xdag-commented","homepage":"","size":6484,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"Comment-1"}},"base":{"label":"XDagger:develop","ref":"develop","sha":"175a3b224e963260f9d2c1907d29a0e386d6211c","user":{"login":"XDagger","id":35428337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDI4MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/35428337?v=4","gravatar_id":"","url":"https://api.github.com/users/XDagger","html_url":"https://github.com/XDagger","followers_url":"https://api.github.com/users/XDagger/followers","following_url":"https://api.github.com/users/XDagger/following{/other_user}","gists_url":"https://api.github.com/users/XDagger/gists{/gist_id}","starred_url":"https://api.github.com/users/XDagger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDagger/subscriptions","organizations_url":"https://api.github.com/users/XDagger/orgs","repos_url":"https://api.github.com/users/XDagger/repos","events_url":"https://api.github.com/users/XDagger/events{/privacy}","received_events_url":"https://api.github.com/users/XDagger/received_events","type":"Organization","site_admin":false},"repo":{"id":117907222,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc5MDcyMjI=","name":"xdag","full_name":"XDagger/xdag","owner":{"login":"XDagger","id":35428337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDI4MzM3","avatar_url":"https://avatars0.githubusercontent.com/u/35428337?v=4","gravatar_id":"","url":"https://api.github.com/users/XDagger","html_url":"https://github.com/XDagger","followers_url":"https://api.github.com/users/XDagger/followers","following_url":"https://api.github.com/users/XDagger/following{/other_user}","gists_url":"https://api.github.com/users/XDagger/gists{/gist_id}","starred_url":"https://api.github.com/users/XDagger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/XDagger/subscriptions","organizations_url":"https://api.github.com/users/XDagger/orgs","repos_url":"https://api.github.com/users/XDagger/repos","events_url":"https://api.github.com/users/XDagger/events{/privacy}","received_events_url":"https://api.github.com/users/XDagger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/XDagger/xdag","description":"XDAG (Dagger Coin) Official Main Repository. XDAG is a novel DAG based cryptocurrency.","fork":true,"url":"https://api.github.com/repos/XDagger/xdag","forks_url":"https://api.github.com/repos/XDagger/xdag/forks","keys_url":"https://api.github.com/repos/XDagger/xdag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/XDagger/xdag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/XDagger/xdag/teams","hooks_url":"https://api.github.com/repos/XDagger/xdag/hooks","issue_events_url":"https://api.github.com/repos/XDagger/xdag/issues/events{/number}","events_url":"https://api.github.com/repos/XDagger/xdag/events","assignees_url":"https://api.github.com/repos/XDagger/xdag/assignees{/user}","branches_url":"https://api.github.com/repos/XDagger/xdag/branches{/branch}","tags_url":"https://api.github.com/repos/XDagger/xdag/tags","blobs_url":"https://api.github.com/repos/XDagger/xdag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/XDagger/xdag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/XDagger/xdag/git/refs{/sha}","trees_url":"https://api.github.com/repos/XDagger/xdag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/XDagger/xdag/statuses/{sha}","languages_url":"https://api.github.com/repos/XDagger/xdag/languages","stargazers_url":"https://api.github.com/repos/XDagger/xdag/stargazers","contributors_url":"https://api.github.com/repos/XDagger/xdag/contributors","subscribers_url":"https://api.github.com/repos/XDagger/xdag/subscribers","subscription_url":"https://api.github.com/repos/XDagger/xdag/subscription","commits_url":"https://api.github.com/repos/XDagger/xdag/commits{/sha}","git_commits_url":"https://api.github.com/repos/XDagger/xdag/git/commits{/sha}","comments_url":"https://api.github.com/repos/XDagger/xdag/comments{/number}","issue_comment_url":"https://api.github.com/repos/XDagger/xdag/issues/comments{/number}","contents_url":"https://api.github.com/repos/XDagger/xdag/contents/{+path}","compare_url":"https://api.github.com/repos/XDagger/xdag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/XDagger/xdag/merges","archive_url":"https://api.github.com/repos/XDagger/xdag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/XDagger/xdag/downloads","issues_url":"https://api.github.com/repos/XDagger/xdag/issues{/number}","pulls_url":"https://api.github.com/repos/XDagger/xdag/pulls{/number}","milestones_url":"https://api.github.com/repos/XDagger/xdag/milestones{/number}","notifications_url":"https://api.github.com/repos/XDagger/xdag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/XDagger/xdag/labels{/name}","releases_url":"https://api.github.com/repos/XDagger/xdag/releases{/id}","deployments_url":"https://api.github.com/repos/XDagger/xdag/deployments","created_at":"2018-01-17T23:55:56Z","updated_at":"2018-07-06T17:12:12Z","pushed_at":"2018-07-07T20:51:57Z","git_url":"git://github.com/XDagger/xdag.git","ssh_url":"[email protected]:XDagger/xdag.git","clone_url":"https://github.com/XDagger/xdag.git","svn_url":"https://github.com/XDagger/xdag","homepage":"http://xdag.io","size":6100,"stargazers_count":190,"watchers_count":190,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":84,"open_issues":25,"watchers":190,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/247"},"html":{"href":"https://github.com/XDagger/xdag/pull/247"},"issue":{"href":"https://api.github.com/repos/XDagger/xdag/issues/247"},"comments":{"href":"https://api.github.com/repos/XDagger/xdag/issues/247/comments"},"review_comments":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/247/comments"},"review_comment":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/XDagger/xdag/pulls/247/commits"},"statuses":{"href":"https://api.github.com/repos/XDagger/xdag/statuses/cb5539b02552b245e11f870f461693d1cc58f98d"}},"author_association":"NONE"}}

7933592681

{"actor":{"display_login":"sgaragagghu"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/loki-project/loki-messenger/pulls/comments/239303451","pull_request_review_id":182054078,"id":239303451,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTMwMzQ1MQ==","diff_hunk":"@@ -183,11 +183,11 @@\n window.log.error('Failed to fetch prekey:', keyId);\n return undefined;\n },\n- async loadPreKeyForContactIdentityKeyString(contactIdentityKeyString) {\n- const key = await window.Signal.Data.getPreKeyByRecipient(contactIdentityKeyString);\n+ async loadPreKeyForContact (contactPubKey) {","path":"js/signal_protocol_store.js","position":6,"original_position":6,"commit_id":"1e3886cca8a5a112ab9a022b9a6e259aeb3c2fdb","original_commit_id":"1e3886cca8a5a112ab9a022b9a6e259aeb3c2fdb","user":{"login":"sachaaaaa","id":40749766,"node_id":"MDQ6VXNlcjQwNzQ5NzY2","avatar_url":"https://avatars2.githubusercontent.com/u/40749766?v=4","gravatar_id":"","url":"https://api.github.com/users/sachaaaaa","html_url":"https://github.com/sachaaaaa","followers_url":"https://api.github.com/users/sachaaaaa/followers","following_url":"https://api.github.com/users/sachaaaaa/following{/other_user}","gists_url":"https://api.github.com/users/sachaaaaa/gists{/gist_id}","starred_url":"https://api.github.com/users/sachaaaaa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sachaaaaa/subscriptions","organizations_url":"https://api.github.com/users/sachaaaaa/orgs","repos_url":"https://api.github.com/users/sachaaaaa/repos","events_url":"https://api.github.com/users/sachaaaaa/events{/privacy}","received_events_url":"https://api.github.com/users/sachaaaaa/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n async loadPreKeyForContact(contactPubKey) {\r\n```","created_at":"2018-12-06T01:45:19Z","updated_at":"2018-12-06T01:45:19Z","html_url":"https://github.com/loki-project/loki-messenger/pull/75#discussion_r239303451","pull_request_url":"https://api.github.com/repos/loki-project/loki-messenger/pulls/75","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/loki-project/loki-messenger/pulls/comments/239303451"},"html":{"href":"https://github.com/loki-project/loki-messenger/pull/75#discussion_r239303451"},"pull_request":{"href":"https://api.github.com/repos/loki-project/loki-messenger/pulls/75"}}},"pull_request":{"url":"https://api.github.com/repos/loki-project/loki-messenger/pulls/75","id":236379291,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2Mzc5Mjkx","html_url":"https://github.com/loki-project/loki-messenger/pull/75","diff_url":"https://github.com/loki-project/loki-messenger/pull/75.diff","patch_url":"https://github.com/loki-project/loki-messenger/pull/75.patch","issue_url":"https://api.github.com/repos/loki-project/loki-messenger/issues/75","number":75,"state":"open","locked":false,"title":"Clean up function names and loki store","user":{"login":"BeaudanBrown","id":43770694,"node_id":"MDQ6VXNlcjQzNzcwNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/43770694?v=4","gravatar_id":"","url":"https://api.github.com/users/BeaudanBrown","html_url":"https://github.com/BeaudanBrown","followers_url":"https://api.github.com/users/BeaudanBrown/followers","following_url":"https://api.github.com/users/BeaudanBrown/following{/other_user}","gists_url":"https://api.github.com/users/BeaudanBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/BeaudanBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeaudanBrown/subscriptions","organizations_url":"https://api.github.com/users/BeaudanBrown/orgs","repos_url":"https://api.github.com/users/BeaudanBrown/repos","events_url":"https://api.github.com/users/BeaudanBrown/events{/privacy}","received_events_url":"https://api.github.com/users/BeaudanBrown/received_events","type":"User","site_admin":false},"body":"More consistent naming of key storage functions, moved some loki messenger only functions into new file\r\nMade getPreKeyBundleForContact return object rather than a proto to be consistent with other functions","created_at":"2018-12-06T01:29:13Z","updated_at":"2018-12-06T01:45:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9dcfea1482b795f1726847f06b290ed885672a28","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Mikunj","id":4365065,"node_id":"MDQ6VXNlcjQzNjUwNjU=","avatar_url":"https://avatars1.githubusercontent.com/u/4365065?v=4","gravatar_id":"","url":"https://api.github.com/users/Mikunj","html_url":"https://github.com/Mikunj","followers_url":"https://api.github.com/users/Mikunj/followers","following_url":"https://api.github.com/users/Mikunj/following{/other_user}","gists_url":"https://api.github.com/users/Mikunj/gists{/gist_id}","starred_url":"https://api.github.com/users/Mikunj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mikunj/subscriptions","organizations_url":"https://api.github.com/users/Mikunj/orgs","repos_url":"https://api.github.com/users/Mikunj/repos","events_url":"https://api.github.com/users/Mikunj/events{/privacy}","received_events_url":"https://api.github.com/users/Mikunj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/loki-project/loki-messenger/pulls/75/commits","review_comments_url":"https://api.github.com/repos/loki-project/loki-messenger/pulls/75/comments","review_comment_url":"https://api.github.com/repos/loki-project/loki-messenger/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loki-project/loki-messenger/issues/75/comments","statuses_url":"https://api.github.com/repos/loki-project/loki-messenger/statuses/1e3886cca8a5a112ab9a022b9a6e259aeb3c2fdb","head":{"label":"BeaudanBrown:loki-store-clean","ref":"loki-store-clean","sha":"1e3886cca8a5a112ab9a022b9a6e259aeb3c2fdb","user":{"login":"BeaudanBrown","id":43770694,"node_id":"MDQ6VXNlcjQzNzcwNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/43770694?v=4","gravatar_id":"","url":"https://api.github.com/users/BeaudanBrown","html_url":"https://github.com/BeaudanBrown","followers_url":"https://api.github.com/users/BeaudanBrown/followers","following_url":"https://api.github.com/users/BeaudanBrown/following{/other_user}","gists_url":"https://api.github.com/users/BeaudanBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/BeaudanBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeaudanBrown/subscriptions","organizations_url":"https://api.github.com/users/BeaudanBrown/orgs","repos_url":"https://api.github.com/users/BeaudanBrown/repos","events_url":"https://api.github.com/users/BeaudanBrown/events{/privacy}","received_events_url":"https://api.github.com/users/BeaudanBrown/received_events","type":"User","site_admin":false},"repo":{"id":157156560,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcxNTY1NjA=","name":"loki-messenger","full_name":"BeaudanBrown/loki-messenger","private":false,"owner":{"login":"BeaudanBrown","id":43770694,"node_id":"MDQ6VXNlcjQzNzcwNjk0","avatar_url":"https://avatars0.githubusercontent.com/u/43770694?v=4","gravatar_id":"","url":"https://api.github.com/users/BeaudanBrown","html_url":"https://github.com/BeaudanBrown","followers_url":"https://api.github.com/users/BeaudanBrown/followers","following_url":"https://api.github.com/users/BeaudanBrown/following{/other_user}","gists_url":"https://api.github.com/users/BeaudanBrown/gists{/gist_id}","starred_url":"https://api.github.com/users/BeaudanBrown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BeaudanBrown/subscriptions","organizations_url":"https://api.github.com/users/BeaudanBrown/orgs","repos_url":"https://api.github.com/users/BeaudanBrown/repos","events_url":"https://api.github.com/users/BeaudanBrown/events{/privacy}","received_events_url":"https://api.github.com/users/BeaudanBrown/received_events","type":"User","site_admin":false},"html_url":"https://github.com/BeaudanBrown/loki-messenger","description":"Loki Messenger - Mixnet based messenger","fork":true,"url":"https://api.github.com/repos/BeaudanBrown/loki-messenger","forks_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/forks","keys_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/teams","hooks_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/hooks","issue_events_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/issues/events{/number}","events_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/events","assignees_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/assignees{/user}","branches_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/branches{/branch}","tags_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/tags","blobs_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/git/refs{/sha}","trees_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/statuses/{sha}","languages_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/languages","stargazers_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/stargazers","contributors_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/contributors","subscribers_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/subscribers","subscription_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/subscription","commits_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/commits{/sha}","git_commits_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/git/commits{/sha}","comments_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/comments{/number}","issue_comment_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/issues/comments{/number}","contents_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/contents/{+path}","compare_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/merges","archive_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/downloads","issues_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/issues{/number}","pulls_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/pulls{/number}","milestones_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/milestones{/number}","notifications_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/labels{/name}","releases_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/releases{/id}","deployments_url":"https://api.github.com/repos/BeaudanBrown/loki-messenger/deployments","created_at":"2018-11-12T04:30:21Z","updated_at":"2018-12-06T00:50:16Z","pushed_at":"2018-12-06T01:28:16Z","git_url":"git://github.com/BeaudanBrown/loki-messenger.git","ssh_url":"[email protected]:BeaudanBrown/loki-messenger.git","clone_url":"https://github.com/BeaudanBrown/loki-messenger.git","svn_url":"https://github.com/BeaudanBrown/loki-messenger","homepage":"https://loki.network","size":75009,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"loki-project:development","ref":"development","sha":"fd45da35cea024ba8559a5f88c844be7b709a839","user":{"login":"loki-project","id":35471049,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDcxMDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/35471049?v=4","gravatar_id":"","url":"https://api.github.com/users/loki-project","html_url":"https://github.com/loki-project","followers_url":"https://api.github.com/users/loki-project/followers","following_url":"https://api.github.com/users/loki-project/following{/other_user}","gists_url":"https://api.github.com/users/loki-project/gists{/gist_id}","starred_url":"https://api.github.com/users/loki-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loki-project/subscriptions","organizations_url":"https://api.github.com/users/loki-project/orgs","repos_url":"https://api.github.com/users/loki-project/repos","events_url":"https://api.github.com/users/loki-project/events{/privacy}","received_events_url":"https://api.github.com/users/loki-project/received_events","type":"Organization","site_admin":false},"repo":{"id":144933387,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5MzMzODc=","name":"loki-messenger","full_name":"loki-project/loki-messenger","private":false,"owner":{"login":"loki-project","id":35471049,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NDcxMDQ5","avatar_url":"https://avatars0.githubusercontent.com/u/35471049?v=4","gravatar_id":"","url":"https://api.github.com/users/loki-project","html_url":"https://github.com/loki-project","followers_url":"https://api.github.com/users/loki-project/followers","following_url":"https://api.github.com/users/loki-project/following{/other_user}","gists_url":"https://api.github.com/users/loki-project/gists{/gist_id}","starred_url":"https://api.github.com/users/loki-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loki-project/subscriptions","organizations_url":"https://api.github.com/users/loki-project/orgs","repos_url":"https://api.github.com/users/loki-project/repos","events_url":"https://api.github.com/users/loki-project/events{/privacy}","received_events_url":"https://api.github.com/users/loki-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/loki-project/loki-messenger","description":"Loki Messenger - Mixnet based messenger","fork":true,"url":"https://api.github.com/repos/loki-project/loki-messenger","forks_url":"https://api.github.com/repos/loki-project/loki-messenger/forks","keys_url":"https://api.github.com/repos/loki-project/loki-messenger/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loki-project/loki-messenger/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loki-project/loki-messenger/teams","hooks_url":"https://api.github.com/repos/loki-project/loki-messenger/hooks","issue_events_url":"https://api.github.com/repos/loki-project/loki-messenger/issues/events{/number}","events_url":"https://api.github.com/repos/loki-project/loki-messenger/events","assignees_url":"https://api.github.com/repos/loki-project/loki-messenger/assignees{/user}","branches_url":"https://api.github.com/repos/loki-project/loki-messenger/branches{/branch}","tags_url":"https://api.github.com/repos/loki-project/loki-messenger/tags","blobs_url":"https://api.github.com/repos/loki-project/loki-messenger/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loki-project/loki-messenger/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loki-project/loki-messenger/git/refs{/sha}","trees_url":"https://api.github.com/repos/loki-project/loki-messenger/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loki-project/loki-messenger/statuses/{sha}","languages_url":"https://api.github.com/repos/loki-project/loki-messenger/languages","stargazers_url":"https://api.github.com/repos/loki-project/loki-messenger/stargazers","contributors_url":"https://api.github.com/repos/loki-project/loki-messenger/contributors","subscribers_url":"https://api.github.com/repos/loki-project/loki-messenger/subscribers","subscription_url":"https://api.github.com/repos/loki-project/loki-messenger/subscription","commits_url":"https://api.github.com/repos/loki-project/loki-messenger/commits{/sha}","git_commits_url":"https://api.github.com/repos/loki-project/loki-messenger/git/commits{/sha}","comments_url":"https://api.github.com/repos/loki-project/loki-messenger/comments{/number}","issue_comment_url":"https://api.github.com/repos/loki-project/loki-messenger/issues/comments{/number}","contents_url":"https://api.github.com/repos/loki-project/loki-messenger/contents/{+path}","compare_url":"https://api.github.com/repos/loki-project/loki-messenger/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loki-project/loki-messenger/merges","archive_url":"https://api.github.com/repos/loki-project/loki-messenger/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loki-project/loki-messenger/downloads","issues_url":"https://api.github.com/repos/loki-project/loki-messenger/issues{/number}","pulls_url":"https://api.github.com/repos/loki-project/loki-messenger/pulls{/number}","milestones_url":"https://api.github.com/repos/loki-project/loki-messenger/milestones{/number}","notifications_url":"https://api.github.com/repos/loki-project/loki-messenger/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loki-project/loki-messenger/labels{/name}","releases_url":"https://api.github.com/repos/loki-project/loki-messenger/releases{/id}","deployments_url":"https://api.github.com/repos/loki-project/loki-messenger/deployments","created_at":"2018-08-16T03:45:21Z","updated_at":"2018-12-05T23:40:10Z","pushed_at":"2018-12-06T01:40:55Z","git_url":"git://github.com/loki-project/loki-messenger.git","ssh_url":"[email protected]:loki-project/loki-messenger.git","clone_url":"https://github.com/loki-project/loki-messenger.git","svn_url":"https://github.com/loki-project/loki-messenger","homepage":"https://loki.network","size":75036,"stargazers_count":6,"watchers_count":6,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":7,"open_issues":2,"watchers":6,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/loki-project/loki-messenger/pulls/75"},"html":{"href":"https://github.com/loki-project/loki-messenger/pull/75"},"issue":{"href":"https://api.github.com/repos/loki-project/loki-messenger/issues/75"},"comments":{"href":"https://api.github.com/repos/loki-project/loki-messenger/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/loki-project/loki-messenger/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/loki-project/loki-messenger/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loki-project/loki-messenger/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/loki-project/loki-messenger/statuses/1e3886cca8a5a112ab9a022b9a6e259aeb3c2fdb"}},"author_association":"COLLABORATOR"}}

8706223566

{"actor":{"display_login":"sachaaaaa"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/a15k/mothership/pulls/comments/195289165","pull_request_review_id":128626190,"id":195289165,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTI4OTE2NQ==","diff_hunk":"@@ -0,0 +1,100 @@\n+# coding: utf-8\n+class Api::V1::AssessmentsController < ApiController\n+\n+ include Swagger::Blocks\n+\n+ swagger_path '/assessments' do\n+ operation :get do\n+ key :summary, 'Search for assessments'\n+ key :operationId, 'searchAssessments'\n+ security do\n+ key :api_token, []\n+ end\n+ key :tags, ['Assessments']\n+\n+ parameter do\n+ key :name, :q\n+ key :in, :path\n+ key :description, 'query to execute'","path":"app/controllers/api/v1/assessments_controller.rb","position":18,"original_position":18,"commit_id":"247649757b2635515e4cb20b541f66897bcf0ade","original_commit_id":"36e9a753279b45f347825c72d1771d74493bf040","user":{"login":"jpslav","id":1001691,"node_id":"MDQ6VXNlcjEwMDE2OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1001691?v=4","gravatar_id":"","url":"https://api.github.com/users/jpslav","html_url":"https://github.com/jpslav","followers_url":"https://api.github.com/users/jpslav/followers","following_url":"https://api.github.com/users/jpslav/following{/other_user}","gists_url":"https://api.github.com/users/jpslav/gists{/gist_id}","starred_url":"https://api.github.com/users/jpslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpslav/subscriptions","organizations_url":"https://api.github.com/users/jpslav/orgs","repos_url":"https://api.github.com/users/jpslav/repos","events_url":"https://api.github.com/users/jpslav/events{/privacy}","received_events_url":"https://api.github.com/users/jpslav/received_events","type":"User","site_admin":false},"body":"made a card for y'all to get together and document :-)","created_at":"2018-06-14T02:40:41Z","updated_at":"2018-06-14T02:40:41Z","html_url":"https://github.com/a15k/mothership/pull/6#discussion_r195289165","pull_request_url":"https://api.github.com/repos/a15k/mothership/pulls/6","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/a15k/mothership/pulls/comments/195289165"},"html":{"href":"https://github.com/a15k/mothership/pull/6#discussion_r195289165"},"pull_request":{"href":"https://api.github.com/repos/a15k/mothership/pulls/6"}},"in_reply_to_id":194897462},"pull_request":{"url":"https://api.github.com/repos/a15k/mothership/pulls/6","id":187498433,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg3NDk4NDMz","html_url":"https://github.com/a15k/mothership/pull/6","diff_url":"https://github.com/a15k/mothership/pull/6.diff","patch_url":"https://github.com/a15k/mothership/pull/6.patch","issue_url":"https://api.github.com/repos/a15k/mothership/issues/6","number":6,"state":"open","locked":false,"title":"DO NOT MERGE: Full review 5/11/18","user":{"login":"jpslav","id":1001691,"node_id":"MDQ6VXNlcjEwMDE2OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1001691?v=4","gravatar_id":"","url":"https://api.github.com/users/jpslav","html_url":"https://github.com/jpslav","followers_url":"https://api.github.com/users/jpslav/followers","following_url":"https://api.github.com/users/jpslav/following{/other_user}","gists_url":"https://api.github.com/users/jpslav/gists{/gist_id}","starred_url":"https://api.github.com/users/jpslav/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpslav/subscriptions","organizations_url":"https://api.github.com/users/jpslav/orgs","repos_url":"https://api.github.com/users/jpslav/repos","events_url":"https://api.github.com/users/jpslav/events{/privacy}","received_events_url":"https://api.github.com/users/jpslav/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-11T15:35:38Z","updated_at":"2018-06-14T02:40:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ab1ee5dbc1c591664e1ec8604c970ca961cd9aab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/a15k/mothership/pulls/6/commits","review_comments_url":"https://api.github.com/repos/a15k/mothership/pulls/6/comments","review_comment_url":"https://api.github.com/repos/a15k/mothership/pulls/comments{/number}","comments_url":"https://api.github.com/repos/a15k/mothership/issues/6/comments","statuses_url":"https://api.github.com/repos/a15k/mothership/statuses/247649757b2635515e4cb20b541f66897bcf0ade","head":{"label":"a15k:master","ref":"master","sha":"247649757b2635515e4cb20b541f66897bcf0ade","user":{"login":"a15k","id":35530852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTMwODUy","avatar_url":"https://avatars3.githubusercontent.com/u/35530852?v=4","gravatar_id":"","url":"https://api.github.com/users/a15k","html_url":"https://github.com/a15k","followers_url":"https://api.github.com/users/a15k/followers","following_url":"https://api.github.com/users/a15k/following{/other_user}","gists_url":"https://api.github.com/users/a15k/gists{/gist_id}","starred_url":"https://api.github.com/users/a15k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a15k/subscriptions","organizations_url":"https://api.github.com/users/a15k/orgs","repos_url":"https://api.github.com/users/a15k/repos","events_url":"https://api.github.com/users/a15k/events{/privacy}","received_events_url":"https://api.github.com/users/a15k/received_events","type":"Organization","site_admin":false},"repo":{"id":120025401,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwMjU0MDE=","name":"mothership","full_name":"a15k/mothership","owner":{"login":"a15k","id":35530852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTMwODUy","avatar_url":"https://avatars3.githubusercontent.com/u/35530852?v=4","gravatar_id":"","url":"https://api.github.com/users/a15k","html_url":"https://github.com/a15k","followers_url":"https://api.github.com/users/a15k/followers","following_url":"https://api.github.com/users/a15k/following{/other_user}","gists_url":"https://api.github.com/users/a15k/gists{/gist_id}","starred_url":"https://api.github.com/users/a15k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a15k/subscriptions","organizations_url":"https://api.github.com/users/a15k/orgs","repos_url":"https://api.github.com/users/a15k/repos","events_url":"https://api.github.com/users/a15k/events{/privacy}","received_events_url":"https://api.github.com/users/a15k/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/a15k/mothership","description":"The repository for assessments, members and their users","fork":false,"url":"https://api.github.com/repos/a15k/mothership","forks_url":"https://api.github.com/repos/a15k/mothership/forks","keys_url":"https://api.github.com/repos/a15k/mothership/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a15k/mothership/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a15k/mothership/teams","hooks_url":"https://api.github.com/repos/a15k/mothership/hooks","issue_events_url":"https://api.github.com/repos/a15k/mothership/issues/events{/number}","events_url":"https://api.github.com/repos/a15k/mothership/events","assignees_url":"https://api.github.com/repos/a15k/mothership/assignees{/user}","branches_url":"https://api.github.com/repos/a15k/mothership/branches{/branch}","tags_url":"https://api.github.com/repos/a15k/mothership/tags","blobs_url":"https://api.github.com/repos/a15k/mothership/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a15k/mothership/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a15k/mothership/git/refs{/sha}","trees_url":"https://api.github.com/repos/a15k/mothership/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a15k/mothership/statuses/{sha}","languages_url":"https://api.github.com/repos/a15k/mothership/languages","stargazers_url":"https://api.github.com/repos/a15k/mothership/stargazers","contributors_url":"https://api.github.com/repos/a15k/mothership/contributors","subscribers_url":"https://api.github.com/repos/a15k/mothership/subscribers","subscription_url":"https://api.github.com/repos/a15k/mothership/subscription","commits_url":"https://api.github.com/repos/a15k/mothership/commits{/sha}","git_commits_url":"https://api.github.com/repos/a15k/mothership/git/commits{/sha}","comments_url":"https://api.github.com/repos/a15k/mothership/comments{/number}","issue_comment_url":"https://api.github.com/repos/a15k/mothership/issues/comments{/number}","contents_url":"https://api.github.com/repos/a15k/mothership/contents/{+path}","compare_url":"https://api.github.com/repos/a15k/mothership/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a15k/mothership/merges","archive_url":"https://api.github.com/repos/a15k/mothership/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a15k/mothership/downloads","issues_url":"https://api.github.com/repos/a15k/mothership/issues{/number}","pulls_url":"https://api.github.com/repos/a15k/mothership/pulls{/number}","milestones_url":"https://api.github.com/repos/a15k/mothership/milestones{/number}","notifications_url":"https://api.github.com/repos/a15k/mothership/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a15k/mothership/labels{/name}","releases_url":"https://api.github.com/repos/a15k/mothership/releases{/id}","deployments_url":"https://api.github.com/repos/a15k/mothership/deployments","created_at":"2018-02-02T20:01:06Z","updated_at":"2018-06-14T02:34:07Z","pushed_at":"2018-06-14T02:34:08Z","git_url":"git://github.com/a15k/mothership.git","ssh_url":"[email protected]:a15k/mothership.git","clone_url":"https://github.com/a15k/mothership.git","svn_url":"https://github.com/a15k/mothership","homepage":"","size":686,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"a15k:first-commit","ref":"first-commit","sha":"d5bc7f088d26c42205b8d3bd8903984c4e13889c","user":{"login":"a15k","id":35530852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTMwODUy","avatar_url":"https://avatars3.githubusercontent.com/u/35530852?v=4","gravatar_id":"","url":"https://api.github.com/users/a15k","html_url":"https://github.com/a15k","followers_url":"https://api.github.com/users/a15k/followers","following_url":"https://api.github.com/users/a15k/following{/other_user}","gists_url":"https://api.github.com/users/a15k/gists{/gist_id}","starred_url":"https://api.github.com/users/a15k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a15k/subscriptions","organizations_url":"https://api.github.com/users/a15k/orgs","repos_url":"https://api.github.com/users/a15k/repos","events_url":"https://api.github.com/users/a15k/events{/privacy}","received_events_url":"https://api.github.com/users/a15k/received_events","type":"Organization","site_admin":false},"repo":{"id":120025401,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAwMjU0MDE=","name":"mothership","full_name":"a15k/mothership","owner":{"login":"a15k","id":35530852,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTMwODUy","avatar_url":"https://avatars3.githubusercontent.com/u/35530852?v=4","gravatar_id":"","url":"https://api.github.com/users/a15k","html_url":"https://github.com/a15k","followers_url":"https://api.github.com/users/a15k/followers","following_url":"https://api.github.com/users/a15k/following{/other_user}","gists_url":"https://api.github.com/users/a15k/gists{/gist_id}","starred_url":"https://api.github.com/users/a15k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a15k/subscriptions","organizations_url":"https://api.github.com/users/a15k/orgs","repos_url":"https://api.github.com/users/a15k/repos","events_url":"https://api.github.com/users/a15k/events{/privacy}","received_events_url":"https://api.github.com/users/a15k/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/a15k/mothership","description":"The repository for assessments, members and their users","fork":false,"url":"https://api.github.com/repos/a15k/mothership","forks_url":"https://api.github.com/repos/a15k/mothership/forks","keys_url":"https://api.github.com/repos/a15k/mothership/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a15k/mothership/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a15k/mothership/teams","hooks_url":"https://api.github.com/repos/a15k/mothership/hooks","issue_events_url":"https://api.github.com/repos/a15k/mothership/issues/events{/number}","events_url":"https://api.github.com/repos/a15k/mothership/events","assignees_url":"https://api.github.com/repos/a15k/mothership/assignees{/user}","branches_url":"https://api.github.com/repos/a15k/mothership/branches{/branch}","tags_url":"https://api.github.com/repos/a15k/mothership/tags","blobs_url":"https://api.github.com/repos/a15k/mothership/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a15k/mothership/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a15k/mothership/git/refs{/sha}","trees_url":"https://api.github.com/repos/a15k/mothership/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a15k/mothership/statuses/{sha}","languages_url":"https://api.github.com/repos/a15k/mothership/languages","stargazers_url":"https://api.github.com/repos/a15k/mothership/stargazers","contributors_url":"https://api.github.com/repos/a15k/mothership/contributors","subscribers_url":"https://api.github.com/repos/a15k/mothership/subscribers","subscription_url":"https://api.github.com/repos/a15k/mothership/subscription","commits_url":"https://api.github.com/repos/a15k/mothership/commits{/sha}","git_commits_url":"https://api.github.com/repos/a15k/mothership/git/commits{/sha}","comments_url":"https://api.github.com/repos/a15k/mothership/comments{/number}","issue_comment_url":"https://api.github.com/repos/a15k/mothership/issues/comments{/number}","contents_url":"https://api.github.com/repos/a15k/mothership/contents/{+path}","compare_url":"https://api.github.com/repos/a15k/mothership/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a15k/mothership/merges","archive_url":"https://api.github.com/repos/a15k/mothership/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a15k/mothership/downloads","issues_url":"https://api.github.com/repos/a15k/mothership/issues{/number}","pulls_url":"https://api.github.com/repos/a15k/mothership/pulls{/number}","milestones_url":"https://api.github.com/repos/a15k/mothership/milestones{/number}","notifications_url":"https://api.github.com/repos/a15k/mothership/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a15k/mothership/labels{/name}","releases_url":"https://api.github.com/repos/a15k/mothership/releases{/id}","deployments_url":"https://api.github.com/repos/a15k/mothership/deployments","created_at":"2018-02-02T20:01:06Z","updated_at":"2018-06-14T02:34:07Z","pushed_at":"2018-06-14T02:34:08Z","git_url":"git://github.com/a15k/mothership.git","ssh_url":"[email protected]:a15k/mothership.git","clone_url":"https://github.com/a15k/mothership.git","svn_url":"https://github.com/a15k/mothership","homepage":"","size":686,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/a15k/mothership/pulls/6"},"html":{"href":"https://github.com/a15k/mothership/pull/6"},"issue":{"href":"https://api.github.com/repos/a15k/mothership/issues/6"},"comments":{"href":"https://api.github.com/repos/a15k/mothership/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/a15k/mothership/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/a15k/mothership/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/a15k/mothership/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/a15k/mothership/statuses/247649757b2635515e4cb20b541f66897bcf0ade"}},"author_association":"CONTRIBUTOR"}}

7822469959

{"actor":{"display_login":"jpslav"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/OCFL/spec/pulls/comments/221675504","pull_request_review_id":160382345,"id":221675504,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTY3NTUwNA==","diff_hunk":"@@ -151,42 +151,43 @@ <h2>Filesystem metadata</h2>\n \n <h2>Empty Directories</h2>\n <p>\n-OCFL preserves files and their content, with directories serving as a useful organisational convention. An empty\n+OCFL preserves files and their content, with directories serving as a useful organizational convention. An empty\n directory consists only of filesystem metadata and therefore, as noted above, is not amenable to direct\n preservation in OCFL. If the preservation of empty directories is considered essential then the suggested route\n-is to insert a zero length file named <code>.keep</code> into the directory which will thus be preserved as\n-part of the files' path.\n+is to insert a zero length file named <code>.keep</code> into the directory which will ensure directories are preserved\n+as part of the files' path.","path":"draft/implementation-notes/index.html","position":29,"original_position":29,"commit_id":"115759fa1ac8c4e1cb1ea9fd5d8aeaa0d4eb16ae","original_commit_id":"115759fa1ac8c4e1cb1ea9fd5d8aeaa0d4eb16ae","user":{"login":"zimeon","id":658600,"node_id":"MDQ6VXNlcjY1ODYwMA==","avatar_url":"https://avatars0.githubusercontent.com/u/658600?v=4","gravatar_id":"","url":"https://api.github.com/users/zimeon","html_url":"https://github.com/zimeon","followers_url":"https://api.github.com/users/zimeon/followers","following_url":"https://api.github.com/users/zimeon/following{/other_user}","gists_url":"https://api.github.com/users/zimeon/gists{/gist_id}","starred_url":"https://api.github.com/users/zimeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimeon/subscriptions","organizations_url":"https://api.github.com/users/zimeon/orgs","repos_url":"https://api.github.com/users/zimeon/repos","events_url":"https://api.github.com/users/zimeon/events{/privacy}","received_events_url":"https://api.github.com/users/zimeon/received_events","type":"User","site_admin":false},"body":"should be **file's** instead of **files'** as we are talking about only one file (\"a zero length file\")","created_at":"2018-10-01T16:35:52Z","updated_at":"2018-10-01T16:36:31Z","html_url":"https://github.com/OCFL/spec/pull/172#discussion_r221675504","pull_request_url":"https://api.github.com/repos/OCFL/spec/pulls/172","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OCFL/spec/pulls/comments/221675504"},"html":{"href":"https://github.com/OCFL/spec/pull/172#discussion_r221675504"},"pull_request":{"href":"https://api.github.com/repos/OCFL/spec/pulls/172"}}},"pull_request":{"url":"https://api.github.com/repos/OCFL/spec/pulls/172","id":219394175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Mzk0MTc1","html_url":"https://github.com/OCFL/spec/pull/172","diff_url":"https://github.com/OCFL/spec/pull/172.diff","patch_url":"https://github.com/OCFL/spec/pull/172.patch","issue_url":"https://api.github.com/repos/OCFL/spec/issues/172","number":172,"state":"open","locked":false,"title":"updates to implementation notes","user":{"login":"rosy1280","id":143322,"node_id":"MDQ6VXNlcjE0MzMyMg==","avatar_url":"https://avatars0.githubusercontent.com/u/143322?v=4","gravatar_id":"","url":"https://api.github.com/users/rosy1280","html_url":"https://github.com/rosy1280","followers_url":"https://api.github.com/users/rosy1280/followers","following_url":"https://api.github.com/users/rosy1280/following{/other_user}","gists_url":"https://api.github.com/users/rosy1280/gists{/gist_id}","starred_url":"https://api.github.com/users/rosy1280/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosy1280/subscriptions","organizations_url":"https://api.github.com/users/rosy1280/orgs","repos_url":"https://api.github.com/users/rosy1280/repos","events_url":"https://api.github.com/users/rosy1280/events{/privacy}","received_events_url":"https://api.github.com/users/rosy1280/received_events","type":"User","site_admin":false},"body":"fixes the checklist referenced in #129","created_at":"2018-10-01T14:21:32Z","updated_at":"2018-10-01T16:36:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ccd843234db7908acc7f4b3caf7285814d159e38","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ahankinson","id":163183,"node_id":"MDQ6VXNlcjE2MzE4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/163183?v=4","gravatar_id":"","url":"https://api.github.com/users/ahankinson","html_url":"https://github.com/ahankinson","followers_url":"https://api.github.com/users/ahankinson/followers","following_url":"https://api.github.com/users/ahankinson/following{/other_user}","gists_url":"https://api.github.com/users/ahankinson/gists{/gist_id}","starred_url":"https://api.github.com/users/ahankinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahankinson/subscriptions","organizations_url":"https://api.github.com/users/ahankinson/orgs","repos_url":"https://api.github.com/users/ahankinson/repos","events_url":"https://api.github.com/users/ahankinson/events{/privacy}","received_events_url":"https://api.github.com/users/ahankinson/received_events","type":"User","site_admin":false},{"login":"julianmorley","id":8161286,"node_id":"MDQ6VXNlcjgxNjEyODY=","avatar_url":"https://avatars0.githubusercontent.com/u/8161286?v=4","gravatar_id":"","url":"https://api.github.com/users/julianmorley","html_url":"https://github.com/julianmorley","followers_url":"https://api.github.com/users/julianmorley/followers","following_url":"https://api.github.com/users/julianmorley/following{/other_user}","gists_url":"https://api.github.com/users/julianmorley/gists{/gist_id}","starred_url":"https://api.github.com/users/julianmorley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/julianmorley/subscriptions","organizations_url":"https://api.github.com/users/julianmorley/orgs","repos_url":"https://api.github.com/users/julianmorley/repos","events_url":"https://api.github.com/users/julianmorley/events{/privacy}","received_events_url":"https://api.github.com/users/julianmorley/received_events","type":"User","site_admin":false},{"login":"neilsjefferies","id":37909475,"node_id":"MDQ6VXNlcjM3OTA5NDc1","avatar_url":"https://avatars1.githubusercontent.com/u/37909475?v=4","gravatar_id":"","url":"https://api.github.com/users/neilsjefferies","html_url":"https://github.com/neilsjefferies","followers_url":"https://api.github.com/users/neilsjefferies/followers","following_url":"https://api.github.com/users/neilsjefferies/following{/other_user}","gists_url":"https://api.github.com/users/neilsjefferies/gists{/gist_id}","starred_url":"https://api.github.com/users/neilsjefferies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilsjefferies/subscriptions","organizations_url":"https://api.github.com/users/neilsjefferies/orgs","repos_url":"https://api.github.com/users/neilsjefferies/repos","events_url":"https://api.github.com/users/neilsjefferies/events{/privacy}","received_events_url":"https://api.github.com/users/neilsjefferies/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCFL/spec/pulls/172/commits","review_comments_url":"https://api.github.com/repos/OCFL/spec/pulls/172/comments","review_comment_url":"https://api.github.com/repos/OCFL/spec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCFL/spec/issues/172/comments","statuses_url":"https://api.github.com/repos/OCFL/spec/statuses/115759fa1ac8c4e1cb1ea9fd5d8aeaa0d4eb16ae","head":{"label":"OCFL:fixes-129","ref":"fixes-129","sha":"115759fa1ac8c4e1cb1ea9fd5d8aeaa0d4eb16ae","user":{"login":"OCFL","id":35607965,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA3OTY1","avatar_url":"https://avatars2.githubusercontent.com/u/35607965?v=4","gravatar_id":"","url":"https://api.github.com/users/OCFL","html_url":"https://github.com/OCFL","followers_url":"https://api.github.com/users/OCFL/followers","following_url":"https://api.github.com/users/OCFL/following{/other_user}","gists_url":"https://api.github.com/users/OCFL/gists{/gist_id}","starred_url":"https://api.github.com/users/OCFL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCFL/subscriptions","organizations_url":"https://api.github.com/users/OCFL/orgs","repos_url":"https://api.github.com/users/OCFL/repos","events_url":"https://api.github.com/users/OCFL/events{/privacy}","received_events_url":"https://api.github.com/users/OCFL/received_events","type":"Organization","site_admin":false},"repo":{"id":123150101,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMxNTAxMDE=","name":"spec","full_name":"OCFL/spec","private":false,"owner":{"login":"OCFL","id":35607965,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA3OTY1","avatar_url":"https://avatars2.githubusercontent.com/u/35607965?v=4","gravatar_id":"","url":"https://api.github.com/users/OCFL","html_url":"https://github.com/OCFL","followers_url":"https://api.github.com/users/OCFL/followers","following_url":"https://api.github.com/users/OCFL/following{/other_user}","gists_url":"https://api.github.com/users/OCFL/gists{/gist_id}","starred_url":"https://api.github.com/users/OCFL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCFL/subscriptions","organizations_url":"https://api.github.com/users/OCFL/orgs","repos_url":"https://api.github.com/users/OCFL/repos","events_url":"https://api.github.com/users/OCFL/events{/privacy}","received_events_url":"https://api.github.com/users/OCFL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OCFL/spec","description":"The OCFL Specifications (WIP)","fork":false,"url":"https://api.github.com/repos/OCFL/spec","forks_url":"https://api.github.com/repos/OCFL/spec/forks","keys_url":"https://api.github.com/repos/OCFL/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCFL/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCFL/spec/teams","hooks_url":"https://api.github.com/repos/OCFL/spec/hooks","issue_events_url":"https://api.github.com/repos/OCFL/spec/issues/events{/number}","events_url":"https://api.github.com/repos/OCFL/spec/events","assignees_url":"https://api.github.com/repos/OCFL/spec/assignees{/user}","branches_url":"https://api.github.com/repos/OCFL/spec/branches{/branch}","tags_url":"https://api.github.com/repos/OCFL/spec/tags","blobs_url":"https://api.github.com/repos/OCFL/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCFL/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCFL/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCFL/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCFL/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/OCFL/spec/languages","stargazers_url":"https://api.github.com/repos/OCFL/spec/stargazers","contributors_url":"https://api.github.com/repos/OCFL/spec/contributors","subscribers_url":"https://api.github.com/repos/OCFL/spec/subscribers","subscription_url":"https://api.github.com/repos/OCFL/spec/subscription","commits_url":"https://api.github.com/repos/OCFL/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCFL/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCFL/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCFL/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCFL/spec/contents/{+path}","compare_url":"https://api.github.com/repos/OCFL/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCFL/spec/merges","archive_url":"https://api.github.com/repos/OCFL/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCFL/spec/downloads","issues_url":"https://api.github.com/repos/OCFL/spec/issues{/number}","pulls_url":"https://api.github.com/repos/OCFL/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/OCFL/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/OCFL/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCFL/spec/labels{/name}","releases_url":"https://api.github.com/repos/OCFL/spec/releases{/id}","deployments_url":"https://api.github.com/repos/OCFL/spec/deployments","created_at":"2018-02-27T15:38:51Z","updated_at":"2018-10-01T15:26:38Z","pushed_at":"2018-10-01T16:15:25Z","git_url":"git://github.com/OCFL/spec.git","ssh_url":"[email protected]:OCFL/spec.git","clone_url":"https://github.com/OCFL/spec.git","svn_url":"https://github.com/OCFL/spec","homepage":"https://ocfl.io","size":1160,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":4,"open_issues":19,"watchers":8,"default_branch":"master"}},"base":{"label":"OCFL:master","ref":"master","sha":"51a85e9a95e33fd3af17677be51b341ec8ced7d3","user":{"login":"OCFL","id":35607965,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA3OTY1","avatar_url":"https://avatars2.githubusercontent.com/u/35607965?v=4","gravatar_id":"","url":"https://api.github.com/users/OCFL","html_url":"https://github.com/OCFL","followers_url":"https://api.github.com/users/OCFL/followers","following_url":"https://api.github.com/users/OCFL/following{/other_user}","gists_url":"https://api.github.com/users/OCFL/gists{/gist_id}","starred_url":"https://api.github.com/users/OCFL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCFL/subscriptions","organizations_url":"https://api.github.com/users/OCFL/orgs","repos_url":"https://api.github.com/users/OCFL/repos","events_url":"https://api.github.com/users/OCFL/events{/privacy}","received_events_url":"https://api.github.com/users/OCFL/received_events","type":"Organization","site_admin":false},"repo":{"id":123150101,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMxNTAxMDE=","name":"spec","full_name":"OCFL/spec","private":false,"owner":{"login":"OCFL","id":35607965,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NjA3OTY1","avatar_url":"https://avatars2.githubusercontent.com/u/35607965?v=4","gravatar_id":"","url":"https://api.github.com/users/OCFL","html_url":"https://github.com/OCFL","followers_url":"https://api.github.com/users/OCFL/followers","following_url":"https://api.github.com/users/OCFL/following{/other_user}","gists_url":"https://api.github.com/users/OCFL/gists{/gist_id}","starred_url":"https://api.github.com/users/OCFL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCFL/subscriptions","organizations_url":"https://api.github.com/users/OCFL/orgs","repos_url":"https://api.github.com/users/OCFL/repos","events_url":"https://api.github.com/users/OCFL/events{/privacy}","received_events_url":"https://api.github.com/users/OCFL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OCFL/spec","description":"The OCFL Specifications (WIP)","fork":false,"url":"https://api.github.com/repos/OCFL/spec","forks_url":"https://api.github.com/repos/OCFL/spec/forks","keys_url":"https://api.github.com/repos/OCFL/spec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCFL/spec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCFL/spec/teams","hooks_url":"https://api.github.com/repos/OCFL/spec/hooks","issue_events_url":"https://api.github.com/repos/OCFL/spec/issues/events{/number}","events_url":"https://api.github.com/repos/OCFL/spec/events","assignees_url":"https://api.github.com/repos/OCFL/spec/assignees{/user}","branches_url":"https://api.github.com/repos/OCFL/spec/branches{/branch}","tags_url":"https://api.github.com/repos/OCFL/spec/tags","blobs_url":"https://api.github.com/repos/OCFL/spec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCFL/spec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCFL/spec/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCFL/spec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCFL/spec/statuses/{sha}","languages_url":"https://api.github.com/repos/OCFL/spec/languages","stargazers_url":"https://api.github.com/repos/OCFL/spec/stargazers","contributors_url":"https://api.github.com/repos/OCFL/spec/contributors","subscribers_url":"https://api.github.com/repos/OCFL/spec/subscribers","subscription_url":"https://api.github.com/repos/OCFL/spec/subscription","commits_url":"https://api.github.com/repos/OCFL/spec/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCFL/spec/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCFL/spec/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCFL/spec/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCFL/spec/contents/{+path}","compare_url":"https://api.github.com/repos/OCFL/spec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCFL/spec/merges","archive_url":"https://api.github.com/repos/OCFL/spec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCFL/spec/downloads","issues_url":"https://api.github.com/repos/OCFL/spec/issues{/number}","pulls_url":"https://api.github.com/repos/OCFL/spec/pulls{/number}","milestones_url":"https://api.github.com/repos/OCFL/spec/milestones{/number}","notifications_url":"https://api.github.com/repos/OCFL/spec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCFL/spec/labels{/name}","releases_url":"https://api.github.com/repos/OCFL/spec/releases{/id}","deployments_url":"https://api.github.com/repos/OCFL/spec/deployments","created_at":"2018-02-27T15:38:51Z","updated_at":"2018-10-01T15:26:38Z","pushed_at":"2018-10-01T16:15:25Z","git_url":"git://github.com/OCFL/spec.git","ssh_url":"[email protected]:OCFL/spec.git","clone_url":"https://github.com/OCFL/spec.git","svn_url":"https://github.com/OCFL/spec","homepage":"https://ocfl.io","size":1160,"stargazers_count":8,"watchers_count":8,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":19,"license":null,"forks":4,"open_issues":19,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OCFL/spec/pulls/172"},"html":{"href":"https://github.com/OCFL/spec/pull/172"},"issue":{"href":"https://api.github.com/repos/OCFL/spec/issues/172"},"comments":{"href":"https://api.github.com/repos/OCFL/spec/issues/172/comments"},"review_comments":{"href":"https://api.github.com/repos/OCFL/spec/pulls/172/comments"},"review_comment":{"href":"https://api.github.com/repos/OCFL/spec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCFL/spec/pulls/172/commits"},"statuses":{"href":"https://api.github.com/repos/OCFL/spec/statuses/115759fa1ac8c4e1cb1ea9fd5d8aeaa0d4eb16ae"}},"author_association":"CONTRIBUTOR"}}

8349216889

{"actor":{"display_login":"zimeon"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/tox-rs/tox/pulls/comments/243921602","pull_request_review_id":187804543,"id":243921602,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzkyMTYwMg==","diff_hunk":"@@ -258,7 +258,7 @@ impl ToBytes for OnionReturn {\n }\n \n impl OnionReturn {\n- #[cfg_attr(feature = \"cargo-clippy\", allow(clippy::needless_pass_by_value))]\n+ #[allow(clippy::needless_pass_by_value)]","path":"src/toxcore/onion/packet/mod.rs","position":5,"original_position":5,"commit_id":"6a4e37e56fa0a682741520419d69838f9c83a5a6","original_commit_id":"6a4e37e56fa0a682741520419d69838f9c83a5a6","user":{"login":"kpp","id":467709,"node_id":"MDQ6VXNlcjQ2NzcwOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/467709?v=4","gravatar_id":"","url":"https://api.github.com/users/kpp","html_url":"https://github.com/kpp","followers_url":"https://api.github.com/users/kpp/followers","following_url":"https://api.github.com/users/kpp/following{/other_user}","gists_url":"https://api.github.com/users/kpp/gists{/gist_id}","starred_url":"https://api.github.com/users/kpp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kpp/subscriptions","organizations_url":"https://api.github.com/users/kpp/orgs","repos_url":"https://api.github.com/users/kpp/repos","events_url":"https://api.github.com/users/kpp/events{/privacy}","received_events_url":"https://api.github.com/users/kpp/received_events","type":"User","site_admin":false},"body":"Why needless_pass_by_value? Can you change inner to `&Option<OnionReturn>` using Option::as_ref in the call site?","created_at":"2018-12-25T18:37:47Z","updated_at":"2018-12-25T18:37:47Z","html_url":"https://github.com/tox-rs/tox/pull/288#discussion_r243921602","pull_request_url":"https://api.github.com/repos/tox-rs/tox/pulls/288","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/comments/243921602"},"html":{"href":"https://github.com/tox-rs/tox/pull/288#discussion_r243921602"},"pull_request":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/288"}}},"pull_request":{"url":"https://api.github.com/repos/tox-rs/tox/pulls/288","id":240500469,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNTAwNDY5","html_url":"https://github.com/tox-rs/tox/pull/288","diff_url":"https://github.com/tox-rs/tox/pull/288.diff","patch_url":"https://github.com/tox-rs/tox/pull/288.patch","issue_url":"https://api.github.com/repos/tox-rs/tox/issues/288","number":288,"state":"open","locked":false,"title":"Fix clippy warnings","user":{"login":"kurnevsky","id":2943605,"node_id":"MDQ6VXNlcjI5NDM2MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/2943605?v=4","gravatar_id":"","url":"https://api.github.com/users/kurnevsky","html_url":"https://github.com/kurnevsky","followers_url":"https://api.github.com/users/kurnevsky/followers","following_url":"https://api.github.com/users/kurnevsky/following{/other_user}","gists_url":"https://api.github.com/users/kurnevsky/gists{/gist_id}","starred_url":"https://api.github.com/users/kurnevsky/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurnevsky/subscriptions","organizations_url":"https://api.github.com/users/kurnevsky/orgs","repos_url":"https://api.github.com/users/kurnevsky/repos","events_url":"https://api.github.com/users/kurnevsky/events{/privacy}","received_events_url":"https://api.github.com/users/kurnevsky/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-21T15:14:43Z","updated_at":"2018-12-25T18:37:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25cab0df7c5a00e7e789751a1a23588d257df68d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tox-rs/tox/pulls/288/commits","review_comments_url":"https://api.github.com/repos/tox-rs/tox/pulls/288/comments","review_comment_url":"https://api.github.com/repos/tox-rs/tox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tox-rs/tox/issues/288/comments","statuses_url":"https://api.github.com/repos/tox-rs/tox/statuses/6a4e37e56fa0a682741520419d69838f9c83a5a6","head":{"label":"tox-rs:clippy","ref":"clippy","sha":"6a4e37e56fa0a682741520419d69838f9c83a5a6","user":{"login":"tox-rs","id":35774911,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1Nzc0OTEx","avatar_url":"https://avatars2.githubusercontent.com/u/35774911?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-rs","html_url":"https://github.com/tox-rs","followers_url":"https://api.github.com/users/tox-rs/followers","following_url":"https://api.github.com/users/tox-rs/following{/other_user}","gists_url":"https://api.github.com/users/tox-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-rs/subscriptions","organizations_url":"https://api.github.com/users/tox-rs/orgs","repos_url":"https://api.github.com/users/tox-rs/repos","events_url":"https://api.github.com/users/tox-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tox-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":118792123,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg3OTIxMjM=","name":"tox","full_name":"tox-rs/tox","private":false,"owner":{"login":"tox-rs","id":35774911,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1Nzc0OTEx","avatar_url":"https://avatars2.githubusercontent.com/u/35774911?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-rs","html_url":"https://github.com/tox-rs","followers_url":"https://api.github.com/users/tox-rs/followers","following_url":"https://api.github.com/users/tox-rs/following{/other_user}","gists_url":"https://api.github.com/users/tox-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-rs/subscriptions","organizations_url":"https://api.github.com/users/tox-rs/orgs","repos_url":"https://api.github.com/users/tox-rs/repos","events_url":"https://api.github.com/users/tox-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tox-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tox-rs/tox","description":"toxcore implementation in Rust","fork":false,"url":"https://api.github.com/repos/tox-rs/tox","forks_url":"https://api.github.com/repos/tox-rs/tox/forks","keys_url":"https://api.github.com/repos/tox-rs/tox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tox-rs/tox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tox-rs/tox/teams","hooks_url":"https://api.github.com/repos/tox-rs/tox/hooks","issue_events_url":"https://api.github.com/repos/tox-rs/tox/issues/events{/number}","events_url":"https://api.github.com/repos/tox-rs/tox/events","assignees_url":"https://api.github.com/repos/tox-rs/tox/assignees{/user}","branches_url":"https://api.github.com/repos/tox-rs/tox/branches{/branch}","tags_url":"https://api.github.com/repos/tox-rs/tox/tags","blobs_url":"https://api.github.com/repos/tox-rs/tox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tox-rs/tox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tox-rs/tox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tox-rs/tox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tox-rs/tox/statuses/{sha}","languages_url":"https://api.github.com/repos/tox-rs/tox/languages","stargazers_url":"https://api.github.com/repos/tox-rs/tox/stargazers","contributors_url":"https://api.github.com/repos/tox-rs/tox/contributors","subscribers_url":"https://api.github.com/repos/tox-rs/tox/subscribers","subscription_url":"https://api.github.com/repos/tox-rs/tox/subscription","commits_url":"https://api.github.com/repos/tox-rs/tox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tox-rs/tox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tox-rs/tox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tox-rs/tox/issues/comments{/number}","contents_url":"https://api.github.com/repos/tox-rs/tox/contents/{+path}","compare_url":"https://api.github.com/repos/tox-rs/tox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tox-rs/tox/merges","archive_url":"https://api.github.com/repos/tox-rs/tox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tox-rs/tox/downloads","issues_url":"https://api.github.com/repos/tox-rs/tox/issues{/number}","pulls_url":"https://api.github.com/repos/tox-rs/tox/pulls{/number}","milestones_url":"https://api.github.com/repos/tox-rs/tox/milestones{/number}","notifications_url":"https://api.github.com/repos/tox-rs/tox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tox-rs/tox/labels{/name}","releases_url":"https://api.github.com/repos/tox-rs/tox/releases{/id}","deployments_url":"https://api.github.com/repos/tox-rs/tox/deployments","created_at":"2018-01-24T16:35:53Z","updated_at":"2018-12-24T17:23:08Z","pushed_at":"2018-12-22T22:49:12Z","git_url":"git://github.com/tox-rs/tox.git","ssh_url":"[email protected]:tox-rs/tox.git","clone_url":"https://github.com/tox-rs/tox.git","svn_url":"https://github.com/tox-rs/tox","homepage":"","size":2762,"stargazers_count":144,"watchers_count":144,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":13,"watchers":144,"default_branch":"master"}},"base":{"label":"tox-rs:master","ref":"master","sha":"c47ea1c9a496dd4c09861bb5126d2e28c5ad8ba3","user":{"login":"tox-rs","id":35774911,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1Nzc0OTEx","avatar_url":"https://avatars2.githubusercontent.com/u/35774911?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-rs","html_url":"https://github.com/tox-rs","followers_url":"https://api.github.com/users/tox-rs/followers","following_url":"https://api.github.com/users/tox-rs/following{/other_user}","gists_url":"https://api.github.com/users/tox-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-rs/subscriptions","organizations_url":"https://api.github.com/users/tox-rs/orgs","repos_url":"https://api.github.com/users/tox-rs/repos","events_url":"https://api.github.com/users/tox-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tox-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":118792123,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg3OTIxMjM=","name":"tox","full_name":"tox-rs/tox","private":false,"owner":{"login":"tox-rs","id":35774911,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1Nzc0OTEx","avatar_url":"https://avatars2.githubusercontent.com/u/35774911?v=4","gravatar_id":"","url":"https://api.github.com/users/tox-rs","html_url":"https://github.com/tox-rs","followers_url":"https://api.github.com/users/tox-rs/followers","following_url":"https://api.github.com/users/tox-rs/following{/other_user}","gists_url":"https://api.github.com/users/tox-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/tox-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tox-rs/subscriptions","organizations_url":"https://api.github.com/users/tox-rs/orgs","repos_url":"https://api.github.com/users/tox-rs/repos","events_url":"https://api.github.com/users/tox-rs/events{/privacy}","received_events_url":"https://api.github.com/users/tox-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tox-rs/tox","description":"toxcore implementation in Rust","fork":false,"url":"https://api.github.com/repos/tox-rs/tox","forks_url":"https://api.github.com/repos/tox-rs/tox/forks","keys_url":"https://api.github.com/repos/tox-rs/tox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tox-rs/tox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tox-rs/tox/teams","hooks_url":"https://api.github.com/repos/tox-rs/tox/hooks","issue_events_url":"https://api.github.com/repos/tox-rs/tox/issues/events{/number}","events_url":"https://api.github.com/repos/tox-rs/tox/events","assignees_url":"https://api.github.com/repos/tox-rs/tox/assignees{/user}","branches_url":"https://api.github.com/repos/tox-rs/tox/branches{/branch}","tags_url":"https://api.github.com/repos/tox-rs/tox/tags","blobs_url":"https://api.github.com/repos/tox-rs/tox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tox-rs/tox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tox-rs/tox/git/refs{/sha}","trees_url":"https://api.github.com/repos/tox-rs/tox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tox-rs/tox/statuses/{sha}","languages_url":"https://api.github.com/repos/tox-rs/tox/languages","stargazers_url":"https://api.github.com/repos/tox-rs/tox/stargazers","contributors_url":"https://api.github.com/repos/tox-rs/tox/contributors","subscribers_url":"https://api.github.com/repos/tox-rs/tox/subscribers","subscription_url":"https://api.github.com/repos/tox-rs/tox/subscription","commits_url":"https://api.github.com/repos/tox-rs/tox/commits{/sha}","git_commits_url":"https://api.github.com/repos/tox-rs/tox/git/commits{/sha}","comments_url":"https://api.github.com/repos/tox-rs/tox/comments{/number}","issue_comment_url":"https://api.github.com/repos/tox-rs/tox/issues/comments{/number}","contents_url":"https://api.github.com/repos/tox-rs/tox/contents/{+path}","compare_url":"https://api.github.com/repos/tox-rs/tox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tox-rs/tox/merges","archive_url":"https://api.github.com/repos/tox-rs/tox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tox-rs/tox/downloads","issues_url":"https://api.github.com/repos/tox-rs/tox/issues{/number}","pulls_url":"https://api.github.com/repos/tox-rs/tox/pulls{/number}","milestones_url":"https://api.github.com/repos/tox-rs/tox/milestones{/number}","notifications_url":"https://api.github.com/repos/tox-rs/tox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tox-rs/tox/labels{/name}","releases_url":"https://api.github.com/repos/tox-rs/tox/releases{/id}","deployments_url":"https://api.github.com/repos/tox-rs/tox/deployments","created_at":"2018-01-24T16:35:53Z","updated_at":"2018-12-24T17:23:08Z","pushed_at":"2018-12-22T22:49:12Z","git_url":"git://github.com/tox-rs/tox.git","ssh_url":"[email protected]:tox-rs/tox.git","clone_url":"https://github.com/tox-rs/tox.git","svn_url":"https://github.com/tox-rs/tox","homepage":"","size":2762,"stargazers_count":144,"watchers_count":144,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":13,"watchers":144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/288"},"html":{"href":"https://github.com/tox-rs/tox/pull/288"},"issue":{"href":"https://api.github.com/repos/tox-rs/tox/issues/288"},"comments":{"href":"https://api.github.com/repos/tox-rs/tox/issues/288/comments"},"review_comments":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/288/comments"},"review_comment":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tox-rs/tox/pulls/288/commits"},"statuses":{"href":"https://api.github.com/repos/tox-rs/tox/statuses/6a4e37e56fa0a682741520419d69838f9c83a5a6"}},"author_association":"MEMBER"}}

8802187351

{"actor":{"display_login":"kpp"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/fimbullinter/wotan/pulls/comments/183159542","pull_request_review_id":114113487,"id":183159542,"diff_hunk":"@@ -0,0 +1,313 @@\n+import * as ts from 'typescript';\n+import { excludeDeclarationFiles, Replacement, typescriptOnly, ConfigurableRule } from '@fimbul/ymir';\n+import {\n+ getLineBreakStyle,\n+ isCallExpression,\n+ isExpressionStatement,\n+ isClassDeclaration,\n+ isClassExpression,\n+ isConstructorDeclaration,\n+ isParameterProperty,\n+ isBinaryExpression,\n+ isPropertyAccessExpression,\n+ isIdentifier,\n+ isPropertyDeclaration,\n+ getPropertyName,\n+ hasSideEffects,\n+ isStringLiteral,\n+} from 'tsutils';\n+\n+export interface Options {\n+ mode: Mode;\n+}\n+\n+export enum Mode {\n+ Never,\n+ WhenPossible,\n+ Consistent,\n+}\n+\n+const FAILURE_STRINGS = {\n+ [Mode.Never]: 'Parameter properties have been disallowed.',\n+ [Mode.WhenPossible]: 'Use parameter properties when possible.',\n+ [Mode.Consistent]: {\n+ canBeParamPropsOnly: 'All parameters can be parameter properties.',\n+ cannotBeParamPropsOnly: 'Only use parameter properties if all parameters can be parameter properties.',\n+ },\n+};\n+\n+@excludeDeclarationFiles\n+@typescriptOnly\n+export class Rule extends ConfigurableRule<Options> {\n+ protected parseOptions(options: { mode: string } | null | undefined): Options {\n+ if (options) {\n+ switch (options.mode) {\n+ case 'consistent':\n+ return { mode: Mode.Consistent };\n+ case 'when-possible':\n+ return { mode: Mode.WhenPossible };\n+ }\n+ }\n+ return { mode: Mode.Never };\n+ }\n+\n+ public apply() {\n+ for (const node of this.context.getFlatAst()) {\n+ if (\n+ (isClassDeclaration(node) || isClassExpression(node)) &&\n+ node.members.filter(isConstructorDeclaration).length > 0\n+ ) {\n+ const construct = node.members.find(\n+ (member) =>\n+ isConstructorDeclaration(member) && member.body !== undefined && member.parent !== undefined,","path":"packages/mimir/src/rules/parameter-properties.ts","position":62,"original_position":62,"commit_id":"c687d527911ee90a3ab14f0b1571077bea0203be","original_commit_id":"c687d527911ee90a3ab14f0b1571077bea0203be","user":{"login":"ajafff","id":11968040,"avatar_url":"https://avatars0.githubusercontent.com/u/11968040?v=4","gravatar_id":"","url":"https://api.github.com/users/ajafff","html_url":"https://github.com/ajafff","followers_url":"https://api.github.com/users/ajafff/followers","following_url":"https://api.github.com/users/ajafff/following{/other_user}","gists_url":"https://api.github.com/users/ajafff/gists{/gist_id}","starred_url":"https://api.github.com/users/ajafff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajafff/subscriptions","organizations_url":"https://api.github.com/users/ajafff/orgs","repos_url":"https://api.github.com/users/ajafff/repos","events_url":"https://api.github.com/users/ajafff/events{/privacy}","received_events_url":"https://api.github.com/users/ajafff/received_events","type":"User","site_admin":false},"body":"`member.parent` will always be defined","created_at":"2018-04-20T20:20:26Z","updated_at":"2018-04-20T21:00:02Z","html_url":"https://github.com/fimbullinter/wotan/pull/189#discussion_r183159542","pull_request_url":"https://api.github.com/repos/fimbullinter/wotan/pulls/189","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/comments/183159542"},"html":{"href":"https://github.com/fimbullinter/wotan/pull/189#discussion_r183159542"},"pull_request":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/189"}}},"pull_request":{"url":"https://api.github.com/repos/fimbullinter/wotan/pulls/189","id":181659848,"html_url":"https://github.com/fimbullinter/wotan/pull/189","diff_url":"https://github.com/fimbullinter/wotan/pull/189.diff","patch_url":"https://github.com/fimbullinter/wotan/pull/189.patch","issue_url":"https://api.github.com/repos/fimbullinter/wotan/issues/189","number":189,"state":"open","locked":false,"title":"new rule // parameter-properties","user":{"login":"aervin","id":13973880,"avatar_url":"https://avatars0.githubusercontent.com/u/13973880?v=4","gravatar_id":"","url":"https://api.github.com/users/aervin","html_url":"https://github.com/aervin","followers_url":"https://api.github.com/users/aervin/followers","following_url":"https://api.github.com/users/aervin/following{/other_user}","gists_url":"https://api.github.com/users/aervin/gists{/gist_id}","starred_url":"https://api.github.com/users/aervin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aervin/subscriptions","organizations_url":"https://api.github.com/users/aervin/orgs","repos_url":"https://api.github.com/users/aervin/repos","events_url":"https://api.github.com/users/aervin/events{/privacy}","received_events_url":"https://api.github.com/users/aervin/received_events","type":"User","site_admin":false},"body":"#### Checklist\r\n\r\n- [X] Fixes: #167 \r\n- [X] Added or updated tests / baselines\r\n- [ ] Documentation update\r\n","created_at":"2018-04-14T18:07:36Z","updated_at":"2018-04-20T21:00:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d0a988bcc8ab3820cb0c211ffa99b45d7d54421","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fimbullinter/wotan/pulls/189/commits","review_comments_url":"https://api.github.com/repos/fimbullinter/wotan/pulls/189/comments","review_comment_url":"https://api.github.com/repos/fimbullinter/wotan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fimbullinter/wotan/issues/189/comments","statuses_url":"https://api.github.com/repos/fimbullinter/wotan/statuses/c687d527911ee90a3ab14f0b1571077bea0203be","head":{"label":"aervin:param-props","ref":"param-props","sha":"c687d527911ee90a3ab14f0b1571077bea0203be","user":{"login":"aervin","id":13973880,"avatar_url":"https://avatars0.githubusercontent.com/u/13973880?v=4","gravatar_id":"","url":"https://api.github.com/users/aervin","html_url":"https://github.com/aervin","followers_url":"https://api.github.com/users/aervin/followers","following_url":"https://api.github.com/users/aervin/following{/other_user}","gists_url":"https://api.github.com/users/aervin/gists{/gist_id}","starred_url":"https://api.github.com/users/aervin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aervin/subscriptions","organizations_url":"https://api.github.com/users/aervin/orgs","repos_url":"https://api.github.com/users/aervin/repos","events_url":"https://api.github.com/users/aervin/events{/privacy}","received_events_url":"https://api.github.com/users/aervin/received_events","type":"User","site_admin":false},"repo":{"id":127985184,"name":"wotan","full_name":"aervin/wotan","owner":{"login":"aervin","id":13973880,"avatar_url":"https://avatars0.githubusercontent.com/u/13973880?v=4","gravatar_id":"","url":"https://api.github.com/users/aervin","html_url":"https://github.com/aervin","followers_url":"https://api.github.com/users/aervin/followers","following_url":"https://api.github.com/users/aervin/following{/other_user}","gists_url":"https://api.github.com/users/aervin/gists{/gist_id}","starred_url":"https://api.github.com/users/aervin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aervin/subscriptions","organizations_url":"https://api.github.com/users/aervin/orgs","repos_url":"https://api.github.com/users/aervin/repos","events_url":"https://api.github.com/users/aervin/events{/privacy}","received_events_url":"https://api.github.com/users/aervin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aervin/wotan","description":"Pluggable TypeScript and JavaScript linter","fork":true,"url":"https://api.github.com/repos/aervin/wotan","forks_url":"https://api.github.com/repos/aervin/wotan/forks","keys_url":"https://api.github.com/repos/aervin/wotan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aervin/wotan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aervin/wotan/teams","hooks_url":"https://api.github.com/repos/aervin/wotan/hooks","issue_events_url":"https://api.github.com/repos/aervin/wotan/issues/events{/number}","events_url":"https://api.github.com/repos/aervin/wotan/events","assignees_url":"https://api.github.com/repos/aervin/wotan/assignees{/user}","branches_url":"https://api.github.com/repos/aervin/wotan/branches{/branch}","tags_url":"https://api.github.com/repos/aervin/wotan/tags","blobs_url":"https://api.github.com/repos/aervin/wotan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aervin/wotan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aervin/wotan/git/refs{/sha}","trees_url":"https://api.github.com/repos/aervin/wotan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aervin/wotan/statuses/{sha}","languages_url":"https://api.github.com/repos/aervin/wotan/languages","stargazers_url":"https://api.github.com/repos/aervin/wotan/stargazers","contributors_url":"https://api.github.com/repos/aervin/wotan/contributors","subscribers_url":"https://api.github.com/repos/aervin/wotan/subscribers","subscription_url":"https://api.github.com/repos/aervin/wotan/subscription","commits_url":"https://api.github.com/repos/aervin/wotan/commits{/sha}","git_commits_url":"https://api.github.com/repos/aervin/wotan/git/commits{/sha}","comments_url":"https://api.github.com/repos/aervin/wotan/comments{/number}","issue_comment_url":"https://api.github.com/repos/aervin/wotan/issues/comments{/number}","contents_url":"https://api.github.com/repos/aervin/wotan/contents/{+path}","compare_url":"https://api.github.com/repos/aervin/wotan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aervin/wotan/merges","archive_url":"https://api.github.com/repos/aervin/wotan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aervin/wotan/downloads","issues_url":"https://api.github.com/repos/aervin/wotan/issues{/number}","pulls_url":"https://api.github.com/repos/aervin/wotan/pulls{/number}","milestones_url":"https://api.github.com/repos/aervin/wotan/milestones{/number}","notifications_url":"https://api.github.com/repos/aervin/wotan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aervin/wotan/labels{/name}","releases_url":"https://api.github.com/repos/aervin/wotan/releases{/id}","deployments_url":"https://api.github.com/repos/aervin/wotan/deployments","created_at":"2018-04-04T00:37:08Z","updated_at":"2018-04-14T15:08:09Z","pushed_at":"2018-04-19T20:19:58Z","git_url":"git://github.com/aervin/wotan.git","ssh_url":"[email protected]:aervin/wotan.git","clone_url":"https://github.com/aervin/wotan.git","svn_url":"https://github.com/aervin/wotan","homepage":null,"size":1110,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fimbullinter:master","ref":"master","sha":"ef32f24b66372ad4a11b7ef83c647eda14e20e43","user":{"login":"fimbullinter","id":35915981,"avatar_url":"https://avatars1.githubusercontent.com/u/35915981?v=4","gravatar_id":"","url":"https://api.github.com/users/fimbullinter","html_url":"https://github.com/fimbullinter","followers_url":"https://api.github.com/users/fimbullinter/followers","following_url":"https://api.github.com/users/fimbullinter/following{/other_user}","gists_url":"https://api.github.com/users/fimbullinter/gists{/gist_id}","starred_url":"https://api.github.com/users/fimbullinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fimbullinter/subscriptions","organizations_url":"https://api.github.com/users/fimbullinter/orgs","repos_url":"https://api.github.com/users/fimbullinter/repos","events_url":"https://api.github.com/users/fimbullinter/events{/privacy}","received_events_url":"https://api.github.com/users/fimbullinter/received_events","type":"Organization","site_admin":false},"repo":{"id":111957557,"name":"wotan","full_name":"fimbullinter/wotan","owner":{"login":"fimbullinter","id":35915981,"avatar_url":"https://avatars1.githubusercontent.com/u/35915981?v=4","gravatar_id":"","url":"https://api.github.com/users/fimbullinter","html_url":"https://github.com/fimbullinter","followers_url":"https://api.github.com/users/fimbullinter/followers","following_url":"https://api.github.com/users/fimbullinter/following{/other_user}","gists_url":"https://api.github.com/users/fimbullinter/gists{/gist_id}","starred_url":"https://api.github.com/users/fimbullinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fimbullinter/subscriptions","organizations_url":"https://api.github.com/users/fimbullinter/orgs","repos_url":"https://api.github.com/users/fimbullinter/repos","events_url":"https://api.github.com/users/fimbullinter/events{/privacy}","received_events_url":"https://api.github.com/users/fimbullinter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fimbullinter/wotan","description":"Pluggable TypeScript and JavaScript linter","fork":false,"url":"https://api.github.com/repos/fimbullinter/wotan","forks_url":"https://api.github.com/repos/fimbullinter/wotan/forks","keys_url":"https://api.github.com/repos/fimbullinter/wotan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fimbullinter/wotan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fimbullinter/wotan/teams","hooks_url":"https://api.github.com/repos/fimbullinter/wotan/hooks","issue_events_url":"https://api.github.com/repos/fimbullinter/wotan/issues/events{/number}","events_url":"https://api.github.com/repos/fimbullinter/wotan/events","assignees_url":"https://api.github.com/repos/fimbullinter/wotan/assignees{/user}","branches_url":"https://api.github.com/repos/fimbullinter/wotan/branches{/branch}","tags_url":"https://api.github.com/repos/fimbullinter/wotan/tags","blobs_url":"https://api.github.com/repos/fimbullinter/wotan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fimbullinter/wotan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fimbullinter/wotan/git/refs{/sha}","trees_url":"https://api.github.com/repos/fimbullinter/wotan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fimbullinter/wotan/statuses/{sha}","languages_url":"https://api.github.com/repos/fimbullinter/wotan/languages","stargazers_url":"https://api.github.com/repos/fimbullinter/wotan/stargazers","contributors_url":"https://api.github.com/repos/fimbullinter/wotan/contributors","subscribers_url":"https://api.github.com/repos/fimbullinter/wotan/subscribers","subscription_url":"https://api.github.com/repos/fimbullinter/wotan/subscription","commits_url":"https://api.github.com/repos/fimbullinter/wotan/commits{/sha}","git_commits_url":"https://api.github.com/repos/fimbullinter/wotan/git/commits{/sha}","comments_url":"https://api.github.com/repos/fimbullinter/wotan/comments{/number}","issue_comment_url":"https://api.github.com/repos/fimbullinter/wotan/issues/comments{/number}","contents_url":"https://api.github.com/repos/fimbullinter/wotan/contents/{+path}","compare_url":"https://api.github.com/repos/fimbullinter/wotan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fimbullinter/wotan/merges","archive_url":"https://api.github.com/repos/fimbullinter/wotan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fimbullinter/wotan/downloads","issues_url":"https://api.github.com/repos/fimbullinter/wotan/issues{/number}","pulls_url":"https://api.github.com/repos/fimbullinter/wotan/pulls{/number}","milestones_url":"https://api.github.com/repos/fimbullinter/wotan/milestones{/number}","notifications_url":"https://api.github.com/repos/fimbullinter/wotan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fimbullinter/wotan/labels{/name}","releases_url":"https://api.github.com/repos/fimbullinter/wotan/releases{/id}","deployments_url":"https://api.github.com/repos/fimbullinter/wotan/deployments","created_at":"2017-11-24T21:43:37Z","updated_at":"2018-04-20T12:07:29Z","pushed_at":"2018-04-20T19:03:21Z","git_url":"git://github.com/fimbullinter/wotan.git","ssh_url":"[email protected]:fimbullinter/wotan.git","clone_url":"https://github.com/fimbullinter/wotan.git","svn_url":"https://github.com/fimbullinter/wotan","homepage":null,"size":1133,"stargazers_count":24,"watchers_count":24,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1,"open_issues":42,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/189"},"html":{"href":"https://github.com/fimbullinter/wotan/pull/189"},"issue":{"href":"https://api.github.com/repos/fimbullinter/wotan/issues/189"},"comments":{"href":"https://api.github.com/repos/fimbullinter/wotan/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fimbullinter/wotan/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/fimbullinter/wotan/statuses/c687d527911ee90a3ab14f0b1571077bea0203be"}},"author_association":"CONTRIBUTOR"}}

7564082079

{"actor":{"display_login":"ajafff"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/comments/176262639","pull_request_review_id":105934196,"id":176262639,"diff_hunk":"@@ -1,99 +1,63 @@\n-Poseidon is Firmament's (http://www.firmament.io) integration with\n-Kubernetes.\n+# Introduction\n+The Poseidon/Firmament scheduler incubation project is to bring integration of Firmament Scheduler (OSDI paper) in Kubernetes.\n+At a very high level, Poseidon/Firmament scheduler augments the \n+current Kubernetes scheduling capabilities by incorporating a new \n+novel flow network graph based scheduling capabilities alongside the default Kubernetes Scheduler. \n+Firmament models workloads on a cluster as flow networks and runs min-cost flow optimizations over these networks to make scheduling decisions.\n \n-[](https://travis-ci.org/camsas/poseidon)\n-[](https://coveralls.io/github/camsas/poseidon?branch=master)\n+Due to the inherent rescheduling capabilities, the new scheduler enables a globally optimal scheduling environment that keeps on refining the dynamic placements of the workload.\n \n-***Note: this repo contains an initial prototype, it may break at any time! :)***\n+As we all know that as part of the Kubernetes multiple schedulers support, each new pod is typically scheduled by the default scheduler, but Kubernetes can be instructed to use another scheduler by specifying the name of another custom scheduler (Poseidon in our case) at the time of pod deployment. In this case, the default scheduler will ignore that Pod and allow Poseidon scheduler to schedule the Pod on a relevant node. We plugin Poseidon as an add-on scheduler to K8s, by using the 'schedulerName' as Poseidon in the pod template this will by-pass the default-scheduler.\n \n-# Getting started\n+# Key Advantages\n \n-The easiest way to get Poseidon up and running is to use our Docker image:\n+* Flow graph scheduling provides the following \n+ * Support for high-volume workloads placement \n+ * Complex rule constraints \n+ * Globally optimal scheduling\n+ * Extremely high scalability. \n+ \n+ **NOTE:** Additionally, it is also very important to highlight that Firmament scales much better than default scheduler as the number of nodes increase in a cluster.\n \n-```\n-$ docker pull camsas/poseidon:dev\n-```\n-Once the image has downloaded, you can start Poseidon as follows:\n-```\n-$ docker run camsas/poseidon:dev poseidon \\\n- --logtostderr \\\n- --kubeConfig=<path_kubeconfig_file> \\\n- --firmamentAddress=<host>:<port> \\\n- --statsServerAddress=<host>:<port> \\\n- --kubeVersion=<Major.Minor>\n-```\n-Note that Poseidon will try to schedule for Kubernetes even if `kube-scheduler`\n-is running. How you best avoid conflicts depends on the version of Kubernetes\n-you are running:\n- 1. If you are using Kubernetes <1.6, shut down `kube-scheduler` first, and make\n- sure your pods are labeled with `scheduler: poseidon`.\n- 2. If you are using Kubernetes 1.6+, you do not have to to shut down\n- `kube-scheduler`, but you must specify `schedulerName: poseidon` in your pod\n- specs.\n+An argument can be made from functional parity standpoint between two scheduling algorithms at this point of time. Currently, Firmament functionally is not at par with the default scheduler, especially for affinity/anti-affinity functionality as well as various other functional features currently supported in the default scheduling algorithm. It would definitely take some time to bridge the functionality gap between two scheduling algorithms. But our argument is that due to the exceptional throughput superiority of Firmament scheduler, certain use cases may not even require additional functional features such as advanced affinity/anti-affinity etc.\n \n-You will also need to ensure that the API server is reachable from the Poseidon\n-container's network (e.g., using `--net=host` if you're running a local\n-development cluster).\n \n-# Building from source\n+# Design \n \n-## System requirements\n+ <p align=\"center\">\n+ <img src=\"docs/poseidon.png\"> \n+<p align=\"center\"> <b>Poseidon Integration architecture</b> </p>\n+</p>\n \n- * Go 1.7+\n- * Docker 1.7+\n- * Kubernetes v1.1+\n \n-A known-good build environment is Ubuntu 14.04.\n \n-## Build process\n+For more details about the design of this project see the [design document](https://docs.google.com/document/d/1VNoaw1GoRK-yop_Oqzn7wZhxMxvN3pdNjuaICjXLarA/edit?usp=sharing) doc.\n \n-Run:\n \n-```\n-$ go build\n-$ go install\n-```\n \n-Following, make sure you have a Kubernetes cluster running. If you're running Ubuntu on amd64 then you can execute:\n+# Installation\n+ In-cluster installation of Poseidon, this method is to run Poseidon and its components in the\n+ kubernetes cluster.\n+ \n+ The following are the components required.\n+ * A [Running Kubernetes cluster](https://kubernetes.io/docs/setup/).\n+ * [Firmament scheduler](https://github.com/Huawei-PaaS/firmament) deployment\n+ * Poseidon deployment\n+ * Heapster with the Poseidon sink.\n+ \n+ Please start [here](https://github.com/shivramsrivastava/poseidon/blob/master/docs/install/README.md).\n+ \n+ \n+ \n+# Development\n+ For developers please refer [here](https://github.com/shivramsrivastava/poseidon/blob/master/docs/devel/README.md)","path":"README.md","position":96,"original_position":96,"commit_id":"540e52dec8856bb0a18bbfaeac13156ed915dc01","original_commit_id":"ef589de58c9a4e360b3042087496bb475b7eba0b","user":{"login":"ms705","id":192315,"avatar_url":"https://avatars3.githubusercontent.com/u/192315?v=4","gravatar_id":"","url":"https://api.github.com/users/ms705","html_url":"https://github.com/ms705","followers_url":"https://api.github.com/users/ms705/followers","following_url":"https://api.github.com/users/ms705/following{/other_user}","gists_url":"https://api.github.com/users/ms705/gists{/gist_id}","starred_url":"https://api.github.com/users/ms705/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ms705/subscriptions","organizations_url":"https://api.github.com/users/ms705/orgs","repos_url":"https://api.github.com/users/ms705/repos","events_url":"https://api.github.com/users/ms705/events{/privacy}","received_events_url":"https://api.github.com/users/ms705/received_events","type":"User","site_admin":false},"body":"Same as above.","created_at":"2018-03-21T22:43:44Z","updated_at":"2018-03-21T22:49:03Z","html_url":"https://github.com/kubernetes-sigs/poseidon/pull/19#discussion_r176262639","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/19","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/comments/176262639"},"html":{"href":"https://github.com/kubernetes-sigs/poseidon/pull/19#discussion_r176262639"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/19"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/19","id":176075526,"html_url":"https://github.com/kubernetes-sigs/poseidon/pull/19","diff_url":"https://github.com/kubernetes-sigs/poseidon/pull/19.diff","patch_url":"https://github.com/kubernetes-sigs/poseidon/pull/19.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/issues/19","number":19,"state":"open","locked":false,"title":"[WIP] Adding scripts and updating README.","user":{"login":"shivramsrivastava","id":6160655,"avatar_url":"https://avatars1.githubusercontent.com/u/6160655?v=4","gravatar_id":"","url":"https://api.github.com/users/shivramsrivastava","html_url":"https://github.com/shivramsrivastava","followers_url":"https://api.github.com/users/shivramsrivastava/followers","following_url":"https://api.github.com/users/shivramsrivastava/following{/other_user}","gists_url":"https://api.github.com/users/shivramsrivastava/gists{/gist_id}","starred_url":"https://api.github.com/users/shivramsrivastava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivramsrivastava/subscriptions","organizations_url":"https://api.github.com/users/shivramsrivastava/orgs","repos_url":"https://api.github.com/users/shivramsrivastava/repos","events_url":"https://api.github.com/users/shivramsrivastava/events{/privacy}","received_events_url":"https://api.github.com/users/shivramsrivastava/received_events","type":"User","site_admin":false},"body":"Updated the deployment scripts to point to the correct config file and correct image.\r\nAdded the heapster deployment yaml.\r\n\r\nThese are standalone script only changes.","created_at":"2018-03-20T02:45:42Z","updated_at":"2018-03-21T22:49:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09a7bb22176bbf5a1610d498e4fa7cdd66284f59","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shashidharatd","id":8734900,"avatar_url":"https://avatars3.githubusercontent.com/u/8734900?v=4","gravatar_id":"","url":"https://api.github.com/users/shashidharatd","html_url":"https://github.com/shashidharatd","followers_url":"https://api.github.com/users/shashidharatd/followers","following_url":"https://api.github.com/users/shashidharatd/following{/other_user}","gists_url":"https://api.github.com/users/shashidharatd/gists{/gist_id}","starred_url":"https://api.github.com/users/shashidharatd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shashidharatd/subscriptions","organizations_url":"https://api.github.com/users/shashidharatd/orgs","repos_url":"https://api.github.com/users/shashidharatd/repos","events_url":"https://api.github.com/users/shashidharatd/events{/privacy}","received_events_url":"https://api.github.com/users/shashidharatd/received_events","type":"User","site_admin":false},{"login":"irfanurrehman","id":10027921,"avatar_url":"https://avatars0.githubusercontent.com/u/10027921?v=4","gravatar_id":"","url":"https://api.github.com/users/irfanurrehman","html_url":"https://github.com/irfanurrehman","followers_url":"https://api.github.com/users/irfanurrehman/followers","following_url":"https://api.github.com/users/irfanurrehman/following{/other_user}","gists_url":"https://api.github.com/users/irfanurrehman/gists{/gist_id}","starred_url":"https://api.github.com/users/irfanurrehman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irfanurrehman/subscriptions","organizations_url":"https://api.github.com/users/irfanurrehman/orgs","repos_url":"https://api.github.com/users/irfanurrehman/repos","events_url":"https://api.github.com/users/irfanurrehman/events{/privacy}","received_events_url":"https://api.github.com/users/irfanurrehman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":866564133,"url":"https://api.github.com/repos/kubernetes-sigs/poseidon/labels/approved","name":"approved","color":"ededed","default":false},{"id":860649558,"url":"https://api.github.com/repos/kubernetes-sigs/poseidon/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"ededed","default":false},{"id":869119839,"url":"https://api.github.com/repos/kubernetes-sigs/poseidon/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"ededed","default":false},{"id":874094176,"url":"https://api.github.com/repos/kubernetes-sigs/poseidon/labels/size/XL","name":"size/XL","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/19/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/19/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/issues/19/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/statuses/540e52dec8856bb0a18bbfaeac13156ed915dc01","head":{"label":"shivramsrivastava:script_changes","ref":"script_changes","sha":"540e52dec8856bb0a18bbfaeac13156ed915dc01","user":{"login":"shivramsrivastava","id":6160655,"avatar_url":"https://avatars1.githubusercontent.com/u/6160655?v=4","gravatar_id":"","url":"https://api.github.com/users/shivramsrivastava","html_url":"https://github.com/shivramsrivastava","followers_url":"https://api.github.com/users/shivramsrivastava/followers","following_url":"https://api.github.com/users/shivramsrivastava/following{/other_user}","gists_url":"https://api.github.com/users/shivramsrivastava/gists{/gist_id}","starred_url":"https://api.github.com/users/shivramsrivastava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivramsrivastava/subscriptions","organizations_url":"https://api.github.com/users/shivramsrivastava/orgs","repos_url":"https://api.github.com/users/shivramsrivastava/repos","events_url":"https://api.github.com/users/shivramsrivastava/events{/privacy}","received_events_url":"https://api.github.com/users/shivramsrivastava/received_events","type":"User","site_admin":false},"repo":{"id":82964797,"name":"poseidon","full_name":"shivramsrivastava/poseidon","owner":{"login":"shivramsrivastava","id":6160655,"avatar_url":"https://avatars1.githubusercontent.com/u/6160655?v=4","gravatar_id":"","url":"https://api.github.com/users/shivramsrivastava","html_url":"https://github.com/shivramsrivastava","followers_url":"https://api.github.com/users/shivramsrivastava/followers","following_url":"https://api.github.com/users/shivramsrivastava/following{/other_user}","gists_url":"https://api.github.com/users/shivramsrivastava/gists{/gist_id}","starred_url":"https://api.github.com/users/shivramsrivastava/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shivramsrivastava/subscriptions","organizations_url":"https://api.github.com/users/shivramsrivastava/orgs","repos_url":"https://api.github.com/users/shivramsrivastava/repos","events_url":"https://api.github.com/users/shivramsrivastava/events{/privacy}","received_events_url":"https://api.github.com/users/shivramsrivastava/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shivramsrivastava/poseidon","description":"Kubernetes integration for Firmament","fork":true,"url":"https://api.github.com/repos/shivramsrivastava/poseidon","forks_url":"https://api.github.com/repos/shivramsrivastava/poseidon/forks","keys_url":"https://api.github.com/repos/shivramsrivastava/poseidon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shivramsrivastava/poseidon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shivramsrivastava/poseidon/teams","hooks_url":"https://api.github.com/repos/shivramsrivastava/poseidon/hooks","issue_events_url":"https://api.github.com/repos/shivramsrivastava/poseidon/issues/events{/number}","events_url":"https://api.github.com/repos/shivramsrivastava/poseidon/events","assignees_url":"https://api.github.com/repos/shivramsrivastava/poseidon/assignees{/user}","branches_url":"https://api.github.com/repos/shivramsrivastava/poseidon/branches{/branch}","tags_url":"https://api.github.com/repos/shivramsrivastava/poseidon/tags","blobs_url":"https://api.github.com/repos/shivramsrivastava/poseidon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shivramsrivastava/poseidon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shivramsrivastava/poseidon/git/refs{/sha}","trees_url":"https://api.github.com/repos/shivramsrivastava/poseidon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shivramsrivastava/poseidon/statuses/{sha}","languages_url":"https://api.github.com/repos/shivramsrivastava/poseidon/languages","stargazers_url":"https://api.github.com/repos/shivramsrivastava/poseidon/stargazers","contributors_url":"https://api.github.com/repos/shivramsrivastava/poseidon/contributors","subscribers_url":"https://api.github.com/repos/shivramsrivastava/poseidon/subscribers","subscription_url":"https://api.github.com/repos/shivramsrivastava/poseidon/subscription","commits_url":"https://api.github.com/repos/shivramsrivastava/poseidon/commits{/sha}","git_commits_url":"https://api.github.com/repos/shivramsrivastava/poseidon/git/commits{/sha}","comments_url":"https://api.github.com/repos/shivramsrivastava/poseidon/comments{/number}","issue_comment_url":"https://api.github.com/repos/shivramsrivastava/poseidon/issues/comments{/number}","contents_url":"https://api.github.com/repos/shivramsrivastava/poseidon/contents/{+path}","compare_url":"https://api.github.com/repos/shivramsrivastava/poseidon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shivramsrivastava/poseidon/merges","archive_url":"https://api.github.com/repos/shivramsrivastava/poseidon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shivramsrivastava/poseidon/downloads","issues_url":"https://api.github.com/repos/shivramsrivastava/poseidon/issues{/number}","pulls_url":"https://api.github.com/repos/shivramsrivastava/poseidon/pulls{/number}","milestones_url":"https://api.github.com/repos/shivramsrivastava/poseidon/milestones{/number}","notifications_url":"https://api.github.com/repos/shivramsrivastava/poseidon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shivramsrivastava/poseidon/labels{/name}","releases_url":"https://api.github.com/repos/shivramsrivastava/poseidon/releases{/id}","deployments_url":"https://api.github.com/repos/shivramsrivastava/poseidon/deployments","created_at":"2017-02-23T19:44:16Z","updated_at":"2017-08-21T17:32:40Z","pushed_at":"2018-03-21T22:48:35Z","git_url":"git://github.com/shivramsrivastava/poseidon.git","ssh_url":"[email protected]:shivramsrivastava/poseidon.git","clone_url":"https://github.com/shivramsrivastava/poseidon.git","svn_url":"https://github.com/shivramsrivastava/poseidon","homepage":"http://www.firmament.io","size":3010,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"67d7d451b94a94963386cf1ade7d5ee0bacca32d","user":{"login":"kubernetes-sigs","id":36015203,"avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":43949742,"name":"poseidon","full_name":"kubernetes-sigs/poseidon","owner":{"login":"kubernetes-sigs","id":36015203,"avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes-sigs/poseidon","description":"A Firmament-based Kubernetes scheduler","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/poseidon","forks_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/poseidon/deployments","created_at":"2015-10-09T10:47:50Z","updated_at":"2018-03-21T18:18:08Z","pushed_at":"2018-03-21T22:48:37Z","git_url":"git://github.com/kubernetes-sigs/poseidon.git","ssh_url":"[email protected]:kubernetes-sigs/poseidon.git","clone_url":"https://github.com/kubernetes-sigs/poseidon.git","svn_url":"https://github.com/kubernetes-sigs/poseidon","homepage":"http://www.firmament.io","size":26875,"stargazers_count":81,"watchers_count":81,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":15,"open_issues":8,"watchers":81,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/19"},"html":{"href":"https://github.com/kubernetes-sigs/poseidon/pull/19"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/issues/19"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/poseidon/statuses/540e52dec8856bb0a18bbfaeac13156ed915dc01"}},"author_association":"COLLABORATOR"}}

7415988782

{"actor":{"display_login":"ms705"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/comments/178440998","pull_request_review_id":108501641,"id":178440998,"diff_hunk":"@@ -0,0 +1,26 @@\n+---\n+layout: post\n+title: Improve the User Experience in your Custom Dev Tools\n+author: Maria Camenzuli\n+---\n+\n+Whether you are writing an internal tool for your colleagues at work, or writing something open source, you should be thinking about the user experience other developers have with your tool. Just like in a client facing app or API, a good user experience in dev tools is incredibly valuable, and requires deliberate thought and consideration to get right.\n+\n+Over the past few months, I've been doing a lot of work on dev tooling. My team at work currently produces and maintains a set of Gradle plugins that automate our software packaging and versioning processes. We are also involved in work done on deployment tooling, which is mostly Ansible complemented by bash and python scripting. Having gone through several iterations of these tools, and listening to feedback from my colleagues who use them, I am writing this article to share with you 3 simple things you can do to improve the user experience in your own custom dev tools.\n+\n+## 1. Take a design first approach to user input.","path":"_posts/2018-3-31-improving-user-experience-in-dev-tools.md","position":11,"original_position":11,"commit_id":"35f2f76c4f35a71fc999326d981c4e1c094b2a5f","original_commit_id":"35f2f76c4f35a71fc999326d981c4e1c094b2a5f","user":{"login":"FrelliBB","id":2591677,"avatar_url":"https://avatars1.githubusercontent.com/u/2591677?v=4","gravatar_id":"","url":"https://api.github.com/users/FrelliBB","html_url":"https://github.com/FrelliBB","followers_url":"https://api.github.com/users/FrelliBB/followers","following_url":"https://api.github.com/users/FrelliBB/following{/other_user}","gists_url":"https://api.github.com/users/FrelliBB/gists{/gist_id}","starred_url":"https://api.github.com/users/FrelliBB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrelliBB/subscriptions","organizations_url":"https://api.github.com/users/FrelliBB/orgs","repos_url":"https://api.github.com/users/FrelliBB/repos","events_url":"https://api.github.com/users/FrelliBB/events{/privacy}","received_events_url":"https://api.github.com/users/FrelliBB/received_events","type":"User","site_admin":false},"body":"I think you should provide some simple example of a bad API design and a good API design when it comes to dev tools. Ex: bad design would be `francesco@toph:~$ myscript true true false`","created_at":"2018-03-31T20:14:57Z","updated_at":"2018-03-31T20:18:55Z","html_url":"https://github.com/purpledevcat/purpledevcat.github.io/pull/5#discussion_r178440998","pull_request_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/comments/178440998"},"html":{"href":"https://github.com/purpledevcat/purpledevcat.github.io/pull/5#discussion_r178440998"},"pull_request":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/5"}}},"pull_request":{"url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/5","id":178698284,"html_url":"https://github.com/purpledevcat/purpledevcat.github.io/pull/5","diff_url":"https://github.com/purpledevcat/purpledevcat.github.io/pull/5.diff","patch_url":"https://github.com/purpledevcat/purpledevcat.github.io/pull/5.patch","issue_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues/5","number":5,"state":"open","locked":false,"title":"Post: Improving the user experience of a dev tool","user":{"login":"maria-camenzuli","id":5031229,"avatar_url":"https://avatars1.githubusercontent.com/u/5031229?v=4","gravatar_id":"","url":"https://api.github.com/users/maria-camenzuli","html_url":"https://github.com/maria-camenzuli","followers_url":"https://api.github.com/users/maria-camenzuli/followers","following_url":"https://api.github.com/users/maria-camenzuli/following{/other_user}","gists_url":"https://api.github.com/users/maria-camenzuli/gists{/gist_id}","starred_url":"https://api.github.com/users/maria-camenzuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maria-camenzuli/subscriptions","organizations_url":"https://api.github.com/users/maria-camenzuli/orgs","repos_url":"https://api.github.com/users/maria-camenzuli/repos","events_url":"https://api.github.com/users/maria-camenzuli/events{/privacy}","received_events_url":"https://api.github.com/users/maria-camenzuli/received_events","type":"User","site_admin":false},"body":"**Changes**\r\n- Added a new post titled `Improve the User Experience in your Custom Dev Tools`.\r\n- Removed the `Hello World` post. I don't feel like it adds any value to the site.","created_at":"2018-03-31T20:07:22Z","updated_at":"2018-03-31T20:18:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1e9e914be425eb4f596dcd02fe637f794aee5050","assignee":{"login":"maria-camenzuli","id":5031229,"avatar_url":"https://avatars1.githubusercontent.com/u/5031229?v=4","gravatar_id":"","url":"https://api.github.com/users/maria-camenzuli","html_url":"https://github.com/maria-camenzuli","followers_url":"https://api.github.com/users/maria-camenzuli/followers","following_url":"https://api.github.com/users/maria-camenzuli/following{/other_user}","gists_url":"https://api.github.com/users/maria-camenzuli/gists{/gist_id}","starred_url":"https://api.github.com/users/maria-camenzuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maria-camenzuli/subscriptions","organizations_url":"https://api.github.com/users/maria-camenzuli/orgs","repos_url":"https://api.github.com/users/maria-camenzuli/repos","events_url":"https://api.github.com/users/maria-camenzuli/events{/privacy}","received_events_url":"https://api.github.com/users/maria-camenzuli/received_events","type":"User","site_admin":false},"assignees":[{"login":"maria-camenzuli","id":5031229,"avatar_url":"https://avatars1.githubusercontent.com/u/5031229?v=4","gravatar_id":"","url":"https://api.github.com/users/maria-camenzuli","html_url":"https://github.com/maria-camenzuli","followers_url":"https://api.github.com/users/maria-camenzuli/followers","following_url":"https://api.github.com/users/maria-camenzuli/following{/other_user}","gists_url":"https://api.github.com/users/maria-camenzuli/gists{/gist_id}","starred_url":"https://api.github.com/users/maria-camenzuli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maria-camenzuli/subscriptions","organizations_url":"https://api.github.com/users/maria-camenzuli/orgs","repos_url":"https://api.github.com/users/maria-camenzuli/repos","events_url":"https://api.github.com/users/maria-camenzuli/events{/privacy}","received_events_url":"https://api.github.com/users/maria-camenzuli/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/5/commits","review_comments_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/5/comments","review_comment_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/comments{/number}","comments_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues/5/comments","statuses_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/statuses/35f2f76c4f35a71fc999326d981c4e1c094b2a5f","head":{"label":"purpledevcat:post-tips-for-writing-gradle-plugin","ref":"post-tips-for-writing-gradle-plugin","sha":"35f2f76c4f35a71fc999326d981c4e1c094b2a5f","user":{"login":"purpledevcat","id":36240549,"avatar_url":"https://avatars2.githubusercontent.com/u/36240549?v=4","gravatar_id":"","url":"https://api.github.com/users/purpledevcat","html_url":"https://github.com/purpledevcat","followers_url":"https://api.github.com/users/purpledevcat/followers","following_url":"https://api.github.com/users/purpledevcat/following{/other_user}","gists_url":"https://api.github.com/users/purpledevcat/gists{/gist_id}","starred_url":"https://api.github.com/users/purpledevcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpledevcat/subscriptions","organizations_url":"https://api.github.com/users/purpledevcat/orgs","repos_url":"https://api.github.com/users/purpledevcat/repos","events_url":"https://api.github.com/users/purpledevcat/events{/privacy}","received_events_url":"https://api.github.com/users/purpledevcat/received_events","type":"Organization","site_admin":false},"repo":{"id":120653386,"name":"purpledevcat.github.io","full_name":"purpledevcat/purpledevcat.github.io","owner":{"login":"purpledevcat","id":36240549,"avatar_url":"https://avatars2.githubusercontent.com/u/36240549?v=4","gravatar_id":"","url":"https://api.github.com/users/purpledevcat","html_url":"https://github.com/purpledevcat","followers_url":"https://api.github.com/users/purpledevcat/followers","following_url":"https://api.github.com/users/purpledevcat/following{/other_user}","gists_url":"https://api.github.com/users/purpledevcat/gists{/gist_id}","starred_url":"https://api.github.com/users/purpledevcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpledevcat/subscriptions","organizations_url":"https://api.github.com/users/purpledevcat/orgs","repos_url":"https://api.github.com/users/purpledevcat/repos","events_url":"https://api.github.com/users/purpledevcat/events{/privacy}","received_events_url":"https://api.github.com/users/purpledevcat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purpledevcat/purpledevcat.github.io","description":"Github Pages site for the organisation.","fork":false,"url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io","forks_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/forks","keys_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/teams","hooks_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/hooks","issue_events_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/events","assignees_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/tags","blobs_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/languages","stargazers_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/stargazers","contributors_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/contributors","subscribers_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/subscribers","subscription_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/subscription","commits_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/merges","archive_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/downloads","issues_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/labels{/name}","releases_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/deployments","created_at":"2018-02-07T18:20:35Z","updated_at":"2018-02-18T18:26:32Z","pushed_at":"2018-03-31T20:07:22Z","git_url":"git://github.com/purpledevcat/purpledevcat.github.io.git","ssh_url":"[email protected]:purpledevcat/purpledevcat.github.io.git","clone_url":"https://github.com/purpledevcat/purpledevcat.github.io.git","svn_url":"https://github.com/purpledevcat/purpledevcat.github.io","homepage":"https://purpledevcat.com","size":75,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"purpledevcat:master","ref":"master","sha":"9b9aa1fe92fa7e60b70fbe8c79b5398de4502cd8","user":{"login":"purpledevcat","id":36240549,"avatar_url":"https://avatars2.githubusercontent.com/u/36240549?v=4","gravatar_id":"","url":"https://api.github.com/users/purpledevcat","html_url":"https://github.com/purpledevcat","followers_url":"https://api.github.com/users/purpledevcat/followers","following_url":"https://api.github.com/users/purpledevcat/following{/other_user}","gists_url":"https://api.github.com/users/purpledevcat/gists{/gist_id}","starred_url":"https://api.github.com/users/purpledevcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpledevcat/subscriptions","organizations_url":"https://api.github.com/users/purpledevcat/orgs","repos_url":"https://api.github.com/users/purpledevcat/repos","events_url":"https://api.github.com/users/purpledevcat/events{/privacy}","received_events_url":"https://api.github.com/users/purpledevcat/received_events","type":"Organization","site_admin":false},"repo":{"id":120653386,"name":"purpledevcat.github.io","full_name":"purpledevcat/purpledevcat.github.io","owner":{"login":"purpledevcat","id":36240549,"avatar_url":"https://avatars2.githubusercontent.com/u/36240549?v=4","gravatar_id":"","url":"https://api.github.com/users/purpledevcat","html_url":"https://github.com/purpledevcat","followers_url":"https://api.github.com/users/purpledevcat/followers","following_url":"https://api.github.com/users/purpledevcat/following{/other_user}","gists_url":"https://api.github.com/users/purpledevcat/gists{/gist_id}","starred_url":"https://api.github.com/users/purpledevcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/purpledevcat/subscriptions","organizations_url":"https://api.github.com/users/purpledevcat/orgs","repos_url":"https://api.github.com/users/purpledevcat/repos","events_url":"https://api.github.com/users/purpledevcat/events{/privacy}","received_events_url":"https://api.github.com/users/purpledevcat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/purpledevcat/purpledevcat.github.io","description":"Github Pages site for the organisation.","fork":false,"url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io","forks_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/forks","keys_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/keys{/key_id}","collaborators_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/teams","hooks_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/hooks","issue_events_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues/events{/number}","events_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/events","assignees_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/assignees{/user}","branches_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/branches{/branch}","tags_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/tags","blobs_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/refs{/sha}","trees_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/trees{/sha}","statuses_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/statuses/{sha}","languages_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/languages","stargazers_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/stargazers","contributors_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/contributors","subscribers_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/subscribers","subscription_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/subscription","commits_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/commits{/sha}","git_commits_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/git/commits{/sha}","comments_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/comments{/number}","issue_comment_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues/comments{/number}","contents_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/contents/{+path}","compare_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/compare/{base}...{head}","merges_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/merges","archive_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/downloads","issues_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues{/number}","pulls_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls{/number}","milestones_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/milestones{/number}","notifications_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/labels{/name}","releases_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/releases{/id}","deployments_url":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/deployments","created_at":"2018-02-07T18:20:35Z","updated_at":"2018-02-18T18:26:32Z","pushed_at":"2018-03-31T20:07:22Z","git_url":"git://github.com/purpledevcat/purpledevcat.github.io.git","ssh_url":"[email protected]:purpledevcat/purpledevcat.github.io.git","clone_url":"https://github.com/purpledevcat/purpledevcat.github.io.git","svn_url":"https://github.com/purpledevcat/purpledevcat.github.io","homepage":"https://purpledevcat.com","size":75,"stargazers_count":1,"watchers_count":1,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/5"},"html":{"href":"https://github.com/purpledevcat/purpledevcat.github.io/pull/5"},"issue":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues/5"},"comments":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/purpledevcat/purpledevcat.github.io/statuses/35f2f76c4f35a71fc999326d981c4e1c094b2a5f"}},"author_association":"CONTRIBUTOR"}}

7462823287

{"actor":{"display_login":"FrelliBB"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/comments/221983017","pull_request_review_id":160761762,"id":221983017,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk4MzAxNw==","diff_hunk":"@@ -1,94 +1,96 @@\n-module RootInsurance::Api\n- module Quote\n- # Create a quote\n- #\n- # @param [Hash] opts The quote details. Depending on +:type+, different options are available. Available types are: +:root_gadgets+, +:root_term+ and +:root_funeral+ See below for details\n- # @return [Hash]\n- #\n- ## == +:root_gadgets+\n- # [model_name (String)] The model name of the gadget\n- #\n- ## == +:root_term+\n- # [cover_amount (Integer)] Amount to cover, in cents. Should be between R100 000 and R5 000 000, inclusive.\n- # [cover_period (String or Symbol)] Duration to cover: +:1_year+, +:2_years+, +:5_years+, +:10_years+, +:15_years+, +:20_years+ or +:whole_life+.\n- # [basic_income_per_month (Integer)] Policyholder's basic monthly income, in cents.\n- # [education_status (String or Symbol)] Policyholder’s education class: +:grade_12_no_matric+, +:grade_12_matric+, +:diploma_or_btech+, +:undergraduate_degree+ or +:professional_degree+\n- # [smoker (Boolean)] Is the policyholder a smoker.\n- # [gender (String or Symbol)] Gender of policyholder. Should be either +:male+ or +:female+.\n- # [age (Integer)] Age of policyholder. Should be between 18 and 63, inclusive.\n- #\n- # == +:root_funeral+\n- # [cover_amount (Integer)] Amount to cover, in cents. Should be between R10k and R50k, inclusive.\n- # [has_spouse (Boolean)] Should a spouse also be covered.\n- # [number_of_children (Integer)] Number of children to include in the policy. Should be between 0 and 8, inclusive\n- # [extended_family_ages (Array<Integer>)] Ages of extended family members to cover.\n- #\n- # @example\n- # client.create_quote(\n- # type: :root_gadgets,\n- # model_name: 'iPhone 6s 64GB LTE')\n- #\n- def create_quote(opts={})\n- type = opts[:type]\n-\n- case type.to_sym\n- when :root_gadgets\n- create_gadget_quote(opts)\n- when :root_term\n- create_term_quote(opts)\n- when :root_funeral\n- create_funeral_quote(opts)\n- else\n- raise ArgumentError(\"Unknown quote type: #{type}\")\n+module RootInsurance\n+ module Api\n+ module Quote\n+ # Create a quote\n+ #\n+ # @param [Hash] opts The quote details. Depending on +:type+, different options are available. Available types are: +:root_gadgets+, +:root_term+ and +:root_funeral+ See below for details\n+ # @return [Hash]\n+ #\n+ ## == +:root_gadgets+\n+ # [model_name (String)] The model name of the gadget\n+ #\n+ ## == +:root_term+\n+ # [cover_amount (Integer)] Amount to cover, in cents. Should be between R100 000 and R5 000 000, inclusive.\n+ # [cover_period (String or Symbol)] Duration to cover: +:1_year+, +:2_years+, +:5_years+, +:10_years+, +:15_years+, +:20_years+ or +:whole_life+.\n+ # [basic_income_per_month (Integer)] Policyholder's basic monthly income, in cents.\n+ # [education_status (String or Symbol)] Policyholder’s education class: +:grade_12_no_matric+, +:grade_12_matric+, +:diploma_or_btech+, +:undergraduate_degree+ or +:professional_degree+\n+ # [smoker (Boolean)] Is the policyholder a smoker.\n+ # [gender (String or Symbol)] Gender of policyholder. Should be either +:male+ or +:female+.\n+ # [age (Integer)] Age of policyholder. Should be between 18 and 63, inclusive.\n+ #\n+ # == +:root_funeral+\n+ # [cover_amount (Integer)] Amount to cover, in cents. Should be between R10k and R50k, inclusive.\n+ # [has_spouse (Boolean)] Should a spouse also be covered.\n+ # [number_of_children (Integer)] Number of children to include in the policy. Should be between 0 and 8, inclusive\n+ # [extended_family_ages (Array<Integer>)] Ages of extended family members to cover.\n+ #\n+ # @example\n+ # client.create_quote(\n+ # type: :root_gadgets,\n+ # model_name: 'iPhone 6s 64GB LTE')\n+ #\n+ def create_quote(opts={})\n+ type = opts[:type]\n+ ","path":"lib/root_insurance/api/quote.rb","position":76,"original_position":76,"commit_id":"548009878dbd584636b3e59abd96e0167a2a2a95","original_commit_id":"548009878dbd584636b3e59abd96e0167a2a2a95","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Layout/TrailingWhitespace: Trailing whitespace detected.","created_at":"2018-10-02T14:50:12Z","updated_at":"2018-10-02T14:50:13Z","html_url":"https://github.com/root-community/root-insurance-ruby/pull/1#discussion_r221983017","pull_request_url":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/comments/221983017"},"html":{"href":"https://github.com/root-community/root-insurance-ruby/pull/1#discussion_r221983017"},"pull_request":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/1","id":219732503,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzMyNTAz","html_url":"https://github.com/root-community/root-insurance-ruby/pull/1","diff_url":"https://github.com/root-community/root-insurance-ruby/pull/1.diff","patch_url":"https://github.com/root-community/root-insurance-ruby/pull/1.patch","issue_url":"https://api.github.com/repos/root-community/root-insurance-ruby/issues/1","number":1,"state":"open","locked":false,"title":"Updated Module Definition","user":{"login":"rijnhardtkotze","id":42969596,"node_id":"MDQ6VXNlcjQyOTY5NTk2","avatar_url":"https://avatars2.githubusercontent.com/u/42969596?v=4","gravatar_id":"","url":"https://api.github.com/users/rijnhardtkotze","html_url":"https://github.com/rijnhardtkotze","followers_url":"https://api.github.com/users/rijnhardtkotze/followers","following_url":"https://api.github.com/users/rijnhardtkotze/following{/other_user}","gists_url":"https://api.github.com/users/rijnhardtkotze/gists{/gist_id}","starred_url":"https://api.github.com/users/rijnhardtkotze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rijnhardtkotze/subscriptions","organizations_url":"https://api.github.com/users/rijnhardtkotze/orgs","repos_url":"https://api.github.com/users/rijnhardtkotze/repos","events_url":"https://api.github.com/users/rijnhardtkotze/events{/privacy}","received_events_url":"https://api.github.com/users/rijnhardtkotze/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-02T14:49:59Z","updated_at":"2018-10-02T14:50:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"789398a3b0db6c5024335c274ab44ad6227f4046","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/1/commits","review_comments_url":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/1/comments","review_comment_url":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-community/root-insurance-ruby/issues/1/comments","statuses_url":"https://api.github.com/repos/root-community/root-insurance-ruby/statuses/548009878dbd584636b3e59abd96e0167a2a2a95","head":{"label":"rijnhardtkotze:rk-module-fix","ref":"rk-module-fix","sha":"548009878dbd584636b3e59abd96e0167a2a2a95","user":{"login":"rijnhardtkotze","id":42969596,"node_id":"MDQ6VXNlcjQyOTY5NTk2","avatar_url":"https://avatars2.githubusercontent.com/u/42969596?v=4","gravatar_id":"","url":"https://api.github.com/users/rijnhardtkotze","html_url":"https://github.com/rijnhardtkotze","followers_url":"https://api.github.com/users/rijnhardtkotze/followers","following_url":"https://api.github.com/users/rijnhardtkotze/following{/other_user}","gists_url":"https://api.github.com/users/rijnhardtkotze/gists{/gist_id}","starred_url":"https://api.github.com/users/rijnhardtkotze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rijnhardtkotze/subscriptions","organizations_url":"https://api.github.com/users/rijnhardtkotze/orgs","repos_url":"https://api.github.com/users/rijnhardtkotze/repos","events_url":"https://api.github.com/users/rijnhardtkotze/events{/privacy}","received_events_url":"https://api.github.com/users/rijnhardtkotze/received_events","type":"User","site_admin":false},"repo":{"id":151271232,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyNzEyMzI=","name":"root-insurance-ruby","full_name":"rijnhardtkotze/root-insurance-ruby","private":false,"owner":{"login":"rijnhardtkotze","id":42969596,"node_id":"MDQ6VXNlcjQyOTY5NTk2","avatar_url":"https://avatars2.githubusercontent.com/u/42969596?v=4","gravatar_id":"","url":"https://api.github.com/users/rijnhardtkotze","html_url":"https://github.com/rijnhardtkotze","followers_url":"https://api.github.com/users/rijnhardtkotze/followers","following_url":"https://api.github.com/users/rijnhardtkotze/following{/other_user}","gists_url":"https://api.github.com/users/rijnhardtkotze/gists{/gist_id}","starred_url":"https://api.github.com/users/rijnhardtkotze/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rijnhardtkotze/subscriptions","organizations_url":"https://api.github.com/users/rijnhardtkotze/orgs","repos_url":"https://api.github.com/users/rijnhardtkotze/repos","events_url":"https://api.github.com/users/rijnhardtkotze/events{/privacy}","received_events_url":"https://api.github.com/users/rijnhardtkotze/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rijnhardtkotze/root-insurance-ruby","description":"A wrapper around Root's Insurance API","fork":true,"url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby","forks_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/forks","keys_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/teams","hooks_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/hooks","issue_events_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/events","assignees_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/tags","blobs_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/languages","stargazers_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/stargazers","contributors_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/contributors","subscribers_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/subscribers","subscription_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/subscription","commits_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/merges","archive_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/downloads","issues_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/labels{/name}","releases_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/rijnhardtkotze/root-insurance-ruby/deployments","created_at":"2018-10-02T14:45:09Z","updated_at":"2018-10-02T14:45:11Z","pushed_at":"2018-10-02T14:49:20Z","git_url":"git://github.com/rijnhardtkotze/root-insurance-ruby.git","ssh_url":"[email protected]:rijnhardtkotze/root-insurance-ruby.git","clone_url":"https://github.com/rijnhardtkotze/root-insurance-ruby.git","svn_url":"https://github.com/rijnhardtkotze/root-insurance-ruby","homepage":"","size":104,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-community:master","ref":"master","sha":"b15152dd8c787e986c1decba37fc1ef91e46d46c","user":{"login":"root-community","id":36500702,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTAwNzAy","avatar_url":"https://avatars1.githubusercontent.com/u/36500702?v=4","gravatar_id":"","url":"https://api.github.com/users/root-community","html_url":"https://github.com/root-community","followers_url":"https://api.github.com/users/root-community/followers","following_url":"https://api.github.com/users/root-community/following{/other_user}","gists_url":"https://api.github.com/users/root-community/gists{/gist_id}","starred_url":"https://api.github.com/users/root-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-community/subscriptions","organizations_url":"https://api.github.com/users/root-community/orgs","repos_url":"https://api.github.com/users/root-community/repos","events_url":"https://api.github.com/users/root-community/events{/privacy}","received_events_url":"https://api.github.com/users/root-community/received_events","type":"Organization","site_admin":false},"repo":{"id":121608573,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2MDg1NzM=","name":"root-insurance-ruby","full_name":"root-community/root-insurance-ruby","private":false,"owner":{"login":"root-community","id":36500702,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTAwNzAy","avatar_url":"https://avatars1.githubusercontent.com/u/36500702?v=4","gravatar_id":"","url":"https://api.github.com/users/root-community","html_url":"https://github.com/root-community","followers_url":"https://api.github.com/users/root-community/followers","following_url":"https://api.github.com/users/root-community/following{/other_user}","gists_url":"https://api.github.com/users/root-community/gists{/gist_id}","starred_url":"https://api.github.com/users/root-community/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-community/subscriptions","organizations_url":"https://api.github.com/users/root-community/orgs","repos_url":"https://api.github.com/users/root-community/repos","events_url":"https://api.github.com/users/root-community/events{/privacy}","received_events_url":"https://api.github.com/users/root-community/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/root-community/root-insurance-ruby","description":"A wrapper around Root's Insurance API","fork":true,"url":"https://api.github.com/repos/root-community/root-insurance-ruby","forks_url":"https://api.github.com/repos/root-community/root-insurance-ruby/forks","keys_url":"https://api.github.com/repos/root-community/root-insurance-ruby/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-community/root-insurance-ruby/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-community/root-insurance-ruby/teams","hooks_url":"https://api.github.com/repos/root-community/root-insurance-ruby/hooks","issue_events_url":"https://api.github.com/repos/root-community/root-insurance-ruby/issues/events{/number}","events_url":"https://api.github.com/repos/root-community/root-insurance-ruby/events","assignees_url":"https://api.github.com/repos/root-community/root-insurance-ruby/assignees{/user}","branches_url":"https://api.github.com/repos/root-community/root-insurance-ruby/branches{/branch}","tags_url":"https://api.github.com/repos/root-community/root-insurance-ruby/tags","blobs_url":"https://api.github.com/repos/root-community/root-insurance-ruby/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-community/root-insurance-ruby/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-community/root-insurance-ruby/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-community/root-insurance-ruby/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-community/root-insurance-ruby/statuses/{sha}","languages_url":"https://api.github.com/repos/root-community/root-insurance-ruby/languages","stargazers_url":"https://api.github.com/repos/root-community/root-insurance-ruby/stargazers","contributors_url":"https://api.github.com/repos/root-community/root-insurance-ruby/contributors","subscribers_url":"https://api.github.com/repos/root-community/root-insurance-ruby/subscribers","subscription_url":"https://api.github.com/repos/root-community/root-insurance-ruby/subscription","commits_url":"https://api.github.com/repos/root-community/root-insurance-ruby/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-community/root-insurance-ruby/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-community/root-insurance-ruby/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-community/root-insurance-ruby/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-community/root-insurance-ruby/contents/{+path}","compare_url":"https://api.github.com/repos/root-community/root-insurance-ruby/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-community/root-insurance-ruby/merges","archive_url":"https://api.github.com/repos/root-community/root-insurance-ruby/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-community/root-insurance-ruby/downloads","issues_url":"https://api.github.com/repos/root-community/root-insurance-ruby/issues{/number}","pulls_url":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls{/number}","milestones_url":"https://api.github.com/repos/root-community/root-insurance-ruby/milestones{/number}","notifications_url":"https://api.github.com/repos/root-community/root-insurance-ruby/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-community/root-insurance-ruby/labels{/name}","releases_url":"https://api.github.com/repos/root-community/root-insurance-ruby/releases{/id}","deployments_url":"https://api.github.com/repos/root-community/root-insurance-ruby/deployments","created_at":"2018-02-15T08:59:55Z","updated_at":"2018-06-01T09:36:29Z","pushed_at":"2018-10-02T14:50:00Z","git_url":"git://github.com/root-community/root-insurance-ruby.git","ssh_url":"[email protected]:root-community/root-insurance-ruby.git","clone_url":"https://github.com/root-community/root-insurance-ruby.git","svn_url":"https://github.com/root-community/root-insurance-ruby","homepage":"","size":104,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/1"},"html":{"href":"https://github.com/root-community/root-insurance-ruby/pull/1"},"issue":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/issues/1"},"comments":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/root-community/root-insurance-ruby/statuses/548009878dbd584636b3e59abd96e0167a2a2a95"}},"author_association":"NONE"}}

8355068746

{"actor":{"display_login":"houndci-bot"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/comments/181541831","pull_request_review_id":112197103,"id":181541831,"diff_hunk":"@@ -0,0 +1,3 @@\n+\u001D\u0016a�?�^4\rO\u0003rv�\u0012�\u0018���\u00071����\u0016�WJ�=GJ��WT��r�7/(���~wݒ�\u000FPu�\u001BT\r�\u0006��Kv�>��4Ξq&��A�w��\u0011��0�n5��7�4���\u001F\u0011�ۤbe8eJI��*��Z��\u0018�\\�-s��@\u0007,I�{<��Rq]\u000B�&�\tn��\u0014�}SR��D��s\u0010\"��wv-�S�a7\u000E+x\u0015\u0014J �/|��s)�\u0015\u0003��\b\u0006���^rE%\u0005�h5�j�kO9.���h�r։V\u000F��?9�4�.�T\u001Cs\u0007�\u0019��CL\u0011��8\u0007+\t��","path":"src/test/data/XmlAddressBookStorageTest/encryptedAliceBensonAddressBook.xml","position":null,"original_position":1,"commit_id":"963e72e34add9289294a72f20b524819a34b9d5b","original_commit_id":"963e72e34add9289294a72f20b524819a34b9d5b","user":{"login":"jingyinno","id":26522439,"avatar_url":"https://avatars3.githubusercontent.com/u/26522439?v=4","gravatar_id":"","url":"https://api.github.com/users/jingyinno","html_url":"https://github.com/jingyinno","followers_url":"https://api.github.com/users/jingyinno/followers","following_url":"https://api.github.com/users/jingyinno/following{/other_user}","gists_url":"https://api.github.com/users/jingyinno/gists{/gist_id}","starred_url":"https://api.github.com/users/jingyinno/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingyinno/subscriptions","organizations_url":"https://api.github.com/users/jingyinno/orgs","repos_url":"https://api.github.com/users/jingyinno/repos","events_url":"https://api.github.com/users/jingyinno/events{/privacy}","received_events_url":"https://api.github.com/users/jingyinno/received_events","type":"User","site_admin":false},"body":"Supposed to be encrypted?","created_at":"2018-04-14T04:55:35Z","updated_at":"2018-04-14T04:56:19Z","html_url":"https://github.com/CS2103JAN2018-W11-B4/main/pull/230#discussion_r181541831","pull_request_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/230","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/comments/181541831"},"html":{"href":"https://github.com/CS2103JAN2018-W11-B4/main/pull/230#discussion_r181541831"},"pull_request":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/230"}}},"pull_request":{"url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/230","id":181594571,"html_url":"https://github.com/CS2103JAN2018-W11-B4/main/pull/230","diff_url":"https://github.com/CS2103JAN2018-W11-B4/main/pull/230.diff","patch_url":"https://github.com/CS2103JAN2018-W11-B4/main/pull/230.patch","issue_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/issues/230","number":230,"state":"open","locked":false,"title":"Add test cases for Export command","user":{"login":"Caijun7","id":28557835,"avatar_url":"https://avatars1.githubusercontent.com/u/28557835?v=4","gravatar_id":"","url":"https://api.github.com/users/Caijun7","html_url":"https://github.com/Caijun7","followers_url":"https://api.github.com/users/Caijun7/followers","following_url":"https://api.github.com/users/Caijun7/following{/other_user}","gists_url":"https://api.github.com/users/Caijun7/gists{/gist_id}","starred_url":"https://api.github.com/users/Caijun7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caijun7/subscriptions","organizations_url":"https://api.github.com/users/Caijun7/orgs","repos_url":"https://api.github.com/users/Caijun7/repos","events_url":"https://api.github.com/users/Caijun7/events{/privacy}","received_events_url":"https://api.github.com/users/Caijun7/received_events","type":"User","site_admin":false},"body":"Refer to issue: #229","created_at":"2018-04-13T20:57:47Z","updated_at":"2018-04-14T04:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ca2a63388498afef642e38d2f3a897be1c44b2cb","assignee":{"login":"Caijun7","id":28557835,"avatar_url":"https://avatars1.githubusercontent.com/u/28557835?v=4","gravatar_id":"","url":"https://api.github.com/users/Caijun7","html_url":"https://github.com/Caijun7","followers_url":"https://api.github.com/users/Caijun7/followers","following_url":"https://api.github.com/users/Caijun7/following{/other_user}","gists_url":"https://api.github.com/users/Caijun7/gists{/gist_id}","starred_url":"https://api.github.com/users/Caijun7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caijun7/subscriptions","organizations_url":"https://api.github.com/users/Caijun7/orgs","repos_url":"https://api.github.com/users/Caijun7/repos","events_url":"https://api.github.com/users/Caijun7/events{/privacy}","received_events_url":"https://api.github.com/users/Caijun7/received_events","type":"User","site_admin":false},"assignees":[{"login":"Caijun7","id":28557835,"avatar_url":"https://avatars1.githubusercontent.com/u/28557835?v=4","gravatar_id":"","url":"https://api.github.com/users/Caijun7","html_url":"https://github.com/Caijun7","followers_url":"https://api.github.com/users/Caijun7/followers","following_url":"https://api.github.com/users/Caijun7/following{/other_user}","gists_url":"https://api.github.com/users/Caijun7/gists{/gist_id}","starred_url":"https://api.github.com/users/Caijun7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caijun7/subscriptions","organizations_url":"https://api.github.com/users/Caijun7/orgs","repos_url":"https://api.github.com/users/Caijun7/repos","events_url":"https://api.github.com/users/Caijun7/events{/privacy}","received_events_url":"https://api.github.com/users/Caijun7/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"yeggasd","id":21959620,"avatar_url":"https://avatars0.githubusercontent.com/u/21959620?v=4","gravatar_id":"","url":"https://api.github.com/users/yeggasd","html_url":"https://github.com/yeggasd","followers_url":"https://api.github.com/users/yeggasd/followers","following_url":"https://api.github.com/users/yeggasd/following{/other_user}","gists_url":"https://api.github.com/users/yeggasd/gists{/gist_id}","starred_url":"https://api.github.com/users/yeggasd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yeggasd/subscriptions","organizations_url":"https://api.github.com/users/yeggasd/orgs","repos_url":"https://api.github.com/users/yeggasd/repos","events_url":"https://api.github.com/users/yeggasd/events{/privacy}","received_events_url":"https://api.github.com/users/yeggasd/received_events","type":"User","site_admin":false},{"login":"AzuraAiR","id":22815038,"avatar_url":"https://avatars2.githubusercontent.com/u/22815038?v=4","gravatar_id":"","url":"https://api.github.com/users/AzuraAiR","html_url":"https://github.com/AzuraAiR","followers_url":"https://api.github.com/users/AzuraAiR/followers","following_url":"https://api.github.com/users/AzuraAiR/following{/other_user}","gists_url":"https://api.github.com/users/AzuraAiR/gists{/gist_id}","starred_url":"https://api.github.com/users/AzuraAiR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AzuraAiR/subscriptions","organizations_url":"https://api.github.com/users/AzuraAiR/orgs","repos_url":"https://api.github.com/users/AzuraAiR/repos","events_url":"https://api.github.com/users/AzuraAiR/events{/privacy}","received_events_url":"https://api.github.com/users/AzuraAiR/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":865350257,"url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/labels/do.not.merge","name":"do.not.merge","color":"b60205","default":false},{"id":865348965,"url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/labels/priority.high","name":"priority.high","color":"ff69b4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/230/commits","review_comments_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/230/comments","review_comment_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/issues/230/comments","statuses_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/statuses/963e72e34add9289294a72f20b524819a34b9d5b","head":{"label":"Caijun7:ExportCommand","ref":"ExportCommand","sha":"963e72e34add9289294a72f20b524819a34b9d5b","user":{"login":"Caijun7","id":28557835,"avatar_url":"https://avatars1.githubusercontent.com/u/28557835?v=4","gravatar_id":"","url":"https://api.github.com/users/Caijun7","html_url":"https://github.com/Caijun7","followers_url":"https://api.github.com/users/Caijun7/followers","following_url":"https://api.github.com/users/Caijun7/following{/other_user}","gists_url":"https://api.github.com/users/Caijun7/gists{/gist_id}","starred_url":"https://api.github.com/users/Caijun7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caijun7/subscriptions","organizations_url":"https://api.github.com/users/Caijun7/orgs","repos_url":"https://api.github.com/users/Caijun7/repos","events_url":"https://api.github.com/users/Caijun7/events{/privacy}","received_events_url":"https://api.github.com/users/Caijun7/received_events","type":"User","site_admin":false},"repo":{"id":123396921,"name":"addressbook-level4","full_name":"Caijun7/addressbook-level4","owner":{"login":"Caijun7","id":28557835,"avatar_url":"https://avatars1.githubusercontent.com/u/28557835?v=4","gravatar_id":"","url":"https://api.github.com/users/Caijun7","html_url":"https://github.com/Caijun7","followers_url":"https://api.github.com/users/Caijun7/followers","following_url":"https://api.github.com/users/Caijun7/following{/other_user}","gists_url":"https://api.github.com/users/Caijun7/gists{/gist_id}","starred_url":"https://api.github.com/users/Caijun7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Caijun7/subscriptions","organizations_url":"https://api.github.com/users/Caijun7/orgs","repos_url":"https://api.github.com/users/Caijun7/repos","events_url":"https://api.github.com/users/Caijun7/events{/privacy}","received_events_url":"https://api.github.com/users/Caijun7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Caijun7/addressbook-level4","description":"Address Book sample application (Level 4)","fork":true,"url":"https://api.github.com/repos/Caijun7/addressbook-level4","forks_url":"https://api.github.com/repos/Caijun7/addressbook-level4/forks","keys_url":"https://api.github.com/repos/Caijun7/addressbook-level4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Caijun7/addressbook-level4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Caijun7/addressbook-level4/teams","hooks_url":"https://api.github.com/repos/Caijun7/addressbook-level4/hooks","issue_events_url":"https://api.github.com/repos/Caijun7/addressbook-level4/issues/events{/number}","events_url":"https://api.github.com/repos/Caijun7/addressbook-level4/events","assignees_url":"https://api.github.com/repos/Caijun7/addressbook-level4/assignees{/user}","branches_url":"https://api.github.com/repos/Caijun7/addressbook-level4/branches{/branch}","tags_url":"https://api.github.com/repos/Caijun7/addressbook-level4/tags","blobs_url":"https://api.github.com/repos/Caijun7/addressbook-level4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Caijun7/addressbook-level4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Caijun7/addressbook-level4/git/refs{/sha}","trees_url":"https://api.github.com/repos/Caijun7/addressbook-level4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Caijun7/addressbook-level4/statuses/{sha}","languages_url":"https://api.github.com/repos/Caijun7/addressbook-level4/languages","stargazers_url":"https://api.github.com/repos/Caijun7/addressbook-level4/stargazers","contributors_url":"https://api.github.com/repos/Caijun7/addressbook-level4/contributors","subscribers_url":"https://api.github.com/repos/Caijun7/addressbook-level4/subscribers","subscription_url":"https://api.github.com/repos/Caijun7/addressbook-level4/subscription","commits_url":"https://api.github.com/repos/Caijun7/addressbook-level4/commits{/sha}","git_commits_url":"https://api.github.com/repos/Caijun7/addressbook-level4/git/commits{/sha}","comments_url":"https://api.github.com/repos/Caijun7/addressbook-level4/comments{/number}","issue_comment_url":"https://api.github.com/repos/Caijun7/addressbook-level4/issues/comments{/number}","contents_url":"https://api.github.com/repos/Caijun7/addressbook-level4/contents/{+path}","compare_url":"https://api.github.com/repos/Caijun7/addressbook-level4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Caijun7/addressbook-level4/merges","archive_url":"https://api.github.com/repos/Caijun7/addressbook-level4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Caijun7/addressbook-level4/downloads","issues_url":"https://api.github.com/repos/Caijun7/addressbook-level4/issues{/number}","pulls_url":"https://api.github.com/repos/Caijun7/addressbook-level4/pulls{/number}","milestones_url":"https://api.github.com/repos/Caijun7/addressbook-level4/milestones{/number}","notifications_url":"https://api.github.com/repos/Caijun7/addressbook-level4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Caijun7/addressbook-level4/labels{/name}","releases_url":"https://api.github.com/repos/Caijun7/addressbook-level4/releases{/id}","deployments_url":"https://api.github.com/repos/Caijun7/addressbook-level4/deployments","created_at":"2018-03-01T07:11:05Z","updated_at":"2018-04-10T17:14:43Z","pushed_at":"2018-04-13T21:25:28Z","git_url":"git://github.com/Caijun7/addressbook-level4.git","ssh_url":"[email protected]:Caijun7/addressbook-level4.git","clone_url":"https://github.com/Caijun7/addressbook-level4.git","svn_url":"https://github.com/Caijun7/addressbook-level4","homepage":"https://nus-cs2103-ay1718s2.github.io/addressbook-level4/","size":16218,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CS2103JAN2018-W11-B4:master","ref":"master","sha":"7b2ecf19108060bff6520ed7de67f45fcee4e582","user":{"login":"CS2103JAN2018-W11-B4","id":36947616,"avatar_url":"https://avatars3.githubusercontent.com/u/36947616?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103JAN2018-W11-B4","html_url":"https://github.com/CS2103JAN2018-W11-B4","followers_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/followers","following_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/following{/other_user}","gists_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/subscriptions","organizations_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/orgs","repos_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/repos","events_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/received_events","type":"Organization","site_admin":false},"repo":{"id":123395476,"name":"main","full_name":"CS2103JAN2018-W11-B4/main","owner":{"login":"CS2103JAN2018-W11-B4","id":36947616,"avatar_url":"https://avatars3.githubusercontent.com/u/36947616?v=4","gravatar_id":"","url":"https://api.github.com/users/CS2103JAN2018-W11-B4","html_url":"https://github.com/CS2103JAN2018-W11-B4","followers_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/followers","following_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/following{/other_user}","gists_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/gists{/gist_id}","starred_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/subscriptions","organizations_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/orgs","repos_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/repos","events_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/events{/privacy}","received_events_url":"https://api.github.com/users/CS2103JAN2018-W11-B4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CS2103JAN2018-W11-B4/main","description":"StardyTogether","fork":true,"url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main","forks_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/forks","keys_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/teams","hooks_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/hooks","issue_events_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/issues/events{/number}","events_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/events","assignees_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/assignees{/user}","branches_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/branches{/branch}","tags_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/tags","blobs_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/git/refs{/sha}","trees_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/statuses/{sha}","languages_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/languages","stargazers_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/stargazers","contributors_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/contributors","subscribers_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/subscribers","subscription_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/subscription","commits_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/commits{/sha}","git_commits_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/git/commits{/sha}","comments_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/comments{/number}","issue_comment_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/issues/comments{/number}","contents_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/contents/{+path}","compare_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/merges","archive_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/downloads","issues_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/issues{/number}","pulls_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls{/number}","milestones_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/milestones{/number}","notifications_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/labels{/name}","releases_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/releases{/id}","deployments_url":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/deployments","created_at":"2018-03-01T06:56:48Z","updated_at":"2018-04-13T16:23:39Z","pushed_at":"2018-04-14T04:38:43Z","git_url":"git://github.com/CS2103JAN2018-W11-B4/main.git","ssh_url":"[email protected]:CS2103JAN2018-W11-B4/main.git","clone_url":"https://github.com/CS2103JAN2018-W11-B4/main.git","svn_url":"https://github.com/CS2103JAN2018-W11-B4/main","homepage":"https://cs2103jan2018-w11-b4.github.io/main/","size":16506,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":25,"license":null,"forks":4,"open_issues":25,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/230"},"html":{"href":"https://github.com/CS2103JAN2018-W11-B4/main/pull/230"},"issue":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/issues/230"},"comments":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/CS2103JAN2018-W11-B4/main/statuses/963e72e34add9289294a72f20b524819a34b9d5b"}},"author_association":"NONE"}}

7529445745

{"actor":{"display_login":"jingyinno"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/hapipal/schwifty/pulls/comments/183440070","pull_request_review_id":114438576,"id":183440070,"diff_hunk":"@@ -55,6 +56,55 @@ exports.plugin = {\n server.ext('onPreStart', internals.initialize);\n server.ext('onPostStop', internals.stop);\n \n+ // Expose an hpal command for schwifty-migration\n+ server.expose('commands', {\n+ 'migrate:diff': (initializedServer, args, rootDir, ctx) => {\n+\n+ const SchwiftyMigrateDiff = require('./schwifty-migrate-diff').get();\n+\n+ if (!SchwiftyMigrateDiff) {\n+ throw new ctx.DisplayError('To use this command please first install `npm install --save-dev schwifty-migrate-diff`');\n+ }\n+\n+ const [mode, migrationName, argsMigrationsDir] = args;","path":"lib/index.js","position":null,"original_position":21,"commit_id":"f1ccd3eab91beaf6fc5c12f73a0e3cab400406a3","original_commit_id":"5faf12f6741b410cf8238265d664c137f817493c","user":{"login":"wswoodruff","id":9013245,"avatar_url":"https://avatars1.githubusercontent.com/u/9013245?v=4","gravatar_id":"","url":"https://api.github.com/users/wswoodruff","html_url":"https://github.com/wswoodruff","followers_url":"https://api.github.com/users/wswoodruff/followers","following_url":"https://api.github.com/users/wswoodruff/following{/other_user}","gists_url":"https://api.github.com/users/wswoodruff/gists{/gist_id}","starred_url":"https://api.github.com/users/wswoodruff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wswoodruff/subscriptions","organizations_url":"https://api.github.com/users/wswoodruff/orgs","repos_url":"https://api.github.com/users/wswoodruff/repos","events_url":"https://api.github.com/users/wswoodruff/events{/privacy}","received_events_url":"https://api.github.com/users/wswoodruff/received_events","type":"User","site_admin":false},"body":"These are all optional, and they are validated in schwifty-migrate-diff","created_at":"2018-04-23T15:35:45Z","updated_at":"2018-04-23T15:35:45Z","html_url":"https://github.com/hapipal/schwifty/pull/56#discussion_r183440070","pull_request_url":"https://api.github.com/repos/hapipal/schwifty/pulls/56","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hapipal/schwifty/pulls/comments/183440070"},"html":{"href":"https://github.com/hapipal/schwifty/pull/56#discussion_r183440070"},"pull_request":{"href":"https://api.github.com/repos/hapipal/schwifty/pulls/56"}},"in_reply_to_id":183151443},"pull_request":{"url":"https://api.github.com/repos/hapipal/schwifty/pulls/56","id":175034079,"html_url":"https://github.com/hapipal/schwifty/pull/56","diff_url":"https://github.com/hapipal/schwifty/pull/56.diff","patch_url":"https://github.com/hapipal/schwifty/pull/56.patch","issue_url":"https://api.github.com/repos/hapipal/schwifty/issues/56","number":56,"state":"open","locked":false,"title":"Add `hpal run schwifty:migrate:diff` command","user":{"login":"wswoodruff","id":9013245,"avatar_url":"https://avatars1.githubusercontent.com/u/9013245?v=4","gravatar_id":"","url":"https://api.github.com/users/wswoodruff","html_url":"https://github.com/wswoodruff","followers_url":"https://api.github.com/users/wswoodruff/followers","following_url":"https://api.github.com/users/wswoodruff/following{/other_user}","gists_url":"https://api.github.com/users/wswoodruff/gists{/gist_id}","starred_url":"https://api.github.com/users/wswoodruff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wswoodruff/subscriptions","organizations_url":"https://api.github.com/users/wswoodruff/orgs","repos_url":"https://api.github.com/users/wswoodruff/repos","events_url":"https://api.github.com/users/wswoodruff/events{/privacy}","received_events_url":"https://api.github.com/users/wswoodruff/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-14T17:41:48Z","updated_at":"2018-04-23T15:35:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f7fa26b7008d0a31b588cb5b4a7cd54142c2361","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hapipal/schwifty/pulls/56/commits","review_comments_url":"https://api.github.com/repos/hapipal/schwifty/pulls/56/comments","review_comment_url":"https://api.github.com/repos/hapipal/schwifty/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hapipal/schwifty/issues/56/comments","statuses_url":"https://api.github.com/repos/hapipal/schwifty/statuses/f1ccd3eab91beaf6fc5c12f73a0e3cab400406a3","head":{"label":"hapipal:add-hpal-schwifty-migration-command","ref":"add-hpal-schwifty-migration-command","sha":"f1ccd3eab91beaf6fc5c12f73a0e3cab400406a3","user":{"login":"hapipal","id":36996446,"avatar_url":"https://avatars0.githubusercontent.com/u/36996446?v=4","gravatar_id":"","url":"https://api.github.com/users/hapipal","html_url":"https://github.com/hapipal","followers_url":"https://api.github.com/users/hapipal/followers","following_url":"https://api.github.com/users/hapipal/following{/other_user}","gists_url":"https://api.github.com/users/hapipal/gists{/gist_id}","starred_url":"https://api.github.com/users/hapipal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapipal/subscriptions","organizations_url":"https://api.github.com/users/hapipal/orgs","repos_url":"https://api.github.com/users/hapipal/repos","events_url":"https://api.github.com/users/hapipal/events{/privacy}","received_events_url":"https://api.github.com/users/hapipal/received_events","type":"Organization","site_admin":false},"repo":{"id":75424160,"name":"schwifty","full_name":"hapipal/schwifty","owner":{"login":"hapipal","id":36996446,"avatar_url":"https://avatars0.githubusercontent.com/u/36996446?v=4","gravatar_id":"","url":"https://api.github.com/users/hapipal","html_url":"https://github.com/hapipal","followers_url":"https://api.github.com/users/hapipal/followers","following_url":"https://api.github.com/users/hapipal/following{/other_user}","gists_url":"https://api.github.com/users/hapipal/gists{/gist_id}","starred_url":"https://api.github.com/users/hapipal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapipal/subscriptions","organizations_url":"https://api.github.com/users/hapipal/orgs","repos_url":"https://api.github.com/users/hapipal/repos","events_url":"https://api.github.com/users/hapipal/events{/privacy}","received_events_url":"https://api.github.com/users/hapipal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hapipal/schwifty","description":"A model layer for hapi integrating Objection ORM","fork":false,"url":"https://api.github.com/repos/hapipal/schwifty","forks_url":"https://api.github.com/repos/hapipal/schwifty/forks","keys_url":"https://api.github.com/repos/hapipal/schwifty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hapipal/schwifty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hapipal/schwifty/teams","hooks_url":"https://api.github.com/repos/hapipal/schwifty/hooks","issue_events_url":"https://api.github.com/repos/hapipal/schwifty/issues/events{/number}","events_url":"https://api.github.com/repos/hapipal/schwifty/events","assignees_url":"https://api.github.com/repos/hapipal/schwifty/assignees{/user}","branches_url":"https://api.github.com/repos/hapipal/schwifty/branches{/branch}","tags_url":"https://api.github.com/repos/hapipal/schwifty/tags","blobs_url":"https://api.github.com/repos/hapipal/schwifty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hapipal/schwifty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hapipal/schwifty/git/refs{/sha}","trees_url":"https://api.github.com/repos/hapipal/schwifty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hapipal/schwifty/statuses/{sha}","languages_url":"https://api.github.com/repos/hapipal/schwifty/languages","stargazers_url":"https://api.github.com/repos/hapipal/schwifty/stargazers","contributors_url":"https://api.github.com/repos/hapipal/schwifty/contributors","subscribers_url":"https://api.github.com/repos/hapipal/schwifty/subscribers","subscription_url":"https://api.github.com/repos/hapipal/schwifty/subscription","commits_url":"https://api.github.com/repos/hapipal/schwifty/commits{/sha}","git_commits_url":"https://api.github.com/repos/hapipal/schwifty/git/commits{/sha}","comments_url":"https://api.github.com/repos/hapipal/schwifty/comments{/number}","issue_comment_url":"https://api.github.com/repos/hapipal/schwifty/issues/comments{/number}","contents_url":"https://api.github.com/repos/hapipal/schwifty/contents/{+path}","compare_url":"https://api.github.com/repos/hapipal/schwifty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hapipal/schwifty/merges","archive_url":"https://api.github.com/repos/hapipal/schwifty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hapipal/schwifty/downloads","issues_url":"https://api.github.com/repos/hapipal/schwifty/issues{/number}","pulls_url":"https://api.github.com/repos/hapipal/schwifty/pulls{/number}","milestones_url":"https://api.github.com/repos/hapipal/schwifty/milestones{/number}","notifications_url":"https://api.github.com/repos/hapipal/schwifty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hapipal/schwifty/labels{/name}","releases_url":"https://api.github.com/repos/hapipal/schwifty/releases{/id}","deployments_url":"https://api.github.com/repos/hapipal/schwifty/deployments","created_at":"2016-12-02T19:21:18Z","updated_at":"2018-04-15T20:11:42Z","pushed_at":"2018-04-23T15:35:05Z","git_url":"git://github.com/hapipal/schwifty.git","ssh_url":"[email protected]:hapipal/schwifty.git","clone_url":"https://github.com/hapipal/schwifty.git","svn_url":"https://github.com/hapipal/schwifty","homepage":"","size":276,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":2,"watchers":32,"default_branch":"master"}},"base":{"label":"hapipal:master","ref":"master","sha":"f42ea529ec73710ae9dd020f600a14a9abc7ab35","user":{"login":"hapipal","id":36996446,"avatar_url":"https://avatars0.githubusercontent.com/u/36996446?v=4","gravatar_id":"","url":"https://api.github.com/users/hapipal","html_url":"https://github.com/hapipal","followers_url":"https://api.github.com/users/hapipal/followers","following_url":"https://api.github.com/users/hapipal/following{/other_user}","gists_url":"https://api.github.com/users/hapipal/gists{/gist_id}","starred_url":"https://api.github.com/users/hapipal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapipal/subscriptions","organizations_url":"https://api.github.com/users/hapipal/orgs","repos_url":"https://api.github.com/users/hapipal/repos","events_url":"https://api.github.com/users/hapipal/events{/privacy}","received_events_url":"https://api.github.com/users/hapipal/received_events","type":"Organization","site_admin":false},"repo":{"id":75424160,"name":"schwifty","full_name":"hapipal/schwifty","owner":{"login":"hapipal","id":36996446,"avatar_url":"https://avatars0.githubusercontent.com/u/36996446?v=4","gravatar_id":"","url":"https://api.github.com/users/hapipal","html_url":"https://github.com/hapipal","followers_url":"https://api.github.com/users/hapipal/followers","following_url":"https://api.github.com/users/hapipal/following{/other_user}","gists_url":"https://api.github.com/users/hapipal/gists{/gist_id}","starred_url":"https://api.github.com/users/hapipal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hapipal/subscriptions","organizations_url":"https://api.github.com/users/hapipal/orgs","repos_url":"https://api.github.com/users/hapipal/repos","events_url":"https://api.github.com/users/hapipal/events{/privacy}","received_events_url":"https://api.github.com/users/hapipal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hapipal/schwifty","description":"A model layer for hapi integrating Objection ORM","fork":false,"url":"https://api.github.com/repos/hapipal/schwifty","forks_url":"https://api.github.com/repos/hapipal/schwifty/forks","keys_url":"https://api.github.com/repos/hapipal/schwifty/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hapipal/schwifty/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hapipal/schwifty/teams","hooks_url":"https://api.github.com/repos/hapipal/schwifty/hooks","issue_events_url":"https://api.github.com/repos/hapipal/schwifty/issues/events{/number}","events_url":"https://api.github.com/repos/hapipal/schwifty/events","assignees_url":"https://api.github.com/repos/hapipal/schwifty/assignees{/user}","branches_url":"https://api.github.com/repos/hapipal/schwifty/branches{/branch}","tags_url":"https://api.github.com/repos/hapipal/schwifty/tags","blobs_url":"https://api.github.com/repos/hapipal/schwifty/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hapipal/schwifty/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hapipal/schwifty/git/refs{/sha}","trees_url":"https://api.github.com/repos/hapipal/schwifty/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hapipal/schwifty/statuses/{sha}","languages_url":"https://api.github.com/repos/hapipal/schwifty/languages","stargazers_url":"https://api.github.com/repos/hapipal/schwifty/stargazers","contributors_url":"https://api.github.com/repos/hapipal/schwifty/contributors","subscribers_url":"https://api.github.com/repos/hapipal/schwifty/subscribers","subscription_url":"https://api.github.com/repos/hapipal/schwifty/subscription","commits_url":"https://api.github.com/repos/hapipal/schwifty/commits{/sha}","git_commits_url":"https://api.github.com/repos/hapipal/schwifty/git/commits{/sha}","comments_url":"https://api.github.com/repos/hapipal/schwifty/comments{/number}","issue_comment_url":"https://api.github.com/repos/hapipal/schwifty/issues/comments{/number}","contents_url":"https://api.github.com/repos/hapipal/schwifty/contents/{+path}","compare_url":"https://api.github.com/repos/hapipal/schwifty/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hapipal/schwifty/merges","archive_url":"https://api.github.com/repos/hapipal/schwifty/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hapipal/schwifty/downloads","issues_url":"https://api.github.com/repos/hapipal/schwifty/issues{/number}","pulls_url":"https://api.github.com/repos/hapipal/schwifty/pulls{/number}","milestones_url":"https://api.github.com/repos/hapipal/schwifty/milestones{/number}","notifications_url":"https://api.github.com/repos/hapipal/schwifty/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hapipal/schwifty/labels{/name}","releases_url":"https://api.github.com/repos/hapipal/schwifty/releases{/id}","deployments_url":"https://api.github.com/repos/hapipal/schwifty/deployments","created_at":"2016-12-02T19:21:18Z","updated_at":"2018-04-15T20:11:42Z","pushed_at":"2018-04-23T15:35:05Z","git_url":"git://github.com/hapipal/schwifty.git","ssh_url":"[email protected]:hapipal/schwifty.git","clone_url":"https://github.com/hapipal/schwifty.git","svn_url":"https://github.com/hapipal/schwifty","homepage":"","size":276,"stargazers_count":32,"watchers_count":32,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":2,"open_issues":2,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hapipal/schwifty/pulls/56"},"html":{"href":"https://github.com/hapipal/schwifty/pull/56"},"issue":{"href":"https://api.github.com/repos/hapipal/schwifty/issues/56"},"comments":{"href":"https://api.github.com/repos/hapipal/schwifty/issues/56/comments"},"review_comments":{"href":"https://api.github.com/repos/hapipal/schwifty/pulls/56/comments"},"review_comment":{"href":"https://api.github.com/repos/hapipal/schwifty/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hapipal/schwifty/pulls/56/commits"},"statuses":{"href":"https://api.github.com/repos/hapipal/schwifty/statuses/f1ccd3eab91beaf6fc5c12f73a0e3cab400406a3"}},"author_association":"MEMBER"}}

7572693229

{"actor":{"display_login":"wswoodruff"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments/191819990","pull_request_review_id":124456770,"id":191819990,"diff_hunk":"@@ -0,0 +1,44 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Data.Entity;\n+using System.Linq;\n+using Lab06.MVC.DAL.Entities;\n+\n+namespace Lab06.MVC.DAL.Repositories\n+{\n+ public class EfGenreReporitory : IRepository<Genre>","path":"Lab06.MVC/Lab06.MVC.DAL/Repositories/EfGenreReporitory.cs","position":9,"original_position":9,"commit_id":"bd99cec9b13dbb5e9160d4a59a57c8d446920033","original_commit_id":"bd99cec9b13dbb5e9160d4a59a57c8d446920033","user":{"login":"stas-litvinenka","id":4135348,"avatar_url":"https://avatars0.githubusercontent.com/u/4135348?v=4","gravatar_id":"","url":"https://api.github.com/users/stas-litvinenka","html_url":"https://github.com/stas-litvinenka","followers_url":"https://api.github.com/users/stas-litvinenka/followers","following_url":"https://api.github.com/users/stas-litvinenka/following{/other_user}","gists_url":"https://api.github.com/users/stas-litvinenka/gists{/gist_id}","starred_url":"https://api.github.com/users/stas-litvinenka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stas-litvinenka/subscriptions","organizations_url":"https://api.github.com/users/stas-litvinenka/orgs","repos_url":"https://api.github.com/users/stas-litvinenka/repos","events_url":"https://api.github.com/users/stas-litvinenka/events{/privacy}","received_events_url":"https://api.github.com/users/stas-litvinenka/received_events","type":"User","site_admin":false},"body":"remove Ef","created_at":"2018-05-30T15:44:12Z","updated_at":"2018-05-30T15:46:30Z","html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8#discussion_r191819990","pull_request_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments/191819990"},"html":{"href":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8#discussion_r191819990"},"pull_request":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8","id":190523269,"html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8","diff_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8.diff","patch_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8.patch","issue_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/8","number":8,"state":"open","locked":false,"title":"Lab 06 Preliminary check","user":{"login":"HenadzHatsko","id":38043995,"avatar_url":"https://avatars1.githubusercontent.com/u/38043995?v=4","gravatar_id":"","url":"https://api.github.com/users/HenadzHatsko","html_url":"https://github.com/HenadzHatsko","followers_url":"https://api.github.com/users/HenadzHatsko/followers","following_url":"https://api.github.com/users/HenadzHatsko/following{/other_user}","gists_url":"https://api.github.com/users/HenadzHatsko/gists{/gist_id}","starred_url":"https://api.github.com/users/HenadzHatsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenadzHatsko/subscriptions","organizations_url":"https://api.github.com/users/HenadzHatsko/orgs","repos_url":"https://api.github.com/users/HenadzHatsko/repos","events_url":"https://api.github.com/users/HenadzHatsko/events{/privacy}","received_events_url":"https://api.github.com/users/HenadzHatsko/received_events","type":"User","site_admin":false},"body":"Please check current progress.","created_at":"2018-05-25T09:01:32Z","updated_at":"2018-05-30T15:46:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f55fef1c568aa696cf5ec5fa50773b1d2d543da7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/8/comments","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/bd99cec9b13dbb5e9160d4a59a57c8d446920033","head":{"label":"Godel-Mastery-v3:lab-06","ref":"lab-06","sha":"bd99cec9b13dbb5e9160d4a59a57c8d446920033","user":{"login":"Godel-Mastery-v3","id":37075055,"avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"repo":{"id":128057818,"name":"Henadz-Hatsko","full_name":"Godel-Mastery-v3/Henadz-Hatsko","owner":{"login":"Godel-Mastery-v3","id":37075055,"avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","description":"Henadz Hatsko","fork":false,"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko","forks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/forks","keys_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/teams","hooks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/hooks","issue_events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/events{/number}","events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/events","assignees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/assignees{/user}","branches_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/branches{/branch}","tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/tags","blobs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/refs{/sha}","trees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/{sha}","languages_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/languages","stargazers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/stargazers","contributors_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contributors","subscribers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscribers","subscription_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscription","commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/commits{/sha}","git_commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/commits{/sha}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/comments{/number}","issue_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/comments{/number}","contents_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contents/{+path}","compare_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/merges","archive_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/downloads","issues_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues{/number}","pulls_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls{/number}","milestones_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/milestones{/number}","notifications_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/labels{/name}","releases_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/releases{/id}","deployments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/deployments","created_at":"2018-04-04T12:18:14Z","updated_at":"2018-05-22T11:54:50Z","pushed_at":"2018-05-29T17:08:07Z","git_url":"git://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","ssh_url":"[email protected]:Godel-Mastery-v3/Henadz-Hatsko.git","clone_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","svn_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","homepage":null,"size":54663,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Godel-Mastery-v3:master","ref":"master","sha":"b0792e61be866ef60dd72d629ac8b092a39f00ee","user":{"login":"Godel-Mastery-v3","id":37075055,"avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"repo":{"id":128057818,"name":"Henadz-Hatsko","full_name":"Godel-Mastery-v3/Henadz-Hatsko","owner":{"login":"Godel-Mastery-v3","id":37075055,"avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","description":"Henadz Hatsko","fork":false,"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko","forks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/forks","keys_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/teams","hooks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/hooks","issue_events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/events{/number}","events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/events","assignees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/assignees{/user}","branches_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/branches{/branch}","tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/tags","blobs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/refs{/sha}","trees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/{sha}","languages_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/languages","stargazers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/stargazers","contributors_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contributors","subscribers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscribers","subscription_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscription","commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/commits{/sha}","git_commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/commits{/sha}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/comments{/number}","issue_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/comments{/number}","contents_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contents/{+path}","compare_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/merges","archive_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/downloads","issues_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues{/number}","pulls_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls{/number}","milestones_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/milestones{/number}","notifications_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/labels{/name}","releases_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/releases{/id}","deployments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/deployments","created_at":"2018-04-04T12:18:14Z","updated_at":"2018-05-22T11:54:50Z","pushed_at":"2018-05-29T17:08:07Z","git_url":"git://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","ssh_url":"[email protected]:Godel-Mastery-v3/Henadz-Hatsko.git","clone_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","svn_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","homepage":null,"size":54663,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8"},"html":{"href":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8"},"issue":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/8"},"comments":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/bd99cec9b13dbb5e9160d4a59a57c8d446920033"}},"author_association":"NONE"}}

7751006909

{"actor":{"display_login":"stas-litvinenka"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments/193371219","pull_request_review_id":126326225,"id":193371219,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzM3MTIxOQ==","diff_hunk":"@@ -0,0 +1,25 @@\n+<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<packages>","path":"Lab06.MVC/Lab06.MVC.DAL/packages.config","position":2,"original_position":2,"commit_id":"7b77767291e8930db5ef36b49e396e80a9b63199","original_commit_id":"902fd27d9415efaf71987420f84f863e3d2ce0a1","user":{"login":"HenadzHatsko","id":38043995,"node_id":"MDQ6VXNlcjM4MDQzOTk1","avatar_url":"https://avatars1.githubusercontent.com/u/38043995?v=4","gravatar_id":"","url":"https://api.github.com/users/HenadzHatsko","html_url":"https://github.com/HenadzHatsko","followers_url":"https://api.github.com/users/HenadzHatsko/followers","following_url":"https://api.github.com/users/HenadzHatsko/following{/other_user}","gists_url":"https://api.github.com/users/HenadzHatsko/gists{/gist_id}","starred_url":"https://api.github.com/users/HenadzHatsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenadzHatsko/subscriptions","organizations_url":"https://api.github.com/users/HenadzHatsko/orgs","repos_url":"https://api.github.com/users/HenadzHatsko/repos","events_url":"https://api.github.com/users/HenadzHatsko/events{/privacy}","received_events_url":"https://api.github.com/users/HenadzHatsko/received_events","type":"User","site_admin":false},"body":"removed some","created_at":"2018-06-06T11:00:48Z","updated_at":"2018-06-06T11:00:48Z","html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8#discussion_r193371219","pull_request_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments/193371219"},"html":{"href":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8#discussion_r193371219"},"pull_request":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8"}},"in_reply_to_id":192557036},"pull_request":{"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8","id":190523269,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNTIzMjY5","html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8","diff_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8.diff","patch_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8.patch","issue_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/8","number":8,"state":"open","locked":false,"title":"Lab 06 Finished main task and additional.","user":{"login":"HenadzHatsko","id":38043995,"node_id":"MDQ6VXNlcjM4MDQzOTk1","avatar_url":"https://avatars1.githubusercontent.com/u/38043995?v=4","gravatar_id":"","url":"https://api.github.com/users/HenadzHatsko","html_url":"https://github.com/HenadzHatsko","followers_url":"https://api.github.com/users/HenadzHatsko/followers","following_url":"https://api.github.com/users/HenadzHatsko/following{/other_user}","gists_url":"https://api.github.com/users/HenadzHatsko/gists{/gist_id}","starred_url":"https://api.github.com/users/HenadzHatsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenadzHatsko/subscriptions","organizations_url":"https://api.github.com/users/HenadzHatsko/orgs","repos_url":"https://api.github.com/users/HenadzHatsko/repos","events_url":"https://api.github.com/users/HenadzHatsko/events{/privacy}","received_events_url":"https://api.github.com/users/HenadzHatsko/received_events","type":"User","site_admin":false},"body":"Please check current progress.","created_at":"2018-05-25T09:01:32Z","updated_at":"2018-06-06T11:00:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9938e75f405f1c09397302e7300860cc35d3a42","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8/commits","review_comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8/comments","review_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/8/comments","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/7b77767291e8930db5ef36b49e396e80a9b63199","head":{"label":"Godel-Mastery-v3:lab-06","ref":"lab-06","sha":"7b77767291e8930db5ef36b49e396e80a9b63199","user":{"login":"Godel-Mastery-v3","id":37075055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDc1MDU1","avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"repo":{"id":128057818,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgwNTc4MTg=","name":"Henadz-Hatsko","full_name":"Godel-Mastery-v3/Henadz-Hatsko","owner":{"login":"Godel-Mastery-v3","id":37075055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDc1MDU1","avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","description":"Henadz Hatsko","fork":false,"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko","forks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/forks","keys_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/teams","hooks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/hooks","issue_events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/events{/number}","events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/events","assignees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/assignees{/user}","branches_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/branches{/branch}","tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/tags","blobs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/refs{/sha}","trees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/{sha}","languages_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/languages","stargazers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/stargazers","contributors_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contributors","subscribers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscribers","subscription_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscription","commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/commits{/sha}","git_commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/commits{/sha}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/comments{/number}","issue_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/comments{/number}","contents_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contents/{+path}","compare_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/merges","archive_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/downloads","issues_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues{/number}","pulls_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls{/number}","milestones_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/milestones{/number}","notifications_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/labels{/name}","releases_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/releases{/id}","deployments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/deployments","created_at":"2018-04-04T12:18:14Z","updated_at":"2018-05-22T11:54:50Z","pushed_at":"2018-06-06T10:48:21Z","git_url":"git://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","ssh_url":"[email protected]:Godel-Mastery-v3/Henadz-Hatsko.git","clone_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","svn_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","homepage":null,"size":56206,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Godel-Mastery-v3:master","ref":"master","sha":"b0792e61be866ef60dd72d629ac8b092a39f00ee","user":{"login":"Godel-Mastery-v3","id":37075055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDc1MDU1","avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"repo":{"id":128057818,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgwNTc4MTg=","name":"Henadz-Hatsko","full_name":"Godel-Mastery-v3/Henadz-Hatsko","owner":{"login":"Godel-Mastery-v3","id":37075055,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDc1MDU1","avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","description":"Henadz Hatsko","fork":false,"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko","forks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/forks","keys_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/teams","hooks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/hooks","issue_events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/events{/number}","events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/events","assignees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/assignees{/user}","branches_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/branches{/branch}","tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/tags","blobs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/refs{/sha}","trees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/{sha}","languages_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/languages","stargazers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/stargazers","contributors_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contributors","subscribers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscribers","subscription_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscription","commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/commits{/sha}","git_commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/commits{/sha}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/comments{/number}","issue_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/comments{/number}","contents_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contents/{+path}","compare_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/merges","archive_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/downloads","issues_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues{/number}","pulls_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls{/number}","milestones_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/milestones{/number}","notifications_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/labels{/name}","releases_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/releases{/id}","deployments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/deployments","created_at":"2018-04-04T12:18:14Z","updated_at":"2018-05-22T11:54:50Z","pushed_at":"2018-06-06T10:48:21Z","git_url":"git://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","ssh_url":"[email protected]:Godel-Mastery-v3/Henadz-Hatsko.git","clone_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","svn_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","homepage":null,"size":56206,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8"},"html":{"href":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/8"},"issue":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/8"},"comments":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/7b77767291e8930db5ef36b49e396e80a9b63199"}},"author_association":"NONE"}}

7783745069

{"actor":{"display_login":"HenadzHatsko"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments/183010315","pull_request_review_id":113906632,"id":183010315,"diff_hunk":"@@ -0,0 +1,436 @@\n+using System;\n+using System.Collections.Generic;\n+using System.Collections.ObjectModel;\n+using System.Linq;\n+using System.Text;\n+using System.Threading.Tasks;\n+using System.IO;\n+using System.Configuration;\n+using System.Net;\n+using System.Net.NetworkInformation;\n+using System.Runtime.InteropServices;\n+using System.Runtime.Serialization;\n+using System.Runtime.Serialization.Formatters.Binary;\n+using System.Xml.Serialization;\n+using Newtonsoft.Json;\n+using ExportInterface;\n+using System.Reflection;\n+\n+namespace lab_file_storage\n+{\n+ [Serializable]\n+ public class AppFile\n+ {\n+ public string Name { get; set; }\n+ public string Extension { get; set; }\n+ public long Size { get; set; }\n+ public DateTime CreationDate { get; set; }\n+ public int DownloadsNumber { get; set; }\n+ public string Login { get; set; }\n+ public string FullPath { get; set; }\n+ \n+ private static readonly string _metaFilePath = ConfigurationManager.AppSettings[\"dbFile\"];\n+ private static readonly string _metaFileName = string.Concat(_metaFilePath, \"dbFile.dat\");\n+\n+ public static void ShowPath()\n+ {\n+ Console.WriteLine(_metaFileName);\n+ }\n+\n+ public AppFile(){ }\n+\n+ public AppFile(string name, string extension, long size, DateTime creationDate, int downloadsNumber, string login, string fullPath)\n+ {\n+ Name = name;\n+ Extension = extension;\n+ Size = size;\n+ CreationDate = creationDate;\n+ DownloadsNumber = downloadsNumber;\n+ Login = User.UserName;\n+ FullPath = fullPath;\n+ }\n+\n+ public static void Serialize(Dictionary<string, AppFile> appFileDictionary)\n+ {\n+ FileStream fs = new FileStream(_metaFileName, FileMode.OpenOrCreate);\n+ BinaryFormatter formatter = new BinaryFormatter();\n+ try\n+ {\n+ ","path":"lab-file-storage/AppFile.cs","position":59,"original_position":59,"commit_id":"df661c9d165b78f7780676954c14b850027fe5eb","original_commit_id":"df661c9d165b78f7780676954c14b850027fe5eb","user":{"login":"stas-litvinenka","id":4135348,"avatar_url":"https://avatars0.githubusercontent.com/u/4135348?v=4","gravatar_id":"","url":"https://api.github.com/users/stas-litvinenka","html_url":"https://github.com/stas-litvinenka","followers_url":"https://api.github.com/users/stas-litvinenka/followers","following_url":"https://api.github.com/users/stas-litvinenka/following{/other_user}","gists_url":"https://api.github.com/users/stas-litvinenka/gists{/gist_id}","starred_url":"https://api.github.com/users/stas-litvinenka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stas-litvinenka/subscriptions","organizations_url":"https://api.github.com/users/stas-litvinenka/orgs","repos_url":"https://api.github.com/users/stas-litvinenka/repos","events_url":"https://api.github.com/users/stas-litvinenka/events{/privacy}","received_events_url":"https://api.github.com/users/stas-litvinenka/received_events","type":"User","site_admin":false},"body":"remove empty line","created_at":"2018-04-20T10:30:22Z","updated_at":"2018-04-20T10:38:44Z","html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/4#discussion_r183010315","pull_request_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments/183010315"},"html":{"href":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/4#discussion_r183010315"},"pull_request":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/4","id":182692829,"html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/4","diff_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/4.diff","patch_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/4.patch","issue_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/4","number":4,"state":"open","locked":false,"title":"Lab 02. Finish main task","user":{"login":"HenadzHatsko","id":38043995,"avatar_url":"https://avatars1.githubusercontent.com/u/38043995?v=4","gravatar_id":"","url":"https://api.github.com/users/HenadzHatsko","html_url":"https://github.com/HenadzHatsko","followers_url":"https://api.github.com/users/HenadzHatsko/followers","following_url":"https://api.github.com/users/HenadzHatsko/following{/other_user}","gists_url":"https://api.github.com/users/HenadzHatsko/gists{/gist_id}","starred_url":"https://api.github.com/users/HenadzHatsko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HenadzHatsko/subscriptions","organizations_url":"https://api.github.com/users/HenadzHatsko/orgs","repos_url":"https://api.github.com/users/HenadzHatsko/repos","events_url":"https://api.github.com/users/HenadzHatsko/events{/privacy}","received_events_url":"https://api.github.com/users/HenadzHatsko/received_events","type":"User","site_admin":false},"body":"Finished main task and 1 extra task.\r\nadded 1 plugin for xml serialization.","created_at":"2018-04-19T07:51:33Z","updated_at":"2018-04-20T10:38:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"240e0a28114d38557a16ab49c642e654dc88384c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/4/comments","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/df661c9d165b78f7780676954c14b850027fe5eb","head":{"label":"Godel-Mastery-v3:lab-02","ref":"lab-02","sha":"df661c9d165b78f7780676954c14b850027fe5eb","user":{"login":"Godel-Mastery-v3","id":37075055,"avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"repo":{"id":128057818,"name":"Henadz-Hatsko","full_name":"Godel-Mastery-v3/Henadz-Hatsko","owner":{"login":"Godel-Mastery-v3","id":37075055,"avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","description":"Henadz Hatsko","fork":false,"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko","forks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/forks","keys_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/teams","hooks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/hooks","issue_events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/events{/number}","events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/events","assignees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/assignees{/user}","branches_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/branches{/branch}","tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/tags","blobs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/refs{/sha}","trees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/{sha}","languages_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/languages","stargazers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/stargazers","contributors_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contributors","subscribers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscribers","subscription_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscription","commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/commits{/sha}","git_commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/commits{/sha}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/comments{/number}","issue_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/comments{/number}","contents_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contents/{+path}","compare_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/merges","archive_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/downloads","issues_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues{/number}","pulls_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls{/number}","milestones_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/milestones{/number}","notifications_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/labels{/name}","releases_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/releases{/id}","deployments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/deployments","created_at":"2018-04-04T12:18:14Z","updated_at":"2018-04-11T14:28:11Z","pushed_at":"2018-04-19T07:51:34Z","git_url":"git://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","ssh_url":"[email protected]:Godel-Mastery-v3/Henadz-Hatsko.git","clone_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","svn_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Godel-Mastery-v3:master","ref":"master","sha":"7b24ceda9c50283fdee7e25c5882ddfa371081bf","user":{"login":"Godel-Mastery-v3","id":37075055,"avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"repo":{"id":128057818,"name":"Henadz-Hatsko","full_name":"Godel-Mastery-v3/Henadz-Hatsko","owner":{"login":"Godel-Mastery-v3","id":37075055,"avatar_url":"https://avatars1.githubusercontent.com/u/37075055?v=4","gravatar_id":"","url":"https://api.github.com/users/Godel-Mastery-v3","html_url":"https://github.com/Godel-Mastery-v3","followers_url":"https://api.github.com/users/Godel-Mastery-v3/followers","following_url":"https://api.github.com/users/Godel-Mastery-v3/following{/other_user}","gists_url":"https://api.github.com/users/Godel-Mastery-v3/gists{/gist_id}","starred_url":"https://api.github.com/users/Godel-Mastery-v3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Godel-Mastery-v3/subscriptions","organizations_url":"https://api.github.com/users/Godel-Mastery-v3/orgs","repos_url":"https://api.github.com/users/Godel-Mastery-v3/repos","events_url":"https://api.github.com/users/Godel-Mastery-v3/events{/privacy}","received_events_url":"https://api.github.com/users/Godel-Mastery-v3/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","description":"Henadz Hatsko","fork":false,"url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko","forks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/forks","keys_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/teams","hooks_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/hooks","issue_events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/events{/number}","events_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/events","assignees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/assignees{/user}","branches_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/branches{/branch}","tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/tags","blobs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/refs{/sha}","trees_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/{sha}","languages_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/languages","stargazers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/stargazers","contributors_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contributors","subscribers_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscribers","subscription_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/subscription","commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/commits{/sha}","git_commits_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/git/commits{/sha}","comments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/comments{/number}","issue_comment_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/comments{/number}","contents_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/contents/{+path}","compare_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/merges","archive_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/downloads","issues_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues{/number}","pulls_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls{/number}","milestones_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/milestones{/number}","notifications_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/labels{/name}","releases_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/releases{/id}","deployments_url":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/deployments","created_at":"2018-04-04T12:18:14Z","updated_at":"2018-04-11T14:28:11Z","pushed_at":"2018-04-19T07:51:34Z","git_url":"git://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","ssh_url":"[email protected]:Godel-Mastery-v3/Henadz-Hatsko.git","clone_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko.git","svn_url":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko","homepage":null,"size":40,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/4"},"html":{"href":"https://github.com/Godel-Mastery-v3/Henadz-Hatsko/pull/4"},"issue":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/4"},"comments":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Godel-Mastery-v3/Henadz-Hatsko/statuses/df661c9d165b78f7780676954c14b850027fe5eb"}},"author_association":"NONE"}}

7560986543

{"actor":{"display_login":"stas-litvinenka"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/libero/php-coding-standard/pulls/comments/235716776","pull_request_review_id":177646034,"id":235716776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTcxNjc3Ng==","diff_hunk":"@@ -11,10 +11,16 @@ namespace Vendor;\n \n abstract class Foo\n {\n+ /**\n+ * @param array<string> $qux","path":"tests/cases/classes/method-type-case","position":5,"original_position":5,"commit_id":"8c589a1ea9c8ef716d924d6f55838515a2e58a43","original_commit_id":"8c589a1ea9c8ef716d924d6f55838515a2e58a43","user":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"body":"This will depend on https://github.com/slevomat/coding-standard/pull/558. (PHPStan already supports it, next version of PHPStorm will.)","created_at":"2018-11-22T12:59:26Z","updated_at":"2018-11-22T12:59:27Z","html_url":"https://github.com/libero/php-coding-standard/pull/32#discussion_r235716776","pull_request_url":"https://api.github.com/repos/libero/php-coding-standard/pulls/32","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/comments/235716776"},"html":{"href":"https://github.com/libero/php-coding-standard/pull/32#discussion_r235716776"},"pull_request":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/libero/php-coding-standard/pulls/32","id":228286050,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4Mjg2MDUw","html_url":"https://github.com/libero/php-coding-standard/pull/32","diff_url":"https://github.com/libero/php-coding-standard/pull/32.diff","patch_url":"https://github.com/libero/php-coding-standard/pull/32.patch","issue_url":"https://api.github.com/repos/libero/php-coding-standard/issues/32","number":32,"state":"open","locked":false,"title":"[WIP] Require argument and return types","user":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"body":"Not yet working, and missing dedicated tests.\r\n\r\n- Every argument must have a type (natively if possible).\r\n- Every function/method must have a type (natively if possible), or `void` if none.","created_at":"2018-11-05T09:21:59Z","updated_at":"2018-11-22T12:59:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"635487ddf2a4564aee38c6548213193adf3f32df","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"PHP Reviewers","id":2940302,"node_id":"MDQ6VGVhbTI5NDAzMDI=","slug":"php-reviewers","description":"","privacy":"closed","url":"https://api.github.com/teams/2940302","members_url":"https://api.github.com/teams/2940302/members{/member}","repositories_url":"https://api.github.com/teams/2940302/repos","permission":"pull"}],"labels":[{"id":1034376530,"node_id":"MDU6TGFiZWwxMDM0Mzc2NTMw","url":"https://api.github.com/repos/libero/php-coding-standard/labels/feature","name":"feature","color":"a2eeef","default":false}],"milestone":{"url":"https://api.github.com/repos/libero/php-coding-standard/milestones/6","html_url":"https://github.com/libero/php-coding-standard/milestone/6","labels_url":"https://api.github.com/repos/libero/php-coding-standard/milestones/6/labels","id":3823663,"node_id":"MDk6TWlsZXN0b25lMzgyMzY2Mw==","number":6,"title":"0.4.0","description":"","creator":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-11-15T08:07:15Z","updated_at":"2018-11-15T13:31:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/libero/php-coding-standard/pulls/32/commits","review_comments_url":"https://api.github.com/repos/libero/php-coding-standard/pulls/32/comments","review_comment_url":"https://api.github.com/repos/libero/php-coding-standard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/libero/php-coding-standard/issues/32/comments","statuses_url":"https://api.github.com/repos/libero/php-coding-standard/statuses/8c589a1ea9c8ef716d924d6f55838515a2e58a43","head":{"label":"thewilkybarkid:require-types","ref":"require-types","sha":"8c589a1ea9c8ef716d924d6f55838515a2e58a43","user":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"repo":{"id":146002206,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMDIyMDY=","name":"php-coding-standard","full_name":"thewilkybarkid/php-coding-standard","private":false,"owner":{"login":"thewilkybarkid","id":1784740,"node_id":"MDQ6VXNlcjE3ODQ3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1784740?v=4","gravatar_id":"","url":"https://api.github.com/users/thewilkybarkid","html_url":"https://github.com/thewilkybarkid","followers_url":"https://api.github.com/users/thewilkybarkid/followers","following_url":"https://api.github.com/users/thewilkybarkid/following{/other_user}","gists_url":"https://api.github.com/users/thewilkybarkid/gists{/gist_id}","starred_url":"https://api.github.com/users/thewilkybarkid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thewilkybarkid/subscriptions","organizations_url":"https://api.github.com/users/thewilkybarkid/orgs","repos_url":"https://api.github.com/users/thewilkybarkid/repos","events_url":"https://api.github.com/users/thewilkybarkid/events{/privacy}","received_events_url":"https://api.github.com/users/thewilkybarkid/received_events","type":"User","site_admin":false},"html_url":"https://github.com/thewilkybarkid/php-coding-standard","description":"Libero PHP coding standard","fork":true,"url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard","forks_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/forks","keys_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/teams","hooks_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/hooks","issue_events_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/issues/events{/number}","events_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/events","assignees_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/assignees{/user}","branches_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/branches{/branch}","tags_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/tags","blobs_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/languages","stargazers_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/stargazers","contributors_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/contributors","subscribers_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/subscribers","subscription_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/subscription","commits_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/contents/{+path}","compare_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/merges","archive_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/downloads","issues_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/issues{/number}","pulls_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/labels{/name}","releases_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/releases{/id}","deployments_url":"https://api.github.com/repos/thewilkybarkid/php-coding-standard/deployments","created_at":"2018-08-24T14:32:06Z","updated_at":"2018-09-24T06:36:49Z","pushed_at":"2018-11-15T13:30:59Z","git_url":"git://github.com/thewilkybarkid/php-coding-standard.git","ssh_url":"[email protected]:thewilkybarkid/php-coding-standard.git","clone_url":"https://github.com/thewilkybarkid/php-coding-standard.git","svn_url":"https://github.com/thewilkybarkid/php-coding-standard","homepage":null,"size":81,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"libero:master","ref":"master","sha":"cf6aee0efac4dcde50b9a5c3362b51c9cfb283e5","user":{"login":"libero","id":37089447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDg5NDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"repo":{"id":146001837,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMDE4Mzc=","name":"php-coding-standard","full_name":"libero/php-coding-standard","private":false,"owner":{"login":"libero","id":37089447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MDg5NDQ3","avatar_url":"https://avatars1.githubusercontent.com/u/37089447?v=4","gravatar_id":"","url":"https://api.github.com/users/libero","html_url":"https://github.com/libero","followers_url":"https://api.github.com/users/libero/followers","following_url":"https://api.github.com/users/libero/following{/other_user}","gists_url":"https://api.github.com/users/libero/gists{/gist_id}","starred_url":"https://api.github.com/users/libero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/libero/subscriptions","organizations_url":"https://api.github.com/users/libero/orgs","repos_url":"https://api.github.com/users/libero/repos","events_url":"https://api.github.com/users/libero/events{/privacy}","received_events_url":"https://api.github.com/users/libero/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/libero/php-coding-standard","description":"Libero PHP coding standard","fork":false,"url":"https://api.github.com/repos/libero/php-coding-standard","forks_url":"https://api.github.com/repos/libero/php-coding-standard/forks","keys_url":"https://api.github.com/repos/libero/php-coding-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/libero/php-coding-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/libero/php-coding-standard/teams","hooks_url":"https://api.github.com/repos/libero/php-coding-standard/hooks","issue_events_url":"https://api.github.com/repos/libero/php-coding-standard/issues/events{/number}","events_url":"https://api.github.com/repos/libero/php-coding-standard/events","assignees_url":"https://api.github.com/repos/libero/php-coding-standard/assignees{/user}","branches_url":"https://api.github.com/repos/libero/php-coding-standard/branches{/branch}","tags_url":"https://api.github.com/repos/libero/php-coding-standard/tags","blobs_url":"https://api.github.com/repos/libero/php-coding-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/libero/php-coding-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/libero/php-coding-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/libero/php-coding-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/libero/php-coding-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/libero/php-coding-standard/languages","stargazers_url":"https://api.github.com/repos/libero/php-coding-standard/stargazers","contributors_url":"https://api.github.com/repos/libero/php-coding-standard/contributors","subscribers_url":"https://api.github.com/repos/libero/php-coding-standard/subscribers","subscription_url":"https://api.github.com/repos/libero/php-coding-standard/subscription","commits_url":"https://api.github.com/repos/libero/php-coding-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/libero/php-coding-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/libero/php-coding-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/libero/php-coding-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/libero/php-coding-standard/contents/{+path}","compare_url":"https://api.github.com/repos/libero/php-coding-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/libero/php-coding-standard/merges","archive_url":"https://api.github.com/repos/libero/php-coding-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/libero/php-coding-standard/downloads","issues_url":"https://api.github.com/repos/libero/php-coding-standard/issues{/number}","pulls_url":"https://api.github.com/repos/libero/php-coding-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/libero/php-coding-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/libero/php-coding-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/libero/php-coding-standard/labels{/name}","releases_url":"https://api.github.com/repos/libero/php-coding-standard/releases{/id}","deployments_url":"https://api.github.com/repos/libero/php-coding-standard/deployments","created_at":"2018-08-24T14:29:07Z","updated_at":"2018-11-15T08:04:52Z","pushed_at":"2018-11-15T13:31:35Z","git_url":"git://github.com/libero/php-coding-standard.git","ssh_url":"[email protected]:libero/php-coding-standard.git","clone_url":"https://github.com/libero/php-coding-standard.git","svn_url":"https://github.com/libero/php-coding-standard","homepage":null,"size":66,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/32"},"html":{"href":"https://github.com/libero/php-coding-standard/pull/32"},"issue":{"href":"https://api.github.com/repos/libero/php-coding-standard/issues/32"},"comments":{"href":"https://api.github.com/repos/libero/php-coding-standard/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/libero/php-coding-standard/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/libero/php-coding-standard/statuses/8c589a1ea9c8ef716d924d6f55838515a2e58a43"}},"author_association":"MEMBER"}}

8633138065

{"actor":{"display_login":"thewilkybarkid"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/comments/235769245","pull_request_review_id":177712321,"id":235769245,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc2OTI0NQ==","diff_hunk":"@@ -0,0 +1,36 @@\n+<%--@elvariable id=\"hcaExperimentsCount\" type=\"int\"--%>\n+<%--@elvariable id=\"humanExperimentsCount\" type=\"int\"--%>\n+\n+<%@ taglib prefix=\"fmt\" uri=\"http://java.sun.com/jsp/jstl/fmt\" %>\n+<%@ page contentType=\"text/html;charset=UTF-8\" %>\n+\n+<div id=\"data\" class=\"callout\" data-equalizer-watch>\n+ <h3><span class=\"icon icon-functional\" data-icon=\"A\"></span> Data</h3>\n+ <hr>\n+\n+ <p> Single cell Expression Atlas provides access to the analysis results of\n+ <fmt:formatNumber pattern=\"#,##0\" value=\"${hcaExperimentsCount}\"/> data sets from the Human Cell Atlas\n+ and <fmt:formatNumber pattern=\"#,##0\" value=\"${humanExperimentsCount}\"/> data sets in <i>Homo sapiens</i>\n+ from other studies.\n+ </p>\n+ <p>\n+ All studies have been re-analysed using our standardised pipeline\n+ (<a href=\"https://github.com/nunofonseca/irap\">iRAP</a>). Pipelines and web services are\n+ being developed by the Gene Expression Team at EMBL-EBI, funded by the","path":"sc/src/main/webapp/WEB-INF/jsp/tiles/views/hca-landing-page/data.jsp","position":19,"original_position":19,"commit_id":"17633b4b9ac093a3ce6b453b95edbfea28f2b360","original_commit_id":"17633b4b9ac093a3ce6b453b95edbfea28f2b360","user":{"login":"alfonsomunozpomer","id":4425744,"node_id":"MDQ6VXNlcjQ0MjU3NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4425744?v=4","gravatar_id":"","url":"https://api.github.com/users/alfonsomunozpomer","html_url":"https://github.com/alfonsomunozpomer","followers_url":"https://api.github.com/users/alfonsomunozpomer/followers","following_url":"https://api.github.com/users/alfonsomunozpomer/following{/other_user}","gists_url":"https://api.github.com/users/alfonsomunozpomer/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsomunozpomer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsomunozpomer/subscriptions","organizations_url":"https://api.github.com/users/alfonsomunozpomer/orgs","repos_url":"https://api.github.com/users/alfonsomunozpomer/repos","events_url":"https://api.github.com/users/alfonsomunozpomer/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsomunozpomer/received_events","type":"User","site_admin":false},"body":"Judging from https://wellcome.ac.uk/about-us, it looks like that under the new Wellcome Trust branding “the” isn’t used:\r\n<img width=\"313\" alt=\"image\" src=\"https://user-images.githubusercontent.com/4425744/48912646-14f1bc00-ee6e-11e8-83b6-d5b58426598d.png\">\r\n","created_at":"2018-11-22T15:49:43Z","updated_at":"2018-11-22T15:50:47Z","html_url":"https://github.com/ebi-gene-expression-group/atlas/pull/209#discussion_r235769245","pull_request_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/209","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/comments/235769245"},"html":{"href":"https://github.com/ebi-gene-expression-group/atlas/pull/209#discussion_r235769245"},"pull_request":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/209","id":233017616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDE3NjE2","html_url":"https://github.com/ebi-gene-expression-group/atlas/pull/209","diff_url":"https://github.com/ebi-gene-expression-group/atlas/pull/209.diff","patch_url":"https://github.com/ebi-gene-expression-group/atlas/pull/209.patch","issue_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/209","number":209,"state":"open","locked":false,"title":"Feature #162058565 - HCA landing page improvements","user":{"login":"monicajianu","id":5923538,"node_id":"MDQ6VXNlcjU5MjM1Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/5923538?v=4","gravatar_id":"","url":"https://api.github.com/users/monicajianu","html_url":"https://github.com/monicajianu","followers_url":"https://api.github.com/users/monicajianu/followers","following_url":"https://api.github.com/users/monicajianu/following{/other_user}","gists_url":"https://api.github.com/users/monicajianu/gists{/gist_id}","starred_url":"https://api.github.com/users/monicajianu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monicajianu/subscriptions","organizations_url":"https://api.github.com/users/monicajianu/orgs","repos_url":"https://api.github.com/users/monicajianu/repos","events_url":"https://api.github.com/users/monicajianu/events{/privacy}","received_events_url":"https://api.github.com/users/monicajianu/received_events","type":"User","site_admin":false},"body":"- Created an additional base JSP which doesn't contain any EBI branding\r\n- Created special HCA footer containing EBI, Sanger and Wellcome logos\r\n- Added boxes with Tools, People and Data to the HCA landing page\r\n- Updated `atlas-homepage-cards` depedency to latest version","created_at":"2018-11-22T15:35:26Z","updated_at":"2018-11-22T15:50:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/209/commits","review_comments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/209/comments","review_comment_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/209/comments","statuses_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/statuses/17633b4b9ac093a3ce6b453b95edbfea28f2b360","head":{"label":"ebi-gene-expression-group:feature/162058565-hca-landing-page-improvements","ref":"feature/162058565-hca-landing-page-improvements","sha":"17633b4b9ac093a3ce6b453b95edbfea28f2b360","user":{"login":"ebi-gene-expression-group","id":37115756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE1NzU2","avatar_url":"https://avatars3.githubusercontent.com/u/37115756?v=4","gravatar_id":"","url":"https://api.github.com/users/ebi-gene-expression-group","html_url":"https://github.com/ebi-gene-expression-group","followers_url":"https://api.github.com/users/ebi-gene-expression-group/followers","following_url":"https://api.github.com/users/ebi-gene-expression-group/following{/other_user}","gists_url":"https://api.github.com/users/ebi-gene-expression-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-gene-expression-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-gene-expression-group/subscriptions","organizations_url":"https://api.github.com/users/ebi-gene-expression-group/orgs","repos_url":"https://api.github.com/users/ebi-gene-expression-group/repos","events_url":"https://api.github.com/users/ebi-gene-expression-group/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-gene-expression-group/received_events","type":"Organization","site_admin":false},"repo":{"id":5426219,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI2MjE5","name":"atlas","full_name":"ebi-gene-expression-group/atlas","private":false,"owner":{"login":"ebi-gene-expression-group","id":37115756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE1NzU2","avatar_url":"https://avatars3.githubusercontent.com/u/37115756?v=4","gravatar_id":"","url":"https://api.github.com/users/ebi-gene-expression-group","html_url":"https://github.com/ebi-gene-expression-group","followers_url":"https://api.github.com/users/ebi-gene-expression-group/followers","following_url":"https://api.github.com/users/ebi-gene-expression-group/following{/other_user}","gists_url":"https://api.github.com/users/ebi-gene-expression-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-gene-expression-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-gene-expression-group/subscriptions","organizations_url":"https://api.github.com/users/ebi-gene-expression-group/orgs","repos_url":"https://api.github.com/users/ebi-gene-expression-group/repos","events_url":"https://api.github.com/users/ebi-gene-expression-group/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-gene-expression-group/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ebi-gene-expression-group/atlas","description":"Expression Atlas","fork":false,"url":"https://api.github.com/repos/ebi-gene-expression-group/atlas","forks_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/forks","keys_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/teams","hooks_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/hooks","issue_events_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/events","assignees_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/tags","blobs_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/languages","stargazers_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/stargazers","contributors_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/contributors","subscribers_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/subscribers","subscription_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/subscription","commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/merges","archive_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/downloads","issues_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/labels{/name}","releases_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/deployments","created_at":"2012-08-15T13:18:18Z","updated_at":"2018-11-22T15:37:25Z","pushed_at":"2018-11-22T15:37:38Z","git_url":"git://github.com/ebi-gene-expression-group/atlas.git","ssh_url":"[email protected]:ebi-gene-expression-group/atlas.git","clone_url":"https://github.com/ebi-gene-expression-group/atlas.git","svn_url":"https://github.com/ebi-gene-expression-group/atlas","homepage":"https://www.ebi.ac.uk/gxa","size":867087,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":18,"default_branch":"dev"}},"base":{"label":"ebi-gene-expression-group:dev","ref":"dev","sha":"27bbfb2f4d928b4aa0d931bb10225d87ee869728","user":{"login":"ebi-gene-expression-group","id":37115756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE1NzU2","avatar_url":"https://avatars3.githubusercontent.com/u/37115756?v=4","gravatar_id":"","url":"https://api.github.com/users/ebi-gene-expression-group","html_url":"https://github.com/ebi-gene-expression-group","followers_url":"https://api.github.com/users/ebi-gene-expression-group/followers","following_url":"https://api.github.com/users/ebi-gene-expression-group/following{/other_user}","gists_url":"https://api.github.com/users/ebi-gene-expression-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-gene-expression-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-gene-expression-group/subscriptions","organizations_url":"https://api.github.com/users/ebi-gene-expression-group/orgs","repos_url":"https://api.github.com/users/ebi-gene-expression-group/repos","events_url":"https://api.github.com/users/ebi-gene-expression-group/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-gene-expression-group/received_events","type":"Organization","site_admin":false},"repo":{"id":5426219,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI2MjE5","name":"atlas","full_name":"ebi-gene-expression-group/atlas","private":false,"owner":{"login":"ebi-gene-expression-group","id":37115756,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTE1NzU2","avatar_url":"https://avatars3.githubusercontent.com/u/37115756?v=4","gravatar_id":"","url":"https://api.github.com/users/ebi-gene-expression-group","html_url":"https://github.com/ebi-gene-expression-group","followers_url":"https://api.github.com/users/ebi-gene-expression-group/followers","following_url":"https://api.github.com/users/ebi-gene-expression-group/following{/other_user}","gists_url":"https://api.github.com/users/ebi-gene-expression-group/gists{/gist_id}","starred_url":"https://api.github.com/users/ebi-gene-expression-group/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebi-gene-expression-group/subscriptions","organizations_url":"https://api.github.com/users/ebi-gene-expression-group/orgs","repos_url":"https://api.github.com/users/ebi-gene-expression-group/repos","events_url":"https://api.github.com/users/ebi-gene-expression-group/events{/privacy}","received_events_url":"https://api.github.com/users/ebi-gene-expression-group/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ebi-gene-expression-group/atlas","description":"Expression Atlas","fork":false,"url":"https://api.github.com/repos/ebi-gene-expression-group/atlas","forks_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/forks","keys_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/teams","hooks_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/hooks","issue_events_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/events{/number}","events_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/events","assignees_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/assignees{/user}","branches_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/branches{/branch}","tags_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/tags","blobs_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/refs{/sha}","trees_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/statuses/{sha}","languages_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/languages","stargazers_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/stargazers","contributors_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/contributors","subscribers_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/subscribers","subscription_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/subscription","commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/commits{/sha}","git_commits_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/git/commits{/sha}","comments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/comments{/number}","issue_comment_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/comments{/number}","contents_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/contents/{+path}","compare_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/merges","archive_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/downloads","issues_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues{/number}","pulls_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls{/number}","milestones_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/milestones{/number}","notifications_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/labels{/name}","releases_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/releases{/id}","deployments_url":"https://api.github.com/repos/ebi-gene-expression-group/atlas/deployments","created_at":"2012-08-15T13:18:18Z","updated_at":"2018-11-22T15:37:25Z","pushed_at":"2018-11-22T15:37:38Z","git_url":"git://github.com/ebi-gene-expression-group/atlas.git","ssh_url":"[email protected]:ebi-gene-expression-group/atlas.git","clone_url":"https://github.com/ebi-gene-expression-group/atlas.git","svn_url":"https://github.com/ebi-gene-expression-group/atlas","homepage":"https://www.ebi.ac.uk/gxa","size":867087,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":3,"watchers":18,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/209"},"html":{"href":"https://github.com/ebi-gene-expression-group/atlas/pull/209"},"issue":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/209"},"comments":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/ebi-gene-expression-group/atlas/statuses/17633b4b9ac093a3ce6b453b95edbfea28f2b360"}},"author_association":"MEMBER"}}

8634129114

{"actor":{"display_login":"alfonsomunozpomer"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/comments/236898034","pull_request_review_id":179072404,"id":236898034,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjg5ODAzNA==","diff_hunk":"@@ -1,6 +1,29 @@\n+from starfish.imagestack.imagestack import ImageStack\n \n \n-class AlgorithmBase:\n+class AlgorithmBaseType(type):\n+\n+ def __init__(cls, name, bases, namespace):\n+ super().__init__(name, bases, namespace)\n+ if len(bases) != 0:\n+ # this is _not_ AlgorithmBase. Instead, it's a subclass of AlgorithmBase.\n+ cls.run = AlgorithmBaseType.run_with_logging(cls.run)\n+\n+ @staticmethod\n+ def run_with_logging(func):\n+ def helper(*args, **kwargs):\n+ result = func(*args, **kwargs)\n+ # Spot detection returns a tuple, filtering returns an Imagestack\n+ if isinstance(result, ImageStack):\n+ # Only run on second run of function if in_place is True\n+ in_place = 'in_place' in kwargs and kwargs['in_place'] is True\n+ if not in_place:\n+ result.update_log(args[0])\n+ return result\n+ return helper\n+","path":"starfish/pipeline/algorithmbase.py","position":25,"original_position":25,"commit_id":"02004b8e730a952bb4e55cd0a7814d981862de4a","original_commit_id":"02004b8e730a952bb4e55cd0a7814d981862de4a","user":{"login":"shanaxel42","id":6810854,"node_id":"MDQ6VXNlcjY4MTA4NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6810854?v=4","gravatar_id":"","url":"https://api.github.com/users/shanaxel42","html_url":"https://github.com/shanaxel42","followers_url":"https://api.github.com/users/shanaxel42/followers","following_url":"https://api.github.com/users/shanaxel42/following{/other_user}","gists_url":"https://api.github.com/users/shanaxel42/gists{/gist_id}","starred_url":"https://api.github.com/users/shanaxel42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanaxel42/subscriptions","organizations_url":"https://api.github.com/users/shanaxel42/orgs","repos_url":"https://api.github.com/users/shanaxel42/repos","events_url":"https://api.github.com/users/shanaxel42/events{/privacy}","received_events_url":"https://api.github.com/users/shanaxel42/received_events","type":"User","site_admin":false},"body":"So right now this will only add to the Imagestack log if a pipeline component returns an Imagestack, (all filters do). But it doesn't capture spot detection. Do we care? Another idea I had was to make the log an external class from Imagestack that both filtering and detection could log too throughout a pipeline. ","created_at":"2018-11-28T00:14:33Z","updated_at":"2018-11-28T00:14:33Z","html_url":"https://github.com/spacetx/starfish/pull/813#discussion_r236898034","pull_request_url":"https://api.github.com/repos/spacetx/starfish/pulls/813","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments/236898034"},"html":{"href":"https://github.com/spacetx/starfish/pull/813#discussion_r236898034"},"pull_request":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/813"}}},"pull_request":{"url":"https://api.github.com/repos/spacetx/starfish/pulls/813","id":234105227,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MTA1MjI3","html_url":"https://github.com/spacetx/starfish/pull/813","diff_url":"https://github.com/spacetx/starfish/pull/813.diff","patch_url":"https://github.com/spacetx/starfish/pull/813.patch","issue_url":"https://api.github.com/repos/spacetx/starfish/issues/813","number":813,"state":"open","locked":false,"title":"Metaclass Logging ","user":{"login":"shanaxel42","id":6810854,"node_id":"MDQ6VXNlcjY4MTA4NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6810854?v=4","gravatar_id":"","url":"https://api.github.com/users/shanaxel42","html_url":"https://github.com/shanaxel42","followers_url":"https://api.github.com/users/shanaxel42/followers","following_url":"https://api.github.com/users/shanaxel42/following{/other_user}","gists_url":"https://api.github.com/users/shanaxel42/gists{/gist_id}","starred_url":"https://api.github.com/users/shanaxel42/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shanaxel42/subscriptions","organizations_url":"https://api.github.com/users/shanaxel42/orgs","repos_url":"https://api.github.com/users/shanaxel42/repos","events_url":"https://api.github.com/users/shanaxel42/events{/privacy}","received_events_url":"https://api.github.com/users/shanaxel42/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-28T00:11:52Z","updated_at":"2018-11-28T00:14:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"55d391986f55b3e14e16014b0882298391a3efb2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spacetx/starfish/pulls/813/commits","review_comments_url":"https://api.github.com/repos/spacetx/starfish/pulls/813/comments","review_comment_url":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spacetx/starfish/issues/813/comments","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/02004b8e730a952bb4e55cd0a7814d981862de4a","head":{"label":"spacetx:saxelrod-metaclass-logging","ref":"saxelrod-metaclass-logging","sha":"02004b8e730a952bb4e55cd0a7814d981862de4a","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","private":false,"owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetx/starfish","description":"*fish -- A standardized analysis pipeline for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2018-11-26T18:20:48Z","pushed_at":"2018-11-28T00:11:53Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"[email protected]:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"","size":69652,"stargazers_count":55,"watchers_count":55,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":130,"watchers":55,"default_branch":"master"}},"base":{"label":"spacetx:master","ref":"master","sha":"f0e206aa318933f117c77226172f8a76d0401ebe","user":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"repo":{"id":92539237,"node_id":"MDEwOlJlcG9zaXRvcnk5MjUzOTIzNw==","name":"starfish","full_name":"spacetx/starfish","private":false,"owner":{"login":"spacetx","id":37218549,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjE4NTQ5","avatar_url":"https://avatars0.githubusercontent.com/u/37218549?v=4","gravatar_id":"","url":"https://api.github.com/users/spacetx","html_url":"https://github.com/spacetx","followers_url":"https://api.github.com/users/spacetx/followers","following_url":"https://api.github.com/users/spacetx/following{/other_user}","gists_url":"https://api.github.com/users/spacetx/gists{/gist_id}","starred_url":"https://api.github.com/users/spacetx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spacetx/subscriptions","organizations_url":"https://api.github.com/users/spacetx/orgs","repos_url":"https://api.github.com/users/spacetx/repos","events_url":"https://api.github.com/users/spacetx/events{/privacy}","received_events_url":"https://api.github.com/users/spacetx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spacetx/starfish","description":"*fish -- A standardized analysis pipeline for image-based transcriptomics","fork":false,"url":"https://api.github.com/repos/spacetx/starfish","forks_url":"https://api.github.com/repos/spacetx/starfish/forks","keys_url":"https://api.github.com/repos/spacetx/starfish/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spacetx/starfish/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spacetx/starfish/teams","hooks_url":"https://api.github.com/repos/spacetx/starfish/hooks","issue_events_url":"https://api.github.com/repos/spacetx/starfish/issues/events{/number}","events_url":"https://api.github.com/repos/spacetx/starfish/events","assignees_url":"https://api.github.com/repos/spacetx/starfish/assignees{/user}","branches_url":"https://api.github.com/repos/spacetx/starfish/branches{/branch}","tags_url":"https://api.github.com/repos/spacetx/starfish/tags","blobs_url":"https://api.github.com/repos/spacetx/starfish/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spacetx/starfish/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spacetx/starfish/git/refs{/sha}","trees_url":"https://api.github.com/repos/spacetx/starfish/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spacetx/starfish/statuses/{sha}","languages_url":"https://api.github.com/repos/spacetx/starfish/languages","stargazers_url":"https://api.github.com/repos/spacetx/starfish/stargazers","contributors_url":"https://api.github.com/repos/spacetx/starfish/contributors","subscribers_url":"https://api.github.com/repos/spacetx/starfish/subscribers","subscription_url":"https://api.github.com/repos/spacetx/starfish/subscription","commits_url":"https://api.github.com/repos/spacetx/starfish/commits{/sha}","git_commits_url":"https://api.github.com/repos/spacetx/starfish/git/commits{/sha}","comments_url":"https://api.github.com/repos/spacetx/starfish/comments{/number}","issue_comment_url":"https://api.github.com/repos/spacetx/starfish/issues/comments{/number}","contents_url":"https://api.github.com/repos/spacetx/starfish/contents/{+path}","compare_url":"https://api.github.com/repos/spacetx/starfish/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spacetx/starfish/merges","archive_url":"https://api.github.com/repos/spacetx/starfish/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spacetx/starfish/downloads","issues_url":"https://api.github.com/repos/spacetx/starfish/issues{/number}","pulls_url":"https://api.github.com/repos/spacetx/starfish/pulls{/number}","milestones_url":"https://api.github.com/repos/spacetx/starfish/milestones{/number}","notifications_url":"https://api.github.com/repos/spacetx/starfish/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spacetx/starfish/labels{/name}","releases_url":"https://api.github.com/repos/spacetx/starfish/releases{/id}","deployments_url":"https://api.github.com/repos/spacetx/starfish/deployments","created_at":"2017-05-26T18:45:11Z","updated_at":"2018-11-26T18:20:48Z","pushed_at":"2018-11-28T00:11:53Z","git_url":"git://github.com/spacetx/starfish.git","ssh_url":"[email protected]:spacetx/starfish.git","clone_url":"https://github.com/spacetx/starfish.git","svn_url":"https://github.com/spacetx/starfish","homepage":"","size":69652,"stargazers_count":55,"watchers_count":55,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":130,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":23,"open_issues":130,"watchers":55,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/813"},"html":{"href":"https://github.com/spacetx/starfish/pull/813"},"issue":{"href":"https://api.github.com/repos/spacetx/starfish/issues/813"},"comments":{"href":"https://api.github.com/repos/spacetx/starfish/issues/813/comments"},"review_comments":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/813/comments"},"review_comment":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spacetx/starfish/pulls/813/commits"},"statuses":{"href":"https://api.github.com/repos/spacetx/starfish/statuses/02004b8e730a952bb4e55cd0a7814d981862de4a"}},"author_association":"COLLABORATOR"}}

8658273630

{"actor":{"display_login":"shanaxel42"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments/235784649","pull_request_review_id":177731783,"id":235784649,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc4NDY0OQ==","diff_hunk":"@@ -10312,4 +10312,16 @@ Recognized isotopes include: {2}</value>\n <data name=\"SkylineVersion_V4_2_Skyline_4_2\" xml:space=\"preserve\">\r\n <value>Skyline 4.2</value>\r\n </data>\r\n-</root>\r\n+ <data name=\"BuildPeptideSearchLibraryControl_BuildPeptideSearchLibrary_Embedded\" xml:space=\"preserve\">\r\n+ <value>Embedded</value>\r\n+ </data>\r\n+ <data name=\"BiblioSpecLiteBuilder_Could_not_find_an_external_spectrum_file_matching__0__in_the_same_directory_as_the_MaxQuant_input_file__1__\" xml:space=\"preserve\">\r\n+ <value>Could not find an external spectrum file matching '{0}' in the same directory as the MaxQuant input file '{1}', or in its parent or grandparent directory.\r\n+\r\n+If you do not have the original file, you may build the library with embedded spectra from the input file. However, fragment ions in MaxQuant embedded spectra are charge state deconvoluted, and will contain only singly charged fragment ions which may not be representative of intensities measured by a mass spectrometer.\r\n+\r","path":"pwiz_tools/Skyline/Properties/Resources.resx","position":12,"original_position":12,"commit_id":"8423a4f1cbd2ad4a02cd6765e1b4bd9acbc061bc","original_commit_id":"8423a4f1cbd2ad4a02cd6765e1b4bd9acbc061bc","user":{"login":"chambm","id":5011937,"node_id":"MDQ6VXNlcjUwMTE5Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5011937?v=4","gravatar_id":"","url":"https://api.github.com/users/chambm","html_url":"https://github.com/chambm","followers_url":"https://api.github.com/users/chambm/followers","following_url":"https://api.github.com/users/chambm/following{/other_user}","gists_url":"https://api.github.com/users/chambm/gists{/gist_id}","starred_url":"https://api.github.com/users/chambm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chambm/subscriptions","organizations_url":"https://api.github.com/users/chambm/orgs","repos_url":"https://api.github.com/users/chambm/repos","events_url":"https://api.github.com/users/chambm/events{/privacy}","received_events_url":"https://api.github.com/users/chambm/received_events","type":"User","site_admin":false},"body":"Like this?\r\n\r\n> Opening file...\r\n> File blank.sky opened.\r\n> Creating spectral library from files:\r\n> yeast-wiff-msms.txt\r\n> Could not find an external spectrum file matching 'wine yeast sampleA_2' in the same directory as the MaxQuant input file 'C:\\pwiz.git\\pwiz\\pwiz_tools\\Skyline\\bin\\x64\\Release\\CommandLineImportTest\\yeast-wiff-msms.txt', or in its parent or grandparent directory.\r\n> \r\n> If you do not have the original file, you may build the library with embedded spectra from the input file. However, fragment ions in MaxQuant embedded spectra are charge state deconvoluted, and will contain only singly charged fragment ions which may not be representative of intensities measured by a mass spectrometer.\r\n> \r\n> Use the argument --import-search-prefer-embedded-spectra to force the library build to use embedded spectra, or place the original spectrum files next to the input files (with a supported file extension: mz5, mzML, raw, wiff, d, lcd, mzXML, cms2, ms2, or mgf) and rerun.\r\n> ","created_at":"2018-11-22T16:46:22Z","updated_at":"2018-11-22T16:46:22Z","html_url":"https://github.com/ProteoWizard/pwiz/pull/333#discussion_r235784649","pull_request_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/333","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments/235784649"},"html":{"href":"https://github.com/ProteoWizard/pwiz/pull/333#discussion_r235784649"},"pull_request":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/333"}},"in_reply_to_id":235578072},"pull_request":{"url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/333","id":232817221,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODE3MjIx","html_url":"https://github.com/ProteoWizard/pwiz/pull/333","diff_url":"https://github.com/ProteoWizard/pwiz/pull/333.diff","patch_url":"https://github.com/ProteoWizard/pwiz/pull/333.patch","issue_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/333","number":333,"state":"open","locked":false,"title":"Feature/bibliospec-maxquant-external-spectra","user":{"login":"chambm","id":5011937,"node_id":"MDQ6VXNlcjUwMTE5Mzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5011937?v=4","gravatar_id":"","url":"https://api.github.com/users/chambm","html_url":"https://github.com/chambm","followers_url":"https://api.github.com/users/chambm/followers","following_url":"https://api.github.com/users/chambm/following{/other_user}","gists_url":"https://api.github.com/users/chambm/gists{/gist_id}","starred_url":"https://api.github.com/users/chambm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chambm/subscriptions","organizations_url":"https://api.github.com/users/chambm/orgs","repos_url":"https://api.github.com/users/chambm/repos","events_url":"https://api.github.com/users/chambm/events{/privacy}","received_events_url":"https://api.github.com/users/chambm/received_events","type":"User","site_admin":false},"body":"I'm not too happy with the duplication between `BiblioSpecLiteBuilder.BuildLibrary` and `BuildPeptideSearchLibraryControl.BuildPeptideSearchLibrary` but a better solution has not occurred to me outside of a significant refactoring of `BuildPeptideSearchLibraryControl.BuildPeptideSearchLibrary`.","created_at":"2018-11-21T22:51:03Z","updated_at":"2018-11-22T16:46:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"794a038e0e701c98a060b5f05d6af232a18d48a8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/333/commits","review_comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/333/comments","review_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/333/comments","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/8423a4f1cbd2ad4a02cd6765e1b4bd9acbc061bc","head":{"label":"ProteoWizard:feature/BiblioSpec-MaxQuant-external-spectra","ref":"feature/BiblioSpec-MaxQuant-external-spectra","sha":"8423a4f1cbd2ad4a02cd6765e1b4bd9acbc061bc","user":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"repo":{"id":124952577,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NTI1Nzc=","name":"pwiz","full_name":"ProteoWizard/pwiz","private":false,"owner":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProteoWizard/pwiz","description":"The ProteoWizard Library is a set of software libraries and tools for rapid development of mass spectrometry and proteomic data analysis software. ","fork":false,"url":"https://api.github.com/repos/ProteoWizard/pwiz","forks_url":"https://api.github.com/repos/ProteoWizard/pwiz/forks","keys_url":"https://api.github.com/repos/ProteoWizard/pwiz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProteoWizard/pwiz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProteoWizard/pwiz/teams","hooks_url":"https://api.github.com/repos/ProteoWizard/pwiz/hooks","issue_events_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/events{/number}","events_url":"https://api.github.com/repos/ProteoWizard/pwiz/events","assignees_url":"https://api.github.com/repos/ProteoWizard/pwiz/assignees{/user}","branches_url":"https://api.github.com/repos/ProteoWizard/pwiz/branches{/branch}","tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/tags","blobs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/{sha}","languages_url":"https://api.github.com/repos/ProteoWizard/pwiz/languages","stargazers_url":"https://api.github.com/repos/ProteoWizard/pwiz/stargazers","contributors_url":"https://api.github.com/repos/ProteoWizard/pwiz/contributors","subscribers_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscribers","subscription_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscription","commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProteoWizard/pwiz/contents/{+path}","compare_url":"https://api.github.com/repos/ProteoWizard/pwiz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProteoWizard/pwiz/merges","archive_url":"https://api.github.com/repos/ProteoWizard/pwiz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProteoWizard/pwiz/downloads","issues_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues{/number}","pulls_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls{/number}","milestones_url":"https://api.github.com/repos/ProteoWizard/pwiz/milestones{/number}","notifications_url":"https://api.github.com/repos/ProteoWizard/pwiz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProteoWizard/pwiz/labels{/name}","releases_url":"https://api.github.com/repos/ProteoWizard/pwiz/releases{/id}","deployments_url":"https://api.github.com/repos/ProteoWizard/pwiz/deployments","created_at":"2018-03-12T21:16:01Z","updated_at":"2018-11-20T17:18:44Z","pushed_at":"2018-11-22T00:06:39Z","git_url":"git://github.com/ProteoWizard/pwiz.git","ssh_url":"[email protected]:ProteoWizard/pwiz.git","clone_url":"https://github.com/ProteoWizard/pwiz.git","svn_url":"https://github.com/ProteoWizard/pwiz","homepage":"http://proteowizard.sourceforge.net/","size":2943739,"stargazers_count":34,"watchers_count":34,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":15,"watchers":34,"default_branch":"master"}},"base":{"label":"ProteoWizard:master","ref":"master","sha":"26619b941455bed62f2b09364b9e06f2a7ed9993","user":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"repo":{"id":124952577,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ5NTI1Nzc=","name":"pwiz","full_name":"ProteoWizard/pwiz","private":false,"owner":{"login":"ProteoWizard","id":37312314,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MzEyMzE0","avatar_url":"https://avatars2.githubusercontent.com/u/37312314?v=4","gravatar_id":"","url":"https://api.github.com/users/ProteoWizard","html_url":"https://github.com/ProteoWizard","followers_url":"https://api.github.com/users/ProteoWizard/followers","following_url":"https://api.github.com/users/ProteoWizard/following{/other_user}","gists_url":"https://api.github.com/users/ProteoWizard/gists{/gist_id}","starred_url":"https://api.github.com/users/ProteoWizard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProteoWizard/subscriptions","organizations_url":"https://api.github.com/users/ProteoWizard/orgs","repos_url":"https://api.github.com/users/ProteoWizard/repos","events_url":"https://api.github.com/users/ProteoWizard/events{/privacy}","received_events_url":"https://api.github.com/users/ProteoWizard/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProteoWizard/pwiz","description":"The ProteoWizard Library is a set of software libraries and tools for rapid development of mass spectrometry and proteomic data analysis software. ","fork":false,"url":"https://api.github.com/repos/ProteoWizard/pwiz","forks_url":"https://api.github.com/repos/ProteoWizard/pwiz/forks","keys_url":"https://api.github.com/repos/ProteoWizard/pwiz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProteoWizard/pwiz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProteoWizard/pwiz/teams","hooks_url":"https://api.github.com/repos/ProteoWizard/pwiz/hooks","issue_events_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/events{/number}","events_url":"https://api.github.com/repos/ProteoWizard/pwiz/events","assignees_url":"https://api.github.com/repos/ProteoWizard/pwiz/assignees{/user}","branches_url":"https://api.github.com/repos/ProteoWizard/pwiz/branches{/branch}","tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/tags","blobs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/{sha}","languages_url":"https://api.github.com/repos/ProteoWizard/pwiz/languages","stargazers_url":"https://api.github.com/repos/ProteoWizard/pwiz/stargazers","contributors_url":"https://api.github.com/repos/ProteoWizard/pwiz/contributors","subscribers_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscribers","subscription_url":"https://api.github.com/repos/ProteoWizard/pwiz/subscription","commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProteoWizard/pwiz/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProteoWizard/pwiz/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProteoWizard/pwiz/contents/{+path}","compare_url":"https://api.github.com/repos/ProteoWizard/pwiz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProteoWizard/pwiz/merges","archive_url":"https://api.github.com/repos/ProteoWizard/pwiz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProteoWizard/pwiz/downloads","issues_url":"https://api.github.com/repos/ProteoWizard/pwiz/issues{/number}","pulls_url":"https://api.github.com/repos/ProteoWizard/pwiz/pulls{/number}","milestones_url":"https://api.github.com/repos/ProteoWizard/pwiz/milestones{/number}","notifications_url":"https://api.github.com/repos/ProteoWizard/pwiz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProteoWizard/pwiz/labels{/name}","releases_url":"https://api.github.com/repos/ProteoWizard/pwiz/releases{/id}","deployments_url":"https://api.github.com/repos/ProteoWizard/pwiz/deployments","created_at":"2018-03-12T21:16:01Z","updated_at":"2018-11-20T17:18:44Z","pushed_at":"2018-11-22T00:06:39Z","git_url":"git://github.com/ProteoWizard/pwiz.git","ssh_url":"[email protected]:ProteoWizard/pwiz.git","clone_url":"https://github.com/ProteoWizard/pwiz.git","svn_url":"https://github.com/ProteoWizard/pwiz","homepage":"http://proteowizard.sourceforge.net/","size":2943739,"stargazers_count":34,"watchers_count":34,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":15,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/333"},"html":{"href":"https://github.com/ProteoWizard/pwiz/pull/333"},"issue":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/issues/333"},"comments":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/issues/333/comments"},"review_comments":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/333/comments"},"review_comment":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/pulls/333/commits"},"statuses":{"href":"https://api.github.com/repos/ProteoWizard/pwiz/statuses/8423a4f1cbd2ad4a02cd6765e1b4bd9acbc061bc"}},"author_association":"MEMBER"}}

8634418878

{"actor":{"display_login":"chambm"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/comments/211068462","pull_request_review_id":147423241,"id":211068462,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTA2ODQ2Mg==","diff_hunk":"@@ -0,0 +1,21 @@\n+import React from 'react';\n+import styled from 'styled-components';\n+\n+const Icon = styled.img`\n+ width: ${props => (props.width ? props.width : null)};\n+ height: ${props => (props.height ? props.height : null)};\n+`;\n+\n+const IconButton = props => {\n+ return (\n+ <Icon\n+ width={props.width}\n+ height={props.height}\n+ src={props.src}\n+ alt={props.alt}\n+ {...props}","path":"src/components/IconButton/index.jsx","position":16,"original_position":16,"commit_id":"7d893ef979c5f247e715b5923a888c444982645a","original_commit_id":"7d893ef979c5f247e715b5923a888c444982645a","user":{"login":"tomaszferens","id":17815179,"node_id":"MDQ6VXNlcjE3ODE1MTc5","avatar_url":"https://avatars2.githubusercontent.com/u/17815179?v=4","gravatar_id":"","url":"https://api.github.com/users/tomaszferens","html_url":"https://github.com/tomaszferens","followers_url":"https://api.github.com/users/tomaszferens/followers","following_url":"https://api.github.com/users/tomaszferens/following{/other_user}","gists_url":"https://api.github.com/users/tomaszferens/gists{/gist_id}","starred_url":"https://api.github.com/users/tomaszferens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomaszferens/subscriptions","organizations_url":"https://api.github.com/users/tomaszferens/orgs","repos_url":"https://api.github.com/users/tomaszferens/repos","events_url":"https://api.github.com/users/tomaszferens/events{/privacy}","received_events_url":"https://api.github.com/users/tomaszferens/received_events","type":"User","site_admin":false},"body":"hmmm, isn't `{...props}` enough?","created_at":"2018-08-18T07:58:16Z","updated_at":"2018-08-18T07:58:16Z","html_url":"https://github.com/code-pride/DailyAdvisor-PWA/pull/6#discussion_r211068462","pull_request_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/6","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/comments/211068462"},"html":{"href":"https://github.com/code-pride/DailyAdvisor-PWA/pull/6#discussion_r211068462"},"pull_request":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/6"}}},"pull_request":{"url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/6","id":208686750,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4Njg2NzUw","html_url":"https://github.com/code-pride/DailyAdvisor-PWA/pull/6","diff_url":"https://github.com/code-pride/DailyAdvisor-PWA/pull/6.diff","patch_url":"https://github.com/code-pride/DailyAdvisor-PWA/pull/6.patch","issue_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues/6","number":6,"state":"open","locked":false,"title":"Task [374] Main view of user profile","user":{"login":"marckraw","id":8228270,"node_id":"MDQ6VXNlcjgyMjgyNzA=","avatar_url":"https://avatars1.githubusercontent.com/u/8228270?v=4","gravatar_id":"","url":"https://api.github.com/users/marckraw","html_url":"https://github.com/marckraw","followers_url":"https://api.github.com/users/marckraw/followers","following_url":"https://api.github.com/users/marckraw/following{/other_user}","gists_url":"https://api.github.com/users/marckraw/gists{/gist_id}","starred_url":"https://api.github.com/users/marckraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marckraw/subscriptions","organizations_url":"https://api.github.com/users/marckraw/orgs","repos_url":"https://api.github.com/users/marckraw/repos","events_url":"https://api.github.com/users/marckraw/events{/privacy}","received_events_url":"https://api.github.com/users/marckraw/received_events","type":"User","site_admin":false},"body":"There are lot of components there which will be nice to have in other branches ;) so let's merge it ;)","created_at":"2018-08-15T21:28:34Z","updated_at":"2018-08-18T07:58:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bfbce957412495cb5f3155d3ff01126798b5bb83","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/6/commits","review_comments_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/6/comments","review_comment_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues/6/comments","statuses_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/statuses/7d893ef979c5f247e715b5923a888c444982645a","head":{"label":"code-pride:task-374-main-view-of-user-profile","ref":"task-374-main-view-of-user-profile","sha":"7d893ef979c5f247e715b5923a888c444982645a","user":{"login":"code-pride","id":37473955,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NDczOTU1","avatar_url":"https://avatars3.githubusercontent.com/u/37473955?v=4","gravatar_id":"","url":"https://api.github.com/users/code-pride","html_url":"https://github.com/code-pride","followers_url":"https://api.github.com/users/code-pride/followers","following_url":"https://api.github.com/users/code-pride/following{/other_user}","gists_url":"https://api.github.com/users/code-pride/gists{/gist_id}","starred_url":"https://api.github.com/users/code-pride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-pride/subscriptions","organizations_url":"https://api.github.com/users/code-pride/orgs","repos_url":"https://api.github.com/users/code-pride/repos","events_url":"https://api.github.com/users/code-pride/events{/privacy}","received_events_url":"https://api.github.com/users/code-pride/received_events","type":"Organization","site_admin":false},"repo":{"id":142268680,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyNjg2ODA=","name":"DailyAdvisor-PWA","full_name":"code-pride/DailyAdvisor-PWA","owner":{"login":"code-pride","id":37473955,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NDczOTU1","avatar_url":"https://avatars3.githubusercontent.com/u/37473955?v=4","gravatar_id":"","url":"https://api.github.com/users/code-pride","html_url":"https://github.com/code-pride","followers_url":"https://api.github.com/users/code-pride/followers","following_url":"https://api.github.com/users/code-pride/following{/other_user}","gists_url":"https://api.github.com/users/code-pride/gists{/gist_id}","starred_url":"https://api.github.com/users/code-pride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-pride/subscriptions","organizations_url":"https://api.github.com/users/code-pride/orgs","repos_url":"https://api.github.com/users/code-pride/repos","events_url":"https://api.github.com/users/code-pride/events{/privacy}","received_events_url":"https://api.github.com/users/code-pride/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-pride/DailyAdvisor-PWA","description":null,"fork":false,"url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA","forks_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/forks","keys_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/teams","hooks_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/hooks","issue_events_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues/events{/number}","events_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/events","assignees_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/assignees{/user}","branches_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/branches{/branch}","tags_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/tags","blobs_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/statuses/{sha}","languages_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/languages","stargazers_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/stargazers","contributors_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/contributors","subscribers_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/subscribers","subscription_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/subscription","commits_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/contents/{+path}","compare_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/merges","archive_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/downloads","issues_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues{/number}","pulls_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls{/number}","milestones_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/milestones{/number}","notifications_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/labels{/name}","releases_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/releases{/id}","deployments_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/deployments","created_at":"2018-07-25T08:10:10Z","updated_at":"2018-08-15T19:39:27Z","pushed_at":"2018-08-15T21:32:16Z","git_url":"git://github.com/code-pride/DailyAdvisor-PWA.git","ssh_url":"[email protected]:code-pride/DailyAdvisor-PWA.git","clone_url":"https://github.com/code-pride/DailyAdvisor-PWA.git","svn_url":"https://github.com/code-pride/DailyAdvisor-PWA","homepage":null,"size":5283,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"code-pride:develop","ref":"develop","sha":"dd5cf7ea1c2af5400af485302e7070a32502334c","user":{"login":"code-pride","id":37473955,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NDczOTU1","avatar_url":"https://avatars3.githubusercontent.com/u/37473955?v=4","gravatar_id":"","url":"https://api.github.com/users/code-pride","html_url":"https://github.com/code-pride","followers_url":"https://api.github.com/users/code-pride/followers","following_url":"https://api.github.com/users/code-pride/following{/other_user}","gists_url":"https://api.github.com/users/code-pride/gists{/gist_id}","starred_url":"https://api.github.com/users/code-pride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-pride/subscriptions","organizations_url":"https://api.github.com/users/code-pride/orgs","repos_url":"https://api.github.com/users/code-pride/repos","events_url":"https://api.github.com/users/code-pride/events{/privacy}","received_events_url":"https://api.github.com/users/code-pride/received_events","type":"Organization","site_admin":false},"repo":{"id":142268680,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIyNjg2ODA=","name":"DailyAdvisor-PWA","full_name":"code-pride/DailyAdvisor-PWA","owner":{"login":"code-pride","id":37473955,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NDczOTU1","avatar_url":"https://avatars3.githubusercontent.com/u/37473955?v=4","gravatar_id":"","url":"https://api.github.com/users/code-pride","html_url":"https://github.com/code-pride","followers_url":"https://api.github.com/users/code-pride/followers","following_url":"https://api.github.com/users/code-pride/following{/other_user}","gists_url":"https://api.github.com/users/code-pride/gists{/gist_id}","starred_url":"https://api.github.com/users/code-pride/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-pride/subscriptions","organizations_url":"https://api.github.com/users/code-pride/orgs","repos_url":"https://api.github.com/users/code-pride/repos","events_url":"https://api.github.com/users/code-pride/events{/privacy}","received_events_url":"https://api.github.com/users/code-pride/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/code-pride/DailyAdvisor-PWA","description":null,"fork":false,"url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA","forks_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/forks","keys_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/teams","hooks_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/hooks","issue_events_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues/events{/number}","events_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/events","assignees_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/assignees{/user}","branches_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/branches{/branch}","tags_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/tags","blobs_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/statuses/{sha}","languages_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/languages","stargazers_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/stargazers","contributors_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/contributors","subscribers_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/subscribers","subscription_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/subscription","commits_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/contents/{+path}","compare_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/merges","archive_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/downloads","issues_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues{/number}","pulls_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls{/number}","milestones_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/milestones{/number}","notifications_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/labels{/name}","releases_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/releases{/id}","deployments_url":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/deployments","created_at":"2018-07-25T08:10:10Z","updated_at":"2018-08-15T19:39:27Z","pushed_at":"2018-08-15T21:32:16Z","git_url":"git://github.com/code-pride/DailyAdvisor-PWA.git","ssh_url":"[email protected]:code-pride/DailyAdvisor-PWA.git","clone_url":"https://github.com/code-pride/DailyAdvisor-PWA.git","svn_url":"https://github.com/code-pride/DailyAdvisor-PWA","homepage":null,"size":5283,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/6"},"html":{"href":"https://github.com/code-pride/DailyAdvisor-PWA/pull/6"},"issue":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues/6"},"comments":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/issues/6/comments"},"review_comments":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/6/comments"},"review_comment":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/pulls/6/commits"},"statuses":{"href":"https://api.github.com/repos/code-pride/DailyAdvisor-PWA/statuses/7d893ef979c5f247e715b5923a888c444982645a"}},"author_association":"CONTRIBUTOR"}}

8132160980

{"actor":{"display_login":"tomaszferens"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/comments/236528322","pull_request_review_id":178619827,"id":236528322,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjUyODMyMg==","diff_hunk":"@@ -0,0 +1,105 @@\n+import stringHash from 'string-hash';\n+import store from 'store';\n+\n+export function cacheController(meta) {\n+ return function (...args) {\n+ return new Promise(async (accept, reject) => {\n+ const blockNumber = await store.dispatch('Cache/getBlockNumber');\n+\n+ let hash;\n+\n+ switch (meta.typeCache) {\n+ case 'permanent':\n+ hash = stringHash(meta.address + meta.method + args.toString());\n+ break;\n+\n+ default:\n+ hash = stringHash(meta.address + meta.method + args.toString() + blockNumber);\n+ break;\n+ }\n+\n+ const callback = function (error, result) {\n+ if (error != null) {\n+ reject(error);\n+ } else {\n+ store.dispatch('Cache/set', {meta, hash, result, blockNumber, args: {...args}});\n+ accept(result);\n+ }\n+ };\n+\n+ const functCache = (data) => accept(data.result);\n+\n+ const cacheData = await store.dispatch('Cache/get');\n+\n+ return cacheData ? functCache(cacheData) : meta.funct(...args, callback);\n+ });\n+ };\n+}\n+\n+export function getCacheType(version, name, method) {\n+ const cacheMap = getCacheMap();\n+ for (let type in cacheMap) {\n+ const versions = cacheMap[type];\n+ const contracts = versions ? versions[version] : false;\n+ const methods = contracts ? contracts[name] : false;\n+\n+ if (methods && methods.find(item => item === method)) {\n+ return type;\n+ }\n+ }\n+ return false;\n+}\n+\n+export function getCacheMap() {\n+ return {\n+ /* Permanent caching */\n+ permanent: {\n+ \"0.20.5\": {\n+ DetailedERC20: ['name', 'symbol', 'decimals'],\n+ IW12Crowdsale: ['getWToken'],\n+ WToken: ['name', 'symbol', 'decimals', 'owner'],\n+ W12Lister: ['version', 'exchanger', 'serviceWallet', 'owner', 'factory', 'getTokenCrowdsale',\n+ 'getExchanger'],\n+ W12TokenLedger: ['getWTokenByToken', 'getTokenByWToken', 'owner', 'version'],\n+ W12FundFactory: ['version'],\n+ W12CrowdsaleFactory: ['version'],\n+ W12AtomicSwap: ['owner', 'version', 'ledger'],\n+ TokenExchanger: ['getTokenByWToken', 'getWTokenByToken', 'owner', 'version'],\n+ W12Crowdsale: ['originToken', 'WTokenSaleFeePercent', 'version', 'serviceWallet',\n+ 'swap', 'serviceFee', 'owner', 'price', 'fund', 'token', 'getWToken', 'getFund'],\n+ W12Fund: ['wToken', 'totalTranchePercentReleased', 'tokenDecimals', 'version', 'serviceWallet',\n+ 'swap', 'owner', 'crowdsale', 'trancheFeePercent'],\n+ },\n+ \"0.21.3\": {\n+ DetailedERC20: ['name', 'symbol', 'decimals'],\n+ IW12Crowdsale: ['getWToken'],\n+ WToken: ['name', 'symbol', 'decimals', 'owner'],\n+ W12Lister: ['version', 'exchanger', 'serviceWallet', 'owner', 'factory', 'getTokenCrowdsale',\n+ 'getExchanger'],\n+ W12TokenLedger: ['getWTokenByToken', 'getTokenByWToken', 'owner', 'version'],\n+ W12FundFactory: ['version'],\n+ W12CrowdsaleFactory: ['version'],\n+ W12AtomicSwap: ['owner', 'version', 'ledger'],\n+ W12Crowdsale: ['originToken', 'WTokenSaleFeePercent', 'version', 'serviceWallet', 'swap',\n+ 'serviceFee', 'owner', 'price', 'fund', 'token', 'getWToken', 'getFund'],\n+ W12Fund: ['wToken', 'totalTranchePercentReleased', 'tokenDecimals', 'version', 'serviceWallet',\n+ 'swap', 'owner', 'crowdsale', 'trancheFeePercent'],\n+ },\n+ \"0.23.2\": {\n+ DetailedERC20: ['name', 'symbol', 'decimals'],\n+ IW12Crowdsale: ['getWToken'],\n+ WToken: ['name', 'symbol', 'decimals', 'owner'],\n+ W12Lister: ['version', 'exchanger', 'serviceWallet', 'owner', 'factory', 'getTokenCrowdsale',\n+ 'getExchanger'],\n+ W12TokenLedger: ['getWTokenByToken', 'getTokenByWToken', 'owner', 'version'],\n+ W12FundFactory: ['version'],\n+ W12CrowdsaleFactory: ['version'],\n+ W12AtomicSwap: ['owner', 'version', 'ledger'],\n+ W12Crowdsale: ['originToken', 'WTokenSaleFeePercent', 'version', 'serviceWallet',","path":"src/lib/Blockchain/Cache.js","position":98,"original_position":98,"commit_id":"fd51a451b511e82742bf85236352b9b8cd5f2626","original_commit_id":"fd51a451b511e82742bf85236352b9b8cd5f2626","user":{"login":"Semapl3","id":5088596,"node_id":"MDQ6VXNlcjUwODg1OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5088596?v=4","gravatar_id":"","url":"https://api.github.com/users/Semapl3","html_url":"https://github.com/Semapl3","followers_url":"https://api.github.com/users/Semapl3/followers","following_url":"https://api.github.com/users/Semapl3/following{/other_user}","gists_url":"https://api.github.com/users/Semapl3/gists{/gist_id}","starred_url":"https://api.github.com/users/Semapl3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semapl3/subscriptions","organizations_url":"https://api.github.com/users/Semapl3/orgs","repos_url":"https://api.github.com/users/Semapl3/repos","events_url":"https://api.github.com/users/Semapl3/events{/privacy}","received_events_url":"https://api.github.com/users/Semapl3/received_events","type":"User","site_admin":false},"body":"ок","created_at":"2018-11-27T05:56:22Z","updated_at":"2018-11-27T05:56:22Z","html_url":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces/pull/93#discussion_r236528322","pull_request_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/93","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/comments/236528322"},"html":{"href":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces/pull/93#discussion_r236528322"},"pull_request":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/93"}},"in_reply_to_id":236461634},"pull_request":{"url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/93","id":233673812,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjczODEy","html_url":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces/pull/93","diff_url":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces/pull/93.diff","patch_url":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces/pull/93.patch","issue_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/issues/93","number":93,"state":"open","locked":false,"title":"feat: [W12-187] Cache WIP","user":{"login":"Semapl3","id":5088596,"node_id":"MDQ6VXNlcjUwODg1OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5088596?v=4","gravatar_id":"","url":"https://api.github.com/users/Semapl3","html_url":"https://github.com/Semapl3","followers_url":"https://api.github.com/users/Semapl3/followers","following_url":"https://api.github.com/users/Semapl3/following{/other_user}","gists_url":"https://api.github.com/users/Semapl3/gists{/gist_id}","starred_url":"https://api.github.com/users/Semapl3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semapl3/subscriptions","organizations_url":"https://api.github.com/users/Semapl3/orgs","repos_url":"https://api.github.com/users/Semapl3/repos","events_url":"https://api.github.com/users/Semapl3/events{/privacy}","received_events_url":"https://api.github.com/users/Semapl3/received_events","type":"User","site_admin":false},"body":"/src/lib/Blockchain/Cache.js\r\n\r\nУказанные в функции getCacheMap названия методов с типом permanent будут кешироваться постоянно до момента их ручного удаления либо до обновления версии в package.json\r\n\r\nВерсия -> Название контракта -> Массив имен методов\r\n```\r\n\"0.20.5\": {\r\n WToken: ['name', 'symbol', 'decimals', 'owner'],\r\n},\r\n```\r\nОстальные методы имеющие в abi type === function и constant === true будут кешироваться по номеру последнего блока в сети.","created_at":"2018-11-26T19:41:27Z","updated_at":"2018-11-27T05:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef2061b894ba65db70b23b582b307597a9e14277","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/93/commits","review_comments_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/93/comments","review_comment_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/issues/93/comments","statuses_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/statuses/fd51a451b511e82742bf85236352b9b8cd5f2626","head":{"label":"Semapl3:stage","ref":"stage","sha":"fd51a451b511e82742bf85236352b9b8cd5f2626","user":{"login":"Semapl3","id":5088596,"node_id":"MDQ6VXNlcjUwODg1OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5088596?v=4","gravatar_id":"","url":"https://api.github.com/users/Semapl3","html_url":"https://github.com/Semapl3","followers_url":"https://api.github.com/users/Semapl3/followers","following_url":"https://api.github.com/users/Semapl3/following{/other_user}","gists_url":"https://api.github.com/users/Semapl3/gists{/gist_id}","starred_url":"https://api.github.com/users/Semapl3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semapl3/subscriptions","organizations_url":"https://api.github.com/users/Semapl3/orgs","repos_url":"https://api.github.com/users/Semapl3/repos","events_url":"https://api.github.com/users/Semapl3/events{/privacy}","received_events_url":"https://api.github.com/users/Semapl3/received_events","type":"User","site_admin":false},"repo":{"id":158821497,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg4MjE0OTc=","name":"W12-Product-Blockchain-User-Interfaces","full_name":"Semapl3/W12-Product-Blockchain-User-Interfaces","private":false,"owner":{"login":"Semapl3","id":5088596,"node_id":"MDQ6VXNlcjUwODg1OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5088596?v=4","gravatar_id":"","url":"https://api.github.com/users/Semapl3","html_url":"https://github.com/Semapl3","followers_url":"https://api.github.com/users/Semapl3/followers","following_url":"https://api.github.com/users/Semapl3/following{/other_user}","gists_url":"https://api.github.com/users/Semapl3/gists{/gist_id}","starred_url":"https://api.github.com/users/Semapl3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Semapl3/subscriptions","organizations_url":"https://api.github.com/users/Semapl3/orgs","repos_url":"https://api.github.com/users/Semapl3/repos","events_url":"https://api.github.com/users/Semapl3/events{/privacy}","received_events_url":"https://api.github.com/users/Semapl3/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Semapl3/W12-Product-Blockchain-User-Interfaces","description":"The W12 protocol is designed to be easily integrated into any existing business, platform or organization. In addition, W12 provides a token sale platform, through which projects can sell their tokens and easily launch fundraising campaigns based on the W12 protocol.","fork":true,"url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces","forks_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/forks","keys_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/teams","hooks_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/hooks","issue_events_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/issues/events{/number}","events_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/events","assignees_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/assignees{/user}","branches_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/branches{/branch}","tags_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/tags","blobs_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/statuses/{sha}","languages_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/languages","stargazers_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/stargazers","contributors_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/contributors","subscribers_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/subscribers","subscription_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/subscription","commits_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/contents/{+path}","compare_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/merges","archive_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/downloads","issues_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/issues{/number}","pulls_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/pulls{/number}","milestones_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/milestones{/number}","notifications_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/labels{/name}","releases_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/releases{/id}","deployments_url":"https://api.github.com/repos/Semapl3/W12-Product-Blockchain-User-Interfaces/deployments","created_at":"2018-11-23T11:07:32Z","updated_at":"2018-11-23T11:32:03Z","pushed_at":"2018-11-26T19:30:24Z","git_url":"git://github.com/Semapl3/W12-Product-Blockchain-User-Interfaces.git","ssh_url":"[email protected]:Semapl3/W12-Product-Blockchain-User-Interfaces.git","clone_url":"https://github.com/Semapl3/W12-Product-Blockchain-User-Interfaces.git","svn_url":"https://github.com/Semapl3/W12-Product-Blockchain-User-Interfaces","homepage":"","size":18133,"stargazers_count":0,"watchers_count":0,"language":"Vue","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"w12-platform:stage","ref":"stage","sha":"85c49b6e33a77a8597c6d00fdf4075d7ff741c1e","user":{"login":"w12-platform","id":37643624,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjQzNjI0","avatar_url":"https://avatars2.githubusercontent.com/u/37643624?v=4","gravatar_id":"","url":"https://api.github.com/users/w12-platform","html_url":"https://github.com/w12-platform","followers_url":"https://api.github.com/users/w12-platform/followers","following_url":"https://api.github.com/users/w12-platform/following{/other_user}","gists_url":"https://api.github.com/users/w12-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/w12-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w12-platform/subscriptions","organizations_url":"https://api.github.com/users/w12-platform/orgs","repos_url":"https://api.github.com/users/w12-platform/repos","events_url":"https://api.github.com/users/w12-platform/events{/privacy}","received_events_url":"https://api.github.com/users/w12-platform/received_events","type":"Organization","site_admin":false},"repo":{"id":146868866,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4Njg4NjY=","name":"W12-Product-Blockchain-User-Interfaces","full_name":"w12-platform/W12-Product-Blockchain-User-Interfaces","private":false,"owner":{"login":"w12-platform","id":37643624,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjQzNjI0","avatar_url":"https://avatars2.githubusercontent.com/u/37643624?v=4","gravatar_id":"","url":"https://api.github.com/users/w12-platform","html_url":"https://github.com/w12-platform","followers_url":"https://api.github.com/users/w12-platform/followers","following_url":"https://api.github.com/users/w12-platform/following{/other_user}","gists_url":"https://api.github.com/users/w12-platform/gists{/gist_id}","starred_url":"https://api.github.com/users/w12-platform/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w12-platform/subscriptions","organizations_url":"https://api.github.com/users/w12-platform/orgs","repos_url":"https://api.github.com/users/w12-platform/repos","events_url":"https://api.github.com/users/w12-platform/events{/privacy}","received_events_url":"https://api.github.com/users/w12-platform/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces","description":"The W12 protocol is designed to be easily integrated into any existing business, platform or organization. In addition, W12 provides a token sale platform, through which projects can sell their tokens and easily launch fundraising campaigns based on the W12 protocol.","fork":false,"url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces","forks_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/forks","keys_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/teams","hooks_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/hooks","issue_events_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/issues/events{/number}","events_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/events","assignees_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/assignees{/user}","branches_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/branches{/branch}","tags_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/tags","blobs_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/git/refs{/sha}","trees_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/statuses/{sha}","languages_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/languages","stargazers_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/stargazers","contributors_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/contributors","subscribers_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/subscribers","subscription_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/subscription","commits_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/commits{/sha}","git_commits_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/git/commits{/sha}","comments_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/comments{/number}","issue_comment_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/issues/comments{/number}","contents_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/contents/{+path}","compare_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/merges","archive_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/downloads","issues_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/issues{/number}","pulls_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls{/number}","milestones_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/milestones{/number}","notifications_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/labels{/name}","releases_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/releases{/id}","deployments_url":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/deployments","created_at":"2018-08-31T09:10:26Z","updated_at":"2018-11-26T20:03:57Z","pushed_at":"2018-11-26T20:03:54Z","git_url":"git://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces.git","ssh_url":"[email protected]:w12-platform/W12-Product-Blockchain-User-Interfaces.git","clone_url":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces.git","svn_url":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces","homepage":"","size":18146,"stargazers_count":2,"watchers_count":2,"language":"Vue","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":4,"open_issues":1,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/93"},"html":{"href":"https://github.com/w12-platform/W12-Product-Blockchain-User-Interfaces/pull/93"},"issue":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/issues/93"},"comments":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/issues/93/comments"},"review_comments":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/93/comments"},"review_comment":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/pulls/93/commits"},"statuses":{"href":"https://api.github.com/repos/w12-platform/W12-Product-Blockchain-User-Interfaces/statuses/fd51a451b511e82742bf85236352b9b8cd5f2626"}},"author_association":"CONTRIBUTOR"}}

8651941820

{"actor":{"display_login":"Semapl3"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/esac-ic/esac.nl/pulls/comments/238284887","pull_request_review_id":180784866,"id":238284887,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODI4NDg4Nw==","diff_hunk":"@@ -27,8 +27,9 @@ class RepositorieFactory{\n public static $APPLICATIONFORMROWREPOKEY = \"ApplicationFormRow\";\n public static $ZEKERINGENREPOKEY = \"Zekeringen\";\n public static $INSCHRIJVENREPOKEY = \"InschrijvenRepository\";\n- public static $BOOKREPOKEY = \"BookRepository\";","path":"app/repositories/RepositorieFactory.php","position":4,"original_position":4,"commit_id":"2719efa6c8622a84c43801e7f17c1aa17c3deda8","original_commit_id":"2719efa6c8622a84c43801e7f17c1aa17c3deda8","user":{"login":"wouterbles","id":7345910,"node_id":"MDQ6VXNlcjczNDU5MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7345910?v=4","gravatar_id":"","url":"https://api.github.com/users/wouterbles","html_url":"https://github.com/wouterbles","followers_url":"https://api.github.com/users/wouterbles/followers","following_url":"https://api.github.com/users/wouterbles/following{/other_user}","gists_url":"https://api.github.com/users/wouterbles/gists{/gist_id}","starred_url":"https://api.github.com/users/wouterbles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wouterbles/subscriptions","organizations_url":"https://api.github.com/users/wouterbles/orgs","repos_url":"https://api.github.com/users/wouterbles/repos","events_url":"https://api.github.com/users/wouterbles/events{/privacy}","received_events_url":"https://api.github.com/users/wouterbles/received_events","type":"User","site_admin":false},"body":"bookrepo verwijderd","created_at":"2018-12-03T14:20:10Z","updated_at":"2018-12-03T14:20:30Z","html_url":"https://github.com/esac-ic/esac.nl/pull/28#discussion_r238284887","pull_request_url":"https://api.github.com/repos/esac-ic/esac.nl/pulls/28","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/esac-ic/esac.nl/pulls/comments/238284887"},"html":{"href":"https://github.com/esac-ic/esac.nl/pull/28#discussion_r238284887"},"pull_request":{"href":"https://api.github.com/repos/esac-ic/esac.nl/pulls/28"}}},"pull_request":{"url":"https://api.github.com/repos/esac-ic/esac.nl/pulls/28","id":227478631,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDc4NjMx","html_url":"https://github.com/esac-ic/esac.nl/pull/28","diff_url":"https://github.com/esac-ic/esac.nl/pull/28.diff","patch_url":"https://github.com/esac-ic/esac.nl/pull/28.patch","issue_url":"https://api.github.com/repos/esac-ic/esac.nl/issues/28","number":28,"state":"open","locked":false,"title":"Photoalbums","user":{"login":"indiePeeters","id":16254233,"node_id":"MDQ6VXNlcjE2MjU0MjMz","avatar_url":"https://avatars3.githubusercontent.com/u/16254233?v=4","gravatar_id":"","url":"https://api.github.com/users/indiePeeters","html_url":"https://github.com/indiePeeters","followers_url":"https://api.github.com/users/indiePeeters/followers","following_url":"https://api.github.com/users/indiePeeters/following{/other_user}","gists_url":"https://api.github.com/users/indiePeeters/gists{/gist_id}","starred_url":"https://api.github.com/users/indiePeeters/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indiePeeters/subscriptions","organizations_url":"https://api.github.com/users/indiePeeters/orgs","repos_url":"https://api.github.com/users/indiePeeters/repos","events_url":"https://api.github.com/users/indiePeeters/events{/privacy}","received_events_url":"https://api.github.com/users/indiePeeters/received_events","type":"User","site_admin":false},"body":"Om gehele albums te kunnen uploaden is het belangrijk dat de regel max_execution_time naar 90 gezet wordt in de php.ini file. \r\n\r\n\r\n**known issues:**\r\nPagination in album pagina\r\npagination in photo pagina\r\nPotrait fotos vallen niet netjes in de paginas\r\nAlbums gesorteerd op id ipv Datum\r\n","created_at":"2018-11-01T00:14:17Z","updated_at":"2018-12-03T14:20:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c90ec03fc93fcb2f00cdb34601d2d6432a51dc6c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"marijnvanderhorst","id":7057618,"node_id":"MDQ6VXNlcjcwNTc2MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/7057618?v=4","gravatar_id":"","url":"https://api.github.com/users/marijnvanderhorst","html_url":"https://github.com/marijnvanderhorst","followers_url":"https://api.github.com/users/marijnvanderhorst/followers","following_url":"https://api.github.com/users/marijnvanderhorst/following{/other_user}","gists_url":"https://api.github.com/users/marijnvanderhorst/gists{/gist_id}","starred_url":"https://api.github.com/users/marijnvanderhorst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marijnvanderhorst/subscriptions","organizations_url":"https://api.github.com/users/marijnvanderhorst/orgs","repos_url":"https://api.github.com/users/marijnvanderhorst/repos","events_url":"https://api.github.com/users/marijnvanderhorst/events{/privacy}","received_events_url":"https://api.github.com/users/marijnvanderhorst/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/esac-ic/esac.nl/pulls/28/commits","review_comments_url":"https://api.github.com/repos/esac-ic/esac.nl/pulls/28/comments","review_comment_url":"https://api.github.com/repos/esac-ic/esac.nl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/esac-ic/esac.nl/issues/28/comments","statuses_url":"https://api.github.com/repos/esac-ic/esac.nl/statuses/2719efa6c8622a84c43801e7f17c1aa17c3deda8","head":{"label":"esac-ic:Photoalbums","ref":"Photoalbums","sha":"2719efa6c8622a84c43801e7f17c1aa17c3deda8","user":{"login":"esac-ic","id":37651032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjUxMDMy","avatar_url":"https://avatars3.githubusercontent.com/u/37651032?v=4","gravatar_id":"","url":"https://api.github.com/users/esac-ic","html_url":"https://github.com/esac-ic","followers_url":"https://api.github.com/users/esac-ic/followers","following_url":"https://api.github.com/users/esac-ic/following{/other_user}","gists_url":"https://api.github.com/users/esac-ic/gists{/gist_id}","starred_url":"https://api.github.com/users/esac-ic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esac-ic/subscriptions","organizations_url":"https://api.github.com/users/esac-ic/orgs","repos_url":"https://api.github.com/users/esac-ic/repos","events_url":"https://api.github.com/users/esac-ic/events{/privacy}","received_events_url":"https://api.github.com/users/esac-ic/received_events","type":"Organization","site_admin":false},"repo":{"id":126292118,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyOTIxMTg=","name":"esac.nl","full_name":"esac-ic/esac.nl","private":false,"owner":{"login":"esac-ic","id":37651032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjUxMDMy","avatar_url":"https://avatars3.githubusercontent.com/u/37651032?v=4","gravatar_id":"","url":"https://api.github.com/users/esac-ic","html_url":"https://github.com/esac-ic","followers_url":"https://api.github.com/users/esac-ic/followers","following_url":"https://api.github.com/users/esac-ic/following{/other_user}","gists_url":"https://api.github.com/users/esac-ic/gists{/gist_id}","starred_url":"https://api.github.com/users/esac-ic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esac-ic/subscriptions","organizations_url":"https://api.github.com/users/esac-ic/orgs","repos_url":"https://api.github.com/users/esac-ic/repos","events_url":"https://api.github.com/users/esac-ic/events{/privacy}","received_events_url":"https://api.github.com/users/esac-ic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/esac-ic/esac.nl","description":"Website voor de Eindhovense Studenten Alpen Club","fork":false,"url":"https://api.github.com/repos/esac-ic/esac.nl","forks_url":"https://api.github.com/repos/esac-ic/esac.nl/forks","keys_url":"https://api.github.com/repos/esac-ic/esac.nl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esac-ic/esac.nl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esac-ic/esac.nl/teams","hooks_url":"https://api.github.com/repos/esac-ic/esac.nl/hooks","issue_events_url":"https://api.github.com/repos/esac-ic/esac.nl/issues/events{/number}","events_url":"https://api.github.com/repos/esac-ic/esac.nl/events","assignees_url":"https://api.github.com/repos/esac-ic/esac.nl/assignees{/user}","branches_url":"https://api.github.com/repos/esac-ic/esac.nl/branches{/branch}","tags_url":"https://api.github.com/repos/esac-ic/esac.nl/tags","blobs_url":"https://api.github.com/repos/esac-ic/esac.nl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esac-ic/esac.nl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esac-ic/esac.nl/git/refs{/sha}","trees_url":"https://api.github.com/repos/esac-ic/esac.nl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esac-ic/esac.nl/statuses/{sha}","languages_url":"https://api.github.com/repos/esac-ic/esac.nl/languages","stargazers_url":"https://api.github.com/repos/esac-ic/esac.nl/stargazers","contributors_url":"https://api.github.com/repos/esac-ic/esac.nl/contributors","subscribers_url":"https://api.github.com/repos/esac-ic/esac.nl/subscribers","subscription_url":"https://api.github.com/repos/esac-ic/esac.nl/subscription","commits_url":"https://api.github.com/repos/esac-ic/esac.nl/commits{/sha}","git_commits_url":"https://api.github.com/repos/esac-ic/esac.nl/git/commits{/sha}","comments_url":"https://api.github.com/repos/esac-ic/esac.nl/comments{/number}","issue_comment_url":"https://api.github.com/repos/esac-ic/esac.nl/issues/comments{/number}","contents_url":"https://api.github.com/repos/esac-ic/esac.nl/contents/{+path}","compare_url":"https://api.github.com/repos/esac-ic/esac.nl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esac-ic/esac.nl/merges","archive_url":"https://api.github.com/repos/esac-ic/esac.nl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esac-ic/esac.nl/downloads","issues_url":"https://api.github.com/repos/esac-ic/esac.nl/issues{/number}","pulls_url":"https://api.github.com/repos/esac-ic/esac.nl/pulls{/number}","milestones_url":"https://api.github.com/repos/esac-ic/esac.nl/milestones{/number}","notifications_url":"https://api.github.com/repos/esac-ic/esac.nl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esac-ic/esac.nl/labels{/name}","releases_url":"https://api.github.com/repos/esac-ic/esac.nl/releases{/id}","deployments_url":"https://api.github.com/repos/esac-ic/esac.nl/deployments","created_at":"2018-03-22T06:49:49Z","updated_at":"2018-11-30T22:33:08Z","pushed_at":"2018-12-02T21:06:30Z","git_url":"git://github.com/esac-ic/esac.nl.git","ssh_url":"[email protected]:esac-ic/esac.nl.git","clone_url":"https://github.com/esac-ic/esac.nl.git","svn_url":"https://github.com/esac-ic/esac.nl","homepage":"https://esac.nl","size":4456,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":3,"open_issues":16,"watchers":3,"default_branch":"master"}},"base":{"label":"esac-ic:master","ref":"master","sha":"381c0799f4b475d5a5228fe0cb28fc959d59a04d","user":{"login":"esac-ic","id":37651032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjUxMDMy","avatar_url":"https://avatars3.githubusercontent.com/u/37651032?v=4","gravatar_id":"","url":"https://api.github.com/users/esac-ic","html_url":"https://github.com/esac-ic","followers_url":"https://api.github.com/users/esac-ic/followers","following_url":"https://api.github.com/users/esac-ic/following{/other_user}","gists_url":"https://api.github.com/users/esac-ic/gists{/gist_id}","starred_url":"https://api.github.com/users/esac-ic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esac-ic/subscriptions","organizations_url":"https://api.github.com/users/esac-ic/orgs","repos_url":"https://api.github.com/users/esac-ic/repos","events_url":"https://api.github.com/users/esac-ic/events{/privacy}","received_events_url":"https://api.github.com/users/esac-ic/received_events","type":"Organization","site_admin":false},"repo":{"id":126292118,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYyOTIxMTg=","name":"esac.nl","full_name":"esac-ic/esac.nl","private":false,"owner":{"login":"esac-ic","id":37651032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3NjUxMDMy","avatar_url":"https://avatars3.githubusercontent.com/u/37651032?v=4","gravatar_id":"","url":"https://api.github.com/users/esac-ic","html_url":"https://github.com/esac-ic","followers_url":"https://api.github.com/users/esac-ic/followers","following_url":"https://api.github.com/users/esac-ic/following{/other_user}","gists_url":"https://api.github.com/users/esac-ic/gists{/gist_id}","starred_url":"https://api.github.com/users/esac-ic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/esac-ic/subscriptions","organizations_url":"https://api.github.com/users/esac-ic/orgs","repos_url":"https://api.github.com/users/esac-ic/repos","events_url":"https://api.github.com/users/esac-ic/events{/privacy}","received_events_url":"https://api.github.com/users/esac-ic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/esac-ic/esac.nl","description":"Website voor de Eindhovense Studenten Alpen Club","fork":false,"url":"https://api.github.com/repos/esac-ic/esac.nl","forks_url":"https://api.github.com/repos/esac-ic/esac.nl/forks","keys_url":"https://api.github.com/repos/esac-ic/esac.nl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/esac-ic/esac.nl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/esac-ic/esac.nl/teams","hooks_url":"https://api.github.com/repos/esac-ic/esac.nl/hooks","issue_events_url":"https://api.github.com/repos/esac-ic/esac.nl/issues/events{/number}","events_url":"https://api.github.com/repos/esac-ic/esac.nl/events","assignees_url":"https://api.github.com/repos/esac-ic/esac.nl/assignees{/user}","branches_url":"https://api.github.com/repos/esac-ic/esac.nl/branches{/branch}","tags_url":"https://api.github.com/repos/esac-ic/esac.nl/tags","blobs_url":"https://api.github.com/repos/esac-ic/esac.nl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/esac-ic/esac.nl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/esac-ic/esac.nl/git/refs{/sha}","trees_url":"https://api.github.com/repos/esac-ic/esac.nl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/esac-ic/esac.nl/statuses/{sha}","languages_url":"https://api.github.com/repos/esac-ic/esac.nl/languages","stargazers_url":"https://api.github.com/repos/esac-ic/esac.nl/stargazers","contributors_url":"https://api.github.com/repos/esac-ic/esac.nl/contributors","subscribers_url":"https://api.github.com/repos/esac-ic/esac.nl/subscribers","subscription_url":"https://api.github.com/repos/esac-ic/esac.nl/subscription","commits_url":"https://api.github.com/repos/esac-ic/esac.nl/commits{/sha}","git_commits_url":"https://api.github.com/repos/esac-ic/esac.nl/git/commits{/sha}","comments_url":"https://api.github.com/repos/esac-ic/esac.nl/comments{/number}","issue_comment_url":"https://api.github.com/repos/esac-ic/esac.nl/issues/comments{/number}","contents_url":"https://api.github.com/repos/esac-ic/esac.nl/contents/{+path}","compare_url":"https://api.github.com/repos/esac-ic/esac.nl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/esac-ic/esac.nl/merges","archive_url":"https://api.github.com/repos/esac-ic/esac.nl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/esac-ic/esac.nl/downloads","issues_url":"https://api.github.com/repos/esac-ic/esac.nl/issues{/number}","pulls_url":"https://api.github.com/repos/esac-ic/esac.nl/pulls{/number}","milestones_url":"https://api.github.com/repos/esac-ic/esac.nl/milestones{/number}","notifications_url":"https://api.github.com/repos/esac-ic/esac.nl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/esac-ic/esac.nl/labels{/name}","releases_url":"https://api.github.com/repos/esac-ic/esac.nl/releases{/id}","deployments_url":"https://api.github.com/repos/esac-ic/esac.nl/deployments","created_at":"2018-03-22T06:49:49Z","updated_at":"2018-11-30T22:33:08Z","pushed_at":"2018-12-02T21:06:30Z","git_url":"git://github.com/esac-ic/esac.nl.git","ssh_url":"[email protected]:esac-ic/esac.nl.git","clone_url":"https://github.com/esac-ic/esac.nl.git","svn_url":"https://github.com/esac-ic/esac.nl","homepage":"https://esac.nl","size":4456,"stargazers_count":3,"watchers_count":3,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":3,"open_issues":16,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/esac-ic/esac.nl/pulls/28"},"html":{"href":"https://github.com/esac-ic/esac.nl/pull/28"},"issue":{"href":"https://api.github.com/repos/esac-ic/esac.nl/issues/28"},"comments":{"href":"https://api.github.com/repos/esac-ic/esac.nl/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/esac-ic/esac.nl/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/esac-ic/esac.nl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/esac-ic/esac.nl/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/esac-ic/esac.nl/statuses/2719efa6c8622a84c43801e7f17c1aa17c3deda8"}},"author_association":"NONE"}}

8687666790

{"actor":{"display_login":"wouterbles"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/comments/238132623","pull_request_review_id":180598186,"id":238132623,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODEzMjYyMw==","diff_hunk":"@@ -371,16 +373,19 @@ func ValidateOp(st *storage.LevelDBBackend, config common.Config, source *block.\n \t\t\treturn errors.InvalidOperation\n \t\t}\n \n-\t\texists, err := block.ExistsBlockOperation(st, inflationPF.VotingResult)\n-\t\tif err != nil || !exists {\n-\t\t\treturn errors.InflationPFResultMissed\n-\t\t}\n-\n \t\tvar congressVotingHash string\n \t\t{\n \t\t\tvar bo block.BlockOperation\n \t\t\tvar err error\n-\t\t\tif bo, err = block.GetBlockOperation(st, inflationPF.VotingResult); err != nil {\n+\n+\t\t\tvar opIndex int\n+\t\t\tparsedCongressVotingResultHash := strings.Split(inflationPF.VotingResult, \"-\") //0:TxHash, 1:Index\n+\t\t\ttxHash := parsedCongressVotingResultHash[0]\n+\t\t\tif opIndex, err = strconv.Atoi(parsedCongressVotingResultHash[1]); err != nil {\n+\t\t\t\treturn errors.InvalidOperation\n+\t\t\t}","path":"lib/node/runner/checker_ballot_transaction.go","position":29,"original_position":29,"commit_id":"d008441a665de6d1f2f0cf6ea4307a5c19df8503","original_commit_id":"d008441a665de6d1f2f0cf6ea4307a5c19df8503","user":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"body":"This checking also should be checked in `CongressVotingResult.IsWellformed()`.","created_at":"2018-12-03T02:47:15Z","updated_at":"2018-12-03T02:47:49Z","html_url":"https://github.com/bosnet/sebak/pull/850#discussion_r238132623","pull_request_url":"https://api.github.com/repos/bosnet/sebak/pulls/850","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/comments/238132623"},"html":{"href":"https://github.com/bosnet/sebak/pull/850#discussion_r238132623"},"pull_request":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/850"}}},"pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/850","id":234526384,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NTI2Mzg0","html_url":"https://github.com/bosnet/sebak/pull/850","diff_url":"https://github.com/bosnet/sebak/pull/850.diff","patch_url":"https://github.com/bosnet/sebak/pull/850.patch","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/850","number":850,"state":"open","locked":false,"title":"Do not use Operation Hash for validation","user":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"body":"### Github Issue\r\n#851 \r\n\r\n### Background\r\nsee #851 \r\n\r\n### Solution\r\n* Do not use Operation Hash for validation\r\n* Identifier the operation is changed to Tx + Index\r\n\r\n### Possible Drawbacks\r\n<!--\r\n What are the possible side-effects or negative impacts of the code change?\r\n-->\r\n\r\n","created_at":"2018-11-29T06:48:26Z","updated_at":"2018-12-03T02:47:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fe96cb0db4653bb76565cd00ea94f9afb798b1cf","assignee":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"assignees":[{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"anarcher","id":12271,"node_id":"MDQ6VXNlcjEyMjcx","avatar_url":"https://avatars1.githubusercontent.com/u/12271?v=4","gravatar_id":"","url":"https://api.github.com/users/anarcher","html_url":"https://github.com/anarcher","followers_url":"https://api.github.com/users/anarcher/followers","following_url":"https://api.github.com/users/anarcher/following{/other_user}","gists_url":"https://api.github.com/users/anarcher/gists{/gist_id}","starred_url":"https://api.github.com/users/anarcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anarcher/subscriptions","organizations_url":"https://api.github.com/users/anarcher/orgs","repos_url":"https://api.github.com/users/anarcher/repos","events_url":"https://api.github.com/users/anarcher/events{/privacy}","received_events_url":"https://api.github.com/users/anarcher/received_events","type":"User","site_admin":false},{"login":"outsideris","id":390146,"node_id":"MDQ6VXNlcjM5MDE0Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/390146?v=4","gravatar_id":"","url":"https://api.github.com/users/outsideris","html_url":"https://github.com/outsideris","followers_url":"https://api.github.com/users/outsideris/followers","following_url":"https://api.github.com/users/outsideris/following{/other_user}","gists_url":"https://api.github.com/users/outsideris/gists{/gist_id}","starred_url":"https://api.github.com/users/outsideris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/outsideris/subscriptions","organizations_url":"https://api.github.com/users/outsideris/orgs","repos_url":"https://api.github.com/users/outsideris/repos","events_url":"https://api.github.com/users/outsideris/events{/privacy}","received_events_url":"https://api.github.com/users/outsideris/received_events","type":"User","site_admin":false},{"login":"soonkuk","id":24219197,"node_id":"MDQ6VXNlcjI0MjE5MTk3","avatar_url":"https://avatars0.githubusercontent.com/u/24219197?v=4","gravatar_id":"","url":"https://api.github.com/users/soonkuk","html_url":"https://github.com/soonkuk","followers_url":"https://api.github.com/users/soonkuk/followers","following_url":"https://api.github.com/users/soonkuk/following{/other_user}","gists_url":"https://api.github.com/users/soonkuk/gists{/gist_id}","starred_url":"https://api.github.com/users/soonkuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonkuk/subscriptions","organizations_url":"https://api.github.com/users/soonkuk/orgs","repos_url":"https://api.github.com/users/soonkuk/repos","events_url":"https://api.github.com/users/soonkuk/events{/privacy}","received_events_url":"https://api.github.com/users/soonkuk/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bosnet/sebak/pulls/850/commits","review_comments_url":"https://api.github.com/repos/bosnet/sebak/pulls/850/comments","review_comment_url":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/850/comments","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/d008441a665de6d1f2f0cf6ea4307a5c19df8503","head":{"label":"kfangw:congressvoting_validation_tx","ref":"congressvoting_validation_tx","sha":"d008441a665de6d1f2f0cf6ea4307a5c19df8503","user":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"repo":{"id":137439556,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc0Mzk1NTY=","name":"sebak","full_name":"kfangw/sebak","private":false,"owner":{"login":"kfangw","id":973304,"node_id":"MDQ6VXNlcjk3MzMwNA==","avatar_url":"https://avatars2.githubusercontent.com/u/973304?v=4","gravatar_id":"","url":"https://api.github.com/users/kfangw","html_url":"https://github.com/kfangw","followers_url":"https://api.github.com/users/kfangw/followers","following_url":"https://api.github.com/users/kfangw/following{/other_user}","gists_url":"https://api.github.com/users/kfangw/gists{/gist_id}","starred_url":"https://api.github.com/users/kfangw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kfangw/subscriptions","organizations_url":"https://api.github.com/users/kfangw/orgs","repos_url":"https://api.github.com/users/kfangw/repos","events_url":"https://api.github.com/users/kfangw/events{/privacy}","received_events_url":"https://api.github.com/users/kfangw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kfangw/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":true,"url":"https://api.github.com/repos/kfangw/sebak","forks_url":"https://api.github.com/repos/kfangw/sebak/forks","keys_url":"https://api.github.com/repos/kfangw/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kfangw/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kfangw/sebak/teams","hooks_url":"https://api.github.com/repos/kfangw/sebak/hooks","issue_events_url":"https://api.github.com/repos/kfangw/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/kfangw/sebak/events","assignees_url":"https://api.github.com/repos/kfangw/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/kfangw/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/kfangw/sebak/tags","blobs_url":"https://api.github.com/repos/kfangw/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kfangw/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kfangw/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/kfangw/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kfangw/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/kfangw/sebak/languages","stargazers_url":"https://api.github.com/repos/kfangw/sebak/stargazers","contributors_url":"https://api.github.com/repos/kfangw/sebak/contributors","subscribers_url":"https://api.github.com/repos/kfangw/sebak/subscribers","subscription_url":"https://api.github.com/repos/kfangw/sebak/subscription","commits_url":"https://api.github.com/repos/kfangw/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/kfangw/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/kfangw/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/kfangw/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/kfangw/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/kfangw/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kfangw/sebak/merges","archive_url":"https://api.github.com/repos/kfangw/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kfangw/sebak/downloads","issues_url":"https://api.github.com/repos/kfangw/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/kfangw/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/kfangw/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/kfangw/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kfangw/sebak/labels{/name}","releases_url":"https://api.github.com/repos/kfangw/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/kfangw/sebak/deployments","created_at":"2018-06-15T04:05:44Z","updated_at":"2018-11-15T06:56:22Z","pushed_at":"2018-11-29T09:20:43Z","git_url":"git://github.com/kfangw/sebak.git","ssh_url":"[email protected]:kfangw/sebak.git","clone_url":"https://github.com/kfangw/sebak.git","svn_url":"https://github.com/kfangw/sebak","homepage":"https://boscoin.io","size":2338,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"bosnet:master","ref":"master","sha":"3763bb149aba2cf40cfff5ba603180c9029ddb3f","user":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"repo":{"id":129848943,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4NDg5NDM=","name":"sebak","full_name":"bosnet/sebak","private":false,"owner":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bosnet/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":false,"url":"https://api.github.com/repos/bosnet/sebak","forks_url":"https://api.github.com/repos/bosnet/sebak/forks","keys_url":"https://api.github.com/repos/bosnet/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bosnet/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bosnet/sebak/teams","hooks_url":"https://api.github.com/repos/bosnet/sebak/hooks","issue_events_url":"https://api.github.com/repos/bosnet/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/bosnet/sebak/events","assignees_url":"https://api.github.com/repos/bosnet/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/bosnet/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/bosnet/sebak/tags","blobs_url":"https://api.github.com/repos/bosnet/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bosnet/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bosnet/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/bosnet/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/bosnet/sebak/languages","stargazers_url":"https://api.github.com/repos/bosnet/sebak/stargazers","contributors_url":"https://api.github.com/repos/bosnet/sebak/contributors","subscribers_url":"https://api.github.com/repos/bosnet/sebak/subscribers","subscription_url":"https://api.github.com/repos/bosnet/sebak/subscription","commits_url":"https://api.github.com/repos/bosnet/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/bosnet/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/bosnet/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/bosnet/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/bosnet/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/bosnet/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bosnet/sebak/merges","archive_url":"https://api.github.com/repos/bosnet/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bosnet/sebak/downloads","issues_url":"https://api.github.com/repos/bosnet/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/bosnet/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/bosnet/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/bosnet/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bosnet/sebak/labels{/name}","releases_url":"https://api.github.com/repos/bosnet/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/bosnet/sebak/deployments","created_at":"2018-04-17T05:05:34Z","updated_at":"2018-12-03T02:04:42Z","pushed_at":"2018-12-03T02:04:39Z","git_url":"git://github.com/bosnet/sebak.git","ssh_url":"[email protected]:bosnet/sebak.git","clone_url":"https://github.com/bosnet/sebak.git","svn_url":"https://github.com/bosnet/sebak","homepage":"https://bosnet.github.io","size":2307,"stargazers_count":38,"watchers_count":38,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":91,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":16,"open_issues":91,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/850"},"html":{"href":"https://github.com/bosnet/sebak/pull/850"},"issue":{"href":"https://api.github.com/repos/bosnet/sebak/issues/850"},"comments":{"href":"https://api.github.com/repos/bosnet/sebak/issues/850/comments"},"review_comments":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/850/comments"},"review_comment":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/850/commits"},"statuses":{"href":"https://api.github.com/repos/bosnet/sebak/statuses/d008441a665de6d1f2f0cf6ea4307a5c19df8503"}},"author_association":"MEMBER"}}

8684525364

{"actor":{"display_login":"spikeekips"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/improbable-research/keanu/pulls/comments/210083740","pull_request_review_id":146215368,"id":210083740,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDA4Mzc0MA==","diff_hunk":"@@ -11,43 +11,46 @@\n import io.improbable.keanu.vertices.dbl.KeanuRandom;\n \n /**\n- * Computer Generation of Statistical Distributions\n+ * @see \"Computer Generation of Statistical Distributions\n * by Richard Saucier\n * ARL-TR-2168 March 2000\n- * 5.2.8 page 49\n+ * 5.2.8 page 49\"\n */\n public class Poisson implements DiscreteDistribution {\n \n- private final DoubleTensor mu;\n+ private final DoubleTensor rate;","path":"keanu-project/src/main/java/io/improbable/keanu/distributions/discrete/Poisson.java","position":14,"original_position":14,"commit_id":"41d26026d6f22b27476b176e028f58c3682e4d1d","original_commit_id":"41d26026d6f22b27476b176e028f58c3682e4d1d","user":{"login":"migwellian","id":1508452,"node_id":"MDQ6VXNlcjE1MDg0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1508452?v=4","gravatar_id":"","url":"https://api.github.com/users/migwellian","html_url":"https://github.com/migwellian","followers_url":"https://api.github.com/users/migwellian/followers","following_url":"https://api.github.com/users/migwellian/following{/other_user}","gists_url":"https://api.github.com/users/migwellian/gists{/gist_id}","starred_url":"https://api.github.com/users/migwellian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/migwellian/subscriptions","organizations_url":"https://api.github.com/users/migwellian/orgs","repos_url":"https://api.github.com/users/migwellian/repos","events_url":"https://api.github.com/users/migwellian/events{/privacy}","received_events_url":"https://api.github.com/users/migwellian/received_events","type":"User","site_admin":false},"body":"sgtm - especially since wikipedia calls it lambda and wolfram calls it nu!","created_at":"2018-08-14T19:58:13Z","updated_at":"2018-08-14T19:58:26Z","html_url":"https://github.com/improbable-research/keanu/pull/168#discussion_r210083740","pull_request_url":"https://api.github.com/repos/improbable-research/keanu/pulls/168","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/comments/210083740"},"html":{"href":"https://github.com/improbable-research/keanu/pull/168#discussion_r210083740"},"pull_request":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/168"}}},"pull_request":{"url":"https://api.github.com/repos/improbable-research/keanu/pulls/168","id":208322440,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzIyNDQw","html_url":"https://github.com/improbable-research/keanu/pull/168","diff_url":"https://github.com/improbable-research/keanu/pull/168.diff","patch_url":"https://github.com/improbable-research/keanu/pull/168.patch","issue_url":"https://api.github.com/repos/improbable-research/keanu/issues/168","number":168,"state":"open","locked":false,"title":"Some work on `withParameters` API for distributions","user":{"login":"icantsayrural","id":13027838,"node_id":"MDQ6VXNlcjEzMDI3ODM4","avatar_url":"https://avatars1.githubusercontent.com/u/13027838?v=4","gravatar_id":"","url":"https://api.github.com/users/icantsayrural","html_url":"https://github.com/icantsayrural","followers_url":"https://api.github.com/users/icantsayrural/followers","following_url":"https://api.github.com/users/icantsayrural/following{/other_user}","gists_url":"https://api.github.com/users/icantsayrural/gists{/gist_id}","starred_url":"https://api.github.com/users/icantsayrural/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icantsayrural/subscriptions","organizations_url":"https://api.github.com/users/icantsayrural/orgs","repos_url":"https://api.github.com/users/icantsayrural/repos","events_url":"https://api.github.com/users/icantsayrural/events{/privacy}","received_events_url":"https://api.github.com/users/icantsayrural/received_events","type":"User","site_admin":false},"body":"I realise this is a controversial change. I'm open to feedback. Also, I didn't finish some tasks, because I wanted to first continue our slack discussion in a PR since we can all see the method signatures here.\r\n\r\n- [x] Rename most parameters to [location](https://en.wikipedia.org/wiki/Location_parameter), [scale](https://en.wikipedia.org/wiki/Scale_parameter) or [shape](https://en.wikipedia.org/wiki/Shape_parameter) (alpha, beta, ...) where appropriate\r\n- [x] Add a JavaDoc for `withParameters` method explaining the parameters in\r\ndetail, alternate names of the distribution and references to books/wiki\r\npages\r\n- [x] Add a JavaDoc for sample methods that throw exceptions\r\n- [ ] Clean up `Diff` parameter names\r\n- [ ] Rename local variables (stopped making changes in case we don't go through with my suggestion)\r\n\r\nNote: the shape parameter is not called `shape` because (1) the name\r\nclashes with `shape` for tensors (2) there may be more than one shape\r\nparameters (e.g. see Beta Distribution)\r\n\r\nBest way to test this would be to enable JavaDocs on Intellji: go to File/Settings, Editor, click on General. Scroll down, then ✔ Show quick documentation on mouse move\r\n\r\n","created_at":"2018-08-14T15:30:55Z","updated_at":"2018-08-14T19:58:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2d864dbd91b38c6d4c6128dc64a7b49c119e474","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gordoncaleb","id":1253165,"node_id":"MDQ6VXNlcjEyNTMxNjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1253165?v=4","gravatar_id":"","url":"https://api.github.com/users/gordoncaleb","html_url":"https://github.com/gordoncaleb","followers_url":"https://api.github.com/users/gordoncaleb/followers","following_url":"https://api.github.com/users/gordoncaleb/following{/other_user}","gists_url":"https://api.github.com/users/gordoncaleb/gists{/gist_id}","starred_url":"https://api.github.com/users/gordoncaleb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gordoncaleb/subscriptions","organizations_url":"https://api.github.com/users/gordoncaleb/orgs","repos_url":"https://api.github.com/users/gordoncaleb/repos","events_url":"https://api.github.com/users/gordoncaleb/events{/privacy}","received_events_url":"https://api.github.com/users/gordoncaleb/received_events","type":"User","site_admin":false},{"login":"GeorgeNash","id":5854544,"node_id":"MDQ6VXNlcjU4NTQ1NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/5854544?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeNash","html_url":"https://github.com/GeorgeNash","followers_url":"https://api.github.com/users/GeorgeNash/followers","following_url":"https://api.github.com/users/GeorgeNash/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeNash/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeNash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeNash/subscriptions","organizations_url":"https://api.github.com/users/GeorgeNash/orgs","repos_url":"https://api.github.com/users/GeorgeNash/repos","events_url":"https://api.github.com/users/GeorgeNash/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeNash/received_events","type":"User","site_admin":false},{"login":"chris-major-improbable","id":19412775,"node_id":"MDQ6VXNlcjE5NDEyNzc1","avatar_url":"https://avatars0.githubusercontent.com/u/19412775?v=4","gravatar_id":"","url":"https://api.github.com/users/chris-major-improbable","html_url":"https://github.com/chris-major-improbable","followers_url":"https://api.github.com/users/chris-major-improbable/followers","following_url":"https://api.github.com/users/chris-major-improbable/following{/other_user}","gists_url":"https://api.github.com/users/chris-major-improbable/gists{/gist_id}","starred_url":"https://api.github.com/users/chris-major-improbable/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chris-major-improbable/subscriptions","organizations_url":"https://api.github.com/users/chris-major-improbable/orgs","repos_url":"https://api.github.com/users/chris-major-improbable/repos","events_url":"https://api.github.com/users/chris-major-improbable/events{/privacy}","received_events_url":"https://api.github.com/users/chris-major-improbable/received_events","type":"User","site_admin":false},{"login":"christophernorth","id":41296447,"node_id":"MDQ6VXNlcjQxMjk2NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/41296447?v=4","gravatar_id":"","url":"https://api.github.com/users/christophernorth","html_url":"https://github.com/christophernorth","followers_url":"https://api.github.com/users/christophernorth/followers","following_url":"https://api.github.com/users/christophernorth/following{/other_user}","gists_url":"https://api.github.com/users/christophernorth/gists{/gist_id}","starred_url":"https://api.github.com/users/christophernorth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophernorth/subscriptions","organizations_url":"https://api.github.com/users/christophernorth/orgs","repos_url":"https://api.github.com/users/christophernorth/repos","events_url":"https://api.github.com/users/christophernorth/events{/privacy}","received_events_url":"https://api.github.com/users/christophernorth/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/improbable-research/keanu/pulls/168/commits","review_comments_url":"https://api.github.com/repos/improbable-research/keanu/pulls/168/comments","review_comment_url":"https://api.github.com/repos/improbable-research/keanu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/improbable-research/keanu/issues/168/comments","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/41d26026d6f22b27476b176e028f58c3682e4d1d","head":{"label":"improbable-research:javadoc","ref":"javadoc","sha":"41d26026d6f22b27476b176e028f58c3682e4d1d","user":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"repo":{"id":128393918,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzOTM5MTg=","name":"keanu","full_name":"improbable-research/keanu","owner":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-research/keanu","description":"A probabilistic approach from an Improbabilistic company","fork":false,"url":"https://api.github.com/repos/improbable-research/keanu","forks_url":"https://api.github.com/repos/improbable-research/keanu/forks","keys_url":"https://api.github.com/repos/improbable-research/keanu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-research/keanu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-research/keanu/teams","hooks_url":"https://api.github.com/repos/improbable-research/keanu/hooks","issue_events_url":"https://api.github.com/repos/improbable-research/keanu/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-research/keanu/events","assignees_url":"https://api.github.com/repos/improbable-research/keanu/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-research/keanu/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-research/keanu/tags","blobs_url":"https://api.github.com/repos/improbable-research/keanu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-research/keanu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-research/keanu/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-research/keanu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-research/keanu/languages","stargazers_url":"https://api.github.com/repos/improbable-research/keanu/stargazers","contributors_url":"https://api.github.com/repos/improbable-research/keanu/contributors","subscribers_url":"https://api.github.com/repos/improbable-research/keanu/subscribers","subscription_url":"https://api.github.com/repos/improbable-research/keanu/subscription","commits_url":"https://api.github.com/repos/improbable-research/keanu/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-research/keanu/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-research/keanu/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-research/keanu/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-research/keanu/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-research/keanu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-research/keanu/merges","archive_url":"https://api.github.com/repos/improbable-research/keanu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-research/keanu/downloads","issues_url":"https://api.github.com/repos/improbable-research/keanu/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-research/keanu/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-research/keanu/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-research/keanu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-research/keanu/labels{/name}","releases_url":"https://api.github.com/repos/improbable-research/keanu/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-research/keanu/deployments","created_at":"2018-04-06T12:48:36Z","updated_at":"2018-08-14T15:32:31Z","pushed_at":"2018-08-14T17:35:14Z","git_url":"git://github.com/improbable-research/keanu.git","ssh_url":"[email protected]:improbable-research/keanu.git","clone_url":"https://github.com/improbable-research/keanu.git","svn_url":"https://github.com/improbable-research/keanu","homepage":"","size":3908,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":17,"watchers":76,"default_branch":"develop"}},"base":{"label":"improbable-research:develop","ref":"develop","sha":"80d2ffa37d57fa9ac9ea63eacc2f1e150e399ccf","user":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"repo":{"id":128393918,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgzOTM5MTg=","name":"keanu","full_name":"improbable-research/keanu","owner":{"login":"improbable-research","id":37903994,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTAzOTk0","avatar_url":"https://avatars1.githubusercontent.com/u/37903994?v=4","gravatar_id":"","url":"https://api.github.com/users/improbable-research","html_url":"https://github.com/improbable-research","followers_url":"https://api.github.com/users/improbable-research/followers","following_url":"https://api.github.com/users/improbable-research/following{/other_user}","gists_url":"https://api.github.com/users/improbable-research/gists{/gist_id}","starred_url":"https://api.github.com/users/improbable-research/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/improbable-research/subscriptions","organizations_url":"https://api.github.com/users/improbable-research/orgs","repos_url":"https://api.github.com/users/improbable-research/repos","events_url":"https://api.github.com/users/improbable-research/events{/privacy}","received_events_url":"https://api.github.com/users/improbable-research/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/improbable-research/keanu","description":"A probabilistic approach from an Improbabilistic company","fork":false,"url":"https://api.github.com/repos/improbable-research/keanu","forks_url":"https://api.github.com/repos/improbable-research/keanu/forks","keys_url":"https://api.github.com/repos/improbable-research/keanu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/improbable-research/keanu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/improbable-research/keanu/teams","hooks_url":"https://api.github.com/repos/improbable-research/keanu/hooks","issue_events_url":"https://api.github.com/repos/improbable-research/keanu/issues/events{/number}","events_url":"https://api.github.com/repos/improbable-research/keanu/events","assignees_url":"https://api.github.com/repos/improbable-research/keanu/assignees{/user}","branches_url":"https://api.github.com/repos/improbable-research/keanu/branches{/branch}","tags_url":"https://api.github.com/repos/improbable-research/keanu/tags","blobs_url":"https://api.github.com/repos/improbable-research/keanu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/improbable-research/keanu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/improbable-research/keanu/git/refs{/sha}","trees_url":"https://api.github.com/repos/improbable-research/keanu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/improbable-research/keanu/statuses/{sha}","languages_url":"https://api.github.com/repos/improbable-research/keanu/languages","stargazers_url":"https://api.github.com/repos/improbable-research/keanu/stargazers","contributors_url":"https://api.github.com/repos/improbable-research/keanu/contributors","subscribers_url":"https://api.github.com/repos/improbable-research/keanu/subscribers","subscription_url":"https://api.github.com/repos/improbable-research/keanu/subscription","commits_url":"https://api.github.com/repos/improbable-research/keanu/commits{/sha}","git_commits_url":"https://api.github.com/repos/improbable-research/keanu/git/commits{/sha}","comments_url":"https://api.github.com/repos/improbable-research/keanu/comments{/number}","issue_comment_url":"https://api.github.com/repos/improbable-research/keanu/issues/comments{/number}","contents_url":"https://api.github.com/repos/improbable-research/keanu/contents/{+path}","compare_url":"https://api.github.com/repos/improbable-research/keanu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/improbable-research/keanu/merges","archive_url":"https://api.github.com/repos/improbable-research/keanu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/improbable-research/keanu/downloads","issues_url":"https://api.github.com/repos/improbable-research/keanu/issues{/number}","pulls_url":"https://api.github.com/repos/improbable-research/keanu/pulls{/number}","milestones_url":"https://api.github.com/repos/improbable-research/keanu/milestones{/number}","notifications_url":"https://api.github.com/repos/improbable-research/keanu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/improbable-research/keanu/labels{/name}","releases_url":"https://api.github.com/repos/improbable-research/keanu/releases{/id}","deployments_url":"https://api.github.com/repos/improbable-research/keanu/deployments","created_at":"2018-04-06T12:48:36Z","updated_at":"2018-08-14T15:32:31Z","pushed_at":"2018-08-14T17:35:14Z","git_url":"git://github.com/improbable-research/keanu.git","ssh_url":"[email protected]:improbable-research/keanu.git","clone_url":"https://github.com/improbable-research/keanu.git","svn_url":"https://github.com/improbable-research/keanu","homepage":"","size":3908,"stargazers_count":76,"watchers_count":76,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":17,"watchers":76,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/168"},"html":{"href":"https://github.com/improbable-research/keanu/pull/168"},"issue":{"href":"https://api.github.com/repos/improbable-research/keanu/issues/168"},"comments":{"href":"https://api.github.com/repos/improbable-research/keanu/issues/168/comments"},"review_comments":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/168/comments"},"review_comment":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/improbable-research/keanu/pulls/168/commits"},"statuses":{"href":"https://api.github.com/repos/improbable-research/keanu/statuses/41d26026d6f22b27476b176e028f58c3682e4d1d"}},"author_association":"COLLABORATOR"}}

8113421784

{"actor":{"display_login":"migwellian"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/comments/206537319","pull_request_review_id":141966224,"id":206537319,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjUzNzMxOQ==","diff_hunk":"@@ -11,19 +15,70 @@ export default Wrapped =>\n \n constructor(props) {\n super(props);\n- this.state = {};\n+ this.state = {\n+ holiday: {},\n+ };\n }\n \n- approveHoliday = holidayId => {\n- console.log('approved');\n+ componentWillUpdate(nextProps) {\n+ if (nextProps.holiday !== this.props.holiday) {\n+ this.setState({ holiday: nextProps.holiday });\n+ }\n+ }\n+\n+ approveHoliday = () => {\n+ const holidayId = this.state.holiday.holidayId;\n+\n+ approveHoliday(holidayId)\n+ .then(() => {\n+ this.setState({\n+ holiday: {\n+ ...this.state.holiday,\n+ eventStatus: {\n+ ...this.state.holiday.eventStatus,\n+ eventStatusId: holidayStatus.APPROVED,\n+ },\n+ },\n+ });\n+ Toast({\n+ type: 'success',\n+ title: 'Holiday Approved',\n+ position: 'top-end',\n+ });\n+ })\n+ .catch(error => {\n+ swal('Error', `There was an error: ${error.message}. 'error`);\n+ });\n };\n \n- rejectHoliday = holidayId => {\n- console.log('rejected');\n+ rejectHoliday = () => {\n+ const holidayId = this.state.holiday.holidayId;\n+\n+ rejectHoliday(holidayId)","path":"web-app/src/components/HolidayModal/container.js","position":59,"original_position":59,"commit_id":"6f0c89c6633bbde6f20317039d33756d167debb3","original_commit_id":"6f0c89c6633bbde6f20317039d33756d167debb3","user":{"login":"paulmatchett","id":39831210,"node_id":"MDQ6VXNlcjM5ODMxMjEw","avatar_url":"https://avatars2.githubusercontent.com/u/39831210?v=4","gravatar_id":"","url":"https://api.github.com/users/paulmatchett","html_url":"https://github.com/paulmatchett","followers_url":"https://api.github.com/users/paulmatchett/followers","following_url":"https://api.github.com/users/paulmatchett/following{/other_user}","gists_url":"https://api.github.com/users/paulmatchett/gists{/gist_id}","starred_url":"https://api.github.com/users/paulmatchett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulmatchett/subscriptions","organizations_url":"https://api.github.com/users/paulmatchett/orgs","repos_url":"https://api.github.com/users/paulmatchett/repos","events_url":"https://api.github.com/users/paulmatchett/events{/privacy}","received_events_url":"https://api.github.com/users/paulmatchett/received_events","type":"User","site_admin":false},"body":"The two rejectHoliday methods (one class and the other for services) confused me. Maybe consider renaming the class method to onRejectHoliday?","created_at":"2018-07-31T13:55:56Z","updated_at":"2018-07-31T13:55:57Z","html_url":"https://github.com/UnosquareBelfast/AdminCore/pull/135#discussion_r206537319","pull_request_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/135","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/comments/206537319"},"html":{"href":"https://github.com/UnosquareBelfast/AdminCore/pull/135#discussion_r206537319"},"pull_request":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/135","id":205113731,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTEzNzMx","html_url":"https://github.com/UnosquareBelfast/AdminCore/pull/135","diff_url":"https://github.com/UnosquareBelfast/AdminCore/pull/135.diff","patch_url":"https://github.com/UnosquareBelfast/AdminCore/pull/135.patch","issue_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues/135","number":135,"state":"open","locked":false,"title":"Approve / Reject holidays","user":{"login":"William-Unosquare","id":39301552,"node_id":"MDQ6VXNlcjM5MzAxNTUy","avatar_url":"https://avatars0.githubusercontent.com/u/39301552?v=4","gravatar_id":"","url":"https://api.github.com/users/William-Unosquare","html_url":"https://github.com/William-Unosquare","followers_url":"https://api.github.com/users/William-Unosquare/followers","following_url":"https://api.github.com/users/William-Unosquare/following{/other_user}","gists_url":"https://api.github.com/users/William-Unosquare/gists{/gist_id}","starred_url":"https://api.github.com/users/William-Unosquare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/William-Unosquare/subscriptions","organizations_url":"https://api.github.com/users/William-Unosquare/orgs","repos_url":"https://api.github.com/users/William-Unosquare/repos","events_url":"https://api.github.com/users/William-Unosquare/events{/privacy}","received_events_url":"https://api.github.com/users/William-Unosquare/received_events","type":"User","site_admin":false},"body":"Adds ability to approve and reject holidays from the holiday modal. When the modals are closed the table that the modal was opened from will fetch its data again.","created_at":"2018-07-31T13:31:45Z","updated_at":"2018-07-31T13:55:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3409fd8014acefe37eb31c3154975f1661b04104","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BrownMark","id":26248685,"node_id":"MDQ6VXNlcjI2MjQ4Njg1","avatar_url":"https://avatars3.githubusercontent.com/u/26248685?v=4","gravatar_id":"","url":"https://api.github.com/users/BrownMark","html_url":"https://github.com/BrownMark","followers_url":"https://api.github.com/users/BrownMark/followers","following_url":"https://api.github.com/users/BrownMark/following{/other_user}","gists_url":"https://api.github.com/users/BrownMark/gists{/gist_id}","starred_url":"https://api.github.com/users/BrownMark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrownMark/subscriptions","organizations_url":"https://api.github.com/users/BrownMark/orgs","repos_url":"https://api.github.com/users/BrownMark/repos","events_url":"https://api.github.com/users/BrownMark/events{/privacy}","received_events_url":"https://api.github.com/users/BrownMark/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/135/commits","review_comments_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/135/comments","review_comment_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/comments{/number}","comments_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues/135/comments","statuses_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/statuses/6f0c89c6633bbde6f20317039d33756d167debb3","head":{"label":"UnosquareBelfast:Feature/holiday-modal-approval","ref":"Feature/holiday-modal-approval","sha":"6f0c89c6633bbde6f20317039d33756d167debb3","user":{"login":"UnosquareBelfast","id":37988067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTg4MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/37988067?v=4","gravatar_id":"","url":"https://api.github.com/users/UnosquareBelfast","html_url":"https://github.com/UnosquareBelfast","followers_url":"https://api.github.com/users/UnosquareBelfast/followers","following_url":"https://api.github.com/users/UnosquareBelfast/following{/other_user}","gists_url":"https://api.github.com/users/UnosquareBelfast/gists{/gist_id}","starred_url":"https://api.github.com/users/UnosquareBelfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnosquareBelfast/subscriptions","organizations_url":"https://api.github.com/users/UnosquareBelfast/orgs","repos_url":"https://api.github.com/users/UnosquareBelfast/repos","events_url":"https://api.github.com/users/UnosquareBelfast/events{/privacy}","received_events_url":"https://api.github.com/users/UnosquareBelfast/received_events","type":"Organization","site_admin":false},"repo":{"id":127679324,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc2NzkzMjQ=","name":"AdminCore","full_name":"UnosquareBelfast/AdminCore","owner":{"login":"UnosquareBelfast","id":37988067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTg4MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/37988067?v=4","gravatar_id":"","url":"https://api.github.com/users/UnosquareBelfast","html_url":"https://github.com/UnosquareBelfast","followers_url":"https://api.github.com/users/UnosquareBelfast/followers","following_url":"https://api.github.com/users/UnosquareBelfast/following{/other_user}","gists_url":"https://api.github.com/users/UnosquareBelfast/gists{/gist_id}","starred_url":"https://api.github.com/users/UnosquareBelfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnosquareBelfast/subscriptions","organizations_url":"https://api.github.com/users/UnosquareBelfast/orgs","repos_url":"https://api.github.com/users/UnosquareBelfast/repos","events_url":"https://api.github.com/users/UnosquareBelfast/events{/privacy}","received_events_url":"https://api.github.com/users/UnosquareBelfast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UnosquareBelfast/AdminCore","description":"Administrative tool","fork":false,"url":"https://api.github.com/repos/UnosquareBelfast/AdminCore","forks_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/forks","keys_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/teams","hooks_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/hooks","issue_events_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues/events{/number}","events_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/events","assignees_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/assignees{/user}","branches_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/branches{/branch}","tags_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/tags","blobs_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/statuses/{sha}","languages_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/languages","stargazers_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/stargazers","contributors_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/contributors","subscribers_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/subscribers","subscription_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/subscription","commits_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/contents/{+path}","compare_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/merges","archive_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/downloads","issues_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues{/number}","pulls_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls{/number}","milestones_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/milestones{/number}","notifications_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/labels{/name}","releases_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/releases{/id}","deployments_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/deployments","created_at":"2018-04-01T23:22:16Z","updated_at":"2018-07-31T13:53:18Z","pushed_at":"2018-07-31T13:53:19Z","git_url":"git://github.com/UnosquareBelfast/AdminCore.git","ssh_url":"[email protected]:UnosquareBelfast/AdminCore.git","clone_url":"https://github.com/UnosquareBelfast/AdminCore.git","svn_url":"https://github.com/UnosquareBelfast/AdminCore","homepage":null,"size":2792,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":4,"watchers":1,"default_branch":"develop"}},"base":{"label":"UnosquareBelfast:develop","ref":"develop","sha":"4e055200003f35dbe88fd3f4e73bd1f1e8b0a7cc","user":{"login":"UnosquareBelfast","id":37988067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTg4MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/37988067?v=4","gravatar_id":"","url":"https://api.github.com/users/UnosquareBelfast","html_url":"https://github.com/UnosquareBelfast","followers_url":"https://api.github.com/users/UnosquareBelfast/followers","following_url":"https://api.github.com/users/UnosquareBelfast/following{/other_user}","gists_url":"https://api.github.com/users/UnosquareBelfast/gists{/gist_id}","starred_url":"https://api.github.com/users/UnosquareBelfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnosquareBelfast/subscriptions","organizations_url":"https://api.github.com/users/UnosquareBelfast/orgs","repos_url":"https://api.github.com/users/UnosquareBelfast/repos","events_url":"https://api.github.com/users/UnosquareBelfast/events{/privacy}","received_events_url":"https://api.github.com/users/UnosquareBelfast/received_events","type":"Organization","site_admin":false},"repo":{"id":127679324,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc2NzkzMjQ=","name":"AdminCore","full_name":"UnosquareBelfast/AdminCore","owner":{"login":"UnosquareBelfast","id":37988067,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTg4MDY3","avatar_url":"https://avatars1.githubusercontent.com/u/37988067?v=4","gravatar_id":"","url":"https://api.github.com/users/UnosquareBelfast","html_url":"https://github.com/UnosquareBelfast","followers_url":"https://api.github.com/users/UnosquareBelfast/followers","following_url":"https://api.github.com/users/UnosquareBelfast/following{/other_user}","gists_url":"https://api.github.com/users/UnosquareBelfast/gists{/gist_id}","starred_url":"https://api.github.com/users/UnosquareBelfast/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnosquareBelfast/subscriptions","organizations_url":"https://api.github.com/users/UnosquareBelfast/orgs","repos_url":"https://api.github.com/users/UnosquareBelfast/repos","events_url":"https://api.github.com/users/UnosquareBelfast/events{/privacy}","received_events_url":"https://api.github.com/users/UnosquareBelfast/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/UnosquareBelfast/AdminCore","description":"Administrative tool","fork":false,"url":"https://api.github.com/repos/UnosquareBelfast/AdminCore","forks_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/forks","keys_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/keys{/key_id}","collaborators_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/teams","hooks_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/hooks","issue_events_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues/events{/number}","events_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/events","assignees_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/assignees{/user}","branches_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/branches{/branch}","tags_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/tags","blobs_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/refs{/sha}","trees_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/trees{/sha}","statuses_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/statuses/{sha}","languages_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/languages","stargazers_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/stargazers","contributors_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/contributors","subscribers_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/subscribers","subscription_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/subscription","commits_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/commits{/sha}","git_commits_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/git/commits{/sha}","comments_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/comments{/number}","issue_comment_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues/comments{/number}","contents_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/contents/{+path}","compare_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/compare/{base}...{head}","merges_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/merges","archive_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/downloads","issues_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues{/number}","pulls_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls{/number}","milestones_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/milestones{/number}","notifications_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/labels{/name}","releases_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/releases{/id}","deployments_url":"https://api.github.com/repos/UnosquareBelfast/AdminCore/deployments","created_at":"2018-04-01T23:22:16Z","updated_at":"2018-07-31T13:53:18Z","pushed_at":"2018-07-31T13:53:19Z","git_url":"git://github.com/UnosquareBelfast/AdminCore.git","ssh_url":"[email protected]:UnosquareBelfast/AdminCore.git","clone_url":"https://github.com/UnosquareBelfast/AdminCore.git","svn_url":"https://github.com/UnosquareBelfast/AdminCore","homepage":null,"size":2792,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":4,"watchers":1,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/135"},"html":{"href":"https://github.com/UnosquareBelfast/AdminCore/pull/135"},"issue":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues/135"},"comments":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/UnosquareBelfast/AdminCore/statuses/6f0c89c6633bbde6f20317039d33756d167debb3"}},"author_association":"COLLABORATOR"}}

8044247287

{"actor":{"display_login":"paulmatchett"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/comments/236771978","pull_request_review_id":178917570,"id":236771978,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjc3MTk3OA==","diff_hunk":"@@ -41,8 +41,8 @@ contract Advertisement is BaseAdvertisement {\n uint[] vercodes","path":"contracts/Advertisement.sol","position":1,"original_position":1,"commit_id":"c945ff2f38c6e9e1de63444c50468a87d551c2b2","original_commit_id":"353b6e9cb04a7cc9a52362f6b213cd0539ac56d0","user":{"login":"DioPires","id":6649682,"node_id":"MDQ6VXNlcjY2NDk2ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/6649682?v=4","gravatar_id":"","url":"https://api.github.com/users/DioPires","html_url":"https://github.com/DioPires","followers_url":"https://api.github.com/users/DioPires/followers","following_url":"https://api.github.com/users/DioPires/following{/other_user}","gists_url":"https://api.github.com/users/DioPires/gists{/gist_id}","starred_url":"https://api.github.com/users/DioPires/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DioPires/subscriptions","organizations_url":"https://api.github.com/users/DioPires/orgs","repos_url":"https://api.github.com/users/DioPires/repos","events_url":"https://api.github.com/users/DioPires/events{/privacy}","received_events_url":"https://api.github.com/users/DioPires/received_events","type":"User","site_admin":false},"body":"#### Tests:\n```diff \n+ 112 passing\n```\n#### Test coverage: \n82.97 %","created_at":"2018-11-27T17:37:49Z","updated_at":"2018-11-27T17:37:50Z","html_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/107#discussion_r236771978","pull_request_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/107","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/comments/236771978"},"html":{"href":"https://github.com/AppStoreFoundation/asf-contracts/pull/107#discussion_r236771978"},"pull_request":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/107"}}},"pull_request":{"url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/107","id":233046993,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMDQ2OTkz","html_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/107","diff_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/107.diff","patch_url":"https://github.com/AppStoreFoundation/asf-contracts/pull/107.patch","issue_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/107","number":107,"state":"open","locked":false,"title":"Feature/appc credits contract","user":{"login":"GustavoRSSilva","id":8384988,"node_id":"MDQ6VXNlcjgzODQ5ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/8384988?v=4","gravatar_id":"","url":"https://api.github.com/users/GustavoRSSilva","html_url":"https://github.com/GustavoRSSilva","followers_url":"https://api.github.com/users/GustavoRSSilva/followers","following_url":"https://api.github.com/users/GustavoRSSilva/following{/other_user}","gists_url":"https://api.github.com/users/GustavoRSSilva/gists{/gist_id}","starred_url":"https://api.github.com/users/GustavoRSSilva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GustavoRSSilva/subscriptions","organizations_url":"https://api.github.com/users/GustavoRSSilva/orgs","repos_url":"https://api.github.com/users/GustavoRSSilva/repos","events_url":"https://api.github.com/users/GustavoRSSilva/events{/privacy}","received_events_url":"https://api.github.com/users/GustavoRSSilva/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] You have followed our [**contributing guidelines**](https://github.com/AppStoreFoundation/asf-contracts/wiki/Contributing-to-AppCoins-Protocol-smart-contracts)\r\n- [x] double-check your branch is based on `dev` and targets `dev` \r\n- [x] Pull request has tests (at least 80% coverage)\r\n- [x] Code is well-commented, linted and follows project conventions\r\n- [x] Documentation is updated (if necessary)\r\n- [x] Description explains the issue/use-case resolved and auto-closes related issues\r\n","created_at":"2018-11-22T17:38:01Z","updated_at":"2018-11-27T17:37:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd4050486680ed490ef0d3bf391947d59619e19","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zepcp","id":8983591,"node_id":"MDQ6VXNlcjg5ODM1OTE=","avatar_url":"https://avatars0.githubusercontent.com/u/8983591?v=4","gravatar_id":"","url":"https://api.github.com/users/zepcp","html_url":"https://github.com/zepcp","followers_url":"https://api.github.com/users/zepcp/followers","following_url":"https://api.github.com/users/zepcp/following{/other_user}","gists_url":"https://api.github.com/users/zepcp/gists{/gist_id}","starred_url":"https://api.github.com/users/zepcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zepcp/subscriptions","organizations_url":"https://api.github.com/users/zepcp/orgs","repos_url":"https://api.github.com/users/zepcp/repos","events_url":"https://api.github.com/users/zepcp/events{/privacy}","received_events_url":"https://api.github.com/users/zepcp/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/107/commits","review_comments_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/107/comments","review_comment_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/107/comments","statuses_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/statuses/c945ff2f38c6e9e1de63444c50468a87d551c2b2","head":{"label":"AppStoreFoundation:feature/appc-credits-contract","ref":"feature/appc-credits-contract","sha":"c945ff2f38c6e9e1de63444c50468a87d551c2b2","user":{"login":"AppStoreFoundation","id":38036935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDM2OTM1","avatar_url":"https://avatars2.githubusercontent.com/u/38036935?v=4","gravatar_id":"","url":"https://api.github.com/users/AppStoreFoundation","html_url":"https://github.com/AppStoreFoundation","followers_url":"https://api.github.com/users/AppStoreFoundation/followers","following_url":"https://api.github.com/users/AppStoreFoundation/following{/other_user}","gists_url":"https://api.github.com/users/AppStoreFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/AppStoreFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppStoreFoundation/subscriptions","organizations_url":"https://api.github.com/users/AppStoreFoundation/orgs","repos_url":"https://api.github.com/users/AppStoreFoundation/repos","events_url":"https://api.github.com/users/AppStoreFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/AppStoreFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":124879368,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4NzkzNjg=","name":"asf-contracts","full_name":"AppStoreFoundation/asf-contracts","private":false,"owner":{"login":"AppStoreFoundation","id":38036935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDM2OTM1","avatar_url":"https://avatars2.githubusercontent.com/u/38036935?v=4","gravatar_id":"","url":"https://api.github.com/users/AppStoreFoundation","html_url":"https://github.com/AppStoreFoundation","followers_url":"https://api.github.com/users/AppStoreFoundation/followers","following_url":"https://api.github.com/users/AppStoreFoundation/following{/other_user}","gists_url":"https://api.github.com/users/AppStoreFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/AppStoreFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppStoreFoundation/subscriptions","organizations_url":"https://api.github.com/users/AppStoreFoundation/orgs","repos_url":"https://api.github.com/users/AppStoreFoundation/repos","events_url":"https://api.github.com/users/AppStoreFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/AppStoreFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AppStoreFoundation/asf-contracts","description":"Repo containing the smart contracts of the AppCoins protocol","fork":false,"url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts","forks_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/forks","keys_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/teams","hooks_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/hooks","issue_events_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/events","assignees_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/tags","blobs_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/languages","stargazers_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/stargazers","contributors_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/contributors","subscribers_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/subscribers","subscription_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/subscription","commits_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/merges","archive_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/downloads","issues_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/labels{/name}","releases_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/deployments","created_at":"2018-03-12T11:33:01Z","updated_at":"2018-10-25T10:43:53Z","pushed_at":"2018-11-27T17:18:33Z","git_url":"git://github.com/AppStoreFoundation/asf-contracts.git","ssh_url":"[email protected]:AppStoreFoundation/asf-contracts.git","clone_url":"https://github.com/AppStoreFoundation/asf-contracts.git","svn_url":"https://github.com/AppStoreFoundation/asf-contracts","homepage":null,"size":8609,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"base":{"label":"AppStoreFoundation:dev","ref":"dev","sha":"90f199365882b47f858b2b56b79518680ccf6bc7","user":{"login":"AppStoreFoundation","id":38036935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDM2OTM1","avatar_url":"https://avatars2.githubusercontent.com/u/38036935?v=4","gravatar_id":"","url":"https://api.github.com/users/AppStoreFoundation","html_url":"https://github.com/AppStoreFoundation","followers_url":"https://api.github.com/users/AppStoreFoundation/followers","following_url":"https://api.github.com/users/AppStoreFoundation/following{/other_user}","gists_url":"https://api.github.com/users/AppStoreFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/AppStoreFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppStoreFoundation/subscriptions","organizations_url":"https://api.github.com/users/AppStoreFoundation/orgs","repos_url":"https://api.github.com/users/AppStoreFoundation/repos","events_url":"https://api.github.com/users/AppStoreFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/AppStoreFoundation/received_events","type":"Organization","site_admin":false},"repo":{"id":124879368,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ4NzkzNjg=","name":"asf-contracts","full_name":"AppStoreFoundation/asf-contracts","private":false,"owner":{"login":"AppStoreFoundation","id":38036935,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MDM2OTM1","avatar_url":"https://avatars2.githubusercontent.com/u/38036935?v=4","gravatar_id":"","url":"https://api.github.com/users/AppStoreFoundation","html_url":"https://github.com/AppStoreFoundation","followers_url":"https://api.github.com/users/AppStoreFoundation/followers","following_url":"https://api.github.com/users/AppStoreFoundation/following{/other_user}","gists_url":"https://api.github.com/users/AppStoreFoundation/gists{/gist_id}","starred_url":"https://api.github.com/users/AppStoreFoundation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppStoreFoundation/subscriptions","organizations_url":"https://api.github.com/users/AppStoreFoundation/orgs","repos_url":"https://api.github.com/users/AppStoreFoundation/repos","events_url":"https://api.github.com/users/AppStoreFoundation/events{/privacy}","received_events_url":"https://api.github.com/users/AppStoreFoundation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AppStoreFoundation/asf-contracts","description":"Repo containing the smart contracts of the AppCoins protocol","fork":false,"url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts","forks_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/forks","keys_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/teams","hooks_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/hooks","issue_events_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/events","assignees_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/tags","blobs_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/languages","stargazers_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/stargazers","contributors_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/contributors","subscribers_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/subscribers","subscription_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/subscription","commits_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/merges","archive_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/downloads","issues_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/labels{/name}","releases_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/deployments","created_at":"2018-03-12T11:33:01Z","updated_at":"2018-10-25T10:43:53Z","pushed_at":"2018-11-27T17:18:33Z","git_url":"git://github.com/AppStoreFoundation/asf-contracts.git","ssh_url":"[email protected]:AppStoreFoundation/asf-contracts.git","clone_url":"https://github.com/AppStoreFoundation/asf-contracts.git","svn_url":"https://github.com/AppStoreFoundation/asf-contracts","homepage":null,"size":8609,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":2,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/107"},"html":{"href":"https://github.com/AppStoreFoundation/asf-contracts/pull/107"},"issue":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/107"},"comments":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/AppStoreFoundation/asf-contracts/statuses/c945ff2f38c6e9e1de63444c50468a87d551c2b2"}},"author_association":"CONTRIBUTOR"}}

8656147838

{"actor":{"display_login":"DioPires"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/tj-developers/jgrapht/pulls/comments/188920531","pull_request_review_id":120993186,"id":188920531,"diff_hunk":"@@ -241,29 +244,136 @@ public boolean isIntervalGraph()\n }\n \n /**\n- * Returns the list of all intervals sorted by starting point, or null, if the graph was not an interval graph.\n+ * Returns the list of all intervals sorted by starting point, or null, if the graph was not an\n+ * interval graph.\n *\n- * @return The list of all intervals sorted by starting point, or null, if the graph was not an interval graph.\n+ * @return The list of all intervals sorted by starting point, or null, if the graph was not an\n+ * interval graph.\n */\n public ArrayList<Interval<Integer>> getIntervalsSortedByStartingPoint()\n {\n return this.intervalsSortedByStartingPoint;\n }\n \n /**\n- * Returns a mapping of the constructed intervals to the vertices of the original graph, or null, if the graph was not an interval graph.\n+ * Implementation of radix Sort for integers on Intervals after the ending point\n+ * \n+ * @param list list of intervals to sort\n+ * @return a new sorted list of the intervals sorted after the ending point\n+ */\n+ private ArrayList<Interval<Integer>> radixSortInteger(List<Interval<Integer>> list)\n+ {\n+ if(list.size() == 0)\n+ return new ArrayList<Interval<Integer>>();\n+ \n+ ArrayList<Interval<Integer>> positiveList = new ArrayList<Interval<Integer>>(list.size());\n+ ArrayList<Interval<Integer>> negativeList = new ArrayList<Interval<Integer>>(list.size());\n+ for (Interval<Integer> interval : list) {\n+ if (interval.getEnd() < 0)\n+ negativeList.add(interval);\n+ else\n+ positiveList.add(interval);\n+ }\n+\n+ positiveList = radixSortNatural(positiveList);\n+ negativeList = radixSortNatural(negativeList);\n+ negativeList.addAll(positiveList);\n+ return negativeList;\n+ }\n+\n+ /**\n+ * Implementation of radix Sort for natural numbers on Intervals after the ending point\n+ * \n+ * @param list list of intervals to sort\n+ * @return a new sorted list of the intervals sorted after the ending point\n+ */\n+ private ArrayList<Interval<Integer>> radixSortNatural(List<Interval<Integer>> list)","path":"jgrapht-core/src/main/java/org/jgrapht/alg/intervalgraph/IntervalGraphRecognizer.java","position":181,"original_position":181,"commit_id":"7e538d77b73e04d473907971da3da40f5f029c30","original_commit_id":"7e538d77b73e04d473907971da3da40f5f029c30","user":{"login":"magnificent-tony","id":8175858,"avatar_url":"https://avatars0.githubusercontent.com/u/8175858?v=4","gravatar_id":"","url":"https://api.github.com/users/magnificent-tony","html_url":"https://github.com/magnificent-tony","followers_url":"https://api.github.com/users/magnificent-tony/followers","following_url":"https://api.github.com/users/magnificent-tony/following{/other_user}","gists_url":"https://api.github.com/users/magnificent-tony/gists{/gist_id}","starred_url":"https://api.github.com/users/magnificent-tony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magnificent-tony/subscriptions","organizations_url":"https://api.github.com/users/magnificent-tony/orgs","repos_url":"https://api.github.com/users/magnificent-tony/repos","events_url":"https://api.github.com/users/magnificent-tony/events{/privacy}","received_events_url":"https://api.github.com/users/magnificent-tony/received_events","type":"User","site_admin":false},"body":"see comment at line 264.","created_at":"2018-05-17T11:09:06Z","updated_at":"2018-05-17T11:51:13Z","html_url":"https://github.com/tj-developers/jgrapht/pull/31#discussion_r188920531","pull_request_url":"https://api.github.com/repos/tj-developers/jgrapht/pulls/31","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/tj-developers/jgrapht/pulls/comments/188920531"},"html":{"href":"https://github.com/tj-developers/jgrapht/pull/31#discussion_r188920531"},"pull_request":{"href":"https://api.github.com/repos/tj-developers/jgrapht/pulls/31"}}},"pull_request":{"url":"https://api.github.com/repos/tj-developers/jgrapht/pulls/31","id":187919689,"html_url":"https://github.com/tj-developers/jgrapht/pull/31","diff_url":"https://github.com/tj-developers/jgrapht/pull/31.diff","patch_url":"https://github.com/tj-developers/jgrapht/pull/31.patch","issue_url":"https://api.github.com/repos/tj-developers/jgrapht/issues/31","number":31,"state":"open","locked":false,"title":"Nice Decomposition for interval graph","user":{"login":"PhoenixIra","id":9974411,"avatar_url":"https://avatars1.githubusercontent.com/u/9974411?v=4","gravatar_id":"","url":"https://api.github.com/users/PhoenixIra","html_url":"https://github.com/PhoenixIra","followers_url":"https://api.github.com/users/PhoenixIra/followers","following_url":"https://api.github.com/users/PhoenixIra/following{/other_user}","gists_url":"https://api.github.com/users/PhoenixIra/gists{/gist_id}","starred_url":"https://api.github.com/users/PhoenixIra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhoenixIra/subscriptions","organizations_url":"https://api.github.com/users/PhoenixIra/orgs","repos_url":"https://api.github.com/users/PhoenixIra/repos","events_url":"https://api.github.com/users/PhoenixIra/events{/privacy}","received_events_url":"https://api.github.com/users/PhoenixIra/received_events","type":"User","site_admin":false},"body":"My progress on the nice decomposition for the interval graphs. Since I am now happy enough to show it to you, I created a PR. At least two tests are missing currently and should probably added in the near future. But they do not really tests critical methods.","created_at":"2018-05-14T18:58:00Z","updated_at":"2018-05-17T11:51:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5fe569d4d351cadc9df0c028abce53ce4a09e43e","assignee":{"login":"PhoenixIra","id":9974411,"avatar_url":"https://avatars1.githubusercontent.com/u/9974411?v=4","gravatar_id":"","url":"https://api.github.com/users/PhoenixIra","html_url":"https://github.com/PhoenixIra","followers_url":"https://api.github.com/users/PhoenixIra/followers","following_url":"https://api.github.com/users/PhoenixIra/following{/other_user}","gists_url":"https://api.github.com/users/PhoenixIra/gists{/gist_id}","starred_url":"https://api.github.com/users/PhoenixIra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhoenixIra/subscriptions","organizations_url":"https://api.github.com/users/PhoenixIra/orgs","repos_url":"https://api.github.com/users/PhoenixIra/repos","events_url":"https://api.github.com/users/PhoenixIra/events{/privacy}","received_events_url":"https://api.github.com/users/PhoenixIra/received_events","type":"User","site_admin":false},"assignees":[{"login":"PhoenixIra","id":9974411,"avatar_url":"https://avatars1.githubusercontent.com/u/9974411?v=4","gravatar_id":"","url":"https://api.github.com/users/PhoenixIra","html_url":"https://github.com/PhoenixIra","followers_url":"https://api.github.com/users/PhoenixIra/followers","following_url":"https://api.github.com/users/PhoenixIra/following{/other_user}","gists_url":"https://api.github.com/users/PhoenixIra/gists{/gist_id}","starred_url":"https://api.github.com/users/PhoenixIra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhoenixIra/subscriptions","organizations_url":"https://api.github.com/users/PhoenixIra/orgs","repos_url":"https://api.github.com/users/PhoenixIra/repos","events_url":"https://api.github.com/users/PhoenixIra/events{/privacy}","received_events_url":"https://api.github.com/users/PhoenixIra/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pdelvo","id":1710209,"avatar_url":"https://avatars1.githubusercontent.com/u/1710209?v=4","gravatar_id":"","url":"https://api.github.com/users/pdelvo","html_url":"https://github.com/pdelvo","followers_url":"https://api.github.com/users/pdelvo/followers","following_url":"https://api.github.com/users/pdelvo/following{/other_user}","gists_url":"https://api.github.com/users/pdelvo/gists{/gist_id}","starred_url":"https://api.github.com/users/pdelvo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pdelvo/subscriptions","organizations_url":"https://api.github.com/users/pdelvo/orgs","repos_url":"https://api.github.com/users/pdelvo/repos","events_url":"https://api.github.com/users/pdelvo/events{/privacy}","received_events_url":"https://api.github.com/users/pdelvo/received_events","type":"User","site_admin":false},{"login":"Watercrystal","id":3755557,"avatar_url":"https://avatars0.githubusercontent.com/u/3755557?v=4","gravatar_id":"","url":"https://api.github.com/users/Watercrystal","html_url":"https://github.com/Watercrystal","followers_url":"https://api.github.com/users/Watercrystal/followers","following_url":"https://api.github.com/users/Watercrystal/following{/other_user}","gists_url":"https://api.github.com/users/Watercrystal/gists{/gist_id}","starred_url":"https://api.github.com/users/Watercrystal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Watercrystal/subscriptions","organizations_url":"https://api.github.com/users/Watercrystal/orgs","repos_url":"https://api.github.com/users/Watercrystal/repos","events_url":"https://api.github.com/users/Watercrystal/events{/privacy}","received_events_url":"https://api.github.com/users/Watercrystal/received_events","type":"User","site_admin":false},{"login":"dia007","id":8613933,"avatar_url":"https://avatars0.githubusercontent.com/u/8613933?v=4","gravatar_id":"","url":"https://api.github.com/users/dia007","html_url":"https://github.com/dia007","followers_url":"https://api.github.com/users/dia007/followers","following_url":"https://api.github.com/users/dia007/following{/other_user}","gists_url":"https://api.github.com/users/dia007/gists{/gist_id}","starred_url":"https://api.github.com/users/dia007/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dia007/subscriptions","organizations_url":"https://api.github.com/users/dia007/orgs","repos_url":"https://api.github.com/users/dia007/repos","events_url":"https://api.github.com/users/dia007/events{/privacy}","received_events_url":"https://api.github.com/users/dia007/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":920249312,"url":"https://api.github.com/repos/tj-developers/jgrapht/labels/Tree%20Decomposition","name":"Tree Decomposition","color":"b60205","default":false},{"id":903870290,"url":"https://api.github.com/repos/tj-developers/jgrapht/labels/interval%20graphs","name":"interval graphs","color":"a088f7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tj-developers/jgrapht/pulls/31/commits","review_comments_url":"https://api.github.com/repos/tj-developers/jgrapht/pulls/31/comments","review_comment_url":"https://api.github.com/repos/tj-developers/jgrapht/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tj-developers/jgrapht/issues/31/comments","statuses_url":"https://api.github.com/repos/tj-developers/jgrapht/statuses/7e538d77b73e04d473907971da3da40f5f029c30","head":{"label":"PhoenixIra:treedecomposition","ref":"treedecomposition","sha":"7e538d77b73e04d473907971da3da40f5f029c30","user":{"login":"PhoenixIra","id":9974411,"avatar_url":"https://avatars1.githubusercontent.com/u/9974411?v=4","gravatar_id":"","url":"https://api.github.com/users/PhoenixIra","html_url":"https://github.com/PhoenixIra","followers_url":"https://api.github.com/users/PhoenixIra/followers","following_url":"https://api.github.com/users/PhoenixIra/following{/other_user}","gists_url":"https://api.github.com/users/PhoenixIra/gists{/gist_id}","starred_url":"https://api.github.com/users/PhoenixIra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhoenixIra/subscriptions","organizations_url":"https://api.github.com/users/PhoenixIra/orgs","repos_url":"https://api.github.com/users/PhoenixIra/repos","events_url":"https://api.github.com/users/PhoenixIra/events{/privacy}","received_events_url":"https://api.github.com/users/PhoenixIra/received_events","type":"User","site_admin":false},"repo":{"id":129881618,"name":"jgrapht","full_name":"PhoenixIra/jgrapht","owner":{"login":"PhoenixIra","id":9974411,"avatar_url":"https://avatars1.githubusercontent.com/u/9974411?v=4","gravatar_id":"","url":"https://api.github.com/users/PhoenixIra","html_url":"https://github.com/PhoenixIra","followers_url":"https://api.github.com/users/PhoenixIra/followers","following_url":"https://api.github.com/users/PhoenixIra/following{/other_user}","gists_url":"https://api.github.com/users/PhoenixIra/gists{/gist_id}","starred_url":"https://api.github.com/users/PhoenixIra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PhoenixIra/subscriptions","organizations_url":"https://api.github.com/users/PhoenixIra/orgs","repos_url":"https://api.github.com/users/PhoenixIra/repos","events_url":"https://api.github.com/users/PhoenixIra/events{/privacy}","received_events_url":"https://api.github.com/users/PhoenixIra/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PhoenixIra/jgrapht","description":"Master repository for the JGraphT project","fork":true,"url":"https://api.github.com/repos/PhoenixIra/jgrapht","forks_url":"https://api.github.com/repos/PhoenixIra/jgrapht/forks","keys_url":"https://api.github.com/repos/PhoenixIra/jgrapht/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PhoenixIra/jgrapht/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PhoenixIra/jgrapht/teams","hooks_url":"https://api.github.com/repos/PhoenixIra/jgrapht/hooks","issue_events_url":"https://api.github.com/repos/PhoenixIra/jgrapht/issues/events{/number}","events_url":"https://api.github.com/repos/PhoenixIra/jgrapht/events","assignees_url":"https://api.github.com/repos/PhoenixIra/jgrapht/assignees{/user}","branches_url":"https://api.github.com/repos/PhoenixIra/jgrapht/branches{/branch}","tags_url":"https://api.github.com/repos/PhoenixIra/jgrapht/tags","blobs_url":"https://api.github.com/repos/PhoenixIra/jgrapht/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PhoenixIra/jgrapht/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PhoenixIra/jgrapht/git/refs{/sha}","trees_url":"https://api.github.com/repos/PhoenixIra/jgrapht/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PhoenixIra/jgrapht/statuses/{sha}","languages_url":"https://api.github.com/repos/PhoenixIra/jgrapht/languages","stargazers_url":"https://api.github.com/repos/PhoenixIra/jgrapht/stargazers","contributors_url":"https://api.github.com/repos/PhoenixIra/jgrapht/contributors","subscribers_url":"https://api.github.com/repos/PhoenixIra/jgrapht/subscribers","subscription_url":"https://api.github.com/repos/PhoenixIra/jgrapht/subscription","commits_url":"https://api.github.com/repos/PhoenixIra/jgrapht/commits{/sha}","git_commits_url":"https://api.github.com/repos/PhoenixIra/jgrapht/git/commits{/sha}","comments_url":"https://api.github.com/repos/PhoenixIra/jgrapht/comments{/number}","issue_comment_url":"https://api.github.com/repos/PhoenixIra/jgrapht/issues/comments{/number}","contents_url":"https://api.github.com/repos/PhoenixIra/jgrapht/contents/{+path}","compare_url":"https://api.github.com/repos/PhoenixIra/jgrapht/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PhoenixIra/jgrapht/merges","archive_url":"https://api.github.com/repos/PhoenixIra/jgrapht/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PhoenixIra/jgrapht/downloads","issues_url":"https://api.github.com/repos/PhoenixIra/jgrapht/issues{/number}","pulls_url":"https://api.github.com/repos/PhoenixIra/jgrapht/pulls{/number}","milestones_url":"https://api.github.com/repos/PhoenixIra/jgrapht/milestones{/number}","notifications_url":"https://api.github.com/repos/PhoenixIra/jgrapht/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PhoenixIra/jgrapht/labels{/name}","releases_url":"https://api.github.com/repos/PhoenixIra/jgrapht/releases{/id}","deployments_url":"https://api.github.com/repos/PhoenixIra/jgrapht/deployments","created_at":"2018-04-17T09:40:22Z","updated_at":"2018-04-17T09:40:26Z","pushed_at":"2018-05-15T18:12:11Z","git_url":"git://github.com/PhoenixIra/jgrapht.git","ssh_url":"[email protected]:PhoenixIra/jgrapht.git","clone_url":"https://github.com/PhoenixIra/jgrapht.git","svn_url":"https://github.com/PhoenixIra/jgrapht","homepage":"http://www.jgrapht.org","size":9433,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tj-developers:intervalDecomposition","ref":"intervalDecomposition","sha":"2e57f7bb36a3b486b56c1dea42051da0be7ca82c","user":{"login":"tj-developers","id":38179805,"avatar_url":"https://avatars2.githubusercontent.com/u/38179805?v=4","gravatar_id":"","url":"https://api.github.com/users/tj-developers","html_url":"https://github.com/tj-developers","followers_url":"https://api.github.com/users/tj-developers/followers","following_url":"https://api.github.com/users/tj-developers/following{/other_user}","gists_url":"https://api.github.com/users/tj-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/tj-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tj-developers/subscriptions","organizations_url":"https://api.github.com/users/tj-developers/orgs","repos_url":"https://api.github.com/users/tj-developers/repos","events_url":"https://api.github.com/users/tj-developers/events{/privacy}","received_events_url":"https://api.github.com/users/tj-developers/received_events","type":"Organization","site_admin":false},"repo":{"id":128627460,"name":"jgrapht","full_name":"tj-developers/jgrapht","owner":{"login":"tj-developers","id":38179805,"avatar_url":"https://avatars2.githubusercontent.com/u/38179805?v=4","gravatar_id":"","url":"https://api.github.com/users/tj-developers","html_url":"https://github.com/tj-developers","followers_url":"https://api.github.com/users/tj-developers/followers","following_url":"https://api.github.com/users/tj-developers/following{/other_user}","gists_url":"https://api.github.com/users/tj-developers/gists{/gist_id}","starred_url":"https://api.github.com/users/tj-developers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tj-developers/subscriptions","organizations_url":"https://api.github.com/users/tj-developers/orgs","repos_url":"https://api.github.com/users/tj-developers/repos","events_url":"https://api.github.com/users/tj-developers/events{/privacy}","received_events_url":"https://api.github.com/users/tj-developers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tj-developers/jgrapht","description":"Master repository for the JGraphT project","fork":true,"url":"https://api.github.com/repos/tj-developers/jgrapht","forks_url":"https://api.github.com/repos/tj-developers/jgrapht/forks","keys_url":"https://api.github.com/repos/tj-developers/jgrapht/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tj-developers/jgrapht/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tj-developers/jgrapht/teams","hooks_url":"https://api.github.com/repos/tj-developers/jgrapht/hooks","issue_events_url":"https://api.github.com/repos/tj-developers/jgrapht/issues/events{/number}","events_url":"https://api.github.com/repos/tj-developers/jgrapht/events","assignees_url":"https://api.github.com/repos/tj-developers/jgrapht/assignees{/user}","branches_url":"https://api.github.com/repos/tj-developers/jgrapht/branches{/branch}","tags_url":"https://api.github.com/repos/tj-developers/jgrapht/tags","blobs_url":"https://api.github.com/repos/tj-developers/jgrapht/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tj-developers/jgrapht/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tj-developers/jgrapht/git/refs{/sha}","trees_url":"https://api.github.com/repos/tj-developers/jgrapht/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tj-developers/jgrapht/statuses/{sha}","languages_url":"https://api.github.com/repos/tj-developers/jgrapht/languages","stargazers_url":"https://api.github.com/repos/tj-developers/jgrapht/stargazers","contributors_url":"https://api.github.com/repos/tj-developers/jgrapht/contributors","subscribers_url":"https://api.github.com/repos/tj-developers/jgrapht/subscribers","subscription_url":"https://api.github.com/repos/tj-developers/jgrapht/subscription","commits_url":"https://api.github.com/repos/tj-developers/jgrapht/commits{/sha}","git_commits_url":"https://api.github.com/repos/tj-developers/jgrapht/git/commits{/sha}","comments_url":"https://api.github.com/repos/tj-developers/jgrapht/comments{/number}","issue_comment_url":"https://api.github.com/repos/tj-developers/jgrapht/issues/comments{/number}","contents_url":"https://api.github.com/repos/tj-developers/jgrapht/contents/{+path}","compare_url":"https://api.github.com/repos/tj-developers/jgrapht/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tj-developers/jgrapht/merges","archive_url":"https://api.github.com/repos/tj-developers/jgrapht/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tj-developers/jgrapht/downloads","issues_url":"https://api.github.com/repos/tj-developers/jgrapht/issues{/number}","pulls_url":"https://api.github.com/repos/tj-developers/jgrapht/pulls{/number}","milestones_url":"https://api.github.com/repos/tj-developers/jgrapht/milestones{/number}","notifications_url":"https://api.github.com/repos/tj-developers/jgrapht/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tj-developers/jgrapht/labels{/name}","releases_url":"https://api.github.com/repos/tj-developers/jgrapht/releases{/id}","deployments_url":"https://api.github.com/repos/tj-developers/jgrapht/deployments","created_at":"2018-04-08T10:04:42Z","updated_at":"2018-05-02T08:20:45Z","pushed_at":"2018-05-15T19:37:50Z","git_url":"git://github.com/tj-developers/jgrapht.git","ssh_url":"[email protected]:tj-developers/jgrapht.git","clone_url":"https://github.com/tj-developers/jgrapht.git","svn_url":"https://github.com/tj-developers/jgrapht","homepage":"http://www.jgrapht.org","size":9415,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":6,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tj-developers/jgrapht/pulls/31"},"html":{"href":"https://github.com/tj-developers/jgrapht/pull/31"},"issue":{"href":"https://api.github.com/repos/tj-developers/jgrapht/issues/31"},"comments":{"href":"https://api.github.com/repos/tj-developers/jgrapht/issues/31/comments"},"review_comments":{"href":"https://api.github.com/repos/tj-developers/jgrapht/pulls/31/comments"},"review_comment":{"href":"https://api.github.com/repos/tj-developers/jgrapht/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tj-developers/jgrapht/pulls/31/commits"},"statuses":{"href":"https://api.github.com/repos/tj-developers/jgrapht/statuses/7e538d77b73e04d473907971da3da40f5f029c30"}},"author_association":"NONE"}}

7689159720

{"actor":{"display_login":"magnificent-tony"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments/196852149","pull_request_review_id":130483420,"id":196852149,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Njg1MjE0OQ==","diff_hunk":"@@ -174,13 +171,22 @@ Property | Type\n `username` | `String`\n `password` | `String`\n \n+<a name=\"container-closure\"></a>`container` is a closure with the following properties:\n+\n+Property | Type | Default | Description\n+--- | --- | --- | ---\n+`jvmFlags` | `List<String>` | *None* | Additional flags to pass into the JVM when running your application.\n+`mainClass` | `String` | *Inferred\\** | The main class to launch your application from.\n+`args` | `List<String>` | *None* | Default main method arguments to run your application with.\n+`format` | `String` | `Docker` | Use `OCI` to build an [OCI container image](https://www.opencontainers.org/).\n+\n+\n ### Example\n \n In this configuration, the image is:\n * Built from a base of `openjdk:alpine` (pulled from Docker Hub)\n * Pushed to `localhost:5000/my-image:built-with-jib`\n-* Runs by calling `java -Xms512m -Xdebug -Xmy:flag=jib-rules -cp app/libs/*:app/resources:app/classes mypackage.MyApp some args`\n-* Reproducible","path":"jib-gradle-plugin/README.md","position":31,"original_position":32,"commit_id":"bca58c26e84133b8156042c1d0230149257053ea","original_commit_id":"76a8af51d670662c200d996a3921054238a3cafd","user":{"login":"coollog","id":4852522,"node_id":"MDQ6VXNlcjQ4NTI1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4852522?v=4","gravatar_id":"","url":"https://api.github.com/users/coollog","html_url":"https://github.com/coollog","followers_url":"https://api.github.com/users/coollog/followers","following_url":"https://api.github.com/users/coollog/following{/other_user}","gists_url":"https://api.github.com/users/coollog/gists{/gist_id}","starred_url":"https://api.github.com/users/coollog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coollog/subscriptions","organizations_url":"https://api.github.com/users/coollog/orgs","repos_url":"https://api.github.com/users/coollog/repos","events_url":"https://api.github.com/users/coollog/events{/privacy}","received_events_url":"https://api.github.com/users/coollog/received_events","type":"User","site_admin":false},"body":"Okay that makes sense.","created_at":"2018-06-20T16:35:15Z","updated_at":"2018-06-20T16:35:16Z","html_url":"https://github.com/GoogleContainerTools/jib/pull/427#discussion_r196852149","pull_request_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/427","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments/196852149"},"html":{"href":"https://github.com/GoogleContainerTools/jib/pull/427#discussion_r196852149"},"pull_request":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/427"}},"in_reply_to_id":196849088},"pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/427","id":196197369,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MTk3MzY5","html_url":"https://github.com/GoogleContainerTools/jib/pull/427","diff_url":"https://github.com/GoogleContainerTools/jib/pull/427.diff","patch_url":"https://github.com/GoogleContainerTools/jib/pull/427.patch","issue_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/427","number":427,"state":"open","locked":false,"title":"Add 'container' config to READMEs","user":{"login":"TadCordle","id":521881,"node_id":"MDQ6VXNlcjUyMTg4MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/521881?v=4","gravatar_id":"","url":"https://api.github.com/users/TadCordle","html_url":"https://github.com/TadCordle","followers_url":"https://api.github.com/users/TadCordle/followers","following_url":"https://api.github.com/users/TadCordle/following{/other_user}","gists_url":"https://api.github.com/users/TadCordle/gists{/gist_id}","starred_url":"https://api.github.com/users/TadCordle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TadCordle/subscriptions","organizations_url":"https://api.github.com/users/TadCordle/orgs","repos_url":"https://api.github.com/users/TadCordle/repos","events_url":"https://api.github.com/users/TadCordle/events{/privacy}","received_events_url":"https://api.github.com/users/TadCordle/received_events","type":"User","site_admin":false},"body":"Fixes #422. Merge after 0.9.1 release.","created_at":"2018-06-20T16:16:54Z","updated_at":"2018-06-20T16:35:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"df8713c6a5d77b87603de503e736abe166a00c5c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"loosebazooka","id":1304826,"node_id":"MDQ6VXNlcjEzMDQ4MjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1304826?v=4","gravatar_id":"","url":"https://api.github.com/users/loosebazooka","html_url":"https://github.com/loosebazooka","followers_url":"https://api.github.com/users/loosebazooka/followers","following_url":"https://api.github.com/users/loosebazooka/following{/other_user}","gists_url":"https://api.github.com/users/loosebazooka/gists{/gist_id}","starred_url":"https://api.github.com/users/loosebazooka/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loosebazooka/subscriptions","organizations_url":"https://api.github.com/users/loosebazooka/orgs","repos_url":"https://api.github.com/users/loosebazooka/repos","events_url":"https://api.github.com/users/loosebazooka/events{/privacy}","received_events_url":"https://api.github.com/users/loosebazooka/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":820236577,"node_id":"MDU6TGFiZWw4MjAyMzY1Nzc=","url":"https://api.github.com/repos/GoogleContainerTools/jib/labels/PR:%20Not%20Ready","name":"PR: Not Ready","color":"b60205","default":false},{"id":829319256,"node_id":"MDU6TGFiZWw4MjkzMTkyNTY=","url":"https://api.github.com/repos/GoogleContainerTools/jib/labels/documentation","name":"documentation","color":"db9f13","default":false}],"milestone":{"url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones/14","html_url":"https://github.com/GoogleContainerTools/jib/milestone/14","labels_url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones/14/labels","id":3438857,"node_id":"MDk6TWlsZXN0b25lMzQzODg1Nw==","number":14,"title":"0.10.0","description":"","creator":{"login":"coollog","id":4852522,"node_id":"MDQ6VXNlcjQ4NTI1MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4852522?v=4","gravatar_id":"","url":"https://api.github.com/users/coollog","html_url":"https://github.com/coollog","followers_url":"https://api.github.com/users/coollog/followers","following_url":"https://api.github.com/users/coollog/following{/other_user}","gists_url":"https://api.github.com/users/coollog/gists{/gist_id}","starred_url":"https://api.github.com/users/coollog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coollog/subscriptions","organizations_url":"https://api.github.com/users/coollog/orgs","repos_url":"https://api.github.com/users/coollog/repos","events_url":"https://api.github.com/users/coollog/events{/privacy}","received_events_url":"https://api.github.com/users/coollog/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-06-20T14:29:55Z","updated_at":"2018-06-20T16:19:39Z","due_on":"2018-06-29T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/427/commits","review_comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/427/comments","review_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/427/comments","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/bca58c26e84133b8156042c1d0230149257053ea","head":{"label":"GoogleContainerTools:readme_0.9.1","ref":"readme_0.9.1","sha":"bca58c26e84133b8156042c1d0230149257053ea","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":118497841,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTc4NDE=","name":"jib","full_name":"GoogleContainerTools/jib","owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleContainerTools/jib","description":":sailboat: Build container images for your Java applications.","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/jib","forks_url":"https://api.github.com/repos/GoogleContainerTools/jib/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/jib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/jib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/jib/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/jib/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/jib/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/jib/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/jib/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/jib/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/jib/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/jib/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/jib/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/jib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/jib/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/jib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/jib/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/jib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/jib/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/jib/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/jib/deployments","created_at":"2018-01-22T18:30:43Z","updated_at":"2018-06-20T16:32:20Z","pushed_at":"2018-06-20T16:34:04Z","git_url":"git://github.com/GoogleContainerTools/jib.git","ssh_url":"[email protected]:GoogleContainerTools/jib.git","clone_url":"https://github.com/GoogleContainerTools/jib.git","svn_url":"https://github.com/GoogleContainerTools/jib","homepage":"","size":2468,"stargazers_count":183,"watchers_count":183,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":50,"watchers":183,"default_branch":"master"}},"base":{"label":"GoogleContainerTools:master","ref":"master","sha":"c0103ba17d4003a55ea1fa5f232b1cb6b9a8b50e","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":118497841,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg0OTc4NDE=","name":"jib","full_name":"GoogleContainerTools/jib","owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleContainerTools/jib","description":":sailboat: Build container images for your Java applications.","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/jib","forks_url":"https://api.github.com/repos/GoogleContainerTools/jib/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/jib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/jib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/jib/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/jib/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/jib/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/jib/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/jib/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/jib/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/jib/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/jib/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/jib/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/jib/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/jib/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/jib/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/jib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/jib/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/jib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/jib/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/jib/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/jib/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/jib/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/jib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/jib/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/jib/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/jib/deployments","created_at":"2018-01-22T18:30:43Z","updated_at":"2018-06-20T16:32:20Z","pushed_at":"2018-06-20T16:34:04Z","git_url":"git://github.com/GoogleContainerTools/jib.git","ssh_url":"[email protected]:GoogleContainerTools/jib.git","clone_url":"https://github.com/GoogleContainerTools/jib.git","svn_url":"https://github.com/GoogleContainerTools/jib","homepage":"","size":2468,"stargazers_count":183,"watchers_count":183,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":true,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":17,"open_issues":50,"watchers":183,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/427"},"html":{"href":"https://github.com/GoogleContainerTools/jib/pull/427"},"issue":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/issues/427"},"comments":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/issues/427/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/427/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/pulls/427/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleContainerTools/jib/statuses/bca58c26e84133b8156042c1d0230149257053ea"}},"author_association":"COLLABORATOR"}}

7853180700

{"actor":{"display_login":"coollog"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/comments/217256989","pull_request_review_id":154923753,"id":217256989,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzI1Njk4OQ==","diff_hunk":"@@ -0,0 +1,76 @@\n+/*\n+Copyright 2018 Google LLC\n+\n+Licensed under the Apache License, Version 2.0 (the \"License\");\n+you may not use this file except in compliance with the License.\n+You may obtain a copy of the License at\n+\n+ http://www.apache.org/licenses/LICENSE-2.0\n+\n+Unless required by applicable law or agreed to in writing, software\n+distributed under the License is distributed on an \"AS IS\" BASIS,\n+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+See the License for the specific language governing permissions and\n+limitations under the License.\n+*/\n+\n+package executor\n+\n+import (\n+\t\"testing\"\n+\n+\t\"github.com/GoogleContainerTools/kaniko/pkg/config\"\n+\t\"github.com/GoogleContainerTools/kaniko/pkg/dockerfile\"\n+\t\"github.com/GoogleContainerTools/kaniko/testutil\"\n+\t\"github.com/google/go-containerregistry/pkg/v1\"\n+)\n+\n+func Test_reviewConfig(t *testing.T) {\n+\ttests := []struct {\n+\t\tname string\n+\t\tdockerfile string\n+\t\toriginalCmd []string\n+\t\toriginalEntrypoint []string\n+\t\texpectedCmd []string\n+\t}{\n+\t\t{\n+\t\t\tname: \"entrypoint and cmd declared\",\n+\t\t\tdockerfile: `\n+\t\t\tFROM scratch\n+\t\t\tCMD [\"mycmd\"]\n+\t\t\tENTRYPOINT [\"myentrypoint\"]`,\n+\t\t\toriginalEntrypoint: []string{\"myentrypoint\"},","path":"pkg/executor/build_test.go","position":42,"original_position":42,"commit_id":"da6f099820c8982391c0e79f3e90e7ae222d9bfe","original_commit_id":"da6f099820c8982391c0e79f3e90e7ae222d9bfe","user":{"login":"tejal29","id":1534539,"node_id":"MDQ6VXNlcjE1MzQ1Mzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1534539?v=4","gravatar_id":"","url":"https://api.github.com/users/tejal29","html_url":"https://github.com/tejal29","followers_url":"https://api.github.com/users/tejal29/followers","following_url":"https://api.github.com/users/tejal29/following{/other_user}","gists_url":"https://api.github.com/users/tejal29/gists{/gist_id}","starred_url":"https://api.github.com/users/tejal29/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tejal29/subscriptions","organizations_url":"https://api.github.com/users/tejal29/orgs","repos_url":"https://api.github.com/users/tejal29/repos","events_url":"https://api.github.com/users/tejal29/events{/privacy}","received_events_url":"https://api.github.com/users/tejal29/received_events","type":"User","site_admin":false},"body":"by originalCmd, do you mean command from previous stage?","created_at":"2018-09-13T04:27:33Z","updated_at":"2018-09-13T04:31:17Z","html_url":"https://github.com/GoogleContainerTools/kaniko/pull/348#discussion_r217256989","pull_request_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/348","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/comments/217256989"},"html":{"href":"https://github.com/GoogleContainerTools/kaniko/pull/348#discussion_r217256989"},"pull_request":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/348"}}},"pull_request":{"url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/348","id":214486486,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDg2NDg2","html_url":"https://github.com/GoogleContainerTools/kaniko/pull/348","diff_url":"https://github.com/GoogleContainerTools/kaniko/pull/348.diff","patch_url":"https://github.com/GoogleContainerTools/kaniko/pull/348.patch","issue_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/348","number":348,"state":"open","locked":false,"title":"Review config for cmd/entrypoint after building a stage","user":{"login":"priyawadhwa","id":10676490,"node_id":"MDQ6VXNlcjEwNjc2NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/10676490?v=4","gravatar_id":"","url":"https://api.github.com/users/priyawadhwa","html_url":"https://github.com/priyawadhwa","followers_url":"https://api.github.com/users/priyawadhwa/followers","following_url":"https://api.github.com/users/priyawadhwa/following{/other_user}","gists_url":"https://api.github.com/users/priyawadhwa/gists{/gist_id}","starred_url":"https://api.github.com/users/priyawadhwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyawadhwa/subscriptions","organizations_url":"https://api.github.com/users/priyawadhwa/orgs","repos_url":"https://api.github.com/users/priyawadhwa/repos","events_url":"https://api.github.com/users/priyawadhwa/events{/privacy}","received_events_url":"https://api.github.com/users/priyawadhwa/received_events","type":"User","site_admin":false},"body":"As mentioned in #346, if only ENTRYPOINT is set in a stage then any\r\nCMD inherited from a parent should be cleared.\r\n\r\nIf both entrypoint and cmd are set then nothing should change.\r\n\r\nI added a function and unit test to review the config file after building a stage\r\nwhich clears out config.Cmd if ENTRYPOINT was declared but CMD wasn't.\r\n\r\nI also added an integration test to make sure this works, which should\r\nbe tested by the preexisting container-diff --metadata test.","created_at":"2018-09-11T01:16:57Z","updated_at":"2018-09-13T04:31:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98241086d8b99e9ee9ce2f2fa78cfac6428b5283","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1033586080,"node_id":"MDU6TGFiZWwxMDMzNTg2MDgw","url":"https://api.github.com/repos/GoogleContainerTools/kaniko/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/348/commits","review_comments_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/348/comments","review_comment_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/348/comments","statuses_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/statuses/da6f099820c8982391c0e79f3e90e7ae222d9bfe","head":{"label":"priyawadhwa:entrypoint","ref":"entrypoint","sha":"da6f099820c8982391c0e79f3e90e7ae222d9bfe","user":{"login":"priyawadhwa","id":10676490,"node_id":"MDQ6VXNlcjEwNjc2NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/10676490?v=4","gravatar_id":"","url":"https://api.github.com/users/priyawadhwa","html_url":"https://github.com/priyawadhwa","followers_url":"https://api.github.com/users/priyawadhwa/followers","following_url":"https://api.github.com/users/priyawadhwa/following{/other_user}","gists_url":"https://api.github.com/users/priyawadhwa/gists{/gist_id}","starred_url":"https://api.github.com/users/priyawadhwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyawadhwa/subscriptions","organizations_url":"https://api.github.com/users/priyawadhwa/orgs","repos_url":"https://api.github.com/users/priyawadhwa/repos","events_url":"https://api.github.com/users/priyawadhwa/events{/privacy}","received_events_url":"https://api.github.com/users/priyawadhwa/received_events","type":"User","site_admin":false},"repo":{"id":129780332,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3ODAzMzI=","name":"kaniko","full_name":"priyawadhwa/kaniko","owner":{"login":"priyawadhwa","id":10676490,"node_id":"MDQ6VXNlcjEwNjc2NDkw","avatar_url":"https://avatars1.githubusercontent.com/u/10676490?v=4","gravatar_id":"","url":"https://api.github.com/users/priyawadhwa","html_url":"https://github.com/priyawadhwa","followers_url":"https://api.github.com/users/priyawadhwa/followers","following_url":"https://api.github.com/users/priyawadhwa/following{/other_user}","gists_url":"https://api.github.com/users/priyawadhwa/gists{/gist_id}","starred_url":"https://api.github.com/users/priyawadhwa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/priyawadhwa/subscriptions","organizations_url":"https://api.github.com/users/priyawadhwa/orgs","repos_url":"https://api.github.com/users/priyawadhwa/repos","events_url":"https://api.github.com/users/priyawadhwa/events{/privacy}","received_events_url":"https://api.github.com/users/priyawadhwa/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/priyawadhwa/kaniko","description":null,"fork":true,"url":"https://api.github.com/repos/priyawadhwa/kaniko","forks_url":"https://api.github.com/repos/priyawadhwa/kaniko/forks","keys_url":"https://api.github.com/repos/priyawadhwa/kaniko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/priyawadhwa/kaniko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/priyawadhwa/kaniko/teams","hooks_url":"https://api.github.com/repos/priyawadhwa/kaniko/hooks","issue_events_url":"https://api.github.com/repos/priyawadhwa/kaniko/issues/events{/number}","events_url":"https://api.github.com/repos/priyawadhwa/kaniko/events","assignees_url":"https://api.github.com/repos/priyawadhwa/kaniko/assignees{/user}","branches_url":"https://api.github.com/repos/priyawadhwa/kaniko/branches{/branch}","tags_url":"https://api.github.com/repos/priyawadhwa/kaniko/tags","blobs_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/refs{/sha}","trees_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/priyawadhwa/kaniko/statuses/{sha}","languages_url":"https://api.github.com/repos/priyawadhwa/kaniko/languages","stargazers_url":"https://api.github.com/repos/priyawadhwa/kaniko/stargazers","contributors_url":"https://api.github.com/repos/priyawadhwa/kaniko/contributors","subscribers_url":"https://api.github.com/repos/priyawadhwa/kaniko/subscribers","subscription_url":"https://api.github.com/repos/priyawadhwa/kaniko/subscription","commits_url":"https://api.github.com/repos/priyawadhwa/kaniko/commits{/sha}","git_commits_url":"https://api.github.com/repos/priyawadhwa/kaniko/git/commits{/sha}","comments_url":"https://api.github.com/repos/priyawadhwa/kaniko/comments{/number}","issue_comment_url":"https://api.github.com/repos/priyawadhwa/kaniko/issues/comments{/number}","contents_url":"https://api.github.com/repos/priyawadhwa/kaniko/contents/{+path}","compare_url":"https://api.github.com/repos/priyawadhwa/kaniko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/priyawadhwa/kaniko/merges","archive_url":"https://api.github.com/repos/priyawadhwa/kaniko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/priyawadhwa/kaniko/downloads","issues_url":"https://api.github.com/repos/priyawadhwa/kaniko/issues{/number}","pulls_url":"https://api.github.com/repos/priyawadhwa/kaniko/pulls{/number}","milestones_url":"https://api.github.com/repos/priyawadhwa/kaniko/milestones{/number}","notifications_url":"https://api.github.com/repos/priyawadhwa/kaniko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/priyawadhwa/kaniko/labels{/name}","releases_url":"https://api.github.com/repos/priyawadhwa/kaniko/releases{/id}","deployments_url":"https://api.github.com/repos/priyawadhwa/kaniko/deployments","created_at":"2018-04-16T17:23:28Z","updated_at":"2018-09-12T23:32:21Z","pushed_at":"2018-09-13T00:10:15Z","git_url":"git://github.com/priyawadhwa/kaniko.git","ssh_url":"[email protected]:priyawadhwa/kaniko.git","clone_url":"https://github.com/priyawadhwa/kaniko.git","svn_url":"https://github.com/priyawadhwa/kaniko","homepage":null,"size":18184,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"GoogleContainerTools:master","ref":"master","sha":"c814466e152d818e28aee406bb6f95a29fe627dc","user":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"repo":{"id":119419195,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk0MTkxOTU=","name":"kaniko","full_name":"GoogleContainerTools/kaniko","owner":{"login":"GoogleContainerTools","id":38444003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NDQ0MDAz","avatar_url":"https://avatars1.githubusercontent.com/u/38444003?v=4","gravatar_id":"","url":"https://api.github.com/users/GoogleContainerTools","html_url":"https://github.com/GoogleContainerTools","followers_url":"https://api.github.com/users/GoogleContainerTools/followers","following_url":"https://api.github.com/users/GoogleContainerTools/following{/other_user}","gists_url":"https://api.github.com/users/GoogleContainerTools/gists{/gist_id}","starred_url":"https://api.github.com/users/GoogleContainerTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GoogleContainerTools/subscriptions","organizations_url":"https://api.github.com/users/GoogleContainerTools/orgs","repos_url":"https://api.github.com/users/GoogleContainerTools/repos","events_url":"https://api.github.com/users/GoogleContainerTools/events{/privacy}","received_events_url":"https://api.github.com/users/GoogleContainerTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/GoogleContainerTools/kaniko","description":"Build Container Images In Kubernetes","fork":false,"url":"https://api.github.com/repos/GoogleContainerTools/kaniko","forks_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/forks","keys_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/teams","hooks_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/hooks","issue_events_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/events{/number}","events_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/events","assignees_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/assignees{/user}","branches_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/branches{/branch}","tags_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/tags","blobs_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/refs{/sha}","trees_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/statuses/{sha}","languages_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/languages","stargazers_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/stargazers","contributors_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/contributors","subscribers_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/subscribers","subscription_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/subscription","commits_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/commits{/sha}","git_commits_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/git/commits{/sha}","comments_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/comments{/number}","issue_comment_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/comments{/number}","contents_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/contents/{+path}","compare_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/merges","archive_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/downloads","issues_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues{/number}","pulls_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls{/number}","milestones_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/milestones{/number}","notifications_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/labels{/name}","releases_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/releases{/id}","deployments_url":"https://api.github.com/repos/GoogleContainerTools/kaniko/deployments","created_at":"2018-01-29T17:53:54Z","updated_at":"2018-09-13T03:53:00Z","pushed_at":"2018-09-13T00:10:16Z","git_url":"git://github.com/GoogleContainerTools/kaniko.git","ssh_url":"[email protected]:GoogleContainerTools/kaniko.git","clone_url":"https://github.com/GoogleContainerTools/kaniko.git","svn_url":"https://github.com/GoogleContainerTools/kaniko","homepage":"","size":15458,"stargazers_count":2138,"watchers_count":2138,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":115,"open_issues":51,"watchers":2138,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/348"},"html":{"href":"https://github.com/GoogleContainerTools/kaniko/pull/348"},"issue":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/348"},"comments":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/issues/348/comments"},"review_comments":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/348/comments"},"review_comment":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/pulls/348/commits"},"statuses":{"href":"https://api.github.com/repos/GoogleContainerTools/kaniko/statuses/da6f099820c8982391c0e79f3e90e7ae222d9bfe"}},"author_association":"MEMBER"}}

8257357685

{"actor":{"display_login":"tejal29"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/Plume-org/Plume/pulls/comments/244357694","pull_request_review_id":188318614,"id":244357694,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDM1NzY5NA==","diff_hunk":"@@ -96,139 +96,109 @@ impl User {\n find_by!(users, find_by_name, username as &str, instance_id as i32);\n find_by!(users, find_by_ap_url, ap_url as &str);\n \n- pub fn one_by_instance(conn: &Connection) -> Vec<User> {\n+ pub fn one_by_instance(conn: &Connection) -> Result<Vec<User>> {\n users::table\n .filter(users::instance_id.eq_any(users::table.select(users::instance_id).distinct()))\n .load::<User>(conn)\n- .expect(\"User::one_by_instance: loading error\")\n+ .map_err(Error::from)\n }\n \n- pub fn delete(&self, conn: &Connection, searcher: &Searcher) {\n+ pub fn delete(&self, conn: &Connection, searcher: &Searcher) -> Result<usize> {\n use schema::post_authors;\n \n- Blog::find_for_author(conn, self)\n+ for blog in Blog::find_for_author(conn, self)?\n .iter()\n- .filter(|b| b.count_authors(conn) <= 1)\n- .for_each(|b| b.delete(conn, searcher));\n+ .filter(|b| b.count_authors(conn).map(|c| c <= 1).unwrap_or(false)) {\n+ blog.delete(conn, searcher)?;\n+ }\n // delete the posts if they is the only author\n let all_their_posts_ids: Vec<i32> = post_authors::table\n .filter(post_authors::author_id.eq(self.id))\n .select(post_authors::post_id)\n- .load(conn)\n- .expect(\"User::delete: post loading error\");\n+ .load(conn)?;\n for post_id in all_their_posts_ids {\n let has_other_authors = post_authors::table\n .filter(post_authors::post_id.eq(post_id))\n .filter(post_authors::author_id.ne(self.id))\n .count()\n- .load(conn)\n- .expect(\"User::delete: count author error\")\n+ .load(conn)?\n .first()\n .unwrap_or(&0) > &0;\n if !has_other_authors {\n- Post::get(conn, post_id)\n- .expect(\"User::delete: post not found error\")\n- .delete(&(conn, searcher));\n+ Post::get(conn, post_id)?\n+ .delete(&(conn, searcher))?;\n }\n }\n \n diesel::delete(self)\n .execute(conn)\n- .expect(\"User::delete: user deletion error\");\n+ .map_err(Error::from)\n }\n \n- pub fn get_instance(&self, conn: &Connection) -> Instance {\n- Instance::get(conn, self.instance_id).expect(\"User::get_instance: instance not found error\")\n+ pub fn get_instance(&self, conn: &Connection) -> Result<Instance> {\n+ Instance::get(conn, self.instance_id)\n }\n \n- pub fn grant_admin_rights(&self, conn: &Connection) {\n+ pub fn grant_admin_rights(&self, conn: &Connection) -> Result<usize> {\n diesel::update(self)\n .set(users::is_admin.eq(true))\n .execute(conn)\n- .expect(\"User::grand_admin_rights: update error\");\n+ .map_err(Error::from)\n }\n \n- pub fn revoke_admin_rights(&self, conn: &Connection) {\n+ pub fn revoke_admin_rights(&self, conn: &Connection) -> Result<usize> {","path":"plume-models/src/users.rs","position":82,"original_position":82,"commit_id":"ca3f3a92e5693833aee3589190003fb37434e28b","original_commit_id":"ca3f3a92e5693833aee3589190003fb37434e28b","user":{"login":"fdb-hiroshima","id":35889323,"node_id":"MDQ6VXNlcjM1ODg5MzIz","avatar_url":"https://avatars3.githubusercontent.com/u/35889323?v=4","gravatar_id":"","url":"https://api.github.com/users/fdb-hiroshima","html_url":"https://github.com/fdb-hiroshima","followers_url":"https://api.github.com/users/fdb-hiroshima/followers","following_url":"https://api.github.com/users/fdb-hiroshima/following{/other_user}","gists_url":"https://api.github.com/users/fdb-hiroshima/gists{/gist_id}","starred_url":"https://api.github.com/users/fdb-hiroshima/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdb-hiroshima/subscriptions","organizations_url":"https://api.github.com/users/fdb-hiroshima/orgs","repos_url":"https://api.github.com/users/fdb-hiroshima/repos","events_url":"https://api.github.com/users/fdb-hiroshima/events{/privacy}","received_events_url":"https://api.github.com/users/fdb-hiroshima/received_events","type":"User","site_admin":false},"body":"Same about `Result<()>`Same about `Result<()>`","created_at":"2018-12-28T16:29:08Z","updated_at":"2018-12-28T16:42:39Z","html_url":"https://github.com/Plume-org/Plume/pull/392#discussion_r244357694","pull_request_url":"https://api.github.com/repos/Plume-org/Plume/pulls/392","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Plume-org/Plume/pulls/comments/244357694"},"html":{"href":"https://github.com/Plume-org/Plume/pull/392#discussion_r244357694"},"pull_request":{"href":"https://api.github.com/repos/Plume-org/Plume/pulls/392"}}},"pull_request":{"url":"https://api.github.com/repos/Plume-org/Plume/pulls/392","id":241024107,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDI0MTA3","html_url":"https://github.com/Plume-org/Plume/pull/392","diff_url":"https://github.com/Plume-org/Plume/pull/392.diff","patch_url":"https://github.com/Plume-org/Plume/pull/392.patch","issue_url":"https://api.github.com/repos/Plume-org/Plume/issues/392","number":392,"state":"open","locked":false,"title":"Avoid panics","user":{"login":"BaptisteGelez","id":16254623,"node_id":"MDQ6VXNlcjE2MjU0NjIz","avatar_url":"https://avatars1.githubusercontent.com/u/16254623?v=4","gravatar_id":"","url":"https://api.github.com/users/BaptisteGelez","html_url":"https://github.com/BaptisteGelez","followers_url":"https://api.github.com/users/BaptisteGelez/followers","following_url":"https://api.github.com/users/BaptisteGelez/following{/other_user}","gists_url":"https://api.github.com/users/BaptisteGelez/gists{/gist_id}","starred_url":"https://api.github.com/users/BaptisteGelez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BaptisteGelez/subscriptions","organizations_url":"https://api.github.com/users/BaptisteGelez/orgs","repos_url":"https://api.github.com/users/BaptisteGelez/repos","events_url":"https://api.github.com/users/BaptisteGelez/events{/privacy}","received_events_url":"https://api.github.com/users/BaptisteGelez/received_events","type":"User","site_admin":false},"body":"- Use `Result` as much as possible\r\n- Display errors instead of panicking\r\n\r\nTODO (maybe in another PR? this one is already quite big):\r\n- Find a way to merge Ructe/ErrorPage types, so that we can have routes returning `Result<X, ErrorPage>` instead of panicking when we have an `Error`\r\n- Display more details about the error, to make it easier to debug\r\n\r\n(sorry, this isn't going to be fun to review, the diff is huge, but it is always the same changes)","created_at":"2018-12-26T19:11:52Z","updated_at":"2018-12-28T16:42:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1b964b4152e882f1a5bfbd51a6b24be65f52ffdb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":996694866,"node_id":"MDU6TGFiZWw5OTY2OTQ4NjY=","url":"https://api.github.com/repos/Plume-org/Plume/labels/A:%20Backend","name":"A: Backend","color":"1d76db","default":false},{"id":909397038,"node_id":"MDU6TGFiZWw5MDkzOTcwMzg=","url":"https://api.github.com/repos/Plume-org/Plume/labels/C:%20Enhancement","name":"C: Enhancement","color":"a2eeef","default":false},{"id":919675490,"node_id":"MDU6TGFiZWw5MTk2NzU0OTA=","url":"https://api.github.com/repos/Plume-org/Plume/labels/S:%20Ready%20for%20review","name":"S: Ready for review","color":"f9b8ef","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Plume-org/Plume/pulls/392/commits","review_comments_url":"https://api.github.com/repos/Plume-org/Plume/pulls/392/comments","review_comment_url":"https://api.github.com/repos/Plume-org/Plume/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Plume-org/Plume/issues/392/comments","statuses_url":"https://api.github.com/repos/Plume-org/Plume/statuses/ca3f3a92e5693833aee3589190003fb37434e28b","head":{"label":"Plume-org:result","ref":"result","sha":"ca3f3a92e5693833aee3589190003fb37434e28b","user":{"login":"Plume-org","id":38588078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTg4MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/38588078?v=4","gravatar_id":"","url":"https://api.github.com/users/Plume-org","html_url":"https://github.com/Plume-org","followers_url":"https://api.github.com/users/Plume-org/followers","following_url":"https://api.github.com/users/Plume-org/following{/other_user}","gists_url":"https://api.github.com/users/Plume-org/gists{/gist_id}","starred_url":"https://api.github.com/users/Plume-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Plume-org/subscriptions","organizations_url":"https://api.github.com/users/Plume-org/orgs","repos_url":"https://api.github.com/users/Plume-org/repos","events_url":"https://api.github.com/users/Plume-org/events{/privacy}","received_events_url":"https://api.github.com/users/Plume-org/received_events","type":"Organization","site_admin":false},"repo":{"id":130482471,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0ODI0NzE=","name":"Plume","full_name":"Plume-org/Plume","private":false,"owner":{"login":"Plume-org","id":38588078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTg4MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/38588078?v=4","gravatar_id":"","url":"https://api.github.com/users/Plume-org","html_url":"https://github.com/Plume-org","followers_url":"https://api.github.com/users/Plume-org/followers","following_url":"https://api.github.com/users/Plume-org/following{/other_user}","gists_url":"https://api.github.com/users/Plume-org/gists{/gist_id}","starred_url":"https://api.github.com/users/Plume-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Plume-org/subscriptions","organizations_url":"https://api.github.com/users/Plume-org/orgs","repos_url":"https://api.github.com/users/Plume-org/repos","events_url":"https://api.github.com/users/Plume-org/events{/privacy}","received_events_url":"https://api.github.com/users/Plume-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Plume-org/Plume","description":"Federated blogging application, thanks to ActivityPub","fork":false,"url":"https://api.github.com/repos/Plume-org/Plume","forks_url":"https://api.github.com/repos/Plume-org/Plume/forks","keys_url":"https://api.github.com/repos/Plume-org/Plume/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Plume-org/Plume/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Plume-org/Plume/teams","hooks_url":"https://api.github.com/repos/Plume-org/Plume/hooks","issue_events_url":"https://api.github.com/repos/Plume-org/Plume/issues/events{/number}","events_url":"https://api.github.com/repos/Plume-org/Plume/events","assignees_url":"https://api.github.com/repos/Plume-org/Plume/assignees{/user}","branches_url":"https://api.github.com/repos/Plume-org/Plume/branches{/branch}","tags_url":"https://api.github.com/repos/Plume-org/Plume/tags","blobs_url":"https://api.github.com/repos/Plume-org/Plume/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Plume-org/Plume/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Plume-org/Plume/git/refs{/sha}","trees_url":"https://api.github.com/repos/Plume-org/Plume/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Plume-org/Plume/statuses/{sha}","languages_url":"https://api.github.com/repos/Plume-org/Plume/languages","stargazers_url":"https://api.github.com/repos/Plume-org/Plume/stargazers","contributors_url":"https://api.github.com/repos/Plume-org/Plume/contributors","subscribers_url":"https://api.github.com/repos/Plume-org/Plume/subscribers","subscription_url":"https://api.github.com/repos/Plume-org/Plume/subscription","commits_url":"https://api.github.com/repos/Plume-org/Plume/commits{/sha}","git_commits_url":"https://api.github.com/repos/Plume-org/Plume/git/commits{/sha}","comments_url":"https://api.github.com/repos/Plume-org/Plume/comments{/number}","issue_comment_url":"https://api.github.com/repos/Plume-org/Plume/issues/comments{/number}","contents_url":"https://api.github.com/repos/Plume-org/Plume/contents/{+path}","compare_url":"https://api.github.com/repos/Plume-org/Plume/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Plume-org/Plume/merges","archive_url":"https://api.github.com/repos/Plume-org/Plume/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Plume-org/Plume/downloads","issues_url":"https://api.github.com/repos/Plume-org/Plume/issues{/number}","pulls_url":"https://api.github.com/repos/Plume-org/Plume/pulls{/number}","milestones_url":"https://api.github.com/repos/Plume-org/Plume/milestones{/number}","notifications_url":"https://api.github.com/repos/Plume-org/Plume/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Plume-org/Plume/labels{/name}","releases_url":"https://api.github.com/repos/Plume-org/Plume/releases{/id}","deployments_url":"https://api.github.com/repos/Plume-org/Plume/deployments","created_at":"2018-04-21T14:42:16Z","updated_at":"2018-12-27T13:13:03Z","pushed_at":"2018-12-27T21:51:40Z","git_url":"git://github.com/Plume-org/Plume.git","ssh_url":"[email protected]:Plume-org/Plume.git","clone_url":"https://github.com/Plume-org/Plume.git","svn_url":"https://github.com/Plume-org/Plume","homepage":"https://joinplu.me","size":7288,"stargazers_count":802,"watchers_count":802,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":55,"open_issues":46,"watchers":802,"default_branch":"master"}},"base":{"label":"Plume-org:master","ref":"master","sha":"e2d5a5057c2009e25cbb0f5625de0d0ebe7875ca","user":{"login":"Plume-org","id":38588078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTg4MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/38588078?v=4","gravatar_id":"","url":"https://api.github.com/users/Plume-org","html_url":"https://github.com/Plume-org","followers_url":"https://api.github.com/users/Plume-org/followers","following_url":"https://api.github.com/users/Plume-org/following{/other_user}","gists_url":"https://api.github.com/users/Plume-org/gists{/gist_id}","starred_url":"https://api.github.com/users/Plume-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Plume-org/subscriptions","organizations_url":"https://api.github.com/users/Plume-org/orgs","repos_url":"https://api.github.com/users/Plume-org/repos","events_url":"https://api.github.com/users/Plume-org/events{/privacy}","received_events_url":"https://api.github.com/users/Plume-org/received_events","type":"Organization","site_admin":false},"repo":{"id":130482471,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0ODI0NzE=","name":"Plume","full_name":"Plume-org/Plume","private":false,"owner":{"login":"Plume-org","id":38588078,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NTg4MDc4","avatar_url":"https://avatars1.githubusercontent.com/u/38588078?v=4","gravatar_id":"","url":"https://api.github.com/users/Plume-org","html_url":"https://github.com/Plume-org","followers_url":"https://api.github.com/users/Plume-org/followers","following_url":"https://api.github.com/users/Plume-org/following{/other_user}","gists_url":"https://api.github.com/users/Plume-org/gists{/gist_id}","starred_url":"https://api.github.com/users/Plume-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Plume-org/subscriptions","organizations_url":"https://api.github.com/users/Plume-org/orgs","repos_url":"https://api.github.com/users/Plume-org/repos","events_url":"https://api.github.com/users/Plume-org/events{/privacy}","received_events_url":"https://api.github.com/users/Plume-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Plume-org/Plume","description":"Federated blogging application, thanks to ActivityPub","fork":false,"url":"https://api.github.com/repos/Plume-org/Plume","forks_url":"https://api.github.com/repos/Plume-org/Plume/forks","keys_url":"https://api.github.com/repos/Plume-org/Plume/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Plume-org/Plume/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Plume-org/Plume/teams","hooks_url":"https://api.github.com/repos/Plume-org/Plume/hooks","issue_events_url":"https://api.github.com/repos/Plume-org/Plume/issues/events{/number}","events_url":"https://api.github.com/repos/Plume-org/Plume/events","assignees_url":"https://api.github.com/repos/Plume-org/Plume/assignees{/user}","branches_url":"https://api.github.com/repos/Plume-org/Plume/branches{/branch}","tags_url":"https://api.github.com/repos/Plume-org/Plume/tags","blobs_url":"https://api.github.com/repos/Plume-org/Plume/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Plume-org/Plume/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Plume-org/Plume/git/refs{/sha}","trees_url":"https://api.github.com/repos/Plume-org/Plume/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Plume-org/Plume/statuses/{sha}","languages_url":"https://api.github.com/repos/Plume-org/Plume/languages","stargazers_url":"https://api.github.com/repos/Plume-org/Plume/stargazers","contributors_url":"https://api.github.com/repos/Plume-org/Plume/contributors","subscribers_url":"https://api.github.com/repos/Plume-org/Plume/subscribers","subscription_url":"https://api.github.com/repos/Plume-org/Plume/subscription","commits_url":"https://api.github.com/repos/Plume-org/Plume/commits{/sha}","git_commits_url":"https://api.github.com/repos/Plume-org/Plume/git/commits{/sha}","comments_url":"https://api.github.com/repos/Plume-org/Plume/comments{/number}","issue_comment_url":"https://api.github.com/repos/Plume-org/Plume/issues/comments{/number}","contents_url":"https://api.github.com/repos/Plume-org/Plume/contents/{+path}","compare_url":"https://api.github.com/repos/Plume-org/Plume/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Plume-org/Plume/merges","archive_url":"https://api.github.com/repos/Plume-org/Plume/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Plume-org/Plume/downloads","issues_url":"https://api.github.com/repos/Plume-org/Plume/issues{/number}","pulls_url":"https://api.github.com/repos/Plume-org/Plume/pulls{/number}","milestones_url":"https://api.github.com/repos/Plume-org/Plume/milestones{/number}","notifications_url":"https://api.github.com/repos/Plume-org/Plume/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Plume-org/Plume/labels{/name}","releases_url":"https://api.github.com/repos/Plume-org/Plume/releases{/id}","deployments_url":"https://api.github.com/repos/Plume-org/Plume/deployments","created_at":"2018-04-21T14:42:16Z","updated_at":"2018-12-27T13:13:03Z","pushed_at":"2018-12-27T21:51:40Z","git_url":"git://github.com/Plume-org/Plume.git","ssh_url":"[email protected]:Plume-org/Plume.git","clone_url":"https://github.com/Plume-org/Plume.git","svn_url":"https://github.com/Plume-org/Plume","homepage":"https://joinplu.me","size":7288,"stargazers_count":802,"watchers_count":802,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":46,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":55,"open_issues":46,"watchers":802,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Plume-org/Plume/pulls/392"},"html":{"href":"https://github.com/Plume-org/Plume/pull/392"},"issue":{"href":"https://api.github.com/repos/Plume-org/Plume/issues/392"},"comments":{"href":"https://api.github.com/repos/Plume-org/Plume/issues/392/comments"},"review_comments":{"href":"https://api.github.com/repos/Plume-org/Plume/pulls/392/comments"},"review_comment":{"href":"https://api.github.com/repos/Plume-org/Plume/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Plume-org/Plume/pulls/392/commits"},"statuses":{"href":"https://api.github.com/repos/Plume-org/Plume/statuses/ca3f3a92e5693833aee3589190003fb37434e28b"}},"author_association":"MEMBER"}}

8812825865

{"actor":{"display_login":"fdb-hiroshima"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/netket/netket/pulls/comments/217143563","pull_request_review_id":154787473,"id":217143563,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzE0MzU2Mw==","diff_hunk":"@@ -0,0 +1,74 @@\n+// Copyright 2018 Alexander Wietek - All Rights Reserved.\n+//\n+// Licensed under the Apache License, Version 2.0 (the \"License\");\n+// you may not use this file except in compliance with the License.\n+// You may obtain a copy of the License at\n+//\n+// http://www.apache.org/licenses/LICENSE-2.0\n+//\n+// Unless required by applicable law or agreed to in writing, software\n+// distributed under the License is distributed on an \"AS IS\" BASIS,\n+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+// See the License for the specific language governing permissions and\n+// limitations under the License.\n+\n+#ifndef NETKET_EXACT_DIAGONALIZATION_HPP\n+#define NETKET_EXACT_DIAGONALIZATION_HPP\n+\n+#include <vector>\n+\n+#include <ietl/lanczos.h>\n+#include <ietl/randomgenerator.h>\n+\n+#include \"Hamiltonian/MatrixWrapper/matrix_wrapper.hpp\"\n+\n+namespace netket {\n+\n+std::vector<double> eigenvalues_lanczos(const Hamiltonian &hamiltonian,\n+ int first_n = 1) {\n+ using complex = std::complex<double>;\n+ using normal_dist_t = std::uniform_real_distribution<double>;\n+ using matrix_t = Eigen::SparseMatrix<complex>;\n+ using vectorspace_t = ietl::vectorspace<complex>;\n+ using iter_t = ietl::lanczos_iteration_nlowest<double>;\n+ using lanczos_t = ietl::lanczos<matrix_t, vectorspace_t>;\n+\n+ // TODO: make these parameters accessible to user\n+ int max_iter = 1000;\n+ int seed = 42;\n+ double precision = 1e-8;\n+\n+ SparseMatrixWrapper<Hamiltonian> matrix(hamiltonian);\n+ const matrix_t &numerical_matrix = matrix.GetMatrix();\n+\n+ size_t dimension = numerical_matrix.rows();\n+ vectorspace_t ietl_vecspace(dimension);\n+\n+ int num_eigenvalue_to_converge = first_n;\n+\n+ normal_dist_t dist(-1., 1.);\n+ ietl::random_generator<std::mt19937, normal_dist_t> random_gen(dist, seed);\n+ iter_t iter(max_iter, num_eigenvalue_to_converge, precision, precision);\n+ lanczos_t lanczos(numerical_matrix, ietl_vecspace);\n+\n+ lanczos.calculate_eigenvalues(iter, random_gen);\n+\n+ std::vector<double> eigs_lanczos = lanczos.eigenvalues();\n+ eigs_lanczos.resize(first_n);","path":"NetKet/GroundState/exact_diagonalization.hpp","position":57,"original_position":57,"commit_id":"117796cd3bf9b4d950ef4adc3cf13b072d77ba55","original_commit_id":"117796cd3bf9b4d950ef4adc3cf13b072d77ba55","user":{"login":"twesterhout","id":14264576,"node_id":"MDQ6VXNlcjE0MjY0NTc2","avatar_url":"https://avatars3.githubusercontent.com/u/14264576?v=4","gravatar_id":"","url":"https://api.github.com/users/twesterhout","html_url":"https://github.com/twesterhout","followers_url":"https://api.github.com/users/twesterhout/followers","following_url":"https://api.github.com/users/twesterhout/following{/other_user}","gists_url":"https://api.github.com/users/twesterhout/gists{/gist_id}","starred_url":"https://api.github.com/users/twesterhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/twesterhout/subscriptions","organizations_url":"https://api.github.com/users/twesterhout/orgs","repos_url":"https://api.github.com/users/twesterhout/repos","events_url":"https://api.github.com/users/twesterhout/events{/privacy}","received_events_url":"https://api.github.com/users/twesterhout/received_events","type":"User","site_admin":false},"body":"Oh, you're absolutely right @alexwie! I missed a few lines in your implementation. All makes sense now (except for the copying, but ALPS is way too old for move semantics :grinning:).","created_at":"2018-09-12T18:35:39Z","updated_at":"2018-09-12T18:35:39Z","html_url":"https://github.com/netket/netket/pull/67#discussion_r217143563","pull_request_url":"https://api.github.com/repos/netket/netket/pulls/67","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/netket/netket/pulls/comments/217143563"},"html":{"href":"https://github.com/netket/netket/pull/67#discussion_r217143563"},"pull_request":{"href":"https://api.github.com/repos/netket/netket/pulls/67"}},"in_reply_to_id":217116033},"pull_request":{"url":"https://api.github.com/repos/netket/netket/pulls/67","id":213922416,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzOTIyNDE2","html_url":"https://github.com/netket/netket/pull/67","diff_url":"https://github.com/netket/netket/pull/67.diff","patch_url":"https://github.com/netket/netket/pull/67.patch","issue_url":"https://api.github.com/repos/netket/netket/issues/67","number":67,"state":"open","locked":false,"title":"Introduced Lanczos ED from IETL library","user":{"login":"alexwie","id":5948847,"node_id":"MDQ6VXNlcjU5NDg4NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/5948847?v=4","gravatar_id":"","url":"https://api.github.com/users/alexwie","html_url":"https://github.com/alexwie","followers_url":"https://api.github.com/users/alexwie/followers","following_url":"https://api.github.com/users/alexwie/following{/other_user}","gists_url":"https://api.github.com/users/alexwie/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwie/subscriptions","organizations_url":"https://api.github.com/users/alexwie/orgs","repos_url":"https://api.github.com/users/alexwie/repos","events_url":"https://api.github.com/users/alexwie/events{/privacy}","received_events_url":"https://api.github.com/users/alexwie/received_events","type":"User","site_admin":false},"body":"Dear all, \r\n\r\nI wrote a wrapper for using the IETL Lanczos code (http://alps.comp-phys.org/static/doc2.1.0/ietl.html). The ground state energy computation in NetKet would now be done with this library. Probably we should discuss some more detailed user interface for the algorithm (how to set parameters, like precision for the Lanczos iteration. There are also some test, which could be extended. \r\n\r\nBest,\r\nAlex","created_at":"2018-09-07T13:06:53Z","updated_at":"2018-09-12T18:35:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"938db289cbc508d955d07d698697e263fd693ac3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gcarleo","id":28149892,"node_id":"MDQ6VXNlcjI4MTQ5ODky","avatar_url":"https://avatars0.githubusercontent.com/u/28149892?v=4","gravatar_id":"","url":"https://api.github.com/users/gcarleo","html_url":"https://github.com/gcarleo","followers_url":"https://api.github.com/users/gcarleo/followers","following_url":"https://api.github.com/users/gcarleo/following{/other_user}","gists_url":"https://api.github.com/users/gcarleo/gists{/gist_id}","starred_url":"https://api.github.com/users/gcarleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcarleo/subscriptions","organizations_url":"https://api.github.com/users/gcarleo/orgs","repos_url":"https://api.github.com/users/gcarleo/repos","events_url":"https://api.github.com/users/gcarleo/events{/privacy}","received_events_url":"https://api.github.com/users/gcarleo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/netket/netket/pulls/67/commits","review_comments_url":"https://api.github.com/repos/netket/netket/pulls/67/comments","review_comment_url":"https://api.github.com/repos/netket/netket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/netket/netket/issues/67/comments","statuses_url":"https://api.github.com/repos/netket/netket/statuses/117796cd3bf9b4d950ef4adc3cf13b072d77ba55","head":{"label":"netket:lanczos","ref":"lanczos","sha":"117796cd3bf9b4d950ef4adc3cf13b072d77ba55","user":{"login":"netket","id":38641916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjQxOTE2","avatar_url":"https://avatars2.githubusercontent.com/u/38641916?v=4","gravatar_id":"","url":"https://api.github.com/users/netket","html_url":"https://github.com/netket","followers_url":"https://api.github.com/users/netket/followers","following_url":"https://api.github.com/users/netket/following{/other_user}","gists_url":"https://api.github.com/users/netket/gists{/gist_id}","starred_url":"https://api.github.com/users/netket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netket/subscriptions","organizations_url":"https://api.github.com/users/netket/orgs","repos_url":"https://api.github.com/users/netket/repos","events_url":"https://api.github.com/users/netket/events{/privacy}","received_events_url":"https://api.github.com/users/netket/received_events","type":"Organization","site_admin":false},"repo":{"id":130741783,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3NDE3ODM=","name":"netket","full_name":"netket/netket","owner":{"login":"netket","id":38641916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjQxOTE2","avatar_url":"https://avatars2.githubusercontent.com/u/38641916?v=4","gravatar_id":"","url":"https://api.github.com/users/netket","html_url":"https://github.com/netket","followers_url":"https://api.github.com/users/netket/followers","following_url":"https://api.github.com/users/netket/following{/other_user}","gists_url":"https://api.github.com/users/netket/gists{/gist_id}","starred_url":"https://api.github.com/users/netket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netket/subscriptions","organizations_url":"https://api.github.com/users/netket/orgs","repos_url":"https://api.github.com/users/netket/repos","events_url":"https://api.github.com/users/netket/events{/privacy}","received_events_url":"https://api.github.com/users/netket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netket/netket","description":"Machine learning algorithms for many-body quantum systems ","fork":false,"url":"https://api.github.com/repos/netket/netket","forks_url":"https://api.github.com/repos/netket/netket/forks","keys_url":"https://api.github.com/repos/netket/netket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netket/netket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netket/netket/teams","hooks_url":"https://api.github.com/repos/netket/netket/hooks","issue_events_url":"https://api.github.com/repos/netket/netket/issues/events{/number}","events_url":"https://api.github.com/repos/netket/netket/events","assignees_url":"https://api.github.com/repos/netket/netket/assignees{/user}","branches_url":"https://api.github.com/repos/netket/netket/branches{/branch}","tags_url":"https://api.github.com/repos/netket/netket/tags","blobs_url":"https://api.github.com/repos/netket/netket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netket/netket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netket/netket/git/refs{/sha}","trees_url":"https://api.github.com/repos/netket/netket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netket/netket/statuses/{sha}","languages_url":"https://api.github.com/repos/netket/netket/languages","stargazers_url":"https://api.github.com/repos/netket/netket/stargazers","contributors_url":"https://api.github.com/repos/netket/netket/contributors","subscribers_url":"https://api.github.com/repos/netket/netket/subscribers","subscription_url":"https://api.github.com/repos/netket/netket/subscription","commits_url":"https://api.github.com/repos/netket/netket/commits{/sha}","git_commits_url":"https://api.github.com/repos/netket/netket/git/commits{/sha}","comments_url":"https://api.github.com/repos/netket/netket/comments{/number}","issue_comment_url":"https://api.github.com/repos/netket/netket/issues/comments{/number}","contents_url":"https://api.github.com/repos/netket/netket/contents/{+path}","compare_url":"https://api.github.com/repos/netket/netket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netket/netket/merges","archive_url":"https://api.github.com/repos/netket/netket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netket/netket/downloads","issues_url":"https://api.github.com/repos/netket/netket/issues{/number}","pulls_url":"https://api.github.com/repos/netket/netket/pulls{/number}","milestones_url":"https://api.github.com/repos/netket/netket/milestones{/number}","notifications_url":"https://api.github.com/repos/netket/netket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netket/netket/labels{/name}","releases_url":"https://api.github.com/repos/netket/netket/releases{/id}","deployments_url":"https://api.github.com/repos/netket/netket/deployments","created_at":"2018-04-23T18:48:08Z","updated_at":"2018-09-09T12:00:27Z","pushed_at":"2018-09-09T12:00:23Z","git_url":"git://github.com/netket/netket.git","ssh_url":"[email protected]:netket/netket.git","clone_url":"https://github.com/netket/netket.git","svn_url":"https://github.com/netket/netket","homepage":"https://www.netket.org","size":25884,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":13,"watchers":54,"default_branch":"master"}},"base":{"label":"netket:master","ref":"master","sha":"4e805a82cad602616223eec5e0364787c52976f0","user":{"login":"netket","id":38641916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjQxOTE2","avatar_url":"https://avatars2.githubusercontent.com/u/38641916?v=4","gravatar_id":"","url":"https://api.github.com/users/netket","html_url":"https://github.com/netket","followers_url":"https://api.github.com/users/netket/followers","following_url":"https://api.github.com/users/netket/following{/other_user}","gists_url":"https://api.github.com/users/netket/gists{/gist_id}","starred_url":"https://api.github.com/users/netket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netket/subscriptions","organizations_url":"https://api.github.com/users/netket/orgs","repos_url":"https://api.github.com/users/netket/repos","events_url":"https://api.github.com/users/netket/events{/privacy}","received_events_url":"https://api.github.com/users/netket/received_events","type":"Organization","site_admin":false},"repo":{"id":130741783,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3NDE3ODM=","name":"netket","full_name":"netket/netket","owner":{"login":"netket","id":38641916,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjQxOTE2","avatar_url":"https://avatars2.githubusercontent.com/u/38641916?v=4","gravatar_id":"","url":"https://api.github.com/users/netket","html_url":"https://github.com/netket","followers_url":"https://api.github.com/users/netket/followers","following_url":"https://api.github.com/users/netket/following{/other_user}","gists_url":"https://api.github.com/users/netket/gists{/gist_id}","starred_url":"https://api.github.com/users/netket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/netket/subscriptions","organizations_url":"https://api.github.com/users/netket/orgs","repos_url":"https://api.github.com/users/netket/repos","events_url":"https://api.github.com/users/netket/events{/privacy}","received_events_url":"https://api.github.com/users/netket/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/netket/netket","description":"Machine learning algorithms for many-body quantum systems ","fork":false,"url":"https://api.github.com/repos/netket/netket","forks_url":"https://api.github.com/repos/netket/netket/forks","keys_url":"https://api.github.com/repos/netket/netket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/netket/netket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/netket/netket/teams","hooks_url":"https://api.github.com/repos/netket/netket/hooks","issue_events_url":"https://api.github.com/repos/netket/netket/issues/events{/number}","events_url":"https://api.github.com/repos/netket/netket/events","assignees_url":"https://api.github.com/repos/netket/netket/assignees{/user}","branches_url":"https://api.github.com/repos/netket/netket/branches{/branch}","tags_url":"https://api.github.com/repos/netket/netket/tags","blobs_url":"https://api.github.com/repos/netket/netket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/netket/netket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/netket/netket/git/refs{/sha}","trees_url":"https://api.github.com/repos/netket/netket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/netket/netket/statuses/{sha}","languages_url":"https://api.github.com/repos/netket/netket/languages","stargazers_url":"https://api.github.com/repos/netket/netket/stargazers","contributors_url":"https://api.github.com/repos/netket/netket/contributors","subscribers_url":"https://api.github.com/repos/netket/netket/subscribers","subscription_url":"https://api.github.com/repos/netket/netket/subscription","commits_url":"https://api.github.com/repos/netket/netket/commits{/sha}","git_commits_url":"https://api.github.com/repos/netket/netket/git/commits{/sha}","comments_url":"https://api.github.com/repos/netket/netket/comments{/number}","issue_comment_url":"https://api.github.com/repos/netket/netket/issues/comments{/number}","contents_url":"https://api.github.com/repos/netket/netket/contents/{+path}","compare_url":"https://api.github.com/repos/netket/netket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/netket/netket/merges","archive_url":"https://api.github.com/repos/netket/netket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/netket/netket/downloads","issues_url":"https://api.github.com/repos/netket/netket/issues{/number}","pulls_url":"https://api.github.com/repos/netket/netket/pulls{/number}","milestones_url":"https://api.github.com/repos/netket/netket/milestones{/number}","notifications_url":"https://api.github.com/repos/netket/netket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/netket/netket/labels{/name}","releases_url":"https://api.github.com/repos/netket/netket/releases{/id}","deployments_url":"https://api.github.com/repos/netket/netket/deployments","created_at":"2018-04-23T18:48:08Z","updated_at":"2018-09-09T12:00:27Z","pushed_at":"2018-09-09T12:00:23Z","git_url":"git://github.com/netket/netket.git","ssh_url":"[email protected]:netket/netket.git","clone_url":"https://github.com/netket/netket.git","svn_url":"https://github.com/netket/netket","homepage":"https://www.netket.org","size":25884,"stargazers_count":54,"watchers_count":54,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":26,"open_issues":13,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/netket/netket/pulls/67"},"html":{"href":"https://github.com/netket/netket/pull/67"},"issue":{"href":"https://api.github.com/repos/netket/netket/issues/67"},"comments":{"href":"https://api.github.com/repos/netket/netket/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/netket/netket/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/netket/netket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/netket/netket/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/netket/netket/statuses/117796cd3bf9b4d950ef4adc3cf13b072d77ba55"}},"author_association":"COLLABORATOR"}}

8255184263

{"actor":{"display_login":"twesterhout"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/comments/209718952","pull_request_review_id":145787394,"id":209718952,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTcxODk1Mg==","diff_hunk":"@@ -0,0 +1,27 @@\n+-- | Memory pool. TBD.","path":"witness/src/Dscp/Witness/Mempool/Type.hs","position":1,"original_position":1,"commit_id":"3ac80cd487379582544f9c801982dd576dc471b1","original_commit_id":"3ac80cd487379582544f9c801982dd576dc471b1","user":{"login":"volhovm","id":5604643,"node_id":"MDQ6VXNlcjU2MDQ2NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/5604643?v=4","gravatar_id":"","url":"https://api.github.com/users/volhovm","html_url":"https://github.com/volhovm","followers_url":"https://api.github.com/users/volhovm/followers","following_url":"https://api.github.com/users/volhovm/following{/other_user}","gists_url":"https://api.github.com/users/volhovm/gists{/gist_id}","starred_url":"https://api.github.com/users/volhovm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/volhovm/subscriptions","organizations_url":"https://api.github.com/users/volhovm/orgs","repos_url":"https://api.github.com/users/volhovm/repos","events_url":"https://api.github.com/users/volhovm/events{/privacy}","received_events_url":"https://api.github.com/users/volhovm/received_events","type":"User","site_admin":false},"body":"Old comment.","created_at":"2018-08-13T18:50:11Z","updated_at":"2018-08-13T18:59:09Z","html_url":"https://github.com/DisciplinaOU/disciplina/pull/115#discussion_r209718952","pull_request_url":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/115","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/comments/209718952"},"html":{"href":"https://github.com/DisciplinaOU/disciplina/pull/115#discussion_r209718952"},"pull_request":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/115"}}},"pull_request":{"url":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/115","id":207668425,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjY4NDI1","html_url":"https://github.com/DisciplinaOU/disciplina/pull/115","diff_url":"https://github.com/DisciplinaOU/disciplina/pull/115.diff","patch_url":"https://github.com/DisciplinaOU/disciplina/pull/115.patch","issue_url":"https://api.github.com/repos/DisciplinaOU/disciplina/issues/115","number":115,"state":"open","locked":false,"title":"[DSCP-139] [WIP] Adding tx to mempool, unrolling import loops","user":{"login":"Heimdell","id":1784505,"node_id":"MDQ6VXNlcjE3ODQ1MDU=","avatar_url":"https://avatars3.githubusercontent.com/u/1784505?v=4","gravatar_id":"","url":"https://api.github.com/users/Heimdell","html_url":"https://github.com/Heimdell","followers_url":"https://api.github.com/users/Heimdell/followers","following_url":"https://api.github.com/users/Heimdell/following{/other_user}","gists_url":"https://api.github.com/users/Heimdell/gists{/gist_id}","starred_url":"https://api.github.com/users/Heimdell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Heimdell/subscriptions","organizations_url":"https://api.github.com/users/Heimdell/orgs","repos_url":"https://api.github.com/users/Heimdell/repos","events_url":"https://api.github.com/users/Heimdell/events{/privacy}","received_events_url":"https://api.github.com/users/Heimdell/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-10T16:54:45Z","updated_at":"2018-08-13T18:59:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bed5c4a8f5b00205cc972b6ec8cec2d23dc0da85","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/115/commits","review_comments_url":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/115/comments","review_comment_url":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DisciplinaOU/disciplina/issues/115/comments","statuses_url":"https://api.github.com/repos/DisciplinaOU/disciplina/statuses/3ac80cd487379582544f9c801982dd576dc471b1","head":{"label":"DisciplinaOU:kirill.andreev/dscp-139-mempool-logic","ref":"kirill.andreev/dscp-139-mempool-logic","sha":"3ac80cd487379582544f9c801982dd576dc471b1","user":{"login":"DisciplinaOU","id":38657648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjU3NjQ4","avatar_url":"https://avatars1.githubusercontent.com/u/38657648?v=4","gravatar_id":"","url":"https://api.github.com/users/DisciplinaOU","html_url":"https://github.com/DisciplinaOU","followers_url":"https://api.github.com/users/DisciplinaOU/followers","following_url":"https://api.github.com/users/DisciplinaOU/following{/other_user}","gists_url":"https://api.github.com/users/DisciplinaOU/gists{/gist_id}","starred_url":"https://api.github.com/users/DisciplinaOU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DisciplinaOU/subscriptions","organizations_url":"https://api.github.com/users/DisciplinaOU/orgs","repos_url":"https://api.github.com/users/DisciplinaOU/repos","events_url":"https://api.github.com/users/DisciplinaOU/events{/privacy}","received_events_url":"https://api.github.com/users/DisciplinaOU/received_events","type":"Organization","site_admin":false},"repo":{"id":113064771,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMwNjQ3NzE=","name":"disciplina","full_name":"DisciplinaOU/disciplina","owner":{"login":"DisciplinaOU","id":38657648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjU3NjQ4","avatar_url":"https://avatars1.githubusercontent.com/u/38657648?v=4","gravatar_id":"","url":"https://api.github.com/users/DisciplinaOU","html_url":"https://github.com/DisciplinaOU","followers_url":"https://api.github.com/users/DisciplinaOU/followers","following_url":"https://api.github.com/users/DisciplinaOU/following{/other_user}","gists_url":"https://api.github.com/users/DisciplinaOU/gists{/gist_id}","starred_url":"https://api.github.com/users/DisciplinaOU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DisciplinaOU/subscriptions","organizations_url":"https://api.github.com/users/DisciplinaOU/orgs","repos_url":"https://api.github.com/users/DisciplinaOU/repos","events_url":"https://api.github.com/users/DisciplinaOU/events{/privacy}","received_events_url":"https://api.github.com/users/DisciplinaOU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DisciplinaOU/disciplina","description":"We are developing the first blockchain for recruiting & education","fork":false,"url":"https://api.github.com/repos/DisciplinaOU/disciplina","forks_url":"https://api.github.com/repos/DisciplinaOU/disciplina/forks","keys_url":"https://api.github.com/repos/DisciplinaOU/disciplina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DisciplinaOU/disciplina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DisciplinaOU/disciplina/teams","hooks_url":"https://api.github.com/repos/DisciplinaOU/disciplina/hooks","issue_events_url":"https://api.github.com/repos/DisciplinaOU/disciplina/issues/events{/number}","events_url":"https://api.github.com/repos/DisciplinaOU/disciplina/events","assignees_url":"https://api.github.com/repos/DisciplinaOU/disciplina/assignees{/user}","branches_url":"https://api.github.com/repos/DisciplinaOU/disciplina/branches{/branch}","tags_url":"https://api.github.com/repos/DisciplinaOU/disciplina/tags","blobs_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/refs{/sha}","trees_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DisciplinaOU/disciplina/statuses/{sha}","languages_url":"https://api.github.com/repos/DisciplinaOU/disciplina/languages","stargazers_url":"https://api.github.com/repos/DisciplinaOU/disciplina/stargazers","contributors_url":"https://api.github.com/repos/DisciplinaOU/disciplina/contributors","subscribers_url":"https://api.github.com/repos/DisciplinaOU/disciplina/subscribers","subscription_url":"https://api.github.com/repos/DisciplinaOU/disciplina/subscription","commits_url":"https://api.github.com/repos/DisciplinaOU/disciplina/commits{/sha}","git_commits_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/commits{/sha}","comments_url":"https://api.github.com/repos/DisciplinaOU/disciplina/comments{/number}","issue_comment_url":"https://api.github.com/repos/DisciplinaOU/disciplina/issues/comments{/number}","contents_url":"https://api.github.com/repos/DisciplinaOU/disciplina/contents/{+path}","compare_url":"https://api.github.com/repos/DisciplinaOU/disciplina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DisciplinaOU/disciplina/merges","archive_url":"https://api.github.com/repos/DisciplinaOU/disciplina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DisciplinaOU/disciplina/downloads","issues_url":"https://api.github.com/repos/DisciplinaOU/disciplina/issues{/number}","pulls_url":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls{/number}","milestones_url":"https://api.github.com/repos/DisciplinaOU/disciplina/milestones{/number}","notifications_url":"https://api.github.com/repos/DisciplinaOU/disciplina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DisciplinaOU/disciplina/labels{/name}","releases_url":"https://api.github.com/repos/DisciplinaOU/disciplina/releases{/id}","deployments_url":"https://api.github.com/repos/DisciplinaOU/disciplina/deployments","created_at":"2017-12-04T16:10:46Z","updated_at":"2018-08-11T19:27:27Z","pushed_at":"2018-08-13T18:26:23Z","git_url":"git://github.com/DisciplinaOU/disciplina.git","ssh_url":"[email protected]:DisciplinaOU/disciplina.git","clone_url":"https://github.com/DisciplinaOU/disciplina.git","svn_url":"https://github.com/DisciplinaOU/disciplina","homepage":"https://disciplina.io","size":9322,"stargazers_count":20,"watchers_count":20,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":20,"default_branch":"master"}},"base":{"label":"DisciplinaOU:master","ref":"master","sha":"148468f6c3621fcc8caf5fb10d7c9a744eb7f592","user":{"login":"DisciplinaOU","id":38657648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjU3NjQ4","avatar_url":"https://avatars1.githubusercontent.com/u/38657648?v=4","gravatar_id":"","url":"https://api.github.com/users/DisciplinaOU","html_url":"https://github.com/DisciplinaOU","followers_url":"https://api.github.com/users/DisciplinaOU/followers","following_url":"https://api.github.com/users/DisciplinaOU/following{/other_user}","gists_url":"https://api.github.com/users/DisciplinaOU/gists{/gist_id}","starred_url":"https://api.github.com/users/DisciplinaOU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DisciplinaOU/subscriptions","organizations_url":"https://api.github.com/users/DisciplinaOU/orgs","repos_url":"https://api.github.com/users/DisciplinaOU/repos","events_url":"https://api.github.com/users/DisciplinaOU/events{/privacy}","received_events_url":"https://api.github.com/users/DisciplinaOU/received_events","type":"Organization","site_admin":false},"repo":{"id":113064771,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMwNjQ3NzE=","name":"disciplina","full_name":"DisciplinaOU/disciplina","owner":{"login":"DisciplinaOU","id":38657648,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjU3NjQ4","avatar_url":"https://avatars1.githubusercontent.com/u/38657648?v=4","gravatar_id":"","url":"https://api.github.com/users/DisciplinaOU","html_url":"https://github.com/DisciplinaOU","followers_url":"https://api.github.com/users/DisciplinaOU/followers","following_url":"https://api.github.com/users/DisciplinaOU/following{/other_user}","gists_url":"https://api.github.com/users/DisciplinaOU/gists{/gist_id}","starred_url":"https://api.github.com/users/DisciplinaOU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DisciplinaOU/subscriptions","organizations_url":"https://api.github.com/users/DisciplinaOU/orgs","repos_url":"https://api.github.com/users/DisciplinaOU/repos","events_url":"https://api.github.com/users/DisciplinaOU/events{/privacy}","received_events_url":"https://api.github.com/users/DisciplinaOU/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DisciplinaOU/disciplina","description":"We are developing the first blockchain for recruiting & education","fork":false,"url":"https://api.github.com/repos/DisciplinaOU/disciplina","forks_url":"https://api.github.com/repos/DisciplinaOU/disciplina/forks","keys_url":"https://api.github.com/repos/DisciplinaOU/disciplina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DisciplinaOU/disciplina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DisciplinaOU/disciplina/teams","hooks_url":"https://api.github.com/repos/DisciplinaOU/disciplina/hooks","issue_events_url":"https://api.github.com/repos/DisciplinaOU/disciplina/issues/events{/number}","events_url":"https://api.github.com/repos/DisciplinaOU/disciplina/events","assignees_url":"https://api.github.com/repos/DisciplinaOU/disciplina/assignees{/user}","branches_url":"https://api.github.com/repos/DisciplinaOU/disciplina/branches{/branch}","tags_url":"https://api.github.com/repos/DisciplinaOU/disciplina/tags","blobs_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/refs{/sha}","trees_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DisciplinaOU/disciplina/statuses/{sha}","languages_url":"https://api.github.com/repos/DisciplinaOU/disciplina/languages","stargazers_url":"https://api.github.com/repos/DisciplinaOU/disciplina/stargazers","contributors_url":"https://api.github.com/repos/DisciplinaOU/disciplina/contributors","subscribers_url":"https://api.github.com/repos/DisciplinaOU/disciplina/subscribers","subscription_url":"https://api.github.com/repos/DisciplinaOU/disciplina/subscription","commits_url":"https://api.github.com/repos/DisciplinaOU/disciplina/commits{/sha}","git_commits_url":"https://api.github.com/repos/DisciplinaOU/disciplina/git/commits{/sha}","comments_url":"https://api.github.com/repos/DisciplinaOU/disciplina/comments{/number}","issue_comment_url":"https://api.github.com/repos/DisciplinaOU/disciplina/issues/comments{/number}","contents_url":"https://api.github.com/repos/DisciplinaOU/disciplina/contents/{+path}","compare_url":"https://api.github.com/repos/DisciplinaOU/disciplina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DisciplinaOU/disciplina/merges","archive_url":"https://api.github.com/repos/DisciplinaOU/disciplina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DisciplinaOU/disciplina/downloads","issues_url":"https://api.github.com/repos/DisciplinaOU/disciplina/issues{/number}","pulls_url":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls{/number}","milestones_url":"https://api.github.com/repos/DisciplinaOU/disciplina/milestones{/number}","notifications_url":"https://api.github.com/repos/DisciplinaOU/disciplina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DisciplinaOU/disciplina/labels{/name}","releases_url":"https://api.github.com/repos/DisciplinaOU/disciplina/releases{/id}","deployments_url":"https://api.github.com/repos/DisciplinaOU/disciplina/deployments","created_at":"2017-12-04T16:10:46Z","updated_at":"2018-08-11T19:27:27Z","pushed_at":"2018-08-13T18:26:23Z","git_url":"git://github.com/DisciplinaOU/disciplina.git","ssh_url":"[email protected]:DisciplinaOU/disciplina.git","clone_url":"https://github.com/DisciplinaOU/disciplina.git","svn_url":"https://github.com/DisciplinaOU/disciplina","homepage":"https://disciplina.io","size":9322,"stargazers_count":20,"watchers_count":20,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/115"},"html":{"href":"https://github.com/DisciplinaOU/disciplina/pull/115"},"issue":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/issues/115"},"comments":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/DisciplinaOU/disciplina/statuses/3ac80cd487379582544f9c801982dd576dc471b1"}},"author_association":"MEMBER"}}

8106889561

{"actor":{"display_login":"volhovm"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/gopherdojo/dojo4/pulls/comments/236642049","pull_request_review_id":178755256,"id":236642049,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjY0MjA0OQ==","diff_hunk":"@@ -0,0 +1,76 @@\n+package game\n+\n+import (\n+\t\"bufio\"\n+\t\"context\"\n+\t\"fmt\"\n+\t\"io\"\n+\t\"math/rand\"\n+\t\"os\"\n+\t\"time\"\n+)\n+\n+// Game generates typing game\n+type Game struct {\n+\twriter io.Writer\n+\tidx int\n+\twords []string\n+\ttimeout int\n+}\n+\n+func init() {\n+\trand.Seed(time.Now().UnixNano())\n+}\n+\n+// NewGame generates new Game instance\n+func NewGame(w io.Writer, words []string, timeout int) *Game {","path":"kadai3-1/akuchii/game/game.go","position":null,"original_position":26,"commit_id":"c33add5f6d3f34f38f8061e4ae2cdba779191d71","original_commit_id":"b3217ec360263a25a8e0467a4bc8dbd98f416492","user":{"login":"hakuta","id":806605,"node_id":"MDQ6VXNlcjgwNjYwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/806605?v=4","gravatar_id":"","url":"https://api.github.com/users/hakuta","html_url":"https://github.com/hakuta","followers_url":"https://api.github.com/users/hakuta/followers","following_url":"https://api.github.com/users/hakuta/following{/other_user}","gists_url":"https://api.github.com/users/hakuta/gists{/gist_id}","starred_url":"https://api.github.com/users/hakuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakuta/subscriptions","organizations_url":"https://api.github.com/users/hakuta/orgs","repos_url":"https://api.github.com/users/hakuta/repos","events_url":"https://api.github.com/users/hakuta/events{/privacy}","received_events_url":"https://api.github.com/users/hakuta/received_events","type":"User","site_admin":false},"body":"利用する側のことを考えて型を考えるのがよいんですね\r\nhttps://github.com/gopherdojo/dojo4/pull/41/commits/26d35640c69c188ed21867020180311f243006b0","created_at":"2018-11-27T12:31:35Z","updated_at":"2018-11-27T12:31:35Z","html_url":"https://github.com/gopherdojo/dojo4/pull/41#discussion_r236642049","pull_request_url":"https://api.github.com/repos/gopherdojo/dojo4/pulls/41","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/gopherdojo/dojo4/pulls/comments/236642049"},"html":{"href":"https://github.com/gopherdojo/dojo4/pull/41#discussion_r236642049"},"pull_request":{"href":"https://api.github.com/repos/gopherdojo/dojo4/pulls/41"}},"in_reply_to_id":236136854},"pull_request":{"url":"https://api.github.com/repos/gopherdojo/dojo4/pulls/41","id":233383056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzgzMDU2","html_url":"https://github.com/gopherdojo/dojo4/pull/41","diff_url":"https://github.com/gopherdojo/dojo4/pull/41.diff","patch_url":"https://github.com/gopherdojo/dojo4/pull/41.patch","issue_url":"https://api.github.com/repos/gopherdojo/dojo4/issues/41","number":41,"state":"open","locked":false,"title":"Kadai3 akuchii","user":{"login":"hakuta","id":806605,"node_id":"MDQ6VXNlcjgwNjYwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/806605?v=4","gravatar_id":"","url":"https://api.github.com/users/hakuta","html_url":"https://github.com/hakuta","followers_url":"https://api.github.com/users/hakuta/followers","following_url":"https://api.github.com/users/hakuta/following{/other_user}","gists_url":"https://api.github.com/users/hakuta/gists{/gist_id}","starred_url":"https://api.github.com/users/hakuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakuta/subscriptions","organizations_url":"https://api.github.com/users/hakuta/orgs","repos_url":"https://api.github.com/users/hakuta/repos","events_url":"https://api.github.com/users/hakuta/events{/privacy}","received_events_url":"https://api.github.com/users/hakuta/received_events","type":"User","site_admin":false},"body":"# タイピングゲームを作ろう\r\n- [x] 標準出力に英単語を出す（出すものは自由）\r\n英単語のリストをcsvやjsonから読み込んだりできるようにしたかったが、ファイル内に書いてしまっている\r\n- [x] 標準入力から1行受け取る\r\n- [x] 制限時間内に何問解けたか表示する\r\n`context.WithTimeout`を使って制限時間を実装\r\n\r\n# 分割ダウンロードを行う\r\n- [x] Rangeアクセスを用いる\r\n- [x] いくつかのゴルーチンでダウンロードしてマージする\r\n他の方の実装やgithub.com/Code-Hex/pgetを参考に実装\r\n- [ ] エラー処理を工夫する\r\n- [x] golang.org/x/sync/errgroupパッケージなどを使ってみる\r\n`errgroup`を使ってみたが、errorが起きた時にどうなるのか試せていないです...\r\n- [ ] キャンセルが発生した場合の実装を行う\r\n\r\nエラー処理の工夫、キャンセル発生時の実装が未実装ですが一旦提出します。\r\nテストは時間がとれず用意できていません...","created_at":"2018-11-25T15:43:24Z","updated_at":"2018-11-27T12:31:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"72742ddf815d68db3b4f8d09ebc78973edfd4ed7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gopherdojo/dojo4/pulls/41/commits","review_comments_url":"https://api.github.com/repos/gopherdojo/dojo4/pulls/41/comments","review_comment_url":"https://api.github.com/repos/gopherdojo/dojo4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gopherdojo/dojo4/issues/41/comments","statuses_url":"https://api.github.com/repos/gopherdojo/dojo4/statuses/c33add5f6d3f34f38f8061e4ae2cdba779191d71","head":{"label":"hakuta:kadai3-akuchii","ref":"kadai3-akuchii","sha":"c33add5f6d3f34f38f8061e4ae2cdba779191d71","user":{"login":"hakuta","id":806605,"node_id":"MDQ6VXNlcjgwNjYwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/806605?v=4","gravatar_id":"","url":"https://api.github.com/users/hakuta","html_url":"https://github.com/hakuta","followers_url":"https://api.github.com/users/hakuta/followers","following_url":"https://api.github.com/users/hakuta/following{/other_user}","gists_url":"https://api.github.com/users/hakuta/gists{/gist_id}","starred_url":"https://api.github.com/users/hakuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakuta/subscriptions","organizations_url":"https://api.github.com/users/hakuta/orgs","repos_url":"https://api.github.com/users/hakuta/repos","events_url":"https://api.github.com/users/hakuta/events{/privacy}","received_events_url":"https://api.github.com/users/hakuta/received_events","type":"User","site_admin":false},"repo":{"id":156700093,"node_id":"MDEwOlJlcG9zaXRvcnkxNTY3MDAwOTM=","name":"dojo4","full_name":"hakuta/dojo4","private":false,"owner":{"login":"hakuta","id":806605,"node_id":"MDQ6VXNlcjgwNjYwNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/806605?v=4","gravatar_id":"","url":"https://api.github.com/users/hakuta","html_url":"https://github.com/hakuta","followers_url":"https://api.github.com/users/hakuta/followers","following_url":"https://api.github.com/users/hakuta/following{/other_user}","gists_url":"https://api.github.com/users/hakuta/gists{/gist_id}","starred_url":"https://api.github.com/users/hakuta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakuta/subscriptions","organizations_url":"https://api.github.com/users/hakuta/orgs","repos_url":"https://api.github.com/users/hakuta/repos","events_url":"https://api.github.com/users/hakuta/events{/privacy}","received_events_url":"https://api.github.com/users/hakuta/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hakuta/dojo4","description":"#4 Gopher道場用のリポジトリです。","fork":true,"url":"https://api.github.com/repos/hakuta/dojo4","forks_url":"https://api.github.com/repos/hakuta/dojo4/forks","keys_url":"https://api.github.com/repos/hakuta/dojo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hakuta/dojo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hakuta/dojo4/teams","hooks_url":"https://api.github.com/repos/hakuta/dojo4/hooks","issue_events_url":"https://api.github.com/repos/hakuta/dojo4/issues/events{/number}","events_url":"https://api.github.com/repos/hakuta/dojo4/events","assignees_url":"https://api.github.com/repos/hakuta/dojo4/assignees{/user}","branches_url":"https://api.github.com/repos/hakuta/dojo4/branches{/branch}","tags_url":"https://api.github.com/repos/hakuta/dojo4/tags","blobs_url":"https://api.github.com/repos/hakuta/dojo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hakuta/dojo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hakuta/dojo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/hakuta/dojo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hakuta/dojo4/statuses/{sha}","languages_url":"https://api.github.com/repos/hakuta/dojo4/languages","stargazers_url":"https://api.github.com/repos/hakuta/dojo4/stargazers","contributors_url":"https://api.github.com/repos/hakuta/dojo4/contributors","subscribers_url":"https://api.github.com/repos/hakuta/dojo4/subscribers","subscription_url":"https://api.github.com/repos/hakuta/dojo4/subscription","commits_url":"https://api.github.com/repos/hakuta/dojo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/hakuta/dojo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/hakuta/dojo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/hakuta/dojo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/hakuta/dojo4/contents/{+path}","compare_url":"https://api.github.com/repos/hakuta/dojo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hakuta/dojo4/merges","archive_url":"https://api.github.com/repos/hakuta/dojo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hakuta/dojo4/downloads","issues_url":"https://api.github.com/repos/hakuta/dojo4/issues{/number}","pulls_url":"https://api.github.com/repos/hakuta/dojo4/pulls{/number}","milestones_url":"https://api.github.com/repos/hakuta/dojo4/milestones{/number}","notifications_url":"https://api.github.com/repos/hakuta/dojo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hakuta/dojo4/labels{/name}","releases_url":"https://api.github.com/repos/hakuta/dojo4/releases{/id}","deployments_url":"https://api.github.com/repos/hakuta/dojo4/deployments","created_at":"2018-11-08T11:57:55Z","updated_at":"2018-11-08T11:57:57Z","pushed_at":"2018-11-27T12:25:08Z","git_url":"git://github.com/hakuta/dojo4.git","ssh_url":"[email protected]:hakuta/dojo4.git","clone_url":"https://github.com/hakuta/dojo4.git","svn_url":"https://github.com/hakuta/dojo4","homepage":null,"size":351,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gopherdojo:master","ref":"master","sha":"c5b5d5108bacd21c6227b47d44d1a6a7001daf7e","user":{"login":"gopherdojo","id":38746752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NzQ2NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/38746752?v=4","gravatar_id":"","url":"https://api.github.com/users/gopherdojo","html_url":"https://github.com/gopherdojo","followers_url":"https://api.github.com/users/gopherdojo/followers","following_url":"https://api.github.com/users/gopherdojo/following{/other_user}","gists_url":"https://api.github.com/users/gopherdojo/gists{/gist_id}","starred_url":"https://api.github.com/users/gopherdojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gopherdojo/subscriptions","organizations_url":"https://api.github.com/users/gopherdojo/orgs","repos_url":"https://api.github.com/users/gopherdojo/repos","events_url":"https://api.github.com/users/gopherdojo/events{/privacy}","received_events_url":"https://api.github.com/users/gopherdojo/received_events","type":"Organization","site_admin":false},"repo":{"id":156155262,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYxNTUyNjI=","name":"dojo4","full_name":"gopherdojo/dojo4","private":false,"owner":{"login":"gopherdojo","id":38746752,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NzQ2NzUy","avatar_url":"https://avatars2.githubusercontent.com/u/38746752?v=4","gravatar_id":"","url":"https://api.github.com/users/gopherdojo","html_url":"https://github.com/gopherdojo","followers_url":"https://api.github.com/users/gopherdojo/followers","following_url":"https://api.github.com/users/gopherdojo/following{/other_user}","gists_url":"https://api.github.com/users/gopherdojo/gists{/gist_id}","starred_url":"https://api.github.com/users/gopherdojo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gopherdojo/subscriptions","organizations_url":"https://api.github.com/users/gopherdojo/orgs","repos_url":"https://api.github.com/users/gopherdojo/repos","events_url":"https://api.github.com/users/gopherdojo/events{/privacy}","received_events_url":"https://api.github.com/users/gopherdojo/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gopherdojo/dojo4","description":"#4 Gopher道場用のリポジトリです。","fork":false,"url":"https://api.github.com/repos/gopherdojo/dojo4","forks_url":"https://api.github.com/repos/gopherdojo/dojo4/forks","keys_url":"https://api.github.com/repos/gopherdojo/dojo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gopherdojo/dojo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gopherdojo/dojo4/teams","hooks_url":"https://api.github.com/repos/gopherdojo/dojo4/hooks","issue_events_url":"https://api.github.com/repos/gopherdojo/dojo4/issues/events{/number}","events_url":"https://api.github.com/repos/gopherdojo/dojo4/events","assignees_url":"https://api.github.com/repos/gopherdojo/dojo4/assignees{/user}","branches_url":"https://api.github.com/repos/gopherdojo/dojo4/branches{/branch}","tags_url":"https://api.github.com/repos/gopherdojo/dojo4/tags","blobs_url":"https://api.github.com/repos/gopherdojo/dojo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gopherdojo/dojo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gopherdojo/dojo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/gopherdojo/dojo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gopherdojo/dojo4/statuses/{sha}","languages_url":"https://api.github.com/repos/gopherdojo/dojo4/languages","stargazers_url":"https://api.github.com/repos/gopherdojo/dojo4/stargazers","contributors_url":"https://api.github.com/repos/gopherdojo/dojo4/contributors","subscribers_url":"https://api.github.com/repos/gopherdojo/dojo4/subscribers","subscription_url":"https://api.github.com/repos/gopherdojo/dojo4/subscription","commits_url":"https://api.github.com/repos/gopherdojo/dojo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/gopherdojo/dojo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/gopherdojo/dojo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/gopherdojo/dojo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/gopherdojo/dojo4/contents/{+path}","compare_url":"https://api.github.com/repos/gopherdojo/dojo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gopherdojo/dojo4/merges","archive_url":"https://api.github.com/repos/gopherdojo/dojo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gopherdojo/dojo4/downloads","issues_url":"https://api.github.com/repos/gopherdojo/dojo4/issues{/number}","pulls_url":"https://api.github.com/repos/gopherdojo/dojo4/pulls{/number}","milestones_url":"https://api.github.com/repos/gopherdojo/dojo4/milestones{/number}","notifications_url":"https://api.github.com/repos/gopherdojo/dojo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gopherdojo/dojo4/labels{/name}","releases_url":"https://api.github.com/repos/gopherdojo/dojo4/releases{/id}","deployments_url":"https://api.github.com/repos/gopherdojo/dojo4/deployments","created_at":"2018-11-05T03:26:22Z","updated_at":"2018-11-26T08:59:39Z","pushed_at":"2018-11-27T12:25:10Z","git_url":"git://github.com/gopherdojo/dojo4.git","ssh_url":"[email protected]:gopherdojo/dojo4.git","clone_url":"https://github.com/gopherdojo/dojo4.git","svn_url":"https://github.com/gopherdojo/dojo4","homepage":null,"size":4339,"stargazers_count":5,"watchers_count":5,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":47,"license":null,"forks":19,"open_issues":47,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gopherdojo/dojo4/pulls/41"},"html":{"href":"https://github.com/gopherdojo/dojo4/pull/41"},"issue":{"href":"https://api.github.com/repos/gopherdojo/dojo4/issues/41"},"comments":{"href":"https://api.github.com/repos/gopherdojo/dojo4/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/gopherdojo/dojo4/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/gopherdojo/dojo4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gopherdojo/dojo4/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/gopherdojo/dojo4/statuses/c33add5f6d3f34f38f8061e4ae2cdba779191d71"}},"author_association":"NONE"}}

8654013879

{"actor":{"display_login":"hakuta"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/optikon/coredns/pulls/comments/187121417","pull_request_review_id":118837913,"id":187121417,"diff_hunk":"@@ -1,3 +1,3 @@\n # Optikon DNS\n \n-Custom DNS for Optikon, Using Homemade CoreDNS Plugins\n+Custom DNS for Optikon, Using Homemade CoreDNS Plugins.","path":"README.md","position":4,"original_position":4,"commit_id":"13dbb5bf27ecab80b9a025fbfa3f62f688b54af0","original_commit_id":"13ba8a7b66bdba505ce4d39c06e73a739b5da785","user":{"login":"stephenrlouie","id":2810544,"avatar_url":"https://avatars0.githubusercontent.com/u/2810544?v=4","gravatar_id":"","url":"https://api.github.com/users/stephenrlouie","html_url":"https://github.com/stephenrlouie","followers_url":"https://api.github.com/users/stephenrlouie/followers","following_url":"https://api.github.com/users/stephenrlouie/following{/other_user}","gists_url":"https://api.github.com/users/stephenrlouie/gists{/gist_id}","starred_url":"https://api.github.com/users/stephenrlouie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stephenrlouie/subscriptions","organizations_url":"https://api.github.com/users/stephenrlouie/orgs","repos_url":"https://api.github.com/users/stephenrlouie/repos","events_url":"https://api.github.com/users/stephenrlouie/events{/privacy}","received_events_url":"https://api.github.com/users/stephenrlouie/received_events","type":"User","site_admin":false},"body":"I'll take a shot at it and submit a PR for this branch. Please correct whatever I submit and feel free to add more detail","created_at":"2018-05-09T17:47:02Z","updated_at":"2018-05-09T17:47:03Z","html_url":"https://github.com/optikon/coredns/pull/2#discussion_r187121417","pull_request_url":"https://api.github.com/repos/optikon/coredns/pulls/2","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/optikon/coredns/pulls/comments/187121417"},"html":{"href":"https://github.com/optikon/coredns/pull/2#discussion_r187121417"},"pull_request":{"href":"https://api.github.com/repos/optikon/coredns/pulls/2"}},"in_reply_to_id":186502767},"pull_request":{"url":"https://api.github.com/repos/optikon/coredns/pulls/2","id":186368489,"html_url":"https://github.com/optikon/coredns/pull/2","diff_url":"https://github.com/optikon/coredns/pull/2.diff","patch_url":"https://github.com/optikon/coredns/pull/2.patch","issue_url":"https://api.github.com/repos/optikon/coredns/issues/2","number":2,"state":"open","locked":false,"title":"CoreDNS Edge plugin rebirth","user":{"login":"rfliegerallison","id":6509399,"avatar_url":"https://avatars3.githubusercontent.com/u/6509399?v=4","gravatar_id":"","url":"https://api.github.com/users/rfliegerallison","html_url":"https://github.com/rfliegerallison","followers_url":"https://api.github.com/users/rfliegerallison/followers","following_url":"https://api.github.com/users/rfliegerallison/following{/other_user}","gists_url":"https://api.github.com/users/rfliegerallison/gists{/gist_id}","starred_url":"https://api.github.com/users/rfliegerallison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfliegerallison/subscriptions","organizations_url":"https://api.github.com/users/rfliegerallison/orgs","repos_url":"https://api.github.com/users/rfliegerallison/repos","events_url":"https://api.github.com/users/rfliegerallison/events{/privacy}","received_events_url":"https://api.github.com/users/rfliegerallison/received_events","type":"User","site_admin":false},"body":"A complete refactor/re-design of the CoreDNS Edge plugin.","created_at":"2018-05-07T14:30:55Z","updated_at":"2018-05-09T17:47:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7820b5e69137dadea9542fb8b5798383e8beecd3","assignee":{"login":"rfliegerallison","id":6509399,"avatar_url":"https://avatars3.githubusercontent.com/u/6509399?v=4","gravatar_id":"","url":"https://api.github.com/users/rfliegerallison","html_url":"https://github.com/rfliegerallison","followers_url":"https://api.github.com/users/rfliegerallison/followers","following_url":"https://api.github.com/users/rfliegerallison/following{/other_user}","gists_url":"https://api.github.com/users/rfliegerallison/gists{/gist_id}","starred_url":"https://api.github.com/users/rfliegerallison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfliegerallison/subscriptions","organizations_url":"https://api.github.com/users/rfliegerallison/orgs","repos_url":"https://api.github.com/users/rfliegerallison/repos","events_url":"https://api.github.com/users/rfliegerallison/events{/privacy}","received_events_url":"https://api.github.com/users/rfliegerallison/received_events","type":"User","site_admin":false},"assignees":[{"login":"rfliegerallison","id":6509399,"avatar_url":"https://avatars3.githubusercontent.com/u/6509399?v=4","gravatar_id":"","url":"https://api.github.com/users/rfliegerallison","html_url":"https://github.com/rfliegerallison","followers_url":"https://api.github.com/users/rfliegerallison/followers","following_url":"https://api.github.com/users/rfliegerallison/following{/other_user}","gists_url":"https://api.github.com/users/rfliegerallison/gists{/gist_id}","starred_url":"https://api.github.com/users/rfliegerallison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rfliegerallison/subscriptions","organizations_url":"https://api.github.com/users/rfliegerallison/orgs","repos_url":"https://api.github.com/users/rfliegerallison/repos","events_url":"https://api.github.com/users/rfliegerallison/events{/privacy}","received_events_url":"https://api.github.com/users/rfliegerallison/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":922421389,"url":"https://api.github.com/repos/optikon/coredns/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/optikon/coredns/pulls/2/commits","review_comments_url":"https://api.github.com/repos/optikon/coredns/pulls/2/comments","review_comment_url":"https://api.github.com/repos/optikon/coredns/pulls/comments{/number}","comments_url":"https://api.github.com/repos/optikon/coredns/issues/2/comments","statuses_url":"https://api.github.com/repos/optikon/coredns/statuses/13dbb5bf27ecab80b9a025fbfa3f62f688b54af0","head":{"label":"optikon:rebirth","ref":"rebirth","sha":"13dbb5bf27ecab80b9a025fbfa3f62f688b54af0","user":{"login":"optikon","id":38769315,"avatar_url":"https://avatars1.githubusercontent.com/u/38769315?v=4","gravatar_id":"","url":"https://api.github.com/users/optikon","html_url":"https://github.com/optikon","followers_url":"https://api.github.com/users/optikon/followers","following_url":"https://api.github.com/users/optikon/following{/other_user}","gists_url":"https://api.github.com/users/optikon/gists{/gist_id}","starred_url":"https://api.github.com/users/optikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optikon/subscriptions","organizations_url":"https://api.github.com/users/optikon/orgs","repos_url":"https://api.github.com/users/optikon/repos","events_url":"https://api.github.com/users/optikon/events{/privacy}","received_events_url":"https://api.github.com/users/optikon/received_events","type":"Organization","site_admin":false},"repo":{"id":132099952,"name":"coredns","full_name":"optikon/coredns","owner":{"login":"optikon","id":38769315,"avatar_url":"https://avatars1.githubusercontent.com/u/38769315?v=4","gravatar_id":"","url":"https://api.github.com/users/optikon","html_url":"https://github.com/optikon","followers_url":"https://api.github.com/users/optikon/followers","following_url":"https://api.github.com/users/optikon/following{/other_user}","gists_url":"https://api.github.com/users/optikon/gists{/gist_id}","starred_url":"https://api.github.com/users/optikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optikon/subscriptions","organizations_url":"https://api.github.com/users/optikon/orgs","repos_url":"https://api.github.com/users/optikon/repos","events_url":"https://api.github.com/users/optikon/events{/privacy}","received_events_url":"https://api.github.com/users/optikon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optikon/coredns","description":"Custom DNS for Optikon, Using Homemade CoreDNS Plugins","fork":false,"url":"https://api.github.com/repos/optikon/coredns","forks_url":"https://api.github.com/repos/optikon/coredns/forks","keys_url":"https://api.github.com/repos/optikon/coredns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optikon/coredns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optikon/coredns/teams","hooks_url":"https://api.github.com/repos/optikon/coredns/hooks","issue_events_url":"https://api.github.com/repos/optikon/coredns/issues/events{/number}","events_url":"https://api.github.com/repos/optikon/coredns/events","assignees_url":"https://api.github.com/repos/optikon/coredns/assignees{/user}","branches_url":"https://api.github.com/repos/optikon/coredns/branches{/branch}","tags_url":"https://api.github.com/repos/optikon/coredns/tags","blobs_url":"https://api.github.com/repos/optikon/coredns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optikon/coredns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optikon/coredns/git/refs{/sha}","trees_url":"https://api.github.com/repos/optikon/coredns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optikon/coredns/statuses/{sha}","languages_url":"https://api.github.com/repos/optikon/coredns/languages","stargazers_url":"https://api.github.com/repos/optikon/coredns/stargazers","contributors_url":"https://api.github.com/repos/optikon/coredns/contributors","subscribers_url":"https://api.github.com/repos/optikon/coredns/subscribers","subscription_url":"https://api.github.com/repos/optikon/coredns/subscription","commits_url":"https://api.github.com/repos/optikon/coredns/commits{/sha}","git_commits_url":"https://api.github.com/repos/optikon/coredns/git/commits{/sha}","comments_url":"https://api.github.com/repos/optikon/coredns/comments{/number}","issue_comment_url":"https://api.github.com/repos/optikon/coredns/issues/comments{/number}","contents_url":"https://api.github.com/repos/optikon/coredns/contents/{+path}","compare_url":"https://api.github.com/repos/optikon/coredns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optikon/coredns/merges","archive_url":"https://api.github.com/repos/optikon/coredns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optikon/coredns/downloads","issues_url":"https://api.github.com/repos/optikon/coredns/issues{/number}","pulls_url":"https://api.github.com/repos/optikon/coredns/pulls{/number}","milestones_url":"https://api.github.com/repos/optikon/coredns/milestones{/number}","notifications_url":"https://api.github.com/repos/optikon/coredns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optikon/coredns/labels{/name}","releases_url":"https://api.github.com/repos/optikon/coredns/releases{/id}","deployments_url":"https://api.github.com/repos/optikon/coredns/deployments","created_at":"2018-05-04T06:47:57Z","updated_at":"2018-05-07T13:53:00Z","pushed_at":"2018-05-09T17:39:14Z","git_url":"git://github.com/optikon/coredns.git","ssh_url":"[email protected]:optikon/coredns.git","clone_url":"https://github.com/optikon/coredns.git","svn_url":"https://github.com/optikon/coredns","homepage":"","size":12934,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"optikon:master","ref":"master","sha":"7cc964a46628f047c59d6828931db9cc0352c88b","user":{"login":"optikon","id":38769315,"avatar_url":"https://avatars1.githubusercontent.com/u/38769315?v=4","gravatar_id":"","url":"https://api.github.com/users/optikon","html_url":"https://github.com/optikon","followers_url":"https://api.github.com/users/optikon/followers","following_url":"https://api.github.com/users/optikon/following{/other_user}","gists_url":"https://api.github.com/users/optikon/gists{/gist_id}","starred_url":"https://api.github.com/users/optikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optikon/subscriptions","organizations_url":"https://api.github.com/users/optikon/orgs","repos_url":"https://api.github.com/users/optikon/repos","events_url":"https://api.github.com/users/optikon/events{/privacy}","received_events_url":"https://api.github.com/users/optikon/received_events","type":"Organization","site_admin":false},"repo":{"id":132099952,"name":"coredns","full_name":"optikon/coredns","owner":{"login":"optikon","id":38769315,"avatar_url":"https://avatars1.githubusercontent.com/u/38769315?v=4","gravatar_id":"","url":"https://api.github.com/users/optikon","html_url":"https://github.com/optikon","followers_url":"https://api.github.com/users/optikon/followers","following_url":"https://api.github.com/users/optikon/following{/other_user}","gists_url":"https://api.github.com/users/optikon/gists{/gist_id}","starred_url":"https://api.github.com/users/optikon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/optikon/subscriptions","organizations_url":"https://api.github.com/users/optikon/orgs","repos_url":"https://api.github.com/users/optikon/repos","events_url":"https://api.github.com/users/optikon/events{/privacy}","received_events_url":"https://api.github.com/users/optikon/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/optikon/coredns","description":"Custom DNS for Optikon, Using Homemade CoreDNS Plugins","fork":false,"url":"https://api.github.com/repos/optikon/coredns","forks_url":"https://api.github.com/repos/optikon/coredns/forks","keys_url":"https://api.github.com/repos/optikon/coredns/keys{/key_id}","collaborators_url":"https://api.github.com/repos/optikon/coredns/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/optikon/coredns/teams","hooks_url":"https://api.github.com/repos/optikon/coredns/hooks","issue_events_url":"https://api.github.com/repos/optikon/coredns/issues/events{/number}","events_url":"https://api.github.com/repos/optikon/coredns/events","assignees_url":"https://api.github.com/repos/optikon/coredns/assignees{/user}","branches_url":"https://api.github.com/repos/optikon/coredns/branches{/branch}","tags_url":"https://api.github.com/repos/optikon/coredns/tags","blobs_url":"https://api.github.com/repos/optikon/coredns/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/optikon/coredns/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/optikon/coredns/git/refs{/sha}","trees_url":"https://api.github.com/repos/optikon/coredns/git/trees{/sha}","statuses_url":"https://api.github.com/repos/optikon/coredns/statuses/{sha}","languages_url":"https://api.github.com/repos/optikon/coredns/languages","stargazers_url":"https://api.github.com/repos/optikon/coredns/stargazers","contributors_url":"https://api.github.com/repos/optikon/coredns/contributors","subscribers_url":"https://api.github.com/repos/optikon/coredns/subscribers","subscription_url":"https://api.github.com/repos/optikon/coredns/subscription","commits_url":"https://api.github.com/repos/optikon/coredns/commits{/sha}","git_commits_url":"https://api.github.com/repos/optikon/coredns/git/commits{/sha}","comments_url":"https://api.github.com/repos/optikon/coredns/comments{/number}","issue_comment_url":"https://api.github.com/repos/optikon/coredns/issues/comments{/number}","contents_url":"https://api.github.com/repos/optikon/coredns/contents/{+path}","compare_url":"https://api.github.com/repos/optikon/coredns/compare/{base}...{head}","merges_url":"https://api.github.com/repos/optikon/coredns/merges","archive_url":"https://api.github.com/repos/optikon/coredns/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/optikon/coredns/downloads","issues_url":"https://api.github.com/repos/optikon/coredns/issues{/number}","pulls_url":"https://api.github.com/repos/optikon/coredns/pulls{/number}","milestones_url":"https://api.github.com/repos/optikon/coredns/milestones{/number}","notifications_url":"https://api.github.com/repos/optikon/coredns/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/optikon/coredns/labels{/name}","releases_url":"https://api.github.com/repos/optikon/coredns/releases{/id}","deployments_url":"https://api.github.com/repos/optikon/coredns/deployments","created_at":"2018-05-04T06:47:57Z","updated_at":"2018-05-07T13:53:00Z","pushed_at":"2018-05-09T17:39:14Z","git_url":"git://github.com/optikon/coredns.git","ssh_url":"[email protected]:optikon/coredns.git","clone_url":"https://github.com/optikon/coredns.git","svn_url":"https://github.com/optikon/coredns","homepage":"","size":12934,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/optikon/coredns/pulls/2"},"html":{"href":"https://github.com/optikon/coredns/pull/2"},"issue":{"href":"https://api.github.com/repos/optikon/coredns/issues/2"},"comments":{"href":"https://api.github.com/repos/optikon/coredns/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/optikon/coredns/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/optikon/coredns/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/optikon/coredns/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/optikon/coredns/statuses/13dbb5bf27ecab80b9a025fbfa3f62f688b54af0"}},"author_association":"NONE"}}

7651228727

{"actor":{"display_login":"stephenrlouie"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/comments/221535440","pull_request_review_id":160201430,"id":221535440,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTUzNTQ0MA==","diff_hunk":"@@ -15,3 +18,99 @@ exports.parseMongooseError = (err) => {\n };\n \n exports.checkMongooseConnectionErr = err => err.message === 'no connection available for operation and number of stored operation > 0';\n+\n+exports.voidDocuSignContract = (res, envelopeId, cb) => {","path":"src/helpers/utils.js","position":13,"original_position":13,"commit_id":"628abd253a4d82c993ff137d0de3f4104e4562e4","original_commit_id":"628abd253a4d82c993ff137d0de3f4104e4562e4","user":{"login":"bbbneo333","id":23015711,"node_id":"MDQ6VXNlcjIzMDE1NzEx","avatar_url":"https://avatars2.githubusercontent.com/u/23015711?v=4","gravatar_id":"","url":"https://api.github.com/users/bbbneo333","html_url":"https://github.com/bbbneo333","followers_url":"https://api.github.com/users/bbbneo333/followers","following_url":"https://api.github.com/users/bbbneo333/following{/other_user}","gists_url":"https://api.github.com/users/bbbneo333/gists{/gist_id}","starred_url":"https://api.github.com/users/bbbneo333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bbbneo333/subscriptions","organizations_url":"https://api.github.com/users/bbbneo333/orgs","repos_url":"https://api.github.com/users/bbbneo333/repos","events_url":"https://api.github.com/users/bbbneo333/events{/privacy}","received_events_url":"https://api.github.com/users/bbbneo333/received_events","type":"User","site_admin":false},"body":"Pass the `res.locals.DOCU_SIGN_ACCOUNT_ID` via parameter.","created_at":"2018-10-01T08:56:04Z","updated_at":"2018-10-01T08:56:56Z","html_url":"https://github.com/jalantechnologies/proptoken-api/pull/5#discussion_r221535440","pull_request_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/5","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/comments/221535440"},"html":{"href":"https://github.com/jalantechnologies/proptoken-api/pull/5#discussion_r221535440"},"pull_request":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/5"}},"in_reply_to_id":221535283},"pull_request":{"url":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/5","id":219297660,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Mjk3NjYw","html_url":"https://github.com/jalantechnologies/proptoken-api/pull/5","diff_url":"https://github.com/jalantechnologies/proptoken-api/pull/5.diff","patch_url":"https://github.com/jalantechnologies/proptoken-api/pull/5.patch","issue_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues/5","number":5,"state":"open","locked":false,"title":"PROP-10: proptoken-webapp and propetoken-enterprise-webapp should use same API server","user":{"login":"sakshigokhru","id":38902768,"node_id":"MDQ6VXNlcjM4OTAyNzY4","avatar_url":"https://avatars0.githubusercontent.com/u/38902768?v=4","gravatar_id":"","url":"https://api.github.com/users/sakshigokhru","html_url":"https://github.com/sakshigokhru","followers_url":"https://api.github.com/users/sakshigokhru/followers","following_url":"https://api.github.com/users/sakshigokhru/following{/other_user}","gists_url":"https://api.github.com/users/sakshigokhru/gists{/gist_id}","starred_url":"https://api.github.com/users/sakshigokhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakshigokhru/subscriptions","organizations_url":"https://api.github.com/users/sakshigokhru/orgs","repos_url":"https://api.github.com/users/sakshigokhru/repos","events_url":"https://api.github.com/users/sakshigokhru/events{/privacy}","received_events_url":"https://api.github.com/users/sakshigokhru/received_events","type":"User","site_admin":false},"body":"### Description\r\n_proptoken-webapp and proptoken-enterprise-webapp should use same API server_","created_at":"2018-10-01T08:39:20Z","updated_at":"2018-10-01T08:56:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4238a92d7d698880c86d43411e0cab9b2ed9b4bf","assignee":{"login":"sakshigokhru","id":38902768,"node_id":"MDQ6VXNlcjM4OTAyNzY4","avatar_url":"https://avatars0.githubusercontent.com/u/38902768?v=4","gravatar_id":"","url":"https://api.github.com/users/sakshigokhru","html_url":"https://github.com/sakshigokhru","followers_url":"https://api.github.com/users/sakshigokhru/followers","following_url":"https://api.github.com/users/sakshigokhru/following{/other_user}","gists_url":"https://api.github.com/users/sakshigokhru/gists{/gist_id}","starred_url":"https://api.github.com/users/sakshigokhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakshigokhru/subscriptions","organizations_url":"https://api.github.com/users/sakshigokhru/orgs","repos_url":"https://api.github.com/users/sakshigokhru/repos","events_url":"https://api.github.com/users/sakshigokhru/events{/privacy}","received_events_url":"https://api.github.com/users/sakshigokhru/received_events","type":"User","site_admin":false},"assignees":[{"login":"sakshigokhru","id":38902768,"node_id":"MDQ6VXNlcjM4OTAyNzY4","avatar_url":"https://avatars0.githubusercontent.com/u/38902768?v=4","gravatar_id":"","url":"https://api.github.com/users/sakshigokhru","html_url":"https://github.com/sakshigokhru","followers_url":"https://api.github.com/users/sakshigokhru/followers","following_url":"https://api.github.com/users/sakshigokhru/following{/other_user}","gists_url":"https://api.github.com/users/sakshigokhru/gists{/gist_id}","starred_url":"https://api.github.com/users/sakshigokhru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakshigokhru/subscriptions","organizations_url":"https://api.github.com/users/sakshigokhru/orgs","repos_url":"https://api.github.com/users/sakshigokhru/repos","events_url":"https://api.github.com/users/sakshigokhru/events{/privacy}","received_events_url":"https://api.github.com/users/sakshigokhru/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jjalan","id":328858,"node_id":"MDQ6VXNlcjMyODg1OA==","avatar_url":"https://avatars2.githubusercontent.com/u/328858?v=4","gravatar_id":"","url":"https://api.github.com/users/jjalan","html_url":"https://github.com/jjalan","followers_url":"https://api.github.com/users/jjalan/followers","following_url":"https://api.github.com/users/jjalan/following{/other_user}","gists_url":"https://api.github.com/users/jjalan/gists{/gist_id}","starred_url":"https://api.github.com/users/jjalan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjalan/subscriptions","organizations_url":"https://api.github.com/users/jjalan/orgs","repos_url":"https://api.github.com/users/jjalan/repos","events_url":"https://api.github.com/users/jjalan/events{/privacy}","received_events_url":"https://api.github.com/users/jjalan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1041558692,"node_id":"MDU6TGFiZWwxMDQxNTU4Njky","url":"https://api.github.com/repos/jalantechnologies/proptoken-api/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/5/commits","review_comments_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/5/comments","review_comment_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues/5/comments","statuses_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/statuses/628abd253a4d82c993ff137d0de3f4104e4562e4","head":{"label":"jalantechnologies:feature/PROP-10/combine_deedlock_and_proptoken_api_server","ref":"feature/PROP-10/combine_deedlock_and_proptoken_api_server","sha":"628abd253a4d82c993ff137d0de3f4104e4562e4","user":{"login":"jalantechnologies","id":38894550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODk0NTUw","avatar_url":"https://avatars0.githubusercontent.com/u/38894550?v=4","gravatar_id":"","url":"https://api.github.com/users/jalantechnologies","html_url":"https://github.com/jalantechnologies","followers_url":"https://api.github.com/users/jalantechnologies/followers","following_url":"https://api.github.com/users/jalantechnologies/following{/other_user}","gists_url":"https://api.github.com/users/jalantechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/jalantechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalantechnologies/subscriptions","organizations_url":"https://api.github.com/users/jalantechnologies/orgs","repos_url":"https://api.github.com/users/jalantechnologies/repos","events_url":"https://api.github.com/users/jalantechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/jalantechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":146893910,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4OTM5MTA=","name":"proptoken-api","full_name":"jalantechnologies/proptoken-api","private":false,"owner":{"login":"jalantechnologies","id":38894550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODk0NTUw","avatar_url":"https://avatars0.githubusercontent.com/u/38894550?v=4","gravatar_id":"","url":"https://api.github.com/users/jalantechnologies","html_url":"https://github.com/jalantechnologies","followers_url":"https://api.github.com/users/jalantechnologies/followers","following_url":"https://api.github.com/users/jalantechnologies/following{/other_user}","gists_url":"https://api.github.com/users/jalantechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/jalantechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalantechnologies/subscriptions","organizations_url":"https://api.github.com/users/jalantechnologies/orgs","repos_url":"https://api.github.com/users/jalantechnologies/repos","events_url":"https://api.github.com/users/jalantechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/jalantechnologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jalantechnologies/proptoken-api","description":null,"fork":false,"url":"https://api.github.com/repos/jalantechnologies/proptoken-api","forks_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/forks","keys_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/teams","hooks_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/hooks","issue_events_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues/events{/number}","events_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/events","assignees_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/assignees{/user}","branches_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/branches{/branch}","tags_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/tags","blobs_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/statuses/{sha}","languages_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/languages","stargazers_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/stargazers","contributors_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/contributors","subscribers_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/subscribers","subscription_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/subscription","commits_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/contents/{+path}","compare_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/merges","archive_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/downloads","issues_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues{/number}","pulls_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls{/number}","milestones_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/milestones{/number}","notifications_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/labels{/name}","releases_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/releases{/id}","deployments_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/deployments","created_at":"2018-08-31T13:12:55Z","updated_at":"2018-09-29T11:55:42Z","pushed_at":"2018-10-01T08:39:21Z","git_url":"git://github.com/jalantechnologies/proptoken-api.git","ssh_url":"[email protected]:jalantechnologies/proptoken-api.git","clone_url":"https://github.com/jalantechnologies/proptoken-api.git","svn_url":"https://github.com/jalantechnologies/proptoken-api","homepage":null,"size":188,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"base":{"label":"jalantechnologies:develop","ref":"develop","sha":"4704ee53235d5479bec969240f13f18c4973369e","user":{"login":"jalantechnologies","id":38894550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODk0NTUw","avatar_url":"https://avatars0.githubusercontent.com/u/38894550?v=4","gravatar_id":"","url":"https://api.github.com/users/jalantechnologies","html_url":"https://github.com/jalantechnologies","followers_url":"https://api.github.com/users/jalantechnologies/followers","following_url":"https://api.github.com/users/jalantechnologies/following{/other_user}","gists_url":"https://api.github.com/users/jalantechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/jalantechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalantechnologies/subscriptions","organizations_url":"https://api.github.com/users/jalantechnologies/orgs","repos_url":"https://api.github.com/users/jalantechnologies/repos","events_url":"https://api.github.com/users/jalantechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/jalantechnologies/received_events","type":"Organization","site_admin":false},"repo":{"id":146893910,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY4OTM5MTA=","name":"proptoken-api","full_name":"jalantechnologies/proptoken-api","private":false,"owner":{"login":"jalantechnologies","id":38894550,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4ODk0NTUw","avatar_url":"https://avatars0.githubusercontent.com/u/38894550?v=4","gravatar_id":"","url":"https://api.github.com/users/jalantechnologies","html_url":"https://github.com/jalantechnologies","followers_url":"https://api.github.com/users/jalantechnologies/followers","following_url":"https://api.github.com/users/jalantechnologies/following{/other_user}","gists_url":"https://api.github.com/users/jalantechnologies/gists{/gist_id}","starred_url":"https://api.github.com/users/jalantechnologies/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jalantechnologies/subscriptions","organizations_url":"https://api.github.com/users/jalantechnologies/orgs","repos_url":"https://api.github.com/users/jalantechnologies/repos","events_url":"https://api.github.com/users/jalantechnologies/events{/privacy}","received_events_url":"https://api.github.com/users/jalantechnologies/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jalantechnologies/proptoken-api","description":null,"fork":false,"url":"https://api.github.com/repos/jalantechnologies/proptoken-api","forks_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/forks","keys_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/teams","hooks_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/hooks","issue_events_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues/events{/number}","events_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/events","assignees_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/assignees{/user}","branches_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/branches{/branch}","tags_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/tags","blobs_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/statuses/{sha}","languages_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/languages","stargazers_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/stargazers","contributors_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/contributors","subscribers_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/subscribers","subscription_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/subscription","commits_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/contents/{+path}","compare_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/merges","archive_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/downloads","issues_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues{/number}","pulls_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls{/number}","milestones_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/milestones{/number}","notifications_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/labels{/name}","releases_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/releases{/id}","deployments_url":"https://api.github.com/repos/jalantechnologies/proptoken-api/deployments","created_at":"2018-08-31T13:12:55Z","updated_at":"2018-09-29T11:55:42Z","pushed_at":"2018-10-01T08:39:21Z","git_url":"git://github.com/jalantechnologies/proptoken-api.git","ssh_url":"[email protected]:jalantechnologies/proptoken-api.git","clone_url":"https://github.com/jalantechnologies/proptoken-api.git","svn_url":"https://github.com/jalantechnologies/proptoken-api","homepage":null,"size":188,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/5"},"html":{"href":"https://github.com/jalantechnologies/proptoken-api/pull/5"},"issue":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues/5"},"comments":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/jalantechnologies/proptoken-api/statuses/628abd253a4d82c993ff137d0de3f4104e4562e4"}},"author_association":"COLLABORATOR"}}

8346562871

{"actor":{"display_login":"bbbneo333"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/reposense/RepoSense/pulls/comments/193152479","pull_request_review_id":126065215,"id":193152479,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzE1MjQ3OQ==","diff_hunk":"@@ -0,0 +1,175 @@\n+package reposense.parser;\n+\n+import java.io.IOException;\n+import java.nio.file.Files;\n+import java.nio.file.Path;\n+import java.nio.file.Paths;\n+import java.util.Calendar;\n+import java.util.Date;\n+import java.util.Optional;\n+\n+import org.junit.Assert;\n+import org.junit.Test;\n+\n+import reposense.exception.ParseException;\n+import reposense.frontend.CliArguments;\n+import reposense.util.TestUtil;\n+\n+public class ArgsParserTest {\n+\n+ private static final String INPUT_DELIMITER = \" \";\n+ private static final String PROJECT_DIRECTORY = System.getProperty(\"user.dir\");\n+\n+ private static final String CONFIG_FILE_ABSOLUTE = Paths.get(PROJECT_DIRECTORY, \"sample_small.csv\").toString();\n+ private static final String OUTPUT_DIRECTORY_ABSOLUTE = Paths.get(PROJECT_DIRECTORY, \"build\").toString();\n+ private static final String CONFIG_FILE_RELATIVE = Paths.get(\"sample_small.csv\").toString();\n+ private static final String OUTPUT_DIRECTORY_RELATIVE = Paths.get(\"build\").toString();\n+ private static final String DEFAULT_MANDATORY_ARGS = \"-config \" + CONFIG_FILE_ABSOLUTE + \" \";\n+\n+ @Test\n+ public void parse_allCorrectInputs_success() throws ParseException, IOException {\n+ String input = String.format(\"-config %s -output %s -since 01/07/2017 -until 30/11/2017\",\n+ CONFIG_FILE_ABSOLUTE, OUTPUT_DIRECTORY_ABSOLUTE);\n+ CliArguments cliArguments = ArgsParser.parse(input.split(INPUT_DELIMITER));\n+ Files.isSameFile(Paths.get(CONFIG_FILE_ABSOLUTE), cliArguments.getConfigFilePath());\n+ Files.isSameFile(Paths.get(OUTPUT_DIRECTORY_ABSOLUTE), cliArguments.getOutputFilePath());\n+\n+ Date expectedSinceDate = TestUtil.getDate(2017, Calendar.JULY, 1);\n+ Date expectedUntilDate = TestUtil.getDate(2017, Calendar.NOVEMBER, 30);\n+ Assert.assertEquals(expectedSinceDate, cliArguments.getSinceDate().get());\n+ Assert.assertEquals(expectedUntilDate, cliArguments.getUntilDate().get());\n+ }\n+\n+ @Test\n+ public void parse_configFileOnly_success() throws ParseException, IOException {\n+ String input = String.format(\"-config %s\", CONFIG_FILE_ABSOLUTE);\n+ CliArguments cliArgumentsOfAbsolutePath = ArgsParser.parse(input.split(INPUT_DELIMITER));\n+\n+ input = String.format(\"-config %s\", CONFIG_FILE_RELATIVE);\n+ CliArguments cliArgumentsOfRelativePath = ArgsParser.parse(input.split(INPUT_DELIMITER));\n+\n+ Path expected = Paths.get(CONFIG_FILE_ABSOLUTE);\n+ Files.isSameFile(expected, cliArgumentsOfAbsolutePath.getConfigFilePath());\n+ Files.isSameFile(expected, cliArgumentsOfRelativePath.getConfigFilePath());\n+\n+ //Optional arguments have default values\n+ Assert.assertEquals(Optional.empty(), cliArgumentsOfAbsolutePath.getSinceDate());\n+ Assert.assertEquals(Optional.empty(), cliArgumentsOfAbsolutePath.getUntilDate());\n+ Assert.assertTrue(Files.isSameFile(Paths.get(\".\"), cliArgumentsOfAbsolutePath.getOutputFilePath()));\n+\n+ Assert.assertEquals(Optional.empty(), cliArgumentsOfRelativePath.getSinceDate());\n+ Assert.assertEquals(Optional.empty(), cliArgumentsOfRelativePath.getUntilDate());\n+ Assert.assertTrue(Files.isSameFile(Paths.get(\".\"), cliArgumentsOfRelativePath.getOutputFilePath()));\n+ }\n+\n+ @Test\n+ public void parse_configFileAndOutputDirectory_success() throws ParseException, IOException {\n+ String input = String.format(\"-config %s -output %s\", CONFIG_FILE_ABSOLUTE, OUTPUT_DIRECTORY_RELATIVE);\n+ CliArguments cliArgAbsConfigRelOutput = ArgsParser.parse(input.split(INPUT_DELIMITER));","path":"src/test/java/reposense/parser/ArgsParserTest.java","position":68,"original_position":68,"commit_id":"dd283e649e7d24f08520af29f734f5efbb691f02","original_commit_id":"dd283e649e7d24f08520af29f734f5efbb691f02","user":{"login":"eugenepeh","id":19277206,"node_id":"MDQ6VXNlcjE5Mjc3MjA2","avatar_url":"https://avatars2.githubusercontent.com/u/19277206?v=4","gravatar_id":"","url":"https://api.github.com/users/eugenepeh","html_url":"https://github.com/eugenepeh","followers_url":"https://api.github.com/users/eugenepeh/followers","following_url":"https://api.github.com/users/eugenepeh/following{/other_user}","gists_url":"https://api.github.com/users/eugenepeh/gists{/gist_id}","starred_url":"https://api.github.com/users/eugenepeh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugenepeh/subscriptions","organizations_url":"https://api.github.com/users/eugenepeh/orgs","repos_url":"https://api.github.com/users/eugenepeh/repos","events_url":"https://api.github.com/users/eugenepeh/events{/privacy}","received_events_url":"https://api.github.com/users/eugenepeh/received_events","type":"User","site_admin":false},"body":"Have you explore such tools as mentioned in this SO? https://stackoverflow.com/questions/3259143/split-a-string-containing-command-line-parameters-into-a-string-in-java","created_at":"2018-06-05T17:14:18Z","updated_at":"2018-06-05T17:22:14Z","html_url":"https://github.com/reposense/RepoSense/pull/128#discussion_r193152479","pull_request_url":"https://api.github.com/repos/reposense/RepoSense/pulls/128","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reposense/RepoSense/pulls/comments/193152479"},"html":{"href":"https://github.com/reposense/RepoSense/pull/128#discussion_r193152479"},"pull_request":{"href":"https://api.github.com/repos/reposense/RepoSense/pulls/128"}}},"pull_request":{"url":"https://api.github.com/repos/reposense/RepoSense/pulls/128","id":190515724,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNTE1NzI0","html_url":"https://github.com/reposense/RepoSense/pull/128","diff_url":"https://github.com/reposense/RepoSense/pull/128.diff","patch_url":"https://github.com/reposense/RepoSense/pull/128.patch","issue_url":"https://api.github.com/repos/reposense/RepoSense/issues/128","number":128,"state":"open","locked":false,"title":"Increase parsing capabilities using third-party library","user":{"login":"yong24s","id":2003406,"node_id":"MDQ6VXNlcjIwMDM0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2003406?v=4","gravatar_id":"","url":"https://api.github.com/users/yong24s","html_url":"https://github.com/yong24s","followers_url":"https://api.github.com/users/yong24s/followers","following_url":"https://api.github.com/users/yong24s/following{/other_user}","gists_url":"https://api.github.com/users/yong24s/gists{/gist_id}","starred_url":"https://api.github.com/users/yong24s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yong24s/subscriptions","organizations_url":"https://api.github.com/users/yong24s/orgs","repos_url":"https://api.github.com/users/yong24s/repos","events_url":"https://api.github.com/users/yong24s/events{/privacy}","received_events_url":"https://api.github.com/users/yong24s/received_events","type":"User","site_admin":false},"body":"Proposed message:\r\n```\r\nCurrently, the program expects arguments to be given in a pair,\r\nin this form \"-argument value\".\r\n\r\nThis design is not flexible as it does not allow inputs \r\nwith no value or multiple values. For example, -incremental and \r\n-config file1 file2 file3.\r\n\r\nLet's use third-party argument parser library, ArgParse4J \r\nto increase flexibility and functionality. It provides many \r\nquality-of-life features, such as, flexible arguments \r\nas well as datatype conversion.\r\n```","created_at":"2018-05-25T08:30:16Z","updated_at":"2018-06-05T17:22:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e06539c721fd5f7ad49dedc4b37a39fb36ef455d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":920545643,"node_id":"MDU6TGFiZWw5MjA1NDU2NDM=","url":"https://api.github.com/repos/reposense/RepoSense/labels/s.ToReview","name":"s.ToReview","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/reposense/RepoSense/pulls/128/commits","review_comments_url":"https://api.github.com/repos/reposense/RepoSense/pulls/128/comments","review_comment_url":"https://api.github.com/repos/reposense/RepoSense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reposense/RepoSense/issues/128/comments","statuses_url":"https://api.github.com/repos/reposense/RepoSense/statuses/dd283e649e7d24f08520af29f734f5efbb691f02","head":{"label":"yong24s:ExtendArgParser","ref":"ExtendArgParser","sha":"dd283e649e7d24f08520af29f734f5efbb691f02","user":{"login":"yong24s","id":2003406,"node_id":"MDQ6VXNlcjIwMDM0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2003406?v=4","gravatar_id":"","url":"https://api.github.com/users/yong24s","html_url":"https://github.com/yong24s","followers_url":"https://api.github.com/users/yong24s/followers","following_url":"https://api.github.com/users/yong24s/following{/other_user}","gists_url":"https://api.github.com/users/yong24s/gists{/gist_id}","starred_url":"https://api.github.com/users/yong24s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yong24s/subscriptions","organizations_url":"https://api.github.com/users/yong24s/orgs","repos_url":"https://api.github.com/users/yong24s/repos","events_url":"https://api.github.com/users/yong24s/events{/privacy}","received_events_url":"https://api.github.com/users/yong24s/received_events","type":"User","site_admin":false},"repo":{"id":133293230,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyOTMyMzA=","name":"RepoSense","full_name":"yong24s/RepoSense","owner":{"login":"yong24s","id":2003406,"node_id":"MDQ6VXNlcjIwMDM0MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2003406?v=4","gravatar_id":"","url":"https://api.github.com/users/yong24s","html_url":"https://github.com/yong24s","followers_url":"https://api.github.com/users/yong24s/followers","following_url":"https://api.github.com/users/yong24s/following{/other_user}","gists_url":"https://api.github.com/users/yong24s/gists{/gist_id}","starred_url":"https://api.github.com/users/yong24s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yong24s/subscriptions","organizations_url":"https://api.github.com/users/yong24s/orgs","repos_url":"https://api.github.com/users/yong24s/repos","events_url":"https://api.github.com/users/yong24s/events{/privacy}","received_events_url":"https://api.github.com/users/yong24s/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yong24s/RepoSense","description":"Product demo ","fork":true,"url":"https://api.github.com/repos/yong24s/RepoSense","forks_url":"https://api.github.com/repos/yong24s/RepoSense/forks","keys_url":"https://api.github.com/repos/yong24s/RepoSense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yong24s/RepoSense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yong24s/RepoSense/teams","hooks_url":"https://api.github.com/repos/yong24s/RepoSense/hooks","issue_events_url":"https://api.github.com/repos/yong24s/RepoSense/issues/events{/number}","events_url":"https://api.github.com/repos/yong24s/RepoSense/events","assignees_url":"https://api.github.com/repos/yong24s/RepoSense/assignees{/user}","branches_url":"https://api.github.com/repos/yong24s/RepoSense/branches{/branch}","tags_url":"https://api.github.com/repos/yong24s/RepoSense/tags","blobs_url":"https://api.github.com/repos/yong24s/RepoSense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yong24s/RepoSense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yong24s/RepoSense/git/refs{/sha}","trees_url":"https://api.github.com/repos/yong24s/RepoSense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yong24s/RepoSense/statuses/{sha}","languages_url":"https://api.github.com/repos/yong24s/RepoSense/languages","stargazers_url":"https://api.github.com/repos/yong24s/RepoSense/stargazers","contributors_url":"https://api.github.com/repos/yong24s/RepoSense/contributors","subscribers_url":"https://api.github.com/repos/yong24s/RepoSense/subscribers","subscription_url":"https://api.github.com/repos/yong24s/RepoSense/subscription","commits_url":"https://api.github.com/repos/yong24s/RepoSense/commits{/sha}","git_commits_url":"https://api.github.com/repos/yong24s/RepoSense/git/commits{/sha}","comments_url":"https://api.github.com/repos/yong24s/RepoSense/comments{/number}","issue_comment_url":"https://api.github.com/repos/yong24s/RepoSense/issues/comments{/number}","contents_url":"https://api.github.com/repos/yong24s/RepoSense/contents/{+path}","compare_url":"https://api.github.com/repos/yong24s/RepoSense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yong24s/RepoSense/merges","archive_url":"https://api.github.com/repos/yong24s/RepoSense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yong24s/RepoSense/downloads","issues_url":"https://api.github.com/repos/yong24s/RepoSense/issues{/number}","pulls_url":"https://api.github.com/repos/yong24s/RepoSense/pulls{/number}","milestones_url":"https://api.github.com/repos/yong24s/RepoSense/milestones{/number}","notifications_url":"https://api.github.com/repos/yong24s/RepoSense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yong24s/RepoSense/labels{/name}","releases_url":"https://api.github.com/repos/yong24s/RepoSense/releases{/id}","deployments_url":"https://api.github.com/repos/yong24s/RepoSense/deployments","created_at":"2018-05-14T02:13:06Z","updated_at":"2018-05-22T08:36:10Z","pushed_at":"2018-06-05T09:25:52Z","git_url":"git://github.com/yong24s/RepoSense.git","ssh_url":"[email protected]:yong24s/RepoSense.git","clone_url":"https://github.com/yong24s/RepoSense.git","svn_url":"https://github.com/yong24s/RepoSense","homepage":"https://reposense.github.io/dashboard-demo/","size":8542,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reposense:master","ref":"master","sha":"b686f101af317bdd361153af72ee0932efa338c0","user":{"login":"reposense","id":38902595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTAyNTk1","avatar_url":"https://avatars1.githubusercontent.com/u/38902595?v=4","gravatar_id":"","url":"https://api.github.com/users/reposense","html_url":"https://github.com/reposense","followers_url":"https://api.github.com/users/reposense/followers","following_url":"https://api.github.com/users/reposense/following{/other_user}","gists_url":"https://api.github.com/users/reposense/gists{/gist_id}","starred_url":"https://api.github.com/users/reposense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reposense/subscriptions","organizations_url":"https://api.github.com/users/reposense/orgs","repos_url":"https://api.github.com/users/reposense/repos","events_url":"https://api.github.com/users/reposense/events{/privacy}","received_events_url":"https://api.github.com/users/reposense/received_events","type":"Organization","site_admin":false},"repo":{"id":92653253,"node_id":"MDEwOlJlcG9zaXRvcnk5MjY1MzI1Mw==","name":"RepoSense","full_name":"reposense/RepoSense","owner":{"login":"reposense","id":38902595,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4OTAyNTk1","avatar_url":"https://avatars1.githubusercontent.com/u/38902595?v=4","gravatar_id":"","url":"https://api.github.com/users/reposense","html_url":"https://github.com/reposense","followers_url":"https://api.github.com/users/reposense/followers","following_url":"https://api.github.com/users/reposense/following{/other_user}","gists_url":"https://api.github.com/users/reposense/gists{/gist_id}","starred_url":"https://api.github.com/users/reposense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reposense/subscriptions","organizations_url":"https://api.github.com/users/reposense/orgs","repos_url":"https://api.github.com/users/reposense/repos","events_url":"https://api.github.com/users/reposense/events{/privacy}","received_events_url":"https://api.github.com/users/reposense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/reposense/RepoSense","description":"Product demo ","fork":false,"url":"https://api.github.com/repos/reposense/RepoSense","forks_url":"https://api.github.com/repos/reposense/RepoSense/forks","keys_url":"https://api.github.com/repos/reposense/RepoSense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reposense/RepoSense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reposense/RepoSense/teams","hooks_url":"https://api.github.com/repos/reposense/RepoSense/hooks","issue_events_url":"https://api.github.com/repos/reposense/RepoSense/issues/events{/number}","events_url":"https://api.github.com/repos/reposense/RepoSense/events","assignees_url":"https://api.github.com/repos/reposense/RepoSense/assignees{/user}","branches_url":"https://api.github.com/repos/reposense/RepoSense/branches{/branch}","tags_url":"https://api.github.com/repos/reposense/RepoSense/tags","blobs_url":"https://api.github.com/repos/reposense/RepoSense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reposense/RepoSense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reposense/RepoSense/git/refs{/sha}","trees_url":"https://api.github.com/repos/reposense/RepoSense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reposense/RepoSense/statuses/{sha}","languages_url":"https://api.github.com/repos/reposense/RepoSense/languages","stargazers_url":"https://api.github.com/repos/reposense/RepoSense/stargazers","contributors_url":"https://api.github.com/repos/reposense/RepoSense/contributors","subscribers_url":"https://api.github.com/repos/reposense/RepoSense/subscribers","subscription_url":"https://api.github.com/repos/reposense/RepoSense/subscription","commits_url":"https://api.github.com/repos/reposense/RepoSense/commits{/sha}","git_commits_url":"https://api.github.com/repos/reposense/RepoSense/git/commits{/sha}","comments_url":"https://api.github.com/repos/reposense/RepoSense/comments{/number}","issue_comment_url":"https://api.github.com/repos/reposense/RepoSense/issues/comments{/number}","contents_url":"https://api.github.com/repos/reposense/RepoSense/contents/{+path}","compare_url":"https://api.github.com/repos/reposense/RepoSense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reposense/RepoSense/merges","archive_url":"https://api.github.com/repos/reposense/RepoSense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reposense/RepoSense/downloads","issues_url":"https://api.github.com/repos/reposense/RepoSense/issues{/number}","pulls_url":"https://api.github.com/repos/reposense/RepoSense/pulls{/number}","milestones_url":"https://api.github.com/repos/reposense/RepoSense/milestones{/number}","notifications_url":"https://api.github.com/repos/reposense/RepoSense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reposense/RepoSense/labels{/name}","releases_url":"https://api.github.com/repos/reposense/RepoSense/releases{/id}","deployments_url":"https://api.github.com/repos/reposense/RepoSense/deployments","created_at":"2017-05-28T10:02:08Z","updated_at":"2018-06-04T06:37:11Z","pushed_at":"2018-06-05T09:25:54Z","git_url":"git://github.com/reposense/RepoSense.git","ssh_url":"[email protected]:reposense/RepoSense.git","clone_url":"https://github.com/reposense/RepoSense.git","svn_url":"https://github.com/reposense/RepoSense","homepage":"https://reposense.github.io/dashboard-demo/","size":8470,"stargazers_count":2,"watchers_count":2,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":55,"license":null,"forks":6,"open_issues":55,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reposense/RepoSense/pulls/128"},"html":{"href":"https://github.com/reposense/RepoSense/pull/128"},"issue":{"href":"https://api.github.com/repos/reposense/RepoSense/issues/128"},"comments":{"href":"https://api.github.com/repos/reposense/RepoSense/issues/128/comments"},"review_comments":{"href":"https://api.github.com/repos/reposense/RepoSense/pulls/128/comments"},"review_comment":{"href":"https://api.github.com/repos/reposense/RepoSense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reposense/RepoSense/pulls/128/commits"},"statuses":{"href":"https://api.github.com/repos/reposense/RepoSense/statuses/dd283e649e7d24f08520af29f734f5efbb691f02"}},"author_association":"CONTRIBUTOR"}}

7779610902

{"actor":{"display_login":"eugenepeh"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/Sakuten/backend/pulls/comments/207183679","pull_request_review_id":142741172,"id":207183679,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzE4MzY3OQ==","diff_hunk":"@@ -198,7 +198,7 @@ def draw_lottery(idx):\n except (OutOfHoursError, OutOfAcceptingHoursError):\n return not_acceptable_resp, 400\n \n- if index != idx:\n+ if index != lottery.index:","path":"api/routes/api.py","position":5,"original_position":5,"commit_id":"23a74c69e4efffc62756af0e2e6e3acdb80eb69e","original_commit_id":"23a74c69e4efffc62756af0e2e6e3acdb80eb69e","user":{"login":"Cj-bc","id":16875061,"node_id":"MDQ6VXNlcjE2ODc1MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/16875061?v=4","gravatar_id":"","url":"https://api.github.com/users/Cj-bc","html_url":"https://github.com/Cj-bc","followers_url":"https://api.github.com/users/Cj-bc/followers","following_url":"https://api.github.com/users/Cj-bc/following{/other_user}","gists_url":"https://api.github.com/users/Cj-bc/gists{/gist_id}","starred_url":"https://api.github.com/users/Cj-bc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cj-bc/subscriptions","organizations_url":"https://api.github.com/users/Cj-bc/orgs","repos_url":"https://api.github.com/users/Cj-bc/repos","events_url":"https://api.github.com/users/Cj-bc/events{/privacy}","received_events_url":"https://api.github.com/users/Cj-bc/received_events","type":"User","site_admin":false},"body":"ん、そうなんだけど、これ直さないとtravisが回ってくれないから...（元のままでもテスト失敗するので）\r\nなので緊急にここだけ（多分もう一箇所あったはずだけど）パッチ当てました","created_at":"2018-08-02T10:54:40Z","updated_at":"2018-08-02T10:54:40Z","html_url":"https://github.com/Sakuten/backend/pull/111#discussion_r207183679","pull_request_url":"https://api.github.com/repos/Sakuten/backend/pulls/111","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Sakuten/backend/pulls/comments/207183679"},"html":{"href":"https://github.com/Sakuten/backend/pull/111#discussion_r207183679"},"pull_request":{"href":"https://api.github.com/repos/Sakuten/backend/pulls/111"}},"in_reply_to_id":207175716},"pull_request":{"url":"https://api.github.com/repos/Sakuten/backend/pulls/111","id":205680550,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjgwNTUw","html_url":"https://github.com/Sakuten/backend/pull/111","diff_url":"https://github.com/Sakuten/backend/pull/111.diff","patch_url":"https://github.com/Sakuten/backend/pull/111.patch","issue_url":"https://api.github.com/repos/Sakuten/backend/issues/111","number":111,"state":"open","locked":false,"title":"応募期間に一分間の猶予を追加-#95","user":{"login":"Cj-bc","id":16875061,"node_id":"MDQ6VXNlcjE2ODc1MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/16875061?v=4","gravatar_id":"","url":"https://api.github.com/users/Cj-bc","html_url":"https://github.com/Cj-bc","followers_url":"https://api.github.com/users/Cj-bc/followers","following_url":"https://api.github.com/users/Cj-bc/following{/other_user}","gists_url":"https://api.github.com/users/Cj-bc/gists{/gist_id}","starred_url":"https://api.github.com/users/Cj-bc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cj-bc/subscriptions","organizations_url":"https://api.github.com/users/Cj-bc/orgs","repos_url":"https://api.github.com/users/Cj-bc/repos","events_url":"https://api.github.com/users/Cj-bc/events{/privacy}","received_events_url":"https://api.github.com/users/Cj-bc/received_events","type":"User","site_admin":false},"body":"Step 2: 変更内容\n----------------\n\n * 委員会からの要望により、応募可能期間よりも1分すぎた時点までは応募できるようにします。\n * これは、ギリギリに応募処理をしようとしていてギリギリ応募できなかった...という自体を防ぐためです。\n * 該当issue #75\n\n修正前の挙動:\n-------------\n\n * 応募可能期間ぴったりまでしか応募ができず、1秒でも過ぎると応募が不可能になる。\n\n修正後の挙動:\n-------------\n\n * 応募可能期間から1分間は応募が可能に\n * それに伴い、抽選実行期間は実質9分になります（猶予期間の1分間は抽選できないため）\n * 尚抽選期間の10分から1分が猶予期間として使われるようになるだけで、他の時間は変更されません。（委員会より）\n\nStep 3: 影響範囲\n================\n\n * 今回の変更部分**以外**に、この変更が影響を与えそうなところがあったら書いてください","created_at":"2018-08-02T09:59:30Z","updated_at":"2018-08-02T10:54:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Sakuten/backend/pulls/111/commits","review_comments_url":"https://api.github.com/repos/Sakuten/backend/pulls/111/comments","review_comment_url":"https://api.github.com/repos/Sakuten/backend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Sakuten/backend/issues/111/comments","statuses_url":"https://api.github.com/repos/Sakuten/backend/statuses/23a74c69e4efffc62756af0e2e6e3acdb80eb69e","head":{"label":"Sakuten:feature/95-1-minute-margin","ref":"feature/95-1-minute-margin","sha":"23a74c69e4efffc62756af0e2e6e3acdb80eb69e","user":{"login":"Sakuten","id":39185331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTg1MzMx","avatar_url":"https://avatars0.githubusercontent.com/u/39185331?v=4","gravatar_id":"","url":"https://api.github.com/users/Sakuten","html_url":"https://github.com/Sakuten","followers_url":"https://api.github.com/users/Sakuten/followers","following_url":"https://api.github.com/users/Sakuten/following{/other_user}","gists_url":"https://api.github.com/users/Sakuten/gists{/gist_id}","starred_url":"https://api.github.com/users/Sakuten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sakuten/subscriptions","organizations_url":"https://api.github.com/users/Sakuten/orgs","repos_url":"https://api.github.com/users/Sakuten/repos","events_url":"https://api.github.com/users/Sakuten/events{/privacy}","received_events_url":"https://api.github.com/users/Sakuten/received_events","type":"Organization","site_admin":false},"repo":{"id":133071823,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNzE4MjM=","name":"backend","full_name":"Sakuten/backend","owner":{"login":"Sakuten","id":39185331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTg1MzMx","avatar_url":"https://avatars0.githubusercontent.com/u/39185331?v=4","gravatar_id":"","url":"https://api.github.com/users/Sakuten","html_url":"https://github.com/Sakuten","followers_url":"https://api.github.com/users/Sakuten/followers","following_url":"https://api.github.com/users/Sakuten/following{/other_user}","gists_url":"https://api.github.com/users/Sakuten/gists{/gist_id}","starred_url":"https://api.github.com/users/Sakuten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sakuten/subscriptions","organizations_url":"https://api.github.com/users/Sakuten/orgs","repos_url":"https://api.github.com/users/Sakuten/repos","events_url":"https://api.github.com/users/Sakuten/events{/privacy}","received_events_url":"https://api.github.com/users/Sakuten/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sakuten/backend","description":"創作展Webシステム バックエンド","fork":false,"url":"https://api.github.com/repos/Sakuten/backend","forks_url":"https://api.github.com/repos/Sakuten/backend/forks","keys_url":"https://api.github.com/repos/Sakuten/backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sakuten/backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sakuten/backend/teams","hooks_url":"https://api.github.com/repos/Sakuten/backend/hooks","issue_events_url":"https://api.github.com/repos/Sakuten/backend/issues/events{/number}","events_url":"https://api.github.com/repos/Sakuten/backend/events","assignees_url":"https://api.github.com/repos/Sakuten/backend/assignees{/user}","branches_url":"https://api.github.com/repos/Sakuten/backend/branches{/branch}","tags_url":"https://api.github.com/repos/Sakuten/backend/tags","blobs_url":"https://api.github.com/repos/Sakuten/backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sakuten/backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sakuten/backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sakuten/backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sakuten/backend/statuses/{sha}","languages_url":"https://api.github.com/repos/Sakuten/backend/languages","stargazers_url":"https://api.github.com/repos/Sakuten/backend/stargazers","contributors_url":"https://api.github.com/repos/Sakuten/backend/contributors","subscribers_url":"https://api.github.com/repos/Sakuten/backend/subscribers","subscription_url":"https://api.github.com/repos/Sakuten/backend/subscription","commits_url":"https://api.github.com/repos/Sakuten/backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sakuten/backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sakuten/backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sakuten/backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sakuten/backend/contents/{+path}","compare_url":"https://api.github.com/repos/Sakuten/backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sakuten/backend/merges","archive_url":"https://api.github.com/repos/Sakuten/backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sakuten/backend/downloads","issues_url":"https://api.github.com/repos/Sakuten/backend/issues{/number}","pulls_url":"https://api.github.com/repos/Sakuten/backend/pulls{/number}","milestones_url":"https://api.github.com/repos/Sakuten/backend/milestones{/number}","notifications_url":"https://api.github.com/repos/Sakuten/backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sakuten/backend/labels{/name}","releases_url":"https://api.github.com/repos/Sakuten/backend/releases{/id}","deployments_url":"https://api.github.com/repos/Sakuten/backend/deployments","created_at":"2018-05-11T17:56:22Z","updated_at":"2018-08-02T02:34:21Z","pushed_at":"2018-08-02T10:10:29Z","git_url":"git://github.com/Sakuten/backend.git","ssh_url":"[email protected]:Sakuten/backend.git","clone_url":"https://github.com/Sakuten/backend.git","svn_url":"https://github.com/Sakuten/backend","homepage":"","size":412,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":25,"watchers":0,"default_branch":"develop"}},"base":{"label":"Sakuten:develop","ref":"develop","sha":"58389e343b043a690bdd50d413de8c265e16ae45","user":{"login":"Sakuten","id":39185331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTg1MzMx","avatar_url":"https://avatars0.githubusercontent.com/u/39185331?v=4","gravatar_id":"","url":"https://api.github.com/users/Sakuten","html_url":"https://github.com/Sakuten","followers_url":"https://api.github.com/users/Sakuten/followers","following_url":"https://api.github.com/users/Sakuten/following{/other_user}","gists_url":"https://api.github.com/users/Sakuten/gists{/gist_id}","starred_url":"https://api.github.com/users/Sakuten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sakuten/subscriptions","organizations_url":"https://api.github.com/users/Sakuten/orgs","repos_url":"https://api.github.com/users/Sakuten/repos","events_url":"https://api.github.com/users/Sakuten/events{/privacy}","received_events_url":"https://api.github.com/users/Sakuten/received_events","type":"Organization","site_admin":false},"repo":{"id":133071823,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNzE4MjM=","name":"backend","full_name":"Sakuten/backend","owner":{"login":"Sakuten","id":39185331,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTg1MzMx","avatar_url":"https://avatars0.githubusercontent.com/u/39185331?v=4","gravatar_id":"","url":"https://api.github.com/users/Sakuten","html_url":"https://github.com/Sakuten","followers_url":"https://api.github.com/users/Sakuten/followers","following_url":"https://api.github.com/users/Sakuten/following{/other_user}","gists_url":"https://api.github.com/users/Sakuten/gists{/gist_id}","starred_url":"https://api.github.com/users/Sakuten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sakuten/subscriptions","organizations_url":"https://api.github.com/users/Sakuten/orgs","repos_url":"https://api.github.com/users/Sakuten/repos","events_url":"https://api.github.com/users/Sakuten/events{/privacy}","received_events_url":"https://api.github.com/users/Sakuten/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Sakuten/backend","description":"創作展Webシステム バックエンド","fork":false,"url":"https://api.github.com/repos/Sakuten/backend","forks_url":"https://api.github.com/repos/Sakuten/backend/forks","keys_url":"https://api.github.com/repos/Sakuten/backend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Sakuten/backend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Sakuten/backend/teams","hooks_url":"https://api.github.com/repos/Sakuten/backend/hooks","issue_events_url":"https://api.github.com/repos/Sakuten/backend/issues/events{/number}","events_url":"https://api.github.com/repos/Sakuten/backend/events","assignees_url":"https://api.github.com/repos/Sakuten/backend/assignees{/user}","branches_url":"https://api.github.com/repos/Sakuten/backend/branches{/branch}","tags_url":"https://api.github.com/repos/Sakuten/backend/tags","blobs_url":"https://api.github.com/repos/Sakuten/backend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Sakuten/backend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Sakuten/backend/git/refs{/sha}","trees_url":"https://api.github.com/repos/Sakuten/backend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Sakuten/backend/statuses/{sha}","languages_url":"https://api.github.com/repos/Sakuten/backend/languages","stargazers_url":"https://api.github.com/repos/Sakuten/backend/stargazers","contributors_url":"https://api.github.com/repos/Sakuten/backend/contributors","subscribers_url":"https://api.github.com/repos/Sakuten/backend/subscribers","subscription_url":"https://api.github.com/repos/Sakuten/backend/subscription","commits_url":"https://api.github.com/repos/Sakuten/backend/commits{/sha}","git_commits_url":"https://api.github.com/repos/Sakuten/backend/git/commits{/sha}","comments_url":"https://api.github.com/repos/Sakuten/backend/comments{/number}","issue_comment_url":"https://api.github.com/repos/Sakuten/backend/issues/comments{/number}","contents_url":"https://api.github.com/repos/Sakuten/backend/contents/{+path}","compare_url":"https://api.github.com/repos/Sakuten/backend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Sakuten/backend/merges","archive_url":"https://api.github.com/repos/Sakuten/backend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Sakuten/backend/downloads","issues_url":"https://api.github.com/repos/Sakuten/backend/issues{/number}","pulls_url":"https://api.github.com/repos/Sakuten/backend/pulls{/number}","milestones_url":"https://api.github.com/repos/Sakuten/backend/milestones{/number}","notifications_url":"https://api.github.com/repos/Sakuten/backend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Sakuten/backend/labels{/name}","releases_url":"https://api.github.com/repos/Sakuten/backend/releases{/id}","deployments_url":"https://api.github.com/repos/Sakuten/backend/deployments","created_at":"2018-05-11T17:56:22Z","updated_at":"2018-08-02T02:34:21Z","pushed_at":"2018-08-02T10:10:29Z","git_url":"git://github.com/Sakuten/backend.git","ssh_url":"[email protected]:Sakuten/backend.git","clone_url":"https://github.com/Sakuten/backend.git","svn_url":"https://github.com/Sakuten/backend","homepage":"","size":412,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":25,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/Sakuten/backend/pulls/111"},"html":{"href":"https://github.com/Sakuten/backend/pull/111"},"issue":{"href":"https://api.github.com/repos/Sakuten/backend/issues/111"},"comments":{"href":"https://api.github.com/repos/Sakuten/backend/issues/111/comments"},"review_comments":{"href":"https://api.github.com/repos/Sakuten/backend/pulls/111/comments"},"review_comment":{"href":"https://api.github.com/repos/Sakuten/backend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Sakuten/backend/pulls/111/commits"},"statuses":{"href":"https://api.github.com/repos/Sakuten/backend/statuses/23a74c69e4efffc62756af0e2e6e3acdb80eb69e"}},"author_association":"MEMBER"}}

8055928032

{"actor":{"display_login":"Cj-bc"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/inspec/inspec/pulls/comments/193561466","pull_request_review_id":126557659,"id":193561466,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzU2MTQ2Ng==","diff_hunk":"@@ -0,0 +1,117 @@\n+---\n+title: About the aws_flow_log Resource\n+platform: aws\n+---\n+\n+# aws\\_flow\\_log\n+\n+Use the `aws_flow_log` InSpec audit resource to test properties of a single Flow Log.\n+\n+## Syntax\n+\n+ describe aws_flow_log('fl-9c718cf5') do\n+ it { should exist }\n+ end\n+\n+## Resource Parameters\n+### flow_log_id\n+\n+This resource accepts a single parameter or other search terms. You may pass it as a string, or as the value in a hash:\n+\n+ describe aws_flow_log('fl-9c718cf5') do\n+ it { should exist }\n+ end\n+\n+ describe aws_flow_log(flow_log_id: 'fl-8905f8e0') do\n+ it { should exist }\n+ end\n+\n+### subnet_id\n+\n+To search for a flow log by the associated subnet id:\n+\n+ describe aws_flow_log(subnet_id: 'subnet-c6a4319c') do\n+ it { should exist }\n+ end\n+\n+### vpc_id\n+\n+To search for a flow log by the associated vpc id:\n+\n+ describe aws_flow_log(vpc_id: 'vpc-96cabaef') do\n+ it { should exist }\n+ end\n+\n+## Properties\n+### flow_log_id\n+\n+The `flow_log_id` property tests the name of the flow log.\n+\n+ describe aws_flow_log(subnet_id: 'subnet-c6a4319c') do\n+ its('flow_log_id') { should cmp 'fl-9c718cf5' }\n+ end\n+\n+### log_group_name\n+\n+The `log_group_name` property tests the name of the associated log group.\n+\n+ describe aws_flow_log('fl-9c718cf5') do\n+ its('log_group_name') { should cmp 'test_log_group' }\n+ end\n+\n+### resource_id\n+\n+The `resource_id` property tests the id of the associated VPC, subnet, or network interface.\n+ describe aws_flow_log('fl-9c718cf5') do\n+ its('resource_id') { should cmp 'subnet-c6a4319c' }\n+ end\n+\n+### resource_type\n+\n+The `resource_type` property tests the type of resource the Flow Log is attached to.\n+The property will return `eni`, `subnet`, or `vpc`.\n+\n+ describe aws_flow_log('fl-9c718cf5') do\n+ its('resource_type') { should cmp 'subnet' }\n+ end\n+\n+## Matchers\n+\n+For a full list of available matchers, please visit our [matchers page](https://www.inspec.io/docs/reference/matchers/).\n+\n+### exist\n+\n+Indicates that the Flow Log provided was found. Use `should_not` to test for Flow Logs that should not exist.\n+\n+ describe aws_flow_log('should-be-there') do\n+ it { should exist }\n+ end\n+\n+ describe aws_flow_log('should-not-be-there') do\n+ it { should_not exist }\n+ end\n+\n+### be_attached_to_eni","path":"docs/resources/aws_flow_log.md.erb","position":94,"original_position":94,"commit_id":"05c645987d39cc4338c9d7d92f2cbfbe1d7f09b0","original_commit_id":"05c645987d39cc4338c9d7d92f2cbfbe1d7f09b0","user":{"login":"jerryaldrichiii","id":13783510,"node_id":"MDQ6VXNlcjEzNzgzNTEw","avatar_url":"https://avatars2.githubusercontent.com/u/13783510?v=4","gravatar_id":"","url":"https://api.github.com/users/jerryaldrichiii","html_url":"https://github.com/jerryaldrichiii","followers_url":"https://api.github.com/users/jerryaldrichiii/followers","following_url":"https://api.github.com/users/jerryaldrichiii/following{/other_user}","gists_url":"https://api.github.com/users/jerryaldrichiii/gists{/gist_id}","starred_url":"https://api.github.com/users/jerryaldrichiii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jerryaldrichiii/subscriptions","organizations_url":"https://api.github.com/users/jerryaldrichiii/orgs","repos_url":"https://api.github.com/users/jerryaldrichiii/repos","events_url":"https://api.github.com/users/jerryaldrichiii/events{/privacy}","received_events_url":"https://api.github.com/users/jerryaldrichiii/received_events","type":"User","site_admin":false},"body":"Need `\\_` here since it's a heading.","created_at":"2018-06-06T21:14:37Z","updated_at":"2018-06-06T21:18:25Z","html_url":"https://github.com/inspec/inspec/pull/2906#discussion_r193561466","pull_request_url":"https://api.github.com/repos/inspec/inspec/pulls/2906","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/inspec/inspec/pulls/comments/193561466"},"html":{"href":"https://github.com/inspec/inspec/pull/2906#discussion_r193561466"},"pull_request":{"href":"https://api.github.com/repos/inspec/inspec/pulls/2906"}}},"pull_request":{"url":"https://api.github.com/repos/inspec/inspec/pulls/2906","id":178884254,"node_id":"MDExOlB1bGxSZXF1ZXN0MTc4ODg0MjU0","html_url":"https://github.com/inspec/inspec/pull/2906","diff_url":"https://github.com/inspec/inspec/pull/2906.diff","patch_url":"https://github.com/inspec/inspec/pull/2906.patch","issue_url":"https://api.github.com/repos/inspec/inspec/issues/2906","number":2906,"state":"open","locked":false,"title":"Adds a aws_flow_log resource with unit and integration testing.","user":{"login":"miah","id":49856,"node_id":"MDQ6VXNlcjQ5ODU2","avatar_url":"https://avatars1.githubusercontent.com/u/49856?v=4","gravatar_id":"","url":"https://api.github.com/users/miah","html_url":"https://github.com/miah","followers_url":"https://api.github.com/users/miah/followers","following_url":"https://api.github.com/users/miah/following{/other_user}","gists_url":"https://api.github.com/users/miah/gists{/gist_id}","starred_url":"https://api.github.com/users/miah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miah/subscriptions","organizations_url":"https://api.github.com/users/miah/orgs","repos_url":"https://api.github.com/users/miah/repos","events_url":"https://api.github.com/users/miah/events{/privacy}","received_events_url":"https://api.github.com/users/miah/received_events","type":"User","site_admin":false},"body":"The aws_flow_log resource can search by subnet, vpc, or flow log ID.\r\nIt can match on name, resource_id, and log_group_name\r\n\r\nFixes #2581\r\n\r\nSigned-off-by: Miah Johnson <[email protected]>","created_at":"2018-04-02T17:22:24Z","updated_at":"2018-06-06T21:18:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb78c55de0dc83d10f060259786d35df3f6dbc27","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":832497816,"node_id":"MDU6TGFiZWw4MzI0OTc4MTY=","url":"https://api.github.com/repos/inspec/inspec/labels/Platform:%20AWS","name":"Platform: AWS","color":"f9d0c4","default":false},{"id":669500225,"node_id":"MDU6TGFiZWw2Njk1MDAyMjU=","url":"https://api.github.com/repos/inspec/inspec/labels/Type:%20New%20Resource","name":"Type: New Resource","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/inspec/inspec/pulls/2906/commits","review_comments_url":"https://api.github.com/repos/inspec/inspec/pulls/2906/comments","review_comment_url":"https://api.github.com/repos/inspec/inspec/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspec/inspec/issues/2906/comments","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/05c645987d39cc4338c9d7d92f2cbfbe1d7f09b0","head":{"label":"inspec:miah/2581","ref":"miah/2581","sha":"05c645987d39cc4338c9d7d92f2cbfbe1d7f09b0","user":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU3MTU0MQ==","name":"inspec","full_name":"inspec/inspec","owner":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspec/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/inspec/inspec","forks_url":"https://api.github.com/repos/inspec/inspec/forks","keys_url":"https://api.github.com/repos/inspec/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspec/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspec/inspec/teams","hooks_url":"https://api.github.com/repos/inspec/inspec/hooks","issue_events_url":"https://api.github.com/repos/inspec/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/inspec/inspec/events","assignees_url":"https://api.github.com/repos/inspec/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/inspec/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/inspec/inspec/tags","blobs_url":"https://api.github.com/repos/inspec/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspec/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspec/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspec/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/inspec/inspec/languages","stargazers_url":"https://api.github.com/repos/inspec/inspec/stargazers","contributors_url":"https://api.github.com/repos/inspec/inspec/contributors","subscribers_url":"https://api.github.com/repos/inspec/inspec/subscribers","subscription_url":"https://api.github.com/repos/inspec/inspec/subscription","commits_url":"https://api.github.com/repos/inspec/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspec/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspec/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspec/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspec/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/inspec/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspec/inspec/merges","archive_url":"https://api.github.com/repos/inspec/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspec/inspec/downloads","issues_url":"https://api.github.com/repos/inspec/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/inspec/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/inspec/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/inspec/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspec/inspec/labels{/name}","releases_url":"https://api.github.com/repos/inspec/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/inspec/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2018-06-06T18:15:42Z","pushed_at":"2018-06-06T21:03:57Z","git_url":"git://github.com/inspec/inspec.git","ssh_url":"[email protected]:inspec/inspec.git","clone_url":"https://github.com/inspec/inspec.git","svn_url":"https://github.com/inspec/inspec","homepage":"http://inspec.io","size":13743,"stargazers_count":1234,"watchers_count":1234,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":343,"mirror_url":null,"archived":false,"open_issues_count":505,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":343,"open_issues":505,"watchers":1234,"default_branch":"master"}},"base":{"label":"inspec:master","ref":"master","sha":"ce384937ec89fbdcc9253c8708e830d4bd4126b4","user":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"repo":{"id":41571541,"node_id":"MDEwOlJlcG9zaXRvcnk0MTU3MTU0MQ==","name":"inspec","full_name":"inspec/inspec","owner":{"login":"inspec","id":39202509,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjAyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/39202509?v=4","gravatar_id":"","url":"https://api.github.com/users/inspec","html_url":"https://github.com/inspec","followers_url":"https://api.github.com/users/inspec/followers","following_url":"https://api.github.com/users/inspec/following{/other_user}","gists_url":"https://api.github.com/users/inspec/gists{/gist_id}","starred_url":"https://api.github.com/users/inspec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspec/subscriptions","organizations_url":"https://api.github.com/users/inspec/orgs","repos_url":"https://api.github.com/users/inspec/repos","events_url":"https://api.github.com/users/inspec/events{/privacy}","received_events_url":"https://api.github.com/users/inspec/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspec/inspec","description":"InSpec: Auditing and Testing Framework","fork":false,"url":"https://api.github.com/repos/inspec/inspec","forks_url":"https://api.github.com/repos/inspec/inspec/forks","keys_url":"https://api.github.com/repos/inspec/inspec/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspec/inspec/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspec/inspec/teams","hooks_url":"https://api.github.com/repos/inspec/inspec/hooks","issue_events_url":"https://api.github.com/repos/inspec/inspec/issues/events{/number}","events_url":"https://api.github.com/repos/inspec/inspec/events","assignees_url":"https://api.github.com/repos/inspec/inspec/assignees{/user}","branches_url":"https://api.github.com/repos/inspec/inspec/branches{/branch}","tags_url":"https://api.github.com/repos/inspec/inspec/tags","blobs_url":"https://api.github.com/repos/inspec/inspec/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspec/inspec/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspec/inspec/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspec/inspec/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspec/inspec/statuses/{sha}","languages_url":"https://api.github.com/repos/inspec/inspec/languages","stargazers_url":"https://api.github.com/repos/inspec/inspec/stargazers","contributors_url":"https://api.github.com/repos/inspec/inspec/contributors","subscribers_url":"https://api.github.com/repos/inspec/inspec/subscribers","subscription_url":"https://api.github.com/repos/inspec/inspec/subscription","commits_url":"https://api.github.com/repos/inspec/inspec/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspec/inspec/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspec/inspec/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspec/inspec/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspec/inspec/contents/{+path}","compare_url":"https://api.github.com/repos/inspec/inspec/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspec/inspec/merges","archive_url":"https://api.github.com/repos/inspec/inspec/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspec/inspec/downloads","issues_url":"https://api.github.com/repos/inspec/inspec/issues{/number}","pulls_url":"https://api.github.com/repos/inspec/inspec/pulls{/number}","milestones_url":"https://api.github.com/repos/inspec/inspec/milestones{/number}","notifications_url":"https://api.github.com/repos/inspec/inspec/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspec/inspec/labels{/name}","releases_url":"https://api.github.com/repos/inspec/inspec/releases{/id}","deployments_url":"https://api.github.com/repos/inspec/inspec/deployments","created_at":"2015-08-28T22:16:01Z","updated_at":"2018-06-06T18:15:42Z","pushed_at":"2018-06-06T21:03:57Z","git_url":"git://github.com/inspec/inspec.git","ssh_url":"[email protected]:inspec/inspec.git","clone_url":"https://github.com/inspec/inspec.git","svn_url":"https://github.com/inspec/inspec","homepage":"http://inspec.io","size":13743,"stargazers_count":1234,"watchers_count":1234,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":343,"mirror_url":null,"archived":false,"open_issues_count":505,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":343,"open_issues":505,"watchers":1234,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspec/inspec/pulls/2906"},"html":{"href":"https://github.com/inspec/inspec/pull/2906"},"issue":{"href":"https://api.github.com/repos/inspec/inspec/issues/2906"},"comments":{"href":"https://api.github.com/repos/inspec/inspec/issues/2906/comments"},"review_comments":{"href":"https://api.github.com/repos/inspec/inspec/pulls/2906/comments"},"review_comment":{"href":"https://api.github.com/repos/inspec/inspec/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspec/inspec/pulls/2906/commits"},"statuses":{"href":"https://api.github.com/repos/inspec/inspec/statuses/05c645987d39cc4338c9d7d92f2cbfbe1d7f09b0"}},"author_association":"CONTRIBUTOR"}}

7787138882

{"actor":{"display_login":"jerryaldrichiii"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/linterhub/catalog/pulls/comments/213253492","pull_request_review_id":150049437,"id":213253492,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI1MzQ5Mg==","diff_hunk":"@@ -0,0 +1,16 @@\n+'use strict';\n+\n+// Set global shared core\n+const lhcore = require('./script/gulp/index.js');\n+global.lhcore = lhcore;\n+\n+// External modules as aliases\n+const gulp = require('gulp');\n+const hubRegistry = require('gulp-hub');","path":"gulpfile.js","position":9,"original_position":9,"commit_id":"17e305e5a03db15b2b6efc8fdec256fe364ee2c6","original_commit_id":"17e305e5a03db15b2b6efc8fdec256fe364ee2c6","user":{"login":"Arcle1","id":39379625,"node_id":"MDQ6VXNlcjM5Mzc5NjI1","avatar_url":"https://avatars1.githubusercontent.com/u/39379625?v=4","gravatar_id":"","url":"https://api.github.com/users/Arcle1","html_url":"https://github.com/Arcle1","followers_url":"https://api.github.com/users/Arcle1/followers","following_url":"https://api.github.com/users/Arcle1/following{/other_user}","gists_url":"https://api.github.com/users/Arcle1/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcle1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcle1/subscriptions","organizations_url":"https://api.github.com/users/Arcle1/orgs","repos_url":"https://api.github.com/users/Arcle1/repos","events_url":"https://api.github.com/users/Arcle1/events{/privacy}","received_events_url":"https://api.github.com/users/Arcle1/received_events","type":"User","site_admin":false},"body":"@svoboda-rabstvo we have hubRegistry in `schema`. Do you think we should rename it here?","created_at":"2018-08-28T10:01:25Z","updated_at":"2018-08-28T10:01:25Z","html_url":"https://github.com/linterhub/catalog/pull/5#discussion_r213253492","pull_request_url":"https://api.github.com/repos/linterhub/catalog/pulls/5","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/linterhub/catalog/pulls/comments/213253492"},"html":{"href":"https://github.com/linterhub/catalog/pull/5#discussion_r213253492"},"pull_request":{"href":"https://api.github.com/repos/linterhub/catalog/pulls/5"}},"in_reply_to_id":213250946},"pull_request":{"url":"https://api.github.com/repos/linterhub/catalog/pulls/5","id":210477685,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDc3Njg1","html_url":"https://github.com/linterhub/catalog/pull/5","diff_url":"https://github.com/linterhub/catalog/pull/5.diff","patch_url":"https://github.com/linterhub/catalog/pull/5.patch","issue_url":"https://api.github.com/repos/linterhub/catalog/issues/5","number":5,"state":"open","locked":false,"title":"feat: add list of linters from npm","user":{"login":"Arcle1","id":39379625,"node_id":"MDQ6VXNlcjM5Mzc5NjI1","avatar_url":"https://avatars1.githubusercontent.com/u/39379625?v=4","gravatar_id":"","url":"https://api.github.com/users/Arcle1","html_url":"https://github.com/Arcle1","followers_url":"https://api.github.com/users/Arcle1/followers","following_url":"https://api.github.com/users/Arcle1/following{/other_user}","gists_url":"https://api.github.com/users/Arcle1/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcle1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcle1/subscriptions","organizations_url":"https://api.github.com/users/Arcle1/orgs","repos_url":"https://api.github.com/users/Arcle1/repos","events_url":"https://api.github.com/users/Arcle1/events{/privacy}","received_events_url":"https://api.github.com/users/Arcle1/received_events","type":"User","site_admin":false},"body":"- Add list of linters from npm\r\n\r\nCloses #2 ","created_at":"2018-08-23T14:56:53Z","updated_at":"2018-08-28T10:01:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"365823aedc79d2c1296a5240880e61db64e0ac23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linterhub/catalog/pulls/5/commits","review_comments_url":"https://api.github.com/repos/linterhub/catalog/pulls/5/comments","review_comment_url":"https://api.github.com/repos/linterhub/catalog/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linterhub/catalog/issues/5/comments","statuses_url":"https://api.github.com/repos/linterhub/catalog/statuses/17e305e5a03db15b2b6efc8fdec256fe364ee2c6","head":{"label":"Arcle1:feat/linter-npm","ref":"feat/linter-npm","sha":"17e305e5a03db15b2b6efc8fdec256fe364ee2c6","user":{"login":"Arcle1","id":39379625,"node_id":"MDQ6VXNlcjM5Mzc5NjI1","avatar_url":"https://avatars1.githubusercontent.com/u/39379625?v=4","gravatar_id":"","url":"https://api.github.com/users/Arcle1","html_url":"https://github.com/Arcle1","followers_url":"https://api.github.com/users/Arcle1/followers","following_url":"https://api.github.com/users/Arcle1/following{/other_user}","gists_url":"https://api.github.com/users/Arcle1/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcle1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcle1/subscriptions","organizations_url":"https://api.github.com/users/Arcle1/orgs","repos_url":"https://api.github.com/users/Arcle1/repos","events_url":"https://api.github.com/users/Arcle1/events{/privacy}","received_events_url":"https://api.github.com/users/Arcle1/received_events","type":"User","site_admin":false},"repo":{"id":145864404,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NjQ0MDQ=","name":"catalog","full_name":"Arcle1/catalog","owner":{"login":"Arcle1","id":39379625,"node_id":"MDQ6VXNlcjM5Mzc5NjI1","avatar_url":"https://avatars1.githubusercontent.com/u/39379625?v=4","gravatar_id":"","url":"https://api.github.com/users/Arcle1","html_url":"https://github.com/Arcle1","followers_url":"https://api.github.com/users/Arcle1/followers","following_url":"https://api.github.com/users/Arcle1/following{/other_user}","gists_url":"https://api.github.com/users/Arcle1/gists{/gist_id}","starred_url":"https://api.github.com/users/Arcle1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arcle1/subscriptions","organizations_url":"https://api.github.com/users/Arcle1/orgs","repos_url":"https://api.github.com/users/Arcle1/repos","events_url":"https://api.github.com/users/Arcle1/events{/privacy}","received_events_url":"https://api.github.com/users/Arcle1/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Arcle1/catalog","description":null,"fork":true,"url":"https://api.github.com/repos/Arcle1/catalog","forks_url":"https://api.github.com/repos/Arcle1/catalog/forks","keys_url":"https://api.github.com/repos/Arcle1/catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Arcle1/catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Arcle1/catalog/teams","hooks_url":"https://api.github.com/repos/Arcle1/catalog/hooks","issue_events_url":"https://api.github.com/repos/Arcle1/catalog/issues/events{/number}","events_url":"https://api.github.com/repos/Arcle1/catalog/events","assignees_url":"https://api.github.com/repos/Arcle1/catalog/assignees{/user}","branches_url":"https://api.github.com/repos/Arcle1/catalog/branches{/branch}","tags_url":"https://api.github.com/repos/Arcle1/catalog/tags","blobs_url":"https://api.github.com/repos/Arcle1/catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Arcle1/catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Arcle1/catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/Arcle1/catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Arcle1/catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/Arcle1/catalog/languages","stargazers_url":"https://api.github.com/repos/Arcle1/catalog/stargazers","contributors_url":"https://api.github.com/repos/Arcle1/catalog/contributors","subscribers_url":"https://api.github.com/repos/Arcle1/catalog/subscribers","subscription_url":"https://api.github.com/repos/Arcle1/catalog/subscription","commits_url":"https://api.github.com/repos/Arcle1/catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/Arcle1/catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/Arcle1/catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/Arcle1/catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/Arcle1/catalog/contents/{+path}","compare_url":"https://api.github.com/repos/Arcle1/catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Arcle1/catalog/merges","archive_url":"https://api.github.com/repos/Arcle1/catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Arcle1/catalog/downloads","issues_url":"https://api.github.com/repos/Arcle1/catalog/issues{/number}","pulls_url":"https://api.github.com/repos/Arcle1/catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/Arcle1/catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/Arcle1/catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Arcle1/catalog/labels{/name}","releases_url":"https://api.github.com/repos/Arcle1/catalog/releases{/id}","deployments_url":"https://api.github.com/repos/Arcle1/catalog/deployments","created_at":"2018-08-23T14:22:36Z","updated_at":"2018-08-23T14:22:38Z","pushed_at":"2018-08-28T09:49:52Z","git_url":"git://github.com/Arcle1/catalog.git","ssh_url":"[email protected]:Arcle1/catalog.git","clone_url":"https://github.com/Arcle1/catalog.git","svn_url":"https://github.com/Arcle1/catalog","homepage":null,"size":2,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"linterhub:temporary","ref":"temporary","sha":"018127b95fd56b0b331dbac401430b8bd7e95b0d","user":{"login":"linterhub","id":39357698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU3Njk4","avatar_url":"https://avatars3.githubusercontent.com/u/39357698?v=4","gravatar_id":"","url":"https://api.github.com/users/linterhub","html_url":"https://github.com/linterhub","followers_url":"https://api.github.com/users/linterhub/followers","following_url":"https://api.github.com/users/linterhub/following{/other_user}","gists_url":"https://api.github.com/users/linterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/linterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linterhub/subscriptions","organizations_url":"https://api.github.com/users/linterhub/orgs","repos_url":"https://api.github.com/users/linterhub/repos","events_url":"https://api.github.com/users/linterhub/events{/privacy}","received_events_url":"https://api.github.com/users/linterhub/received_events","type":"Organization","site_admin":false},"repo":{"id":143592453,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM1OTI0NTM=","name":"catalog","full_name":"linterhub/catalog","owner":{"login":"linterhub","id":39357698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MzU3Njk4","avatar_url":"https://avatars3.githubusercontent.com/u/39357698?v=4","gravatar_id":"","url":"https://api.github.com/users/linterhub","html_url":"https://github.com/linterhub","followers_url":"https://api.github.com/users/linterhub/followers","following_url":"https://api.github.com/users/linterhub/following{/other_user}","gists_url":"https://api.github.com/users/linterhub/gists{/gist_id}","starred_url":"https://api.github.com/users/linterhub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linterhub/subscriptions","organizations_url":"https://api.github.com/users/linterhub/orgs","repos_url":"https://api.github.com/users/linterhub/repos","events_url":"https://api.github.com/users/linterhub/events{/privacy}","received_events_url":"https://api.github.com/users/linterhub/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linterhub/catalog","description":null,"fork":false,"url":"https://api.github.com/repos/linterhub/catalog","forks_url":"https://api.github.com/repos/linterhub/catalog/forks","keys_url":"https://api.github.com/repos/linterhub/catalog/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linterhub/catalog/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linterhub/catalog/teams","hooks_url":"https://api.github.com/repos/linterhub/catalog/hooks","issue_events_url":"https://api.github.com/repos/linterhub/catalog/issues/events{/number}","events_url":"https://api.github.com/repos/linterhub/catalog/events","assignees_url":"https://api.github.com/repos/linterhub/catalog/assignees{/user}","branches_url":"https://api.github.com/repos/linterhub/catalog/branches{/branch}","tags_url":"https://api.github.com/repos/linterhub/catalog/tags","blobs_url":"https://api.github.com/repos/linterhub/catalog/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linterhub/catalog/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linterhub/catalog/git/refs{/sha}","trees_url":"https://api.github.com/repos/linterhub/catalog/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linterhub/catalog/statuses/{sha}","languages_url":"https://api.github.com/repos/linterhub/catalog/languages","stargazers_url":"https://api.github.com/repos/linterhub/catalog/stargazers","contributors_url":"https://api.github.com/repos/linterhub/catalog/contributors","subscribers_url":"https://api.github.com/repos/linterhub/catalog/subscribers","subscription_url":"https://api.github.com/repos/linterhub/catalog/subscription","commits_url":"https://api.github.com/repos/linterhub/catalog/commits{/sha}","git_commits_url":"https://api.github.com/repos/linterhub/catalog/git/commits{/sha}","comments_url":"https://api.github.com/repos/linterhub/catalog/comments{/number}","issue_comment_url":"https://api.github.com/repos/linterhub/catalog/issues/comments{/number}","contents_url":"https://api.github.com/repos/linterhub/catalog/contents/{+path}","compare_url":"https://api.github.com/repos/linterhub/catalog/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linterhub/catalog/merges","archive_url":"https://api.github.com/repos/linterhub/catalog/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linterhub/catalog/downloads","issues_url":"https://api.github.com/repos/linterhub/catalog/issues{/number}","pulls_url":"https://api.github.com/repos/linterhub/catalog/pulls{/number}","milestones_url":"https://api.github.com/repos/linterhub/catalog/milestones{/number}","notifications_url":"https://api.github.com/repos/linterhub/catalog/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linterhub/catalog/labels{/name}","releases_url":"https://api.github.com/repos/linterhub/catalog/releases{/id}","deployments_url":"https://api.github.com/repos/linterhub/catalog/deployments","created_at":"2018-08-05T07:28:27Z","updated_at":"2018-08-23T14:22:25Z","pushed_at":"2018-08-28T09:49:53Z","git_url":"git://github.com/linterhub/catalog.git","ssh_url":"[email protected]:linterhub/catalog.git","clone_url":"https://github.com/linterhub/catalog.git","svn_url":"https://github.com/linterhub/catalog","homepage":null,"size":0,"stargazers_count":2,"watchers_count":2,"language":null,"has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":2,"open_issues":6,"watchers":2,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/linterhub/catalog/pulls/5"},"html":{"href":"https://github.com/linterhub/catalog/pull/5"},"issue":{"href":"https://api.github.com/repos/linterhub/catalog/issues/5"},"comments":{"href":"https://api.github.com/repos/linterhub/catalog/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/linterhub/catalog/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/linterhub/catalog/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linterhub/catalog/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/linterhub/catalog/statuses/17e305e5a03db15b2b6efc8fdec256fe364ee2c6"}},"author_association":"COLLABORATOR"}}

8177227366

{"actor":{"display_login":"Arcle1"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments/221459279","pull_request_review_id":160114461,"id":221459279,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTQ1OTI3OQ==","diff_hunk":"@@ -1158,35 +1163,46 @@ void CPropTypesColor::DrawColorListItem( DRAWITEMSTRUCT* pDis )\n \t}\n //\treturn;\n \n+\tconst int colorSampleWidth = DpiScaleX(12);\n+\tconst int scaled1 = DpiScaleX(1);\n+\tconst int scaled2 = DpiScaleX(2);\n+\tconst int scaled3 = DpiScaleX(3);\n \n \t// 2002/11/02 Moca 比較方法変更\n //\tif( 0 != strcmp( \"カーソル行アンダーライン\", pColorInfo->m_szName ) )\n \tif ( 0 == (g_ColorAttributeArr[pColorInfo->m_nColorIdx].fAttribute & COLOR_ATTRIB_NO_BACK) )\t// 2006.12.18 ryoji フラグ利用で簡素化\n \t{\n \t\t/* 背景色 見本矩形 */\n \t\trc1 = pDis->rcItem;\n-\t\trc1.left = rc1.right - 13;\n-\t\trc1.top += 2;\n-\t\trc1.right = rc1.left + 12;\n-\t\trc1.bottom -= 2;\n+\t\trc1.left = rc1.right - (colorSampleWidth + scaled1);\n+\t\trc1.top += scaled2;\n+\t\trc1.right = rc1.left + colorSampleWidth;\n+\t\trc1.bottom -= scaled2;\n+\n+\t\tm_bgColorSampleLeft = rc1.left;\n+\t\tm_bgColorSampleRight = rc1.right;\n \n \t\tgr.SetBrushColor( pColorInfo->m_sColorAttr.m_cBACK );\n \t\tgr.SetPen( cRim );\n-\t\t::RoundRect( pDis->hDC, rc1.left, rc1.top, rc1.right, rc1.bottom , 3, 3 );\n+\t\t::RoundRect( pDis->hDC, rc1.left, rc1.top, rc1.right, rc1.bottom , scaled3, scaled3 );\n \t}\n \n \n \tif( 0 == (g_ColorAttributeArr[pColorInfo->m_nColorIdx].fAttribute & COLOR_ATTRIB_NO_TEXT) )\n \t{\n \t\t/* 前景色 見本矩形 */\n \t\trc1 = pDis->rcItem;\n-\t\trc1.left = rc1.right - 27;\n-\t\trc1.top += 2;\n-\t\trc1.right = rc1.left + 12;\n-\t\trc1.bottom -= 2;\n+\t\trc1.left = rc1.right - (2 * colorSampleWidth + scaled3);\n+\t\trc1.top += scaled2;\n+\t\trc1.right = rc1.left + colorSampleWidth;\n+\t\trc1.bottom -= scaled2;\n+\n+\t\tm_fgColorSampleLeft = rc1.left;\n+\t\tm_fgColorSampleRight = rc1.right;","path":"sakura_core/typeprop/CPropTypesColor.cpp","position":87,"original_position":87,"commit_id":"dd0b317758d8c022f2dc691233f4d15951bbe122","original_commit_id":"dd0b317758d8c022f2dc691233f4d15951bbe122","user":{"login":"berryzplus","id":3253151,"node_id":"MDQ6VXNlcjMyNTMxNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/3253151?v=4","gravatar_id":"","url":"https://api.github.com/users/berryzplus","html_url":"https://github.com/berryzplus","followers_url":"https://api.github.com/users/berryzplus/followers","following_url":"https://api.github.com/users/berryzplus/following{/other_user}","gists_url":"https://api.github.com/users/berryzplus/gists{/gist_id}","starred_url":"https://api.github.com/users/berryzplus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/berryzplus/subscriptions","organizations_url":"https://api.github.com/users/berryzplus/orgs","repos_url":"https://api.github.com/users/berryzplus/repos","events_url":"https://api.github.com/users/berryzplus/events{/privacy}","received_events_url":"https://api.github.com/users/berryzplus/received_events","type":"User","site_admin":false},"body":"一点懸念点があって、この新規追加の変数に値を設定しているのがここ（描画）だけで、\r\n描画される前にクリックされる可能性はないと思うんですけど、\r\n変数の初期化がないのが少し気になりました。","created_at":"2018-09-30T13:25:51Z","updated_at":"2018-09-30T13:27:33Z","html_url":"https://github.com/sakura-editor/sakura/pull/499#discussion_r221459279","pull_request_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/499","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments/221459279"},"html":{"href":"https://github.com/sakura-editor/sakura/pull/499#discussion_r221459279"},"pull_request":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/499"}}},"pull_request":{"url":"https://api.github.com/repos/sakura-editor/sakura/pulls/499","id":219201276,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjAxMjc2","html_url":"https://github.com/sakura-editor/sakura/pull/499","diff_url":"https://github.com/sakura-editor/sakura/pull/499.diff","patch_url":"https://github.com/sakura-editor/sakura/pull/499.patch","issue_url":"https://api.github.com/repos/sakura-editor/sakura/issues/499","number":499,"state":"open","locked":false,"title":"タイプ別設定画面のカラータブの色指定リストの背景色と前景色の色見本矩形の描画処理をDPIに合わせるように変更","user":{"login":"beru","id":1131125,"node_id":"MDQ6VXNlcjExMzExMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1131125?v=4","gravatar_id":"","url":"https://api.github.com/users/beru","html_url":"https://github.com/beru","followers_url":"https://api.github.com/users/beru/followers","following_url":"https://api.github.com/users/beru/following{/other_user}","gists_url":"https://api.github.com/users/beru/gists{/gist_id}","starred_url":"https://api.github.com/users/beru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beru/subscriptions","organizations_url":"https://api.github.com/users/beru/orgs","repos_url":"https://api.github.com/users/beru/repos","events_url":"https://api.github.com/users/beru/events{/privacy}","received_events_url":"https://api.github.com/users/beru/received_events","type":"User","site_admin":false},"body":"高DPIだと色指定リストの色見本矩形の横幅が狭くて選択しにくかったのを改善しました。\r\n左端のチェック描画には手を入れていません。そこは個人的に困っていないので。\r\n\r\nスクリーンショットを貼り付けます。\r\n\r\n| ディスプレイ設定 | 変更前 (4055e4f63ede85cea8c767abed9812e877ac1b9d) | 変更後 (dd0b317758d8c022f2dc691233f4d15951bbe122) |\r\n|---|---|---|\r\n| 100% |  |  |\r\n| 150% |  |  |\r\n| 200% |  |  |\r\n\r\n","created_at":"2018-09-30T11:51:38Z","updated_at":"2018-09-30T13:27:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f9941e2f3e17477d01cab90f5de6117ce1a0569","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/499/commits","review_comments_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/499/comments","review_comment_url":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/issues/499/comments","statuses_url":"https://api.github.com/repos/sakura-editor/sakura/statuses/dd0b317758d8c022f2dc691233f4d15951bbe122","head":{"label":"beru:HighDPI_PropTypesColor","ref":"HighDPI_PropTypesColor","sha":"dd0b317758d8c022f2dc691233f4d15951bbe122","user":{"login":"beru","id":1131125,"node_id":"MDQ6VXNlcjExMzExMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1131125?v=4","gravatar_id":"","url":"https://api.github.com/users/beru","html_url":"https://github.com/beru","followers_url":"https://api.github.com/users/beru/followers","following_url":"https://api.github.com/users/beru/following{/other_user}","gists_url":"https://api.github.com/users/beru/gists{/gist_id}","starred_url":"https://api.github.com/users/beru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beru/subscriptions","organizations_url":"https://api.github.com/users/beru/orgs","repos_url":"https://api.github.com/users/beru/repos","events_url":"https://api.github.com/users/beru/events{/privacy}","received_events_url":"https://api.github.com/users/beru/received_events","type":"User","site_admin":false},"repo":{"id":136746507,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY3NDY1MDc=","name":"sakura","full_name":"beru/sakura","private":false,"owner":{"login":"beru","id":1131125,"node_id":"MDQ6VXNlcjExMzExMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/1131125?v=4","gravatar_id":"","url":"https://api.github.com/users/beru","html_url":"https://github.com/beru","followers_url":"https://api.github.com/users/beru/followers","following_url":"https://api.github.com/users/beru/following{/other_user}","gists_url":"https://api.github.com/users/beru/gists{/gist_id}","starred_url":"https://api.github.com/users/beru/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beru/subscriptions","organizations_url":"https://api.github.com/users/beru/orgs","repos_url":"https://api.github.com/users/beru/repos","events_url":"https://api.github.com/users/beru/events{/privacy}","received_events_url":"https://api.github.com/users/beru/received_events","type":"User","site_admin":false},"html_url":"https://github.com/beru/sakura","description":"SourceForgeから移行。VS2017ビルド確認済。","fork":true,"url":"https://api.github.com/repos/beru/sakura","forks_url":"https://api.github.com/repos/beru/sakura/forks","keys_url":"https://api.github.com/repos/beru/sakura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beru/sakura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beru/sakura/teams","hooks_url":"https://api.github.com/repos/beru/sakura/hooks","issue_events_url":"https://api.github.com/repos/beru/sakura/issues/events{/number}","events_url":"https://api.github.com/repos/beru/sakura/events","assignees_url":"https://api.github.com/repos/beru/sakura/assignees{/user}","branches_url":"https://api.github.com/repos/beru/sakura/branches{/branch}","tags_url":"https://api.github.com/repos/beru/sakura/tags","blobs_url":"https://api.github.com/repos/beru/sakura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beru/sakura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beru/sakura/git/refs{/sha}","trees_url":"https://api.github.com/repos/beru/sakura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beru/sakura/statuses/{sha}","languages_url":"https://api.github.com/repos/beru/sakura/languages","stargazers_url":"https://api.github.com/repos/beru/sakura/stargazers","contributors_url":"https://api.github.com/repos/beru/sakura/contributors","subscribers_url":"https://api.github.com/repos/beru/sakura/subscribers","subscription_url":"https://api.github.com/repos/beru/sakura/subscription","commits_url":"https://api.github.com/repos/beru/sakura/commits{/sha}","git_commits_url":"https://api.github.com/repos/beru/sakura/git/commits{/sha}","comments_url":"https://api.github.com/repos/beru/sakura/comments{/number}","issue_comment_url":"https://api.github.com/repos/beru/sakura/issues/comments{/number}","contents_url":"https://api.github.com/repos/beru/sakura/contents/{+path}","compare_url":"https://api.github.com/repos/beru/sakura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beru/sakura/merges","archive_url":"https://api.github.com/repos/beru/sakura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beru/sakura/downloads","issues_url":"https://api.github.com/repos/beru/sakura/issues{/number}","pulls_url":"https://api.github.com/repos/beru/sakura/pulls{/number}","milestones_url":"https://api.github.com/repos/beru/sakura/milestones{/number}","notifications_url":"https://api.github.com/repos/beru/sakura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beru/sakura/labels{/name}","releases_url":"https://api.github.com/repos/beru/sakura/releases{/id}","deployments_url":"https://api.github.com/repos/beru/sakura/deployments","created_at":"2018-06-09T18:03:32Z","updated_at":"2018-09-30T12:59:29Z","pushed_at":"2018-09-30T11:38:15Z","git_url":"git://github.com/beru/sakura.git","ssh_url":"[email protected]:beru/sakura.git","clone_url":"https://github.com/beru/sakura.git","svn_url":"https://github.com/beru/sakura","homepage":"","size":33025,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sakura-editor:master","ref":"master","sha":"4055e4f63ede85cea8c767abed9812e877ac1b9d","user":{"login":"sakura-editor","id":39432189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDMyMTg5","avatar_url":"https://avatars3.githubusercontent.com/u/39432189?v=4","gravatar_id":"","url":"https://api.github.com/users/sakura-editor","html_url":"https://github.com/sakura-editor","followers_url":"https://api.github.com/users/sakura-editor/followers","following_url":"https://api.github.com/users/sakura-editor/following{/other_user}","gists_url":"https://api.github.com/users/sakura-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/sakura-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakura-editor/subscriptions","organizations_url":"https://api.github.com/users/sakura-editor/orgs","repos_url":"https://api.github.com/users/sakura-editor/repos","events_url":"https://api.github.com/users/sakura-editor/events{/privacy}","received_events_url":"https://api.github.com/users/sakura-editor/received_events","type":"Organization","site_admin":false},"repo":{"id":134057969,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQwNTc5Njk=","name":"sakura","full_name":"sakura-editor/sakura","private":false,"owner":{"login":"sakura-editor","id":39432189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NDMyMTg5","avatar_url":"https://avatars3.githubusercontent.com/u/39432189?v=4","gravatar_id":"","url":"https://api.github.com/users/sakura-editor","html_url":"https://github.com/sakura-editor","followers_url":"https://api.github.com/users/sakura-editor/followers","following_url":"https://api.github.com/users/sakura-editor/following{/other_user}","gists_url":"https://api.github.com/users/sakura-editor/gists{/gist_id}","starred_url":"https://api.github.com/users/sakura-editor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sakura-editor/subscriptions","organizations_url":"https://api.github.com/users/sakura-editor/orgs","repos_url":"https://api.github.com/users/sakura-editor/repos","events_url":"https://api.github.com/users/sakura-editor/events{/privacy}","received_events_url":"https://api.github.com/users/sakura-editor/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sakura-editor/sakura","description":"SAKURA Editor (Japanese text editor for MS Windows)","fork":false,"url":"https://api.github.com/repos/sakura-editor/sakura","forks_url":"https://api.github.com/repos/sakura-editor/sakura/forks","keys_url":"https://api.github.com/repos/sakura-editor/sakura/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sakura-editor/sakura/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sakura-editor/sakura/teams","hooks_url":"https://api.github.com/repos/sakura-editor/sakura/hooks","issue_events_url":"https://api.github.com/repos/sakura-editor/sakura/issues/events{/number}","events_url":"https://api.github.com/repos/sakura-editor/sakura/events","assignees_url":"https://api.github.com/repos/sakura-editor/sakura/assignees{/user}","branches_url":"https://api.github.com/repos/sakura-editor/sakura/branches{/branch}","tags_url":"https://api.github.com/repos/sakura-editor/sakura/tags","blobs_url":"https://api.github.com/repos/sakura-editor/sakura/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sakura-editor/sakura/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sakura-editor/sakura/git/refs{/sha}","trees_url":"https://api.github.com/repos/sakura-editor/sakura/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sakura-editor/sakura/statuses/{sha}","languages_url":"https://api.github.com/repos/sakura-editor/sakura/languages","stargazers_url":"https://api.github.com/repos/sakura-editor/sakura/stargazers","contributors_url":"https://api.github.com/repos/sakura-editor/sakura/contributors","subscribers_url":"https://api.github.com/repos/sakura-editor/sakura/subscribers","subscription_url":"https://api.github.com/repos/sakura-editor/sakura/subscription","commits_url":"https://api.github.com/repos/sakura-editor/sakura/commits{/sha}","git_commits_url":"https://api.github.com/repos/sakura-editor/sakura/git/commits{/sha}","comments_url":"https://api.github.com/repos/sakura-editor/sakura/comments{/number}","issue_comment_url":"https://api.github.com/repos/sakura-editor/sakura/issues/comments{/number}","contents_url":"https://api.github.com/repos/sakura-editor/sakura/contents/{+path}","compare_url":"https://api.github.com/repos/sakura-editor/sakura/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sakura-editor/sakura/merges","archive_url":"https://api.github.com/repos/sakura-editor/sakura/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sakura-editor/sakura/downloads","issues_url":"https://api.github.com/repos/sakura-editor/sakura/issues{/number}","pulls_url":"https://api.github.com/repos/sakura-editor/sakura/pulls{/number}","milestones_url":"https://api.github.com/repos/sakura-editor/sakura/milestones{/number}","notifications_url":"https://api.github.com/repos/sakura-editor/sakura/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sakura-editor/sakura/labels{/name}","releases_url":"https://api.github.com/repos/sakura-editor/sakura/releases{/id}","deployments_url":"https://api.github.com/repos/sakura-editor/sakura/deployments","created_at":"2018-05-19T12:02:06Z","updated_at":"2018-09-30T12:52:28Z","pushed_at":"2018-09-30T13:08:48Z","git_url":"git://github.com/sakura-editor/sakura.git","ssh_url":"[email protected]:sakura-editor/sakura.git","clone_url":"https://github.com/sakura-editor/sakura.git","svn_url":"https://github.com/sakura-editor/sakura","homepage":"https://sakura-editor.github.io/","size":32900,"stargazers_count":216,"watchers_count":216,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":116,"watchers":216,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/499"},"html":{"href":"https://github.com/sakura-editor/sakura/pull/499"},"issue":{"href":"https://api.github.com/repos/sakura-editor/sakura/issues/499"},"comments":{"href":"https://api.github.com/repos/sakura-editor/sakura/issues/499/comments"},"review_comments":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/499/comments"},"review_comment":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sakura-editor/sakura/pulls/499/commits"},"statuses":{"href":"https://api.github.com/repos/sakura-editor/sakura/statuses/dd0b317758d8c022f2dc691233f4d15951bbe122"}},"author_association":"CONTRIBUTOR"}}

8344140662

{"actor":{"display_login":"berryzplus"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/comments/190713824","pull_request_review_id":123151110,"id":190713824,"diff_hunk":"@@ -34,9 +34,6 @@\n \n private static boolean levelStart = false;\n \n- private static Level level;","path":"src/SpiritRunner/Main.java","position":4,"original_position":4,"commit_id":"4290268d7635e773769c4a105ff48fc079d6306c","original_commit_id":"4290268d7635e773769c4a105ff48fc079d6306c","user":{"login":"jprolejko","id":39591181,"avatar_url":"https://avatars1.githubusercontent.com/u/39591181?v=4","gravatar_id":"","url":"https://api.github.com/users/jprolejko","html_url":"https://github.com/jprolejko","followers_url":"https://api.github.com/users/jprolejko/followers","following_url":"https://api.github.com/users/jprolejko/following{/other_user}","gists_url":"https://api.github.com/users/jprolejko/gists{/gist_id}","starred_url":"https://api.github.com/users/jprolejko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprolejko/subscriptions","organizations_url":"https://api.github.com/users/jprolejko/orgs","repos_url":"https://api.github.com/users/jprolejko/repos","events_url":"https://api.github.com/users/jprolejko/events{/privacy}","received_events_url":"https://api.github.com/users/jprolejko/received_events","type":"User","site_admin":false},"body":"nie wiem xD","created_at":"2018-05-24T20:04:14Z","updated_at":"2018-05-24T20:04:14Z","html_url":"https://github.com/SpiritStudio/Spirit-Runner/pull/2#discussion_r190713824","pull_request_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/2","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/comments/190713824"},"html":{"href":"https://github.com/SpiritStudio/Spirit-Runner/pull/2#discussion_r190713824"},"pull_request":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/2"}},"in_reply_to_id":190713579},"pull_request":{"url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/2","id":190404143,"html_url":"https://github.com/SpiritStudio/Spirit-Runner/pull/2","diff_url":"https://github.com/SpiritStudio/Spirit-Runner/pull/2.diff","patch_url":"https://github.com/SpiritStudio/Spirit-Runner/pull/2.patch","issue_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues/2","number":2,"state":"open","locked":false,"title":"Pykes included","user":{"login":"jprolejko","id":39591181,"avatar_url":"https://avatars1.githubusercontent.com/u/39591181?v=4","gravatar_id":"","url":"https://api.github.com/users/jprolejko","html_url":"https://github.com/jprolejko","followers_url":"https://api.github.com/users/jprolejko/followers","following_url":"https://api.github.com/users/jprolejko/following{/other_user}","gists_url":"https://api.github.com/users/jprolejko/gists{/gist_id}","starred_url":"https://api.github.com/users/jprolejko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jprolejko/subscriptions","organizations_url":"https://api.github.com/users/jprolejko/orgs","repos_url":"https://api.github.com/users/jprolejko/repos","events_url":"https://api.github.com/users/jprolejko/events{/privacy}","received_events_url":"https://api.github.com/users/jprolejko/received_events","type":"User","site_admin":false},"body":"fixes #1 ","created_at":"2018-05-24T20:02:29Z","updated_at":"2018-05-24T20:04:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78ce04003d3df9176d18e8c6cb161c18b17e3bc3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/2/commits","review_comments_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/2/comments","review_comment_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues/2/comments","statuses_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/statuses/4290268d7635e773769c4a105ff48fc079d6306c","head":{"label":"SpiritStudio:pykes","ref":"pykes","sha":"4290268d7635e773769c4a105ff48fc079d6306c","user":{"login":"SpiritStudio","id":39591239,"avatar_url":"https://avatars2.githubusercontent.com/u/39591239?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiritStudio","html_url":"https://github.com/SpiritStudio","followers_url":"https://api.github.com/users/SpiritStudio/followers","following_url":"https://api.github.com/users/SpiritStudio/following{/other_user}","gists_url":"https://api.github.com/users/SpiritStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiritStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiritStudio/subscriptions","organizations_url":"https://api.github.com/users/SpiritStudio/orgs","repos_url":"https://api.github.com/users/SpiritStudio/repos","events_url":"https://api.github.com/users/SpiritStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SpiritStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":134714792,"name":"Spirit-Runner","full_name":"SpiritStudio/Spirit-Runner","owner":{"login":"SpiritStudio","id":39591239,"avatar_url":"https://avatars2.githubusercontent.com/u/39591239?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiritStudio","html_url":"https://github.com/SpiritStudio","followers_url":"https://api.github.com/users/SpiritStudio/followers","following_url":"https://api.github.com/users/SpiritStudio/following{/other_user}","gists_url":"https://api.github.com/users/SpiritStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiritStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiritStudio/subscriptions","organizations_url":"https://api.github.com/users/SpiritStudio/orgs","repos_url":"https://api.github.com/users/SpiritStudio/repos","events_url":"https://api.github.com/users/SpiritStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SpiritStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpiritStudio/Spirit-Runner","description":"simple 2d platformer mobile game","fork":false,"url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner","forks_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/forks","keys_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/teams","hooks_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/hooks","issue_events_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues/events{/number}","events_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/events","assignees_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/assignees{/user}","branches_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/branches{/branch}","tags_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/tags","blobs_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/statuses/{sha}","languages_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/languages","stargazers_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/stargazers","contributors_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/contributors","subscribers_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/subscribers","subscription_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/subscription","commits_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/contents/{+path}","compare_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/merges","archive_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/downloads","issues_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues{/number}","pulls_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls{/number}","milestones_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/milestones{/number}","notifications_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/labels{/name}","releases_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/releases{/id}","deployments_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/deployments","created_at":"2018-05-24T12:50:31Z","updated_at":"2018-05-24T19:55:46Z","pushed_at":"2018-05-24T20:02:29Z","git_url":"git://github.com/SpiritStudio/Spirit-Runner.git","ssh_url":"[email protected]:SpiritStudio/Spirit-Runner.git","clone_url":"https://github.com/SpiritStudio/Spirit-Runner.git","svn_url":"https://github.com/SpiritStudio/Spirit-Runner","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"SpiritStudio:master","ref":"master","sha":"98a0c0c7f8fed699959953126af461f628760ab0","user":{"login":"SpiritStudio","id":39591239,"avatar_url":"https://avatars2.githubusercontent.com/u/39591239?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiritStudio","html_url":"https://github.com/SpiritStudio","followers_url":"https://api.github.com/users/SpiritStudio/followers","following_url":"https://api.github.com/users/SpiritStudio/following{/other_user}","gists_url":"https://api.github.com/users/SpiritStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiritStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiritStudio/subscriptions","organizations_url":"https://api.github.com/users/SpiritStudio/orgs","repos_url":"https://api.github.com/users/SpiritStudio/repos","events_url":"https://api.github.com/users/SpiritStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SpiritStudio/received_events","type":"Organization","site_admin":false},"repo":{"id":134714792,"name":"Spirit-Runner","full_name":"SpiritStudio/Spirit-Runner","owner":{"login":"SpiritStudio","id":39591239,"avatar_url":"https://avatars2.githubusercontent.com/u/39591239?v=4","gravatar_id":"","url":"https://api.github.com/users/SpiritStudio","html_url":"https://github.com/SpiritStudio","followers_url":"https://api.github.com/users/SpiritStudio/followers","following_url":"https://api.github.com/users/SpiritStudio/following{/other_user}","gists_url":"https://api.github.com/users/SpiritStudio/gists{/gist_id}","starred_url":"https://api.github.com/users/SpiritStudio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SpiritStudio/subscriptions","organizations_url":"https://api.github.com/users/SpiritStudio/orgs","repos_url":"https://api.github.com/users/SpiritStudio/repos","events_url":"https://api.github.com/users/SpiritStudio/events{/privacy}","received_events_url":"https://api.github.com/users/SpiritStudio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SpiritStudio/Spirit-Runner","description":"simple 2d platformer mobile game","fork":false,"url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner","forks_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/forks","keys_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/teams","hooks_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/hooks","issue_events_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues/events{/number}","events_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/events","assignees_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/assignees{/user}","branches_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/branches{/branch}","tags_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/tags","blobs_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/refs{/sha}","trees_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/statuses/{sha}","languages_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/languages","stargazers_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/stargazers","contributors_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/contributors","subscribers_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/subscribers","subscription_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/subscription","commits_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/commits{/sha}","git_commits_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/git/commits{/sha}","comments_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/comments{/number}","issue_comment_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues/comments{/number}","contents_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/contents/{+path}","compare_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/merges","archive_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/downloads","issues_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues{/number}","pulls_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls{/number}","milestones_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/milestones{/number}","notifications_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/labels{/name}","releases_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/releases{/id}","deployments_url":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/deployments","created_at":"2018-05-24T12:50:31Z","updated_at":"2018-05-24T19:55:46Z","pushed_at":"2018-05-24T20:02:29Z","git_url":"git://github.com/SpiritStudio/Spirit-Runner.git","ssh_url":"[email protected]:SpiritStudio/Spirit-Runner.git","clone_url":"https://github.com/SpiritStudio/Spirit-Runner.git","svn_url":"https://github.com/SpiritStudio/Spirit-Runner","homepage":null,"size":0,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/2"},"html":{"href":"https://github.com/SpiritStudio/Spirit-Runner/pull/2"},"issue":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues/2"},"comments":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/SpiritStudio/Spirit-Runner/statuses/4290268d7635e773769c4a105ff48fc079d6306c"}},"author_association":"CONTRIBUTOR"}}

7726084713

{"actor":{"display_login":"jprolejko"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/comments/192782110","pull_request_review_id":125586633,"id":192782110,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mjc4MjExMA==","diff_hunk":"@@ -0,0 +1,75 @@\n+\"\"\"\n+Module for converting data set into files used by agent\n+\"\"\"\n+\n+from typing import List, Dict\n+from nltk.tokenize import sent_tokenize\n+import json_manager\n+import nouns_finder\n+import stemming\n+\n+\n+def read_text_file(file_name: str) -> str:\n+ \"\"\"\n+ Reads file and returns its text\n+ :param file_name: name of a file to read\n+ :return: text of the file\n+ \"\"\"\n+ # encoding='utf-8-sig' is used for omitting \\ufeff symbol\n+ # in the beginning of the string after reading from file\n+ with open(file_name, 'r', encoding='utf-8-sig') as text_file:\n+ text = text_file.read()\n+\n+ return text\n+\n+\n+def write_sentences_and_nouns(text_file_name: str,\n+ json_file_name: str = \"sentences_and_nouns.json\") -> None:\n+ \"\"\"\n+ Reads text file and writes json with object containing sentences as attributes\n+ and lists of nouns in corresponding sentence as values.\n+ :param text_file_name: name of the input text file\n+ :param json_file_name: name of the output json file\n+ :return: None\n+ \"\"\"\n+\n+ # read text\n+ input_text = read_text_file(text_file_name)\n+\n+ # sentences in the text\n+ sentences: List[str] = sent_tokenize(input_text)\n+\n+ # dictionary to be serialized for json\n+ sentences_and_nouns: Dict[str, List[str]] = dict()\n+\n+ # searching for nouns\n+ for sentence in sentences:\n+ print(sentence)","path":"dataset_processing.py","position":47,"original_position":47,"commit_id":"fe2b7bab244c15b6c772a7c84ca956db2df7b5d8","original_commit_id":"fe2b7bab244c15b6c772a7c84ca956db2df7b5d8","user":{"login":"UnoYakshi","id":5715383,"node_id":"MDQ6VXNlcjU3MTUzODM=","avatar_url":"https://avatars3.githubusercontent.com/u/5715383?v=4","gravatar_id":"","url":"https://api.github.com/users/UnoYakshi","html_url":"https://github.com/UnoYakshi","followers_url":"https://api.github.com/users/UnoYakshi/followers","following_url":"https://api.github.com/users/UnoYakshi/following{/other_user}","gists_url":"https://api.github.com/users/UnoYakshi/gists{/gist_id}","starred_url":"https://api.github.com/users/UnoYakshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/UnoYakshi/subscriptions","organizations_url":"https://api.github.com/users/UnoYakshi/orgs","repos_url":"https://api.github.com/users/UnoYakshi/repos","events_url":"https://api.github.com/users/UnoYakshi/events{/privacy}","received_events_url":"https://api.github.com/users/UnoYakshi/received_events","type":"User","site_admin":false},"body":"Should this `print()` be?","created_at":"2018-06-04T15:27:24Z","updated_at":"2018-06-04T15:32:11Z","html_url":"https://github.com/ReiBot/rei-bot-2/pull/3#discussion_r192782110","pull_request_url":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/3","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/comments/192782110"},"html":{"href":"https://github.com/ReiBot/rei-bot-2/pull/3#discussion_r192782110"},"pull_request":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/3","id":192386098,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzg2MDk4","html_url":"https://github.com/ReiBot/rei-bot-2/pull/3","diff_url":"https://github.com/ReiBot/rei-bot-2/pull/3.diff","patch_url":"https://github.com/ReiBot/rei-bot-2/pull/3.patch","issue_url":"https://api.github.com/repos/ReiBot/rei-bot-2/issues/3","number":3,"state":"open","locked":false,"title":"Output generating tools","user":{"login":"oninbo","id":8857825,"node_id":"MDQ6VXNlcjg4NTc4MjU=","avatar_url":"https://avatars0.githubusercontent.com/u/8857825?v=4","gravatar_id":"","url":"https://api.github.com/users/oninbo","html_url":"https://github.com/oninbo","followers_url":"https://api.github.com/users/oninbo/followers","following_url":"https://api.github.com/users/oninbo/following{/other_user}","gists_url":"https://api.github.com/users/oninbo/gists{/gist_id}","starred_url":"https://api.github.com/users/oninbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oninbo/subscriptions","organizations_url":"https://api.github.com/users/oninbo/orgs","repos_url":"https://api.github.com/users/oninbo/repos","events_url":"https://api.github.com/users/oninbo/events{/privacy}","received_events_url":"https://api.github.com/users/oninbo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-04T12:04:57Z","updated_at":"2018-06-04T15:32:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d566af53737883f0d3adfcaa54ca090ae69829e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/3/commits","review_comments_url":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/3/comments","review_comment_url":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReiBot/rei-bot-2/issues/3/comments","statuses_url":"https://api.github.com/repos/ReiBot/rei-bot-2/statuses/fe2b7bab244c15b6c772a7c84ca956db2df7b5d8","head":{"label":"ReiBot:output_generating_tools","ref":"output_generating_tools","sha":"fe2b7bab244c15b6c772a7c84ca956db2df7b5d8","user":{"login":"ReiBot","id":39763672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzYzNjcy","avatar_url":"https://avatars3.githubusercontent.com/u/39763672?v=4","gravatar_id":"","url":"https://api.github.com/users/ReiBot","html_url":"https://github.com/ReiBot","followers_url":"https://api.github.com/users/ReiBot/followers","following_url":"https://api.github.com/users/ReiBot/following{/other_user}","gists_url":"https://api.github.com/users/ReiBot/gists{/gist_id}","starred_url":"https://api.github.com/users/ReiBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReiBot/subscriptions","organizations_url":"https://api.github.com/users/ReiBot/orgs","repos_url":"https://api.github.com/users/ReiBot/repos","events_url":"https://api.github.com/users/ReiBot/events{/privacy}","received_events_url":"https://api.github.com/users/ReiBot/received_events","type":"Organization","site_admin":false},"repo":{"id":135346891,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNDY4OTE=","name":"rei-bot-2","full_name":"ReiBot/rei-bot-2","owner":{"login":"ReiBot","id":39763672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzYzNjcy","avatar_url":"https://avatars3.githubusercontent.com/u/39763672?v=4","gravatar_id":"","url":"https://api.github.com/users/ReiBot","html_url":"https://github.com/ReiBot","followers_url":"https://api.github.com/users/ReiBot/followers","following_url":"https://api.github.com/users/ReiBot/following{/other_user}","gists_url":"https://api.github.com/users/ReiBot/gists{/gist_id}","starred_url":"https://api.github.com/users/ReiBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReiBot/subscriptions","organizations_url":"https://api.github.com/users/ReiBot/orgs","repos_url":"https://api.github.com/users/ReiBot/repos","events_url":"https://api.github.com/users/ReiBot/events{/privacy}","received_events_url":"https://api.github.com/users/ReiBot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReiBot/rei-bot-2","description":"Chatbot for telegram groups representing anime character Ayanami Rei","fork":false,"url":"https://api.github.com/repos/ReiBot/rei-bot-2","forks_url":"https://api.github.com/repos/ReiBot/rei-bot-2/forks","keys_url":"https://api.github.com/repos/ReiBot/rei-bot-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReiBot/rei-bot-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReiBot/rei-bot-2/teams","hooks_url":"https://api.github.com/repos/ReiBot/rei-bot-2/hooks","issue_events_url":"https://api.github.com/repos/ReiBot/rei-bot-2/issues/events{/number}","events_url":"https://api.github.com/repos/ReiBot/rei-bot-2/events","assignees_url":"https://api.github.com/repos/ReiBot/rei-bot-2/assignees{/user}","branches_url":"https://api.github.com/repos/ReiBot/rei-bot-2/branches{/branch}","tags_url":"https://api.github.com/repos/ReiBot/rei-bot-2/tags","blobs_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReiBot/rei-bot-2/statuses/{sha}","languages_url":"https://api.github.com/repos/ReiBot/rei-bot-2/languages","stargazers_url":"https://api.github.com/repos/ReiBot/rei-bot-2/stargazers","contributors_url":"https://api.github.com/repos/ReiBot/rei-bot-2/contributors","subscribers_url":"https://api.github.com/repos/ReiBot/rei-bot-2/subscribers","subscription_url":"https://api.github.com/repos/ReiBot/rei-bot-2/subscription","commits_url":"https://api.github.com/repos/ReiBot/rei-bot-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReiBot/rei-bot-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReiBot/rei-bot-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReiBot/rei-bot-2/contents/{+path}","compare_url":"https://api.github.com/repos/ReiBot/rei-bot-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReiBot/rei-bot-2/merges","archive_url":"https://api.github.com/repos/ReiBot/rei-bot-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReiBot/rei-bot-2/downloads","issues_url":"https://api.github.com/repos/ReiBot/rei-bot-2/issues{/number}","pulls_url":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls{/number}","milestones_url":"https://api.github.com/repos/ReiBot/rei-bot-2/milestones{/number}","notifications_url":"https://api.github.com/repos/ReiBot/rei-bot-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReiBot/rei-bot-2/labels{/name}","releases_url":"https://api.github.com/repos/ReiBot/rei-bot-2/releases{/id}","deployments_url":"https://api.github.com/repos/ReiBot/rei-bot-2/deployments","created_at":"2018-05-29T20:02:10Z","updated_at":"2018-05-30T10:20:31Z","pushed_at":"2018-06-04T12:30:56Z","git_url":"git://github.com/ReiBot/rei-bot-2.git","ssh_url":"[email protected]:ReiBot/rei-bot-2.git","clone_url":"https://github.com/ReiBot/rei-bot-2.git","svn_url":"https://github.com/ReiBot/rei-bot-2","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"ReiBot:dev","ref":"dev","sha":"c9255bc241be2e797d25b89eb6a9aaa4580c37b0","user":{"login":"ReiBot","id":39763672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzYzNjcy","avatar_url":"https://avatars3.githubusercontent.com/u/39763672?v=4","gravatar_id":"","url":"https://api.github.com/users/ReiBot","html_url":"https://github.com/ReiBot","followers_url":"https://api.github.com/users/ReiBot/followers","following_url":"https://api.github.com/users/ReiBot/following{/other_user}","gists_url":"https://api.github.com/users/ReiBot/gists{/gist_id}","starred_url":"https://api.github.com/users/ReiBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReiBot/subscriptions","organizations_url":"https://api.github.com/users/ReiBot/orgs","repos_url":"https://api.github.com/users/ReiBot/repos","events_url":"https://api.github.com/users/ReiBot/events{/privacy}","received_events_url":"https://api.github.com/users/ReiBot/received_events","type":"Organization","site_admin":false},"repo":{"id":135346891,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNDY4OTE=","name":"rei-bot-2","full_name":"ReiBot/rei-bot-2","owner":{"login":"ReiBot","id":39763672,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzYzNjcy","avatar_url":"https://avatars3.githubusercontent.com/u/39763672?v=4","gravatar_id":"","url":"https://api.github.com/users/ReiBot","html_url":"https://github.com/ReiBot","followers_url":"https://api.github.com/users/ReiBot/followers","following_url":"https://api.github.com/users/ReiBot/following{/other_user}","gists_url":"https://api.github.com/users/ReiBot/gists{/gist_id}","starred_url":"https://api.github.com/users/ReiBot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReiBot/subscriptions","organizations_url":"https://api.github.com/users/ReiBot/orgs","repos_url":"https://api.github.com/users/ReiBot/repos","events_url":"https://api.github.com/users/ReiBot/events{/privacy}","received_events_url":"https://api.github.com/users/ReiBot/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReiBot/rei-bot-2","description":"Chatbot for telegram groups representing anime character Ayanami Rei","fork":false,"url":"https://api.github.com/repos/ReiBot/rei-bot-2","forks_url":"https://api.github.com/repos/ReiBot/rei-bot-2/forks","keys_url":"https://api.github.com/repos/ReiBot/rei-bot-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReiBot/rei-bot-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReiBot/rei-bot-2/teams","hooks_url":"https://api.github.com/repos/ReiBot/rei-bot-2/hooks","issue_events_url":"https://api.github.com/repos/ReiBot/rei-bot-2/issues/events{/number}","events_url":"https://api.github.com/repos/ReiBot/rei-bot-2/events","assignees_url":"https://api.github.com/repos/ReiBot/rei-bot-2/assignees{/user}","branches_url":"https://api.github.com/repos/ReiBot/rei-bot-2/branches{/branch}","tags_url":"https://api.github.com/repos/ReiBot/rei-bot-2/tags","blobs_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReiBot/rei-bot-2/statuses/{sha}","languages_url":"https://api.github.com/repos/ReiBot/rei-bot-2/languages","stargazers_url":"https://api.github.com/repos/ReiBot/rei-bot-2/stargazers","contributors_url":"https://api.github.com/repos/ReiBot/rei-bot-2/contributors","subscribers_url":"https://api.github.com/repos/ReiBot/rei-bot-2/subscribers","subscription_url":"https://api.github.com/repos/ReiBot/rei-bot-2/subscription","commits_url":"https://api.github.com/repos/ReiBot/rei-bot-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReiBot/rei-bot-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReiBot/rei-bot-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReiBot/rei-bot-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReiBot/rei-bot-2/contents/{+path}","compare_url":"https://api.github.com/repos/ReiBot/rei-bot-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReiBot/rei-bot-2/merges","archive_url":"https://api.github.com/repos/ReiBot/rei-bot-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReiBot/rei-bot-2/downloads","issues_url":"https://api.github.com/repos/ReiBot/rei-bot-2/issues{/number}","pulls_url":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls{/number}","milestones_url":"https://api.github.com/repos/ReiBot/rei-bot-2/milestones{/number}","notifications_url":"https://api.github.com/repos/ReiBot/rei-bot-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReiBot/rei-bot-2/labels{/name}","releases_url":"https://api.github.com/repos/ReiBot/rei-bot-2/releases{/id}","deployments_url":"https://api.github.com/repos/ReiBot/rei-bot-2/deployments","created_at":"2018-05-29T20:02:10Z","updated_at":"2018-05-30T10:20:31Z","pushed_at":"2018-06-04T12:30:56Z","git_url":"git://github.com/ReiBot/rei-bot-2.git","ssh_url":"[email protected]:ReiBot/rei-bot-2.git","clone_url":"https://github.com/ReiBot/rei-bot-2.git","svn_url":"https://github.com/ReiBot/rei-bot-2","homepage":null,"size":18,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/3"},"html":{"href":"https://github.com/ReiBot/rei-bot-2/pull/3"},"issue":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/issues/3"},"comments":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/ReiBot/rei-bot-2/statuses/fe2b7bab244c15b6c772a7c84ca956db2df7b5d8"}},"author_association":"COLLABORATOR"}}

7772652390

{"actor":{"display_login":"UnoYakshi"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/sarugaku/passa/pulls/comments/212188861","pull_request_review_id":148765119,"id":212188861,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjE4ODg2MQ==","diff_hunk":"@@ -2,9 +2,18 @@\n \n from __future__ import absolute_import, unicode_literals\n \n+import itertools\n+import operator\n+\n+import vistir\n+\n+from packaging.specifiers import SpecifierSet, Specifier\n from packaging.markers import Marker\n \n \n+PYTHON_BOUNDARIES = {2: 7, 3: 9}","path":"src/passa/markers.py","position":13,"original_position":13,"commit_id":"b7d46f1ab2f7fb5fcf520c98c844e017a94be68f","original_commit_id":"8bbfd0efa27a48f870e24c1f20ee1bc5eb5302d7","user":{"login":"techalchemy","id":954310,"node_id":"MDQ6VXNlcjk1NDMxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/954310?v=4","gravatar_id":"","url":"https://api.github.com/users/techalchemy","html_url":"https://github.com/techalchemy","followers_url":"https://api.github.com/users/techalchemy/followers","following_url":"https://api.github.com/users/techalchemy/following{/other_user}","gists_url":"https://api.github.com/users/techalchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/techalchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techalchemy/subscriptions","organizations_url":"https://api.github.com/users/techalchemy/orgs","repos_url":"https://api.github.com/users/techalchemy/repos","events_url":"https://api.github.com/users/techalchemy/events{/privacy}","received_events_url":"https://api.github.com/users/techalchemy/received_events","type":"User","site_admin":false},"body":"More importantly if we _dont_ do it it means there is actually no point in doing anything at all here, because the entire purpose of adding or subtracting one is to consolidate. If you don't define a boundary you don't consolidate anything and wind up just putting invalid python versions in people's markers where they only had valid ones, so you are just making things worse","created_at":"2018-08-23T05:50:25Z","updated_at":"2018-08-23T05:50:25Z","html_url":"https://github.com/sarugaku/passa/pull/14#discussion_r212188861","pull_request_url":"https://api.github.com/repos/sarugaku/passa/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sarugaku/passa/pulls/comments/212188861"},"html":{"href":"https://github.com/sarugaku/passa/pull/14#discussion_r212188861"},"pull_request":{"href":"https://api.github.com/repos/sarugaku/passa/pulls/14"}},"in_reply_to_id":211916652},"pull_request":{"url":"https://api.github.com/repos/sarugaku/passa/pulls/14","id":210058736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDU4NzM2","html_url":"https://github.com/sarugaku/passa/pull/14","diff_url":"https://github.com/sarugaku/passa/pull/14.diff","patch_url":"https://github.com/sarugaku/passa/pull/14.patch","issue_url":"https://api.github.com/repos/sarugaku/passa/issues/14","number":14,"state":"open","locked":false,"title":"Markers","user":{"login":"techalchemy","id":954310,"node_id":"MDQ6VXNlcjk1NDMxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/954310?v=4","gravatar_id":"","url":"https://api.github.com/users/techalchemy","html_url":"https://github.com/techalchemy","followers_url":"https://api.github.com/users/techalchemy/followers","following_url":"https://api.github.com/users/techalchemy/following{/other_user}","gists_url":"https://api.github.com/users/techalchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/techalchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techalchemy/subscriptions","organizations_url":"https://api.github.com/users/techalchemy/orgs","repos_url":"https://api.github.com/users/techalchemy/repos","events_url":"https://api.github.com/users/techalchemy/events{/privacy}","received_events_url":"https://api.github.com/users/techalchemy/received_events","type":"User","site_admin":false},"body":" - Flatten markers & consolidate ","created_at":"2018-08-22T08:39:51Z","updated_at":"2018-08-23T05:50:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"25a133016909d10f7686cd160915c7362ea96b4e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1028720381,"node_id":"MDU6TGFiZWwxMDI4NzIwMzgx","url":"https://api.github.com/repos/sarugaku/passa/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sarugaku/passa/pulls/14/commits","review_comments_url":"https://api.github.com/repos/sarugaku/passa/pulls/14/comments","review_comment_url":"https://api.github.com/repos/sarugaku/passa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sarugaku/passa/issues/14/comments","statuses_url":"https://api.github.com/repos/sarugaku/passa/statuses/b7d46f1ab2f7fb5fcf520c98c844e017a94be68f","head":{"label":"sarugaku:markers","ref":"markers","sha":"b7d46f1ab2f7fb5fcf520c98c844e017a94be68f","user":{"login":"sarugaku","id":39783362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzgzMzYy","avatar_url":"https://avatars3.githubusercontent.com/u/39783362?v=4","gravatar_id":"","url":"https://api.github.com/users/sarugaku","html_url":"https://github.com/sarugaku","followers_url":"https://api.github.com/users/sarugaku/followers","following_url":"https://api.github.com/users/sarugaku/following{/other_user}","gists_url":"https://api.github.com/users/sarugaku/gists{/gist_id}","starred_url":"https://api.github.com/users/sarugaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarugaku/subscriptions","organizations_url":"https://api.github.com/users/sarugaku/orgs","repos_url":"https://api.github.com/users/sarugaku/repos","events_url":"https://api.github.com/users/sarugaku/events{/privacy}","received_events_url":"https://api.github.com/users/sarugaku/received_events","type":"Organization","site_admin":false},"repo":{"id":143817997,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4MTc5OTc=","name":"passa","full_name":"sarugaku/passa","owner":{"login":"sarugaku","id":39783362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzgzMzYy","avatar_url":"https://avatars3.githubusercontent.com/u/39783362?v=4","gravatar_id":"","url":"https://api.github.com/users/sarugaku","html_url":"https://github.com/sarugaku","followers_url":"https://api.github.com/users/sarugaku/followers","following_url":"https://api.github.com/users/sarugaku/following{/other_user}","gists_url":"https://api.github.com/users/sarugaku/gists{/gist_id}","starred_url":"https://api.github.com/users/sarugaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarugaku/subscriptions","organizations_url":"https://api.github.com/users/sarugaku/orgs","repos_url":"https://api.github.com/users/sarugaku/repos","events_url":"https://api.github.com/users/sarugaku/events{/privacy}","received_events_url":"https://api.github.com/users/sarugaku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sarugaku/passa","description":"A resolver implementation for generating and interacting with Pipenv-compatible Lockfiles.","fork":false,"url":"https://api.github.com/repos/sarugaku/passa","forks_url":"https://api.github.com/repos/sarugaku/passa/forks","keys_url":"https://api.github.com/repos/sarugaku/passa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarugaku/passa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarugaku/passa/teams","hooks_url":"https://api.github.com/repos/sarugaku/passa/hooks","issue_events_url":"https://api.github.com/repos/sarugaku/passa/issues/events{/number}","events_url":"https://api.github.com/repos/sarugaku/passa/events","assignees_url":"https://api.github.com/repos/sarugaku/passa/assignees{/user}","branches_url":"https://api.github.com/repos/sarugaku/passa/branches{/branch}","tags_url":"https://api.github.com/repos/sarugaku/passa/tags","blobs_url":"https://api.github.com/repos/sarugaku/passa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarugaku/passa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarugaku/passa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarugaku/passa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarugaku/passa/statuses/{sha}","languages_url":"https://api.github.com/repos/sarugaku/passa/languages","stargazers_url":"https://api.github.com/repos/sarugaku/passa/stargazers","contributors_url":"https://api.github.com/repos/sarugaku/passa/contributors","subscribers_url":"https://api.github.com/repos/sarugaku/passa/subscribers","subscription_url":"https://api.github.com/repos/sarugaku/passa/subscription","commits_url":"https://api.github.com/repos/sarugaku/passa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarugaku/passa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarugaku/passa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarugaku/passa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarugaku/passa/contents/{+path}","compare_url":"https://api.github.com/repos/sarugaku/passa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarugaku/passa/merges","archive_url":"https://api.github.com/repos/sarugaku/passa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarugaku/passa/downloads","issues_url":"https://api.github.com/repos/sarugaku/passa/issues{/number}","pulls_url":"https://api.github.com/repos/sarugaku/passa/pulls{/number}","milestones_url":"https://api.github.com/repos/sarugaku/passa/milestones{/number}","notifications_url":"https://api.github.com/repos/sarugaku/passa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarugaku/passa/labels{/name}","releases_url":"https://api.github.com/repos/sarugaku/passa/releases{/id}","deployments_url":"https://api.github.com/repos/sarugaku/passa/deployments","created_at":"2018-08-07T04:06:04Z","updated_at":"2018-08-22T10:02:37Z","pushed_at":"2018-08-22T11:26:10Z","git_url":"git://github.com/sarugaku/passa.git","ssh_url":"[email protected]:sarugaku/passa.git","clone_url":"https://github.com/sarugaku/passa.git","svn_url":"https://github.com/sarugaku/passa","homepage":null,"size":252,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":9,"watchers":4,"default_branch":"master"}},"base":{"label":"sarugaku:master","ref":"master","sha":"89d0de31d734399c627ce56388fdc6347ce640c1","user":{"login":"sarugaku","id":39783362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzgzMzYy","avatar_url":"https://avatars3.githubusercontent.com/u/39783362?v=4","gravatar_id":"","url":"https://api.github.com/users/sarugaku","html_url":"https://github.com/sarugaku","followers_url":"https://api.github.com/users/sarugaku/followers","following_url":"https://api.github.com/users/sarugaku/following{/other_user}","gists_url":"https://api.github.com/users/sarugaku/gists{/gist_id}","starred_url":"https://api.github.com/users/sarugaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarugaku/subscriptions","organizations_url":"https://api.github.com/users/sarugaku/orgs","repos_url":"https://api.github.com/users/sarugaku/repos","events_url":"https://api.github.com/users/sarugaku/events{/privacy}","received_events_url":"https://api.github.com/users/sarugaku/received_events","type":"Organization","site_admin":false},"repo":{"id":143817997,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4MTc5OTc=","name":"passa","full_name":"sarugaku/passa","owner":{"login":"sarugaku","id":39783362,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzgzMzYy","avatar_url":"https://avatars3.githubusercontent.com/u/39783362?v=4","gravatar_id":"","url":"https://api.github.com/users/sarugaku","html_url":"https://github.com/sarugaku","followers_url":"https://api.github.com/users/sarugaku/followers","following_url":"https://api.github.com/users/sarugaku/following{/other_user}","gists_url":"https://api.github.com/users/sarugaku/gists{/gist_id}","starred_url":"https://api.github.com/users/sarugaku/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sarugaku/subscriptions","organizations_url":"https://api.github.com/users/sarugaku/orgs","repos_url":"https://api.github.com/users/sarugaku/repos","events_url":"https://api.github.com/users/sarugaku/events{/privacy}","received_events_url":"https://api.github.com/users/sarugaku/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sarugaku/passa","description":"A resolver implementation for generating and interacting with Pipenv-compatible Lockfiles.","fork":false,"url":"https://api.github.com/repos/sarugaku/passa","forks_url":"https://api.github.com/repos/sarugaku/passa/forks","keys_url":"https://api.github.com/repos/sarugaku/passa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sarugaku/passa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sarugaku/passa/teams","hooks_url":"https://api.github.com/repos/sarugaku/passa/hooks","issue_events_url":"https://api.github.com/repos/sarugaku/passa/issues/events{/number}","events_url":"https://api.github.com/repos/sarugaku/passa/events","assignees_url":"https://api.github.com/repos/sarugaku/passa/assignees{/user}","branches_url":"https://api.github.com/repos/sarugaku/passa/branches{/branch}","tags_url":"https://api.github.com/repos/sarugaku/passa/tags","blobs_url":"https://api.github.com/repos/sarugaku/passa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sarugaku/passa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sarugaku/passa/git/refs{/sha}","trees_url":"https://api.github.com/repos/sarugaku/passa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sarugaku/passa/statuses/{sha}","languages_url":"https://api.github.com/repos/sarugaku/passa/languages","stargazers_url":"https://api.github.com/repos/sarugaku/passa/stargazers","contributors_url":"https://api.github.com/repos/sarugaku/passa/contributors","subscribers_url":"https://api.github.com/repos/sarugaku/passa/subscribers","subscription_url":"https://api.github.com/repos/sarugaku/passa/subscription","commits_url":"https://api.github.com/repos/sarugaku/passa/commits{/sha}","git_commits_url":"https://api.github.com/repos/sarugaku/passa/git/commits{/sha}","comments_url":"https://api.github.com/repos/sarugaku/passa/comments{/number}","issue_comment_url":"https://api.github.com/repos/sarugaku/passa/issues/comments{/number}","contents_url":"https://api.github.com/repos/sarugaku/passa/contents/{+path}","compare_url":"https://api.github.com/repos/sarugaku/passa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sarugaku/passa/merges","archive_url":"https://api.github.com/repos/sarugaku/passa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sarugaku/passa/downloads","issues_url":"https://api.github.com/repos/sarugaku/passa/issues{/number}","pulls_url":"https://api.github.com/repos/sarugaku/passa/pulls{/number}","milestones_url":"https://api.github.com/repos/sarugaku/passa/milestones{/number}","notifications_url":"https://api.github.com/repos/sarugaku/passa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sarugaku/passa/labels{/name}","releases_url":"https://api.github.com/repos/sarugaku/passa/releases{/id}","deployments_url":"https://api.github.com/repos/sarugaku/passa/deployments","created_at":"2018-08-07T04:06:04Z","updated_at":"2018-08-22T10:02:37Z","pushed_at":"2018-08-22T11:26:10Z","git_url":"git://github.com/sarugaku/passa.git","ssh_url":"[email protected]:sarugaku/passa.git","clone_url":"https://github.com/sarugaku/passa.git","svn_url":"https://github.com/sarugaku/passa","homepage":null,"size":252,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":0,"open_issues":9,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sarugaku/passa/pulls/14"},"html":{"href":"https://github.com/sarugaku/passa/pull/14"},"issue":{"href":"https://api.github.com/repos/sarugaku/passa/issues/14"},"comments":{"href":"https://api.github.com/repos/sarugaku/passa/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/sarugaku/passa/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/sarugaku/passa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sarugaku/passa/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/sarugaku/passa/statuses/b7d46f1ab2f7fb5fcf520c98c844e017a94be68f"}},"author_association":"CONTRIBUTOR"}}

8154856789

{"actor":{"display_login":"techalchemy"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/comments/222057652","pull_request_review_id":160846648,"id":222057652,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjA1NzY1Mg==","diff_hunk":"@@ -0,0 +1,71 @@\n+/* font-family: 'Sawarabi Mincho', sans-serif;\n+font-family: 'Marck Script', cursive; */\n+*{\n+ background-color: #EBDCCB;\n+}\n+h1{\n+ display:flex;\n+ font-size: 150px;\n+ font-family: 'Sawarabi Mincho', sans-serif;\n+ justify-content: center;\n+ padding: 10px;\n+}\n+h2{\n+ display:flex;\n+ font-family: 'Sawarabi Mincho', sans-serif;\n+ font-size: 20px;\n+ justify-content: center;\n+}\n+p{\n+ background-color: #B2A3B5;\n+ list-style: none;\n+ display: flex;\n+ font-size: 15px;\n+ font: Arial;\n+ font-family: sans-serif;\n+ justify-content: space-between;\n+ padding: 5px;\n+}\n+p :link{\n+ text-decoration: none;\n+ color: #000000;\n+ background-color: #B2A3B5;\n+}\n+p :hover, p :active{\n+ text-decoration: none;\n+ color: white;\n+ font-size: 150%;\n+}\n+\n+\n+img {\n+ display: block;\n+ margin-left: auto;\n+ margin-right: auto;\n+ width: 50%;\n+}\n+\n+.flex-container{\n+ display: flex;\n+ flex-flow: wrap;\n+}\n+.item1{\n+ background-color: #C3BAAA;\n+ border: 3px solid #fff;\n+ padding: 20px;\n+ font-size: 1em;\n+ justify-content: center;\n+ text-align: center;\n+ font-family: 'Sawarabi Mincho', sans-serif;\n+}\n+.footer {","path":"styles/style.css","position":61,"original_position":61,"commit_id":"532e9617ffa8f52b7fb284a26b3fb7c925e292af","original_commit_id":"532e9617ffa8f52b7fb284a26b3fb7c925e292af","user":{"login":"dHelmgren","id":5455308,"node_id":"MDQ6VXNlcjU0NTUzMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/5455308?v=4","gravatar_id":"","url":"https://api.github.com/users/dHelmgren","html_url":"https://github.com/dHelmgren","followers_url":"https://api.github.com/users/dHelmgren/followers","following_url":"https://api.github.com/users/dHelmgren/following{/other_user}","gists_url":"https://api.github.com/users/dHelmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/dHelmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dHelmgren/subscriptions","organizations_url":"https://api.github.com/users/dHelmgren/orgs","repos_url":"https://api.github.com/users/dHelmgren/repos","events_url":"https://api.github.com/users/dHelmgren/events{/privacy}","received_events_url":"https://api.github.com/users/dHelmgren/received_events","type":"User","site_admin":false},"body":"You had this class style in more than one file. Seems like a good use case for a `main.css` that gives default styles across the site.","created_at":"2018-10-02T18:13:19Z","updated_at":"2018-10-02T18:48:28Z","html_url":"https://github.com/Ada-C10/personal-portfolio-site/pull/45#discussion_r222057652","pull_request_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/45","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/comments/222057652"},"html":{"href":"https://github.com/Ada-C10/personal-portfolio-site/pull/45#discussion_r222057652"},"pull_request":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/45","id":217166820,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3MTY2ODIw","html_url":"https://github.com/Ada-C10/personal-portfolio-site/pull/45","diff_url":"https://github.com/Ada-C10/personal-portfolio-site/pull/45.diff","patch_url":"https://github.com/Ada-C10/personal-portfolio-site/pull/45.patch","issue_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/issues/45","number":45,"state":"open","locked":false,"title":"Sherman, personal portfolio","user":{"login":"Peacegypsy","id":29167506,"node_id":"MDQ6VXNlcjI5MTY3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/29167506?v=4","gravatar_id":"","url":"https://api.github.com/users/Peacegypsy","html_url":"https://github.com/Peacegypsy","followers_url":"https://api.github.com/users/Peacegypsy/followers","following_url":"https://api.github.com/users/Peacegypsy/following{/other_user}","gists_url":"https://api.github.com/users/Peacegypsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Peacegypsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peacegypsy/subscriptions","organizations_url":"https://api.github.com/users/Peacegypsy/orgs","repos_url":"https://api.github.com/users/Peacegypsy/repos","events_url":"https://api.github.com/users/Peacegypsy/events{/privacy}","received_events_url":"https://api.github.com/users/Peacegypsy/received_events","type":"User","site_admin":false},"body":"# Personal Portfolio Site\r\nCongratulations! You're submitting your assignment!\r\n\r\n## Comprehension Questions\r\nQuestion | Answer\r\n:------------- | :-------------\r\nDid you have to resolve any issues when running the HTML Validator? If so, what were they? |incorrect links and some typos (misplaced or missing commas, unclosed parentheses ,etc.\r\nWhy is it important to consider and use semantic HTML? | to be able to style tags properly and to better relay to others what you have set up(clear communication)\r\nHow did you decide to structure your CSS? | It depended on the content mostly, but also I tried to utilize things we had covered in class while keeping a similar theme across all pages.\r\nWhat was the most challenging piece of this assignment? | coming up with the content idea and layout, followed by the css part.\r\nDescribe one area that you gained more clarity on when completing this assignment | using class in tags for better and more accurate styling.\r\n**Optional** |\r\nDid you deploy to GitHub Pages? If so, what is the URL to your website? |\r\n","created_at":"2018-09-21T04:11:12Z","updated_at":"2018-10-02T18:48:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66a0ad215bb381fd450b060cb19da651ce0c94e8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/45/commits","review_comments_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/45/comments","review_comment_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/issues/45/comments","statuses_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/statuses/532e9617ffa8f52b7fb284a26b3fb7c925e292af","head":{"label":"Peacegypsy:master","ref":"master","sha":"532e9617ffa8f52b7fb284a26b3fb7c925e292af","user":{"login":"Peacegypsy","id":29167506,"node_id":"MDQ6VXNlcjI5MTY3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/29167506?v=4","gravatar_id":"","url":"https://api.github.com/users/Peacegypsy","html_url":"https://github.com/Peacegypsy","followers_url":"https://api.github.com/users/Peacegypsy/followers","following_url":"https://api.github.com/users/Peacegypsy/following{/other_user}","gists_url":"https://api.github.com/users/Peacegypsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Peacegypsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peacegypsy/subscriptions","organizations_url":"https://api.github.com/users/Peacegypsy/orgs","repos_url":"https://api.github.com/users/Peacegypsy/repos","events_url":"https://api.github.com/users/Peacegypsy/events{/privacy}","received_events_url":"https://api.github.com/users/Peacegypsy/received_events","type":"User","site_admin":false},"repo":{"id":149066143,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkwNjYxNDM=","name":"personal-portfolio-site","full_name":"Peacegypsy/personal-portfolio-site","private":false,"owner":{"login":"Peacegypsy","id":29167506,"node_id":"MDQ6VXNlcjI5MTY3NTA2","avatar_url":"https://avatars0.githubusercontent.com/u/29167506?v=4","gravatar_id":"","url":"https://api.github.com/users/Peacegypsy","html_url":"https://github.com/Peacegypsy","followers_url":"https://api.github.com/users/Peacegypsy/followers","following_url":"https://api.github.com/users/Peacegypsy/following{/other_user}","gists_url":"https://api.github.com/users/Peacegypsy/gists{/gist_id}","starred_url":"https://api.github.com/users/Peacegypsy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Peacegypsy/subscriptions","organizations_url":"https://api.github.com/users/Peacegypsy/orgs","repos_url":"https://api.github.com/users/Peacegypsy/repos","events_url":"https://api.github.com/users/Peacegypsy/events{/privacy}","received_events_url":"https://api.github.com/users/Peacegypsy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Peacegypsy/personal-portfolio-site","description":"Project: Create a static site representing your portfolio of coding work","fork":true,"url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site","forks_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/forks","keys_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/teams","hooks_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/hooks","issue_events_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/issues/events{/number}","events_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/events","assignees_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/assignees{/user}","branches_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/branches{/branch}","tags_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/tags","blobs_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/statuses/{sha}","languages_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/languages","stargazers_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/stargazers","contributors_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/contributors","subscribers_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/subscribers","subscription_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/subscription","commits_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/contents/{+path}","compare_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/merges","archive_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/downloads","issues_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/issues{/number}","pulls_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/pulls{/number}","milestones_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/milestones{/number}","notifications_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/labels{/name}","releases_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/releases{/id}","deployments_url":"https://api.github.com/repos/Peacegypsy/personal-portfolio-site/deployments","created_at":"2018-09-17T03:53:40Z","updated_at":"2018-09-17T04:21:12Z","pushed_at":"2018-09-17T04:21:10Z","git_url":"git://github.com/Peacegypsy/personal-portfolio-site.git","ssh_url":"[email protected]:Peacegypsy/personal-portfolio-site.git","clone_url":"https://github.com/Peacegypsy/personal-portfolio-site.git","svn_url":"https://github.com/Peacegypsy/personal-portfolio-site","homepage":"","size":40865,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ada-C10:master","ref":"master","sha":"480c426560479ac0092b67bb49a21438cf53d069","user":{"login":"Ada-C10","id":40303054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzAzMDU0","avatar_url":"https://avatars0.githubusercontent.com/u/40303054?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C10","html_url":"https://github.com/Ada-C10","followers_url":"https://api.github.com/users/Ada-C10/followers","following_url":"https://api.github.com/users/Ada-C10/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C10/subscriptions","organizations_url":"https://api.github.com/users/Ada-C10/orgs","repos_url":"https://api.github.com/users/Ada-C10/repos","events_url":"https://api.github.com/users/Ada-C10/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C10/received_events","type":"Organization","site_admin":false},"repo":{"id":147875370,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc4NzUzNzA=","name":"personal-portfolio-site","full_name":"Ada-C10/personal-portfolio-site","private":false,"owner":{"login":"Ada-C10","id":40303054,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzAzMDU0","avatar_url":"https://avatars0.githubusercontent.com/u/40303054?v=4","gravatar_id":"","url":"https://api.github.com/users/Ada-C10","html_url":"https://github.com/Ada-C10","followers_url":"https://api.github.com/users/Ada-C10/followers","following_url":"https://api.github.com/users/Ada-C10/following{/other_user}","gists_url":"https://api.github.com/users/Ada-C10/gists{/gist_id}","starred_url":"https://api.github.com/users/Ada-C10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ada-C10/subscriptions","organizations_url":"https://api.github.com/users/Ada-C10/orgs","repos_url":"https://api.github.com/users/Ada-C10/repos","events_url":"https://api.github.com/users/Ada-C10/events{/privacy}","received_events_url":"https://api.github.com/users/Ada-C10/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Ada-C10/personal-portfolio-site","description":"Project: Create a static site representing your portfolio of coding work","fork":true,"url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site","forks_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/forks","keys_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/teams","hooks_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/hooks","issue_events_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/issues/events{/number}","events_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/events","assignees_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/assignees{/user}","branches_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/branches{/branch}","tags_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/tags","blobs_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/statuses/{sha}","languages_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/languages","stargazers_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/stargazers","contributors_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/contributors","subscribers_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/subscribers","subscription_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/subscription","commits_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/contents/{+path}","compare_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/merges","archive_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/downloads","issues_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/issues{/number}","pulls_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls{/number}","milestones_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/milestones{/number}","notifications_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/labels{/name}","releases_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/releases{/id}","deployments_url":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/deployments","created_at":"2018-09-07T21:13:50Z","updated_at":"2018-09-21T04:04:37Z","pushed_at":"2018-09-30T17:15:33Z","git_url":"git://github.com/Ada-C10/personal-portfolio-site.git","ssh_url":"[email protected]:Ada-C10/personal-portfolio-site.git","clone_url":"https://github.com/Ada-C10/personal-portfolio-site.git","svn_url":"https://github.com/Ada-C10/personal-portfolio-site","homepage":"","size":12,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":47,"license":null,"forks":48,"open_issues":47,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/45"},"html":{"href":"https://github.com/Ada-C10/personal-portfolio-site/pull/45"},"issue":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/issues/45"},"comments":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/Ada-C10/personal-portfolio-site/statuses/532e9617ffa8f52b7fb284a26b3fb7c925e292af"}},"author_association":"NONE"}}

8356546182

{"actor":{"display_login":"dHelmgren"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/comments/211474286","pull_request_review_id":147899487,"id":211474286,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTQ3NDI4Ng==","diff_hunk":"@@ -20,4 +24,31 @@\n private NormalUser normalUser;\n \n private Long quantity;\n+\n+ @Builder\n+ public ProductUserMap(NormalUser normalUser, Long quantity) {\n+ this.normalUser = normalUser;\n+ this.quantity = quantity;\n+ }","path":"src/main/java/com/woowahan/moduchan/domain/product/ProductUserMap.java","position":25,"original_position":25,"commit_id":"769d4d7601647981cdbd551c886a4121a022c80b","original_commit_id":"769d4d7601647981cdbd551c886a4121a022c80b","user":{"login":"mindock","id":32254667,"node_id":"MDQ6VXNlcjMyMjU0NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/32254667?v=4","gravatar_id":"","url":"https://api.github.com/users/mindock","html_url":"https://github.com/mindock","followers_url":"https://api.github.com/users/mindock/followers","following_url":"https://api.github.com/users/mindock/following{/other_user}","gists_url":"https://api.github.com/users/mindock/gists{/gist_id}","starred_url":"https://api.github.com/users/mindock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mindock/subscriptions","organizations_url":"https://api.github.com/users/mindock/orgs","repos_url":"https://api.github.com/users/mindock/repos","events_url":"https://api.github.com/users/mindock/events{/privacy}","received_events_url":"https://api.github.com/users/mindock/received_events","type":"User","site_admin":false},"body":"Product 인자로 받기 & private 로 접근 제한자 바꾸기","created_at":"2018-08-21T04:18:56Z","updated_at":"2018-08-21T04:51:00Z","html_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember/pull/67#discussion_r211474286","pull_request_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/67","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/comments/211474286"},"html":{"href":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember/pull/67#discussion_r211474286"},"pull_request":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/67","id":209690308,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NjkwMzA4","html_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember/pull/67","diff_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember/pull/67.diff","patch_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember/pull/67.patch","issue_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues/67","number":67,"state":"open","locked":false,"title":"Feat/project","user":{"login":"chldbtjd2272","id":25260024,"node_id":"MDQ6VXNlcjI1MjYwMDI0","avatar_url":"https://avatars1.githubusercontent.com/u/25260024?v=4","gravatar_id":"","url":"https://api.github.com/users/chldbtjd2272","html_url":"https://github.com/chldbtjd2272","followers_url":"https://api.github.com/users/chldbtjd2272/followers","following_url":"https://api.github.com/users/chldbtjd2272/following{/other_user}","gists_url":"https://api.github.com/users/chldbtjd2272/gists{/gist_id}","starred_url":"https://api.github.com/users/chldbtjd2272/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chldbtjd2272/subscriptions","organizations_url":"https://api.github.com/users/chldbtjd2272/orgs","repos_url":"https://api.github.com/users/chldbtjd2272/repos","events_url":"https://api.github.com/users/chldbtjd2272/events{/privacy}","received_events_url":"https://api.github.com/users/chldbtjd2272/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-21T02:16:00Z","updated_at":"2018-08-21T04:51:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48a04d5d529e6057c34cecc664e9ddcdadc70e79","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kwangilcho","id":12382114,"node_id":"MDQ6VXNlcjEyMzgyMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/12382114?v=4","gravatar_id":"","url":"https://api.github.com/users/kwangilcho","html_url":"https://github.com/kwangilcho","followers_url":"https://api.github.com/users/kwangilcho/followers","following_url":"https://api.github.com/users/kwangilcho/following{/other_user}","gists_url":"https://api.github.com/users/kwangilcho/gists{/gist_id}","starred_url":"https://api.github.com/users/kwangilcho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwangilcho/subscriptions","organizations_url":"https://api.github.com/users/kwangilcho/orgs","repos_url":"https://api.github.com/users/kwangilcho/repos","events_url":"https://api.github.com/users/kwangilcho/events{/privacy}","received_events_url":"https://api.github.com/users/kwangilcho/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/67/commits","review_comments_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/67/comments","review_comment_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues/67/comments","statuses_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/statuses/769d4d7601647981cdbd551c886a4121a022c80b","head":{"label":"wwh-techcamp-2018:feat/project","ref":"feat/project","sha":"769d4d7601647981cdbd551c886a4121a022c80b","user":{"login":"wwh-techcamp-2018","id":40353008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzUzMDA4","avatar_url":"https://avatars1.githubusercontent.com/u/40353008?v=4","gravatar_id":"","url":"https://api.github.com/users/wwh-techcamp-2018","html_url":"https://github.com/wwh-techcamp-2018","followers_url":"https://api.github.com/users/wwh-techcamp-2018/followers","following_url":"https://api.github.com/users/wwh-techcamp-2018/following{/other_user}","gists_url":"https://api.github.com/users/wwh-techcamp-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/wwh-techcamp-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwh-techcamp-2018/subscriptions","organizations_url":"https://api.github.com/users/wwh-techcamp-2018/orgs","repos_url":"https://api.github.com/users/wwh-techcamp-2018/repos","events_url":"https://api.github.com/users/wwh-techcamp-2018/events{/privacy}","received_events_url":"https://api.github.com/users/wwh-techcamp-2018/received_events","type":"Organization","site_admin":false},"repo":{"id":143090469,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwOTA0Njk=","name":"team6-SeeYouAtSeptember","full_name":"wwh-techcamp-2018/team6-SeeYouAtSeptember","owner":{"login":"wwh-techcamp-2018","id":40353008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzUzMDA4","avatar_url":"https://avatars1.githubusercontent.com/u/40353008?v=4","gravatar_id":"","url":"https://api.github.com/users/wwh-techcamp-2018","html_url":"https://github.com/wwh-techcamp-2018","followers_url":"https://api.github.com/users/wwh-techcamp-2018/followers","following_url":"https://api.github.com/users/wwh-techcamp-2018/following{/other_user}","gists_url":"https://api.github.com/users/wwh-techcamp-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/wwh-techcamp-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwh-techcamp-2018/subscriptions","organizations_url":"https://api.github.com/users/wwh-techcamp-2018/orgs","repos_url":"https://api.github.com/users/wwh-techcamp-2018/repos","events_url":"https://api.github.com/users/wwh-techcamp-2018/events{/privacy}","received_events_url":"https://api.github.com/users/wwh-techcamp-2018/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember","description":"6팀 프로젝트 저장소","fork":false,"url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember","forks_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/forks","keys_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/teams","hooks_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/hooks","issue_events_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues/events{/number}","events_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/events","assignees_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/assignees{/user}","branches_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/branches{/branch}","tags_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/tags","blobs_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/refs{/sha}","trees_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/statuses/{sha}","languages_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/languages","stargazers_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/stargazers","contributors_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/contributors","subscribers_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/subscribers","subscription_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/subscription","commits_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/commits{/sha}","git_commits_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/commits{/sha}","comments_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/comments{/number}","issue_comment_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues/comments{/number}","contents_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/contents/{+path}","compare_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/merges","archive_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/downloads","issues_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues{/number}","pulls_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls{/number}","milestones_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/milestones{/number}","notifications_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/labels{/name}","releases_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/releases{/id}","deployments_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/deployments","created_at":"2018-08-01T01:55:20Z","updated_at":"2018-08-21T02:17:13Z","pushed_at":"2018-08-21T02:16:00Z","git_url":"git://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember.git","ssh_url":"[email protected]:wwh-techcamp-2018/team6-SeeYouAtSeptember.git","clone_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember.git","svn_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember","homepage":null,"size":5168,"stargazers_count":4,"watchers_count":4,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":4,"open_issues":32,"watchers":4,"default_branch":"master"}},"base":{"label":"wwh-techcamp-2018:develop","ref":"develop","sha":"13d1703fe466fd5f4ce9cad1ecc0def45ef5968c","user":{"login":"wwh-techcamp-2018","id":40353008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzUzMDA4","avatar_url":"https://avatars1.githubusercontent.com/u/40353008?v=4","gravatar_id":"","url":"https://api.github.com/users/wwh-techcamp-2018","html_url":"https://github.com/wwh-techcamp-2018","followers_url":"https://api.github.com/users/wwh-techcamp-2018/followers","following_url":"https://api.github.com/users/wwh-techcamp-2018/following{/other_user}","gists_url":"https://api.github.com/users/wwh-techcamp-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/wwh-techcamp-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwh-techcamp-2018/subscriptions","organizations_url":"https://api.github.com/users/wwh-techcamp-2018/orgs","repos_url":"https://api.github.com/users/wwh-techcamp-2018/repos","events_url":"https://api.github.com/users/wwh-techcamp-2018/events{/privacy}","received_events_url":"https://api.github.com/users/wwh-techcamp-2018/received_events","type":"Organization","site_admin":false},"repo":{"id":143090469,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwOTA0Njk=","name":"team6-SeeYouAtSeptember","full_name":"wwh-techcamp-2018/team6-SeeYouAtSeptember","owner":{"login":"wwh-techcamp-2018","id":40353008,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzUzMDA4","avatar_url":"https://avatars1.githubusercontent.com/u/40353008?v=4","gravatar_id":"","url":"https://api.github.com/users/wwh-techcamp-2018","html_url":"https://github.com/wwh-techcamp-2018","followers_url":"https://api.github.com/users/wwh-techcamp-2018/followers","following_url":"https://api.github.com/users/wwh-techcamp-2018/following{/other_user}","gists_url":"https://api.github.com/users/wwh-techcamp-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/wwh-techcamp-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wwh-techcamp-2018/subscriptions","organizations_url":"https://api.github.com/users/wwh-techcamp-2018/orgs","repos_url":"https://api.github.com/users/wwh-techcamp-2018/repos","events_url":"https://api.github.com/users/wwh-techcamp-2018/events{/privacy}","received_events_url":"https://api.github.com/users/wwh-techcamp-2018/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember","description":"6팀 프로젝트 저장소","fork":false,"url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember","forks_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/forks","keys_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/teams","hooks_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/hooks","issue_events_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues/events{/number}","events_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/events","assignees_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/assignees{/user}","branches_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/branches{/branch}","tags_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/tags","blobs_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/refs{/sha}","trees_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/statuses/{sha}","languages_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/languages","stargazers_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/stargazers","contributors_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/contributors","subscribers_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/subscribers","subscription_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/subscription","commits_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/commits{/sha}","git_commits_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/git/commits{/sha}","comments_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/comments{/number}","issue_comment_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues/comments{/number}","contents_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/contents/{+path}","compare_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/merges","archive_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/downloads","issues_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues{/number}","pulls_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls{/number}","milestones_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/milestones{/number}","notifications_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/labels{/name}","releases_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/releases{/id}","deployments_url":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/deployments","created_at":"2018-08-01T01:55:20Z","updated_at":"2018-08-21T02:17:13Z","pushed_at":"2018-08-21T02:16:00Z","git_url":"git://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember.git","ssh_url":"[email protected]:wwh-techcamp-2018/team6-SeeYouAtSeptember.git","clone_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember.git","svn_url":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember","homepage":null,"size":5168,"stargazers_count":4,"watchers_count":4,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":32,"license":null,"forks":4,"open_issues":32,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/67"},"html":{"href":"https://github.com/wwh-techcamp-2018/team6-SeeYouAtSeptember/pull/67"},"issue":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues/67"},"comments":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/wwh-techcamp-2018/team6-SeeYouAtSeptember/statuses/769d4d7601647981cdbd551c886a4121a022c80b"}},"author_association":"COLLABORATOR"}}

8141865897

{"actor":{"display_login":"mindock"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/rpt-labs/attendance/pulls/comments/223904115","pull_request_review_id":163146384,"id":223904115,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzkwNDExNQ==","diff_hunk":"@@ -1,19 +1,17 @@\n function flattenZoomResults(zoomResults){\n+ if (!zoomResults.length) {\n+ console.log(\"Zoom rooms are currently empty\");\n+ return zoomResults;\n+ }\n if (zoomResults[0].room) {\n console.log('🧚‍ running sample data');\n return zoomResults\n }\n \n- let studentsPresent = []\n- // console.log(zoomResults)\n-\n- if (zoomResults.length < 1 || zoomResults === undefined) {\n- console.log(\"There are no students in any Zoom Room\");\n- return false;\n- }\n+ let studentsPresent = [];\n \n for (var i = 0; i < zoomResults.length; i++) {\n- let session = zoomResults[i].liveAttendance.map(student => {\n+ let session = zoomResults[i].liveAttendance.map((student) => {","path":"utils/flattenZoomResults.js","position":23,"original_position":22,"commit_id":"a3cb564d86cc122e6f414275b2e0f03ac4416213","original_commit_id":"dd82e093a5dc0a6801a8bbb3cc5efab12626f420","user":{"login":"magee","id":15180,"node_id":"MDQ6VXNlcjE1MTgw","avatar_url":"https://avatars0.githubusercontent.com/u/15180?v=4","gravatar_id":"","url":"https://api.github.com/users/magee","html_url":"https://github.com/magee","followers_url":"https://api.github.com/users/magee/followers","following_url":"https://api.github.com/users/magee/following{/other_user}","gists_url":"https://api.github.com/users/magee/gists{/gist_id}","starred_url":"https://api.github.com/users/magee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magee/subscriptions","organizations_url":"https://api.github.com/users/magee/orgs","repos_url":"https://api.github.com/users/magee/repos","events_url":"https://api.github.com/users/magee/events{/privacy}","received_events_url":"https://api.github.com/users/magee/received_events","type":"User","site_admin":false},"body":"That's 100% right. I want them. This old person with bad vision finds it easier to skim what's happening with the cues given by the parens.","created_at":"2018-10-10T00:19:40Z","updated_at":"2018-10-10T00:19:51Z","html_url":"https://github.com/rpt-labs/attendance/pull/16#discussion_r223904115","pull_request_url":"https://api.github.com/repos/rpt-labs/attendance/pulls/16","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rpt-labs/attendance/pulls/comments/223904115"},"html":{"href":"https://github.com/rpt-labs/attendance/pull/16#discussion_r223904115"},"pull_request":{"href":"https://api.github.com/repos/rpt-labs/attendance/pulls/16"}},"in_reply_to_id":223877026},"pull_request":{"url":"https://api.github.com/repos/rpt-labs/attendance/pulls/16","id":221592539,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTkyNTM5","html_url":"https://github.com/rpt-labs/attendance/pull/16","diff_url":"https://github.com/rpt-labs/attendance/pull/16.diff","patch_url":"https://github.com/rpt-labs/attendance/pull/16.patch","issue_url":"https://api.github.com/repos/rpt-labs/attendance/issues/16","number":16,"state":"open","locked":false,"title":"Handle empty zoom","user":{"login":"michellelockett","id":19374552,"node_id":"MDQ6VXNlcjE5Mzc0NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/19374552?v=4","gravatar_id":"","url":"https://api.github.com/users/michellelockett","html_url":"https://github.com/michellelockett","followers_url":"https://api.github.com/users/michellelockett/followers","following_url":"https://api.github.com/users/michellelockett/following{/other_user}","gists_url":"https://api.github.com/users/michellelockett/gists{/gist_id}","starred_url":"https://api.github.com/users/michellelockett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellelockett/subscriptions","organizations_url":"https://api.github.com/users/michellelockett/orgs","repos_url":"https://api.github.com/users/michellelockett/repos","events_url":"https://api.github.com/users/michellelockett/events{/privacy}","received_events_url":"https://api.github.com/users/michellelockett/received_events","type":"User","site_admin":false},"body":"Returns data as expected when zoom rooms are empty. Also adds in a few semicolons. ;)","created_at":"2018-10-09T21:31:54Z","updated_at":"2018-10-10T00:19:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86be9c1e5f443254b2af8e4eadfd07be431b1b9f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rpt-labs/attendance/pulls/16/commits","review_comments_url":"https://api.github.com/repos/rpt-labs/attendance/pulls/16/comments","review_comment_url":"https://api.github.com/repos/rpt-labs/attendance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rpt-labs/attendance/issues/16/comments","statuses_url":"https://api.github.com/repos/rpt-labs/attendance/statuses/a3cb564d86cc122e6f414275b2e0f03ac4416213","head":{"label":"michellelockett:handleEmptyZoom","ref":"handleEmptyZoom","sha":"a3cb564d86cc122e6f414275b2e0f03ac4416213","user":{"login":"michellelockett","id":19374552,"node_id":"MDQ6VXNlcjE5Mzc0NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/19374552?v=4","gravatar_id":"","url":"https://api.github.com/users/michellelockett","html_url":"https://github.com/michellelockett","followers_url":"https://api.github.com/users/michellelockett/followers","following_url":"https://api.github.com/users/michellelockett/following{/other_user}","gists_url":"https://api.github.com/users/michellelockett/gists{/gist_id}","starred_url":"https://api.github.com/users/michellelockett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellelockett/subscriptions","organizations_url":"https://api.github.com/users/michellelockett/orgs","repos_url":"https://api.github.com/users/michellelockett/repos","events_url":"https://api.github.com/users/michellelockett/events{/privacy}","received_events_url":"https://api.github.com/users/michellelockett/received_events","type":"User","site_admin":false},"repo":{"id":149644072,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NDQwNzI=","name":"attendance","full_name":"michellelockett/attendance","private":false,"owner":{"login":"michellelockett","id":19374552,"node_id":"MDQ6VXNlcjE5Mzc0NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/19374552?v=4","gravatar_id":"","url":"https://api.github.com/users/michellelockett","html_url":"https://github.com/michellelockett","followers_url":"https://api.github.com/users/michellelockett/followers","following_url":"https://api.github.com/users/michellelockett/following{/other_user}","gists_url":"https://api.github.com/users/michellelockett/gists{/gist_id}","starred_url":"https://api.github.com/users/michellelockett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michellelockett/subscriptions","organizations_url":"https://api.github.com/users/michellelockett/orgs","repos_url":"https://api.github.com/users/michellelockett/repos","events_url":"https://api.github.com/users/michellelockett/events{/privacy}","received_events_url":"https://api.github.com/users/michellelockett/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michellelockett/attendance","description":null,"fork":true,"url":"https://api.github.com/repos/michellelockett/attendance","forks_url":"https://api.github.com/repos/michellelockett/attendance/forks","keys_url":"https://api.github.com/repos/michellelockett/attendance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michellelockett/attendance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michellelockett/attendance/teams","hooks_url":"https://api.github.com/repos/michellelockett/attendance/hooks","issue_events_url":"https://api.github.com/repos/michellelockett/attendance/issues/events{/number}","events_url":"https://api.github.com/repos/michellelockett/attendance/events","assignees_url":"https://api.github.com/repos/michellelockett/attendance/assignees{/user}","branches_url":"https://api.github.com/repos/michellelockett/attendance/branches{/branch}","tags_url":"https://api.github.com/repos/michellelockett/attendance/tags","blobs_url":"https://api.github.com/repos/michellelockett/attendance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michellelockett/attendance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michellelockett/attendance/git/refs{/sha}","trees_url":"https://api.github.com/repos/michellelockett/attendance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michellelockett/attendance/statuses/{sha}","languages_url":"https://api.github.com/repos/michellelockett/attendance/languages","stargazers_url":"https://api.github.com/repos/michellelockett/attendance/stargazers","contributors_url":"https://api.github.com/repos/michellelockett/attendance/contributors","subscribers_url":"https://api.github.com/repos/michellelockett/attendance/subscribers","subscription_url":"https://api.github.com/repos/michellelockett/attendance/subscription","commits_url":"https://api.github.com/repos/michellelockett/attendance/commits{/sha}","git_commits_url":"https://api.github.com/repos/michellelockett/attendance/git/commits{/sha}","comments_url":"https://api.github.com/repos/michellelockett/attendance/comments{/number}","issue_comment_url":"https://api.github.com/repos/michellelockett/attendance/issues/comments{/number}","contents_url":"https://api.github.com/repos/michellelockett/attendance/contents/{+path}","compare_url":"https://api.github.com/repos/michellelockett/attendance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michellelockett/attendance/merges","archive_url":"https://api.github.com/repos/michellelockett/attendance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michellelockett/attendance/downloads","issues_url":"https://api.github.com/repos/michellelockett/attendance/issues{/number}","pulls_url":"https://api.github.com/repos/michellelockett/attendance/pulls{/number}","milestones_url":"https://api.github.com/repos/michellelockett/attendance/milestones{/number}","notifications_url":"https://api.github.com/repos/michellelockett/attendance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michellelockett/attendance/labels{/name}","releases_url":"https://api.github.com/repos/michellelockett/attendance/releases{/id}","deployments_url":"https://api.github.com/repos/michellelockett/attendance/deployments","created_at":"2018-09-20T17:13:05Z","updated_at":"2018-10-09T04:28:35Z","pushed_at":"2018-10-09T23:20:11Z","git_url":"git://github.com/michellelockett/attendance.git","ssh_url":"[email protected]:michellelockett/attendance.git","clone_url":"https://github.com/michellelockett/attendance.git","svn_url":"https://github.com/michellelockett/attendance","homepage":null,"size":315,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rpt-labs:master","ref":"master","sha":"ae557b6e43c86ac0858eea532e65451d5ebe65ea","user":{"login":"rpt-labs","id":40478544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDc4NTQ0","avatar_url":"https://avatars0.githubusercontent.com/u/40478544?v=4","gravatar_id":"","url":"https://api.github.com/users/rpt-labs","html_url":"https://github.com/rpt-labs","followers_url":"https://api.github.com/users/rpt-labs/followers","following_url":"https://api.github.com/users/rpt-labs/following{/other_user}","gists_url":"https://api.github.com/users/rpt-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/rpt-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpt-labs/subscriptions","organizations_url":"https://api.github.com/users/rpt-labs/orgs","repos_url":"https://api.github.com/users/rpt-labs/repos","events_url":"https://api.github.com/users/rpt-labs/events{/privacy}","received_events_url":"https://api.github.com/users/rpt-labs/received_events","type":"Organization","site_admin":false},"repo":{"id":139918292,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5MTgyOTI=","name":"attendance","full_name":"rpt-labs/attendance","private":false,"owner":{"login":"rpt-labs","id":40478544,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDc4NTQ0","avatar_url":"https://avatars0.githubusercontent.com/u/40478544?v=4","gravatar_id":"","url":"https://api.github.com/users/rpt-labs","html_url":"https://github.com/rpt-labs","followers_url":"https://api.github.com/users/rpt-labs/followers","following_url":"https://api.github.com/users/rpt-labs/following{/other_user}","gists_url":"https://api.github.com/users/rpt-labs/gists{/gist_id}","starred_url":"https://api.github.com/users/rpt-labs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rpt-labs/subscriptions","organizations_url":"https://api.github.com/users/rpt-labs/orgs","repos_url":"https://api.github.com/users/rpt-labs/repos","events_url":"https://api.github.com/users/rpt-labs/events{/privacy}","received_events_url":"https://api.github.com/users/rpt-labs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rpt-labs/attendance","description":null,"fork":false,"url":"https://api.github.com/repos/rpt-labs/attendance","forks_url":"https://api.github.com/repos/rpt-labs/attendance/forks","keys_url":"https://api.github.com/repos/rpt-labs/attendance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rpt-labs/attendance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rpt-labs/attendance/teams","hooks_url":"https://api.github.com/repos/rpt-labs/attendance/hooks","issue_events_url":"https://api.github.com/repos/rpt-labs/attendance/issues/events{/number}","events_url":"https://api.github.com/repos/rpt-labs/attendance/events","assignees_url":"https://api.github.com/repos/rpt-labs/attendance/assignees{/user}","branches_url":"https://api.github.com/repos/rpt-labs/attendance/branches{/branch}","tags_url":"https://api.github.com/repos/rpt-labs/attendance/tags","blobs_url":"https://api.github.com/repos/rpt-labs/attendance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rpt-labs/attendance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rpt-labs/attendance/git/refs{/sha}","trees_url":"https://api.github.com/repos/rpt-labs/attendance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rpt-labs/attendance/statuses/{sha}","languages_url":"https://api.github.com/repos/rpt-labs/attendance/languages","stargazers_url":"https://api.github.com/repos/rpt-labs/attendance/stargazers","contributors_url":"https://api.github.com/repos/rpt-labs/attendance/contributors","subscribers_url":"https://api.github.com/repos/rpt-labs/attendance/subscribers","subscription_url":"https://api.github.com/repos/rpt-labs/attendance/subscription","commits_url":"https://api.github.com/repos/rpt-labs/attendance/commits{/sha}","git_commits_url":"https://api.github.com/repos/rpt-labs/attendance/git/commits{/sha}","comments_url":"https://api.github.com/repos/rpt-labs/attendance/comments{/number}","issue_comment_url":"https://api.github.com/repos/rpt-labs/attendance/issues/comments{/number}","contents_url":"https://api.github.com/repos/rpt-labs/attendance/contents/{+path}","compare_url":"https://api.github.com/repos/rpt-labs/attendance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rpt-labs/attendance/merges","archive_url":"https://api.github.com/repos/rpt-labs/attendance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rpt-labs/attendance/downloads","issues_url":"https://api.github.com/repos/rpt-labs/attendance/issues{/number}","pulls_url":"https://api.github.com/repos/rpt-labs/attendance/pulls{/number}","milestones_url":"https://api.github.com/repos/rpt-labs/attendance/milestones{/number}","notifications_url":"https://api.github.com/repos/rpt-labs/attendance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rpt-labs/attendance/labels{/name}","releases_url":"https://api.github.com/repos/rpt-labs/attendance/releases{/id}","deployments_url":"https://api.github.com/repos/rpt-labs/attendance/deployments","created_at":"2018-07-06T01:28:58Z","updated_at":"2018-10-09T18:02:36Z","pushed_at":"2018-10-09T23:20:12Z","git_url":"git://github.com/rpt-labs/attendance.git","ssh_url":"[email protected]:rpt-labs/attendance.git","clone_url":"https://github.com/rpt-labs/attendance.git","svn_url":"https://github.com/rpt-labs/attendance","homepage":null,"size":232,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":4,"open_issues":4,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rpt-labs/attendance/pulls/16"},"html":{"href":"https://github.com/rpt-labs/attendance/pull/16"},"issue":{"href":"https://api.github.com/repos/rpt-labs/attendance/issues/16"},"comments":{"href":"https://api.github.com/repos/rpt-labs/attendance/issues/16/comments"},"review_comments":{"href":"https://api.github.com/repos/rpt-labs/attendance/pulls/16/comments"},"review_comment":{"href":"https://api.github.com/repos/rpt-labs/attendance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rpt-labs/attendance/pulls/16/commits"},"statuses":{"href":"https://api.github.com/repos/rpt-labs/attendance/statuses/a3cb564d86cc122e6f414275b2e0f03ac4416213"}},"author_association":"CONTRIBUTOR"}}

8394377681

{"actor":{"display_login":"magee"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/comments/224672103","pull_request_review_id":164099286,"id":224672103,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDY3MjEwMw==","diff_hunk":"@@ -8,20 +8,51 @@\n public class Ship {\n \n @JsonProperty private List<Square> occupiedSquares;\n+ private int length;\n \n- public Ship() {\n- occupiedSquares = new ArrayList<>();\n- }\n-\n+ /**\n+ * Right now this sets the length of the ship. Maybe in the future we might want a list of names and return lengths based on the name but this seems to work fine as is\n+ * @param kind\n+ */\n public Ship(String kind) {\n- //TODO implement\n+ switch(kind) {\n+ case \"DESTROYER\":\n+ length = 2;\n+ break;\n+ case \"BATTLESHIP\":\n+ length = 4;\n+ break;\n+ case \"CRUISER\":\n+ length = 3;\n+ break;","path":"src/main/java/cs361/battleships/models/Ship.java","position":25,"original_position":25,"commit_id":"77bf7f28c7d1501762898ca5b5c871c3cfd514f4","original_commit_id":"77bf7f28c7d1501762898ca5b5c871c3cfd514f4","user":{"login":"ianbrown9475","id":32145829,"node_id":"MDQ6VXNlcjMyMTQ1ODI5","avatar_url":"https://avatars2.githubusercontent.com/u/32145829?v=4","gravatar_id":"","url":"https://api.github.com/users/ianbrown9475","html_url":"https://github.com/ianbrown9475","followers_url":"https://api.github.com/users/ianbrown9475/followers","following_url":"https://api.github.com/users/ianbrown9475/following{/other_user}","gists_url":"https://api.github.com/users/ianbrown9475/gists{/gist_id}","starred_url":"https://api.github.com/users/ianbrown9475/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianbrown9475/subscriptions","organizations_url":"https://api.github.com/users/ianbrown9475/orgs","repos_url":"https://api.github.com/users/ianbrown9475/repos","events_url":"https://api.github.com/users/ianbrown9475/events{/privacy}","received_events_url":"https://api.github.com/users/ianbrown9475/received_events","type":"User","site_admin":false},"body":"Looks like `\"MINESWEEPER\"` should be length 2, `\"DESTROYER\"` should be length 3","created_at":"2018-10-12T05:10:39Z","updated_at":"2018-10-12T05:10:40Z","html_url":"https://github.com/cs361fall2018/project-team-12/pull/17#discussion_r224672103","pull_request_url":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/17","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/comments/224672103"},"html":{"href":"https://github.com/cs361fall2018/project-team-12/pull/17#discussion_r224672103"},"pull_request":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/17"}}},"pull_request":{"url":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/17","id":221995421,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTk1NDIx","html_url":"https://github.com/cs361fall2018/project-team-12/pull/17","diff_url":"https://github.com/cs361fall2018/project-team-12/pull/17.diff","patch_url":"https://github.com/cs361fall2018/project-team-12/pull/17.patch","issue_url":"https://api.github.com/repos/cs361fall2018/project-team-12/issues/17","number":17,"state":"open","locked":false,"title":"Issue 3 boat placement","user":{"login":"foshay","id":25090017,"node_id":"MDQ6VXNlcjI1MDkwMDE3","avatar_url":"https://avatars3.githubusercontent.com/u/25090017?v=4","gravatar_id":"","url":"https://api.github.com/users/foshay","html_url":"https://github.com/foshay","followers_url":"https://api.github.com/users/foshay/followers","following_url":"https://api.github.com/users/foshay/following{/other_user}","gists_url":"https://api.github.com/users/foshay/gists{/gist_id}","starred_url":"https://api.github.com/users/foshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foshay/subscriptions","organizations_url":"https://api.github.com/users/foshay/orgs","repos_url":"https://api.github.com/users/foshay/repos","events_url":"https://api.github.com/users/foshay/events{/privacy}","received_events_url":"https://api.github.com/users/foshay/received_events","type":"User","site_admin":false},"body":"I seriously hate git right now and just hope this works.","created_at":"2018-10-11T03:26:51Z","updated_at":"2018-10-12T05:10:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d38929366b28b7d12fffde0537bcd9d8f2dd04e","assignee":{"login":"foshay","id":25090017,"node_id":"MDQ6VXNlcjI1MDkwMDE3","avatar_url":"https://avatars3.githubusercontent.com/u/25090017?v=4","gravatar_id":"","url":"https://api.github.com/users/foshay","html_url":"https://github.com/foshay","followers_url":"https://api.github.com/users/foshay/followers","following_url":"https://api.github.com/users/foshay/following{/other_user}","gists_url":"https://api.github.com/users/foshay/gists{/gist_id}","starred_url":"https://api.github.com/users/foshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foshay/subscriptions","organizations_url":"https://api.github.com/users/foshay/orgs","repos_url":"https://api.github.com/users/foshay/repos","events_url":"https://api.github.com/users/foshay/events{/privacy}","received_events_url":"https://api.github.com/users/foshay/received_events","type":"User","site_admin":false},"assignees":[{"login":"foshay","id":25090017,"node_id":"MDQ6VXNlcjI1MDkwMDE3","avatar_url":"https://avatars3.githubusercontent.com/u/25090017?v=4","gravatar_id":"","url":"https://api.github.com/users/foshay","html_url":"https://github.com/foshay","followers_url":"https://api.github.com/users/foshay/followers","following_url":"https://api.github.com/users/foshay/following{/other_user}","gists_url":"https://api.github.com/users/foshay/gists{/gist_id}","starred_url":"https://api.github.com/users/foshay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/foshay/subscriptions","organizations_url":"https://api.github.com/users/foshay/orgs","repos_url":"https://api.github.com/users/foshay/repos","events_url":"https://api.github.com/users/foshay/events{/privacy}","received_events_url":"https://api.github.com/users/foshay/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/cs361fall2018/project-team-12/milestones/1","html_url":"https://github.com/cs361fall2018/project-team-12/milestone/1","labels_url":"https://api.github.com/repos/cs361fall2018/project-team-12/milestones/1/labels","id":3717202,"node_id":"MDk6TWlsZXN0b25lMzcxNzIwMg==","number":1,"title":"Sprint 1","description":"","creator":{"login":"ianbrown9475","id":32145829,"node_id":"MDQ6VXNlcjMyMTQ1ODI5","avatar_url":"https://avatars2.githubusercontent.com/u/32145829?v=4","gravatar_id":"","url":"https://api.github.com/users/ianbrown9475","html_url":"https://github.com/ianbrown9475","followers_url":"https://api.github.com/users/ianbrown9475/followers","following_url":"https://api.github.com/users/ianbrown9475/following{/other_user}","gists_url":"https://api.github.com/users/ianbrown9475/gists{/gist_id}","starred_url":"https://api.github.com/users/ianbrown9475/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ianbrown9475/subscriptions","organizations_url":"https://api.github.com/users/ianbrown9475/orgs","repos_url":"https://api.github.com/users/ianbrown9475/repos","events_url":"https://api.github.com/users/ianbrown9475/events{/privacy}","received_events_url":"https://api.github.com/users/ianbrown9475/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":6,"state":"open","created_at":"2018-10-07T01:04:29Z","updated_at":"2018-10-12T04:26:48Z","due_on":"2018-10-12T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/17/commits","review_comments_url":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/17/comments","review_comment_url":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cs361fall2018/project-team-12/issues/17/comments","statuses_url":"https://api.github.com/repos/cs361fall2018/project-team-12/statuses/77bf7f28c7d1501762898ca5b5c871c3cfd514f4","head":{"label":"cs361fall2018:issue-3-boatPlacement","ref":"issue-3-boatPlacement","sha":"77bf7f28c7d1501762898ca5b5c871c3cfd514f4","user":{"login":"cs361fall2018","id":40479452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDc5NDUy","avatar_url":"https://avatars3.githubusercontent.com/u/40479452?v=4","gravatar_id":"","url":"https://api.github.com/users/cs361fall2018","html_url":"https://github.com/cs361fall2018","followers_url":"https://api.github.com/users/cs361fall2018/followers","following_url":"https://api.github.com/users/cs361fall2018/following{/other_user}","gists_url":"https://api.github.com/users/cs361fall2018/gists{/gist_id}","starred_url":"https://api.github.com/users/cs361fall2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs361fall2018/subscriptions","organizations_url":"https://api.github.com/users/cs361fall2018/orgs","repos_url":"https://api.github.com/users/cs361fall2018/repos","events_url":"https://api.github.com/users/cs361fall2018/events{/privacy}","received_events_url":"https://api.github.com/users/cs361fall2018/received_events","type":"Organization","site_admin":false},"repo":{"id":151129474,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMjk0NzQ=","name":"project-team-12","full_name":"cs361fall2018/project-team-12","private":false,"owner":{"login":"cs361fall2018","id":40479452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDc5NDUy","avatar_url":"https://avatars3.githubusercontent.com/u/40479452?v=4","gravatar_id":"","url":"https://api.github.com/users/cs361fall2018","html_url":"https://github.com/cs361fall2018","followers_url":"https://api.github.com/users/cs361fall2018/followers","following_url":"https://api.github.com/users/cs361fall2018/following{/other_user}","gists_url":"https://api.github.com/users/cs361fall2018/gists{/gist_id}","starred_url":"https://api.github.com/users/cs361fall2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs361fall2018/subscriptions","organizations_url":"https://api.github.com/users/cs361fall2018/orgs","repos_url":"https://api.github.com/users/cs361fall2018/repos","events_url":"https://api.github.com/users/cs361fall2018/events{/privacy}","received_events_url":"https://api.github.com/users/cs361fall2018/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cs361fall2018/project-team-12","description":"project-team-12 created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/cs361fall2018/project-team-12","forks_url":"https://api.github.com/repos/cs361fall2018/project-team-12/forks","keys_url":"https://api.github.com/repos/cs361fall2018/project-team-12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cs361fall2018/project-team-12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cs361fall2018/project-team-12/teams","hooks_url":"https://api.github.com/repos/cs361fall2018/project-team-12/hooks","issue_events_url":"https://api.github.com/repos/cs361fall2018/project-team-12/issues/events{/number}","events_url":"https://api.github.com/repos/cs361fall2018/project-team-12/events","assignees_url":"https://api.github.com/repos/cs361fall2018/project-team-12/assignees{/user}","branches_url":"https://api.github.com/repos/cs361fall2018/project-team-12/branches{/branch}","tags_url":"https://api.github.com/repos/cs361fall2018/project-team-12/tags","blobs_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/refs{/sha}","trees_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cs361fall2018/project-team-12/statuses/{sha}","languages_url":"https://api.github.com/repos/cs361fall2018/project-team-12/languages","stargazers_url":"https://api.github.com/repos/cs361fall2018/project-team-12/stargazers","contributors_url":"https://api.github.com/repos/cs361fall2018/project-team-12/contributors","subscribers_url":"https://api.github.com/repos/cs361fall2018/project-team-12/subscribers","subscription_url":"https://api.github.com/repos/cs361fall2018/project-team-12/subscription","commits_url":"https://api.github.com/repos/cs361fall2018/project-team-12/commits{/sha}","git_commits_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/commits{/sha}","comments_url":"https://api.github.com/repos/cs361fall2018/project-team-12/comments{/number}","issue_comment_url":"https://api.github.com/repos/cs361fall2018/project-team-12/issues/comments{/number}","contents_url":"https://api.github.com/repos/cs361fall2018/project-team-12/contents/{+path}","compare_url":"https://api.github.com/repos/cs361fall2018/project-team-12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cs361fall2018/project-team-12/merges","archive_url":"https://api.github.com/repos/cs361fall2018/project-team-12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cs361fall2018/project-team-12/downloads","issues_url":"https://api.github.com/repos/cs361fall2018/project-team-12/issues{/number}","pulls_url":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls{/number}","milestones_url":"https://api.github.com/repos/cs361fall2018/project-team-12/milestones{/number}","notifications_url":"https://api.github.com/repos/cs361fall2018/project-team-12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cs361fall2018/project-team-12/labels{/name}","releases_url":"https://api.github.com/repos/cs361fall2018/project-team-12/releases{/id}","deployments_url":"https://api.github.com/repos/cs361fall2018/project-team-12/deployments","created_at":"2018-10-01T17:32:32Z","updated_at":"2018-10-12T00:43:09Z","pushed_at":"2018-10-12T04:59:55Z","git_url":"git://github.com/cs361fall2018/project-team-12.git","ssh_url":"[email protected]:cs361fall2018/project-team-12.git","clone_url":"https://github.com/cs361fall2018/project-team-12.git","svn_url":"https://github.com/cs361fall2018/project-team-12","homepage":null,"size":85,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"base":{"label":"cs361fall2018:master","ref":"master","sha":"883c2bfea123af4ad23d750dd20c07dfae68d209","user":{"login":"cs361fall2018","id":40479452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDc5NDUy","avatar_url":"https://avatars3.githubusercontent.com/u/40479452?v=4","gravatar_id":"","url":"https://api.github.com/users/cs361fall2018","html_url":"https://github.com/cs361fall2018","followers_url":"https://api.github.com/users/cs361fall2018/followers","following_url":"https://api.github.com/users/cs361fall2018/following{/other_user}","gists_url":"https://api.github.com/users/cs361fall2018/gists{/gist_id}","starred_url":"https://api.github.com/users/cs361fall2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs361fall2018/subscriptions","organizations_url":"https://api.github.com/users/cs361fall2018/orgs","repos_url":"https://api.github.com/users/cs361fall2018/repos","events_url":"https://api.github.com/users/cs361fall2018/events{/privacy}","received_events_url":"https://api.github.com/users/cs361fall2018/received_events","type":"Organization","site_admin":false},"repo":{"id":151129474,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMjk0NzQ=","name":"project-team-12","full_name":"cs361fall2018/project-team-12","private":false,"owner":{"login":"cs361fall2018","id":40479452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDc5NDUy","avatar_url":"https://avatars3.githubusercontent.com/u/40479452?v=4","gravatar_id":"","url":"https://api.github.com/users/cs361fall2018","html_url":"https://github.com/cs361fall2018","followers_url":"https://api.github.com/users/cs361fall2018/followers","following_url":"https://api.github.com/users/cs361fall2018/following{/other_user}","gists_url":"https://api.github.com/users/cs361fall2018/gists{/gist_id}","starred_url":"https://api.github.com/users/cs361fall2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cs361fall2018/subscriptions","organizations_url":"https://api.github.com/users/cs361fall2018/orgs","repos_url":"https://api.github.com/users/cs361fall2018/repos","events_url":"https://api.github.com/users/cs361fall2018/events{/privacy}","received_events_url":"https://api.github.com/users/cs361fall2018/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cs361fall2018/project-team-12","description":"project-team-12 created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/cs361fall2018/project-team-12","forks_url":"https://api.github.com/repos/cs361fall2018/project-team-12/forks","keys_url":"https://api.github.com/repos/cs361fall2018/project-team-12/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cs361fall2018/project-team-12/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cs361fall2018/project-team-12/teams","hooks_url":"https://api.github.com/repos/cs361fall2018/project-team-12/hooks","issue_events_url":"https://api.github.com/repos/cs361fall2018/project-team-12/issues/events{/number}","events_url":"https://api.github.com/repos/cs361fall2018/project-team-12/events","assignees_url":"https://api.github.com/repos/cs361fall2018/project-team-12/assignees{/user}","branches_url":"https://api.github.com/repos/cs361fall2018/project-team-12/branches{/branch}","tags_url":"https://api.github.com/repos/cs361fall2018/project-team-12/tags","blobs_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/refs{/sha}","trees_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cs361fall2018/project-team-12/statuses/{sha}","languages_url":"https://api.github.com/repos/cs361fall2018/project-team-12/languages","stargazers_url":"https://api.github.com/repos/cs361fall2018/project-team-12/stargazers","contributors_url":"https://api.github.com/repos/cs361fall2018/project-team-12/contributors","subscribers_url":"https://api.github.com/repos/cs361fall2018/project-team-12/subscribers","subscription_url":"https://api.github.com/repos/cs361fall2018/project-team-12/subscription","commits_url":"https://api.github.com/repos/cs361fall2018/project-team-12/commits{/sha}","git_commits_url":"https://api.github.com/repos/cs361fall2018/project-team-12/git/commits{/sha}","comments_url":"https://api.github.com/repos/cs361fall2018/project-team-12/comments{/number}","issue_comment_url":"https://api.github.com/repos/cs361fall2018/project-team-12/issues/comments{/number}","contents_url":"https://api.github.com/repos/cs361fall2018/project-team-12/contents/{+path}","compare_url":"https://api.github.com/repos/cs361fall2018/project-team-12/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cs361fall2018/project-team-12/merges","archive_url":"https://api.github.com/repos/cs361fall2018/project-team-12/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cs361fall2018/project-team-12/downloads","issues_url":"https://api.github.com/repos/cs361fall2018/project-team-12/issues{/number}","pulls_url":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls{/number}","milestones_url":"https://api.github.com/repos/cs361fall2018/project-team-12/milestones{/number}","notifications_url":"https://api.github.com/repos/cs361fall2018/project-team-12/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cs361fall2018/project-team-12/labels{/name}","releases_url":"https://api.github.com/repos/cs361fall2018/project-team-12/releases{/id}","deployments_url":"https://api.github.com/repos/cs361fall2018/project-team-12/deployments","created_at":"2018-10-01T17:32:32Z","updated_at":"2018-10-12T00:43:09Z","pushed_at":"2018-10-12T04:59:55Z","git_url":"git://github.com/cs361fall2018/project-team-12.git","ssh_url":"[email protected]:cs361fall2018/project-team-12.git","clone_url":"https://github.com/cs361fall2018/project-team-12.git","svn_url":"https://github.com/cs361fall2018/project-team-12","homepage":null,"size":85,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/17"},"html":{"href":"https://github.com/cs361fall2018/project-team-12/pull/17"},"issue":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/issues/17"},"comments":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/cs361fall2018/project-team-12/statuses/77bf7f28c7d1501762898ca5b5c871c3cfd514f4"}},"author_association":"CONTRIBUTOR"}}

8409007096

{"actor":{"display_login":"ianbrown9475"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/comments/206080732","pull_request_review_id":141470210,"id":206080732,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjA4MDczMg==","diff_hunk":"@@ -17,11 +17,41 @@ public Ship(Set<BoardField> masts) {\n return masts;\n }\n \n- public boolean isMastHit(Coordinate coordinate) {\n- return masts.stream().anyMatch(m -> m.getCoordinate().equals(coordinate));\n+ boolean isMastHit(Coordinate coordinate) {","path":"client/src/main/java/com/battleships/gamewindow/board/Ship.java","position":18,"original_position":18,"commit_id":"9017c1603d584c925dfbcd9401b4346835be50f5","original_commit_id":"405b85847869bcf968af9d3eccd2beb793db41e3","user":{"login":"Hoymm","id":18104393,"node_id":"MDQ6VXNlcjE4MTA0Mzkz","avatar_url":"https://avatars3.githubusercontent.com/u/18104393?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoymm","html_url":"https://github.com/Hoymm","followers_url":"https://api.github.com/users/Hoymm/followers","following_url":"https://api.github.com/users/Hoymm/following{/other_user}","gists_url":"https://api.github.com/users/Hoymm/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoymm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoymm/subscriptions","organizations_url":"https://api.github.com/users/Hoymm/orgs","repos_url":"https://api.github.com/users/Hoymm/repos","events_url":"https://api.github.com/users/Hoymm/events{/privacy}","received_events_url":"https://api.github.com/users/Hoymm/received_events","type":"User","site_admin":false},"body":"Change code inside that method to:\r\n\r\n Optional<BoardField> mastForCoordinate = getMastForCoordinate(coordinate);\r\n return mastForCoordinate.isPresent() ? mastForCoordinate.get().isHit() : false;","created_at":"2018-07-30T10:15:08Z","updated_at":"2018-07-30T10:15:09Z","html_url":"https://github.com/JavaAcademyDoktorki/battleships/pull/45#discussion_r206080732","pull_request_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/45","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/comments/206080732"},"html":{"href":"https://github.com/JavaAcademyDoktorki/battleships/pull/45#discussion_r206080732"},"pull_request":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/45","id":204732126,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0NzMyMTI2","html_url":"https://github.com/JavaAcademyDoktorki/battleships/pull/45","diff_url":"https://github.com/JavaAcademyDoktorki/battleships/pull/45.diff","patch_url":"https://github.com/JavaAcademyDoktorki/battleships/pull/45.patch","issue_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues/45","number":45,"state":"open","locked":false,"title":"Merge branch","user":{"login":"KrzysztofDzioba","id":23156969,"node_id":"MDQ6VXNlcjIzMTU2OTY5","avatar_url":"https://avatars3.githubusercontent.com/u/23156969?v=4","gravatar_id":"","url":"https://api.github.com/users/KrzysztofDzioba","html_url":"https://github.com/KrzysztofDzioba","followers_url":"https://api.github.com/users/KrzysztofDzioba/followers","following_url":"https://api.github.com/users/KrzysztofDzioba/following{/other_user}","gists_url":"https://api.github.com/users/KrzysztofDzioba/gists{/gist_id}","starred_url":"https://api.github.com/users/KrzysztofDzioba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KrzysztofDzioba/subscriptions","organizations_url":"https://api.github.com/users/KrzysztofDzioba/orgs","repos_url":"https://api.github.com/users/KrzysztofDzioba/repos","events_url":"https://api.github.com/users/KrzysztofDzioba/events{/privacy}","received_events_url":"https://api.github.com/users/KrzysztofDzioba/received_events","type":"User","site_admin":false},"body":"playable game! :)\r\ndisabling buttons already hit\r\nshooting almost OK, buffer sending to correct\r\nimplements HIT message\r\nMerge remote-tracking branch 'remotes/origin/fleet_implementation2' into end_game\r\nSending command that other player won\r\nPrimitive win alert on button click\r\nfleet isSunk method implemented and tested\r\nMerge branch 'fleet_implementation2' of github.com:JavaAcademyDoktorki/battleships into end_game\r\nship hit method deimplemented, ship isSunk method tested\r\nship hit implemented","created_at":"2018-07-30T08:39:37Z","updated_at":"2018-07-30T10:15:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ef6d8f767ccd200295957ceb71ebbb9c9cd595d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/45/commits","review_comments_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/45/comments","review_comment_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/comments{/number}","comments_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues/45/comments","statuses_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/statuses/9017c1603d584c925dfbcd9401b4346835be50f5","head":{"label":"JavaAcademyDoktorki:merge_branch","ref":"merge_branch","sha":"9017c1603d584c925dfbcd9401b4346835be50f5","user":{"login":"JavaAcademyDoktorki","id":40495099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDk1MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/40495099?v=4","gravatar_id":"","url":"https://api.github.com/users/JavaAcademyDoktorki","html_url":"https://github.com/JavaAcademyDoktorki","followers_url":"https://api.github.com/users/JavaAcademyDoktorki/followers","following_url":"https://api.github.com/users/JavaAcademyDoktorki/following{/other_user}","gists_url":"https://api.github.com/users/JavaAcademyDoktorki/gists{/gist_id}","starred_url":"https://api.github.com/users/JavaAcademyDoktorki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavaAcademyDoktorki/subscriptions","organizations_url":"https://api.github.com/users/JavaAcademyDoktorki/orgs","repos_url":"https://api.github.com/users/JavaAcademyDoktorki/repos","events_url":"https://api.github.com/users/JavaAcademyDoktorki/events{/privacy}","received_events_url":"https://api.github.com/users/JavaAcademyDoktorki/received_events","type":"Organization","site_admin":false},"repo":{"id":139009080,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMDkwODA=","name":"battleships","full_name":"JavaAcademyDoktorki/battleships","owner":{"login":"JavaAcademyDoktorki","id":40495099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDk1MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/40495099?v=4","gravatar_id":"","url":"https://api.github.com/users/JavaAcademyDoktorki","html_url":"https://github.com/JavaAcademyDoktorki","followers_url":"https://api.github.com/users/JavaAcademyDoktorki/followers","following_url":"https://api.github.com/users/JavaAcademyDoktorki/following{/other_user}","gists_url":"https://api.github.com/users/JavaAcademyDoktorki/gists{/gist_id}","starred_url":"https://api.github.com/users/JavaAcademyDoktorki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavaAcademyDoktorki/subscriptions","organizations_url":"https://api.github.com/users/JavaAcademyDoktorki/orgs","repos_url":"https://api.github.com/users/JavaAcademyDoktorki/repos","events_url":"https://api.github.com/users/JavaAcademyDoktorki/events{/privacy}","received_events_url":"https://api.github.com/users/JavaAcademyDoktorki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JavaAcademyDoktorki/battleships","description":null,"fork":false,"url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships","forks_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/forks","keys_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/teams","hooks_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/hooks","issue_events_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues/events{/number}","events_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/events","assignees_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/assignees{/user}","branches_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/branches{/branch}","tags_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/tags","blobs_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/refs{/sha}","trees_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/statuses/{sha}","languages_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/languages","stargazers_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/stargazers","contributors_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/contributors","subscribers_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/subscribers","subscription_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/subscription","commits_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/commits{/sha}","git_commits_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/commits{/sha}","comments_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/comments{/number}","issue_comment_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues/comments{/number}","contents_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/contents/{+path}","compare_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/merges","archive_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/downloads","issues_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues{/number}","pulls_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls{/number}","milestones_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/milestones{/number}","notifications_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/labels{/name}","releases_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/releases{/id}","deployments_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/deployments","created_at":"2018-06-28T11:28:08Z","updated_at":"2018-07-27T10:42:14Z","pushed_at":"2018-07-30T09:54:17Z","git_url":"git://github.com/JavaAcademyDoktorki/battleships.git","ssh_url":"[email protected]:JavaAcademyDoktorki/battleships.git","clone_url":"https://github.com/JavaAcademyDoktorki/battleships.git","svn_url":"https://github.com/JavaAcademyDoktorki/battleships","homepage":null,"size":856,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"base":{"label":"JavaAcademyDoktorki:master","ref":"master","sha":"8f47928e2649daa4b1b8eca0761951b04a963fea","user":{"login":"JavaAcademyDoktorki","id":40495099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDk1MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/40495099?v=4","gravatar_id":"","url":"https://api.github.com/users/JavaAcademyDoktorki","html_url":"https://github.com/JavaAcademyDoktorki","followers_url":"https://api.github.com/users/JavaAcademyDoktorki/followers","following_url":"https://api.github.com/users/JavaAcademyDoktorki/following{/other_user}","gists_url":"https://api.github.com/users/JavaAcademyDoktorki/gists{/gist_id}","starred_url":"https://api.github.com/users/JavaAcademyDoktorki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavaAcademyDoktorki/subscriptions","organizations_url":"https://api.github.com/users/JavaAcademyDoktorki/orgs","repos_url":"https://api.github.com/users/JavaAcademyDoktorki/repos","events_url":"https://api.github.com/users/JavaAcademyDoktorki/events{/privacy}","received_events_url":"https://api.github.com/users/JavaAcademyDoktorki/received_events","type":"Organization","site_admin":false},"repo":{"id":139009080,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkwMDkwODA=","name":"battleships","full_name":"JavaAcademyDoktorki/battleships","owner":{"login":"JavaAcademyDoktorki","id":40495099,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNDk1MDk5","avatar_url":"https://avatars3.githubusercontent.com/u/40495099?v=4","gravatar_id":"","url":"https://api.github.com/users/JavaAcademyDoktorki","html_url":"https://github.com/JavaAcademyDoktorki","followers_url":"https://api.github.com/users/JavaAcademyDoktorki/followers","following_url":"https://api.github.com/users/JavaAcademyDoktorki/following{/other_user}","gists_url":"https://api.github.com/users/JavaAcademyDoktorki/gists{/gist_id}","starred_url":"https://api.github.com/users/JavaAcademyDoktorki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JavaAcademyDoktorki/subscriptions","organizations_url":"https://api.github.com/users/JavaAcademyDoktorki/orgs","repos_url":"https://api.github.com/users/JavaAcademyDoktorki/repos","events_url":"https://api.github.com/users/JavaAcademyDoktorki/events{/privacy}","received_events_url":"https://api.github.com/users/JavaAcademyDoktorki/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/JavaAcademyDoktorki/battleships","description":null,"fork":false,"url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships","forks_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/forks","keys_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/teams","hooks_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/hooks","issue_events_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues/events{/number}","events_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/events","assignees_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/assignees{/user}","branches_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/branches{/branch}","tags_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/tags","blobs_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/refs{/sha}","trees_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/statuses/{sha}","languages_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/languages","stargazers_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/stargazers","contributors_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/contributors","subscribers_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/subscribers","subscription_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/subscription","commits_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/commits{/sha}","git_commits_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/git/commits{/sha}","comments_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/comments{/number}","issue_comment_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues/comments{/number}","contents_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/contents/{+path}","compare_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/merges","archive_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/downloads","issues_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues{/number}","pulls_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls{/number}","milestones_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/milestones{/number}","notifications_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/labels{/name}","releases_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/releases{/id}","deployments_url":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/deployments","created_at":"2018-06-28T11:28:08Z","updated_at":"2018-07-27T10:42:14Z","pushed_at":"2018-07-30T09:54:17Z","git_url":"git://github.com/JavaAcademyDoktorki/battleships.git","ssh_url":"[email protected]:JavaAcademyDoktorki/battleships.git","clone_url":"https://github.com/JavaAcademyDoktorki/battleships.git","svn_url":"https://github.com/JavaAcademyDoktorki/battleships","homepage":null,"size":856,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":21,"license":null,"forks":0,"open_issues":21,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/45"},"html":{"href":"https://github.com/JavaAcademyDoktorki/battleships/pull/45"},"issue":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues/45"},"comments":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/JavaAcademyDoktorki/battleships/statuses/9017c1603d584c925dfbcd9401b4346835be50f5"}},"author_association":"COLLABORATOR"}}

8036778734

{"actor":{"display_login":"Hoymm"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments/201821166","pull_request_review_id":136399139,"id":201821166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTgyMTE2Ng==","diff_hunk":"@@ -0,0 +1,165 @@\n+require File.expand_path(File.dirname(__FILE__) + '/neo')\n+\n+# This class smells of :reek:UncommunicativeModuleName\n+class AboutHashes < Neo::Koan\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_creating_hashes\n+ empty_hash = {}\n+ assert_equal Hash, empty_hash.class\n+ assert_equal({}, empty_hash)\n+ assert_equal 0, empty_hash.size\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_hash_literals\n+ hash = { one: 'uno', two: 'dos' }\n+ assert_equal 2, hash.size\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_accessing_hashes\n+ hash = { one: 'uno', two: 'dos' }\n+ assert_equal 'uno', hash[:one]\n+ assert_equal 'dos', hash[:two]\n+ assert_equal nil, hash[:doesnt_exist]\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_accessing_hashes_with_fetch\n+ hash = { one: 'uno' }\n+ assert_equal 'uno', hash.fetch(:one)\n+ assert_raise(KeyError) do\n+ hash.fetch(:doesnt_exist)\n+ end\n+\n+ # THINK ABOUT IT:\n+ #\n+ # Why might you want to use #fetch instead of #[] when accessing hash keys?\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_changing_hashes\n+ hash = { one: 'uno', two: 'dos' }\n+ hash[:one] = 'eins'\n+\n+ expected = { one: 'eins', two: 'dos' }\n+ assert_equal expected, hash\n+\n+ # Bonus Question: Why was \"expected\" broken out into a variable\n+ # rather than used as a literal?\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_hash_is_unordered\n+ hash1 = { one: 'uno', two: 'dos' }\n+ hash2 = { two: 'dos', one: 'uno' }\n+\n+ assert_equal true, hash1 == hash2\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_hash_keys\n+ hash = { one: 'uno', two: 'dos' }\n+ assert_equal 2, hash.keys.size\n+ assert_equal true, hash.keys.include?(:one)\n+ assert_equal true, hash.keys.include?(:two)\n+ assert_equal Array, hash.keys.class\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_hash_values\n+ hash = { one: 'uno', two: 'dos' }\n+ assert_equal 2, hash.values.size\n+ assert_equal true, hash.values.include?('uno')\n+ assert_equal true, hash.values.include?('dos')\n+ assert_equal Array, hash.values.class\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_combining_hashes\n+ hash = { 'jim' => 53, 'amy' => 20, 'dan' => 23 }\n+ new_hash = hash.merge('jim' => 54, 'jenny' => 26)\n+\n+ assert_equal true, hash != new_hash\n+\n+ expected = { 'jim' => 54, 'amy' => 20, 'dan' => 23, 'jenny' => 26 }\n+ assert_equal true, expected == new_hash\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_default_value\n+ hash1 = {}\n+ hash1[:one] = 1\n+\n+ assert_equal 1, hash1[:one]\n+ assert_equal nil, hash1[:two]\n+\n+ hash2 = Hash.new('dos')\n+ hash2[:one] = 1\n+\n+ assert_equal 1, hash2[:one]\n+ assert_equal 'dos', hash2[:two]\n+ end\n+\n+ # This method smells of :reek:UncommunicativeMethodName\n+ # This method smells of :reek:UncommunicativeVariableName\n+ # This method smells of :reek:TooManyStatements\n+ # This method smells of :reek:FeatureEnvy\n+ def test_default_value_is_the_same_object","path":"2223/1/about_hashes.rb","position":138,"original_position":138,"commit_id":"ce2ae243876670aac3a3479f28f9233e862e2bc6","original_commit_id":"ce2ae243876670aac3a3479f28f9233e862e2bc6","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Metrics/AbcSize: Assignment Branch Condition size for test_default_value_is_the_same_object is too high. [17.03/15]","created_at":"2018-07-11T19:59:18Z","updated_at":"2018-07-11T19:59:19Z","html_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/200#discussion_r201821166","pull_request_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/200","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments/201821166"},"html":{"href":"https://github.com/rubizza-survival-camp/summer-2018/pull/200#discussion_r201821166"},"pull_request":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/200"}}},"pull_request":{"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/200","id":200795796,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzk1Nzk2","html_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/200","diff_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/200.diff","patch_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/200.patch","issue_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/200","number":200,"state":"open","locked":false,"title":"2223-1","user":{"login":"VDmitryO","id":22802625,"node_id":"MDQ6VXNlcjIyODAyNjI1","avatar_url":"https://avatars2.githubusercontent.com/u/22802625?v=4","gravatar_id":"","url":"https://api.github.com/users/VDmitryO","html_url":"https://github.com/VDmitryO","followers_url":"https://api.github.com/users/VDmitryO/followers","following_url":"https://api.github.com/users/VDmitryO/following{/other_user}","gists_url":"https://api.github.com/users/VDmitryO/gists{/gist_id}","starred_url":"https://api.github.com/users/VDmitryO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDmitryO/subscriptions","organizations_url":"https://api.github.com/users/VDmitryO/orgs","repos_url":"https://api.github.com/users/VDmitryO/repos","events_url":"https://api.github.com/users/VDmitryO/events{/privacy}","received_events_url":"https://api.github.com/users/VDmitryO/received_events","type":"User","site_admin":false},"body":"## Номер\r\n2223\r\n\r\n## Номер задания\r\n1\r\n\r\n## Ссылка на видео с демо\r\nhttps://youtu.be/uG9_2DSxo9k\r\n\r\n## Комментарии\r\nГотово\r\n","created_at":"2018-07-11T19:00:26Z","updated_at":"2018-07-11T19:59:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a62adda32ca76e2dcb2e0878d7955cbe31c738e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/200/commits","review_comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/200/comments","review_comment_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/200/comments","statuses_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/ce2ae243876670aac3a3479f28f9233e862e2bc6","head":{"label":"VDmitryO:2223-1","ref":"2223-1","sha":"ce2ae243876670aac3a3479f28f9233e862e2bc6","user":{"login":"VDmitryO","id":22802625,"node_id":"MDQ6VXNlcjIyODAyNjI1","avatar_url":"https://avatars2.githubusercontent.com/u/22802625?v=4","gravatar_id":"","url":"https://api.github.com/users/VDmitryO","html_url":"https://github.com/VDmitryO","followers_url":"https://api.github.com/users/VDmitryO/followers","following_url":"https://api.github.com/users/VDmitryO/following{/other_user}","gists_url":"https://api.github.com/users/VDmitryO/gists{/gist_id}","starred_url":"https://api.github.com/users/VDmitryO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDmitryO/subscriptions","organizations_url":"https://api.github.com/users/VDmitryO/orgs","repos_url":"https://api.github.com/users/VDmitryO/repos","events_url":"https://api.github.com/users/VDmitryO/events{/privacy}","received_events_url":"https://api.github.com/users/VDmitryO/received_events","type":"User","site_admin":false},"repo":{"id":140580390,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA1ODAzOTA=","name":"summer-2018","full_name":"VDmitryO/summer-2018","owner":{"login":"VDmitryO","id":22802625,"node_id":"MDQ6VXNlcjIyODAyNjI1","avatar_url":"https://avatars2.githubusercontent.com/u/22802625?v=4","gravatar_id":"","url":"https://api.github.com/users/VDmitryO","html_url":"https://github.com/VDmitryO","followers_url":"https://api.github.com/users/VDmitryO/followers","following_url":"https://api.github.com/users/VDmitryO/following{/other_user}","gists_url":"https://api.github.com/users/VDmitryO/gists{/gist_id}","starred_url":"https://api.github.com/users/VDmitryO/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VDmitryO/subscriptions","organizations_url":"https://api.github.com/users/VDmitryO/orgs","repos_url":"https://api.github.com/users/VDmitryO/repos","events_url":"https://api.github.com/users/VDmitryO/events{/privacy}","received_events_url":"https://api.github.com/users/VDmitryO/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/VDmitryO/summer-2018","description":null,"fork":true,"url":"https://api.github.com/repos/VDmitryO/summer-2018","forks_url":"https://api.github.com/repos/VDmitryO/summer-2018/forks","keys_url":"https://api.github.com/repos/VDmitryO/summer-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VDmitryO/summer-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VDmitryO/summer-2018/teams","hooks_url":"https://api.github.com/repos/VDmitryO/summer-2018/hooks","issue_events_url":"https://api.github.com/repos/VDmitryO/summer-2018/issues/events{/number}","events_url":"https://api.github.com/repos/VDmitryO/summer-2018/events","assignees_url":"https://api.github.com/repos/VDmitryO/summer-2018/assignees{/user}","branches_url":"https://api.github.com/repos/VDmitryO/summer-2018/branches{/branch}","tags_url":"https://api.github.com/repos/VDmitryO/summer-2018/tags","blobs_url":"https://api.github.com/repos/VDmitryO/summer-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VDmitryO/summer-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VDmitryO/summer-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/VDmitryO/summer-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VDmitryO/summer-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/VDmitryO/summer-2018/languages","stargazers_url":"https://api.github.com/repos/VDmitryO/summer-2018/stargazers","contributors_url":"https://api.github.com/repos/VDmitryO/summer-2018/contributors","subscribers_url":"https://api.github.com/repos/VDmitryO/summer-2018/subscribers","subscription_url":"https://api.github.com/repos/VDmitryO/summer-2018/subscription","commits_url":"https://api.github.com/repos/VDmitryO/summer-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/VDmitryO/summer-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/VDmitryO/summer-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/VDmitryO/summer-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/VDmitryO/summer-2018/contents/{+path}","compare_url":"https://api.github.com/repos/VDmitryO/summer-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VDmitryO/summer-2018/merges","archive_url":"https://api.github.com/repos/VDmitryO/summer-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VDmitryO/summer-2018/downloads","issues_url":"https://api.github.com/repos/VDmitryO/summer-2018/issues{/number}","pulls_url":"https://api.github.com/repos/VDmitryO/summer-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/VDmitryO/summer-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/VDmitryO/summer-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VDmitryO/summer-2018/labels{/name}","releases_url":"https://api.github.com/repos/VDmitryO/summer-2018/releases{/id}","deployments_url":"https://api.github.com/repos/VDmitryO/summer-2018/deployments","created_at":"2018-07-11T13:38:54Z","updated_at":"2018-07-11T13:38:57Z","pushed_at":"2018-07-11T19:57:11Z","git_url":"git://github.com/VDmitryO/summer-2018.git","ssh_url":"[email protected]:VDmitryO/summer-2018.git","clone_url":"https://github.com/VDmitryO/summer-2018.git","svn_url":"https://github.com/VDmitryO/summer-2018","homepage":null,"size":86376,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubizza-survival-camp:master","ref":"master","sha":"f3415efbcdadde8424e1fc158812c110b93b3967","user":{"login":"rubizza-survival-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-survival-camp","html_url":"https://github.com/rubizza-survival-camp","followers_url":"https://api.github.com/users/rubizza-survival-camp/followers","following_url":"https://api.github.com/users/rubizza-survival-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-survival-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-survival-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-survival-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-survival-camp/orgs","repos_url":"https://api.github.com/users/rubizza-survival-camp/repos","events_url":"https://api.github.com/users/rubizza-survival-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-survival-camp/received_events","type":"Organization","site_admin":false},"repo":{"id":139868408,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4Njg0MDg=","name":"summer-2018","full_name":"rubizza-survival-camp/summer-2018","owner":{"login":"rubizza-survival-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-survival-camp","html_url":"https://github.com/rubizza-survival-camp","followers_url":"https://api.github.com/users/rubizza-survival-camp/followers","following_url":"https://api.github.com/users/rubizza-survival-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-survival-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-survival-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-survival-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-survival-camp/orgs","repos_url":"https://api.github.com/users/rubizza-survival-camp/repos","events_url":"https://api.github.com/users/rubizza-survival-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-survival-camp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubizza-survival-camp/summer-2018","description":null,"fork":false,"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018","forks_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/forks","keys_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/teams","hooks_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/hooks","issue_events_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/events{/number}","events_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/events","assignees_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/assignees{/user}","branches_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/branches{/branch}","tags_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/tags","blobs_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/languages","stargazers_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/stargazers","contributors_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/contributors","subscribers_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/subscribers","subscription_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/subscription","commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/contents/{+path}","compare_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/merges","archive_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/downloads","issues_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues{/number}","pulls_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/labels{/name}","releases_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/releases{/id}","deployments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/deployments","created_at":"2018-07-05T15:28:12Z","updated_at":"2018-07-11T16:54:40Z","pushed_at":"2018-07-11T19:58:10Z","git_url":"git://github.com/rubizza-survival-camp/summer-2018.git","ssh_url":"[email protected]:rubizza-survival-camp/summer-2018.git","clone_url":"https://github.com/rubizza-survival-camp/summer-2018.git","svn_url":"https://github.com/rubizza-survival-camp/summer-2018","homepage":null,"size":86559,"stargazers_count":1,"watchers_count":1,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":31,"license":null,"forks":56,"open_issues":31,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/200"},"html":{"href":"https://github.com/rubizza-survival-camp/summer-2018/pull/200"},"issue":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/200"},"comments":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/200/comments"},"review_comments":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/200/comments"},"review_comment":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/200/commits"},"statuses":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/ce2ae243876670aac3a3479f28f9233e862e2bc6"}},"author_association":"CONTRIBUTOR"}}

7952274200

{"actor":{"display_login":"houndci-bot"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments/200850090","pull_request_review_id":135242241,"id":200850090,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDg1MDA5MA==","diff_hunk":"@@ -0,0 +1,137 @@\n+require File.expand_path(File.dirname(__FILE__) + '/neo')\n+\n+include Java\n+\n+# Concepts\n+# * Pull in a java class\n+# * calling a method, Camel vs snake\n+# * Resolving module/class name conflicts\n+# * Showing what gets returned\n+# * Ruby Strings VS Java Strings\n+# * Calling custom java class\n+# * Calling Ruby from java???\n+\n+class AboutJavaInterop < Neo::Koan\n+ def test_using_a_java_library_class\n+ java_array = java.util.ArrayList.new\n+ assert_equal __, java_array.class\n+ end\n+\n+ def test_java_class_can_be_referenced_using_both_ruby_and_java_like_syntax\n+ assert_equal __, Java::JavaUtil::ArrayList == java.util.ArrayList\n+ end\n+\n+ def test_include_class_includes_class_in_module_scope\n+ assert_nil defined?(TreeSet)\n+ include_class \"java.util.TreeSet\"\n+ assert_equal __, defined?(TreeSet)\n+ end\n+\n+ # THINK ABOUT IT:\n+ #\n+ # What if we use:\n+ #\n+ # include_class \"java.lang.String\"\n+ #\n+ # What would be the value of the String constant after this\n+ # include_class is run? Would it be useful to provide a way of\n+ # aliasing java classes to different names?\n+\n+ JString = java.lang.String\n+ def test_also_java_class_can_be_given_ruby_aliases\n+ java_string = JString.new(\"A Java String\")\n+ assert_equal __, java_string.class\n+ assert_equal __, JString\n+ end\n+\n+ def test_can_directly_call_java_methods_on_java_objects\n+ java_string = JString.new(\"A Java String\")\n+ assert_equal __, java_string.toLowerCase\n+ end\n+\n+ def test_jruby_provides_snake_case_versions_of_java_methods\n+ java_string = JString.new(\"A Java String\")\n+ assert_equal __, java_string.to_lower_case\n+ end\n+\n+ def test_jruby_provides_question_mark_versions_of_boolean_methods\n+ java_string = JString.new(\"A Java String\")\n+ assert_equal __, java_string.endsWith(\"String\")\n+ assert_equal __, java_string.ends_with(\"String\")\n+ assert_equal __, java_string.ends_with?(\"String\")\n+ end\n+\n+ def test_java_string_are_not_ruby_strings\n+ ruby_string = \"A Java String\"\n+ java_string = java.lang.String.new(ruby_string)\n+ assert_equal __, java_string.is_a?(java.lang.String)\n+ assert_equal __, java_string.is_a?(String)\n+ end\n+\n+ def test_java_strings_can_be_compared_to_ruby_strings_maybe\n+ ruby_string = \"A Java String\"\n+ java_string = java.lang.String.new(ruby_string)\n+ assert_equal __, ruby_string == java_string\n+ assert_equal __, java_string == ruby_string\n+\n+ # THINK ABOUT IT:\n+ #\n+ # Is there any possible way for this to be more wrong?\n+ #\n+ # SERIOUSLY, THINK ABOUT IT:\n+ #\n+ # Why do you suppose that Ruby and Java strings compare like that?\n+ #\n+ # ADVANCED THINK ABOUT IT:\n+ #\n+ # Is there a way to make Ruby/Java string comparisons commutative?\n+ # How would you do it?\n+ end\n+\n+ def test_however_most_methods_returning_strings_return_ruby_strings","path":"2420/1/koans/about_java_interop.rb","position":91,"original_position":91,"commit_id":"733fd1a56d7b21cfa82aed8f287916f174144f74","original_commit_id":"733fd1a56d7b21cfa82aed8f287916f174144f74","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Metrics/AbcSize: Assignment Branch Condition size for test_however_most_methods_returning_strings_return_ruby_strings is too high. [18.03/15]","created_at":"2018-07-08T19:05:21Z","updated_at":"2018-07-08T19:05:22Z","html_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/91#discussion_r200850090","pull_request_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments/200850090"},"html":{"href":"https://github.com/rubizza-survival-camp/summer-2018/pull/91#discussion_r200850090"},"pull_request":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91","id":199948839,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTQ4ODM5","html_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/91","diff_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/91.diff","patch_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/91.patch","issue_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/91","number":91,"state":"open","locked":false,"title":"2420/1","user":{"login":"Apachina","id":40717699,"node_id":"MDQ6VXNlcjQwNzE3Njk5","avatar_url":"https://avatars3.githubusercontent.com/u/40717699?v=4","gravatar_id":"","url":"https://api.github.com/users/Apachina","html_url":"https://github.com/Apachina","followers_url":"https://api.github.com/users/Apachina/followers","following_url":"https://api.github.com/users/Apachina/following{/other_user}","gists_url":"https://api.github.com/users/Apachina/gists{/gist_id}","starred_url":"https://api.github.com/users/Apachina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apachina/subscriptions","organizations_url":"https://api.github.com/users/Apachina/orgs","repos_url":"https://api.github.com/users/Apachina/repos","events_url":"https://api.github.com/users/Apachina/events{/privacy}","received_events_url":"https://api.github.com/users/Apachina/received_events","type":"User","site_admin":false},"body":"## Номер\r\n2420\r\n\r\n## Номер задания\r\n1\r\n\r\n## Ссылка на видео с демо\r\nhttps://youtu.be/Ik-giz15zhU\r\n\r\n## Комментарии\r\nЧто-то да получилось.\r\n","created_at":"2018-07-08T16:06:11Z","updated_at":"2018-07-08T19:05:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9ddd173bb3faedbcfc0692bbfb2a20cdc81603a7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91/commits","review_comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91/comments","review_comment_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/91/comments","statuses_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/733fd1a56d7b21cfa82aed8f287916f174144f74","head":{"label":"Apachina:2420_1","ref":"2420_1","sha":"733fd1a56d7b21cfa82aed8f287916f174144f74","user":{"login":"Apachina","id":40717699,"node_id":"MDQ6VXNlcjQwNzE3Njk5","avatar_url":"https://avatars3.githubusercontent.com/u/40717699?v=4","gravatar_id":"","url":"https://api.github.com/users/Apachina","html_url":"https://github.com/Apachina","followers_url":"https://api.github.com/users/Apachina/followers","following_url":"https://api.github.com/users/Apachina/following{/other_user}","gists_url":"https://api.github.com/users/Apachina/gists{/gist_id}","starred_url":"https://api.github.com/users/Apachina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apachina/subscriptions","organizations_url":"https://api.github.com/users/Apachina/orgs","repos_url":"https://api.github.com/users/Apachina/repos","events_url":"https://api.github.com/users/Apachina/events{/privacy}","received_events_url":"https://api.github.com/users/Apachina/received_events","type":"User","site_admin":false},"repo":{"id":139899423,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4OTk0MjM=","name":"summer-2018","full_name":"Apachina/summer-2018","owner":{"login":"Apachina","id":40717699,"node_id":"MDQ6VXNlcjQwNzE3Njk5","avatar_url":"https://avatars3.githubusercontent.com/u/40717699?v=4","gravatar_id":"","url":"https://api.github.com/users/Apachina","html_url":"https://github.com/Apachina","followers_url":"https://api.github.com/users/Apachina/followers","following_url":"https://api.github.com/users/Apachina/following{/other_user}","gists_url":"https://api.github.com/users/Apachina/gists{/gist_id}","starred_url":"https://api.github.com/users/Apachina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apachina/subscriptions","organizations_url":"https://api.github.com/users/Apachina/orgs","repos_url":"https://api.github.com/users/Apachina/repos","events_url":"https://api.github.com/users/Apachina/events{/privacy}","received_events_url":"https://api.github.com/users/Apachina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Apachina/summer-2018","description":null,"fork":true,"url":"https://api.github.com/repos/Apachina/summer-2018","forks_url":"https://api.github.com/repos/Apachina/summer-2018/forks","keys_url":"https://api.github.com/repos/Apachina/summer-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Apachina/summer-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Apachina/summer-2018/teams","hooks_url":"https://api.github.com/repos/Apachina/summer-2018/hooks","issue_events_url":"https://api.github.com/repos/Apachina/summer-2018/issues/events{/number}","events_url":"https://api.github.com/repos/Apachina/summer-2018/events","assignees_url":"https://api.github.com/repos/Apachina/summer-2018/assignees{/user}","branches_url":"https://api.github.com/repos/Apachina/summer-2018/branches{/branch}","tags_url":"https://api.github.com/repos/Apachina/summer-2018/tags","blobs_url":"https://api.github.com/repos/Apachina/summer-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Apachina/summer-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Apachina/summer-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/Apachina/summer-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Apachina/summer-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/Apachina/summer-2018/languages","stargazers_url":"https://api.github.com/repos/Apachina/summer-2018/stargazers","contributors_url":"https://api.github.com/repos/Apachina/summer-2018/contributors","subscribers_url":"https://api.github.com/repos/Apachina/summer-2018/subscribers","subscription_url":"https://api.github.com/repos/Apachina/summer-2018/subscription","commits_url":"https://api.github.com/repos/Apachina/summer-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/Apachina/summer-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/Apachina/summer-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/Apachina/summer-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/Apachina/summer-2018/contents/{+path}","compare_url":"https://api.github.com/repos/Apachina/summer-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Apachina/summer-2018/merges","archive_url":"https://api.github.com/repos/Apachina/summer-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Apachina/summer-2018/downloads","issues_url":"https://api.github.com/repos/Apachina/summer-2018/issues{/number}","pulls_url":"https://api.github.com/repos/Apachina/summer-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/Apachina/summer-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/Apachina/summer-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Apachina/summer-2018/labels{/name}","releases_url":"https://api.github.com/repos/Apachina/summer-2018/releases{/id}","deployments_url":"https://api.github.com/repos/Apachina/summer-2018/deployments","created_at":"2018-07-05T20:53:38Z","updated_at":"2018-07-06T10:36:14Z","pushed_at":"2018-07-08T19:04:57Z","git_url":"git://github.com/Apachina/summer-2018.git","ssh_url":"[email protected]:Apachina/summer-2018.git","clone_url":"https://github.com/Apachina/summer-2018.git","svn_url":"https://github.com/Apachina/summer-2018","homepage":null,"size":14287,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubizza-survival-camp:master","ref":"master","sha":"c99fdfda9ff36e7b140393ab9a51b021dec0c9d8","user":{"login":"rubizza-survival-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-survival-camp","html_url":"https://github.com/rubizza-survival-camp","followers_url":"https://api.github.com/users/rubizza-survival-camp/followers","following_url":"https://api.github.com/users/rubizza-survival-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-survival-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-survival-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-survival-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-survival-camp/orgs","repos_url":"https://api.github.com/users/rubizza-survival-camp/repos","events_url":"https://api.github.com/users/rubizza-survival-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-survival-camp/received_events","type":"Organization","site_admin":false},"repo":{"id":139868408,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4Njg0MDg=","name":"summer-2018","full_name":"rubizza-survival-camp/summer-2018","owner":{"login":"rubizza-survival-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-survival-camp","html_url":"https://github.com/rubizza-survival-camp","followers_url":"https://api.github.com/users/rubizza-survival-camp/followers","following_url":"https://api.github.com/users/rubizza-survival-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-survival-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-survival-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-survival-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-survival-camp/orgs","repos_url":"https://api.github.com/users/rubizza-survival-camp/repos","events_url":"https://api.github.com/users/rubizza-survival-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-survival-camp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubizza-survival-camp/summer-2018","description":null,"fork":false,"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018","forks_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/forks","keys_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/teams","hooks_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/hooks","issue_events_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/events{/number}","events_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/events","assignees_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/assignees{/user}","branches_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/branches{/branch}","tags_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/tags","blobs_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/languages","stargazers_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/stargazers","contributors_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/contributors","subscribers_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/subscribers","subscription_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/subscription","commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/contents/{+path}","compare_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/merges","archive_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/downloads","issues_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues{/number}","pulls_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/labels{/name}","releases_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/releases{/id}","deployments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/deployments","created_at":"2018-07-05T15:28:12Z","updated_at":"2018-07-07T20:17:21Z","pushed_at":"2018-07-08T19:04:58Z","git_url":"git://github.com/rubizza-survival-camp/summer-2018.git","ssh_url":"[email protected]:rubizza-survival-camp/summer-2018.git","clone_url":"https://github.com/rubizza-survival-camp/summer-2018.git","svn_url":"https://github.com/rubizza-survival-camp/summer-2018","homepage":null,"size":86207,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":54,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91"},"html":{"href":"https://github.com/rubizza-survival-camp/summer-2018/pull/91"},"issue":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/91"},"comments":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/733fd1a56d7b21cfa82aed8f287916f174144f74"}},"author_association":"CONTRIBUTOR"}}

7934426396

{"actor":{"display_login":"houndci-bot"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments/200841618","pull_request_review_id":135234158,"id":200841618,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDg0MTYxOA==","diff_hunk":"@@ -0,0 +1,177 @@\n+require File.expand_path(File.dirname(__FILE__) + '/neo')\n+# rubocop:disable Style/TrivialAccessors\n+# Project: Create a Proxy Class\n+#\n+# In this assignment, create a proxy class (one is started for you\n+# below). You should be able to initialize the proxy object with any\n+# object. Any messages sent to the proxy object should be forwarded\n+# to the target object. As each message is sent, the proxy should\n+# record the name of the method sent.\n+#\n+# The proxy class is started for you. You will need to add a method\n+# missing handler and any other supporting methods. The specification\n+# of the Proxy class is given in the AboutProxyObjectProject koan.\n+class Proxy\n+ attr_reader :messages\n+\n+ def initialize(target_object)\n+ @object = target_object\n+ @messages = []\n+ @times_called = Hash.new(0)\n+ end\n+\n+ def method_missing(method_name, *args, &block)\n+ if @object.respond_to?(method_name)\n+ @times_called[method_name] += 1\n+ unless @messages.include?(method_name)\n+ @messages << method_name\n+ end\n+ @object.send(method_name, *args)\n+ else\n+ super(method_name, *args, &block)\n+ end\n+ end\n+\n+ def called?(method_name)\n+ @times_called.key?(method_name)\n+ end\n+\n+ def number_of_times_called(method_name)\n+ called?(method_name) ? @times_called[method_name] : 0\n+ end\n+end\n+\n+# The proxy object should pass the following Koan:\n+#\n+class AboutProxyObjectProject < Neo::Koan\n+ def test_proxy_method_returns_wrapped_object\n+ # NOTE: The Television class is defined below\n+ tv = Proxy.new(Television.new)\n+\n+ # HINT: Proxy class is defined above, may need tweaking...\n+\n+ assert tv.instance_of?(Proxy)\n+ end\n+\n+ def test_tv_methods_still_perform_their_function\n+ tv = Proxy.new(Television.new)\n+\n+ tv.channel = 10\n+ tv.power\n+\n+ assert_equal 10, tv.channel\n+ assert tv.on?\n+ end\n+\n+ def test_proxy_records_messages_sent_to_tv\n+ tv = Proxy.new(Television.new)\n+\n+ tv.power\n+ tv.channel = 10\n+\n+ assert_equal [:power, :channel=], tv.messages","path":"2226/1/koans/about_proxy_object_project.rb","position":72,"original_position":72,"commit_id":"db64b0fa35f5ddfd70587022ac3aeb02499c4e05","original_commit_id":"db64b0fa35f5ddfd70587022ac3aeb02499c4e05","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/SymbolArray: Use %i or %I for an array of symbols.","created_at":"2018-07-08T14:01:37Z","updated_at":"2018-07-08T14:01:38Z","html_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/50#discussion_r200841618","pull_request_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/50","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments/200841618"},"html":{"href":"https://github.com/rubizza-survival-camp/summer-2018/pull/50#discussion_r200841618"},"pull_request":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/50"}}},"pull_request":{"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/50","id":199756549,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NzU2NTQ5","html_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/50","diff_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/50.diff","patch_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/50.patch","issue_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/50","number":50,"state":"open","locked":false,"title":"2226-1","user":{"login":"andreydro","id":12498356,"node_id":"MDQ6VXNlcjEyNDk4MzU2","avatar_url":"https://avatars0.githubusercontent.com/u/12498356?v=4","gravatar_id":"","url":"https://api.github.com/users/andreydro","html_url":"https://github.com/andreydro","followers_url":"https://api.github.com/users/andreydro/followers","following_url":"https://api.github.com/users/andreydro/following{/other_user}","gists_url":"https://api.github.com/users/andreydro/gists{/gist_id}","starred_url":"https://api.github.com/users/andreydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreydro/subscriptions","organizations_url":"https://api.github.com/users/andreydro/orgs","repos_url":"https://api.github.com/users/andreydro/repos","events_url":"https://api.github.com/users/andreydro/events{/privacy}","received_events_url":"https://api.github.com/users/andreydro/received_events","type":"User","site_admin":false},"body":"## Номер\r\n2226\r\n\r\n## Номер задания\r\n1\r\n\r\n## Ссылка на видео с демо\r\nhttps://youtu.be/_-peFCnhKbo\r\n\r\n## Комментарии\r\n\r\n","created_at":"2018-07-06T14:01:30Z","updated_at":"2018-07-08T14:01:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"00ddcd475093d11e2b4cf2dd91e96e5c2142b181","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/50/commits","review_comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/50/comments","review_comment_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/50/comments","statuses_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/db64b0fa35f5ddfd70587022ac3aeb02499c4e05","head":{"label":"andreydro:2226/1","ref":"2226/1","sha":"db64b0fa35f5ddfd70587022ac3aeb02499c4e05","user":{"login":"andreydro","id":12498356,"node_id":"MDQ6VXNlcjEyNDk4MzU2","avatar_url":"https://avatars0.githubusercontent.com/u/12498356?v=4","gravatar_id":"","url":"https://api.github.com/users/andreydro","html_url":"https://github.com/andreydro","followers_url":"https://api.github.com/users/andreydro/followers","following_url":"https://api.github.com/users/andreydro/following{/other_user}","gists_url":"https://api.github.com/users/andreydro/gists{/gist_id}","starred_url":"https://api.github.com/users/andreydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreydro/subscriptions","organizations_url":"https://api.github.com/users/andreydro/orgs","repos_url":"https://api.github.com/users/andreydro/repos","events_url":"https://api.github.com/users/andreydro/events{/privacy}","received_events_url":"https://api.github.com/users/andreydro/received_events","type":"User","site_admin":false},"repo":{"id":139937162,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk5MzcxNjI=","name":"summer-2018","full_name":"andreydro/summer-2018","owner":{"login":"andreydro","id":12498356,"node_id":"MDQ6VXNlcjEyNDk4MzU2","avatar_url":"https://avatars0.githubusercontent.com/u/12498356?v=4","gravatar_id":"","url":"https://api.github.com/users/andreydro","html_url":"https://github.com/andreydro","followers_url":"https://api.github.com/users/andreydro/followers","following_url":"https://api.github.com/users/andreydro/following{/other_user}","gists_url":"https://api.github.com/users/andreydro/gists{/gist_id}","starred_url":"https://api.github.com/users/andreydro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreydro/subscriptions","organizations_url":"https://api.github.com/users/andreydro/orgs","repos_url":"https://api.github.com/users/andreydro/repos","events_url":"https://api.github.com/users/andreydro/events{/privacy}","received_events_url":"https://api.github.com/users/andreydro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreydro/summer-2018","description":null,"fork":true,"url":"https://api.github.com/repos/andreydro/summer-2018","forks_url":"https://api.github.com/repos/andreydro/summer-2018/forks","keys_url":"https://api.github.com/repos/andreydro/summer-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreydro/summer-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreydro/summer-2018/teams","hooks_url":"https://api.github.com/repos/andreydro/summer-2018/hooks","issue_events_url":"https://api.github.com/repos/andreydro/summer-2018/issues/events{/number}","events_url":"https://api.github.com/repos/andreydro/summer-2018/events","assignees_url":"https://api.github.com/repos/andreydro/summer-2018/assignees{/user}","branches_url":"https://api.github.com/repos/andreydro/summer-2018/branches{/branch}","tags_url":"https://api.github.com/repos/andreydro/summer-2018/tags","blobs_url":"https://api.github.com/repos/andreydro/summer-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreydro/summer-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreydro/summer-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreydro/summer-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreydro/summer-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/andreydro/summer-2018/languages","stargazers_url":"https://api.github.com/repos/andreydro/summer-2018/stargazers","contributors_url":"https://api.github.com/repos/andreydro/summer-2018/contributors","subscribers_url":"https://api.github.com/repos/andreydro/summer-2018/subscribers","subscription_url":"https://api.github.com/repos/andreydro/summer-2018/subscription","commits_url":"https://api.github.com/repos/andreydro/summer-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreydro/summer-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreydro/summer-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreydro/summer-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreydro/summer-2018/contents/{+path}","compare_url":"https://api.github.com/repos/andreydro/summer-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreydro/summer-2018/merges","archive_url":"https://api.github.com/repos/andreydro/summer-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreydro/summer-2018/downloads","issues_url":"https://api.github.com/repos/andreydro/summer-2018/issues{/number}","pulls_url":"https://api.github.com/repos/andreydro/summer-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/andreydro/summer-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/andreydro/summer-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreydro/summer-2018/labels{/name}","releases_url":"https://api.github.com/repos/andreydro/summer-2018/releases{/id}","deployments_url":"https://api.github.com/repos/andreydro/summer-2018/deployments","created_at":"2018-07-06T05:27:32Z","updated_at":"2018-07-06T05:27:34Z","pushed_at":"2018-07-08T14:01:06Z","git_url":"git://github.com/andreydro/summer-2018.git","ssh_url":"[email protected]:andreydro/summer-2018.git","clone_url":"https://github.com/andreydro/summer-2018.git","svn_url":"https://github.com/andreydro/summer-2018","homepage":null,"size":14275,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubizza-survival-camp:master","ref":"master","sha":"a29f25fb61c10c9183d995ea060697bc11bd8491","user":{"login":"rubizza-survival-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-survival-camp","html_url":"https://github.com/rubizza-survival-camp","followers_url":"https://api.github.com/users/rubizza-survival-camp/followers","following_url":"https://api.github.com/users/rubizza-survival-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-survival-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-survival-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-survival-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-survival-camp/orgs","repos_url":"https://api.github.com/users/rubizza-survival-camp/repos","events_url":"https://api.github.com/users/rubizza-survival-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-survival-camp/received_events","type":"Organization","site_admin":false},"repo":{"id":139868408,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4Njg0MDg=","name":"summer-2018","full_name":"rubizza-survival-camp/summer-2018","owner":{"login":"rubizza-survival-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-survival-camp","html_url":"https://github.com/rubizza-survival-camp","followers_url":"https://api.github.com/users/rubizza-survival-camp/followers","following_url":"https://api.github.com/users/rubizza-survival-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-survival-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-survival-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-survival-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-survival-camp/orgs","repos_url":"https://api.github.com/users/rubizza-survival-camp/repos","events_url":"https://api.github.com/users/rubizza-survival-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-survival-camp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubizza-survival-camp/summer-2018","description":null,"fork":false,"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018","forks_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/forks","keys_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/teams","hooks_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/hooks","issue_events_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/events{/number}","events_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/events","assignees_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/assignees{/user}","branches_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/branches{/branch}","tags_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/tags","blobs_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/languages","stargazers_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/stargazers","contributors_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/contributors","subscribers_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/subscribers","subscription_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/subscription","commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/contents/{+path}","compare_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/merges","archive_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/downloads","issues_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues{/number}","pulls_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/labels{/name}","releases_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/releases{/id}","deployments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/deployments","created_at":"2018-07-05T15:28:12Z","updated_at":"2018-07-07T20:17:21Z","pushed_at":"2018-07-08T14:01:08Z","git_url":"git://github.com/rubizza-survival-camp/summer-2018.git","ssh_url":"[email protected]:rubizza-survival-camp/summer-2018.git","clone_url":"https://github.com/rubizza-survival-camp/summer-2018.git","svn_url":"https://github.com/rubizza-survival-camp/summer-2018","homepage":null,"size":86207,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":54,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/50"},"html":{"href":"https://github.com/rubizza-survival-camp/summer-2018/pull/50"},"issue":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/50"},"comments":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/50/comments"},"review_comments":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/50/comments"},"review_comment":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/50/commits"},"statuses":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/db64b0fa35f5ddfd70587022ac3aeb02499c4e05"}},"author_association":"CONTRIBUTOR"}}

7933995893

{"actor":{"display_login":"houndci-bot"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments/200848775","pull_request_review_id":135241053,"id":200848775,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDg0ODc3NQ==","diff_hunk":"@@ -0,0 +1,100 @@\n+require File.expand_path(File.dirname(__FILE__) + '/neo')\n+\n+class AboutSymbols < Neo::Koan\n+ def test_symbols_are_symbols\n+ symbol = :ruby\n+ assert_equal true, symbol.is_a?(Symbol)\n+ end\n+\n+ def test_symbols_can_be_compared\n+ symbol1 = :a_symbol\n+ symbol2 = :a_symbol\n+ symbol3 = :something_else\n+\n+ assert_equal true, symbol1 == symbol2\n+ assert_equal false, symbol1 == symbol3\n+ end\n+\n+ def test_identical_symbols_are_a_single_internal_object\n+ symbol1 = :a_symbol\n+ symbol2 = :a_symbol\n+\n+ assert_equal true, symbol1 == symbol2\n+ assert_equal true, symbol1.object_id == symbol2.object_id\n+ end\n+\n+ def test_method_names_become_symbols\n+ symbols_as_strings = Symbol.all_symbols.map { |x| x.to_s }\n+ assert_equal true, symbols_as_strings.include?(\"test_method_names_become_symbols\")\n+ end\n+\n+ # THINK ABOUT IT:\n+ #\n+ # Why do we convert the list of symbols to strings and then compare\n+ # against the string value rather than against symbols?\n+\n+ in_ruby_version(\"mri\") do\n+ RubyConstant = \"What is the sound of one hand clapping?\"\n+ def test_constants_become_symbols\n+ all_symbols_as_strings = Symbol.all_symbols.map { |x| x.to_s }\n+\n+ assert_equal false, all_symbols_as_strings.include?(__)\n+ end\n+ end\n+\n+ def test_symbols_can_be_made_from_strings\n+ string = \"catsAndDogs\"","path":"2420/1/koans/about_symbols.rb","position":46,"original_position":46,"commit_id":"6e3416693bcf818e733b91bbcc5682db184d4070","original_commit_id":"6e3416693bcf818e733b91bbcc5682db184d4070","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.","created_at":"2018-07-08T18:19:39Z","updated_at":"2018-07-08T18:19:41Z","html_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/91#discussion_r200848775","pull_request_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments/200848775"},"html":{"href":"https://github.com/rubizza-survival-camp/summer-2018/pull/91#discussion_r200848775"},"pull_request":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91"}}},"pull_request":{"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91","id":199948839,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTQ4ODM5","html_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/91","diff_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/91.diff","patch_url":"https://github.com/rubizza-survival-camp/summer-2018/pull/91.patch","issue_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/91","number":91,"state":"open","locked":false,"title":"2420/1","user":{"login":"Apachina","id":40717699,"node_id":"MDQ6VXNlcjQwNzE3Njk5","avatar_url":"https://avatars3.githubusercontent.com/u/40717699?v=4","gravatar_id":"","url":"https://api.github.com/users/Apachina","html_url":"https://github.com/Apachina","followers_url":"https://api.github.com/users/Apachina/followers","following_url":"https://api.github.com/users/Apachina/following{/other_user}","gists_url":"https://api.github.com/users/Apachina/gists{/gist_id}","starred_url":"https://api.github.com/users/Apachina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apachina/subscriptions","organizations_url":"https://api.github.com/users/Apachina/orgs","repos_url":"https://api.github.com/users/Apachina/repos","events_url":"https://api.github.com/users/Apachina/events{/privacy}","received_events_url":"https://api.github.com/users/Apachina/received_events","type":"User","site_admin":false},"body":"## Номер\r\n2420\r\n\r\n## Номер задания\r\n1\r\n\r\n## Ссылка на видео с демо\r\nhttps://youtu.be/Ik-giz15zhU\r\n\r\n## Комментарии\r\nЧто-то да получилось.\r\n","created_at":"2018-07-08T16:06:11Z","updated_at":"2018-07-08T18:19:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"995a31981e4ab9f8baac73edaa535d29821b63ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91/commits","review_comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91/comments","review_comment_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/91/comments","statuses_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/6e3416693bcf818e733b91bbcc5682db184d4070","head":{"label":"Apachina:2420_1","ref":"2420_1","sha":"6e3416693bcf818e733b91bbcc5682db184d4070","user":{"login":"Apachina","id":40717699,"node_id":"MDQ6VXNlcjQwNzE3Njk5","avatar_url":"https://avatars3.githubusercontent.com/u/40717699?v=4","gravatar_id":"","url":"https://api.github.com/users/Apachina","html_url":"https://github.com/Apachina","followers_url":"https://api.github.com/users/Apachina/followers","following_url":"https://api.github.com/users/Apachina/following{/other_user}","gists_url":"https://api.github.com/users/Apachina/gists{/gist_id}","starred_url":"https://api.github.com/users/Apachina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apachina/subscriptions","organizations_url":"https://api.github.com/users/Apachina/orgs","repos_url":"https://api.github.com/users/Apachina/repos","events_url":"https://api.github.com/users/Apachina/events{/privacy}","received_events_url":"https://api.github.com/users/Apachina/received_events","type":"User","site_admin":false},"repo":{"id":139899423,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4OTk0MjM=","name":"summer-2018","full_name":"Apachina/summer-2018","owner":{"login":"Apachina","id":40717699,"node_id":"MDQ6VXNlcjQwNzE3Njk5","avatar_url":"https://avatars3.githubusercontent.com/u/40717699?v=4","gravatar_id":"","url":"https://api.github.com/users/Apachina","html_url":"https://github.com/Apachina","followers_url":"https://api.github.com/users/Apachina/followers","following_url":"https://api.github.com/users/Apachina/following{/other_user}","gists_url":"https://api.github.com/users/Apachina/gists{/gist_id}","starred_url":"https://api.github.com/users/Apachina/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Apachina/subscriptions","organizations_url":"https://api.github.com/users/Apachina/orgs","repos_url":"https://api.github.com/users/Apachina/repos","events_url":"https://api.github.com/users/Apachina/events{/privacy}","received_events_url":"https://api.github.com/users/Apachina/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Apachina/summer-2018","description":null,"fork":true,"url":"https://api.github.com/repos/Apachina/summer-2018","forks_url":"https://api.github.com/repos/Apachina/summer-2018/forks","keys_url":"https://api.github.com/repos/Apachina/summer-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Apachina/summer-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Apachina/summer-2018/teams","hooks_url":"https://api.github.com/repos/Apachina/summer-2018/hooks","issue_events_url":"https://api.github.com/repos/Apachina/summer-2018/issues/events{/number}","events_url":"https://api.github.com/repos/Apachina/summer-2018/events","assignees_url":"https://api.github.com/repos/Apachina/summer-2018/assignees{/user}","branches_url":"https://api.github.com/repos/Apachina/summer-2018/branches{/branch}","tags_url":"https://api.github.com/repos/Apachina/summer-2018/tags","blobs_url":"https://api.github.com/repos/Apachina/summer-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Apachina/summer-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Apachina/summer-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/Apachina/summer-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Apachina/summer-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/Apachina/summer-2018/languages","stargazers_url":"https://api.github.com/repos/Apachina/summer-2018/stargazers","contributors_url":"https://api.github.com/repos/Apachina/summer-2018/contributors","subscribers_url":"https://api.github.com/repos/Apachina/summer-2018/subscribers","subscription_url":"https://api.github.com/repos/Apachina/summer-2018/subscription","commits_url":"https://api.github.com/repos/Apachina/summer-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/Apachina/summer-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/Apachina/summer-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/Apachina/summer-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/Apachina/summer-2018/contents/{+path}","compare_url":"https://api.github.com/repos/Apachina/summer-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Apachina/summer-2018/merges","archive_url":"https://api.github.com/repos/Apachina/summer-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Apachina/summer-2018/downloads","issues_url":"https://api.github.com/repos/Apachina/summer-2018/issues{/number}","pulls_url":"https://api.github.com/repos/Apachina/summer-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/Apachina/summer-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/Apachina/summer-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Apachina/summer-2018/labels{/name}","releases_url":"https://api.github.com/repos/Apachina/summer-2018/releases{/id}","deployments_url":"https://api.github.com/repos/Apachina/summer-2018/deployments","created_at":"2018-07-05T20:53:38Z","updated_at":"2018-07-06T10:36:14Z","pushed_at":"2018-07-08T18:19:12Z","git_url":"git://github.com/Apachina/summer-2018.git","ssh_url":"[email protected]:Apachina/summer-2018.git","clone_url":"https://github.com/Apachina/summer-2018.git","svn_url":"https://github.com/Apachina/summer-2018","homepage":null,"size":14287,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rubizza-survival-camp:master","ref":"master","sha":"c99fdfda9ff36e7b140393ab9a51b021dec0c9d8","user":{"login":"rubizza-survival-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-survival-camp","html_url":"https://github.com/rubizza-survival-camp","followers_url":"https://api.github.com/users/rubizza-survival-camp/followers","following_url":"https://api.github.com/users/rubizza-survival-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-survival-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-survival-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-survival-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-survival-camp/orgs","repos_url":"https://api.github.com/users/rubizza-survival-camp/repos","events_url":"https://api.github.com/users/rubizza-survival-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-survival-camp/received_events","type":"Organization","site_admin":false},"repo":{"id":139868408,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk4Njg0MDg=","name":"summer-2018","full_name":"rubizza-survival-camp/summer-2018","owner":{"login":"rubizza-survival-camp","id":40864986,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODY0OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/40864986?v=4","gravatar_id":"","url":"https://api.github.com/users/rubizza-survival-camp","html_url":"https://github.com/rubizza-survival-camp","followers_url":"https://api.github.com/users/rubizza-survival-camp/followers","following_url":"https://api.github.com/users/rubizza-survival-camp/following{/other_user}","gists_url":"https://api.github.com/users/rubizza-survival-camp/gists{/gist_id}","starred_url":"https://api.github.com/users/rubizza-survival-camp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubizza-survival-camp/subscriptions","organizations_url":"https://api.github.com/users/rubizza-survival-camp/orgs","repos_url":"https://api.github.com/users/rubizza-survival-camp/repos","events_url":"https://api.github.com/users/rubizza-survival-camp/events{/privacy}","received_events_url":"https://api.github.com/users/rubizza-survival-camp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rubizza-survival-camp/summer-2018","description":null,"fork":false,"url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018","forks_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/forks","keys_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/teams","hooks_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/hooks","issue_events_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/events{/number}","events_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/events","assignees_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/assignees{/user}","branches_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/branches{/branch}","tags_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/tags","blobs_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/{sha}","languages_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/languages","stargazers_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/stargazers","contributors_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/contributors","subscribers_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/subscribers","subscription_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/subscription","commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/contents/{+path}","compare_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/merges","archive_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/downloads","issues_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues{/number}","pulls_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls{/number}","milestones_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/milestones{/number}","notifications_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/labels{/name}","releases_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/releases{/id}","deployments_url":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/deployments","created_at":"2018-07-05T15:28:12Z","updated_at":"2018-07-07T20:17:21Z","pushed_at":"2018-07-08T18:19:13Z","git_url":"git://github.com/rubizza-survival-camp/summer-2018.git","ssh_url":"[email protected]:rubizza-survival-camp/summer-2018.git","clone_url":"https://github.com/rubizza-survival-camp/summer-2018.git","svn_url":"https://github.com/rubizza-survival-camp/summer-2018","homepage":null,"size":86207,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":54,"open_issues":11,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91"},"html":{"href":"https://github.com/rubizza-survival-camp/summer-2018/pull/91"},"issue":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/91"},"comments":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/issues/91/comments"},"review_comments":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91/comments"},"review_comment":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/pulls/91/commits"},"statuses":{"href":"https://api.github.com/repos/rubizza-survival-camp/summer-2018/statuses/6e3416693bcf818e733b91bbcc5682db184d4070"}},"author_association":"CONTRIBUTOR"}}

7934363475

{"actor":{"display_login":"houndci-bot"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/tikv/rfcs/pulls/comments/243456949","pull_request_review_id":187233322,"id":243456949,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzQ1Njk0OQ==","diff_hunk":"@@ -0,0 +1,67 @@\n+# Summary\n+`Consistent Replica Read` supports consistent read on the follower replica or ","path":"text/2018-11-24-consistent-replica-read.md","position":2,"original_position":2,"commit_id":"d84dbb997a040773d251b005a950682639e2c4c3","original_commit_id":"d84dbb997a040773d251b005a950682639e2c4c3","user":{"login":"Hoverbear","id":130903,"node_id":"MDQ6VXNlcjEzMDkwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/130903?v=4","gravatar_id":"","url":"https://api.github.com/users/Hoverbear","html_url":"https://github.com/Hoverbear","followers_url":"https://api.github.com/users/Hoverbear/followers","following_url":"https://api.github.com/users/Hoverbear/following{/other_user}","gists_url":"https://api.github.com/users/Hoverbear/gists{/gist_id}","starred_url":"https://api.github.com/users/Hoverbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hoverbear/subscriptions","organizations_url":"https://api.github.com/users/Hoverbear/orgs","repos_url":"https://api.github.com/users/Hoverbear/repos","events_url":"https://api.github.com/users/Hoverbear/events{/privacy}","received_events_url":"https://api.github.com/users/Hoverbear/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n*Consistent Replica Read* supports consistent read on the follower replica or \r\n```","created_at":"2018-12-21T00:09:51Z","updated_at":"2018-12-21T00:21:51Z","html_url":"https://github.com/tikv/rfcs/pull/14#discussion_r243456949","pull_request_url":"https://api.github.com/repos/tikv/rfcs/pulls/14","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tikv/rfcs/pulls/comments/243456949"},"html":{"href":"https://github.com/tikv/rfcs/pull/14#discussion_r243456949"},"pull_request":{"href":"https://api.github.com/repos/tikv/rfcs/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/tikv/rfcs/pulls/14","id":232613884,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjEzODg0","html_url":"https://github.com/tikv/rfcs/pull/14","diff_url":"https://github.com/tikv/rfcs/pull/14.diff","patch_url":"https://github.com/tikv/rfcs/pull/14.patch","issue_url":"https://api.github.com/repos/tikv/rfcs/issues/14","number":14,"state":"open","locked":false,"title":"Consistent Replica Read RFC","user":{"login":"nolouch","id":6428910,"node_id":"MDQ6VXNlcjY0Mjg5MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6428910?v=4","gravatar_id":"","url":"https://api.github.com/users/nolouch","html_url":"https://github.com/nolouch","followers_url":"https://api.github.com/users/nolouch/followers","following_url":"https://api.github.com/users/nolouch/following{/other_user}","gists_url":"https://api.github.com/users/nolouch/gists{/gist_id}","starred_url":"https://api.github.com/users/nolouch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nolouch/subscriptions","organizations_url":"https://api.github.com/users/nolouch/orgs","repos_url":"https://api.github.com/users/nolouch/repos","events_url":"https://api.github.com/users/nolouch/events{/privacy}","received_events_url":"https://api.github.com/users/nolouch/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-21T10:37:49Z","updated_at":"2018-12-21T00:21:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e8ab9efa437ddb664ea34dcec84ca9f6b185cfa2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"siddontang","id":1080370,"node_id":"MDQ6VXNlcjEwODAzNzA=","avatar_url":"https://avatars2.githubusercontent.com/u/1080370?v=4","gravatar_id":"","url":"https://api.github.com/users/siddontang","html_url":"https://github.com/siddontang","followers_url":"https://api.github.com/users/siddontang/followers","following_url":"https://api.github.com/users/siddontang/following{/other_user}","gists_url":"https://api.github.com/users/siddontang/gists{/gist_id}","starred_url":"https://api.github.com/users/siddontang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/siddontang/subscriptions","organizations_url":"https://api.github.com/users/siddontang/orgs","repos_url":"https://api.github.com/users/siddontang/repos","events_url":"https://api.github.com/users/siddontang/events{/privacy}","received_events_url":"https://api.github.com/users/siddontang/received_events","type":"User","site_admin":false},{"login":"disksing","id":12077877,"node_id":"MDQ6VXNlcjEyMDc3ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12077877?v=4","gravatar_id":"","url":"https://api.github.com/users/disksing","html_url":"https://github.com/disksing","followers_url":"https://api.github.com/users/disksing/followers","following_url":"https://api.github.com/users/disksing/following{/other_user}","gists_url":"https://api.github.com/users/disksing/gists{/gist_id}","starred_url":"https://api.github.com/users/disksing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disksing/subscriptions","organizations_url":"https://api.github.com/users/disksing/orgs","repos_url":"https://api.github.com/users/disksing/repos","events_url":"https://api.github.com/users/disksing/events{/privacy}","received_events_url":"https://api.github.com/users/disksing/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1127577606,"node_id":"MDU6TGFiZWwxMTI3NTc3NjA2","url":"https://api.github.com/repos/tikv/rfcs/labels/Initial%20Comment%20Period","name":"Initial Comment Period","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tikv/rfcs/pulls/14/commits","review_comments_url":"https://api.github.com/repos/tikv/rfcs/pulls/14/comments","review_comment_url":"https://api.github.com/repos/tikv/rfcs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tikv/rfcs/issues/14/comments","statuses_url":"https://api.github.com/repos/tikv/rfcs/statuses/d84dbb997a040773d251b005a950682639e2c4c3","head":{"label":"tikv:follower_read","ref":"follower_read","sha":"d84dbb997a040773d251b005a950682639e2c4c3","user":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"repo":{"id":145156191,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNTYxOTE=","name":"rfcs","full_name":"tikv/rfcs","private":false,"owner":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tikv/rfcs","description":"RFCs for changes to TiKV and its ecosystem","fork":false,"url":"https://api.github.com/repos/tikv/rfcs","forks_url":"https://api.github.com/repos/tikv/rfcs/forks","keys_url":"https://api.github.com/repos/tikv/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikv/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikv/rfcs/teams","hooks_url":"https://api.github.com/repos/tikv/rfcs/hooks","issue_events_url":"https://api.github.com/repos/tikv/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/tikv/rfcs/events","assignees_url":"https://api.github.com/repos/tikv/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/tikv/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/tikv/rfcs/tags","blobs_url":"https://api.github.com/repos/tikv/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikv/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikv/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikv/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikv/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/tikv/rfcs/languages","stargazers_url":"https://api.github.com/repos/tikv/rfcs/stargazers","contributors_url":"https://api.github.com/repos/tikv/rfcs/contributors","subscribers_url":"https://api.github.com/repos/tikv/rfcs/subscribers","subscription_url":"https://api.github.com/repos/tikv/rfcs/subscription","commits_url":"https://api.github.com/repos/tikv/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikv/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikv/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikv/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikv/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/tikv/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikv/rfcs/merges","archive_url":"https://api.github.com/repos/tikv/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikv/rfcs/downloads","issues_url":"https://api.github.com/repos/tikv/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/tikv/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/tikv/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/tikv/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikv/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/tikv/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/tikv/rfcs/deployments","created_at":"2018-08-17T18:55:29Z","updated_at":"2018-12-20T22:33:52Z","pushed_at":"2018-12-20T23:55:52Z","git_url":"git://github.com/tikv/rfcs.git","ssh_url":"[email protected]:tikv/rfcs.git","clone_url":"https://github.com/tikv/rfcs.git","svn_url":"https://github.com/tikv/rfcs","homepage":"","size":114,"stargazers_count":11,"watchers_count":11,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":9,"watchers":11,"default_branch":"master"}},"base":{"label":"tikv:master","ref":"master","sha":"32f1947aad1e4867b350eca13de0ef4ec6a91212","user":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"repo":{"id":145156191,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNTYxOTE=","name":"rfcs","full_name":"tikv/rfcs","private":false,"owner":{"login":"tikv","id":41004122,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDA0MTIy","avatar_url":"https://avatars2.githubusercontent.com/u/41004122?v=4","gravatar_id":"","url":"https://api.github.com/users/tikv","html_url":"https://github.com/tikv","followers_url":"https://api.github.com/users/tikv/followers","following_url":"https://api.github.com/users/tikv/following{/other_user}","gists_url":"https://api.github.com/users/tikv/gists{/gist_id}","starred_url":"https://api.github.com/users/tikv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tikv/subscriptions","organizations_url":"https://api.github.com/users/tikv/orgs","repos_url":"https://api.github.com/users/tikv/repos","events_url":"https://api.github.com/users/tikv/events{/privacy}","received_events_url":"https://api.github.com/users/tikv/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tikv/rfcs","description":"RFCs for changes to TiKV and its ecosystem","fork":false,"url":"https://api.github.com/repos/tikv/rfcs","forks_url":"https://api.github.com/repos/tikv/rfcs/forks","keys_url":"https://api.github.com/repos/tikv/rfcs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tikv/rfcs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tikv/rfcs/teams","hooks_url":"https://api.github.com/repos/tikv/rfcs/hooks","issue_events_url":"https://api.github.com/repos/tikv/rfcs/issues/events{/number}","events_url":"https://api.github.com/repos/tikv/rfcs/events","assignees_url":"https://api.github.com/repos/tikv/rfcs/assignees{/user}","branches_url":"https://api.github.com/repos/tikv/rfcs/branches{/branch}","tags_url":"https://api.github.com/repos/tikv/rfcs/tags","blobs_url":"https://api.github.com/repos/tikv/rfcs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tikv/rfcs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tikv/rfcs/git/refs{/sha}","trees_url":"https://api.github.com/repos/tikv/rfcs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tikv/rfcs/statuses/{sha}","languages_url":"https://api.github.com/repos/tikv/rfcs/languages","stargazers_url":"https://api.github.com/repos/tikv/rfcs/stargazers","contributors_url":"https://api.github.com/repos/tikv/rfcs/contributors","subscribers_url":"https://api.github.com/repos/tikv/rfcs/subscribers","subscription_url":"https://api.github.com/repos/tikv/rfcs/subscription","commits_url":"https://api.github.com/repos/tikv/rfcs/commits{/sha}","git_commits_url":"https://api.github.com/repos/tikv/rfcs/git/commits{/sha}","comments_url":"https://api.github.com/repos/tikv/rfcs/comments{/number}","issue_comment_url":"https://api.github.com/repos/tikv/rfcs/issues/comments{/number}","contents_url":"https://api.github.com/repos/tikv/rfcs/contents/{+path}","compare_url":"https://api.github.com/repos/tikv/rfcs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tikv/rfcs/merges","archive_url":"https://api.github.com/repos/tikv/rfcs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tikv/rfcs/downloads","issues_url":"https://api.github.com/repos/tikv/rfcs/issues{/number}","pulls_url":"https://api.github.com/repos/tikv/rfcs/pulls{/number}","milestones_url":"https://api.github.com/repos/tikv/rfcs/milestones{/number}","notifications_url":"https://api.github.com/repos/tikv/rfcs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tikv/rfcs/labels{/name}","releases_url":"https://api.github.com/repos/tikv/rfcs/releases{/id}","deployments_url":"https://api.github.com/repos/tikv/rfcs/deployments","created_at":"2018-08-17T18:55:29Z","updated_at":"2018-12-20T22:33:52Z","pushed_at":"2018-12-20T23:55:52Z","git_url":"git://github.com/tikv/rfcs.git","ssh_url":"[email protected]:tikv/rfcs.git","clone_url":"https://github.com/tikv/rfcs.git","svn_url":"https://github.com/tikv/rfcs","homepage":"","size":114,"stargazers_count":11,"watchers_count":11,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":9,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tikv/rfcs/pulls/14"},"html":{"href":"https://github.com/tikv/rfcs/pull/14"},"issue":{"href":"https://api.github.com/repos/tikv/rfcs/issues/14"},"comments":{"href":"https://api.github.com/repos/tikv/rfcs/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/tikv/rfcs/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/tikv/rfcs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tikv/rfcs/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/tikv/rfcs/statuses/d84dbb997a040773d251b005a950682639e2c4c3"}},"author_association":"NONE"}}

8788891015

{"actor":{"display_login":"Hoverbear"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/comments/227970684","pull_request_review_id":168133033,"id":227970684,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzk3MDY4NA==","diff_hunk":"@@ -152,6 +158,14 @@ export default {\n return null\n }\n },\n+ parseSelectionOptions (fieldOptions) {\n+ if (!fieldOptions) {\n+ return [{ value: null, text: 'Please select an option' }]\n+ }\n+ var options = JSON.parse(fieldOptions).filter(e => e).map(x => { return { value: x, text: x } })","path":"src/vue/src/components/entry/EntryFields.vue","position":28,"original_position":28,"commit_id":"b60f79df6832a10a26d3e87d83da23a8bbd2df65","original_commit_id":"90e8d821f099295c7b26eeb3c6977075a157f4ca","user":{"login":"Rickyboy320","id":3754047,"node_id":"MDQ6VXNlcjM3NTQwNDc=","avatar_url":"https://avatars0.githubusercontent.com/u/3754047?v=4","gravatar_id":"","url":"https://api.github.com/users/Rickyboy320","html_url":"https://github.com/Rickyboy320","followers_url":"https://api.github.com/users/Rickyboy320/followers","following_url":"https://api.github.com/users/Rickyboy320/following{/other_user}","gists_url":"https://api.github.com/users/Rickyboy320/gists{/gist_id}","starred_url":"https://api.github.com/users/Rickyboy320/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rickyboy320/subscriptions","organizations_url":"https://api.github.com/users/Rickyboy320/orgs","repos_url":"https://api.github.com/users/Rickyboy320/repos","events_url":"https://api.github.com/users/Rickyboy320/events{/privacy}","received_events_url":"https://api.github.com/users/Rickyboy320/received_events","type":"User","site_admin":false},"body":"Ah right, had a gut feeling something like that was at play...\r\nthanks for clearing that up!","created_at":"2018-10-24T21:42:37Z","updated_at":"2018-10-24T21:42:37Z","html_url":"https://github.com/eJourn-al/eJournal/pull/429#discussion_r227970684","pull_request_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/429","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/comments/227970684"},"html":{"href":"https://github.com/eJourn-al/eJournal/pull/429#discussion_r227970684"},"pull_request":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/429"}},"in_reply_to_id":227962248},"pull_request":{"url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/429","id":220849020,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODQ5MDIw","html_url":"https://github.com/eJourn-al/eJournal/pull/429","diff_url":"https://github.com/eJourn-al/eJournal/pull/429.diff","patch_url":"https://github.com/eJourn-al/eJournal/pull/429.patch","issue_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/429","number":429,"state":"open","locked":false,"title":"Add selection field feature","user":{"login":"Airgetfrog","id":29678823,"node_id":"MDQ6VXNlcjI5Njc4ODIz","avatar_url":"https://avatars1.githubusercontent.com/u/29678823?v=4","gravatar_id":"","url":"https://api.github.com/users/Airgetfrog","html_url":"https://github.com/Airgetfrog","followers_url":"https://api.github.com/users/Airgetfrog/followers","following_url":"https://api.github.com/users/Airgetfrog/following{/other_user}","gists_url":"https://api.github.com/users/Airgetfrog/gists{/gist_id}","starred_url":"https://api.github.com/users/Airgetfrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Airgetfrog/subscriptions","organizations_url":"https://api.github.com/users/Airgetfrog/orgs","repos_url":"https://api.github.com/users/Airgetfrog/repos","events_url":"https://api.github.com/users/Airgetfrog/events{/privacy}","received_events_url":"https://api.github.com/users/Airgetfrog/received_events","type":"User","site_admin":false},"body":"## Description\r\n- Add 'options' field to Field model, intended for field types taking options.\r\n- Added selection to backend structure and frontend structure.\r\n\r\nThe options input is a textfield with placeholder text used as instructions and generated through a function. How the data for options is handled is entirely up to the frontend implementation. It is simply a textfield, but it's accessible from the field object when needed so it should work fine. Possible issue is that there is no indication in grade view or overview that a field was a selection field (it's displayed in the same way as regular text inputs are).\r\n\r\n\r\n\r\n\r\n\r\n\r\n## Summary of changes\r\n- Fixes #212 \r\n","created_at":"2018-10-05T23:41:34Z","updated_at":"2018-10-24T21:42:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5af9f8256cfee98017dcf276ebf192a2ef71f26","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/429/commits","review_comments_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/429/comments","review_comment_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/429/comments","statuses_url":"https://api.github.com/repos/eJourn-al/eJournal/statuses/b60f79df6832a10a26d3e87d83da23a8bbd2df65","head":{"label":"eJourn-al:enhancement/selection-field","ref":"enhancement/selection-field","sha":"b60f79df6832a10a26d3e87d83da23a8bbd2df65","user":{"login":"eJourn-al","id":41028230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDI4MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/41028230?v=4","gravatar_id":"","url":"https://api.github.com/users/eJourn-al","html_url":"https://github.com/eJourn-al","followers_url":"https://api.github.com/users/eJourn-al/followers","following_url":"https://api.github.com/users/eJourn-al/following{/other_user}","gists_url":"https://api.github.com/users/eJourn-al/gists{/gist_id}","starred_url":"https://api.github.com/users/eJourn-al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eJourn-al/subscriptions","organizations_url":"https://api.github.com/users/eJourn-al/orgs","repos_url":"https://api.github.com/users/eJourn-al/repos","events_url":"https://api.github.com/users/eJourn-al/events{/privacy}","received_events_url":"https://api.github.com/users/eJourn-al/received_events","type":"Organization","site_admin":false},"repo":{"id":136030378,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzAzNzg=","name":"eJournal","full_name":"eJourn-al/eJournal","private":false,"owner":{"login":"eJourn-al","id":41028230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDI4MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/41028230?v=4","gravatar_id":"","url":"https://api.github.com/users/eJourn-al","html_url":"https://github.com/eJourn-al","followers_url":"https://api.github.com/users/eJourn-al/followers","following_url":"https://api.github.com/users/eJourn-al/following{/other_user}","gists_url":"https://api.github.com/users/eJourn-al/gists{/gist_id}","starred_url":"https://api.github.com/users/eJourn-al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eJourn-al/subscriptions","organizations_url":"https://api.github.com/users/eJourn-al/orgs","repos_url":"https://api.github.com/users/eJourn-al/repos","events_url":"https://api.github.com/users/eJourn-al/events{/privacy}","received_events_url":"https://api.github.com/users/eJourn-al/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eJourn-al/eJournal","description":"eJournal is a platform for long term assignments designed for virtual learning environments.","fork":false,"url":"https://api.github.com/repos/eJourn-al/eJournal","forks_url":"https://api.github.com/repos/eJourn-al/eJournal/forks","keys_url":"https://api.github.com/repos/eJourn-al/eJournal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eJourn-al/eJournal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eJourn-al/eJournal/teams","hooks_url":"https://api.github.com/repos/eJourn-al/eJournal/hooks","issue_events_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/events{/number}","events_url":"https://api.github.com/repos/eJourn-al/eJournal/events","assignees_url":"https://api.github.com/repos/eJourn-al/eJournal/assignees{/user}","branches_url":"https://api.github.com/repos/eJourn-al/eJournal/branches{/branch}","tags_url":"https://api.github.com/repos/eJourn-al/eJournal/tags","blobs_url":"https://api.github.com/repos/eJourn-al/eJournal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eJourn-al/eJournal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eJourn-al/eJournal/git/refs{/sha}","trees_url":"https://api.github.com/repos/eJourn-al/eJournal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eJourn-al/eJournal/statuses/{sha}","languages_url":"https://api.github.com/repos/eJourn-al/eJournal/languages","stargazers_url":"https://api.github.com/repos/eJourn-al/eJournal/stargazers","contributors_url":"https://api.github.com/repos/eJourn-al/eJournal/contributors","subscribers_url":"https://api.github.com/repos/eJourn-al/eJournal/subscribers","subscription_url":"https://api.github.com/repos/eJourn-al/eJournal/subscription","commits_url":"https://api.github.com/repos/eJourn-al/eJournal/commits{/sha}","git_commits_url":"https://api.github.com/repos/eJourn-al/eJournal/git/commits{/sha}","comments_url":"https://api.github.com/repos/eJourn-al/eJournal/comments{/number}","issue_comment_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/comments{/number}","contents_url":"https://api.github.com/repos/eJourn-al/eJournal/contents/{+path}","compare_url":"https://api.github.com/repos/eJourn-al/eJournal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eJourn-al/eJournal/merges","archive_url":"https://api.github.com/repos/eJourn-al/eJournal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eJourn-al/eJournal/downloads","issues_url":"https://api.github.com/repos/eJourn-al/eJournal/issues{/number}","pulls_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls{/number}","milestones_url":"https://api.github.com/repos/eJourn-al/eJournal/milestones{/number}","notifications_url":"https://api.github.com/repos/eJourn-al/eJournal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eJourn-al/eJournal/labels{/name}","releases_url":"https://api.github.com/repos/eJourn-al/eJournal/releases{/id}","deployments_url":"https://api.github.com/repos/eJourn-al/eJournal/deployments","created_at":"2018-06-04T13:36:31Z","updated_at":"2018-10-21T22:42:57Z","pushed_at":"2018-10-24T21:39:32Z","git_url":"git://github.com/eJourn-al/eJournal.git","ssh_url":"[email protected]:eJourn-al/eJournal.git","clone_url":"https://github.com/eJourn-al/eJournal.git","svn_url":"https://github.com/eJourn-al/eJournal","homepage":"https://eJourn.al","size":23554,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":56,"watchers":10,"default_branch":"develop"}},"base":{"label":"eJourn-al:develop","ref":"develop","sha":"9fe9c69be3c8b10dbff7bef3d204f0d0df5ed8c8","user":{"login":"eJourn-al","id":41028230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDI4MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/41028230?v=4","gravatar_id":"","url":"https://api.github.com/users/eJourn-al","html_url":"https://github.com/eJourn-al","followers_url":"https://api.github.com/users/eJourn-al/followers","following_url":"https://api.github.com/users/eJourn-al/following{/other_user}","gists_url":"https://api.github.com/users/eJourn-al/gists{/gist_id}","starred_url":"https://api.github.com/users/eJourn-al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eJourn-al/subscriptions","organizations_url":"https://api.github.com/users/eJourn-al/orgs","repos_url":"https://api.github.com/users/eJourn-al/repos","events_url":"https://api.github.com/users/eJourn-al/events{/privacy}","received_events_url":"https://api.github.com/users/eJourn-al/received_events","type":"Organization","site_admin":false},"repo":{"id":136030378,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYwMzAzNzg=","name":"eJournal","full_name":"eJourn-al/eJournal","private":false,"owner":{"login":"eJourn-al","id":41028230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDI4MjMw","avatar_url":"https://avatars3.githubusercontent.com/u/41028230?v=4","gravatar_id":"","url":"https://api.github.com/users/eJourn-al","html_url":"https://github.com/eJourn-al","followers_url":"https://api.github.com/users/eJourn-al/followers","following_url":"https://api.github.com/users/eJourn-al/following{/other_user}","gists_url":"https://api.github.com/users/eJourn-al/gists{/gist_id}","starred_url":"https://api.github.com/users/eJourn-al/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eJourn-al/subscriptions","organizations_url":"https://api.github.com/users/eJourn-al/orgs","repos_url":"https://api.github.com/users/eJourn-al/repos","events_url":"https://api.github.com/users/eJourn-al/events{/privacy}","received_events_url":"https://api.github.com/users/eJourn-al/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/eJourn-al/eJournal","description":"eJournal is a platform for long term assignments designed for virtual learning environments.","fork":false,"url":"https://api.github.com/repos/eJourn-al/eJournal","forks_url":"https://api.github.com/repos/eJourn-al/eJournal/forks","keys_url":"https://api.github.com/repos/eJourn-al/eJournal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eJourn-al/eJournal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eJourn-al/eJournal/teams","hooks_url":"https://api.github.com/repos/eJourn-al/eJournal/hooks","issue_events_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/events{/number}","events_url":"https://api.github.com/repos/eJourn-al/eJournal/events","assignees_url":"https://api.github.com/repos/eJourn-al/eJournal/assignees{/user}","branches_url":"https://api.github.com/repos/eJourn-al/eJournal/branches{/branch}","tags_url":"https://api.github.com/repos/eJourn-al/eJournal/tags","blobs_url":"https://api.github.com/repos/eJourn-al/eJournal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eJourn-al/eJournal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eJourn-al/eJournal/git/refs{/sha}","trees_url":"https://api.github.com/repos/eJourn-al/eJournal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eJourn-al/eJournal/statuses/{sha}","languages_url":"https://api.github.com/repos/eJourn-al/eJournal/languages","stargazers_url":"https://api.github.com/repos/eJourn-al/eJournal/stargazers","contributors_url":"https://api.github.com/repos/eJourn-al/eJournal/contributors","subscribers_url":"https://api.github.com/repos/eJourn-al/eJournal/subscribers","subscription_url":"https://api.github.com/repos/eJourn-al/eJournal/subscription","commits_url":"https://api.github.com/repos/eJourn-al/eJournal/commits{/sha}","git_commits_url":"https://api.github.com/repos/eJourn-al/eJournal/git/commits{/sha}","comments_url":"https://api.github.com/repos/eJourn-al/eJournal/comments{/number}","issue_comment_url":"https://api.github.com/repos/eJourn-al/eJournal/issues/comments{/number}","contents_url":"https://api.github.com/repos/eJourn-al/eJournal/contents/{+path}","compare_url":"https://api.github.com/repos/eJourn-al/eJournal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eJourn-al/eJournal/merges","archive_url":"https://api.github.com/repos/eJourn-al/eJournal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eJourn-al/eJournal/downloads","issues_url":"https://api.github.com/repos/eJourn-al/eJournal/issues{/number}","pulls_url":"https://api.github.com/repos/eJourn-al/eJournal/pulls{/number}","milestones_url":"https://api.github.com/repos/eJourn-al/eJournal/milestones{/number}","notifications_url":"https://api.github.com/repos/eJourn-al/eJournal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eJourn-al/eJournal/labels{/name}","releases_url":"https://api.github.com/repos/eJourn-al/eJournal/releases{/id}","deployments_url":"https://api.github.com/repos/eJourn-al/eJournal/deployments","created_at":"2018-06-04T13:36:31Z","updated_at":"2018-10-21T22:42:57Z","pushed_at":"2018-10-24T21:39:32Z","git_url":"git://github.com/eJourn-al/eJournal.git","ssh_url":"[email protected]:eJourn-al/eJournal.git","clone_url":"https://github.com/eJourn-al/eJournal.git","svn_url":"https://github.com/eJourn-al/eJournal","homepage":"https://eJourn.al","size":23554,"stargazers_count":10,"watchers_count":10,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":56,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":1,"open_issues":56,"watchers":10,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/429"},"html":{"href":"https://github.com/eJourn-al/eJournal/pull/429"},"issue":{"href":"https://api.github.com/repos/eJourn-al/eJournal/issues/429"},"comments":{"href":"https://api.github.com/repos/eJourn-al/eJournal/issues/429/comments"},"review_comments":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/429/comments"},"review_comment":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eJourn-al/eJournal/pulls/429/commits"},"statuses":{"href":"https://api.github.com/repos/eJourn-al/eJournal/statuses/b60f79df6832a10a26d3e87d83da23a8bbd2df65"}},"author_association":"MEMBER"}}

8476368817

{"actor":{"display_login":"Rickyboy320"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/HalalGuys/bookings/pulls/comments/204606996","pull_request_review_id":139712992,"id":204606996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDYwNjk5Ng==","diff_hunk":"@@ -0,0 +1,153 @@\n+import React from 'react';\n+import ReactDOM from 'react-dom';\n+import Calendar from './components/Calendar.jsx';\n+import rightArrow from './styles/icons/right_arrow.svg';\n+import downArrow from './styles/icons/down_arrow.svg';\n+import flag from './styles/icons/flag.svg';\n+import question from './styles/icons/question.svg';\n+import './styles/style.css';\n+import $ from 'jquery';\n+\n+class App extends React.Component {\n+ constructor() {\n+ super();\n+ this.today = new Date();\n+ this.state = {\n+ year: this.today.getFullYear(),\n+ month: this.today.getMonth(),\n+ requestedDates: [],\n+ stage: 0,\n+ price: 0,\n+ cleaning: 0,\n+ maxGuests: 0,\n+ minStay: 0,\n+ serviceFee: 0,\n+ bookedDates: []\n+ };\n+ }\n+\n+ componentDidMount() {\n+ $.get('/cal', (res) => {\n+ let result = JSON.parse(res);\n+ this.setState({\n+ price: result.price,\n+ cleaning: result.cleaning,\n+ maxGuests: result.maxGuests,\n+ minStay: result.minStay,\n+ serviceFee: result.serviceFee,\n+ bookedDates: result.year\n+ });\n+ });\n+ }\n+\n+ handleCheckInClick(newStage) {","path":"client/app.jsx","position":43,"original_position":43,"commit_id":"b40620fdfeb816e26eb25720db1b0aafa490418c","original_commit_id":"b40620fdfeb816e26eb25720db1b0aafa490418c","user":{"login":"bcronin2","id":6960884,"node_id":"MDQ6VXNlcjY5NjA4ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6960884?v=4","gravatar_id":"","url":"https://api.github.com/users/bcronin2","html_url":"https://github.com/bcronin2","followers_url":"https://api.github.com/users/bcronin2/followers","following_url":"https://api.github.com/users/bcronin2/following{/other_user}","gists_url":"https://api.github.com/users/bcronin2/gists{/gist_id}","starred_url":"https://api.github.com/users/bcronin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcronin2/subscriptions","organizations_url":"https://api.github.com/users/bcronin2/orgs","repos_url":"https://api.github.com/users/bcronin2/repos","events_url":"https://api.github.com/users/bcronin2/events{/privacy}","received_events_url":"https://api.github.com/users/bcronin2/received_events","type":"User","site_admin":false},"body":"I could be wrong, I think in general 'handle' is used to identify functions that take an event as an argument. In cases where you're just taking a string or number value, I would suggest something a little more directly related to the purpose, like 'setStage'.","created_at":"2018-07-24T02:25:44Z","updated_at":"2018-07-24T02:53:29Z","html_url":"https://github.com/HalalGuys/bookings/pull/4#discussion_r204606996","pull_request_url":"https://api.github.com/repos/HalalGuys/bookings/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/HalalGuys/bookings/pulls/comments/204606996"},"html":{"href":"https://github.com/HalalGuys/bookings/pull/4#discussion_r204606996"},"pull_request":{"href":"https://api.github.com/repos/HalalGuys/bookings/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/HalalGuys/bookings/pulls/4","id":203358478,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMzU4NDc4","html_url":"https://github.com/HalalGuys/bookings/pull/4","diff_url":"https://github.com/HalalGuys/bookings/pull/4.diff","patch_url":"https://github.com/HalalGuys/bookings/pull/4.patch","issue_url":"https://api.github.com/repos/HalalGuys/bookings/issues/4","number":4,"state":"open","locked":false,"title":"Functionality for adding user selected check in check out dates","user":{"login":"jlukenoff","id":36255627,"node_id":"MDQ6VXNlcjM2MjU1NjI3","avatar_url":"https://avatars0.githubusercontent.com/u/36255627?v=4","gravatar_id":"","url":"https://api.github.com/users/jlukenoff","html_url":"https://github.com/jlukenoff","followers_url":"https://api.github.com/users/jlukenoff/followers","following_url":"https://api.github.com/users/jlukenoff/following{/other_user}","gists_url":"https://api.github.com/users/jlukenoff/gists{/gist_id}","starred_url":"https://api.github.com/users/jlukenoff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlukenoff/subscriptions","organizations_url":"https://api.github.com/users/jlukenoff/orgs","repos_url":"https://api.github.com/users/jlukenoff/repos","events_url":"https://api.github.com/users/jlukenoff/events{/privacy}","received_events_url":"https://api.github.com/users/jlukenoff/received_events","type":"User","site_admin":false},"body":"- meaningful changes occur in app.jsx, calendar.jsx, style.css\r\n\r\n-added state property 'stage' to indicate whether the user is selecting check in, check out, or reviewing pricing\r\n\r\n-this iteration lacks some styling and features but meets mvp for calendar component","created_at":"2018-07-23T22:11:57Z","updated_at":"2018-07-24T02:53:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fad8d6124eedadc78f77959592aaa2835ae95d0b","assignee":{"login":"bcronin2","id":6960884,"node_id":"MDQ6VXNlcjY5NjA4ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6960884?v=4","gravatar_id":"","url":"https://api.github.com/users/bcronin2","html_url":"https://github.com/bcronin2","followers_url":"https://api.github.com/users/bcronin2/followers","following_url":"https://api.github.com/users/bcronin2/following{/other_user}","gists_url":"https://api.github.com/users/bcronin2/gists{/gist_id}","starred_url":"https://api.github.com/users/bcronin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcronin2/subscriptions","organizations_url":"https://api.github.com/users/bcronin2/orgs","repos_url":"https://api.github.com/users/bcronin2/repos","events_url":"https://api.github.com/users/bcronin2/events{/privacy}","received_events_url":"https://api.github.com/users/bcronin2/received_events","type":"User","site_admin":false},"assignees":[{"login":"bcronin2","id":6960884,"node_id":"MDQ6VXNlcjY5NjA4ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/6960884?v=4","gravatar_id":"","url":"https://api.github.com/users/bcronin2","html_url":"https://github.com/bcronin2","followers_url":"https://api.github.com/users/bcronin2/followers","following_url":"https://api.github.com/users/bcronin2/following{/other_user}","gists_url":"https://api.github.com/users/bcronin2/gists{/gist_id}","starred_url":"https://api.github.com/users/bcronin2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcronin2/subscriptions","organizations_url":"https://api.github.com/users/bcronin2/orgs","repos_url":"https://api.github.com/users/bcronin2/repos","events_url":"https://api.github.com/users/bcronin2/events{/privacy}","received_events_url":"https://api.github.com/users/bcronin2/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HalalGuys/bookings/pulls/4/commits","review_comments_url":"https://api.github.com/repos/HalalGuys/bookings/pulls/4/comments","review_comment_url":"https://api.github.com/repos/HalalGuys/bookings/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HalalGuys/bookings/issues/4/comments","statuses_url":"https://api.github.com/repos/HalalGuys/bookings/statuses/b40620fdfeb816e26eb25720db1b0aafa490418c","head":{"label":"HalalGuys:check_in","ref":"check_in","sha":"b40620fdfeb816e26eb25720db1b0aafa490418c","user":{"login":"HalalGuys","id":41344279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzQ0Mjc5","avatar_url":"https://avatars2.githubusercontent.com/u/41344279?v=4","gravatar_id":"","url":"https://api.github.com/users/HalalGuys","html_url":"https://github.com/HalalGuys","followers_url":"https://api.github.com/users/HalalGuys/followers","following_url":"https://api.github.com/users/HalalGuys/following{/other_user}","gists_url":"https://api.github.com/users/HalalGuys/gists{/gist_id}","starred_url":"https://api.github.com/users/HalalGuys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalalGuys/subscriptions","organizations_url":"https://api.github.com/users/HalalGuys/orgs","repos_url":"https://api.github.com/users/HalalGuys/repos","events_url":"https://api.github.com/users/HalalGuys/events{/privacy}","received_events_url":"https://api.github.com/users/HalalGuys/received_events","type":"Organization","site_admin":false},"repo":{"id":141331330,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMzEzMzA=","name":"bookings","full_name":"HalalGuys/bookings","owner":{"login":"HalalGuys","id":41344279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzQ0Mjc5","avatar_url":"https://avatars2.githubusercontent.com/u/41344279?v=4","gravatar_id":"","url":"https://api.github.com/users/HalalGuys","html_url":"https://github.com/HalalGuys","followers_url":"https://api.github.com/users/HalalGuys/followers","following_url":"https://api.github.com/users/HalalGuys/following{/other_user}","gists_url":"https://api.github.com/users/HalalGuys/gists{/gist_id}","starred_url":"https://api.github.com/users/HalalGuys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalalGuys/subscriptions","organizations_url":"https://api.github.com/users/HalalGuys/orgs","repos_url":"https://api.github.com/users/HalalGuys/repos","events_url":"https://api.github.com/users/HalalGuys/events{/privacy}","received_events_url":"https://api.github.com/users/HalalGuys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HalalGuys/bookings","description":"Purchase dialog component ","fork":false,"url":"https://api.github.com/repos/HalalGuys/bookings","forks_url":"https://api.github.com/repos/HalalGuys/bookings/forks","keys_url":"https://api.github.com/repos/HalalGuys/bookings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HalalGuys/bookings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HalalGuys/bookings/teams","hooks_url":"https://api.github.com/repos/HalalGuys/bookings/hooks","issue_events_url":"https://api.github.com/repos/HalalGuys/bookings/issues/events{/number}","events_url":"https://api.github.com/repos/HalalGuys/bookings/events","assignees_url":"https://api.github.com/repos/HalalGuys/bookings/assignees{/user}","branches_url":"https://api.github.com/repos/HalalGuys/bookings/branches{/branch}","tags_url":"https://api.github.com/repos/HalalGuys/bookings/tags","blobs_url":"https://api.github.com/repos/HalalGuys/bookings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HalalGuys/bookings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HalalGuys/bookings/git/refs{/sha}","trees_url":"https://api.github.com/repos/HalalGuys/bookings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HalalGuys/bookings/statuses/{sha}","languages_url":"https://api.github.com/repos/HalalGuys/bookings/languages","stargazers_url":"https://api.github.com/repos/HalalGuys/bookings/stargazers","contributors_url":"https://api.github.com/repos/HalalGuys/bookings/contributors","subscribers_url":"https://api.github.com/repos/HalalGuys/bookings/subscribers","subscription_url":"https://api.github.com/repos/HalalGuys/bookings/subscription","commits_url":"https://api.github.com/repos/HalalGuys/bookings/commits{/sha}","git_commits_url":"https://api.github.com/repos/HalalGuys/bookings/git/commits{/sha}","comments_url":"https://api.github.com/repos/HalalGuys/bookings/comments{/number}","issue_comment_url":"https://api.github.com/repos/HalalGuys/bookings/issues/comments{/number}","contents_url":"https://api.github.com/repos/HalalGuys/bookings/contents/{+path}","compare_url":"https://api.github.com/repos/HalalGuys/bookings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HalalGuys/bookings/merges","archive_url":"https://api.github.com/repos/HalalGuys/bookings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HalalGuys/bookings/downloads","issues_url":"https://api.github.com/repos/HalalGuys/bookings/issues{/number}","pulls_url":"https://api.github.com/repos/HalalGuys/bookings/pulls{/number}","milestones_url":"https://api.github.com/repos/HalalGuys/bookings/milestones{/number}","notifications_url":"https://api.github.com/repos/HalalGuys/bookings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HalalGuys/bookings/labels{/name}","releases_url":"https://api.github.com/repos/HalalGuys/bookings/releases{/id}","deployments_url":"https://api.github.com/repos/HalalGuys/bookings/deployments","created_at":"2018-07-17T18:59:30Z","updated_at":"2018-07-20T18:32:33Z","pushed_at":"2018-07-23T23:31:26Z","git_url":"git://github.com/HalalGuys/bookings.git","ssh_url":"[email protected]:HalalGuys/bookings.git","clone_url":"https://github.com/HalalGuys/bookings.git","svn_url":"https://github.com/HalalGuys/bookings","homepage":null,"size":4081,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"HalalGuys:master","ref":"master","sha":"9ff4e623063f0ad7f3b98595c7870dd37cf6affa","user":{"login":"HalalGuys","id":41344279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzQ0Mjc5","avatar_url":"https://avatars2.githubusercontent.com/u/41344279?v=4","gravatar_id":"","url":"https://api.github.com/users/HalalGuys","html_url":"https://github.com/HalalGuys","followers_url":"https://api.github.com/users/HalalGuys/followers","following_url":"https://api.github.com/users/HalalGuys/following{/other_user}","gists_url":"https://api.github.com/users/HalalGuys/gists{/gist_id}","starred_url":"https://api.github.com/users/HalalGuys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalalGuys/subscriptions","organizations_url":"https://api.github.com/users/HalalGuys/orgs","repos_url":"https://api.github.com/users/HalalGuys/repos","events_url":"https://api.github.com/users/HalalGuys/events{/privacy}","received_events_url":"https://api.github.com/users/HalalGuys/received_events","type":"Organization","site_admin":false},"repo":{"id":141331330,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMzEzMzA=","name":"bookings","full_name":"HalalGuys/bookings","owner":{"login":"HalalGuys","id":41344279,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMzQ0Mjc5","avatar_url":"https://avatars2.githubusercontent.com/u/41344279?v=4","gravatar_id":"","url":"https://api.github.com/users/HalalGuys","html_url":"https://github.com/HalalGuys","followers_url":"https://api.github.com/users/HalalGuys/followers","following_url":"https://api.github.com/users/HalalGuys/following{/other_user}","gists_url":"https://api.github.com/users/HalalGuys/gists{/gist_id}","starred_url":"https://api.github.com/users/HalalGuys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HalalGuys/subscriptions","organizations_url":"https://api.github.com/users/HalalGuys/orgs","repos_url":"https://api.github.com/users/HalalGuys/repos","events_url":"https://api.github.com/users/HalalGuys/events{/privacy}","received_events_url":"https://api.github.com/users/HalalGuys/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HalalGuys/bookings","description":"Purchase dialog component ","fork":false,"url":"https://api.github.com/repos/HalalGuys/bookings","forks_url":"https://api.github.com/repos/HalalGuys/bookings/forks","keys_url":"https://api.github.com/repos/HalalGuys/bookings/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HalalGuys/bookings/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HalalGuys/bookings/teams","hooks_url":"https://api.github.com/repos/HalalGuys/bookings/hooks","issue_events_url":"https://api.github.com/repos/HalalGuys/bookings/issues/events{/number}","events_url":"https://api.github.com/repos/HalalGuys/bookings/events","assignees_url":"https://api.github.com/repos/HalalGuys/bookings/assignees{/user}","branches_url":"https://api.github.com/repos/HalalGuys/bookings/branches{/branch}","tags_url":"https://api.github.com/repos/HalalGuys/bookings/tags","blobs_url":"https://api.github.com/repos/HalalGuys/bookings/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HalalGuys/bookings/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HalalGuys/bookings/git/refs{/sha}","trees_url":"https://api.github.com/repos/HalalGuys/bookings/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HalalGuys/bookings/statuses/{sha}","languages_url":"https://api.github.com/repos/HalalGuys/bookings/languages","stargazers_url":"https://api.github.com/repos/HalalGuys/bookings/stargazers","contributors_url":"https://api.github.com/repos/HalalGuys/bookings/contributors","subscribers_url":"https://api.github.com/repos/HalalGuys/bookings/subscribers","subscription_url":"https://api.github.com/repos/HalalGuys/bookings/subscription","commits_url":"https://api.github.com/repos/HalalGuys/bookings/commits{/sha}","git_commits_url":"https://api.github.com/repos/HalalGuys/bookings/git/commits{/sha}","comments_url":"https://api.github.com/repos/HalalGuys/bookings/comments{/number}","issue_comment_url":"https://api.github.com/repos/HalalGuys/bookings/issues/comments{/number}","contents_url":"https://api.github.com/repos/HalalGuys/bookings/contents/{+path}","compare_url":"https://api.github.com/repos/HalalGuys/bookings/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HalalGuys/bookings/merges","archive_url":"https://api.github.com/repos/HalalGuys/bookings/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HalalGuys/bookings/downloads","issues_url":"https://api.github.com/repos/HalalGuys/bookings/issues{/number}","pulls_url":"https://api.github.com/repos/HalalGuys/bookings/pulls{/number}","milestones_url":"https://api.github.com/repos/HalalGuys/bookings/milestones{/number}","notifications_url":"https://api.github.com/repos/HalalGuys/bookings/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HalalGuys/bookings/labels{/name}","releases_url":"https://api.github.com/repos/HalalGuys/bookings/releases{/id}","deployments_url":"https://api.github.com/repos/HalalGuys/bookings/deployments","created_at":"2018-07-17T18:59:30Z","updated_at":"2018-07-20T18:32:33Z","pushed_at":"2018-07-23T23:31:26Z","git_url":"git://github.com/HalalGuys/bookings.git","ssh_url":"[email protected]:HalalGuys/bookings.git","clone_url":"https://github.com/HalalGuys/bookings.git","svn_url":"https://github.com/HalalGuys/bookings","homepage":null,"size":4081,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HalalGuys/bookings/pulls/4"},"html":{"href":"https://github.com/HalalGuys/bookings/pull/4"},"issue":{"href":"https://api.github.com/repos/HalalGuys/bookings/issues/4"},"comments":{"href":"https://api.github.com/repos/HalalGuys/bookings/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/HalalGuys/bookings/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/HalalGuys/bookings/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HalalGuys/bookings/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/HalalGuys/bookings/statuses/b40620fdfeb816e26eb25720db1b0aafa490418c"}},"author_association":"COLLABORATOR"}}

8007510021

{"actor":{"display_login":"bcronin2"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/PHPEducation/confession/pulls/comments/231818151","pull_request_review_id":172870256,"id":231818151,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTgxODE1MQ==","diff_hunk":"@@ -0,0 +1,113 @@\n+<?php\n+\n+namespace App\\Http\\Controllers\\User;\n+\n+use App\\Models\\Like;\n+use Illuminate\\Http\\Request;\n+use App\\Http\\Controllers\\Controller;\n+use Illuminate\\Support\\Facades\\Auth;\n+\n+class LikeController extends Controller\n+{\n+ /**\n+ * Display a listing of the resource.\n+ *\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function index()\n+ {\n+ //\n+ }\n+\n+ /**\n+ * Show the form for creating a new resource.\n+ *\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function create()\n+ {\n+ //\n+ }\n+\n+ /**\n+ * Store a newly created resource in storage.\n+ *\n+ * @param \\Illuminate\\Http\\Request $request\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function store(Request $request)\n+ {\n+ //\n+ }\n+\n+ /**\n+ * Display the specified resource.\n+ *\n+ * @param int $id\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function show($id)\n+ {\n+ //\n+ }\n+\n+ /**\n+ * Show the form for editing the specified resource.\n+ *\n+ * @param int $id\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function edit($id)\n+ {\n+ //\n+ }\n+\n+ /**\n+ * Update the specified resource in storage.\n+ *\n+ * @param \\Illuminate\\Http\\Request $request\n+ * @param int $id\n+ * @return \\Illuminate\\Http\\Response\n+ */\n+ public function update(Request $request, $id)\n+ {\n+ $user = Auth::id();\n+\n+ $like = Like::where('user_id', $user)->where('post_id', $id)->first();\n+\n+ if (!$like) {\n+ $like = Like::create([\n+ 'user_id' => $request->get('user'),\n+ 'type' => 1,\n+ 'post_id' => $request->get('post_id'),\n+ ]);\n+ } else {\n+ if ($request->get('type') == 1 ){\n+ $like->update([\n+ 'type' => 0,\n+ ]);\n+ } else {\n+ $like->update([\n+ 'type' => 1,\n+ ]);\n+ }\n+ }\n+\n+ return response()->json([\n+ 'error' => false,","path":"app/Http/Controllers/User/LikeController.php","position":97,"original_position":97,"commit_id":"cc15fd91c7b9755cfdc58b356e99e85a78ca189b","original_commit_id":"cc15fd91c7b9755cfdc58b356e99e85a78ca189b","user":{"login":"framgiaciv3","id":40970418,"node_id":"MDQ6VXNlcjQwOTcwNDE4","avatar_url":"https://avatars3.githubusercontent.com/u/40970418?v=4","gravatar_id":"","url":"https://api.github.com/users/framgiaciv3","html_url":"https://github.com/framgiaciv3","followers_url":"https://api.github.com/users/framgiaciv3/followers","following_url":"https://api.github.com/users/framgiaciv3/following{/other_user}","gists_url":"https://api.github.com/users/framgiaciv3/gists{/gist_id}","starred_url":"https://api.github.com/users/framgiaciv3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/framgiaciv3/subscriptions","organizations_url":"https://api.github.com/users/framgiaciv3/orgs","repos_url":"https://api.github.com/users/framgiaciv3/repos","events_url":"https://api.github.com/users/framgiaciv3/events{/privacy}","received_events_url":"https://api.github.com/users/framgiaciv3/received_events","type":"User","site_admin":false},"body":"**Reporter**: CHECKSTYLE</br>**Rule**: Framgia.Arrays.ArrayDeclaration.NoComma</br>**Severity**: error</br>**File**: app/Http/Controllers/User/LikeController.php</br>**Line**: 99</br>Each line in an array declaration must end in a comma","created_at":"2018-11-08T09:37:18Z","updated_at":"2018-11-08T09:37:18Z","html_url":"https://github.com/PHPEducation/confession/pull/18#discussion_r231818151","pull_request_url":"https://api.github.com/repos/PHPEducation/confession/pulls/18","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PHPEducation/confession/pulls/comments/231818151"},"html":{"href":"https://github.com/PHPEducation/confession/pull/18#discussion_r231818151"},"pull_request":{"href":"https://api.github.com/repos/PHPEducation/confession/pulls/18"}}},"pull_request":{"url":"https://api.github.com/repos/PHPEducation/confession/pulls/18","id":229300959,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzAwOTU5","html_url":"https://github.com/PHPEducation/confession/pull/18","diff_url":"https://github.com/PHPEducation/confession/pull/18.diff","patch_url":"https://github.com/PHPEducation/confession/pull/18.patch","issue_url":"https://api.github.com/repos/PHPEducation/confession/issues/18","number":18,"state":"open","locked":false,"title":"like, comment, report","user":{"login":"NguyenCongViet","id":43327312,"node_id":"MDQ6VXNlcjQzMzI3MzEy","avatar_url":"https://avatars2.githubusercontent.com/u/43327312?v=4","gravatar_id":"","url":"https://api.github.com/users/NguyenCongViet","html_url":"https://github.com/NguyenCongViet","followers_url":"https://api.github.com/users/NguyenCongViet/followers","following_url":"https://api.github.com/users/NguyenCongViet/following{/other_user}","gists_url":"https://api.github.com/users/NguyenCongViet/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenCongViet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenCongViet/subscriptions","organizations_url":"https://api.github.com/users/NguyenCongViet/orgs","repos_url":"https://api.github.com/users/NguyenCongViet/repos","events_url":"https://api.github.com/users/NguyenCongViet/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenCongViet/received_events","type":"User","site_admin":false},"body":"ready","created_at":"2018-11-08T09:35:39Z","updated_at":"2018-11-08T09:37:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb8622e136486b12f541584311cc0f29dc690f2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PHPEducation/confession/pulls/18/commits","review_comments_url":"https://api.github.com/repos/PHPEducation/confession/pulls/18/comments","review_comment_url":"https://api.github.com/repos/PHPEducation/confession/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PHPEducation/confession/issues/18/comments","statuses_url":"https://api.github.com/repos/PHPEducation/confession/statuses/cc15fd91c7b9755cfdc58b356e99e85a78ca189b","head":{"label":"NguyenCongViet:viet-cfs","ref":"viet-cfs","sha":"cc15fd91c7b9755cfdc58b356e99e85a78ca189b","user":{"login":"NguyenCongViet","id":43327312,"node_id":"MDQ6VXNlcjQzMzI3MzEy","avatar_url":"https://avatars2.githubusercontent.com/u/43327312?v=4","gravatar_id":"","url":"https://api.github.com/users/NguyenCongViet","html_url":"https://github.com/NguyenCongViet","followers_url":"https://api.github.com/users/NguyenCongViet/followers","following_url":"https://api.github.com/users/NguyenCongViet/following{/other_user}","gists_url":"https://api.github.com/users/NguyenCongViet/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenCongViet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenCongViet/subscriptions","organizations_url":"https://api.github.com/users/NguyenCongViet/orgs","repos_url":"https://api.github.com/users/NguyenCongViet/repos","events_url":"https://api.github.com/users/NguyenCongViet/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenCongViet/received_events","type":"User","site_admin":false},"repo":{"id":155493742,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU0OTM3NDI=","name":"confession","full_name":"NguyenCongViet/confession","private":false,"owner":{"login":"NguyenCongViet","id":43327312,"node_id":"MDQ6VXNlcjQzMzI3MzEy","avatar_url":"https://avatars2.githubusercontent.com/u/43327312?v=4","gravatar_id":"","url":"https://api.github.com/users/NguyenCongViet","html_url":"https://github.com/NguyenCongViet","followers_url":"https://api.github.com/users/NguyenCongViet/followers","following_url":"https://api.github.com/users/NguyenCongViet/following{/other_user}","gists_url":"https://api.github.com/users/NguyenCongViet/gists{/gist_id}","starred_url":"https://api.github.com/users/NguyenCongViet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NguyenCongViet/subscriptions","organizations_url":"https://api.github.com/users/NguyenCongViet/orgs","repos_url":"https://api.github.com/users/NguyenCongViet/repos","events_url":"https://api.github.com/users/NguyenCongViet/events{/privacy}","received_events_url":"https://api.github.com/users/NguyenCongViet/received_events","type":"User","site_admin":false},"html_url":"https://github.com/NguyenCongViet/confession","description":null,"fork":true,"url":"https://api.github.com/repos/NguyenCongViet/confession","forks_url":"https://api.github.com/repos/NguyenCongViet/confession/forks","keys_url":"https://api.github.com/repos/NguyenCongViet/confession/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NguyenCongViet/confession/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NguyenCongViet/confession/teams","hooks_url":"https://api.github.com/repos/NguyenCongViet/confession/hooks","issue_events_url":"https://api.github.com/repos/NguyenCongViet/confession/issues/events{/number}","events_url":"https://api.github.com/repos/NguyenCongViet/confession/events","assignees_url":"https://api.github.com/repos/NguyenCongViet/confession/assignees{/user}","branches_url":"https://api.github.com/repos/NguyenCongViet/confession/branches{/branch}","tags_url":"https://api.github.com/repos/NguyenCongViet/confession/tags","blobs_url":"https://api.github.com/repos/NguyenCongViet/confession/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NguyenCongViet/confession/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NguyenCongViet/confession/git/refs{/sha}","trees_url":"https://api.github.com/repos/NguyenCongViet/confession/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NguyenCongViet/confession/statuses/{sha}","languages_url":"https://api.github.com/repos/NguyenCongViet/confession/languages","stargazers_url":"https://api.github.com/repos/NguyenCongViet/confession/stargazers","contributors_url":"https://api.github.com/repos/NguyenCongViet/confession/contributors","subscribers_url":"https://api.github.com/repos/NguyenCongViet/confession/subscribers","subscription_url":"https://api.github.com/repos/NguyenCongViet/confession/subscription","commits_url":"https://api.github.com/repos/NguyenCongViet/confession/commits{/sha}","git_commits_url":"https://api.github.com/repos/NguyenCongViet/confession/git/commits{/sha}","comments_url":"https://api.github.com/repos/NguyenCongViet/confession/comments{/number}","issue_comment_url":"https://api.github.com/repos/NguyenCongViet/confession/issues/comments{/number}","contents_url":"https://api.github.com/repos/NguyenCongViet/confession/contents/{+path}","compare_url":"https://api.github.com/repos/NguyenCongViet/confession/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NguyenCongViet/confession/merges","archive_url":"https://api.github.com/repos/NguyenCongViet/confession/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NguyenCongViet/confession/downloads","issues_url":"https://api.github.com/repos/NguyenCongViet/confession/issues{/number}","pulls_url":"https://api.github.com/repos/NguyenCongViet/confession/pulls{/number}","milestones_url":"https://api.github.com/repos/NguyenCongViet/confession/milestones{/number}","notifications_url":"https://api.github.com/repos/NguyenCongViet/confession/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NguyenCongViet/confession/labels{/name}","releases_url":"https://api.github.com/repos/NguyenCongViet/confession/releases{/id}","deployments_url":"https://api.github.com/repos/NguyenCongViet/confession/deployments","created_at":"2018-10-31T03:33:46Z","updated_at":"2018-11-05T01:56:17Z","pushed_at":"2018-11-08T09:35:27Z","git_url":"git://github.com/NguyenCongViet/confession.git","ssh_url":"[email protected]:NguyenCongViet/confession.git","clone_url":"https://github.com/NguyenCongViet/confession.git","svn_url":"https://github.com/NguyenCongViet/confession","homepage":null,"size":640,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PHPEducation:master","ref":"master","sha":"f62d2f164e51c14394973bd2aa1d97efc8f13ffc","user":{"login":"PHPEducation","id":41612083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjEyMDgz","avatar_url":"https://avatars3.githubusercontent.com/u/41612083?v=4","gravatar_id":"","url":"https://api.github.com/users/PHPEducation","html_url":"https://github.com/PHPEducation","followers_url":"https://api.github.com/users/PHPEducation/followers","following_url":"https://api.github.com/users/PHPEducation/following{/other_user}","gists_url":"https://api.github.com/users/PHPEducation/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPEducation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPEducation/subscriptions","organizations_url":"https://api.github.com/users/PHPEducation/orgs","repos_url":"https://api.github.com/users/PHPEducation/repos","events_url":"https://api.github.com/users/PHPEducation/events{/privacy}","received_events_url":"https://api.github.com/users/PHPEducation/received_events","type":"Organization","site_admin":false},"repo":{"id":147600569,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2MDA1Njk=","name":"confession","full_name":"PHPEducation/confession","private":false,"owner":{"login":"PHPEducation","id":41612083,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNjEyMDgz","avatar_url":"https://avatars3.githubusercontent.com/u/41612083?v=4","gravatar_id":"","url":"https://api.github.com/users/PHPEducation","html_url":"https://github.com/PHPEducation","followers_url":"https://api.github.com/users/PHPEducation/followers","following_url":"https://api.github.com/users/PHPEducation/following{/other_user}","gists_url":"https://api.github.com/users/PHPEducation/gists{/gist_id}","starred_url":"https://api.github.com/users/PHPEducation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PHPEducation/subscriptions","organizations_url":"https://api.github.com/users/PHPEducation/orgs","repos_url":"https://api.github.com/users/PHPEducation/repos","events_url":"https://api.github.com/users/PHPEducation/events{/privacy}","received_events_url":"https://api.github.com/users/PHPEducation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PHPEducation/confession","description":null,"fork":false,"url":"https://api.github.com/repos/PHPEducation/confession","forks_url":"https://api.github.com/repos/PHPEducation/confession/forks","keys_url":"https://api.github.com/repos/PHPEducation/confession/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PHPEducation/confession/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PHPEducation/confession/teams","hooks_url":"https://api.github.com/repos/PHPEducation/confession/hooks","issue_events_url":"https://api.github.com/repos/PHPEducation/confession/issues/events{/number}","events_url":"https://api.github.com/repos/PHPEducation/confession/events","assignees_url":"https://api.github.com/repos/PHPEducation/confession/assignees{/user}","branches_url":"https://api.github.com/repos/PHPEducation/confession/branches{/branch}","tags_url":"https://api.github.com/repos/PHPEducation/confession/tags","blobs_url":"https://api.github.com/repos/PHPEducation/confession/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PHPEducation/confession/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PHPEducation/confession/git/refs{/sha}","trees_url":"https://api.github.com/repos/PHPEducation/confession/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PHPEducation/confession/statuses/{sha}","languages_url":"https://api.github.com/repos/PHPEducation/confession/languages","stargazers_url":"https://api.github.com/repos/PHPEducation/confession/stargazers","contributors_url":"https://api.github.com/repos/PHPEducation/confession/contributors","subscribers_url":"https://api.github.com/repos/PHPEducation/confession/subscribers","subscription_url":"https://api.github.com/repos/PHPEducation/confession/subscription","commits_url":"https://api.github.com/repos/PHPEducation/confession/commits{/sha}","git_commits_url":"https://api.github.com/repos/PHPEducation/confession/git/commits{/sha}","comments_url":"https://api.github.com/repos/PHPEducation/confession/comments{/number}","issue_comment_url":"https://api.github.com/repos/PHPEducation/confession/issues/comments{/number}","contents_url":"https://api.github.com/repos/PHPEducation/confession/contents/{+path}","compare_url":"https://api.github.com/repos/PHPEducation/confession/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PHPEducation/confession/merges","archive_url":"https://api.github.com/repos/PHPEducation/confession/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PHPEducation/confession/downloads","issues_url":"https://api.github.com/repos/PHPEducation/confession/issues{/number}","pulls_url":"https://api.github.com/repos/PHPEducation/confession/pulls{/number}","milestones_url":"https://api.github.com/repos/PHPEducation/confession/milestones{/number}","notifications_url":"https://api.github.com/repos/PHPEducation/confession/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PHPEducation/confession/labels{/name}","releases_url":"https://api.github.com/repos/PHPEducation/confession/releases{/id}","deployments_url":"https://api.github.com/repos/PHPEducation/confession/deployments","created_at":"2018-09-06T01:31:22Z","updated_at":"2018-11-08T06:08:02Z","pushed_at":"2018-11-08T09:35:40Z","git_url":"git://github.com/PHPEducation/confession.git","ssh_url":"[email protected]:PHPEducation/confession.git","clone_url":"https://github.com/PHPEducation/confession.git","svn_url":"https://github.com/PHPEducation/confession","homepage":null,"size":679,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":2,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PHPEducation/confession/pulls/18"},"html":{"href":"https://github.com/PHPEducation/confession/pull/18"},"issue":{"href":"https://api.github.com/repos/PHPEducation/confession/issues/18"},"comments":{"href":"https://api.github.com/repos/PHPEducation/confession/issues/18/comments"},"review_comments":{"href":"https://api.github.com/repos/PHPEducation/confession/pulls/18/comments"},"review_comment":{"href":"https://api.github.com/repos/PHPEducation/confession/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PHPEducation/confession/pulls/18/commits"},"statuses":{"href":"https://api.github.com/repos/PHPEducation/confession/statuses/cc15fd91c7b9755cfdc58b356e99e85a78ca189b"}},"author_association":"COLLABORATOR"}}

8555290103

{"actor":{"display_login":"framgiaciv3"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/threefoldtech/0-templates/pulls/comments/230581155","pull_request_review_id":171354596,"id":230581155,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU4MTE1NQ==","diff_hunk":"@@ -0,0 +1,106 @@\n+from tests.testcases.base_test import BaseTest\n+import unittest\n+import time\n+from random import randint\n+from zerorobot.dsl.ZeroRobotManager import ServiceCreateError\n+from tests.controller.controller import Controller\n+\n+class TESTContainer(BaseTest):\n+\n+ def __init__(self, *args, **kwargs):\n+ super().__init__(*args, **kwargs)\n+\n+ def setUp(self):","path":"tests/testcases/a_basics/container_testcases.py","position":13,"original_position":13,"commit_id":"6f1d5aa110c6539e4faa5be2def7da7d7f45e983","original_commit_id":"6f1d5aa110c6539e4faa5be2def7da7d7f45e983","user":{"login":"0xIslamTaha","id":17981089,"node_id":"MDQ6VXNlcjE3OTgxMDg5","avatar_url":"https://avatars0.githubusercontent.com/u/17981089?v=4","gravatar_id":"","url":"https://api.github.com/users/0xIslamTaha","html_url":"https://github.com/0xIslamTaha","followers_url":"https://api.github.com/users/0xIslamTaha/followers","following_url":"https://api.github.com/users/0xIslamTaha/following{/other_user}","gists_url":"https://api.github.com/users/0xIslamTaha/gists{/gist_id}","starred_url":"https://api.github.com/users/0xIslamTaha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xIslamTaha/subscriptions","organizations_url":"https://api.github.com/users/0xIslamTaha/orgs","repos_url":"https://api.github.com/users/0xIslamTaha/repos","events_url":"https://api.github.com/users/0xIslamTaha/events{/privacy}","received_events_url":"https://api.github.com/users/0xIslamTaha/received_events","type":"User","site_admin":false},"body":"remove it","created_at":"2018-11-04T09:22:07Z","updated_at":"2018-11-04T09:36:43Z","html_url":"https://github.com/threefoldtech/0-templates/pull/193#discussion_r230581155","pull_request_url":"https://api.github.com/repos/threefoldtech/0-templates/pulls/193","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/threefoldtech/0-templates/pulls/comments/230581155"},"html":{"href":"https://github.com/threefoldtech/0-templates/pull/193#discussion_r230581155"},"pull_request":{"href":"https://api.github.com/repos/threefoldtech/0-templates/pulls/193"}}},"pull_request":{"url":"https://api.github.com/repos/threefoldtech/0-templates/pulls/193","id":227634445,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjM0NDQ1","html_url":"https://github.com/threefoldtech/0-templates/pull/193","diff_url":"https://github.com/threefoldtech/0-templates/pull/193.diff","patch_url":"https://github.com/threefoldtech/0-templates/pull/193.patch","issue_url":"https://api.github.com/repos/threefoldtech/0-templates/issues/193","number":193,"state":"open","locked":false,"title":"Container testcases","user":{"login":"Dinaamagdy","id":24386802,"node_id":"MDQ6VXNlcjI0Mzg2ODAy","avatar_url":"https://avatars2.githubusercontent.com/u/24386802?v=4","gravatar_id":"","url":"https://api.github.com/users/Dinaamagdy","html_url":"https://github.com/Dinaamagdy","followers_url":"https://api.github.com/users/Dinaamagdy/followers","following_url":"https://api.github.com/users/Dinaamagdy/following{/other_user}","gists_url":"https://api.github.com/users/Dinaamagdy/gists{/gist_id}","starred_url":"https://api.github.com/users/Dinaamagdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dinaamagdy/subscriptions","organizations_url":"https://api.github.com/users/Dinaamagdy/orgs","repos_url":"https://api.github.com/users/Dinaamagdy/repos","events_url":"https://api.github.com/users/Dinaamagdy/events{/privacy}","received_events_url":"https://api.github.com/users/Dinaamagdy/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-01T14:20:09Z","updated_at":"2018-11-04T09:36:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"47e5b967a9284efb50316aae568a7d83cd658ee5","assignee":{"login":"Dinaamagdy","id":24386802,"node_id":"MDQ6VXNlcjI0Mzg2ODAy","avatar_url":"https://avatars2.githubusercontent.com/u/24386802?v=4","gravatar_id":"","url":"https://api.github.com/users/Dinaamagdy","html_url":"https://github.com/Dinaamagdy","followers_url":"https://api.github.com/users/Dinaamagdy/followers","following_url":"https://api.github.com/users/Dinaamagdy/following{/other_user}","gists_url":"https://api.github.com/users/Dinaamagdy/gists{/gist_id}","starred_url":"https://api.github.com/users/Dinaamagdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dinaamagdy/subscriptions","organizations_url":"https://api.github.com/users/Dinaamagdy/orgs","repos_url":"https://api.github.com/users/Dinaamagdy/repos","events_url":"https://api.github.com/users/Dinaamagdy/events{/privacy}","received_events_url":"https://api.github.com/users/Dinaamagdy/received_events","type":"User","site_admin":false},"assignees":[{"login":"Dinaamagdy","id":24386802,"node_id":"MDQ6VXNlcjI0Mzg2ODAy","avatar_url":"https://avatars2.githubusercontent.com/u/24386802?v=4","gravatar_id":"","url":"https://api.github.com/users/Dinaamagdy","html_url":"https://github.com/Dinaamagdy","followers_url":"https://api.github.com/users/Dinaamagdy/followers","following_url":"https://api.github.com/users/Dinaamagdy/following{/other_user}","gists_url":"https://api.github.com/users/Dinaamagdy/gists{/gist_id}","starred_url":"https://api.github.com/users/Dinaamagdy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dinaamagdy/subscriptions","organizations_url":"https://api.github.com/users/Dinaamagdy/orgs","repos_url":"https://api.github.com/users/Dinaamagdy/repos","events_url":"https://api.github.com/users/Dinaamagdy/events{/privacy}","received_events_url":"https://api.github.com/users/Dinaamagdy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1094584292,"node_id":"MDU6TGFiZWwxMDk0NTg0Mjky","url":"https://api.github.com/repos/threefoldtech/0-templates/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":1008959086,"node_id":"MDU6TGFiZWwxMDA4OTU5MDg2","url":"https://api.github.com/repos/threefoldtech/0-templates/labels/state_inprogress","name":"state_inprogress","color":"c2e0c6","default":false},{"id":1008959105,"node_id":"MDU6TGFiZWwxMDA4OTU5MTA1","url":"https://api.github.com/repos/threefoldtech/0-templates/labels/state_verification","name":"state_verification","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/threefoldtech/0-templates/pulls/193/commits","review_comments_url":"https://api.github.com/repos/threefoldtech/0-templates/pulls/193/comments","review_comment_url":"https://api.github.com/repos/threefoldtech/0-templates/pulls/comments{/number}","comments_url":"https://api.github.com/repos/threefoldtech/0-templates/issues/193/comments","statuses_url":"https://api.github.com/repos/threefoldtech/0-templates/statuses/6f1d5aa110c6539e4faa5be2def7da7d7f45e983","head":{"label":"threefoldtech:container_testcases","ref":"container_testcases","sha":"6f1d5aa110c6539e4faa5be2def7da7d7f45e983","user":{"login":"threefoldtech","id":41825953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODI1OTUz","avatar_url":"https://avatars1.githubusercontent.com/u/41825953?v=4","gravatar_id":"","url":"https://api.github.com/users/threefoldtech","html_url":"https://github.com/threefoldtech","followers_url":"https://api.github.com/users/threefoldtech/followers","following_url":"https://api.github.com/users/threefoldtech/following{/other_user}","gists_url":"https://api.github.com/users/threefoldtech/gists{/gist_id}","starred_url":"https://api.github.com/users/threefoldtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threefoldtech/subscriptions","organizations_url":"https://api.github.com/users/threefoldtech/orgs","repos_url":"https://api.github.com/users/threefoldtech/repos","events_url":"https://api.github.com/users/threefoldtech/events{/privacy}","received_events_url":"https://api.github.com/users/threefoldtech/received_events","type":"Organization","site_admin":false},"repo":{"id":124394460,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzOTQ0NjA=","name":"0-templates","full_name":"threefoldtech/0-templates","private":false,"owner":{"login":"threefoldtech","id":41825953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODI1OTUz","avatar_url":"https://avatars1.githubusercontent.com/u/41825953?v=4","gravatar_id":"","url":"https://api.github.com/users/threefoldtech","html_url":"https://github.com/threefoldtech","followers_url":"https://api.github.com/users/threefoldtech/followers","following_url":"https://api.github.com/users/threefoldtech/following{/other_user}","gists_url":"https://api.github.com/users/threefoldtech/gists{/gist_id}","starred_url":"https://api.github.com/users/threefoldtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threefoldtech/subscriptions","organizations_url":"https://api.github.com/users/threefoldtech/orgs","repos_url":"https://api.github.com/users/threefoldtech/repos","events_url":"https://api.github.com/users/threefoldtech/events{/privacy}","received_events_url":"https://api.github.com/users/threefoldtech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/threefoldtech/0-templates","description":"0-robot templates","fork":false,"url":"https://api.github.com/repos/threefoldtech/0-templates","forks_url":"https://api.github.com/repos/threefoldtech/0-templates/forks","keys_url":"https://api.github.com/repos/threefoldtech/0-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threefoldtech/0-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threefoldtech/0-templates/teams","hooks_url":"https://api.github.com/repos/threefoldtech/0-templates/hooks","issue_events_url":"https://api.github.com/repos/threefoldtech/0-templates/issues/events{/number}","events_url":"https://api.github.com/repos/threefoldtech/0-templates/events","assignees_url":"https://api.github.com/repos/threefoldtech/0-templates/assignees{/user}","branches_url":"https://api.github.com/repos/threefoldtech/0-templates/branches{/branch}","tags_url":"https://api.github.com/repos/threefoldtech/0-templates/tags","blobs_url":"https://api.github.com/repos/threefoldtech/0-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threefoldtech/0-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threefoldtech/0-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/threefoldtech/0-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threefoldtech/0-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/threefoldtech/0-templates/languages","stargazers_url":"https://api.github.com/repos/threefoldtech/0-templates/stargazers","contributors_url":"https://api.github.com/repos/threefoldtech/0-templates/contributors","subscribers_url":"https://api.github.com/repos/threefoldtech/0-templates/subscribers","subscription_url":"https://api.github.com/repos/threefoldtech/0-templates/subscription","commits_url":"https://api.github.com/repos/threefoldtech/0-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/threefoldtech/0-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/threefoldtech/0-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/threefoldtech/0-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/threefoldtech/0-templates/contents/{+path}","compare_url":"https://api.github.com/repos/threefoldtech/0-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threefoldtech/0-templates/merges","archive_url":"https://api.github.com/repos/threefoldtech/0-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threefoldtech/0-templates/downloads","issues_url":"https://api.github.com/repos/threefoldtech/0-templates/issues{/number}","pulls_url":"https://api.github.com/repos/threefoldtech/0-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/threefoldtech/0-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/threefoldtech/0-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threefoldtech/0-templates/labels{/name}","releases_url":"https://api.github.com/repos/threefoldtech/0-templates/releases{/id}","deployments_url":"https://api.github.com/repos/threefoldtech/0-templates/deployments","created_at":"2018-03-08T13:20:16Z","updated_at":"2018-11-01T12:37:43Z","pushed_at":"2018-11-01T17:12:20Z","git_url":"git://github.com/threefoldtech/0-templates.git","ssh_url":"[email protected]:threefoldtech/0-templates.git","clone_url":"https://github.com/threefoldtech/0-templates.git","svn_url":"https://github.com/threefoldtech/0-templates","homepage":"","size":861,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":35,"watchers":0,"default_branch":"development"}},"base":{"label":"threefoldtech:testcases","ref":"testcases","sha":"a02535dfc24c7d90ef53070fa68cb83fd611d08b","user":{"login":"threefoldtech","id":41825953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODI1OTUz","avatar_url":"https://avatars1.githubusercontent.com/u/41825953?v=4","gravatar_id":"","url":"https://api.github.com/users/threefoldtech","html_url":"https://github.com/threefoldtech","followers_url":"https://api.github.com/users/threefoldtech/followers","following_url":"https://api.github.com/users/threefoldtech/following{/other_user}","gists_url":"https://api.github.com/users/threefoldtech/gists{/gist_id}","starred_url":"https://api.github.com/users/threefoldtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threefoldtech/subscriptions","organizations_url":"https://api.github.com/users/threefoldtech/orgs","repos_url":"https://api.github.com/users/threefoldtech/repos","events_url":"https://api.github.com/users/threefoldtech/events{/privacy}","received_events_url":"https://api.github.com/users/threefoldtech/received_events","type":"Organization","site_admin":false},"repo":{"id":124394460,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQzOTQ0NjA=","name":"0-templates","full_name":"threefoldtech/0-templates","private":false,"owner":{"login":"threefoldtech","id":41825953,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODI1OTUz","avatar_url":"https://avatars1.githubusercontent.com/u/41825953?v=4","gravatar_id":"","url":"https://api.github.com/users/threefoldtech","html_url":"https://github.com/threefoldtech","followers_url":"https://api.github.com/users/threefoldtech/followers","following_url":"https://api.github.com/users/threefoldtech/following{/other_user}","gists_url":"https://api.github.com/users/threefoldtech/gists{/gist_id}","starred_url":"https://api.github.com/users/threefoldtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/threefoldtech/subscriptions","organizations_url":"https://api.github.com/users/threefoldtech/orgs","repos_url":"https://api.github.com/users/threefoldtech/repos","events_url":"https://api.github.com/users/threefoldtech/events{/privacy}","received_events_url":"https://api.github.com/users/threefoldtech/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/threefoldtech/0-templates","description":"0-robot templates","fork":false,"url":"https://api.github.com/repos/threefoldtech/0-templates","forks_url":"https://api.github.com/repos/threefoldtech/0-templates/forks","keys_url":"https://api.github.com/repos/threefoldtech/0-templates/keys{/key_id}","collaborators_url":"https://api.github.com/repos/threefoldtech/0-templates/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/threefoldtech/0-templates/teams","hooks_url":"https://api.github.com/repos/threefoldtech/0-templates/hooks","issue_events_url":"https://api.github.com/repos/threefoldtech/0-templates/issues/events{/number}","events_url":"https://api.github.com/repos/threefoldtech/0-templates/events","assignees_url":"https://api.github.com/repos/threefoldtech/0-templates/assignees{/user}","branches_url":"https://api.github.com/repos/threefoldtech/0-templates/branches{/branch}","tags_url":"https://api.github.com/repos/threefoldtech/0-templates/tags","blobs_url":"https://api.github.com/repos/threefoldtech/0-templates/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/threefoldtech/0-templates/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/threefoldtech/0-templates/git/refs{/sha}","trees_url":"https://api.github.com/repos/threefoldtech/0-templates/git/trees{/sha}","statuses_url":"https://api.github.com/repos/threefoldtech/0-templates/statuses/{sha}","languages_url":"https://api.github.com/repos/threefoldtech/0-templates/languages","stargazers_url":"https://api.github.com/repos/threefoldtech/0-templates/stargazers","contributors_url":"https://api.github.com/repos/threefoldtech/0-templates/contributors","subscribers_url":"https://api.github.com/repos/threefoldtech/0-templates/subscribers","subscription_url":"https://api.github.com/repos/threefoldtech/0-templates/subscription","commits_url":"https://api.github.com/repos/threefoldtech/0-templates/commits{/sha}","git_commits_url":"https://api.github.com/repos/threefoldtech/0-templates/git/commits{/sha}","comments_url":"https://api.github.com/repos/threefoldtech/0-templates/comments{/number}","issue_comment_url":"https://api.github.com/repos/threefoldtech/0-templates/issues/comments{/number}","contents_url":"https://api.github.com/repos/threefoldtech/0-templates/contents/{+path}","compare_url":"https://api.github.com/repos/threefoldtech/0-templates/compare/{base}...{head}","merges_url":"https://api.github.com/repos/threefoldtech/0-templates/merges","archive_url":"https://api.github.com/repos/threefoldtech/0-templates/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/threefoldtech/0-templates/downloads","issues_url":"https://api.github.com/repos/threefoldtech/0-templates/issues{/number}","pulls_url":"https://api.github.com/repos/threefoldtech/0-templates/pulls{/number}","milestones_url":"https://api.github.com/repos/threefoldtech/0-templates/milestones{/number}","notifications_url":"https://api.github.com/repos/threefoldtech/0-templates/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/threefoldtech/0-templates/labels{/name}","releases_url":"https://api.github.com/repos/threefoldtech/0-templates/releases{/id}","deployments_url":"https://api.github.com/repos/threefoldtech/0-templates/deployments","created_at":"2018-03-08T13:20:16Z","updated_at":"2018-11-01T12:37:43Z","pushed_at":"2018-11-01T17:12:20Z","git_url":"git://github.com/threefoldtech/0-templates.git","ssh_url":"[email protected]:threefoldtech/0-templates.git","clone_url":"https://github.com/threefoldtech/0-templates.git","svn_url":"https://github.com/threefoldtech/0-templates","homepage":"","size":861,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":35,"watchers":0,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/threefoldtech/0-templates/pulls/193"},"html":{"href":"https://github.com/threefoldtech/0-templates/pull/193"},"issue":{"href":"https://api.github.com/repos/threefoldtech/0-templates/issues/193"},"comments":{"href":"https://api.github.com/repos/threefoldtech/0-templates/issues/193/comments"},"review_comments":{"href":"https://api.github.com/repos/threefoldtech/0-templates/pulls/193/comments"},"review_comment":{"href":"https://api.github.com/repos/threefoldtech/0-templates/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/threefoldtech/0-templates/pulls/193/commits"},"statuses":{"href":"https://api.github.com/repos/threefoldtech/0-templates/statuses/6f1d5aa110c6539e4faa5be2def7da7d7f45e983"}},"author_association":"NONE"}}

8531208963

{"actor":{"display_login":"0xIslamTaha"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/SmartCourse/app/pulls/comments/234424891","pull_request_review_id":176071239,"id":234424891,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDQyNDg5MQ==","diff_hunk":"@@ -0,0 +1,153 @@\n+const { writeFileSync } = require('fs')\n+const courses = require('./js/courses')\n+const subjects = require('./js/subjects')\n+const degreeData = require('../../../data/degrees')\n+const faculties = require('../../../data/faculties')\n+const { TABLE_NAMES } = require('../constants')\n+\n+const questionColumns = ['userID', 'code', 'title', 'body', 'pinned'].join(',')\n+\n+const ADMIN = 1\n+const universityID = 1\n+\n+const users = [\n+ {\n+ id: ADMIN,\n+ uid: '1233444',\n+ displayName: 'Moderator',\n+ email: '[email protected]',\n+ degree: 'PhD',\n+ gradYear: 2018\n+ }\n+]\n+\n+const SAMPLE_QUESTIONS = [\n+ {\n+ title: 'Is this course textbook necessary?',\n+ body: 'I\\'m wondering if it\\'s worth buying/obtaining the course textbook. If not, are there good alternative resources that people might recommend?'\n+ },\n+ {\n+ title: 'What year would you recommend taking this course?',\n+ body: 'Is this course worth taking earlier or later in my degree? What are the advantages or disadvantages?'\n+ },\n+ {\n+ title: 'Why did you take this course?',\n+ body: 'I\\'m wondering why people took this course as I don\\'t know a lot about it.'\n+ },\n+ {\n+ title: 'What are similar courses to this course?',\n+ body: 'I\\'m interested in this course\\'s content area and I\\'m looking for similar courses. What would people recommend, and why?'\n+ },\n+ {\n+ title: 'How essential is it to attend lectures?',\n+ body: 'Are the lectures for the course recorded? Are the worthwhile attending. What am I giving up if I can\\'t attend them?'\n+ }\n+]\n+\n+// mega query begins here\n+const data = `\\\n+BEGIN TRANSACTION;\\n\\\n+${\n+ // user\n+ users.map(sqlUser).join('\\n')\n+}\\n\n+${\n+ // uni\n+ `INSERT INTO ${TABLE_NAMES.UNIVERSITY} (name) VALUES (\"UNSW\");`\n+}\\n\n+${\n+ // faculties\n+ faculties.map(sqlFaculty).join('\\n')\n+}\\n\n+${\n+ // degrees\n+ degreeData.map(sqlDegree).join('\\n')\n+}\\n\n+${\n+ // subjects\n+ subjects.map(sqlSubject).join('\\n')\n+}\\n\n+${\n+ // courses\n+ courses.map(sqlCourse).join('\\n')\n+ // '\\n'\n+}\\n\n+${\n+ // questions\n+ courses.map(({ code }) =>\n+ SAMPLE_QUESTIONS.map(sqlQuestion(code)).join('\\n') + '\\n').join('')\n+}\\\n+\\nCOMMIT;`\n+","path":"backend/src/models/db/init_sql.js","position":81,"original_position":81,"commit_id":"463211bd3d14275fc289152ea65c946a07f534c7","original_commit_id":"463211bd3d14275fc289152ea65c946a07f534c7","user":{"login":"PapaPwn","id":26681270,"node_id":"MDQ6VXNlcjI2NjgxMjcw","avatar_url":"https://avatars0.githubusercontent.com/u/26681270?v=4","gravatar_id":"","url":"https://api.github.com/users/PapaPwn","html_url":"https://github.com/PapaPwn","followers_url":"https://api.github.com/users/PapaPwn/followers","following_url":"https://api.github.com/users/PapaPwn/following{/other_user}","gists_url":"https://api.github.com/users/PapaPwn/gists{/gist_id}","starred_url":"https://api.github.com/users/PapaPwn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PapaPwn/subscriptions","organizations_url":"https://api.github.com/users/PapaPwn/orgs","repos_url":"https://api.github.com/users/PapaPwn/repos","events_url":"https://api.github.com/users/PapaPwn/events{/privacy}","received_events_url":"https://api.github.com/users/PapaPwn/received_events","type":"User","site_admin":false},"body":"Wow that is super clean","created_at":"2018-11-17T23:35:33Z","updated_at":"2018-11-17T23:35:34Z","html_url":"https://github.com/SmartCourse/app/pull/276#discussion_r234424891","pull_request_url":"https://api.github.com/repos/SmartCourse/app/pulls/276","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SmartCourse/app/pulls/comments/234424891"},"html":{"href":"https://github.com/SmartCourse/app/pull/276#discussion_r234424891"},"pull_request":{"href":"https://api.github.com/repos/SmartCourse/app/pulls/276"}}},"pull_request":{"url":"https://api.github.com/repos/SmartCourse/app/pulls/276","id":227512093,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NTEyMDkz","html_url":"https://github.com/SmartCourse/app/pull/276","diff_url":"https://github.com/SmartCourse/app/pull/276.diff","patch_url":"https://github.com/SmartCourse/app/pull/276.patch","issue_url":"https://api.github.com/repos/SmartCourse/app/issues/276","number":276,"state":"open","locked":false,"title":"Move DB init over to SQL","user":{"login":"DarkPurple141","id":13936670,"node_id":"MDQ6VXNlcjEzOTM2Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/13936670?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkPurple141","html_url":"https://github.com/DarkPurple141","followers_url":"https://api.github.com/users/DarkPurple141/followers","following_url":"https://api.github.com/users/DarkPurple141/following{/other_user}","gists_url":"https://api.github.com/users/DarkPurple141/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkPurple141/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkPurple141/subscriptions","organizations_url":"https://api.github.com/users/DarkPurple141/orgs","repos_url":"https://api.github.com/users/DarkPurple141/repos","events_url":"https://api.github.com/users/DarkPurple141/events{/privacy}","received_events_url":"https://api.github.com/users/DarkPurple141/received_events","type":"User","site_admin":false},"body":"1. Made it faster","created_at":"2018-11-01T04:44:33Z","updated_at":"2018-11-17T23:35:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"68b3746edffda895c49d2bc908657aa59cecf0f9","assignee":{"login":"DarkPurple141","id":13936670,"node_id":"MDQ6VXNlcjEzOTM2Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/13936670?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkPurple141","html_url":"https://github.com/DarkPurple141","followers_url":"https://api.github.com/users/DarkPurple141/followers","following_url":"https://api.github.com/users/DarkPurple141/following{/other_user}","gists_url":"https://api.github.com/users/DarkPurple141/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkPurple141/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkPurple141/subscriptions","organizations_url":"https://api.github.com/users/DarkPurple141/orgs","repos_url":"https://api.github.com/users/DarkPurple141/repos","events_url":"https://api.github.com/users/DarkPurple141/events{/privacy}","received_events_url":"https://api.github.com/users/DarkPurple141/received_events","type":"User","site_admin":false},"assignees":[{"login":"DarkPurple141","id":13936670,"node_id":"MDQ6VXNlcjEzOTM2Njcw","avatar_url":"https://avatars0.githubusercontent.com/u/13936670?v=4","gravatar_id":"","url":"https://api.github.com/users/DarkPurple141","html_url":"https://github.com/DarkPurple141","followers_url":"https://api.github.com/users/DarkPurple141/followers","following_url":"https://api.github.com/users/DarkPurple141/following{/other_user}","gists_url":"https://api.github.com/users/DarkPurple141/gists{/gist_id}","starred_url":"https://api.github.com/users/DarkPurple141/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DarkPurple141/subscriptions","organizations_url":"https://api.github.com/users/DarkPurple141/orgs","repos_url":"https://api.github.com/users/DarkPurple141/repos","events_url":"https://api.github.com/users/DarkPurple141/events{/privacy}","received_events_url":"https://api.github.com/users/DarkPurple141/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"NunoDasNeves","id":4468620,"node_id":"MDQ6VXNlcjQ0Njg2MjA=","avatar_url":"https://avatars1.githubusercontent.com/u/4468620?v=4","gravatar_id":"","url":"https://api.github.com/users/NunoDasNeves","html_url":"https://github.com/NunoDasNeves","followers_url":"https://api.github.com/users/NunoDasNeves/followers","following_url":"https://api.github.com/users/NunoDasNeves/following{/other_user}","gists_url":"https://api.github.com/users/NunoDasNeves/gists{/gist_id}","starred_url":"https://api.github.com/users/NunoDasNeves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NunoDasNeves/subscriptions","organizations_url":"https://api.github.com/users/NunoDasNeves/orgs","repos_url":"https://api.github.com/users/NunoDasNeves/repos","events_url":"https://api.github.com/users/NunoDasNeves/events{/privacy}","received_events_url":"https://api.github.com/users/NunoDasNeves/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SmartCourse/app/pulls/276/commits","review_comments_url":"https://api.github.com/repos/SmartCourse/app/pulls/276/comments","review_comment_url":"https://api.github.com/repos/SmartCourse/app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SmartCourse/app/issues/276/comments","statuses_url":"https://api.github.com/repos/SmartCourse/app/statuses/463211bd3d14275fc289152ea65c946a07f534c7","head":{"label":"SmartCourse:s10-sqlerise-db-init","ref":"s10-sqlerise-db-init","sha":"463211bd3d14275fc289152ea65c946a07f534c7","user":{"login":"SmartCourse","id":42050730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDUwNzMw","avatar_url":"https://avatars1.githubusercontent.com/u/42050730?v=4","gravatar_id":"","url":"https://api.github.com/users/SmartCourse","html_url":"https://github.com/SmartCourse","followers_url":"https://api.github.com/users/SmartCourse/followers","following_url":"https://api.github.com/users/SmartCourse/following{/other_user}","gists_url":"https://api.github.com/users/SmartCourse/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartCourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartCourse/subscriptions","organizations_url":"https://api.github.com/users/SmartCourse/orgs","repos_url":"https://api.github.com/users/SmartCourse/repos","events_url":"https://api.github.com/users/SmartCourse/events{/privacy}","received_events_url":"https://api.github.com/users/SmartCourse/received_events","type":"Organization","site_admin":false},"repo":{"id":143969680,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5Njk2ODA=","name":"app","full_name":"SmartCourse/app","private":false,"owner":{"login":"SmartCourse","id":42050730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDUwNzMw","avatar_url":"https://avatars1.githubusercontent.com/u/42050730?v=4","gravatar_id":"","url":"https://api.github.com/users/SmartCourse","html_url":"https://github.com/SmartCourse","followers_url":"https://api.github.com/users/SmartCourse/followers","following_url":"https://api.github.com/users/SmartCourse/following{/other_user}","gists_url":"https://api.github.com/users/SmartCourse/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartCourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartCourse/subscriptions","organizations_url":"https://api.github.com/users/SmartCourse/orgs","repos_url":"https://api.github.com/users/SmartCourse/repos","events_url":"https://api.github.com/users/SmartCourse/events{/privacy}","received_events_url":"https://api.github.com/users/SmartCourse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SmartCourse/app","description":"Making the most of your degree.","fork":false,"url":"https://api.github.com/repos/SmartCourse/app","forks_url":"https://api.github.com/repos/SmartCourse/app/forks","keys_url":"https://api.github.com/repos/SmartCourse/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmartCourse/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmartCourse/app/teams","hooks_url":"https://api.github.com/repos/SmartCourse/app/hooks","issue_events_url":"https://api.github.com/repos/SmartCourse/app/issues/events{/number}","events_url":"https://api.github.com/repos/SmartCourse/app/events","assignees_url":"https://api.github.com/repos/SmartCourse/app/assignees{/user}","branches_url":"https://api.github.com/repos/SmartCourse/app/branches{/branch}","tags_url":"https://api.github.com/repos/SmartCourse/app/tags","blobs_url":"https://api.github.com/repos/SmartCourse/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmartCourse/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmartCourse/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmartCourse/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmartCourse/app/statuses/{sha}","languages_url":"https://api.github.com/repos/SmartCourse/app/languages","stargazers_url":"https://api.github.com/repos/SmartCourse/app/stargazers","contributors_url":"https://api.github.com/repos/SmartCourse/app/contributors","subscribers_url":"https://api.github.com/repos/SmartCourse/app/subscribers","subscription_url":"https://api.github.com/repos/SmartCourse/app/subscription","commits_url":"https://api.github.com/repos/SmartCourse/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmartCourse/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmartCourse/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmartCourse/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmartCourse/app/contents/{+path}","compare_url":"https://api.github.com/repos/SmartCourse/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmartCourse/app/merges","archive_url":"https://api.github.com/repos/SmartCourse/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmartCourse/app/downloads","issues_url":"https://api.github.com/repos/SmartCourse/app/issues{/number}","pulls_url":"https://api.github.com/repos/SmartCourse/app/pulls{/number}","milestones_url":"https://api.github.com/repos/SmartCourse/app/milestones{/number}","notifications_url":"https://api.github.com/repos/SmartCourse/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmartCourse/app/labels{/name}","releases_url":"https://api.github.com/repos/SmartCourse/app/releases{/id}","deployments_url":"https://api.github.com/repos/SmartCourse/app/deployments","created_at":"2018-08-08T06:22:23Z","updated_at":"2018-11-17T02:29:33Z","pushed_at":"2018-11-17T08:48:17Z","git_url":"git://github.com/SmartCourse/app.git","ssh_url":"[email protected]:SmartCourse/app.git","clone_url":"https://github.com/SmartCourse/app.git","svn_url":"https://github.com/SmartCourse/app","homepage":"https://www.smartcourse.me","size":4544,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":0,"open_issues":38,"watchers":2,"default_branch":"dev"}},"base":{"label":"SmartCourse:dev","ref":"dev","sha":"25ef8c79ffd5396b12e056b1bed3e048ba463fb2","user":{"login":"SmartCourse","id":42050730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDUwNzMw","avatar_url":"https://avatars1.githubusercontent.com/u/42050730?v=4","gravatar_id":"","url":"https://api.github.com/users/SmartCourse","html_url":"https://github.com/SmartCourse","followers_url":"https://api.github.com/users/SmartCourse/followers","following_url":"https://api.github.com/users/SmartCourse/following{/other_user}","gists_url":"https://api.github.com/users/SmartCourse/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartCourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartCourse/subscriptions","organizations_url":"https://api.github.com/users/SmartCourse/orgs","repos_url":"https://api.github.com/users/SmartCourse/repos","events_url":"https://api.github.com/users/SmartCourse/events{/privacy}","received_events_url":"https://api.github.com/users/SmartCourse/received_events","type":"Organization","site_admin":false},"repo":{"id":143969680,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM5Njk2ODA=","name":"app","full_name":"SmartCourse/app","private":false,"owner":{"login":"SmartCourse","id":42050730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMDUwNzMw","avatar_url":"https://avatars1.githubusercontent.com/u/42050730?v=4","gravatar_id":"","url":"https://api.github.com/users/SmartCourse","html_url":"https://github.com/SmartCourse","followers_url":"https://api.github.com/users/SmartCourse/followers","following_url":"https://api.github.com/users/SmartCourse/following{/other_user}","gists_url":"https://api.github.com/users/SmartCourse/gists{/gist_id}","starred_url":"https://api.github.com/users/SmartCourse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SmartCourse/subscriptions","organizations_url":"https://api.github.com/users/SmartCourse/orgs","repos_url":"https://api.github.com/users/SmartCourse/repos","events_url":"https://api.github.com/users/SmartCourse/events{/privacy}","received_events_url":"https://api.github.com/users/SmartCourse/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SmartCourse/app","description":"Making the most of your degree.","fork":false,"url":"https://api.github.com/repos/SmartCourse/app","forks_url":"https://api.github.com/repos/SmartCourse/app/forks","keys_url":"https://api.github.com/repos/SmartCourse/app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SmartCourse/app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SmartCourse/app/teams","hooks_url":"https://api.github.com/repos/SmartCourse/app/hooks","issue_events_url":"https://api.github.com/repos/SmartCourse/app/issues/events{/number}","events_url":"https://api.github.com/repos/SmartCourse/app/events","assignees_url":"https://api.github.com/repos/SmartCourse/app/assignees{/user}","branches_url":"https://api.github.com/repos/SmartCourse/app/branches{/branch}","tags_url":"https://api.github.com/repos/SmartCourse/app/tags","blobs_url":"https://api.github.com/repos/SmartCourse/app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SmartCourse/app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SmartCourse/app/git/refs{/sha}","trees_url":"https://api.github.com/repos/SmartCourse/app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SmartCourse/app/statuses/{sha}","languages_url":"https://api.github.com/repos/SmartCourse/app/languages","stargazers_url":"https://api.github.com/repos/SmartCourse/app/stargazers","contributors_url":"https://api.github.com/repos/SmartCourse/app/contributors","subscribers_url":"https://api.github.com/repos/SmartCourse/app/subscribers","subscription_url":"https://api.github.com/repos/SmartCourse/app/subscription","commits_url":"https://api.github.com/repos/SmartCourse/app/commits{/sha}","git_commits_url":"https://api.github.com/repos/SmartCourse/app/git/commits{/sha}","comments_url":"https://api.github.com/repos/SmartCourse/app/comments{/number}","issue_comment_url":"https://api.github.com/repos/SmartCourse/app/issues/comments{/number}","contents_url":"https://api.github.com/repos/SmartCourse/app/contents/{+path}","compare_url":"https://api.github.com/repos/SmartCourse/app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SmartCourse/app/merges","archive_url":"https://api.github.com/repos/SmartCourse/app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SmartCourse/app/downloads","issues_url":"https://api.github.com/repos/SmartCourse/app/issues{/number}","pulls_url":"https://api.github.com/repos/SmartCourse/app/pulls{/number}","milestones_url":"https://api.github.com/repos/SmartCourse/app/milestones{/number}","notifications_url":"https://api.github.com/repos/SmartCourse/app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SmartCourse/app/labels{/name}","releases_url":"https://api.github.com/repos/SmartCourse/app/releases{/id}","deployments_url":"https://api.github.com/repos/SmartCourse/app/deployments","created_at":"2018-08-08T06:22:23Z","updated_at":"2018-11-17T02:29:33Z","pushed_at":"2018-11-17T08:48:17Z","git_url":"git://github.com/SmartCourse/app.git","ssh_url":"[email protected]:SmartCourse/app.git","clone_url":"https://github.com/SmartCourse/app.git","svn_url":"https://github.com/SmartCourse/app","homepage":"https://www.smartcourse.me","size":4544,"stargazers_count":2,"watchers_count":2,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":0,"open_issues":38,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/SmartCourse/app/pulls/276"},"html":{"href":"https://github.com/SmartCourse/app/pull/276"},"issue":{"href":"https://api.github.com/repos/SmartCourse/app/issues/276"},"comments":{"href":"https://api.github.com/repos/SmartCourse/app/issues/276/comments"},"review_comments":{"href":"https://api.github.com/repos/SmartCourse/app/pulls/276/comments"},"review_comment":{"href":"https://api.github.com/repos/SmartCourse/app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SmartCourse/app/pulls/276/commits"},"statuses":{"href":"https://api.github.com/repos/SmartCourse/app/statuses/463211bd3d14275fc289152ea65c946a07f534c7"}},"author_association":"COLLABORATOR"}}

8607534325

{"actor":{"display_login":"PapaPwn"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/comments/244423362","pull_request_review_id":188381329,"id":244423362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQyMzM2Mg==","diff_hunk":"@@ -0,0 +1,282 @@\n+-module(telemetry_SUITE).\n+\n+-compile(export_all).\n+\n+-include_lib(\"common_test/include/ct.hrl\").\n+-include_lib(\"stdlib/include/assert.hrl\").\n+\n+all() ->\n+ [bad_event_names, duplicate_attach, invoke_handler, default_metadata,\n+ list_handlers, list_for_prefix, detach_on_exception,\n+ no_execute_detached, no_execute_on_prefix, no_execute_on_specific,\n+ handler_on_multiple_events, remove_all_handler_on_failure,\n+ list_handler_on_many, detach_from_all].\n+\n+init_per_suite(Config) ->\n+ application:ensure_all_started(telemetry),\n+ Config.\n+\n+end_per_suite(_Config) ->\n+ application:stop(telemetry).\n+\n+init_per_testcase(_, Config) ->\n+ HandlerId = crypto:strong_rand_bytes(16),\n+ [{id, HandlerId} | Config].\n+\n+end_per_testcase(_, Config) ->\n+ HandlerId = ?config(id, Config),\n+ telemetry:detach(HandlerId).\n+\n+bad_event_names(Config) ->\n+ HandlerId = ?config(id, Config),\n+ ?assertError(badarg, telemetry:attach(HandlerId, [\"some\", event], fun ?MODULE:echo_event/4, [])),\n+ ?assertError(badarg, telemetry:attach(HandlerId, hello, fun ?MODULE:echo_event/4, [])).\n+\n+%% attaching returns error if handler with the same ID already exist\n+duplicate_attach(Config) ->","path":"test/telemetry_SUITE.erl","position":36,"original_position":36,"commit_id":"18b1431e2897fe953b1801d08b743fb020d7de00","original_commit_id":"97ae9ba5c0815f529a6716789595b182b9eb99ff","user":{"login":"tsloughter","id":36227,"node_id":"MDQ6VXNlcjM2MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/36227?v=4","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"body":"Why a line in export? There is `all()`.","created_at":"2018-12-28T22:57:53Z","updated_at":"2018-12-28T22:57:53Z","html_url":"https://github.com/beam-telemetry/telemetry/pull/28#discussion_r244423362","pull_request_url":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/28","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/comments/244423362"},"html":{"href":"https://github.com/beam-telemetry/telemetry/pull/28#discussion_r244423362"},"pull_request":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/28"}},"in_reply_to_id":244102225},"pull_request":{"url":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/28","id":240785594,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNzg1NTk0","html_url":"https://github.com/beam-telemetry/telemetry/pull/28","diff_url":"https://github.com/beam-telemetry/telemetry/pull/28.diff","patch_url":"https://github.com/beam-telemetry/telemetry/pull/28.patch","issue_url":"https://api.github.com/repos/beam-telemetry/telemetry/issues/28","number":28,"state":"open","locked":false,"title":"conversion to erlang","user":{"login":"tsloughter","id":36227,"node_id":"MDQ6VXNlcjM2MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/36227?v=4","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"body":"There are a couple things I'm unsure about:\r\n\r\n* logging the handler detachment:\r\n * I noticed the current telemetry supports older OTPs, using logger will break that\r\n * I changed the error to an info. Personally I prefer errors to be things I wouldn't mind alerting me, better to leave the choice up to the user if they want this to be an error.\r\n * could change`execute` to return a list of detached handlers, if any.. though that falls apart if I want to know about my detached handler that it attached to events executed by a third party library, damn..\r\n* using `fun m:f/4` instead of `apply(m, f, [...])`. Recent Erlang's support fun's like this in term files, so they can be used in `sys.config`, before that you had to rely on a `{m, f}` tuple in configs.\r\n * it could still support the separate module/function arguments and store as `fun m:f/4` if you'd rather.\r\n* CI is using circle, though I'm not happy with it since I haven't found a good way to do the xref/dialyzer/ct steps in parallel like I usually do, because of needing to run against mulitple versions of Erlang\r\n * can be switched back to travis. I just find circle easier since you can just use a docker image (travis always has old rebar3s) and now with the rebar3-orb even easier.","created_at":"2018-12-24T14:58:47Z","updated_at":"2018-12-28T22:57:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2b83dbb2dbf4b712262c376294bef68662fba6ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/28/commits","review_comments_url":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/28/comments","review_comment_url":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/beam-telemetry/telemetry/issues/28/comments","statuses_url":"https://api.github.com/repos/beam-telemetry/telemetry/statuses/18b1431e2897fe953b1801d08b743fb020d7de00","head":{"label":"tsloughter:erlang","ref":"erlang","sha":"18b1431e2897fe953b1801d08b743fb020d7de00","user":{"login":"tsloughter","id":36227,"node_id":"MDQ6VXNlcjM2MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/36227?v=4","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"repo":{"id":161915894,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE5MTU4OTQ=","name":"telemetry","full_name":"tsloughter/telemetry","private":false,"owner":{"login":"tsloughter","id":36227,"node_id":"MDQ6VXNlcjM2MjI3","avatar_url":"https://avatars2.githubusercontent.com/u/36227?v=4","gravatar_id":"","url":"https://api.github.com/users/tsloughter","html_url":"https://github.com/tsloughter","followers_url":"https://api.github.com/users/tsloughter/followers","following_url":"https://api.github.com/users/tsloughter/following{/other_user}","gists_url":"https://api.github.com/users/tsloughter/gists{/gist_id}","starred_url":"https://api.github.com/users/tsloughter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsloughter/subscriptions","organizations_url":"https://api.github.com/users/tsloughter/orgs","repos_url":"https://api.github.com/users/tsloughter/repos","events_url":"https://api.github.com/users/tsloughter/events{/privacy}","received_events_url":"https://api.github.com/users/tsloughter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tsloughter/telemetry","description":"Dynamic dispatching library for metrics and instrumentations.","fork":true,"url":"https://api.github.com/repos/tsloughter/telemetry","forks_url":"https://api.github.com/repos/tsloughter/telemetry/forks","keys_url":"https://api.github.com/repos/tsloughter/telemetry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsloughter/telemetry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsloughter/telemetry/teams","hooks_url":"https://api.github.com/repos/tsloughter/telemetry/hooks","issue_events_url":"https://api.github.com/repos/tsloughter/telemetry/issues/events{/number}","events_url":"https://api.github.com/repos/tsloughter/telemetry/events","assignees_url":"https://api.github.com/repos/tsloughter/telemetry/assignees{/user}","branches_url":"https://api.github.com/repos/tsloughter/telemetry/branches{/branch}","tags_url":"https://api.github.com/repos/tsloughter/telemetry/tags","blobs_url":"https://api.github.com/repos/tsloughter/telemetry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsloughter/telemetry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsloughter/telemetry/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsloughter/telemetry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsloughter/telemetry/statuses/{sha}","languages_url":"https://api.github.com/repos/tsloughter/telemetry/languages","stargazers_url":"https://api.github.com/repos/tsloughter/telemetry/stargazers","contributors_url":"https://api.github.com/repos/tsloughter/telemetry/contributors","subscribers_url":"https://api.github.com/repos/tsloughter/telemetry/subscribers","subscription_url":"https://api.github.com/repos/tsloughter/telemetry/subscription","commits_url":"https://api.github.com/repos/tsloughter/telemetry/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsloughter/telemetry/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsloughter/telemetry/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsloughter/telemetry/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsloughter/telemetry/contents/{+path}","compare_url":"https://api.github.com/repos/tsloughter/telemetry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsloughter/telemetry/merges","archive_url":"https://api.github.com/repos/tsloughter/telemetry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsloughter/telemetry/downloads","issues_url":"https://api.github.com/repos/tsloughter/telemetry/issues{/number}","pulls_url":"https://api.github.com/repos/tsloughter/telemetry/pulls{/number}","milestones_url":"https://api.github.com/repos/tsloughter/telemetry/milestones{/number}","notifications_url":"https://api.github.com/repos/tsloughter/telemetry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsloughter/telemetry/labels{/name}","releases_url":"https://api.github.com/repos/tsloughter/telemetry/releases{/id}","deployments_url":"https://api.github.com/repos/tsloughter/telemetry/deployments","created_at":"2018-12-15T15:04:39Z","updated_at":"2018-12-15T15:04:41Z","pushed_at":"2018-12-28T22:03:34Z","git_url":"git://github.com/tsloughter/telemetry.git","ssh_url":"[email protected]:tsloughter/telemetry.git","clone_url":"https://github.com/tsloughter/telemetry.git","svn_url":"https://github.com/tsloughter/telemetry","homepage":"https://hexdocs.pm/telemetry","size":114,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"beam-telemetry:master","ref":"master","sha":"63c7221a6c2496a91ec9ad13f8449700951f00d2","user":{"login":"beam-telemetry","id":42248730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjQ4NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/42248730?v=4","gravatar_id":"","url":"https://api.github.com/users/beam-telemetry","html_url":"https://github.com/beam-telemetry","followers_url":"https://api.github.com/users/beam-telemetry/followers","following_url":"https://api.github.com/users/beam-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/beam-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/beam-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beam-telemetry/subscriptions","organizations_url":"https://api.github.com/users/beam-telemetry/orgs","repos_url":"https://api.github.com/users/beam-telemetry/repos","events_url":"https://api.github.com/users/beam-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/beam-telemetry/received_events","type":"Organization","site_admin":false},"repo":{"id":143751561,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM3NTE1NjE=","name":"telemetry","full_name":"beam-telemetry/telemetry","private":false,"owner":{"login":"beam-telemetry","id":42248730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyMjQ4NzMw","avatar_url":"https://avatars2.githubusercontent.com/u/42248730?v=4","gravatar_id":"","url":"https://api.github.com/users/beam-telemetry","html_url":"https://github.com/beam-telemetry","followers_url":"https://api.github.com/users/beam-telemetry/followers","following_url":"https://api.github.com/users/beam-telemetry/following{/other_user}","gists_url":"https://api.github.com/users/beam-telemetry/gists{/gist_id}","starred_url":"https://api.github.com/users/beam-telemetry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beam-telemetry/subscriptions","organizations_url":"https://api.github.com/users/beam-telemetry/orgs","repos_url":"https://api.github.com/users/beam-telemetry/repos","events_url":"https://api.github.com/users/beam-telemetry/events{/privacy}","received_events_url":"https://api.github.com/users/beam-telemetry/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/beam-telemetry/telemetry","description":"Dynamic dispatching library for metrics and instrumentations.","fork":false,"url":"https://api.github.com/repos/beam-telemetry/telemetry","forks_url":"https://api.github.com/repos/beam-telemetry/telemetry/forks","keys_url":"https://api.github.com/repos/beam-telemetry/telemetry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/beam-telemetry/telemetry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/beam-telemetry/telemetry/teams","hooks_url":"https://api.github.com/repos/beam-telemetry/telemetry/hooks","issue_events_url":"https://api.github.com/repos/beam-telemetry/telemetry/issues/events{/number}","events_url":"https://api.github.com/repos/beam-telemetry/telemetry/events","assignees_url":"https://api.github.com/repos/beam-telemetry/telemetry/assignees{/user}","branches_url":"https://api.github.com/repos/beam-telemetry/telemetry/branches{/branch}","tags_url":"https://api.github.com/repos/beam-telemetry/telemetry/tags","blobs_url":"https://api.github.com/repos/beam-telemetry/telemetry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/beam-telemetry/telemetry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/beam-telemetry/telemetry/git/refs{/sha}","trees_url":"https://api.github.com/repos/beam-telemetry/telemetry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/beam-telemetry/telemetry/statuses/{sha}","languages_url":"https://api.github.com/repos/beam-telemetry/telemetry/languages","stargazers_url":"https://api.github.com/repos/beam-telemetry/telemetry/stargazers","contributors_url":"https://api.github.com/repos/beam-telemetry/telemetry/contributors","subscribers_url":"https://api.github.com/repos/beam-telemetry/telemetry/subscribers","subscription_url":"https://api.github.com/repos/beam-telemetry/telemetry/subscription","commits_url":"https://api.github.com/repos/beam-telemetry/telemetry/commits{/sha}","git_commits_url":"https://api.github.com/repos/beam-telemetry/telemetry/git/commits{/sha}","comments_url":"https://api.github.com/repos/beam-telemetry/telemetry/comments{/number}","issue_comment_url":"https://api.github.com/repos/beam-telemetry/telemetry/issues/comments{/number}","contents_url":"https://api.github.com/repos/beam-telemetry/telemetry/contents/{+path}","compare_url":"https://api.github.com/repos/beam-telemetry/telemetry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/beam-telemetry/telemetry/merges","archive_url":"https://api.github.com/repos/beam-telemetry/telemetry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/beam-telemetry/telemetry/downloads","issues_url":"https://api.github.com/repos/beam-telemetry/telemetry/issues{/number}","pulls_url":"https://api.github.com/repos/beam-telemetry/telemetry/pulls{/number}","milestones_url":"https://api.github.com/repos/beam-telemetry/telemetry/milestones{/number}","notifications_url":"https://api.github.com/repos/beam-telemetry/telemetry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/beam-telemetry/telemetry/labels{/name}","releases_url":"https://api.github.com/repos/beam-telemetry/telemetry/releases{/id}","deployments_url":"https://api.github.com/repos/beam-telemetry/telemetry/deployments","created_at":"2018-08-06T15:58:01Z","updated_at":"2018-12-28T20:58:53Z","pushed_at":"2018-12-28T22:03:35Z","git_url":"git://github.com/beam-telemetry/telemetry.git","ssh_url":"[email protected]:beam-telemetry/telemetry.git","clone_url":"https://github.com/beam-telemetry/telemetry.git","svn_url":"https://github.com/beam-telemetry/telemetry","homepage":"https://hexdocs.pm/telemetry","size":97,"stargazers_count":207,"watchers_count":207,"language":"Elixir","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":5,"watchers":207,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/28"},"html":{"href":"https://github.com/beam-telemetry/telemetry/pull/28"},"issue":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/issues/28"},"comments":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/beam-telemetry/telemetry/statuses/18b1431e2897fe953b1801d08b743fb020d7de00"}},"author_association":"NONE"}}

8813805190

{"actor":{"display_login":"tsloughter"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/comments/233043190","pull_request_review_id":174364945,"id":233043190,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzA0MzE5MA==","diff_hunk":"@@ -1,15 +1,77 @@\n 'use strict';\n \n+function sort(friend, anotherFriend) {\n+ if (friend.name < anotherFriend.name) {","path":"lib.js","position":4,"original_position":4,"commit_id":"1240df1a0ace5c85682afa24ff34ddc19d843090","original_commit_id":"1240df1a0ace5c85682afa24ff34ddc19d843090","user":{"login":"nikshel","id":11533472,"node_id":"MDQ6VXNlcjExNTMzNDcy","avatar_url":"https://avatars2.githubusercontent.com/u/11533472?v=4","gravatar_id":"","url":"https://api.github.com/users/nikshel","html_url":"https://github.com/nikshel","followers_url":"https://api.github.com/users/nikshel/followers","following_url":"https://api.github.com/users/nikshel/following{/other_user}","gists_url":"https://api.github.com/users/nikshel/gists{/gist_id}","starred_url":"https://api.github.com/users/nikshel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikshel/subscriptions","organizations_url":"https://api.github.com/users/nikshel/orgs","repos_url":"https://api.github.com/users/nikshel/repos","events_url":"https://api.github.com/users/nikshel/events{/privacy}","received_events_url":"https://api.github.com/users/nikshel/received_events","type":"User","site_admin":false},"body":"Есть, кстати, полезная функция `str1.localeCompare(str2)`","created_at":"2018-11-13T13:48:19Z","updated_at":"2018-11-13T13:59:46Z","html_url":"https://github.com/urfu-2018/javascript-task-5/pull/62#discussion_r233043190","pull_request_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/62","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/comments/233043190"},"html":{"href":"https://github.com/urfu-2018/javascript-task-5/pull/62#discussion_r233043190"},"pull_request":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/62"}}},"pull_request":{"url":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/62","id":230380335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzgwMzM1","html_url":"https://github.com/urfu-2018/javascript-task-5/pull/62","diff_url":"https://github.com/urfu-2018/javascript-task-5/pull/62.diff","patch_url":"https://github.com/urfu-2018/javascript-task-5/pull/62.patch","issue_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/issues/62","number":62,"state":"open","locked":false,"title":"Чикунов Никита","user":{"login":"KoMeDiAnTNDP","id":39746404,"node_id":"MDQ6VXNlcjM5NzQ2NDA0","avatar_url":"https://avatars0.githubusercontent.com/u/39746404?v=4","gravatar_id":"","url":"https://api.github.com/users/KoMeDiAnTNDP","html_url":"https://github.com/KoMeDiAnTNDP","followers_url":"https://api.github.com/users/KoMeDiAnTNDP/followers","following_url":"https://api.github.com/users/KoMeDiAnTNDP/following{/other_user}","gists_url":"https://api.github.com/users/KoMeDiAnTNDP/gists{/gist_id}","starred_url":"https://api.github.com/users/KoMeDiAnTNDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoMeDiAnTNDP/subscriptions","organizations_url":"https://api.github.com/users/KoMeDiAnTNDP/orgs","repos_url":"https://api.github.com/users/KoMeDiAnTNDP/repos","events_url":"https://api.github.com/users/KoMeDiAnTNDP/events{/privacy}","received_events_url":"https://api.github.com/users/KoMeDiAnTNDP/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-13T08:02:23Z","updated_at":"2018-11-13T13:59:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5e1e28c2374d3aa23c3d0414cf28861991cab552","assignee":{"login":"nikshel","id":11533472,"node_id":"MDQ6VXNlcjExNTMzNDcy","avatar_url":"https://avatars2.githubusercontent.com/u/11533472?v=4","gravatar_id":"","url":"https://api.github.com/users/nikshel","html_url":"https://github.com/nikshel","followers_url":"https://api.github.com/users/nikshel/followers","following_url":"https://api.github.com/users/nikshel/following{/other_user}","gists_url":"https://api.github.com/users/nikshel/gists{/gist_id}","starred_url":"https://api.github.com/users/nikshel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikshel/subscriptions","organizations_url":"https://api.github.com/users/nikshel/orgs","repos_url":"https://api.github.com/users/nikshel/repos","events_url":"https://api.github.com/users/nikshel/events{/privacy}","received_events_url":"https://api.github.com/users/nikshel/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikshel","id":11533472,"node_id":"MDQ6VXNlcjExNTMzNDcy","avatar_url":"https://avatars2.githubusercontent.com/u/11533472?v=4","gravatar_id":"","url":"https://api.github.com/users/nikshel","html_url":"https://github.com/nikshel","followers_url":"https://api.github.com/users/nikshel/followers","following_url":"https://api.github.com/users/nikshel/following{/other_user}","gists_url":"https://api.github.com/users/nikshel/gists{/gist_id}","starred_url":"https://api.github.com/users/nikshel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikshel/subscriptions","organizations_url":"https://api.github.com/users/nikshel/orgs","repos_url":"https://api.github.com/users/nikshel/repos","events_url":"https://api.github.com/users/nikshel/events{/privacy}","received_events_url":"https://api.github.com/users/nikshel/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/62/commits","review_comments_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/62/comments","review_comment_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/issues/62/comments","statuses_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/statuses/1240df1a0ace5c85682afa24ff34ddc19d843090","head":{"label":"KoMeDiAnTNDP:master","ref":"master","sha":"1240df1a0ace5c85682afa24ff34ddc19d843090","user":{"login":"KoMeDiAnTNDP","id":39746404,"node_id":"MDQ6VXNlcjM5NzQ2NDA0","avatar_url":"https://avatars0.githubusercontent.com/u/39746404?v=4","gravatar_id":"","url":"https://api.github.com/users/KoMeDiAnTNDP","html_url":"https://github.com/KoMeDiAnTNDP","followers_url":"https://api.github.com/users/KoMeDiAnTNDP/followers","following_url":"https://api.github.com/users/KoMeDiAnTNDP/following{/other_user}","gists_url":"https://api.github.com/users/KoMeDiAnTNDP/gists{/gist_id}","starred_url":"https://api.github.com/users/KoMeDiAnTNDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoMeDiAnTNDP/subscriptions","organizations_url":"https://api.github.com/users/KoMeDiAnTNDP/orgs","repos_url":"https://api.github.com/users/KoMeDiAnTNDP/repos","events_url":"https://api.github.com/users/KoMeDiAnTNDP/events{/privacy}","received_events_url":"https://api.github.com/users/KoMeDiAnTNDP/received_events","type":"User","site_admin":false},"repo":{"id":157237049,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyMzcwNDk=","name":"javascript-task-5","full_name":"KoMeDiAnTNDP/javascript-task-5","private":false,"owner":{"login":"KoMeDiAnTNDP","id":39746404,"node_id":"MDQ6VXNlcjM5NzQ2NDA0","avatar_url":"https://avatars0.githubusercontent.com/u/39746404?v=4","gravatar_id":"","url":"https://api.github.com/users/KoMeDiAnTNDP","html_url":"https://github.com/KoMeDiAnTNDP","followers_url":"https://api.github.com/users/KoMeDiAnTNDP/followers","following_url":"https://api.github.com/users/KoMeDiAnTNDP/following{/other_user}","gists_url":"https://api.github.com/users/KoMeDiAnTNDP/gists{/gist_id}","starred_url":"https://api.github.com/users/KoMeDiAnTNDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KoMeDiAnTNDP/subscriptions","organizations_url":"https://api.github.com/users/KoMeDiAnTNDP/orgs","repos_url":"https://api.github.com/users/KoMeDiAnTNDP/repos","events_url":"https://api.github.com/users/KoMeDiAnTNDP/events{/privacy}","received_events_url":"https://api.github.com/users/KoMeDiAnTNDP/received_events","type":"User","site_admin":false},"html_url":"https://github.com/KoMeDiAnTNDP/javascript-task-5","description":"Задача «Свадьба Аркадия»","fork":true,"url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5","forks_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/forks","keys_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/teams","hooks_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/hooks","issue_events_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/issues/events{/number}","events_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/events","assignees_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/assignees{/user}","branches_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/branches{/branch}","tags_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/tags","blobs_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/git/refs{/sha}","trees_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/statuses/{sha}","languages_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/languages","stargazers_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/stargazers","contributors_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/contributors","subscribers_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/subscribers","subscription_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/subscription","commits_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/commits{/sha}","git_commits_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/git/commits{/sha}","comments_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/comments{/number}","issue_comment_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/issues/comments{/number}","contents_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/contents/{+path}","compare_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/merges","archive_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/downloads","issues_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/issues{/number}","pulls_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/pulls{/number}","milestones_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/milestones{/number}","notifications_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/labels{/name}","releases_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/releases{/id}","deployments_url":"https://api.github.com/repos/KoMeDiAnTNDP/javascript-task-5/deployments","created_at":"2018-11-12T15:45:39Z","updated_at":"2018-11-13T08:01:29Z","pushed_at":"2018-11-13T08:01:28Z","git_url":"git://github.com/KoMeDiAnTNDP/javascript-task-5.git","ssh_url":"[email protected]:KoMeDiAnTNDP/javascript-task-5.git","clone_url":"https://github.com/KoMeDiAnTNDP/javascript-task-5.git","svn_url":"https://github.com/KoMeDiAnTNDP/javascript-task-5","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urfu-2018:master","ref":"master","sha":"f019605ed9c8280aa69ef0f34adac8db795d3fcd","user":{"login":"urfu-2018","id":43127233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMTI3MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/43127233?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2018","html_url":"https://github.com/urfu-2018","followers_url":"https://api.github.com/users/urfu-2018/followers","following_url":"https://api.github.com/users/urfu-2018/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2018/subscriptions","organizations_url":"https://api.github.com/users/urfu-2018/orgs","repos_url":"https://api.github.com/users/urfu-2018/repos","events_url":"https://api.github.com/users/urfu-2018/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2018/received_events","type":"Organization","site_admin":false},"repo":{"id":156398028,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYzOTgwMjg=","name":"javascript-task-5","full_name":"urfu-2018/javascript-task-5","private":false,"owner":{"login":"urfu-2018","id":43127233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMTI3MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/43127233?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2018","html_url":"https://github.com/urfu-2018","followers_url":"https://api.github.com/users/urfu-2018/followers","following_url":"https://api.github.com/users/urfu-2018/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2018/subscriptions","organizations_url":"https://api.github.com/users/urfu-2018/orgs","repos_url":"https://api.github.com/users/urfu-2018/repos","events_url":"https://api.github.com/users/urfu-2018/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2018/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/urfu-2018/javascript-task-5","description":"Задача «Свадьба Аркадия»","fork":false,"url":"https://api.github.com/repos/urfu-2018/javascript-task-5","forks_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/forks","keys_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/teams","hooks_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/hooks","issue_events_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/issues/events{/number}","events_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/events","assignees_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/assignees{/user}","branches_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/branches{/branch}","tags_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/tags","blobs_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/git/refs{/sha}","trees_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/statuses/{sha}","languages_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/languages","stargazers_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/stargazers","contributors_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/contributors","subscribers_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/subscribers","subscription_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/subscription","commits_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/commits{/sha}","git_commits_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/git/commits{/sha}","comments_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/comments{/number}","issue_comment_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/issues/comments{/number}","contents_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/contents/{+path}","compare_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/merges","archive_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/downloads","issues_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/issues{/number}","pulls_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls{/number}","milestones_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/milestones{/number}","notifications_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/labels{/name}","releases_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/releases{/id}","deployments_url":"https://api.github.com/repos/urfu-2018/javascript-task-5/deployments","created_at":"2018-11-06T14:41:36Z","updated_at":"2018-11-06T15:02:17Z","pushed_at":"2018-11-13T13:10:43Z","git_url":"git://github.com/urfu-2018/javascript-task-5.git","ssh_url":"[email protected]:urfu-2018/javascript-task-5.git","clone_url":"https://github.com/urfu-2018/javascript-task-5.git","svn_url":"https://github.com/urfu-2018/javascript-task-5","homepage":null,"size":15,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":66,"license":null,"forks":94,"open_issues":66,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/62"},"html":{"href":"https://github.com/urfu-2018/javascript-task-5/pull/62"},"issue":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/issues/62"},"comments":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/issues/62/comments"},"review_comments":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/62/comments"},"review_comment":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/pulls/62/commits"},"statuses":{"href":"https://api.github.com/repos/urfu-2018/javascript-task-5/statuses/1240df1a0ace5c85682afa24ff34ddc19d843090"}},"author_association":"NONE"}}

8581143329

{"actor":{"display_login":"nikshel"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/comments/228250267","pull_request_review_id":168452291,"id":228250267,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI1MDI2Nw==","diff_hunk":"@@ -12,7 +12,15 @@ <h1 class=\"global-heading\">&nbsp;</h1>\n \n <main class=\"global-results\">\n <style>\n- /* your styles here */\n+ .global-scope li a[href*='//']:not([href*='my-site.ru'])\n+ {\n+ color: #ff6698;\n+ }\n+\n+ .global-scope li a\n+ {\n+ color: #6698ff;","path":"tasks/8.html","position":12,"original_position":12,"commit_id":"b3f9558506d754455db559c2542ffa0345af6800","original_commit_id":"b3f9558506d754455db559c2542ffa0345af6800","user":{"login":"spt30","id":31798669,"node_id":"MDQ6VXNlcjMxNzk4NjY5","avatar_url":"https://avatars1.githubusercontent.com/u/31798669?v=4","gravatar_id":"","url":"https://api.github.com/users/spt30","html_url":"https://github.com/spt30","followers_url":"https://api.github.com/users/spt30/followers","following_url":"https://api.github.com/users/spt30/following{/other_user}","gists_url":"https://api.github.com/users/spt30/gists{/gist_id}","starred_url":"https://api.github.com/users/spt30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spt30/subscriptions","organizations_url":"https://api.github.com/users/spt30/orgs","repos_url":"https://api.github.com/users/spt30/repos","events_url":"https://api.github.com/users/spt30/events{/privacy}","received_events_url":"https://api.github.com/users/spt30/received_events","type":"User","site_admin":false},"body":"это свойство не нужно было писать, ссылки уже синие и такого цвета, какого надо","created_at":"2018-10-25T16:42:04Z","updated_at":"2018-10-25T16:44:20Z","html_url":"https://github.com/urfu-2018/markup-task-2/pull/14#discussion_r228250267","pull_request_url":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/14","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/comments/228250267"},"html":{"href":"https://github.com/urfu-2018/markup-task-2/pull/14#discussion_r228250267"},"pull_request":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/14","id":222705778,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzA1Nzc4","html_url":"https://github.com/urfu-2018/markup-task-2/pull/14","diff_url":"https://github.com/urfu-2018/markup-task-2/pull/14.diff","patch_url":"https://github.com/urfu-2018/markup-task-2/pull/14.patch","issue_url":"https://api.github.com/repos/urfu-2018/markup-task-2/issues/14","number":14,"state":"open","locked":false,"title":"Ромасс Ольга","user":{"login":"romassol","id":32218560,"node_id":"MDQ6VXNlcjMyMjE4NTYw","avatar_url":"https://avatars0.githubusercontent.com/u/32218560?v=4","gravatar_id":"","url":"https://api.github.com/users/romassol","html_url":"https://github.com/romassol","followers_url":"https://api.github.com/users/romassol/followers","following_url":"https://api.github.com/users/romassol/following{/other_user}","gists_url":"https://api.github.com/users/romassol/gists{/gist_id}","starred_url":"https://api.github.com/users/romassol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romassol/subscriptions","organizations_url":"https://api.github.com/users/romassol/orgs","repos_url":"https://api.github.com/users/romassol/repos","events_url":"https://api.github.com/users/romassol/events{/privacy}","received_events_url":"https://api.github.com/users/romassol/received_events","type":"User","site_admin":false},"body":"[Посмотреть решение](https://hruview.herokuapp.com/romassol/markup-task-2/master/index.html)","created_at":"2018-10-14T10:15:25Z","updated_at":"2018-10-25T16:44:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29c1d0897609274cc7c5e29224ed9d1f0822ff30","assignee":{"login":"spt30","id":31798669,"node_id":"MDQ6VXNlcjMxNzk4NjY5","avatar_url":"https://avatars1.githubusercontent.com/u/31798669?v=4","gravatar_id":"","url":"https://api.github.com/users/spt30","html_url":"https://github.com/spt30","followers_url":"https://api.github.com/users/spt30/followers","following_url":"https://api.github.com/users/spt30/following{/other_user}","gists_url":"https://api.github.com/users/spt30/gists{/gist_id}","starred_url":"https://api.github.com/users/spt30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spt30/subscriptions","organizations_url":"https://api.github.com/users/spt30/orgs","repos_url":"https://api.github.com/users/spt30/repos","events_url":"https://api.github.com/users/spt30/events{/privacy}","received_events_url":"https://api.github.com/users/spt30/received_events","type":"User","site_admin":false},"assignees":[{"login":"spt30","id":31798669,"node_id":"MDQ6VXNlcjMxNzk4NjY5","avatar_url":"https://avatars1.githubusercontent.com/u/31798669?v=4","gravatar_id":"","url":"https://api.github.com/users/spt30","html_url":"https://github.com/spt30","followers_url":"https://api.github.com/users/spt30/followers","following_url":"https://api.github.com/users/spt30/following{/other_user}","gists_url":"https://api.github.com/users/spt30/gists{/gist_id}","starred_url":"https://api.github.com/users/spt30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spt30/subscriptions","organizations_url":"https://api.github.com/users/spt30/orgs","repos_url":"https://api.github.com/users/spt30/repos","events_url":"https://api.github.com/users/spt30/events{/privacy}","received_events_url":"https://api.github.com/users/spt30/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/14/commits","review_comments_url":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/14/comments","review_comment_url":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/urfu-2018/markup-task-2/issues/14/comments","statuses_url":"https://api.github.com/repos/urfu-2018/markup-task-2/statuses/b3f9558506d754455db559c2542ffa0345af6800","head":{"label":"romassol:master","ref":"master","sha":"b3f9558506d754455db559c2542ffa0345af6800","user":{"login":"romassol","id":32218560,"node_id":"MDQ6VXNlcjMyMjE4NTYw","avatar_url":"https://avatars0.githubusercontent.com/u/32218560?v=4","gravatar_id":"","url":"https://api.github.com/users/romassol","html_url":"https://github.com/romassol","followers_url":"https://api.github.com/users/romassol/followers","following_url":"https://api.github.com/users/romassol/following{/other_user}","gists_url":"https://api.github.com/users/romassol/gists{/gist_id}","starred_url":"https://api.github.com/users/romassol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romassol/subscriptions","organizations_url":"https://api.github.com/users/romassol/orgs","repos_url":"https://api.github.com/users/romassol/repos","events_url":"https://api.github.com/users/romassol/events{/privacy}","received_events_url":"https://api.github.com/users/romassol/received_events","type":"User","site_admin":false},"repo":{"id":152941904,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI5NDE5MDQ=","name":"markup-task-2","full_name":"romassol/markup-task-2","private":false,"owner":{"login":"romassol","id":32218560,"node_id":"MDQ6VXNlcjMyMjE4NTYw","avatar_url":"https://avatars0.githubusercontent.com/u/32218560?v=4","gravatar_id":"","url":"https://api.github.com/users/romassol","html_url":"https://github.com/romassol","followers_url":"https://api.github.com/users/romassol/followers","following_url":"https://api.github.com/users/romassol/following{/other_user}","gists_url":"https://api.github.com/users/romassol/gists{/gist_id}","starred_url":"https://api.github.com/users/romassol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romassol/subscriptions","organizations_url":"https://api.github.com/users/romassol/orgs","repos_url":"https://api.github.com/users/romassol/repos","events_url":"https://api.github.com/users/romassol/events{/privacy}","received_events_url":"https://api.github.com/users/romassol/received_events","type":"User","site_admin":false},"html_url":"https://github.com/romassol/markup-task-2","description":"Задача «Ацссорти»","fork":true,"url":"https://api.github.com/repos/romassol/markup-task-2","forks_url":"https://api.github.com/repos/romassol/markup-task-2/forks","keys_url":"https://api.github.com/repos/romassol/markup-task-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/romassol/markup-task-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/romassol/markup-task-2/teams","hooks_url":"https://api.github.com/repos/romassol/markup-task-2/hooks","issue_events_url":"https://api.github.com/repos/romassol/markup-task-2/issues/events{/number}","events_url":"https://api.github.com/repos/romassol/markup-task-2/events","assignees_url":"https://api.github.com/repos/romassol/markup-task-2/assignees{/user}","branches_url":"https://api.github.com/repos/romassol/markup-task-2/branches{/branch}","tags_url":"https://api.github.com/repos/romassol/markup-task-2/tags","blobs_url":"https://api.github.com/repos/romassol/markup-task-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/romassol/markup-task-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/romassol/markup-task-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/romassol/markup-task-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/romassol/markup-task-2/statuses/{sha}","languages_url":"https://api.github.com/repos/romassol/markup-task-2/languages","stargazers_url":"https://api.github.com/repos/romassol/markup-task-2/stargazers","contributors_url":"https://api.github.com/repos/romassol/markup-task-2/contributors","subscribers_url":"https://api.github.com/repos/romassol/markup-task-2/subscribers","subscription_url":"https://api.github.com/repos/romassol/markup-task-2/subscription","commits_url":"https://api.github.com/repos/romassol/markup-task-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/romassol/markup-task-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/romassol/markup-task-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/romassol/markup-task-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/romassol/markup-task-2/contents/{+path}","compare_url":"https://api.github.com/repos/romassol/markup-task-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/romassol/markup-task-2/merges","archive_url":"https://api.github.com/repos/romassol/markup-task-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/romassol/markup-task-2/downloads","issues_url":"https://api.github.com/repos/romassol/markup-task-2/issues{/number}","pulls_url":"https://api.github.com/repos/romassol/markup-task-2/pulls{/number}","milestones_url":"https://api.github.com/repos/romassol/markup-task-2/milestones{/number}","notifications_url":"https://api.github.com/repos/romassol/markup-task-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/romassol/markup-task-2/labels{/name}","releases_url":"https://api.github.com/repos/romassol/markup-task-2/releases{/id}","deployments_url":"https://api.github.com/repos/romassol/markup-task-2/deployments","created_at":"2018-10-14T05:18:30Z","updated_at":"2018-10-14T10:14:18Z","pushed_at":"2018-10-14T10:14:16Z","git_url":"git://github.com/romassol/markup-task-2.git","ssh_url":"[email protected]:romassol/markup-task-2.git","clone_url":"https://github.com/romassol/markup-task-2.git","svn_url":"https://github.com/romassol/markup-task-2","homepage":null,"size":252,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"urfu-2018:master","ref":"master","sha":"2518db463dde02809020ec3ca0d24dcd0ed97411","user":{"login":"urfu-2018","id":43127233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMTI3MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/43127233?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2018","html_url":"https://github.com/urfu-2018","followers_url":"https://api.github.com/users/urfu-2018/followers","following_url":"https://api.github.com/users/urfu-2018/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2018/subscriptions","organizations_url":"https://api.github.com/users/urfu-2018/orgs","repos_url":"https://api.github.com/users/urfu-2018/repos","events_url":"https://api.github.com/users/urfu-2018/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2018/received_events","type":"Organization","site_admin":false},"repo":{"id":152608698,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI2MDg2OTg=","name":"markup-task-2","full_name":"urfu-2018/markup-task-2","private":false,"owner":{"login":"urfu-2018","id":43127233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzMTI3MjMz","avatar_url":"https://avatars0.githubusercontent.com/u/43127233?v=4","gravatar_id":"","url":"https://api.github.com/users/urfu-2018","html_url":"https://github.com/urfu-2018","followers_url":"https://api.github.com/users/urfu-2018/followers","following_url":"https://api.github.com/users/urfu-2018/following{/other_user}","gists_url":"https://api.github.com/users/urfu-2018/gists{/gist_id}","starred_url":"https://api.github.com/users/urfu-2018/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/urfu-2018/subscriptions","organizations_url":"https://api.github.com/users/urfu-2018/orgs","repos_url":"https://api.github.com/users/urfu-2018/repos","events_url":"https://api.github.com/users/urfu-2018/events{/privacy}","received_events_url":"https://api.github.com/users/urfu-2018/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/urfu-2018/markup-task-2","description":"Задача «Ацссорти»","fork":false,"url":"https://api.github.com/repos/urfu-2018/markup-task-2","forks_url":"https://api.github.com/repos/urfu-2018/markup-task-2/forks","keys_url":"https://api.github.com/repos/urfu-2018/markup-task-2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/urfu-2018/markup-task-2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/urfu-2018/markup-task-2/teams","hooks_url":"https://api.github.com/repos/urfu-2018/markup-task-2/hooks","issue_events_url":"https://api.github.com/repos/urfu-2018/markup-task-2/issues/events{/number}","events_url":"https://api.github.com/repos/urfu-2018/markup-task-2/events","assignees_url":"https://api.github.com/repos/urfu-2018/markup-task-2/assignees{/user}","branches_url":"https://api.github.com/repos/urfu-2018/markup-task-2/branches{/branch}","tags_url":"https://api.github.com/repos/urfu-2018/markup-task-2/tags","blobs_url":"https://api.github.com/repos/urfu-2018/markup-task-2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/urfu-2018/markup-task-2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/urfu-2018/markup-task-2/git/refs{/sha}","trees_url":"https://api.github.com/repos/urfu-2018/markup-task-2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/urfu-2018/markup-task-2/statuses/{sha}","languages_url":"https://api.github.com/repos/urfu-2018/markup-task-2/languages","stargazers_url":"https://api.github.com/repos/urfu-2018/markup-task-2/stargazers","contributors_url":"https://api.github.com/repos/urfu-2018/markup-task-2/contributors","subscribers_url":"https://api.github.com/repos/urfu-2018/markup-task-2/subscribers","subscription_url":"https://api.github.com/repos/urfu-2018/markup-task-2/subscription","commits_url":"https://api.github.com/repos/urfu-2018/markup-task-2/commits{/sha}","git_commits_url":"https://api.github.com/repos/urfu-2018/markup-task-2/git/commits{/sha}","comments_url":"https://api.github.com/repos/urfu-2018/markup-task-2/comments{/number}","issue_comment_url":"https://api.github.com/repos/urfu-2018/markup-task-2/issues/comments{/number}","contents_url":"https://api.github.com/repos/urfu-2018/markup-task-2/contents/{+path}","compare_url":"https://api.github.com/repos/urfu-2018/markup-task-2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/urfu-2018/markup-task-2/merges","archive_url":"https://api.github.com/repos/urfu-2018/markup-task-2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/urfu-2018/markup-task-2/downloads","issues_url":"https://api.github.com/repos/urfu-2018/markup-task-2/issues{/number}","pulls_url":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls{/number}","milestones_url":"https://api.github.com/repos/urfu-2018/markup-task-2/milestones{/number}","notifications_url":"https://api.github.com/repos/urfu-2018/markup-task-2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/urfu-2018/markup-task-2/labels{/name}","releases_url":"https://api.github.com/repos/urfu-2018/markup-task-2/releases{/id}","deployments_url":"https://api.github.com/repos/urfu-2018/markup-task-2/deployments","created_at":"2018-10-11T14:50:46Z","updated_at":"2018-10-11T15:09:51Z","pushed_at":"2018-10-25T13:48:34Z","git_url":"git://github.com/urfu-2018/markup-task-2.git","ssh_url":"[email protected]:urfu-2018/markup-task-2.git","clone_url":"https://github.com/urfu-2018/markup-task-2.git","svn_url":"https://github.com/urfu-2018/markup-task-2","homepage":null,"size":239,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":127,"mirror_url":null,"archived":false,"open_issues_count":65,"license":null,"forks":127,"open_issues":65,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/14"},"html":{"href":"https://github.com/urfu-2018/markup-task-2/pull/14"},"issue":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/issues/14"},"comments":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/urfu-2018/markup-task-2/statuses/b3f9558506d754455db559c2542ffa0345af6800"}},"author_association":"NONE"}}

8481820792

{"actor":{"display_login":"spt30"}}

PullRequestReviewCommentEvent

{"action":"created","comment":{"url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/comments/226988393","pull_request_review_id":166927173,"id":226988393,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjk4ODM5Mw==","diff_hunk":"@@ -0,0 +1,98 @@\n+<template>\n+ <div>\n+ <div>\n+ <v-layout row align-center>\n+ <v-flex xs12>\n+ <gmap-autocomplete\n+ @place_changed=\"setPlace\"\n+ id=\"autocomplete\"\n+ ></gmap-autocomplete>\n+ </v-flex>\n+ </v-layout>\n+ </div>\n+ <br>\n+ <gmap-map\n+ :center=\"center\"\n+ :zoom=\"15\"\n+ @click=\"updateMarker\"\n+ id=\"gmap\"\n+ >\n+ <gmap-marker","path":"src/components/GoogleMap.vue","position":20,"original_position":20,"commit_id":"422c2bd27ec15612c6b42c6e84a605bea8b96c5e","original_commit_id":"422c2bd27ec15612c6b42c6e84a605bea8b96c5e","user":{"login":"rartner","id":21064354,"node_id":"MDQ6VXNlcjIxMDY0MzU0","avatar_url":"https://avatars1.githubusercontent.com/u/21064354?v=4","gravatar_id":"","url":"https://api.github.com/users/rartner","html_url":"https://github.com/rartner","followers_url":"https://api.github.com/users/rartner/followers","following_url":"https://api.github.com/users/rartner/following{/other_user}","gists_url":"https://api.github.com/users/rartner/gists{/gist_id}","starred_url":"https://api.github.com/users/rartner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rartner/subscriptions","organizations_url":"https://api.github.com/users/rartner/orgs","repos_url":"https://api.github.com/users/rartner/repos","events_url":"https://api.github.com/users/rartner/events{/privacy}","received_events_url":"https://api.github.com/users/rartner/received_events","type":"User","site_admin":false},"body":"Personalizar marcador","created_at":"2018-10-22T13:31:42Z","updated_at":"2018-10-22T13:31:42Z","html_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets/pull/4#discussion_r226988393","pull_request_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/comments/226988393"},"html":{"href":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets/pull/4#discussion_r226988393"},"pull_request":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/4","id":224646394,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NjQ2Mzk0","html_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets/pull/4","diff_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets/pull/4.diff","patch_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets/pull/4.patch","issue_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues/4","number":4,"state":"open","locked":false,"title":"#1 - Tela de cadastro de pets","user":{"login":"diogoantelo","id":30725441,"node_id":"MDQ6VXNlcjMwNzI1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/30725441?v=4","gravatar_id":"","url":"https://api.github.com/users/diogoantelo","html_url":"https://github.com/diogoantelo","followers_url":"https://api.github.com/users/diogoantelo/followers","following_url":"https://api.github.com/users/diogoantelo/following{/other_user}","gists_url":"https://api.github.com/users/diogoantelo/gists{/gist_id}","starred_url":"https://api.github.com/users/diogoantelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogoantelo/subscriptions","organizations_url":"https://api.github.com/users/diogoantelo/orgs","repos_url":"https://api.github.com/users/diogoantelo/repos","events_url":"https://api.github.com/users/diogoantelo/events{/privacy}","received_events_url":"https://api.github.com/users/diogoantelo/received_events","type":"User","site_admin":false},"body":"- Criação da estrutura básica da aplicação.\r\n- Desenvolvimento da tela de cadastro dos pets com api de mapa e envio de fotos. (#1)","created_at":"2018-10-22T11:00:02Z","updated_at":"2018-10-22T13:31:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"030d9c97264df352ff0866fc32608c3eeda2345b","assignee":{"login":"diogoantelo","id":30725441,"node_id":"MDQ6VXNlcjMwNzI1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/30725441?v=4","gravatar_id":"","url":"https://api.github.com/users/diogoantelo","html_url":"https://github.com/diogoantelo","followers_url":"https://api.github.com/users/diogoantelo/followers","following_url":"https://api.github.com/users/diogoantelo/following{/other_user}","gists_url":"https://api.github.com/users/diogoantelo/gists{/gist_id}","starred_url":"https://api.github.com/users/diogoantelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogoantelo/subscriptions","organizations_url":"https://api.github.com/users/diogoantelo/orgs","repos_url":"https://api.github.com/users/diogoantelo/repos","events_url":"https://api.github.com/users/diogoantelo/events{/privacy}","received_events_url":"https://api.github.com/users/diogoantelo/received_events","type":"User","site_admin":false},"assignees":[{"login":"diogoantelo","id":30725441,"node_id":"MDQ6VXNlcjMwNzI1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/30725441?v=4","gravatar_id":"","url":"https://api.github.com/users/diogoantelo","html_url":"https://github.com/diogoantelo","followers_url":"https://api.github.com/users/diogoantelo/followers","following_url":"https://api.github.com/users/diogoantelo/following{/other_user}","gists_url":"https://api.github.com/users/diogoantelo/gists{/gist_id}","starred_url":"https://api.github.com/users/diogoantelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogoantelo/subscriptions","organizations_url":"https://api.github.com/users/diogoantelo/orgs","repos_url":"https://api.github.com/users/diogoantelo/repos","events_url":"https://api.github.com/users/diogoantelo/events{/privacy}","received_events_url":"https://api.github.com/users/diogoantelo/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Botuca","id":26383069,"node_id":"MDQ6VXNlcjI2MzgzMDY5","avatar_url":"https://avatars0.githubusercontent.com/u/26383069?v=4","gravatar_id":"","url":"https://api.github.com/users/Botuca","html_url":"https://github.com/Botuca","followers_url":"https://api.github.com/users/Botuca/followers","following_url":"https://api.github.com/users/Botuca/following{/other_user}","gists_url":"https://api.github.com/users/Botuca/gists{/gist_id}","starred_url":"https://api.github.com/users/Botuca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Botuca/subscriptions","organizations_url":"https://api.github.com/users/Botuca/orgs","repos_url":"https://api.github.com/users/Botuca/repos","events_url":"https://api.github.com/users/Botuca/events{/privacy}","received_events_url":"https://api.github.com/users/Botuca/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1098056622,"node_id":"MDU6TGFiZWwxMDk4MDU2NjIy","url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":{"url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/milestones/1","html_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets/milestone/1","labels_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/milestones/1/labels","id":3754712,"node_id":"MDk6TWlsZXN0b25lMzc1NDcxMg==","number":1,"title":"sprint-1","description":"","creator":{"login":"diogoantelo","id":30725441,"node_id":"MDQ6VXNlcjMwNzI1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/30725441?v=4","gravatar_id":"","url":"https://api.github.com/users/diogoantelo","html_url":"https://github.com/diogoantelo","followers_url":"https://api.github.com/users/diogoantelo/followers","following_url":"https://api.github.com/users/diogoantelo/following{/other_user}","gists_url":"https://api.github.com/users/diogoantelo/gists{/gist_id}","starred_url":"https://api.github.com/users/diogoantelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diogoantelo/subscriptions","organizations_url":"https://api.github.com/users/diogoantelo/orgs","repos_url":"https://api.github.com/users/diogoantelo/repos","events_url":"https://api.github.com/users/diogoantelo/events{/privacy}","received_events_url":"https://api.github.com/users/diogoantelo/received_events","type":"User","site_admin":false},"open_issues":2,"closed_issues":0,"state":"open","created_at":"2018-10-21T16:45:28Z","updated_at":"2018-10-22T11:00:05Z","due_on":"2018-10-27T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/4/commits","review_comments_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/4/comments","review_comment_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/comments{/number}","comments_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues/4/comments","statuses_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/statuses/422c2bd27ec15612c6b42c6e84a605bea8b96c5e","head":{"label":"academiadev-joinville:feature/01","ref":"feature/01","sha":"422c2bd27ec15612c6b42c6e84a605bea8b96c5e","user":{"login":"academiadev-joinville","id":43502360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTAyMzYw","avatar_url":"https://avatars3.githubusercontent.com/u/43502360?v=4","gravatar_id":"","url":"https://api.github.com/users/academiadev-joinville","html_url":"https://github.com/academiadev-joinville","followers_url":"https://api.github.com/users/academiadev-joinville/followers","following_url":"https://api.github.com/users/academiadev-joinville/following{/other_user}","gists_url":"https://api.github.com/users/academiadev-joinville/gists{/gist_id}","starred_url":"https://api.github.com/users/academiadev-joinville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/academiadev-joinville/subscriptions","organizations_url":"https://api.github.com/users/academiadev-joinville/orgs","repos_url":"https://api.github.com/users/academiadev-joinville/repos","events_url":"https://api.github.com/users/academiadev-joinville/events{/privacy}","received_events_url":"https://api.github.com/users/academiadev-joinville/received_events","type":"Organization","site_admin":false},"repo":{"id":153903490,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5MDM0OTA=","name":"projeto-frontend-thunderpets","full_name":"academiadev-joinville/projeto-frontend-thunderpets","private":false,"owner":{"login":"academiadev-joinville","id":43502360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTAyMzYw","avatar_url":"https://avatars3.githubusercontent.com/u/43502360?v=4","gravatar_id":"","url":"https://api.github.com/users/academiadev-joinville","html_url":"https://github.com/academiadev-joinville","followers_url":"https://api.github.com/users/academiadev-joinville/followers","following_url":"https://api.github.com/users/academiadev-joinville/following{/other_user}","gists_url":"https://api.github.com/users/academiadev-joinville/gists{/gist_id}","starred_url":"https://api.github.com/users/academiadev-joinville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/academiadev-joinville/subscriptions","organizations_url":"https://api.github.com/users/academiadev-joinville/orgs","repos_url":"https://api.github.com/users/academiadev-joinville/repos","events_url":"https://api.github.com/users/academiadev-joinville/events{/privacy}","received_events_url":"https://api.github.com/users/academiadev-joinville/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets","description":"projeto-frontend-thunderpets created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets","forks_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/forks","keys_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/teams","hooks_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/hooks","issue_events_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues/events{/number}","events_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/events","assignees_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/assignees{/user}","branches_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/branches{/branch}","tags_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/tags","blobs_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/refs{/sha}","trees_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/statuses/{sha}","languages_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/languages","stargazers_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/stargazers","contributors_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/contributors","subscribers_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/subscribers","subscription_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/subscription","commits_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/commits{/sha}","git_commits_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/commits{/sha}","comments_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/comments{/number}","issue_comment_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues/comments{/number}","contents_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/contents/{+path}","compare_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/merges","archive_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/downloads","issues_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues{/number}","pulls_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls{/number}","milestones_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/milestones{/number}","notifications_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/labels{/name}","releases_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/releases{/id}","deployments_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/deployments","created_at":"2018-10-20T12:30:36Z","updated_at":"2018-10-20T13:57:41Z","pushed_at":"2018-10-22T11:00:06Z","git_url":"git://github.com/academiadev-joinville/projeto-frontend-thunderpets.git","ssh_url":"[email protected]:academiadev-joinville/projeto-frontend-thunderpets.git","clone_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets.git","svn_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets","homepage":null,"size":369,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"base":{"label":"academiadev-joinville:master","ref":"master","sha":"3aca6e1cc14a777552480421e0593994a3355a22","user":{"login":"academiadev-joinville","id":43502360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTAyMzYw","avatar_url":"https://avatars3.githubusercontent.com/u/43502360?v=4","gravatar_id":"","url":"https://api.github.com/users/academiadev-joinville","html_url":"https://github.com/academiadev-joinville","followers_url":"https://api.github.com/users/academiadev-joinville/followers","following_url":"https://api.github.com/users/academiadev-joinville/following{/other_user}","gists_url":"https://api.github.com/users/academiadev-joinville/gists{/gist_id}","starred_url":"https://api.github.com/users/academiadev-joinville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/academiadev-joinville/subscriptions","organizations_url":"https://api.github.com/users/academiadev-joinville/orgs","repos_url":"https://api.github.com/users/academiadev-joinville/repos","events_url":"https://api.github.com/users/academiadev-joinville/events{/privacy}","received_events_url":"https://api.github.com/users/academiadev-joinville/received_events","type":"Organization","site_admin":false},"repo":{"id":153903490,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM5MDM0OTA=","name":"projeto-frontend-thunderpets","full_name":"academiadev-joinville/projeto-frontend-thunderpets","private":false,"owner":{"login":"academiadev-joinville","id":43502360,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNTAyMzYw","avatar_url":"https://avatars3.githubusercontent.com/u/43502360?v=4","gravatar_id":"","url":"https://api.github.com/users/academiadev-joinville","html_url":"https://github.com/academiadev-joinville","followers_url":"https://api.github.com/users/academiadev-joinville/followers","following_url":"https://api.github.com/users/academiadev-joinville/following{/other_user}","gists_url":"https://api.github.com/users/academiadev-joinville/gists{/gist_id}","starred_url":"https://api.github.com/users/academiadev-joinville/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/academiadev-joinville/subscriptions","organizations_url":"https://api.github.com/users/academiadev-joinville/orgs","repos_url":"https://api.github.com/users/academiadev-joinville/repos","events_url":"https://api.github.com/users/academiadev-joinville/events{/privacy}","received_events_url":"https://api.github.com/users/academiadev-joinville/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets","description":"projeto-frontend-thunderpets created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets","forks_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/forks","keys_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/keys{/key_id}","collaborators_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/teams","hooks_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/hooks","issue_events_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues/events{/number}","events_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/events","assignees_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/assignees{/user}","branches_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/branches{/branch}","tags_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/tags","blobs_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/refs{/sha}","trees_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/trees{/sha}","statuses_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/statuses/{sha}","languages_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/languages","stargazers_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/stargazers","contributors_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/contributors","subscribers_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/subscribers","subscription_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/subscription","commits_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/commits{/sha}","git_commits_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/git/commits{/sha}","comments_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/comments{/number}","issue_comment_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues/comments{/number}","contents_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/contents/{+path}","compare_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/compare/{base}...{head}","merges_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/merges","archive_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/downloads","issues_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues{/number}","pulls_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls{/number}","milestones_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/milestones{/number}","notifications_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/labels{/name}","releases_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/releases{/id}","deployments_url":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/deployments","created_at":"2018-10-20T12:30:36Z","updated_at":"2018-10-20T13:57:41Z","pushed_at":"2018-10-22T11:00:06Z","git_url":"git://github.com/academiadev-joinville/projeto-frontend-thunderpets.git","ssh_url":"[email protected]:academiadev-joinville/projeto-frontend-thunderpets.git","clone_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets.git","svn_url":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets","homepage":null,"size":369,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":0,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/4"},"html":{"href":"https://github.com/academiadev-joinville/projeto-frontend-thunderpets/pull/4"},"issue":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues/4"},"comments":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/academiadev-joinville/projeto-frontend-thunderpets/statuses/422c2bd27ec15612c6b42c6e84a605bea8b96c5e"}},"author_association":"NONE"}}

8458590650

{"actor":{"display_login":"rartner"}}